ifcol.cocci 1.2 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849
  1. /// Find confusingly indented code in or after an if. An if branch should
  2. /// be indented. The code following an if should not be indented.
  3. /// Sometimes, code after an if that is indented is actually intended to be
  4. /// part of the if branch.
  5. ///
  6. /// This has a high rate of false positives, because Coccinelle's column
  7. /// calculation does not distinguish between spaces and tabs, so code that
  8. /// is not visually aligned may be considered to be in the same column.
  9. ///
  10. // Confidence: Low
  11. // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2.
  12. // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2.
  13. // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2.
  14. // URL: http://coccinelle.lip6.fr/
  15. // Comments:
  16. // Options: -no_includes -include_headers
  17. virtual org
  18. virtual report
  19. @r disable braces4@
  20. position p1,p2;
  21. statement S1,S2;
  22. @@
  23. (
  24. if (...) { ... }
  25. |
  26. if (...) S1@p1 S2@p2
  27. )
  28. @script:python depends on org@
  29. p1 << r.p1;
  30. p2 << r.p2;
  31. @@
  32. if (p1[0].column == p2[0].column):
  33. cocci.print_main("branch",p1)
  34. cocci.print_secs("after",p2)
  35. @script:python depends on report@
  36. p1 << r.p1;
  37. p2 << r.p2;
  38. @@
  39. if (p1[0].column == p2[0].column):
  40. msg = "code aligned with following code on line %s" % (p2[0].line)
  41. coccilib.report.print_report(p1[0],msg)