ide-acpi.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611
  1. /*
  2. * Provides ACPI support for IDE drives.
  3. *
  4. * Copyright (C) 2005 Intel Corp.
  5. * Copyright (C) 2005 Randy Dunlap
  6. * Copyright (C) 2006 SUSE Linux Products GmbH
  7. * Copyright (C) 2006 Hannes Reinecke
  8. */
  9. #include <linux/ata.h>
  10. #include <linux/delay.h>
  11. #include <linux/device.h>
  12. #include <linux/errno.h>
  13. #include <linux/kernel.h>
  14. #include <linux/slab.h>
  15. #include <acpi/acpi.h>
  16. #include <linux/ide.h>
  17. #include <linux/pci.h>
  18. #include <linux/dmi.h>
  19. #include <acpi/acpi_bus.h>
  20. #define REGS_PER_GTF 7
  21. struct GTM_buffer {
  22. u32 PIO_speed0;
  23. u32 DMA_speed0;
  24. u32 PIO_speed1;
  25. u32 DMA_speed1;
  26. u32 GTM_flags;
  27. };
  28. struct ide_acpi_drive_link {
  29. acpi_handle obj_handle;
  30. u8 idbuff[512];
  31. };
  32. struct ide_acpi_hwif_link {
  33. ide_hwif_t *hwif;
  34. acpi_handle obj_handle;
  35. struct GTM_buffer gtm;
  36. struct ide_acpi_drive_link master;
  37. struct ide_acpi_drive_link slave;
  38. };
  39. #undef DEBUGGING
  40. /* note: adds function name and KERN_DEBUG */
  41. #ifdef DEBUGGING
  42. #define DEBPRINT(fmt, args...) \
  43. printk(KERN_DEBUG "%s: " fmt, __func__, ## args)
  44. #else
  45. #define DEBPRINT(fmt, args...) do {} while (0)
  46. #endif /* DEBUGGING */
  47. static int ide_noacpi;
  48. module_param_named(noacpi, ide_noacpi, bool, 0);
  49. MODULE_PARM_DESC(noacpi, "disable IDE ACPI support");
  50. static int ide_acpigtf;
  51. module_param_named(acpigtf, ide_acpigtf, bool, 0);
  52. MODULE_PARM_DESC(acpigtf, "enable IDE ACPI _GTF support");
  53. static int ide_acpionboot;
  54. module_param_named(acpionboot, ide_acpionboot, bool, 0);
  55. MODULE_PARM_DESC(acpionboot, "call IDE ACPI methods on boot");
  56. static bool ide_noacpi_psx;
  57. static int no_acpi_psx(const struct dmi_system_id *id)
  58. {
  59. ide_noacpi_psx = true;
  60. printk(KERN_NOTICE"%s detected - disable ACPI _PSx.\n", id->ident);
  61. return 0;
  62. }
  63. static const struct dmi_system_id ide_acpi_dmi_table[] = {
  64. /* Bug 9673. */
  65. /* We should check if this is because ACPI NVS isn't save/restored. */
  66. {
  67. .callback = no_acpi_psx,
  68. .ident = "HP nx9005",
  69. .matches = {
  70. DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies Ltd."),
  71. DMI_MATCH(DMI_BIOS_VERSION, "KAM1.60")
  72. },
  73. },
  74. { } /* terminate list */
  75. };
  76. int ide_acpi_init(void)
  77. {
  78. dmi_check_system(ide_acpi_dmi_table);
  79. return 0;
  80. }
  81. bool ide_port_acpi(ide_hwif_t *hwif)
  82. {
  83. return ide_noacpi == 0 && hwif->acpidata;
  84. }
  85. /**
  86. * ide_get_dev_handle - finds acpi_handle and PCI device.function
  87. * @dev: device to locate
  88. * @handle: returned acpi_handle for @dev
  89. * @pcidevfn: return PCI device.func for @dev
  90. *
  91. * Returns the ACPI object handle to the corresponding PCI device.
  92. *
  93. * Returns 0 on success, <0 on error.
  94. */
  95. static int ide_get_dev_handle(struct device *dev, acpi_handle *handle,
  96. u64 *pcidevfn)
  97. {
  98. struct pci_dev *pdev = to_pci_dev(dev);
  99. unsigned int bus, devnum, func;
  100. u64 addr;
  101. acpi_handle dev_handle;
  102. acpi_status status;
  103. struct acpi_device_info *dinfo = NULL;
  104. int ret = -ENODEV;
  105. bus = pdev->bus->number;
  106. devnum = PCI_SLOT(pdev->devfn);
  107. func = PCI_FUNC(pdev->devfn);
  108. /* ACPI _ADR encoding for PCI bus: */
  109. addr = (u64)(devnum << 16 | func);
  110. DEBPRINT("ENTER: pci %02x:%02x.%01x\n", bus, devnum, func);
  111. dev_handle = DEVICE_ACPI_HANDLE(dev);
  112. if (!dev_handle) {
  113. DEBPRINT("no acpi handle for device\n");
  114. goto err;
  115. }
  116. status = acpi_get_object_info(dev_handle, &dinfo);
  117. if (ACPI_FAILURE(status)) {
  118. DEBPRINT("get_object_info for device failed\n");
  119. goto err;
  120. }
  121. if (dinfo && (dinfo->valid & ACPI_VALID_ADR) &&
  122. dinfo->address == addr) {
  123. *pcidevfn = addr;
  124. *handle = dev_handle;
  125. } else {
  126. DEBPRINT("get_object_info for device has wrong "
  127. " address: %llu, should be %u\n",
  128. dinfo ? (unsigned long long)dinfo->address : -1ULL,
  129. (unsigned int)addr);
  130. goto err;
  131. }
  132. DEBPRINT("for dev=0x%x.%x, addr=0x%llx, *handle=0x%p\n",
  133. devnum, func, (unsigned long long)addr, *handle);
  134. ret = 0;
  135. err:
  136. kfree(dinfo);
  137. return ret;
  138. }
  139. /**
  140. * ide_acpi_hwif_get_handle - Get ACPI object handle for a given hwif
  141. * @hwif: device to locate
  142. *
  143. * Retrieves the object handle for a given hwif.
  144. *
  145. * Returns handle on success, 0 on error.
  146. */
  147. static acpi_handle ide_acpi_hwif_get_handle(ide_hwif_t *hwif)
  148. {
  149. struct device *dev = hwif->gendev.parent;
  150. acpi_handle uninitialized_var(dev_handle);
  151. u64 pcidevfn;
  152. acpi_handle chan_handle;
  153. int err;
  154. DEBPRINT("ENTER: device %s\n", hwif->name);
  155. if (!dev) {
  156. DEBPRINT("no PCI device for %s\n", hwif->name);
  157. return NULL;
  158. }
  159. err = ide_get_dev_handle(dev, &dev_handle, &pcidevfn);
  160. if (err < 0) {
  161. DEBPRINT("ide_get_dev_handle failed (%d)\n", err);
  162. return NULL;
  163. }
  164. /* get child objects of dev_handle == channel objects,
  165. * + _their_ children == drive objects */
  166. /* channel is hwif->channel */
  167. chan_handle = acpi_get_child(dev_handle, hwif->channel);
  168. DEBPRINT("chan adr=%d: handle=0x%p\n",
  169. hwif->channel, chan_handle);
  170. return chan_handle;
  171. }
  172. /**
  173. * do_drive_get_GTF - get the drive bootup default taskfile settings
  174. * @drive: the drive for which the taskfile settings should be retrieved
  175. * @gtf_length: number of bytes of _GTF data returned at @gtf_address
  176. * @gtf_address: buffer containing _GTF taskfile arrays
  177. *
  178. * The _GTF method has no input parameters.
  179. * It returns a variable number of register set values (registers
  180. * hex 1F1..1F7, taskfiles).
  181. * The <variable number> is not known in advance, so have ACPI-CA
  182. * allocate the buffer as needed and return it, then free it later.
  183. *
  184. * The returned @gtf_length and @gtf_address are only valid if the
  185. * function return value is 0.
  186. */
  187. static int do_drive_get_GTF(ide_drive_t *drive,
  188. unsigned int *gtf_length, unsigned long *gtf_address,
  189. unsigned long *obj_loc)
  190. {
  191. acpi_status status;
  192. struct acpi_buffer output;
  193. union acpi_object *out_obj;
  194. int err = -ENODEV;
  195. *gtf_length = 0;
  196. *gtf_address = 0UL;
  197. *obj_loc = 0UL;
  198. if (!drive->acpidata->obj_handle) {
  199. DEBPRINT("No ACPI object found for %s\n", drive->name);
  200. goto out;
  201. }
  202. /* Setting up output buffer */
  203. output.length = ACPI_ALLOCATE_BUFFER;
  204. output.pointer = NULL; /* ACPI-CA sets this; save/free it later */
  205. /* _GTF has no input parameters */
  206. err = -EIO;
  207. status = acpi_evaluate_object(drive->acpidata->obj_handle, "_GTF",
  208. NULL, &output);
  209. if (ACPI_FAILURE(status)) {
  210. printk(KERN_DEBUG
  211. "%s: Run _GTF error: status = 0x%x\n",
  212. __func__, status);
  213. goto out;
  214. }
  215. if (!output.length || !output.pointer) {
  216. DEBPRINT("Run _GTF: "
  217. "length or ptr is NULL (0x%llx, 0x%p)\n",
  218. (unsigned long long)output.length,
  219. output.pointer);
  220. goto out;
  221. }
  222. out_obj = output.pointer;
  223. if (out_obj->type != ACPI_TYPE_BUFFER) {
  224. DEBPRINT("Run _GTF: error: "
  225. "expected object type of ACPI_TYPE_BUFFER, "
  226. "got 0x%x\n", out_obj->type);
  227. err = -ENOENT;
  228. kfree(output.pointer);
  229. goto out;
  230. }
  231. if (!out_obj->buffer.length || !out_obj->buffer.pointer ||
  232. out_obj->buffer.length % REGS_PER_GTF) {
  233. printk(KERN_ERR
  234. "%s: unexpected GTF length (%d) or addr (0x%p)\n",
  235. __func__, out_obj->buffer.length,
  236. out_obj->buffer.pointer);
  237. err = -ENOENT;
  238. kfree(output.pointer);
  239. goto out;
  240. }
  241. *gtf_length = out_obj->buffer.length;
  242. *gtf_address = (unsigned long)out_obj->buffer.pointer;
  243. *obj_loc = (unsigned long)out_obj;
  244. DEBPRINT("returning gtf_length=%d, gtf_address=0x%lx, obj_loc=0x%lx\n",
  245. *gtf_length, *gtf_address, *obj_loc);
  246. err = 0;
  247. out:
  248. return err;
  249. }
  250. /**
  251. * do_drive_set_taskfiles - write the drive taskfile settings from _GTF
  252. * @drive: the drive to which the taskfile command should be sent
  253. * @gtf_length: total number of bytes of _GTF taskfiles
  254. * @gtf_address: location of _GTF taskfile arrays
  255. *
  256. * Write {gtf_address, length gtf_length} in groups of
  257. * REGS_PER_GTF bytes.
  258. */
  259. static int do_drive_set_taskfiles(ide_drive_t *drive,
  260. unsigned int gtf_length,
  261. unsigned long gtf_address)
  262. {
  263. int rc = 0, err;
  264. int gtf_count = gtf_length / REGS_PER_GTF;
  265. int ix;
  266. DEBPRINT("total GTF bytes=%u (0x%x), gtf_count=%d, addr=0x%lx\n",
  267. gtf_length, gtf_length, gtf_count, gtf_address);
  268. /* send all taskfile registers (0x1f1-0x1f7) *in*that*order* */
  269. for (ix = 0; ix < gtf_count; ix++) {
  270. u8 *gtf = (u8 *)(gtf_address + ix * REGS_PER_GTF);
  271. struct ide_cmd cmd;
  272. DEBPRINT("(0x1f1-1f7): "
  273. "hex: %02x %02x %02x %02x %02x %02x %02x\n",
  274. gtf[0], gtf[1], gtf[2],
  275. gtf[3], gtf[4], gtf[5], gtf[6]);
  276. if (!ide_acpigtf) {
  277. DEBPRINT("_GTF execution disabled\n");
  278. continue;
  279. }
  280. /* convert GTF to taskfile */
  281. memset(&cmd, 0, sizeof(cmd));
  282. memcpy(&cmd.tf.feature, gtf, REGS_PER_GTF);
  283. cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
  284. cmd.valid.in.tf = IDE_VALID_IN_TF | IDE_VALID_DEVICE;
  285. err = ide_no_data_taskfile(drive, &cmd);
  286. if (err) {
  287. printk(KERN_ERR "%s: ide_no_data_taskfile failed: %u\n",
  288. __func__, err);
  289. rc = err;
  290. }
  291. }
  292. return rc;
  293. }
  294. /**
  295. * ide_acpi_exec_tfs - get then write drive taskfile settings
  296. * @drive: the drive for which the taskfile settings should be
  297. * written.
  298. *
  299. * According to the ACPI spec this should be called after _STM
  300. * has been evaluated for the interface. Some ACPI vendors interpret
  301. * that as a hard requirement and modify the taskfile according
  302. * to the Identify Drive information passed down with _STM.
  303. * So one should really make sure to call this only after _STM has
  304. * been executed.
  305. */
  306. int ide_acpi_exec_tfs(ide_drive_t *drive)
  307. {
  308. int ret;
  309. unsigned int gtf_length;
  310. unsigned long gtf_address;
  311. unsigned long obj_loc;
  312. DEBPRINT("call get_GTF, drive=%s port=%d\n", drive->name, drive->dn);
  313. ret = do_drive_get_GTF(drive, &gtf_length, &gtf_address, &obj_loc);
  314. if (ret < 0) {
  315. DEBPRINT("get_GTF error (%d)\n", ret);
  316. return ret;
  317. }
  318. DEBPRINT("call set_taskfiles, drive=%s\n", drive->name);
  319. ret = do_drive_set_taskfiles(drive, gtf_length, gtf_address);
  320. kfree((void *)obj_loc);
  321. if (ret < 0) {
  322. DEBPRINT("set_taskfiles error (%d)\n", ret);
  323. }
  324. DEBPRINT("ret=%d\n", ret);
  325. return ret;
  326. }
  327. /**
  328. * ide_acpi_get_timing - get the channel (controller) timings
  329. * @hwif: target IDE interface (channel)
  330. *
  331. * This function executes the _GTM ACPI method for the target channel.
  332. *
  333. */
  334. void ide_acpi_get_timing(ide_hwif_t *hwif)
  335. {
  336. acpi_status status;
  337. struct acpi_buffer output;
  338. union acpi_object *out_obj;
  339. /* Setting up output buffer for _GTM */
  340. output.length = ACPI_ALLOCATE_BUFFER;
  341. output.pointer = NULL; /* ACPI-CA sets this; save/free it later */
  342. /* _GTM has no input parameters */
  343. status = acpi_evaluate_object(hwif->acpidata->obj_handle, "_GTM",
  344. NULL, &output);
  345. DEBPRINT("_GTM status: %d, outptr: 0x%p, outlen: 0x%llx\n",
  346. status, output.pointer,
  347. (unsigned long long)output.length);
  348. if (ACPI_FAILURE(status)) {
  349. DEBPRINT("Run _GTM error: status = 0x%x\n", status);
  350. return;
  351. }
  352. if (!output.length || !output.pointer) {
  353. DEBPRINT("Run _GTM: length or ptr is NULL (0x%llx, 0x%p)\n",
  354. (unsigned long long)output.length,
  355. output.pointer);
  356. kfree(output.pointer);
  357. return;
  358. }
  359. out_obj = output.pointer;
  360. if (out_obj->type != ACPI_TYPE_BUFFER) {
  361. DEBPRINT("Run _GTM: error: "
  362. "expected object type of ACPI_TYPE_BUFFER, "
  363. "got 0x%x\n", out_obj->type);
  364. kfree(output.pointer);
  365. return;
  366. }
  367. if (!out_obj->buffer.length || !out_obj->buffer.pointer ||
  368. out_obj->buffer.length != sizeof(struct GTM_buffer)) {
  369. printk(KERN_ERR
  370. "%s: unexpected _GTM length (0x%x)[should be 0x%zx] or "
  371. "addr (0x%p)\n",
  372. __func__, out_obj->buffer.length,
  373. sizeof(struct GTM_buffer), out_obj->buffer.pointer);
  374. kfree(output.pointer);
  375. return;
  376. }
  377. memcpy(&hwif->acpidata->gtm, out_obj->buffer.pointer,
  378. sizeof(struct GTM_buffer));
  379. DEBPRINT("_GTM info: ptr: 0x%p, len: 0x%x, exp.len: 0x%Zx\n",
  380. out_obj->buffer.pointer, out_obj->buffer.length,
  381. sizeof(struct GTM_buffer));
  382. DEBPRINT("_GTM fields: 0x%x, 0x%x, 0x%x, 0x%x, 0x%x\n",
  383. hwif->acpidata->gtm.PIO_speed0,
  384. hwif->acpidata->gtm.DMA_speed0,
  385. hwif->acpidata->gtm.PIO_speed1,
  386. hwif->acpidata->gtm.DMA_speed1,
  387. hwif->acpidata->gtm.GTM_flags);
  388. kfree(output.pointer);
  389. }
  390. /**
  391. * ide_acpi_push_timing - set the channel (controller) timings
  392. * @hwif: target IDE interface (channel)
  393. *
  394. * This function executes the _STM ACPI method for the target channel.
  395. *
  396. * _STM requires Identify Drive data, which has to passed as an argument.
  397. * Unfortunately drive->id is a mangled version which we can't readily
  398. * use; hence we'll get the information afresh.
  399. */
  400. void ide_acpi_push_timing(ide_hwif_t *hwif)
  401. {
  402. acpi_status status;
  403. struct acpi_object_list input;
  404. union acpi_object in_params[3];
  405. struct ide_acpi_drive_link *master = &hwif->acpidata->master;
  406. struct ide_acpi_drive_link *slave = &hwif->acpidata->slave;
  407. /* Give the GTM buffer + drive Identify data to the channel via the
  408. * _STM method: */
  409. /* setup input parameters buffer for _STM */
  410. input.count = 3;
  411. input.pointer = in_params;
  412. in_params[0].type = ACPI_TYPE_BUFFER;
  413. in_params[0].buffer.length = sizeof(struct GTM_buffer);
  414. in_params[0].buffer.pointer = (u8 *)&hwif->acpidata->gtm;
  415. in_params[1].type = ACPI_TYPE_BUFFER;
  416. in_params[1].buffer.length = ATA_ID_WORDS * 2;
  417. in_params[1].buffer.pointer = (u8 *)&master->idbuff;
  418. in_params[2].type = ACPI_TYPE_BUFFER;
  419. in_params[2].buffer.length = ATA_ID_WORDS * 2;
  420. in_params[2].buffer.pointer = (u8 *)&slave->idbuff;
  421. /* Output buffer: _STM has no output */
  422. status = acpi_evaluate_object(hwif->acpidata->obj_handle, "_STM",
  423. &input, NULL);
  424. if (ACPI_FAILURE(status)) {
  425. DEBPRINT("Run _STM error: status = 0x%x\n", status);
  426. }
  427. DEBPRINT("_STM status: %d\n", status);
  428. }
  429. /**
  430. * ide_acpi_set_state - set the channel power state
  431. * @hwif: target IDE interface
  432. * @on: state, on/off
  433. *
  434. * This function executes the _PS0/_PS3 ACPI method to set the power state.
  435. * ACPI spec requires _PS0 when IDE power on and _PS3 when power off
  436. */
  437. void ide_acpi_set_state(ide_hwif_t *hwif, int on)
  438. {
  439. ide_drive_t *drive;
  440. int i;
  441. if (ide_noacpi_psx)
  442. return;
  443. DEBPRINT("ENTER:\n");
  444. /* channel first and then drives for power on and verse versa for power off */
  445. if (on)
  446. acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D0);
  447. ide_port_for_each_present_dev(i, drive, hwif) {
  448. if (drive->acpidata->obj_handle)
  449. acpi_bus_set_power(drive->acpidata->obj_handle,
  450. on ? ACPI_STATE_D0 : ACPI_STATE_D3);
  451. }
  452. if (!on)
  453. acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D3);
  454. }
  455. /**
  456. * ide_acpi_init_port - initialize the ACPI link for an IDE interface
  457. * @hwif: target IDE interface (channel)
  458. *
  459. * The ACPI spec is not quite clear when the drive identify buffer
  460. * should be obtained. Calling IDENTIFY DEVICE during shutdown
  461. * is not the best of ideas as the drive might already being put to
  462. * sleep. And obviously we can't call it during resume.
  463. * So we get the information during startup; but this means that
  464. * any changes during run-time will be lost after resume.
  465. */
  466. void ide_acpi_init_port(ide_hwif_t *hwif)
  467. {
  468. hwif->acpidata = kzalloc(sizeof(struct ide_acpi_hwif_link), GFP_KERNEL);
  469. if (!hwif->acpidata)
  470. return;
  471. hwif->acpidata->obj_handle = ide_acpi_hwif_get_handle(hwif);
  472. if (!hwif->acpidata->obj_handle) {
  473. DEBPRINT("no ACPI object for %s found\n", hwif->name);
  474. kfree(hwif->acpidata);
  475. hwif->acpidata = NULL;
  476. }
  477. }
  478. void ide_acpi_port_init_devices(ide_hwif_t *hwif)
  479. {
  480. ide_drive_t *drive;
  481. int i, err;
  482. if (hwif->acpidata == NULL)
  483. return;
  484. /*
  485. * The ACPI spec mandates that we send information
  486. * for both drives, regardless whether they are connected
  487. * or not.
  488. */
  489. hwif->devices[0]->acpidata = &hwif->acpidata->master;
  490. hwif->devices[1]->acpidata = &hwif->acpidata->slave;
  491. /* get _ADR info for each device */
  492. ide_port_for_each_present_dev(i, drive, hwif) {
  493. acpi_handle dev_handle;
  494. DEBPRINT("ENTER: %s at channel#: %d port#: %d\n",
  495. drive->name, hwif->channel, drive->dn & 1);
  496. /* TBD: could also check ACPI object VALID bits */
  497. dev_handle = acpi_get_child(hwif->acpidata->obj_handle,
  498. drive->dn & 1);
  499. DEBPRINT("drive %s handle 0x%p\n", drive->name, dev_handle);
  500. drive->acpidata->obj_handle = dev_handle;
  501. }
  502. /* send IDENTIFY for each device */
  503. ide_port_for_each_present_dev(i, drive, hwif) {
  504. err = taskfile_lib_get_identify(drive, drive->acpidata->idbuff);
  505. if (err)
  506. DEBPRINT("identify device %s failed (%d)\n",
  507. drive->name, err);
  508. }
  509. if (ide_noacpi || ide_acpionboot == 0) {
  510. DEBPRINT("ACPI methods disabled on boot\n");
  511. return;
  512. }
  513. /* ACPI _PS0 before _STM */
  514. ide_acpi_set_state(hwif, 1);
  515. /*
  516. * ACPI requires us to call _STM on startup
  517. */
  518. ide_acpi_get_timing(hwif);
  519. ide_acpi_push_timing(hwif);
  520. ide_port_for_each_present_dev(i, drive, hwif) {
  521. ide_acpi_exec_tfs(drive);
  522. }
  523. }