intel_dvo.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565
  1. /*
  2. * Copyright 2006 Dave Airlie <airlied@linux.ie>
  3. * Copyright © 2006-2007 Intel Corporation
  4. *
  5. * Permission is hereby granted, free of charge, to any person obtaining a
  6. * copy of this software and associated documentation files (the "Software"),
  7. * to deal in the Software without restriction, including without limitation
  8. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  9. * and/or sell copies of the Software, and to permit persons to whom the
  10. * Software is furnished to do so, subject to the following conditions:
  11. *
  12. * The above copyright notice and this permission notice (including the next
  13. * paragraph) shall be included in all copies or substantial portions of the
  14. * Software.
  15. *
  16. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  19. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21. * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22. * DEALINGS IN THE SOFTWARE.
  23. *
  24. * Authors:
  25. * Eric Anholt <eric@anholt.net>
  26. */
  27. #include <linux/i2c.h>
  28. #include <linux/slab.h>
  29. #include <drm/drmP.h>
  30. #include <drm/drm_atomic_helper.h>
  31. #include <drm/drm_crtc.h>
  32. #include "intel_drv.h"
  33. #include <drm/i915_drm.h>
  34. #include "i915_drv.h"
  35. #include "dvo.h"
  36. #define SIL164_ADDR 0x38
  37. #define CH7xxx_ADDR 0x76
  38. #define TFP410_ADDR 0x38
  39. #define NS2501_ADDR 0x38
  40. static const struct intel_dvo_device intel_dvo_devices[] = {
  41. {
  42. .type = INTEL_DVO_CHIP_TMDS,
  43. .name = "sil164",
  44. .dvo_reg = DVOC,
  45. .dvo_srcdim_reg = DVOC_SRCDIM,
  46. .slave_addr = SIL164_ADDR,
  47. .dev_ops = &sil164_ops,
  48. },
  49. {
  50. .type = INTEL_DVO_CHIP_TMDS,
  51. .name = "ch7xxx",
  52. .dvo_reg = DVOC,
  53. .dvo_srcdim_reg = DVOC_SRCDIM,
  54. .slave_addr = CH7xxx_ADDR,
  55. .dev_ops = &ch7xxx_ops,
  56. },
  57. {
  58. .type = INTEL_DVO_CHIP_TMDS,
  59. .name = "ch7xxx",
  60. .dvo_reg = DVOC,
  61. .dvo_srcdim_reg = DVOC_SRCDIM,
  62. .slave_addr = 0x75, /* For some ch7010 */
  63. .dev_ops = &ch7xxx_ops,
  64. },
  65. {
  66. .type = INTEL_DVO_CHIP_LVDS,
  67. .name = "ivch",
  68. .dvo_reg = DVOA,
  69. .dvo_srcdim_reg = DVOA_SRCDIM,
  70. .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
  71. .dev_ops = &ivch_ops,
  72. },
  73. {
  74. .type = INTEL_DVO_CHIP_TMDS,
  75. .name = "tfp410",
  76. .dvo_reg = DVOC,
  77. .dvo_srcdim_reg = DVOC_SRCDIM,
  78. .slave_addr = TFP410_ADDR,
  79. .dev_ops = &tfp410_ops,
  80. },
  81. {
  82. .type = INTEL_DVO_CHIP_LVDS,
  83. .name = "ch7017",
  84. .dvo_reg = DVOC,
  85. .dvo_srcdim_reg = DVOC_SRCDIM,
  86. .slave_addr = 0x75,
  87. .gpio = GMBUS_PIN_DPB,
  88. .dev_ops = &ch7017_ops,
  89. },
  90. {
  91. .type = INTEL_DVO_CHIP_TMDS,
  92. .name = "ns2501",
  93. .dvo_reg = DVOB,
  94. .dvo_srcdim_reg = DVOB_SRCDIM,
  95. .slave_addr = NS2501_ADDR,
  96. .dev_ops = &ns2501_ops,
  97. }
  98. };
  99. struct intel_dvo {
  100. struct intel_encoder base;
  101. struct intel_dvo_device dev;
  102. struct intel_connector *attached_connector;
  103. bool panel_wants_dither;
  104. };
  105. static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
  106. {
  107. return container_of(encoder, struct intel_dvo, base);
  108. }
  109. static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
  110. {
  111. return enc_to_dvo(intel_attached_encoder(connector));
  112. }
  113. static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
  114. {
  115. struct drm_device *dev = connector->base.dev;
  116. struct drm_i915_private *dev_priv = to_i915(dev);
  117. struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
  118. u32 tmp;
  119. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  120. if (!(tmp & DVO_ENABLE))
  121. return false;
  122. return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
  123. }
  124. static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
  125. enum pipe *pipe)
  126. {
  127. struct drm_device *dev = encoder->base.dev;
  128. struct drm_i915_private *dev_priv = to_i915(dev);
  129. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  130. u32 tmp;
  131. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  132. if (!(tmp & DVO_ENABLE))
  133. return false;
  134. *pipe = PORT_TO_PIPE(tmp);
  135. return true;
  136. }
  137. static void intel_dvo_get_config(struct intel_encoder *encoder,
  138. struct intel_crtc_state *pipe_config)
  139. {
  140. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  141. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  142. u32 tmp, flags = 0;
  143. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  144. if (tmp & DVO_HSYNC_ACTIVE_HIGH)
  145. flags |= DRM_MODE_FLAG_PHSYNC;
  146. else
  147. flags |= DRM_MODE_FLAG_NHSYNC;
  148. if (tmp & DVO_VSYNC_ACTIVE_HIGH)
  149. flags |= DRM_MODE_FLAG_PVSYNC;
  150. else
  151. flags |= DRM_MODE_FLAG_NVSYNC;
  152. pipe_config->base.adjusted_mode.flags |= flags;
  153. pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
  154. }
  155. static void intel_disable_dvo(struct intel_encoder *encoder,
  156. struct intel_crtc_state *old_crtc_state,
  157. struct drm_connector_state *old_conn_state)
  158. {
  159. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  160. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  161. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  162. u32 temp = I915_READ(dvo_reg);
  163. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
  164. I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
  165. I915_READ(dvo_reg);
  166. }
  167. static void intel_enable_dvo(struct intel_encoder *encoder,
  168. struct intel_crtc_state *pipe_config,
  169. struct drm_connector_state *conn_state)
  170. {
  171. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  172. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  173. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  174. u32 temp = I915_READ(dvo_reg);
  175. intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
  176. &pipe_config->base.mode,
  177. &pipe_config->base.adjusted_mode);
  178. I915_WRITE(dvo_reg, temp | DVO_ENABLE);
  179. I915_READ(dvo_reg);
  180. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
  181. }
  182. static enum drm_mode_status
  183. intel_dvo_mode_valid(struct drm_connector *connector,
  184. struct drm_display_mode *mode)
  185. {
  186. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  187. const struct drm_display_mode *fixed_mode =
  188. to_intel_connector(connector)->panel.fixed_mode;
  189. int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
  190. int target_clock = mode->clock;
  191. if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
  192. return MODE_NO_DBLESCAN;
  193. /* XXX: Validate clock range */
  194. if (fixed_mode) {
  195. if (mode->hdisplay > fixed_mode->hdisplay)
  196. return MODE_PANEL;
  197. if (mode->vdisplay > fixed_mode->vdisplay)
  198. return MODE_PANEL;
  199. target_clock = fixed_mode->clock;
  200. }
  201. if (target_clock > max_dotclk)
  202. return MODE_CLOCK_HIGH;
  203. return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
  204. }
  205. static bool intel_dvo_compute_config(struct intel_encoder *encoder,
  206. struct intel_crtc_state *pipe_config,
  207. struct drm_connector_state *conn_state)
  208. {
  209. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  210. const struct drm_display_mode *fixed_mode =
  211. intel_dvo->attached_connector->panel.fixed_mode;
  212. struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  213. /* If we have timings from the BIOS for the panel, put them in
  214. * to the adjusted mode. The CRTC will be set up for this mode,
  215. * with the panel scaling set up to source from the H/VDisplay
  216. * of the original mode.
  217. */
  218. if (fixed_mode)
  219. intel_fixed_panel_mode(fixed_mode, adjusted_mode);
  220. return true;
  221. }
  222. static void intel_dvo_pre_enable(struct intel_encoder *encoder,
  223. struct intel_crtc_state *pipe_config,
  224. struct drm_connector_state *conn_state)
  225. {
  226. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  227. struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
  228. const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  229. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  230. int pipe = crtc->pipe;
  231. u32 dvo_val;
  232. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  233. i915_reg_t dvo_srcdim_reg = intel_dvo->dev.dvo_srcdim_reg;
  234. /* Save the data order, since I don't know what it should be set to. */
  235. dvo_val = I915_READ(dvo_reg) &
  236. (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
  237. dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
  238. DVO_BLANK_ACTIVE_HIGH;
  239. if (pipe == 1)
  240. dvo_val |= DVO_PIPE_B_SELECT;
  241. dvo_val |= DVO_PIPE_STALL;
  242. if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
  243. dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
  244. if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
  245. dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
  246. /*I915_WRITE(DVOB_SRCDIM,
  247. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  248. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
  249. I915_WRITE(dvo_srcdim_reg,
  250. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  251. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
  252. /*I915_WRITE(DVOB, dvo_val);*/
  253. I915_WRITE(dvo_reg, dvo_val);
  254. }
  255. /**
  256. * Detect the output connection on our DVO device.
  257. *
  258. * Unimplemented.
  259. */
  260. static enum drm_connector_status
  261. intel_dvo_detect(struct drm_connector *connector, bool force)
  262. {
  263. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  264. DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
  265. connector->base.id, connector->name);
  266. return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
  267. }
  268. static int intel_dvo_get_modes(struct drm_connector *connector)
  269. {
  270. struct drm_i915_private *dev_priv = to_i915(connector->dev);
  271. const struct drm_display_mode *fixed_mode =
  272. to_intel_connector(connector)->panel.fixed_mode;
  273. /* We should probably have an i2c driver get_modes function for those
  274. * devices which will have a fixed set of modes determined by the chip
  275. * (TV-out, for example), but for now with just TMDS and LVDS,
  276. * that's not the case.
  277. */
  278. intel_ddc_get_modes(connector,
  279. intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
  280. if (!list_empty(&connector->probed_modes))
  281. return 1;
  282. if (fixed_mode) {
  283. struct drm_display_mode *mode;
  284. mode = drm_mode_duplicate(connector->dev, fixed_mode);
  285. if (mode) {
  286. drm_mode_probed_add(connector, mode);
  287. return 1;
  288. }
  289. }
  290. return 0;
  291. }
  292. static void intel_dvo_destroy(struct drm_connector *connector)
  293. {
  294. drm_connector_cleanup(connector);
  295. intel_panel_fini(&to_intel_connector(connector)->panel);
  296. kfree(connector);
  297. }
  298. static const struct drm_connector_funcs intel_dvo_connector_funcs = {
  299. .dpms = drm_atomic_helper_connector_dpms,
  300. .detect = intel_dvo_detect,
  301. .late_register = intel_connector_register,
  302. .early_unregister = intel_connector_unregister,
  303. .destroy = intel_dvo_destroy,
  304. .fill_modes = drm_helper_probe_single_connector_modes,
  305. .atomic_get_property = intel_connector_atomic_get_property,
  306. .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
  307. .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
  308. };
  309. static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
  310. .mode_valid = intel_dvo_mode_valid,
  311. .get_modes = intel_dvo_get_modes,
  312. };
  313. static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
  314. {
  315. struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
  316. if (intel_dvo->dev.dev_ops->destroy)
  317. intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
  318. intel_encoder_destroy(encoder);
  319. }
  320. static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
  321. .destroy = intel_dvo_enc_destroy,
  322. };
  323. /**
  324. * Attempts to get a fixed panel timing for LVDS (currently only the i830).
  325. *
  326. * Other chips with DVO LVDS will need to extend this to deal with the LVDS
  327. * chip being on DVOB/C and having multiple pipes.
  328. */
  329. static struct drm_display_mode *
  330. intel_dvo_get_current_mode(struct drm_connector *connector)
  331. {
  332. struct drm_device *dev = connector->dev;
  333. struct drm_i915_private *dev_priv = to_i915(dev);
  334. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  335. uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
  336. struct drm_display_mode *mode = NULL;
  337. /* If the DVO port is active, that'll be the LVDS, so we can pull out
  338. * its timings to get how the BIOS set up the panel.
  339. */
  340. if (dvo_val & DVO_ENABLE) {
  341. struct drm_crtc *crtc;
  342. int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;
  343. crtc = intel_get_crtc_for_pipe(dev, pipe);
  344. if (crtc) {
  345. mode = intel_crtc_mode_get(dev, crtc);
  346. if (mode) {
  347. mode->type |= DRM_MODE_TYPE_PREFERRED;
  348. if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
  349. mode->flags |= DRM_MODE_FLAG_PHSYNC;
  350. if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
  351. mode->flags |= DRM_MODE_FLAG_PVSYNC;
  352. }
  353. }
  354. }
  355. return mode;
  356. }
  357. static char intel_dvo_port_name(i915_reg_t dvo_reg)
  358. {
  359. if (i915_mmio_reg_equal(dvo_reg, DVOA))
  360. return 'A';
  361. else if (i915_mmio_reg_equal(dvo_reg, DVOB))
  362. return 'B';
  363. else if (i915_mmio_reg_equal(dvo_reg, DVOC))
  364. return 'C';
  365. else
  366. return '?';
  367. }
  368. void intel_dvo_init(struct drm_device *dev)
  369. {
  370. struct drm_i915_private *dev_priv = to_i915(dev);
  371. struct intel_encoder *intel_encoder;
  372. struct intel_dvo *intel_dvo;
  373. struct intel_connector *intel_connector;
  374. int i;
  375. int encoder_type = DRM_MODE_ENCODER_NONE;
  376. intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
  377. if (!intel_dvo)
  378. return;
  379. intel_connector = intel_connector_alloc();
  380. if (!intel_connector) {
  381. kfree(intel_dvo);
  382. return;
  383. }
  384. intel_dvo->attached_connector = intel_connector;
  385. intel_encoder = &intel_dvo->base;
  386. intel_encoder->disable = intel_disable_dvo;
  387. intel_encoder->enable = intel_enable_dvo;
  388. intel_encoder->get_hw_state = intel_dvo_get_hw_state;
  389. intel_encoder->get_config = intel_dvo_get_config;
  390. intel_encoder->compute_config = intel_dvo_compute_config;
  391. intel_encoder->pre_enable = intel_dvo_pre_enable;
  392. intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
  393. /* Now, try to find a controller */
  394. for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
  395. struct drm_connector *connector = &intel_connector->base;
  396. const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
  397. struct i2c_adapter *i2c;
  398. int gpio;
  399. bool dvoinit;
  400. enum pipe pipe;
  401. uint32_t dpll[I915_MAX_PIPES];
  402. /* Allow the I2C driver info to specify the GPIO to be used in
  403. * special cases, but otherwise default to what's defined
  404. * in the spec.
  405. */
  406. if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
  407. gpio = dvo->gpio;
  408. else if (dvo->type == INTEL_DVO_CHIP_LVDS)
  409. gpio = GMBUS_PIN_SSC;
  410. else
  411. gpio = GMBUS_PIN_DPB;
  412. /* Set up the I2C bus necessary for the chip we're probing.
  413. * It appears that everything is on GPIOE except for panels
  414. * on i830 laptops, which are on GPIOB (DVOA).
  415. */
  416. i2c = intel_gmbus_get_adapter(dev_priv, gpio);
  417. intel_dvo->dev = *dvo;
  418. /* GMBUS NAK handling seems to be unstable, hence let the
  419. * transmitter detection run in bit banging mode for now.
  420. */
  421. intel_gmbus_force_bit(i2c, true);
  422. /* ns2501 requires the DVO 2x clock before it will
  423. * respond to i2c accesses, so make sure we have
  424. * have the clock enabled before we attempt to
  425. * initialize the device.
  426. */
  427. for_each_pipe(dev_priv, pipe) {
  428. dpll[pipe] = I915_READ(DPLL(pipe));
  429. I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
  430. }
  431. dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
  432. /* restore the DVO 2x clock state to original */
  433. for_each_pipe(dev_priv, pipe) {
  434. I915_WRITE(DPLL(pipe), dpll[pipe]);
  435. }
  436. intel_gmbus_force_bit(i2c, false);
  437. if (!dvoinit)
  438. continue;
  439. drm_encoder_init(dev, &intel_encoder->base,
  440. &intel_dvo_enc_funcs, encoder_type,
  441. "DVO %c", intel_dvo_port_name(dvo->dvo_reg));
  442. intel_encoder->type = INTEL_OUTPUT_DVO;
  443. intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
  444. switch (dvo->type) {
  445. case INTEL_DVO_CHIP_TMDS:
  446. intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
  447. (1 << INTEL_OUTPUT_DVO);
  448. drm_connector_init(dev, connector,
  449. &intel_dvo_connector_funcs,
  450. DRM_MODE_CONNECTOR_DVII);
  451. encoder_type = DRM_MODE_ENCODER_TMDS;
  452. break;
  453. case INTEL_DVO_CHIP_LVDS:
  454. intel_encoder->cloneable = 0;
  455. drm_connector_init(dev, connector,
  456. &intel_dvo_connector_funcs,
  457. DRM_MODE_CONNECTOR_LVDS);
  458. encoder_type = DRM_MODE_ENCODER_LVDS;
  459. break;
  460. }
  461. drm_connector_helper_add(connector,
  462. &intel_dvo_connector_helper_funcs);
  463. connector->display_info.subpixel_order = SubPixelHorizontalRGB;
  464. connector->interlace_allowed = false;
  465. connector->doublescan_allowed = false;
  466. intel_connector_attach_encoder(intel_connector, intel_encoder);
  467. if (dvo->type == INTEL_DVO_CHIP_LVDS) {
  468. /* For our LVDS chipsets, we should hopefully be able
  469. * to dig the fixed panel mode out of the BIOS data.
  470. * However, it's in a different format from the BIOS
  471. * data on chipsets with integrated LVDS (stored in AIM
  472. * headers, likely), so for now, just get the current
  473. * mode being output through DVO.
  474. */
  475. intel_panel_init(&intel_connector->panel,
  476. intel_dvo_get_current_mode(connector),
  477. NULL);
  478. intel_dvo->panel_wants_dither = true;
  479. }
  480. return;
  481. }
  482. kfree(intel_dvo);
  483. kfree(intel_connector);
  484. }