#1 Fixed error in gif:frame() and updated disposal method description

Originally PR#1 by ReFreezed in GitHub, 2 Jan 2018 11:15 CET

No description provided.

Commits: b6252c21f7 and 983621aa45

Post by pgimeno, 3 Jan 2018 1:43 CET

Good catch about nimages, thanks! As for the comment change, I have to check again but I'd swear I've seen differences between disposal methods 0 and 1 as rendered by browsers, which are the de-facto standard regardless of what the GIF specification says, which I have to say is very unclear on this area and open to interpretation, hence my attempt at clarifying the behaviour.

Post by ReFreezed, 3 Jan 2018 15:04 CET

Yeah, the GIF specification is not super clear about what should happen I guess, but I followed the description here before looking at any specification and my program was rendering some GIF images incorrectly until I changed method 0 to render the same way as method 1.

Specifically, I used a program called ScreenToGif to record some GIF images that used method 0, and I edited some of the animations in Photoshop which exported GIFs using method 1. All images rendered correctly in Firefox and Chrome so it seemed the description here was simply wrong.

Also looking in main.lua in the example program, you've commented out if dispose == 0 then love.graphics.clear() in DoFrame() which tells me the previous contents should indeed not be dismissed. :)

Post by pgimeno, 3 Jan 2018 16:55 CET

Alright then. Thanks for your contribution!

ReFreezed reacted with :+1: emoji

pgimeno merged commit 5099041 into pgimeno:master on 3 Jan 2018 16:55 CET