no-children-prop.js 5.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204
  1. /**
  2. * @fileoverview Tests for no-children-prop
  3. * @author Benjamin Stepp
  4. */
  5. 'use strict';
  6. // -----------------------------------------------------------------------------
  7. // Requirements
  8. // -----------------------------------------------------------------------------
  9. const rule = require('../../../lib/rules/no-children-prop');
  10. const RuleTester = require('eslint').RuleTester;
  11. const parserOptions = {
  12. ecmaVersion: 2018,
  13. sourceType: 'module',
  14. ecmaFeatures: {
  15. jsx: true
  16. }
  17. };
  18. const JSX_ERROR = 'Do not pass children as props. Instead, nest children between the opening and closing tags.';
  19. const CREATE_ELEMENT_ERROR = 'Do not pass children as props. Instead, pass them as additional arguments to React.createElement.';
  20. // -----------------------------------------------------------------------------
  21. // Tests
  22. // -----------------------------------------------------------------------------
  23. const ruleTester = new RuleTester({parserOptions});
  24. ruleTester.run('no-children-prop', rule, {
  25. valid: [
  26. {
  27. code: '<div />;'
  28. },
  29. {
  30. code: '<div></div>;'
  31. },
  32. {
  33. code: 'React.createElement("div", {});'
  34. },
  35. {
  36. code: 'React.createElement("div", undefined);'
  37. },
  38. {
  39. code: '<div className="class-name"></div>;'
  40. },
  41. {
  42. code: 'React.createElement("div", {className: "class-name"});'
  43. },
  44. {
  45. code: '<div>Children</div>;'
  46. },
  47. {
  48. code: 'React.createElement("div", "Children");'
  49. },
  50. {
  51. code: 'React.createElement("div", {}, "Children");'
  52. },
  53. {
  54. code: 'React.createElement("div", undefined, "Children");'
  55. },
  56. {
  57. code: '<div className="class-name">Children</div>;'
  58. },
  59. {
  60. code: 'React.createElement("div", {className: "class-name"}, "Children");'
  61. },
  62. {
  63. code: '<div><div /></div>;'
  64. },
  65. {
  66. code: 'React.createElement("div", React.createElement("div"));'
  67. },
  68. {
  69. code: 'React.createElement("div", {}, React.createElement("div"));'
  70. },
  71. {
  72. code: 'React.createElement("div", undefined, React.createElement("div"));'
  73. },
  74. {
  75. code: '<div><div /><div /></div>;'
  76. },
  77. {
  78. code: 'React.createElement("div", React.createElement("div"), React.createElement("div"));'
  79. },
  80. {
  81. code: 'React.createElement("div", {}, React.createElement("div"), React.createElement("div"));'
  82. },
  83. {
  84. code: 'React.createElement("div", undefined, React.createElement("div"), React.createElement("div"));'
  85. },
  86. {
  87. code: 'React.createElement("div", [React.createElement("div"), React.createElement("div")]);'
  88. },
  89. {
  90. code: 'React.createElement("div", {}, [React.createElement("div"), React.createElement("div")]);'
  91. },
  92. {
  93. code: 'React.createElement("div", undefined, [React.createElement("div"), React.createElement("div")]);'
  94. },
  95. {
  96. code: '<MyComponent />'
  97. },
  98. {
  99. code: 'React.createElement(MyComponent);'
  100. },
  101. {
  102. code: 'React.createElement(MyComponent, {});'
  103. },
  104. {
  105. code: 'React.createElement(MyComponent, undefined);'
  106. },
  107. {
  108. code: '<MyComponent>Children</MyComponent>;'
  109. },
  110. {
  111. code: 'React.createElement(MyComponent, "Children");'
  112. },
  113. {
  114. code: 'React.createElement(MyComponent, {}, "Children");'
  115. },
  116. {
  117. code: 'React.createElement(MyComponent, undefined, "Children");'
  118. },
  119. {
  120. code: '<MyComponent className="class-name"></MyComponent>;'
  121. },
  122. {
  123. code: 'React.createElement(MyComponent, {className: "class-name"});'
  124. },
  125. {
  126. code: '<MyComponent className="class-name">Children</MyComponent>;'
  127. },
  128. {
  129. code: 'React.createElement(MyComponent, {className: "class-name"}, "Children");'
  130. },
  131. {
  132. code: '<MyComponent className="class-name" {...props} />;'
  133. },
  134. {
  135. code: 'React.createElement(MyComponent, {className: "class-name", ...props});'
  136. }
  137. ],
  138. invalid: [
  139. {
  140. code: '<div children="Children" />;',
  141. errors: [{message: JSX_ERROR}]
  142. },
  143. {
  144. code: '<div children={<div />} />;',
  145. errors: [{message: JSX_ERROR}]
  146. },
  147. {
  148. code: '<div children={[<div />, <div />]} />;',
  149. errors: [{message: JSX_ERROR}]
  150. },
  151. {
  152. code: '<div children="Children">Children</div>;',
  153. errors: [{message: JSX_ERROR}]
  154. },
  155. {
  156. code: 'React.createElement("div", {children: "Children"});',
  157. errors: [{message: CREATE_ELEMENT_ERROR}]
  158. },
  159. {
  160. code: 'React.createElement("div", {children: "Children"}, "Children");',
  161. errors: [{message: CREATE_ELEMENT_ERROR}]
  162. },
  163. {
  164. code: 'React.createElement("div", {children: React.createElement("div")});',
  165. errors: [{message: CREATE_ELEMENT_ERROR}]
  166. },
  167. {
  168. code: 'React.createElement("div", {children: [React.createElement("div"), React.createElement("div")]});',
  169. errors: [{message: CREATE_ELEMENT_ERROR}]
  170. },
  171. {
  172. code: '<MyComponent children="Children" />',
  173. errors: [{message: JSX_ERROR}]
  174. },
  175. {
  176. code: 'React.createElement(MyComponent, {children: "Children"});',
  177. errors: [{message: CREATE_ELEMENT_ERROR}]
  178. },
  179. {
  180. code: '<MyComponent className="class-name" children="Children" />;',
  181. errors: [{message: JSX_ERROR}]
  182. },
  183. {
  184. code: 'React.createElement(MyComponent, {children: "Children", className: "class-name"});',
  185. errors: [{message: CREATE_ELEMENT_ERROR}]
  186. },
  187. {
  188. code: '<MyComponent {...props} children="Children" />;',
  189. errors: [{message: JSX_ERROR}]
  190. },
  191. {
  192. code: 'React.createElement(MyComponent, {...props, children: "Children"})',
  193. errors: [{message: CREATE_ELEMENT_ERROR}]
  194. }
  195. ]
  196. });