#50 [feature request] "Downloaded" indicator

开启中
byliz551 年之前创建 · 5 条评论
byliz55 评论于 1 年之前

Background

I'm getting accustomed more and more to FastLBRY. Just need a couple of more things to get me to leave LBRY Desktop.

In the channel page, or anywhere there are thumbnails, add an indicator in thumbnail to show that the video has already been downloaded (or downloading). This is good for rewatching content or just getting a bird's eye view of what I watched/what's available.

Mockups/hints

I'll add a screenshot of how LBRY Desktop does it. It could be something similar or different. I think that the icon should not be clickable on it's own (clicking it should be similar to clicking on thumbnail). For keeping UI clean, there should be no indicator present on other normal/undownloaded thumbnails. Feel free to suggest any ideas if you disagree with LBRY Desktop - on how/which icon should be used, where should it be placed etc.

Summary

  • What: indicator/icon
  • Where: video thumbnails
  • When: when the video is downloaded or downloading (no indicator for others)
  • Why:
    • to make rewatching content easier
    • to get a bird's eye view of what's available
## Background I'm getting accustomed more and more to FastLBRY. Just need a couple of more things to get me to leave LBRY Desktop. In the channel page, or anywhere there are thumbnails, add an indicator in thumbnail to show that the video has already been downloaded (or downloading). This is good for rewatching content or just getting a bird's eye view of what I watched/what's available. ## Mockups/hints I'll add a screenshot of how LBRY Desktop does it. It could be something similar or different. I think that the icon should not be clickable on it's own (clicking it should be similar to clicking on thumbnail). For keeping UI clean, there should be no indicator present on other normal/undownloaded thumbnails. Feel free to suggest any ideas if you disagree with LBRY Desktop - on how/which icon should be used, where should it be placed etc. ## Summary - What: indicator/icon - Where: video thumbnails - When: when the video is downloaded or downloading (no indicator for others) - Why: - to make rewatching content easier - to get a bird's eye view of what's available

It will need a design. What icon to use and so on and so forth.

It will need a design. What icon to use and so on and so forth.
byliz55 评论于 1 年之前
发布者

I looked into Adwaita icon theme and found these:

actions/document-save-symbolic
emblems/emblem-ok-symbolic
places/folder-symbolic
status/folder-visiting-symbolic

Here are some changes I've been working on:

https://notabug.org/byliz55/FastLBRY-GTK/src/thumb-overlay

Attached a screenshot below of current looks.

I'm using folder-symbolic now for a start. I'm also thinking if we should include a reposted indicator while we're at it because now it is just a separate label taking up extra space.

Haven't tested with all kinds of content, but with my one day of use it has done pretty well. I'm not that great with understanding how the colors should be handled (themed or custom). I'm leaning towards custom because thumbnails will not change depending on theme. Any feedback is welcome.

EDIT: Oh! Forgot to mention I added time also.

I looked into Adwaita icon theme and found these: ``` actions/document-save-symbolic emblems/emblem-ok-symbolic places/folder-symbolic status/folder-visiting-symbolic ``` Here are some changes I've been working on: <https://notabug.org/byliz55/FastLBRY-GTK/src/thumb-overlay> Attached a screenshot below of current looks. I'm using `folder-symbolic` now for a start. I'm also thinking if we should include a reposted indicator while we're at it because now it is just a separate label taking up extra space. Haven't tested with all kinds of content, but with my one day of use it has done pretty well. I'm not that great with understanding how the colors should be handled (themed or custom). I'm leaning towards custom because thumbnails will not change depending on theme. Any feedback is welcome. EDIT: Oh! Forgot to mention I added time also.
byliz55 评论于 1 年之前
发布者

I added a re-post indicator in the thumbnail overlay and styled everything to look more nicer. Also I custom made some icons for the indicators.

Current screenshots are below.

Screenshots are of these channels:

lbry://@BestFoodVideos#7
lbry://@blenderdumbass#f
I added a re-post indicator in the thumbnail overlay and styled everything to look more nicer. Also I custom made some icons for the indicators. Current screenshots are below. Screenshots are of these channels: ``` lbry://@BestFoodVideos#7 lbry://@blenderdumbass#f ```
byliz55 评论于 1 年之前
发布者

Although there is an issue with square 200x200 px thumbnails. Not sure how to solve this.

I'll post a PR anyways in case it is okey to merge.

Although there is an issue with square 200x200 px thumbnails. Not sure how to solve this. I'll post a PR anyways in case it is okey to merge.

Merged! But not closing. Something needs to be done with those square thumbs.

Merged! But not closing. Something needs to be done with those square thumbs.
登录 并参与到对话中。
未选择里程碑
未指派成员
2 名参与者
正在加载...
取消
保存
这个人很懒,什么都没留下。