ide-acpi.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612
  1. /*
  2. * Provides ACPI support for IDE drives.
  3. *
  4. * Copyright (C) 2005 Intel Corp.
  5. * Copyright (C) 2005 Randy Dunlap
  6. * Copyright (C) 2006 SUSE Linux Products GmbH
  7. * Copyright (C) 2006 Hannes Reinecke
  8. */
  9. #include <linux/ata.h>
  10. #include <linux/delay.h>
  11. #include <linux/device.h>
  12. #include <linux/errno.h>
  13. #include <linux/kernel.h>
  14. #include <linux/slab.h>
  15. #include <acpi/acpi.h>
  16. #include <linux/ide.h>
  17. #include <linux/pci.h>
  18. #include <linux/dmi.h>
  19. #include <linux/module.h>
  20. #include <acpi/acpi_bus.h>
  21. #define REGS_PER_GTF 7
  22. struct GTM_buffer {
  23. u32 PIO_speed0;
  24. u32 DMA_speed0;
  25. u32 PIO_speed1;
  26. u32 DMA_speed1;
  27. u32 GTM_flags;
  28. };
  29. struct ide_acpi_drive_link {
  30. acpi_handle obj_handle;
  31. u8 idbuff[512];
  32. };
  33. struct ide_acpi_hwif_link {
  34. ide_hwif_t *hwif;
  35. acpi_handle obj_handle;
  36. struct GTM_buffer gtm;
  37. struct ide_acpi_drive_link master;
  38. struct ide_acpi_drive_link slave;
  39. };
  40. #undef DEBUGGING
  41. /* note: adds function name and KERN_DEBUG */
  42. #ifdef DEBUGGING
  43. #define DEBPRINT(fmt, args...) \
  44. printk(KERN_DEBUG "%s: " fmt, __func__, ## args)
  45. #else
  46. #define DEBPRINT(fmt, args...) do {} while (0)
  47. #endif /* DEBUGGING */
  48. static bool ide_noacpi;
  49. module_param_named(noacpi, ide_noacpi, bool, 0);
  50. MODULE_PARM_DESC(noacpi, "disable IDE ACPI support");
  51. static bool ide_acpigtf;
  52. module_param_named(acpigtf, ide_acpigtf, bool, 0);
  53. MODULE_PARM_DESC(acpigtf, "enable IDE ACPI _GTF support");
  54. static bool ide_acpionboot;
  55. module_param_named(acpionboot, ide_acpionboot, bool, 0);
  56. MODULE_PARM_DESC(acpionboot, "call IDE ACPI methods on boot");
  57. static bool ide_noacpi_psx;
  58. static int no_acpi_psx(const struct dmi_system_id *id)
  59. {
  60. ide_noacpi_psx = true;
  61. printk(KERN_NOTICE"%s detected - disable ACPI _PSx.\n", id->ident);
  62. return 0;
  63. }
  64. static const struct dmi_system_id ide_acpi_dmi_table[] = {
  65. /* Bug 9673. */
  66. /* We should check if this is because ACPI NVS isn't save/restored. */
  67. {
  68. .callback = no_acpi_psx,
  69. .ident = "HP nx9005",
  70. .matches = {
  71. DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies Ltd."),
  72. DMI_MATCH(DMI_BIOS_VERSION, "KAM1.60")
  73. },
  74. },
  75. { } /* terminate list */
  76. };
  77. int ide_acpi_init(void)
  78. {
  79. dmi_check_system(ide_acpi_dmi_table);
  80. return 0;
  81. }
  82. bool ide_port_acpi(ide_hwif_t *hwif)
  83. {
  84. return ide_noacpi == 0 && hwif->acpidata;
  85. }
  86. /**
  87. * ide_get_dev_handle - finds acpi_handle and PCI device.function
  88. * @dev: device to locate
  89. * @handle: returned acpi_handle for @dev
  90. * @pcidevfn: return PCI device.func for @dev
  91. *
  92. * Returns the ACPI object handle to the corresponding PCI device.
  93. *
  94. * Returns 0 on success, <0 on error.
  95. */
  96. static int ide_get_dev_handle(struct device *dev, acpi_handle *handle,
  97. u64 *pcidevfn)
  98. {
  99. struct pci_dev *pdev = to_pci_dev(dev);
  100. unsigned int bus, devnum, func;
  101. u64 addr;
  102. acpi_handle dev_handle;
  103. acpi_status status;
  104. struct acpi_device_info *dinfo = NULL;
  105. int ret = -ENODEV;
  106. bus = pdev->bus->number;
  107. devnum = PCI_SLOT(pdev->devfn);
  108. func = PCI_FUNC(pdev->devfn);
  109. /* ACPI _ADR encoding for PCI bus: */
  110. addr = (u64)(devnum << 16 | func);
  111. DEBPRINT("ENTER: pci %02x:%02x.%01x\n", bus, devnum, func);
  112. dev_handle = DEVICE_ACPI_HANDLE(dev);
  113. if (!dev_handle) {
  114. DEBPRINT("no acpi handle for device\n");
  115. goto err;
  116. }
  117. status = acpi_get_object_info(dev_handle, &dinfo);
  118. if (ACPI_FAILURE(status)) {
  119. DEBPRINT("get_object_info for device failed\n");
  120. goto err;
  121. }
  122. if (dinfo && (dinfo->valid & ACPI_VALID_ADR) &&
  123. dinfo->address == addr) {
  124. *pcidevfn = addr;
  125. *handle = dev_handle;
  126. } else {
  127. DEBPRINT("get_object_info for device has wrong "
  128. " address: %llu, should be %u\n",
  129. dinfo ? (unsigned long long)dinfo->address : -1ULL,
  130. (unsigned int)addr);
  131. goto err;
  132. }
  133. DEBPRINT("for dev=0x%x.%x, addr=0x%llx, *handle=0x%p\n",
  134. devnum, func, (unsigned long long)addr, *handle);
  135. ret = 0;
  136. err:
  137. kfree(dinfo);
  138. return ret;
  139. }
  140. /**
  141. * ide_acpi_hwif_get_handle - Get ACPI object handle for a given hwif
  142. * @hwif: device to locate
  143. *
  144. * Retrieves the object handle for a given hwif.
  145. *
  146. * Returns handle on success, 0 on error.
  147. */
  148. static acpi_handle ide_acpi_hwif_get_handle(ide_hwif_t *hwif)
  149. {
  150. struct device *dev = hwif->gendev.parent;
  151. acpi_handle uninitialized_var(dev_handle);
  152. u64 pcidevfn;
  153. acpi_handle chan_handle;
  154. int err;
  155. DEBPRINT("ENTER: device %s\n", hwif->name);
  156. if (!dev) {
  157. DEBPRINT("no PCI device for %s\n", hwif->name);
  158. return NULL;
  159. }
  160. err = ide_get_dev_handle(dev, &dev_handle, &pcidevfn);
  161. if (err < 0) {
  162. DEBPRINT("ide_get_dev_handle failed (%d)\n", err);
  163. return NULL;
  164. }
  165. /* get child objects of dev_handle == channel objects,
  166. * + _their_ children == drive objects */
  167. /* channel is hwif->channel */
  168. chan_handle = acpi_get_child(dev_handle, hwif->channel);
  169. DEBPRINT("chan adr=%d: handle=0x%p\n",
  170. hwif->channel, chan_handle);
  171. return chan_handle;
  172. }
  173. /**
  174. * do_drive_get_GTF - get the drive bootup default taskfile settings
  175. * @drive: the drive for which the taskfile settings should be retrieved
  176. * @gtf_length: number of bytes of _GTF data returned at @gtf_address
  177. * @gtf_address: buffer containing _GTF taskfile arrays
  178. *
  179. * The _GTF method has no input parameters.
  180. * It returns a variable number of register set values (registers
  181. * hex 1F1..1F7, taskfiles).
  182. * The <variable number> is not known in advance, so have ACPI-CA
  183. * allocate the buffer as needed and return it, then free it later.
  184. *
  185. * The returned @gtf_length and @gtf_address are only valid if the
  186. * function return value is 0.
  187. */
  188. static int do_drive_get_GTF(ide_drive_t *drive,
  189. unsigned int *gtf_length, unsigned long *gtf_address,
  190. unsigned long *obj_loc)
  191. {
  192. acpi_status status;
  193. struct acpi_buffer output;
  194. union acpi_object *out_obj;
  195. int err = -ENODEV;
  196. *gtf_length = 0;
  197. *gtf_address = 0UL;
  198. *obj_loc = 0UL;
  199. if (!drive->acpidata->obj_handle) {
  200. DEBPRINT("No ACPI object found for %s\n", drive->name);
  201. goto out;
  202. }
  203. /* Setting up output buffer */
  204. output.length = ACPI_ALLOCATE_BUFFER;
  205. output.pointer = NULL; /* ACPI-CA sets this; save/free it later */
  206. /* _GTF has no input parameters */
  207. err = -EIO;
  208. status = acpi_evaluate_object(drive->acpidata->obj_handle, "_GTF",
  209. NULL, &output);
  210. if (ACPI_FAILURE(status)) {
  211. printk(KERN_DEBUG
  212. "%s: Run _GTF error: status = 0x%x\n",
  213. __func__, status);
  214. goto out;
  215. }
  216. if (!output.length || !output.pointer) {
  217. DEBPRINT("Run _GTF: "
  218. "length or ptr is NULL (0x%llx, 0x%p)\n",
  219. (unsigned long long)output.length,
  220. output.pointer);
  221. goto out;
  222. }
  223. out_obj = output.pointer;
  224. if (out_obj->type != ACPI_TYPE_BUFFER) {
  225. DEBPRINT("Run _GTF: error: "
  226. "expected object type of ACPI_TYPE_BUFFER, "
  227. "got 0x%x\n", out_obj->type);
  228. err = -ENOENT;
  229. kfree(output.pointer);
  230. goto out;
  231. }
  232. if (!out_obj->buffer.length || !out_obj->buffer.pointer ||
  233. out_obj->buffer.length % REGS_PER_GTF) {
  234. printk(KERN_ERR
  235. "%s: unexpected GTF length (%d) or addr (0x%p)\n",
  236. __func__, out_obj->buffer.length,
  237. out_obj->buffer.pointer);
  238. err = -ENOENT;
  239. kfree(output.pointer);
  240. goto out;
  241. }
  242. *gtf_length = out_obj->buffer.length;
  243. *gtf_address = (unsigned long)out_obj->buffer.pointer;
  244. *obj_loc = (unsigned long)out_obj;
  245. DEBPRINT("returning gtf_length=%d, gtf_address=0x%lx, obj_loc=0x%lx\n",
  246. *gtf_length, *gtf_address, *obj_loc);
  247. err = 0;
  248. out:
  249. return err;
  250. }
  251. /**
  252. * do_drive_set_taskfiles - write the drive taskfile settings from _GTF
  253. * @drive: the drive to which the taskfile command should be sent
  254. * @gtf_length: total number of bytes of _GTF taskfiles
  255. * @gtf_address: location of _GTF taskfile arrays
  256. *
  257. * Write {gtf_address, length gtf_length} in groups of
  258. * REGS_PER_GTF bytes.
  259. */
  260. static int do_drive_set_taskfiles(ide_drive_t *drive,
  261. unsigned int gtf_length,
  262. unsigned long gtf_address)
  263. {
  264. int rc = 0, err;
  265. int gtf_count = gtf_length / REGS_PER_GTF;
  266. int ix;
  267. DEBPRINT("total GTF bytes=%u (0x%x), gtf_count=%d, addr=0x%lx\n",
  268. gtf_length, gtf_length, gtf_count, gtf_address);
  269. /* send all taskfile registers (0x1f1-0x1f7) *in*that*order* */
  270. for (ix = 0; ix < gtf_count; ix++) {
  271. u8 *gtf = (u8 *)(gtf_address + ix * REGS_PER_GTF);
  272. struct ide_cmd cmd;
  273. DEBPRINT("(0x1f1-1f7): "
  274. "hex: %02x %02x %02x %02x %02x %02x %02x\n",
  275. gtf[0], gtf[1], gtf[2],
  276. gtf[3], gtf[4], gtf[5], gtf[6]);
  277. if (!ide_acpigtf) {
  278. DEBPRINT("_GTF execution disabled\n");
  279. continue;
  280. }
  281. /* convert GTF to taskfile */
  282. memset(&cmd, 0, sizeof(cmd));
  283. memcpy(&cmd.tf.feature, gtf, REGS_PER_GTF);
  284. cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
  285. cmd.valid.in.tf = IDE_VALID_IN_TF | IDE_VALID_DEVICE;
  286. err = ide_no_data_taskfile(drive, &cmd);
  287. if (err) {
  288. printk(KERN_ERR "%s: ide_no_data_taskfile failed: %u\n",
  289. __func__, err);
  290. rc = err;
  291. }
  292. }
  293. return rc;
  294. }
  295. /**
  296. * ide_acpi_exec_tfs - get then write drive taskfile settings
  297. * @drive: the drive for which the taskfile settings should be
  298. * written.
  299. *
  300. * According to the ACPI spec this should be called after _STM
  301. * has been evaluated for the interface. Some ACPI vendors interpret
  302. * that as a hard requirement and modify the taskfile according
  303. * to the Identify Drive information passed down with _STM.
  304. * So one should really make sure to call this only after _STM has
  305. * been executed.
  306. */
  307. int ide_acpi_exec_tfs(ide_drive_t *drive)
  308. {
  309. int ret;
  310. unsigned int gtf_length;
  311. unsigned long gtf_address;
  312. unsigned long obj_loc;
  313. DEBPRINT("call get_GTF, drive=%s port=%d\n", drive->name, drive->dn);
  314. ret = do_drive_get_GTF(drive, &gtf_length, &gtf_address, &obj_loc);
  315. if (ret < 0) {
  316. DEBPRINT("get_GTF error (%d)\n", ret);
  317. return ret;
  318. }
  319. DEBPRINT("call set_taskfiles, drive=%s\n", drive->name);
  320. ret = do_drive_set_taskfiles(drive, gtf_length, gtf_address);
  321. kfree((void *)obj_loc);
  322. if (ret < 0) {
  323. DEBPRINT("set_taskfiles error (%d)\n", ret);
  324. }
  325. DEBPRINT("ret=%d\n", ret);
  326. return ret;
  327. }
  328. /**
  329. * ide_acpi_get_timing - get the channel (controller) timings
  330. * @hwif: target IDE interface (channel)
  331. *
  332. * This function executes the _GTM ACPI method for the target channel.
  333. *
  334. */
  335. void ide_acpi_get_timing(ide_hwif_t *hwif)
  336. {
  337. acpi_status status;
  338. struct acpi_buffer output;
  339. union acpi_object *out_obj;
  340. /* Setting up output buffer for _GTM */
  341. output.length = ACPI_ALLOCATE_BUFFER;
  342. output.pointer = NULL; /* ACPI-CA sets this; save/free it later */
  343. /* _GTM has no input parameters */
  344. status = acpi_evaluate_object(hwif->acpidata->obj_handle, "_GTM",
  345. NULL, &output);
  346. DEBPRINT("_GTM status: %d, outptr: 0x%p, outlen: 0x%llx\n",
  347. status, output.pointer,
  348. (unsigned long long)output.length);
  349. if (ACPI_FAILURE(status)) {
  350. DEBPRINT("Run _GTM error: status = 0x%x\n", status);
  351. return;
  352. }
  353. if (!output.length || !output.pointer) {
  354. DEBPRINT("Run _GTM: length or ptr is NULL (0x%llx, 0x%p)\n",
  355. (unsigned long long)output.length,
  356. output.pointer);
  357. kfree(output.pointer);
  358. return;
  359. }
  360. out_obj = output.pointer;
  361. if (out_obj->type != ACPI_TYPE_BUFFER) {
  362. DEBPRINT("Run _GTM: error: "
  363. "expected object type of ACPI_TYPE_BUFFER, "
  364. "got 0x%x\n", out_obj->type);
  365. kfree(output.pointer);
  366. return;
  367. }
  368. if (!out_obj->buffer.length || !out_obj->buffer.pointer ||
  369. out_obj->buffer.length != sizeof(struct GTM_buffer)) {
  370. printk(KERN_ERR
  371. "%s: unexpected _GTM length (0x%x)[should be 0x%zx] or "
  372. "addr (0x%p)\n",
  373. __func__, out_obj->buffer.length,
  374. sizeof(struct GTM_buffer), out_obj->buffer.pointer);
  375. kfree(output.pointer);
  376. return;
  377. }
  378. memcpy(&hwif->acpidata->gtm, out_obj->buffer.pointer,
  379. sizeof(struct GTM_buffer));
  380. DEBPRINT("_GTM info: ptr: 0x%p, len: 0x%x, exp.len: 0x%Zx\n",
  381. out_obj->buffer.pointer, out_obj->buffer.length,
  382. sizeof(struct GTM_buffer));
  383. DEBPRINT("_GTM fields: 0x%x, 0x%x, 0x%x, 0x%x, 0x%x\n",
  384. hwif->acpidata->gtm.PIO_speed0,
  385. hwif->acpidata->gtm.DMA_speed0,
  386. hwif->acpidata->gtm.PIO_speed1,
  387. hwif->acpidata->gtm.DMA_speed1,
  388. hwif->acpidata->gtm.GTM_flags);
  389. kfree(output.pointer);
  390. }
  391. /**
  392. * ide_acpi_push_timing - set the channel (controller) timings
  393. * @hwif: target IDE interface (channel)
  394. *
  395. * This function executes the _STM ACPI method for the target channel.
  396. *
  397. * _STM requires Identify Drive data, which has to passed as an argument.
  398. * Unfortunately drive->id is a mangled version which we can't readily
  399. * use; hence we'll get the information afresh.
  400. */
  401. void ide_acpi_push_timing(ide_hwif_t *hwif)
  402. {
  403. acpi_status status;
  404. struct acpi_object_list input;
  405. union acpi_object in_params[3];
  406. struct ide_acpi_drive_link *master = &hwif->acpidata->master;
  407. struct ide_acpi_drive_link *slave = &hwif->acpidata->slave;
  408. /* Give the GTM buffer + drive Identify data to the channel via the
  409. * _STM method: */
  410. /* setup input parameters buffer for _STM */
  411. input.count = 3;
  412. input.pointer = in_params;
  413. in_params[0].type = ACPI_TYPE_BUFFER;
  414. in_params[0].buffer.length = sizeof(struct GTM_buffer);
  415. in_params[0].buffer.pointer = (u8 *)&hwif->acpidata->gtm;
  416. in_params[1].type = ACPI_TYPE_BUFFER;
  417. in_params[1].buffer.length = ATA_ID_WORDS * 2;
  418. in_params[1].buffer.pointer = (u8 *)&master->idbuff;
  419. in_params[2].type = ACPI_TYPE_BUFFER;
  420. in_params[2].buffer.length = ATA_ID_WORDS * 2;
  421. in_params[2].buffer.pointer = (u8 *)&slave->idbuff;
  422. /* Output buffer: _STM has no output */
  423. status = acpi_evaluate_object(hwif->acpidata->obj_handle, "_STM",
  424. &input, NULL);
  425. if (ACPI_FAILURE(status)) {
  426. DEBPRINT("Run _STM error: status = 0x%x\n", status);
  427. }
  428. DEBPRINT("_STM status: %d\n", status);
  429. }
  430. /**
  431. * ide_acpi_set_state - set the channel power state
  432. * @hwif: target IDE interface
  433. * @on: state, on/off
  434. *
  435. * This function executes the _PS0/_PS3 ACPI method to set the power state.
  436. * ACPI spec requires _PS0 when IDE power on and _PS3 when power off
  437. */
  438. void ide_acpi_set_state(ide_hwif_t *hwif, int on)
  439. {
  440. ide_drive_t *drive;
  441. int i;
  442. if (ide_noacpi_psx)
  443. return;
  444. DEBPRINT("ENTER:\n");
  445. /* channel first and then drives for power on and verse versa for power off */
  446. if (on)
  447. acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D0);
  448. ide_port_for_each_present_dev(i, drive, hwif) {
  449. if (drive->acpidata->obj_handle)
  450. acpi_bus_set_power(drive->acpidata->obj_handle,
  451. on ? ACPI_STATE_D0 : ACPI_STATE_D3);
  452. }
  453. if (!on)
  454. acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D3);
  455. }
  456. /**
  457. * ide_acpi_init_port - initialize the ACPI link for an IDE interface
  458. * @hwif: target IDE interface (channel)
  459. *
  460. * The ACPI spec is not quite clear when the drive identify buffer
  461. * should be obtained. Calling IDENTIFY DEVICE during shutdown
  462. * is not the best of ideas as the drive might already being put to
  463. * sleep. And obviously we can't call it during resume.
  464. * So we get the information during startup; but this means that
  465. * any changes during run-time will be lost after resume.
  466. */
  467. void ide_acpi_init_port(ide_hwif_t *hwif)
  468. {
  469. hwif->acpidata = kzalloc(sizeof(struct ide_acpi_hwif_link), GFP_KERNEL);
  470. if (!hwif->acpidata)
  471. return;
  472. hwif->acpidata->obj_handle = ide_acpi_hwif_get_handle(hwif);
  473. if (!hwif->acpidata->obj_handle) {
  474. DEBPRINT("no ACPI object for %s found\n", hwif->name);
  475. kfree(hwif->acpidata);
  476. hwif->acpidata = NULL;
  477. }
  478. }
  479. void ide_acpi_port_init_devices(ide_hwif_t *hwif)
  480. {
  481. ide_drive_t *drive;
  482. int i, err;
  483. if (hwif->acpidata == NULL)
  484. return;
  485. /*
  486. * The ACPI spec mandates that we send information
  487. * for both drives, regardless whether they are connected
  488. * or not.
  489. */
  490. hwif->devices[0]->acpidata = &hwif->acpidata->master;
  491. hwif->devices[1]->acpidata = &hwif->acpidata->slave;
  492. /* get _ADR info for each device */
  493. ide_port_for_each_present_dev(i, drive, hwif) {
  494. acpi_handle dev_handle;
  495. DEBPRINT("ENTER: %s at channel#: %d port#: %d\n",
  496. drive->name, hwif->channel, drive->dn & 1);
  497. /* TBD: could also check ACPI object VALID bits */
  498. dev_handle = acpi_get_child(hwif->acpidata->obj_handle,
  499. drive->dn & 1);
  500. DEBPRINT("drive %s handle 0x%p\n", drive->name, dev_handle);
  501. drive->acpidata->obj_handle = dev_handle;
  502. }
  503. /* send IDENTIFY for each device */
  504. ide_port_for_each_present_dev(i, drive, hwif) {
  505. err = taskfile_lib_get_identify(drive, drive->acpidata->idbuff);
  506. if (err)
  507. DEBPRINT("identify device %s failed (%d)\n",
  508. drive->name, err);
  509. }
  510. if (ide_noacpi || ide_acpionboot == 0) {
  511. DEBPRINT("ACPI methods disabled on boot\n");
  512. return;
  513. }
  514. /* ACPI _PS0 before _STM */
  515. ide_acpi_set_state(hwif, 1);
  516. /*
  517. * ACPI requires us to call _STM on startup
  518. */
  519. ide_acpi_get_timing(hwif);
  520. ide_acpi_push_timing(hwif);
  521. ide_port_for_each_present_dev(i, drive, hwif) {
  522. ide_acpi_exec_tfs(drive);
  523. }
  524. }