| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071 |
- ///
- /// Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR
- ///
- // Confidence: High
- // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2.
- // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2.
- // URL: http://coccinelle.lip6.fr/
- // Options: -no_includes -include_headers
- //
- // Keywords: ERR_PTR, PTR_ERR, PTR_RET
- // Version min: 2.6.39
- //
- virtual context
- virtual patch
- virtual org
- virtual report
- @depends on patch@
- expression ptr;
- @@
- - if (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0;
- + return PTR_RET(ptr);
- @depends on patch@
- expression ptr;
- @@
- - if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;
- + return PTR_RET(ptr);
- @r1 depends on !patch@
- expression ptr;
- position p1;
- @@
- * if@p1 (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0;
- @r2 depends on !patch@
- expression ptr;
- position p2;
- @@
- * if@p2 (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;
- @script:python depends on org@
- p << r1.p1;
- @@
- coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
- @script:python depends on org@
- p << r2.p2;
- @@
- coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
- @script:python depends on report@
- p << r1.p1;
- @@
- coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
- @script:python depends on report@
- p << r2.p2;
- @@
- coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
|
