webcodecs-stop-using-AudioOpusEncoder.patch 2.3 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950
  1. From 3bd46cb9a51773f103ef52b39d6407740eb0d60a Mon Sep 17 00:00:00 2001
  2. From: Eugene Zemtsov <eugene@chromium.org>
  3. Date: Thu, 24 Feb 2022 23:17:20 +0000
  4. Subject: [PATCH] webcodecs: Stop using AudioOpusEncoder as backed for mojo
  5. audio encoder
  6. AudioOpusEncoder was only used here for testing. Let's not let it get
  7. comfortable. We'll use MF AAC encoder here when we have it. (Soon...)
  8. Bug: 1259883
  9. Change-Id: Ia1819395c8c8fd6d403d4b8558c12f9a1bf7e761
  10. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489449
  11. Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
  12. Auto-Submit: Eugene Zemtsov <eugene@chromium.org>
  13. Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
  14. Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
  15. Cr-Commit-Position: refs/heads/main@{#974895}
  16. ---
  17. media/mojo/services/gpu_mojo_media_client.cc | 10 +---------
  18. 1 file changed, 1 insertion(+), 9 deletions(-)
  19. diff --git a/media/mojo/services/gpu_mojo_media_client.cc b/media/mojo/services/gpu_mojo_media_client.cc
  20. index 8f83a4d6cf6..40cdaff8d3a 100644
  21. --- a/media/mojo/services/gpu_mojo_media_client.cc
  22. +++ b/media/mojo/services/gpu_mojo_media_client.cc
  23. @@ -13,7 +13,6 @@
  24. #include "build/chromeos_buildflags.h"
  25. #include "gpu/ipc/service/gpu_channel.h"
  26. #include "media/audio/audio_features.h"
  27. -#include "media/audio/audio_opus_encoder.h"
  28. #include "media/base/audio_decoder.h"
  29. #include "media/base/cdm_factory.h"
  30. #include "media/base/media_switches.h"
  31. @@ -119,14 +118,7 @@ std::unique_ptr<AudioEncoder> GpuMojoMediaClient::CreateAudioEncoder(
  32. scoped_refptr<base::SequencedTaskRunner> task_runner) {
  33. if (!base::FeatureList::IsEnabled(features::kPlatformAudioEncoder))
  34. return nullptr;
  35. - // TODO(crbug.com/1259883) Right now Opus encoder is all we have, later on
  36. - // we'll create a real platform encoder here.
  37. - auto opus_encoder = std::make_unique<AudioOpusEncoder>();
  38. - auto encoding_runner = base::ThreadPool::CreateSequencedTaskRunner(
  39. - {base::TaskPriority::USER_BLOCKING});
  40. - return std::make_unique<OffloadingAudioEncoder>(std::move(opus_encoder),
  41. - std::move(encoding_runner),
  42. - std::move(task_runner));
  43. + return nullptr;
  44. }
  45. VideoDecoderType GpuMojoMediaClient::GetDecoderImplementationType() {