add-clang-nomerge-attribute-to-CheckError.patch 1.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445
  1. From 9909f146b28d56c9c0411329a056ed959b33f76a Mon Sep 17 00:00:00 2001
  2. From: Zequan Wu <zequanwu@google.com>
  3. Date: Wed, 10 Feb 2021 03:26:00 +0000
  4. Subject: [PATCH] Reland "Add [[clang::nomerge]] attribute to ~CheckError()."
  5. This is a reland of 8860253376c38c090d585bda4b20b801e3aa3ce3
  6. Original change's description:
  7. > Add [[clang::nomerge]] attribute to ~CheckError().
  8. >
  9. > To disable merging multiple ~CheckError() destructor for accurate crash logs.
  10. >
  11. > Bug: 1153188
  12. > Change-Id: If6d153661667a63f13b645f6d284eb3d5ea3a300
  13. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611331
  14. > Commit-Queue: Nico Weber <thakis@chromium.org>
  15. > Auto-Submit: Zequan Wu <zequanwu@google.com>
  16. > Reviewed-by: Nico Weber <thakis@chromium.org>
  17. > Cr-Commit-Position: refs/heads/master@{#844989}
  18. Bug: 1153188
  19. Change-Id: I303c5ff9fb88f7a30663400622b327a910d0b108
  20. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2686331
  21. Reviewed-by: Nico Weber <thakis@chromium.org>
  22. Commit-Queue: Nico Weber <thakis@chromium.org>
  23. Commit-Queue: Zequan Wu <zequanwu@google.com>
  24. Cr-Commit-Position: refs/heads/master@{#852453}
  25. ---
  26. base/check.h | 2 +-
  27. 1 file changed, 1 insertion(+), 1 deletion(-)
  28. diff --git a/base/check.h b/base/check.h
  29. index c94ab68db90..17048e45539 100644
  30. --- a/base/check.h
  31. +++ b/base/check.h
  32. @@ -85,7 +85,7 @@ class BASE_EXPORT CheckError {
  33. // Stream for adding optional details to the error message.
  34. std::ostream& stream();
  35. - ~CheckError();
  36. + NOMERGE ~CheckError();
  37. CheckError(const CheckError& other) = delete;
  38. CheckError& operator=(const CheckError& other) = delete;