libmygpo-qt-1.1.0-qt-5.11b3.patch 4.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131
  1. From 0d76d960727018bddf04c6cc89552af69aaa7e55 Mon Sep 17 00:00:00 2001
  2. From: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
  3. Date: Sun, 15 Apr 2018 22:20:34 +0200
  4. Subject: [PATCH] Add missing Qt5Network, Qt5Test, make BUILD_WITH_QT4 more
  5. strict
  6. ---
  7. CMakeLists.txt | 22 +++++++++++-----------
  8. 1 file changed, 11 insertions(+), 11 deletions(-)
  9. diff --git a/CMakeLists.txt b/CMakeLists.txt
  10. index 2a1f652..eb006d9 100644
  11. --- a/CMakeLists.txt
  12. +++ b/CMakeLists.txt
  13. @@ -5,25 +5,25 @@ project( libmygpo-qt )
  14. set( CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules)
  15. set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII" )
  16. -option(BUILD_WITH_QT4 "Build libmygpo-qt with Qt4 no matter if Qt5 was found" OFF)
  17. +option(BUILD_WITH_QT4 "Build libmygpo-qt with Qt4" OFF)
  18. if( NOT BUILD_WITH_QT4 )
  19. - find_package(Qt5Core QUIET)
  20. - if( Qt5Core_DIR )
  21. - set(MYGPO_QT_VERSION_SUFFIX 5)
  22. -
  23. - macro(qt_wrap_cpp)
  24. - qt5_wrap_cpp(${ARGN})
  25. - endmacro()
  26. + if( MYGPO_BUILD_TESTS )
  27. + find_package(Qt5 REQUIRED COMPONENTS Core Network Test CONFIG)
  28. + else()
  29. + find_package(Qt5 REQUIRED COMPONENTS Core Network CONFIG)
  30. endif()
  31. + set(MYGPO_QT_VERSION_SUFFIX 5)
  32. +
  33. + macro(qt_wrap_cpp)
  34. + qt5_wrap_cpp(${ARGN})
  35. + endmacro()
  36. # pkg-config names of QtCore and QtNetwork are Qt5Core and Qt5Network for
  37. # Qt5
  38. set(MYGPO_QT_MAJOR_VERSION "5")
  39. set(MYGPO_QT4_QJSON_DEP "")
  40. -endif()
  41. -
  42. -if( NOT Qt5Core_DIR )
  43. +else()
  44. message(STATUS "Could not find Qt5, searching for Qt4 instead...")
  45. message(STATUS "Qt4 Support is deprecated, building with Qt4 is no longer officially supported")
  46. if( MYGPO_BUILD_TESTS )
  47. From 1b53767b988b339aac8b353327a1542b2a0c0610 Mon Sep 17 00:00:00 2001
  48. From: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
  49. Date: Sun, 15 Apr 2018 22:29:33 +0200
  50. Subject: [PATCH] Fix build with Qt 5.11_beta3 (dropping qt5_use_modules)
  51. ---
  52. CMakeLists.txt | 3 ---
  53. src/CMakeLists.txt | 8 ++++++--
  54. tests/CMakeLists.txt | 12 +++++++++---
  55. 3 files changed, 15 insertions(+), 8 deletions(-)
  56. diff --git a/CMakeLists.txt b/CMakeLists.txt
  57. index eb006d9..fa4b0cb 100644
  58. --- a/CMakeLists.txt
  59. +++ b/CMakeLists.txt
  60. @@ -34,9 +34,6 @@ else()
  61. set( QT_DONT_USE_QTGUI TRUE )
  62. include( ${QT_USE_FILE} )
  63. - macro(qt5_use_modules)
  64. - endmacro()
  65. -
  66. macro(qt_wrap_cpp)
  67. qt4_wrap_cpp(${ARGN})
  68. endmacro()
  69. diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
  70. index 802125b..253e81e 100644
  71. --- a/src/CMakeLists.txt
  72. +++ b/src/CMakeLists.txt
  73. @@ -79,9 +79,13 @@ QT_WRAP_CPP(LIBMYGPO_QT_MOC_SRC ${LIBMYGPO_QT_MOC_H} )
  74. add_library( ${MYGPO_QT_TARGET_NAME} SHARED ${LIBMYGPO_QT_SRC} ${LIBMYGPO_QT_MOC_SRC} )
  75. -target_link_libraries( ${MYGPO_QT_TARGET_NAME} ${QJSON_LIBRARIES} ${QT_QTCORE_LIBRARY} ${QT_QTNETWORK_LIBRARY} )
  76. set_target_properties( ${MYGPO_QT_TARGET_NAME} PROPERTIES VERSION ${MYGPO_QT_VERSION} SOVERSION ${MYGPO_QT_SONAME} DEFINE_SYMBOL MYGPO_MAKEDLL)
  77. -qt5_use_modules( ${MYGPO_QT_TARGET_NAME} Core Network )
  78. +
  79. +if( NOT BUILD_WITH_QT4 )
  80. + target_link_libraries( ${MYGPO_QT_TARGET_NAME} Qt5::Core Qt5::Network)
  81. +else()
  82. + target_link_libraries( ${MYGPO_QT_TARGET_NAME} ${QT_QTCORE_LIBRARY} ${QT_QTNETWORK_LIBRARY} ${QJSON_LIBRARIES})
  83. +endif()
  84. install( TARGETS ${MYGPO_QT_TARGET_NAME} EXPORT ${MYGPO_QT_TARGET_NAME}Export DESTINATION ${LIB_INSTALL_DIR} )
  85. diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
  86. index a3e3223..4f77158 100644
  87. --- a/tests/CMakeLists.txt
  88. +++ b/tests/CMakeLists.txt
  89. @@ -11,11 +11,15 @@ include_directories( ${QJSON_INCLUDE_DIR} ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CU
  90. # UrlBuilder library
  91. add_library( UrlBuilder ${TESTOBJECTS_SRCDIR}/UrlBuilder.cpp ${TESTOBJECTS_SRCDIR}/Config.cpp )
  92. -qt5_use_modules( UrlBuilder Core )
  93. +if( NOT BUILD_WITH_QT4 )
  94. + target_link_libraries( UrlBuilder Qt5::Core )
  95. +endif()
  96. # JSONCreator library
  97. QT_WRAP_CPP(LIBMYGPO_QT_MOC_SRC ${TESTOBJECTS_SRCDIR}/EpisodeAction.h ${TESTOBJECTS_SRCDIR}/EpisodeAction_p.h )
  98. add_library( JsonCreator ${TESTOBJECTS_SRCDIR}/JsonCreator.cpp ${TESTOBJECTS_SRCDIR}/EpisodeAction.cpp ${TESTOBJECTS_SRCDIR}/qjsonwrapper/Json.cpp ${LIBMYGPO_QT_MOC_SRC})
  99. -qt5_use_modules( JsonCreator Core Network )
  100. +if( NOT BUILD_WITH_QT4 )
  101. + target_link_libraries( JsonCreator Qt5::Core Qt5::Network )
  102. +endif()
  103. set( EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR} )
  104. @@ -25,7 +29,9 @@ macro(add_libmygpo_test _source)
  105. add_executable(${_name} ${_source} ${${_name}_MOC_SRC})
  106. target_link_libraries(${_name} ${QT_QTCORE_LIBRARY} ${QT_QTTEST_LIBRARY} ${QT_QTNETWORK_LIBRARY})
  107. add_test(${_name}-test ${EXECUTABLE_OUTPUT_PATH}/${_name})
  108. - qt5_use_modules(${_name} Network Test)
  109. + if( NOT BUILD_WITH_QT4 )
  110. + target_link_libraries(${_name} Qt5::Network Qt5::Test)
  111. + endif()
  112. endmacro(add_libmygpo_test)
  113. add_libmygpo_test( UrlBuilderTest.cpp )