e002696b.patch 1.3 KB

123456789101112131415161718192021222324252627282930313233343536373839
  1. From e002696b0673dff7ec9584e00b1546d2f850121c Mon Sep 17 00:00:00 2001
  2. From: Christoph Cullmann <cullmann@kde.org>
  3. Date: Mon, 16 May 2022 19:47:04 +0200
  4. Subject: [PATCH] Revert "fix crash on file browser activation"
  5. This reverts commit a28624c877cfe6db6ae6ab257f95af36213b25e0.
  6. => this fix is not enough, the KConfigGroup is just not valid anymore here
  7. in some cases
  8. BUG: 453795
  9. ---
  10. addons/filebrowser/katefilebrowserplugin.cpp | 9 +++------
  11. 1 file changed, 3 insertions(+), 6 deletions(-)
  12. diff --git a/addons/filebrowser/katefilebrowserplugin.cpp b/addons/filebrowser/katefilebrowserplugin.cpp
  13. index 6df25239a..f03c78698 100644
  14. --- a/addons/filebrowser/katefilebrowserplugin.cpp
  15. +++ b/addons/filebrowser/katefilebrowserplugin.cpp
  16. @@ -100,12 +100,9 @@ void KateFileBrowserPluginView::createFileBrowser(bool visible)
  17. disconnect(m_toolView.get(), SIGNAL(toolVisibleChanged(bool)), this, SLOT(createFileBrowser(bool)));
  18. m_fileBrowser = std::make_unique<KateFileBrowser>(m_mainWindow, m_toolView.get());
  19. -
  20. - // read config only if there yet, see bug 453234
  21. - if (cg) {
  22. - m_fileBrowser->readSessionConfig(*cg);
  23. - cg.reset();
  24. - }
  25. + m_fileBrowser->readSessionConfig(*cg);
  26. + // delete the config now
  27. + cg.reset();
  28. }
  29. bool KateFileBrowserPluginView::eventFilter(QObject *obj, QEvent *event)
  30. --
  31. GitLab