d5a3e749.patch 1.6 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950
  1. From d5a3e749a30613294f41386180aaf31dfb1a9bee Mon Sep 17 00:00:00 2001
  2. From: Nate Graham <nate@kde.org>
  3. Date: Thu, 14 Oct 2021 15:44:33 -0600
  4. Subject: [PATCH] sddm-theme: fix missing password field on "Other" page
  5. On this page there is no concept of the user being passwordless because
  6. no username has been specified by the user yet; we cannot know ahead of
  7. time. As a result, userList.currentItem.needsPassword is blank so the
  8. password field gets hidden.
  9. We should just assume that in username/password entry mode, all users
  10. have a password set. For any users where this is not the case, they can
  11. just leave the password blank, and it's not any worse than it was in
  12. Plasma 5.22.
  13. BUG: 443737
  14. FIXED-IN: 5.23.1
  15. (cherry picked from commit f038ab3f494f26b443b10ff5dc9f156e1ec16341)
  16. ---
  17. sddm-theme/Login.qml | 4 ++--
  18. 1 file changed, 2 insertions(+), 2 deletions(-)
  19. diff --git a/sddm-theme/Login.qml b/sddm-theme/Login.qml
  20. index 8829666f1..6d3d62804 100644
  21. --- a/sddm-theme/Login.qml
  22. +++ b/sddm-theme/Login.qml
  23. @@ -83,7 +83,7 @@ SessionManagementScreen {
  24. }
  25. }
  26. - visible: userList.currentItem.needsPassword
  27. + visible: root.showUsernamePrompt || userList.currentItem.needsPassword
  28. Keys.onEscapePressed: {
  29. mainStack.currentItem.forceActiveFocus();
  30. @@ -119,7 +119,7 @@ SessionManagementScreen {
  31. icon.name: text.length == 0 ? "go-next" : ""
  32. - text: userList.currentItem.needsPassword ? "" : i18n("Log In")
  33. + text: root.showUsernamePrompt || userList.currentItem.needsPassword ? "" : i18n("Log In")
  34. onClicked: startLogin();
  35. }
  36. }
  37. --
  38. GitLab