95551f44.patch 1.2 KB

123456789101112131415161718192021222324252627282930313233343536
  1. From 95551f44922670be5c4d670833c2d4e398657495 Mon Sep 17 00:00:00 2001
  2. From: Nicolas Fella <nicolas.fella@gmx.de>
  3. Date: Fri, 8 Mar 2024 18:46:32 +0100
  4. Subject: [PATCH] Remove unneeded code for toggeling dockwidget visibility
  5. QDockWidget::toggleViewAction::toggled is emitted when minimizing
  6. the application window on X11 (https://bugreports.qt.io/browse/QTBUG-48161
  7. potentially related). This will cause the dockwidget to be hidden when
  8. minimizing the window.
  9. We don't actually seem to need that connection, triggering the action
  10. (via shortcut or menu) seems to correctly show/hide the dockwidget
  11. without it
  12. BUG: 481952
  13. ---
  14. src/dolphinmainwindow.cpp | 2 --
  15. 1 file changed, 2 deletions(-)
  16. diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
  17. index 03486a9cf6..1f4de8869c 100644
  18. --- a/src/dolphinmainwindow.cpp
  19. +++ b/src/dolphinmainwindow.cpp
  20. @@ -2619,8 +2619,6 @@ void DolphinMainWindow::createPanelAction(const QIcon &icon, const QKeySequence
  21. QAction *panelAction = actionCollection()->addAction(actionName, dockAction);
  22. actionCollection()->setDefaultShortcut(panelAction, shortcut);
  23. -
  24. - connect(panelAction, &QAction::toggled, dockWidget, &QWidget::setVisible);
  25. }
  26. // clang-format off
  27. void DolphinMainWindow::setupWhatsThis()
  28. --
  29. GitLab