Hi, thanks for this great project. I'm not a developer, just an enthusiast... so go easy ;-). Anyway, I noticed a *** stack smashing detected ***: terminated error for the temperature component.
After a bit of printf debugging I've come to the conclusion that the char name[16]; declaration was the culprit - enlarging it to PATH_MAX allowed the component to run without crashing. On my system (some output from printf'ing):
from 1st esnprintf: /sys/class/hwmon/hwmon8/name
name is: ucsi_source_psy_USBC000:001
i.e. bigger than 16.
I've no idea if there is a "sensible" value for this, PATH_MAX seems excessive... maybe 48?
Do you think this is worth a change to your code... maybe I'm just an outlier! (thinkpad t470s running pop!_os) :-)
Cheers
Hi, thanks for this great project. I'm not a developer, just an enthusiast... so go easy ;-). Anyway, I noticed a `*** stack smashing detected ***: terminated` error for the temperature component.
After a bit of `printf` debugging I've come to the conclusion that the `char name[16];` declaration was the culprit - enlarging it to `PATH_MAX` allowed the component to run without crashing. On my system (some output from `printf`'ing):
```
from 1st esnprintf: /sys/class/hwmon/hwmon8/name
name is: ucsi_source_psy_USBC000:001
```
i.e. bigger than 16.
I've no idea if there is a "sensible" value for this, `PATH_MAX` seems excessive... maybe 48?
Do you think this is worth a change to your code... maybe I'm just an outlier! (thinkpad t470s running pop!_os) :-)
Cheers
Hi, thanks for this great project. I'm not a developer, just an enthusiast... so go easy ;-). Anyway, I noticed a
*** stack smashing detected ***: terminatederror for the temperature component.After a bit of
printfdebugging I've come to the conclusion that thechar name[16];declaration was the culprit - enlarging it toPATH_MAXallowed the component to run without crashing. On my system (some output fromprintf'ing):i.e. bigger than 16.
I've no idea if there is a "sensible" value for this,
PATH_MAXseems excessive... maybe 48?Do you think this is worth a change to your code... maybe I'm just an outlier! (thinkpad t470s running pop!_os) :-)
Cheers
thanks for your interest in the project and thanks for the bug report
may be you an outlier, but this bug must be fixed, so i'll fix it soon
should be fixed
Thanks, I see what you did there. Very sneaky. Indeed, it is fixed.