patchreader.py 3.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384
  1. # Copyright (C) 2010 Google Inc. All rights reserved.
  2. # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com)
  3. # Copyright (C) 2010 ProFUSION embedded systems
  4. #
  5. # Redistribution and use in source and binary forms, with or without
  6. # modification, are permitted provided that the following conditions are
  7. # met:
  8. #
  9. # * Redistributions of source code must retain the above copyright
  10. # notice, this list of conditions and the following disclaimer.
  11. # * Redistributions in binary form must reproduce the above
  12. # copyright notice, this list of conditions and the following disclaimer
  13. # in the documentation and/or other materials provided with the
  14. # distribution.
  15. # * Neither the name of Google Inc. nor the names of its
  16. # contributors may be used to endorse or promote products derived from
  17. # this software without specific prior written permission.
  18. #
  19. # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  20. # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  21. # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  22. # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  23. # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  24. # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  25. # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  26. # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  27. # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  28. # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  29. # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  30. import logging
  31. import re
  32. from webkitpy.common.checkout.diff_parser import DiffParser
  33. from webkitpy.common.system.executive import Executive
  34. from webkitpy.common.system.filesystem import FileSystem
  35. from webkitpy.common.checkout.scm.detection import SCMDetector
  36. _log = logging.getLogger(__name__)
  37. class PatchReader(object):
  38. """Supports checking style in patches."""
  39. def __init__(self, text_file_reader):
  40. """Create a PatchReader instance.
  41. Args:
  42. text_file_reader: A TextFileReader instance.
  43. """
  44. self._text_file_reader = text_file_reader
  45. def check(self, patch_string, fs=None):
  46. """Check style in the given patch."""
  47. fs = fs or FileSystem()
  48. patch_files = DiffParser(patch_string.splitlines()).files
  49. # If the user uses git, checking subversion config file only once is enough.
  50. call_only_once = True
  51. for path, diff_file in patch_files.iteritems():
  52. line_numbers = diff_file.added_or_modified_line_numbers()
  53. _log.debug('Found %s new or modified lines in: %s' % (len(line_numbers), path))
  54. if not line_numbers:
  55. match = re.search("\s*png$", path)
  56. if match and fs.exists(path):
  57. if call_only_once:
  58. self._text_file_reader.process_file(file_path=path, line_numbers=None)
  59. cwd = FileSystem().getcwd()
  60. detection = SCMDetector(fs, Executive()).detect_scm_system(cwd)
  61. if detection.display_name() == "git":
  62. call_only_once = False
  63. continue
  64. # Don't check files which contain only deleted lines
  65. # as they can never add style errors. However, mark them as
  66. # processed so that we count up number of such files.
  67. self._text_file_reader.count_delete_only_file()
  68. continue
  69. self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)