123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490 |
- 2014-05-22 Dana Burkart <dburkart@apple.com>
- Merge r166628. <rdar://problem/16975444>
- 2014-04-13 Darin Adler <darin@apple.com>
- userVisibleString should not try to "encode" host names
- https://bugs.webkit.org/show_bug.cgi?id=131587
- rdar://problem/14686849
- Reviewed by Alexey Proskuryakov.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
- * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
- Coverage is tiny at this point; we could add a lot more cases!
- 2013-08-15 Lucas Forschler <lforschler@apple.com>
- Merge r154115
- 2013-08-15 Andy Estes <aestes@apple.com>
- <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
- Reviewed by Brady Eidson.
- Wrote an API test that verifies -[WebView stopLoading:] can be called
- inside webView:resource:didFinishLoadingFromDataSource: without crashing.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
- (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
- (TestWebKitAPI::TEST):
- 2013-08-09 Lucas Forschler <lforschler@apple.com>
- Merge r153907
- 2013-08-09 Beth Dakin <bdakin@apple.com>
- AX: Not able to use arrow keys to read text in a WK2 app
- https://bugs.webkit.org/show_bug.cgi?id=119605
- -and corresponding-
- <rdar://problem/14281275>
- Reviewed by Darin Adler.
- New test verifies that didNotHandleKeyEvent will be called when there is nothing
- to scroll.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
- (TestWebKitAPI::didFinishLoadForFrame):
- (TestWebKitAPI::didNotHandleKeyEventCallback):
- (TestWebKitAPI::TEST):
- 2013-08-05 Lucas Forschler <lforschler@apple.com>
- Merge r153628
- 2013-08-01 Brent Fulgham <bfulgham@apple.com>
- [Windows] WebKit1 Fullscreen Video Play is Broken
- https://bugs.webkit.org/show_bug.cgi?id=119415
- Reviewed by Jer Noble.
- * WinLauncher/WinLauncher.cpp:
- (dllLauncherEntryPoint): Activate full screen mode via
- IWebPreferencesInternal interface.
- 2013-08-05 Lucas Forschler <lforschler@apple.com>
- Merge r152861
- 2013-07-16 Brent Fulgham <bfulgham@apple.com>
- [Win] Support in-band text tracks.
- https://bugs.webkit.org/show_bug.cgi?id=103770
- Reviewed by Eric Carlson.
- Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
- libdispatch and CFRunLoop elements are services during the run loop.
- * WinLauncher/WinLauncher.cpp:
- (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
- a CoreFoundation (or CFLite) support library.
- * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
- * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
- and WinLauncherCFLite.props.
- 2013-07-26 Lucas Forschler <lforschler@apple.com>
- Merge r153344
- 2013-07-25 Sam Weinig <sam@webkit.org>
- -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
- https://bugs.webkit.org/show_bug.cgi?id=119099
- <rdar://problem/13439291>
- Reviewed by Enrica Casucci.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/mac/AttributedString.mm:
- (TestWebKitAPI::attributedString):
- (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
- (TestWebKitAPI::AttributedStringTest_CustomFont::url):
- (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
- (TestWebKitAPI::TEST_F):
- (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
- (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
- (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
- * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
- Add tests for attributed strings with strikethrough. Refactor the attributed string tests
- to make adding more easier in the future.
- 2013-07-26 Lucas Forschler <lforschler@apple.com>
- Merge r153107
- 2013-07-24 Anders Carlsson <andersca@apple.com>
- Crash when calling WKPageGetProcessIdentifier after aborted process launch
- https://bugs.webkit.org/show_bug.cgi?id=119069
- <rdar://problem/14494064>
- Reviewed by Andreas Kling.
- Add a test.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
- (TestWebKitAPI::didFinishLoadForFrame):
- (TestWebKitAPI::TEST):
- 2013-07-25 Babak Shafiei <bshafiei@apple.com>
- Merge r153353
- 2013-07-25 Mark Rowe <mrowe@apple.com>
- Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
- * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
- * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
- so they pull the version out of the SDK.
- 2013-07-23 Lucas Forschler <lforschler@apple.com>
- Merge r153072
- 2013-07-23 Andreas Kling <akling@apple.com>
- REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
- <rdar://problem/14324895>
- <http://webkit.org/b/119023>
- Reviewed by Simon Fraser.
- Add a test for this rather specific problem.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
- (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
- (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
- (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Merge r152951
- 2013-07-21 Andreas Kling <akling@apple.com>
- KURL creates duplicate strings when completing data: URIs.
- <http://webkit.org/b/118952>
- <rdar://problem/14504480>
- Reviewed by Anders Carlsson.
- * TestWebKitAPI/Tests/WebCore/KURL.cpp:
- (TestWebKitAPI::TEST_F):
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Merge r152484
- 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
- KURL unit test fixture class should have a meaningful name
- https://bugs.webkit.org/show_bug.cgi?id=118467
- Reviewed by Sam Weinig.
- * TestWebKitAPI/Tests/WebCore/KURL.cpp:
- (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
- instead of the generic and inappropriate 'WebCore' name.
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Merge r152939
- 2013-07-19 Chris Fleizach <cfleizach@apple.com>
- AX: VoiceOver not detecting misspelled words don't work in all cases
- https://bugs.webkit.org/show_bug.cgi?id=118924
- Reviewed by Tim Horton.
- Make the misspelled detection dependent on both types of attributes being present.
- * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- (AccessibilityUIElement::attributedStringRangeIsMisspelled):
- * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Merge r152939
- 2013-07-19 Chris Fleizach <cfleizach@apple.com>
- AX: VoiceOver not detecting misspelled words don't work in all cases
- https://bugs.webkit.org/show_bug.cgi?id=118924
- Reviewed by Tim Horton.
- Make the misspelled detection dependent on both types of attributes being present.
- * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- (AccessibilityUIElement::attributedStringRangeIsMisspelled):
- * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Merge r152824
- 2013-07-17 Tim Horton <timothy_horton@apple.com>
- Update blocked/missing plug-in UI
- https://bugs.webkit.org/show_bug.cgi?id=118347
- <rdar://problem/14209318>
- Reviewed by Sam Weinig.
- * MiniBrowser/mac/WK2BrowserWindowController.m:
- (-[WK2BrowserWindowController awakeFromNib]):
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::createWebViewWithOptions):
- Match new WKPageLoaderClient entry.
- 2013-07-22 Lucas Forschler <lforschler@apple.com>
- Rollout r152701
- 2013-07-16 Lucas Forschler <lforschler@apple.com>
- Merge r152701
- 2013-07-15 Tim Horton <timothy_horton@apple.com>
- Update blocked/missing plug-in UI
- https://bugs.webkit.org/show_bug.cgi?id=118347
- <rdar://problem/14209318>
- Reviewed by Sam Weinig.
- * MiniBrowser/mac/WK2BrowserWindowController.m:
- (-[WK2BrowserWindowController awakeFromNib]):
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::createWebViewWithOptions):
- Match new WKPageLoaderClient entry.
- 2013-07-15 Lucas Forschler <lforschler@apple.com>
- Merge r152498
- 2013-07-09 Anders Carlsson <andersca@apple.com>
- DumpRenderTree should stop sending unsupported URLs to NSWorkspace
- https://bugs.webkit.org/show_bug.cgi?id=118514
- <rdar://problem/13686836>
- Reviewed by Sam Weinig.
- Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
- * DumpRenderTree/DefaultPolicyDelegate.h: Added.
- * DumpRenderTree/DefaultPolicyDelegate.m: Added.
- (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (allocateGlobalControllers):
- Allocate a DefaultPolicyDelegate object.
- (resetWebViewToConsistentStateBeforeTesting):
- Set the policy delegate to the default policy delegate.
- * DumpRenderTree/mac/DumpRenderTreeMac.h:
- Declare the defaultPolicyDelegate object.
- * DumpRenderTree/mac/TestRunnerMac.mm:
- (TestRunner::setCustomPolicyDelegate):
- Set the policy delegate to the default delegate if setDelegate is false.
- 2013-07-15 Lucas Forschler <lforschler@apple.com>
- Merge r152366
- 2013-07-03 Jer Noble <jer.noble@apple.com>
- Xcode often gets in a state where the debugger is completely unresponsive
- https://bugs.webkit.org/show_bug.cgi?id=118157
- The GetPointeeData() operations we use to retrieve strings is extremely expensive.
- Rather than pull the character data out of the debugger one byte at a time
- through the GetPointeeData() API, retrieve the memory contents of the string through
- the ReadMemory() API, and convert the retrieved memory into a python string.
- Reviewed by Anders Carlsson.
- * lldb/lldb_webkit.py:
- (__lldb_init_module.lldb_webkit):
- (guess_string_length):
- (ustring_to_string):
- (lstring_to_string):
- 2013-07-09 Lucas Forschler <lforschler@apple.com>
- Merge r152433
- 2013-07-05 Tim Horton <timothy_horton@apple.com>
- Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
- https://bugs.webkit.org/show_bug.cgi?id=118439
- <rdar://problem/14366120>
- Reviewed by Anders Carlsson.
- * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
- (TestWebKitAPI::didLayout):
- (TestWebKitAPI::TEST):
- - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
- - Assert that we got the right number of pages for sanity.
- - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
- so much memory that SharedMemory asserts and makes the test time out.
- - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
- because paint doesn't fire if the window is offscreen.
- 2013-07-09 Lucas Forschler <lforschler@apple.com>
- Merge r152425
- 2013-07-05 Tim Horton <timothy_horton@apple.com>
- [wk2] Add API to lock the scroll position at the top or bottom of the page
- https://bugs.webkit.org/show_bug.cgi?id=118429
- <rdar://problem/14120323>
- Reviewed by Anders Carlsson.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
- (TestWebKitAPI::didFinishDocumentLoadForFrame):
- (TestWebKitAPI::TEST):
- Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
- all work correctly in the face of resizing the view and scrolling from JS.
- 2013-07-08 Lucas Forschler <lforschler@apple.com>
- Merge r152267
- 2013-07-01 Timothy Hatcher <timothy@apple.com>
- Link to WebInspectorUI.framework at build time instead of soft linking.
- https://bugs.webkit.org/show_bug.cgi?id=118261
- Reviewed by Joseph Pecoraro.
- * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
- 2013-07-03 Alexey Proskuryakov <ap@apple.com>
- Merge r152195.
- 2013-06-28 Andy Estes <aestes@apple.com>
- [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
- https://bugs.webkit.org/show_bug.cgi?id=118208
- Reviewed by Mark Rowe.
- Newer versions of clang use a default template depth of 128, but this
- is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
- previous default.
- Clang lowered the default to keep recursive template instantiation
- from overflowing the stack (see <rdar://problem/13935016>), but
- TestWebKitAPI's C++ files don't trigger a stack overflow even with the
- higher limit. If for some reason this starts happening then we can
- lower the limit back down.
- * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
- 2013-07-01 Lucas Forschler <lforschler@apple.com>
- Merge r152265
- 2013-07-01 Tim Horton <timothy_horton@apple.com>
- Maximum scroll position can be negative in some cases
- https://bugs.webkit.org/show_bug.cgi?id=118175
- <rdar://problem/14301217>
- Reviewed by Anders Carlsson.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
- (TestWebKitAPI::didRunJavaScript):
- (TestWebKitAPI::didLayout):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
- Add a test that loads a vertical-lr document, paginates it horizontally
- from right to left, resizes the view to fit the entire document, and
- verifies that the scroll position is negative, as it must be for the
- document to be enclosed by the view.
- 2013-07-01 Lucas Forschler <lforschler@apple.com>
- Merge r152196
- 2013-06-28 Alexey Proskuryakov <ap@apple.com>
- [Mac] Crash when loading is stopped from -didReceiveResponse
- https://bugs.webkit.org/show_bug.cgi?id=118209
- <rdar://problem/14259249>
- Reviewed by Brady Eidson.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
- * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
- (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
- (TestWebKitAPI::TEST):
- 2013-06-28 Lucas Forschler <lforschler@apple.com>
- Merge r152188
- 2013-06-28 Jessie Berlin <jberlin@apple.com>
- WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
- https://bugs.webkit.org/show_bug.cgi?id=118201
- Reviewed by Dean Jackson.
- * WebKitTestRunner/mac/main.mm:
- (main):
- Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
- setAutomaticDashSubstitutionEnabled are not exposed on WKView.
- 2013-06-27 Lucas Forschler <lforschler@apple.com>
- Merge r152144
- 2013-06-26 Dean Jackson <dino@apple.com>
- [Mac] Add Mavericks system font to Test systems
- https://bugs.webkit.org/show_bug.cgi?id=118109
- Reviewed by Simon Fraser.
- OS X Mavericks uses a different font for system controls. Tell DRT and
- WKTR about them otherwise they use a fallback font. Unfortunately the
- fonts are hidden (not found in the list of available fonts) so I
- had to add them manually.
- Even though there is only one at the moment, I implemented this
- as a set so it will be easier to add new fonts if necessary.
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (allowedFontFamilySet): Fixed typo.
- (systemHiddenFontFamilySet): New method that returns the system control font.
- (drt_NSFontManager_availableFonts): Merge the hidden fonts.
- * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
- (WTR::allowedFontFamilySet): Fixed typo.
- (WTR::systemHiddenFontFamilySet): As above.
- (WTR::wtr_NSFontManager_availableFonts):
- 2013-06-27 Lucas Forschler <lforschler@apple.com>
- Merge r151954
- 2013-06-24 Dean Jackson <dino@apple.com>
- [Mac] Update font used for Chinese in test systems
- https://bugs.webkit.org/show_bug.cgi?id=117970
- Reviewed by Alexey Proskuryakov.
- Add "Songti TC" and "Songti SC" to the list of allowed fonts
- in DRT and WKTR.
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (allowedFontFamilySet):
- * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
- (WTR::allowedFontFamilySet):
- 2013-06-26 Lucas Forschler <lforschler@apple.com>
- Merge r151832
- 2013-06-21 Christophe Dumez <ch.dumez@sisa.samsung.com>
- REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
- https://bugs.webkit.org/show_bug.cgi?id=117825
- Reviewed by Kentaro Hara.
- DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
- * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
- (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- * DumpRenderTree/efl/TestRunnerEfl.cpp:
- (TestRunner::overridePreference):
- 2013-06-18 Alex Christensen <achristensen@apple.com>
- Working on coverage script, added xml to json data extraction script.
- https://bugs.webkit.org/show_bug.cgi?id=117648
- This is part of a new test code coverage analysis tool. This compiles WebKit to generate
- coverage data, runs the tests, and collects all of the data in json format.
- Reviewed by Stephanie Lewis.
- * Scripts/generate-coverage-data:
- (parseGcovrOutput):
- (getFileHitsAndBranches):
- (addLineCounts):
- (createResultName):
- * Scripts/webkitpy/tool/gcovr: Added.
- 2013-06-18 Ryuan Choi <ryuan.choi@samsung.com>
- Unreviewed build fix after r151699.
- * TestWebKitAPI/CMakeLists.txt:
- * WebKitTestRunner/CMakeLists.txt:
- Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
- 2013-06-18 Roger Fong <roger_fong@apple.com>
- Replace tools32 folder with tools and update WebKit Windows solution accordingly.
- <rdar://problem/14118143>.
- Rubberstamped by Brent Fulgham.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
- * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
- * win/record-memory/record-memory.vcxproj:
- * win/record-memory/record-memoryDebug.props:
- * win/record-memory/record-memoryDebugWinCairo.props:
- * win/record-memory/record-memoryProduction.props:
- * win/record-memory/record-memoryRelease.props:
- * win/record-memory/record-memoryReleaseWinCairo.props:
- 2013-06-17 Kangil Han <kangil.han@samsung.com>
- Unreviewed. Add my email to a DOM watchlist.
- * Scripts/webkitpy/common/config/watchlist:
- 2013-06-17 Zan Dobersek <zdobersek@igalia.com>
- Unreviewed GTK gardening.
- * Scripts/run-gtk-tests:
- (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
- 2013-06-15 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
- Unreviewed. Reorder my email addresses.
- https://bugs.webkit.org/show_bug.cgi?id=100122
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-06-14 Enrica Casucci <enrica@apple.com>
- WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
- https://bugs.webkit.org/show_bug.cgi?id=117647
- <rdar://problem/13881024>
- Reviewed by Darin Adler.
-
- The test now uses content with a selection and tests both
- forwards and backward find as well as the case of a find
- that has no matches after the user selection.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
- (TestWebKitAPI::didFindStringMatches):
- * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
- 2013-06-14 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
- Remove myself from Qt build system watchlist
- Reviewed by Simon Hausmann.
- * Scripts/webkitpy/common/config/watchlist:
- 2013-06-13 Michael Brüning <michael.bruning@digia.com>
- [Qt][Mac] Disable QTKit video on OS X.
- https://bugs.webkit.org/show_bug.cgi?id=117591
- Reviewed by Tor Arne Vestbø.
- Deployment of Qt binaries to different Mac OS X
- platform version makes it impossible to link against
- the correct version of the WebKitSystemInterface library,
- so we need to disable QTKit for media elements.
- * qmake/mkspecs/features/features.prf:
- 2013-06-13 Michał Pakuła vel Rutka <m.pakula@samsung.com>
- [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
- https://bugs.webkit.org/show_bug.cgi?id=116610
- Reviewed by Noam Rosenthal.
- Remove unnecessary code adjusting context menu position to webview position.
- Now position is calculcated in EwkView.
- * MiniBrowser/efl/main.c:
- (on_context_menu_show):
- 2013-06-12 Roger Fong <roger_fong@apple.com>
- Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
- * Scripts/webkitpy/common/config/ews.json:
- 2013-06-12 Eduardo Lima Mitev <elima@igalia.com>
- [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
- https://bugs.webkit.org/show_bug.cgi?id=115647
- Reviewed by Martin Robinson.
- Locale resolution is moved to WebKitAccessibleWrapperAtk using
- AtkObject::get_object_locale() API. Now, implementation of
- AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
- be leveraged to get_object_locale() of AtkObject.
- Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
- method.
- No new functionality, no new tests.
- * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- (AccessibilityUIElement::language): Leverage locale resolution to
- AtkObject::get_object_locale().
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- (WTR::AccessibilityUIElement::language): Leverage locale resolution to
- AtkObject::get_object_locale().
- 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
- Remove last bits of GYP from build-webkit and update-webkit scripts
- https://bugs.webkit.org/show_bug.cgi?id=117557
- Reviewed by Ryosuke Niwa.
- * Scripts/build-webkit:
- * Scripts/update-webkit:
- 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
- Remove forgotten unused Tools/Script/make-gypi script
- https://bugs.webkit.org/show_bug.cgi?id=117558
- Reviewed by Ryosuke Niwa.
- This script isn't used since the GYP removal from WebKit.
- * Scripts/make-gypi: Removed.
- 2013-06-12 Andres Gomez <agomez@igalia.com>
- [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
- https://bugs.webkit.org/show_bug.cgi?id=117533
- Reviewed by Carlos Garcia Campos.
- MiniBrowser now starts automatically the download of the documents
- that cannot be shown just by WebKit itself on link left clicking.
- * MiniBrowser/gtk/BrowserWindow.c:
- (webViewDecidePolicy): handled the
- WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
- 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
- https://bugs.webkit.org/show_bug.cgi?id=116723
- Reviewed by Carlos Garcia Campos.
- * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
- remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
- and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
- not expensive and produces a working archive without problems even on incremental builds.
- 2013-06-11 Santosh Mahto <santosh.ma@samsung.com>
- [EFL] Window resize should close the popupmenu
- https://bugs.webkit.org/show_bug.cgi?id=117391
- Reviewed by Christophe Dumez.
-
- Added the code to close the popup when main window is resized.
- * MiniBrowser/efl/main.c:
- (on_window_resize):
- 2013-06-11 Alex Christensen <achristensen@apple.com>
- Removed old broken code coverage tool.
- https://bugs.webkit.org/show_bug.cgi?id=117520
- Reviewed by Sam Weinig.
- * CodeCoverage: Removed.
- * CodeCoverage/README: Removed.
- * CodeCoverage/amber.png: Removed.
- * CodeCoverage/cov.py: Removed.
- * CodeCoverage/emerald.png: Removed.
- * CodeCoverage/gcov.css: Removed.
- * CodeCoverage/glass.png: Removed.
- * CodeCoverage/regenerate-coverage-display: Removed.
- * CodeCoverage/ruby.png: Removed.
- * CodeCoverage/run-generate-coverage-data: Removed.
- * CodeCoverage/snow.png: Removed.
- 2013-06-11 Timothy Hatcher <timothy@apple.com>
- Have build-webkit build the WebInspectorUI project.
- * Scripts/build-webkit:
- 2013-06-11 Ryosuke Niwa <rniwa@webkit.org>
- Add an option to run-webkit-tests to skip java dependency check
- https://bugs.webkit.org/show_bug.cgi?id=117516
- Reviewed by Andreas Kling.
- * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- (parse_args):
- * Scripts/webkitpy/port/mac.py:
- (MacPort._check_port_build):
- 2013-06-11 Alex Christensen <achristensen@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=117514
- Removed extra Xcode code coverage flags.
- Reviewed by Sam Weinig.
- * Scripts/webkitdirs.pm:
- (XcodeCoverageSupportOptions):
- 2013-06-11 Brent Fulgham <bfulgham@apple.com>
- [Windows] Implement 'attributeValue' accessor to support testing
- https://bugs.webkit.org/show_bug.cgi?id=117513
- Reviewed by Anders Carlsson.
- * DumpRenderTree/win/AccessibilityControllerWin.cpp:
- (comparableObject): Move earlier in file.
- (findAccessibleObjectById): New implemenation.
- (AccessibilityController::accessibleElementById): New implementation.
- 2013-06-11 Csaba Osztrogonác <ossy@webkit.org>
- Make WTR use its own temporary directory for application cache
- https://bugs.webkit.org/show_bug.cgi?id=117143
- Reviewed by Alexey Proskuryakov.
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::initialize):
- 2013-06-10 Alexey Proskuryakov <ap@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=117449
- Remove dead code for storing fonts in __DATA section
- Reviewed by Dan Bernstein.
- * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- Don't copy font resources to __DATA, as we don't have any code that reads them
- from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
- * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
- * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
- Removed comments suggesting that we want to restore the old solution.
- 2013-06-10 Bear Travis <betravis@adobe.com>
- [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
- https://bugs.webkit.org/show_bug.cgi?id=117162
- Reviewed by Alexandru Chiculita.
- Adding the WebCore/rendering/shapes directory to the include list.
- * DumpRenderTree/efl/CMakeLists.txt:
- 2013-06-09 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed test correction: Prevent DumpRenderTree crashes
- * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
- (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
- happends in some of the 'accessibility' test cases.
- 2013-06-08 peavo@outlook.com <peavo@outlook.com>
- [WinCairo] TestWebKitAPI fails to link.
- https://bugs.webkit.org/show_bug.cgi?id=117345
- Reviewed by Brent Fulgham.
- Need to link with WTF.lib.
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
- 2013-06-07 Roger Fong <roger_fong@apple.com>
- Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
- Rubberstamped by Ryousuke Niwa.
- * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- (RunTest.test_build_check):
- 2013-06-07 Hugo Parente Lima <hugo.lima@openbossa.org>
- [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
- https://bugs.webkit.org/show_bug.cgi?id=117315
- Reviewed by Benjamin Poulain.
- Qt doesn't use the default values specified on FeatureList since r44681,
- this patch just remove a bit of noise.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-06-07 Jungsik Tae <davidtlay88@gmail.com>
- [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
- https://bugs.webkit.org/show_bug.cgi?id=115890
- Reviewed by Christophe Dumez.
- When user clicks HTML5 input type color,
- color selector window is created on browser object by using elm_colorchooser_add().
- It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
- The evas_object_color_set() sets a color value returning to browser.
- * MiniBrowser/efl/main.c:
- (window_free): When we delete parent window, deleting the colorpicker object.
- (on_color_changed): Change color of rectangle to show color selected by user.
- (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
- (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
- (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
- (on_color_picker_dismiss): Delete colorpicker object.
- (on_color_picker_request): Create colorpicker window object.
- (window_create):
- 2013-06-06 Yuki Sekiguchi <yuki.sekiguchi@access-company.com>
- svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
- https://bugs.webkit.org/show_bug.cgi?id=111066
- Reviewed by Daniel Bates.
- Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
- ParseGitDiffHeader() should support the path which line has space characters.
- To support this, I changed parsing algorithm like the following:
- - When the diff have prefix, we consider next characters after "b/" as part of a file path.
- - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
- We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
- If the path has a tab, the patch(1) command thinks file path is characters before the tab.
- I added a dummy tab and revision when we convert git diff to svn diff.
- * Scripts/VCSUtils.pm:
- (parseGitDiffHeader):
- * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
- * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
- * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
- - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
- 2013-06-06 Simon Fraser <simon.fraser@apple.com>
- Add a menu item to MiniBrowser to toggle Transparent windows
- https://bugs.webkit.org/show_bug.cgi?id=117316
- Reviewed by Anders Carlsson.
-
- Add a menu item that toggles "Transparent window" mode, which is exposed
- via private WebKit API and WebKit2 API.
- * MiniBrowser/mac/BrowserWindowController.h:
- * MiniBrowser/mac/MainMenu.xib:
- * MiniBrowser/mac/MiniBrowser_Prefix.pch:
- * MiniBrowser/mac/WK1BrowserWindowController.m:
- (-[WK1BrowserWindowController validateMenuItem:]):
- (-[WK1BrowserWindowController toggleTransparentWindow:]):
- * MiniBrowser/mac/WK2BrowserWindowController.m:
- (-[WK2BrowserWindowController validateMenuItem:]):
- (-[WK2BrowserWindowController toggleTransparentWindow:]):
- (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
- when testing.
- 2013-06-06 Roger Fong <roger_fong@apple.com>
- Stop copying AAS binaries into build folder.
- https://bugs.webkit.org/show_bug.cgi?id=117319.
- Rubberstamped by Darin Adler.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
- 2013-06-06 Hugo Parente Lima <hugo.lima@openbossa.org>
- Aligning build-webkit command line switch names to the WebKit flag names
- https://bugs.webkit.org/show_bug.cgi?id=117254
- Reviewed by Laszlo Gombos.
- * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
- 2013-06-06 Chris Fleizach <cfleizach@apple.com>
- AX: iOS ignores ARIA progressbar elements
- https://bugs.webkit.org/show_bug.cgi?id=116727
- Reviewed by David Kilzer.
- * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
- (AccessibilityUIElement::minValue):
- (AccessibilityUIElement::maxValue):
- 2013-06-06 peavo@outlook.com <peavo@outlook.com>
- [WinCairo] Fix build-webkit to build WinCairo under VS2010.
- https://bugs.webkit.org/show_bug.cgi?id=117255
- Reviewed by Daniel Bates.
- Need to update configuration names according to solution file.
- * Scripts/webkitdirs.pm:
- (determineConfiguration):
- (determinePassedConfiguration):
- 2013-06-06 Ryosuke Niwa <rniwa@webkit.org>
- Remove run-performance-tests
- https://bugs.webkit.org/show_bug.cgi?id=117285
- Reviewed by Andreas Kling.
-
- Remove the script since it's not used anywhere.
- * BuildSlaveSupport/run-performance-tests: Removed.
- 2013-06-05 Bear Travis <betravis@adobe.com>
- [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
- https://bugs.webkit.org/show_bug.cgi?id=117172
- Reviewed by Alexandru Chiculita.
- Adding the CSS_SHAPES compile flag.
- * Scripts/webkitperl/FeatureList.pm:
- * qmake/mkspecs/features/features.pri:
- 2013-06-05 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
- to UNIX-style they will not execute properly.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
- 2013-06-05 Roger Fong <roger_fong@apple.com>
- Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- (RunWebKitTests.start):
- 2013-06-05 Brent Fulgham <bfulgham@apple.com>
- [Windows] Switch to NRWT
- https://bugs.webkit.org/show_bug.cgi?id=117200
- Reviewed by Anders Carlsson.
- * Scripts/run-webkit-tests:
- (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
- 2013-06-05 Dominik Röttsches <dominik.rottsches@intel.com>
- Unreviewed name fix after r150662
- My firstname got duplicated when fixing bug 116737.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-06-05 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
- Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
- https://bugs.webkit.org/show_bug.cgi?id=117244
- Reviewed by Daniel Bates.
- Fixed a regression introduced by r151196: not only does webkit.org
- still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
- infrastructure used by ports such as GTK+ and EFL also use on it for
- things such as jhbuild.
- While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
- both environment variables.
- * Scripts/webkitdirs.pm:
- (determineBaseProductDir):
- 2013-06-05 Wojciech Bielawski <w.bielawski@samsung.com>
- [GTK] Forwarding headers not generated for incremental build
- https://bugs.webkit.org/show_bug.cgi?id=117198
- Reviewed by Carlos Garcia Campos.
- * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
- 2013-06-05 Andras Becsi <andras.becsi@digia.com>
- [Qt][WK2] Fix layout testing with Qt 5.1
- https://bugs.webkit.org/show_bug.cgi?id=117203
- Reviewed by Jocelyn Turcotte.
- With Qt 5.1 synchronous requests via QNetworkAccessManager do not
- go into loading state but directly call handler functions for
- finished state instead of relying on a connection.
- Our wrapper QQuickView uses a data URI scheme to create the root
- item for testing which results in a synchronous request when loading
- the QML data, therefore the state of the QQuickWindow immediately
- becomes Ready.
- Since the final initialization of the root item depended on the
- emission of QQuickView::statusChanged(QQuickView::Ready) we ended
- up with a partially initialized wrapper window, thus most of our
- layout tests were failing.
- For compatibility with pre-5.1 Qt versions keep the old behaviour
- in case the WrapperWindow is not ready in the constructor yet.
- * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
- (WTR::WrapperWindow::WrapperWindow):
- * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
- (TestWebKitAPI::WrapperWindow::WrapperWindow):
- 2013-06-05 Dariusz Frankiewicz <d.frankiewic@samsung.com>
- Bad value in tests counter at new-run-webkit-tests
- in --debug-rwt-logging mode
- https://bugs.webkit.org/show_bug.cgi?id=116858
- Reviewed by Dirk Pranke.
- Fix by moving counter incrementation, from after printing line,
- to before printing. Also changed variable name.
- * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
- (LayoutTestRunner.run_tests):
- * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
- (FakePrinter):
- * Scripts/webkitpy/layout_tests/views/printing.py:
- (Printer.__init__):
- (Printer._test_status_line):
- (Printer.print_started_test):
- (Printer.print_finished_test):
- * Scripts/webkitpy/test/printer.py:
- (Printer.__init__):
- (Printer.print_finished_test):
- (Printer._test_line):
- (Printer.print_result):
- 2013-06-05 Zan Dobersek <zdobersek@igalia.com>
- Move MemoryInfo under window.internals
- https://bugs.webkit.org/show_bug.cgi?id=117197
- Reviewed by Ryosuke Niwa.
- * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
- the Automake build
- * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
- testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
- 2013-06-03 Roger Fong <roger_fong@apple.com>
- Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
- <rdar://problem/14042021>.
- Reviewed by Brent Fulgham.
- * Scripts/build-api-tests:
- * Scripts/build-dumprendertree:
- * Scripts/build-webkit:
- * Scripts/update-webkit-dependency:
- * Scripts/update-webkit-support-libs:
- * Scripts/webkitdirs.pm:
- (determineBaseProductDir):
- (setupAppleWinEnv):
- (setupCygwinEnv):
- 2013-06-04 Brent Fulgham <bfulgham@apple.com>
- [Windows] NRWT is not putting crash logs in proper place (corrections)
- https://bugs.webkit.org/show_bug.cgi?id=117212
- Reviewed by Dirk Pranke.
- * Scripts/webkitpy/common/system/crashlogs.py:
- (CrashLogs.__init__): Accept a result directory argument in constructor.
- (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
- (CrashLogs._find_newest_log_win): No longer use 'port' argument.
- * Scripts/webkitpy/common/system/crashlogs_unittest.py:
- (CrashLogsTest.test_find_log_win): Simplify test.
- * Scripts/webkitpy/common/system/executive.py:
- (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
- * Scripts/webkitpy/port/win.py:
- (WinPort._get_crash_log): No longer require 'port' argument.
- 2013-06-04 Ryosuke Niwa <rniwa@webkit.org>
- Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2013-06-04 Greg Hughes <ghughes@apple.com>
- Add "VisibleOnly" key to search predicate
- https://bugs.webkit.org/show_bug.cgi?id=115491
- Reviewed by Chris Fleizach.
- Added support for accessibility clients to use the search predicate to find only visible elements
- * DumpRenderTree/AccessibilityUIElement.cpp:
- (uiElementForSearchPredicateCallback):
- * DumpRenderTree/AccessibilityUIElement.h:
- (AccessibilityUIElement):
- * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
- (AccessibilityUIElement::uiElementForSearchPredicate):
- * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- (AccessibilityUIElement::uiElementForSearchPredicate):
- * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- (AccessibilityUIElement):
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- 2013-06-04 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix. The last check-in lost CR/LF endings on the batch file,
- causing build failure.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
- DOS-style CR/LF endings.
- 2013-06-04 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed test correction.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
- QuartzCore dll's, which are needed by TestWebKitAPI.
- * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
- with VS2010 will run when linked against VS2005 support libraries.
- 2013-06-04 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Automatically generate WorkerContext constructor attributes
- https://bugs.webkit.org/show_bug.cgi?id=117183
- Reviewed by Kentaro Hara.
- Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
- tests.
- * Scripts/webkitpy/bindings/main.py:
- (BindingsTests.generate_supplemental_dependency):
- (BindingsTests.main):
- 2013-06-04 Ryuan Choi <ryuan.choi@samsung.com>
- [EFL] File dialog of MiniBrowser have broken background.
- https://bugs.webkit.org/show_bug.cgi?id=117189
- Reviewed by Christophe Dumez.
- * MiniBrowser/efl/main.c:
- (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
- 2013-06-04 Christophe Dumez <ch.dumez@sisa.samsung.com>
- [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
- https://bugs.webkit.org/show_bug.cgi?id=117184
- Reviewed by Gyuyoung Kim.
- Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
- that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- (WTR::AccessibilityUIElement::mathPostscriptsDescription):
- (WTR::AccessibilityUIElement::mathPrescriptsDescription):
- 2013-06-03 Simon Pena <simon.pena@samsung.com>
- validate-committer-lists script is now outdated and does not work
- https://bugs.webkit.org/show_bug.cgi?id=115860
- Reviewed by Brent Fulgham.
- The script validate-committer-lists was outdated, still using the deprecated log
- system and having the old addresses for the mailing lists, as well as still referring
- to committers.py, after this was renamed to contributors.json. This patch fixes that
- so it can be used again.
- * Scripts/validate-committer-lists: Replace calls to log and error with the
- new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
- to committers.py, which should be contributors.json.
- (CommitterListFromMailingList):
- (CommitterListFromMailingList.check_for_emails_missing_from_list):
- (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
- (CommitterListFromGit._fill_in_emails_for_old_logins):
- (CommitterListFromGit.print_committers_missing_from_committer_list):
- 2013-06-03 Dirk Pranke <dpranke@chromium.org>
- add a script to dump the tests run most recently by a given worker
- https://bugs.webkit.org/show_bug.cgi?id=116571
- Reviewed by Brent Fulgham.
- The tests_run*.txt results files in layout-test-results/ were removed
- in r137356, in favor of collecting more data about how the tests were
- run and compressing it and storing it in stats.json. However, it was
- nice to just be able to look at a flat text file.
- This script will extract the tests run by a given worker from a
- given stats.json file, and should help to address that.
- * Scripts/dump-webkit-tests-run: Added.
- (main):
- (convert_trie_to_flat_paths):
- 2013-06-03 Brent Fulgham <bfulgham@apple.com>
- [Windows] NRWT is not putting crash logs in proper place
- https://bugs.webkit.org/show_bug.cgi?id=117098
- Reviewed by Ryosuke Niwa.
- Provide windows-specific overloads for various Port features needed to create and capture
- crash logs. This change makes it possible to view crash logs (when created) as part of the
- summary report at the end of the NRWT run.
- * Scripts/webkitpy/common/system/crashlogs.py:
- (CrashLogs.find_newest_log): Add support for win32 crash logs
- (CrashLogs._find_newest_log_win): Added
- * Scripts/webkitpy/common/system/crashlogs_unittest.py:
- (make_mock_crash_report_win): Added
- (CrashLogsTest.test_find_log_win): Added.
- * Scripts/webkitpy/common/system/executive.py:
- (Executive.running_pids): Add support for Cygwin win32 crash logs
- * Scripts/webkitpy/common/system/executive_mock.py:
- (MockExecutive.__init__):
- * Scripts/webkitpy/common/system/filesystem_unittest.py:
- (RealFileSystemTest.test_read_and_write_file): Add tests for
- malformed ascii/utf8 handling (i.e., Windows log files)
- * Scripts/webkitpy/port/base.py:
- (Port.find_system_pid): Added
- * Scripts/webkitpy/port/server_process.py:
- (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
- * Scripts/webkitpy/port/win.py:
- (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
- for user to hit enter.
- (WinPort._get_crash_log): Added
- (WinPort.look_for_new_crash_logs): Added
- (WinPort.find_system_pid): Added
- * Scripts/webkitpy/port/win_unittest.py:
- (WinPortTest.test_get_crash_log): Added test
- 2013-06-03 Eduardo Lima Mitev <elima@igalia.com>
- [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
- https://bugs.webkit.org/show_bug.cgi?id=116726
- Reviewed by Gyuyoung Kim.
- Current version of ATK in efl-ews environment is 2.4.0 and is taken from
- the platform (it is not listed in jhbuild moduleset). That version is
- old-ish and contain deprecated symbols and missing API, that are blocking
- patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
- moduleset, which is the same version the gtk port uses.
- See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
- why this is needed.
- * efl/jhbuild.modules: Adds ATK module as dependency
- 2013-06-03 Erik van Pienbroek <epienbro@fedoraproject.org>
- [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
- https://bugs.webkit.org/show_bug.cgi?id=117168
- Reviewed by Martin Robinson.
- The tool generate-gtkdoc internally calls pkg-config.
- When cross-compiling it shouldn't use pkg-config, but
- it should use the pkg-config which was detected by
- the ./configure script (for example this can be
- i686-w64-mingw32-pkg-config when cross-compiling)
- * GNUmakefile.am:
- * gtk/gtkdoc.py:
- (PkgConfigGTKDoc.__init__):
- 2013-06-03 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix.
- * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
- allow VS2010 builds to use VS2005 runtime libraries as needed.
- 2013-06-03 Roger Fong <roger_fong@apple.com>
- Nuke VS2005 files from the tree.
- <rdar://problem/14042021>.
- Rubberstamped by Brent Fulgham.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
- * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
- * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
- * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
- * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
- * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
- * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/ImageDiff.vcproj: Removed.
- * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
- * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
- * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
- * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
- * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
- * Scripts/pdevenv: Removed.
- * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
- * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
- * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
- * WebKitLauncherWin: Removed.
- * WebKitLauncherWin/Resource.h: Removed.
- * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
- * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
- * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
- * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
- * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
- * WebKitLauncherWin/webkit.ico: Removed.
- * WinLauncher/WinLauncher.ico: Removed.
- * WinLauncher/WinLauncher.rc: Removed.
- * WinLauncher/WinLauncher.vcproj: Removed.
- * WinLauncher/WinLauncherCommon.vsprops: Removed.
- * WinLauncher/WinLauncherDebug.vsprops: Removed.
- * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
- * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
- * WinLauncher/WinLauncherLauncher.rc: Removed.
- * WinLauncher/WinLauncherLauncher.vcproj: Removed.
- * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
- * WinLauncher/WinLauncherLauncherResource.h: Removed.
- * WinLauncher/WinLauncherPostBuild.cmd: Removed.
- * WinLauncher/WinLauncherPreBuild.cmd: Removed.
- * WinLauncher/WinLauncherProduction.vsprops: Removed.
- * WinLauncher/WinLauncherRelease.vsprops: Removed.
- * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
- * WinLauncher/small.ico: Removed.
- * record-memory-win: Removed.
- * record-memory-win/main.cpp: Removed.
- * record-memory-win/record-memory-win-common.vsprops: Removed.
- * record-memory-win/record-memory-win.vcproj: Removed.
- * record-memory-win/record-memory-winDebug.vsprops: Removed.
- * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
- * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
- * record-memory-win/record-memory-winProduction.vsprops: Removed.
- * record-memory-win/record-memory-winRelease.vsprops: Removed.
- * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
- 2013-06-03 Chris Fleizach <cfleizach@apple.com>
- AX: MathML multiscripts not exposed in Accessibility
- https://bugs.webkit.org/show_bug.cgi?id=115069
- Reviewed by Tim Horton.
- Add methods to help output components of math multiscripts for accessibility.
- * DumpRenderTree/AccessibilityUIElement.cpp:
- (mathPostscriptsDescriptionCallback):
- (mathPrescriptsDescriptionCallback):
- (AccessibilityUIElement::getJSClass):
- * DumpRenderTree/AccessibilityUIElement.h:
- (AccessibilityUIElement):
- * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- (convertMathMultiscriptPairsToString):
- (AccessibilityUIElement::mathPostscriptsDescription):
- (AccessibilityUIElement::mathPrescriptsDescription):
- * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- (WTR::AccessibilityUIElement::mathPostscriptsDescription):
- (WTR::AccessibilityUIElement::mathPrescriptsDescription):
- * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- (AccessibilityUIElement):
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- (WTR::_convertMathMultiscriptPairsToString):
- (WTR::AccessibilityUIElement::mathPostscriptsDescription):
- (WTR::AccessibilityUIElement::mathPrescriptsDescription):
- 2013-06-03 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r151109.
- http://trac.webkit.org/changeset/151109
- https://bugs.webkit.org/show_bug.cgi?id=117145
- "Plugins in WK2 aren't implemented yet." (Requested by
- jturcotte on #webkit).
- * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- * qmake/mkspecs/features/features.prf:
- * qmake/mkspecs/features/unix/default_pre.prf:
- 2013-05-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
- [Qt] Re-enable plugins on Mac.
- https://bugs.webkit.org/show_bug.cgi?id=116622
- Reviewed by Tor Arne Vestbø.
- Plugins on Mac were only enabled if !embedded but the later was set if
- QPA is enabled, which is the default since Qt 5.0.
- Remove references to 'embedded' and fix various build issues,
- PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
- months.
- * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- * qmake/mkspecs/features/features.prf:
- * qmake/mkspecs/features/unix/default_pre.prf:
- 2013-06-03 Krzysztof Czech <k.czech@samsung.com>
- [GTK][WK2] accessibility/placeholder.html is failing
- https://bugs.webkit.org/show_bug.cgi?id=106344
- Reviewed by Gyuyoung Kim.
- Adds support for retrieving attribute value.
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- (WTR::coreAttributeToAtkAttribute):
- (WTR::AccessibilityUIElement::stringAttributeValue):
- 2013-06-01 Tim Horton <timothy_horton@apple.com>
- Add a preferred email address and "expertise" for me.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Make windows test bots search in the correct directory for build output.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- (RunWebKitTests.start):
- * Scripts/webkitdirs.pm:
- (determineConfigurationProductDir):
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Windows build fix...
- * BuildSlaveSupport/built-product-archive:
- (createZip):
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Windows build fix. One more time!
- * BuildSlaveSupport/built-product-archive:
- (archiveBuiltProduct):
- (extractBuiltProduct):
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Windows build fix.
- * Scripts/build-webkit:
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Windows build fix.
- * Scripts/build-webkit:
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Make build-webkit output VCExpress 2010 build logs properly.
- https://bugs.webkit.org/show_bug.cgi?id=117096
- Reviewed by Brent Fulgham.
- Make it so that output from VCExpress is always printed to console.
- Get build log results from AssembleBuildLogs project output.
- We don't need those old VCExpress scripts anymore either.
- * Scripts/build-webkit:
- * Scripts/print-msvc-project-dependencies: Removed.
- * Scripts/print-vse-failure-logs: Removed.
- 2013-05-31 Brent Fulgham <bfulgham@apple.com>
- [Windows] Use WinLauncher to display LayoutTest results
- https://bugs.webkit.org/show_bug.cgi?id=117085
- Reviewed by Oliver Hunt.
- * Scripts/webkitdirs.pm:
- (runSafari): Use WinLauncher to display content
- * WinLauncher/WinLauncher.cpp:
- (dllLauncherEntryPoint): Check for URL argument.
- 2013-05-31 Roger Fong <roger_fong@apple.com>
- Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
- * win/AssembleBuildLogs/AssembleLogs.cmd:
- 2013-05-31 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r151022.
- http://trac.webkit.org/changeset/151022
- https://bugs.webkit.org/show_bug.cgi?id=117084
- Also breaks build by introducing duplicate symbols (Requested
- by bfulgham on #webkit).
- * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
- 2013-05-31 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix to NRWT
- * Scripts/webkitpy/port/win.py:
- (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
- 2013-05-31 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix after r151012
- * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
- WTF library to support SHA tests
- 2013-05-31 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build fix after r151012
- * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
- snprintf definition for Windows.
- 2013-05-31 Zan Dobersek <zdobersek@igalia.com>
- Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
- https://bugs.webkit.org/show_bug.cgi?id=116445
- Reviewed by Benjamin Poulain.
- Add the MD5 and SHA1 unit tests that were previously located inside WTF.
- * TestWebKitAPI/CMakeLists.txt:
- * TestWebKitAPI/GNUmakefile.am:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::expectMD5):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::expectSHA1):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WTF/WTF.pro:
- * TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 2013-05-30 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed build correction.
- * Scripts/webkitpy/port/win.py:
- (WinPort.create_debugger_command_file): The directory needs to be
- a string, not a temporary directory object.
- 2013-05-30 Brent Fulgham <bfulgham@apple.com>
- [Windows] NRWT doesn't save crash logs on Apple's Windows port.
- https://bugs.webkit.org/show_bug.cgi?id=76935
- Reviewed by Ryosuke Niwa.
- Extend the WinPort class with commands to set and clean up various registry
- values needed to invoke the correct debugger to get crash files.
- * Scripts/webkitpy/port/win.py:
- (WinPort): Added global caches for registry keys and settings
- (WinPort._ntsd_location): Added
- (WinPort.create_debugger_command_file): Added
- (WinPort.read_registry_string): Added
- (WinPort.write_registry_string): Added
- (WinPort.setup_crash_log_saving): Added
- (WinPort.restore_crash_log_saving): Added
- (WinPort.setup_test_run): Added overload to add registry settings.
- (WinPort.clean_up_test_run): Added overload to clean up registry settings.
- 2013-05-30 Roger Fong <roger_fong@apple.com>
- Get rid of JavaScript exports file on AppleWin port.
- https://bugs.webkit.org/show_bug.cgi?id=117050.
- Reviewed by Darin Adler.
- Start linking in WTF.lib now that it's a shared library.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
- 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
- Web Inspector: tests in PerformanceTests/inspector/ are timing out
- https://bugs.webkit.org/show_bug.cgi?id=77024
- Reviewed by Andreas Kling.
- Remove inspector performance tests since they have been disabled for ages,
- and they don't use the standard parser-style performance output.
- It's adding a lot of code complexity to our infrastructure.
- * Scripts/webkitpy/performance_tests/perftest.py:
- (SingleProcessPerfTest.__init__):
- (PerfTestFactory):
- * Scripts/webkitpy/performance_tests/perftest_unittest.py:
- (TestPerfTestFactory.test_regular_test):
- * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
- (TestDriver.run_test):
- (MainTest.run_test):
- (MainTest._tests_for_runner):
- (MainTest.test_run_test_set_kills_drt_per_run):
- (MainTest._test_run_with_json_output):
- (MainTest):
- (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
- 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
- Remove requires_http_server as Chromium Android was the only port that needed this
- https://bugs.webkit.org/show_bug.cgi?id=117018
- Reviewed by Benjamin Poulain.
- Removed the unused code that existed for Chromium Android port.
- * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
- (LayoutTestRunner.run_tests):
- (LayoutTestRunner._handle_finished_test_list):
- * Scripts/webkitpy/layout_tests/controllers/manager.py:
- (Manager._run_tests):
- * Scripts/webkitpy/performance_tests/perftestsrunner.py:
- (PerfTestsRunner._collect_tests):
- (PerfTestsRunner.run):
- * Scripts/webkitpy/port/base.py:
- (Port.to.start_helper):
- * Scripts/webkitpy/port/base_unittest.py:
- (PortTest.test_build_path):
- 2013-05-29 Ruth Fong <ruth_fong@apple.com>
- prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
- https://bugs.webkit.org/show_bug.cgi?id=113221
- Reviewed by Ryosuke Niwa.
- Teach prepare-Changelog to not list the names of modified namespaces,
- classes, or structs in C++ files. Thus, if a change is made
- within a namespace/class/struct yet outside a function, it will
- not be reflected in the ChangeLog entry.
- See https://bugs.webkit.org/show_bug.cgi?id=113221#c8
- for more details on how ChangeLog entries are affected.
- * Scripts/prepare-ChangeLog:
- (get_function_line_ranges_for_cpp):
- (delete_namespaces_from_ranges_for_cpp): Added.
- (is_function_in_namespace): Added.
- * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
- to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
- 2013-05-29 Praveen R Jadhav <praveen.j@samsung.com>
- Cleanup AudioSourceNode.idl from WebKit build.
- https://bugs.webkit.org/show_bug.cgi?id=116905.
- Reviewed by Darin Adler.
- AudioSourceNode.idl is not part of WebAudio Specifications anymore.
- AudioNode is inherited directly in all the audio source nodes.
- * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
- 2013-05-29 Andrew Lo <anlo@rim.com>
- Add Andrew Lo to contributors.json
- https://bugs.webkit.org/show_bug.cgi?id=116981
- Reviewed by Rob Buis.
- Adding Andrew Lo to contributors.json.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-29 Adenilson Cavalcanti <cavalcantii@gmail.com>
- Unreviewed. Adding myself as a committer.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-29 Marcelo Lira <marcelo.lira@openbossa.org>
- [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
- https://bugs.webkit.org/show_bug.cgi?id=116683
- Reviewed by Noam Rosenthal.
- A coordinates conversion test for WKViewUserViewportToContents was
- added to WebKit2 API tests.
- * TestWebKitAPI/PlatformEfl.cmake:
- * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::TEST):
- 2013-05-29 Yong Li <yong.li.webkit@outlook.com>
- Unreviewed. Update my info.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-29 Dongseong Hwang <dongseong.hwang@intel.com>
- Unreviewed. Add myself as committer in contributors.json.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-29 Carlos Garcia Campos <cgarcia@igalia.com>
- Unreviewed. Fix make distcheck.
- * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
- DISTCLEANFILES.
- 2013-05-29 Mary Wu <mawu@blackberry.com>
- Unreviewed: update my email address in contributors.json.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-29 Kalyan Kondapally <kalyan.kondapally@intel.com>
- Unreviewed: Adding myself to committers list.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-28 Arpita Bahuguna <a.bah@samsung.com>
- Unreviewed: Adding myself to committers list.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-28 Brent Fulgham <bfulgham@webkit.org>
- [Windows] Many CSS2.1 tests fail under NRWT.
- https://bugs.webkit.org/show_bug.cgi?id=75707
- Reviewed by Darin Adler.
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (findFontFallback): Added
- (addFontFallbackIfPresent): Added
- (removeFontFallbackIfPresent): Added
- (runTest): Set up/remove font fallbacks when needed.
- 2013-05-28 Brent Fulgham <bfulgham@apple.com>
- [Windows] NRWT reports failure for 'mac' test cases.
- https://bugs.webkit.org/show_bug.cgi?id=116698
- Reviewed by Ryosuke Niwa.
- The Windows port falls back to the Mac port for many test results,
- and so adds the mac and mac-wk2 to its set of fallbacks.
- Unfortunately, NRWT thinks that this means that tests in these
- folders should be executed, resulting in many failures on
- Windows.
- This change overloads the '_tests_for_other_platforms' method
- to return a subset of the result fallback list so that we do
- not attempt to execute Mac tests on Windows.
- * Scripts/webkitpy/port/base.py:
- (Port.test_search_path): Added. Defaults to just calling the
- baseline_search_path method, which is how most ports behave.
- (Port._test_for_other_platforms): Modified to call the new
- test_search_path method.
- * Scripts/webkitpy/port/win.py:
- (WinPort.test_search_path): Added custom overload. Strips
- out mac-specific test paths.
- 2013-05-28 Martin Robinson <mrobinson@igalia.com>
- Fix GTK+ CMake build
- * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
- library target is simply "WebKit2."
- 2013-05-28 Zan Dobersek <zdobersek@igalia.com>
- [webkitpy] Explicitly specify the reference file extensions
- https://bugs.webkit.org/show_bug.cgi?id=116333
- Reviewed by Benjamin Poulain.
- Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
- between valid reference files required by reftests and text baselines that have the same extension as
- potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
- that were until this change recognized as reference files).
- Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
- * Scripts/webkitpy/port/base.py:
- (Port.reference_files): Iterate through the _supported_reference_extensions set.
- (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
- _supported_reference_extensions set, containing the extensions allowed for reference files.
- (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
- (Port._has_supported_extension): Use _supported_test_extensions.
- * Scripts/webkitpy/port/base_unittest.py:
- (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
- Port.is_reference_html_file method.
- 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
- Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
- * Scripts/webkitpy/tool/commands/newcommitbot.py:
- (NewCommitBot.next_work_item):
- 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
- WKR and webkitbot build fixes.
- * Scripts/webkitpy/tool/bot/irc_command.py:
- (RollChromiumDEPS.execute):
- * Scripts/webkitpy/tool/commands/newcommitbot.py:
- (NewCommitBot.next_work_item):
- 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
- roll-chromium-deps doesn't repeat the full name.
- Rubber-stamped by Andreas Kling.
- * Scripts/webkitpy/tool/bot/irc_command.py:
- (RollChromiumDEPS.execute):
- 2013-05-25 Ryosuke Niwa <rniwa@webkit.org>
- Revert another erroneous change.
- * Scripts/webkitpy/tool/commands/newcommitbot.py:
- (NewCommitBot.next_work_item):
- 2013-05-25 Ryosuke Niwa <rniwa@webkit.org>
- Revert an erroneous change.
- * Scripts/webkitpy/tool/commands/sheriffbot.py:
- (SheriffBot):
- 2013-05-25 Ryosuke Niwa <rniwa@webkit.org>
- Some build fixes for WKR and webkitbot.
- * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
- (IRCBotTest.test_help):
- * Scripts/webkitpy/tool/commands/newcommitbot.py:
- (Agent):
- (Agent.__init__):
- (Agent.name):
- (NewCommitBot):
- (NewCommitBot.begin_work_queue):
- (NewCommitBot.next_work_item):
- * Scripts/webkitpy/tool/commands/sheriffbot.py:
- (SheriffBot):
- 2013-05-25 Ryosuke Niwa <rniwa@webkit.org>
- Teach webkitbot and WKR how to respond to yt?
- https://bugs.webkit.org/show_bug.cgi?id=116775
- Reviewed by Andreas Kling.
- * Scripts/webkitpy/tool/bot/irc_command.py:
- (Hi): Fixed the usage string.
- (Hi.execute): Made it more generic so that it works in WKR.
- (YouThere): Added.
- (YouThere.execute): Added.
- * Scripts/webkitpy/tool/commands/newcommitbot.py:
- 2013-05-25 Simon Fraser <simon.fraser@apple.com>
- Try to fix the EFL build.
-
- * DumpRenderTree/efl/TestRunnerEfl.cpp:
- (TestRunner::setPageVisibility):
- 2013-05-25 Simon Fraser <simon.fraser@apple.com>
- Unprefix Page Visibility API
- https://bugs.webkit.org/show_bug.cgi?id=102340
- Reviewed by Tim Horton.
-
- Rename "preview" state to "unloaded" state, and adjust the tests
- to test for it.
- * DumpRenderTree/mac/TestRunnerMac.mm:
- (TestRunner::setPageVisibility):
- * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
- (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
- (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
- (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
- (TestWebKitAPI::didRunStep4InStateUnloaded):
- * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
- * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
- (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- (WTR::TestRunner::setPageVisibility):
- 2013-05-24 Brent Fulgham <bfulgham@apple.com>
- Unreviewed build fix. Don't use new NRWT logic needed
- by Windows yet. Activate (and fix test) when we cut over.
- * Scripts/webkitpy/port/driver.py:
- (Driver._setup_environ_for_driver):
- (Driver._start):
- 2013-05-24 Brent Fulgham <bfulgham@apple.com>
- [Windows] Expose database storage and cache locations via preferences.
- https://bugs.webkit.org/show_bug.cgi?id=116729
- Reviewed by Tim Horton.
- Update DumpRenderTree to use CFPreferences to control where WebKit
- stores its local databases, URL caches, etc.
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (libraryPathForDumpRenderTree): Added.
- (dllLauncherEntryPoint): Set up DRT-specific cache locations.
- * Scripts/webkitpy/port/base.py:
- (Port._driver_tempdir): Added (to allow port-specific overload).
- (Port._driver_tempdir_for_environment): Ditto
- * Scripts/webkitpy/port/driver.py:
- (Driver._setup_environ_for_driver): Use new overload to set
- environment variable.
- (Driver._start): Use new overload for temp directory location.
- * Scripts/webkitpy/port/win.py:
- (WinPort._driver_tempdir_for_environment): New overload to supply
- Windows path to DumpRenderTree environment (while still using
- cygwin paths for internal operations.
- 2013-05-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Remove custom code for webkitAudioContext global constructor getter
- https://bugs.webkit.org/show_bug.cgi?id=116530
- Reviewed by Geoffrey Garen.
- Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
- WebAudio feature instead of public ewk_view API since that API was
- removed.
- * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
- (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- * DumpRenderTree/efl/TestRunnerEfl.cpp:
- (TestRunner::overridePreference):
- 2013-05-24 Bem Jones-Bey <bjonesbe@adobe.com>
- Make team.html have each contributor's area of expertise
- https://bugs.webkit.org/show_bug.cgi?id=116737
- Reviewed by Benjamin Poulain.
- * Scripts/webkitpy/common/config/contributors.json:
- Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
-
- Changed formatting of the file because the lines are getting way to
- long, and I generated this, so it's easier if the formatting of the
- file is regular.
- 2013-05-24 Simon Pena <simon.pena@samsung.com>
- Update WTF::Vector pretty printers
- https://bugs.webkit.org/show_bug.cgi?id=116719
- Reviewed by Anders Carlsson.
- After r148891, WTF::Vector pretty printers were left outdated, as
- the WTF::Vector was made to extend a VectorBuffer, instead of keeping
- one as a member. This patch updates the pretty printers so they work
- again.
- * gdb/webkit.py:
- (WTFVectorPrinter.children):
- (WTFVectorPrinter.to_string):
- 2013-05-24 Steve Falkenburg <sfalken@apple.com>
- Update prepareConsistentTestingEnvironment to use a non-deprecated API.
- https://bugs.webkit.org/show_bug.cgi?id=116710
- Reviewed by Mark Rowe.
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
- 2013-05-23 Lauro Neto <lauro.neto@openbossa.org>
- Add missing dependencies to deps script.
- [GTK] Missing packages in install-dependencies script.
- https://bugs.webkit.org/show_bug.cgi?id=116632
- Reviewed by Martin Robinson.
- * gtk/install-dependencies:
- 2013-05-23 Brent Fulgham <bfulgham@apple.com>
- [Windows] Unreviewed change for NRWT support.
- * Scripts/webkitpy/port/win.py:
- (WinPort.default_child_processes): Added a default implementation
- that limits NRWT to a single instance.
- 2013-05-23 Brent Fulgham <bfulgham@apple.com>
- Remove meaningless "test_uses_apache" from Python test cases.
- https://bugs.webkit.org/show_bug.cgi?id=38756
- Reviewed by Ryosuke Niwa.
- * Scripts/webkitpy/port/port_testcase.py:
- (PortTestCase.test_driver_cmd_line): Remove the meaningless
- "test_uses_apache" test case from the Python test infrastructure.
- It was hard-coded to true, even though not all ports use
- Apache.
- 2013-05-23 Brent Fulgham <bfulgham@webkit.org>
- [Windows] Update new-run-webkit-tests for Windows port.
- https://bugs.webkit.org/show_bug.cgi?id=38756
- Reviewed by Ryosuke Niwa.
- * Scripts/new-run-webkit-httpd:
- (run): Switch from 'chromium' to 'win'
- * Scripts/webkitpy/port/win.py:
- (WinPort): Add support methods for lighttpd server.
- (WinPort._uses_apache):
- (WinPort._path_to_lighttpd):
- (WinPort._path_to_lighttpd_modules):
- (WinPort._path_to_lighttpd_php):
- 2013-05-23 Patrick Gansterer <paroga@webkit.org>
- Make default bug links in buildbot clickable
- https://bugs.webkit.org/show_bug.cgi?id=116673
- Reviewed by Ryosuke Niwa.
- Use changecommentlink of html.WebStatus to make the links clickable.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2013-05-22 Ryosuke Niwa <rniwa@webkit.org>
- REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
- https://bugs.webkit.org/show_bug.cgi?id=116595
- Temporarily skip this test.
- * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
- (TestWebKitAPI::TEST):
- 2013-05-22 Alex Christensen <achristensen@apple.com>
- Unreviewed. Added myself to contributors.json.
- * Scripts/webkitpy/common/config/contributors.json:
- Added myself.
- 2013-05-22 Michał Pakuła vel Rutka <m.pakula@samsung.com>
- [EFL][WK2] Add sub menus to MiniBrowser
- https://bugs.webkit.org/show_bug.cgi?id=114728
- Reviewed by Christophe Dumez.
- Elementary Ctxpopup widget API does not provide support for submenu item.
- To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
- Elementary Menu widget.
- * MiniBrowser/efl/main.c:
- (_Browser_Window):
- (on_window_resize):
- (window_free):
- (context_menu_item_selected_cb):
- (context_menu_populate):
- (on_context_menu_show):
- (on_context_menu_hide):
- (window_create):
- 2013-05-22 Andrzej Badowski <a.badowski@samsung.com>
- [EFL] Add command line option to MiniBrowser to set cookies policy.
- https://bugs.webkit.org/show_bug.cgi?id=115028
- Reviewed by Christophe Dumez.
- Add command line option to MiniBrowser EFL to set cookies policy:
- -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
- EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
- * MiniBrowser/efl/main.c:
- (elm_main):
- 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
- REGRESSION(r150369): WebKit2WillLoadTest tests are failing
- https://bugs.webkit.org/show_bug.cgi?id=116585
- Reviewed by Alexey Proskuryakov.
- willLoadURLRequest and willLoadDataRequest require the API version 6.
- * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
- 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
- REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
- https://bugs.webkit.org/show_bug.cgi?id=116516
- Reviewed by Alexey Proskuryakov.
- Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (createWebViewAndOffscreenWindow): Match the ordering.
- (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
- 2013-05-21 Alexey Proskuryakov <ap@apple.com>
- <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
- https://bugs.webkit.org/show_bug.cgi?id=116568
- Reviewed by Anders Carlsson.
- * WebKitTestRunner/WebNotificationProvider.cpp:
- (WTR::WebNotificationProvider::~WebNotificationProvider):
- * WebKitTestRunner/WebNotificationProvider.h:
- When the provider is destroyed, it should no longer be registered with the manager.
- * WebKitTestRunner/GeolocationProviderMock.cpp:
- (WTR::GeolocationProviderMock::~GeolocationProviderMock):
- * WebKitTestRunner/GeolocationProviderMock.h:
- I wasn't seeing a crash here, but this code has the same issue as notification
- provider, so applying the same fix.
- * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
- Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
- destructor having fixed the above.
- 2013-05-21 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r150386 and r150397.
- http://trac.webkit.org/changeset/150386
- http://trac.webkit.org/changeset/150397
- https://bugs.webkit.org/show_bug.cgi?id=116572
- Broke a test; Alex is going to try again later. (Requested by
- thorton on #webkit).
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::pathSuitableForTestResult):
- (WTR::dumpRequestDescriptionSuitableForTestResult):
- (WTR::dumpResponseDescriptionSuitableForTestResult):
- (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
- (WTR::InjectedBundlePage::didInitiateLoadForResource):
- (WTR::InjectedBundlePage::willSendRequestForFrame):
- (WTR::InjectedBundlePage::didReceiveResponseForResource):
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- (InjectedBundlePage):
- 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
- Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
- * Scripts/webkitpy/tool/commands/suggestnominations.py:
- (AbstractCommitLogCommand._recent_commit_messages):
- 2013-05-21 Martin Robinson <mrobinson@igalia.com>
- [GTK] [CMake] Add support for building WebKit2
- https://bugs.webkit.org/show_bug.cgi?id=116372
- Reviewed by Gustavo Noronha Silva.
- * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
- * MiniBrowser/gtk/CMakeLists.txt: Added.
- 2013-05-21 Jessie Berlin <jberlin@apple.com>
- Revert r149635, it was too optimistic.
- Rubber-stamped by Andreas Kling.
- We are not at the point where we can always use more descriptive macros instead of PLATFORM()
- #ifdefs in WebCore code outside of WebCore/platform.
- * Scripts/webkitpy/style/checkers/cpp.py:
- (check_invalid_increment):
- (process_line):
- (CppChecker):
- * Scripts/webkitpy/style/checkers/cpp_unittest.py:
- (CppStyleTest.test_plain_integral_bitfields):
- 2013-05-21 Jer Noble <jer.noble@apple.com>
- Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
- * lldb/lldb_webkit.py:
- (WTFVectorProvider.num_children):
- (WTFVectorProvider.get_child_index):
- (WTFVectorProvider.get_child_at_index):
- (WTFVectorProvider.update):
- 2013-05-21 Jessie Berlin <jberlin@apple.com>
- Expose a way to know when forms are added to a page or when form controls are added to a form
- in the injected bundle
- https://bugs.webkit.org/show_bug.cgi?id=116334
- Reviewed by Alexey Proskuryakov.
- Add tests for the new callbacks.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
- (TestWebKitAPI::nullJavaScriptCallback):
- A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
- being passed in for the callback.
- (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
- After receiving the message that didAssociateFormControls callback was invoked from adding
- the form in the onload handler, tell the page to add a password field to the form, which
- should also invoke didAssociateFormControls callback.
- (TestWebKitAPI::setInjectedBundleClient):
- Register to receive messages.
- (TestWebKitAPI::TEST):
- Load associate-form-controls.html and wait until the didAssociateFormControls callback has
- been invoked for both adding the form and for adding a password field to the form.
- * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
- (TestWebKitAPI::shouldNotifyOnFormChanges):
- Return true so the didAssociateFormControls callback is invoked.
- (TestWebKitAPI::didAssociateFormControls):
- Tell the UI process.
- (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
- (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
- Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
- Add a form in response to the onload event. Add a button that will add the password field
- for manual testing.
- 2013-05-21 Krzysztof Czech <k.czech@samsung.com>
- [GTK][WK2] accessibility/label-for-control-hittest.html is failing
- https://bugs.webkit.org/show_bug.cgi?id=106341
- Reviewed by Martin Robinson.
- Adds support for retrieving accessibility element at exact point.
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- (WTR::AccessibilityUIElement::elementAtPoint):
- 2013-05-21 Krzysztof Czech <k.czech@samsung.com>
- [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
- https://bugs.webkit.org/show_bug.cgi?id=112913
- Reviewed by Martin Robinson.
- AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
- AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
- so the leak appears.
- * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
- (WTR):
- * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
- (WTR::AccessibilityController::rootElement):
- (WTR):
- (WTR::AccessibilityController::focusedElement):
- * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- (WTR::checkElementState):
- (WTR::indexRangeInTable):
- (WTR::alterCurrentValue):
- (WTR::AccessibilityUIElement::getChildren):
- (WTR::AccessibilityUIElement::getChildrenWithRange):
- (WTR::AccessibilityUIElement::childrenCount):
- (WTR::AccessibilityUIElement::indexOfChild):
- (WTR::AccessibilityUIElement::titleUIElement):
- (WTR::AccessibilityUIElement::parentElement):
- (WTR::AccessibilityUIElement::allAttributes):
- (WTR::AccessibilityUIElement::role):
- (WTR::AccessibilityUIElement::title):
- (WTR::AccessibilityUIElement::description):
- (WTR::AccessibilityUIElement::orientation):
- (WTR::AccessibilityUIElement::stringValue):
- (WTR::AccessibilityUIElement::language):
- (WTR::AccessibilityUIElement::x):
- (WTR::AccessibilityUIElement::y):
- (WTR::AccessibilityUIElement::width):
- (WTR::AccessibilityUIElement::height):
- (WTR::AccessibilityUIElement::intValue):
- (WTR::AccessibilityUIElement::minValue):
- (WTR::AccessibilityUIElement::maxValue):
- (WTR::AccessibilityUIElement::isEnabled):
- (WTR::AccessibilityUIElement::isFocused):
- (WTR::AccessibilityUIElement::isSelected):
- (WTR::AccessibilityUIElement::isExpanded):
- (WTR::AccessibilityUIElement::isChecked):
- (WTR::AccessibilityUIElement::rowCount):
- (WTR::AccessibilityUIElement::columnCount):
- (WTR::AccessibilityUIElement::rowIndexRange):
- (WTR::AccessibilityUIElement::columnIndexRange):
- (WTR::AccessibilityUIElement::cellForColumnAndRow):
- (WTR::AccessibilityUIElement::increment):
- (WTR::AccessibilityUIElement::decrement):
- (WTR::AccessibilityUIElement::press):
- (WTR::AccessibilityUIElement::documentEncoding):
- (WTR::AccessibilityUIElement::documentURI):
- (WTR::AccessibilityUIElement::isFocusable):
- (WTR::AccessibilityUIElement::isSelectable):
- (WTR::AccessibilityUIElement::isMultiSelectable):
- (WTR::AccessibilityUIElement::isVisible):
- 2013-05-20 Lucas Forschler <lforschler@apple.com>
- Rollout 150398.
-
- 2013-05-20 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Fix concatenations of string literals that are not C++11-compliant
- https://bugs.webkit.org/show_bug.cgi?id=116449
- Reviewed by Martin Robinson.
- Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
- is simply a matter of separating the string and the string literal that are being concatenated with a space.
- * ImageDiff/gtk/ImageDiff.cpp:
- (printImage):
- 2013-05-20 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
- https://bugs.webkit.org/show_bug.cgi?id=116450
- Reviewed by Martin Robinson.
- The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
- programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
- default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
- TestWebKitAPI programs when compiling them.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-05-20 Ryosuke Niwa <rniwa@webkit.org>
- Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
- https://bugs.webkit.org/show_bug.cgi?id=116492
- Reviewed by Dirk Pranke.
- Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
- The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
- so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
- starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
- and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
- the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
- to memory pressure on the machine.
- This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
- we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
- for a subsequent patch just to make things easier to follow.
- * Scripts/webkitpy/port/driver.py:
- (DriverProxy.__init__):
- (DriverProxy.run_test):
- (DriverProxy.has_crashed):
- (DriverProxy.stop):
- 2013-05-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
- Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
- https://bugs.webkit.org/show_bug.cgi?id=116423
- Reviewed by Ryosuke Niwa.
- EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
- * BuildSlaveSupport/build.webkit.org-config/config.json:
- 2013-05-20 Seokju Kwon <seokju.kwon@gmail.com>
- Remove remaining link-prerender code
- https://bugs.webkit.org/show_bug.cgi?id=116429
- Reviewed by Darin Adler.
- Link prerendering code was removed in r150356.
- * Scripts/webkitperl/FeatureList.pm:
- * qmake/mkspecs/features/features.pri:
- 2013-05-20 Ryosuke Niwa <rniwa@webkit.org>
- commit-queue should check for oops in changelog entries
- https://bugs.webkit.org/show_bug.cgi?id=116395
- Reviewed by Martin Robinson.
- Make changelog validation fail when it contains oops!.
- * Scripts/webkitpy/tool/bot/commitqueuetask.py:
- (CommitQueueTask._validate_changelog):
- * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- (CommitQueueTaskTest._run_through_task):
- * Scripts/webkitpy/tool/commands/queues_unittest.py:
- * Scripts/webkitpy/tool/steps/validatechangelogs.py:
- (ValidateChangeLogs.options):
- (ValidateChangeLogs._check_changelog_diff):
- (ValidateChangeLogs._changelog_contains_oops):
- (ValidateChangeLogs.run):
- * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
- (ValidateChangeLogsTest._assert_start_line_produces_output):
- (ValidateChangeLogsTest.test_check_changelog_diff):
- (ValidateChangeLogsTest):
- (ValidateChangeLogsTest.test_changelog_contains_oops):
- 2013-05-20 Jessie Berlin <jberlin@apple.com>
- Expose a way to know when forms are added to a page or when form controls are added to a form
- in the injected bundle
- https://bugs.webkit.org/show_bug.cgi?id=116334
- Reviewed by Alexey Proskuryakov.
- Add tests for the new callbacks.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
- (TestWebKitAPI::nullJavaScriptCallback):
- A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
- being passed in for the callback.
- (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
- After receiving the message that didAssociateFormControls callback was invoked from adding
- the form in the onload handler, tell the page to add a password field to the form, which
- should also invoke didAssociateFormControls callback.
- (TestWebKitAPI::setInjectedBundleClient):
- Register to receive messages.
- (TestWebKitAPI::TEST):
- Load associate-form-controls.html and wait until the didAssociateFormControls callback has
- been invoked for both adding the form and for adding a password field to the form.
- * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
- (TestWebKitAPI::shouldNotifyOnFormChanges):
- Return true so the didAssociateFormControls callback is invoked.
- (TestWebKitAPI::didAssociateFormControls):
- Tell the UI process.
- (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
- (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
- Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
- Add a form in response to the onload event. Add a button that will add the password field
- for manual testing.
- 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
- [EFL][JHBUILD] Make sure eet is built before evas
- https://bugs.webkit.org/show_bug.cgi?id=116440
- Reviewed by Gyuyoung Kim.
- Mark eet as a dependency of evas since evas requires eet to enable some of its
- functionality.
- * efl/jhbuild.modules:
- 2013-05-20 Alex Christensen <achristensen@apple.com>
- WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
- https://bugs.webkit.org/show_bug.cgi?id=116125
- Reviewed by Tim Horton.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::pathSuitableForTestResult):
- Changed string operations to match _drt_descriptionSuitableForTestResult.
- (WTR::dumpRequestDescriptionSuitableForTestResult):
- (WTR::dumpResponseDescriptionSuitableForTestResult):
- (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
- (WTR::InjectedBundlePage::didInitiateLoadForResource):
- (WTR::InjectedBundlePage::willSendRequestForFrame):
- (WTR::InjectedBundlePage::didReceiveResponseForResource):
- Pass the main frame's URL to pathSuitableForTestResult.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- Added WKBundlePageRef to willPerformClientRedirectForFrame.
- 2013-05-20 Dirk Pranke <dpranke@chromium.org>
- fix w3c test importer unit tests after r150324
- https://bugs.webkit.org/show_bug.cgi?id=116459
- Reviewed by Ryosuke Niwa.
- This patch fixes the unit tests to not actually call out to
- 'hg' (by using a mock executive) and also changes the real
- directory we crawl from Source/WebCore/css to
- Tools/Scripts/webkitpy/w3c to run much more quickly. We should
- still change this to a mock filesystem, but that's a separate change.
- * Scripts/webkitpy/w3c/test_importer.py:
- (main):
- (TestImporter.__init__):
- (TestImporter.load_changeset):
- * Scripts/webkitpy/w3c/test_importer_unittest.py:
- (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
- (TestImporterTest.test_import_dir_with_no_tests):
- 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed EFL build fix.
- Fix linking errors due to undefined symbols on Ubuntu 13.04.
- * DumpRenderTree/efl/CMakeLists.txt:
- * EWebLauncher/CMakeLists.txt:
- * MiniBrowser/efl/CMakeLists.txt:
- 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
- [EFL] Reenabled INDEXED_DATABASE after r150344
- https://bugs.webkit.org/show_bug.cgi?id=116430
- Reviewed by Gyuyoung Kim.
- Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
- build was fixed in r150344.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-05-19 Ryuan Choi <ryuan.choi@samsung.com>
- [EFL] init/shutdown should be paired in EWebLauncher
- https://bugs.webkit.org/show_bug.cgi?id=116427
- Reviewed by Christophe Dumez.
- Added ecore_file_shutdown() for cleanup of ecore_file.
- Removed edje_init and ecore_evas_init because it was in ewk_init().
- * EWebLauncher/main.c:
- (main):
- 2013-05-19 Jinwoo Song <jinwoo7.song@samsung.com>
- [EFL] Add command line option to MiniBrowser to set user agent
- https://bugs.webkit.org/show_bug.cgi?id=116387
- Reviewed by Christophe Dumez.
- We need this option to compare the rendering differences according to different user agents.
- * MiniBrowser/efl/main.c:
- (window_create):
- (elm_main):
- 2013-05-19 Zan Dobersek <zdobersek@igalia.com>
- Unreviewed, addressing test-webkitpy failures after r150317.
- * Scripts/webkitpy/w3c/test_converter.py:
- (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
- 2013-05-18 Patrick Gansterer <paroga@webkit.org>
- [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
- https://bugs.webkit.org/show_bug.cgi?id=114554
- Reviewed by Gyuyoung Kim.
- Using variables as target names is very uncommon in CMake.
- The usual way to specify the name of the resulting binary
- is to set the OUTPUT_NAME target property.
- * DumpRenderTree/efl/CMakeLists.txt:
- * EWebLauncher/CMakeLists.txt:
- * ImageDiff/CMakeLists.txt:
- * MiniBrowser/efl/CMakeLists.txt:
- * TestWebKitAPI/CMakeLists.txt:
- * WebKitTestRunner/CMakeLists.txt:
- * WebKitTestRunner/PlatformEfl.cmake:
- * WinCELauncher/CMakeLists.txt:
- 2013-05-18 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed EFL build fix.
- Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
- WK2 build after r150305.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-05-18 Alberto Garcia <agarcia@igalia.com>
- [GTK] Parallel build fails if gtk-doc is enabled
- https://bugs.webkit.org/show_bug.cgi?id=116227
- Reviewed by Martin Robinson.
- * GNUmakefile.am:
- Don't use the 'all' target to generate the documentation.
- The prerequisites of this target must be files that need to be
- built _before_ the actual compilation of WebKit starts. Since the
- documentation depends on WebKit being built first, this means in
- practice that the code will be built in parallel with the
- generation of its dependencies, potentially making the build fail.
- 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
- Don't run hg.
- * Scripts/webkitpy/w3c/test_importer_unittest.py:
- (TestImporterTest):
- 2013-05-17 Dirk Pranke <dpranke@chromium.org>
- Create a script to import W3C tests
- https://bugs.webkit.org/show_bug.cgi?id=111513
- Reviewed by Ryosuke Niwa.
- This patch attempts to re-land the 'import-w3c-tests'
- script and accompanying modules. The tests and code have
- been cleaned up so that we do not log anything to stdout/stderr
- while running the tests (thanks to outputcapture) and do not
- write into the source tree while running the tests, and much
- but not all of the code has been converted over to using the webkitpy
- * Scripts/import-w3c-tests: Added.
- * Scripts/webkitpy/w3c/__init__.py: Added.
- * Scripts/webkitpy/w3c/test_converter.py: Added.
- (W3CTestConverter):
- (W3CTestConverter.__init__):
- (W3CTestConverter.path_from_webkit_root):
- (W3CTestConverter.read_webkit_prefixed_css_property_list):
- (W3CTestConverter.convert_for_webkit):
- (W3CTestConverter.convert_css):
- (W3CTestConverter.convert_html):
- (W3CTestConverter.convert_testharness_paths):
- (W3CTestConverter.convert_prefixed_properties):
- (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
- (W3CTestConverter.replace_tag):
- * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
- (W3CTestConverterTest):
- (W3CTestConverterTest.fake_dir_path):
- (W3CTestConverterTest.test_read_prefixed_property_list):
- (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
- (test_convert_for_webkit_harness_only):
- (test_convert_for_webkit_properties_only):
- (test_convert_for_webkit_harness_and_properties):
- (test_convert_test_harness_paths):
- (test_convert_prefixed_properties):
- (verify_conversion_happened):
- (verify_no_conversion_happened):
- (verify_test_harness_paths):
- (verify_prefixed_properties):
- (generate_test_content):
- * Scripts/webkitpy/w3c/test_importer.py: Added.
- (main):
- (parse_args):
- (validate_import_directory):
- (TestImporter):
- (TestImporter.__init__):
- (TestImporter.path_from_webkit_root):
- (TestImporter.do_import):
- (TestImporter.load_changeset):
- (TestImporter.find_importable_tests):
- (TestImporter.import_tests):
- (TestImporter.setup_destination_directory):
- (TestImporter.update_test_status):
- (TestImporter.remove_deleted_files):
- (TestImporter.write_import_log):
- * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
- (TestImporterTest):
- (TestImporterTest.test_import_dir_with_no_tests):
- * Scripts/webkitpy/w3c/test_parser.py: Added.
- (TestParser):
- (TestParser.__init__):
- (TestParser.load_file):
- (TestParser.analyze_test):
- (TestParser.reference_links_of_type):
- (TestParser.is_jstest):
- (TestParser.support_files):
- * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
- (TestParserTest):
- (TestParserTest.test_analyze_test_reftest_one_match):
- (test_analyze_test_reftest_multiple_matches):
- (test_analyze_test_reftest_match_and_mismatch):
- (test_analyze_test_reftest_with_ref_support_Files):
- (test_analyze_jstest):
- (test_analyze_pixel_test_all_true):
- (test_analyze_pixel_test_all_false):
- (test_analyze_non_html_file):
- 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
- Leaks builders exit early frequently
- https://bugs.webkit.org/show_bug.cgi?id=116355
- Reviewed by Stephanie Lewis.
- Throttle the number of processes to use, and also bump up the number of crashes/timeouts
- we tolerate from 20 to 50.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- (RunWebKitTests.start):
- * Scripts/webkitpy/port/mac.py:
- (MacPort.default_child_processes):
- 2013-05-17 Peter Gal <galpeter@inf.u-szeged.hu>
- Remove chrome-channels command from the webkit-patch
- https://bugs.webkit.org/show_bug.cgi?id=116303
- Reviewed by Ryosuke Niwa.
- * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
- * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
- * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
- * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
- * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
- * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
- 2013-05-17 David Kilzer <ddkilzer@apple.com>
- filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
- Part 3 of 3: <http://webkit.org/b/116247>
- Reviewed by Benjamin Poulain.
- * Scripts/filter-build-webkit: Change while() loop to for() loop
- to track $previousLine, then pass $previousLine into
- shouldIgnoreLine().
- (shouldIgnoreLine): Add $previousLine argument. Do not skip a
- line that begins with four spaces if the previous line is a
- linker error message.
- * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
- - Add "Ignored: " to test descriptions to document expected
- behavior.
- - Add comment blocks for various groups of tests.
- - Expand "Build settings" tests since we're changing the code in
- shouldIgnoreLine() that ignores those lines.
- - Add tests for undefined symbols error message.
- (description): Add. Extract from global code.
- 2013-05-17 David Kilzer <ddkilzer@apple.com>
- Add tests for shouldIgnoreLine() in filter-build-webkit
- Part 2 of 3: <http://webkit.org/b/116247>
- Reviewed by Benjamin Poulain.
- * Scripts/filter-build-webkit:
- (shouldIgnoreLine): Add. Extract code from global scope into
- subroutine to make it testable.
- * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
- Tests shouldIgnoreLine() using output from a real build
- transcript.
- 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
- Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
- https://bugs.webkit.org/show_bug.cgi?id=116341
- Reviewed by Brady Eidson.
- * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 2013-05-17 Brent Fulgham <bfulgham@apple.com>
- [Windows] Don't use pdevenv when building with VS2010.
- https://bugs.webkit.org/show_bug.cgi?id=116338.
- Reviewed by Adam Roben.
- * Scripts/webkitdirs.pm:
- (setupCygwinEnv): Check if we are using VS2005, and only use
- the 'pdevenv' hack if we are. Otherwise, just build with
- our standard project since it uses VS2010+'s native
- parallel building features.
- 2013-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
- Unreviewed. Disable accelerated compositing until we figure out why it does not work
- properly in the 64 bits release bot.
- * DumpRenderTree/gtk/DumpRenderTree.cpp:
- (resetDefaultsToConsistentValues):
- 2013-05-17 David Kilzer <ddkilzer@apple.com>
- Make filter-build-webkit testable using LoadAsModule
- Part 1 of 3: <http://webkit.org/b/116247>
- Reviewed by Benjamin Poulain.
- * Scripts/filter-build-webkit: Change global variables that are
- used in subroutines from 'my' to 'our' to make it possible to
- evaluate the script in a package context in LoadAsModule.pm.
- 2013-05-14 Sam Weinig <sam@webkit.org>
- Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
- https://bugs.webkit.org/show_bug.cgi?id=116132
- Reviewed by Anders Carlsson.
- Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
- willLoadURLRequest and willLoadDataRequest to let the bundle access them.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
- * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- 2013-05-16 Seokju Kwon <seokju.kwon@gmail.com>
- [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
- https://bugs.webkit.org/show_bug.cgi?id=114781
- Reviewed by Christophe Dumez.
- Add run_before_unload_confirm and
- Print the log message with "CONFIRM NAVIGATION: " in console.
- * DumpRenderTree/efl/DumpRenderTreeView.cpp:
- (onBeforeUnloadConfirm):
- (drtViewAdd):
- 2013-05-16 Peter Gal <galpeter@inf.u-szeged.hu>
- Fix Analyze ChangeLog's entry processing
- https://bugs.webkit.org/show_bug.cgi?id=116219
- Reviewed by Ryosuke Niwa.
- * Scripts/webkitpy/tool/commands/analyzechangelog.py:
- (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
- 2013-05-16 Hyungchan Kim <hyungchan2.kim@lge.com>
- [Qt] UrlLoader::loadNext is broken in MiniBrowser
- https://bugs.webkit.org/show_bug.cgi?id=116099
- Reviewed by Jocelyn Turcotte.
- QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
- are not available any more. So, UrlLoader::loadNext was broken
- because it failed to connect to those signals.
- * MiniBrowser/qt/UrlLoader.cpp:
- (UrlLoader::UrlLoader):
- (UrlLoader::loadingChanged):
- * MiniBrowser/qt/UrlLoader.h:
- (UrlLoader):
- 2013-05-16 Lamarque V. Souza <Lamarque.Souza@basyskom.com>
- [WebSocket] Update pywebsocket to r760
- https://bugs.webkit.org/show_bug.cgi?id=115863
- Reviewed by Alexey Proskuryakov.
- Version r760 supports a newer draft of message compression.
- We need this update to finish the permessage compression patch in
- bug 98840. This patch also fixes failing unit tests after the update.
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
- (StreamBase._read):
- (StreamBase._read.of):
- (StreamBase._write):
- (StreamBase.receive_bytes):
- (StreamBase._read_until):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
- (parse_frame):
- (StreamOptions.__init__):
- (Stream.__init__):
- (Stream._receive_frame_as_frame_object):
- (Stream._get_message_from_frame):
- (Stream._process_close_message):
- (Stream.close_connection):
- (Stream.get_last_received_opcode):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
- (Dispatcher.do_extra_handshake):
- (Dispatcher.transfer_data):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
- (ExtensionProcessorInterface.__init__):
- (ExtensionProcessorInterface.request):
- (ExtensionProcessorInterface):
- (ExtensionProcessorInterface.name):
- (ExtensionProcessorInterface.check_consistency_with_other_processors):
- (ExtensionProcessorInterface.set_active):
- (ExtensionProcessorInterface.is_active):
- (ExtensionProcessorInterface._get_extension_response_internal):
- (ExtensionProcessorInterface.get_extension_response):
- (ExtensionProcessorInterface._setup_stream_options_internal):
- (ExtensionProcessorInterface.setup_stream_options):
- (_log_outgoing_compression_ratio):
- (_log_incoming_compression_ratio):
- (_parse_window_bits):
- (_AverageRatioCalculator):
- (_AverageRatioCalculator.__init__):
- (_AverageRatioCalculator.add_original_bytes):
- (_AverageRatioCalculator.add_result_bytes):
- (_AverageRatioCalculator.get_average_ratio):
- (DeflateFrameExtensionProcessor):
- (DeflateFrameExtensionProcessor.__init__):
- (DeflateFrameExtensionProcessor._get_extension_response_internal):
- (DeflateFrameExtensionProcessor._setup_stream_options_internal):
- (DeflateFrameExtensionProcessor._outgoing_filter):
- (DeflateFrameExtensionProcessor._incoming_filter):
- (CompressionExtensionProcessorBase.for):
- (CompressionExtensionProcessorBase.__init__):
- (CompressionExtensionProcessorBase._get_extension_response_internal):
- (CompressionExtensionProcessorBase._setup_stream_options_internal):
- (PerFrameCompressExtensionProcessor):
- (PerMessageDeflateExtensionProcessor):
- (PerMessageDeflateExtensionProcessor.__init__):
- (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
- (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
- (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
- (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
- (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
- (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
- (PerMessageDeflateExtensionProcessor.set_bfinal):
- (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
- (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
- (_PerMessageDeflateFramer):
- (_PerMessageDeflateFramer.__init__):
- (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
- (_PerMessageDeflateFramer._process_incoming_message):
- (_PerMessageDeflateFramer._process_outgoing_message):
- (_PerMessageDeflateFramer.setup_stream_options):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
- (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
- (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
- (PerMessageCompressExtensionProcessor):
- (PerMessageCompressExtensionProcessor._lookup_compression_processor):
- (MuxExtensionProcessor.__init__):
- (MuxExtensionProcessor.check_consistency_with_other_processors):
- (MuxExtensionProcessor):
- (MuxExtensionProcessor._get_extension_response_internal):
- (MuxExtensionProcessor._setup_stream_options_internal):
- (MuxExtensionProcessor.set_quota):
- (MuxExtensionProcessor.quota):
- (MuxExtensionProcessor.set_extensions):
- (MuxExtensionProcessor.extensions):
- (is_compression_extension):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
- (validate_subprotocol):
- (parse_host_header):
- (format_header):
- (check_request_line):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
- (Handshaker.do_handshake):
- (Handshaker._create_handshake_response):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
- (_validate_subprotocol):
- (_check_header_lines):
- (_build_location):
- (Handshaker.do_handshake):
- (Handshaker._set_subprotocol):
- (Handshaker._set_location):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
- (_create_dispatcher):
- (headerparserhandler):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
- (_create_add_channel_response):
- (_create_drop_channel):
- (_create_flow_control):
- (_create_new_channel_slot):
- (_create_fallback_new_channel_slot):
- (_MuxFramePayloadParser._read_number):
- (_MuxFramePayloadParser._read_size_and_contents):
- (_MuxFramePayloadParser._read_flow_control):
- (_MuxFramePayloadParser._read_new_channel_slot):
- (_LogicalConnection.__init__):
- (_LogicalConnection.write):
- (_LogicalConnection.on_write_data_done):
- (_LogicalConnection):
- (_LogicalConnection.on_writer_done):
- (_InnerMessage):
- (_InnerMessage.__init__):
- (_InnerMessageBuilder):
- (_InnerMessageBuilder.that):
- (_InnerMessageBuilder.__init__):
- (_InnerMessageBuilder._handle_first):
- (_InnerMessageBuilder._process_first_fragmented_control):
- (_InnerMessageBuilder._process_first_fragmented_message):
- (_InnerMessageBuilder._handle_fragmented_control):
- (_InnerMessageBuilder._reassemble_fragmented_control):
- (_InnerMessageBuilder._handle_fragmented_message):
- (_InnerMessageBuilder._reassemble_fragmented_message):
- (_InnerMessageBuilder.build):
- (_LogicalStream.__init__):
- (_LogicalStream._create_inner_frame):
- (_LogicalStream._write_inner_frame):
- (_LogicalStream.replenish_send_quota):
- (_LogicalStream.send_message):
- (_LogicalStream._receive_frame):
- (_LogicalStream._get_message_from_frame):
- (_LogicalStream.stop_sending):
- (_PhysicalConnectionWriter.__init__):
- (_PhysicalConnectionWriter._write_data):
- (_PhysicalConnectionWriter.run):
- (_PhysicalConnectionWriter.stop):
- (_Worker.run):
- (_MuxHandshaker.__init__):
- (_MuxHandshaker._create_stream):
- (_MuxHandshaker._create_handshake_response):
- (_HandshakeDeltaBase.create_headers):
- (_MuxHandler.start):
- (_MuxHandler.wait_until_done):
- (_MuxHandler.notify_write_data_done):
- (_MuxHandler._process_drop_channel):
- (_MuxHandler._process_logical_frame):
- (_MuxHandler.notify_reader_done):
- (_MuxHandler):
- (_MuxHandler.notify_writer_done):
- (_MuxHandler.fail_physical_connection):
- (_MuxHandler.fail_logical_channel):
- (use_mux):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
- (_StandaloneRequest.get_uri):
- (_StandaloneRequest.get_unparsed_uri):
- (_StandaloneRequest):
- (_StandaloneRequest.is_https):
- (_import_ssl):
- (_import_pyopenssl):
- (_StandaloneSSLConnection.for):
- (_StandaloneSSLConnection):
- (_StandaloneSSLConnection.__getattribute__):
- (_StandaloneSSLConnection.__setattr__):
- (_StandaloneSSLConnection.makefile):
- (_StandaloneSSLConnection.shutdown):
- (_StandaloneSSLConnection.recv):
- (WebSocketServer.__init__):
- (WebSocketServer._create_sockets):
- (WebSocketServer.handle_error):
- (WebSocketServer.get_request):
- (WebSocketServer.get_request.default_callback):
- (WebSocketRequestHandler.parse_request):
- (_build_option_parser):
- (_main):
- (_main.if):
- * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
- (RepeatedXorMasker.__init__):
- (RepeatedXorMasker._mask_using_swig):
- (RepeatedXorMasker):
- (RepeatedXorMasker._mask_using_array):
- (_Deflater.compress_and_finish):
- (_RFC1979Deflater.filter):
- (DeflateSocket.send):
- 2013-05-16 Jonathan Liu <net147@gmail.com>
- Fix testing if program exists in PATH
- https://bugs.webkit.org/show_bug.cgi?id=116216
- Reviewed by Jocelyn Turcotte.
- functions.prf incorrectly uses win_cmd_shell to test whether to
- add .exe to the executable name when checking if it exists in
- the PATH environment variable. This works correctly when
- building using Windows Command Prompt but not under MSYS shell.
- To resolve this, check the win32 platform scope instead of
- win_cmd_shell so that it correctly adds .exe to the executable
- name on Windows regardless of the shell used when testing if
- it exists in PATH.
- * qmake/mkspecs/features/functions.prf:
- 2013-05-16 Ryosuke Niwa <rniwa@webkit.org>
- Fix the hard-coded names of EWS bots that run tests.
- * Scripts/webkitpy/tool/commands/queues.py:
- (CommitQueue.did_pass_testing_ews):
- 2013-05-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
- [GTK] Build Xvfb with jhbuild
- https://bugs.webkit.org/show_bug.cgi?id=115907
- Reviewed by Martin Robinson.
- Build our own Xvfb so that we can avoid problems with the system Xvfb
- relying on symbols not present in our jhbuilt libraries such as pixman,
- and also to ensure we have the fix for a GLX module crasher.
- * DumpRenderTree/gtk/DumpRenderTree.cpp:
- (resetDefaultsToConsistentValues): enable accelerated compositing.
- * gtk/install-dependencies: list packages required for building Xvfb.
- * gtk/jhbuild.modules: add xserver as a jhbuild module.
- * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
- * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
- initializing the GLX module for Xvfb.
- 2013-05-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
- [jhbuild] Should remove the sources directory as well when cleaning
- https://bugs.webkit.org/show_bug.cgi?id=116229
- Reviewed by Martin Robinson.
- * Scripts/update-webkit-libs-jhbuild:
- (cleanJhbuild): remove the Source directory as well when cleaning.
- 2013-05-15 Dominik Röttsches <dominik.rottsches@intel.com>
- [EFL] Remove Intel Wk2 Buildbots from Master
- https://bugs.webkit.org/show_bug.cgi?id=116149
- Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
- since Gyuyoung Kim from Samsung plans to take over and maintain it.
- Reviewed by Benjamin Poulain.
- * BuildSlaveSupport/build.webkit.org-config/config.json:
- 2013-05-15 Brent Fulgham <bfulgham@apple.com>
- [Windows] Update various build tools to understand VS2010 environment.
- https://bugs.webkit.org/show_bug.cgi?id=116169.
- Reviewed by Anders Carlsson.
- * Scripts/build-api-tests: Identify VS2010 environment.
- * Scripts/build-dumprendertree: Ditto.
- * Scripts/build-webkit: Ditto.
- * Scripts/webkitdirs.pm:
- (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
- range of acceptable SDK's.
- 2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
- Allow http tests on Arch Linux
- https://bugs.webkit.org/show_bug.cgi?id=116155
- Reviewed by Ryosuke Niwa.
- * Scripts/webkitpy/port/base.py:
- (Port._is_arch_based): Added check for /etc/arch-release file.
- (Port._apache_config_file_name_for_platform): Call the check.
- * Scripts/webkitpy/port/port_testcase.py:
- (test_linux_distro_detection): Testcase added.
- 2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
- Remove a leftover v8 file from the watchlist
- https://bugs.webkit.org/show_bug.cgi?id=116158
- Reviewed by Csaba Osztrogonác.
- * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
- 2013-05-15 Alberto Garcia <agarcia@igalia.com>
- [GTK] Fails to build while generating gtkdoc
- https://bugs.webkit.org/show_bug.cgi?id=115612
- Reviewed by Philippe Normand.
- Fix typo in the prerequisites of docs-build.stamp.
- * GNUmakefile.am:
- 2013-05-15 Zan Dobersek <zdobersek@igalia.com>
- Unreviewed, fixing the current test-webkitpy failure.
- * Scripts/webkitpy/port/mac_unittest.py:
- (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
- in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
- 2013-05-14 Jaehun Lim <ljaehun.lim@samsung.com>
- Fix build after r150090.
- https://bugs.webkit.org/show_bug.cgi?id=116129
- Unreviewed build fix after r150090.
- * WebKitTestRunner/TestInvocation.cpp:
- (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- 2013-05-14 Brent Fulgham <bfulgham@apple.com>
- [Windows, others] Unreviewed build fix after r150090.
- * DumpRenderTree/TestRunner.cpp:
- (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
- doesn't exist on other platforms.
- 2013-05-14 Brent Fulgham <bfulgham@webkit.org>
- [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
- https://bugs.webkit.org/show_bug.cgi?id=115889
- Reviewed by Benjamin Poulain.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
- 2013-05-14 Brent Fulgham <bfulgham@apple.com>
- [Windows] Identify proper run environment for scripts.
- https://bugs.webkit.org/show_bug.cgi?id=116114
- Reviewed by David Kilzer.
- Determine (based on Visual Studio version) which path to use for
- executables (bin versus bin32).
- * Scripts/webkitdirs.pm:
- (determineVisualStudioInstallDir): Added.
- (determineVisualStudioVersion): Added.
- (determineConfigurationProductDir): Modified to choose proper bin
- or bin32 directory.
- (visualStudioVersion): Added
- (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
- 2013-05-14 Alexey Proskuryakov <ap@apple.com>
- [Mac] Add tests for secure event input
- https://bugs.webkit.org/show_bug.cgi?id=116121
- Reviewed by Mark Rowe.
- * DumpRenderTree/TestRunner.cpp:
- (getSecureEventInputIsEnabledCallback):
- (TestRunner::staticValues):
- Expose an accessor for current secure event input state.
- * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- (WTR::TestRunner::secureEventInputIsEnabled):
- * WebKitTestRunner/InjectedBundle/TestRunner.h:
- * WebKitTestRunner/TestInvocation.cpp:
- (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- Expose an accessor for current secure event input state. This has to be done in
- UI process, as this is where it's changed by WebKit.
- 2013-05-14 Alexey Proskuryakov <ap@apple.com>
- [Mac] Add a testing shim for secure event input functions
- https://bugs.webkit.org/show_bug.cgi?id=116122
- Reviewed by Mark Rowe.
- * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
- Inject WebCore testing shim library to override system framework functions.
- 2013-05-14 Brent Fulgham <bfulgham@apple.com>
- [Windows] Switch to embedded manifest commands for launcher executables.
- https://bugs.webkit.org/show_bug.cgi?id=116109
- Reviewed by Darin Adler.
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
- now-unused WinLauncher.exe.manifest file.
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
- * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
- when building with VS2010 or newer.
- 2013-05-14 Brent Fulgham <bfulgham@apple.com>
- [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
- https://bugs.webkit.org/show_bug.cgi?id=116079
- Reviewed by David Kilzer.
- * Scripts/old-run-webkit-tests:
- (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
- 2013-05-14 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
- https://bugs.webkit.org/show_bug.cgi?id=115921
- Reviewed by Gustavo Noronha Silva.
- * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
- * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
- 2013-05-13 Alex Christensen <achristensen@apple.com>
- Added testRunner.setPrinting.
- https://bugs.webkit.org/show_bug.cgi?id=42693
- rdar://problem/8213845
- Reviewed by Darin Adler.
- * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- Added setPrinting JavaScript function.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::dump):
- Dump the external representation for printing if setPrinting has been called.
- * WebKitTestRunner/InjectedBundle/TestRunner.h:
- (WTR::TestRunner::isPrinting): Added.
- (WTR::TestRunner::setPrinting): Added.
- Added and initialized m_isPrinting member boolean.
- 2013-05-13 Csaba Osztrogonác <ossy@webkit.org>
- [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
- https://bugs.webkit.org/show_bug.cgi?id=116016
- Reviewed by Dirk Pranke.
- Same fix as in the upstream style checker, but without hg support.
- ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
- * Scripts/webkitpy/style/checkers/cpp.py:
- (FileInfo.repository_name):
- 2013-05-13 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
- https://bugs.webkit.org/show_bug.cgi?id=115918
- Reviewed by Gustavo Noronha Silva.
- Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
- the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
- This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
- due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
- when linking, simplifying the code and suppressing all the layering violations so they do not cause build
- problems.
- First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
- These are then used as dependencies for the archive creation rule as well as the list from which the archive
- file paths are constructed and then used to dump the member files from these archives. The member files are
- then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
- successfully link.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-05-13 Anders Carlsson <andersca@apple.com>
- Remove UnusedParam.h
- https://bugs.webkit.org/show_bug.cgi?id=116029
- Reviewed by Andreas Kling.
- Stop including UnusedParam.h.
- * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- * WebKitTestRunner/qt/TestInvocationQt.cpp:
- 2013-05-12 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r149955.
- http://trac.webkit.org/changeset/149955
- https://bugs.webkit.org/show_bug.cgi?id=115990
- Broke lots of tests (Requested by smfr on #webkit).
- * Scripts/webkitpy/port/mac.py:
- 2013-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
- [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
- https://bugs.webkit.org/show_bug.cgi?id=115914
- Reviewed by Martin Robinson.
- * GtkLauncher/main.c:
- (createToolbar):
- * MiniBrowser/gtk/BrowserWindow.c:
- (_BrowserWindow):
- (browserWindowSetStatusText):
- (fullScreenMessageTimeoutCallback):
- (webViewEnterFullScreen):
- (webViewLeaveFullScreen):
- (browserWindowFinalize):
- (browserWindowConstructed):
- * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- (WTR::EventSenderProxy::mouseScrollBy):
- (WTR::EventSenderProxy::continuousMouseScrollBy):
- 2013-05-11 Anders Carlsson <andersca@apple.com>
- Crash when terminating a process that has not been fully launched
- https://bugs.webkit.org/show_bug.cgi?id=115962
- <rdar://problem/13660916>
- Reviewed by Andreas Kling.
- Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
- before the process has had a chance to be fully launched.
- * TestWebKitAPI/GNUmakefile.am:
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::didFinishLoadForFrame):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 2013-05-10 Laszlo Gombos <l.gombos@samsung.com>
- Remove Mac OS X Leopard (10.5) support
- https://bugs.webkit.org/show_bug.cgi?id=107964
- Reviewed by Ryosuke Niwa.
- Removed the code for 10.5 and removed if-def for 10.6.
- * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
- (convertMIMEType):
- (createXMLStringFromWebArchiveData):
- * DumpRenderTree/mac/TestRunnerMac.mm:
- (TestRunner::authenticateSession):
- (TestRunner::setTextDirection):
- * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
- (convertMIMEType):
- (createXMLStringFromWebArchiveData):
- 2013-05-10 Brent Fulgham <bfulgham@apple.com>
- [Windows] Allow VS2010 Build to use VS2005 Support Libraries
- https://bugs.webkit.org/show_bug.cgi?id=115935
- Reviewed by Jer Noble.
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
- to the new manifest file.
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
- 2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
- Fix some compiler warnings (miscellaneous)
- https://bugs.webkit.org/show_bug.cgi?id=80790
- Reviewed by Rob Buis.
- Fix the following warnings for BlackBerry:
- DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
- used as truth value [-Wparentheses].
- * DumpRenderTree/blackberry/DumpRenderTree.cpp:
- (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 2013-05-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
- [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
- https://bugs.webkit.org/show_bug.cgi?id=115928
- Reviewed by Kenneth Rohde Christiansen.
- WKViewSetThemePath was moved to WKViewEfl.h.
- * TestWebKitAPI/efl/PlatformWebView.cpp:
- 2013-05-10 Andreas Kling <akling@apple.com>
- I accidentally the Java testing.
- * Scripts/webkitpy/port/mac.py:
- 2013-05-10 Brian Holt <brian.holt@samsung.com>
- [GTK] Module Cairo fails to build under jhbuild
- https://bugs.webkit.org/show_bug.cgi?id=115854
- Reviewed by Martin Robinson.
- Make cairo depend on glib in jhbuild.modules.
- * gtk/jhbuild.modules:
- 2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
- [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
- https://bugs.webkit.org/show_bug.cgi?id=115904
- Reviewed by Martin Robinson.
- * ImageDiff/gtk/ImageDiff.cpp:
- (main):
- 2013-05-10 Balazs Kelemen <kbalazs@webkit.org>
- Add my new address to contributors.json. (Unreviewed)
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed. Move myself to the reviewers list.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed. Add my email to a few watchlists.
- * Scripts/webkitpy/common/config/watchlist:
- 2013-05-10 Simon Pena <simon.pena@samsung.com>
- Unicode support missing from string representation of Contributors in committers.py
- https://bugs.webkit.org/show_bug.cgi?id=115859
- Reviewed by Darin Adler.
- Contributors, in committers.py, provided a string representation in __str__ which
- didn't support unicode characters, so printing a contributor would fail in that case.
- This patch implements __unicode__ and makes __str__ use it to represent a contributor.
- The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
- * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
- to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
- representation.
- (Contributor.__str__):
- (Contributor):
- (Contributor.__unicode__):
- * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
- a contributor with unicode characters can be represented as a string.
- (CommittersTest):
- (CommittersTest.test_contributor_encoding):
- 2013-05-09 Patrick Gansterer <paroga@webkit.org>
- [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
- https://bugs.webkit.org/show_bug.cgi?id=92371
- Reviewed by Brent Fulgham.
- Use JavaScriptThreading.cpp where the same functionality is
- implemented too. This reduces the dependency on the pthread
- library. Also replace assert() with WebKit ASSERT().
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (dumpHistoryItem):
- (dumpBackForwardList):
- * DumpRenderTree/win/DumpRenderTree.vcproj:
- 2013-05-09 Patrick Gansterer <paroga@webkit.org>
- [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
- https://bugs.webkit.org/show_bug.cgi?id=92505
- Reviewed by Brent Fulgham.
- * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
- (javaScriptThreadsMutex):
- (javaScriptThreads):
- (runJavaScriptThread):
- (startJavaScriptThreads):
- (stopJavaScriptThreads):
- * DumpRenderTree/pthreads: Removed.
- * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
- 2013-05-09 Mario Sanchez Prada <mario.prada@samsung.com>
- Unreviewed. Update Simon Pena email on his behalf.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Add support for [NoInterfaceObject] Web IDL extended attribute
- https://bugs.webkit.org/show_bug.cgi?id=115714
- Reviewed by Kentaro Hara.
- Update BindingsTests.generate_supplemental_dependency() to pass an
- additional windowConstructorsFile argument to preprocess-idls.pl.
- * Scripts/webkitpy/bindings/main.py:
- (BindingsTests.generate_supplemental_dependency):
- (BindingsTests.main):
- 2013-05-09 ChangSeok Oh <changseok.oh@collabora.com>
- [GTK][AC] Buildfix after r149694
- https://bugs.webkit.org/show_bug.cgi?id=115797
- Reviewed by Gustavo Noronha Silva.
- Add CLUTTER_LIBS for linking TestWebCore.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-05-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
- [EFL] Remove unnecessary pkgs in EFL jhbuild
- https://bugs.webkit.org/show_bug.cgi?id=114908
- Reviewed by Laszlo Gombos.
- p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
- handle them using jhbuild. We can reduce build time when using --update-efl.
- * efl/jhbuild.modules:
- 2013-05-08 Seokju Kwon <seokju.kwon@gmail.com>
- [EFL] Disable SHADOW DOM feature in FeatureList.pm
- https://bugs.webkit.org/show_bug.cgi?id=115834
- Reviewed by Gyuyoung Kim.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-05-08 Lucas Forschler <lforschler@apple.com>
- Add Scheduler for Mac MtnLion 32bit Release builder.
-
- Unreviewed.
-
- * BuildSlaveSupport/build.webkit.org-config/config.json:
- 2013-05-08 Denis Nomiyama <d.nomiyama@samsung.com>
- Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
- https://bugs.webkit.org/show_bug.cgi?id=115808
- Reviewed by Darin Adler.
- The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
- was left outdated after r127191, when the m_string member was changed
- from UString to String. This patch calls the right pretty printer for it.
- * gdb/webkit.py:
- (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
- WTFImplPrettyPrinter.
- 2013-05-08 Andy Estes <aestes@apple.com>
- [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
- https://bugs.webkit.org/show_bug.cgi?id=115790
- Reviewed by Alexey Proskuryakov.
- Added two API tests:
- 1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
- 2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
- (TestWebKitAPI):
- (TestWebKitAPI::decidePolicyForNavigationAction):
- (CustomProtocolInvalidSchemeTest):
- (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
- 2013-05-08 Lucas Forschler <lforschler@apple.com>
- Teach buildbot how to compile 32-bit on Mac.
- Reviewed by Ryosuke Niwa.
- * BuildSlaveSupport/build.webkit.org-config/master.cfg:
- (CompileWebKit.start):
- (ExtractTestResultsAndLeaks):
- 2013-05-08 Eli Fidler <efidler@blackberry.com>
- [BlackBerry] Fix usage of BlackBerry::Platform::String
- https://bugs.webkit.org/show_bug.cgi?id=115781
- Reviewed by Rob Buis.
- BlackBerry PRs 304193 and 327181
- Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
- We currently have a problem where we're passing UTF-8 encoded data into
- the char* constructors of BlackBerry::Platform::String. This means the string
- thinks its data is not UTF-8.
- * DumpRenderTree/blackberry/DumpRenderTree.cpp:
- (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- (BlackBerry::WebKit::dumpHistoryItem):
- * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- (TestRunner::setUserStyleSheetLocation):
- * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
- (LoadHTMLStringItem::invoke):
- 2013-05-08 Alberto Garcia <agarcia@igalia.com>
- Tools: add new BlackBerry include dirs.
- https://bugs.webkit.org/show_bug.cgi?id=115514
- Reviewed by Rob Buis.
- iType include dirs are missing, and HarfBuzz needs to be fixed.
- * Scripts/webkitdirs.pm:
- (blackberryCMakeArguments):
- 2013-05-08 José Dapena Paz <jdapena@igalia.com> and Zan Dobersek <zdobersek@igalia.com>
- [GTK] Plumb the Automake build system for the Battery Status API feature
- https://bugs.webkit.org/show_bug.cgi?id=115718
- Reviewed by Martin Robinson.
- * Scripts/webkitdirs.pm:
- (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
- through the --(enable|disable)-battery-status flag passed to configure.
- 2013-05-08 Ryosuke Niwa <rniwa@webkit.org>
- new-run-webkit-websocketserver doesn't work after Chromium removal
- https://bugs.webkit.org/show_bug.cgi?id=115816
- Reviewed by Joseph Pecoraro.
- Fix the bug by instantiating the correct port object.
- * Scripts/new-run-webkit-websocketserver:
- (main):
- 2013-05-07 Lucas Forschler <lforschler@apple.com>
- Configure buildbot for 32bit builder.
- https://bugs.webkit.org/show_bug.cgi?id=115769
-
- Reviewed by Ryosuke Niwa.
- * BuildSlaveSupport/build.webkit.org-config/config.json:
- 2013-05-08 Brent Fulgham <bfulgham@webkit.org>
- Unreviewed. Update to show my apple.com address.
- * Scripts/webkitpy/common/config/contributors.json: Added
- my apple.com e-mail address.
- 2013-05-08 David Kilzer <ddkilzer@apple.com>
- BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
- * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
- (concatenateAttributeAndValue): Switch to appendVector().
- 2013-05-08 Andras Becsi <andras.becsi@digia.com>
- [Qt][WTR] Fix the build on Mac after r149692
- Unreviewed build fix.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- 2013-05-08 Mario Sanchez Prada <mario.prada@samsung.com>
- Unreviewed. Added Anton Obzhirov to the list of contributors and myself
- to the watchlist for Accessibility.
- * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
- * Scripts/webkitpy/common/config/watchlist: Added myself.
- 2013-05-08 Andras Becsi <andras.becsi@digia.com>
- [Qt] Build fails with clang
- https://bugs.webkit.org/show_bug.cgi?id=115741
- Reviewed by Benjamin Poulain.
- Since r149112 std::move is used in AtomicString for compilers that
- support rvalue references and this requires a standard library
- implementing c++11 move semantics.
- We only explicitely require c++11 for WebKit2, but since clang supports
- rvalue references the build of subtargets using AtomicString fails because
- of missing std::move.
- It is safe to add CONFIG += c++11 for the whole project when using clang
- since we explicitely disable c++11 for ANGLE that had probems with libc++.
- * qmake/mkspecs/features/unix/default_pre.prf:
- 2013-05-08 Darin Adler <darin@apple.com>
- Fix one more place that needed to use adoptCF/NS
- https://bugs.webkit.org/show_bug.cgi?id=115778
- Reviewed by Benjamin Poulain.
- Not sure why I missed this code last time, but found a bit more code that needs
- to switch to the newer style adoptCF/NS.
- * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
- (convertWebResourceDataToString): Use adoptCF.
- (convertWebResourceResponseToDictionary): Ditto.
- (createXMLStringFromWebArchiveData): Ditto.
- * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
- (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
- 2013-05-08 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r149271.
- http://trac.webkit.org/changeset/149271
- https://bugs.webkit.org/show_bug.cgi?id=115780
- The mangled symbols are now enforced through LDFLAGS
- (Requested by zdobersek on #webkit).
- * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
- 2013-05-08 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
- https://bugs.webkit.org/show_bug.cgi?id=115636
- Reviewed by Ryosuke Niwa.
- * TestResultServer/static-dashboards/flakiness_dashboard.js:
- (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
- through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
- while Chromium-specific, can't be removed just yet as there's more code that uses it.
- 2013-05-06 Darin Adler <darin@apple.com>
- Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
- https://bugs.webkit.org/show_bug.cgi?id=115657
- Reviewed by Sam Weinig.
- This is similar to my last set of changes, but covers code that I missed with
- global replace using the Safari Xcode workspace.
- * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
- (convertWebResourceDataToString):
- (convertWebResourceResponseToDictionary):
- (createXMLStringFromWebArchiveData):
- * DumpRenderTree/cg/ImageDiffCG.cpp:
- (createImageFromStdin):
- (createDifferenceImage):
- (main):
- * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
- (printPNG):
- (dumpBitmap):
- * DumpRenderTree/cg/PixelDumpSupportCG.h:
- (BitmapContext::BitmapContext):
- * DumpRenderTree/mac/MockWebNotificationProvider.mm:
- (-[MockWebNotificationProvider init]):
- * DumpRenderTree/mac/PixelDumpSupportMac.mm:
- (createBitmapContext):
- * DumpRenderTree/mac/TestRunnerMac.mm:
- (TestRunner::addDisallowedURL):
- (TestRunner::applicationCacheDiskUsageForOrigin):
- (TestRunner::localStorageDiskUsageForOrigin):
- (TestRunner::clearApplicationCacheForOrigin):
- (TestRunner::deleteLocalStorageForOrigin):
- (TestRunner::copyDecodedHostName):
- (TestRunner::copyEncodedHostName):
- (TestRunner::queueLoad):
- (TestRunner::setDomainRelaxationForbiddenForURLScheme):
- (TestRunner::setMockGeolocationPositionUnavailableError):
- (TestRunner::setUserStyleSheetLocation):
- (TestRunner::setValueForUser):
- (TestRunner::overridePreference):
- (TestRunner::setPersistentUserStyleSheetLocation):
- (TestRunner::execCommand):
- (TestRunner::findString):
- (TestRunner::isCommandEnabled):
- (TestRunner::addOriginAccessWhitelistEntry):
- (TestRunner::removeOriginAccessWhitelistEntry):
- (TestRunner::addUserScript):
- (TestRunner::addUserStyleSheet):
- (TestRunner::evaluateInWebInspector):
- (TestRunner::evaluateScriptInIsolatedWorld):
- (TestRunner::apiTestNewWindowDataLoadBaseURL):
- (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
- (TestRunner::authenticateSession):
- (TestRunner::grantWebNotificationPermission):
- (TestRunner::denyWebNotificationPermission):
- * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
- (createCFURLResponseFromResponseData):
- * DumpRenderTree/mac/WorkQueueItemMac.mm:
- (LoadItem::invoke):
- (LoadHTMLStringItem::invoke):
- (ScriptItem::invoke):
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (substringFromIndex):
- (urlSuitableForTestResult):
- (lastPathComponent):
- (sharedCFURLCache):
- * DumpRenderTree/win/ImageDiffCairo.cpp:
- (createImageFromStdin):
- (main):
- * DumpRenderTree/win/PixelDumpSupportWin.cpp:
- (createBitmapContextFromWebView):
- * DumpRenderTree/win/TestRunnerWin.cpp:
- (TestRunner::setUserStyleSheetLocation):
- (TestRunner::setPersistentUserStyleSheetLocation):
- * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
- (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
- * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
- (TestWebKitAPI::createWindow):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
- (TestWebKitAPI::AcceptsFirstMouse::runTest):
- * TestWebKitAPI/Tests/mac/AttributedString.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/BackForwardList.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
- (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
- * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
- (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
- * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/InspectorBar.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
- (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
- (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
- * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
- (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
- (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
- * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
- (WTR::testPathFromURL):
- * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
- (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- * WebKitTestRunner/cg/TestInvocationCG.cpp:
- (WTR::createCGContextFromImage):
- (WTR::dumpBitmap):
- (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- * WebKitTestRunner/mac/EventSenderProxy.mm:
- (WTR::EventSenderProxy::mouseScrollBy):
- * WebKitTestRunner/mac/PlatformWebViewMac.mm:
- (WTR::PlatformWebView::windowSnapshotImage):
- * WebKitTestRunner/win/TestControllerWin.cpp:
- (WTR::TestController::initializeTestPluginDirectory):
- Use adoptCF and adoptNS.
- 2013-05-07 Alex Christensen <achristensen@apple.com>
- Fix a memory leak introduced in r149692
- https://bugs.webkit.org/show_bug.cgi?id=115766
- Reviewed by Mark Rowe.
- In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
- matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
- 2013-05-07 Darin Adler <darin@apple.com>
- [Win] Fix storage leak in Windows DumpRenderTree
- https://bugs.webkit.org/show_bug.cgi?id=115651
- Reviewed by Sam Weinig.
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (lastPathComponent): Added a missing call to adoptCF.
- 2013-05-07 Alex Christensen <achristensen@apple.com>
- fixed a memory leak introduced by bug 42324 by using a RetainPtr
- https://bugs.webkit.org/show_bug.cgi?id=115760
- Reviewed by Tim Horton.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- fixed memory leak, added UNUSED_PARAM macros
- 2013-05-07 Alex Christensen <achristensen@apple.com>
- WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
- https://bugs.webkit.org/show_bug.cgi?id=42324
- <rdar://problem/8193633>
- Reviewed by Tim Horton.
- * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
- * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- Added dumpDOMAsWebArchive code that is called when dumping.
- (WTR::InjectedBundlePage::dump):
- Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
- * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- (InjectedBundlePage):
- Added dumpDOMAsWebArchive declaration.
- * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
- (WTR::TestRunner::dumpDOMAsWebArchive):
- Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
- * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
- * Tools/WebKitTestRunner/cf: Added.
- * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
- Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
- (convertMIMEType):
- (convertWebResourceDataToString):
- (normalizeHTTPResponseHeaderFields):
- (normalizeWebResourceURL):
- (convertWebResourceResponseToDictionary):
- (compareResourceURLs):
- (createXMLStringFromWebArchiveData):
- * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
- Copied from Tools/DumpRenderTree/cf for used symbol declarations.
- * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
- Copied from Tools/DumpRenderTree/mac for used functions.
- (createCFURLResponseFromResponseData):
- (supportedNonImageMIMETypes):
- 2013-05-07 Alex Christensen <achristensen@apple.com>
- Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
- https://bugs.webkit.org/show_bug.cgi?id=115745
- Reviewed by Tim Horton.
- * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
- (compareResourceURLs):
- Updated style.
- 2013-05-06 Ryosuke Niwa <rniwa@webkit.org>
- Add an 'isReadOnly' member to IDL parse tree structure
- https://bugs.webkit.org/show_bug.cgi?id=115704
- Reviewed by Kentaro Hara.
- Use newly added isReadOnly attribute.
- * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
- (_generateHeaderFile):
- (_generateImplementationFile):
- (_staticValuesGetterImplementation):
- 2013-05-07 Anders Carlsson <andersca@apple.com>
- Remove AlwaysInline.h from WTF
- https://bugs.webkit.org/show_bug.cgi?id=115727
- Reviewed by Brent Fulgham.
- The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
- to keep AlwaysInline.h around anymore.
- * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
- * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
- 2013-05-07 Andras Becsi <andras.becsi@digia.com>
- [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
- https://bugs.webkit.org/show_bug.cgi?id=114808
- Reviewed by Jocelyn Turcotte.
- QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
- (https://codereview.qt-project.org/#change,54234)
- * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
- (WTR::WrapperWindow::handleStatusChanged):
- 2013-05-06 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed. Add my email to EFL and BindingsScripts watchlists.
- * Scripts/webkitpy/common/config/watchlist:
- 2013-05-06 Kangil Han <kangil.han@samsung.com>
- [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
- https://bugs.webkit.org/show_bug.cgi?id=115645
- Reviewed by Gyuyoung Kim.
- To run performance tests in wk1, we need --no-timeout option implementation.
- So adopt it from gtk+ port.
- * DumpRenderTree/efl/DumpRenderTree.cpp:
- (shouldSetWaitToDumpWatchdog):
- (parseCommandLineOptions):
- * DumpRenderTree/efl/DumpRenderTreeEfl.h:
- * DumpRenderTree/efl/TestRunnerEfl.cpp:
- (TestRunner::setWaitToDump):
- 2013-05-06 Commit Queue <commit-queue@webkit.org>
- Unreviewed, rolling out r149547.
- http://trac.webkit.org/changeset/149547
- https://bugs.webkit.org/show_bug.cgi?id=115682
- Added unittests that fail on bots and spits out text into
- stdout (Requested by rniwa on #webkit).
- * Scripts/import-w3c-tests: Removed.
- * Scripts/webkitpy/w3c/__init__.py: Removed.
- * Scripts/webkitpy/w3c/test_converter.py: Removed.
- * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
- * Scripts/webkitpy/w3c/test_importer.py: Removed.
- * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
- * Scripts/webkitpy/w3c/test_parser.py: Removed.
- * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
- 2013-05-03 Gustavo Noronha Silva <gns@gnome.org>
- [jhbuild] bump jhbuild version to take advantage of new improvements
- https://bugs.webkit.org/show_bug.cgi?id=115558
- Reviewed by Martin Robinson.
- One of the important improvements is jhbuild no longer fetches git
- repositories if they are already at the expected revision, which should
- make the EWS bots more robust to git servers unavailability.
- * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
- 2013-05-06 Manuel Rego Casasnovas <rego@igalia.com>
- [GTK] Add webkit_uri_scheme_request_finish_error
- https://bugs.webkit.org/show_bug.cgi?id=94316
- Reviewed by Anders Carlsson.
- * MiniBrowser/gtk/main.c:
- (miniBrowserErrorQuark): Add function to create a global quark for
- MiniBrowser.
- (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
- function webkit_uri_scheme_request_finish_error().
- 2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
- [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
- https://bugs.webkit.org/show_bug.cgi?id=113808
- Reviewed by Rob Buis.
- Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
- to true for BlackBerry.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-05-06 Jessie Berlin <jberlin@apple.com>
- check-webkit-style should complain about a layering violation if platform-specific guards are
- used in WebCore outside of the platform directory
- https://bugs.webkit.org/show_bug.cgi?id=115567
- Reviewed by Benjamin Poulain.
- * Scripts/webkitpy/style/checkers/cpp.py:
- (check_for_webcore_platform_layering_violation):
- If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
- (process_line):
- Add the check_for_webcore_platform_layering_violation.
- (CppChecker):
- List the new check.
- * Scripts/webkitpy/style/checkers/cpp_unittest.py:
- (CppStyleTest.test_webcore_platform_layering_violation):
- Add tests.
- 2013-05-06 David Kilzer <ddkilzer@apple.com>
- webkit-patch: fix 'upload' command with Bugzilla 4.2.5
- <http://webkit.org/b/115667>
- Reviewed by Dirk Pranke.
- * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- (Bugzilla._check_create_bug_response): Update regex to work with
- Bugzilla 3.2.3 and 4.2.5.
- * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
- (test__check_create_bug_response): Add new test that covers both
- old and new <title> variations.
- 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
- https://bugs.webkit.org/show_bug.cgi?id=115661
- Reviewed by Ryosuke Niwa.
- The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
- builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
- and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
- * TestResultServer/static-dashboards/flakiness_dashboard.js:
- * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
- https://bugs.webkit.org/show_bug.cgi?id=114603
- Reviewed by Ryosuke Niwa.
- * TestResultServer/generate_builders_json.py:
- (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
- to represent these to be 'layout-test', for backwards compatibility.
- (main): Remove all the build.chromium.org masters.
- * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
- (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
- (GenerateBuildersJsonTest):
- (GenerateBuildersJsonTest.test_generate_json_data):
- * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
- test-running builders from the webkit.org master.
- 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
- https://bugs.webkit.org/show_bug.cgi?id=114988
- Reviewed by Ryosuke Niwa.
- * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
- and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
- * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
- mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
- once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
- 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
- https://bugs.webkit.org/show_bug.cgi?id=114954
- Reviewed by Ryosuke Niwa.
- * TestResultServer/static-dashboards/flakiness_dashboard.js:
- (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
- modifier unions in the list of modifiers.
- (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
- * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
- 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
- [Flakiness Dashboard] Simplify builder-name-based platform recognition
- https://bugs.webkit.org/show_bug.cgi?id=114957
- Reviewed by Ryosuke Niwa.
- * TestResultServer/static-dashboards/flakiness_dashboard.js:
- (determineBuilderPlatform): Renamed from nonChromiumPlatform.
- (chromiumPlatform): Removed, unnecessary.
- (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
- to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
- the builder operates with debug builds, no webkit.org builders are named this way.
- * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
- 2013-05-06 Andy Estes <aestes@apple.com>
- Added two files I neglected to commit in r149589.
- * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
- * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
- 2013-05-04 Andy Estes <aestes@apple.com>
- REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
- https://bugs.webkit.org/show_bug.cgi?id=115609
- Reviewed by Oliver Hunt.
- Added an API test.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
- (+[TestDelegate shared]):
- (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- (-[TestDelegate webView:createWebViewWithRequest:]):
- (TestWebKitAPI):
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
- 2013-05-06 Antoine Quint <graouts@apple.com>
- Manage the presentation of the snapshotted plug-in using JavaScript
- https://bugs.webkit.org/show_bug.cgi?id=115548
- Reviewed by Dean Jackson.
- Take into account the new plugInExtraScript method added to support
- the injection of a JS file from the chrome client to customize the
- rendering of a snapshotted plug-in's shadow tree.
- * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- (WTR::InjectedBundlePage::InjectedBundlePage):
- 2013-05-05 Anders Carlsson <andersca@apple.com>
- Remove the Vector::append overload that takes a Vector
- https://bugs.webkit.org/show_bug.cgi?id=115535
- Reviewed by Andreas Kling.
- Use Vector::appendVector instead.
- * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- (concatenateAttributeAndValue):
- * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- (WTR::concatenateAttributeAndValue):
- 2013-05-04 Sam Weinig <sam@webkit.org>
- REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
- <rdar://problem/13702008>
- https://bugs.webkit.org/show_bug.cgi?id=115607
- Reviewed by Benjamin Poulain.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
- (TestWebKitAPI::didFinishLoadForFrame):
- (TestWebKitAPI::TEST):
- Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
- 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
- Unreviewed.
- * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
- 2013-05-04 Mihnea Ovidenie <mihnea@adobe.com>
- Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Catch select.error exceptions in parse_output_lines
- https://bugs.webkit.org/show_bug.cgi?id=115253
- Reviewed by Gustavo Noronha Silva.
- Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
- output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
- builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
- error code and the error message) and the loop is re-entered.
- * gtk/common.py:
- (parse_output_lines):
- 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Set up the TestWebCore in TestWebKitAPI
- https://bugs.webkit.org/show_bug.cgi?id=115237
- Reviewed by Gustavo Noronha Silva.
- Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
- Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
- a workaround for the layer violations and circular dependencies between various static libraries. Linking against
- either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
- shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
- * TestWebKitAPI/GNUmakefile.am:
- 2013-05-03 Rebecca Hauck <rhauck@adobe.com>
- Create a script to import W3C tests
- https://bugs.webkit.org/show_bug.cgi?id=111513
- Reviewed by Dirk Pranke.
- Script to automate the import of W3C tests into WebKit.
- For the full description of how it works, see the comments
- at the top of test_importer.py.
- * Scripts/import-w3c-tests: Added.
- * Scripts/webkitpy/w3c/__init__.py: Added.
- * Scripts/webkitpy/w3c/test_converter.py: Added.
- (TestConverter):
- (TestConverter.__init__):
- (TestConverter.load_prefixed_prop_list):
- (TestConverter.load_file):
- (TestConverter.convert_for_webkit):
- (TestConverter.convert_testharness_paths):
- (TestConverter.convert_prefixed_properties):
- (TestConverter.scrub_unprefixed_props):
- (TestConverter.replace_tag):
- * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
- (TestConverterTest):
- (TestConverterTest.testLoadPrefixedPropList):
- (TestConverterTest.test_convertForWebkitNothingToConvert):
- (test_convertForWebkitHarnessOnly):
- (test_convertForWebkitPropsOnly):
- (test_convertForWebkitHarnessAndProps):
- (test_convertTestHarnessPaths):
- (test_convertPrefixedProperties):
- (verifyTestHarnessPaths):
- (verifyPrefixedProperties):
- (generateTestContent):
- * Scripts/webkitpy/w3c/test_importer.py: Added.
- (main):
- (parse_args):
- (validate_import_directory):
- (TestImporter):
- (TestImporter.__init__):
- (TestImporter.do_import):
- (TestImporter.get_changeset):
- (TestImporter.scan_source_directory):
- (TestImporter.import_tests):
- (TestImporter.setup_destination_directory):
- (TestImporter.get_test_status):
- (TestImporter.remove_deleted_files):
- (TestImporter.write_import_log):
- * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
- (TestImporterTest):
- (TestImporterTest.test_ImportDirWithNoTests):
- * Scripts/webkitpy/w3c/test_parser.py: Added.
- (TestParser):
- (TestParser.__init__):
- (TestParser.load_file):
- (TestParser.analyze_test):
- (TestParser.get_reftests):
- (TestParser.is_jstest):
- (TestParser.get_support_files):
- * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
- (TestParserTest):
- (TestParserTest.test_analyzeTestReftestOneMatch):
- (test_analyzeTestReftestMultipleMatches):
- (test_analyzeTestReftestMatchAndMismatch):
- (test_analyzeTestReftestWithRefSupportFiles):
- (test_analyzeJSTest):
- (test_analyzePixelTestAllTrue):
- (test_analyzePixelTestAllFalse):
- (test_analyzeNonHTMLFile):
- 2013-05-03 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-05-02 Nico Weber <thakis@chromium.org>
- Remove a stale script file.
- https://bugs.webkit.org/show_bug.cgi?id=115521
- Reviewed by Anders Carlsson.
- This script was added in
- https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
- Bakefile system that was removed in
- https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
- script just asserts when it's run and is useless.
- * Scripts/update-sources-list.py: Removed.
- 2013-05-01 Glenn Adams <glenn@skynav.com>
- [webkitpy] Need abstract base class for commands that analyze commit logs
- https://bugs.webkit.org/show_bug.cgi?id=115391
- Reviewed by Benjamin Poulain.
- Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
- in preparation for adding two new commands that will reuse this functionality along with
- suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
- https://bugs.webkit.org/show_bug.cgi?id=115388.
- No new tests as this patch does not change existing functionality or behavior.
- * Scripts/webkitpy/tool/commands/suggestnominations.py:
- (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
- (AbstractCommitLogCommand.__init__):
- (AbstractCommitLogCommand._init_options):
- (AbstractCommitLogCommand._parse_commit_message):
- (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
- (SuggestNominations.__init__):
- (SuggestNominations._init_options):
- 2013-05-01 Seokju Kwon <seokju.kwon@gmail.com>
- Web Inspector: Fix check-inspector-strings script and fix localized strings
- https://bugs.webkit.org/show_bug.cgi?id=115495
- Reviewed by Joseph Pecoraro.
- * Scripts/check-inspector-strings:
- 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
- [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
- https://bugs.webkit.org/show_bug.cgi?id=115470
- Reviewed by Martin Robinson.
- In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
- not building either of the IOS, Windows or GTK-WK1 platforms.
- Up until now the header was included for everything but the IOS and Windows platforms due to
- an incorrectly stated condition regarding the GTK platform.
- * TestWebKitAPI/config.h:
- 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
- https://bugs.webkit.org/show_bug.cgi?id=115469
- Reviewed by Martin Robinson.
- Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
- for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
- for the WebKit2 tests and the injected bundle required by them.
- This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
- tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
- under the WebKit2 code).
- The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
- while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
- TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-04-30 Glenn Adams <glenn@skynav.com>
- Unreviewed. Add myself to watchlist entries.
- * Scripts/webkitpy/common/config/watchlist:
- 2013-04-30 Glenn Adams <glenn@skynav.com>
- [webkitpy] suggest-nominations doesn't count all qualified patches
- https://bugs.webkit.org/show_bug.cgi?id=115285
- Reviewed by Benjamin Poulain.
- Fix commit analysis so that patches made by an existing committer are counted towards reviewer
- nomination. Improve commit log parsing.
- * Scripts/webkitpy/tool/commands/suggestnominations.py:
- (CommitLogError):
- (CommitLogError.__init__):
- (CommitLogMissingReviewer):
- (CommitLogMissingReviewer.__init__):
- (SuggestNominations):
- (SuggestNominations.__init__):
- (SuggestNominations._recent_commit_messages):
- (SuggestNominations._author_name_from_email):
- (SuggestNominations._contributor_from_email):
- (SuggestNominations._parse_commit_message):
- (SuggestNominations._count_commit):
- (SuggestNominations._count_recent_patches):
- (SuggestNominations._collect_nominations):
- (SuggestNominations._print_nominations):
- (SuggestNominations.execute):
- * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
- (_make_options):
- (test_recent_commit_messages):
- (test_basic):
- 2013-04-30 Commit Queue <rniwa@webkit.org>
- Unreviewed, rolling out r149309.
- http://trac.webkit.org/changeset/149309
- https://bugs.webkit.org/show_bug.cgi?id=115430
- The patch does not build on WK1-only builds of the GTK port
- (Requested by zdobersek on #webkit).
- * TestWebKitAPI/GNUmakefile.am:
- 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Stop using "in" keyword in IDL files
- https://bugs.webkit.org/show_bug.cgi?id=115418
- Reviewed by Kentaro Hara.
- Remove "in" keyword from IDL files as this is no longer part of the Web
- IDL specification.
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
- 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
- [EFL] Enable scaled cursors
- https://bugs.webkit.org/show_bug.cgi?id=106242
- Reviewed by Gyuyoung Kim.
- Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Replace "Optional" extended attribute by proper Web IDL "optional" keyword
- https://bugs.webkit.org/show_bug.cgi?id=115380
- Reviewed by Kentaro Hara.
- Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
- keyword.
- * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- 2013-04-30 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
- Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
- https://bugs.webkit.org/show_bug.cgi?id=114684
- Reviewed by Simon Hausmann.
- Remove the ANGLE requirement for USE(3D_GRAPHICS).
- This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
- * qmake/mkspecs/features/features.prf:
- 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Disable Shadow DOM feature
- https://bugs.webkit.org/show_bug.cgi?id=115374
- Reviewed by Martin Robinson.
- Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-04-29 Glenn Adams <glenn@skynav.com>
- [webkitpy] Add missing contributor email addresses
- https://bugs.webkit.org/show_bug.cgi?id=115394
- Reviewed by Ryosuke Niwa.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-04-29 Alberto Garcia <agarcia@igalia.com>
- Remove all remaining Skia code
- https://bugs.webkit.org/show_bug.cgi?id=115263
- Reviewed by Benjamin Poulain.
- Remove all remaining references to Skia.
- * Scripts/webkitdirs.pm:
- (blackberryCMakeArguments):
- * Scripts/webkitpy/common/config/contributionareas.py:
- * Scripts/webkitpy/common/config/watchlist:
- 2013-04-29 Seokju Kwon <seokju.kwon@gmail.com>
- Get rid of unused options in Tools/Scripts/webkit-build-directory
- https://bugs.webkit.org/show_bug.cgi?id=115383
- Reviewed by Darin Adler.
- * Scripts/webkit-build-directory:
- 2013-04-29 Alexey Proskuryakov <ap@apple.com>
- [WK2][Mac] Test with NetworkProcess enabled.
- Fix the build for non-Mac.
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::initialize):
- 2013-04-29 Alexey Proskuryakov <ap@apple.com>
- [WK2][Mac] Test with NetworkProcess enabled.
- Reviewed by Sam Weinig.
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::initialize):
- 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Set up the TestWebCore in TestWebKitAPI
- https://bugs.webkit.org/show_bug.cgi?id=115237
- Reviewed by Gustavo Noronha Silva.
- Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
- Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
- a workaround for the layer violations and circular dependencies between various static libraries. Linking against
- either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
- shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
- * TestWebKitAPI/GNUmakefile.am:
- 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
- https://bugs.webkit.org/show_bug.cgi?id=115236
- Reviewed by Gustavo Noronha Silva.
- Set up the TestJavaScriptCore unit test program, consisting of the unit tests
- under the TestWebKitAPI/Tests/JavaScriptCore directory.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
- https://bugs.webkit.org/show_bug.cgi?id=115323
- Reviewed by Philippe Normand.
- Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
- Its presence enforces linkers to output mangled symbols when reporting linking failures
- due to unresolved references. People trying to fix the build can then simply copy
- the printed mangled symbol into the symbols.filter file instead of doing a manual build
- or connecting to the builders to discover the mangled version of the missing symbol.
- * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
- 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
- Remove Chromium code from Tools/BuildSlaveSupport
- https://bugs.webkit.org/show_bug.cgi?id=115325
- Reviewed by Benjamin Poulain.
- Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
- covering archiving test results and built products.
- * BuildSlaveSupport/built-product-archive:
- (archiveBuiltProduct):
- (extractBuiltProduct):
- * BuildSlaveSupport/chromium/output-android-device-status: Removed.
- * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
- * BuildSlaveSupport/test-result-archive:
- (archiveTestResults):
- 2013-04-28 Seokju Kwon <seokju.kwon@gmail.com>
- Remove support for Chromium from webkitdirs.pm
- https://bugs.webkit.org/show_bug.cgi?id=115338
- Reviewed by Darin Adler.
- * Scripts/webkitdirs.pm:
- (determineBaseProductDir):
- (argumentsForConfiguration):
- (builtDylibPathForName):
- (determineIsQt):
- (isAppleWebKit):
- 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
- Rename TestRunner's setAudioData to setAudioResult
- https://bugs.webkit.org/show_bug.cgi?id=115326
- Reviewed by Darin Adler.
- Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
- than the previous one. The change is a simple rename, there's no change in the method's functionality. The
- affected tests are adjusted accordingly.
- * DumpRenderTree/qt/TestRunnerQt.cpp:
- (TestRunnerQt::setAudioResult):
- * DumpRenderTree/qt/TestRunnerQt.h:
- (TestRunnerQt):
- * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- (WTR::TestRunner::setAudioResult):
- * WebKitTestRunner/InjectedBundle/TestRunner.h:
- (TestRunner):
- 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
- [WKTR] Tests dumping audio data shouldn't dump pixels
- https://bugs.webkit.org/show_bug.cgi?id=115270
- Reviewed by Benjamin Poulain.
- Prevent dumping the pixel output when Web Audio tests are dumping output data
- as the testing output. Pixel output in these tests has no real meaning and is
- as such unnecessary.
- * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- (WTR::TestRunner::setAudioData):
- 2013-04-27 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
- [EFL] Unreviewed Intel bots fix after r149231.
- * efl/jhbuild.modules: Disable the libxml Python bindings since the
- bots don't have Python's development files installed. libxml should
- detect this kind of thing better.
- 2013-04-26 Ryuan Choi <ryuan.choi@samsung.com>
- [EFL] Build break using jhbuild on ubuntu 13.04
- https://bugs.webkit.org/show_bug.cgi?id=115225
- Reviewed by Gyuyoung Kim.
- libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
- libxml 2.9.0 has a bug to make regression which r138422 mentioned.
- So this patch bumped libxml version to 2.9.1.
- * efl/jhbuild.modules:
- 2013-04-26 Jeffrey Pfau <jpfau@apple.com>
- delete-stale-build-files does not clear .d files
- http://bugs.webkit.org/show_bug.cgi?id=115293
- Reviewed by Ryosuke Niwa.
- * BuildSlaveSupport/delete-stale-build-files:
- (main): Add .d to the file type list
- 2013-04-26 Roger Fong <roger_fong@apple.com>
- Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
- Make the DebugSuffix configuration use _debug dependencies.
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
- * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
- * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
- * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
- * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
- * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
- * win/AssembleBuildLogs/AssembleLogs.cmd:
- * win/record-memory/record-memory.vcxproj:
- * win/record-memory/record-memoryDebug.props:
- * win/record-memory/record-memoryDebugWinCairo.props:
- * win/record-memory/record-memoryProduction.props:
- * win/record-memory/record-memoryRelease.props:
- * win/record-memory/record-memoryReleaseWinCairo.props:
- 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
- [GTK] Clean up the TestWebKitAPI GNUmakefile.am
- https://bugs.webkit.org/show_bug.cgi?id=115233
- Reviewed by Martin Robinson.
- Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
- WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
- Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
- Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
- be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
- * TestWebKitAPI/GNUmakefile.am:
- 2013-04-25 Andy Estes <aestes@apple.com>
- [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
- https://bugs.webkit.org/show_bug.cgi?id=115223
- Reviewed by Darin Adler.
- Added an API test.
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
- (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
- when it loads a request with a custom protocol.
- * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
- * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
- NSURLProtocol subclass to TestProtocol.{h, mm} and did some
- miscellaneous cleanup.
- * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
- * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
- (+[TestProtocol canInitWithRequest:]):
- (+[TestProtocol canonicalRequestForRequest:]):
- (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
- (+[TestProtocol scheme]):
- (-[TestProtocol startLoading]):
- (-[TestProtocol stopLoading]):
- 2013-04-26 Martin Robinson <mrobinson@igalia.com>
- Remove the remaining Skia #ifdefs
- https://bugs.webkit.org/show_bug.cgi?id=114886
- Reviewed by Benjamin Poulain.
- * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
- (createBitmapContextFromWebView): Remove Skia #ifdef references.
- 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Clean up load interface in WebPage
- https://bugs.webkit.org/show_bug.cgi?id=113267
- Reviewed by Rob Buis.
- Update DumpRenderTree with change of load() interface in WebPage.
- RIM Bug# 315535, internally reviewed by Joe Mason.
- * DumpRenderTree/blackberry/DumpRenderTree.cpp:
- (BlackBerry::WebKit::DumpRenderTree::runTest):
- 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
- Remove the HeapGraphSerializer unit test
- https://bugs.webkit.org/show_bug.cgi?id=115231
- Reviewed by Andreas Kling.
- Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
- specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
- * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
- 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
- Remove support for Chromium from build/update scripts
- https://bugs.webkit.org/show_bug.cgi?id=115218
- Reviewed by Darin Adler.
- * Scripts/build-webkit:
- (writeCongrats):
- * Scripts/update-webkit:
- 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
- Remove support for Chromium from api-test
- https://bugs.webkit.org/show_bug.cgi?id=115211
- Reviewed by Dirk Pranke.
- * Scripts/build-api-tests:
- * Scripts/run-api-tests:
- (isSupportedPlatform):
- 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
- Get rid of Chromium in build-dumprendertree
- https://bugs.webkit.org/show_bug.cgi?id=115212
- Reviewed by Dirk Pranke.
- * Scripts/build-dumprendertree:
- 2013-04-25 Alexey Proskuryakov <ap@apple.com>
- Pass relatedPage when creating a page in WebKitTestRunner
- https://bugs.webkit.org/show_bug.cgi?id=115206
- Reviewed by Geoffrey Garen.
- To make sure that window.open() opens in the same process even when using multiple processes.
- * WebKitTestRunner/PlatformWebView.h:
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::createOtherPage):
- (WTR::TestController::createWebViewWithOptions):
- * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
- (WTR::PlatformWebView::PlatformWebView):
- * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
- (WTR::PlatformWebView::PlatformWebView):
- * WebKitTestRunner/mac/PlatformWebViewMac.mm:
- (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
- (WTR::PlatformWebView::PlatformWebView):
- * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
- (WTR::PlatformWebView::PlatformWebView):
- * WebKitTestRunner/win/PlatformWebViewWin.cpp:
- (WTR::PlatformWebView::PlatformWebView):
- 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
- Fix autocompletion for Benjamin. The Bugzilla email address must come first.
- * Scripts/webkitpy/common/config/contributors.json:
- 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
- Build fix. Forgot to merge args.
- * Scripts/webkitpy/tool/bot/irc_command.py:
- (Hi.execute):
- 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
- webkitbot should recognize its own nickname in greetings.
- https://bugs.webkit.org/show_bug.cgi?id=115196
- Reviewed by Andreas Kling.
- Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
- * Scripts/webkitpy/tool/bot/irc_command.py:
- (Hi.execute):
- 2013-04-25 Xavier Castano <xcastanho@igalia.com>
- [GTK] Tools/gtk/install-dependencies added ragel dependency
- https://bugs.webkit.org/show_bug.cgi?id=115163
- Reviewed by Xan Lopez.
- The install-dependencies script was missing a dependency on ragel
- which is expected when building HarfBuzz.
- * gtk/install-dependencies: Added a dependency on ragel for both
- apt and yum.
- 2013-04-25 Eduardo Lima Mitev <elima@igalia.com>
- [GTK] Remove pango from optional jhbuild dependencies
- https://bugs.webkit.org/show_bug.cgi?id=115162
- Reviewed by Martin Robinson.
- Pango is not needed since revision r148293 that lowers the pango
- dependency to 1.30, which is available in most distributions.
- * gtk/jhbuild-optional.modules: Removes description of pango module.
- 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
- Remove Chromium-specific cases from FeatureList.pm
- https://bugs.webkit.org/show_bug.cgi?id=115169
- Reviewed by Andreas Kling.
- * Scripts/webkitperl/FeatureList.pm:
- 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
- Remove checking chromium from run-webkit-tests
- https://bugs.webkit.org/show_bug.cgi?id=115139
- Reviewed by Benjamin Poulain.
- * Scripts/run-webkit-tests:
- (useNewRunWebKitTests):
- 2013-04-24 Simon Fraser <simon.fraser@apple.com>
- Pixel tests in SVG are all broken in WK2
- https://bugs.webkit.org/show_bug.cgi?id=114218
- Reviewed by Darin Adler.
-
- Window snapshots in WebKitTestRunner on Mac are window-sized
- (800x600), which is wrong for the W3C SVG tests that require a
- 480x360 snapshot.
-
- Fix by resizing the window, as well as the web view in
- PlatformWebView::resizeTo() so that window snapshots are correctly
- sized.
-
- Also do some drive-by cleanup of the window size constants in both
- DRT and WTR to remove magic numbers, and make the code more similar.
-
- * DumpRenderTree/TestRunner.cpp:
- (TestRunner::setShouldPaintBrokenImage):
- * DumpRenderTree/TestRunner.h:
- * DumpRenderTree/efl/DumpRenderTree.cpp:
- * DumpRenderTree/gtk/DumpRenderTree.cpp:
- (webInspectorShowWindow):
- * DumpRenderTree/mac/DumpRenderTree.mm:
- (createWebViewAndOffscreenWindow):
- (sizeWebViewForCurrentTest):
- * DumpRenderTree/mac/DumpRenderTreeMac.h:
- * DumpRenderTree/mac/PixelDumpSupportMac.mm:
- (createPagedBitmapContext):
- * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- (DumpRenderTree::DumpRenderTree):
- (DumpRenderTree::open):
- * DumpRenderTree/qt/TestRunnerQt.cpp:
- * DumpRenderTree/qt/TestRunnerQt.h:
- * DumpRenderTree/win/DumpRenderTree.cpp:
- (sizeWebViewForCurrentTest):
- * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::resetStateToConsistentValues):
- * WebKitTestRunner/TestController.h:
- * WebKitTestRunner/TestInvocation.cpp:
- (WTR::sizeWebViewForCurrentTest):
- * WebKitTestRunner/mac/PlatformWebViewMac.mm:
- (WTR::PlatformWebView::PlatformWebView):
- (WTR::PlatformWebView::resizeTo):
- 2013-04-24 Byungwoo Lee <bw80.lee@samsung.com>
- [EFL] Fix build error after r148963.
- https://bugs.webkit.org/show_bug.cgi?id=115126
- Reviewed by Laszlo Gombos.
- Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
- * TestWebKitAPI/PlatformEfl.cmake:
- 2013-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
- [GTK] Use stamp files for generate-forwarding-headers makefile rules
- https://bugs.webkit.org/show_bug.cgi?id=115118
- Reviewed by Martin Robinson.
- Use a stamp file for the TestWebKitAPI and WebKitTestRunner
- forwarding generator rules and don't call it for soup since there
- aren't soup directories in TestWebKitAPI and WebKitTestRunner.
- * TestWebKitAPI/GNUmakefile.am:
- * WebKitTestRunner/GNUmakefile.am:
- 2013-04-24 Simon Pena <simon.pena@samsung.com>
- [GTK] Update build dependencies
- https://bugs.webkit.org/show_bug.cgi?id=115111
- Reviewed by Martin Robinson.
- The install-dependencies script was missing a dependency on EGL,
- which is expected when building Cairo.
- * gtk/install-dependencies: Added a dependency on libegl1-mesa
- for both apt and yum.
- 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
- Remove the Chromium-specific helper from run_webkit_tests.py
- https://bugs.webkit.org/show_bug.cgi?id=114996
- Reviewed by Dirk Pranke.
- * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- (parse_args):
- 2013-04-24 Sergio Correia <sergio.correia@openbossa.org>
- [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
- https://bugs.webkit.org/show_bug.cgi?id=114850
- Reviewed by Andreas Kling.
- Revision r148312 fixed WebPageProxy cleanup and also changed the process
- termination semantics when requested by the user so that a client is not
- notified of a crash anymore, since there was no crash anyway.
- That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
- relied on being notified of a crash after calling WKPageTerminate(). As
- a result of not being notified of such non-existent crash, the test would
- timeout right after making the terminate call.
- This patch adds an InjectedBundle to be used for simulating a crash, by
- calling abort() upon receiving a "Crash" message, and thus we are able to
- keep testing the crash callback.
- This patch also re-enables the WKViewClientWebProcessCallbacks test, which
- had been disabled in revisions r148858 and r148855, since it was failing.
- * TestWebKitAPI/PlatformEfl.cmake:
- * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
- (TestWebKitAPI::TEST):
- * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
- (TestWebKitAPI):
- (WKViewClientWebProcessCallbacksTest):
- (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
- (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
- 2013-04-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
- [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
- https://bugs.webkit.org/show_bug.cgi?id=115095
- Reviewed by Antonio Gomes.
- Use different subfolders under DumpRenderTree Temp folder for every
- functionality (icon database, cache, localstorage, ...). This makes
- sure there is no conflict between the functionalities.
- In EFL's case, libsoup cache was causing problems for the icon
- database if sharing the same folder.
- * WebKitTestRunner/TestController.cpp:
- (WTR::TestController::initialize):
- == Rolled over to ChangeLog-2013-04-24 ==
|