ChangeLog 81 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092
  1. 2013-06-17 Tiancheng Jiang <tijiang@rim.com>
  2. Cache FatFinger Text Result.
  3. https://bugs.webkit.org/show_bug.cgi?id=107403.
  4. Reviewed by Rob Buis.
  5. Internally Reviewed by Genevieve Mak.
  6. Cache the FatFinger text result for later use in TouchEventHandler.
  7. * Api/WebPage.cpp:
  8. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  9. * WebKitSupport/SelectionHandler.cpp:
  10. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  11. * WebKitSupport/TouchEventHandler.h:
  12. (BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
  13. (TouchEventHandler):
  14. 2013-06-14 Alberto Garcia <agarcia@igalia.com>
  15. [BlackBerry] Remove implementation of ContextMenu classes
  16. https://bugs.webkit.org/show_bug.cgi?id=114860
  17. Reviewed by Rob Buis.
  18. This code is not being used so we can safely remove it.
  19. * Api/WebPage.cpp:
  20. (BlackBerry::WebKit::WebPagePrivate::init):
  21. * WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
  22. * WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
  23. 2013-06-14 Arvid Nilsson <anilsson@rim.com>
  24. [BlackBerry] LayerTiler fails to tile really big layers
  25. https://bugs.webkit.org/show_bug.cgi?id=117211
  26. Reviewed by Carlos Garcia Campos.
  27. PR 273550
  28. Adapt to changes in LayerCompositingThreadClient interface.
  29. * Api/WebOverlay.cpp:
  30. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
  31. * Api/WebOverlay_p.h:
  32. (WebOverlayLayerCompositingThreadClient):
  33. 2013-06-12 Leo Yang <leoyang@rim.com>
  34. [BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
  35. https://bugs.webkit.org/show_bug.cgi?id=117553
  36. Reviewed by Carlos Garcia Campos.
  37. In CredentialTransformData we should use RefPtr for
  38. m_userNameElement, m_passwordElement and m_oldPasswordElement
  39. because otherwise the elements could go away when the form
  40. elements get destroyed.
  41. Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
  42. No functionalities changed no new tests.
  43. * WebCoreSupport/CredentialTransformData.cpp:
  44. (WebCore::CredentialTransformData::findPasswordFormFields):
  45. (WebCore::CredentialTransformData::locateSpecificPasswords):
  46. * WebCoreSupport/CredentialTransformData.h:
  47. 2013-06-12 Alberto Garcia <agarcia@igalia.com>
  48. [BlackBerry] Remove dead WebDOM code
  49. https://bugs.webkit.org/show_bug.cgi?id=113370
  50. Reviewed by Anders Carlsson.
  51. BlackBerry PR 347565
  52. Internally reviewed by Charles Wei.
  53. * Api/WebPage.cpp:
  54. * Api/WebPage.h:
  55. * WebCoreSupport/AboutDataEnableFeatures.in:
  56. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  57. 2013-06-12 Jakob Petsovits <jpetsovits@blackberry.com>
  58. [BlackBerry] Smarter algorithm to determine the backingstore rect
  59. https://bugs.webkit.org/show_bug.cgi?id=117451
  60. JIRA115644
  61. https://jira.bbqnx.net/browse/BRWSR-7028
  62. Reviewed by Rob Buis.
  63. So far, the backingstore tile geometry allocation was
  64. pretty straightforward: We would start off from the
  65. current viewport and append all available tiles into
  66. the current scrolling direction from there.
  67. This will usually work well enough, but has the downside
  68. of discarding all the tiles in the opposite direction.
  69. Also, tiles very close to the viewport will often get
  70. discarded even if the user only scrolls very slowly.
  71. This patch completely revamps the algorithm for
  72. determining where the backingstore should be positioned.
  73. The general idea is that we construct a "desired rect"
  74. based on the viewport and inflate it into all four
  75. directions according to the current scroll momentum.
  76. This rectangle will be similarly large as a backingstore
  77. tile geometry rectangle might be, by using the
  78. approximate number of pixels that are available in the
  79. given number of tiles.
  80. The proportions for extending the rectangle from the
  81. viewport are influenced by different factors, including
  82. scroll momentum, viewport ratio, available space in the
  83. overall contents rectangle, and natural bias for the
  84. "down" direction.
  85. In practice, this results in a backingstore that is
  86. roughly evenly distributed around the viewport when no
  87. movement is happening, and will gradually narrow down
  88. and extend into the scroll direction at a higher momentum.
  89. The final tile geometry is constructed by trying fit
  90. the tiles into the desired rect in a way that maximizes
  91. the area of its intersection. There are a few parameters
  92. that can be tweaked, the ones in this patch seem to
  93. handle most cases well enough to minimize checkerboarding.
  94. As an additional bonus, a rectangle-based tiling strategy
  95. can more easily be adopted for accelerated compositing,
  96. which currently operates on a simpler algorithm that also
  97. inflates the viewport but does not take scrolling into
  98. account.
  99. * Api/BackingStore.cpp:
  100. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  101. (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
  102. (WebKit):
  103. (BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
  104. (BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
  105. (BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
  106. (BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
  107. (BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
  108. (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
  109. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  110. * Api/BackingStore_p.h:
  111. (BackingStorePrivate):
  112. 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
  113. Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
  114. https://bugs.webkit.org/show_bug.cgi?id=117512
  115. Reviewed by Darin Adler.
  116. * Api/WebPage.cpp:
  117. (BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
  118. 2013-06-06 Genevieve Mak <gmak@rim.com>
  119. [BlackBerry] Crash in InRegionScrollerPrivate::clearDocumentData
  120. https://bugs.webkit.org/show_bug.cgi?id=117317
  121. Reviewed by Rob Buis.
  122. PR #348994
  123. Need to check the scrollableArea instead of asserting because in this case for the
  124. selection subframe it is allowed to be null.
  125. * Api/InRegionScroller.cpp:
  126. (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
  127. 2013-06-05 Bear Travis <betravis@adobe.com>
  128. [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
  129. https://bugs.webkit.org/show_bug.cgi?id=117172
  130. Reviewed by Alexandru Chiculita.
  131. Adding the CSS_SHAPES compile flag.
  132. * WebCoreSupport/AboutDataEnableFeatures.in:
  133. 2013-06-05 Genevieve Mak <gmak@rim.com>
  134. [BlackBerry] Deleting the pendingSelectionCandidate on the wrong thread causes an assert.
  135. https://bugs.webkit.org/show_bug.cgi?id=117276
  136. Reviewed by Rob Buis.
  137. Reviewed Internally by Nima Ghanavatian.
  138. PR #342399
  139. Store and delete the selectionScrollView in webkit which is what we already do for
  140. scrolling subframes.
  141. * Api/InRegionScroller.cpp:
  142. (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
  143. (BlackBerry::WebKit::InRegionScrollerPrivate::resetSelectionScrollView):
  144. (WebKit):
  145. (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
  146. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  147. (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
  148. (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
  149. * Api/InRegionScroller_p.h:
  150. (InRegionScrollerPrivate):
  151. 2013-06-05 Tiancheng Jiang <tijiang@rim.com>
  152. [BlackBerry] Make image clickable when it has anchor as parent node.
  153. https://bugs.webkit.org/show_bug.cgi?id=117271
  154. Reviewed by Rob Buis.
  155. BlackBerry PR 345995
  156. Internally Reviewed by Genevieve Mak.
  157. * WebKitSupport/FatFingers.cpp:
  158. (BlackBerry::WebKit::FatFingers::isElementClickable):
  159. 2013-06-05 Mike Fenton <mifenton@rim.com>
  160. [BlackBerry] Selection handles are inverted on directional selections
  161. https://bugs.webkit.org/show_bug.cgi?id=117269
  162. Reviewed by Rob Buis.
  163. PR 336178
  164. Don't invert the handles leave them in the visual order.
  165. Internally Reviewed by Nima Ghanavatian.
  166. * WebKitSupport/SelectionHandler.cpp:
  167. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  168. 2013-06-03 Andrew Lo <anlo@rim.com>
  169. [BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
  170. https://bugs.webkit.org/show_bug.cgi?id=117167
  171. Reviewed by Rob Buis.
  172. Internally reviewed by Arvid Nilsson.
  173. Add WebKit::WebPage API for setting whether to show accelerated compositing
  174. debug borders.
  175. * Api/WebPage.cpp:
  176. (BlackBerry::WebKit::WebPage::setShowDebugBorders):
  177. (WebKit):
  178. * Api/WebPage.h:
  179. 2013-06-03 Mike Fenton <mifenton@rim.com>
  180. [BlackBerry] Selection handles are not cleared when displaying error pages.
  181. https://bugs.webkit.org/show_bug.cgi?id=117158
  182. Reviewed by Carlos Garcia Campos.
  183. PR 342159.
  184. Add explicit cancel of selection state when loading an error page
  185. as it is not always cleared.
  186. Internally Reviewed by Nima Ghanavatian.
  187. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  188. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  189. 2013-06-03 Mike Fenton <mifenton@rim.com>
  190. [BlackBerry] ROI details are not always cleared when using back navigation.
  191. https://bugs.webkit.org/show_bug.cgi?id=117159
  192. Reviewed by Carlos Garcia Campos.
  193. PR 328557.
  194. Secondary change to ensure when restoreViewState is triggered
  195. ROI is reset.
  196. Internally Reviewed by Nima Ghanavatian.
  197. * WebKitSupport/InputHandler.cpp:
  198. (BlackBerry::WebKit::InputHandler::restoreViewState):
  199. 2013-05-29 Otto Derek Cheung <otcheung@rim.com>
  200. [BlackBerry] Add more cellular technologies into the NetworkInfo enum
  201. https://bugs.webkit.org/show_bug.cgi?id=116982
  202. PR 340189
  203. Reviewed by Rob Buis.
  204. Provide more specific bandwidth speeds on different network
  205. services our devices provide.
  206. * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
  207. (WebCore):
  208. (WebCore::NetworkInfoClientBlackBerry::bandwidth):
  209. 2013-05-29 Yong Li <yoli@rim.com>
  210. [BlackBerry] about:memory should use malloc_stats instead of mallinfo
  211. https://bugs.webkit.org/show_bug.cgi?id=96420
  212. Reviewed by Rob Buis.
  213. PR 206297
  214. Use mallopt to get malloc_stats.
  215. * WebKitSupport/AboutData.cpp:
  216. (BlackBerry::WebKit::mallocStats):
  217. (BlackBerry::WebKit::memoryPage):
  218. (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
  219. 2013-05-29 Nima Ghanavatian <nghanavatian@blackberry.com>
  220. [BlackBerry] Notify client of selection deletion
  221. https://bugs.webkit.org/show_bug.cgi?id=116843
  222. Reviewed by Rob Buis.
  223. Internally reviewed by Mike Fenton.
  224. PR342106
  225. Our change guard was preventing caret change notification to be sent to IMF.
  226. This put us out of state when a selection was deleted because it is not a simple
  227. single character deletion. Ensure that selection deletions always send a caret
  228. update.
  229. * WebKitSupport/InputHandler.cpp:
  230. (BlackBerry::WebKit::InputHandler::deleteSelection):
  231. (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
  232. (BlackBerry::WebKit::InputHandler::deleteText):
  233. 2013-05-29 Rob Buis <rbuis@rim.com>
  234. [BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
  235. https://bugs.webkit.org/show_bug.cgi?id=116954
  236. Reviewed by Carlos Garcia Campos.
  237. PR 206152
  238. Internally reviewed by Konrad Piascik
  239. * WebKitSupport/AboutData.cpp:
  240. (BlackBerry::WebKit::configPage):
  241. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  242. (BlackBerry::WebKit::mallocStats):
  243. (BlackBerry::WebKit::memoryPage):
  244. (BlackBerry::WebKit::memoryPeaksToHtmlTable):
  245. (BlackBerry::WebKit::memoryLivePage):
  246. 2013-05-29 Jakob Petsovits <jpetsovits@blackberry.com>
  247. [BlackBerry] Use lazily-backed backingstore tiles
  248. https://bugs.webkit.org/show_bug.cgi?id=116879
  249. Internal PR 344523
  250. Reviewed by Carlos Garcia Campos.
  251. Informally reviewed by Arvid Nilsson and Mike Lattanzio.
  252. As a consequence, also don't use fixed-size
  253. shared pixmap buffers for these tiles anymore.
  254. * WebKitSupport/AboutData.cpp:
  255. (BlackBerry::WebKit::configPage):
  256. * WebKitSupport/BackingStoreTile.cpp:
  257. (BlackBerry::WebKit::TileBuffer::nativeBuffer):
  258. * WebKitSupport/SurfacePool.cpp:
  259. (BlackBerry::WebKit::SurfacePool::initialize):
  260. * WebKitSupport/SurfacePool.h:
  261. (SurfacePool):
  262. 2013-05-29 Kent Tamura <tkent@chromium.org>
  263. Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
  264. https://bugs.webkit.org/show_bug.cgi?id=116796
  265. Reviewed by Ryosuke Niwa.
  266. * WebCoreSupport/AboutDataEnableFeatures.in:
  267. 2013-05-28 Arvid Nilsson <anilsson@rim.com>
  268. [BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
  269. https://bugs.webkit.org/show_bug.cgi?id=116604
  270. Reviewed by Carlos Garcia Campos.
  271. Adapt to the removal of "get" prefix from getters in the WebKit- and
  272. compositing-thread layer classes.
  273. * Api/WebOverlay.cpp:
  274. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
  275. * Api/WebPageCompositor.cpp:
  276. (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
  277. (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
  278. (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
  279. 2013-05-28 Andreas Kling <akling@apple.com>
  280. Document::setFocusedNode() should be setFocusedElement().
  281. <http://webkit.org/b/116857>
  282. Reviewed by Antti Koivisto.
  283. * Api/WebPage.cpp:
  284. (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
  285. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  286. (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
  287. (BlackBerry::WebKit::WebPage::setNodeFocus):
  288. * WebCoreSupport/EditorClientBlackBerry.cpp:
  289. (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
  290. (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
  291. * WebKitSupport/InputHandler.cpp:
  292. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  293. * WebKitSupport/SelectionHandler.cpp:
  294. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  295. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  296. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  297. (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
  298. (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
  299. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  300. 2013-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
  301. Unreviewed. Fix BlackBerry debug build after r150756.
  302. * WebKitSupport/PagePopup.cpp:
  303. (BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
  304. assert.
  305. 2013-05-27 Nima Ghanavatian <nghanavatian@blackberry.com>
  306. [BlackBerry] Clear supression flag when caret changes aren't propogated through
  307. https://bugs.webkit.org/show_bug.cgi?id=116840
  308. Reviewed by Rob Buis.
  309. Internally reviewed by Mike Fenton.
  310. PR339965
  311. We set and clear the flag upon every use. This leaves us vulnerable if
  312. 1. midway through processing the selection change event is dismissed and
  313. 2. we don't receive a TouchRelease event
  314. One example of this is while dragging the FCC handle we start typing. To
  315. safeguard against this, if the process change guard is set during a
  316. selection change event, we send out to clear the flag status before returning.
  317. * Api/WebPageClient.h:
  318. * WebKitSupport/InputHandler.cpp:
  319. (BlackBerry::WebKit::InputHandler::selectionChanged):
  320. 2013-05-27 Andy Chen <andchen@blackberry.com>
  321. [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
  322. https://bugs.webkit.org/show_bug.cgi?id=116837
  323. Reviewed by Rob Buis.
  324. PR 291903
  325. Internally reviewed by Mike Fenton.
  326. * Api/WebPage.cpp:
  327. (BlackBerry::WebKit::WebPage::findNextString):
  328. * Api/WebPage.h:
  329. * WebKitSupport/InPageSearchManager.cpp:
  330. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  331. (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
  332. * WebKitSupport/InPageSearchManager.h:
  333. (InPageSearchManager):
  334. 2013-05-27 Eli Fidler <efidler@rim.com>
  335. [BlackBerry] Fix subframe target added to new requests
  336. https://bugs.webkit.org/show_bug.cgi?id=116602
  337. Reviewed by Rob Buis.
  338. In some cases we might be adding TargetIsMainFrame to a subframe
  339. request causing an isMainFrame assert.
  340. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  341. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  342. Check we are actually loading the main frame before setting
  343. ResourceRequest::TargetIsMainFrame target.
  344. 2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
  345. [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
  346. https://bugs.webkit.org/show_bug.cgi?id=116724
  347. Reviewed by Rob Buis.
  348. Add another bool variable m_previousFrameDone to make sure we
  349. don't start a new frame until the previous one has been done. Also
  350. make sure we pass the animation start time to
  351. serviceScriptedAnimations().
  352. * Api/WebPage.cpp:
  353. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
  354. m_previousFrameDone and m_monotonicAnimationStartTime.
  355. (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
  356. Return early if previous frame is not done. Otherwise set
  357. m_previousFrameDone to false and save the animation start time.
  358. (BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
  359. serviceScriptedAnimations() passing the saved animation start time
  360. and reset m_animationScheduled and m_previousFrameDone.
  361. (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
  362. Call WebPagePrivate::serviceAnimations().
  363. * Api/WebPage_p.h:
  364. (WebPagePrivate):
  365. 2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
  366. [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
  367. https://bugs.webkit.org/show_bug.cgi?id=116598
  368. Reviewed by Rob Buis.
  369. It's no longer needed since the encoder now checks the override encoding.
  370. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  371. (WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
  372. receivedData() passing the DocumentLoader instead of the text
  373. encoding.
  374. (WebCore::FrameLoaderClientBlackBerry::receivedData): Call
  375. DocumentLoader::commitData() directly.
  376. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  377. (FrameLoaderClientBlackBerry):
  378. 2013-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
  379. [BlackBerry] Move PagePopup implementation to WebKitSupport
  380. https://bugs.webkit.org/show_bug.cgi?id=116824
  381. Reviewed by Rob Buis.
  382. After r150434 PagePopup implementation in BlackBerry port is
  383. independent from WebCore. The classes are now in the
  384. BlackBerry::WebKit namespace so they can be moved from
  385. WebCoresupport to WebKitSupport and renamed to remove the
  386. BlackBerry suffix which is now redundant. Also, now that the
  387. implementation is not shared, it can be simplified a bit more.
  388. * Api/WebPage.cpp:
  389. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
  390. API changes.
  391. (BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
  392. (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
  393. (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
  394. (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
  395. * Api/WebPage.h:
  396. (WebKit): Ditto.
  397. * Api/WebPage_p.h:
  398. (WebKit): Ditto.
  399. (WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
  400. can also point to a color picker or date picker page popup. Also
  401. use RefPtr instead of raw pointer.
  402. * WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
  403. (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
  404. (BlackBerry::WebKit::ColorPickerClient::generateHTML):
  405. (BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
  406. Return early if popup has been closed already.
  407. (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
  408. * WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
  409. * WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
  410. (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
  411. (BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
  412. (BlackBerry::WebKit::DatePickerClient::generateHTML):
  413. (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
  414. Return early if popup has been closed already.
  415. (BlackBerry::WebKit::DatePickerClient::didClosePopup):
  416. (BlackBerry::WebKit::DatePickerClient::generateDateLabels):
  417. * WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
  418. * WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
  419. (BlackBerry::WebKit::PagePopup::PagePopup):
  420. (BlackBerry::WebKit::PagePopup::~PagePopup):
  421. (BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
  422. and made void, since it always returned true and the callers
  423. ignored the return value.
  424. (BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
  425. generateHTML for consistency with PagePopupClient::writeDocument()
  426. and to avoid confusion with generateHTML method in the clients
  427. that create the HTML contents but they don't write the document.
  428. (BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
  429. Make it static member of PagePopup since the JS object now holds a
  430. reference of PagePopup instance as private data.
  431. (BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
  432. of the PagePopup instance saved as private data of the JS object.
  433. (BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
  434. instance saved as private data of the JS object.
  435. (BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
  436. saving the client as private data of the JS object using a wrapper
  437. refcounted object, save the PagePopup instance that is now
  438. refcounted and access the client from the PagePopup instance in
  439. the callback.
  440. (BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
  441. since PagePopup::closePagePopup was a bit redundant.
  442. * WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
  443. (BlackBerry::WebKit::PagePopup::create): Static member to create
  444. instances of PagePopup now that it's refcounted.
  445. * WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
  446. (BlackBerry::WebKit::PagePopupClient::PagePopupClient):
  447. (BlackBerry::WebKit::PagePopupClient::closePopup):
  448. (BlackBerry::WebKit::PagePopupClient::didClosePopup):
  449. (BlackBerry::WebKit::PagePopupClient::contentSize):
  450. (BlackBerry::WebKit::PagePopupClient::writeDocument):
  451. * WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
  452. * WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
  453. (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
  454. (BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
  455. (BlackBerry::WebKit::SelectPopupClient::generateHTML):
  456. (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
  457. Return early if popup has been closed already.
  458. (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
  459. (BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
  460. * WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
  461. 2013-05-26 Jakob Petsovits <jpetsovits@blackberry.com>
  462. [BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
  463. https://bugs.webkit.org/show_bug.cgi?id=116539
  464. Internal PR 330917
  465. Reviewed by Carlos Garcia Campos.
  466. Internally reviewed by Xiaobo Wang and Arvid Nilsson.
  467. This reduces complexity by relying on the current state,
  468. rather than the suspend counter, which in turn makes it
  469. possible to simplify the code in setCompositor().
  470. * Api/BackingStore.cpp:
  471. (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
  472. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  473. * Api/WebPage.cpp:
  474. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  475. 2013-05-26 Kent Tamura <tkent@chromium.org>
  476. Remove ENABLE_CALENDAR_PICKER
  477. https://bugs.webkit.org/show_bug.cgi?id=116795
  478. Reviewed by Ryosuke Niwa.
  479. * WebCoreSupport/AboutDataEnableFeatures.in:
  480. The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
  481. 2013-05-26 Andreas Kling <akling@apple.com>
  482. FocusController::setFocusedNode() should be setFocusedElement().
  483. <http://webkit.org/b/116780>
  484. Reviewed by Antti Koivisto.
  485. * Api/WebPage.cpp:
  486. (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
  487. (BlackBerry::WebKit::WebPage::setNodeFocus):
  488. * WebKitSupport/SelectionHandler.cpp:
  489. (BlackBerry::WebKit::SelectionHandler::selectObject):
  490. 2013-05-24 Anders Carlsson <andersca@apple.com>
  491. Remove PagePopup code
  492. https://bugs.webkit.org/show_bug.cgi?id=116732
  493. Reviewed by Andreas Kling.
  494. * WebCoreSupport/AboutDataEnableFeatures.in:
  495. Remove PAGE_POPUP.
  496. 2013-05-24 Mike Fenton <mifenton@rim.com>
  497. [BlackBerry] Fix bad type warning in InputHandler log.
  498. https://bugs.webkit.org/show_bug.cgi?id=116720
  499. Reviewed by Carlos Garcia Campos.
  500. Fix warning in inputLog string.
  501. * WebKitSupport/InputHandler.cpp:
  502. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  503. 2013-05-24 Mike Fenton <mifenton@rim.com>
  504. [BlackBerry] Respect tabindex when using form controls.
  505. https://bugs.webkit.org/show_bug.cgi?id=116676
  506. Reviewed by Xan Lopez.
  507. PR 337419.
  508. Update form control navigation tracking to take tabindex
  509. order into account when calculating next and previous nodes.
  510. The order to follow is tab index 1 - N, followed by all items
  511. without a tab index or tab index 0 in rendering order to match
  512. with standard desktop behavior.
  513. Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
  514. * WebKitSupport/InputHandler.cpp:
  515. (BlackBerry::WebKit::InputHandler::updateFormState):
  516. 2013-05-24 Jeff Rogers <jrogers@rim.com>
  517. [BlackBerry] Remove SKIA leftovers from WebPage.cpp
  518. https://bugs.webkit.org/show_bug.cgi?id=116656
  519. Reviewed by Rob Buis.
  520. * Api/WebPage.cpp:
  521. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  522. 2013-05-23 Xiaobo Wang <xiaobwang@blackberry.com>
  523. [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
  524. https://bugs.webkit.org/show_bug.cgi?id=115245
  525. Reviewed by Rob Buis.
  526. PR 330917.
  527. Internally reviewed by Arvid Nilsson.
  528. 1. Suspend/resumeRootLayerCommit when notified app activation state
  529. change.
  530. 2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
  531. start root layer commit timer, so that there's a commit even if
  532. BackingStore got disabled/removed.
  533. * Api/WebPage.cpp:
  534. (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
  535. (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
  536. 2013-05-23 Andy Chen <andchen@blackberry.com>
  537. [BlackBerry] Need to forward the opener frame url to client when creating a new window
  538. https://bugs.webkit.org/show_bug.cgi?id=116566
  539. Reviewed by Rob Buis.
  540. PR 337935
  541. Internally reviewed by Arvid Nilsson.
  542. When creating a new window, forward the opener frame url to client.
  543. * Api/WebPageClient.h:
  544. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  545. (WebCore::ChromeClientBlackBerry::createWindow):
  546. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  547. (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
  548. 2013-05-23 Jakob Petsovits <jpetsovits@blackberry.com>
  549. [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
  550. https://bugs.webkit.org/show_bug.cgi?id=116545
  551. Internal PR 189775
  552. Reviewed by Rob Buis.
  553. Also change the name of the "documentContents" parameter
  554. to the more descriptive "documentSrcRect".
  555. * Api/WebPageCompositor.cpp:
  556. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  557. (BlackBerry::WebKit::WebPageCompositor::render):
  558. * Api/WebPageCompositor.h:
  559. * Api/WebPageCompositor_p.h:
  560. (WebPageCompositorPrivate):
  561. 2013-05-23 Ed Baker <edbaker@blackberry.com>
  562. [BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
  563. https://bugs.webkit.org/show_bug.cgi?id=116627
  564. Reviewed by Xan Lopez.
  565. PR #341084
  566. If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
  567. Internally Reviewed by Gen Mak.
  568. * Api/WebPage.cpp:
  569. (BlackBerry::WebKit::WebPagePrivate::webContext):
  570. 2013-05-23 Mike Fenton <mifenton@rim.com>
  571. [BlackBerry] Validate form data before doing direct submission.
  572. https://bugs.webkit.org/show_bug.cgi?id=116674
  573. Reviewed by Xan Lopez.
  574. PR 314202.
  575. Check validation of the input form before triggering direct submission.
  576. Internally Reviewed by Nima Ghanavatian.
  577. * WebKitSupport/InputHandler.cpp:
  578. (BlackBerry::WebKit::InputHandler::submitForm):
  579. 2013-05-23 Rob Buis <rbuis@rim.com>
  580. [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
  581. https://bugs.webkit.org/show_bug.cgi?id=116603
  582. Reviewed by Xan Lopez.
  583. PR 119789
  584. Internally reviewed by Yong Li.
  585. Provide a domain value for this ResourceError instance. Note that
  586. this does not change behavior.
  587. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  588. (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
  589. 2013-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
  590. [BlackBerry] Make PagePopup implementation independent from WebCore
  591. https://bugs.webkit.org/show_bug.cgi?id=116448
  592. Reviewed by Anders Carlsson.
  593. Add our own implementation of PagePopupClient and make all the
  594. pickers inherit from it. Unused methods have been removed and
  595. common implementation have been moved from the pickers to the
  596. parent class.
  597. * Api/WebPage.cpp:
  598. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
  599. popup if there's one active.
  600. (BlackBerry::WebKit::WebPagePrivate::setVisible): Call
  601. closePagePopup() directly.
  602. (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
  603. PagePopupBlackBerry for the given client.
  604. (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
  605. active popup if there's one.
  606. (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
  607. whether there's an active popup.
  608. * Api/WebPage.h:
  609. * Api/WebPage_p.h:
  610. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  611. (WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
  612. closePagePopup() call since this is now handled by
  613. WebPagePrivate.
  614. (WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
  615. WebPagePrivate::hasOpenedPopup().
  616. * WebCoreSupport/ChromeClientBlackBerry.h:
  617. (ChromeClientBlackBerry):
  618. * WebCoreSupport/ColorPickerClient.cpp:
  619. (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
  620. (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
  621. * WebCoreSupport/ColorPickerClient.h:
  622. (ColorPickerClient):
  623. * WebCoreSupport/DatePickerClient.cpp:
  624. (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
  625. (BlackBerry::WebKit::DatePickerClient::didClosePopup):
  626. * WebCoreSupport/DatePickerClient.h:
  627. (DatePickerClient):
  628. * WebCoreSupport/PagePopupBlackBerry.cpp:
  629. (BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
  630. (BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
  631. * WebCoreSupport/PagePopupBlackBerry.h:
  632. (PagePopupBlackBerry):
  633. (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
  634. (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
  635. (SharedClientPointer):
  636. * WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
  637. (BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
  638. (BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
  639. (BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
  640. (BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
  641. (BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
  642. * WebCoreSupport/PagePopupBlackBerryClient.h: Added.
  643. (PagePopupBlackBerryClient):
  644. (BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
  645. * WebCoreSupport/SelectPopupClient.cpp:
  646. (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
  647. (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
  648. * WebCoreSupport/SelectPopupClient.h:
  649. (SelectPopupClient):
  650. * WebKitSupport/InputHandler.cpp:
  651. (BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
  652. closePagePopup() since this is already done by openPagePopup() and
  653. use openPagePopup() from WebPagePrivate directly.
  654. (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
  655. (BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
  656. 2013-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
  657. [BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
  658. https://bugs.webkit.org/show_bug.cgi?id=116302
  659. Reviewed by Rob Buis.
  660. TiledImage is now the NativeImage of the BlackBerry port.
  661. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  662. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
  663. 2013-05-19 Anders Carlsson <andersca@apple.com>
  664. Remove link prerendering code
  665. https://bugs.webkit.org/show_bug.cgi?id=116415
  666. Reviewed by Darin Adler.
  667. This code was only used by Chromium and is dead now.
  668. * WebCoreSupport/AboutDataEnableFeatures.in:
  669. 2013-05-19 Anders Carlsson <andersca@apple.com>
  670. Remove ChromeClient::webView()
  671. https://bugs.webkit.org/show_bug.cgi?id=116054
  672. Reviewed by Andreas Kling.
  673. This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
  674. * WebCoreSupport/ChromeClientBlackBerry.h:
  675. (ChromeClientBlackBerry):
  676. 2013-05-17 Carlos Garcia Campos <cgarcia@igalia.com>
  677. [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
  678. https://bugs.webkit.org/show_bug.cgi?id=116305
  679. Reviewed by Rob Buis.
  680. PR 340537.
  681. Internally reviewed by Arvid Nilsson.
  682. Use updateLayoutAndStyleIfNeededRecursive() instead of
  683. layoutIfNeeded() since we are about to draw in
  684. rootLayerCommitTimerFired().
  685. * Api/WebPage.cpp:
  686. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  687. 2013-05-17 Mike Fenton <mifenton@rim.com>
  688. [BlackBerry] Remove stale comment for select mouse handling.
  689. https://bugs.webkit.org/show_bug.cgi?id=116309
  690. Reviewed by Rob Buis.
  691. PR 135935.
  692. Remove a FIXME that has been invalidated by a change
  693. to our touch -> mouse model.
  694. Internally Rubberstamped by Genevieve Mak.
  695. * Api/WebPage.cpp:
  696. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  697. 2013-05-17 Alberto Garcia <agarcia@igalia.com>
  698. [BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
  699. https://bugs.webkit.org/show_bug.cgi?id=116298
  700. Reviewed by Carlos Garcia Campos.
  701. Pass the correct parameter to toDeviceOrientationClientMock()
  702. * WebKitSupport/DumpRenderTreeSupport.cpp:
  703. (DumpRenderTreeSupport::setMockDeviceOrientation):
  704. 2013-05-16 Mike Fenton <mifenton@rim.com>
  705. [BlackBerry] Optimize caret bounds calculation when leaving an input field.
  706. https://bugs.webkit.org/show_bug.cgi?id=116224
  707. Reviewed by Rob Buis.
  708. PR 340132.
  709. If the caret is no longer active in the field, do not allow it
  710. to go into the single line input logic and calculate the node
  711. bounding box.
  712. Internally Reviewed By Gen Mak
  713. * WebKitSupport/SelectionHandler.cpp:
  714. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  715. 2013-05-16 Mary Wu <mary.wu@torchmobile.com.cn>
  716. [BlackBerry] Unable to download blob resource
  717. https://bugs.webkit.org/show_bug.cgi?id=115888
  718. Reviewed by Benjamin Poulain.
  719. For blob resource (blob:http....), it's not suitable to go to NetworkStream
  720. which don't handle "blob" protocol at all. since blob data already handled
  721. in BlobResourceHandle, simply get the data out to download stream.
  722. RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
  723. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  724. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  725. 2013-05-16 Andreas Kling <akling@apple.com>
  726. Page::chrome() should return a reference.
  727. <http://webkit.org/b/116185>
  728. Reviewed by Anders Carlsson.
  729. 2013-05-13 Anders Carlsson <andersca@apple.com>
  730. Frame::editor() should return a reference
  731. https://bugs.webkit.org/show_bug.cgi?id=116037
  732. Reviewed by Darin Adler.
  733. * WebCoreSupport/EditorClientBlackBerry.cpp:
  734. (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
  735. (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
  736. * WebKitSupport/DOMSupport.cpp:
  737. (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
  738. * WebKitSupport/InPageSearchManager.cpp:
  739. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  740. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  741. * WebKitSupport/SelectionHandler.cpp:
  742. (BlackBerry::WebKit::SelectionHandler::selectedText):
  743. 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
  744. Remove WTF_USE_PLATFORM_STRATEGIES
  745. https://bugs.webkit.org/show_bug.cgi?id=114431
  746. Reviewed by Darin Adler.
  747. * WebCoreSupport/AboutDataUseFeatures.in:
  748. 2013-05-14 Tiancheng Jiang <tijiang@rim.com>
  749. [BlackBerry] Improve Fatfinger phase.
  750. https://bugs.webkit.org/show_bug.cgi?id=107403
  751. Reviewed by Rob Buis.
  752. Internally reviewed by Genevieve Mak.
  753. BlackBerry PR 324965.
  754. Cache and reuse intersected nodes as long as hit position has not been
  755. changed.
  756. * Api/WebPage.cpp:
  757. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  758. * Api/WebPage_p.h:
  759. (WebPagePrivate):
  760. * WebKitSupport/FatFingers.cpp:
  761. (BlackBerry::WebKit::FatFingers::findBestPoint):
  762. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  763. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  764. * WebKitSupport/FatFingers.h:
  765. 2013-05-14 Andrew Lo <anlo@rim.com>
  766. [BlackBerry] Hook up frame render begin/end in PerformanceMonitor
  767. https://bugs.webkit.org/show_bug.cgi?id=116110
  768. Reviewed by Rob Buis.
  769. Internally reviewed by Jeff Rogers, Jonathan Jiang.
  770. Internal PR 299155.
  771. Mark frame render begin & end for BlackBerry performance monitoring
  772. in blitVisibleContents.
  773. * Api/BackingStore.cpp:
  774. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  775. 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
  776. [BlackBerry] Use requestAnimationFrame for animations
  777. https://bugs.webkit.org/show_bug.cgi?id=115896
  778. Reviewed by Rob Buis.
  779. Make WebPagePrivate a
  780. BlackBerry::Platform::AnimationFrameRateClient and use it to
  781. schedule animations.
  782. * Api/WebPage.cpp:
  783. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  784. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  785. (WebKit):
  786. (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
  787. (BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
  788. (BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
  789. (BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
  790. (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
  791. * Api/WebPage_p.h:
  792. (WebPagePrivate):
  793. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  794. (WebCore):
  795. (WebCore::ChromeClientBlackBerry::scheduleAnimation):
  796. * WebCoreSupport/ChromeClientBlackBerry.h:
  797. (ChromeClientBlackBerry):
  798. 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
  799. [BlackBerry] Implement platform strategies
  800. https://bugs.webkit.org/show_bug.cgi?id=112162
  801. Reviewed by Rob Buis.
  802. * Api/BlackBerryGlobal.cpp:
  803. (BlackBerry::WebKit::globalInitialize): Initialize platform
  804. strategies.
  805. * WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
  806. (PlatformStrategiesBlackBerry::initialize):
  807. (PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
  808. (PlatformStrategiesBlackBerry::createCookiesStrategy):
  809. (PlatformStrategiesBlackBerry::createDatabaseStrategy):
  810. (PlatformStrategiesBlackBerry::createLoaderStrategy):
  811. (PlatformStrategiesBlackBerry::createPasteboardStrategy):
  812. (PlatformStrategiesBlackBerry::createPluginStrategy):
  813. (PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
  814. (PlatformStrategiesBlackBerry::createStorageStrategy):
  815. (PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
  816. (PlatformStrategiesBlackBerry::cookiesForDOM):
  817. (PlatformStrategiesBlackBerry::setCookiesFromDOM):
  818. (PlatformStrategiesBlackBerry::cookiesEnabled):
  819. (PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
  820. (PlatformStrategiesBlackBerry::getRawCookies):
  821. (PlatformStrategiesBlackBerry::deleteCookie):
  822. (PlatformStrategiesBlackBerry::refreshPlugins):
  823. (PlatformStrategiesBlackBerry::getPluginInfo):
  824. (PlatformStrategiesBlackBerry::isLinkVisited):
  825. (PlatformStrategiesBlackBerry::addVisitedLink):
  826. * WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
  827. (PlatformStrategiesBlackBerry):
  828. 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
  829. [BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
  830. https://bugs.webkit.org/show_bug.cgi?id=115412
  831. Reviewed by Rob Buis.
  832. PR 115412
  833. The problem is that we are calling
  834. updateLayoutAndStyleIfNeededRecursive() (because of
  835. zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
  836. callback which is not expected. It's expected to be called right
  837. before painting, and not right after painting. Even if a new
  838. layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
  839. flushDeferredRepaints() and it's possible that this is called in
  840. the middle of a beginDeferredRepaints() and endDeferredRepaints()
  841. apparently.
  842. In general only BackingStore should call
  843. updateLayoutAndStyleIfNeededRecursive before painting, and a simple
  844. layout is enough in all other cases like resizing. This patch renames
  845. requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
  846. make more obvious what it does, and adds layoutIfNeeded that calls
  847. layout. The former is used by the BackingStore and the latter by
  848. WebPage.
  849. * Api/BackingStore.cpp:
  850. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  851. (BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
  852. * Api/WebPage.cpp:
  853. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  854. (BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
  855. (BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
  856. (WebKit):
  857. (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
  858. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  859. (BlackBerry::WebKit::WebPagePrivate::webContext):
  860. (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
  861. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  862. (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
  863. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  864. * Api/WebPage_p.h:
  865. (WebPagePrivate):
  866. 2013-05-10 Laszlo Gombos <l.gombos@samsung.com>
  867. Remove USE(OS_RANDOMNESS)
  868. https://bugs.webkit.org/show_bug.cgi?id=108095
  869. Reviewed by Darin Adler.
  870. Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
  871. ports.
  872. * WebCoreSupport/AboutDataUseFeatures.in:
  873. 2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
  874. Fix some compiler warnings (miscellaneous)
  875. https://bugs.webkit.org/show_bug.cgi?id=80790
  876. Reviewed by Rob Buis.
  877. Fix the following warnings for BlackBerry:
  878. BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
  879. '||' [-Wparentheses].
  880. WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
  881. as truth value [-Wparentheses].
  882. WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
  883. as truth value [-Wparentheses]
  884. * Api/BackingStore.cpp:
  885. (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
  886. * Api/WebPage.cpp:
  887. (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
  888. (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
  889. 2013-05-09 Mike Fenton <mifenton@rim.com>
  890. [BlackBerry] Style updates required based on new check-webkit-style
  891. https://bugs.webkit.org/show_bug.cgi?id=115857
  892. Reviewed by Rob Buis.
  893. Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
  894. to match check-webkit-style updates.
  895. * Api/InRegionScroller.cpp:
  896. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
  897. * Api/InRegionScroller_p.h:
  898. * Api/WebKitTextCodec.cpp:
  899. (BlackBerry::WebKit::transcode):
  900. * Api/WebPageCompositor.cpp:
  901. (BlackBerry::WebKit::WebPageCompositor::render):
  902. * Api/WebPageCompositor.h:
  903. * Api/WebPageCompositor_p.h:
  904. (WebPageCompositorPrivate):
  905. * Api/WebSettings_p.h:
  906. 2013-05-09 Max Feil <mfeil@rim.com>
  907. shouldUsePluginDocument() needs to be respected when a document is created
  908. https://bugs.webkit.org/show_bug.cgi?id=110308
  909. Reviewed by Rob Buis.
  910. This patch implements shouldAlwaysUsePluginDocument() in the
  911. BlackBerry frame loader client. It is called in several places
  912. within WebCore to determine whether a PluginDocument should
  913. be created.
  914. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  915. (WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
  916. (WebCore):
  917. (WebCore::FrameLoaderClientBlackBerry::createPlugin):
  918. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  919. (FrameLoaderClientBlackBerry):
  920. 2013-05-09 Mike Fenton <mifenton@rim.com>
  921. [BlackBerry] Style updates required based on new check-webkit-style
  922. https://bugs.webkit.org/show_bug.cgi?id=115857
  923. Reviewed by Rob Buis.
  924. Update SelectionHandler to match check-webkit-style updates.
  925. * WebKitSupport/SelectionHandler.cpp:
  926. (BlackBerry::WebKit::shouldExtendSelectionInDirection):
  927. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  928. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  929. (BlackBerry::WebKit::adjustCaretRects):
  930. (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
  931. (BlackBerry::WebKit::regionRectListContainsPoint):
  932. * WebKitSupport/SelectionHandler.h:
  933. (SelectionHandler):
  934. 2013-05-09 Mike Fenton <mifenton@rim.com>
  935. [BlackBerry] Style updates required based on new check-webkit-style
  936. https://bugs.webkit.org/show_bug.cgi?id=115857
  937. Reviewed by Rob Buis.
  938. Update WebPage and WebPageClient to match check-webkit-style updates.
  939. * Api/WebPage.cpp:
  940. (BlackBerry::WebKit::WebPagePrivate::init):
  941. (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
  942. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  943. (BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
  944. (BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
  945. (BlackBerry::WebKit::WebPage::assignFocus):
  946. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  947. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  948. (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
  949. (BlackBerry::WebKit::WebPage::addVisitedLink):
  950. (BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
  951. (BlackBerry::WebKit::WebPage::notifySwipeEvent):
  952. (BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
  953. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  954. (BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
  955. (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
  956. * Api/WebPageClient.h:
  957. * Api/WebPage_p.h:
  958. 2013-05-09 Mike Fenton <mifenton@rim.com>
  959. [BlackBerry] Style updates required based on new check-webkit-style
  960. https://bugs.webkit.org/show_bug.cgi?id=115857
  961. Reviewed by Rob Buis.
  962. Update BackingStore to match check-webkit-style updates.
  963. Internally reviewed by Jakob Petsovits.
  964. * Api/BackingStore.cpp:
  965. (BlackBerry::WebKit::bestDivisor):
  966. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  967. (BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
  968. (BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
  969. (BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
  970. (BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
  971. (BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
  972. (BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
  973. (BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
  974. (BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
  975. (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
  976. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  977. (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
  978. (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
  979. (BlackBerry::WebKit::BackingStore::repaint):
  980. * Api/BackingStore_p.h:
  981. (BackingStoreGeometry):
  982. 2013-05-09 Mike Fenton <mifenton@rim.com>
  983. [BlackBerry] Style updates required based on new check-webkit-style
  984. https://bugs.webkit.org/show_bug.cgi?id=115857
  985. Reviewed by Rob Buis.
  986. Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
  987. GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
  988. match check-webkit-style updates.
  989. * WebCoreSupport/ChromeClientBlackBerry.h:
  990. (ChromeClientBlackBerry):
  991. * WebCoreSupport/CredentialManager.h:
  992. (CredentialManager):
  993. * WebCoreSupport/CredentialTransformData.cpp:
  994. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  995. (WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
  996. (FrameLoaderClientBlackBerry):
  997. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
  998. (WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
  999. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
  1000. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
  1001. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
  1002. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  1003. (GeolocationClientBlackBerry::onLocationUpdate):
  1004. * WebCoreSupport/GeolocationClientBlackBerry.h:
  1005. (GeolocationClientBlackBerry):
  1006. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  1007. (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
  1008. 2013-05-09 Jacky Jiang <zhajiang@blackberry.com>
  1009. Fix some compiler warnings (miscellaneous)
  1010. https://bugs.webkit.org/show_bug.cgi?id=80790
  1011. Reviewed by Rob Buis.
  1012. Fix the following warnings for BlackBerry:
  1013. InRegionScroller.cpp:286:39: warning: suggest parentheses around
  1014. assignment used as truth value [-Wparentheses].
  1015. InRegionScroller.cpp:349:39: warning: suggest parentheses around
  1016. assignment used as truth value [-Wparentheses].
  1017. InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
  1018. within '||' [-Wparentheses].
  1019. InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
  1020. avoid ambiguous 'else' [-Wparentheses].
  1021. SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
  1022. within '||' [-Wparentheses].
  1023. SelectionOverlay.cpp:56:47: warning: comparison between signed and
  1024. unsigned integer expressions [-Wsign-compare].
  1025. * Api/InRegionScroller.cpp:
  1026. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  1027. (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
  1028. (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
  1029. * WebKitSupport/InRegionScrollableArea.cpp:
  1030. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  1031. * WebKitSupport/SelectionHandler.cpp:
  1032. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  1033. * WebKitSupport/SelectionOverlay.cpp:
  1034. (BlackBerry::WebKit::SelectionOverlay::draw):
  1035. 2013-05-09 Mike Fenton <mifenton@rim.com>
  1036. [BlackBerry] Style updates required based on new check-webkit-style
  1037. https://bugs.webkit.org/show_bug.cgi?id=115857
  1038. Reviewed by Rob Buis.
  1039. Update ColorPickerClient and PagePopupBlackBerry
  1040. to match check-webkit-style updates.
  1041. * WebCoreSupport/ColorPickerClient.cpp:
  1042. (WebCore::ColorPickerClient::generateHTML):
  1043. * WebCoreSupport/PagePopupBlackBerry.cpp:
  1044. (WebCore::setValueAndClosePopupCallback):
  1045. (WebCore::PagePopupBlackBerry::installDOMFunction):
  1046. 2013-05-09 Alberto Garcia <agarcia@igalia.com>
  1047. [BlackBerry] Upstream the input popups
  1048. https://bugs.webkit.org/show_bug.cgi?id=114608
  1049. Reviewed by Rob Buis.
  1050. This patch contains contributions from many members of the
  1051. BlackBerry WebKit team, including:
  1052. Chris Hutten-Czapski
  1053. David Hoon
  1054. Jessica Cao
  1055. Rob Buis
  1056. Tiancheng Jiang
  1057. * WebCoreSupport/ColorPickerClient.cpp:
  1058. (WebCore):
  1059. (WebCore::ColorPickerClient::generateHTML):
  1060. * WebCoreSupport/DatePickerClient.cpp:
  1061. (WebCore):
  1062. (WebCore::DatePickerClient::generateHTML):
  1063. (WebCore::DatePickerClient::generateDateLabels):
  1064. * WebCoreSupport/DatePickerClient.h:
  1065. (DatePickerClient):
  1066. * WebCoreSupport/SelectPopupClient.cpp:
  1067. (WebCore):
  1068. (WebCore::SelectPopupClient::generateHTML):
  1069. 2013-05-09 Mike Fenton <mifenton@rim.com>
  1070. [BlackBerry] Style updates required based on new check-webkit-style
  1071. https://bugs.webkit.org/show_bug.cgi?id=115857
  1072. Reviewed by Rob Buis.
  1073. Update DOMSupport to match check-webkit-style updates.
  1074. * WebKitSupport/DOMSupport.cpp:
  1075. (BlackBerry::WebKit::DOMSupport::isTextInputElement):
  1076. (BlackBerry::WebKit::DOMSupport::isPasswordElement):
  1077. (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
  1078. 2013-05-09 Xuefei Ren <xren@blackberry.com>
  1079. [BLACKBERRY]fix regression in Webpage
  1080. and FrameLoaderClientBlackberry
  1081. https://bugs.webkit.org/show_bug.cgi?id=115843
  1082. Reviewed by Rob Buis.
  1083. Internally reviewed by Mary Wu.
  1084. * Api/WebPage.cpp:
  1085. (BlackBerry::WebKit::WebPage::loadFile):
  1086. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1087. (WebCore::FrameLoaderClientBlackBerry::startDownload):
  1088. 2013-05-09 Mike Fenton <mifenton@rim.com>
  1089. [BlackBerry] Style updates required based on new check-webkit-style
  1090. https://bugs.webkit.org/show_bug.cgi?id=115857
  1091. Reviewed by Rob Buis.
  1092. Update FatFingers to match check-webkit-style updates.
  1093. * WebKitSupport/FatFingers.cpp:
  1094. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  1095. (BlackBerry::WebKit::FatFingers::checkForClickableElement):
  1096. * WebKitSupport/FatFingers.h:
  1097. (FatFingersResult):
  1098. 2013-05-09 Mike Fenton <mifenton@rim.com>
  1099. [BlackBerry] Style updates required based on new check-webkit-style
  1100. https://bugs.webkit.org/show_bug.cgi?id=115857
  1101. Reviewed by Rob Buis.
  1102. Update InRegionScrollableArea, TileIndexHash
  1103. and TouchEventHandler to match check-webkit-style updates.
  1104. * WebKitSupport/InRegionScrollableArea.cpp:
  1105. * WebKitSupport/TileIndexHash.h:
  1106. * WebKitSupport/TouchEventHandler.cpp:
  1107. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  1108. 2013-05-09 Mike Fenton <mifenton@rim.com>
  1109. [BlackBerry] Style updates required based on new check-webkit-style
  1110. https://bugs.webkit.org/show_bug.cgi?id=115857
  1111. Reviewed by Rob Buis.
  1112. Styles fixes required for InputHandler based on updated
  1113. check-webkit-style.
  1114. * WebKitSupport/InputHandler.cpp:
  1115. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  1116. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  1117. (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
  1118. (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
  1119. (BlackBerry::WebKit::InputHandler::firstSpanInString):
  1120. (BlackBerry::WebKit::InputHandler::setTextAttributes):
  1121. * WebKitSupport/InputHandler.h:
  1122. 2013-05-08 Eli Fidler <efidler@blackberry.com>
  1123. [BlackBerry] Fix usage of BlackBerry::Platform::String
  1124. https://bugs.webkit.org/show_bug.cgi?id=115781
  1125. Reviewed by Rob Buis.
  1126. BlackBerry PRs 304193 and 327181
  1127. Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
  1128. We currently have a problem where we're passing UTF-8 encoded data into
  1129. the char* constructors of BlackBerry::Platform::String. This means the string
  1130. thinks its data is not UTF-8.
  1131. * Api/JavaScriptVariant.cpp:
  1132. (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
  1133. * Api/WebKitTextCodec.cpp:
  1134. (BlackBerry::WebKit::base64Encode):
  1135. * Api/WebPage.cpp:
  1136. (BlackBerry::WebKit::WebPage::loadFile):
  1137. (BlackBerry::WebKit::WebPage::textEncoding):
  1138. (BlackBerry::WebKit::WebPage::textHasAttribute):
  1139. (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
  1140. * Api/WebPage.h:
  1141. * Api/WebSettings.cpp:
  1142. (BlackBerry::WebKit::WebSettings::standardSettings):
  1143. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1144. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  1145. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
  1146. * WebKitSupport/DefaultTapHighlight.cpp:
  1147. (WebKit):
  1148. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  1149. (BlackBerry::WebKit::DefaultTapHighlight::hide):
  1150. 2013-05-08 Rob Buis <rbuis@rim.com>
  1151. Fix some compiler warnings (miscellaneous)
  1152. https://bugs.webkit.org/show_bug.cgi?id=80790
  1153. Reviewed by Philip Rogers.
  1154. Get rid of the following warning for BlackBerry:
  1155. BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
  1156. by using ASSERT_UNUSED instead of ASSERT.
  1157. * WebKitSupport/BackingStoreClient.cpp:
  1158. (BlackBerry::WebKit::BackingStoreClient::create):
  1159. 2013-05-07 Xuefei Ren <xren@blackberry.com>
  1160. Clean up load interface in WebPage
  1161. https://bugs.webkit.org/show_bug.cgi?id=115622
  1162. Reviewed by Rob Buis.
  1163. Internal PR:315535
  1164. Internal reviewed by Mary Wu
  1165. * Api/WebPage.cpp:
  1166. (BlackBerry::WebKit::WebPagePrivate::load):
  1167. (BlackBerry::WebKit::WebPage::loadFile):
  1168. (BlackBerry::WebKit::WebPage::load):
  1169. * Api/WebPage.h:
  1170. * Api/WebPage_p.h:
  1171. (WebPagePrivate):
  1172. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1173. (WebCore::FrameLoaderClientBlackBerry::startDownload):
  1174. 2013-05-07 Mike Fenton <mifenton@rim.com>
  1175. [BlackBerry] Increase the padding size for caret based scrolling.
  1176. https://bugs.webkit.org/show_bug.cgi?id=115749
  1177. Reviewed by Rob Buis.
  1178. PR 322670.
  1179. Increasing the padding size for scrolling in order to optimize the
  1180. number of scrolls required during typing.
  1181. * WebKitSupport/InputHandler.cpp:
  1182. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  1183. 2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
  1184. [BlackBerry] Maintain touch event state throughout processing
  1185. https://bugs.webkit.org/show_bug.cgi?id=115663
  1186. Reviewed by Rob Buis.
  1187. Internally reviewed by Otto Cheung and Genevieve Mak.
  1188. PR 297691
  1189. By maintaining our touch event state, we can get a better idea
  1190. of what triggered an update to selection and respond appropriately.
  1191. On touch press we set userTouchTriggered to give the UI thread
  1192. some context.
  1193. * Api/WebPage.cpp:
  1194. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  1195. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  1196. (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
  1197. * Api/WebPage_p.h:
  1198. (WebPagePrivate):
  1199. * WebKitSupport/SelectionHandler.cpp:
  1200. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  1201. 2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
  1202. [BlackBerry] Read-only fields should not get keyboard focus
  1203. https://bugs.webkit.org/show_bug.cgi?id=115725
  1204. Reviewed by Rob Buis.
  1205. Internally reviewed by Mike Fenton.
  1206. PR332887
  1207. Prevent keyboard focus and FCC from displaying when the user taps on a
  1208. read-only field. Further, ensure form controls skip over these fields
  1209. with the next/previous buttons.
  1210. * WebKitSupport/DOMSupport.cpp:
  1211. (BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
  1212. (DOMSupport):
  1213. * WebKitSupport/DOMSupport.h:
  1214. * WebKitSupport/InputHandler.cpp:
  1215. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  1216. (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
  1217. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  1218. (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
  1219. (WebKit):
  1220. * WebKitSupport/InputHandler.h:
  1221. 2013-05-07 Nima Ghanavatian <nghanavatian@blackberry.com>
  1222. [BlackBerry] Expand spellcheck logging
  1223. https://bugs.webkit.org/show_bug.cgi?id=115482
  1224. Reviewed by Rob Buis.
  1225. Internally reviewed by Mike Fenton.
  1226. Fix some build errors when SpellingLog was turned on and expand on the debug
  1227. statements to be more verbose. Set up timers and print the duration of each
  1228. iteration as we traverse the text to create a range to send out for checking.
  1229. * WebKitSupport/InputHandler.cpp:
  1230. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  1231. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  1232. (BlackBerry::WebKit::InputHandler::setElementFocused):
  1233. (WebKit):
  1234. (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
  1235. * WebKitSupport/SpellingHandler.cpp:
  1236. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  1237. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  1238. 2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
  1239. [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
  1240. https://bugs.webkit.org/show_bug.cgi?id=113808
  1241. Reviewed by Rob Buis.
  1242. Create a WebSetting for text autosizing. The default is off.
  1243. * Api/WebPage.cpp:
  1244. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  1245. * Api/WebSettings.cpp:
  1246. (WebKit):
  1247. (BlackBerry::WebKit::WebSettings::standardSettings):
  1248. (BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
  1249. (BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
  1250. * Api/WebSettings.h:
  1251. 2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
  1252. [BlackBerry] Ensure document is attached before accessing its FrameSelection
  1253. https://bugs.webkit.org/show_bug.cgi?id=115565
  1254. Reviewed by Rob Buis.
  1255. Internally reviewed by Mike Fenton.
  1256. PR 312101
  1257. We need to make sure that the node and document
  1258. are attached before accessing the FrameSelection. This was
  1259. handled earlier but not all call paths were covered.
  1260. * WebKitSupport/InputHandler.cpp:
  1261. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  1262. (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
  1263. (WebKit):
  1264. * WebKitSupport/InputHandler.h:
  1265. 2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
  1266. [BlackBerry] Do not spellcheck when composition is active.
  1267. https://bugs.webkit.org/show_bug.cgi?id=115562
  1268. Reviewed by Rob Buis.
  1269. Internally reviewed by Mike Fenton.
  1270. PR331344
  1271. Typing can trigger rechecking since layout changes. Ensure
  1272. extra work is only done when we need it, and that it won't
  1273. be triggered when composition is active. If the user hasn't
  1274. finished a word yet, it is likely future key events will be
  1275. arriving, so checking the string at this point is extraneous.
  1276. * WebKitSupport/InputHandler.cpp:
  1277. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  1278. 2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
  1279. [BlackBerry] Reduce the spellcheck checking range
  1280. https://bugs.webkit.org/show_bug.cgi?id=115479
  1281. Reviewed by Rob Buis.
  1282. Internally reviewed by Mike Fenton.
  1283. PR332773
  1284. Previously we were spellchecking the entire field on focus. If relayouting
  1285. occurred we rechecked this region, which is very costly. Switch to check
  1286. only a small region around the caret in both cases, which should alleviate
  1287. much of the delays experienced in very large contenteditable fields. This
  1288. allows for faster key input response and less time processing these requests
  1289. on the WebKit thread.
  1290. * WebKitSupport/InputHandler.cpp:
  1291. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  1292. (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
  1293. * WebKitSupport/SpellingHandler.cpp:
  1294. (WebKit):
  1295. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  1296. * WebKitSupport/SpellingHandler.h:
  1297. (SpellingHandler):
  1298. 2013-05-06 Nima Ghanavatian <nghanavatian@blackberry.com>
  1299. [BlackBerry] Use a more descriptive timer name
  1300. https://bugs.webkit.org/show_bug.cgi?id=115481
  1301. Reviewed by Rob Buis.
  1302. Internally reviewed by Mike Fenton.
  1303. Changing m_timer to m_iterationDelayTimer.
  1304. * WebKitSupport/SpellingHandler.cpp:
  1305. (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
  1306. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  1307. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  1308. * WebKitSupport/SpellingHandler.h:
  1309. (SpellingHandler):
  1310. 2013-05-04 Nima Ghanavatian <nghanavatian@blackberry.com>
  1311. [BlackBerry] Clean up unused spellcheck code
  1312. https://bugs.webkit.org/show_bug.cgi?id=115560
  1313. Reviewed by Benjamin Poulain.
  1314. Internally reviewed by Mike Lattanzio
  1315. * Api/WebPage.cpp:
  1316. (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
  1317. * Api/WebPage.h:
  1318. * WebKitSupport/InputHandler.cpp:
  1319. * WebKitSupport/InputHandler.h:
  1320. (InputHandler):
  1321. 2013-05-03 Jacky Jiang <zhajiang@blackberry.com>
  1322. [BlackBerry] Page rendering scale is changed after go back and forward
  1323. https://bugs.webkit.org/show_bug.cgi?id=115573
  1324. Reviewed by Rob Buis.
  1325. Internally reviewed by Jeff Rogers.
  1326. PR: 326886
  1327. When navigating back from page A with viewport to page B without
  1328. viewport, we didn't call setViewMode(); therefore, we didn't change
  1329. the fixed layout size which was set by page A. In that case, WebCore
  1330. would just pick up page A's fixed layout size to layout page B which
  1331. caused this issue.
  1332. Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
  1333. later is not a good way, because zoomToInitialScaleOnLoad() has never
  1334. been called in this case. So we should always call setViewMode() to set
  1335. fixed layout size when a new page is committed.
  1336. * Api/WebPage.cpp:
  1337. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  1338. 2013-05-02 Genevieve Mak <gmak@rim.com>
  1339. [BlackBerry] Cannot touch scroll readonly text input.
  1340. https://bugs.webkit.org/show_bug.cgi?id=115378
  1341. Reviewed by Rob Buis.
  1342. PR #332902
  1343. Reviewed Internally by Mike Fenton.
  1344. Forgot half the patch.
  1345. Node::rendererIsEditable() returns false if the input element has the readonly tag set.
  1346. Check the node type instead.
  1347. * Api/InRegionScroller.cpp:
  1348. (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
  1349. 2013-05-02 Iris Wu <shuwu@blackberry.com>
  1350. [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
  1351. https://bugs.webkit.org/show_bug.cgi?id=115178
  1352. Reviewed by Rob Buis.
  1353. PR 308796
  1354. Debug build fix.
  1355. * Api/WebPage.cpp:
  1356. (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
  1357. 2013-05-01 Iris Wu <shuwu@blackberry.com>
  1358. [BlackBerry] Upstream smart selection
  1359. https://bugs.webkit.org/show_bug.cgi?id=111226
  1360. Reviewed by Rob Buis.
  1361. Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
  1362. caused crash.
  1363. But viewport from webkitThreadViewportAccessor uses unadjusted size which is
  1364. wrong for email.
  1365. The solution here is to get actual viewport size on UI thread and then pass it
  1366. to WebKit::SelectionHandler.
  1367. PR 333763
  1368. Reviewed Internally By Jakob Petsovits.
  1369. * Api/InRegionScroller.cpp:
  1370. (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
  1371. * Api/WebPage.cpp:
  1372. (BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
  1373. (WebKit):
  1374. * Api/WebPage.h:
  1375. * WebKitSupport/SelectionHandler.cpp:
  1376. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  1377. (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
  1378. (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
  1379. * WebKitSupport/SelectionHandler.h:
  1380. (BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
  1381. (BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
  1382. (SelectionHandler):
  1383. 2013-04-30 Genevieve Mak <gmak@rim.com>
  1384. [BlackBerry] Cannot touch scroll readonly text input.
  1385. https://bugs.webkit.org/show_bug.cgi?id=115378
  1386. Reviewed by Rob Buis.
  1387. PR #332902
  1388. Reviewed Internally by Mike Fenton.
  1389. Node::rendererIsEditable() returns false if the input element has the readonly tag set.
  1390. Check the node type instead.
  1391. * WebKitSupport/DOMSupport.cpp:
  1392. (BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
  1393. (DOMSupport):
  1394. * WebKitSupport/DOMSupport.h:
  1395. * WebKitSupport/InRegionScrollableArea.cpp:
  1396. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  1397. 2013-04-29 Jakob Petsovits <jpetsovits@blackberry.com>
  1398. [BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
  1399. https://bugs.webkit.org/show_bug.cgi?id=115360
  1400. Internal PR 303048.
  1401. Reviewed by Rob Buis.
  1402. Instead of using fillBuffer() to draw directly to the
  1403. target buffer, we now lock a Drawable on it and fill it
  1404. with PlatformGraphicsContext::addPredefinedPattern().
  1405. As a bonus, this also includes related clean-ups -
  1406. simpler checkerboard painting code, removal of
  1407. fillWindow(), clearWindow() and paintDefaultBackground(),
  1408. as well as getting rid of the DEBUG_CHECKERBOARD define
  1409. which has been useless for performance tracing purposes
  1410. for a while now.
  1411. * Api/BackingStore.cpp:
  1412. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  1413. * Api/BackingStore_p.h:
  1414. 2013-04-26 Nima Ghanavatian <nghanavatian@blackberry.com>
  1415. [BlackBerry] Check for valid element in elementTouched
  1416. https://bugs.webkit.org/show_bug.cgi?id=115205
  1417. Reviewed by Rob Buis.
  1418. Internally reviewed by Genevieve Mak.
  1419. PR 331546
  1420. We might receive a null ptr from nodeAsElementIfApplicable which
  1421. is passed in here. Check to make sure it's valid before using.
  1422. * WebKitSupport/InputHandler.cpp:
  1423. (BlackBerry::WebKit::InputHandler::elementTouched):
  1424. 2013-04-26 Martin Robinson <mrobinson@igalia.com>
  1425. Remove the remaining Skia #ifdefs
  1426. https://bugs.webkit.org/show_bug.cgi?id=114886
  1427. Reviewed by Benjamin Poulain.
  1428. * Api/WebPage.cpp: Remove Skia #ifdef references.
  1429. * WebCoreSupport/AboutDataUseFeatures.in: Ditto.
  1430. 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
  1431. [BlackBerry] Should check if it's cached resource before download
  1432. https://bugs.webkit.org/show_bug.cgi?id=115101
  1433. Reviewed by Rob Buis.
  1434. Since main resource maybe cached, if user want to save the resource, we first check
  1435. if it's cached. If yes, don't need to initiate a fresh load again, but get the
  1436. cached resource data out to save.
  1437. RIM bug# 324003, internally reviewed by Charles Wei.
  1438. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1439. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  1440. 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
  1441. [BlackBerry] Clean up load interface in WebPage
  1442. https://bugs.webkit.org/show_bug.cgi?id=113267
  1443. Reviewed by Rob Buis.
  1444. Remove unused loadExtended(), combine load() and download() api in WebPage.
  1445. RIM Bug# 315535, internally reviewed by Joe Mason.
  1446. * Api/WebPage.cpp:
  1447. (BlackBerry::WebKit::WebPage::load):
  1448. * Api/WebPage.h:
  1449. 2013-04-25 Andrew Lo <anlo@rim.com>
  1450. [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
  1451. https://bugs.webkit.org/show_bug.cgi?id=115197
  1452. Reviewed by Rob Buis.
  1453. When drawing the selection overlay, the rects to
  1454. paint when selecting text on non-composited sub-frames
  1455. need to be adjusted by the frame position.
  1456. * WebKitSupport/SelectionOverlay.cpp:
  1457. (BlackBerry::WebKit::SelectionOverlay::paintContents):
  1458. 2013-04-25 Andreas Kling <akling@apple.com>
  1459. Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
  1460. Rubber-stamped by Anders Koivisto.
  1461. * WebCoreSupport/AboutDataEnableFeatures.in:
  1462. 2013-04-25 Iris Wu <shuwu@blackberry.com>
  1463. [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
  1464. https://bugs.webkit.org/show_bug.cgi?id=115178
  1465. Reviewed by Rob Buis.
  1466. PR 308796
  1467. Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
  1468. left point of the viewport.
  1469. On the page with fixed position elements, we want it to adjust the position beneath
  1470. the fixed elements so it can be always visible.
  1471. The basic idea is:
  1472. 1. Detect if there are fixed position elements before going through ProximityDetector.
  1473. 2. If the fixed element exists, calculate its the size and the actual visible position
  1474. beneath it.
  1475. 3. Pass the position to ProximityDetector. Then according to the new position we get,
  1476. calculate the top left position of the viewport (final scroll position).
  1477. * Api/WebPage.cpp:
  1478. (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
  1479. (WebKit):
  1480. * Api/WebPage.h:
  1481. * Api/WebPageCompositor.cpp:
  1482. (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
  1483. (WebKit):
  1484. * Api/WebPageCompositor_p.h:
  1485. (WebPageCompositorPrivate):
  1486. 2013-04-25 Mike Lattanzio <mlattanzio@blackberry.com>
  1487. [BlackBerry] Enable balanced page group load deferrer behaviour.
  1488. https://bugs.webkit.org/show_bug.cgi?id=115189
  1489. Reviewed by Rob Buis.
  1490. Prevent a possible deadlock by enabling balanced deferrers.
  1491. Internally reviewed by: Joe Mason
  1492. PR 329986
  1493. * Api/WebPage.cpp:
  1494. (BlackBerry::WebKit::WebPagePrivate::init):
  1495. 2013-04-25 Joseph Pecoraro <pecoraro@apple.com>
  1496. Web Inspector: ConsoleMessage should include line and column number where possible
  1497. https://bugs.webkit.org/show_bug.cgi?id=114929
  1498. Reviewed by Timothy Hatcher.
  1499. * Api/DumpRenderTreeClient.h:
  1500. * Api/WebPageClient.h:
  1501. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  1502. (WebCore::ChromeClientBlackBerry::addMessageToConsole):
  1503. * WebCoreSupport/ChromeClientBlackBerry.h:
  1504. (ChromeClientBlackBerry):
  1505. 2013-04-25 Konrad Piascik <kpiascik@blackberry.com>
  1506. [BlackBerry] Get rid of return in void method
  1507. https://bugs.webkit.org/show_bug.cgi?id=115186
  1508. Reviewed by Rob Buis.
  1509. * Api/WebPage.cpp:
  1510. (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
  1511. 2013-04-24 Nima Ghanavatian <nghanavatian@blackberry.com>
  1512. [BlackBerry] Do not clear focus on a node when tapping on form controls
  1513. https://bugs.webkit.org/show_bug.cgi?id=115055
  1514. Reviewed by Rob Buis.
  1515. Internally reviewed by Genevieve Mak.
  1516. PR316069
  1517. To allow for rich text editors to apply styles on an input field
  1518. or highlighted text, we must maintain focus on the current element
  1519. when tapping on form elements. Moving the code that clears this
  1520. context to trigger off TouchHold instead of TouchPress.
  1521. * WebKitSupport/TouchEventHandler.cpp:
  1522. (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
  1523. == Rolled over to ChangeLog-2013-04-24 ==