12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011601260136014601560166017601860196020602160226023602460256026602760286029603060316032603360346035603660376038603960406041604260436044604560466047604860496050605160526053605460556056605760586059606060616062606360646065606660676068606960706071607260736074607560766077607860796080608160826083608460856086608760886089609060916092609360946095609660976098609961006101610261036104610561066107610861096110611161126113611461156116611761186119612061216122612361246125612661276128612961306131613261336134613561366137613861396140614161426143614461456146614761486149615061516152615361546155615661576158615961606161616261636164616561666167616861696170617161726173617461756176617761786179618061816182618361846185618661876188618961906191619261936194619561966197619861996200620162026203620462056206620762086209621062116212621362146215621662176218621962206221622262236224622562266227622862296230623162326233623462356236623762386239624062416242624362446245624662476248624962506251625262536254625562566257625862596260626162626263626462656266626762686269627062716272627362746275627662776278627962806281628262836284628562866287628862896290629162926293629462956296629762986299630063016302630363046305630663076308630963106311631263136314631563166317631863196320632163226323632463256326632763286329633063316332633363346335633663376338633963406341634263436344634563466347634863496350635163526353635463556356635763586359636063616362636363646365636663676368636963706371637263736374637563766377637863796380638163826383638463856386638763886389639063916392639363946395639663976398639964006401640264036404640564066407640864096410641164126413641464156416641764186419642064216422642364246425642664276428642964306431643264336434643564366437643864396440644164426443644464456446644764486449645064516452645364546455645664576458645964606461646264636464646564666467646864696470647164726473647464756476647764786479648064816482648364846485648664876488648964906491649264936494649564966497649864996500650165026503650465056506650765086509651065116512651365146515651665176518651965206521652265236524652565266527652865296530653165326533653465356536653765386539654065416542654365446545654665476548654965506551655265536554655565566557655865596560656165626563656465656566656765686569657065716572657365746575657665776578657965806581658265836584658565866587658865896590659165926593659465956596659765986599660066016602660366046605660666076608660966106611661266136614661566166617661866196620662166226623662466256626662766286629663066316632663366346635663666376638663966406641664266436644664566466647664866496650665166526653665466556656665766586659666066616662666366646665666666676668666966706671667266736674667566766677667866796680668166826683668466856686668766886689669066916692669366946695669666976698669967006701670267036704670567066707670867096710671167126713671467156716671767186719672067216722672367246725672667276728672967306731673267336734673567366737673867396740674167426743674467456746674767486749675067516752675367546755675667576758675967606761676267636764676567666767676867696770677167726773677467756776677767786779678067816782678367846785678667876788678967906791679267936794679567966797679867996800680168026803680468056806680768086809681068116812681368146815681668176818681968206821682268236824682568266827682868296830683168326833683468356836683768386839684068416842684368446845684668476848684968506851685268536854685568566857685868596860686168626863686468656866686768686869687068716872687368746875687668776878687968806881688268836884688568866887688868896890689168926893689468956896689768986899690069016902690369046905690669076908690969106911691269136914691569166917691869196920692169226923692469256926692769286929693069316932693369346935693669376938693969406941694269436944694569466947694869496950695169526953695469556956695769586959696069616962696369646965696669676968696969706971697269736974697569766977697869796980698169826983698469856986698769886989699069916992699369946995699669976998699970007001700270037004700570067007700870097010701170127013701470157016701770187019702070217022702370247025702670277028702970307031703270337034703570367037703870397040704170427043704470457046704770487049705070517052705370547055705670577058705970607061706270637064706570667067706870697070707170727073707470757076707770787079708070817082708370847085708670877088708970907091709270937094709570967097709870997100710171027103710471057106710771087109711071117112711371147115711671177118711971207121712271237124712571267127712871297130713171327133713471357136713771387139714071417142714371447145714671477148714971507151715271537154715571567157715871597160716171627163716471657166716771687169717071717172717371747175717671777178717971807181718271837184718571867187718871897190719171927193719471957196719771987199720072017202720372047205720672077208720972107211721272137214721572167217721872197220722172227223722472257226722772287229723072317232723372347235723672377238723972407241724272437244724572467247724872497250725172527253725472557256725772587259726072617262726372647265726672677268726972707271727272737274727572767277727872797280728172827283728472857286728772887289729072917292729372947295729672977298729973007301730273037304730573067307730873097310731173127313731473157316731773187319732073217322732373247325732673277328732973307331733273337334733573367337733873397340734173427343734473457346734773487349735073517352735373547355735673577358735973607361736273637364736573667367736873697370737173727373737473757376737773787379738073817382738373847385738673877388738973907391739273937394739573967397739873997400740174027403740474057406740774087409741074117412741374147415741674177418741974207421742274237424742574267427742874297430743174327433743474357436743774387439744074417442744374447445744674477448744974507451745274537454745574567457745874597460746174627463746474657466746774687469747074717472747374747475747674777478747974807481748274837484748574867487748874897490749174927493749474957496749774987499750075017502750375047505750675077508750975107511751275137514751575167517751875197520752175227523752475257526752775287529753075317532753375347535753675377538753975407541754275437544754575467547754875497550755175527553755475557556755775587559756075617562756375647565756675677568756975707571757275737574757575767577757875797580758175827583758475857586758775887589759075917592759375947595759675977598759976007601760276037604760576067607760876097610761176127613761476157616761776187619762076217622762376247625762676277628762976307631763276337634763576367637763876397640764176427643764476457646764776487649765076517652765376547655765676577658765976607661766276637664766576667667766876697670767176727673767476757676767776787679768076817682768376847685768676877688768976907691769276937694769576967697769876997700770177027703770477057706770777087709771077117712771377147715771677177718771977207721772277237724772577267727772877297730773177327733773477357736773777387739774077417742774377447745774677477748774977507751775277537754775577567757775877597760776177627763776477657766776777687769777077717772777377747775777677777778777977807781778277837784778577867787778877897790779177927793779477957796779777987799780078017802780378047805780678077808780978107811781278137814781578167817781878197820782178227823782478257826782778287829783078317832783378347835783678377838783978407841784278437844784578467847784878497850785178527853785478557856785778587859786078617862786378647865786678677868786978707871787278737874787578767877787878797880788178827883788478857886788778887889789078917892789378947895789678977898789979007901790279037904790579067907790879097910791179127913791479157916791779187919792079217922792379247925792679277928792979307931793279337934793579367937793879397940794179427943794479457946794779487949795079517952795379547955795679577958795979607961796279637964796579667967796879697970797179727973797479757976797779787979798079817982798379847985798679877988798979907991799279937994799579967997799879998000800180028003800480058006800780088009801080118012801380148015801680178018801980208021802280238024802580268027802880298030803180328033803480358036803780388039804080418042804380448045804680478048804980508051805280538054805580568057805880598060806180628063806480658066806780688069807080718072807380748075807680778078807980808081808280838084808580868087808880898090809180928093809480958096809780988099810081018102810381048105810681078108810981108111811281138114811581168117811881198120812181228123812481258126812781288129813081318132813381348135813681378138813981408141814281438144814581468147814881498150815181528153815481558156815781588159816081618162816381648165816681678168816981708171817281738174817581768177817881798180818181828183818481858186818781888189819081918192819381948195819681978198819982008201820282038204820582068207820882098210821182128213821482158216821782188219822082218222822382248225822682278228822982308231823282338234823582368237823882398240824182428243824482458246824782488249825082518252825382548255825682578258825982608261826282638264826582668267826882698270827182728273827482758276827782788279828082818282828382848285828682878288828982908291829282938294829582968297829882998300830183028303830483058306830783088309831083118312831383148315831683178318831983208321832283238324832583268327832883298330833183328333833483358336833783388339834083418342834383448345834683478348834983508351835283538354835583568357835883598360836183628363836483658366836783688369837083718372837383748375837683778378837983808381838283838384838583868387838883898390839183928393839483958396839783988399840084018402840384048405840684078408840984108411841284138414841584168417841884198420842184228423842484258426842784288429843084318432843384348435843684378438843984408441844284438444844584468447844884498450845184528453845484558456845784588459846084618462846384648465846684678468846984708471847284738474847584768477847884798480848184828483848484858486848784888489849084918492849384948495849684978498849985008501850285038504850585068507850885098510851185128513851485158516851785188519852085218522852385248525852685278528852985308531853285338534853585368537853885398540854185428543854485458546854785488549855085518552855385548555855685578558855985608561856285638564856585668567856885698570857185728573857485758576857785788579858085818582858385848585858685878588858985908591859285938594859585968597859885998600860186028603860486058606860786088609861086118612861386148615861686178618861986208621862286238624862586268627862886298630863186328633863486358636863786388639864086418642864386448645864686478648864986508651865286538654865586568657865886598660866186628663866486658666866786688669867086718672867386748675867686778678867986808681868286838684868586868687868886898690869186928693869486958696869786988699870087018702870387048705870687078708870987108711871287138714871587168717871887198720872187228723872487258726872787288729873087318732873387348735873687378738873987408741874287438744874587468747874887498750875187528753875487558756875787588759876087618762876387648765876687678768876987708771877287738774877587768777877887798780878187828783878487858786878787888789879087918792879387948795879687978798879988008801880288038804880588068807880888098810881188128813881488158816881788188819882088218822882388248825882688278828882988308831883288338834883588368837883888398840884188428843884488458846884788488849885088518852885388548855885688578858885988608861886288638864886588668867886888698870887188728873887488758876887788788879888088818882888388848885888688878888888988908891889288938894889588968897889888998900890189028903890489058906890789088909891089118912891389148915891689178918891989208921892289238924892589268927892889298930893189328933893489358936893789388939894089418942894389448945894689478948894989508951895289538954895589568957895889598960896189628963896489658966896789688969897089718972897389748975897689778978897989808981898289838984898589868987898889898990899189928993899489958996899789988999900090019002900390049005900690079008900990109011901290139014901590169017901890199020902190229023902490259026902790289029903090319032903390349035903690379038903990409041904290439044904590469047904890499050905190529053905490559056905790589059906090619062906390649065906690679068906990709071907290739074907590769077907890799080908190829083908490859086908790889089909090919092909390949095909690979098909991009101910291039104910591069107910891099110911191129113911491159116911791189119912091219122912391249125912691279128912991309131913291339134913591369137913891399140914191429143914491459146914791489149915091519152915391549155915691579158915991609161916291639164916591669167916891699170917191729173917491759176917791789179918091819182918391849185918691879188918991909191919291939194919591969197919891999200920192029203920492059206920792089209921092119212921392149215921692179218921992209221922292239224922592269227922892299230923192329233923492359236923792389239924092419242924392449245924692479248924992509251925292539254925592569257925892599260926192629263926492659266926792689269927092719272927392749275927692779278927992809281928292839284928592869287928892899290929192929293929492959296929792989299930093019302930393049305930693079308930993109311931293139314931593169317931893199320932193229323932493259326932793289329933093319332933393349335933693379338933993409341934293439344934593469347934893499350935193529353935493559356935793589359936093619362936393649365936693679368936993709371937293739374937593769377937893799380938193829383938493859386938793889389939093919392939393949395939693979398939994009401940294039404940594069407940894099410941194129413941494159416941794189419942094219422942394249425942694279428942994309431943294339434943594369437943894399440944194429443944494459446944794489449945094519452945394549455945694579458945994609461946294639464946594669467946894699470947194729473947494759476947794789479948094819482948394849485948694879488948994909491949294939494949594969497949894999500950195029503950495059506950795089509951095119512951395149515951695179518951995209521952295239524952595269527952895299530953195329533953495359536953795389539954095419542954395449545954695479548954995509551955295539554955595569557955895599560956195629563956495659566956795689569957095719572957395749575957695779578957995809581958295839584958595869587958895899590959195929593959495959596959795989599960096019602960396049605960696079608960996109611961296139614961596169617961896199620962196229623962496259626962796289629963096319632963396349635963696379638963996409641964296439644964596469647964896499650965196529653965496559656965796589659966096619662966396649665966696679668966996709671967296739674967596769677967896799680968196829683968496859686968796889689969096919692969396949695969696979698969997009701970297039704970597069707970897099710971197129713971497159716971797189719972097219722972397249725972697279728972997309731973297339734973597369737973897399740974197429743974497459746974797489749975097519752975397549755975697579758975997609761976297639764976597669767976897699770977197729773977497759776977797789779978097819782978397849785978697879788978997909791979297939794979597969797979897999800980198029803980498059806980798089809981098119812981398149815981698179818981998209821982298239824982598269827982898299830983198329833983498359836983798389839984098419842984398449845984698479848984998509851985298539854985598569857985898599860986198629863986498659866986798689869987098719872987398749875987698779878987998809881988298839884988598869887988898899890989198929893989498959896989798989899990099019902990399049905990699079908990999109911991299139914991599169917991899199920992199229923992499259926992799289929993099319932993399349935993699379938993999409941994299439944994599469947994899499950995199529953995499559956995799589959996099619962996399649965996699679968996999709971997299739974997599769977997899799980998199829983998499859986998799889989999099919992999399949995999699979998999910000100011000210003100041000510006100071000810009100101001110012100131001410015100161001710018100191002010021100221002310024100251002610027100281002910030100311003210033100341003510036100371003810039100401004110042100431004410045100461004710048100491005010051100521005310054100551005610057100581005910060100611006210063100641006510066100671006810069100701007110072100731007410075100761007710078100791008010081100821008310084100851008610087100881008910090100911009210093100941009510096100971009810099101001010110102101031010410105101061010710108101091011010111101121011310114101151011610117101181011910120101211012210123101241012510126101271012810129101301013110132101331013410135101361013710138101391014010141101421014310144101451014610147101481014910150101511015210153101541015510156101571015810159101601016110162101631016410165101661016710168101691017010171101721017310174101751017610177101781017910180101811018210183101841018510186101871018810189101901019110192101931019410195101961019710198101991020010201102021020310204102051020610207102081020910210102111021210213102141021510216102171021810219102201022110222102231022410225102261022710228102291023010231102321023310234102351023610237102381023910240102411024210243102441024510246102471024810249102501025110252102531025410255102561025710258102591026010261102621026310264102651026610267102681026910270102711027210273102741027510276102771027810279102801028110282102831028410285102861028710288102891029010291102921029310294102951029610297102981029910300103011030210303103041030510306103071030810309103101031110312103131031410315103161031710318103191032010321103221032310324103251032610327103281032910330103311033210333103341033510336103371033810339103401034110342103431034410345103461034710348103491035010351103521035310354103551035610357103581035910360103611036210363103641036510366103671036810369103701037110372103731037410375103761037710378103791038010381103821038310384103851038610387103881038910390103911039210393103941039510396103971039810399104001040110402104031040410405104061040710408104091041010411104121041310414104151041610417104181041910420104211042210423104241042510426104271042810429104301043110432104331043410435104361043710438104391044010441104421044310444104451044610447104481044910450104511045210453104541045510456104571045810459104601046110462104631046410465104661046710468104691047010471104721047310474104751047610477104781047910480104811048210483104841048510486104871048810489104901049110492104931049410495104961049710498104991050010501105021050310504105051050610507105081050910510105111051210513105141051510516105171051810519105201052110522105231052410525105261052710528105291053010531105321053310534105351053610537105381053910540105411054210543105441054510546105471054810549105501055110552105531055410555105561055710558105591056010561105621056310564105651056610567105681056910570105711057210573105741057510576105771057810579105801058110582105831058410585105861058710588105891059010591105921059310594105951059610597105981059910600106011060210603106041060510606106071060810609106101061110612106131061410615106161061710618106191062010621106221062310624106251062610627106281062910630106311063210633106341063510636106371063810639106401064110642106431064410645106461064710648106491065010651106521065310654106551065610657106581065910660106611066210663106641066510666106671066810669106701067110672106731067410675106761067710678106791068010681106821068310684106851068610687106881068910690106911069210693106941069510696106971069810699107001070110702107031070410705107061070710708107091071010711107121071310714107151071610717107181071910720107211072210723107241072510726107271072810729107301073110732107331073410735107361073710738107391074010741107421074310744107451074610747107481074910750107511075210753107541075510756107571075810759107601076110762107631076410765107661076710768107691077010771107721077310774107751077610777107781077910780107811078210783107841078510786107871078810789107901079110792107931079410795107961079710798107991080010801108021080310804108051080610807108081080910810108111081210813108141081510816108171081810819108201082110822108231082410825108261082710828108291083010831108321083310834108351083610837108381083910840108411084210843108441084510846108471084810849108501085110852108531085410855108561085710858108591086010861108621086310864108651086610867108681086910870108711087210873108741087510876108771087810879108801088110882108831088410885108861088710888108891089010891108921089310894108951089610897108981089910900109011090210903109041090510906109071090810909109101091110912109131091410915109161091710918109191092010921109221092310924109251092610927109281092910930109311093210933109341093510936109371093810939109401094110942109431094410945109461094710948109491095010951109521095310954109551095610957109581095910960109611096210963109641096510966109671096810969109701097110972109731097410975109761097710978109791098010981109821098310984109851098610987109881098910990109911099210993109941099510996109971099810999110001100111002110031100411005110061100711008110091101011011110121101311014110151101611017110181101911020110211102211023110241102511026110271102811029110301103111032110331103411035110361103711038110391104011041110421104311044110451104611047110481104911050110511105211053110541105511056110571105811059110601106111062110631106411065110661106711068110691107011071110721107311074110751107611077110781107911080110811108211083110841108511086110871108811089110901109111092110931109411095110961109711098110991110011101111021110311104111051110611107111081110911110111111111211113111141111511116111171111811119111201112111122111231112411125111261112711128111291113011131111321113311134111351113611137111381113911140111411114211143111441114511146111471114811149111501115111152111531115411155111561115711158111591116011161111621116311164111651116611167111681116911170111711117211173111741117511176111771117811179111801118111182111831118411185111861118711188111891119011191111921119311194111951119611197111981119911200112011120211203112041120511206112071120811209112101121111212112131121411215112161121711218112191122011221112221122311224112251122611227112281122911230112311123211233112341123511236112371123811239112401124111242112431124411245112461124711248112491125011251112521125311254112551125611257112581125911260112611126211263112641126511266112671126811269112701127111272112731127411275112761127711278112791128011281112821128311284112851128611287112881128911290112911129211293112941129511296112971129811299113001130111302113031130411305113061130711308113091131011311113121131311314113151131611317113181131911320113211132211323113241132511326113271132811329113301133111332113331133411335113361133711338113391134011341113421134311344113451134611347113481134911350113511135211353113541135511356113571135811359113601136111362113631136411365113661136711368113691137011371113721137311374113751137611377113781137911380113811138211383113841138511386113871138811389113901139111392113931139411395113961139711398113991140011401114021140311404114051140611407114081140911410114111141211413114141141511416114171141811419114201142111422114231142411425114261142711428114291143011431114321143311434114351143611437114381143911440114411144211443114441144511446114471144811449114501145111452114531145411455114561145711458114591146011461114621146311464114651146611467114681146911470114711147211473114741147511476114771147811479114801148111482114831148411485114861148711488114891149011491114921149311494114951149611497114981149911500115011150211503115041150511506115071150811509115101151111512115131151411515115161151711518115191152011521115221152311524115251152611527115281152911530115311153211533115341153511536115371153811539115401154111542115431154411545115461154711548115491155011551115521155311554115551155611557115581155911560115611156211563115641156511566115671156811569115701157111572115731157411575115761157711578115791158011581115821158311584115851158611587115881158911590115911159211593115941159511596115971159811599116001160111602116031160411605116061160711608116091161011611116121161311614116151161611617116181161911620116211162211623116241162511626116271162811629116301163111632116331163411635116361163711638116391164011641116421164311644116451164611647116481164911650116511165211653116541165511656116571165811659116601166111662116631166411665116661166711668116691167011671116721167311674116751167611677116781167911680116811168211683116841168511686116871168811689116901169111692116931169411695116961169711698116991170011701117021170311704117051170611707117081170911710117111171211713117141171511716117171171811719117201172111722117231172411725117261172711728117291173011731117321173311734117351173611737117381173911740117411174211743117441174511746117471174811749117501175111752117531175411755117561175711758117591176011761117621176311764117651176611767117681176911770117711177211773117741177511776117771177811779117801178111782117831178411785117861178711788117891179011791117921179311794117951179611797117981179911800118011180211803118041180511806118071180811809118101181111812118131181411815118161181711818118191182011821118221182311824118251182611827118281182911830118311183211833118341183511836118371183811839118401184111842118431184411845118461184711848118491185011851118521185311854118551185611857118581185911860118611186211863118641186511866118671186811869118701187111872118731187411875118761187711878118791188011881118821188311884118851188611887118881188911890118911189211893118941189511896118971189811899119001190111902119031190411905119061190711908119091191011911119121191311914119151191611917119181191911920119211192211923119241192511926119271192811929119301193111932119331193411935119361193711938119391194011941119421194311944119451194611947119481194911950119511195211953119541195511956119571195811959119601196111962119631196411965119661196711968119691197011971119721197311974119751197611977119781197911980119811198211983119841198511986119871198811989119901199111992119931199411995119961199711998119991200012001120021200312004120051200612007120081200912010120111201212013120141201512016120171201812019120201202112022120231202412025120261202712028120291203012031120321203312034120351203612037120381203912040120411204212043120441204512046120471204812049120501205112052120531205412055120561205712058120591206012061120621206312064120651206612067120681206912070120711207212073120741207512076120771207812079120801208112082120831208412085120861208712088120891209012091120921209312094120951209612097120981209912100121011210212103121041210512106121071210812109121101211112112121131211412115121161211712118121191212012121121221212312124121251212612127121281212912130121311213212133121341213512136121371213812139121401214112142121431214412145121461214712148121491215012151121521215312154121551215612157121581215912160121611216212163121641216512166121671216812169121701217112172121731217412175121761217712178121791218012181121821218312184121851218612187121881218912190121911219212193121941219512196121971219812199122001220112202122031220412205122061220712208122091221012211122121221312214122151221612217122181221912220122211222212223122241222512226122271222812229122301223112232122331223412235122361223712238122391224012241122421224312244122451224612247122481224912250122511225212253122541225512256122571225812259122601226112262122631226412265122661226712268122691227012271122721227312274122751227612277122781227912280122811228212283122841228512286122871228812289122901229112292122931229412295122961229712298122991230012301123021230312304123051230612307123081230912310123111231212313123141231512316123171231812319123201232112322123231232412325123261232712328123291233012331123321233312334123351233612337123381233912340123411234212343123441234512346123471234812349123501235112352123531235412355123561235712358123591236012361123621236312364123651236612367123681236912370123711237212373123741237512376123771237812379123801238112382123831238412385123861238712388123891239012391123921239312394123951239612397123981239912400124011240212403124041240512406124071240812409124101241112412124131241412415124161241712418124191242012421124221242312424124251242612427124281242912430124311243212433124341243512436124371243812439124401244112442124431244412445124461244712448124491245012451124521245312454124551245612457124581245912460124611246212463124641246512466124671246812469124701247112472124731247412475124761247712478124791248012481124821248312484124851248612487124881248912490124911249212493124941249512496124971249812499125001250112502125031250412505125061250712508125091251012511125121251312514125151251612517125181251912520125211252212523125241252512526125271252812529125301253112532125331253412535125361253712538125391254012541125421254312544125451254612547125481254912550125511255212553125541255512556125571255812559125601256112562125631256412565125661256712568125691257012571125721257312574125751257612577125781257912580125811258212583125841258512586125871258812589125901259112592125931259412595125961259712598125991260012601126021260312604126051260612607126081260912610126111261212613126141261512616126171261812619126201262112622126231262412625126261262712628126291263012631126321263312634126351263612637126381263912640126411264212643126441264512646126471264812649126501265112652126531265412655126561265712658126591266012661126621266312664126651266612667126681266912670126711267212673126741267512676126771267812679126801268112682126831268412685126861268712688126891269012691126921269312694126951269612697126981269912700127011270212703127041270512706127071270812709127101271112712127131271412715127161271712718127191272012721127221272312724127251272612727127281272912730127311273212733127341273512736127371273812739127401274112742127431274412745127461274712748127491275012751127521275312754127551275612757127581275912760127611276212763127641276512766127671276812769127701277112772127731277412775127761277712778127791278012781127821278312784127851278612787127881278912790127911279212793127941279512796127971279812799128001280112802128031280412805128061280712808128091281012811128121281312814128151281612817128181281912820128211282212823128241282512826128271282812829128301283112832128331283412835128361283712838128391284012841128421284312844128451284612847128481284912850128511285212853128541285512856128571285812859128601286112862128631286412865128661286712868128691287012871128721287312874128751287612877128781287912880128811288212883128841288512886128871288812889128901289112892128931289412895128961289712898128991290012901129021290312904129051290612907129081290912910129111291212913129141291512916129171291812919129201292112922129231292412925129261292712928129291293012931129321293312934129351293612937129381293912940129411294212943129441294512946129471294812949129501295112952129531295412955129561295712958129591296012961129621296312964129651296612967129681296912970129711297212973129741297512976129771297812979129801298112982129831298412985129861298712988129891299012991129921299312994129951299612997129981299913000130011300213003130041300513006130071300813009130101301113012130131301413015130161301713018130191302013021130221302313024130251302613027130281302913030130311303213033130341303513036130371303813039130401304113042130431304413045130461304713048130491305013051130521305313054130551305613057130581305913060130611306213063130641306513066130671306813069130701307113072130731307413075130761307713078130791308013081130821308313084130851308613087130881308913090130911309213093130941309513096130971309813099131001310113102131031310413105131061310713108131091311013111131121311313114131151311613117131181311913120131211312213123131241312513126131271312813129131301313113132131331313413135131361313713138131391314013141131421314313144131451314613147131481314913150131511315213153131541315513156131571315813159131601316113162131631316413165131661316713168131691317013171131721317313174131751317613177131781317913180131811318213183131841318513186131871318813189131901319113192131931319413195131961319713198131991320013201132021320313204132051320613207132081320913210132111321213213132141321513216132171321813219132201322113222132231322413225132261322713228132291323013231132321323313234132351323613237132381323913240132411324213243132441324513246132471324813249132501325113252132531325413255132561325713258132591326013261132621326313264132651326613267132681326913270132711327213273132741327513276132771327813279132801328113282132831328413285132861328713288132891329013291132921329313294132951329613297132981329913300133011330213303133041330513306133071330813309133101331113312133131331413315133161331713318133191332013321133221332313324133251332613327133281332913330133311333213333133341333513336133371333813339133401334113342133431334413345133461334713348133491335013351133521335313354133551335613357133581335913360133611336213363133641336513366133671336813369133701337113372133731337413375133761337713378133791338013381133821338313384133851338613387133881338913390133911339213393133941339513396133971339813399134001340113402134031340413405134061340713408134091341013411134121341313414134151341613417134181341913420134211342213423134241342513426134271342813429134301343113432134331343413435134361343713438134391344013441134421344313444134451344613447134481344913450134511345213453134541345513456134571345813459134601346113462134631346413465134661346713468134691347013471134721347313474134751347613477134781347913480134811348213483134841348513486134871348813489134901349113492134931349413495134961349713498134991350013501135021350313504135051350613507135081350913510135111351213513135141351513516135171351813519135201352113522135231352413525135261352713528135291353013531135321353313534135351353613537135381353913540135411354213543135441354513546135471354813549135501355113552135531355413555135561355713558135591356013561135621356313564135651356613567135681356913570135711357213573135741357513576135771357813579135801358113582135831358413585135861358713588135891359013591135921359313594135951359613597135981359913600136011360213603136041360513606136071360813609136101361113612136131361413615136161361713618136191362013621136221362313624136251362613627136281362913630136311363213633136341363513636136371363813639136401364113642136431364413645136461364713648136491365013651136521365313654136551365613657136581365913660136611366213663136641366513666136671366813669136701367113672136731367413675136761367713678136791368013681136821368313684136851368613687136881368913690136911369213693136941369513696136971369813699137001370113702137031370413705137061370713708137091371013711137121371313714137151371613717137181371913720137211372213723137241372513726137271372813729137301373113732137331373413735137361373713738137391374013741137421374313744137451374613747137481374913750137511375213753137541375513756137571375813759137601376113762137631376413765137661376713768137691377013771137721377313774137751377613777137781377913780137811378213783137841378513786137871378813789137901379113792137931379413795137961379713798137991380013801138021380313804138051380613807138081380913810138111381213813138141381513816138171381813819138201382113822138231382413825138261382713828138291383013831138321383313834138351383613837138381383913840138411384213843138441384513846138471384813849138501385113852138531385413855138561385713858138591386013861138621386313864138651386613867138681386913870138711387213873138741387513876138771387813879138801388113882138831388413885138861388713888138891389013891138921389313894138951389613897138981389913900139011390213903139041390513906139071390813909139101391113912139131391413915139161391713918139191392013921139221392313924139251392613927139281392913930139311393213933139341393513936139371393813939139401394113942139431394413945139461394713948139491395013951139521395313954139551395613957139581395913960139611396213963139641396513966139671396813969139701397113972139731397413975139761397713978139791398013981139821398313984139851398613987139881398913990139911399213993139941399513996139971399813999140001400114002140031400414005140061400714008140091401014011140121401314014140151401614017140181401914020140211402214023140241402514026140271402814029140301403114032140331403414035140361403714038140391404014041140421404314044140451404614047140481404914050140511405214053140541405514056140571405814059140601406114062140631406414065140661406714068140691407014071140721407314074140751407614077140781407914080140811408214083140841408514086140871408814089140901409114092140931409414095140961409714098140991410014101141021410314104141051410614107141081410914110141111411214113141141411514116141171411814119141201412114122141231412414125141261412714128141291413014131141321413314134141351413614137141381413914140141411414214143141441414514146141471414814149141501415114152141531415414155141561415714158141591416014161141621416314164141651416614167141681416914170141711417214173141741417514176141771417814179141801418114182141831418414185141861418714188141891419014191141921419314194141951419614197141981419914200142011420214203142041420514206142071420814209142101421114212142131421414215142161421714218142191422014221142221422314224142251422614227142281422914230142311423214233142341423514236142371423814239142401424114242142431424414245142461424714248142491425014251142521425314254142551425614257142581425914260142611426214263142641426514266142671426814269142701427114272142731427414275142761427714278142791428014281142821428314284142851428614287142881428914290142911429214293142941429514296142971429814299143001430114302143031430414305143061430714308143091431014311143121431314314143151431614317143181431914320143211432214323143241432514326143271432814329143301433114332143331433414335143361433714338143391434014341143421434314344143451434614347143481434914350143511435214353143541435514356143571435814359143601436114362143631436414365143661436714368143691437014371143721437314374143751437614377143781437914380143811438214383143841438514386143871438814389143901439114392143931439414395143961439714398143991440014401144021440314404144051440614407144081440914410144111441214413144141441514416144171441814419144201442114422144231442414425144261442714428144291443014431144321443314434144351443614437144381443914440144411444214443144441444514446144471444814449144501445114452144531445414455144561445714458144591446014461144621446314464144651446614467144681446914470144711447214473144741447514476144771447814479144801448114482144831448414485144861448714488144891449014491144921449314494144951449614497144981449914500145011450214503145041450514506145071450814509145101451114512145131451414515145161451714518145191452014521145221452314524145251452614527145281452914530145311453214533145341453514536145371453814539145401454114542145431454414545145461454714548145491455014551145521455314554145551455614557145581455914560145611456214563145641456514566145671456814569145701457114572145731457414575145761457714578145791458014581145821458314584145851458614587145881458914590145911459214593145941459514596145971459814599146001460114602146031460414605146061460714608146091461014611146121461314614146151461614617146181461914620146211462214623146241462514626146271462814629146301463114632146331463414635146361463714638146391464014641146421464314644146451464614647146481464914650146511465214653146541465514656146571465814659146601466114662146631466414665146661466714668146691467014671146721467314674146751467614677146781467914680146811468214683146841468514686146871468814689146901469114692146931469414695146961469714698146991470014701147021470314704147051470614707147081470914710147111471214713147141471514716147171471814719147201472114722147231472414725147261472714728147291473014731147321473314734147351473614737147381473914740147411474214743147441474514746147471474814749147501475114752147531475414755147561475714758147591476014761147621476314764147651476614767147681476914770147711477214773147741477514776147771477814779147801478114782147831478414785147861478714788147891479014791147921479314794147951479614797147981479914800148011480214803148041480514806148071480814809148101481114812148131481414815148161481714818148191482014821148221482314824148251482614827148281482914830148311483214833148341483514836148371483814839148401484114842148431484414845148461484714848148491485014851148521485314854148551485614857148581485914860148611486214863148641486514866148671486814869148701487114872148731487414875148761487714878148791488014881148821488314884148851488614887148881488914890148911489214893148941489514896148971489814899149001490114902149031490414905149061490714908149091491014911149121491314914149151491614917149181491914920149211492214923149241492514926149271492814929149301493114932149331493414935149361493714938149391494014941149421494314944149451494614947149481494914950149511495214953149541495514956149571495814959149601496114962149631496414965149661496714968149691497014971149721497314974149751497614977149781497914980149811498214983149841498514986149871498814989149901499114992149931499414995149961499714998149991500015001150021500315004150051500615007150081500915010150111501215013150141501515016150171501815019150201502115022150231502415025150261502715028150291503015031150321503315034150351503615037150381503915040150411504215043150441504515046150471504815049150501505115052150531505415055150561505715058150591506015061150621506315064150651506615067150681506915070150711507215073150741507515076150771507815079150801508115082150831508415085150861508715088150891509015091150921509315094150951509615097150981509915100151011510215103151041510515106151071510815109151101511115112151131511415115151161511715118151191512015121151221512315124151251512615127151281512915130151311513215133151341513515136151371513815139151401514115142151431514415145151461514715148151491515015151151521515315154151551515615157151581515915160151611516215163151641516515166151671516815169151701517115172151731517415175151761517715178151791518015181151821518315184151851518615187151881518915190151911519215193151941519515196151971519815199152001520115202152031520415205152061520715208152091521015211152121521315214152151521615217152181521915220152211522215223152241522515226152271522815229152301523115232152331523415235152361523715238152391524015241152421524315244152451524615247152481524915250152511525215253152541525515256152571525815259152601526115262152631526415265152661526715268152691527015271152721527315274152751527615277152781527915280152811528215283152841528515286152871528815289152901529115292152931529415295152961529715298152991530015301153021530315304153051530615307153081530915310153111531215313153141531515316153171531815319153201532115322153231532415325153261532715328153291533015331153321533315334153351533615337153381533915340153411534215343153441534515346153471534815349153501535115352153531535415355153561535715358153591536015361153621536315364153651536615367153681536915370153711537215373153741537515376153771537815379153801538115382153831538415385153861538715388153891539015391153921539315394153951539615397153981539915400154011540215403154041540515406154071540815409154101541115412154131541415415154161541715418154191542015421154221542315424154251542615427154281542915430154311543215433154341543515436154371543815439154401544115442154431544415445154461544715448154491545015451154521545315454154551545615457154581545915460154611546215463154641546515466154671546815469154701547115472154731547415475154761547715478154791548015481154821548315484154851548615487154881548915490154911549215493154941549515496154971549815499155001550115502155031550415505155061550715508155091551015511155121551315514155151551615517155181551915520155211552215523155241552515526155271552815529155301553115532155331553415535155361553715538155391554015541155421554315544155451554615547155481554915550155511555215553155541555515556155571555815559155601556115562155631556415565155661556715568155691557015571155721557315574155751557615577155781557915580155811558215583155841558515586155871558815589155901559115592155931559415595155961559715598155991560015601156021560315604156051560615607156081560915610156111561215613156141561515616156171561815619156201562115622156231562415625156261562715628156291563015631156321563315634156351563615637156381563915640156411564215643156441564515646156471564815649156501565115652156531565415655156561565715658156591566015661156621566315664156651566615667156681566915670156711567215673156741567515676156771567815679156801568115682156831568415685156861568715688156891569015691156921569315694156951569615697156981569915700157011570215703157041570515706157071570815709157101571115712157131571415715157161571715718157191572015721157221572315724157251572615727157281572915730157311573215733157341573515736157371573815739157401574115742157431574415745157461574715748157491575015751157521575315754157551575615757157581575915760157611576215763157641576515766157671576815769157701577115772157731577415775157761577715778157791578015781157821578315784157851578615787157881578915790157911579215793157941579515796157971579815799158001580115802158031580415805158061580715808158091581015811158121581315814158151581615817158181581915820158211582215823158241582515826158271582815829158301583115832158331583415835158361583715838158391584015841158421584315844158451584615847158481584915850158511585215853158541585515856158571585815859158601586115862158631586415865158661586715868158691587015871158721587315874158751587615877158781587915880158811588215883158841588515886158871588815889158901589115892158931589415895158961589715898158991590015901159021590315904159051590615907159081590915910159111591215913159141591515916159171591815919159201592115922159231592415925159261592715928159291593015931159321593315934159351593615937159381593915940159411594215943159441594515946159471594815949159501595115952159531595415955159561595715958159591596015961159621596315964159651596615967159681596915970159711597215973159741597515976159771597815979159801598115982159831598415985159861598715988159891599015991159921599315994159951599615997159981599916000160011600216003160041600516006160071600816009160101601116012160131601416015160161601716018160191602016021160221602316024160251602616027160281602916030160311603216033160341603516036160371603816039160401604116042160431604416045160461604716048160491605016051160521605316054160551605616057160581605916060160611606216063160641606516066160671606816069160701607116072160731607416075160761607716078160791608016081160821608316084160851608616087160881608916090160911609216093160941609516096160971609816099161001610116102161031610416105161061610716108161091611016111161121611316114161151611616117161181611916120161211612216123161241612516126161271612816129161301613116132161331613416135161361613716138161391614016141161421614316144161451614616147161481614916150161511615216153161541615516156161571615816159161601616116162161631616416165161661616716168161691617016171161721617316174161751617616177161781617916180161811618216183161841618516186161871618816189161901619116192161931619416195161961619716198161991620016201162021620316204162051620616207162081620916210162111621216213162141621516216162171621816219162201622116222162231622416225162261622716228162291623016231162321623316234162351623616237162381623916240162411624216243162441624516246162471624816249162501625116252162531625416255162561625716258162591626016261162621626316264162651626616267162681626916270162711627216273162741627516276162771627816279162801628116282162831628416285162861628716288162891629016291162921629316294162951629616297162981629916300163011630216303163041630516306163071630816309163101631116312163131631416315163161631716318163191632016321163221632316324163251632616327163281632916330163311633216333163341633516336163371633816339163401634116342163431634416345163461634716348163491635016351163521635316354163551635616357163581635916360163611636216363163641636516366163671636816369163701637116372163731637416375163761637716378163791638016381163821638316384163851638616387163881638916390163911639216393163941639516396163971639816399164001640116402164031640416405164061640716408164091641016411164121641316414164151641616417164181641916420164211642216423164241642516426164271642816429164301643116432164331643416435164361643716438164391644016441164421644316444164451644616447164481644916450164511645216453164541645516456164571645816459164601646116462164631646416465164661646716468164691647016471164721647316474164751647616477164781647916480164811648216483164841648516486164871648816489164901649116492164931649416495164961649716498164991650016501165021650316504165051650616507165081650916510165111651216513165141651516516165171651816519165201652116522165231652416525165261652716528165291653016531165321653316534165351653616537165381653916540165411654216543165441654516546165471654816549165501655116552165531655416555165561655716558165591656016561165621656316564165651656616567165681656916570165711657216573165741657516576165771657816579165801658116582165831658416585165861658716588165891659016591165921659316594165951659616597165981659916600166011660216603166041660516606166071660816609166101661116612166131661416615166161661716618166191662016621166221662316624166251662616627166281662916630166311663216633166341663516636166371663816639166401664116642166431664416645166461664716648166491665016651166521665316654166551665616657166581665916660166611666216663166641666516666166671666816669166701667116672166731667416675166761667716678166791668016681166821668316684166851668616687166881668916690166911669216693166941669516696166971669816699167001670116702167031670416705167061670716708167091671016711167121671316714167151671616717167181671916720167211672216723167241672516726167271672816729167301673116732167331673416735167361673716738167391674016741167421674316744167451674616747167481674916750167511675216753167541675516756167571675816759167601676116762167631676416765167661676716768167691677016771167721677316774167751677616777167781677916780167811678216783167841678516786167871678816789167901679116792167931679416795167961679716798167991680016801168021680316804168051680616807168081680916810168111681216813168141681516816168171681816819168201682116822168231682416825168261682716828168291683016831168321683316834168351683616837168381683916840168411684216843168441684516846168471684816849168501685116852168531685416855168561685716858168591686016861168621686316864168651686616867168681686916870168711687216873168741687516876168771687816879168801688116882168831688416885168861688716888168891689016891168921689316894168951689616897168981689916900169011690216903169041690516906169071690816909169101691116912169131691416915169161691716918169191692016921169221692316924169251692616927169281692916930169311693216933169341693516936169371693816939169401694116942169431694416945169461694716948169491695016951169521695316954169551695616957169581695916960169611696216963169641696516966169671696816969169701697116972169731697416975169761697716978169791698016981169821698316984169851698616987169881698916990169911699216993169941699516996169971699816999170001700117002170031700417005170061700717008170091701017011170121701317014170151701617017170181701917020170211702217023170241702517026170271702817029170301703117032170331703417035170361703717038170391704017041170421704317044170451704617047170481704917050170511705217053170541705517056170571705817059170601706117062170631706417065170661706717068170691707017071170721707317074170751707617077170781707917080170811708217083170841708517086170871708817089170901709117092170931709417095170961709717098170991710017101171021710317104171051710617107171081710917110171111711217113171141711517116171171711817119171201712117122171231712417125171261712717128171291713017131171321713317134171351713617137171381713917140171411714217143171441714517146171471714817149171501715117152171531715417155171561715717158171591716017161171621716317164171651716617167171681716917170171711717217173171741717517176171771717817179171801718117182171831718417185171861718717188171891719017191171921719317194171951719617197171981719917200172011720217203172041720517206172071720817209172101721117212172131721417215172161721717218172191722017221172221722317224172251722617227172281722917230172311723217233172341723517236172371723817239172401724117242172431724417245172461724717248172491725017251172521725317254172551725617257172581725917260172611726217263172641726517266172671726817269172701727117272172731727417275172761727717278172791728017281172821728317284172851728617287172881728917290172911729217293172941729517296172971729817299173001730117302173031730417305173061730717308173091731017311173121731317314173151731617317173181731917320173211732217323173241732517326173271732817329173301733117332173331733417335173361733717338173391734017341173421734317344173451734617347173481734917350173511735217353173541735517356173571735817359173601736117362173631736417365173661736717368173691737017371173721737317374173751737617377173781737917380173811738217383173841738517386173871738817389173901739117392173931739417395173961739717398173991740017401174021740317404174051740617407174081740917410174111741217413174141741517416174171741817419174201742117422174231742417425174261742717428174291743017431174321743317434174351743617437174381743917440174411744217443174441744517446174471744817449174501745117452174531745417455174561745717458174591746017461174621746317464174651746617467174681746917470174711747217473174741747517476174771747817479174801748117482174831748417485174861748717488174891749017491174921749317494174951749617497174981749917500175011750217503175041750517506175071750817509175101751117512175131751417515175161751717518175191752017521175221752317524175251752617527175281752917530175311753217533175341753517536175371753817539175401754117542175431754417545175461754717548175491755017551175521755317554175551755617557175581755917560175611756217563175641756517566175671756817569175701757117572175731757417575175761757717578175791758017581175821758317584175851758617587175881758917590175911759217593175941759517596175971759817599176001760117602176031760417605176061760717608176091761017611176121761317614176151761617617176181761917620176211762217623176241762517626176271762817629176301763117632176331763417635176361763717638176391764017641176421764317644176451764617647176481764917650176511765217653176541765517656176571765817659176601766117662176631766417665176661766717668176691767017671176721767317674176751767617677176781767917680176811768217683176841768517686176871768817689176901769117692176931769417695176961769717698176991770017701177021770317704177051770617707177081770917710177111771217713177141771517716177171771817719177201772117722177231772417725177261772717728177291773017731177321773317734177351773617737177381773917740177411774217743177441774517746177471774817749177501775117752177531775417755177561775717758177591776017761177621776317764177651776617767177681776917770177711777217773177741777517776177771777817779177801778117782177831778417785177861778717788177891779017791177921779317794177951779617797177981779917800178011780217803178041780517806178071780817809178101781117812178131781417815178161781717818178191782017821178221782317824178251782617827178281782917830178311783217833178341783517836178371783817839178401784117842178431784417845178461784717848178491785017851178521785317854178551785617857178581785917860178611786217863178641786517866178671786817869178701787117872178731787417875178761787717878178791788017881178821788317884178851788617887178881788917890178911789217893178941789517896178971789817899179001790117902179031790417905179061790717908179091791017911179121791317914179151791617917179181791917920179211792217923179241792517926179271792817929179301793117932179331793417935179361793717938179391794017941179421794317944179451794617947179481794917950179511795217953179541795517956179571795817959179601796117962179631796417965179661796717968179691797017971179721797317974179751797617977179781797917980179811798217983179841798517986179871798817989179901799117992179931799417995179961799717998179991800018001180021800318004180051800618007180081800918010180111801218013180141801518016180171801818019180201802118022180231802418025180261802718028180291803018031180321803318034180351803618037180381803918040180411804218043180441804518046180471804818049180501805118052180531805418055180561805718058180591806018061180621806318064180651806618067180681806918070180711807218073180741807518076180771807818079180801808118082180831808418085180861808718088180891809018091180921809318094180951809618097180981809918100181011810218103181041810518106181071810818109181101811118112181131811418115181161811718118181191812018121181221812318124181251812618127181281812918130181311813218133181341813518136181371813818139181401814118142181431814418145181461814718148181491815018151181521815318154181551815618157181581815918160181611816218163181641816518166181671816818169181701817118172181731817418175181761817718178181791818018181181821818318184181851818618187181881818918190181911819218193181941819518196181971819818199182001820118202182031820418205182061820718208182091821018211182121821318214182151821618217182181821918220182211822218223182241822518226182271822818229182301823118232182331823418235182361823718238182391824018241182421824318244182451824618247182481824918250182511825218253182541825518256182571825818259182601826118262182631826418265182661826718268182691827018271182721827318274182751827618277182781827918280182811828218283182841828518286182871828818289182901829118292182931829418295182961829718298182991830018301183021830318304183051830618307183081830918310183111831218313183141831518316183171831818319183201832118322183231832418325183261832718328183291833018331183321833318334183351833618337183381833918340183411834218343183441834518346183471834818349183501835118352183531835418355183561835718358183591836018361183621836318364183651836618367183681836918370183711837218373183741837518376183771837818379183801838118382183831838418385183861838718388183891839018391183921839318394183951839618397183981839918400184011840218403184041840518406184071840818409184101841118412184131841418415184161841718418184191842018421184221842318424184251842618427184281842918430184311843218433184341843518436184371843818439184401844118442184431844418445184461844718448184491845018451184521845318454184551845618457184581845918460184611846218463184641846518466184671846818469184701847118472184731847418475184761847718478184791848018481184821848318484184851848618487184881848918490184911849218493184941849518496184971849818499185001850118502185031850418505185061850718508185091851018511185121851318514185151851618517185181851918520185211852218523185241852518526185271852818529185301853118532185331853418535185361853718538185391854018541185421854318544185451854618547185481854918550185511855218553185541855518556185571855818559185601856118562185631856418565185661856718568185691857018571185721857318574185751857618577185781857918580185811858218583185841858518586185871858818589185901859118592185931859418595185961859718598185991860018601186021860318604186051860618607186081860918610186111861218613186141861518616186171861818619186201862118622186231862418625186261862718628186291863018631186321863318634186351863618637186381863918640186411864218643186441864518646186471864818649186501865118652186531865418655186561865718658186591866018661186621866318664186651866618667186681866918670186711867218673186741867518676186771867818679186801868118682186831868418685186861868718688186891869018691186921869318694186951869618697186981869918700187011870218703187041870518706187071870818709187101871118712187131871418715187161871718718187191872018721187221872318724187251872618727187281872918730187311873218733187341873518736187371873818739187401874118742187431874418745187461874718748187491875018751187521875318754187551875618757187581875918760187611876218763187641876518766187671876818769187701877118772187731877418775187761877718778187791878018781187821878318784187851878618787187881878918790187911879218793187941879518796187971879818799188001880118802188031880418805188061880718808188091881018811188121881318814188151881618817188181881918820188211882218823188241882518826188271882818829188301883118832188331883418835188361883718838188391884018841188421884318844188451884618847188481884918850188511885218853188541885518856188571885818859188601886118862188631886418865188661886718868188691887018871188721887318874188751887618877188781887918880188811888218883188841888518886188871888818889188901889118892188931889418895188961889718898188991890018901189021890318904189051890618907189081890918910189111891218913189141891518916189171891818919189201892118922189231892418925189261892718928189291893018931189321893318934189351893618937189381893918940189411894218943189441894518946189471894818949189501895118952189531895418955189561895718958189591896018961189621896318964189651896618967189681896918970189711897218973189741897518976189771897818979189801898118982189831898418985189861898718988189891899018991189921899318994189951899618997189981899919000190011900219003190041900519006190071900819009190101901119012190131901419015190161901719018190191902019021190221902319024190251902619027190281902919030190311903219033190341903519036190371903819039190401904119042190431904419045190461904719048190491905019051190521905319054190551905619057190581905919060190611906219063190641906519066190671906819069190701907119072190731907419075190761907719078190791908019081190821908319084190851908619087190881908919090190911909219093190941909519096190971909819099191001910119102191031910419105191061910719108191091911019111191121911319114191151911619117191181911919120191211912219123191241912519126191271912819129191301913119132191331913419135191361913719138191391914019141191421914319144191451914619147191481914919150191511915219153191541915519156191571915819159191601916119162191631916419165191661916719168191691917019171191721917319174191751917619177191781917919180191811918219183191841918519186191871918819189191901919119192191931919419195191961919719198191991920019201192021920319204192051920619207192081920919210192111921219213192141921519216192171921819219192201922119222192231922419225192261922719228192291923019231192321923319234192351923619237192381923919240192411924219243192441924519246192471924819249192501925119252192531925419255192561925719258192591926019261192621926319264192651926619267192681926919270192711927219273192741927519276192771927819279192801928119282192831928419285192861928719288192891929019291192921929319294192951929619297192981929919300193011930219303193041930519306193071930819309193101931119312193131931419315193161931719318193191932019321193221932319324193251932619327193281932919330193311933219333193341933519336193371933819339193401934119342193431934419345193461934719348193491935019351193521935319354193551935619357193581935919360193611936219363193641936519366193671936819369193701937119372193731937419375193761937719378193791938019381193821938319384193851938619387193881938919390193911939219393193941939519396193971939819399194001940119402194031940419405194061940719408194091941019411194121941319414194151941619417194181941919420194211942219423194241942519426194271942819429194301943119432194331943419435194361943719438194391944019441194421944319444194451944619447194481944919450194511945219453194541945519456194571945819459194601946119462194631946419465194661946719468194691947019471194721947319474194751947619477194781947919480194811948219483194841948519486194871948819489194901949119492194931949419495194961949719498194991950019501195021950319504195051950619507195081950919510195111951219513195141951519516195171951819519195201952119522195231952419525195261952719528195291953019531195321953319534195351953619537195381953919540195411954219543195441954519546195471954819549195501955119552195531955419555195561955719558195591956019561195621956319564195651956619567195681956919570195711957219573195741957519576195771957819579195801958119582195831958419585195861958719588195891959019591195921959319594195951959619597195981959919600196011960219603196041960519606196071960819609196101961119612196131961419615196161961719618196191962019621196221962319624196251962619627196281962919630196311963219633196341963519636196371963819639196401964119642196431964419645196461964719648196491965019651196521965319654196551965619657196581965919660196611966219663196641966519666196671966819669196701967119672196731967419675196761967719678196791968019681196821968319684196851968619687196881968919690196911969219693196941969519696196971969819699197001970119702197031970419705197061970719708197091971019711197121971319714197151971619717197181971919720197211972219723197241972519726197271972819729197301973119732197331973419735197361973719738197391974019741197421974319744197451974619747197481974919750197511975219753197541975519756197571975819759197601976119762197631976419765197661976719768197691977019771197721977319774197751977619777197781977919780197811978219783197841978519786197871978819789197901979119792197931979419795197961979719798197991980019801198021980319804198051980619807198081980919810198111981219813198141981519816198171981819819198201982119822198231982419825198261982719828198291983019831198321983319834198351983619837198381983919840198411984219843198441984519846198471984819849198501985119852198531985419855198561985719858198591986019861198621986319864198651986619867198681986919870198711987219873198741987519876198771987819879198801988119882198831988419885198861988719888198891989019891198921989319894198951989619897198981989919900199011990219903199041990519906199071990819909199101991119912199131991419915199161991719918199191992019921199221992319924199251992619927199281992919930199311993219933199341993519936199371993819939199401994119942199431994419945199461994719948199491995019951199521995319954199551995619957199581995919960199611996219963199641996519966199671996819969199701997119972199731997419975199761997719978199791998019981199821998319984199851998619987199881998919990199911999219993199941999519996199971999819999200002000120002200032000420005200062000720008200092001020011200122001320014200152001620017200182001920020200212002220023200242002520026200272002820029200302003120032200332003420035200362003720038200392004020041200422004320044200452004620047200482004920050200512005220053200542005520056200572005820059200602006120062200632006420065200662006720068200692007020071200722007320074200752007620077200782007920080200812008220083200842008520086200872008820089200902009120092200932009420095200962009720098200992010020101201022010320104201052010620107201082010920110201112011220113201142011520116201172011820119201202012120122201232012420125201262012720128201292013020131201322013320134201352013620137201382013920140201412014220143201442014520146201472014820149201502015120152201532015420155201562015720158201592016020161201622016320164201652016620167201682016920170201712017220173201742017520176201772017820179201802018120182201832018420185201862018720188201892019020191201922019320194201952019620197201982019920200202012020220203202042020520206202072020820209202102021120212202132021420215202162021720218202192022020221202222022320224202252022620227202282022920230202312023220233202342023520236202372023820239202402024120242202432024420245202462024720248202492025020251202522025320254202552025620257202582025920260202612026220263202642026520266202672026820269202702027120272202732027420275202762027720278202792028020281202822028320284202852028620287202882028920290202912029220293202942029520296202972029820299203002030120302203032030420305203062030720308203092031020311203122031320314203152031620317203182031920320203212032220323203242032520326203272032820329203302033120332203332033420335203362033720338203392034020341203422034320344203452034620347203482034920350203512035220353203542035520356203572035820359203602036120362203632036420365203662036720368203692037020371203722037320374203752037620377203782037920380203812038220383203842038520386203872038820389203902039120392203932039420395203962039720398203992040020401204022040320404204052040620407204082040920410204112041220413204142041520416204172041820419204202042120422204232042420425204262042720428204292043020431204322043320434204352043620437204382043920440204412044220443204442044520446204472044820449204502045120452204532045420455204562045720458204592046020461204622046320464204652046620467204682046920470204712047220473204742047520476204772047820479204802048120482204832048420485204862048720488204892049020491204922049320494204952049620497204982049920500205012050220503205042050520506205072050820509205102051120512205132051420515205162051720518205192052020521205222052320524205252052620527205282052920530205312053220533205342053520536205372053820539205402054120542205432054420545205462054720548205492055020551205522055320554205552055620557205582055920560205612056220563205642056520566205672056820569205702057120572205732057420575205762057720578205792058020581205822058320584205852058620587205882058920590205912059220593205942059520596205972059820599206002060120602206032060420605206062060720608206092061020611206122061320614206152061620617206182061920620206212062220623206242062520626206272062820629206302063120632206332063420635206362063720638206392064020641206422064320644206452064620647206482064920650206512065220653206542065520656206572065820659206602066120662206632066420665206662066720668206692067020671206722067320674206752067620677206782067920680206812068220683206842068520686206872068820689206902069120692206932069420695206962069720698206992070020701207022070320704207052070620707207082070920710207112071220713207142071520716207172071820719207202072120722207232072420725207262072720728207292073020731207322073320734207352073620737207382073920740207412074220743207442074520746207472074820749207502075120752207532075420755207562075720758207592076020761207622076320764207652076620767207682076920770207712077220773207742077520776207772077820779207802078120782207832078420785207862078720788207892079020791207922079320794207952079620797207982079920800208012080220803208042080520806208072080820809208102081120812208132081420815208162081720818208192082020821208222082320824208252082620827208282082920830208312083220833208342083520836208372083820839208402084120842208432084420845208462084720848208492085020851208522085320854208552085620857208582085920860208612086220863208642086520866208672086820869208702087120872208732087420875208762087720878208792088020881208822088320884208852088620887208882088920890208912089220893208942089520896208972089820899209002090120902209032090420905209062090720908209092091020911209122091320914209152091620917209182091920920209212092220923209242092520926209272092820929209302093120932209332093420935209362093720938209392094020941209422094320944209452094620947209482094920950209512095220953209542095520956209572095820959209602096120962209632096420965209662096720968209692097020971209722097320974209752097620977209782097920980209812098220983209842098520986209872098820989209902099120992209932099420995209962099720998209992100021001210022100321004210052100621007210082100921010210112101221013210142101521016210172101821019210202102121022210232102421025210262102721028210292103021031210322103321034210352103621037210382103921040210412104221043210442104521046210472104821049210502105121052210532105421055210562105721058210592106021061210622106321064210652106621067210682106921070210712107221073210742107521076210772107821079210802108121082210832108421085210862108721088210892109021091210922109321094210952109621097210982109921100211012110221103211042110521106211072110821109211102111121112211132111421115211162111721118211192112021121211222112321124211252112621127211282112921130211312113221133211342113521136211372113821139211402114121142211432114421145211462114721148211492115021151211522115321154211552115621157211582115921160211612116221163211642116521166211672116821169211702117121172211732117421175211762117721178211792118021181211822118321184211852118621187211882118921190211912119221193211942119521196211972119821199212002120121202212032120421205212062120721208212092121021211212122121321214212152121621217212182121921220212212122221223212242122521226212272122821229212302123121232212332123421235212362123721238212392124021241212422124321244212452124621247212482124921250212512125221253212542125521256212572125821259212602126121262212632126421265212662126721268212692127021271212722127321274212752127621277212782127921280212812128221283212842128521286212872128821289212902129121292212932129421295212962129721298212992130021301213022130321304213052130621307213082130921310213112131221313213142131521316213172131821319213202132121322213232132421325213262132721328213292133021331213322133321334213352133621337213382133921340213412134221343213442134521346213472134821349213502135121352213532135421355213562135721358213592136021361213622136321364213652136621367213682136921370213712137221373213742137521376213772137821379213802138121382213832138421385213862138721388213892139021391213922139321394213952139621397213982139921400214012140221403214042140521406214072140821409214102141121412214132141421415214162141721418214192142021421214222142321424214252142621427214282142921430214312143221433214342143521436214372143821439214402144121442214432144421445214462144721448214492145021451214522145321454214552145621457214582145921460214612146221463214642146521466214672146821469214702147121472214732147421475214762147721478214792148021481214822148321484214852148621487214882148921490214912149221493214942149521496214972149821499215002150121502215032150421505215062150721508215092151021511215122151321514215152151621517215182151921520215212152221523215242152521526215272152821529215302153121532215332153421535215362153721538215392154021541215422154321544215452154621547215482154921550215512155221553215542155521556215572155821559215602156121562215632156421565215662156721568215692157021571215722157321574215752157621577215782157921580215812158221583215842158521586215872158821589215902159121592215932159421595215962159721598215992160021601216022160321604216052160621607216082160921610216112161221613216142161521616216172161821619216202162121622216232162421625216262162721628216292163021631216322163321634216352163621637216382163921640216412164221643216442164521646216472164821649216502165121652216532165421655216562165721658216592166021661216622166321664216652166621667216682166921670216712167221673216742167521676216772167821679216802168121682216832168421685216862168721688216892169021691216922169321694216952169621697216982169921700217012170221703217042170521706217072170821709217102171121712217132171421715217162171721718217192172021721217222172321724217252172621727217282172921730217312173221733217342173521736217372173821739217402174121742217432174421745217462174721748217492175021751217522175321754217552175621757217582175921760217612176221763217642176521766217672176821769217702177121772217732177421775217762177721778217792178021781217822178321784217852178621787217882178921790217912179221793217942179521796217972179821799218002180121802218032180421805218062180721808218092181021811218122181321814218152181621817218182181921820218212182221823218242182521826218272182821829218302183121832218332183421835218362183721838218392184021841218422184321844218452184621847218482184921850218512185221853218542185521856218572185821859218602186121862218632186421865218662186721868218692187021871218722187321874218752187621877218782187921880218812188221883218842188521886218872188821889218902189121892218932189421895218962189721898218992190021901219022190321904219052190621907219082190921910219112191221913219142191521916219172191821919219202192121922219232192421925219262192721928219292193021931219322193321934219352193621937219382193921940219412194221943219442194521946219472194821949219502195121952219532195421955219562195721958219592196021961219622196321964219652196621967219682196921970219712197221973219742197521976219772197821979219802198121982219832198421985219862198721988219892199021991219922199321994219952199621997219982199922000220012200222003220042200522006220072200822009220102201122012220132201422015220162201722018220192202022021220222202322024220252202622027220282202922030220312203222033220342203522036220372203822039220402204122042220432204422045220462204722048220492205022051220522205322054220552205622057220582205922060220612206222063220642206522066220672206822069220702207122072220732207422075220762207722078220792208022081220822208322084220852208622087220882208922090220912209222093220942209522096220972209822099221002210122102221032210422105221062210722108221092211022111221122211322114221152211622117221182211922120221212212222123221242212522126221272212822129221302213122132221332213422135221362213722138221392214022141221422214322144221452214622147221482214922150221512215222153221542215522156221572215822159221602216122162221632216422165221662216722168221692217022171221722217322174221752217622177221782217922180221812218222183221842218522186221872218822189221902219122192221932219422195221962219722198221992220022201222022220322204222052220622207222082220922210222112221222213222142221522216222172221822219222202222122222222232222422225222262222722228222292223022231222322223322234222352223622237222382223922240222412224222243222442224522246222472224822249222502225122252222532225422255222562225722258222592226022261222622226322264222652226622267222682226922270222712227222273222742227522276222772227822279222802228122282222832228422285222862228722288222892229022291222922229322294222952229622297222982229922300 |
- 2013-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
- https://bugs.webkit.org/show_bug.cgi?id=114952
- Reviewed by Rob Buis.
- Do not assume that Batch requests are only created whe input field
- is focused, the Editor can also create Batch requests when pasting
- a selection.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- Remove invalid assert.
- 2013-04-23 Xan Lopez <xlopez@igalia.com>
- [BlackBerry] Simplify BackForwardListBlackBerry::clear
- https://bugs.webkit.org/show_bug.cgi?id=115029
- Reviewed by Carlos Garcia Campos.
- Simplify the implementation of the clear method. Instead of asking
- the WebCore implementation to search each item and delete it, set
- the capacity of the list to zero directly, which will do the same
- thing but more efficiently.
- No change in behavior, no new tests.
- * WebCoreSupport/BackForwardListBlackBerry.cpp:
- (WebCore::BackForwardListBlackBerry::clear):
- 2013-04-23 Xan Lopez <xlopez@igalia.com>
- [BlackBerry] Do not access BackForwardListImpl from DRT
- https://bugs.webkit.org/show_bug.cgi?id=115041
- Reviewed by Carlos Garcia Campos.
- Export the necessary functionality in our BackForwardList port
- client in order for DRT to work.
- * WebCoreSupport/BackForwardListBlackBerry.cpp:
- (WebCore::BackForwardListBlackBerry::backListWithLimit):
- (WebCore):
- (WebCore::BackForwardListBlackBerry::forwardListWithLimit):
- (WebCore::BackForwardListBlackBerry::capacity):
- * WebCoreSupport/BackForwardListBlackBerry.h:
- (BackForwardListBlackBerry):
- 2013-04-23 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Need to send out change event for date/color picker
- https://bugs.webkit.org/show_bug.cgi?id=114942
- Reviewed by Carlos Garcia Campos.
- We need to instruct the FormControlElements to send out 'change' event
- when the user makes the selection and closes the PagePopup for date/color.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::setValueAndClosePopup):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValueAndClosePopup):
- 2013-04-22 Eli Fidler <efidler@blackberry.com>
- [BlackBerry] Update about:config lists
- https://bugs.webkit.org/show_bug.cgi?id=114967
- Reviewed by Rob Buis.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutDataHaveFeatures.in:
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2013-04-22 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
- https://bugs.webkit.org/show_bug.cgi?id=114892
- Reviewed by Rob Buis.
- PR 328147
- Modify the client so we only have one listener for battery change events.
- The dispatch of different event listeners are handled by BatteryController.
- * WebCoreSupport/BatteryClientBlackBerry.cpp:
- (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
- (WebCore::BatteryClientBlackBerry::startUpdating):
- (WebCore::BatteryClientBlackBerry::stopUpdating):
- (WebCore::BatteryClientBlackBerry::onStatusChange):
- * WebCoreSupport/BatteryClientBlackBerry.h:
- (BatteryClientBlackBerry):
- 2013-04-22 Xuefei Ren <xren@blackberry.com>
- fix build warning(unused parameter)
- https://bugs.webkit.org/show_bug.cgi?id=114855
- Reviewed by Rob Buis.
- remove warning(unused parameter) in
- Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::extractedTextRequest):
- 2013-04-22 Xan Lopez <xlopez@igalia.com>
- [BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
- https://bugs.webkit.org/show_bug.cgi?id=114741
- Reviewed by George Staikos.
- Consider the case where a ResourceHandle won't have a FilterStream
- object associated (for example, Blob objects) instead of ASSERTing
- pointlessly when asking our network layer for such an object.
- This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- 2013-04-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add additional datalist support.
- https://bugs.webkit.org/show_bug.cgi?id=114883
- Reviewed by Rob Buis.
- PR 210083.
- Properly set state when opening a Date/Time popup and simplify
- the logic for showing datalist options.
- Internally Reviewed by Otto Cheung.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- (BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
- 2013-04-19 Andy Chen <andchen@blackberry.com>
- [BlackBerry] Find-on-page should do the scoping again when highlight policy changed
- https://bugs.webkit.org/show_bug.cgi?id=114885
- Reviewed by Rob Buis.
- PR 195773
- Internally reviewed by Mike Fenton.
- For find on page, we need to treat it as a new search if highlightAllMatches
- changes but the text is not changed.
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- 2013-04-19 Xuefei Ren <xren@blackberry.com>
- fixed debug broken from previous patch
- https://bugs.webkit.org/show_bug.cgi?id=114844
- Reviewed by Rob Buis.
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
- Add the parameter outstandingJobs which is used in ASSERT(),it was
- removed in the r148677 by misstake.now I need to fix it.
- 2013-04-19 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] EditorClientBlackBerry: Fix parameter name
- https://bugs.webkit.org/show_bug.cgi?id=114856
- Reviewed by Carlos Garcia Campos.
- Build fix due to a typo in a parameter name.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::requestCheckingOfString):
- 2013-04-18 Nima Ghanavatian <nghanavatian@blackberry.com>
- [BlackBerry] Invalidate spell checking requests in platform code
- https://bugs.webkit.org/show_bug.cgi?id=114830
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- Cache the value of the last requested sequence id at focus change.
- All requests prior to this point will be rejected upon processing.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-04-17 Geoffrey Garen <ggaren@apple.com>
- Renamed JSGlobalData to VM
- https://bugs.webkit.org/show_bug.cgi?id=114777
- Reviewed by Phil Pizlo.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- * WebKitSupport/AboutData.cpp:
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::javaScriptObjectsCount):
- 2013-04-18 Ed Baker <edbaker@blackberry.com>
- [BlackBerry] Should pass through an actual error code when calling notifyLoadFinished
- https://bugs.webkit.org/show_bug.cgi?id=114815
- Reviewed by Rob Buis.
- PR #318079
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::postProgressFinishedNotification):
- 2013-04-18 Xuefei Ren <xren@blackberry.com>
- remove build warning(unused parameter)
- https://bugs.webkit.org/show_bug.cgi?id=114670
- Reviewed by Rob Buis.
- remove builde warning (unused parameter) in
- Source/WebKit/blackberry
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::backingStoreRectChanging):
- (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
- (BlackBerry::WebKit::SurfacePool::waitForBuffer):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
- 2013-04-18 Xuefei Ren <xren@blackberry.com>
- remove build warning(unused parameter)
- https://bugs.webkit.org/show_bug.cgi?id=114670
- Reviewed by Rob Buis.
- remove build warning in Source/WebKit/blackberry/Api
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::scroll):
- (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
- (BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearAppCache):
- (BlackBerry::WebKit::clearDatabase):
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::cleanup):
- 2013-04-18 Xuefei Ren <xren@blackberry.com>
- removei build warning (unused parameter )
- https://bugs.webkit.org/show_bug.cgi?id=114670
- Reviewed by Rob Buis.
- remove warning (unused parameter ) in
- Source/WebKit/blackberry/WebCoreSupport
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
- (WebCore::ChromeClientBlackBerry::needTouchEvents):
- (WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValue):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::checkSpellingOfString):
- (WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
- (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
- * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
- (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
- (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::requestUserMedia):
- 2013-04-17 Nima Ghanavatian <nghanavatian@blackberry.com>
- Clean up spellcheck state when changing focus.
- https://bugs.webkit.org/show_bug.cgi?id=114758
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton and Gen Mak.
- PR325941
- If we lose focus while waiting for a spellcheck request to return, we will
- never see the reply and continue to queue up future requests. By clearing
- the queue we ensure that all requests being processed and waiting to fire
- are valid.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
- 2013-04-17 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Check image node with usemap attribute isLink failed
- https://bugs.webkit.org/show_bug.cgi?id=114751
- Reviewed by Rob Buis.
- PR 326780
- Internally Reviewed by Liam Quinn.
- An image node with usemap will crash when call isLink.
- If the node is linkNode, bring up the CCM(eg. linked image).
- Also use toElement method as agomes suggested in pr 113957.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- 2013-04-16 Nima Ghanavatian <nghanavatian@blackberry.com>
- Redo spellchecking of a field if the layout has changed
- https://bugs.webkit.org/show_bug.cgi?id=114700
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- PR258637
- If we insert a child node during spellchecking, the current request along
- with the requests in queue become stale. The offsets were calculated when
- they were created are no longer valid. We clear the queue by setting sequence
- id to -1 and trigger spell checking again. We only trigger re-checking
- if the layout change occurred during processing of a request. This is
- maintained with the m_request pointer as it should be cleared after use.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::requestCheckingOfString):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-04-16 Jacky Jiang <zhajiang@blackberry.com>
- [BlackBerry] Viewport not rendered correctly
- https://bugs.webkit.org/show_bug.cgi?id=114704
- Reviewed by Rob Buis.
- Internally reviewed by Konrad Piascik.
- PR: 326260
- The applyDeviceScaleFactorInCompositor setting is now generated from
- Settings.in after rebase, the setter should be setApplyDeviceScaleFactorInCompositor()
- instead of setApplyPageScaleFactorInCompositor().
- The setting can be removed from WebSettings and use a simpler way
- instead in the future if there are no issues when TextAutoSizer is
- enabled. Just keep it for now.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::setApplyDeviceScaleFactorInCompositor):
- * Api/WebSettings.h:
- 2013-04-16 Leo Yang <leoyang@rim.com>
- [BlackBerry] Update WebPage.{h, cpp} for supporting web filesystem
- https://bugs.webkit.org/show_bug.cgi?id=114698
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::clearBrowsingData):
- (BlackBerry::WebKit::WebPage::clearWebFileSystem):
- (WebKit):
- * Api/WebPage.h:
- 2013-04-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Accelerated animation regression with GL renderer
- https://bugs.webkit.org/show_bug.cgi?id=114685
- Reviewed by Rob Buis.
- Internally reviewed by Filip Spacek.
- GL renderer changed the assumption made in accelerated animation
- code that rendering the contents of AC layer tiles would be the
- slow operation. By starting animations after the slow operation,
- the appearance of the animation could be made smooth.
- Rendering tiles may still be slow, but now something else can be
- slow too: drawing display lists to backing. And it's running on
- the compositing thread, can happen at any time and will interrupt
- accelerated animations.
- Improved the situation by calling an API for updating backing to
- schedule the delay at a convenient time. We try to update backing
- before starting animations. However, future backing updates can
- still interrupt the running animation and cause dropped frames.
- Further improvements to animation smoothness will probably require
- optimizations in the GL renderer.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::notifyAnimationsStarted):
- (WebKit):
- * WebKitSupport/FrameLayers.h:
- (FrameLayers):
- 2013-04-15 Liam Quinn <lquinn@blackberry.com>
- [BlackBerry] Crash from null m_webSettings in WebPagePrivate
- https://bugs.webkit.org/show_bug.cgi?id=114633
- RIM PR 303745
- Reviewed by Rob Buis.
- Internally reviewed by Leo Yang.
- Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2013-04-15 Andy Chen <andchen@blackberry.com>
- [BlackBerry] Forward userGesture when creating a new window
- https://bugs.webkit.org/show_bug.cgi?id=114622
- Reviewed by Rob Buis.
- Client could use this info to decide whether the popup should
- be blocked.
- PR 291898
- Reviewed internally by Mike Fenton
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 2013-04-15 Xan Lopez <xlopez@igalia.com>
- [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
- https://bugs.webkit.org/show_bug.cgi?id=114615
- Reviewed by Carlos Garcia Campos.
- Add a method to enable the style scoped feature to our
- DumpRenderTreeSupport class.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::setStyleScopedEnabled):
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2013-04-12 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
- https://bugs.webkit.org/show_bug.cgi?id=114515
- Reviewed by Rob Buis.
- PR #317924.
- Internally reviewed by Mike Fenton.
- It was still hard to select text in URL bar with an inverted selection handle.
- We improve the issue by replacing the Y coordinate of selection point with Y
- coordinate of start caret for single line input filed. Thus, the Y coordinate
- is always valid regardless of the actual location of the selection handle.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-04-12 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Crash running layout tests
- https://bugs.webkit.org/show_bug.cgi?id=114503
- Reviewed by Xan Lopez.
- Hit an assertion in ~GuardedPointerBase when DRT is
- deleted. DumpRenderTree class derives from
- BlackBerry::Platform::LayoutTestClient that derives from
- BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
- should no be released with delete but with
- BlackBerry::Platform::deleteGuardedObject().
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- 2013-04-12 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Crash running layout tests when WebPage is destroyed
- https://bugs.webkit.org/show_bug.cgi?id=114497
- Reviewed by Xan Lopez.
- PR 324649
- Internally reviewed by Konrad Piascik and Rob Buis.
- Use a bool member to keep track of whether the inspector is
- enabled or not instead of relaying on the enable developer extras
- setting, that can be set in other places than enableWebInspector().
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
- m_inspectorEnabled.
- (BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
- inspector is already enabled and set m_inspectorEnabled to true.
- (BlackBerry::WebKit::WebPage::disableWebInspector): Return early
- if inspector is not enabled and set m_inspectorEnabled to false.
- (BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
- current value of m_inspectorEnabled instead of the developer
- extras setting.
- * Api/WebPage_p.h:
- (WebPagePrivate): Add m_inspectorEnabled.
- 2013-04-11 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Initial scale changes depending on the order of page navigations
- https://bugs.webkit.org/show_bug.cgi?id=114448
- Reviewed by Rob Buis.
- PR: 323941
- During page transitions, absoluteVisibleOverflowSize() and contentsSize()
- in fixedLayoutSize() were based on the old page when we just started or
- committed provisinal load. In that case, fixedLayoutSize() is very old
- page dependent and can cause inconsistent behaviors. For example, if
- the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
- as the new page's fixedLayoutSize; however, we will get 768 if we
- navigate to the new page directly.
- To fix that, return default layout size if the page doesn't have
- virtual viewport and m_loadState is Provisional.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 2013-04-11 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] LayerTexture refactoring
- https://bugs.webkit.org/show_bug.cgi?id=114276
- Reviewed by Carlos Garcia Campos.
- Adapt to the LayerTexture refactoring down in WebCore.
- PR 322882
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
- 2013-04-10 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Rename BlackBerry specific Texture class
- https://bugs.webkit.org/show_bug.cgi?id=95781
- Reviewed by Rob Buis.
- Texture was a bit too generic and prone to name conflicts. Renamed it
- to LayerTexture.
- PR 322882
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- * Api/WebOverlay_p.h:
- (WebOverlayLayerCompositingThreadClient):
- 2013-04-08 Anders Carlsson <andersca@apple.com>
- Remove unneeded headers from FrameLoader.h
- https://bugs.webkit.org/show_bug.cgi?id=114223
- Reviewed by Geoffrey Garen.
- Include HistoryController.h from WebCore.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 2013-04-09 Geoffrey Garen <ggaren@apple.com>
- Removed bitrotted TimeoutChecker code
- https://bugs.webkit.org/show_bug.cgi?id=114336
- Reviewed by Alexey Proskuryakov.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):
- 2013-04-09 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
- https://bugs.webkit.org/show_bug.cgi?id=114296
- Reviewed by Rob Buis.
- PR: 308655
- We were relying on the load state Committed to reset m_userPerformedManualZoom
- and m_userPerformedManualScroll; however, the main resources of the
- articles on read.thestar.com were preloaded and the WebPage didn't get
- any load state change callbacks when going back to the main page from
- the articles. Therefore, m_userPerformedManualZoom had never been reset
- in this case and we picked up the wrong scale when restoring the main page.
- Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
- we are going back or forward.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::goBackOrForward):
- 2013-04-09 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] InputHandler: fix calls to HTMLInputElement methods
- https://bugs.webkit.org/show_bug.cgi?id=114283
- Reviewed by Rob Buis.
- Fix calls with wrong names.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputType):
- 2013-04-08 Benjamin Poulain <benjamin@webkit.org>
- Remove HTML Notification
- https://bugs.webkit.org/show_bug.cgi?id=114231
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-04-08 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] WebPage: fix build due to type mismatches
- https://bugs.webkit.org/show_bug.cgi?id=114148
- Reviewed by Darin Adler.
- Add explicit conversions between LayoutUnit and int, and between
- LayoutRect and IntRect.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::rectForNode):
- 2013-04-08 Jeff Rogers <jrogers@rim.com>
- [BlackBerry] Update BlackBerry JavaScript API
- https://bugs.webkit.org/show_bug.cgi?id=114065
- Reviewed by Rob Buis.
- Internal PR 317350
- Add new API for determining if user gesture is being processed.
- Remove obsolete files.
- Properly expose JSC global context.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- (BlackBerry::WebKit::WebPage::globalContext):
- (BlackBerry::WebKit::WebPage::isProcessingUserGesture):
- (WebKit):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebCoreSupport/ClientExtension.cpp: Removed.
- * WebCoreSupport/ClientExtension.h: Removed.
- * WebCoreSupport/ExternalExtension.cpp: Removed.
- * WebCoreSupport/ExternalExtension.h: Removed.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 2013-04-08 Jakob Petsovits <jpetsovits@blackberry.com>
- [BlackBerry] More null checks for m_mainFrame
- https://bugs.webkit.org/show_bug.cgi?id=114172
- Reviewed by Rob Buis.
- After r147744, some unit tests were crashing on WebPage
- shutdown, because BackingStorePrivate::repaint() now uses
- pixelContentsRect() (accessing m_webPage->contentsRect())
- instead of BackingStoreClient::contentsRect(). In m_webPage,
- m_mainFrame had already been set to 0.
- Make us more robust against these errors by checking
- the existence of m_mainFrame more diligently.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
- (BlackBerry::WebKit::WebPagePrivate::contentsSize):
- (BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
- (BlackBerry::WebKit::WebPagePrivate::setViewMode):
- 2013-04-08 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Force horizontal list to be horizontal scrollable.
- https://bugs.webkit.org/show_bug.cgi?id=114173
- Reviewed by Rob Buis.
- Force content to be horizontal/vertical overscrollable if it
- scrolls in horizontal/vertical way.
- PR 237440
- Internally Reviewed by Arvid Nilsson.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2013-04-08 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] WebPage: misc build fixes
- https://bugs.webkit.org/show_bug.cgi?id=114152
- Reviewed by Carlos Garcia Campos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
- (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
- (BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
- (BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
- Remove unused parameters.
- (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
- (BlackBerry::WebKit::WebPage::blockZoom):
- Replace TAAUTO with TASTART (this changed in r120495).
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
- r142220).
- (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
- Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
- r113514).
- 2013-04-07 David Kilzer <ddkilzer@apple.com>
- Remove the rest of SVG_DOM_OBJC_BINDINGS
- <http://webkit.org/b/114112>
- Reviewed by Geoffrey Garen.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- - Remove reference to SVG_DOM_OBJC_BINDINGS.
- 2013-04-06 Zan Dobersek <zdobersek@igalia.com>
- Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
- https://bugs.webkit.org/show_bug.cgi?id=114084
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
- 2013-04-05 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] FatFingers Don't check the shadow tree for all elements.
- https://bugs.webkit.org/show_bug.cgi?id=114066
- Reviewed by Rob Buis.
- BlackBerry PR 263078
- Internally reviewed by Genevieve Mak.
- No need to check shadow tree since sliders use touch events.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- 2013-04-05 Zan Dobersek <zdobersek@igalia.com>
- Remove WTF_USE_GOOGLEURL-guarded code
- https://bugs.webkit.org/show_bug.cgi?id=114028
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.
- 2013-04-04 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Blitting wrong rect during history navigations
- https://bugs.webkit.org/show_bug.cgi?id=113963
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- On www.bbc.com/news, we blit wrong rect during the second restoration
- of the view states when we navigate back from stories to the main page.
- Update the contents size and scroll position before we render and blit
- if we failed to zoomAboutPoint so that UI thread can still get the
- correct rect during blit.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- 2013-04-05 Jakob Petsovits <jpetsovits@blackberry.com>
- [BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
- https://bugs.webkit.org/show_bug.cgi?id=113449
- Reviewed by Rob Buis.
- This removes the WebPage/BackingStoreClient family of coordinate
- transformation functions, which were widely disliked for their
- naming, with ViewportAccessor API that had previously been
- introduced for limited use cases. This commit takes care of the
- remaining call sites and leaves us with a single API to use.
- No new tests, only a clean-up/refactor of existing code & functionality.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
- (BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::scrollPosition):
- (BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
- (BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
- (BlackBerry::WebKit::WebPagePrivate::viewportSize):
- (BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
- (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::blockZoom):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
- (BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
- (BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
- (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
- * WebKitSupport/BackingStoreClient.h:
- (BackingStoreClient):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
- (BlackBerry::WebKit::FatFingers::FatFingers):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- * WebKitSupport/WebKitThreadViewportAccessor.cpp:
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
- 2013-04-05 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
- https://bugs.webkit.org/show_bug.cgi?id=114022
- Reviewed by Carlos Garcia Campos.
- Naming the 'time' and 'inClip' unused parameters only produces
- compiler warnings.
- * Api/WebOverlay_p.h:
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
- (WebOverlayPrivateWebKitThread):
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
- (BlackBerry::WebKit::WebPagePrivate::paintContents):
- * WebKitSupport/DefaultTapHighlight.h:
- (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
- * WebKitSupport/InspectorOverlayBlackBerry.cpp:
- (BlackBerry::WebKit::InspectorOverlay::paintContents):
- * WebKitSupport/InspectorOverlayBlackBerry.h:
- (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
- (InspectorOverlay):
- * WebKitSupport/SelectionOverlay.h:
- (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
- 2013-04-05 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] WebOverlay: fix access to m_client
- https://bugs.webkit.org/show_bug.cgi?id=114003
- Reviewed by Rob Buis.
- m_client was replace by m_overlay in r146058.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- 2013-04-05 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
- https://bugs.webkit.org/show_bug.cgi?id=114009
- Reviewed by Carlos Garcia Campos.
- These methods were removed in r133517 but were accidentally
- introduced again in r145968.
- The previous patch didn't remove them all.
- * WebKitSupport/DefaultTapHighlight.cpp:
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/InspectorOverlayBlackBerry.cpp:
- * WebKitSupport/InspectorOverlayBlackBerry.h:
- (InspectorOverlay):
- * WebKitSupport/SelectionOverlay.cpp:
- * WebKitSupport/SelectionOverlay.h:
- (SelectionOverlay):
- 2013-04-05 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
- https://bugs.webkit.org/show_bug.cgi?id=114009
- Reviewed by Carlos Garcia Campos.
- These methods were removed in r133517 but were accidentally
- introduced again in r145968.
- * Api/WebOverlay_p.h:
- (WebOverlayPrivateWebKitThread):
- 2013-04-05 Anthony Scian <ascian@blackberry.com>
- [BlackBerry] WebOverlay: check if platformContext is null
- https://bugs.webkit.org/show_bug.cgi?id=114005
- Reviewed by Carlos Garcia Campos.
- RIM PR 256522
- Internally reviewed by Mike Lattanzio.
- The pointer returned by lockBufferDrawable can be null, so it
- needs to be checked first before being used.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- 2013-04-05 Benjamin Poulain <bpoulain@apple.com>
- Remove WTFURL from WebKit
- https://bugs.webkit.org/show_bug.cgi?id=113994
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2013-04-04 Andrew Lo <anlo@rim.com>
- [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
- https://bugs.webkit.org/show_bug.cgi?id=113944
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- Internal PR 320732.
- When checking whether a RenderObject is fixed position or has a fixed position
- ancestor, we traverse the render tree upwards.
- When we reach the root of the tree, check whether the root is an
- iframe and has an element owner. If so, we also need to continue iterating
- up the tree from the owner to see if the iframe is a descendant of a fixed
- position element.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
- 2013-04-04 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Adjust fatfinger result priority
- https://bugs.webkit.org/show_bug.cgi?id=113957
- Reviewed by Rob Buis.
- RIM PR 224781
- Internally Reviewed by Genevieve Mak.
- Change fatfigner algorithm, return the clickable element rather than
- its parent anchor. Modify taphighlight and context menu node selection
- accordingly.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- * WebKitSupport/FatFingers.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::elementForTapHighlight):
- 2013-04-03 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
- https://bugs.webkit.org/show_bug.cgi?id=113872
- Reviewed by Carlos Garcia Campos.
- Carlos pointed out that recomputeVirtualViewportFromViewportArguments
- already contains the check, and returns an empty IntSize if it fails.
- So pick up on that to make the code a bit more DRY.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2013-04-03 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Decouple layout viewport from visual viewport
- https://bugs.webkit.org/show_bug.cgi?id=113829
- Reviewed by Carlos Garcia Campos.
- Setting the visual viewport would force the layout viewport equal to
- the visual viewport. Decouple the viewports by allowing the user to
- specify a layout viewport when setting the viewport(s). The layout
- viewport could be the exact same value passed for visual viewport, if
- the old behavior is desired.
- Also reevaluate any viewport arguments when (only) the layout viewport
- changes in WebPage::setDefaultLayoutSize() since the layout viewport is
- used as input to the calculation.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPage::setViewportSize):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
- (BlackBerry::WebKit::WebPage::defaultLayoutSize):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-04-02 Maxim Mogilnitsky <mmogilnitsky@rim.com>
- [BlackBerry] API update for IntRect
- https://bugs.webkit.org/show_bug.cgi?id=113824
- Reviewed by Rob Buis.
- Modifing IntRect and FloatRect API.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- 2013-04-02 Nima Ghanavatian <nghanavatian@blackberry.com>
- [BlackBerry] Create a selection from two points irregardless of the caret position.
- https://bugs.webkit.org/show_bug.cgi?id=113795
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- PR276577
- If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
- This prevents us from overwriting the previous calculation when setting extent.
- Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
- create a new directional selection so as to set the base and extent simultaneously.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- 2013-04-01 Konrad Piascik <kpiascik@blackberry.com>
- [BlackBerry] Move Path into it's own header
- https://bugs.webkit.org/show_bug.cgi?id=113724
- Reviewed by Rob Buis.
- * WebKitSupport/DefaultTapHighlight.cpp:
- 2013-03-29 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
- https://bugs.webkit.org/show_bug.cgi?id=113562
- Reviewed by George Staikos.
- Internally reviewed by Mike Fenton and Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/ContextMenuClientBlackBerry.cpp:
- * WebCoreSupport/ContextMenuClientBlackBerry.h:
- 2013-03-29 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Context menu doesn't showup anymore after rebase.
- https://bugs.webkit.org/show_bug.cgi?id=113570
- Reviewed by George Staikos.
- The upstreaming patch for bug: 103058, reverses the return value of
- Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
- so we should reverse our logic in webkit part that calls it also.
- This only applys to master_41 which is a new rebase, don't apply it to master_40.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2013-03-28 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Don't cross editing boundary when touch hold selection expands
- https://bugs.webkit.org/show_bug.cgi?id=113537
- Reviewed by Rob Buis.
- Set editing boundary crossing rule to make sure it won't cross
- editing boundary when selection expands.
- Reviewed Internally By Genevieve Mak and Mike Fenton.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
- (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
- 2013-03-28 Jakob Petsovits <jpetsovits@blackberry.com>
- [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
- https://bugs.webkit.org/show_bug.cgi?id=113447
- Internal PR 313452
- Reviewed by Rob Buis.
- Potential threading problems are avoided by moving from
- WebPage members and mapToTransformed() to the web page
- client's userInterfaceViewportAccessor().
- As part of this cleaning effort, the WebPageCompositor's
- render() method is changed to now take document instead of
- pixel coordinates.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositor::render):
- * Api/WebPageCompositor.h:
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- 2013-03-28 Matt Falkenhagen <falken@chromium.org>
- Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
- https://bugs.webkit.org/show_bug.cgi?id=113273
- Reviewed by Kent Tamura.
- Element::disabled is about form controls and Element::isEnabledFormControl
- is redundant with it, so replace them with a single function
- Element::isDisabledFormControl.
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::findPasswordFormFields):
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- 2013-03-27 Eli Fidler <efidler@blackberry.com>
- [BlackBerry] Show compositing on the Inspector timeline properly
- https://bugs.webkit.org/show_bug.cgi?id=113416
- Reviewed by Rob Buis.
- The call to willComposite was too early and encompased the paint calls
- as well. Moving it lower will no longer encompass the paints.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- 2013-03-27 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Populate the mime type of the WebContext for images
- https://bugs.webkit.org/show_bug.cgi?id=113272
- Reviewed by George Staikos.
- PR 278967
- Populate the mime type using the file extension reported by the image
- decoder. This way we benefit from file type sniffing, instead of
- relying on the mime type reported by the resource response.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2013-03-26 Hayato Ito <hayato@chromium.org>
- Allow ShadowContents in HitTests by default.
- https://bugs.webkit.org/show_bug.cgi?id=113171
- Reviewed by Dimitri Glazkov.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- * WebKitSupport/ProximityDetector.cpp:
- (BlackBerry::WebKit::ProximityDetector::findBestPoint):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2013-03-26 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=112996
- Reviewed by Rob Buis.
- PR 312552
- Internally Reviewed by Anthony Scian.
- NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
- but not deleted anywhere. Fixed by creating an OwnPtr for it.
- Also fixed some webkit-style errors.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- 2013-03-26 Mike Lattanzio <mlattanzio@blackberry.com>
- [BlackBerry] Include accelerated compositing layers in screen captures.
- https://bugs.webkit.org/show_bug.cgi?id=113335
- Reviewed by Rob Buis.
- PR# 280374
- Include accelerated compositing layers in screen captures.
- Reviewed Internally By: Jakob Petsovits
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStore::drawContents):
- * Api/BackingStore_p.h:
- 2013-03-26 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Set mouse document position for mouse event in updateCursor
- https://bugs.webkit.org/show_bug.cgi?id=109094
- Reviewed by Rob Buis.
- Internally Reviewed by Jakob Petsovits.
- Mouse content position should be in document coordinate.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 2013-03-26 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Scrolling up and down can cause the screen to flash black
- https://bugs.webkit.org/show_bug.cgi?id=113269
- Reviewed by Rob Buis.
- PR 296106
- Various flaws in the code could conspire to make the screen cleared to
- black before rendering the web page. This only happened when the
- BackingStore was inactive, and the LayerTiler takes on the job of
- drawing the root layer. When tiles are missing, this made the
- "checkerboard" effect especially noticeable since black color was seen
- where the tile should have been. It would be better to clear to the web
- page background color.
- This was actually the intent of the code, but when the document
- background color was invalid, we would still use it instead of the
- background color from settings. Also, the LayerRenderer would clear to
- black when WebPageCompositorPrivate::drawsRootLayer() was true.
- Fixed by falling back to the settings background color when the
- document background color is invalid, and removing the clearing code
- from the LayerRenderer entirely. The appropriate clear already happens
- near the beginning of BackingStorePrivate::blitVisibleContents().
- Also slightly cleaned up the code for managing the background color.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
- * Api/WebPageCompositor.cpp:
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-03-26 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
- https://bugs.webkit.org/show_bug.cgi?id=113263
- Reviewed by Rob Buis.
- PR 312404
- Fixed by returning pixel viewport coordinates instead of window
- coordinates.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
- 2013-03-26 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] Memory leak in UserMediaClientImpl
- https://bugs.webkit.org/show_bug.cgi?id=112998
- Reviewed by Rob Buis.
- PR 312559
- Internally Reviewed by Anthony Scian.
- Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
- XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::pageDestroyed):
- 2013-03-25 Kent Tamura <tkent@chromium.org>
- Rename ENABLE_INPUT_TYPE_DATETIME
- https://bugs.webkit.org/show_bug.cgi?id=113254
- Reviewed by Kentaro Hara.
- Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
- Actually I'd like to remove the code, but we shouldn't remove it yet
- because we shipped products with it on some platforms.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-03-25 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] add needReferer in WebPage load() api
- https://bugs.webkit.org/show_bug.cgi?id=113167
- Reviewed by Rob Buis.
- PR310175, internally reviewed by Joe Mason.
- Sometimes when client load request, it need to add referer with current frame like
- save link/image in option menu, so we add needRef in load() interface in webpage.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPage::load):
- (BlackBerry::WebKit::WebPage::loadExtended):
- (BlackBerry::WebKit::WebPage::loadFile):
- (BlackBerry::WebKit::WebPage::download):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-03-22 Nima Ghanavatian <nghanavatian@blackberry.com>
- [BlackBerry] Build fix in InputHandler
- https://bugs.webkit.org/show_bug.cgi?id=113092
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- 2013-03-22 Nima Ghanavatian <nghanavatian@blackberry.com>
- Check focused node reference when traversing through history
- https://bugs.webkit.org/show_bug.cgi?id=113082
- Reviewed by Rob Buis.
- PR312101
- Check if we have a valid node and document before attempting to access its frame and
- frame selection. This is causing issues when going back to a page after a redirect
- where a stale pointer is used.
- Further, the focused node should be changed after the frame is fully loaded.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::restoreViewState):
- 2013-03-22 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Hit Test doesn't need to be active
- https://bugs.webkit.org/show_bug.cgi?id=113072
- Reviewed by Rob Buis.
- Reviewed Internally By Mike Lattanzio.
- PR #306074
- * WebKitSupport/ProximityDetector.cpp:
- (BlackBerry::WebKit::ProximityDetector::findBestPoint):
- 2013-03-22 Andrew Lo <anlo@rim.com>
- [BlackBerry] Selection overlay clipped incorrectly
- https://bugs.webkit.org/show_bug.cgi?id=113069
- Reviewed by George Staikos.
- Internally reviewed by Arvid Nilsson.
- As a follow-up to r146278, the clip rect also needs to be
- adjusted by the parent's offset when drawing the
- selection overlay.
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::paintContents):
- 2013-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Add custom BackForwardList client implementation
- https://bugs.webkit.org/show_bug.cgi?id=113024
- Reviewed by Rob Buis.
- PR 310030
- Internally reviewed by Joe Mason.
- Adds a new class BackForwardListBlackBerry that implements
- BackForwardList client and wraps the BackForwardListImpl including
- the BlackBerry specific changes to notify the API layer when the
- BackForwardList changes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init): Create a
- BackForwardListBlackBerry.
- (BlackBerry::WebKit::WebPage::getBackForwardList): Use
- BackForwardListBlackBerry instead of BackForwardListImpl.
- (BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.
- * WebCoreSupport/BackForwardListBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
- (WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
- (WebCore::BackForwardListBlackBerry::current):
- (WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
- (WebCore::BackForwardListBlackBerry::addItem):
- (WebCore::BackForwardListBlackBerry::goToItem):
- (WebCore::BackForwardListBlackBerry::itemAtIndex):
- (WebCore::BackForwardListBlackBerry::backListCount):
- (WebCore::BackForwardListBlackBerry::forwardListCount):
- (WebCore::BackForwardListBlackBerry::isActive):
- (WebCore::BackForwardListBlackBerry::close):
- (WebCore::BackForwardListBlackBerry::clear):
- (WebCore::BackForwardListBlackBerry::entries):
- (WebCore::BackForwardListBlackBerry::currentItem):
- * WebCoreSupport/BackForwardListBlackBerry.h: Added.
- (WebKit):
- (WebCore):
- (BackForwardListBlackBerry):
- (WebCore::BackForwardListBlackBerry::create):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2013-03-21 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
- https://bugs.webkit.org/show_bug.cgi?id=112966
- Reviewed by Rob Buis.
- PR 312044
- Reviewed Internally By Genevieve Mak.
- If selection reaches the bottom of content, ignore scroll margin
- so the text on the bottom can be selected.
- Stop expanding selection only if the end of document is selected
- or touch is released.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::expandSelection):
- (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
- 2013-03-21 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] addSearchProvider shouldn't match the full host, only the server
- https://bugs.webkit.org/show_bug.cgi?id=112960
- Reviewed by Rob Buis.
- Internally Reviewed by Jeff Rogers.
- Remove full host matching. only check if domains are from the same server.
- Also, check user gesture before dispatching the addSearchProvider event to the browser.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addSearchProvider):
- (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebCoreSupport/ExternalExtension.cpp:
- (IsSearchProviderInstalledMethod):
- 2013-03-19 Andrew Lo <anlo@rim.com>
- [BlackBerry] Selection overlay is sometimes in wrong position.
- https://bugs.webkit.org/show_bug.cgi?id=112748
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- Internal PR 305384.
- Translate by parent's offset when drawing selection overlay.
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::paintContents):
- 2013-03-19 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Hook up scroll position to proximity detector
- https://bugs.webkit.org/show_bug.cgi?id=112743
- Reviewed by Rob Buis.
- PR 243385
- Reviewed Internally By Genevieve Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
- (WebKit):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-03-19 Chris Hutten-Czapski <chutten@blackberry.com>
- [BlackBerry] Don't handle keyboard scrolling shortcuts in webkit
- https://bugs.webkit.org/show_bug.cgi?id=112716
- Informally Reviewed by Mike Fenton (mifenton@rim.com)
- Reviewed by Rob Buis.
- The comment is right, this isn't the correct place to handle keyboard
- scrolling shortcuts. That's what we have clients for.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::keyEvent):
- 2013-03-19 Andy Chen <andchen@blackberry.com>
- [BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node
- https://bugs.webkit.org/show_bug.cgi?id=112707
- Reviewed by Rob Buis.
- In SelectionHandler, when selecting a new object, we should set focus
- to the anchor node of selection instead of removing it from the old input.
- In InputHandler, when focusedNodeChanged is called, if the new node is
- not an Element node, we need to set focus to its Element parent node,
- instead of removing focus from the old node.
- PR 304631
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- 2013-03-18 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
- https://bugs.webkit.org/show_bug.cgi?id=111733
- Reviewed by Rob Buis.
- Fix missing brace.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2013-03-18 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] Add Proximity Detector.
- https://bugs.webkit.org/show_bug.cgi?id=112278
- Reviewed by Rob Buis.
- Fix variable names so they actually match the function
- declarations.
- Fix call to rectForPoint(), which was moved from HitTestResult to
- HitTestLocation in r117091 and r126859.
- * WebKitSupport/ProximityDetector.cpp:
- (BlackBerry::WebKit::ProximityDetector::findBestPoint):
- 2013-03-18 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
- https://bugs.webkit.org/show_bug.cgi?id=112556
- Reviewed by Rob Buis.
- This changed in r145849 and broke the BlackBerry build.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
- (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
- 2013-03-18 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Detach overlays from page when compositor is detached
- https://bugs.webkit.org/show_bug.cgi?id=112424
- Reviewed by Rob Buis.
- PR 309160
- If not detached properly, the overlays would have a dangling pointer to
- the page.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
- * Api/WebOverlay_p.h:
- (BlackBerry::WebKit::WebOverlayPrivate::setClient):
- (WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
- (WebOverlayPrivateCompositingThread):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::detach):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
- (BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
- (WebPageCompositorPrivate):
- 2013-03-18 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
- https://bugs.webkit.org/show_bug.cgi?id=112547
- Reviewed by Carlos Garcia Campos.
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
- 2013-03-15 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
- https://bugs.webkit.org/show_bug.cgi?id=112467
- Reviewed by Rob Buis.
- PR 293208
- This patch contains contributions from many members of the BlackBerry
- WebKit team:
- Mike Lattanzio
- Arvid Nilsson
- Jakob Petsovits
- Konrad Piascik
- Jeff Rogers
- Filip Spacek
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- (BlackBerry::WebKit::BackingStorePrivate::tileSize):
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- * Api/WebOverlay.h:
- * Api/WebOverlayClient.h:
- * Api/WebOverlay_p.h:
- (WebOverlayPrivate):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
- (WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
- (WebOverlayPrivateCompositingThread):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::~TileBuffer):
- (BlackBerry::WebKit::TileBuffer::nativeBuffer):
- (BlackBerry::WebKit::TileBuffer::paintBackground):
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
- (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
- (WebKit):
- (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/InspectorOverlayBlackBerry.cpp:
- (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
- (WebKit):
- (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
- * WebKitSupport/InspectorOverlayBlackBerry.h:
- (InspectorOverlay):
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::draw):
- (BlackBerry::WebKit::SelectionOverlay::hide):
- (BlackBerry::WebKit::SelectionOverlay::paintContents):
- (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
- (WebKit):
- (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
- * WebKitSupport/SelectionOverlay.h:
- (SelectionOverlay):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
- (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
- (BlackBerry::WebKit::SurfacePool::waitForBuffer):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
- * WebKitSupport/SurfacePool.h:
- 2013-03-15 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
- https://bugs.webkit.org/show_bug.cgi?id=112255
- Reviewed by Rob Buis.
- PR 308284.
- Reviewed internally by Yongxin Dai.
- The cached draw rectangle is useful for hit testing. Add a getter for
- this compositing thread layer property to the public WebOverlay API.
- We name this getter using terminology familiar from the
- ViewportAccessor interface, to clarify which coordinate system the
- getter uses (pixel coordinates relative to the viewport).
- Note that WebKit-thread flavor of WebOverlay is not currently used by
- any API client and is marked obsolete. It is used internally in WebKit,
- but for that case using GraphicsLayer directly works well. This will
- allow the complexity of WebOverlay to be significantly reduced in the
- future, by removing the WebKit-thread flavor entirely.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlay::pixelViewportRect):
- (WebKit):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
- * Api/WebOverlay.h:
- (WebKit):
- * Api/WebOverlay_p.h:
- (WebOverlayPrivate):
- (WebOverlayPrivateWebKitThread):
- (WebOverlayPrivateCompositingThread):
- 2013-03-15 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Allow an embedder to position child windows using window coordinates
- https://bugs.webkit.org/show_bug.cgi?id=112236
- Reviewed by Rob Buis.
- PR 232752
- Child windows used to always be positioned in document coordinates,
- which requires the
- BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
- window to be kept in sync with the document visible content rect.
- This is easy if there's a one-to-one correspondence between windows
- and scrollable frames.
- However, for an embedder that can display an entire scene graph (where
- the web page is just one of the nodes) in one window, several
- scrollable nodes may be present in that window, and it's difficult to
- know which scrollable node to sync the virtualRect with. It could also
- lead to conflicts, if two scrollable nodes have child windows.
- For the latter scenario, it makes more sense to use window coordinates
- to place child windows.
- The internal default is to use document coordinates, for legacy
- reasons.
- When an external WebPageCompositor is attached, we switch to using
- window coordinates instead of document coordinates by default. The
- behavior is still configurable using the new public
- setChildWindowPlacement method.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
- (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):
- * Api/WebPageCompositor.h:
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
- (WebPageCompositorPrivate):
- 2013-03-15 Nate Chapin <japhet@chromium.org>
- Hide MainResourceLoader from the outside world
- https://bugs.webkit.org/show_bug.cgi?id=109971
- Reviewed by Adam Barth.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2013-03-15 Abhishek Arya <inferno@chromium.org>
- Replace static_casts with to* helper functions.
- https://bugs.webkit.org/show_bug.cgi?id=112401
- Reviewed by Stephen Chenney.
- to* helper functions are preferred over static_cast calls since they
- help to catch bad casts easily on the testing infrastructure.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::frameForNode):
- (BlackBerry::WebKit::needsLayoutRecursive):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
- 2013-03-14 Manuel Rego Casasnovas <rego@igalia.com>
- Add selectTrailingWhitespaceEnabled setting to WebCore::Page
- https://bugs.webkit.org/show_bug.cgi?id=109404
- Reviewed by Tony Chang.
- Use new settings for smartInsertDeleteEnabled and
- selectTrailingWhitespaceEnabled.
- Remove code related to DRT as it is not needed anymore.
- * Api/DumpRenderTreeClient.h:
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
- (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
- 2013-03-14 Abhishek Arya <inferno@chromium.org>
- Replace static_casts with to* helper functions.
- https://bugs.webkit.org/show_bug.cgi?id=112296
- Reviewed by Kentaro Hara.
- to* helper functions are preferred over static_cast calls since they
- help to catch bad casts easily on the testing infrastructure.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::setNodeFocus):
- (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
- (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::toTextControlElement):
- (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
- (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::elementForTapHighlight):
- 2013-03-14 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
- https://bugs.webkit.org/show_bug.cgi?id=112244
- Reviewed by Rob Buis.
- Since r143295 visibleContentRect() receives an enum, not a boolean.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2013-03-13 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Do not do scroll position adjustment if selecting in a subframe
- https://bugs.webkit.org/show_bug.cgi?id=112290
- Reviewed by Rob Buis.
- PR 267394
- In SelectionHandler::ensureSelectedTextVisible(), scroll position
- animation is based on main frame. If selecting in a subframe, don't
- do animation.
- Internally Reviewed By Genevieve Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
- 2013-03-13 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Add Proximity Detector.
- https://bugs.webkit.org/show_bug.cgi?id=112278
- Reviewed by Rob Buis.
- Internally Reviewed by Mike Lattanzio.
- PR #243385
- * WebKitSupport/ProximityDetector.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::getPriorityLevel):
- (BlackBerry::WebKit::ProximityDetector::ProximityDetector):
- (BlackBerry::WebKit::ProximityDetector::~ProximityDetector):
- (BlackBerry::WebKit::ProximityDetector::findBestPoint):
- * WebKitSupport/ProximityDetector.h: Added.
- (WebCore):
- (WebKit):
- (ProximityDetector):
- 2013-03-13 Iris Wu <shuwu@blackberry.com>
- [BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
- https://bugs.webkit.org/show_bug.cgi?id=112259
- Reviewed by Rob Buis.
- PR 267394
- While selecting in a subframe, check that the selection reaches
- the bottom of the current subframe instead of the page.
- Internally Reviewed by Genevieve Mak.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
- (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
- * WebKitSupport/SelectionHandler.h:
- (BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
- (SelectionHandler):
- 2013-03-12 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
- https://bugs.webkit.org/show_bug.cgi?id=111733
- Reviewed by Rob Buis.
- PR 305194.
- Skip rendering of selection if it is in a popup driven
- input field. This covers situations where EditorClientBlackBerry::shouldChangeSelectedRange
- is either not called or focus is not complete when called.
- Informally reviewed by Gen Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (WebKit):
- 2013-03-12 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Notify client if the selection is in a subframe when started.
- https://bugs.webkit.org/show_bug.cgi?id=112065
- Reviewed by Rob Buis.
- PR #278490
- Internally Reviewed by Mike Fenton.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
- (WebKit):
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateSelectionScrollView):
- (WebKit):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- 2013-03-12 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] SelectionHandler: fix truncated line
- https://bugs.webkit.org/show_bug.cgi?id=112133
- Reviewed by Carlos Garcia Campos.
- One of the calls to fatFingersResult.nodeAsElementIfApplicable()
- was somehow truncated when the selection start animation was
- upstreamed in r144640.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- 2013-03-12 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] Fix visible_units.h includes
- https://bugs.webkit.org/show_bug.cgi?id=112131
- Reviewed by Carlos Garcia Campos.
- This file was renamed to VisibleUnits.h in r144911.
- * WebKitSupport/DOMSupport.cpp:
- * WebKitSupport/InputHandler.cpp:
- * WebKitSupport/SelectionHandler.cpp:
- * WebKitSupport/SpellingHandler.cpp:
- 2013-03-11 Jochen Eisinger <jochen@chromium.org>
- Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
- https://bugs.webkit.org/show_bug.cgi?id=111959
- Reviewed by Alexey Proskuryakov.
- * WebKitSupport/NotificationManager.cpp:
- (BlackBerry::WebKit::NotificationManager::notificationClicked):
- 2013-03-11 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Add a method to find the ScrollView for a text selection.
- https://bugs.webkit.org/show_bug.cgi?id=112061
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton and Jakob Petsovits.
- PR #278490
- Refactor the code in InRegionScroller so that we can add a method to find
- the InRegionScrollableArea for a text selection.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
- - Pull out recursive clipping code into its own function.
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
- - This new method allows us to get just the first scrollable region instead of looking
- for more nested ones. We may want to refactor in the future because some of the code is
- very similar to calculateInRegionScrollableAreasForPoint.
- (BlackBerry::WebKit::InRegionScrollerPrivate::clipAndCreateInRegionScrollableArea):
- - Add a convenience method for the previous function
- * Api/InRegionScroller.h:
- (WebKit):
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- 2013-03-11 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Set the documentViewportRect and viewport size.
- https://bugs.webkit.org/show_bug.cgi?id=112056
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton and Jakob Petsovits.
- PR #278490
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2013-03-11 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
- https://bugs.webkit.org/show_bug.cgi?id=111972
- Reviewed by Rob Buis.
- This was removed in r144515 but is still needed by
- SelectionHandler::selectionPositionChanged().
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-03-07 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] RefCounting ParsedCookie to avoid SegFaults
- https://bugs.webkit.org/show_bug.cgi?id=111761
- Reviewed by Rob Buis.
- Making necessary changes to ref-count the ParsedCookie object.
- * Api/WebCookieJar.cpp:
- (BlackBerry::WebKit::WebCookieJar::cookies):
- 2013-03-07 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
- https://bugs.webkit.org/show_bug.cgi?id=111733
- Reviewed by Rob Buis.
- PR 305194.
- Prevent selection for popup input fields as they are buttons.
- Informally Reviewed Gen Mak.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- 2013-03-06 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
- https://bugs.webkit.org/show_bug.cgi?id=111618
- Reviewed by Rob Buis.
- PR 303712
- If we are using a RTL language, we should ensure that the selection handles are angled the right way.
- Further, when expanding the selection, the start and end handles should be appropriately set so that
- expansion in the natural direction is possible.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Use the new authenticationChallenge API in WebPage
- https://bugs.webkit.org/show_bug.cgi?id=111542
- Reviewed by Rob Buis.
- Use the new API that expects requestURL and isProxy parameters.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * Api/WebPageClient.h:
- 2013-03-05 Geoffrey Garen <ggaren@apple.com>
- Removed some dead code in the page cache
- https://bugs.webkit.org/show_bug.cgi?id=111525
- Reviewed by Alexey Proskuryakov.
- Page cache autorelease doesn't exist anymore, so there's no need to keep
- around these olds hacks.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::destroy):
- 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
- https://bugs.webkit.org/show_bug.cgi?id=111555
- Reviewed by Rob Buis.
- CachedResource::data() was renamed to
- CachedResource::resourceBuffer() in r130947.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Remove some unneeded header includes
- https://bugs.webkit.org/show_bug.cgi?id=111545
- Reviewed by Rob Buis.
- * WebCoreSupport/CredentialTransformData.cpp:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
- [BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
- https://bugs.webkit.org/show_bug.cgi?id=111544
- Reviewed by Rob Buis.
- hasLocalName() expects an AtomicString, but we are passing a
- HTMLName which is a QualifiedName.
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::findPasswordFormFields): Use
- hasTagName() instead of hasLocalName().
- 2013-03-05 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Authentication credentials lost when opening a new tab
- https://bugs.webkit.org/show_bug.cgi?id=111445
- PR 286627
- Reviewed by Rob Buis.
- Internally Reviewed by Lianghui Chen.
- Prevent changing the private mode boolean value in didChangeSettings if the value
- hasn't changed.
- Setting the private mode value of credentialstorage every time didChangeSettings gets
- called causes the session credential mapping to be cleared on every tab change in
- non-private mode.
- Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
- if the credentials are cleared. Also ensured the functionality of private mode is not changed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2013-03-05 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
- https://bugs.webkit.org/show_bug.cgi?id=111444
- Reviewed by Rob Buis.
- Internal PR 266214
- Internally reviewed by Genevieve Mak.
- Instead of subtracting with the element region, we should get the remaining
- rect by find the intersect region of element region and fatfinger detection
- region.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::checkForClickableElement):
- 2013-03-05 Andrew Lo <anlo@rim.com>
- [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
- https://bugs.webkit.org/show_bug.cgi?id=111373
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR 285468.
- Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
- animation finishes, rather than keeping those values as instance variables in
- WebPagePrivate.
- Rename some functions & variables to reflect that they are used for both block zoom
- and generic zoom/scroll animations.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
- (BlackBerry::WebKit::WebPage::zoomAnimationFinished):
- (BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
- (BlackBerry::WebKit::WebPage::blockZoom):
- (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-03-04 Iris Wu <shuwu@rim.com>
- [BlackBerry] Upstream selection start animation.
- https://bugs.webkit.org/show_bug.cgi?id=111335
- Reviewed by Rob Buis.
- PR 219960
- To indicate selection starts, we draw an overlay rect larger than
- the selected word at the start of selection. Then shrink it down
- to the actual size.
- Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.
- * Api/WebAnimation.cpp:
- (BlackBerry::WebKit::WebAnimation::shrinkAnimation):
- (WebKit):
- * Api/WebAnimation.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::selectionHighlight):
- (WebKit):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebTapHighlight.h:
- * WebKitSupport/DefaultTapHighlight.cpp:
- (WebKit):
- (BlackBerry::WebKit::shrinkAnimationName):
- (BlackBerry::WebKit::DefaultTapHighlight::draw):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2013-03-02 Benjamin Poulain <bpoulain@apple.com>
- Move computedStyleIncludingVisitedInfo from TestRunner to Internals
- https://bugs.webkit.org/show_bug.cgi?id=109772
- Reviewed by Andreas Kling.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2013-03-01 Iris Wu <shuwu@rim.com>
- [BlackBerry] Upstream smart selection
- https://bugs.webkit.org/show_bug.cgi?id=111226
- Reviewed by Rob Buis.
- 1. Extend the touch hold text selection to next paragraph.
- 2. Draw and expand overlay over text as touch hold selection expands.
- Select paragraph when it's entirely covered by overlay.
- 3. Start scrolling at a constant rate when the end of
- next pargraph is not in the viewport.
- Reviewed Internally By Genevieve Mak and Mike Fenton.
- PR 217897 238485 258279 279042 299779
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
- (BlackBerry::WebKit::WebPage::expandSelection):
- (WebKit):
- (BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
- (BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
- (BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- (BlackBerry::WebKit::isInvalidLine):
- (WebKit):
- (BlackBerry::WebKit::isInvalidParagraph):
- (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
- (BlackBerry::WebKit::SelectionHandler::drawOverlay):
- (BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
- (BlackBerry::WebKit::SelectionHandler::expandSelection):
- (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
- (BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
- (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- (BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):
- 2013-03-01 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Screen went black while navigating back/forward on the reddit.com page
- https://bugs.webkit.org/show_bug.cgi?id=111192
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- PR: 299783
- When going back to the previous reddit.com page, the actual contents
- size was much less than the history contents size. However, we expanded
- the actual contents size to history contents size which caused a huge
- black area below the actual contents.
- To fix that, don't restore the contents size from history contents size
- and scroll back to the valid contents area if we are about to overscroll.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2013-03-01 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Improve input bounds clipping for search fields.
- https://bugs.webkit.org/show_bug.cgi?id=111204
- Reviewed by Rob Buis.
- PR 292673.
- Use the standardized InputHandler function to get the
- bounds of an input field so that search fields are
- truncated smaller to account for the X.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- 2013-03-01 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Reverse the base and extent of a selection when reversing its handles
- https://bugs.webkit.org/show_bug.cgi?id=111098
- Reviewed by Yong Li.
- PR283969
- Swap the base and extent if base does not come first, and set the new selection.
- Internally reviewed by Mike Fenton
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- 2013-03-01 Alberto Garcia <albgarcia@rim.com>
- Fix definition of DatePickerClient::setValue()
- https://bugs.webkit.org/show_bug.cgi?id=110336
- Reviewed by Carlos Garcia Campos.
- The definition of DatePickerClient::setValue() introduced in
- r142987 does not match the prototype.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValue):
- 2013-02-28 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
- https://bugs.webkit.org/show_bug.cgi?id=111078
- Reviewed by Yong Li.
- PR 295224.
- When using the key navigation to modify the selection, reset the
- directionality of the selection to the original to prevent
- changing the anchor.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- 2013-02-28 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
- https://bugs.webkit.org/show_bug.cgi?id=111006
- Internal PR: 295181
- Internal reviewed by Joe Mason.
- Reviewed by Yong Li.
- Check WebSettings::isFormAutofillEnabled() before doing user credential form fill stuff.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- 2013-02-28 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] Misc build fixes
- https://bugs.webkit.org/show_bug.cgi?id=110448
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- WebString was replaced with BlackBerry::Platform::String in r131316.
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Some webdatabase APIs are encapuslated in DatabaseManager since r137520.
- (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
- Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- Add closing brace that was missing in r142482.
- 2013-02-28 Xan Lopez <xlopez@rim.com>
- [BlackBerry] DumpRenderTreeSupport: update the set position methods
- https://bugs.webkit.org/show_bug.cgi?id=110578
- Reviewed by Rob Buis.
- TestRunner::setMockGeolocationPosition() changed in r130416:
- http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2013-02-27 Andrew Lo <anlo@rim.com>
- [BlackBerry] Need WebPage API for animating scroll position & zoom changes
- https://bugs.webkit.org/show_bug.cgi?id=110912
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR 285468.
- Add an API to WebPage for animated scroll position & zoom level
- adjustments.
- Have InputHandler use the new API.
- Rename some variables to reflect the fact that they are not only
- used by block zoom now.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- (BlackBerry::WebKit::WebPage::blockZoom):
- (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
- (WebKit):
- (BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2013-02-27 Lianghui Chen <liachen@rim.com>
- [BlackBerry] User credentials is not correctly handled
- https://bugs.webkit.org/show_bug.cgi?id=110994
- Reviewed by Yong Li.
- Following change are made:
- Remove url from CredentialTransformData, as url is not used anymore.
- Adapt to updated CredentialBackingStore API about removing url.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * WebCoreSupport/CredentialManager.cpp:
- (WebCore::CredentialManager::autofillPasswordForms):
- (WebCore::CredentialManager::saveCredentialIfConfirmed):
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::CredentialTransformData):
- * WebCoreSupport/CredentialTransformData.h:
- (CredentialTransformData):
- 2013-02-27 John Griggs <jgriggs@rim.com>
- 2013-02-27 John Griggs <jgriggs@rim.com>
- Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
- https://bugs.webkit.org/show_bug.cgi?id=110905
- Reviewed by Yong Li.
- Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
- 2013-02-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
- https://bugs.webkit.org/show_bug.cgi?id=110860
- Reviewed by Yong Li.
- PR 290248 Internally reviewed by Mike Fenton
- Add a parameter to notify the webpage client which parts of selection have
- changed in visual or in its selected DOM content. Refactor the selection details
- parameter to platform repo.
- The reason of this issue is that when javascript triggers webpage layout, the selection
- will update its apperance event when the selected content is not changed. We want
- to hide the context menu only when the selected content is changed not when only its
- visual is changed.
- * Api/WebPageClient.h:
- (Platform):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-02-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] The virtual keyboard hides part of Signing In dialog
- https://bugs.webkit.org/show_bug.cgi?id=110836
- Reviewed by Yong Li.
- PR # 283427 Internally reviewed by Mike Fenton.
- Store form credentials before javascript "onSubmit" event and notify
- webpage client to save credentials after that event since javascript
- may check credentials and stop the submission in its event handler.
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::CredentialTransformData):
- (WebCore):
- * WebCoreSupport/CredentialTransformData.h:
- (CredentialTransformData):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2013-02-27 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Accept key events even when composing region is active.
- https://bugs.webkit.org/show_bug.cgi?id=110617
- Reviewed by Rob Buis.
- PR 293598.
- Fix a regression in the previous patch caused
- by an unhandled Alt key down being sent through
- by IMF.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-02-26 Yong Li <yoli@rim.com>
- [BlackBerry] Use APIEntryShim when making JS call
- https://bugs.webkit.org/show_bug.cgi?id=110787
- Reviewed by Rob Buis.
- PR# 301451.
- Use APIEntryShim to fix an assert and ensure it is thread-safe.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 2013-02-26 Alberto Garcia <agarcia@igalia.com>
- [BlackBerry] Upstream the datalist support UI
- https://bugs.webkit.org/show_bug.cgi?id=110736
- Reviewed by Rob Buis.
- Original code by Otto Derek Cheung <otcheung@rim.com>
- * WebCoreSupport/SuggestionBoxElement.cpp: Added.
- (WebCore):
- (WebCore::SuggestionBoxElement::SuggestionBoxElement):
- (WebCore::SuggestionBoxElement::~SuggestionBoxElement):
- (WebCore::SuggestionBoxElement::create):
- (WebCore::SuggestionBoxElement::defaultEventHandler):
- * WebCoreSupport/SuggestionBoxElement.h: Added.
- (WebCore):
- (SuggestionBoxElement):
- * WebCoreSupport/SuggestionBoxHandler.cpp: Added.
- (WebCore):
- (WebCore::SuggestionBoxHandler::SuggestionBoxHandler):
- (WebCore::SuggestionBoxHandler::~SuggestionBoxHandler):
- (WebCore::SuggestionBoxHandler::create):
- (WebCore::SuggestionBoxHandler::setInputElementAndUpdateDisplay):
- (WebCore::SuggestionBoxHandler::showDropdownBox):
- (WebCore::SuggestionBoxHandler::hideDropdownBox):
- (WebCore::SuggestionBoxHandler::changeInputElementInnerTextValue):
- (WebCore::SuggestionBoxHandler::parseSuggestions):
- (WebCore::SuggestionBoxHandler::insertSuggestionsToDropdownBox):
- (WebCore::adjustDropdownBoxPosition):
- (WebCore::SuggestionBoxHandler::buildDropdownBoxTree):
- * WebCoreSupport/SuggestionBoxHandler.h: Added.
- (WebCore):
- (SuggestionBoxHandler):
- (WebCore::SuggestionBoxHandler::focusedElement):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::updateFormState):
- * WebKitSupport/InputHandler.h:
- (WebCore):
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2013-02-25 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Add isInputMode() method to WebPage class.
- https://bugs.webkit.org/show_bug.cgi?id=110754
- Reviewed by Rob Buis.
- PR #262569.
- There is a case we need to know if the active node is content editable
- from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
- InputHandler::isInputMode().
- Reviewed Internally by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::isInputMode):
- (WebKit):
- * Api/WebPage.h:
- 2013-02-25 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Force form submission when implicit submission fails.
- https://bugs.webkit.org/show_bug.cgi?id=110627
- Reviewed by Rob Buis.
- PR 286023.
- When implicit form submission does not submit the form
- do a direct submission of the form.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- 2013-02-25 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry]Adjust fatfinger detection rect size.
- https://bugs.webkit.org/show_bug.cgi?id=108678
- Reviewed by Rob Buis.
- Fix a typo in function names.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- 2013-02-25 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] ChromeClientBlackBerry: fix variable names
- https://bugs.webkit.org/show_bug.cgi?id=110562
- Reviewed by Rob Buis.
- manager was incorrectly renamed back to tracker in r138696:
- http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 2013-02-24 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] GeolocationClientBlackBerry: add missing headers
- https://bugs.webkit.org/show_bug.cgi?id=110563
- Reviewed by Benjamin Poulain.
- Frame.h and SecurityOrigin.h are necessary since r136969.
- GeolocationPosition.h since r132360.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- 2013-02-24 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
- https://bugs.webkit.org/show_bug.cgi?id=110570
- Reviewed by Allan Sandfeld Jensen.
- HitTestResult is no longer a HitTestLocation:
- http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
- 2013-02-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Eliminate invalid clipping for content editable selections
- https://bugs.webkit.org/show_bug.cgi?id=110630
- Reviewed by Rob Buis.
- PR 284629.
- Remove selection clipping for content editable
- fields as the bounds aren't valid and cause
- clipping based on starting node rather than the
- union of nodes.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
- 2013-02-22 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry]Adjust fatfinger detection rect size
- https://bugs.webkit.org/show_bug.cgi?id=108678.
- Reviewed by Antonio Gomes.
- Changing HitTestRequest::IgnoreClipping does not solve the problem that
- FatFinger rect detect the element out of the viewport. We have to clip
- the fatfinger rect according to the current viewport size to avoid picking
- the element out of the viewport.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- * WebKitSupport/FatFingers.h:
- 2013-02-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Accept key events even when composing region is active.
- https://bugs.webkit.org/show_bug.cgi?id=110617
- Reviewed by Rob Buis.
- PR 293598.
- Don't reject key events that arrive when composing region is active,
- this can prevent navigation events from firing, instead end
- the composition and process the key.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- 2013-02-22 Carlos Garcia Campos <cargarcia@rim.com>
- [BlackBerry] Rename first/second to key/value in HashMap iterators
- https://bugs.webkit.org/show_bug.cgi?id=110577
- Reviewed by Rob Buis.
- Iterators were renamed to key/value in r130612.
- * WebKitSupport/NotificationManager.cpp:
- (BlackBerry::WebKit::NotificationManager::show):
- (BlackBerry::WebKit::NotificationManager::clearNotifications):
- (BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):
- 2013-02-22 Carlos Garcia Campos <cargarcia@rim.com>
- [BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=110567
- Reviewed by Rob Buis.
- They were removed from ChromeClient in r122810 and are now
- implemented in NavigatorContentUtilsClientBlackBerry since r131056.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2013-02-22 Xan Lopez <xlopez@rim.com>
- [BlackBerry] DomSupport: use NodeTraversal APIs
- https://bugs.webkit.org/show_bug.cgi?id=110467
- Reviewed by Antonio Gomes.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
- 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
- Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
- https://bugs.webkit.org/show_bug.cgi?id=110208
- Reviewed by Hajime Morrita.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- Extract the request data as it is the member of 'TextCheckingRequest'.
- 2013-02-21 Andrew Lo <anlo@rim.com>
- [BlackBerry] WebPagePrivate::load should not check new window policy
- https://bugs.webkit.org/show_bug.cgi?id=110403
- Reviewed by Rob Buis.
- Based on my understanding of changeset 135952, we should
- not check the new window policy in WebPagePrivate::load.
- None of the other ports seem to do this, except for plugins.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- 2013-02-21 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
- https://bugs.webkit.org/show_bug.cgi?id=110460
- Reviewed by Rob Buis.
- This was renamed incorrectly in r142879.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
- (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
- 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
- [BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
- https://bugs.webkit.org/show_bug.cgi?id=110451
- Reviewed by Rob Buis.
- Remove the extra ResourceRequest parameter from
- FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2013-02-21 Xan Lopez <xlopez@rim.com>
- [BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
- https://bugs.webkit.org/show_bug.cgi?id=110469
- Reviewed by Rob Buis.
- This changed in r134765.
- * Api/WebViewportArguments.cpp:
- (BlackBerry::WebKit::WebViewportArguments::zoom):
- (BlackBerry::WebKit::WebViewportArguments::setZoom):
- (BlackBerry::WebKit::WebViewportArguments::minZoom):
- (BlackBerry::WebKit::WebViewportArguments::setMinZoom):
- (BlackBerry::WebKit::WebViewportArguments::maxZoom):
- (BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
- (BlackBerry::WebKit::WebViewportArguments::userZoom):
- (BlackBerry::WebKit::WebViewportArguments::setUserZoom):
- * Api/WebViewportArguments.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):
- 2013-02-21 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Move posting and scrollbar updates to the page client.
- https://bugs.webkit.org/show_bug.cgi?id=110256
- Internal PR 297099
- Reviewed by Rob Buis.
- In blitVisibleContents(), we were calling the WebKit thread
- functions BackingStorePrivate::isScrollingOrZooming() and
- WebPage::isVisible(). This is not the right spot to do it.
- Furthermore, we want to move away from direct window access
- in WebKit and leave that kind of dirtywork to the client.
- This patch removes invalidateWindow() as well as the two
- virtual scrollbar drawing functions and replaces it with
- one new virtual, WebPageClient::postToSurface().
- This clears up threading issues and gets us another step
- further towards pure WebPageCompositor rendering.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPageClient.h:
- 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
- [BlackBerry] Rename Localizer to Locale
- https://bugs.webkit.org/show_bug.cgi?id=110449
- Reviewed by Rob Buis.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::locale):
- * WebCoreSupport/ColorPickerClient.h:
- (ColorPickerClient):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::locale):
- * WebCoreSupport/DatePickerClient.h:
- (DatePickerClient):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::locale):
- * WebCoreSupport/SelectPopupClient.h:
- (SelectPopupClient):
- 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
- [BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
- https://bugs.webkit.org/show_bug.cgi?id=110437
- Reviewed by Yong Li.
- * Api/WebKitTextCodec.cpp:
- (WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
- check enum values match between WebKit and WTF.
- (BlackBerry::WebKit::base64Decode): Use a static cast directly to
- convert from WebKit Base64DecodePolicy to WTF.
- (BlackBerry::WebKit::base64Encode): Use a static cast directly to
- convert from WebKit Base64EncodePolicy to WTF.
- 2013-02-21 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
- https://bugs.webkit.org/show_bug.cgi?id=110439
- Reviewed by Antonio Gomes.
- This was changed in r142827.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2013-02-21 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] willComposite() and didComposite() are now in InspectorController
- https://bugs.webkit.org/show_bug.cgi?id=110343
- Reviewed by Carlos Garcia Campos.
- This was changed in r142879.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::willComposite):
- (BlackBerry::WebKit::WebPagePrivate::didComposite):
- 2013-02-20 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Check offset for initialized value
- https://bugs.webkit.org/show_bug.cgi?id=110390
- Reviewed by Rob Buis.
- Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
- for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
- triggers the restore from cache in requestSpellingCheckingOptions.
- Internally reviewed by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 2013-02-20 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Make sure to always sync before reusing backingstore tiles.
- https://bugs.webkit.org/show_bug.cgi?id=109863
- PR 296118
- Reviewed by Rob Buis.
- Internally reviewed by Mike Lattanzio and Konrad Piascik.
- In SVN r142137, I replaced a syncToCurrentMessage() call
- with updateSuspendScreenUpdateState() in some cases,
- which internally calls the same function.
- Unfortunately, when I optimized updateSuspendScreenUpdateState()
- to only sync when the state is actually being changed,
- I omitted an adaptation of adoptAsFrontState() which would
- rely on this sync but now didn't always perform it.
- This caused a bad race condition as tile buffers could now
- be accessed from the WebKit thread and the UI thread at
- the same time. Fix it by (optionally) letting the caller
- of updateSuspendScreenUpdateState() know whether a sync
- was performed, and adapt adoptAsFrontState() accordingly.
- Also fixes some excessive flicker caused by the same
- race condition.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
- (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
- * Api/BackingStore_p.h:
- 2013-02-20 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
- https://bugs.webkit.org/show_bug.cgi?id=110235
- Reviewed by Yong Li.
- PR #257207.
- Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
- with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
- is specified in the element, the selection handle is always flipped to the required position.
- along with selected text within element.
- Reviewed Internally by Mike Fenton.
- * Api/WebPageClient.h:
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
- (DOMSupport):
- (BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-02-20 Alberto Garcia <albgarcia@rim.com>
- [BlackBerry] Fix usage of HitTestRequest::RequestType
- https://bugs.webkit.org/show_bug.cgi?id=110342
- Reviewed by Carlos Garcia Campos.
- Rename HitTestResult::* -> HitTestRequest::*
- This was introduced by mistake in r142977.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- 2013-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
- Unreviewed BlackBerry build fix.
- WebPage::download was renamed in the header by mistake to
- convertMainResourceLoadToDownload in r137845.
- * Api/WebPage.h:
- 2013-02-19 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Appropriately handle word wrapping in SpellingHandler
- https://bugs.webkit.org/show_bug.cgi?id=110253
- Reviewed by Rob Buis.
- PR286001
- Since we traverse through text by visual lines instead of blocks, word wrapping causes some
- bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
- mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
- processing to continue. This gives priority to user actions while still completing a large
- paragraph in a reasonable amount of time.
- Internally reviewed by Mike Fenton
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
- (BlackBerry::WebKit::SpellingHandler::startOfNextWord):
- (WebKit):
- (BlackBerry::WebKit::SpellingHandler::incrementByWord):
- (BlackBerry::WebKit::SpellingHandler::doesWordWrap):
- * WebKitSupport/SpellingHandler.h:
- (SpellingHandler):
- 2013-02-18 Simon Fraser <simon.fraser@apple.com>
- Clean up the boolean argument to visibleContentRect
- https://bugs.webkit.org/show_bug.cgi?id=110167
- Reviewed by Simon Fraser.
- Replace the boolean argument to visibleContentRect() with
- an enum.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::getRecursiveVisibleWindowRect):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2013-02-15 Keishi Hattori <keishi@webkit.org>
- Add setValue and closePopup methods to PagePopupController
- https://bugs.webkit.org/show_bug.cgi?id=109897
- Reviewed by Kent Tamura.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::setValue): Added empty implementation.
- (WebCore):
- * WebCoreSupport/ColorPickerClient.h:
- (ColorPickerClient):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValue): Ditto.
- (WebCore):
- * WebCoreSupport/DatePickerClient.h:
- (DatePickerClient):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::setValue): Ditto.
- (WebCore):
- * WebCoreSupport/SelectPopupClient.h:
- (SelectPopupClient):
- 2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
- Simplify hitTestResultAtPoint and nodesFromRect APIs
- https://bugs.webkit.org/show_bug.cgi?id=95720
- Reviewed by Julien Chaffraix.
- Update calls to new API.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
- (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2013-02-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update keyboard event details to match platform details.
- https://bugs.webkit.org/show_bug.cgi?id=109693
- Reviewed by Yong Li.
- PR 220170.
- When re-creating the Platform::Keyboard event ensure
- all values are updated.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::updateFormState):
- 2013-02-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update keyboard event details to match platform details.
- https://bugs.webkit.org/show_bug.cgi?id=109693
- Reviewed by Yong Li.
- PR 220170.
- Update keyboard event details.
- Reviewed Internally by Nima Ghanavatian and Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::keyEvent):
- 2013-02-08 Andrey Kosyakov <caseq@chromium.org>
- Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
- https://bugs.webkit.org/show_bug.cgi?id=109192
- Reviewed by Pavel Feldman.
- - invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
- (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
- 2013-02-12 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
- https://bugs.webkit.org/show_bug.cgi?id=109614
- Internal PR 294513
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- With this further simplification of threading assumptions,
- we can get rid of atomic integer access as well as the
- backing store mutex which was otherwise unused.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
- (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2013-02-12 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Eliminate the direct rendering option.
- https://bugs.webkit.org/show_bug.cgi?id=109608
- RIM PR 293298
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- It added a lot of complexity and we're not going to use it anymore.
- This patch removes direct rendering functionality from
- WebKit/blackberry together with the assumption that blitting on the
- WebKit thread is possible or acceptable. It now isn't anymore.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::scroll):
- (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSettings.cpp:
- (WebKit):
- * Api/WebSettings.h:
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
- (BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- 2013-02-12 Andrew Lo <anlo@rim.com>
- [BlackBerry] CSS animations stop running during zoom
- https://bugs.webkit.org/show_bug.cgi?id=109606
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR 286160.
- New BackingStore API for suspending/resuming geometry updates.
- This is needed because we want to allow render jobs to continue during
- zoom, but we don't want to allow geometry updates during zoom.
- Prevent scroll/zoom render jobs from being added to the queue if
- the tile is outside the expanded content rect.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
- (BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- 2013-02-12 Christophe Dumez <ch.dumez@sisa.samsung.com>
- Remove remaining traces of Web Intents
- https://bugs.webkit.org/show_bug.cgi?id=109586
- Reviewed by Eric Seidel.
- Remove remaining traces of Web Intents from Blackberry port
- configuration as the functionality was removed in r142549.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-02-12 Zan Dobersek <zdobersek@igalia.com>
- Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
- https://bugs.webkit.org/show_bug.cgi?id=109481
- Reviewed by Daniel Bates.
- The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
- back in r120574. There are still occurrences of it in various build systems
- which should all be removed as they are useless.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
- Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
- https://bugs.webkit.org/show_bug.cgi?id=109534
- Reviewed by Anders Carlsson.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2013-02-11 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add form navigation control state tracking.
- https://bugs.webkit.org/show_bug.cgi?id=109300
- Reviewed by Rob Buis.
- Add form navigation control state tracking.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::focusNextField):
- (WebKit):
- (BlackBerry::WebKit::WebPage::focusPreviousField):
- (BlackBerry::WebKit::WebPage::submitForm):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::updateFormState):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-02-09 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Set mouse document position for mouse event in updateCursor.
- https://bugs.webkit.org/show_bug.cgi?id=109094.
- Reviewed by Rob Buis.
- RIM PR 246976
- Internally Reviewed by Genevieve Mak.
- BlackBerry::Platform::MouseEvent have document viewport and document
- content position as members. When we create the event, we should initial
- them as well.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 2013-02-07 Charles Wei <charles.wei@torchmobile.com.cn>
- webpage needs null check in BackingStore::setCurrentBackingStoreOwner
- https://bugs.webkit.org/show_bug.cgi?id=109253
- Reviewed by George Staikos.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
- 2013-02-07 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Enable non-video element enter/exit fullscreen.
- https://bugs.webkit.org/show_bug.cgi?id=108314
- Reviewed by Antonio Gomes.
- Webkit support non-video element (like div) to enter/exit
- fullscreen. We should pass this capability in blackberry porting.
- RIM PR 256370, internally reviewed by Max Feil.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
- (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
- (BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-02-07 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Fix all flicker caused by empty/incomplete geometries.
- https://bugs.webkit.org/show_bug.cgi?id=108951
- RIM PR 286925
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- The main idea for this patch is that whenever we adopt
- a new backingstore geometry that doesn't contain any
- rendered tiles, or VisibleZoom render jobs that need more
- tiles to be rendered to be considered complete, we'll then
- suspend blitting until there is valid content to show.
- This main idea is codified as checks for empty buffers
- in adoptAsFrontState(), and checks for the current state
- of the render queue after rendering content in render().
- However, as BackingStore objects with disabled surface pools
- or pure use of accelerated compositing also swap geometries
- in some circumstances, the use of suspend counters grows
- increasingly fragile.
- To make this patch more resilient against regressions,
- the current suspend counter is complemented with several
- explicit conditions for suspending screen updates,
- and both subsequently combined into a single cached
- boolean value telling the UI thread whether or not to
- suspend. In the future, other suspend calls can be
- migrated to this "state machine" design as well,
- potentially phasing out the suspend counter altogether.
- The immediate result is that there will be no flashing
- of background color between page loads or after discarding
- tiles on scale changes until the content has been rendered.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
- (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
- (BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
- 2013-02-07 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
- https://bugs.webkit.org/show_bug.cgi?id=109126
- PR 292540
- Reviewed by Yong Li.
- Internally reviewed by Mike Fenton.
- Key char is UTF32 encoded, should be 4 bytes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::handleScrolling):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::directionOfPointRelativeToRect):
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::shouldExtendSelectionInDirection):
- (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
- (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-02-07 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
- https://bugs.webkit.org/show_bug.cgi?id=109124
- Reviewed by Yong Li.
- RIM BUG 291246 Internally reviewed by YongLi.
- Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
- into WebPageClientImpl::createWindow() to make it more close to its protecting place.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
- 2013-02-07 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Send type details with IMF mask as part of focus gained.
- https://bugs.webkit.org/show_bug.cgi?id=109086
- Reviewed by Yong Li.
- PR 292609.
- Add masking options based on VKB type to the IMF mask.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- 2013-02-06 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Refactor renderContents() for cleaner code.
- https://bugs.webkit.org/show_bug.cgi?id=109059
- RIM PR 280374
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- The fact that we've got two renderContents() implementations
- in BackingStore.cpp, one of which was tailored to just
- being called from drawContents(), is a major annoyance.
- With this patch, the regular renderContents() is modified
- in a way so that drawContents() can make use of it as well.
- This includes an API change for both functions which makes
- it more flexible and enables further cleanups and improvements
- to accuracy. The second, unloved renderContents() is removed.
- The user-visible changes are improved (float) accuracy for
- render offsets, clipping to exactly the dstRect that has
- been specified, and the changed public drawContents() API.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStore::drawContents):
- * Api/BackingStore.h:
- (Platform):
- (Graphics):
- * Api/BackingStore_p.h:
- (WebCore):
- (BackingStorePrivate):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Check range before use in parseBlockForSpellChecking
- https://bugs.webkit.org/show_bug.cgi?id=109080
- Reviewed by Yong Li.
- PR291394
- This was missed during patch webkit/5aea04f6ea625827. Since getRangeForSpellCheckWithFineGranularity
- now returns null values, we need a check here before using the range object here as well.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Check for a valid range object before using it
- https://bugs.webkit.org/show_bug.cgi?id=109058
- Reviewed by Rob Buis.
- PR291394
- Crash occurs if makeRange returns null, since we are using this value without checking
- its validity. We had an assert before which I'm replacing with just a check for null.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
- 2013-02-05 Andrew Lo <anlo@rim.com>
- [BlackBerry] Scrolling performance drops doing page load
- https://bugs.webkit.org/show_bug.cgi?id=108949
- Reviewed by Yong Li.
- Internally reviewed by Jakob Petsovits.
- Internal PR 291390.
- The intention of this code was to not update non-visible tiles during page load.
- Before this patch, the code would update tiles that have already been rendered
- during page load.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- 2013-02-04 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry]Adjust fatfinger detection rect size
- https://bugs.webkit.org/show_bug.cgi?id=108678
- Reviewed by Antonio Gomes.
- RIM Bug 246976
- We still need to clip the fatfinger detection rect to the viewport to
- avoid wrong hitTest result.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::mouseEvent):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- 2013-02-04 Abhishek Arya <inferno@chromium.org>
- Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
- https://bugs.webkit.org/show_bug.cgi?id=108688
- Reviewed by Eric Seidel.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
- 2013-02-04 Andrew Lo <anlo@rim.com>
- [BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
- https://bugs.webkit.org/show_bug.cgi?id=108760
- Reviewed by Yong Li.
- Internally reviewed by Arvid Nilsson.
- Internal PR 286218.
- When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
- we need to set the needs one-shot drawing synchronization flag
- before rendering, so that when the render is completed we
- commit the root layer.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
- Fix build warning after r141473
- https://bugs.webkit.org/show_bug.cgi?id=108782
- Reviewed by Kentaro Hara.
- Fix -Wunused-parameter build warning.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
- 2013-02-01 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
- https://bugs.webkit.org/show_bug.cgi?id=108252
- Reviewed by Yong Li.
- Internally reviewed by Konrad Piascik.
- PR: 284828
- We got float layoutSize(342.284122, 521.448467) and
- m_maximumScale(2.243750) after computing viewport meta based on the
- device pixel ratio and laid out the contents at IntSize(342, 521).
- Therefore, zoomToFitScale(2.245681) would be a bit larger than
- m_maximumScale based on that contents size and resulted in
- maximumScale()!=minimumScale(), which made the non-scalable page
- scalable.
- Return zoomToFitScale for maximumScale() in such kind of case.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::maximumScale):
- 2013-02-01 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] InputHandler status is not restored when page history goes back
- https://bugs.webkit.org/show_bug.cgi?id=108448
- Reviewed by Yong Li.
- PR288406 Internally reviewed by Mike Fenton
- When webpage goes back, it restores the old frame's selection and focused node,
- but we don't save the InputHandler's status, it becomes non-input mode when page
- goes back. When it restores the focus, since the new focus node is same as the old
- document focused node, webcore will not notify client to update the input handler.
- This patch updates the input handler's status by notifying it focus node changed.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::restoreViewState):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-01-31 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Bing Images viewport causes layout "fun"
- https://bugs.webkit.org/show_bug.cgi?id=108393
- Reviewed by Yong Li.
- Internally reviewed by Arvid Nilsson and partially reviewed by Konrad Piascik.
- PR: 277855
- Set applyPageScaleFactorInCompositor settting to false by default.
- Scale down chrome window rect to density-independent pixels.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::applyDeviceScaleFactorInCompositor):
- (BlackBerry::WebKit::WebSettings::setApplyPageScaleFactorInCompositor):
- * Api/WebSettings.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::windowRect):
- 2013-01-31 Enrica Casucci <enrica@apple.com>
- WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
- https://bugs.webkit.org/show_bug.cgi?id=108396.
- <rdar://problem/12920461>
- Reviewed by Alexey Proskuryakov.
- Adds stub implementation for WebKit of the new EditorClient methods.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::willWriteSelectionToPasteboard):
- (WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
- * WebCoreSupport/EditorClientBlackBerry.h:
- 2013-01-30 Ed Baker <edbaker@rim.com>
- [BlackBerry] Screenshot is clipped when content is smaller than the desintation size
- https://bugs.webkit.org/show_bug.cgi?id=107735
- Reviewed by Rob Buis.
- Internal PR #284662
- Don't scale the transformed content rect when the content is smaller than the destination
- size. Scale the graphics context when it has a scale factor that isn't 1.0.
- Internally reviewed by Andrew Lo
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- 2013-01-30 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] Webpage was cut off after rotating to landscape and then rotating back to portrait on specific website
- https://bugs.webkit.org/show_bug.cgi?id=108281
- PR 284985
- Reviewed by Rob Buis.
- Internally reviewed by Jacky Jiang.
- Return correct fixedLayoutSize when overflow exceeds contents size.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 2013-01-30 Simon Hausmann <simon.hausmann@digia.com>
- [Qt] Remove QT4_UNICODE related code paths
- https://bugs.webkit.org/show_bug.cgi?id=108316
- Reviewed by Kenneth Rohde Christiansen.
- * WebCoreSupport/AboutDataUseFeatures.in: The feature macro has been removed.
- 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r140983.
- http://trac.webkit.org/changeset/140983
- https://bugs.webkit.org/show_bug.cgi?id=108277
- Unfortunately, this API has one last client (Requested by
- abarth on #webkit).
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-01-28 Andrew Lo <anlo@rim.com>
- [BlackBerry] Small animated zoom level adjustments are unnecessary
- https://bugs.webkit.org/show_bug.cgi?id=108104
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- Internal PR 285861.
- If the difference between the target scale and current scale is
- less than a given threshold, don't perform a zoom animation.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2013-01-28 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Reduce the region that is spellchecked on keystroke
- https://bugs.webkit.org/show_bug.cgi?id=108115
- Reviewed by Rob Buis.
- PR288217
- Instead of blindly checking text until endOfDocument, we should be honoring the boundaries of
- the VisibleSelection that is passed into SpellingHandler. Though this results in the same behavior
- on focus, this dramatically reduces the region that is rechecked when a key is hit.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- * WebKitSupport/SpellingHandler.h:
- (SpellingHandler):
- 2013-01-28 Adam Barth <abarth@webkit.org>
- Remove webkitNotifications.createHTMLNotification
- https://bugs.webkit.org/show_bug.cgi?id=107598
- Reviewed by Benjamin Poulain.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-01-28 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
- https://bugs.webkit.org/show_bug.cgi?id=108085
- Reviewed by Rob Buis.
- Fix a merge error that duplicated a function declaration in InputHandler.h.
- * WebKitSupport/InputHandler.h:
- 2013-01-28 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
- https://bugs.webkit.org/show_bug.cgi?id=108085
- PR 286165
- Reviewed by Rob Buis.
- Internally reviewed by Nima Ghanavatian.
- Adding a check for the system spell check status in InputHandler::shouldSpellCheckElement so
- we won't bother sending a spellcheck request if system spell check is turned off.
- However, on a fresh browser start up and on the first setElementFocus, the spellcheck value isn't defined yet.
- The first spell check request is therefore necessary to connect to imf to determine whether spell check is turned on.
- If spell check is turned off, we will turn spellinghandler off.
- Tested the patch using a test site that contains editable text in text-areas and content-editable divs. Also tested on
- an extreme test case where we try to edit a content-editable div with 30000 characters. Confirmed spell-check requests are
- being canceled if system spell check is off.
- In theory, this patch should also fix PR 284229 . However, because of issues with getting the system spell check values from IMF,
- additional work needs to be done for that PR.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- (BlackBerry::WebKit::InputHandler::setSystemSpellCheckStatus):
- 2013-01-25 Andrew Lo <anlo@rim.com>
- [BlackBerry] Pop-up WebViews should not take ownership of the backing store.
- https://bugs.webkit.org/show_bug.cgi?id=107957
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR 274581.
- Add web setting for whether a WebPage should take the backing store.
- Prevent pop-up WebView from taking ownership of the backing
- store when it becomes visible.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setVisible):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::isBackingStoreEnabled):
- (BlackBerry::WebKit::WebSettings::setBackingStoreEnabled):
- * Api/WebSettings.h:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
- (WebCore::PagePopupBlackBerry::init):
- 2013-01-25 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] AC layers appear in the wrong place on RTL page
- https://bugs.webkit.org/show_bug.cgi?id=107930
- Reviewed by George Staikos.
- The public API of the BlackBerry port always reports a minimum scroll
- position of (0, 0), even on RTL pages with left overflow. We
- accomplish this by translating the WebCore scroll position by an
- amount equal in size to the minimum scroll position, to obtain the API
- scroll position reported to the API client.
- This means the API client will ask us to render a rect that needs to
- be corrected for the minimum scroll position, or we'll render the wrong
- part. This is done for BackingStore, but not for WebPageCompositor.
- WebPageCompositor was rendering the wrong part of the web page when
- the minimum scroll position was non-zero. Fixed by communicating the
- minimum scroll position to the WebPageCompositor, and accounting for it
- when interpreting the requested content rectangle to render.
- PR 280229.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::layoutRect):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRect):
- (BlackBerry::WebKit::WebPageCompositorPrivate::documentRect):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setDocumentRect):
- (WebPageCompositorPrivate):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-01-24 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Fix crash in SpellingHandler
- https://bugs.webkit.org/show_bug.cgi?id=107842
- Reviewed by Rob Buis.
- If we have an empty range or one with all spaces, we can simply return 0 instead of
- still creating a range. Putting in a null check after trimming to catch this case
- which was causing the crash in some DRT tests.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
- 2013-01-24 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] It can't Select texts in main frame when the current focus is in a IFrame
- https://bugs.webkit.org/show_bug.cgi?id=107773
- Reviewed by Antonio Gomes.
- PR285211 Internally reviewed by Genevieve Mak
- When touch hold in the unfocused frame, it doesn't switch frame focus. Many
- places in code depends on the webpage->forcusOrMainFrame(), including the
- SelectionHandler, so it can't select in an unfocused frame. This patch switchs
- frame focus when touch starts.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
- 2013-01-23 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Take a better guess as to what text the user wants learned
- https://bugs.webkit.org/show_bug.cgi?id=107706
- Reviewed by Rob Buis.
- If we still have a valid caret position, use it to give priority to a region
- of text. We now take the text before the caret, instead of the text at the end
- of the field. If the caret is not present, we start from the beginning of the field.
- This helps learning in email where the region of interest is generally at the start,
- not end of the field.
- Internally reviewed by Mike Fenton
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::learnText):
- 2013-01-23 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Optimize spellchecking by coalescing messages
- https://bugs.webkit.org/show_bug.cgi?id=107707
- Reviewed by Rob Buis.
- PR233604
- Instead of taking chunks one line at a time, coalesce them together
- to fire off messages as close to our character limit as possible.
- This should dramatically reduce the total number of messages in email
- giving us a little performance bump.
- Internally reviewed by Mike Fenton and Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InputHandler.cpp:
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
- (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
- * WebKitSupport/SpellingHandler.h:
- 2013-01-23 Shinya Kawanaka <shinyak@chromium.org>
- shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
- https://bugs.webkit.org/show_bug.cgi?id=107624
- Reviewed by Dimitri Glazkov.
- Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- * WebKitSupport/FatFingers.h:
- (BlackBerry::WebKit::FatFingersResult::node):
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- 2013-01-22 Andrew Lo <anlo@rim.com>
- [BlackBerry] GIF & RAF animations sometimes don't resume after zoom
- https://bugs.webkit.org/show_bug.cgi?id=107590
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR 276907.
- Dispatch render jobs when resuming backing store updates to perform jobs
- queued when updates were suspended.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- 2013-01-21 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Skip spell checking on single character strings
- https://bugs.webkit.org/show_bug.cgi?id=107463
- Reviewed by Yong Li.
- Check for a minimum string length when firing off spellcheck since we don't
- want to mark single letter words.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- * WebKitSupport/SpellingHandler.cpp:
- (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 2013-01-20 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] some websites only takes half of the screen after rotating from landscape to portrait mode.
- https://bugs.webkit.org/show_bug.cgi?id=107103
- Reviewed by George Staikos.
- Internally reviewed by Jacky Jiang.
- When the document size changes (by some javascript) which makes it too small to fit the viewport, we should
- automatically zoom it to fit the viewport.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- 2013-01-20 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Improve Fatfinger phase.
- https://bugs.webkit.org/show_bug.cgi?id=107403
- Reviewed by Rob Buis.
- RIM PR 219489
- Internally reviewd by Mike Fenton & Gen Mak.
- Treat ClickableByDefault and MadeClickableByTheWebpage elements as
- same category. Avoid unnecessary nodes check step.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- (BlackBerry::WebKit::FatFingers::FatFingers):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- * WebKitSupport/FatFingers.h:
- 2013-01-18 Andrew Lo <anlo@rim.com>
- [BlackBerry] When acquiring/releasing backing store memory, allow web page client control suspend/resuming of backing store
- https://bugs.webkit.org/show_bug.cgi?id=107307
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR276660
- Have BackingStore::createBackingStoreMemory & releaseBackingStoreMemory only
- acquire & release the surface pool. It doesn't matter if either is called
- redundantly since SurfacePool has internal state to protect against that.
- Resuming & suspending backing store and screen updates will be handled by
- the WebPageClient.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStore::acquireBackingStoreMemory):
- (BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
- * Api/BackingStore.h:
- 2013-01-18 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread
- https://bugs.webkit.org/show_bug.cgi?id=107284
- Reviewed by Rob Buis.
- PR282351
- Firing off spellcheck requests is tieing up the WebKit thread for an
- extended period of time. In testing with large blocks of text, this
- can be in the matter of 5-10 seconds. Though we are using asynchronous
- spellchecking, the process in which we break down blocks of text based
- on input_service limitations is the issue.
- Using a timer here which fires with an arbitrary timeout to allow for
- focus and interaction to maintain at a reasonable level.
- Further, pulling this code out of InputHandler and into its own class.
- Internally reviewed by Mike Fenton and Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::~InputHandler):
- (BlackBerry::WebKit::InputHandler::callRequestCheckingFor):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- * WebKitSupport/InputHandler.h:
- (WebCore):
- (WebKit):
- (InputHandler):
- * WebKitSupport/SpellingHandler.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
- (BlackBerry::WebKit::SpellingHandler::~SpellingHandler):
- (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
- (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
- (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
- * WebKitSupport/SpellingHandler.h: Added.
- (WebCore):
- (WebKit):
- (SpellingHandler):
- (BlackBerry::WebKit::SpellingHandler::isSpellCheckActive):
- (BlackBerry::WebKit::SpellingHandler::setSpellCheckActive):
- 2013-01-18 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Check if continuous spellchecking is enabled before processing a request
- https://bugs.webkit.org/show_bug.cgi?id=107169
- Reviewed by Rob Buis.
- PR265815
- We set this value based on the global settings page. The
- spellcheck-on-focus codepath did not hit this, so focusing a
- field would not uphold the setting.
- Internally reviewed by Mike Fenton and Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- 2013-01-18 Seokju Kwon <seokju.kwon@gmail.com>
- Add explicit keyword to constructors in platform-specific InspectorClient
- https://bugs.webkit.org/show_bug.cgi?id=107255
- Reviewed by Kentaro Hara.
- Add explicit keyword to constructors that take one argument
- in platform-specific implementation of InspectorClient.
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- 2013-01-18 Andrew Lo <anlo@rim.com>
- [BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
- https://bugs.webkit.org/show_bug.cgi?id=107215
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- Internal PR276660
- Render jobs should not be performed if the backing store is inactive.
- This occured when the browser was invoked, causing a web page to be made
- visible before the surface pool was resumed.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
- 2013-01-17 Yong Li <yoli@rim.com>
- [BlackBerry] InRegionScroller should notify client before it deletes all the scrollables
- https://bugs.webkit.org/show_bug.cgi?id=107162
- Reviewed by Rob Buis.
- Internally reviewed by Gen Mak and Mike Fenton.
- Move the notification code from notifyInRegionScrollStopped() to reset() as there are
- other places where reset() gets called.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- 2013-01-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fix selection handle appearance for RTL text.
- https://bugs.webkit.org/show_bug.cgi?id=107043
- Reviewed by Rob Buis.
- PR 263585.
- Invert the reported selection handle position if to match
- the visual order instead of the logical order to create the
- desired appearance for RTL text and directional selections.
- Reviewed Internally by Gen Mak and Nima Ghanavatian.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2013-01-16 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's
- device rotation in fullscreen mode
- https://bugs.webkit.org/show_bug.cgi?id=107085
- Reviewed by George STaikos.
- Also internally reviewed by Jacky Jiang.
- We saved the scale and scroll position before entering full screen mode, so that we can restore
- them after leaving fullscreen mode, because entering fullscreen mode automatically changes the
- scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen,
- the scale and scroll position saved before may or may not apply anymore, we need to adjust the
- scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2013-01-16 Joe Mason <jmason@rim.com>
- [BlackBerry] Remove bogus assert in GeolocationClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=105651
- Reviewed by Darin Adler.
- GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is
- in m_geolocationRequestMap. But it's perfectly valid for the origin to not be in the map -
- for instance, if GeolocationClientBlackBerry::requestPermission returned immediately,
- without putting it in the map, because geolocation was disabled. In this case the correct
- thing to do is just return - there is nothing to be done to cancel the permission.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- 2013-01-15 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Don't overwrite field dir with current locale.
- https://bugs.webkit.org/show_bug.cgi?id=106932
- Reviewed by Yong Li.
- PR 212267.
- Remove uncalled onInputLocaleChanged and stop re-writing the dir
- on input focus which prevented RTL fields from rendering properly.
- Reviewed Internally by Eli Fidler.
- * Api/WebPage.cpp:
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/InputHandler.cpp:
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2013-01-15 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Manual zoom propagates to next page load
- https://bugs.webkit.org/show_bug.cgi?id=106914
- Reviewed by Yong Li.
- Internally reviewed by Eli Fidler and Jakob Petsovits.
- PR: 280481
- During load committed, the web page scale was reset. However, UI thread
- still kept the old scale in UserInterfaceViewportAccessor so that it
- blitted the contents at the old scale although WebKit thread could
- update the UI thread scale later when finished the load.
- We should update the scale of the UI thread right after we reset it in
- WebKit thread to keep them in sync.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resetScales):
- 2013-01-14 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] FCC appears when switching search engine providers
- https://bugs.webkit.org/show_bug.cgi?id=106824
- Magnifying glass appears when switching search engine providers
- PR 279178
- Reviewed by Rob Buis.
- Internal Reviewed by Mike Fenton.
- We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
- to show the FCC.
- This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
- when the user touches an element that is not a textfield and changes the caret in the inputbar..
- Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
- search engine providers.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2013-01-14 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Zoom is still possible when user-scalable=no
- https://bugs.webkit.org/show_bug.cgi?id=106809
- Reviewed by George Staikos.
- PR: 274566
- On wordpress.com, the contents were rendered at the width 343 which was
- 1 css pixel larger than the expected device-width 342 so that we didn't
- respect the viewport.
- There was a RenderBlock on the page which contained "\n" and an
- inline-block. "\n" took 0.78 width and the inline-block took 342 width
- and they were unfortunately placed in the same InlineBox which caused
- the contents width 1 css pixels larger than the device-width.
- Allow the contents width to be 1 css pixel larger and still respect the
- viewport in such a special case.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::respectViewport):
- 2013-01-13 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] Add a public function WebPage::isLoading()
- https://bugs.webkit.org/show_bug.cgi?id=106751
- PR 274392
- Reviewed by George Staikos.
- Need to get the load state in WebPageClient when resolving PR 274392.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::isLoading):
- (WebKit):
- * Api/WebPage.h:
- 2013-01-11 Andrew Lo <anlo@rim.com>
- [BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
- https://bugs.webkit.org/show_bug.cgi?id=106719
- Reviewed by Yong Li.
- Internally reviewed by Mike Fenton.
- Internal PR 278687
- Always ensureFocusTextElementVisible if an element is focused when
- the device has a physical keyboard.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- 2013-01-11 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Modifying the databaseQuota call to WebPageClient
- https://bugs.webkit.org/show_bug.cgi?id=106703
- Reviewed by Yong Li.
- The databaseQuota call in WebPageClientImpl is modified to take in
- BP:Strings directly. Also, we want to use the origin URL from the security origin.
- Not the database identifier.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 2013-01-10 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Handle the case that start/end position is out of unclipped selection region
- https://bugs.webkit.org/show_bug.cgi?id=106486
- Reviewed by Rob Buis.
- PR #270624
- Unclipped selection region should cover start/end position of the selection.
- Since we exclude hidden text when calculating unclipped selection region, the
- start/end position can be out of unclipped selection region if it is for hidden
- text. If that is the case, start/end handle will be invisible. To avoid invisible
- handle, we take unclipped selection region as reference rectangle in the case.
- Internally reviewed by Genevieve Mak, Mike Fenton
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::referencePoint):
- 2013-01-09 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Useless if statement check
- https://bugs.webkit.org/show_bug.cgi?id=106113
- Reviewed by Yong Li.
- Remove stray ! in if statement which was mistakenly left in during
- refactoring. Since Injected events are checked before they are sent to
- webkit, it didn't have an effect on behaviour.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2013-01-08 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Removing the totalusage variable in ChromeClientBB::exceededDatabaseQuota
- https://bugs.webkit.org/show_bug.cgi?id=106370
- Reviewed by Yong Li.
- Removing totalUsage in ChromeClientBlackBerry as we no longer use that variable.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 2013-01-08 Jacky Jiang <zhajiang@rim.com>
- [Blackberry][FullScreen] Create a helper method to adjust the fullscreen renderer dimensions
- https://bugs.webkit.org/show_bug.cgi?id=91748
- Reviewed by Antonio Gomes.
- PR: 195524
- The was originally from Antonio Gomes on PR195524. Bug 105488 has
- partially upstreamed that patch. This patch upstreams the rest of it.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 2013-01-08 Mark Lam <mark.lam@apple.com>
- Removed the need for the ProposedDatabase mechanism.
- https://bugs.webkit.org/show_bug.cgi?id=106292.
- Reviewed by Sam Weinig.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2013-01-08 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Can't select text out of current focused input
- https://bugs.webkit.org/show_bug.cgi?id=106322
- Reviewed by Rob Buis.
- PR270755
- Internally reviewed by Mike Fenton
- When selection changed, the selection handler clips new selection with
- current focused node's boundary. So we clear focus before selectObject.
- This patch clear focus when selectObject is at a point but not at a node.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- 2013-01-08 Steve Block <steveblock@chromium.org>
- Rename 'IntSize toSize(const IntPoint&)' to 'toIntSize'
- https://bugs.webkit.org/show_bug.cgi?id=106307
- This matches other method names which distinguish between sizes and
- points. See https://bugs.webkit.org/show_bug.cgi?id=105992#c4.
- Reviewed by Kentaro Hara.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- 2013-01-07 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Touch Events are falling through fullscreen video
- https://bugs.webkit.org/show_bug.cgi?id=106112
- Reviewed by Rob Buis.
- Reviewed Internally by Jakob Petsovits.
- PR #274326
- Do not do viewport centering calculations if in fullscreen video.
- The offset should be zero.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2013-01-07 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Roll out r136173 as there are alternative approaches from the client sides now
- https://bugs.webkit.org/show_bug.cgi?id=106236
- Unreviewed, rolling out r136173.
- This becomes unnecessary now as there are alternative approaches to
- solve the issue from the client sides.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
- 2013-01-07 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Never avoid blitting when one-shot drawing sync is involved.
- https://bugs.webkit.org/show_bug.cgi?id=106225
- RIM PR 274948
- Reviewed by George Staikos.
- Based on a patch by Chris Guan.
- didRenderContent() has a mechanism to avoid double blits;
- when scrolling or zooming is enabled then we don't issue
- blitContents() as the client would (continually) do that
- already.
- However, since r138024, didRenderContents() also deals
- with one-shot drawing synchronization and commits.
- When these are required, we can't just skip out or the
- backingstore and overlaying composited layers are likely
- to get out of sync. The condition also doesn't make much
- sense for direct rendering as no blit calls are issued
- at all when it is enabled.
- Fix the issue by limiting the impact of the scroll/zoom
- early return to only regular blit operations.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- 2013-01-05 Andy Chen <andchen@rim.com>
- [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link
- https://bugs.webkit.org/show_bug.cgi?id=106141
- Reviewed by Rob Buis.
- If last fat finger result is a link, select it directly when
- SelectionHandler::selectAtPoint is called.
- PR 263449
- Internally reviewed by Mike Fenton and Yongxin Dai.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- * WebKitSupport/SelectionHandler.h:
- (WebKit):
- (SelectionHandler):
- 2013-01-04 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Last text input caret left visible when WebView entirely loses focus.
- https://bugs.webkit.org/show_bug.cgi?id=106124
- Reviewed by George Staikos.
- Internal PR 248834
- There are numerous code paths that lead to repainting of the focus node
- when the focus moves to another node, but none seem to cover the case
- of focus leaving the document when there are no DocumentMarkers present.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- 2013-01-04 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] FCC will show up as you type if you tap on the same input bar twice before typing
- https://bugs.webkit.org/show_bug.cgi?id=106116
- Reviewed by Yong Li.
- Internal reviewed by Gen Mak.
- PR 267177
- FCC is being invoked because the fatfinger result is no longer a reliable source
- to tell whether the caret change is caused by user touch input. Instead, we recognize all
- notifyCaretChange calls with userTouchInput as true except when caretPositionChanged is invoked
- by SelectionHandler:inputHandlerDidFinishProcessingChange.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
- (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2013-01-04 Yong Li <yoli@rim.com>
- [BlackBerry] Cached frame shouldn't access the page when being destroyed
- https://bugs.webkit.org/show_bug.cgi?id=105942
- Reviewed by George Staikos.
- Fix regression of previous patch. dispatchDidHandleOnloadEvents() can be called
- after Frame has been detached.
- RIM PR# 271237.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
- 2013-01-04 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Allow defaultTabEventHandler to trigger on tab
- https://bugs.webkit.org/show_bug.cgi?id=106118
- Reviewed by Yong Li.
- In order to support tabbing through input elements, amongst
- other things, we need to bipass the processing of the tab key as
- '\t'. This will simply insert 4 spaces in the field. Remove tab
- support from the key down map so that we don't translate it to
- an editor command.
- Internally reviewed by Mike Fenton.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore):
- 2013-01-04 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Enable Input Focus when handling touch events for JS
- https://bugs.webkit.org/show_bug.cgi?id=106109
- Reviewed by Yong Li.
- PR 273325.
- Toggle input mode active when a touch event is
- received for JS processing to ensure state
- is updated even when event is consumed.
- Reviewed Internally by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2013-01-04 Adam Klein <adamk@chromium.org>
- Remove ENABLE_MUTATION_OBSERVERS #define
- https://bugs.webkit.org/show_bug.cgi?id=105459
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2013-01-04 Anthony Scian <ascian@rim.com>
- [Blackberry] Static code analysis warning fixes
- https://bugs.webkit.org/show_bug.cgi?id=105679
- Reviewed by Rob Buis.
- Klocwork issue 959: check layer against NULL since it is used in both cases
- of the subsequent if-stmt
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- 2013-01-02 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] file:/// pages don't get correct scales after several rotations and history navigations
- https://bugs.webkit.org/show_bug.cgi?id=105996
- Reviewed by George Staikos.
- PR: 273541
- When navigating back to the previous page on portrait mode, we were
- trying to set virtual viewport after recalculation. However, we didn't
- change the fixed layout size so that we still layouted the contents at
- the old virtual viewport size. In this case, the old virtual viewport
- was 570 * 293 which was set in landscape mode unfortunately. There
- would be no chance for such kind of contents size to fit the portrait
- mode screen size nicely.
- This was a regression of webkit/cc31d9bad where setViewMode() was
- removed as a noop. So just get setViewMode() back to apply the fixed
- layout size with a little bit change as SVG document path was proved
- invalid in that patch. Thanks to George for the float comparison change.
- Put a FIXME as we don't have a way to save the scale precisely before
- the rotation and history navigation currently.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
- 2013-01-02 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Do not determine db quota limit using db file size
- https://bugs.webkit.org/show_bug.cgi?id=105991
- PR 267191
- Reviewed by George Staikos.
- Passing the current quota to WebPageClientImpl::databaseQuota so we can determine a better
- quota limit without using the db file size.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 2013-01-02 Yong Li <yoli@rim.com>
- [BlackBerry] Cached frame shouldn't access the page when being destroyed
- https://bugs.webkit.org/show_bug.cgi?id=105942
- Reviewed by George Staikos.
- In order to prevent our FrameLoaderClient from dangling WebPagePrivate object in any case,
- this patches clear the m_webPagePrivate pointer when the frame is detached or cached.
- RIM PR# 272137.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::isMainFrame):
- (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
- (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
- (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
- 2013-01-02 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Use fatfingers result when checking for misspelled words
- https://bugs.webkit.org/show_bug.cgi?id=105923
- Reviewed by Yong Li.
- PR270866
- Currently we are using the raw touch point when checking to see if spell check
- is required on a word. When tapping close to a boundary, the raw point can be
- placed off but fatfingers moves the point onto the word. This causes the caret
- to be placed on a word but no spell check request triggered.
- Internally reviewed by Mike Fenton and Tiancheng Jiang
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-12-28 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
- https://bugs.webkit.org/show_bug.cgi?id=105811
- RIM PR 272067
- Reviewed by George Staikos.
- Internally Reviewed by Jakob Petsovits.
- BackingStorePrivate::m_defersBlit is not used anywhere, it should
- be removed to simplify the code and to avoid confusion.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2012-12-26 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Set load state for popups manually, in absence of a loader.
- https://bugs.webkit.org/show_bug.cgi?id=105708
- RIM PR 257216
- Reviewed by George Staikos.
- Internally reviewed by Chris Guan.
- The WebPage class relies on the load state for various things,
- among others it will only emit contents size changes after
- layouts if a load state other than None is set.
- Given that popups write the web page content itself with no
- loader that would issue such notifications, the load state
- should probably just be set manually in this case.
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::init):
- 2012-12-26 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Caret doesn't update position when scrolling text in Input element
- https://bugs.webkit.org/show_bug.cgi?id=105757
- Reviewed by George Staikos.
- PR 271627
- Internally reviewed by George Staikos.
- Call FrameSelection's updateAppearence instead of SelectionHandler's
- selectionPositionChanged to update the caret position.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- 2012-12-25 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Need to initialize the onLine in the global
- https://bugs.webkit.org/show_bug.cgi?id=105749
- Reviewed by George Staikos.
- The NetworkStatus is initialized to online in the constructor by default,
- we need to update it correctly with the network status at startup.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- 2012-12-24 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Fix various RenderQueue bugs introduced by r138024.
- https://bugs.webkit.org/show_bug.cgi?id=105717
- RIM PR 269029
- Reviewed by George Staikos.
- Scroll/zoom jobs were pretty solid, but I managed to
- leave some bugs in the region handling of RenderQueue's
- renderRegularRenderJobs() function, causing us to skip
- a desired blit or render operation in cases where the
- region and tile tracking did not match up.
- This commit fixes these errors.
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
- 2012-12-24 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Close page popup when a page becomes invisible.
- https://bugs.webkit.org/show_bug.cgi?id=105704
- Reviewed by George Staikos.
- Reviewed internally by Jakob Petsovits.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- 2012-12-23 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] give url when createWindow
- https://bugs.webkit.org/show_bug.cgi?id=105702
- RIM bug# 257329
- Reviewed by George Staikos.
- This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
- for integration issue of cascade and air, as old app side still use the url
- to invoke. It would unrevert after resolving the integration issue.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 2012-12-23 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Specify tile usage enum for backingstore tiles.
- https://bugs.webkit.org/show_bug.cgi?id=105688
- RIM PR 262120
- Reviewed by George Staikos.
- This enables us to have separate tile sizes for
- backingstore / root layer purposes and generic layers.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::tileSize):
- 2012-12-21 Max Feil <mfeil@rim.com>
- [BlackBerry] Fullscreen video fixed position container horizontal position is wrong
- https://bugs.webkit.org/show_bug.cgi?id=105488
- Reviewed by George Staikos.
- The fix for https://bugs.webkit.org/show_bug.cgi?id=105333 has
- broken fullscreen video, which was compensating by doing its
- own positioning in x. My patch fixes things by making vertical
- and horizontal handling symmetrical.
- NOTE: This function was not upstreamed before, so you can't
- actually see my diff. See the bug.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
- 2012-12-18 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Calculate correct word offsets for form elements.
- https://bugs.webkit.org/show_bug.cgi?id=105354
- Reviewed by Rob Buis.
- PR266117
- We need to calculate correct offsets for form elements, such as
- textareas, relative to the start of the field. This allows for correct
- spell checking of words in a textarea element after line breaks.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 2012-12-18 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Remove extra call to doFatFingers.
- https://bugs.webkit.org/show_bug.cgi?id=105347
- Reviewed by Rob Buis.
- Reviewed Internally by Mike Fenton.
- Now that we do fat fingers on touch start, we don't need this anymore.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2012-12-18 Genevieve Mak <gmak@rim.com>
- Bug 105344 - [BlackBerry] Make single line text edits touch scrollable.
- https://bugs.webkit.org/show_bug.cgi?id=105344
- Reviewed by Antonio Gomes.
- Reviewed Internally by Mike Fenton.
- We don't need to check the overflow for editable layers because there's
- no need for overflow to be set by the content.
- PR #231776
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Build fix for r138024.
- https://bugs.webkit.org/show_bug.cgi?id=105199
- RIM PR 260232
- Reviewed by Yong Li.
- The clearVisibleTiles() function doesn't exist anymore
- and apparently I fail at merge conflict resolution.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
- 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Clean up "frontState" vs. "geometry" naming confusion.
- https://bugs.webkit.org/show_bug.cgi?id=105331
- RIM PR 260232
- Reviewed by Adam Treat.
- The concept of the "front state" is going away or will be
- marginalized/renamed, but I don't want to clutter upcoming
- patches with renames. So do the variable renames in here,
- once, and have future patches focus on actual behavior changes.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- 2012-12-18 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Reduce calls to IMF on return
- https://bugs.webkit.org/show_bug.cgi?id=105308
- Reviewed by Yong Li.
- PR207743
- The extra calls of selection change and most importantly, end composition
- are sent incorrectly on return. This is causing our state to be reset
- every time we hit enter.
- Internally reviewed by Mike Fenton and Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::nodeTextChanged):
- (BlackBerry::WebKit::InputHandler::selectionChanged):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::shouldNotifyWebView):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Remove the visible tile buffer from the BackingStore.
- https://bugs.webkit.org/show_bug.cgi?id=105302
- RIM PR 260232
- Reviewed by George Staikos.
- The visible tile buffer was introduced as an additional
- buffering solution that was necessary because other
- buffers would only cover part of the screen and could
- only be swapped one by one, with long blocking calls
- between each newly rendered tile. By carrying an old copy
- of all tiles at once, we were avoiding checkerboard and
- visual artifacts during load time when much zoom-to-fit
- action is going on.
- These days, the visual tile buffer hurts more than it helps,
- not only taking up lots of memory but also requiring
- complexity that we'd rather get rid of. Now that multiple
- buffers are being swapped into the user interface thread
- at once, the need for the visible tile buffer is no longer
- there and can be exchanged for standard geometry behavior.
- This patch simply deletes the visible tile buffer to use
- existing other code instead. Differences in behavior are
- non-existent or negligible.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
- (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::createBuffers):
- (BlackBerry::WebKit::SurfacePool::releaseBuffers):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Restructure the render queue to process multiple tiles at once.
- https://bugs.webkit.org/show_bug.cgi?id=105199
- RIM PR 260232
- Reviewed by George Staikos.
- Internally reviewed by Arvid Nilsson.
- Since my last big commit, r136442, the BackingStore's render()
- function is able to fetch multiple back buffers and swap them
- into the user interface thread in one go. However, it turns out
- that this is not enough to actually render to all of the
- available back buffers at once. The RenderQueue class was still
- working with a model based on processing one rectangle after
- another.
- This commit rewrites large parts of RenderQueue to issue
- render() calls for multiple tiles at once. As WebCore painting
- gets cheaper and blocking becomes more of an issue, this commit
- does away with paints smaller than tile size and always renders
- whole tiles at once. This means the demise of RenderRect.
- As an additional benefit, this means we can remove the
- copyPreviousContentsToTileBuffer() function which caused
- potential threading issues as it was accessing a buffer
- now owned by the UI thread from the WebKit thread.
- RenderQueue is also smarter than before in assigning batches,
- it now takes into account the number of available back buffers
- for rendering as well as excludes tiles outside contents
- boundaries. Regular render jobs continue being tracked as
- regions (and are being issued to didRenderContent()) with only
- the changed content regions. Everything else switches over to
- tile index lists from previously lists of rectangles.
- By default, we render as many tiles at once as we can grab
- back buffers, or until a given set of jobs is done.
- For high-priority jobs, render() will be called in a loop.
- To allow for the necessary changes in render() and improve
- reliability in the same go, we now call render() almost
- exclusively through RenderQueue. Other places would often
- call renderVisibleContents() in situations where rendering
- is not possible, geometries don't get updated, or content
- rendered notifications would not get issued to the client.
- By replacing renderVisibleContents() with a scheduled
- high-priority queue that's immediately being processed
- (but only if possible), these problems go away.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
- (BlackBerry::WebKit::BackingStorePrivate::indexesForBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
- (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitVisibleContentsImmediately):
- (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTileIndexes):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::updateTile):
- (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
- (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::compareRectOneDirection):
- (BlackBerry::WebKit::tileIndexIsLessThan):
- (WebKit):
- (BlackBerry::WebKit::tileIndexLessThanFunction):
- (BlackBerry::WebKit::TileIndexLessThan::TileIndexLessThan):
- (BlackBerry::WebKit::TileIndexLessThan::operator()):
- (TileIndexLessThan):
- (BlackBerry::WebKit::RenderQueue::reset):
- (BlackBerry::WebKit::RenderQueue::isEmpty):
- (BlackBerry::WebKit::RenderQueue::hasCurrentRegularRenderJob):
- (BlackBerry::WebKit::RenderQueue::hasCurrentVisibleZoomJob):
- (BlackBerry::WebKit::RenderQueue::hasCurrentVisibleScrollJob):
- (BlackBerry::WebKit::RenderQueue::isCurrentVisibleZoomJob):
- (BlackBerry::WebKit::RenderQueue::isCurrentVisibleZoomJobCompleted):
- (BlackBerry::WebKit::RenderQueue::isCurrentVisibleScrollJob):
- (BlackBerry::WebKit::RenderQueue::isCurrentVisibleScrollJobCompleted):
- (BlackBerry::WebKit::RenderQueue::isCurrentRegularRenderJob):
- (BlackBerry::WebKit::RenderQueue::tileIndexesIntersectingRegion):
- (BlackBerry::WebKit::RenderQueue::tileIndexesFullyContainedInRegion):
- (BlackBerry::WebKit::RenderQueue::tileRegion):
- (BlackBerry::WebKit::RenderQueue::addToQueue):
- (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
- (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- (BlackBerry::WebKit::RenderQueue::quickSort):
- (BlackBerry::WebKit::RenderQueue::visibleContentChanged):
- (BlackBerry::WebKit::RenderQueue::backingStoreRectChanging):
- (BlackBerry::WebKit::RenderQueue::clear):
- (BlackBerry::WebKit::RenderQueue::clearRegions):
- (BlackBerry::WebKit::RenderQueue::clearTileIndexes):
- (BlackBerry::WebKit::RenderQueue::render):
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
- (BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):
- (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
- * WebKitSupport/RenderQueue.h:
- (WebKit):
- (RenderQueue):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::numberOfAvailableBackBuffers):
- (BlackBerry::WebKit::SurfacePool::takeBackBuffer):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- * WebKitSupport/TileIndex.h:
- (WebKit):
- 2012-12-17 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Editable text element can't be selected
- https://bugs.webkit.org/show_bug.cgi?id=105240
- Reviewed by Rob Buis.
- Internally reviewed by Genevieve Mak and Mike Fenton.
- Internal PR266755
- When the target is Text, we should allow it to collect text nodes in
- the shadow tree of text editable elements.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- 2012-12-17 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Prevent selection handles from being rendered after selection was canceled
- https://bugs.webkit.org/show_bug.cgi?id=105203
- Reviewed by Rob Buis.
- PR255438
- Here is the explanation why handles occur without selection overlay.
- 1. Still touch at current selection (Selection A) initiated by touch-hold
- 2. Selection expanding (Selection B) is ongoing
- 3. Finger moves. In UI thread:
- 1) SelectionHander::cancelSelection() gets called.
- a. Selection A is canceled immediately (clear selecting state and hide handles)
- b. Post a request to webkit thread to cancel Selection A.
- 4. In webkit thread:
- 1) Selection B becomes active selection
- a. Show selection overlay for Selection B
- b. Dispatch Selection B to UI thread to show handles
- 2) Handle the request of canceling Selection A. The selection A was gone. Instead the active Selection B is canceled.
- The visual change is Selection overlay for Selection B becomes invisible..
- 5. In UI thread:
- Selection B is rendered. The start handle and the end handle occur without selection overlay.
- The fix is to notify client with a empty selection whenever the selection is canceled in webkit thread.
- Reviewed Internally by Mike Fenton.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- 2012-12-17 Yong Li <yoli@rim.com>
- [BlackBerry] Null pointer access in compositorDrawsRootLayer
- https://bugs.webkit.org/show_bug.cgi?id=105204
- Reviewed by Rob Buis.
- PR# 267188.
- Add a null check for m_mainFrame in the function.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
- 2012-12-17 Andrew Lo <anlo@rim.com>
- [BlackBerry] Use application size rather than screen size where appropriate.
- https://bugs.webkit.org/show_bug.cgi?id=105201
- Reviewed by Rob Buis.
- Internally reviewed by Jeff Rogers.
- Switch from screenSize to applicationSize where appropriate.
- Internal PR266400
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- 2012-12-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Improve DOMSupport visibleSelectionForClosestActualWordStart for content editable.
- https://bugs.webkit.org/show_bug.cgi?id=105198
- Reviewed by Rob Buis.
- PR 258038.
- Improve closest word matching by giving preference to the left when
- distances are equal.
- Also enforce container matching to avoid selecting the paragraph
- marker if a CE div is followed immediately by a CE paragraph.
- Minor refactor - don't calculate the distance if the selection
- isn't on a word.
- Reviewed Internally by Gen Mak and Nima Ghanavatian.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleSelectionForClosestActualWordStart):
- 2012-12-17 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Clean up log output in WebKit/blackberry.
- https://bugs.webkit.org/show_bug.cgi?id=104823
- Reviewed by George Staikos.
- Behavior-preserving change, fixing many issues with logging:
- - Call logAlways() instead of BBLOG() in already defined-out debug blocks.
- - Call logAlways() instead of BBLOG() for serious errors, too.
- - Fix build for the DEBUG_OVERFLOW_DETECTION block in ChromeClientBlackBerry.
- - Fix build for double declarations of "elapsed" variables in RenderQueue.
- - Fix compiler warnings due to format string / parameter mismatches.
- - Remove unnecessary trailing newlines in logged strings.
- - Consistently use Platform:: as prefix except inside WebCore-namespaced code.
- - Use indentation that actually passes WebKit style checks.
- - Change point/size/rect output to use Platform toString() formats for consistency.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::bestDivisor):
- (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::scroll):
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
- (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::contentsSizeChanged):
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::overflowExceedsContentsSize):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::checkForText):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWchar):
- (BlackBerry::WebKit::convertStringToWcharVector):
- (BlackBerry::WebKit::convertSpannableStringToString):
- (BlackBerry::WebKit::InputHandler::learnText):
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::spellCheckBlock):
- (BlackBerry::WebKit::InputHandler::nodeTextChanged):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::frameUnloaded):
- (BlackBerry::WebKit::InputHandler::selectionChanged):
- (BlackBerry::WebKit::InputHandler::setSelection):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
- (BlackBerry::WebKit::InputHandler::deleteText):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::setComposingRegion):
- (BlackBerry::WebKit::InputHandler::finishComposition):
- (BlackBerry::WebKit::InputHandler::setText):
- (BlackBerry::WebKit::InputHandler::setTextAttributes):
- (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
- (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
- (BlackBerry::WebKit::InputHandler::setComposingText):
- (BlackBerry::WebKit::InputHandler::commitText):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
- (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- (BlackBerry::WebKit::RenderQueue::render):
- (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
- (BlackBerry::WebKit::RenderQueue::startRegularRenderJobBatchIfNeeded):
- (BlackBerry::WebKit::RenderQueue::renderVisibleZoomJob):
- (BlackBerry::WebKit::RenderQueue::renderVisibleScrollJob):
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
- (BlackBerry::WebKit::RenderQueue::renderNonVisibleScrollJob):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- 2012-12-17 Anthony Scian <ascian@rim.com>
- [Blackberry] Static code analysis warning fixes
- https://bugs.webkit.org/show_bug.cgi?id=105129
- Reviewed by Rob Buis.
- - disable copy/op= in BackingStore
- - cache and check intermediate values in parentLayer
- - disable copy/op= in InRegionScroller
- - disable copy/op= in WebPageGroupLoadDeferrer
- - disable copy/op= in WebSettings
- - disable copy/op= in WebViewportArguments
- - disable copy/op= in BackingStoreClient
- - disable copy/op= in TileBuffer
- - if stopNode is not NULL, loop could iterate past NULL; added NULL check to loop
- to make the code more robust
- * Api/BackingStore.h:
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- (BlackBerry::WebKit::parentLayer):
- * Api/InRegionScroller.h:
- * Api/WebPageGroupLoadDeferrer.h:
- * Api/WebSettings.h:
- * Api/WebViewportArguments.h:
- * WebKitSupport/BackingStoreClient.h:
- (BackingStoreClient):
- * WebKitSupport/BackingStoreTile.h:
- (TileBuffer):
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
- 2012-12-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
- https://bugs.webkit.org/show_bug.cgi?id=105143
- RIM PR 171941
- Reviewed by Rob Buis.
- Internally reviewed by George Staikos.
- TouchPoint instances now provide document coordinates for the viewport
- and content position of the touch event. The pixel coordinates stored
- in the TouchPoint should no longer be needed in WebKit. One exception
- is when passing events to a full screen plugin.
- Also adapt to new method names and encapsulation of TouchPoint data
- members.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
- (BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-12-15 Anders Carlsson <andersca@apple.com>
- Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
- https://bugs.webkit.org/show_bug.cgi?id=105122
- Reviewed by Andreas Kling.
- Update for WebCore changes.
- * Api/WebPage.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-12-16 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] GUIMark3 page is rendered at a large scale during history navigation back
- https://bugs.webkit.org/show_bug.cgi?id=105130
- Reviewed by George Staikos.
- PR: 265999
- During history navigation, UI thread can blit the contents at a bad
- view state before WebKit thread restores the view state.
- Suspend screen updates before goBackOrForward() and resume thereafter
- so that screen can be updated after the correct view state is updated.
- No need to render or blit here, as goBackOrForward() can dispatch a
- message to WebKit thread to do that in WebPagePrivate::restoreHistoryViewState().
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::goBackOrForward):
- 2012-12-15 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Pass key modifiers with touch and mouse events
- https://bugs.webkit.org/show_bug.cgi?id=105108
- Reviewed by Rob Buis.
- Pass key modifiers to allow for added functionality, such as
- shift+click to highlight.
- Internally reviewed by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- (BlackBerry::WebKit::WebPage::mouseEvent):
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- * Api/WebPage.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-12-15 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Clean up allocated memory from InputMethodSupport
- https://bugs.webkit.org/show_bug.cgi?id=105110
- Reviewed by Rob Buis.
- PR265919
- We are deep copying the spannable_string from IMF and freeing
- here once we're done with it.
- Internally reviewed by Jeff Rogers.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- 2012-12-14 Parth Patel <parpatel@rim.com>
- [BlackBerry] Allow plugins to be disabled by shared library filename
- https://bugs.webkit.org/show_bug.cgi?id=101274
- Reviewed by Yong Li.
- Fixing build error.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- 2012-12-13 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry][Fullscreen] Exiting fullscreen does not set the correct scroll position
- https://bugs.webkit.org/show_bug.cgi?id=104958
- Reviewed by Antonio Gomes.
- Internally reviewed by Arvid Nilsson and Max Feil.
- PR: 231174
- When leaving fullscreen, WebPage scale and scroll position can't return
- to the original scale and scroll position.
- We can't restore them in WebPagePrivate::exitFullScreenForElement()
- as they can still be changed thereafter during the async
- setViewportSize(). And also the async setViewportSize() from the app
- side isn't guaranteed as some apps don't need to resize the viewport if
- their windows are already fullscreen.
- The restoration is basically only needed if viewport size is changed.
- At the point of entering fullscreen, we can safely assume that there
- would be a viewport size change thereafter if the current visible size
- and screen size are not equal. Based on this assumption, we can save
- the scale and position before entering fullscreen and restore them in
- setViewportSize() thereafter.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-12-13 Yong Li <yoli@rim.com>
- [BlackBerry] Possible JS re-entrancy caused by UI event handler
- https://bugs.webkit.org/show_bug.cgi?id=84862
- Reviewed by Rob Buis.
- Fix an obvious bug in previous patch.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
- 2012-12-13 Parth Patel <parpatel@rim.com>, Max Feil <mfeil@rim.com>
- Allow plugins to be disabled by shared library filename
- https://bugs.webkit.org/show_bug.cgi?id=101274
- Reviewed by Antonio Gomes.
- Mechanism allows plugins to be disabled by specifying their shared library filenames.
- Once disabled, a plugin's shared library should never be loaded.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- (WebKit):
- (BlackBerry::WebKit::WebPage::updateDisabledPluginFiles):
- * Api/WebPage.h:
- 2012-12-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
- NetworkInfoController needs to support destructor
- https://bugs.webkit.org/show_bug.cgi?id=104642
- Reviewed by Kentaro Hara.
- Though NetworkInfoController can be referenced by each port in order to update network status change,
- there is no virtual interface to destroy it. Beside each port client also needs to be destroyed when
- controller is destroyed.
- * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
- (WebCore::NetworkInfoClientBlackBerry::networkInfoControllerDestroyed):
- (WebCore):
- * WebCoreSupport/NetworkInfoClientBlackBerry.h:
- (NetworkInfoClientBlackBerry):
- 2012-12-12 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Ensure InRegionScrollableArea is valid before using.
- https://bugs.webkit.org/show_bug.cgi?id=104832
- Reviewed by Antonio Gomes.
- Make sure the InRegionScrollableArea we are about to scroll is
- still valid by ensuring its present in our cache of scrollable areas.
- Internal PR: 258475
- Internal Review: Gen Mak
- We cache a RefPtr for each scrollable area at the time we discover them,
- but this cache can get cleared anytime and then the references will be
- released. If a request comes in to scroll a region which no longer
- exists we have to ignore it.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::isValidScrollableLayerWebKitThread):
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollerPrivate::isValidScrollableNode):
- * Api/InRegionScroller_p.h:
- (WebCore):
- (InRegionScrollerPrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::cachedScrollableLayer):
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollableArea::cachedScrollableNode):
- * WebKitSupport/InRegionScrollableArea.h:
- (InRegionScrollableArea):
- 2012-12-12 Mark Lam <mark.lam@apple.com>
- Encapsulate externally used webdatabase APIs in DatabaseManager.
- https://bugs.webkit.org/show_bug.cgi?id=104741.
- Reviewed by Sam Weinig.
- Use DatabaseManager instead of accessing DatabaseTracker, AbstractDatabase,
- and DatabaseContext directly. This is to prepare for upcoming webkit2
- refactoring.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 2012-12-12 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fix word matching algorithm to account for adjacent divs with no whitespace between them.
- https://bugs.webkit.org/show_bug.cgi?id=104837
- Reviewed by Rob Buis.
- PR 258038.
- Fix selection at the end of content editable text block.
- The next character may be in the next block bypassing the distance
- comparison logic we have, remove the check for next character being
- whitespace
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleSelectionForClosestActualWordStart):
- 2012-12-12 Alexey Proskuryakov <ap@apple.com>
- Make LOG() work in WebProcess and NetworkProcess
- https://bugs.webkit.org/show_bug.cgi?id=104718
- Reviewed by Tim Horton.
- * Api/BlackBerryGlobal.cpp: Include InitializeLogging.h
- 2012-12-11 Kihong Kwon <kihong.kwon@samsung.com>
- Vibration API: IDL type doesn't match implementation type
- https://bugs.webkit.org/show_bug.cgi?id=103899
- Reviewed by Kentaro Hara.
- According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
- Therefore unsigned long need to be changed to unsigned for the Vibration API.
- - Change a parameter type of vibrate function from unsigned long to unsigned.
- * WebCoreSupport/VibrationClientBlackBerry.cpp:
- (WebCore::VibrationClientBlackBerry::vibrate):
- * WebCoreSupport/VibrationClientBlackBerry.h:
- (VibrationClientBlackBerry):
- 2012-12-11 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Redraw spell check dialog after rotation.
- https://bugs.webkit.org/show_bug.cgi?id=104737
- Reviewed by Rob Buis.
- After rotating the device, all dialogs are dismissed. We should
- restore the spell check dialog as it is still valid after
- rotation and the user will expect it there.
- Internally reviewed by Mike Fenton and Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
- 2012-12-11 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Shift the spell check dialog to align with text after transformation
- https://bugs.webkit.org/show_bug.cgi?id=104716
- Reviewed by Rob Buis.
- PR245033
- As the page is transformed, we should redraw the dialog box to align
- with the new text position. We send a message to move the dialog
- box from different spots to account for scrolling. This includes
- keyboard transitions from hidden to displayed and centering of
- focus around a new touch point. We do not reposition on manual user
- scrolling of the page, as this simply dismisses the dialog.
- Internally reviewed by Mike Fenton and Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::scroll):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- (BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- (BlackBerry::WebKit::InputHandler::clearDidSpellCheckState):
- (BlackBerry::WebKit::InputHandler::didSpellCheckWord):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-12-11 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Avoid multiple calls to fat fingers
- https://bugs.webkit.org/show_bug.cgi?id=104703
- Reviewed by Rob Buis.
- We already run fat fingers on touch start. No need to do it again
- in the general use case.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-12-11 Mike West <mkwst@chromium.org>
- Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector.
- https://bugs.webkit.org/show_bug.cgi?id=66371
- Reviewed by Pavel Feldman.
- Drops WebCore::MessageType from the addMessageToConsole method.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addMessageToConsole):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-12-10 Max Feil <mfeil@rim.com>
- [BlackBerry] Flash content is being rendered as garbled characters when Flashplayer is disabled
- https://bugs.webkit.org/show_bug.cgi?id=104505
- Reviewed by Antonio Gomes.
- The check to allow video and audio as the source of embed and
- object elements is causing a problem when the Flashplayer plugin
- is disabled. We have to take Flash content into account in this
- check otherwise the swf contents will be rendered as garbled
- text characters where there should just be blank space.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createPlugin):
- 2012-12-10 Parth Patel <parpatel@rim.com>
- [BlackBerry] Make hiddenPageDomTimerInterval a setting
- https://bugs.webkit.org/show_bug.cgi?id=104555
- Reviewed by Yong Li.
- HiddenPageDomTimerInterval in setting in webcore can be utilized by browser application
- when needed.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- 2012-12-10 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Fix warning for comparison between signed and unsigned
- https://bugs.webkit.org/show_bug.cgi?id=104563
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
- 2012-12-10 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
- https://bugs.webkit.org/show_bug.cgi?id=104504
- Reviewed by George Staikos.
- When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
- to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
- doing a blit after it has deleted the viewport accessor and before the webkit thread gets
- the time slot to resume it's operation to clean up the webview, which leaves a very short
- time that viewport accessor of a webpage has been deleted while the webpage is still in
- the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.
- So we need to check if the viewport accessor is NULL before using it in the backingstore code.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- 2012-12-10 Kent Tamura <tkent@chromium.org>
- Refactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
- https://bugs.webkit.org/show_bug.cgi?id=104508
- Reviewed by Kentaro Hara.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup): Use isDisabledOrReadOnly.
- (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
- 2012-12-08 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Google results page rendering issue with RTL languages like arabic/hebrew
- https://bugs.webkit.org/show_bug.cgi?id=104451
- Reviewed by Rob Buis.
- PR: 206372
- On Google results page, we layout the contents at the width of 833.
- However, "appbar" and "top_nav" elements which have width 980 cause
- overflow during the last layout and make the contents width larger.
- The other renderers still stay at the old width unfortunately which
- results in blank areas on the left side of the Google results RTL page.
- Give it a chance to request another layout if overflow exceeds the
- contents size and the page doesn't have virtual viewport, as this
- layout will pick up the absolute visible overflow width within
- DEFAULT_MAX_LAYOUT_WIDTH and update the other renderers.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-12-08 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Enforce selection of last work when triggering caret based selection
- https://bugs.webkit.org/show_bug.cgi?id=104447
- Reviewed by Rob Buis.
- PR 249225.
- When the selection has reached the end of an input field,
- ensure the last word is selected by adjusting the caret.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- 2012-12-08 Chris Hutten-Czapski <chutten@rim.com>
- [BlackBerry] Remove about:credits
- https://bugs.webkit.org/show_bug.cgi?id=104399
- Reviewed by Rob Buis.
- Just a simple removal.
- * WebKitSupport/AboutData.cpp:
- 2012-12-08 Rob Buis <rbuis@rim.com>
- [BlackBerry] Remove no-op line in WebPage.cpp
- https://bugs.webkit.org/show_bug.cgi?id=104385
- Reviewed by Antonio Gomes.
- Remove self-assignment no-op line. Must have been left when I removed the
- mapFromTransformed part.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- 2012-12-07 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] General code cleanup and improved logging.
- https://bugs.webkit.org/show_bug.cgi?id=104389
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWchar):
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- 2012-12-07 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Strip whitespace from learned text.
- https://bugs.webkit.org/show_bug.cgi?id=104391
- Reviewed by Rob Buis.
- This was removing the first word from the sentence being learned. Using
- stripWhiteSpace to remove spaces from the start and end of the text.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::learnText):
- 2012-12-07 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] GeolocationClientBB should show file system path in prompts when host is not avaliable
- https://bugs.webkit.org/show_bug.cgi?id=103785
- PR 247656
- Reviewed by Rob Buis.
- Adding a special case for origins with protocol "file". We will use the filepath as
- an origin when asking for geolocation permission.
- If the origin is unique (ie. from a sandboxed iframe), we will fail the location request
- right away.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (getOrigin):
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- 2012-12-07 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
- https://bugs.webkit.org/show_bug.cgi?id=104121
- Reviewed by Rob Buis.
- Update createBuffer calls to reflect new BufferType enum.
- Set buffers opaque if possible to avoid unnecessary blends.
- Internal PR 254649
- Internal Review: Jakob Petsovits
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::nativeBuffer):
- 2012-12-07 Andrew Lo <anlo@rim.com>
- [BlackBerry] Double zoom animation when focusing on input field.
- https://bugs.webkit.org/show_bug.cgi?id=104375
- Reviewed by Rob Buis.
- Internally reviewed by Jakob Petsovits.
- UI thread does not need to be notified of a scale change if the WebKit
- thread scale has not changed.
- This caused issues when two viewport resizes occured one after the other.
- Before the scale change due to the first resize could be set in the WK
- thread's scale value, it caused WK thread to dispatch a scaleChanged,
- overwritting & resetting the new UI thread scale value, resulting in the
- double zoom animation.
- The larger issue dealing with synchronization between the threads where
- scale changes could occur on either thread, however that is beyond the
- scope of this change.
- Internal PR253122
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
- 2012-12-07 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
- https://bugs.webkit.org/show_bug.cgi?id=104243
- RIM PR 259337
- Reviewed by Rob Buis.
- 1. Add DRT callback in dispatchDecidePolicyForResponse.
- 2. Pass frame pointer to DRT callback in
- dispatchDecidePolicyForNavigationAction, so that it can be used to
- calculate originating.
- 3. Fix some webkit style errors.
- The patch fixed the following tests:
- - http/tests/download
- - fast/forms/mailto/formenctype-attribute-button-html.html
- - fast/forms/mailto/formenctype-attribute-input-html.html
- - fast/encoding/mailto-always-utf-8.html
- * Api/DumpRenderTreeClient.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
- (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
- 2012-12-05 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
- https://bugs.webkit.org/show_bug.cgi?id=104162
- PR 257505
- Reviewed by Yong Li.
- GeolocationClientBlackBerry will register itself to GeolocationHandler when it has
- a pending request. When browser responds with WebPageClientImpl::setAllowGeolocation,
- we go through the list and let all the pending GeolocationListeners know that a certain
- origin has been aceepted/denied.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (GeolocationClientBlackBerry::geolocationDestroyed):
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- (GeolocationClientBlackBerry::onPermission):
- 2012-12-05 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Better crash fix for resetting tiles on a backingstore takeover.
- https://bugs.webkit.org/show_bug.cgi?id=103969
- RIM PR 258415
- Reviewed by Adam Treat.
- The previous attempt for releasing tile buffers from the
- previously active backingstore did not take into account
- that resetTiles() would sometimes return early without
- having swapped the tiles and thus reclaiming them.
- This patch removes the early returns, because it's safe
- to swap in an empty geometry at any time and we should
- always take the chance when we get it.
- Also put the code that calls resetTiles() on an owner
- switch right into setCurrentBackingStoreOwner(), so that
- it will also release the buffers when the BackingStore
- is destroyed (the function is then called with 0).
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
- * Api/BackingStore.h: Had to add the friend here to make the moved code work from the static function.
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 2012-12-05 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Keep screen updates suspended until after a viewport resize.
- https://bugs.webkit.org/show_bug.cgi?id=104041
- Reviewed by Adam Treat.
- Now that screen and backing store updates can be suspended
- and resumed separately from each other, prevent blits for
- the whole duration of setViewportSize() and always issue
- a blit at the end.
- Makes WebPage::setViewportSize() more robust in threaded usage,
- easier to read/understand, and gets rid of a couple of FIXMEs.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-12-05 Andrew Lo <anlo@rim.com>
- [BlackBerry] Scroll position shifts while FCC & selection handle are dragged
- https://bugs.webkit.org/show_bug.cgi?id=104156
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- Only ensureFocusTextElementVisible on selectionChanged when
- an element is being re-focused.
- Internal PR256329
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::selectionChanged):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-12-05 Leo Yang <leoyang@rim.com>
- [BlackBerry] Enable CSS_IMAGE_RESOLUTION
- https://bugs.webkit.org/show_bug.cgi?id=104132
- Reviewed by Yong Li.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-12-05 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] meta viewport pages are rendered at a bad initial scale
- https://bugs.webkit.org/show_bug.cgi?id=104122
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- PR: 240378
- Many websites are rendered at a very bad initial scale because they
- both specify meta viewport tag and have large width elements. In such
- a case we will think the meta viewport tag is broken if the width of
- any element is larger than the calculated layout viewport width.
- The fix to this is straightforward that we will zoom the page to fit
- the screen to have better user experience instead of respecting the
- meta viewport. This can fix the issue on the websites such as
- www.travelpod.com, www.forbes.com, interfacelift.com, www.sky.com,
- raphaeljs.com and so on.
- If non-empty m_userViewportArguments is applied, then we will force to
- respect the viewport arguments. In this way we will restrict the fix to
- browser only.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::respectViewport):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::initialScale):
- (BlackBerry::WebKit::WebPagePrivate::maximumScale):
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::isUserScalable):
- (WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::minimumScale):
- 2012-12-05 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
- https://bugs.webkit.org/show_bug.cgi?id=104123
- PR 256089
- Reviewed by Yong Li.
- Add a mapping between origin URL and it's geolocation object so we could
- respond to the correct geolocation when libwebview responds with onPermission
- in GeolocationClient.
- Using the mapping, we could also prevent requestGeolocation requests from the same origin
- to be sent twice. This prevents pages that hold two iframes to the same resource to request
- geolocation permission on the same security origin twice.
- Tested this by running a page that includes 2 or more iframes that requests geolocation
- permission.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- (GeolocationClientBlackBerry::onPermission):
- * WebCoreSupport/GeolocationClientBlackBerry.h:
- (GeolocationClientBlackBerry):
- 2012-12-05 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Avoid showing FCC on empty text field in a different way
- https://bugs.webkit.org/show_bug.cgi?id=104019
- Reviewed by Rob Buis.
- PR #222796
- Add text field empty flag along with the caret change notification so that
- FineCursorContnrol is able to avoid showing FCC on empty text filed.
- Previous approach, notifying client with empty caret on empty text field,
- causes problem. Its code is removed.
- Reviewed Internally by Mike Fenton.
- * Api/WebPageClient.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-12-04 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar
- https://bugs.webkit.org/show_bug.cgi?id=103874
- PR245678
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- When the virtual keyboard is hiding, the viewport is changed and the page needs
- to relayout.At the same time, the user interface thread is executing compositeLayers
- and it will dispatch the updateDelegatedOverlays() to webkit thread which will trigger
- the selectionPositionChanged() in webkit thread.
- When the selectionPositionChanged() calls frame->selection()->selection().
- visibleStart() and frame->selection()->selection().visibleEnd(), it will
- trigger page relayout and return the relayouted selection start and end position.
- These positions are out of the range which is recorded before its relayout.
- As a result it think the selection start and end are all clipped out and it send
- out an "empty selection"(not selected) changing event.
- When the WebPageClient receives the empty selection changing event, it will consider
- the selection process aborted and might cancel selection-related user interaction.
- This is not what we intend to happen.
- This patch stops the changing handling process and returns when the page needs relayout,
- and the selection will be updated again when the page finishs relayout.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2012-12-04 Andrew Lo <anlo@rim.com>
- [BlackBerry] Scroll adjustments while typing scroll off page, then bounce back.
- https://bugs.webkit.org/show_bug.cgi?id=104045
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton & Jakob Petsovits.
- Internal PR253845
- The main frame's view should only be temporarily set to
- not constrain scrolling to the content edge while the
- scroll position is set at the end of the scroll animation.
- Remove ensureFocusTextElementVisible from setSpannableTextAndRelativeCursor
- in InputHandler since FrameSelection::revealSelection
- already implements scroll adjustments due to typing.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- (BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
- 2012-12-04 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHandler::spannableTextInRange
- https://bugs.webkit.org/show_bug.cgi?id=104001
- Reviewed by Rob Buis.
- PR 257723.
- Remove assert and update early return to allow out of bounds
- request at end of field.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Store rendered regions in pixel contents coordinates.
- https://bugs.webkit.org/show_bug.cgi?id=103930
- PR 253496
- Reviewed by Rob Buis.
- Internally reviewed by Adam Treat.
- Previously, the rendered region of a tile used to be
- stored in coordinates relative to the tile origin.
- This brings no benefits whatsoever and causes a lot
- of unnecessary transformations, together with the
- potential of incorrectly transforming rendered regions.
- By storing the rendered region as what it is,
- everything is more compact, easier to understand
- and easier to use with other existing functionality.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
- (BlackBerry::WebKit::BackingStorePrivate::isTileVisible):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
- (BlackBerry::WebKit::BackingStorePrivate::tileContentsRect):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromPixelContentsToTiles):
- (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::surfaceRect):
- (BlackBerry::WebKit::TileBuffer::pixelContentsRect):
- (WebKit):
- (BlackBerry::WebKit::TileBuffer::isRendered):
- (BlackBerry::WebKit::TileBuffer::notRenderedRegion):
- * WebKitSupport/BackingStoreTile.h:
- (TileBuffer):
- 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Use updated API for backingstore tiles.
- https://bugs.webkit.org/show_bug.cgi?id=103970
- PR 212369
- Reviewed by George Staikos.
- Internally reviewed by Arvid Nilsson.
- We now make use of Platform::Settings::tileSize() in the
- backingstore and don't hardcode the number of back buffers
- like we used to.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::bestDivisor):
- (BlackBerry::WebKit::BackingStorePrivate::tileWidth):
- (BlackBerry::WebKit::BackingStorePrivate::tileHeight):
- (BlackBerry::WebKit::BackingStorePrivate::tileSize):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::configPage):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::numberOfBackingStoreFrontBuffers):
- (BlackBerry::WebKit::SurfacePool::initialize):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] On taking over a backingstore, reset the previous page's tiles.
- https://bugs.webkit.org/show_bug.cgi?id=103969
- RIM PR 253496
- Reviewed by George Staikos.
- With buffers being explicitly reclaimed from backingstore
- geometries, we have to make sure that the previously
- active backingstore releases its front buffers for use
- in the newly active one.
- Previously, this clearing of backingstore tiles occurred
- after the dormant backingstore is reactivated,
- the backingstore active in the meantime would just use
- the back buffer anyway and leave the dormant one with
- dangling pointers that would just not be shown.
- Now that we have a counted list of back buffers,
- we need to be explicit about this thing upfront.
- Fixes a crash that would occur after switching ownership
- of the backingstore to a different WebPage.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 2012-12-03 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Refactor the backingstore to swap full geometries.
- https://bugs.webkit.org/show_bug.cgi?id=103924
- RIM PR 253496
- Reviewed by Yong Li.
- Internally reviewed by Adam Treat and Arvid Nilsson.
- The backingstore had a working split between front and
- back state, but it was multilayered and hard to grasp.
- This commit cleanly divides the responsibilities of
- BackingStoreGeometry and TileBuffer, with the latter
- now being able to function on its own without the help
- of its geometry. The BackingStoreTile class was an
- unnecessary middleman and can be removed wholesale.
- A BackingStoreGeometry can now function with null tiles
- being assigned to its indices, which enables us to reclaim
- tile buffers outside of the visible contents area as back
- buffers. This reduces the need to swap and block when the
- backingstore size exceeds the contents size, and also lets
- us use more tiles for initial rendering after a call to
- resetTiles() which is now implemented as swapping in a
- geometry with only null buffers.
- setBackingStoreRect() was the only function that had to
- get a change of behavior. Because we're now constructing
- new BackingStoreGeometry objects every time the front
- geometry is being exchanged for a new one, it is only
- safe to call other functions reliant on the new geometry
- after it has been finalized and put in place. Therefore,
- updateTilesForScrollOrNotRenderedRegion() takes on the
- render queue maintenance tasks that setBackingStoreRect()
- had performed previously. It was already doing something
- very similar so only few changes to the function were
- necessary.
- This commit will make subsequent changes to the
- backingstore geometry and tile logic a lot easier.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStoreGeometry::isTileCorrespondingToBuffer):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
- (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::clearRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
- (BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTilesToTransformedContents):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
- (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
- * Api/BackingStore_p.h:
- (WebKit):
- (BackingStoreGeometry):
- (BlackBerry::WebKit::BackingStoreGeometry::tileBufferAt):
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage_p.h:
- (WebKit):
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::TileBuffer):
- (BlackBerry::WebKit::TileBuffer::~TileBuffer):
- (BlackBerry::WebKit::TileBuffer::isRendered):
- (BlackBerry::WebKit::TileBuffer::nativeBuffer):
- (BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
- (BlackBerry::WebKit::TileBuffer::paintBackground):
- * WebKitSupport/BackingStoreTile.h:
- (BlackBerry::WebKit::TileBuffer::lastRenderOrigin):
- (BlackBerry::WebKit::TileBuffer::setLastRenderOrigin):
- (BlackBerry::WebKit::TileBuffer::lastRenderScale):
- (BlackBerry::WebKit::TileBuffer::setLastRenderScale):
- (TileBuffer):
- (BlackBerry::WebKit::TileBuffer::backgroundPainted):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::size):
- (WebKit):
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
- (BlackBerry::WebKit::SurfacePool::hasBackBuffer):
- (BlackBerry::WebKit::SurfacePool::takeBackBuffer):
- (BlackBerry::WebKit::SurfacePool::addBackBuffer):
- (BlackBerry::WebKit::SurfacePool::createBuffers):
- (BlackBerry::WebKit::SurfacePool::releaseBuffers):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- * WebKitSupport/SurfacePool.h:
- (BlackBerry::WebKit::SurfacePool::isActive):
- (BlackBerry::WebKit::SurfacePool::isEmpty):
- (SurfacePool):
- (BlackBerry::WebKit::SurfacePool::visibleTileBuffer):
- 2012-12-03 Cosmin Truta <ctruta@rim.com>
- [BlackBerry] Enable HIDDEN_PAGE_DOM_TIMER_THROTTLING
- https://bugs.webkit.org/show_bug.cgi?id=103842
- Reviewed by Yong Li.
- Add HIDDEN_PAGE_DOM_TIMER_THROTTLING.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-12-02 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry]Tap highlight
- https://bugs.webkit.org/show_bug.cgi?id=103787
- Reviewed by Rob Buis.
- RIM PR 248626
- Internally Reviewed by Genevieve Mak.
- Draw tap highlight as soon as tap on element.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-11-28 Cosmin Truta <ctruta@rim.com>
- [BlackBerry] Set the minimal DOM timer interval to 4 milliseconds
- https://bugs.webkit.org/show_bug.cgi?id=103534
- Reviewed by Yong Li.
- We align this behavior with other platforms.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- 2012-11-29 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
- https://bugs.webkit.org/show_bug.cgi?id=103666
- Reviewed by Yong Li.
- Internally reviewed by Yong Li.
- PR 243420
- Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
- calls setEnableHighAccuracy.
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (GeolocationClientBlackBerry::startUpdating):
- (GeolocationClientBlackBerry::setEnableHighAccuracy):
- 2012-11-29 Andrew Lo <anlo@rim.com>
- [BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related
- https://bugs.webkit.org/show_bug.cgi?id=103659
- Reviewed by Rob Buis.
- Internally reviewed by Gen Mak.
- Internal PR253893.
- Only adjust scroll position during an orientation change
- when setting viewport size.
- We don't want the scroll position jumping around when opening
- & closing the VKB.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-11-28 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled
- https://bugs.webkit.org/show_bug.cgi?id=103560
- Reviewed by Rob Buis.
- PR 253490
- Syncing platform Websetting's cookieEnabled value with Page->setting's cookieEnabled
- value.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-11-27 James Simonsen <simonjam@chromium.org>
- Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
- https://bugs.webkit.org/show_bug.cgi?id=102151
- Reviewed by Adam Barth.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-27 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] http:// origins can navigate to privileged local:// origins
- https://bugs.webkit.org/show_bug.cgi?id=103437
- Reviewed by Yong Li.
- PR: 251489
- When we aren't allowed to display the destination origin, we shouldn't
- even create the window for it. In this way we can block the remote
- origins(like http://) window.open local origins(like file:// and
- local://) and avoid further security issues.
- Chrome and Safari will open a blank window and fail to load. Firefox
- will fail to open the window and report a load failure error which has
- the same behavior as us. I would prefer this way as the window would
- be useless and the calls after that would be harmful to us.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
- 2012-11-27 Andrew Lo <anlo@rim.com>
- [BlackBerry] Remove unnecessary backing store suspension in InputHandler::ensureFocusTextElementVisible
- https://bugs.webkit.org/show_bug.cgi?id=103441
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- Remove unnecessary backing store suspension in
- InputHandler::ensureFocusTextElementVisible.
- Not necessary anymore since both zoom and scroll adjustments
- happen in an animation.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r135786.
- http://trac.webkit.org/changeset/135786
- https://bugs.webkit.org/show_bug.cgi?id=103379
- It made 3 plugin tests timeout on several platforms (Requested
- by Ossy on #webkit).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-26 James Simonsen <simonjam@chromium.org>
- Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
- https://bugs.webkit.org/show_bug.cgi?id=102151
- Reviewed by Adam Barth.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-26 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Form controls don't show pressed state.
- https://bugs.webkit.org/show_bug.cgi?id=103292
- Reviewed by Rob Buis.
- Reviewed internally by Eli Fidler and Mike Lattanzio.
- We weren't sending touch events to webpages unless they
- had JS touch event listeners which form controls don't have.
- Now send them always and do a little cleanup.
- PR #249791
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPage::touchEvent):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::needTouchEvents):
- 2012-11-26 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Null check calls associated with retrieving the caret rect.
- https://bugs.webkit.org/show_bug.cgi?id=103281
- Reviewed by Rob Buis.
- Some of these calls can return null, which could lead to a crash.
- Internally reviewed by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 2012-11-26 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
- https://bugs.webkit.org/show_bug.cgi?id=103104
- Reviewed by Rob Buis.
- RIM PR: 245334
- Added the oldPassword detection back into the password input
- detection logic, which was removed for simplicity when imported
- those pieces of codes from Chromium. And we won't do autofill
- when there're more than one password field detected.
- Internally reviewed by Rob Buis.
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::CredentialTransformData):
- (WebCore::CredentialTransformData::findPasswordFormFields):
- * WebCoreSupport/CredentialTransformData.h:
- (CredentialTransformData):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- 2012-11-25 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Get rid of resetBitmapZoomScale()
- https://bugs.webkit.org/show_bug.cgi?id=103200
- Reviewed by Rob Buis.
- Internally reviewed by Gen Mak.
- PR: 235707
- Right now, resetBitmapZoomScale() takes an unused paramter and
- dispatches a message to end the bitmap zooming. However, the
- interaction has its own state machine to start bitmap zooming when it
- is active and end bitmap zooming when it is inactive. This is
- expecially for pinch zoom and scroll. From WebKit side, block zoom
- which will call zoomBlock when the bitmap zoom finished doesn't even
- need to dispatch the useless ending message to ZoomHandler.
- resetBitmapZoomScale() is basically a noop for block zoom. And likewise
- that is useless for zoomToInitialScaleOnLoad(). It can also potentially
- cause problem if it is used somewhere else in the future and
- incidentally breaks the interaction's own state machine. So just remove
- this completely.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- * Api/WebPageClient.h:
- 2012-11-24 Andy Chen <andchen@rim.com>
- [BlackBerry] Find-on-page keeps stale pointer
- https://bugs.webkit.org/show_bug.cgi?id=103190
- Reviewed by Rob Buis.
- Find on page: pendingScopingEffort stores stale pointer when frames unload,
- we need to cancel those scoping efforts.
- PR 250807.
- Internally reviewed by Yongxin Dai and Mike Fenton.
- * WebKitSupport/InPageSearchManager.cpp:
- (InPageSearchManager::DeferredScopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- 2012-11-24 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Text not selected when input field focused.
- https://bugs.webkit.org/show_bug.cgi?id=103182
- Reviewed by George Staikos.
- Reviewed Internally by: Mike Fenton, Eli Fidler
- PR #250163
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- 2012-11-23 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Define platform limitations in platform layer
- https://bugs.webkit.org/show_bug.cgi?id=103160
- Reviewed by Rob Buis.
- Taking length as const unsigned in checkSpellingOfStringAsync.
- This value is unchanging and should never be less than 0, even
- in an error case.
- Internally reviewed by Mike Fenton.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- 2012-11-23 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Meta viewport can't be changed dynamically
- https://bugs.webkit.org/show_bug.cgi?id=103098
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- PR: 237072
- Reset m_userPerformedManualZoom and enable
- m_shouldZoomToInitialScaleAfterLoadFinished so that we can relayout the
- page and zoom it to fit the screen when we dynamically change the meta
- viewport after the load is finished.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 2012-11-23 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Drop Synchronous Mouse Events
- https://bugs.webkit.org/show_bug.cgi?id=102980
- Reviewed by Rob Buis.
- Reviewed Internally by George Staikos and Mike Lattanzio.
- Don't send actual Touch Events to fullscreen plugins unless
- its a Touch Cancel, DoubleTap or TouchHold.
- Instead send mouse events as long as its a single finger.
- PR #242781
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
- 2012-11-23 Andrew Lo <anlo@rim.com>
- [BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
- https://bugs.webkit.org/show_bug.cgi?id=103091
- Reviewed by Yong Li.
- Internally reviewed by Mike Fenton.
- Internal PR249523
- Incorrectly used y coordinate as x coordinate in
- InputHandler::ensureFocusTextElementVisible.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-11-22 Jeff Rogers <jrogers@rim.com>
- [BlackBerry] Update Web Notifications Implementation
- https://bugs.webkit.org/show_bug.cgi?id=102621
- Reviewed by George Staikos.
- Reviewed internally by George Staikos and Joe Mason
- Internal PR 172120
- Add new notifications implementation for the BlackBerry port. Rename
- existing class to match Client naming. Adds NotificationManager
- implementation for managing notifications and permissions, and logic
- for passing the notifications to the platform provider.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::updateNotificationPermission):
- (WebKit):
- (BlackBerry::WebKit::WebPage::notificationClicked):
- (BlackBerry::WebKit::WebPage::notificationClosed):
- (BlackBerry::WebKit::WebPage::notificationError):
- (BlackBerry::WebKit::WebPage::notificationShown):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::notificationManager):
- * WebCoreSupport/NotificationClientBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::NotificationClientBlackBerry::NotificationClientBlackBerry):
- (WebCore::NotificationClientBlackBerry::show):
- (WebCore::NotificationClientBlackBerry::cancel):
- (WebCore::NotificationClientBlackBerry::clearNotifications):
- (WebCore::NotificationClientBlackBerry::notificationObjectDestroyed):
- (WebCore::NotificationClientBlackBerry::notificationControllerDestroyed):
- (WebCore::NotificationClientBlackBerry::requestPermission):
- (WebCore::NotificationClientBlackBerry::cancelRequestsForPermission):
- (WebCore::NotificationClientBlackBerry::checkPermission):
- * WebCoreSupport/NotificationClientBlackBerry.h: Added.
- (WebKit):
- (WebCore):
- (NotificationClientBlackBerry):
- * WebCoreSupport/NotificationPresenterImpl.cpp: Removed.
- * WebCoreSupport/NotificationPresenterImpl.h: Removed.
- * WebKitSupport/NotificationManager.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::NotificationManager::NotificationManager):
- (BlackBerry::WebKit::NotificationManager::~NotificationManager):
- (BlackBerry::WebKit::NotificationManager::show):
- (BlackBerry::WebKit::NotificationManager::cancel):
- (BlackBerry::WebKit::NotificationManager::clearNotifications):
- (BlackBerry::WebKit::NotificationManager::notificationObjectDestroyed):
- (BlackBerry::WebKit::NotificationManager::requestPermission):
- (BlackBerry::WebKit::NotificationManager::cancelRequestsForPermission):
- (BlackBerry::WebKit::NotificationManager::checkPermission):
- (BlackBerry::WebKit::NotificationManager::updatePermission):
- (BlackBerry::WebKit::NotificationManager::notificationClicked):
- (BlackBerry::WebKit::NotificationManager::notificationClosed):
- (BlackBerry::WebKit::NotificationManager::notificationError):
- (BlackBerry::WebKit::NotificationManager::notificationShown):
- (BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):
- * WebKitSupport/NotificationManager.h: Added.
- (WebKit):
- (NotificationManager):
- 2012-11-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Guard against a lost focusedNode that input handler isn't yet informed of.
- https://bugs.webkit.org/show_bug.cgi?id=103071
- Reviewed by Rob Buis.
- Fix potential for a crash if input mode is active but
- we can't get a focusedNode.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- 2012-11-21 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Drop Synchronous Mouse Events
- https://bugs.webkit.org/show_bug.cgi?id=102980
- Reviewed by Rob Buis.
- Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
- Get rid of unneeded methods and simplify code.
- Send click if getting context over an empty text field
- so that it will be focused and have a caret.
- PR #242781
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- (BlackBerry::WebKit::WebPage::touchEventCancel):
- * Api/WebPage.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
- (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
- (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-11-21 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
- https://bugs.webkit.org/show_bug.cgi?id=102978
- Reviewed by Rob Buis.
- Internal PR 200848
- We prevent screen from going dim when the front-end is connected and return to normal when
- the front-end disconnects.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::enableWebInspector):
- (BlackBerry::WebKit::WebPage::disableWebInspector):
- 2012-11-21 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Don't add empty rects to the tap highlight region.
- https://bugs.webkit.org/show_bug.cgi?id=102966
- Reviewed by George Staikos.
- Internal PR 246960
- Tap highlight is way too large sometimes.
- When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 2012-11-21 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
- https://bugs.webkit.org/show_bug.cgi?id=102962
- Reviewed by Rob Buis.
- PR 247270.
- Switch from using VisiblePosition to determine if we are in a node
- to a comparison of the field bounds. This fixes the case where
- there is no node before the target node to match.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- 2012-11-20 Andrew Lo <anlo@rim.com>
- [BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after scroll or zoom completes
- https://bugs.webkit.org/show_bug.cgi?id=102838
- Reviewed by Rob Buis.
- Internally reviewed by Adam Treat.
- Internal PR244646
- When entering scrolling & zooming, we suspend regular render jobs
- in order to pause animations. When finishing scrolling or zooming,
- dispatch a render job in order to resume those animations.
- If an animation requests a repaint while the backing store is suspended,
- add the regular render job to the render queue so that it can be
- processed later.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- 2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r135295.
- http://trac.webkit.org/changeset/135295
- https://bugs.webkit.org/show_bug.cgi?id=102834
- This patch causes assertion to some layout tests on chromium
- (Requested by jianli on #webkit).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-20 James Simonsen <simonjam@chromium.org>
- Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
- https://bugs.webkit.org/show_bug.cgi?id=102151
- Reviewed by Adam Barth.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-19 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Block Zoom picks wrong block
- https://bugs.webkit.org/show_bug.cgi?id=102728
- Reviewed by Rob Buis.
- Reviewed Internally by Jakob Petsovits
- Remove transform missed in previous commit for
- https://bugs.webkit.org/show_bug.cgi?id=101608
- PR #247198
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
- 2012-11-19 Liam Quinn <lquinn@rim.com>
- [BlackBerry] Remove RTSP handling from FrameLoaderClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=102692
- Reviewed by Rob Buis.
- Reviewed internally by George Staikos. Internal PR 242750.
- Our RTSP handling in FrameLoaderClientBlackBerry causes HTTP redirects to "rtsp:" URIs to fail. Remove handling of RTSP from this class; it will be moved to the network layer alongside other URI schemes like "data:" and "file:".
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
- 2012-11-16 Adam Treat <atreat@rim.com>
- https://bugs.webkit.org/show_bug.cgi?id=102540
- [BlackBerry] Checkerboard flicker when pinch zooming out on google.com/nwshp
- Reviewed by George Staikos.
- PR 245827
- Disable updates to the backingstore tile matrix when backingstore updates
- are disabled. This prevents changes to the tile matrix when we are in the
- middle of a pinch zoom which can cause checkebroard flickering.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::renderBackingStore):
- (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
- (BlackBerry::WebKit::BackingStorePrivate::contentsSizeChanged):
- (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
- * Api/BackingStore_p.h:
- (BlackBerry::WebKit::BackingStorePrivate::setTileMatrixNeedsUpdate):
- (BackingStorePrivate):
- 2012-11-16 Rob Buis <rbuis@rim.com>
- [BlackBerry] FCC doesn't work in textarea
- https://bugs.webkit.org/show_bug.cgi?id=102088
- Reviewed by Antonio Gomes.
- Remove the cancel button specializations, it was needed at some point but hitting it
- works just as well without it. This unbreaks FCC in textarea's.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- 2012-11-16 Adam Treat <atreat@rim.com>
- [BlackBerry] Fix regression causing checkerboard flicker after app wake-up
- https://bugs.webkit.org/show_bug.cgi?id=102526
- Reviewed by George Staikos.
- PR 245027
- The webkit patch for 219976 introduced an undesirable behavior change
- resulting in a regression where there was checkerboard flickering on
- resuming from an inactive application state. This patch restores the
- previous behavior and fixes the regression.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
- (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
- 2012-11-16 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Use proper keycode value for space instead of hardcoded value.
- https://bugs.webkit.org/show_bug.cgi?id=102518
- Reviewed by Rob Buis.
- Remove hard coded value for space.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setText):
- 2012-11-15 Andrew Lo <anlo@rim.com>
- [BlackBerry] Animate changes to viewport due to input focus changes.
- https://bugs.webkit.org/show_bug.cgi?id=102410
- Reviewed by Rob Buis.
- When changing scroll position or zoom level for input field focus,
- animate the change.
- Internal PR 231937
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-11-15 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Don't restore zoom and scroll when leaving an input field.
- https://bugs.webkit.org/show_bug.cgi?id=102376
- Reviewed by Yong Li.
- Restoring the zoom causes undesirable behavior when switching between fields.
- Reviewed Internally by Andrew Lo.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-11-15 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Fix suspend/resume assertion in setCompositor().
- https://bugs.webkit.org/show_bug.cgi?id=102397
- RIM PR 244701
- Reviewed by Adam Treat.
- If a compositor is used but no surface pool is ever
- allocated (which is a perfectly valid use case), initial
- suspension of the backingstore is skipped because of an
- early return. This will cause an assertion to be triggered
- and a bug. Fix this by suspending it before the return.
- With Adam Treat's recent change to split suspension of
- screen and backingstore into two different functions,
- this can now be reduced to a mere screen (blitting)
- suspension. That was the original intention of this code.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- 2012-11-15 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Leave surface resizing to the client.
- https://bugs.webkit.org/show_bug.cgi?id=102280
- RIM PR 235034
- RIM PR 160619
- Reviewed by Adam Treat.
- Now that we always blit on the user interface thread and
- use the client's userInterfaceViewportAccessor() to determine
- the destination rectangle for blitting, changing the viewport
- size does not affect the window or target surface directly.
- The only way that blitted output is affected is through
- layout, scroll position or scale changes. None of these
- require us to synchronize with the UI thread to resize its
- target surface.
- This commit simplifies setViewportSize() and removes a
- blocking message dispatch by simply offloading all surface
- resizing responsibilities to the client. This is safer,
- cleaner and easier.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPage::setScreenOrientation):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-11-14 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
- https://bugs.webkit.org/show_bug.cgi?id=102284
- Reviewed by Rob Buis.
- PR237497
- When holding backspace, clearing the state forces a keyboard
- update which resets the state of the keyboard. Handling this
- specific corner case separate from all other editor commands.
- Internally reviewed by Mike Fenton.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
- 2012-11-14 Rob Buis <rbuis@rim.com>
- [BlackBerry] Improve debug functionality in FatFingers
- https://bugs.webkit.org/show_bug.cgi?id=102263
- Reviewed by Antonio Gomes.
- - use logAlways to log even in release.
- - dump shadow tree info if available.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::checkForText):
- 2012-11-14 Adam Treat <atreat@rim.com>
- [BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
- https://bugs.webkit.org/show_bug.cgi?id=102126
- Reviewed by George Staikos.
- PR 219976
- Modify the suspend/resume methods so that they can be called from the UI thread
- itself and split up the suspend/resume methods so that we can suspend/resume
- the screen or backingstore separately.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- (BlackBerry::WebKit::BackingStore::suspendBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStore::resumeBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStore::suspendScreenUpdates):
- (BlackBerry::WebKit::BackingStore::resumeScreenUpdates):
- (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
- (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- (BlackBerry::WebKit::WebPage::destroy):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
- 2012-11-14 Andy Chen <andchen@rim.com>
- [BlackBerry] Add FocusBased context node detection strategy
- https://bugs.webkit.org/show_bug.cgi?id=102238
- Reviewed by Rob Buis.
- If last fat finger result is invalid, we need to return current
- focus element as context node, because when user tap on selection
- overlay, there is not touch event sent to webkit.
- PR 241382
- Internally reviewed by Genevieve Mak and Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- * Api/WebPage.h:
- * WebKitSupport/InputHandler.h:
- (BlackBerry::WebKit::InputHandler::currentFocusElement):
- 2012-11-14 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Use mispelled-marker offsets relative to the element
- https://bugs.webkit.org/show_bug.cgi?id=102236
- Reviewed by Rob Buis.
- DocumentMarker offsets are calculated relative to a node. This is causing
- problems for contenteditable which can have numerous nodes. Creating a Range around a word
- and calculating its location and length gives us the correct override in this case for starting
- and ending points to pass to IMF.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 2012-11-13 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fully restore both zoom and scroll when leaving an input field.
- https://bugs.webkit.org/show_bug.cgi?id=102094
- Reviewed by Rob Buis.
- PR 234187.
- Cache both the zoom and scroll position prior to adjusting
- for input focus so that state can be reset fully.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-11-12 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Ensure we only receive one KeyUp per key event
- https://bugs.webkit.org/show_bug.cgi?id=101967
- Reviewed by Rob Buis.
- We are creating synthetic KeyUps too often, and get into trouble since IMF will send up a KeyUp on all key events.
- Furthermore, these KeyUps can arrive both when we are composing and not. To bypass this check, we are storing the KeyDown
- character and comparing against it on KeyUp.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::insertText):
- (BlackBerry::WebKit::InputHandler::setText):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-11-12 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] When opening an image it does not scale to fit our window
- https://bugs.webkit.org/show_bug.cgi?id=101778
- Reviewed by Rob Buis.
- Internally reviewed by Konrad Piascik.
- PR: 230935
- For image document, the actual image size can be different with the
- contents size. Zoom the document based on the image width so that
- images can fit the screen horizontally. Set 2.0 as the maximum zoom to
- fit scale for image document so that very small images won't get
- ridiculous large scales during the initial load.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
- 2012-11-12 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Use keyevents instead of editor commands for backspace
- https://bugs.webkit.org/show_bug.cgi?id=101663
- Reviewed by Rob Buis.
- PR229395
- Sending keyEvents for backspace and switching from KeyChar
- to KeyDown since we are still receiving an unadultered KeyUp
- from the input service. This was causing us to get two keyUps
- for regular keys and no key downs for backspace since it was
- triggering an editor command and bypassing JS listeners.
- Reviewed internally by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::relativeRightOffset):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
- (BlackBerry::WebKit::InputHandler::setText):
- 2012-11-12 Rob Buis <rbuis@rim.com>
- [BlackBerry] Crash in InRegionScrollerPrivate.
- https://bugs.webkit.org/show_bug.cgi?id=101399
- Reviewed by Yong Li.
- Fix warning caused by the previous patch for this bug (r133679).
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-11-11 George Staikos <staikos@webkit.org>
- [BlackBerry] The QNX extension method should not be enabled by default
- https://bugs.webkit.org/show_bug.cgi?id=101863
- Reviewed by Rob Buis.
- Simply change the default to false.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- 2012-11-09 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Adding a sound to touch events on anchor elements
- https://bugs.webkit.org/show_bug.cgi?id=101655
- Reviewed by Antonio Gomes.
- Adding audio feedback to touchevents on html anchor elements.
- The feedback is called directly from client instead of using the
- mouseup event to avoid the delay between touch start and end caused
- by the tap sequence recognizer.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::playSoundIfAnchorIsTarget):
- (WebKit):
- * Api/WebPage.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (WebKit):
- (BlackBerry::WebKit::TouchEventHandler::playSoundIfAnchorIsTarget):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-11-09 George Staikos <staikos@webkit.org>
- [BlackBerry] Remove obsolete tokenizer settings
- https://bugs.webkit.org/show_bug.cgi?id=101689
- Reviewed by Yong Li.
- These tokenizer settings are obsolete and should not be here. Remove them.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-11-08 Chris Guan <chris.guan@torchmobile.com.cn>
- [BlackBerry] need to call closePopup at setValueAndClosePopup
- https://bugs.webkit.org/show_bug.cgi?id=101568
- Reviewed by George Staikos.
- When early return occurs, we need to call closePopup
- at setValueAndClosePopup function. See the comments
- in WebCore/page/PagePopupClient.h. If we have not it,
- Webkit thread is held and browser will be unresponsive
- in BlackBerry port.
-
- RIM PR 232962
- Internally reviewed by Charles Wei.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Replace checkerboard with page background color.
- https://bugs.webkit.org/show_bug.cgi?id=101652
- RIM PR 188235
- Reviewed by George Staikos.
- In order to do this, we introduce a new member variable for
- BackingStore because when blitting, we can't access the
- page background color in a threadsafe way.
- Solid background color fill is still only used for public builds.
- Developers and beta testers should still see checkerboard and
- do something about it.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- (BlackBerry::WebKit::BackingStorePrivate::webPageBackgroundColorUserInterfaceThread):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::setWebPageBackgroundColor):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-11-08 Tiancheng Jiang <tijiang@rim.com>
- [BlackBerry] Update BB10 date input form.
- https://bugs.webkit.org/show_bug.cgi?id=101075
- Reviewed by Rob Buis.
- RIM PR 234531
- Internally Reviewed by Mike Fenton.
- Change date input appearance to button and hide caret when click on them.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValueAndClosePopup):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- 2012-11-08 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Provide pixel coordinates to IMF relative to the screen
- https://bugs.webkit.org/show_bug.cgi?id=101628
- Reviewed by Rob Buis.
- Reviewed internally by Mike Fenton and Jakob Petsovits.
- We need to provide the correct pixel coordinates to IMF,
- accounting for webkit based fields in UIB as well as browser.
- Getting an offset value from the screen point to the document
- content point allows us to adjust for when the document,
- such as in UIB, does not start at 0,0.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Janitor: Remove unused m_isValid bool
- https://bugs.webkit.org/show_bug.cgi?id=101610
- Reviewed by Rob Buis.
- It's not used anywhere, but as we have a constructor
- that creates an invalid TileIndex, let's add another
- method to check validity - now a correct check.
- On top of that, make the stylebot happy by reducing
- "unsigned int" to just "unsigned".
- * WebKitSupport/TileIndex.h:
- (BlackBerry::WebKit::TileIndex::TileIndex):
- (BlackBerry::WebKit::TileIndex::i):
- (BlackBerry::WebKit::TileIndex::j):
- (BlackBerry::WebKit::TileIndex::setIndex):
- (BlackBerry::WebKit::TileIndex::isValid):
- (TileIndex):
- 2012-11-08 Eli Fidler <efidler@rim.com>
- [BlackBerry] Increase memory cache size
- https://bugs.webkit.org/show_bug.cgi?id=101622
- Reviewed by Yong Li.
- * WebCoreSupport/CacheClientBlackBerry.cpp:
- (WebCore::CacheClientBlackBerry::updateCacheCapacity):
- * WebCoreSupport/CacheClientBlackBerry.h:
- (CacheClientBlackBerry):
- 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Rework the API to use document coordinates
- https://bugs.webkit.org/show_bug.cgi?id=101608
- RIM PR 173292
- Reviewed by Adam Treat.
- Scrolling and zooming APIs used to operate on
- transformed coordinates, which is a bad idea:
- The UI thread might long have moved on to a
- different scale and scroll position so outdated
- pixel coordinates are of limited value.
- Moreover, more transformation calculations are
- needed than if we operate purely on document
- coordinates.
- With webkitThreadViewportAccessor() exposed,
- the caller has a choice between how to handle
- coordinates and the means to perform conversions
- with little effort and overhead if needed.
- Therefore, we should remove pixel coordinates
- from the public API. This commit makes this change.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionCompositingThread):
- (BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionWebKitThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- * Api/InRegionScroller.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPage::setDocumentScrollPosition):
- (BlackBerry::WebKit::WebPagePrivate::hasVirtualViewport):
- (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
- (BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
- (BlackBerry::WebKit::WebPagePrivate::setCursor):
- (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
- (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- (BlackBerry::WebKit::WebPage::setVirtualViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
- (BlackBerry::WebKit::WebPage::setDocumentScrollOriginPoint):
- (BlackBerry::WebKit::handleScrolling):
- (BlackBerry::WebKit::WebPage::selectionContainsDocumentPoint):
- (BlackBerry::WebKit::WebPage::setDocumentSelection):
- (BlackBerry::WebKit::WebPage::setDocumentCaretPosition):
- (BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
- (BlackBerry::WebKit::WebPagePrivate::setTextReflowAnchorPoint):
- (BlackBerry::WebKit::WebPage::pinchZoomAboutPoint):
- (BlackBerry::WebKit::WebPage::blockZoom):
- (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
- (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
- * Api/WebPage.h:
- (Platform):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/AutofillManager.cpp:
- (WebCore::AutofillManager::didChangeInTextField):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-11-08 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Verify touched element using the rootEditableElement
- https://bugs.webkit.org/show_bug.cgi?id=101510
- Reviewed by Rob Buis.
- Reviewed internally by Mike Fenton.
- Move up the tree until we find the rootEditableElement and use
- that to compare with the touched element.
- * WebKitSupport/FatFingers.h:
- (BlackBerry::WebKit::FatFingersResult::node):
- (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-11-07 Rob Buis <rbuis@rim.com>
- [BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
- https://bugs.webkit.org/show_bug.cgi?id=101490
- Reviewed by Yong Li.
- We no longer need this API.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- * Api/WebSettings.h:
- 2012-11-07 Christophe Dumez <christophe.dumez@intel.com>
- Add replaceWithLiteral() method to WTF::String
- https://bugs.webkit.org/show_bug.cgi?id=101257
- Reviewed by Benjamin Poulain.
- Substitute String::replace() calls by String::replaceWithLiteral() where
- adequate, for efficiency.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-11-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
- Remove support for "desktop-width" in the viewport meta tag
- https://bugs.webkit.org/show_bug.cgi?id=101217
- Reviewed by Gyuyoung Kim.
- Sync WebViewportArguments enum with the one in
- WebCore::ViewportArguments
- * Api/WebViewportArguments.h:
- 2012-11-06 Genevieve Mak <gmak@rim.com>
- [BlackBerry] Crash in InRegionScrollerPrivate.
- https://bugs.webkit.org/show_bug.cgi?id=101399
- Reviewed by Rob Buis.
- Add a pointer to the enclosing document as the pointer to layer
- or node along the way may become invalid.
- Use document pointer in clearDocumentData.
- PR #238469
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- (BlackBerry::WebKit::InRegionScrollableArea::document):
- (WebKit):
- * WebKitSupport/InRegionScrollableArea.h:
- (WebCore):
- (InRegionScrollableArea):
- 2012-11-06 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Pushing window.external.* events to webplatform
- https://bugs.webkit.org/show_bug.cgi?id=101386
- Reviewed by Rob Buis.
- Adding calls to trigger window.external events so we can handle them on the
- browser side.
- PR 170059
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addSearchProvider):
- (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
- 2012-11-06 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Adding window.external to our port
- https://bugs.webkit.org/show_bug.cgi?id=100868
- Reviewed by Rob Buis.
- Patching the method names to match the ones in the spec.
- * WebCoreSupport/ExternalExtension.cpp:
- 2012-11-06 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Page can't back to whole screen after zoom out and orientation change
- https://bugs.webkit.org/show_bug.cgi?id=101350
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- PR: 229321
- When rotating device during touch interaction, bitmap zooming was
- unexpected ended by resetBitmapZoomScale() so that it couldn't bounce
- back. The call resetBitmapZoomScale() is ancient, which just resets the
- scale of the bitmap before. Right now it only ends the bitmap zooming
- which caused the issue. As UI viewport will be updated by zoomChanged()
- right after that, we can remove this trouble maker.
- Update the interaction views if the rotation is being changed so that
- ZoomHandler can get the updated views.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- * Api/WebPageClient.h:
- 2012-11-05 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Do not show error page for main loads denied by client application
- https://bugs.webkit.org/show_bug.cgi?id=101287
- Internal PR: 237574.
- Internally reviewed by Arvid Nilsson, Joe Mason.
- Reviewed by George Staikos.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-05 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Do not display error page for failed downloads
- https://bugs.webkit.org/show_bug.cgi?id=101246
- Internal PR: 236318
- Internal reviewed by Joe Mason, Leo Yang.
- Reviewed by Rob Buis.
- Right now when a main load, including all downloads, failed, it will
- display an error page. This is not very user friendly, especially for
- WebWorks application, which want to use its own user interface to info
- user about the failure.
- So we just stop displaying error page for downloads.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 2012-11-05 Simon Fraser <simon.fraser@apple.com>
- Fix layer borders to cleaning appear and disappear on switching
- https://bugs.webkit.org/show_bug.cgi?id=101136
- Reviewed by Sam Weinig.
- Remove the GraphicsLayerClient methods showDebugBorders() and
- showRepaintCounter().
- * Api/WebOverlay_p.h:
- (WebOverlayPrivateWebKitThread):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
- * Api/WebPage_p.h:
- * WebKitSupport/DefaultTapHighlight.cpp:
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/InspectorOverlayBlackBerry.cpp:
- * WebKitSupport/InspectorOverlayBlackBerry.h:
- (InspectorOverlay):
- * WebKitSupport/SelectionOverlay.cpp:
- * WebKitSupport/SelectionOverlay.h:
- (SelectionOverlay):
- 2012-11-05 Rob Buis <rbuis@rim.com>
- [BlackBerry] screenX/Y gives wrong values
- https://bugs.webkit.org/show_bug.cgi?id=101259
- Reviewed by Yong Li.
- PR 237071
- Reviewed internally by Gen Mak.
- Do not transform screenPos coordinates.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::mouseEvent):
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- 2012-11-05 Rob Buis <rbuis@rim.com>
- [BlackBerry] Input date should not popup dialog when readonly is set
- https://bugs.webkit.org/show_bug.cgi?id=101234
- Reviewed by Yong Li.
- PR 236114
- Reviewed internally by Mike Fenton.
- Suppress popup dialog if the input element has readonly attribute set.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- (BlackBerry::WebKit::InputHandler::openColorPopup):
- 2012-11-05 Genevieve Mak <gmak@rim.com>
- [BLACKBERRY] Update touch code to reflect touch refactor
- https://bugs.webkit.org/show_bug.cgi?id=101227
- Reviewed by Rob Buis.
- PR #2706785
- Reviewed Internally by: Mike Lattanzio
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
- 2012-11-05 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
- https://bugs.webkit.org/show_bug.cgi?id=101213
- RIM PR 178131
- Reviewed by Rob Buis.
- Internally Reviewed by Arvid Nilsson.
- Added compositing events to the timeline for BlackBerry.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::willComposite):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::didComposite):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-11-03 Alexey Proskuryakov <ap@apple.com>
- Get rid of USE(CFURLSTORAGESESSIONS)
- https://bugs.webkit.org/show_bug.cgi?id=101131
- Reviewed by Sam Weinig.
- * WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
- CFURLSTORAGESESSIONS probably doesn't need to stay here.
- 2012-11-02 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Fix compile-time warning of a possible empty-body if statement
- https://bugs.webkit.org/show_bug.cgi?id=101095
- Reviewed by Yong Li.
- Internally reviewed by Jeff Rogers.
- BBLOG might be compiled out leaving an if statement with an empty
- body. This is giving us a warning at the moment. Simply putting braces
- around it will fail as well because then we'd have braces around a
- single-line if. So, in following with the style observed in other parts
- of BackingStore.cpp, break up the log message and add braces.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- 2012-11-02 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Optimize backspace key handling
- https://bugs.webkit.org/show_bug.cgi?id=101083
- PR233591
- Optimize backspace key handling. Some of these calls are not
- required by IMF since the input_service already processes the backspace key
- and updates the state before passing us the key.
- Internally reviewed by Mike Fenton.
- Reviewed by Yong Li.
- Blocking calls with a flag that we clear immediately after
- processing a backspace keydown.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::nodeTextChanged):
- (BlackBerry::WebKit::InputHandler::selectionChanged):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-11-02 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Adding window.external to our port
- https://bugs.webkit.org/show_bug.cgi?id=100868
- Reviewed by Rob Buis.
- PR 158809
- Patch up an error where we were dereferencing a null pointer.
- * WebCoreSupport/ExternalExtension.cpp:
- (addSearchProviderMethod):
- (IsSearchProviderInstalledMethod):
- 2012-11-01 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
- https://bugs.webkit.org/show_bug.cgi?id=100941
- Reviewed by Yong Li.
- Remove the unnecessary steps, just directly deal with returned JSValue.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
- 2012-11-01 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Add a prompt to enable global location services
- https://bugs.webkit.org/show_bug.cgi?id=100992
-
- PR 227897
- Reviewed by Rob Buis.
- Adding a dialog to let the user know location services isn't enabled.
- Currently, the browser app does not check whether the global setting for
- location service is enabled. This patch adds a dialog to allow the user
- to open the settings app and change that setting. This infobar will only
- show once per session. If the user fails to turn on location services after
- the first prompt, all geolocation requests will automatically fail.
- Also, adapting GeolocationClientBlackBerry to the removal of GeoTracker.
- The class now talks directly to the geo handler singleton.
- * Api/WebPageClient.h:
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
- (GeolocationClientBlackBerry::geolocationDestroyed):
- (GeolocationClientBlackBerry::startUpdating):
- (GeolocationClientBlackBerry::stopUpdating):
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::setEnableHighAccuracy):
- * WebCoreSupport/GeolocationClientBlackBerry.h:
- (WebCore::GeolocationClientBlackBerry::requiresHighAccuracy):
- (GeolocationClientBlackBerry):
- 2012-11-01 Michael Matovsky <mmatovsky@rim.com>
- [BlackBerry] Web page view state should be preserved for pages loaded from page cache
- https://bugs.webkit.org/show_bug.cgi?id=100694
- Internal PR: 220488
- Internally reviewed by Lianghui Chen, Joe Mason
- Reviewed by Rob Buis.
- The web page view specific metadata should be preserved for web pages loaded from page cache (by using back/forward).
- This requires web page view state to be saved in and restored from the corresponding page cache history item.
- * Api/WebPageClient.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-11-01 Leo Yang <leoyang@rim.com>
- [BlackBerry] Use clipped background rect in backing store
- https://bugs.webkit.org/show_bug.cgi?id=100960
- Reviewed by Yong Li.
- Reviewed internally by Arvid Nilsson.
- We calculated clipped background rect but didn't really use it when painting
- the background. Use the correct rect to avoid ASSERT failure in platform code.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- 2012-10-31 George Staikos <staikos@webkit.org>
- [BlackBerry] Crash on html popup form control when element is deleted
- https://bugs.webkit.org/show_bug.cgi?id=100869
- Reviewed by Yong Li.
- Make the element pointers RefPtr so they don't go away before the popup
- is closed.
- * WebCoreSupport/ColorPickerClient.h:
- (ColorPickerClient):
- * WebCoreSupport/DatePickerClient.h:
- (DatePickerClient):
- * WebCoreSupport/SelectPopupClient.h:
- (SelectPopupClient):
- 2012-10-31 Genevieve Mak <gmak@rim.com>
- [BLACKBERRY] Custom WebWorks context menus don't always work.
- https://bugs.webkit.org/show_bug.cgi?id=100891
- Reviewed by Rob Buis.
- Walk up the dom tree until we find the webworks attribute or run out
- of parent nodes.
- PR# 227732
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2012-10-31 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Adding window.external to our port
- https://bugs.webkit.org/show_bug.cgi?id=100868
- Reviewed by Rob Buis.
- Attaching the window.external interface to the frame when
- it loads up.
- When called, the external interface methods call stubs declared
- in ChromeClientBlackBerry. The method passes in the url of the search
- provider and the url of the frame. Cross-site check has to be done in the
- implementation PR.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addSearchProvider):
- (WebCore):
- (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebCoreSupport/ExternalExtension.cpp: Added.
- (addSearchProviderMethod):
- (IsSearchProviderInstalledMethod):
- (externalExtensionInitialize):
- (externalExtensionFinalize):
- * WebCoreSupport/ExternalExtension.h: Added.
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 2012-10-30 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
- https://bugs.webkit.org/show_bug.cgi?id=100724
- Reviewed by Rob Buis.
- Remove the code of JavaScriptDebuggerBlackBerry.
- * Api/WebPage.cpp:
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Removed.
- * WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Removed.
- 2012-10-29 Rob Buis <rbuis@rim.com>
- [BlackBerry] Simplify AuthenticationChallengeManager::instance
- https://bugs.webkit.org/show_bug.cgi?id=100614
- Reviewed by Yong Li.
- Internally reviewed by Lyon Chen.
- No need to call AuthenticationChallengeManager::init anymore.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- 2012-10-29 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle()
- https://bugs.webkit.org/show_bug.cgi?id=100377
- Reviewed by Adam Treat.
- Should be void, not bool.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-10-29 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Fix a build error
- https://bugs.webkit.org/show_bug.cgi?id=100649
- Reviewed by Kentaro Hara.
- r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
- and this commit was later reverted. We need to update a call site in the
- BlackBerry port to make it build.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- 2012-10-26 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
- https://bugs.webkit.org/show_bug.cgi?id=100421
- Reviewed by Yong Li.
- PR: 231173
- When leaving fullscreen, we need to suspend screen and backing store
- updates before setting scroll position and changing transformation and
- resume after they are done. In which way, we can get rid of a noticeable
- glitch during the transition.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- 2012-10-26 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
- https://bugs.webkit.org/show_bug.cgi?id=100504
- Reviewed by Yong Li.
- PR #232038 The similar PR # 200724.
- Reviewed internally by Petter Wang.
- This issue is same as bug 95492, and this patch is same as its patch.
- Hold the JSLock for the current thread before we call toRef to avoid
- the ASSERT failure.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 2012-10-25 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
- https://bugs.webkit.org/show_bug.cgi?id=100330
- Reviewed by Rob Buis.
- Reviewed internally by Charles Wei.
- PR #231232
- Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
- visible needs AuthenticationChallengeManager to update its records, deleting
- webpage from AuthenticationChallengeManager's map should be done after setting
- webpage visibility.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- 2012-10-24 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
- https://bugs.webkit.org/show_bug.cgi?id=100214
- Reviewed by Rob Buis.
- ViewportSize has been changed before committing root layer, it asserts
- that it needs relayout and render if needed before committing if it
- Needs One Shot Drawing Synchronization.
- This patch calls requestLayoutIfNeeded() when resumeScreenAndBackingStoreUpdates().
- Fix a coding style in the BackingStore.cpp as well.
- Reviewed internally by Arvid Nilsson.
- PR #230253
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 2012-10-24 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Geolocation is segfaulting
- https://bugs.webkit.org/show_bug.cgi?id=100305
- Reviewed by Rob Buis.
- We weren't wrapping the Geolocation object in a RefPtr when we call setIsAllowed in
- GeolocationClientBlackBerry::onPermission.
- This patch also removes all references of the Geolocation object in WebPageClientImpl.
- One RefPtr<Geolocation> is used to store the reference of the WebCore object on our port.
- We don't need a mapping between origin -> context of Geolocation because in our port,
- one WebPage.cpp contains one GeolocationController only.
- * Api/WebPageClient.h:
- * WebCoreSupport/GeolocationClientBlackBerry.cpp:
- (frameOrigin):
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- (GeolocationClientBlackBerry::onPermission):
- * WebCoreSupport/GeolocationClientBlackBerry.h:
- (GeolocationClientBlackBerry):
- 2012-10-24 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
- https://bugs.webkit.org/show_bug.cgi?id=100259
- Reviewed by Rob Buis.
- PR: 219666
- Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
- This rolls out r128772.
- The patches relies on the viewport size change of the client side to
- resume the screen and backing store updates. However, some client
- sides don't need or wish to resize the WebKit viewport at all which
- will result in upexpected screen and backing store suspensions.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- 2012-10-24 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
- https://bugs.webkit.org/show_bug.cgi?id=100259
- Reviewed by Rob Buis.
- PR: 219666
- Roll out r130392 and r129909.
- The patches rely on the viewport size change of the client side to
- update the scale and scroll position of the video. However, some client
- sides don't need or wish to resize the WebKit viewport at all.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-10-24 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=100250
- Reviewed by Rob Buis.
- Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
- to prevent confusion.
- PR 230196
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * Api/WebPage_p.h:
- (WebCore):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.
- (frameOrigin):
- (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
- (GeolocationClientBlackBerry::geolocationDestroyed):
- (GeolocationClientBlackBerry::startUpdating):
- (GeolocationClientBlackBerry::stopUpdating):
- (GeolocationClientBlackBerry::lastPosition):
- (GeolocationClientBlackBerry::requestPermission):
- (GeolocationClientBlackBerry::cancelPermissionRequest):
- (GeolocationClientBlackBerry::onLocationUpdate):
- (GeolocationClientBlackBerry::onLocationError):
- (GeolocationClientBlackBerry::onPermission):
- (GeolocationClientBlackBerry::setEnableHighAccuracy):
- * WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.
- (WebKit):
- (WebCore):
- (GeolocationClientBlackBerry):
- (WebCore::GeolocationClientBlackBerry::tracker):
- 2012-10-24 Parth Patel <parpatel@rim.com>
- [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
- Generic ThreadUnsafe Singleton
- https://bugs.webkit.org/show_bug.cgi?id=100145
- Reviewed by Rob Buis.
- Extending the singletons to generic singleton and changing
- getInstance() in IconDatabaseClientBlackBerry to instance()
- to match the generic singleton template.
- Reviewed Internally by Yong Li.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::initializeIconDataBase):
- * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
- (WebCore):
- * WebCoreSupport/IconDatabaseClientBlackBerry.h:
- (IconDatabaseClientBlackBerry):
- 2012-10-23 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Web page renders at the wrong zoom level after viewport changes
- https://bugs.webkit.org/show_bug.cgi?id=100096
- Reviewed by Rob Buis.
- Notify the client of the zoom level change before resuming screen updates.
- Otherwise, the user interface thread may blit the content at the wrong
- zoom level in some cases. This can also prevent potential flickering.
- Reviewed internally by Arvid Nilsson.
- PR #225741
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- 2012-10-23 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
- https://bugs.webkit.org/show_bug.cgi?id=99649
- Reviewed by George Staikos.
- Random latency before scroll starts on sites like http://pintrest.com
- Internal PR225398
- The chief problem here is the all the hit testing that we do for
- touch events and simulated mouse events. If the render tree is dirty
- hit tests can take a long time in Document::recalcStyle(). Masking
- the flags that force style recalculations will make them fast, at the
- expense that they might be happening on stale data.
- Since we are only using these hit tests to look for event handlers -
- we're not actually modifying anything, it is better to skip the
- Document::recalcStyle() and save ourselves tons of time.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
- (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
- (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- (BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
- * WebKitSupport/FatFingers.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-10-23 Rob Buis <rbuis@rim.com>
- [BlackBerry] Make selection in search input box not overlap cancel button
- https://bugs.webkit.org/show_bug.cgi?id=100130
- Reviewed by Antonio Gomes.
- This ensures that even when selection is active, the user can still press 'cancel'.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
- 2012-10-23 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Let WebKit manage the SelectionOverlay
- https://bugs.webkit.org/show_bug.cgi?id=99585
- Reviewed by Rob Buis.
- The SelectionOverlay was exposed to clients of the BlackBerry::WebKit
- API. However, all the information and notifications necessary to manage
- the SelectionOverlay are available within WebKit, so the client does
- not have to shoulder this responsibility.
- Remove WebSelection and all the related plumbing. Now that nobody is
- using the class from the user interface thread, remove the message
- related code in SelectionOverlay.
- Add two calls to SelectionOverlay::hide() that are necessary now that
- the client is no longer responsible for hiding it.
- RIM PR: 225789
- Reviewed internally by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSelectionOverlay.h: Removed.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection): Hide the overlay here, because state is reset and selection mode is no longer active
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): Also hide overlay here, to go with the call to cancelSelectionVisuals
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
- * WebKitSupport/SelectionOverlay.h:
- (BlackBerry::WebKit::SelectionOverlay::create):
- (SelectionOverlay):
- 2012-10-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove specialized handling for isIndex fields.
- https://bugs.webkit.org/show_bug.cgi?id=100004
- Reviewed by Rob Buis.
- PR 214342.
- Remove special handling for isIndex field as the tag
- is rewritten.
- Reviewed Internally by Yongxin Dai and Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::inputStyle):
- (BlackBerry::WebKit::InputHandler::elementType):
- 2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
- [Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
- https://bugs.webkit.org/show_bug.cgi?id=98514
- Reviewed by Kenneth Rohde Christiansen.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
- 2012-10-20 Andrew Lo <anlo@rim.com>
- [BlackBerry] m_mainFrame should be null checked before use in WebPagePrivate destructor
- https://bugs.webkit.org/show_bug.cgi?id=99916
- Reviewed by George Staikos.
- Internally reviewed by Arvid Nilsson.
- Internal PR228029
- Add null checks for m_mainFrame for things that happen during
- WebPage destruction.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
- 2012-10-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Convert input style to int64_t
- https://bugs.webkit.org/show_bug.cgi?id=99848
- Reviewed by Yong Li.
- PR 227381.
- Switch input style mask to int64_t to match the the updated definition.
- Reviewed Internally by Nima Ghanavatian.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::inputStyle):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-10-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Move all keyboard type calculations into InputHandler.
- https://bugs.webkit.org/show_bug.cgi?id=99847
- Reviewed by Yong Li.
- PR 227381.
- Move all keyboard type calculations into webkit and avoid passing type
- information to the webview.
- Reviewed Internally by Nima Ghanavatian.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputTypeToVKBType):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- 2012-10-19 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Page viewport aspect ratio not kept on navigating back
- https://bugs.webkit.org/show_bug.cgi?id=99760
- Reviewed by Yong Li.
- Internally reviewed by Konrad Piascik
- PR: 222437
- This is to fix the second issue on PR222437 that the viewport not kept
- when navigating back from google after rotation to bloomberg.
- We were trying to restore the history contents size and scale of
- bloomberg which has virtual viewport. The scale would be recalculated
- based on the new screen size. However, we would still use the current
- contents size if it was greater than the history contents size in
- FrameView::setContentsSize which made the contents seem to be scaled
- too much.
- Actually when we relayout the contents after rotation change, the
- current contents size which is based on the virtual viewport has taken
- the screen size into account. Shrinking the contents size will be
- expensive. So we can ignore screen size based scale calculation here.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-10-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add input logs to InputHandler::ensureFocusTextElementVisible.
- https://bugs.webkit.org/show_bug.cgi?id=99837
- Reviewed by Antonio Gomes.
- Add input logs for InputHandler::ensureFocusTextElementVisible.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-10-19 Andrew Lo <anlo@rim.com>
- [BlackBerry] Should suspend AnimationController when WebPage becomes invisible.
- https://bugs.webkit.org/show_bug.cgi?id=99844
- Reviewed by Yong Li.
- Internally reviewed by Arvid Nilsson & Yong Li.
- Suspend animation controller when the tab becomes invisible,
- in addition to suspending scripted animations.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- 2012-10-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Don't attempt to auto scroll on input for Fixed Position elements.
- https://bugs.webkit.org/show_bug.cgi?id=99833
- Reviewed by Antonio Gomes.
- PR 195024.
- Don't attempt to scroll fixed position elements.
- Reviewed Internally by Arvid Nilsson.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- (WebCore):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-10-18 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Page viewport aspect ratio not kept on navigating back
- https://bugs.webkit.org/show_bug.cgi?id=99760
- Reviewed by Rob Buis.
- Internally reviewed by Konrad Piascik.
- PR: 190469
- This was added in r127628 which was trying to fix some rendering
- defects on maps.google.com and news.qq.com, however it was very harmful
- and caused regressions.
- zoomToFitScale() depends on the current contents size. During history
- navigation and device rotation, if zoomToFitScale() is based on the
- final contents size which is expected, there will still be a scale
- calculation like this afterwards
- screenSize.width()/screenSize.height()*zoomToFitScale() which will
- result in a wrong scale. During the history navigation, if
- zoomToFitScale() isn't based on the final contents size, then we will
- get the wrong scale as well for sure.
- This issue will be fixed by removing the wrong calculation.
- The original issue of r127628 was fixed by the patch of PR225981.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-10-18 John Griggs <jgriggs@rim.com>
- 2012-10-18 John Griggs <jgriggs@rim.com>
- Crash in InRegionScrollableArea constructor while loading page
- https://bugs.webkit.org/show_bug.cgi?id=99733
- Reviewed by Antonio Gomes.
- Check scrollLayer and avoid constructing InRegionScrollableArea when it is NULL.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- 2012-10-17 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
- https://bugs.webkit.org/show_bug.cgi?id=99624
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson
- PR: 225981
- Several reasons to eliminate the ancient unnecessary
- zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:
- - At this point, we have only committed the data we received.
- - For the new load, we haven't started parsing the tokens and building
- the DOM tree and the first layout will happen after that.
- - For the load restored from cache, the first layout will happen after
- setLoadState committed which is called by
- FrameLoader::dispatchDidCommitLoad().
- - zoomToInitialScaleOnLoad() can still be called after the first
- layout finished.
- - zoomToInitialScaleOnLoad() is expensive and it will boost the load
- performance after the removal.
- - Removal of this can fix some weird rendering defects on yahoo.com,
- maps.google.com, news.qq.com and so on during load and rotation
- mentioned on the PR.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 2012-10-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Prevent focus zoom on non-userscalable pages.
- https://bugs.webkit.org/show_bug.cgi?id=99608
- Reviewed by Rob Buis.
- PR 222378.
- Disable focus zoom when the page is non-user scalable.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-10-16 Mike Lattanzio <mlattanzio@rim.com>
- 2012-10-16 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
- https://bugs.webkit.org/show_bug.cgi?id=99497
- Reviewed by Antonio Gomes.
- Fix calculateInRegionScrollableAreasForPoint to use a ReadOnly
- hit test to improve its performance.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- 2012-10-15 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
- https://bugs.webkit.org/show_bug.cgi?id=99404
- Reviewed by George Staikos.
- In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.
- * WebCoreSupport/inspectorBB.js:
- 2012-10-15 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Only reallocate buffers that were allocated before suspending
- https://bugs.webkit.org/show_bug.cgi?id=99205
- RIM PR 99395
- Reviewed by Antonio Gomes.
- When we call releaseBuffers(), not all of the backingstore
- tile buffers might have been allocated yet. Still we try
- to release all of them, which causes us to lazy-initialize
- the tile buffers so we can release them again.
- This is stupid and we should just ignore buffers that
- haven't been initialized yet. This patch makes that change.
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
- (WebKit):
- * WebKitSupport/BackingStoreTile.h:
- (TileBuffer):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::createBuffers):
- (BlackBerry::WebKit::SurfacePool::releaseBuffers):
- 2012-10-15 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
- https://bugs.webkit.org/show_bug.cgi?id=99302
- Reviewed by Rob Buis.
- RIM PR: 210884
- The marco BBLOG() is defined as a no-op in release mode which will
- save a function call in the release build.
- Internally reviewed by Charles Wei.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::bestDivisor):
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::scroll):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::contentsSizeChanged):
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::overflowExceedsContentsSize):
- (WebCore::ChromeClientBlackBerry::didDiscoverFrameSet):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::checkForText):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
- (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- (BlackBerry::WebKit::RenderQueue::render):
- (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
- (BlackBerry::WebKit::RenderQueue::startRegularRenderJobBatchIfNeeded):
- (BlackBerry::WebKit::RenderQueue::renderVisibleZoomJob):
- (BlackBerry::WebKit::RenderQueue::renderVisibleScrollJob):
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
- (BlackBerry::WebKit::RenderQueue::renderNonVisibleScrollJob):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- 2012-10-15 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] [DRT] Skip region of interest zooming when running DRT
- https://bugs.webkit.org/show_bug.cgi?id=97663
- Reviewed by Rob Buis.
- This patch fixes test fast/forms/textarea-scrolled-endline-caret.html, and
- 1. Add a global function isRunningDrt to check if we're currently running DRT.
- 2. Use the new function in places where getenv("drtRun") is used.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::isRunningDrt):
- (WebKit):
- * Api/BlackBerryGlobal.h:
- (WebKit):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (toGeolocationClientMock):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-10-15 George Staikos <staikos@webkit.org>
- [BlackBerry] Adapt to Platform API changes in string handling
- https://bugs.webkit.org/show_bug.cgi?id=99248
- Reviewed by Yong Li.
- Convert usage of WebString, char* and std::string to BlackBerry::Platform::String.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearAppCache):
- (BlackBerry::WebKit::clearDatabase):
- * Api/BlackBerryGlobal.h:
- (Platform):
- (WebKit):
- * Api/JavaScriptVariant.cpp:
- (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
- (BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
- (BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
- (WebKit):
- (BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
- (BlackBerry::WebKit::JavaScriptVariant::setType):
- (BlackBerry::WebKit::JavaScriptVariant::setString):
- (BlackBerry::WebKit::JavaScriptVariant::stringValue):
- * Api/JavaScriptVariant.h:
- * Api/WebAnimation.cpp:
- (BlackBerry::WebKit::WebAnimation::fadeAnimation):
- (BlackBerry::WebKit::WebAnimation::name):
- * Api/WebAnimation.h:
- * Api/WebCookieJar.cpp:
- (BlackBerry::WebKit::WebCookieJar::cookies):
- (BlackBerry::WebKit::WebCookieJar::setCookies):
- * Api/WebCookieJar.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- * Api/WebKitMIMETypeConverter.cpp:
- (BlackBerry::WebKit::getExtensionForMimeType):
- (BlackBerry::WebKit::getMimeTypeForExtension):
- * Api/WebKitMIMETypeConverter.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- * Api/WebKitTextCodec.cpp:
- (BlackBerry::WebKit::base64Decode):
- (BlackBerry::WebKit::base64Encode):
- (BlackBerry::WebKit::unescapeURL):
- (BlackBerry::WebKit::escapeURL):
- * Api/WebKitTextCodec.h:
- (Platform):
- (BlackBerry):
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlay::removeAnimation):
- * Api/WebOverlay.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- * Api/WebOverlayOverride.cpp:
- (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
- * Api/WebOverlayOverride.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::autofillTextField):
- (BlackBerry::WebKit::WebPage::renderTreeAsText):
- (BlackBerry::WebKit::WebPage::WebPage):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPage::load):
- (BlackBerry::WebKit::WebPage::loadFile):
- (BlackBerry::WebKit::WebPage::download):
- (BlackBerry::WebKit::WebPagePrivate::loadString):
- (BlackBerry::WebKit::WebPage::loadString):
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- (BlackBerry::WebKit::WebPage::executeJavaScript):
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
- (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- (BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
- (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPage::setDateTimeInput):
- (BlackBerry::WebKit::WebPage::setColorInput):
- (BlackBerry::WebKit::WebPage::textEncoding):
- (BlackBerry::WebKit::WebPage::forcedTextEncoding):
- (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
- (BlackBerry::WebKit::WebPage::title):
- (BlackBerry::WebKit::WebPage::selectedText):
- (BlackBerry::WebKit::WebPage::cutSelectedText):
- (BlackBerry::WebKit::WebPage::insertText):
- (BlackBerry::WebKit::WebPage::getBackForwardList):
- (BlackBerry::WebKit::WebPage::onCertificateStoreLocationSet):
- (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- (BlackBerry::WebKit::WebPage::textHasAttribute):
- (BlackBerry::WebKit::WebPage::setAllowNotification):
- (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::addSupportedObjectPluginMIMEType):
- (BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
- (BlackBerry::WebKit::WebSettings::serifFontFamily):
- (BlackBerry::WebKit::WebSettings::setSerifFontFamily):
- (BlackBerry::WebKit::WebSettings::fixedFontFamily):
- (BlackBerry::WebKit::WebSettings::setFixedFontFamily):
- (BlackBerry::WebKit::WebSettings::sansSerifFontFamily):
- (BlackBerry::WebKit::WebSettings::setSansSerifFontFamily):
- (BlackBerry::WebKit::WebSettings::standardFontFamily):
- (BlackBerry::WebKit::WebSettings::setStandardFontFamily):
- (BlackBerry::WebKit::WebSettings::userAgentString):
- (BlackBerry::WebKit::WebSettings::setUserAgentString):
- (BlackBerry::WebKit::WebSettings::defaultTextEncodingName):
- (BlackBerry::WebKit::WebSettings::setDefaultTextEncodingName):
- (BlackBerry::WebKit::WebSettings::userStyleSheetString):
- (BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
- (BlackBerry::WebKit::WebSettings::userStyleSheetLocation):
- (BlackBerry::WebKit::WebSettings::setUserStyleSheetLocation):
- (BlackBerry::WebKit::WebSettings::localStoragePath):
- (BlackBerry::WebKit::WebSettings::setLocalStoragePath):
- (BlackBerry::WebKit::WebSettings::indexedDataBasePath):
- (BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
- (BlackBerry::WebKit::WebSettings::databasePath):
- (BlackBerry::WebKit::WebSettings::setDatabasePath):
- (BlackBerry::WebKit::WebSettings::appCachePath):
- (BlackBerry::WebKit::WebSettings::setAppCachePath):
- (BlackBerry::WebKit::WebSettings::pageGroupName):
- (BlackBerry::WebKit::WebSettings::setPageGroupName):
- * Api/WebSettings.h:
- * Api/WebString.cpp: Removed.
- * Api/WebString.h: Removed.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
- (WebCore::ChromeClientBlackBerry::createWindow):
- (WebCore::ChromeClientBlackBerry::runOpenPanel):
- (WebCore):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebCoreSupport/ClientExtension.cpp:
- (clientExtensionMethod):
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::ColorPickerClient):
- (WebCore::ColorPickerClient::generateHTML):
- * WebCoreSupport/ColorPickerClient.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- (ColorPickerClient):
- * WebCoreSupport/CredentialManager.cpp:
- (WebCore::CredentialManager::autofillAuthenticationChallenge):
- * WebCoreSupport/CredentialManager.h:
- (Platform):
- (CredentialManager):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::DatePickerClient):
- (WebCore::DatePickerClient::generateHTML):
- * WebCoreSupport/DatePickerClient.h:
- (Platform):
- (BlackBerry):
- (WebKit):
- (DatePickerClient):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
- (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
- (WebCore::FrameLoaderClientBlackBerry::loadIconExternally):
- (WebCore::FrameLoaderClientBlackBerry::startDownload):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::show):
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::requestPermission):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebCoreSupport/NotificationPresenterImpl.h:
- (Platform):
- (NotificationPresenterImpl):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::SelectPopupClient):
- (WebCore::SelectPopupClient::update):
- (WebCore::SelectPopupClient::generateHTML):
- * WebCoreSupport/SelectPopupClient.h:
- (Platform):
- (BlackBerry):
- (SelectPopupClient):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::toMediaStreamSource):
- (WebCore::toMediaStreamDescriptor):
- (WebCore::UserMediaClientImpl::requestUserMedia):
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::cachePage):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWchar):
- (BlackBerry::WebKit::convertStringToWcharVector):
- (BlackBerry::WebKit::convertSpannableStringToString):
- (BlackBerry::WebKit::InputHandler::learnText):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- (BlackBerry::WebKit::InputHandler::setText):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectedText):
- * WebKitSupport/SelectionHandler.h:
- (Platform):
- (WebKit):
- (SelectionHandler):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::sharedPixmapGroup):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-10-15 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Clean up BackingStoreClient (part II)
- https://bugs.webkit.org/show_bug.cgi?id=99327
- Reviewed by Yong Li.
- Remove more unneeded BackingStoreClient <-> WebPageClient integration
- methods:
- - BackingStoreClient* backingStoreClientForFrame(...)
- - void addBackingStoreClientForFrame(...)
- - void removeBackingStoreClientForFrame(...)
- Change places calling WPPriv::backingStoreClientForFrame to directly
- access WPPriv::backingStoreClient instead, since only the main frame will
- have a BackingStoreClient instance associated with it, and it is owned by
- the WKPriv.
- Remove non-mainframe only references to BackingStoreClient completely,
- since it is dead code now.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::backingStoreClient):
- (BlackBerry::WebKit::WebPage::destroy):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
- (WebCore::ChromeClientBlackBerry::scroll):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
- (WebCore::FrameLoaderClientBlackBerry::createFrame):
- (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::create):
- (BlackBerry::WebKit::BackingStoreClient::BackingStoreClient):
- (BlackBerry::WebKit::BackingStoreClient::~BackingStoreClient):
- * WebKitSupport/BackingStoreClient.h:
- (BackingStoreClient):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
- 2012-10-15 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Clean up BackingStoreClient (part I)
- https://bugs.webkit.org/show_bug.cgi?id=99327
- Reviewed by Yong Li.
- Now that we won't use the BackingStoreClient code path to scroll inner frames at all
- (instead we use AC layers!), we can remove all "!isMainFrame" code paths.
- No behavior change, since the code path being removed was not in use.
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
- (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
- (BlackBerry::WebKit::BackingStoreClient::viewportSize):
- (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
- (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
- (BlackBerry::WebKit::BackingStoreClient::transformedVisibleContentsRect):
- (BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation):
- 2012-10-13 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Fetch blit rects from a viewport accessor
- https://bugs.webkit.org/show_bug.cgi?id=98581
- RIM PR 173292
- Reviewed by George Staikos.
- Internally reviewed by Arvid Nilsson.
- The long-standing userInterfaceBlittedVisibleContentsRect()
- method in WebPageClient has long been a major annoyance,
- as it returns the source rect for WebKit contents but in
- backingstore pixel coordinates. This makes it not only
- unwieldy but also terribly fragile, especially when
- both pinch zoom and a backingstore re-render both deal
- with the same rectangle. On different threads, even.
- BlackBerry::Platform now exposes a ViewportAccessor
- interface, which can be used to get the various rects
- in document coordinates or target pixel coordinates,
- both being a better choice than the ones dependent
- on an implentation detail.
- This commit makes use of this new functionality.
- Instead of relying on the passed rectangle to contain
- implicit information about the scale factor, we now
- track the scale of each backingstore geometry by making
- a snapshot of the current WebKit-thread scale when the
- geometry is generated. Once the geometry is swapped to
- the front, we can then calculate the remaining
- backingstore-to-viewport transformation in a threadsafe
- way. We now only calculate this if we actually blit from
- backingstore tiles and don't go through a configuration
- of pure accelerated compositing.
- As a result, we are now a lot more robust against
- synchonization issues related to backingstore
- geometry changes. As an additional gimmick, the scale
- is also stored with each tile buffer to doubly secure
- that a tile rendered in one scale is not transferred
- to a different geometry and then rendered there without
- being rerendered at the new scale, even if the rendered
- pixel coordinates are still the same.
- Having per-geometry scale information also opens up
- opportunities to further improve backingstore rendering
- later. For instance, we could pre-render a low-res
- version of the page onto one buffer and combine that one
- with a higher-res array of tiles covering a smaller area.
- Or we could steal some tiles from the front geometry to
- render them at a new scale while a pinch-zoom operation
- is in progress.
- No such thing is implemented in this patch though.
- In adapting/fixing the backingstore visualization
- debug mode and the default background painting in
- renderDirectToWindow(), we also introduce new
- ViewportAccessor subclasses that can subsequently
- be used to replace methods from WebPage and elsewhere.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::scroll):
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
- (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
- (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
- (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- * Api/BackingStore_p.h:
- (BlackBerry):
- (Platform):
- (BlackBerry::WebKit::BackingStoreGeometry::BackingStoreGeometry):
- (BlackBerry::WebKit::BackingStoreGeometry::scale):
- (BlackBerry::WebKit::BackingStoreGeometry::setScale):
- (BackingStoreGeometry):
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::webkitThreadViewportAccessor):
- (WebKit):
- * Api/WebPage.h:
- (Platform):
- * Api/WebPageClient.h:
- (Platform):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- * Api/WebPage_p.h:
- (WebKit):
- (WebPagePrivate):
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::TileBuffer):
- (BlackBerry::WebKit::TileBuffer::isRendered):
- * WebKitSupport/BackingStoreTile.h:
- (TileBuffer):
- (BlackBerry::WebKit::TileBuffer::scale):
- (BlackBerry::WebKit::TileBuffer::setScale):
- * WebKitSupport/BackingStoreVisualizationViewportAccessor.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::BackingStoreVisualizationViewportAccessor):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelContentsSize):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentContentsSize):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelScrollPosition):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentScrollPosition):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelViewportSize):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentViewportSize):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::destinationSurfaceOffset):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::scale):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::state):
- * WebKitSupport/BackingStoreVisualizationViewportAccessor.h: Added.
- (BlackBerry):
- (Platform):
- (WebKit):
- (BackingStoreVisualizationViewportAccessor):
- (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::~BackingStoreVisualizationViewportAccessor):
- * WebKitSupport/WebKitThreadViewportAccessor.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::WebKitThreadViewportAccessor):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentContentsSize):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentScrollPosition):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelViewportSize):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::destinationSurfaceOffset):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::scale):
- * WebKitSupport/WebKitThreadViewportAccessor.h: Added.
- (BlackBerry):
- (Platform):
- (WebKit):
- (WebKitThreadViewportAccessor):
- (BlackBerry::WebKit::WebKitThreadViewportAccessor::~WebKitThreadViewportAccessor):
- 2012-10-11 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] Paused in Inspector, Browser doesn't exit cleanly
- https://bugs.webkit.org/show_bug.cgi?id=97962
- Reviewed by George Staikos.
- Before destroying webpage, close the inspector, so if the JSC is paused it will be resumed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::destroy):
- 2012-10-11 Konrad Piascik <kpiascik@rim.com>
- Web Inspector: node search does not work with elements on touch start listener
- https://bugs.webkit.org/show_bug.cgi?id=95252
- Reviewed by Pavel Feldman.
- Removed calls to InspectorInstrumentation that no didn't work anyway.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2012-10-11 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] makes NavigatorContentUtils work
- https://bugs.webkit.org/show_bug.cgi?id=99022
- Reviewed by Rob Buis.
- Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and
- r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler,
- we need sync up code:
- 1. Add NavigatorContentUtilsClientBlackBerry class.
- 2. use new API provideNavigatorContentUtilsTo.
- No new tests. Covered by existing tests.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::NavigatorContentUtilsClientBlackBerry::NavigatorContentUtilsClientBlackBerry):
- (WebCore::NavigatorContentUtilsClientBlackBerry::registerProtocolHandler):
- (WebCore::NavigatorContentUtilsClientBlackBerry::isProtocolHandlerRegistered):
- (WebCore::NavigatorContentUtilsClientBlackBerry::unregisterProtocolHandler):
- * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.h: Added.
- (WebKit):
- (NavigatorContentUtilsClientBlackBerry):
- (WebCore::NavigatorContentUtilsClientBlackBerry::~NavigatorContentUtilsClientBlackBerry):
- 2012-10-10 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
- https://bugs.webkit.org/show_bug.cgi?id=97397
- Internal PR: 186597.
- Internally reviewed by Yong Li, Joe Mason.
- Reviewed by George Staikos.
- Update WebPage to use new AuthenticationChallengeManager.
- Register page creation/deletion and visibility change to the new
- AuthenticationChallengeManager.
- Initialize AuthenticationChallengeManager in GlobalInitialize() function.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPage::setVisible):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-10-10 Andrew Lo <anlo@rim.com>
- [BlackBerry] Do not perform backing store blit for animations during one-shot drawing synchronization
- https://bugs.webkit.org/show_bug.cgi?id=98944
- Reviewed by Rob Buis.
- Internally reviewed by: Arvid Nilsson.
- Internal PR 220014
- Prevent animations from causing a backing store blit during a
- one-shot drawing synchronization.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- 2012-10-10 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fix crash for detached node when validating selection change.
- https://bugs.webkit.org/show_bug.cgi?id=98926
- Reviewed by Rob Buis.
- PR 220628.
- Guard against detached nodes when generating selection rect.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
- 2012-10-10 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Adjust spell checking location to update after the cursor position is set.
- https://bugs.webkit.org/show_bug.cgi?id=98904
- Reviewed by Rob Buis.
- PR 215172.
- Delay calculation of caret position until it is updated on mouse release
- handling.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 2012-10-10 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Suppress keyboard requests while processing spell checking suggestions unless focus change is occurring..
- https://bugs.webkit.org/show_bug.cgi?id=98903
- Reviewed by Rob Buis.
- PR 221143.
- Suppress keyboard state changes when they are not triggered by
- focus changes.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- * WebKitSupport/InputHandler.h:
- 2012-10-09 Rob Buis <rbuis@rim.com>
- [BlackBerry] Cleanup FatFingers.cpp
- https://bugs.webkit.org/show_bug.cgi?id=98806
- Reviewed by Antonio Gomes.
- Cleanup namespace usage and sync up FatFingers.cpp.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::compareDistanceBetweenPoints):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::checkForClickableElement):
- (BlackBerry::WebKit::FatFingers::checkForText):
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
- 2012-10-09 Antonio Gomes <agomes@rim.com>
- Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
- https://bugs.webkit.org/show_bug.cgi?id=98756
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-10-09 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Need API to control the DNS Prefetching
- https://bugs.webkit.org/show_bug.cgi?id=98713
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::enableDNSPrefetch):
- (WebKit):
- (BlackBerry::WebKit::WebPage::disableDNSPrefetch):
- (BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
- * Api/WebPage.h:
- 2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
- Rename first/second to key/value in HashMap iterators
- https://bugs.webkit.org/show_bug.cgi?id=82784
- Reviewed by Eric Seidel.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
- (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
- (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
- 2012-10-05 Rob Buis <rbuis@rim.com>
- [BlackBerry] Implement TestRunner.setMockDeviceOrientation
- https://bugs.webkit.org/show_bug.cgi?id=98542
- Reviewed by Antonio Gomes.
- PR 120681
- Provide framework for mock device motion.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (toDeviceOrientationClientMock):
- (DumpRenderTreeSupport::setMockDeviceOrientation):
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2012-10-05 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Remove unnecessary html file.
- https://bugs.webkit.org/show_bug.cgi?id=98531
- Reviewed by Yong Li.
- We now just use Source/WebCore/inspector/front-end/inspector.html
- instead.
- * WebCoreSupport/inspectorBB.html: Removed.
- 2012-10-05 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
- https://bugs.webkit.org/show_bug.cgi?id=98517
- PR #137382
- Reviewed by Yong Li.
- We've generalized composited in-region scrolling, originally only applicable
- to block elements, to inner frames (see PR #197093). Past that, we no longer
- need to force repaints of offscreen areas when we finish scrolling, since translating
- the Layer takes care of properly invalidating it. Thus, remove this method.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-10-05 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update default input support style for single line inputs.
- https://bugs.webkit.org/show_bug.cgi?id=98510
- Reviewed by Antonio Gomes.
- PR 219588.
- Update style calculations to eliminate automatic changes
- by default on single line input fields.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::inputStyle):
- 2012-10-04 Simon Fraser <simon.fraser@apple.com>
- Final part of "sync" to "flush" renaming
- https://bugs.webkit.org/show_bug.cgi?id=98430
- Reviewed by Tim Horton.
- Change method names on GraphicsLayer and GraphicsLayerClient that
- refer to "sync" to use the term "flush" instead, to be consistent
- with the rest of the code.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
- * Api/WebOverlay_p.h:
- (WebOverlayPrivateWebKitThread):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/InspectorOverlayBlackBerry.cpp:
- (BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
- * WebKitSupport/InspectorOverlayBlackBerry.h:
- (InspectorOverlay):
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
- * WebKitSupport/SelectionOverlay.h:
- (SelectionOverlay):
- 2012-10-04 Simon Fraser <simon.fraser@apple.com>
- Standardize on "flush" terminology for compositing layer flushing/syncing
- https://bugs.webkit.org/show_bug.cgi?id=98321
- Reviewed by Simon Fraser.
- Rename compositing-related methods that refer to "syncing" to instead
- refer to "flushing".
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-10-03 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
- https://bugs.webkit.org/show_bug.cgi?id=97917
- PR #212920
- Reviewed by Yong Li.
- Internally reviewed by Jacky Jiang.
- Inform the client of transform change so that we avoid
- getting stuck on overscroll.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-10-03 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Implementing the NetworkInfo API for BB port
- https://bugs.webkit.org/show_bug.cgi?id=98273
- Reviewed by Rob Buis.
- Adding new class NetworkInfoClientBlackBerry to implement
- NetworkInfoClient for the BlackBerry port.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/NetworkInfoClientBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::NetworkInfoClientBlackBerry::NetworkInfoClientBlackBerry):
- (WebCore::NetworkInfoClientBlackBerry::startUpdating):
- (WebCore::NetworkInfoClientBlackBerry::stopUpdating):
- (WebCore::NetworkInfoClientBlackBerry::bandwidth):
- (WebCore::NetworkInfoClientBlackBerry::metered):
- (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkChange):
- (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
- * WebCoreSupport/NetworkInfoClientBlackBerry.h: Added.
- (WebKit):
- (WebCore):
- (NetworkInfoClientBlackBerry):
- (WebCore::NetworkInfoClientBlackBerry::~NetworkInfoClientBlackBerry):
- 2012-10-02 Anders Carlsson <andersca@apple.com>
- Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
- https://bugs.webkit.org/show_bug.cgi?id=98217
- Reviewed by Andreas Kling.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
- 2012-10-02 Yong Li <yoli@rim.com>
- [BlackBerry] Prevent window.close() from closing pages that are not opened by JS
- https://bugs.webkit.org/show_bug.cgi?id=98190
- Reviewed by Antonio Gomes.
- RIM PR# 217812.
- Only pages opened by JS can be closed by JS.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::closeWindowSoon):
- 2012-10-01 Brady Eidson <beidson@apple.com>
- Remove the Safari 2 -> Safari 3 icon database import code.
- https://bugs.webkit.org/show_bug.cgi?id=98113
- Reviewed by Maciej Stachowiak.
- Nuke the performImport() IconDatabaseClient method.
- * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
- * WebCoreSupport/IconDatabaseClientBlackBerry.h:
- (IconDatabaseClientBlackBerry):
- 2012-10-01 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
- https://bugs.webkit.org/show_bug.cgi?id=98107
- RIM PR 173292
- Reviewed by George Staikos.
- This method is not referenced anywhere anymore,
- so we should stop requiring it from WebPageClient
- implementations.
- * Api/WebPageClient.h:
- 2012-10-01 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove suppressing of VKB hiding when processing changes.
- https://bugs.webkit.org/show_bug.cgi?id=98023
- Reviewed by Rob Buis.
- PR 215881.
- Allow JS to blur the input field while processing key handling.
- Reviewed Internally by Chris Hutten-Czapski
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- 2012-09-28 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Update the value of window.devicePixelRation when it is set programmatically
- https://bugs.webkit.org/show_bug.cgi?id=97512
- Reviewed by Rob Buis.
- RIM PR 213984
- Set the deviceScaleFactor of the page explicity when the
- devicePixelRatio is changed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
- Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
- https://bugs.webkit.org/show_bug.cgi?id=97547
- Reviewed by Adam Barth.
- Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
- inside WebCore::FrameLoaderClientBlackBerry::canShowMIMEType().
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
- 2012-09-28 Rob Buis <rbuis@rim.com>
- [BlackBerry] Hard to tap on x to clear a text field
- https://bugs.webkit.org/show_bug.cgi?id=97923
- Reviewed by Antonio Gomes.
- Allow the shadow element for 'X' to be clickable and do not prefer
- shadow content-editable div's over the 'X'.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- 2012-09-28 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Extend composited in-region scrolling to iframes/frames
- https://bugs.webkit.org/show_bug.cgi?id=97922
- PR #197093
- Reviewed by Yong Li.
- Internaly reviewed by Arvid Nilsson.
- Add support for composited scrolling in a inner frame level:
- 1) When creating an InRegionScrollableArea, for a inner scrollable frame,
- cache and camouflag the appropriated scroll layer (i.e. RenderLayerCompositor::scrollLayer);
- 2) Differentiate what type of scroll target we are at: BlockElement or
- InnerFrame;
- 3) Change the signature of the public methods to support and newly passed
- in ScrollTarget parameter;
- As a side note, this parameter is needed in order to know what class to static_cast
- the GraphicsLayer::client to: in the case of a composited scrollable inner frame, the client
- is a RenderLayerCompositor; in case of a composited scrollable block element, the client
- is a RenderLayerBacking.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- * Api/InRegionScroller.h:
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (WebCore::ChromeClientBlackBerry::allowedCompositingTriggers):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-09-28 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Exiting fullscreen does not set the correct scroll position
- https://bugs.webkit.org/show_bug.cgi?id=97917
- PR #212920
- Reviewed by Yong Li.
- Internally reviewed by Jacky Jiang.
- Restore the zoom level and scroll position at the time when know
- the fullscreen exit routine has ended (i.e. in ::setViewportSize
- instead of ::exitFullScreenForElement).
- Also patch caches now the scroll position instead of only the
- "x scroll position.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-09-28 Kent Tamura <tkent@chromium.org>
- Clean up Localizer-related functions
- https://bugs.webkit.org/show_bug.cgi?id=97899
- Reviewed by Kentaro Hara.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::SelectPopupClient::localizer): ditto.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::localizer): ditto.
- 2012-09-28 Genevieve Mak <gmak@rim.com>
- [BLACKBERRY] Add isVisible method to WebTapHighlight
- https://bugs.webkit.org/show_bug.cgi?id=97915
- Reviewed by Rob Buis.
- Reviewed Internally By Andrew Lo
- The isVisible() method lets us avoid dispatching to the webkit thread
- if the tap highlight isn't visible.
- Always clear tap highlight on Touch up when converting Touch Events
- to Mouse Events.
- * Api/WebTapHighlight.h:
- * WebKitSupport/DefaultTapHighlight.h:
- (BlackBerry::WebKit::DefaultTapHighlight::isVisible):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-09-28 Andrew Lo <anlo@rim.com>
- [BlackBerry] Should suspend page's scripted animations when WebPage is invisible
- https://bugs.webkit.org/show_bug.cgi?id=97856
- Reviewed by Antonio Gomes.
- Suspend page animations when setting WebPage invisible, resume when visible.
- Internal PR212788.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- 2012-09-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
- https://bugs.webkit.org/show_bug.cgi?id=97674
- Reviewed by Rob Buis.
- A new API was added to BlackBerry::Platform::Graphics for destroying
- thread-specific data generated on the compositing thread when we blit
- buffers. The buffers are otherwise created and destroyed on the WebKit
- thread, which doesn't give platform any opportunity to destroy the
- thread-specific data.
- This patch adds calls to the new API to avoid leaking resources.
- Reviewed internally by Jakob Petsovits and Filip Spacek.
- PR 214644
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
- (BlackBerry::WebKit::SurfacePool::lockTileRenderingSurface):
- (BlackBerry::WebKit::SurfacePool::releaseTileRenderingSurface):
- (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
- (BlackBerry::WebKit::SurfacePool::createBuffers):
- (BlackBerry::WebKit::SurfacePool::releaseBuffers):
- 2012-09-27 Kent Tamura <tkent@chromium.org>
- Use Localizer in PagePopupController
- https://bugs.webkit.org/show_bug.cgi?id=97862
- Reviewed by Hajime Morita.
- We need to implement PagePopupClient::localizer. These clients know the
- host elements. Localizer implementations get Localizer objects from the
- owner documents of the elements for the browser locale.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::localizer): Added.
- * WebCoreSupport/ColorPickerClient.h:
- (ColorPickerClient): Declare "localizer."
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::SelectPopupClient::localizer): Added.
- * WebCoreSupport/DatePickerClient.h:
- (DatePickerClient): Declare "localizer."
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::localizer): Added.
- * WebCoreSupport/SelectPopupClient.h:
- (SelectPopupClient): Declare "localizer."
- 2012-09-27 Charles Wei <charles.wei@torchmobile.com.cn>
- Empty URL gets through to acceptNavigationRequest()
- https://bugs.webkit.org/show_bug.cgi?id=97076
- Reviewed by George Staikos.
- Invalid URLs in iframe src results in an empty URL in platform request, we should reject
- such URL as early as we identify it.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- 2012-09-26 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Remove blitContents() in favor of blitVisibleContents().
- https://bugs.webkit.org/show_bug.cgi?id=97718
- Reviewed by Antonio Gomes.
- After the last calling sites of blitContents() have
- been removed or reworked, the actual method itself
- can now retire. All blits now go through
- blitVisibleContents(). The knowledge that we always
- blit the full visible surface can facilitate further
- optimizations; we will get to that in time.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
- 2012-09-26 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
- https://bugs.webkit.org/show_bug.cgi?id=97684
- Reviewed by Rob Buis.
- Update padding in ensureFocusTextElementVisible to be DPI
- independent and relative to the current zoom level.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-09-25 Genevieve Mak <gmak@rim.com>
- Fat Fingers doesn't work on non-scrollable pages.
- PR #209609
- https://bugs.webkit.org/show_bug.cgi?id=97607
- Reviewed by Antonio Gomes.
- Only bypass Fat Fingers and use the actual touch point if its specifically
- requested and the page has a mouse move listener or if using the Touch Event
- Mode meta-tag.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-09-25 Rob Buis <rbuis@rim.com>
- [BlackBerry] Make COMPUTED_GOTO part of the HAVE section
- https://bugs.webkit.org/show_bug.cgi?id=97600
- Reviewed by Yong Li.
- Also get rid of COMPUTED_GOTO_INTERPRETER and add COMPUTED_GOTO_OPCODES.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutDataHaveFeatures.in:
- 2012-09-25 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
- https://bugs.webkit.org/show_bug.cgi?id=97595
- Reviewed by Antonio Gomes.
- PR 188751.
- Avoid jumpiness when both a scroll and zoom are required to
- move an input field into focus by suspending the backingstore.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-09-25 Pratik Solanki <psolanki@apple.com>
- Remove HAVE_SBRK since we never set use_sbrk to true
- https://bugs.webkit.org/show_bug.cgi?id=97525
- <rdar://problem/12363601>
- Reviewed by Geoffrey Garen.
- * WebCoreSupport/AboutDataHaveFeatures.in: Remove SBRK from list.
- 2012-09-25 Beth Dakin <bdakin@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=95397
- Need to merge didFirstVisuallyNonEmptyLayout and
- didNewFirstVisuallyNonEmptyLayout
- -and corresponding-
- <rdar://problem/10791680>
- Reviewed by Sam Weinig.
- Remove dispatchDidFirstLayout,
- dispatchDidFirstVisuallyNonEmptyLayout, and
- dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
- is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- It is now necessary to opt into getting any of the
- "layout milestone" notifications.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-09-25 Mike Fenton <mifenton@rim.com>
- [BlackBerry] When zooming into an input field take the current zoom level into account.
- https://bugs.webkit.org/show_bug.cgi?id=97594
- Reviewed by Antonio Gomes.
- PR 188751.
- Perform the zoom action prior to scroll to avoid breaking scrolling
- rules. Take the current scale into account when calculating the
- zoom factor.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-09-25 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Handling required for multiple consecutive whitespace
- https://bugs.webkit.org/show_bug.cgi?id=97575
- Reviewed by Rob Buis.
- PR211670
- Need specific handling in the case where we have multiple
- consecutive whitespaces which exceeds our character limit. This
- breaks some of the functionality employed with the visible_units
- methods used here to tranverse the text.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
- (DOMSupport):
- (BlackBerry::WebKit::DOMSupport::isEmptyRangeOrAllSpaces):
- * WebKitSupport/DOMSupport.h:
- (WebCore):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckBlock):
- (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
- 2012-09-24 Mark Lam <mark.lam@apple.com>
- Deleting the classic interpreter and cleaning up some build options.
- https://bugs.webkit.org/show_bug.cgi?id=96969.
- Reviewed by Geoffrey Garen.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-09-24 Benjamin Poulain <bpoulain@apple.com>
- Fix Geolocation error reporting in the test support
- https://bugs.webkit.org/show_bug.cgi?id=97386
- Reviewed by Sam Weinig.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2012-09-24 Otto Derek Cheung <otcheung@rim.com>
- [BlackBerry] Reverting implementation for 407 error pages
- https://bugs.webkit.org/show_bug.cgi?id=97455
- Reviewed by Rob Buis.
- Revert "[BlackBerry] Really fix bug 95488 that user can get the
- authentication challenge dialog while the other tab has focus."
- https://bugs.webkit.org/show_bug.cgi?id=97348
- This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPage::setVisible):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-09-24 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add cookie database API
- https://bugs.webkit.org/show_bug.cgi?id=97102
- Reviewed by Antonio Gomes.
- The cookie database is exposed through WebCookieJar, which has only two
- methods: cookies() and setCookies().
- Also add a new WebString::fromUTF8 overload that takes a const char*
- and a length, in order to avoid a strlen call when converting from
- other string classes to WebString. This is useful for callers of the
- new cookie API when converting cookies to WebString.
- Reviewed internally by Otto D. Cheung.
- PR 209282
- * Api/WebCookieJar.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::WebCookieJar::WebCookieJar):
- (BlackBerry::WebKit::WebCookieJar::cookies):
- (BlackBerry::WebKit::WebCookieJar::setCookies):
- * Api/WebCookieJar.h: Added.
- (WebKit):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPage::cookieJar):
- (WebKit):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPage_p.h:
- (WebKit):
- (WebPagePrivate):
- * Api/WebString.cpp:
- (BlackBerry::WebKit::WebString::fromUtf8):
- (WebKit):
- * Api/WebString.h:
- 2012-09-21 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
- https://bugs.webkit.org/show_bug.cgi?id=97348
- Internal PR: 186597.
- Internally reviewed by Yong Li, Joe Mason.
- Reviewed by Yong Li.
- Update WebPage to use new AuthenticationChallengeManager.
- Register page creation/deletion and visibility change to the new
- AuthenticationChallengeManager.
- Initialize AuthenticationChallengeManager in GlobalInitialize() function.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPage::setVisible):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-09-21 Charles Wei <charles.wei@torchmobile.com.cn>
- Wrong seperator for viewport meta in Popup scripts
- https://bugs.webkit.org/show_bug.cgi?id=97313
- Reviewed by Yong Li.
- The valid seperator for viewport meta is ',' instead of ';'.
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::generateHTML):
- 2012-09-21 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Remove obsolete compositing surface code
- https://bugs.webkit.org/show_bug.cgi?id=97314
- Reviewed by Antonio Gomes.
- The removed code allowed rendering of sublayers to a separate offscreen
- surface.
- Now that we composite root layer and all sublayers to the window
- surface, this code is not needed anymore. In addition, we save some
- memory by not allocating the unused offscreen surface.
- PR 208038.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
- * WebKitSupport/BackingStoreCompositingSurface.h: Removed.
- * WebKitSupport/GLES2Context.cpp:
- (BlackBerry::WebKit::GLES2Context::buffer):
- (BlackBerry::WebKit::GLES2Context::surfaceSize):
- (BlackBerry::WebKit::GLES2Context::swapBuffers):
- * WebKitSupport/GLES2Context.h:
- (GLES2Context):
- * WebKitSupport/SurfacePool.cpp:
- (WebKit):
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::initialize):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-09-20 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
- https://bugs.webkit.org/show_bug.cgi?id=96077
- Reviewed by Pavel Feldman.
- A minor modification to make the inspecting results more accurate.
- Internally reviewd by Arvid, Robin.C, and Konrad.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::render):
- 2012-09-19 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
- https://bugs.webkit.org/show_bug.cgi?id=96362
- Reviewed by Rob Buis.
- Make the FrameLoaderClient use credential storage according to the macro
- BLACKBERRY_CREDENTIAL_PERSIST
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-09-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] After zooming into an input field, zoom out when focus is lost.
- https://bugs.webkit.org/show_bug.cgi?id=97128
- Reviewed by Rob Buis.
- When the page has automatically zoomed in for input
- focus, unzoom it when input focus is lost or keyboard hidden.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-09-19 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Clean up the SpellingLog output
- https://bugs.webkit.org/show_bug.cgi?id=97129
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- 2012-09-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add SpellingLog for spell checking options request.
- https://bugs.webkit.org/show_bug.cgi?id=97125
- Reviewed by Rob Buis.
- Add spell checking log to indicate the calculated
- text position for spell checking option requests.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- 2012-09-19 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Add function playerId() in class PageClientBlackBerry
- https://bugs.webkit.org/show_bug.cgi?id=97099
- Reviewed by Yong Li.
- Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
- and replaced the implementation of FrameLoaderClientBlackBerry::playerId().
- Internally reviewed by Charles Wei.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::playerID):
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::playerId):
- 2012-09-19 Abbas Sherawala <asherawala@rim.com>
- [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
- Added a missing 'if' statement.
- https://bugs.webkit.org/show_bug.cgi?id=96925
- PR #180866
- Internally Reviewed by Antonio Gomes.
- Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)
- Reviewed by Antonio Gomes.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 2012-09-18 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
- https://bugs.webkit.org/show_bug.cgi?id=97033
- Reviewed by Rob Buis.
- Using these preferred public methods (the latter has a note to be made private) ensures that
- the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
- and spellCheckingRequestCancelled.
- Internally reviewed by Mike Fenton.
- By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
- SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::getSpellChecker):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-09-18 Jessica Cao <jecao@rim.com>
- [BlackBerry] Date picker isn't inputting after 'OK'
- https://bugs.webkit.org/show_bug.cgi?id=97031
- PR208052
- Reviewed by Rob Buis
- Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::setValueAndClosePopup):
- 2012-09-18 Yong Li <yoli@rim.com>
- [BlackBerry] Popup page should reference the client with a weak pointer
- https://bugs.webkit.org/show_bug.cgi?id=97028
- Reviewed by Rob Buis.
- RIM PR# 209847.
- Internally reviewed by Mike Fenton.
- Store the pointer in a ref-coutned shared object, and clear the pointer
- when the client is going to be destroyed, so it won't be accessed by
- the JS function afterwards.
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
- (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
- (WebCore::PagePopupBlackBerry::init):
- (WebCore::setValueAndClosePopupCallback):
- (WebCore::popUpExtensionFinalize):
- (WebCore::PagePopupBlackBerry::installDOMFunction):
- (WebCore::PagePopupBlackBerry::closePopup):
- * WebCoreSupport/PagePopupBlackBerry.h:
- (PagePopupBlackBerry):
- (SharedClientPointer):
- (WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
- (WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
- (WebCore::PagePopupBlackBerry::SharedClientPointer::get):
- 2012-09-18 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
- https://bugs.webkit.org/show_bug.cgi?id=96750
- Reviewed by Antonio Gomes.
- The region of interest mechanism replaces the scrolling/zooming
- functionality in InputHandler::ensureFocusTextElementVisible().
- We introduce a new fine-grained setting for the various adjustment
- modes. The WebKit embedder can disable all scroll types in favor of the
- region of interest mechanism by using the new setting.
- PR #208387
- Reviewed internally by Mike Fenton.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::configPage):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/InputHandler.h:
- 2012-09-17 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Remove dysfunctional zoom blit in setViewportSize().
- https://bugs.webkit.org/show_bug.cgi?id=96954
- PR 178411
- Reviewed by Antonio Gomes.
- The blitContents() call removed by this patch used to
- be part of scheduleZoomAboutPoint(). Its goal was to
- display a preview of the zoomed contents, primarily
- when auto-zoomed after rotation. Nested inside a pair
- of screen suspend/resume calls, it has been a pointless
- no-op for a while.
- Antonio's recent change to remove scheduleZoomAboutPoint()
- and call zoomAboutPoint() from setViewportSize() directly
- (the only call site) obsoletes the call completely.
- The zoomAboutPoint() call itself will cause a re-render
- and blit right away, so we don't care about any preview.
- zoomAboutPoint() will also take care of the necessary
- screen/backingstore suspension.
- The result is a vastly simplified block of code.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-09-17 Antonio Gomes <agomes@rim.com>
- [BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
- https://bugs.webkit.org/show_bug.cgi?id=96927
- PR #180866
- Reviewed by Yong Li.
- Suspend backing store and screen updates while entering fullscreen,
- and only resume at the end, when viewport is resized.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- 2012-09-17 Rob Buis <rbuis@rim.com>
- [BlackBerry] Fix compile problems in WebKit/blackberry
- https://bugs.webkit.org/show_bug.cgi?id=96926
- Reviewed by Antonio Gomes.
- This code is slightly out of date and so will not compile, fix it.
- * WebCoreSupport/BatteryClientBlackBerry.cpp:
- (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
- * WebCoreSupport/BatteryClientBlackBerry.h:
- (WebKit):
- * WebCoreSupport/CredentialTransformData.h:
- * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
- (DeviceOrientationClientBlackBerry::onOrientation):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
- (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- 2012-09-17 Antonio Gomes <agomes@rim.com>
- [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
- https://bugs.webkit.org/show_bug.cgi?id=96925
- [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
- PR #180866
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
- Well more atomic than it was before, with regards to a mix of accelerated and
- non-accelerated compositing content".
- I.e. by committing the root layer (if needed) when resuming the Backing
- Store, we call blitVisibleContents right way, so we are actually shortcutting when
- AC content will get on screen.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 2012-09-17 Peter Wang <peter.wang@torchmobile.com.cn>
- [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
- https://bugs.webkit.org/show_bug.cgi?id=96077
- Reviewed by Rob Buis.
- Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
- render message to record one time of page's update.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
- * Api/BackingStore_p.h:
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::render):
- 2012-09-17 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Support copying image data in WebOverlay.
- https://bugs.webkit.org/show_bug.cgi?id=96684
- RIM PR 195444
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- The publicly exposed WebOverlay class provides a method
- setContentsToImage() to assign a pointer to pixel data,
- which is later used to provide texture data for the
- underlying compositing layer. This works well for static
- images that stay in memory and never change, but not
- so well for images with changing contents or where the
- image data is being reassigned from different image
- sources that are not constantly kept around in memory.
- Due to the delayed upload and delayed fetching of
- EGLImage data by the GPU, we shouldn't assume the caller
- to know how long the image should be retained. Instead,
- we should offer another method of setting image data
- that takes ownership of the pixel data.
- This patch adds an option to setContentsToImage() that
- copies the passed pixel data and doesn't destroy it
- until both the texture is destroyed and the image
- contents are changed. Using this method, the caller can
- withdraw the passed pixel array right after the
- setContentsToImage() call without consequences.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlay::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
- (WebKit):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- * Api/WebOverlay.h:
- * Api/WebOverlay_p.h:
- (WebOverlayPrivate):
- (WebOverlayPrivateWebKitThread):
- (WebOverlayLayerCompositingThreadClient):
- (WebOverlayPrivateCompositingThread):
- 2012-09-14 Dana Jansens <danakj@chromium.org>
- Minimize collisions when hashing pairs
- https://bugs.webkit.org/show_bug.cgi?id=96022
- Reviewed by Adrienne Walker.
- Use WTF::pairIntHash() to hash a pair of integers.
- * WebKitSupport/TileIndexHash.h:
- 2012-09-14 Genevieve Mak <gmak@rim.com>
- Always send mouse events on pages that don't scroll even if there
- is no mouse move listener attatched.
- PR #208228
- https://bugs.webkit.org/show_bug.cgi?id=96800
- Reviewed by Antonio Gomes.
- Reviewed Internally By Antonio Gomes.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-09-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update the minimum zoom scale when focusing an input field.
- https://bugs.webkit.org/show_bug.cgi?id=96789
- Reviewed by Antonio Gomes.
- PR 188751.
- Increase the minimum font fix and base it on mm instead of pixels.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-09-13 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Remove the ability to schedule a zoom about point call.
- https://bugs.webkit.org/show_bug.cgi?id=96696
- [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
- PR #180866
- Reviewed by Rob Buis.
- Internally reviewed by Jacky Jiang and Arvid Nilsson.
- Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
- Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
- and in the end call zoomAboutPoint directly.
- Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
- zoom about point be async.. That was a hack I did for BB6, back when we were doing everything on the WK
- thread and needed manual time slicing betwren rendering and user interaction."
- The bigger goal though is to be able to remove screen glitches while entering/leaving
- fullscreen mode: since we could accurately use the count-based suspend/resume backing
- store mechanism to prevent it.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-09-14 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add renderTreeAsText API to WebPage
- https://bugs.webkit.org/show_bug.cgi?id=96629
- Reviewed by Antonio Gomes.
- This will be used for automated testing.
- PR #198595
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::renderTreeAsText):
- (WebKit):
- * Api/WebPage.h:
- 2012-09-13 Rob Buis <rbuis@rim.com>
- [BlackBerry] Cleanup AboutDataEnableFeatures.in
- https://bugs.webkit.org/show_bug.cgi?id=96695
- Reviewed by Antonio Gomes.
- Remove unused features.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-09-13 Rob Buis <rbuis@rim.com>
- [BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
- https://bugs.webkit.org/show_bug.cgi?id=96689
- Reviewed by Antonio Gomes.
- Rename to InspectorClientBlackBerry to avoid include problems.
- * WebCoreSupport/InspectorClientBlackBerry.h:
- * WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
- (WebKit):
- (BlackBerry::WebKit::InspectorOverlay::create):
- (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
- (BlackBerry::WebKit::InspectorOverlay::paintContents):
- (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
- (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
- (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::clear):
- (BlackBerry::WebKit::InspectorOverlay::update):
- * WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
- (WebCore):
- (WebKit):
- (InspectorOverlay):
- (InspectorOverlayClient):
- (BlackBerry::WebKit::InspectorOverlay::setClient):
- (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
- 2012-09-13 Antonio Gomes <agomes@rim.com>
- Unreviewed, warning fix left over from r128456 (bug 96645)
- * Api/InRegionScroller.cpp:
- (WebKit):
- 2012-09-13 Genevieve Mak <gmak@rim.com>
- Continue to send mouse move events to a non-scrollable page
- even if they are not consumed.
- PR #207024
- https://bugs.webkit.org/show_bug.cgi?id=96655
- Reviewed by Antonio Gomes.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::isMainFrameScrollable):
- (WebKit):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-09-13 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
- https://bugs.webkit.org/show_bug.cgi?id=96660
- Reviewed by Antonio Gomes.
- PR: 207884
- According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
- bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
- RenderBox's scroll height equals the client height and the scroll width
- equals the client width. Otherwise, we will miss the conditions.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
- 2012-09-13 Jessica Cao <jecao@rim.com>
- [BlackBerry] Page Popup for Month is non-functional.
- https://bugs.webkit.org/show_bug.cgi?id=96651
- Reviewed by Rob Buis.
- Hook up support for Month popup.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::generateHTML):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- 2012-09-13 Antonio Gomes <agomes@rim.com>
- [BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
- https://bugs.webkit.org/show_bug.cgi?id=96645
- PR #207307
- Reviewed by George Staikos.
- We use canScrollRenderBox to promote the layer as scrollable instead
- of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
- We should assert against the former as well.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
- * Api/InRegionScroller_p.h:
- (WebCore):
- (InRegionScrollerPrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r127876.
- http://trac.webkit.org/changeset/127876
- https://bugs.webkit.org/show_bug.cgi?id=96600
- mouse click doesn't work for spin button if spin button in
- iframe (Requested by yosin on #webkit).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::nodeAtPoint):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2012-09-12 Sami Kyostila <skyostil@google.com>
- Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
- https://bugs.webkit.org/show_bug.cgi?id=96251
- Reviewed by Simon Fraser.
- Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
- the feature it controls.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-09-11 Antonio Gomes <agomes@rim.com>
- [BlackBerry] add a way to overscroll non-overflown content
- https://bugs.webkit.org/show_bug.cgi?id=96331
- PR #195305
- Reviewed by Yong Li.
- Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
- of checking a custom HTML5 attribute.
- No behavioural change. Mostly a rework of r128142.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::canScrollRenderBox):
- 2012-09-11 Rob Buis <rbuis@rim.com>
- [BlackBerry] make pickers/dialogs use appendLiteral
- https://bugs.webkit.org/show_bug.cgi?id=96424
- Reviewed by Antonio Gomes.
- PR 204032
- Other pickers were updated in r128204.
- * WebCoreSupport/ColorPickerClient.cpp:
- (WebCore::ColorPickerClient::generateHTML):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::generateHTML):
- 2012-09-11 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Fix history navigation for error pages.
- https://bugs.webkit.org/show_bug.cgi?id=96410
- Reviewed by Rob Buis.
- Fix how history navigation handles restoring view state when navigating between error pages.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-09-11 Jinwoo Song <jinwoo7.song@samsung.com>
- Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places
- https://bugs.webkit.org/show_bug.cgi?id=96344
- Reviewed by Benjamin Poulain.
- Use StringBuilder::appendNumber() instead of String::number(). Also deploy
- StringBuilder::appendLiteral() instead of String::append() in the surrounding code.
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::generateHTML):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-09-11 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread
- https://bugs.webkit.org/show_bug.cgi?id=96318
- Reviewed by Antonio Gomes.
- PR: 204066
- Dangling pointers were accessed in UI thread, as the actual InRegion
- scrollable areas of WebKit side had been destroyed before that in
- WebKit thread after UI thread set scrolling to false.
- Notify the client side to clear InRegion scrollable areas before we
- destroy them in WebKit side.
- Internally reviewed by Gen Mak and George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
- * Api/WebPageClient.h:
- 2012-09-11 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
- https://bugs.webkit.org/show_bug.cgi?id=96394
- Reviewed by Rob Buis.
- Suppress the VKB notification when the touch event
- is a spell checking request.
- PR 192925.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-09-11 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Colour Dialog popup request should return proper state.
- https://bugs.webkit.org/show_bug.cgi?id=96392
- Reviewed by Rob Buis.
- Return proper state from openColorPopup dependent on
- whether the popup actually opened.
- Reviewed Internally by Chris Hutten-Czapski
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openColorPopup):
- 2012-09-11 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Take account for single words that exceed our client character limit
- https://bugs.webkit.org/show_bug.cgi?id=96389
- Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
- This was failing if a single word was longer than our maximum allowed limit.
- Internally reviewed by Mike Fenton.
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (WebKit):
- (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
- 2012-09-11 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] SelectionHandler drops caret change notifications
- https://bugs.webkit.org/show_bug.cgi?id=96378
- Reviewed by Antonio Gomes.
- The selection handler deliberately drops caret change notifications
- while the input handler is processing changes, to avoid displaying
- intermediate state during a complex change.
- However, this meant that the client was never informed of the final
- caret position.
- Fixed by notifying client about caret change after processing ends, if
- one or more caret change notifications were dropped during processing.
- PR #205073
- Reviewed internally by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setProcessingChange):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
- (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2012-09-10 Antonio Gomes <agomes@rim.com>
- [BlackBerry] add a way to overscroll non-overflown content
- https://bugs.webkit.org/show_bug.cgi?id=96331
- [UxD] Vertical lists should always be scrollable
- PR #195305
- Reviewed by Yong Li.
- Internally reviewed by Gen Mak.
- Check if the RenderLayer is composited / hardware acceleratable prior to
- check if its contents overflows. If that is the case, check if
- our custom data-blackberry-force-overscroll is present.
- That makes it possible for us to align to UX requirements: settings
- and CCM panels should be always scrollable.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::canScrollRenderBox):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-09-10 Genevieve Mak <gmak@rim.com>
- Change -data-blackberry-webworks-context to -data-webworks-context
- because not all webworks apps are blackberry apps.
- https://bugs.webkit.org/show_bug.cgi?id=96297
- Reviewed by Antonio Gomes.
- PR #193726
- Rubber Stamped interally by Mike Fenton.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::webWorksContext):
- 2012-09-09 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Fix flicker due to introduction of the fence extension.
- https://bugs.webkit.org/show_bug.cgi?id=96207
- Reviewed by George Staikos.
- Don't immediately add fence to garbage list, so it is destroyed
- after only one swap, for a set of tiles just because one tile in
- the set gets a new fence, the old fence may still not be signalled
- and before rendering the other tiles in the set we have to wait for it.
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::Fence::~Fence):
- (WebKit):
- * WebKitSupport/BackingStoreTile.h:
- (WebKit):
- (Fence):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- (WebKit):
- (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-09-08 Max Feil <mfeil@rim.com>
- [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
- https://bugs.webkit.org/show_bug.cgi?id=96027
- Reviewed by Antonio Gomes.
- The changes for bug 87337 (landed as trunk svn revision 119119)
- introduced a bug. The same conditions are not checked on enter
- fullscreen vs. exit. Web sites such as http://videojs.com
- and youtube's mobile HTML5 player make the div container
- of the video element go fullscreen. This is allowed in
- WebPagePrivate::enterFullScreenForElement() but disallowed in
- WebPagePrivate::exitFullScreenForElement(). I am fixing this by
- allowing containers of video elements to exit fullscreen.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- 2012-09-07 Ming Xie <mxie@rim.com>
- [BlackBerry] Remove browser from the build info page
- https://bugs.webkit.org/show_bug.cgi?id=96162
- Reviewed by George Staikos.
- Internal reviewed by Jeff Rogers.
- WebKit build should not have the build info for browser which is
- built on top of webkit.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::buildPage):
- 2012-09-07 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Initialize caret rectangle with invalid location
- https://bugs.webkit.org/show_bug.cgi?id=96011
- Reviewed by Rob Buis.
- In SelectionHandler::selectionPositionChanged() method, startCaret and
- endCaret are used to notify clients about new caret positions. This patch
- initializes startCaret and endCaret with location(-1. -1), and keeps them
- empty before they are assigned to valid values. This would help for other
- classes to check validity of the caret correctly.
- Internal reviewed by Mike Fenton.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::adjustCaretRects):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2012-09-07 Lianghui Chen <liachen@rim.com>
- [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
- https://bugs.webkit.org/show_bug.cgi?id=95488
- PR: 186597.
- Internally reviewed by Joe Mason.
- Reviewed by Yong Li.
- Use new AuthenticationChallengeClient interface to make authentication
- challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
- other module that will use HTTP authentication. WebPage itself still use
- synchronous authentication though. Switching to asynchronous authentication
- in WebPage will require bigger platform layer change and not very necessary
- at the moment for this bug.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- 2012-09-07 Rob Buis <rbuis@rim.com>
- [BlackBerry] Remove feature about:cache/disable and about:cache/enable
- https://bugs.webkit.org/show_bug.cgi?id=95820
- Reviewed by Yong Li.
- Fix warning that was caused by r127680.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::cachePage):
- 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
- Simplify hitTestResultAtPoint and nodesFromRect APIs
- https://bugs.webkit.org/show_bug.cgi?id=95720
- Reviewed by Antonio Gomes.
- Update calls to new API.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::nodeAtPoint):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2012-09-07 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Rendering issue after rotation
- https://bugs.webkit.org/show_bug.cgi?id=96094
- PR #201930
- Reviewed by George Staikos.
- The cause of the rendering issue is that the BackingStore tiles
- are not reset after layout. This is a regression of r125680, which
- overwrites a local variable that are used later in the function.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-09-06 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Implement a color picker
- https://bugs.webkit.org/show_bug.cgi?id=96001
- Reviewed by Rob Buis.
- Add files for color picker, replace old hook to AIR color picker.
- * WebCoreSupport/ColorPickerClient.cpp: Added.
- (WebCore):
- (WebCore::ColorPickerClient::ColorPickerClient):
- (WebCore::ColorPickerClient::~ColorPickerClient):
- (WebCore::ColorPickerClient::generateHTML):
- (WebCore::ColorPickerClient::closePopup):
- (WebCore::ColorPickerClient::contentSize):
- (WebCore::ColorPickerClient::htmlSource):
- (WebCore::ColorPickerClient::setValueAndClosePopup):
- (WebCore::ColorPickerClient::didClosePopup):
- (WebCore::ColorPickerClient::writeDocument):
- * WebCoreSupport/ColorPickerClient.h: Added.
- (WebKit):
- (WebCore):
- (ColorPickerClient):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openColorPopup):
- 2012-09-06 Genevieve Mak <gmak@rim.com>
- Add data-blackberry-webworks-context attribute and set the custom context when
- getting context.
- https://bugs.webkit.org/show_bug.cgi?id=95993
- Reviewed by Antonio Gomes.
- PR #193726
- Reviewed Internally by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- - Check for custom WebWorks context and add it if there.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::webWorksContext):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- - Add a method that checks a given element for the data-webworks-context
- attribute and returns its value if present.
- 2012-09-06 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Allow overscroll to composited scroll layers
- https://bugs.webkit.org/show_bug.cgi?id=95998
- PR #195305
- Reviewed by Rob Buis.
- Internally reviewed by Gen Mak.
- No need to reset the overscroll limit factor at creation to 0.
- It is already 0 by default, and later on the client sets the
- appropriated value.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-09-05 Sam Weinig <sam@webkit.org>
- Part 2 of removing PlatformString.h, remove PlatformString.h
- https://bugs.webkit.org/show_bug.cgi?id=95931
- Reviewed by Adam Barth.
- Remove PlatformString.h
- * Api/DumpRenderTreeClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/InspectorClientBlackBerry.h:
- * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
- * WebKitSupport/AboutData.h:
- 2012-09-05 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry] Remove feature about:cache/disable and about:cache/enable
- https://bugs.webkit.org/show_bug.cgi?id=95820
- Reviewed by Rob Buis.
- Remove this feature since we need to add a button in settings.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::cachePage):
- 2012-09-05 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove deprecated dialog connections.
- https://bugs.webkit.org/show_bug.cgi?id=95868
- Reviewed by Rob Buis.
- PR 187481.
- Remove deprecated logic for unsupported
- Dialog types.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- (BlackBerry::WebKit::InputHandler::openColorPopup):
- 2012-09-05 George Staikos <staikos@webkit.org>
- [BlackBerry] Assignment operators missing self-check
- https://bugs.webkit.org/show_bug.cgi?id=95774
- Reviewed by Rob Buis.
- Add a test for self-assignment.
- * Api/WebAnimation.cpp:
- (BlackBerry::WebKit::WebAnimation::operator=):
- * Api/WebString.cpp:
- (BlackBerry::WebKit::WebString::operator=):
- 2012-09-05 Leo Yang <leoyang@rim.com>
- [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
- https://bugs.webkit.org/show_bug.cgi?id=95897
- Reviewed by Antonio Gomes.
- Bail out the loop early if one of the not-rendered rectangle is
- not current regular render job.
- No behavior change, just code optimization.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
- 2012-09-05 Benjamin C Meyer <bmeyer@rim.com>
- [BlackBerry] JavaScriptVariant can crash when operator= is called with itself
- https://bugs.webkit.org/show_bug.cgi?id=95859
- Reviewed by George Staikos.
- * Api/JavaScriptVariant.cpp:
- (BlackBerry::WebKit::JavaScriptVariant::operator=):
- When JavaScriptVariant contains a string and operator= is
- called with itself the memory will be free'd in 'this' and
- then a copy will be attempted from 'that' resulting in a crash.
- 2012-09-05 Leo Yang <leoyang@rim.com>
- [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
- https://bugs.webkit.org/show_bug.cgi?id=95870
- Reviewed by George Staikos.
- Reviewed internally by Jacky Jiang.
- Use the new zoom to fit scale if the page was zoomed to fit initial scale
- When a page is reloaded the layout size may be changed. So the contents
- size on which the initial scale depends may be changed. Use the new initial
- scale in this case to make sure the page will be zoomed to correct scale.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-09-05 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Do not release shared backingstore memory prematurely
- https://bugs.webkit.org/show_bug.cgi?id=95841
- PR #202517
- Reviewed by George Staikos.
- The BackingStore memory is shared by all web pages. We should check if
- the current backingStore is active before create/release this shared memory.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
- (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
- 2012-09-05 Andy Chen <andchen@rim.com>
- [BlackBerry] Implement number of matches and current active match index for find-on-page
- https://bugs.webkit.org/show_bug.cgi?id=95801
- Reviewed by Antonio Gomes.
- - Calculate current match index for find-on-page
- - Notify client when number of matches and current match index update.
- PR 162090 162091.
- Internally reviewed by Mike Fenton and Joe Mason
- * Api/WebPageClient.h:
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
- (InPageSearchManager::DeferredScopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
- (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
- * WebKitSupport/InPageSearchManager.h:
- (InPageSearchManager):
- 2012-09-04 Rob Buis <rbuis@rim.com>
- [BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
- https://bugs.webkit.org/show_bug.cgi?id=95783
- Reviewed by Antonio Gomes.
- Use the correct enum values.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::cachingStrategy):
- 2012-09-04 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
- https://bugs.webkit.org/show_bug.cgi?id=95778
- PR #202252
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- Upstream has switch away from using the parent scroll layer's bounds origin
- in order to translate contents of all its child layers. Instead now, it directly
- sets the scroll position of the child scrollable contents layer.
- Source/WebKit/blackberry:
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- No new tests, since it is a catch-up with upstreaming code.
- 2012-09-04 George Staikos <staikos@webkit.org>
- [BlackBerry] Fix memory leak in InputHandler
- https://bugs.webkit.org/show_bug.cgi?id=95771
- Reviewed by Rob Buis.
- Simply delete the arrays at function exit.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- 2012-09-04 George Staikos <staikos@webkit.org>
- [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
- https://bugs.webkit.org/show_bug.cgi?id=95766
- Reviewed by Rob Buis.
- Passing the frame status through will allow the client to make better
- decisions about how to act on the onload.
- * Api/WebPageClient.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
- 2012-09-04 Rob Buis <rbuis@rim.com>
- [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
- https://bugs.webkit.org/show_bug.cgi?id=95769
- Reviewed by Yong Li.
- Also remove WTF prefixes.
- * Api/DumpRenderTreeClient.h:
- 2012-09-04 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Add webplatform and browser to build info
- https://bugs.webkit.org/show_bug.cgi?id=95715
- Reviewed by George Staikos.
- PR# 202102
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::buildPage):
- 2012-08-31 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
- https://bugs.webkit.org/show_bug.cgi?id=95611
- Reviewed by Antonio Gomes.
- PR:200127
- Remove r118405 now as we already have a new fix webkit/43f8394b for
- that issue and it is not reproducible anymore after the removal.
- In this way, we can get rid of this ASSERT failure as well.
- Thanks Antonio for the suggestion.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-08-31 Joshua Netterfield <jnetterfield@rim.com>
- [BlackBerry] Eliminate WebGL IT policy
- https://bugs.webkit.org/show_bug.cgi?id=95604
- Internal RIM PR #198764
- Reviewed by Rob Buis.
- This is no longer a requirement for the BlackBerry port.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::setWebGLEnabled):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::configPage):
- 2012-08-30 Benjamin Poulain <bpoulain@apple.com>
- Replace JSC::UString by WTF::String
- https://bugs.webkit.org/show_bug.cgi?id=95271
- Reviewed by Geoffrey Garen.
- Replace UString by String.
- * WebCoreSupport/ClientExtension.cpp:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::installDomFunction):
- 2012-08-30 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] ASSERT failure in JSC::MarkedAllocator::allocateSlowCase
- https://bugs.webkit.org/show_bug.cgi?id=95492
- Reviewed by Yong Li.
- PR: 200724
- Hold the JSLock for the current thread before we call toRef to avoid
- the ASSERT failure.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- 2012-08-30 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition
- https://bugs.webkit.org/show_bug.cgi?id=95476
- PR #200704
- Reviewed by Yong Li.
- This code is not needed at this point for neither the fast nor slow in-region
- scroll codepaths, and it is a huge performance beast as it forces all
- containers to get full-repainted per scroll call (in webkit thread).
- Patch also take this opportunity to remove an early-return we
- have in the {i}frame slow scrolling code path so that we can
- adjust the selection handles in this case as well.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- 2012-08-30 Hanna Ma <Hanma@rim.com>
- [BlackBerry] node search does not work with elements on touch start listener
- https://bugs.webkit.org/show_bug.cgi?id=95252
- Reviewed by Antonio Gomes.
- Fix the node search function of web insepctor on elements with touch start listener.
- Add methods from webPage to check if the node search functionality is enabled before handling touch events.
- PR194107
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2012-08-30 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] One shot drawing sync flag never cleared when there's no layers
- https://bugs.webkit.org/show_bug.cgi?id=95447
- Reviewed by Antonio Gomes.
- PR 199866
- When we remove the layers, WebKit could tell us we need a one shot
- drawing sync to repaint the BackingStore with the content that was
- previously drawn by layers. We also sometimes set the one shot drawing
- sync flag manually.
- We would bail from commit if there were no layers and not actually
- perform the osds, so it left the osds flag set forever and the
- situation prevails, because nobody will ever clear the osds flag.
- The BackingStore surrenders the responsibility of blitting to the AC
- commit mechanism when a one shot drawing sync is pending, because we
- want the operations render, commit and blit to happen in the correct
- order with no intermediate blits.
- So, no commit means no blit, and the result of regular rendering did
- not show up on screen.
- Fixed by not bailing from commit if there's no layers, instead clearing
- the "needs commit" and osds flags and performing a blit.
- Reviewed internally by Andrew Lo.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- 2012-08-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
- Use ASCIILiteral for DEFINE_STATIC_LOCAL string
- https://bugs.webkit.org/show_bug.cgi?id=95420
- Reviewed by Benjamin Poulain.
- As recommended by http://trac.webkit.org/wiki/EfficientStrings,
- WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.
- * Api/WebSettings.cpp:
- (WebKit):
- 2012-08-29 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger.
- https://bugs.webkit.org/show_bug.cgi?id=95372
- By using the shadow tree we were getting a mismatch between elements of the
- current element under focus and the one return to us from FatFingers.
- Passing ShadowContentNotAllowed to get the right handle.
- Reviewed by Antonio Gomes.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-08-29 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Move the handling of UserMedia requests to the client
- https://bugs.webkit.org/show_bug.cgi?id=95317
- PR #197283
- Reviewed by George Staikos.
- Internally reviewed by George Staikos.
- Move the logic for user media requests handling to the client, as it requires
- inputs from users. Also adds a origin field to WebUserMediaRequest.
- * Api/WebPageClient.h:
- (Platform):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::requestUserMedia):
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- * WebCoreSupport/UserMediaClientImpl.h:
- (UserMediaClientImpl):
- 2012-08-29 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Replace blackberry specific HitTestRequest::FingerUp by TouchEvent + Release
- https://bugs.webkit.org/show_bug.cgi?id=95383
- Reviewed by Rob Buis.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- 2012-08-29 Rob Buis <rbuis@rim.com>
- [BlackBerry] Adjust wtf include header style
- https://bugs.webkit.org/show_bug.cgi?id=95368
- Reviewed by Yong Li.
- Switch to #include <wtf/...> like the other ports.
- * Api/BlackBerryGlobal.cpp:
- * Api/WebPage.cpp:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
- * WebCoreSupport/SelectPopupClient.h:
- * WebKitSupport/AboutData.cpp:
- * WebKitSupport/DOMSupport.cpp:
- * WebKitSupport/GLES2Context.cpp:
- * WebKitSupport/InPageSearchManager.h:
- * WebKitSupport/InputHandler.cpp:
- 2012-08-29 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Remove unused tapGesture in WebPage.cpp
- https://bugs.webkit.org/show_bug.cgi?id=95357
- Reviewed by Rob Buis.
- Remove unused variable tapGesture in WebPage.cpp.
- Internally reviewed by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2012-08-28 Antonio Gomes <agomes@rim.com>
- [BlackBerry] crash while trying to scroll any inner frame
- https://bugs.webkit.org/show_bug.cgi?id=95287
- PR #198510
- Reviewed by George Staikos.
- Set the starting point of scrolling (slow path only still)
- for inner frames. It was left over as set to 0 by r126474.
- In practice, patch fixes a crash on gmail.com desktop edition.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r126914.
- http://trac.webkit.org/changeset/126914
- https://bugs.webkit.org/show_bug.cgi?id=95239
- it breaks everything and fixes nothing (Requested by pizlo on
- #webkit).
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
- (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
- (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
- 2012-08-28 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Spellcheck should be enabled if undefined in content.
- https://bugs.webkit.org/show_bug.cgi?id=95139
- Currently we only enable spellcheck if it is defined as such in
- the web content explicitly.
- Making this change to enable by default, and only turn off if it is
- explicitly set, or if we expect the field to be a username, email or
- url.
- Internally reviewed by Mike Fenton.
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::unlockSequenceMap):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
- Rename first/second to key/value in HashMap iterators
- https://bugs.webkit.org/show_bug.cgi?id=82784
- Reviewed by Eric Seidel.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
- (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
- (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- 2012-08-28 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Range boundaries should use endOfBlock instead of endOfLine.
- https://bugs.webkit.org/show_bug.cgi?id=95135
- The original implementation used nextLinePosition to iterate
- through the field from the start of each line, and was bounded in
- comparison to the endOfLine. This works fine as long as there aren't any
- empty lines between paragraphs of text, since these will have
- startOfLine == endOfLine and break out.
- Also, protect map access with a mutex in case we get a response
- before updating the map. Further, we should check the Range pointer
- before using it, since its not guaranteed to be valid.
- Internally reviewed by Mike Fenton.
- Reviewed by Antonio Gomes.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckBlock):
- 2012-08-28 Andrew Lo <anlo@rim.com>
- [BlackBerry] One shot drawing synchronization broken
- https://bugs.webkit.org/show_bug.cgi?id=95179
- Reviewed by Antonio Gomes.
- Internally reviewed by Arvid Nilsson.
- Make sure no backing store blits happen during one shot drawing
- synchronization.
- Since we always blit during commit now, make sure we don't blit if
- we commit after a render.
- We no longer need a deferred blit since we don't commit during renderContents
- now. Instead, we only commit & blit once after a full render job.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
- (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
- (BlackBerry::WebKit::RenderQueue::visibleScrollJobsCompleted):
- 2012-08-28 Parth Patel <parpatel@rim.com>
- [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient
- https://bugs.webkit.org/show_bug.cgi?id=95113
- Reviewed by Kentaro Hara.
- Refactoring has lead to relocation of many or all methods from Class
- BlackBerryPlatformClient to other classes. Some files include
- BlackBerryPlatformClient but does not use its instance thus these
- includes has to be removed.
- * Api/BackingStore.cpp:
- 2012-08-28 Andy Chen <andchen@rim.com>
- [BlackBerry] UpdateViewport uses wrong size for frameView
- https://bugs.webkit.org/show_bug.cgi?id=95138
- Reviewed by Antonio Gomes.
- Internally reviewed by Jakob Petsovits.
- Use actual visible size instead of screen size when updating viewport size,
- otherwise, frameView size would be too big.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
- 2012-08-28 Andy Chen <andchen@rim.com>
- [BlackBerry] Pseudo class "active" is broken
- https://bugs.webkit.org/show_bug.cgi?id=95142
- Reviewed by Antonio Gomes.
- Check if an element is affected by active rule before cancelling
- the touch event.
- PR 198544.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r126836.
- http://trac.webkit.org/changeset/126836
- https://bugs.webkit.org/show_bug.cgi?id=95163
- Broke all Apple ports, EFL, and Qt. (Requested by tkent on
- #webkit).
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
- (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
- (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
- 2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
- Rename first/second to key/value in HashMap iterators
- https://bugs.webkit.org/show_bug.cgi?id=82784
- Reviewed by Eric Seidel.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
- (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
- (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::cancel):
- (WebCore::NotificationPresenterImpl::onPermission):
- (WebCore::NotificationPresenterImpl::notificationClicked):
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
- (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
- (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
- 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r126772.
- http://trac.webkit.org/changeset/126772
- https://bugs.webkit.org/show_bug.cgi?id=95137
- "This change breaks news.qq.com" (Requested by leoyang on
- #webkit).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 2012-08-27 Leo Yang <leoyang@rim.com>
- [BlackBerry] Not using absoluteVisibleOverSize when rotating
- https://bugs.webkit.org/show_bug.cgi?id=95092
- PR #190469
- Reviewed by Antonio Gomes.
- Reviewed internally by Arvid Nilsson.
- When we are rotating don't count absolute overflow visible size
- into fixed layout size because we are in a transient state. The
- absolute overflow visible size remains old size during rotation.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 2012-08-25 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Remove the 'in region scrollable starting node' concept from InRegionScroller
- https://bugs.webkit.org/show_bug.cgi?id=95020
- Reviewed by Rob Buis.
- 'In-region start scrolling node' is an obsolete concept, and we can remove it
- in favor of using the information from the cached layers.
- * Api/InRegionScroller.cpp:
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollerPrivate::reset): Adjusted as it used to clear
- the cached 'node'.
- (BlackBerry::WebKit::InRegionScrollerPrivate::isActive): Added method to be
- checked directly instead of only null-checking the previously cached 'node'.
- (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData): New method to
- clear the cached resources if its document is done.
- (BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): Adjusted
- to not care about the cached 'node' anymore.
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped): Check ::isActive instead
- of ::hasNode, since the later is gone.
- (BlackBerry::WebKit::WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableAreaAfterInRegionScrolling):
- Changed the method signature, given that we do have a cached 'node' to pass in as parameter anymore.
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData): Delegate all the related work to InRegionScroller.
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- .
- 2012-08-25 Antonio Gomes <agomes@rim.com>
- BlackBerry] Shrink the in-region nested scrollable list as soon as we can
- https://bugs.webkit.org/show_bug.cgi?id=95019
- Reviewed by Rob Buis.
- We cache all possible nested scrollable in-region layers given a point.
- It is up to the client to pick a view, based on the scroll position and limits
- of each layer, and on the direction user swipes its finger.
- From the point we pick a view on, we stick with it, and any other
- possibly cached layer can be uncached, as it won't be needed.
- Patch provides a simple solution to that.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
- (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateActiveAndShrinkCachedScrollableAreas):
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- 2012-08-25 Antonio Gomes <agomes@rim.com>
- For convenience, make RenderLayer::enclosingElement a public method.
- https://bugs.webkit.org/show_bug.cgi?id=95018
- Reviewed by George Staikos.
- Make use of the new public RenderLayer::enclosingElement method and
- remove duplicated code.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
- Rename RegisterProtocolHandler API to NavigatorContentUtils
- https://bugs.webkit.org/show_bug.cgi?id=94920
- Reviewed by Adam Barth.
- Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-08-26 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] ASSERT failed in WebPagePrivate::commitRootLayerIfNeeded()
- https://bugs.webkit.org/show_bug.cgi?id=94921
- PR 104676
- As visibility changed due to WebPage::setVisible(true),
- resumeRootLayerCommit() would call commitRootLayerIfNeeded(), without
- layouting or rendering. If a one shot drawing sync was pending at this
- time, it would cause the condition
- ASSERT(!needsOneShotDrawingSynchronization()) to fail.
- The comment immediately before the assert states that "In case of one
- shot drawing synchronization, you should first layoutIfNeeded, render,
- then commit and draw the layers". However, resumeRootLayerCommit() did
- no such thing.
- Fixed by removing the call to commitRootLayerIfNeeded() from
- resumeRootLayerCommit(), because the latter is only called in a code
- path where we're going to layout, render and then commit anyway. These
- operations will be performed from resumeBackingStore() which is called
- at the end of setVisible().
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
- 2012-08-24 Adam Treat <atreat@rim.com>
- [BlackBerry] Web pages are zoomed out to much on initial load
- https://bugs.webkit.org/show_bug.cgi?id=94830
- The previous patch caused a slight regression to the calculation we do
- for the default splitting factor in the render queue. The default value
- we use to represent the max area should be the tile size. This was true
- with the old calculation of default max layout width since it was the
- screen size. The fix is to be explicit and use the tile size directly.
- Reviewed by George Staikos.
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::splittingFactor):
- 2012-08-24 Parth Patel <parpatel@rim.com>
- [BlackBerry] Changes resulting from moving network related methods
- from platform client to platform settings.
- https://bugs.webkit.org/show_bug.cgi?id=94963
- Reviewed by Yong Li.
- Changes in response to Network methods moved from
- class BlackBerryPlatformClient to class BlackBerryPlatformSettings
- in platform repository.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::cachePage):
- 2012-08-24 Liam Quinn <lquinn@rim.com>
- [BlackBerry] Debug assertion fires in BackingStorePrivate::renderJob()
- https://bugs.webkit.org/show_bug.cgi?id=94960
- Reviewed by Adam Treat.
- Change the assertion into an early return as recommended by Adam Treat.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- 2012-08-24 Andrew Lo <anlo@rim.com>
- [BlackBerry] Animation & UI lag when rendering
- https://bugs.webkit.org/show_bug.cgi?id=94943
- Reviewed by Rob Buis.
- Schedule a backing store blit & composite when commiting root layer.
- This results in compositing not having to wait until after a long render
- operation, increasing responsiveness & fixing animations which skip to
- the last frame due to lag.
- This can cause a blit during a "one shot drawing synchronization", which is
- a render & commit on the AC layers, which may result in flashing.
- However, this can happen in other situations as well, and we feel that
- the responsiveness, reduced lag, and smoothness of animations is
- more important.
- Internal PR194209
- Internally reviewed by: George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- 2012-08-24 Parth Patel <parpatel@rim.com>
- [BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings.
- https://bugs.webkit.org/show_bug.cgi?id=94249
- Reviewed by Rob Buis.
- PR# 170160
- Changes in response to Application Directory methods moved from
- Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
- platform respository since these methods are more appropriate in
- class BlackBerryPlatformSettings.
- * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
- (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
- 2012-08-24 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Touch cancel can cause huge and needless invalidations
- https://bugs.webkit.org/show_bug.cgi?id=94938
- PR #198051
- Reviewed by George Staikos.
- Internally reviewed by Gen Mak.
- In order to remove the possible hover effect on touch_cancel, we always
- invalidate the node under the fat finger, being the fat finger valid or not.
- Point is: having a valid fat finger node does not mean the original touch
- position was actually adjust for clicking or that the fat finger is actually
- valid. We set the fat finger node to be the result of the point-based hit-test
- regardless if it is a click target or not (in order to make our mouse-move
- machinery to work).
- We should can less aggressively invalidate the fat finger node, since it can
- be rather an expensive call (longer than 1s in the worst scenario).
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- 2012-08-24 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add WebPage API to reset block zoom
- https://bugs.webkit.org/show_bug.cgi?id=94863
- PR 187478
- This is an alternative to WebPage::blockZoomAnimationFinished() when
- it's desirable to avoid rerendering of the whole web page at the end
- of block zoom. This is the case when the planned "incremental zoom
- factor" is used instead of zoomAboutPoint and it's relatives.
- Ideally, the block zoom algorithm would be clever enough not to need
- a reset or any form of callback when the animation finishes, but that
- requires the implementation of said incremental zoom factor, which is
- not done yet.
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::resetBlockZoom):
- (WebKit):
- * Api/WebPage.h:
- 2012-08-23 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
- https://bugs.webkit.org/show_bug.cgi?id=94839
- PR #197775
- Reviewed by George Staikos.
- This codepath is not needed anymore, so lets let it RIP.
- The only code addition is due to some code I've moved from WebPagePrivate::scrollNodeRecursively
- and WebPagePrivate::scrollBy to InRegionScrollerPrivate::setLayerScrollPosition.
- Rest is code removal ...
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::scrollBy):
- (BlackBerry::WebKit::WebPage::scrollBy):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-23 Adam Treat <atreat@rim.com>
- [BlackBerry] Replace the three different rendering mechanisms for clearing the render queue
- https://bugs.webkit.org/show_bug.cgi?id=94837
- Reviewed by George Staikos.
- PR 197738
- Currently, we have three different mechanisms for clearing the render queue.
- The first mechanism is render on idle. Whenever the webkit thread becomes idle
- (read: no more events in its queue) we render the next job in the render queue.
- This is the primary means we use for clearing the render queue. However, this
- mechanism has a flaw, it is such a low priority mechanism that sometimes the
- queue grows so fast due to higher priority events adding rects to the queue
- that this mechanism can't possibly keep up. That is what leads to the second
- mechanism: rendering right before a timer is fired when we discover that the
- render queue is under pressure and rendering on idle can't keep up. However,
- there are still degenerate cases where even this mechanism does not allow us to
- keep up. That brings us to the third mechanism: rendering based on a timer
- that is a catch-all.
- The second and third mechanisms lead to very large render jobs as they try and
- clear the queue faster when it comes under pressure. These very large render
- jobs end up keeping the webkit thread busy with a message that can take large
- fractions of a second to resolve.
- These three mechanisms were put in place when the backingstore had a different
- overall design that was not truly asynchronous. This patch replaces these
- three mechanisms with a single one that uses the platform messaging classes to
- full purpose - a uniquely coalescing message that has a higher priority level
- than timers making sure the render queue can never come under pressure.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (WebKit):
- (RenderJobMessage):
- (BlackBerry::WebKit::RenderJobMessage::RenderJobMessage):
- (BlackBerry::WebKit::BackingStorePrivate::dispatchRenderJob):
- (BlackBerry::WebKit::BackingStorePrivate::renderJob):
- (BlackBerry::WebKit::BackingStore::blitContents):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- * Api/WebPage.h:
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::reset):
- (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
- (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- (BlackBerry::WebKit::RenderQueue::clear):
- (BlackBerry::WebKit::RenderQueue::clearVisibleZoom):
- (BlackBerry::WebKit::RenderQueue::render):
- 2012-08-23 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Unify slow and fast in-region scrolling code paths
- https://bugs.webkit.org/show_bug.cgi?id=94834
- PR #197662
- Reviewed by Rob Buis.
- Internally reviewed by Arvid Nilsson.
- In order to be able to remove a bunch of obsolete code from
- InRegionScroller.cpp, we need to unify the codepaths for slow
- and fast in-region scrolling.
- This patch caches the root scrollable node of each scrollable block
- in InRegionScrollableArea also for the non-composited-scrolling case now too
- (analogly to the way we cache LayerWebKitThread for the composited scrolling case).
- Now the client (libwebview) can dispatch an in-region scrolling with one single code path,
- making use of a boolean (argh!) to inform if the scroll of the given
- layer supports compositing or not. Later on, this boolean is used to casting the proper element.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- * Api/InRegionScroller.h:
- * Api/InRegionScroller_p.h:
- (InRegionScrollerPrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- (BlackBerry::WebKit::enclosingLayerNode):
- * WebKitSupport/InRegionScrollableArea.h:
- (WebCore):
- (InRegionScrollableArea):
- 2012-08-23 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Web pages are zoomed out to much on initial load
- https://bugs.webkit.org/show_bug.cgi?id=94830
- Reviewed by Adam Treat.
- PR: 193943
- Browser continuously adds paddings to the left and right sides of the
- main contents which makes the main contents even smaller.
- The issue can be reproduced on the desktop websites such as
- huffingtonpost.ca, bloomberg.com, online.wsj.com, nytimes.com,
- yahoo.com, thestar.com, sina.com.cn, sohu.com and so on.
- The root cause is that we layout those contents at the width of 1280
- although the fixed width of the main contents of those websites is
- less than 1000, which results in adding the paddings.
- To fix this, we need to get back to the default max layout size
- 1024 * 768, which will make the main contents of those popular websites
- take full advantage of the screen real estate and look much better.
- Internally reviewed by Adam Treat.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/RenderQueue.cpp:
- (BlackBerry::WebKit::RenderQueue::splittingFactor):
- 2012-08-22 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Make all pickers non-zoomable
- https://bugs.webkit.org/show_bug.cgi?id=94729
- Reviewed by Antonio Gomes.
- Move HTML header initialization to PagePopupBlackBerry as that part are all the same, and make all pickers non-zoomable.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::screenSize):
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/DatePickerClient.cpp:
- (WebCore::DatePickerClient::generateHTML):
- (WebCore::DatePickerClient::writeDocument):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::init):
- (WebCore::PagePopupBlackBerry::generateHTML):
- (WebCore):
- * WebCoreSupport/PagePopupBlackBerry.h:
- (PagePopupBlackBerry):
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- (WebCore::SelectPopupClient::writeDocument):
- 2012-08-21 Benjamin C Meyer <bmeyer@rim.com>
- [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
- https://bugs.webkit.org/show_bug.cgi?id=94621
- Reviewed by Yong Li.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::enableQnxJavaScriptObject):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 2012-08-21 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Add support for getUserMedia
- https://bugs.webkit.org/show_bug.cgi?id=94591
- Reviewed by George Staikos.
- Implement getUserMedia feature using the platform API.
- PR #153571
- Reviewed internally by George Staikos.
- * WebCoreSupport/UserMediaClientImpl.cpp:
- (WebCore):
- (WebCore::userMediaRequestsMap):
- (WebCore::toMediaStreamSource):
- (WebCore::toMediaStreamDescriptor):
- (WebUserMediaRequestClientImpl):
- (WebCore::WebUserMediaRequestClientImpl::WebUserMediaRequestClientImpl):
- (WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
- (WebCore::WebUserMediaRequestClientImpl::requestFailed):
- (WebCore::UserMediaClientImpl::UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::requestUserMedia):
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- (WebCore::UserMediaClientImpl::webUserMedia):
- * WebCoreSupport/UserMediaClientImpl.h:
- (BlackBerry):
- (Platform):
- (UserMediaClientImpl):
- 2012-08-21 Kihong Kwon <kihong.kwon@samsung.com>
- [EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
- https://bugs.webkit.org/show_bug.cgi?id=94586
- Reviewed by Kentaro Hara.
- Fix build error in the DeviceOrientationClientBlackBerry.cpp.
- It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
- * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
- (DeviceOrientationClientBlackBerry::lastOrientation):
- 2012-08-21 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] about:memory and about:memory-live should show numbers for the chrome process
- https://bugs.webkit.org/show_bug.cgi?id=94531
- Reviewed by Rob Buis.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 190504
- Add total committed memory of chrome process into about:memory and add
- its peak into about:memory-live.
- Internally reviewed by Yong Li and George Staikos.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::memoryPage):
- (BlackBerry::WebKit::MemoryTracker::clear):
- (MemoryTracker):
- (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfCurrentProcess):
- (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfChromeProcess):
- (BlackBerry::WebKit::MemoryTracker::MemoryTracker):
- (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
- (BlackBerry::WebKit::memoryPeaksToHtmlTable):
- 2012-08-21 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Accelerated In-Region Scrolling does not render correctly on rotation
- https://bugs.webkit.org/show_bug.cgi?id=94608
- PR #194754
- Reviewed by Goerge Staikos.
- When one translates/scrolls a HW accelerated scrollable layer, it makes use of
- the OVERRIDE mechanism. Suppose the following scenario:
- - In landscape, the overflow menu is scrollable. Then the user scrolls it so
- that is has scroll position of 0, -100.
- - when he rotates to portrait, the menus fit well to the available space but it
- still has the OVERRIDE set, so it keeps the layer translated at 0, -100.
- Fix is simple: clear the override when we stop scrolling a HW accelerated layer,
- when we destroy the objects.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea):
- 2012-08-21 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Properly notify WebKit when Client stops in-region scrolling
- https://bugs.webkit.org/show_bug.cgi?id=94603
- PR #195813
- Reviewed by Goerge Staikos.
- Simplify the API to get a notification of when a in-region
- scrolling has finished.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- Removed an unneeded parameter.
- (BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
- Ditto.
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-20 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Select popup shows blank content when its option tags contain '\' characters
- https://bugs.webkit.org/show_bug.cgi?id=94321
- Reviewed by George Staikos.
- PR 194224
- When the SelectPopupClient generates HTML, if there is a character '\' in the select options'
- description, we should escape it to avoid the character being interpreted as an escape character.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-08-20 Genevieve Mak <gmak@rim.com>
- [BLACKBERRY] Add notification if an element does not have touch move or mouse move handlers.
- https://bugs.webkit.org/show_bug.cgi?id=94529
- Reviewed by George Staikos.
- Send a notification to the client if the fat finger element does
- not have a mouse move or touch move handler or if it is empty.
- PR #177701
- Reviewed Internally By Mike Lattanzio and Antonio Gomes.
- * Api/WebPageClient.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-08-17 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Allow in-region accelerated scrolling take advantage of defer_blits
- https://bugs.webkit.org/show_bug.cgi?id=94379
- PR #194595
- Reviewed by Yong Li.
- Client does the blitting now.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- 2012-08-17 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] On reload, www.sohu.com renders part white background, part overscroll pattern
- https://bugs.webkit.org/show_bug.cgi?id=94348
- Reviewed by Yong Li.
- Jacky Jiang <zhajiang@rim.com>
- PR: 179200
- This can fix the reload issues of sohu.com, yahoo.com and
- thestar.com/iphone(PR158041). And it is also related with PR178305.
- Internally reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState): Keeping scales for
- reload was doing more harm than good. Two reasons to remove this:
- (1) During reload, contents rect is changing due to layout updates,
- it is possible that the contents or the white background can't cover
- the whole screen if we are using the previous scales.
- (2) Before reload, the source of the web page can be changed, therefore
- previous scales won't be valid anymore.
- Remove shouldRestoreViewState() as this check here is useless now.
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad): During
- reload, we should give it a chance to zoom to fit the screen,
- otherwise, it happens that the contents can't cover the whole screen
- until we restore the view state, see PR158041.
- Remove shouldRestoreViewState() as the error page issue PR178305 can be
- covered by reload now.
- * WebCoreSupport/FrameLoaderClientBlackBerry.h: Remove unused shouldRestoreViewState().
- 2012-08-16 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Use form state to determine the VKB enter key.
- https://bugs.webkit.org/show_bug.cgi?id=94239
- Reviewed by Rob Buis.
- PR 188234.
- If the enter key for the VKB is not explicitly set, use
- submit if we are in a single line input and a default
- button exists for the form.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- 2012-08-16 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Reload valid page from Error Page keeps history ViewState and zoom.
- https://bugs.webkit.org/show_bug.cgi?id=94123
- Reviewed by Antonio Gomes.
- Reviewed internally by Leo Yang, Jacky Jiang.
- PR 178305
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):Reset the scales and
- the user scalable flag if we're reloading from an error page.
- (BlackBerry::WebKit::WebPagePrivate::updateViewportSize): Don't update the
- viewport size if we're still in the WebPagePrivate::init method.
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- Properly set the shouldZoom flag if we're not going to restore the
- view state.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad): Set the
- ViewState's shouldSaveViewState flag if we're coming from an error page.
- (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem): Set the
- new member variable m_shouldRestoreViewState based on the ViewState's
- shouldSaveViewState flag.
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState): Added early
- return if m_shouldRestoreViewState is false.
- * WebCoreSupport/FrameLoaderClientBlackBerry.h: Add new method to have
- the client track whether we should restore the view state.
- (WebCore::FrameLoaderClientBlackBerry::shouldRestoreViewState):
- (FrameLoaderClientBlackBerry):
- 2012-08-16 Leo Yang <leoyang@rim.com>
- [BlackBerry] Remove Mobile mode from WebPage.cpp and WebPage_p.h
- https://bugs.webkit.org/show_bug.cgi?id=94223
- PR #192773
- Reviewed by Rob Buis.
- Reviewed internally by Arvid Nilsson.
- Remove Mobile mode as it's not been used. Also remove code that
- handle top-level SVG document because now we can handle it in Desktop mode.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- * Api/WebPage_p.h:
- 2012-08-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] SurfacePool::waitForBuffer() sometimes waits for deleted EGLSyncKHR object
- https://bugs.webkit.org/show_bug.cgi?id=94208
- Reviewed by Rob Buis.
- SurfacePool::notifyBuffersComposited() adds a tile's previous
- sync object to the garbage list before replacing it with a new one.
- However, it failed to thoroughly clear all tiles that were referencing
- the old sync object.
- Thus it could happen that if a set of tiles A was composited, then
- another set of tiles B was composited, only the intersection of A and B
- was cleared of the soon-to-be-deleted sync object, and the subtraction
- A - B would reference an invalid sync object in case the BackingStore
- decided to render to one of the tiles in A - B before they were
- composited again.
- Fixed by storing each individual sync object in only one place so we
- don't have to rummage through all tiles and remove stale references to
- sync objects that are about to be destroyed.
- A new reference counted Fence class is added for this purpose, to store
- a sync object. Tiles refer to Fence instances instead of holding a sync
- object directly. Since Fence is reference counted, several tiles can
- refer to the same Fence instance, and clearing its sync object will
- instantly remove it from the grasp of all tiles that depend on that
- Fence.
- Since there's no point in waiting for the same Fence twice, the only
- operation provided on Fence is takePlatformSync() which returns the
- sync object and clears the Fence of its sync object.
- Reviewed internally by Filip Spacek.
- PR 193610
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::TileBuffer):
- * WebKitSupport/BackingStoreTile.h:
- (BlackBerry):
- (Fence):
- (BlackBerry::Fence::create):
- (BlackBerry::Fence::takePlatformSync):
- (BlackBerry::Fence::Fence):
- (BlackBerry::WebKit::TileBuffer::fence):
- (BlackBerry::WebKit::TileBuffer::setFence):
- (TileBuffer):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::waitForBuffer):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-08-16 Rob Buis <rbuis@rim.com>
- [BlackBerry] Suppress non DRT JS Console output.
- https://bugs.webkit.org/show_bug.cgi?id=94058
- Reviewed by Yong Li.
- Reviewed internally by Ming Xie.
- Some actual test results show JS Console showing up twice, for
- instance traversal/moz-bug559526.html. Only print the DRT specific
- Console message.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addMessageToConsole):
- 2012-08-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebGL and Canvas fail to display after being restored from page cache
- https://bugs.webkit.org/show_bug.cgi?id=94105
- Reviewed by George Staikos.
- The EGLImage was being destroyed when releasing layer resources on the
- compositing thread, but the WebKit thread layer never found out and
- failed to create a new image.
- Fixed by extending the release layer resources mechanism to also make a
- pass on the WebKit thread so that thread's layers have a chance to
- delete their textures and related resources.
- Reviewed internally by Filip Spacek.
- PR 192899
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::releaseLayerResources):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
- (BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/FrameLayers.cpp:
- (BlackBerry::WebKit::FrameLayers::releaseLayerResources):
- (WebKit):
- * WebKitSupport/FrameLayers.h:
- (FrameLayers):
- 2012-08-16 Pierre Rossi <pierre.rossi@gmail.com>
- [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
- https://bugs.webkit.org/show_bug.cgi?id=93960
- Reviewed by Simon Hausmann.
- Following the removal of Qt 4 support from trunk in r124879.
- * WebCoreSupport/AboutDataHaveFeatures.in: Remove all traces of HAVE_QRAWFONT's existence.
- 2012-08-15 Benjamin C Meyer <bmeyer@rim.com>
- [BlackBerry] When there is an exception we want to check if the ref is 0, not the
- value as JSObjectCallAsFunction returns 0 in that case.
- https://bugs.webkit.org/show_bug.cgi?id=94153
- Reviewed by Yong Li.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 2012-08-15 Yong Li <yoli@rim.com>
- [BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
- https://bugs.webkit.org/show_bug.cgi?id=94139
- Reviewed by Antonio Gomes.
- Keep same security origin when a file URL automatically redirects to its child folder.
- This patch will be reverted when we finish the better solution.
- PR# 172333 and PR# 180590.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad):
- (WebCore::FrameLoaderClientBlackBerry::securityOriginForNewDocument):
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-08-15 Yong Li <yoli@rim.com>
- [BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
- https://bugs.webkit.org/show_bug.cgi?id=94136
- Reviewed by Rob Buis.
- Internally reviewed by Lyon Chen.
- PR# 192401.
- 1. The prototype of GeoTracker::create() has changed.
- 2. Fix the issue that it could recreate tracker unnecessarily when
- setEnableHighAccuracy() is called but accuracy requirment hasn't
- changed.
- 3. Fix the issue setEnableHighAccuracy() could start tracking when
- tracker was suspended.
- * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
- (GeolocationControllerClientBlackBerry::startUpdating):
- (GeolocationControllerClientBlackBerry::setEnableHighAccuracy):
- 2012-08-15 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input.
- https://bugs.webkit.org/show_bug.cgi?id=94132
- Reviewed by Rob Buis.
- PR 139838.
- Switch direct key input handling to be based on the unconverted
- attribute being present. Converted keys, even during composition
- are now input directly.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setText):
- 2012-08-15 Joshua Netterfield <jnetterfield@rim.com>
- [BlackBerry] Upstream BlackBerry build fixes
- https://bugs.webkit.org/show_bug.cgi?id=94121
- Reviewed by Rob Buis.
- This includes several build fixes due to incorrect upstream patches.
- These mistakes were never present downstream.
- No new tests, because no new functionality is added.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutTemplate.html.cpp:
- (writeHeader):
- 2012-08-15 Leo Yang <leoyang@rim.com>
- [BlackBerry] Use nested layout when rotating
- https://bugs.webkit.org/show_bug.cgi?id=94117
- Partially patched by Arvid Nilsson.
- Reviewed by George Staikos.
- Reviewed internally by Arvid Nilsson.
- When rotating the content width used for fixedLayoutSize is not
- correct because we are changing the rotation and the content with
- should be determined after layout. So we set the with to 0 if we
- are rotating and beginning the nested layout. And in setViewportSize
- we need a nested layout loop to trigger zoom-to-fit.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-08-14 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Stop copying ScrollViewBase vector all over
- https://bugs.webkit.org/show_bug.cgi?id=94021
- Reviewed by Rob Buis.
- It outlives long enough in WebKit that we can
- just pass a const+ref of it.
- Internally reviewed by Gen Mak.
- * Api/WebPageClient.h:
- 2012-08-14 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Robust-fy the LayerWebKitThread ownership with InRegionScroller
- https://bugs.webkit.org/show_bug.cgi?id=93983
- PR #191737
- Reviewed by Yong Li.
- Patch changes the way we currently keep track of the active scrollable area
- objects: before, we acquired the scrollable areas and just passed them in a vector up
- to the client, copying it over and over again. Also, it was a client responsability to
- delete stuff (BAD!).
- Now, we keep track of vector within InRegionScroller, as a class member, which allows us to
- avoid copies (in follow up patch), and control until when these objects outlive.
- Patch also changes InRegionScrollableArea to "retptr" the composited layer
- associated to it (if any). This ensure we have a non-null scrollable element always.
- As mentioned, InRegionScroller is now responsible for deleting and vector of scrollable areas.
- Internally reviewed by Arvid Nilsson.
- * Api/InRegionScroller.cpp:
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollerPrivate::reset): Method is now responsible for
- deleting the tracked scrollable areas.
- (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- Renamed from 'inRegionScrollableAreasForPoint'. It was changed in order to store the
- scrollable area objects instead of just pass a copy of them up to the client.
- (BlackBerry::WebKit::InRegionScrollerPrivate::activeInRegionScrollableAreas): Getter.
- (BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): It was
- promoted to a class method instead of a local helper.
- * Api/InRegionScroller_p.h:
- (WebKit):
- (InRegionScrollerPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint): Adjustments needed due to the
- above changed.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea): Clear up the cached layer.
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- * WebKitSupport/InRegionScrollableArea.h:
- (InRegionScrollableArea):
- 2012-08-15 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Check for valid field focus before processing a spellcheck request
- https://bugs.webkit.org/show_bug.cgi?id=94115
- Reviewed by Rob Buis.
- PR192891
- Checking for valid field focus before processing the spellcheck
- request.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- 2012-08-14 Adam Barth <abarth@webkit.org>
- Delete Frame::domWindow() and Frame::existingDOMWindow()
- https://bugs.webkit.org/show_bug.cgi?id=93990
- Reviewed by Eric Seidel.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::toOriginString):
- (WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
- (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
- (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
- (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
- (WebCore::ChromeClientBlackBerry::requestWebGLPermission):
- 2012-08-14 Leo Yang <leoyang@rim.com>
- [BlackBerry] Checkerboard flashes on Go Back
- https://bugs.webkit.org/show_bug.cgi?id=94018
- Reviewed by Yong Li.
- Reviewed internally by Yong Li.
- The backing store need to be suspended before the
- WebPagePrivate::restoreHistoryViewState() is called to avoid UI thread
- drawing checkerboard.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-08-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove unnecessary \n's from InputHandler log messages.
- https://bugs.webkit.org/show_bug.cgi?id=94015
- Reviewed by Rob Buis.
- Remove many unnecessary \n's from the end of log messages.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWcharVector):
- (BlackBerry::WebKit::convertSpannableStringToString):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::setText):
- (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
- 2012-08-14 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Queue spellcheck requests with char-count limitations
- https://bugs.webkit.org/show_bug.cgi?id=93866
- Reviewed by Rob Buis.
- PR184196
- Making spellcheck a little more granular so as to work around
- the limitations of the inputservice.
- Also, spellcheck the entire field on focus only if
- spellcheck="on" is explicitly set.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- 2012-08-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
- https://bugs.webkit.org/show_bug.cgi?id=93992
- Reviewed by Antonio Gomes.
- Use form control helper functions to determine the editable state
- of the input field.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- 2012-08-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
- https://bugs.webkit.org/show_bug.cgi?id=93988
- Reviewed by Antonio Gomes.
- Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 2012-08-14 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fix use of endsWith to use string instead of char.
- https://bugs.webkit.org/show_bug.cgi?id=93994
- Reviewed by Antonio Gomes.
- Regex comparison should use string instead of char comparison.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
- 2012-08-14 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
- https://bugs.webkit.org/show_bug.cgi?id=93895
- Reviewed by Antonio Gomes.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 188232
- When adjusting block zoom node, don't choose a node if the width of the
- node size is very close to the width of the actual visible size as
- block zoom can do nothing on such kind of node. This condition is more
- restrictive than the one based on area and can bail out early.
- In this way, we can get a better node for double-tap zoom.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
- (BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-14 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Change the call to setUserScalable to use the setting.
- https://bugs.webkit.org/show_bug.cgi?id=93974
- Reviewed by Rob Buis.
- We should be using the WebSetting and not the current value of m_userScalable.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2012-08-14 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Some callback of Select onchange doesn't work
- https://bugs.webkit.org/show_bug.cgi?id=93944
- Reviewed by George Staikos.
- The Selection element is implemented with PagePopup, an HTML-based WebView with
- some Javascripts to make the UI of the select and option lists; The selection
- change is initiated from the javascript code in the Select Webview, and back to
- the native code of SelectPopupClient, which now in turn dispatches
- FormControlChangeEvent to the select element directly, and that causes the
- javascript callback been invoked in the same cycle as the javascript in the
- Popup View, and causes some Javascript Context problem.
- The solution is to send the FormControlChangeEvent asynchronously by a timer,
- when the JavaScript in the Popup view finishes execution, we then send the
- FormControlChangeEvent to the select element in the content page, that avoids
- the concurrent Javascript context issue.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::SelectPopupClient):
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- (WebCore):
- (WebCore::SelectPopupClient::notifySelectionChange):
- * WebCoreSupport/SelectPopupClient.h:
- (SelectPopupClient):
- 2012-08-14 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
- https://bugs.webkit.org/show_bug.cgi?id=93614
- Reviewed by Antonio Gomes.
- We used to set up resource sharing between the compositing thread
- context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
- get a copy of the framebuffer to use as front buffer for compositing
- purposes.
- Now we instead create an EGLImage and blit the Canvas/WebGL output to
- it. The compositing thread creates a texture from the EGLImage in order
- to composite the output.
- This allows us to turn off resource sharing, so the WebPageCompositor
- no longer needs to pass the compositing thread context to the webkit
- thread.
- Reviewed internally by Filip Spacek.
- PR 188472
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-14 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Enable DNS prefetch
- https://bugs.webkit.org/show_bug.cgi?id=93846
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-08-13 Tom Sepez <tsepez@chromium.org>
- [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
- https://bugs.webkit.org/show_bug.cgi?id=93283
- Reviewed by Eric Seidel.
- Change the client redirectDataToPlugin method(s) to expect the possibility of
- a NULL argument, keeping existing behaviour otherwise.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
- 2012-08-13 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update API for spell checking suggestions again.
- https://bugs.webkit.org/show_bug.cgi?id=93877
- Reviewed by Antonio Gomes.
- PR 163283.
- Update the spell checking options request API
- to include the caret positions.
- Reviewed internally by Nima Ghanavatian.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- * WebKitSupport/InputHandler.h:
- (Platform):
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-08-13 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
- https://bugs.webkit.org/show_bug.cgi?id=93848
- PR #190986
- Reviewed by Yong Li.
- Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
- It fixes a mismatch we had of setting a layer's scroll positing directly via
- ::setScrollPosition on the UI thread, but dispatching a coalesceable
- scrollBy(delta) message to WebKit thread.
- * Api/InRegionScroller.cpp:
- (BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
- Changed the API name to match other thread specific methods naming.
- (WebKit):
- (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
- Added a setScrollPosition-like method to InRegionScroller public API. Used
- together with its UI-thread counterpart, it can fix some rounding
- errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- Method renamed. See reasons above.
- (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- Calls fowards the call to ::setLayerScrollPosition (below).
- (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- Sets the scroll position of a given RenderLayer.
- * Api/InRegionScroller.h:
- (InRegionScroller):
- * Api/InRegionScroller_p.h:
- (WebCore):
- (InRegionScrollerPrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- Cache the RenderLayer object associated to a given scrollable area
- instead of its LayerCompositingThread. This way we can use it for
- scrolling from both Compositing/UI and WebKit threads.
- 2012-08-12 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Tap highlight flashes checkerboard after pinch zoom
- https://bugs.webkit.org/show_bug.cgi?id=93601
- Reviewed by Antonio Gomes.
- Since the tap highlight is usually rather small, we can reimplement
- GraphicsLayerClient::contentsVisible() to always return true in order
- to keep all AC layer tiles cached all the time.
- PR 189895
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
- (WebKit):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- 2012-08-12 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Tap highlight sometimes doesn't disappear
- https://bugs.webkit.org/show_bug.cgi?id=93711
- Reviewed by Antonio Gomes.
- The WebOverlayOverride implementation just changes properties of a
- LayerCompositingThread directly, which means the changes will
- immediately be overwritten on the next commit. Therefore, when the tap
- highlight implementation adds a fade out animation, that animation will
- instantly be removed again if a commit happens for any reason.
- The reason is I totally botched the implementation of
- WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
- instead for some reason it's manipulating the LayerCompositingThread
- directly.
- Fixed by actually mapping WebOverlayOverride calls to the corresponding
- WebCore::LayerOverride method, and scheduling a compositing run to make
- the change visible and kick off animations.
- Reviewed internally by Sean Wang.
- PR 188453
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivate::override):
- * Api/WebOverlayOverride.cpp:
- (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
- (BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
- (BlackBerry::WebKit::WebOverlayOverride::setPosition):
- (BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
- (BlackBerry::WebKit::WebOverlayOverride::setSize):
- (BlackBerry::WebKit::WebOverlayOverride::setTransform):
- (BlackBerry::WebKit::WebOverlayOverride::setOpacity):
- (BlackBerry::WebKit::WebOverlayOverride::addAnimation):
- (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
- * Api/WebOverlayOverride.h:
- * Api/WebOverlay_p.h:
- (WebOverlayPrivate):
- (WebOverlayPrivateWebKitThread):
- (WebOverlayPrivateCompositingThread):
- 2012-08-10 Benjamin C Meyer <bmeyer@rim.com>
- Introduce JavaScriptVariant object.
- https://bugs.webkit.org/show_bug.cgi?id=93644
- The JavaScriptVariant can be used for functions that return results from
- JavaScript such as executeJavaScript or functions that take arguments
- to pass a variable to JavaScript and they want to make sure the type
- is correct.
- Convert executeJavaScriptFunction() to use this data type as the
- example, other functions will be converted in the future.
- PR 14929
- Internally reviewed by Joe Mason
- Reviewed by Adam Treat
- * Api/JavaScriptVariant.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
- (BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
- (BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
- (BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
- (BlackBerry::WebKit::JavaScriptVariant::operator=):
- (BlackBerry::WebKit::JavaScriptVariant::setType):
- (BlackBerry::WebKit::JavaScriptVariant::type):
- (BlackBerry::WebKit::JavaScriptVariant::setDouble):
- (BlackBerry::WebKit::JavaScriptVariant::doubleValue):
- (BlackBerry::WebKit::JavaScriptVariant::setString):
- (BlackBerry::WebKit::JavaScriptVariant::stringValue):
- (BlackBerry::WebKit::JavaScriptVariant::setBoolean):
- (BlackBerry::WebKit::JavaScriptVariant::booleanValue):
- * Api/JavaScriptVariant.h: Added.
- (WebKit):
- * Api/JavaScriptVariant_p.h: Added.
- (WebKit):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- * Api/WebPage.h:
- 2012-08-09 Leo Yang <leoyang@rim.com>
- [BlackBerry] Export InRegionScroller to fix build
- https://bugs.webkit.org/show_bug.cgi?id=93635
- Reviewed by Antonio Gomes.
- Build fix.
- * Api/InRegionScroller.h:
- 2012-08-08 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Implement about:memory-live
- https://bugs.webkit.org/show_bug.cgi?id=93153
- Reviewed by Yong Li.
- Patch by Jacky Jiang <zhajiang@rim.com>
- Implementing about:memory-live to track memory peaks:
- - about:memory-live/start: start tracking memory peaks.
- - about:memory-live: show memory peaks every 30ms.
- - about:memory-live/stop: stop tracking and show memory peaks.
- Mainly track the following memory peaks:
- - Total used memory (malloc + JSC).
- - Total committed memory.
- - Total mapped memory.
- Add total committed memory for about:memory
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::memoryPage):
- (WebKit):
- (MemoryTracker):
- (BlackBerry::WebKit::MemoryTracker::isActive):
- (BlackBerry::WebKit::MemoryTracker::clear):
- (BlackBerry::WebKit::MemoryTracker::peakTotalUsedMemory):
- (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemory):
- (BlackBerry::WebKit::MemoryTracker::peakTotalMappedMemory):
- (BlackBerry::WebKit::MemoryTracker::MemoryTracker):
- (BlackBerry::WebKit::MemoryTracker::instance):
- (BlackBerry::WebKit::MemoryTracker::start):
- (BlackBerry::WebKit::MemoryTracker::stop):
- (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
- (BlackBerry::WebKit::memoryPeaksToHtmlTable):
- (BlackBerry::WebKit::memoryLivePage):
- (BlackBerry::WebKit::aboutData):
- 2012-08-08 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable for in-region scroll
- https://bugs.webkit.org/show_bug.cgi?id=93482
- PR #187672
- Make InRegionScroller a simple public webkit/ API
- PR #188677
- Reviewed by Rob Buis.
- In order to prepare InRegionScroller to be a public API
- in webkit/, the patch:
- 1) Renamed the current InRegionScroller class to InRegionScrollerPrivate;
- 2) Moved InRegionScroller.cpp|h from WebKitSupport/ to Api/;
- 3) Renamed InRegionScroller.h to InRegionScroller_p.h;
- 4) Added a new public class implementation to InRegionScroller.h;
- 5) Adapted WebPage and TouchEventHandler classes to use InRegionScroller::d directly.
- The most important API here is '::compositedSetScrollPosition'
- It is a UI/Compositing thread method only and sets the associated LayerCompositingThread
- (camouflaged as a unsigned) for each created InRegionScrollableArea that supports
- composited scrolling.
- The way ::compositedSetScrollPosition "scrolls" a layer is by setting the boundsOrigin
- property to the LayerCompositingThread's 'override' property in the UI/Compositing thread.
- * Api/InRegionScroller.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp.
- (WebKit):
- (BlackBerry::WebKit::InRegionScroller::InRegionScroller):
- (BlackBerry::WebKit::InRegionScroller::~InRegionScroller):
- (BlackBerry::WebKit::InRegionScroller::compositedSetScrollPosition):
- (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
- (BlackBerry::WebKit::InRegionScrollerPrivate::setNode):
- (BlackBerry::WebKit::InRegionScrollerPrivate::node):
- (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
- (BlackBerry::WebKit::InRegionScrollerPrivate::hasNode):
- (BlackBerry::WebKit::InRegionScrollerPrivate::canScroll):
- (BlackBerry::WebKit::InRegionScrollerPrivate::compositedSetScrollPosition):
- (BlackBerry::WebKit::InRegionScrollerPrivate::scrollBy):
- (BlackBerry::WebKit::InRegionScrollerPrivate::inRegionScrollableAreasForPoint):
- (BlackBerry::WebKit::InRegionScrollerPrivate::scrollNodeRecursively):
- (BlackBerry::WebKit::InRegionScrollerPrivate::scrollRenderer):
- (BlackBerry::WebKit::InRegionScrollerPrivate::adjustScrollDelta):
- (BlackBerry::WebKit::canScrollInnerFrame):
- (BlackBerry::WebKit::canScrollRenderBox):
- (BlackBerry::WebKit::parentLayer):
- (BlackBerry::WebKit::enclosingLayerNode):
- (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
- (BlackBerry::WebKit::pushBackInRegionScrollable):
- * Api/InRegionScroller.h: Copied from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
- (WebKit):
- (InRegionScroller):
- * Api/InRegionScroller_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
- (WebCore):
- (WebKit):
- (InRegionScrollerPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::scrollBy):
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
- (BlackBerry::WebKit::WebPage::inRegionScroller):
- (WebKit):
- * Api/WebPage.h:
- (WebKit):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 2012-08-08 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
- https://bugs.webkit.org/show_bug.cgi?id=93480
- PR #188682
- Reviewed by Rob Buis.
- ... this way it can be used by others.
- No behavioural change. Another preparation patch.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-08 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r124887.
- http://trac.webkit.org/changeset/124887
- https://bugs.webkit.org/show_bug.cgi?id=93504
- Dependent API being removed. (Requested by mfenton on
- #webkit).
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::spellCheck):
- (WebKit):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-08-08 Ed Baker <edbaker@rim.com>
- [BlackBerry] Add relayout after updating fixed reported size
- https://bugs.webkit.org/show_bug.cgi?id=93116
- PR #160059
-
- Reviewed by Antonio Gomes.
-
- Reviewed internally by Antonio Gomes.
- On an orientation change and after fixed reported size is
- updated perform a layout and update the fixed elements after
- scrolling. This will recalculate the height and width of
- fixed position elements using percentage values with the
- new fixed reported size. Otherwise using the old fixed reported
- size in the new orientation overflowing or clipping could occur.
-
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-08-07 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] always set PolicyAction to PolicyIgnore if the chrome returns false for acceptNavigationRequest
- https://bugs.webkit.org/show_bug.cgi?id=93251
- Reviewed by George Staikos.
- In acceptNavigationRequest(), webkit will ask if the chrome will accept the navigation request.
- We will take this chance to see if the request is an internal-webkit protocol, otherwise,
- we will try to launch an external application to handle the request, and ask webkit to ignore
- the request by returning false in acceptNavigationRequest().
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- 2012-08-07 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Change how devicePixelRatio is set.
- https://bugs.webkit.org/show_bug.cgi?id=93385
- Reviewed by Antonio Gomes.
- Change devicePixelRatio to be set immediately after the page is created based
- on the WebSetting.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2012-08-07 Antonio Gomes <agomes@rim.com>
- [BlackBerry] [FullScreen] No need to scroll 'x' to 0 before entering fullscreen
- https://bugs.webkit.org/show_bug.cgi?id=91750
- PR #178293
- Reviewed by Rob Buis.
- We are not adjusting the 'left' CSS property of the fullscreen wrapper
- properly, so no need to scroll 'x' to 0 anymore.
- Internally reviewed by Jacky Jiang.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- 2012-08-07 Antonio Gomes <agomes@rim.com>
- [BlackBerry][FullScreen] Remove the set/reset of touch modes code when entering/leaving fullscreen
- https://bugs.webkit.org/show_bug.cgi?id=92520
- PR #184511
- Reviewed by Yong Li.
- Internally reviewed by Gen Mak.
- Remove touch mode set/reset when entering/leaving fullscreen
- for media elements through the new FULLSCREEN_API code path.
- The client now handles it.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-08-07 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Add missing include in FrameLoaderClienBlackBerry after Base64 moved.
- https://bugs.webkit.org/show_bug.cgi?id=93383
- Reviewed by Rob Buis.
- Base64 moved from platform/text to wtf/text, need to add mssing
- include.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 2012-08-07 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] InspectorOverlay class duplicated in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=93124
- Reviewed by Rob Buis.
- Moved files to better align with namespace names.
- * WebKitSupport/InspectorOverlay.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp.
- (WebKit):
- (BlackBerry::WebKit::InspectorOverlay::create):
- (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
- (BlackBerry::WebKit::InspectorOverlay::paintContents):
- (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
- (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
- (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::clear):
- (BlackBerry::WebKit::InspectorOverlay::update):
- * WebKitSupport/InspectorOverlay.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h.
- (WebCore):
- (WebKit):
- (InspectorOverlay):
- (InspectorOverlayClient):
- (BlackBerry::WebKit::InspectorOverlay::setClient):
- (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
- 2012-08-07 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Update API for spell checking suggestions.
- https://bugs.webkit.org/show_bug.cgi?id=93356
- Reviewed by Antonio Gomes.
- PR 163283.
- Add connections for updated spell checking options request API. Move
- all this logic into InputHandler.
- Reviewed Internally by Gen Mak and Nima Ghanavatian.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- * WebKitSupport/InputHandler.h:
- (Platform):
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-08-06 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] About: shows PAGE_CACHE not enabled.
- https://bugs.webkit.org/show_bug.cgi?id=93216
- Reviewed by Antonio Gomes.
- Page cache is a feature that can be enabled/disabled at runtime, there's no
- MACRO named PAGE_CACHE to control the feature.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-08-03 Yong Li <yoli@rim.com>
- [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
- https://bugs.webkit.org/show_bug.cgi?id=93141
- Reviewed by Rob Buis.
- PR# 172041.
- It is not always safe to render the page at this point. So we post a message
- instead.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-08-03 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] InspectorOverlay class duplicated in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=93124
- Reviewed by Rob Buis.
- Changed namespace of InspectorOverlay from WebCore to
- BlackBerry::WebKit
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- * WebCoreSupport/InspectorOverlay.cpp:
- (BlackBerry::WebKit::InspectorOverlay::create):
- (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
- (BlackBerry::WebKit::InspectorOverlay::paintContents):
- (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
- (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
- (BlackBerry::WebKit::InspectorOverlay::contentsVisible):
- (BlackBerry::WebKit::InspectorOverlay::update):
- * WebCoreSupport/InspectorOverlay.h:
- (WebKit):
- (InspectorOverlayClient):
- (InspectorOverlay):
- (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
- 2012-08-03 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Overlays display checkerboard that doesn't resolve
- https://bugs.webkit.org/show_bug.cgi?id=93099
- Reviewed by Antonio Gomes.
- The WebKit-thread overlays, like tap highlight, inspector highlight and
- selection are all part of a separate graphics layer tree rooted in
- WebPagePrivate::m_overlayLayer.
- When LayerRenderer needs to schedule a commit to reactively render
- tiles and resolve checkerboard, it does so through the root layer.
- Since the overlay layer root didn't have a GraphicsLayerClient, there
- was no implementation of GraphicsLayerClient::notifySyncRequired() to
- call, and a commit was never scheduled, thus checkerboard never
- resolved.
- Fixed by adding a fallback implementation of GraphicsLayerClient in
- WebPagePrivate and hooking up the overlay root to it. Also, this
- implementation can be shared by the various overlays to avoide code
- duplication, specifically to implement notifySyncRequired(),
- showDebugBorders() and showRepaintCounter() only once.
- Fixing this revealed a bug where the web page would get stuck in an
- endless sequence of commits. It turned out that
- WebPagePrivate::updateDelegatedOverlays() was called right in the
- middle of the commit operation, after performing the webkit thread part
- of the commit operation but before we continued on the compositing
- thread. Since updateDelegatedOverlays() typically mutates layers, this
- is very bad (layers should not be mutated mid-commit). The mutations
- also cause a new commit to scheduled from within the current, which
- results in an endless sequence of commits.
- Fixed this latter bug by moving the updateDelegatedOverlays() call to
- the beginning of the method where it can cause no harm. This is before
- we mark the web page as no longer needing commit, so even if the
- implementation flips the "needs commit" bit, we will immediately flip
- it back and proceed with commit as usual.
- PR 187458, 184377
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::notifySyncRequired):
- (BlackBerry::WebKit::WebPagePrivate::showDebugBorders):
- (BlackBerry::WebKit::WebPagePrivate::showRepaintCounter):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
- (BlackBerry::WebKit::WebPagePrivate::paintContents):
- * WebCoreSupport/InspectorOverlay.cpp:
- (WebCore::InspectorOverlay::notifySyncRequired):
- (WebCore::InspectorOverlay::showDebugBorders):
- (WebCore::InspectorOverlay::showRepaintCounter):
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
- (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
- (WebKit):
- (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
- (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
- (WebKit):
- (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
- * WebKitSupport/SelectionOverlay.h:
- (SelectionOverlay):
- 2012-08-02 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add default implementation of GraphicsLayerClient::contentsVisible()
- https://bugs.webkit.org/show_bug.cgi?id=93036
- Reviewed by George Staikos.
- Remove implementation of GraphicsLayerClient::contentsVisible() now
- that it has a default implementation.
- This also fixes a bug where memory usage for the inspector highlight
- overlay would balloon because it returned true from contentsVisible()
- which would cause the LayerTiler to populate all tiles. The default
- implementation returns false instead.
- PR 187458, 184377
- * WebCoreSupport/InspectorOverlay.cpp:
- (WebCore::InspectorOverlay::showRepaintCounter):
- * WebCoreSupport/InspectorOverlay.h:
- (InspectorOverlay):
- * WebKitSupport/DefaultTapHighlight.h:
- * WebKitSupport/SelectionOverlay.h:
- 2012-08-02 Antonio Gomes <agomes@rim.com>
- Unreviewed debug build fix (bug 92889)
- * WebKitSupport/InRegionScroller.cpp:
- (BlackBerry::WebKit::pushBackInRegionScrollable):
- 2012-08-02 Leo Yang <leoyang@rim.com>
- [BlackBerry] Rounding error of destination rect of checkerboard
- https://bugs.webkit.org/show_bug.cgi?id=93012
- Reviewed by Rob Buis.
- Reviewed internally by Jakob Petsovits.
- Intersect with the destination rectangle to eliminate the rounding error.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- 2012-08-01 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Implement InRegionScroller class as a in-region scroll controller
- https://bugs.webkit.org/show_bug.cgi?id=92889
- PR #186587
- Reviewed by Yong Li.
- Internally reviewed by Arvid Nilsson.
- Moved all in-region scrolling code out of WebPagePrivate to the just
- created InRegionScroller class. This class aims to:
- 1) Centralize all in-region scroll code and clean up WebPagePrivate as a consequence.
- 2) Be the bases to add UI/Compositing thread driven scrolls to in-region.
- The patch does not change any functionallity change.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::scrollBy):
- (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
- (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::layer):
- * WebKitSupport/InRegionScroller.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::canScrollInnerFrame):
- (BlackBerry::WebKit::canScrollRenderBox):
- (BlackBerry::WebKit::parentLayer):
- (BlackBerry::WebKit::enclosingLayerNode):
- (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
- (BlackBerry::WebKit::pushBackInRegionScrollable):
- (BlackBerry::WebKit::InRegionScroller::InRegionScroller):
- (BlackBerry::WebKit::InRegionScroller::setNode):
- (BlackBerry::WebKit::InRegionScroller::node):
- (BlackBerry::WebKit::InRegionScroller::reset):
- (BlackBerry::WebKit::InRegionScroller::isNull):
- (BlackBerry::WebKit::InRegionScroller::scrollBy):
- (BlackBerry::WebKit::InRegionScroller::inRegionScrollableAreasForPoint):
- (BlackBerry::WebKit::InRegionScroller::scrollNodeRecursively):
- (BlackBerry::WebKit::InRegionScroller::scrollRenderer):
- (BlackBerry::WebKit::InRegionScroller::adjustScrollDelta):
- * WebKitSupport/InRegionScroller.h: Added.
- (WebCore):
- (WebKit):
- (InRegionScroller):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 2012-08-01 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Favicon should be Base64 encoded for cross-process passing
- https://bugs.webkit.org/show_bug.cgi?id=92857
- Reviewed by George Staikos.
- The current implementation just passes the internal of SkPixels data to the client,
- which can't be passed accross the process boundary to chrome for processing.
- This patch makes the favicon Base64 encoded so that can be passed to chrome in another process.
- * Api/WebPageClient.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- 2012-08-01 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Allow client side to add and remove origin access whitelist entries
- https://bugs.webkit.org/show_bug.cgi?id=92790
- Reviewed by Yong Li.
- PR: 172658
- Add two new APIs to add and remove origin access whitelist entries.
- Initialize the BlackBerryAllowCrossSiteRequests WebSetting to false.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
- (WebKit):
- (BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
- (BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- 2012-08-01 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Consolidate suppression of keyboard requests.
- https://bugs.webkit.org/show_bug.cgi?id=92871
- Reviewed by Antonio Gomes.
- Reduce VKB requests even more by applying the filter on
- all requests during processing.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- 2012-08-01 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Disable tap highlight when transparent color is specified
- https://bugs.webkit.org/show_bug.cgi?id=92849
- Reviewed by Antonio Gomes.
- When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
- or any color with alpha value 0, we should disable the tap highlight.
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::draw):
- 2012-07-31 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Pass all file chooser settings to clients
- https://bugs.webkit.org/show_bug.cgi?id=92237
- Reviewed by Rob Buis.
- Expose all file chooser settings to clients.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::runOpenPanel):
- 2012-07-31 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Fix crash in InputHandler spell checking.
- https://bugs.webkit.org/show_bug.cgi?id=92763
- Reviewed by Antonio Gomes.
- PR 185574.
- Fix crash in getSpellChecker by guarding the calling paths
- to ensure that m_currentFocusElement is valid.
- Also add ASSERTs for previous crash.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::getSpellChecker):
- 2012-07-31 Genevieve Mak <gmak@rim.com>
- Send an onContextMenu event to the page content
- so that context menus can be prevented. We use
- the node's event handler because we want to use
- the fat finger's node. If we use the EventHandler's
- sendContextMenuEvent it will hit test with the mouse
- position which may not be what we want.
- PR #184032
- https://bugs.webkit.org/show_bug.cgi?id=92766
- Reviewed by Antonio Gomes.
- Reviewed Internally by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- 2012-07-31 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Backing store output flickers when using WebPageCompositor
- https://bugs.webkit.org/show_bug.cgi?id=90291
- Reviewed by Antonio Gomes.
- The backing store doesn't know when the API client swaps the buffers,
- so it doesn't know when to signal the blit generation condition
- variable. Fixed by using EGL fence sync instead, when available, so we
- don't have to know.
- Reviewed internally by Filip Spacek.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * WebKitSupport/BackingStoreTile.cpp:
- (BlackBerry::WebKit::TileBuffer::TileBuffer):
- * WebKitSupport/BackingStoreTile.h:
- (BlackBerry::WebKit::TileBuffer::syncObject):
- (BlackBerry::WebKit::TileBuffer::setSyncObject):
- (TileBuffer):
- * WebKitSupport/SurfacePool.cpp:
- (WebKit):
- (BlackBerry::WebKit::SurfacePool::SurfacePool):
- (BlackBerry::WebKit::SurfacePool::initialize):
- (BlackBerry::WebKit::SurfacePool::waitForBuffer):
- (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- * WebKitSupport/SurfacePool.h:
- (SurfacePool):
- 2012-07-30 Yoshifumi Inoue <yosin@chromium.org>
- [Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
- https://bugs.webkit.org/show_bug.cgi?id=92612
- Reviewed by Kent Tamura.
- This patch replaces Element::isReadOnlyFormControl() to
- HTMLFormControlElement::readOnly() for preparation of introducing
- Element::shouldMatchReadWriteSelector(), bug 92602.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().
- 2012-07-30 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Optimize the generation of selection details generation.
- https://bugs.webkit.org/show_bug.cgi?id=92522
- Reviewed by Antonio Gomes.
- PR 179264.
- Reduce the number of times we generate selection details notifications.
- This removes several notifications that are handled by the standard
- notification path and makes skipping duplicate notifications the default
- so that only those that must generate a response do.
- Reviewed Internally by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
- (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2012-07-30 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Adapt to changes in the SharedArray platform API
- https://bugs.webkit.org/show_bug.cgi?id=92631
- Reviewed by Rob Buis.
- Adapt to changes in the SharedArray platform API. No behavioural change.
- Reviewed internally by Joe Mason.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::getBackForwardList):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::runOpenPanel):
- 2012-07-30 Patrick Gansterer <paroga@webkit.org>
- Replace UnicodeWinCE with UnicodeWchar
- https://bugs.webkit.org/show_bug.cgi?id=92539
- Reviewed by Ryosuke Niwa.
- UnicodeWinCE never contained WinCE specific code. UnicodeWchar
- is a replacement for it, which is mainly based on the functions
- from <wchar.h>. It is ment as a minimal Unicode backend, which
- can be used very easy and has no external dependencies.
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2012-07-27 Eli Fidler <efidler@rim.com>
- [BlackBerry] Adapt to change in the FontInfo platform API.
- https://bugs.webkit.org/show_bug.cgi?id=92547
- Reviewed by Yong Li
- RIM PR 161263
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- 2012-07-27 Yong Li <yoli@rim.com>
- [BlackBerry] Should support onbeforeunload event and show confirmation dialog
- https://bugs.webkit.org/show_bug.cgi?id=92510
- Reviewed by Antonio Gomes.
- RIM PR# 155878.
- 1. Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
- 2. Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
- (WebKit):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
- (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
- 2012-07-27 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
- https://bugs.webkit.org/show_bug.cgi?id=92508
- Reviewed by Yong Li.
- Replace common uses of malloc with fastMalloc rather
- than trying to recover gracefully. If we are truly
- out of memory, crash before corruption occurs.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::extractedTextRequest):
- 2012-07-26 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Remove synchronous spellchecking code
- https://bugs.webkit.org/show_bug.cgi?id=92415
- Removing synchronous spellchecking code path.
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- * Api/WebPageClient.h:
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::checkSpellingOfString):
- 2012-07-26 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Support async spellcheck for the blackberry port
- https://bugs.webkit.org/show_bug.cgi?id=92160
- PR124517
- Implementing support for async spellcheck.
- Reviewed by Rob Buis.
- Internally reviewed by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
- (WebKit):
- (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebPage.h:
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
- (BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):
- * Api/WebSettings.h:
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore):
- (WebCore::EditorClientBlackBerry::requestCheckingOfString):
- (WebCore::EditorClientBlackBerry::checkTextOfParagraph):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- (BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
- (BlackBerry::WebKit::InputHandler::getSpellChecker):
- * WebKitSupport/InputHandler.h:
- (WebCore):
- (InputHandler):
- 2012-07-26 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Improve the logs in Selection Handler.
- https://bugs.webkit.org/show_bug.cgi?id=92405
- Reviewed by Rob Buis.
- Clean up selection logging, fix priority and style
- of helper function.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-07-26 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add timing logs to SelectionHandler.
- https://bugs.webkit.org/show_bug.cgi?id=92404
- Reviewed by Rob Buis.
- Add selection timing logs.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2012-07-26 Mike Fenton <mifenton@rim.com>
- [BlackBerry] InputHandler failure logs should be logAlways and critical.
- https://bugs.webkit.org/show_bug.cgi?id=92403
- Reviewed by Rob Buis.
- Update Log level for failures and fix mask in log.
- Reviewed Internally by Nima Ghanavatian.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWchar):
- (BlackBerry::WebKit::convertStringToWcharVector):
- (BlackBerry::WebKit::convertSpannableStringToString):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::setTextAttributes):
- 2012-07-26 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion() to avoid touching tile frontbuffer
- https://bugs.webkit.org/show_bug.cgi?id=92095
- Reviewed by George Staikos.
- PR: 141439
- Specifically, we want to avoid changing the rendered region of the
- front buffer without proper synchronization.
- The method is trying to force checkerboard to appear on screen because
- an area was invalidated but the render job was dropped, so the tile
- contents are now invalid.
- Unfortunately it did this in a way which is not thread safe. Fixed by
- making it thread safe, in a way that minimizes memory bandwidth usage.
- Instead of using the customary sequence of copy-back, modify and swap,
- we send a synchronous message to the compositing thread to avoid the
- copy-back step and save memory bandwidth. The trade-off is that the
- WebKit thread might wait a little longer for the compositing thread
- than it would from a waitForCurrentMessage() call.
- The way we synchronize this is rather expensive for the WebKit thread,
- and this method is called rather carelessly, so add various early
- returns to avoid doing it redundantly.
- Internally reviewed by Jakob Petsovits and Adam Treat.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
- (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2012-07-26 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
- https://bugs.webkit.org/show_bug.cgi?id=91989
- Reviewed by George Staikos.
- PR: 141439
- Specifically, we want to avoid changing the rendered region of the
- front buffer. The code only touched the front buffer rendered region
- if the tile was not committed.
- Instead of immediately marking the tile as committed, and clearing the
- front buffer's rendered region to make it appear as checkerboard, we
- leave the front buffer alone and only mark the tile as committed once
- the front buffer has valid content. Un-committed tiles will also be
- rendered as checkerboard, so leaving it uncommitted is equivalent to
- clearing the front buffer rendered region here.
- In addition to the main change, some related changes follow naturally.
- The copyPreviousContentsToBackSurfaceOfTile() call only makes sense if
- the tile is committed, and the front buffer has valid content.
- Otherwise, clearing the back buffer is equivalent. The code has been
- updated to this effect.
- Since copyPreviousContentsToBackSurfaceOfTile() always sets the
- rendered region to the union of the front and back buffer regions,
- there is no point in the "backBufferIsValid" check. It has been turned
- into an ASSERT instead, just to make sure.
- Internally reviewed by Jakob Petsovits.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- 2012-07-25 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Support RTSP in browser
- https://bugs.webkit.org/show_bug.cgi?id=92233
- Reviewed by Rob Buis.
- Handle URL scheme "rtsp://" before creating the DocumentLoader
- and send the request to webkit. As we don't have any application
- which can deal with rtsp invocation for now, we need to create
- a media document to wrap the rtsp url within a video tag which
- makes it load as a normal video clip.
- RIM PR: 169669
- Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
- 2012-07-25 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Rephrase suspend/resume condition to guard against crashes
- https://bugs.webkit.org/show_bug.cgi?id=92300
- PR 182125
- Reviewed by George Staikos.
- When the compositor is removed from a WebPage, it might
- already have unset its context, and issuing a call to
- BackingStore::buffer() would therefore cause a crash.
- Just guarding buffer() from this crash isn't fully
- correct, because then we wouldn't suspend rendering
- for a compositor that had been previously enabled.
- Instead, change the condition to suspend/resume in
- WebPagePrivate::setCompositor() to focus on the
- object that delivers us the buffer. If we can't
- listen to the context or buffer being set, better
- just take the compositor object itself to determine
- whether we have something valid or not... and hope
- that they give us a valid context & buffer in all
- situations when we can actually be rendering.
- Also check compositor->context() in buffer() to be
- non-zero before accessing the context's buffer,
- because more defensive coding can't hurt here.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::buffer):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- 2012-07-25 Joshua Netterfield <jnetterfield@rim.com>
- [BlackBerry] Update about:config lists
- https://bugs.webkit.org/show_bug.cgi?id=92118
- Reviewed by Rob Buis.
- Remove features from list that have either been removed from WebKit
- or that have been moved from one list to another.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutDataHaveFeatures.in:
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2012-07-25 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
- https://bugs.webkit.org/show_bug.cgi?id=91898
- Reviewed by Yong Li.
- Let pthread condition variable in BackingStore.cpp use monotonic clock
- to fix a regression caused by r123266.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- 2012-07-25 Andy Chen <andchen@rim.com>
- [BlackBerry] Add "SelectAll" to WebPage
- https://bugs.webkit.org/show_bug.cgi?id=92246
- Reviewed by Antonio Gomes.
- Add "Select All" editor command to WebPage.
- Internally reviewed by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::selectAll):
- (WebKit):
- * Api/WebPage.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::selectAll):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- 2012-07-25 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
- https://bugs.webkit.org/show_bug.cgi?id=91992
- Reviewed by Adam Treat.
- PR: 141439
- The copyPreviousContentsToBackSurfaceOfTile() call will also modify
- buffer contents, move it after the blit generation condvar to make sure
- we've waited for the buffer to become available first.
- This is done as part of some general BackingStorePrivate::render()
- cleanup in PR 141439.
- Internally reviewed by Jakob Petsovits.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- 2012-07-25 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] notifyContentRendered() call missing in two spots
- https://bugs.webkit.org/show_bug.cgi?id=92153
- RIM PR 173340
- Reviewed by Antonio Gomes.
- In dispatchDidFirstVisualLayout() and repaint() in
- immediate mode, we render but don't notify the
- WebPageClient that the content was modified.
- In the long run, we should probably keep track of
- the modified reason from within render() itself
- and use this to automatically notify the client
- from within blitContents() and/or invalidateWindow(),
- depending on the rendering path. That's somewhat of
- a medium-size undertaking though; for now, adding
- the call directly to the renderVisibleContents()
- call sites will do.
- This patch also adds a blitVisibleContents() to
- dispatchDidFirstVisualLayout() where it was
- inexplicably missing, probably on account of
- old code that was never updated.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::repaint):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
- 2012-07-24 Rob Buis <rbuis@rim.com>
- [BlackBerry] Do not call settings setters twice on page construction
- https://bugs.webkit.org/show_bug.cgi?id=92157
- Reviewed by Yong Li.
- The WebPagePrivate init method sets some settings value that were
- already set in didChangeSettings. setUseHixie76WebSocketProtocol just
- sets the default value, no need to set it again.
- Also call didChangeSettings explicitly from init, before that we are
- not calling it since the delegate is not set yet.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-07-24 Mike Fenton <mifenton@rim.com>
- Throttle calls to request the virtual keyboard be shown.
- https://bugs.webkit.org/show_bug.cgi?id=92138
- Reviewed by Rob Buis.
- PR 178465.
- Do not request keyboard visibility change when
- we are actively processing an input event.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- 2012-07-24 Joshua Netterfield <jnetterfield@rim.com>
- [BlackBerry] Update about:config lists
- https://bugs.webkit.org/show_bug.cgi?id=92118
- Reviewed by Rob Buis.
- We want to have all flags which could be used / have been used by any platform. These lists were created by running:
- * WebCoreSupport/AboutDataEnableFeatures.in: `git grep "ENABLE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
- * WebCoreSupport/AboutDataHaveFeatures.in: `git grep "HAVE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
- * WebCoreSupport/AboutDataUseFeatures.in: `git grep "USE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
- 2012-07-24 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Remove unused variable in BackingStore.cpp
- https://bugs.webkit.org/show_bug.cgi?id=91987
- Reviewed by Antonio Gomes.
- PR: 141439
- This is done as part of some general BackingStorePrivate::render()
- cleanup in PR 141439.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- 2012-07-23 Yong Li <yoli@rim.com>
- [BlackBerry] Move about: URL handling out of WebCore
- https://bugs.webkit.org/show_bug.cgi?id=91541
- Reviewed by Rob Buis.
- PR# 181304.
- Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
- reload and history navigation can work.
- Other changes: Remove about:version which makes little sense. Make about:memory partially visible.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()
- * Api/WebPage_p.h: Remove loadAbout()
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.
- * WebKitSupport/AboutData.cpp:
- (BlackBerry::WebKit::numberToHTMLTr): Make it static
- (BlackBerry::WebKit::configPage): Make it static
- (BlackBerry::WebKit::memoryPage): Make it static
- (BlackBerry::WebKit::cachePage):
- (BlackBerry::WebKit::buildPage):
- (BlackBerry::WebKit::creditsPage):
- (BlackBerry::WebKit::cookiePage):
- (BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
- (WebKit):
- * WebKitSupport/AboutData.h:
- (WebKit):
- 2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
- Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
- https://bugs.webkit.org/show_bug.cgi?id=91006
- Reviewed by Ryosuke Niwa.
- Removed numTouchEventHandlersChanged stub.
- * WebCoreSupport/ChromeClientBlackBerry.h:
- 2012-07-22 Kent Tamura <tkent@chromium.org>
- Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
- https://bugs.webkit.org/show_bug.cgi?id=91941
- Reviewed by Kentaro Hara.
- A flag name for an elmement should be ENABLE_*_ELEMENT.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-07-20 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
- https://bugs.webkit.org/show_bug.cgi?id=91898
- Reviewed by Yong Li.
- PR: 181043
- Use CLOCK_MONOTONIC when we do expect a monotonic timer.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- 2012-07-20 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Add Cancel button for Select popup
- https://bugs.webkit.org/show_bug.cgi?id=91887
- Reviewed by Yong Li.
- PR 177706
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- 2012-07-19 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Make sure to send favicon when go back/forward
- https://bugs.webkit.org/show_bug.cgi?id=91808
- Reviewed by George Staikos.
- When go back/forward, if the page was in page cache, it would have no chance
- to send favicon. So we'll send it in commitLoad right after send the blank
- icon.
- RIM PR# 177495
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
- 2012-07-19 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Suspend when there's no target buffer until an external compositor is set
- https://bugs.webkit.org/show_bug.cgi?id=91686
- RIM PR 174365
- Reviewed by Antonio Gomes.
- If we don't have a client window (i.e. rendering to
- GL directly) and a WebPageCompositor is only set
- after a rendering operation, then we'll try to render
- to BackingStorePrivate::buffer() which doesn't exist
- at this point. That's bad, and gets us various
- assertions and possibly worse.
- Fix it by starting in a screen-suspended state and only
- resuming screen and backingstore once a compositor is
- actually set.
- So, in effect, with this patch applied, the sequence
- of events will look like this:
- 1) WebPage & BackingStore are initialize, neither window
- nor compositor exists, therefore buffer() returns 0.
- createSurface() therefore suspends screen and
- backingstore.
- 2) loadURL() or loadData() is called, web page is
- fully loaded, however we don't try to render because
- we're still suspended, still have no target buffer.
- 3) A WebPageCompositor is being set from outside.
- At the beginning of WebPage::setCompositor() we still
- don't have a buffer() so there's nothing to suspend,
- however, after the sync call to setCompositorHelper()
- the compositor is set so buffer() will return a
- nonzero value, causing us to resume at this point.
- Using the existence of a target buffer to determine
- whether or not to enable rendering or keep it suspended
- seems like a good idea, and the implementation (while
- not quite perfect yet) is a step forward from before.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-07-19 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Allow nested suspend/resume screen & backingstore calls.
- https://bugs.webkit.org/show_bug.cgi?id=91644
- RIM PR 174365
- Reviewed by Adam Treat and Antonio Gomes.
- We expose suspendScreenAndBackingStoreUpdates() to the
- outside API, but also use it internally when reacting
- to a number of happenings, i.e. zooming, viewport resize,
- resetting view state on Committed state or when restoring
- it from previous pages, etc.
- These two can clash. For instance, if we get a suspend
- call from outside that suspends us for app inactivity,
- or we are told to suspend because the main target surface
- is not available at the time, and while being suspended
- we try to rotate, finish loading a page, the we'll end up
- resuming operations even though we shouldn't.
- This patch changes the suspend flag to be a counter
- instead, allowing nested suspend/resume calls and making
- suspend/resume more robust this way. It also changes
- several call sites to make sure suspend/resume calls are
- paired up correctly.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPointTimerFired):
- (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-07-18 Yong Li <yoli@rim.com>
- [BlackBerry] Move about: URL handling out of WebCore
- https://bugs.webkit.org/show_bug.cgi?id=91541
- Reviewed by Rob Buis.
- Move about URL handling code to WebKit/blackberry. Now when WebPage is asked to load an about URL,
- it directly calls loadString() with the generated source.
- Also move AboutData.h/cpp from WebCoreSupport to WebKitSupport and change their namespace from WebCore
- to BlackBerry::WebKit.
- The change is very mechanical except "procss total memory usage" in about:memory now only accounts used
- bytes and ignore free spaces in malloc.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::loadAbout):
- (WebKit):
- (BlackBerry::WebKit::WebPage::load):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/AboutData.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp.
- (WebKit):
- (BlackBerry::WebKit::writeFeatures):
- (BlackBerry::WebKit::numberToHTMLTr):
- (BlackBerry::WebKit::bool):
- (BlackBerry::WebKit::configPage):
- (BlackBerry::WebKit::cacheTypeStatisticToHTMLTr):
- (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
- (BlackBerry::WebKit::memoryPage):
- * WebKitSupport/AboutData.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.h.
- (WebKit):
- 2012-07-17 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Remove unnecessary clearWindow() calls and the method itself
- https://bugs.webkit.org/show_bug.cgi?id=91540
- RIM PR 174365
- Reviewed by Adam Treat.
- If we resume the backingstore right afterwards with
- RenderAndBlit then that'll fill the whole visible area
- with content, making a clearWindow() call unnecessary.
- This call is a remnant from ages ago, and is well suited
- to disappear into nothingness.
- (There is still a clearWindow() call, with rect argument,
- which we continue using. This commit only removes the
- rect-less version.)
- * Api/BackingStore.cpp:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- 2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
- Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
- https://bugs.webkit.org/show_bug.cgi?id=91196
- Reviewed by Pavel Feldman.
- Refactoring InspectorClients. InspectorClient::openInspectorFrontend
- now returning the InspectorFrontendChannel.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::enableWebInspector):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::openInspectorFrontend):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- 2012-07-17 Chris Guan <chris.guan@torchmobile.com.cn>
- [BlackBerry] Enable registerProtocolHandler for Blackberry
- https://bugs.webkit.org/show_bug.cgi?id=90422
- Reviewed by George Staikos.
- Implements APIs were added in Custom Scheme Handler specification
- which is at http://dev.w3.org/html5/spec/Overview.html#custom-handlers.
- Test cases:
- fast/dom/register-protocol-handler.html
- fast/dom/unregister-protocol-handler.html
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
- (WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
- (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-07-16 Benjamin C Meyer <bmeyer@rim.com>
- Any webpage can crash webkit via qnx.callExtensionMethod assuming 'this' is the 'qnx' object.
- https://bugs.webkit.org/show_bug.cgi?id=91419
- Run the following in inspector to crash WebKit
- qnx.callExtensionMethod.apply(window, []);
- In the c++ that handles the function it assumes that when callExtensionMethod
- is called that 'this' is the object 'qnx'. The qnx object has a hidden
- variable that the code casts and uses, but when 'this' is not qnx such as the
- example this will cause a crash. Any website can insert the above JavaScript
- to cause the crash.
- Reviewed by Yong Li.
- * WebCoreSupport/ClientExtension.cpp:
- (clientExtensionMethod):
- 2012-07-16 Yong Li <yoli@rim.com>
- [BlackBerry] Improve about:memory page
- https://bugs.webkit.org/show_bug.cgi?id=87676
- Reviewed by Rob Buis.
- Add a table for process memory usage summary for easy read.
- * WebCoreSupport/AboutData.cpp:
- (WebCore::memoryPage):
- 2012-07-16 Kihong Kwon <kihong.kwon@samsung.com>
- Remove setController from BatteryClient
- https://bugs.webkit.org/show_bug.cgi?id=90944
- Reviewed by Adam Barth.
- BatteryClient doesn't need to keep m_controller,
- because BatteryController can be accessed using BatteryController::from().
- Remove m_controller and Add webPagePrivate to BatteryClientBlackBerry.
- And change all m_controller to BatteryController::from.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/BatteryClientBlackBerry.cpp:
- (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
- (WebCore::BatteryClientBlackBerry::onLevelChange):
- (WebCore::BatteryClientBlackBerry::onChargingChange):
- (WebCore::BatteryClientBlackBerry::onChargingTimeChange):
- (WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
- * WebCoreSupport/BatteryClientBlackBerry.h:
- (BatteryClientBlackBerry):
- 2012-07-16 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Text selection with touch hold does not start on text field in some cases
- https://bugs.webkit.org/show_bug.cgi?id=91267
- Reviewed by Antonio Gomes.
- Input fields host node is by spec non-editable unless the field itself has content editable enabled.
- We enable selection if the shadow tree for the input field is selectable.
- PR # 173450
- Reviewed Internally by Mike Fenton.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2012-07-15 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Move icon database to application data directory.
- https://bugs.webkit.org/show_bug.cgi?id=91195
- Reviewed by Rob Buis.
- RIM PR: 156852
- Create icon database in application data directory instead of
- database or local storage directory, by doing this we can make
- things easier when clearing database or local storage data files.
- Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>
- * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
- (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
- 2012-07-13 Xianzhu Wang <wangxianzhu@chromium.org>
- Move WebCore/platform/text/Base64 to WTF/wtf/text
- https://bugs.webkit.org/show_bug.cgi?id=91162
- Reviewed by Adam Barth.
- * Api/WebKitTextCodec.cpp:
- (BlackBerry::WebKit::base64DecodePolicyForWTF):
- (BlackBerry::WebKit::base64Decode):
- (BlackBerry::WebKit::base64EncodePolicyForWTF):
- (BlackBerry::WebKit::base64Encode):
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 2012-07-13 George Staikos <staikos@webkit.org>
- [BlackBerry] Fix crash due to unguarded use of renderer in select
- popup.
- https://bugs.webkit.org/show_bug.cgi?id=91287
- Reviewed by Rob Buis.
- No known testcase for this. Found in the wild.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- 2012-07-13 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add support for attributes to define keyboard and enter key type on the Virtual Keyboard
- https://bugs.webkit.org/show_bug.cgi?id=91248
- Reviewed by Antonio Gomes.
- PR 174733.
- Add data-blackberry-virtual-keyboard-type and
- data-blackberry-virtual-keyboard-enter-key to
- enable configuration of the desired virtual keyboard
- using element attributes.
- Reviewed Internally by Gen Mak.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToKeyboardType):
- (WebKit):
- (BlackBerry::WebKit::keyboardTypeAttribute):
- (BlackBerry::WebKit::convertStringToKeyboardEnterKeyType):
- (BlackBerry::WebKit::keyboardEnterKeyTypeAttribute):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- 2012-07-13 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
- https://bugs.webkit.org/show_bug.cgi?id=91247
- Reviewed by Antonio Gomes.
- PR: 175432
- On yahoo.com, the web page stopped zooming while trying to pinch as
- WebPageClient::resetBitmapZoomScale(double) was being called by
- WebPagePrivate::zoomToInitialScaleOnLoad() after load finished.
- And also yahoo.com was keeping updating layout, which made it really
- bad that zoomToInitialScaleOnLoad() was called many times when load
- finished and the load type was FrameLoadTypeStandard or FrameLoadTypeSame.
- As we only care about the situation that dispatchDidFirstVisuallyNonEmptyLayout()
- happens after load finished, we can move the code to that method and
- set a flag for WebPage layoutFinished() and zoomToInitialScaleOnLoad()
- instead. In this way, we can ensure that the flag is only enabled when
- dispatchDidFirstVisuallyNonEmptyLayout() is called after load finished
- and get rid of calling zoomToInitialScaleOnLoad() lots of times when
- keeping updating layout in such kind of situation.
- Internally reviewed by Arvid Nilsson
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
- (BlackBerry::WebKit::WebPagePrivate::setShouldZoomToInitialScaleAfterLoadFinished):
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
- 2012-07-13 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Use fillBuffer() instead of a user-defined background image.
- https://bugs.webkit.org/show_bug.cgi?id=91180
- RIM PR 171458
- Reviewed by Rob Buis.
- Internally reviewed by Andrew Lo.
- By using Platform::Graphics::fillBuffer() to fill the
- overscroll area, we save graphics memory for the buffer
- that the background image was occupying.
- Also adapt checkerboard drawing as it is now done using
- fillBuffer() which replaces checkerBuffer().
- In the same go, use the opportunity of the WebSettings
- API change to make it more consistent, renaming the
- OverZoomColor setting to OverScrollColor.
- * Api/BackingStore.cpp:
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::overScrollColor):
- (BlackBerry::WebKit::WebSettings::setOverScrollColor):
- (BlackBerry::WebKit::WebSettings::isEnableDefaultOverScrollBackground):
- (BlackBerry::WebKit::WebSettings::setEnableDefaultOverScrollBackground):
- * Api/WebSettings.h:
- 2012-07-13 Joshua Netterfield <jnetterfield@rim.com>
- [BlackBerry] Update about:* pages
- https://bugs.webkit.org/show_bug.cgi?id=91121
- Reviewed by Yong Li.
- Update the about:config pages, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.
- No new tests, because there is no new funtionality.
- * WebCoreSupport/AboutData.cpp:
- (WebCore):
- (WebCore::writeFeatures):
- (WebCore::numberToHTMLTr): Converted to template function, added bool specialization to write "true" and "false" instead of "1" and "0"
- (WebCore::configPage):
- (WebCore::memoryPage):
- * WebCoreSupport/AboutTemplate.html.cpp: Template for BlackBerry about:* pages.
- 2012-07-12 Benjamin C Meyer <bmeyer@rim.com>
- WebPage::executeJavaScriptFunction crashes when there is an exception
- https://bugs.webkit.org/show_bug.cgi?id=91098
- RIM PR #149294
- When there is an exception currently the code tries to get the string of
- the exception via JSValueToStringCopy to pass back, but this cases a
- crash inside JavaScriptCore, so change it to simply return false and not
- set the return value with the exception string.
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 2012-07-12 Pawel Chomicki <pchomicki@rim.com>
- [BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
- https://bugs.webkit.org/show_bug.cgi?id=91002
- Reviewed by Antonio Gomes.
- Reviewed internally by Genevieve Mak.
- Updated DEBUG_TOUCH_EVENTS section of touchEvent method to utilize
- Platform::TouchEvent's toString method.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchEvent):
- 2012-07-12 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time
- https://bugs.webkit.org/show_bug.cgi?id=91054
- Reviewed by George Staikos.
- Implemented interface function syncProxyCredential() derived
- from class PageClientBlackBerry.
- Internally reviewed by Jason Liu <jason.liu@torchmobile.com.cn>
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
- (WebKit):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-07-11 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] UserViewportArguments are not properly respected.
- https://bugs.webkit.org/show_bug.cgi?id=91005
- Reviewed by Rob Buis.
- PR# 170088.
- Move scale and zooming reset on Committed before applying
- the user viewport to avoid overriding it immediately.
- Internal review by Konrad Piascik, Jacky Jiang.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 2012-07-11 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Implement Date/Time picker
- https://bugs.webkit.org/show_bug.cgi?id=90911
- Reviewed by Rob Buis.
- Implement HTML Date/Time picker, also should delete popup when closing popup.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::closePagePopup):
- * WebCoreSupport/DatePickerClient.cpp: Added.
- (WebCore):
- (WebCore::DatePickerClient::DatePickerClient):
- (WebCore::DatePickerClient::~DatePickerClient):
- (WebCore::DatePickerClient::generateHTML):
- (WebCore::DatePickerClient::closePopup):
- (WebCore::DatePickerClient::contentSize):
- (WebCore::DatePickerClient::htmlSource):
- (WebCore::DatePickerClient::setValueAndClosePopup):
- (WebCore::DatePickerClient::didClosePopup):
- (WebCore::DatePickerClient::writeDocument):
- * WebCoreSupport/DatePickerClient.h: Added.
- (WebKit):
- (WebCore):
- (DatePickerClient):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openDatePopup):
- 2012-07-10 Adam Barth <abarth@webkit.org>
- WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
- https://bugs.webkit.org/show_bug.cgi?id=90910
- Reviewed by Eric Seidel.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-07-10 Adam Barth <abarth@webkit.org>
- LayoutTestController.dumpConfigurationForViewport should move to Internals
- https://bugs.webkit.org/show_bug.cgi?id=45652
- Reviewed by Eric Seidel.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- * WebKitSupport/DumpRenderTreeSupport.h:
- (DumpRenderTreeSupport):
- 2012-07-09 Yong Li <yoli@rim.com>
- [BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate
- https://bugs.webkit.org/show_bug.cgi?id=90817
- Reviewed by Rob Buis.
- PR# 174085.
- PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
- This patch also removes unused variable m_parentPopup and its setter.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::closePagePopup):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
- (WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.
- 2012-07-09 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
- https://bugs.webkit.org/show_bug.cgi?id=90575
- Reviewed by Rob Buis.
- Refactor meta viewport handling to multiply the developer
- specified scale properties by the devicePixelRatio. This
- required moving the setting of these values until after
- the call to computeViewportAttributes.
- This fixes an isssue where content wider than the meta viewport
- would case a zoom-out-to-fit scenario because we misinterpreted
- the specified initial-scale.
- New test to verify wide content doesn't affect initial-scale:
- ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html
- Internal review from Konrad Piascik, Arvid Nilsson.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 2012-07-07 George Staikos <staikos@webkit.org>
- Detach animation clients properly if we clear the web page pointer.
- https://bugs.webkit.org/show_bug.cgi?id=90730
- Reviewed by Adam Treat.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::detach):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- 2012-07-06 Max Feil <mfeil@rim.com>
- [BlackBerry] exitFullScreenForElement() is not working for fullscreen elements in iframes
- https://bugs.webkit.org/show_bug.cgi?id=90327
- Reviewed by Antonio Gomes.
- Fix exit fullscreen problem for elements in iframes. The
- exitFullScreenForElement() call is passed a null element in
- this case, instead of the original element which entered
- fullscreen. If you look in Document.cpp you can see the
- exitFullScreenForElement() call being made on the topDocument
- (which has a null m_fullScreenElement) instead of the iframe's
- document.
- The Chromium and Windows ports get around this problem by
- storing either the fullscreen element or its frame during
- enterFullScreenForElement(), so I will bring the BlackBerry port
- in line with this. See also bug 89817.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-07-06 Benjamin C Meyer <bmeyer@rim.com>
- Add an API to explicitly call a JavaScript function with args.
- https://bugs.webkit.org/show_bug.cgi?id=90694
- Currently the Blackberry port doesn't expose the JavaScript
- engine to 3rd parties so they rely upon executeJavaScript
- which can be slower than necessary and unsafe as eval is used.
- This new API provides a way to explicitly call a specific
- JavaScript function with a list of args preventing the case
- where an argument comes from a untrusted source and tries to
- escape the arg list to take control of the JavaScript engine.
- In the future if the Blackberry port introduces a formal
- way to interact with the JavaScript engine this function should
- be removed.
- PR 149294
- Reviewed by Unreviewed
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- (WebKit):
- * Api/WebPage.h:
- 2012-07-05 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
- https://bugs.webkit.org/show_bug.cgi?id=90588
- Reviewed by Rob Buis.
- Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
- 2012-07-04 Hanna Ma <Hanma@rim.com>
- [BlackBerry] Implement device metrics for blackberry.
- https://bugs.webkit.org/show_bug.cgi?id=90494
- RIM PR #159034
- Reviewed by Rob Buis.
- Implement calls to the application to change the device metrics for
- the web inspector.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
- (WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
- (WebCore):
- (WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
- (WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- 2012-07-03 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Checkerboard shown when clicking on error page buttons
- https://bugs.webkit.org/show_bug.cgi?id=90152
- RIM PR #161867
- Reviewed by George Staikos.
- r121514 just made the race occur in lower possibility but can't avoid it.
- This path is using another approach to fix the problem. When we are resetting
- backingstore while committing a page we need to suspend backingstore and
- screen update to make sure no other threads can update backingstore and screen.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 2012-07-03 George Staikos <staikos@webkit.org>
- [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
- https://bugs.webkit.org/show_bug.cgi?id=90422
- Reviewed by Rob Buis.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
- (WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-07-03 George Staikos <staikos@webkit.org>
- [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
- https://bugs.webkit.org/show_bug.cgi?id=90422
- Reviewed by Rob Buis.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-07-03 Jan Keromnes <janx@linux.com>
- Web Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
- https://bugs.webkit.org/show_bug.cgi?id=89939
- Reviewed by Vsevolod Vlasov.
- * WebCoreSupport/inspectorBB.html:
- 2012-07-02 Xiaobo Wang <xbwang@torchmobile.com.cn>
- [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
- https://bugs.webkit.org/show_bug.cgi?id=90271
- Reviewed by George Staikos.
- RIM PR #154707
- Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
- defined by default.
- We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
- need to rebuild webkit before running DRT.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPage::runLayoutTests):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::addMessageToConsole):
- (WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
- (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
- (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
- (WebCore::ChromeClientBlackBerry::createWindow):
- (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
- (WebCore::ChromeClientBlackBerry::setStatusbarText):
- (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- (WebCore::ChromeClientBlackBerry::keyboardUIMode):
- 2012-07-02 George Staikos <staikos@webkit.org>
- [BlackBerry] Implement cancelVibration, and make sure it's canceled on
- destruction.
- https://bugs.webkit.org/show_bug.cgi?id=90406
- Reviewed by Rob Buis.
- * WebCoreSupport/VibrationClientBlackBerry.cpp:
- (WebCore::VibrationClientBlackBerry::cancelVibration):
- (WebCore::VibrationClientBlackBerry::vibrationDestroyed):
- 2012-07-02 Benjamin Poulain <bpoulain@apple.com>
- Do not do any logging initialization when logging is disabled
- https://bugs.webkit.org/show_bug.cgi?id=90228
- Reviewed by Simon Fraser.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- 2012-07-01 George Staikos <staikos@webkit.org>
- Clear visited links when clearing history.
- https://bugs.webkit.org/show_bug.cgi?id=90345
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::clearHistory):
- 2012-06-30 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
- https://bugs.webkit.org/show_bug.cgi?id=90241
- This issue is caused by single quotes in option's labels.
- We should use the escape character of single quotes in JavaScript's string which
- starts and ends with single quotes.
- So we replace lablels' single quotes with its escape character during generating the
- select popUp's HTML.
- Reviewed by George Staikos.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-06-30 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Allow surface resizing for use cases other than rotation.
- https://bugs.webkit.org/show_bug.cgi?id=90295
- RIM PR 171459
- Reviewed by George Staikos.
- A new API method setHasPendingSurfaceSizeChange() is
- introduced for that effect, and used inside of
- setViewportSize() to let the WebPageClient do the
- resizing. Methods are renamed to reflect that this
- is not exclusively meant for rotation anymore.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPage::setScreenOrientation):
- (WebKit):
- (BlackBerry::WebKit::WebPage::setHasPendingSurfaceSizeChange):
- (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-29 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Page jumps after post-pinch-zoom re-render
- https://bugs.webkit.org/show_bug.cgi?id=90282
- Reviewed by Antonio Gomes.
- PR: 170255
- In r120622, we moved ScrollableArea::setConstrainsScrollingToContentEdge(false|true)
- from WebPage::setScrollPosition() to BackingStorePrivate::setScrollingOrZooming()
- to address an overscroll reset issue.
- However, when we are ending bitmap zooming, UI thread can call
- BackingStorePrivate::setScrollingOrZooming(false) before WebKit thread
- calls WebPage::setScrollPosition(), in which case it will set
- ScrollableArea::m_constrainsScrollingToContentEdge to true earlier.
- To fix this, we can cache ScrollableArea::m_constrainsScrollingToContentEdge
- and always set it to false before we set scroll position in WebKit
- thread to avoid scroll position clamping during scrolling, and restore
- it to what it was after that.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setScrollPosition):
- 2012-06-29 Jakob Petsovits <jpetsovits@rim.com>
- Add blitVisibleContents() as public API.
- https://bugs.webkit.org/show_bug.cgi?id=90211
- Reviewed by Adam Treat.
- We keep blitContents() (with src/dst rectangles)
- for compatibility with older Cascades sprints for now,
- but want to switch to always blitting the full viewport
- and this is a good first step.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStore::blitVisibleContents):
- (WebKit):
- * Api/BackingStore.h:
- 2012-06-29 Konrad Piascik <kpiascik@rim.com>
- Don't hardcode target dpi of 160 (it should be 96 on desktop)
- https://bugs.webkit.org/show_bug.cgi?id=88114
- Reviewed by Adam Barth.
- Added new WebSetting to specify what the devicePixelRatio should be.
- Updated the call to computeViewportAttributes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::devicePixelRatio):
- (BlackBerry::WebKit::WebSettings::setDevicePixelRatio):
- * Api/WebSettings.h:
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::dumpConfigurationForViewport):
- 2012-06-28 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry] Selection items show as garbage for non-ascii characters.
- https://bugs.webkit.org/show_bug.cgi?id=89969
- Add charset utf-8 to the select popup's page.
- Reviewed by Antonio Gomes.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-06-28 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Checkerboard shown when clicking on error page buttons
- https://bugs.webkit.org/show_bug.cgi?id=90152
- RIM PR #161867
- Reviewed by George Staikos.
- Reset m_hasBlitJobs when resetting tiles to prevent ui thread from drawing checkerboard unintentionally.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- 2012-06-27 Andrew Lo <anlo@rim.com>
- [BlackBerry] Selection overlay can become visible after it has been hidden
- https://bugs.webkit.org/show_bug.cgi?id=90105
- Reviewed by George Staikos.
- When SelectionOverlay::hide is called from UI thread,
- rather than setting the override opacity, dispatch to the
- WebKit thread, which removes the overlay (normal case).
- Internal PR164183.
- Internally Reviewed by: Arvid Nilsson.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- (BlackBerry::WebKit::WebPage::selectionOverlay):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSelectionOverlay.h:
- * WebKitSupport/SelectionOverlay.cpp:
- (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
- (BlackBerry::WebKit::SelectionOverlay::hide):
- * WebKitSupport/SelectionOverlay.h:
- (BlackBerry::WebKit::SelectionOverlay::create):
- (SelectionOverlay):
- 2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
- JSLock should be per-JSGlobalData
- https://bugs.webkit.org/show_bug.cgi?id=89123
- Reviewed by Geoffrey Garen.
- Changed all sites that used JSLock to instead use the new JSLockHolder
- and pass in the correct JS context that the code is about to interact with that
- needs protection. Also added a couple JSLocks to places that didn't already
- have it that needed it.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- * WebCoreSupport/ClientExtension.cpp:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::installDomFunction):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
- 2012-06-27 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Wrong scale after leaving fullscreen <video>
- https://bugs.webkit.org/show_bug.cgi?id=89546
- Reviewed by Antonio Gomes.
- PR: 164948
- When we were entering fullscreen, the current scale A was clamped to a
- greater minimum scale B as we relayouted the contents during the change
- of the viewport size. When leaving fullscreen, we still used that scale
- B as the current scale which was incorrect.
- To fix this, we can save the current scale when entering fullscreen and
- restore it when leaving fullscreen.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-27 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Scale was incorrect when reloading a simple web page after initial load
- https://bugs.webkit.org/show_bug.cgi?id=88889
- Reviewed by Antonio Gomes.
- PR: 164442
- For FrameLoadTypeStandard load, the layout timer can be fired which can
- call dispatchDidFirstVisuallyNonEmptyLayout() after the load Finished
- state, in which case the web page will have no chance to zoom to
- initial scale. We should give it a chance as well as FrameLoadTypeSame
- load.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
- 2012-06-26 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add WebPage interface for Async spell check.
- https://bugs.webkit.org/show_bug.cgi?id=89999
- Reviewed by Rob Buis.
- PR 124517.
- Add interface for IMS async spell checking.
- Reviewed Internally by Nima Ghanavatian.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
- (WebKit):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (WebKit):
- (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-06-26 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Limit session storage quota to 5MB by default
- https://bugs.webkit.org/show_bug.cgi?id=89941
- Reviewed by Rob Buis.
- Limit session storage quota to 5MB by default for BlackBerry
- porting.
- Internally reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::sessionStorageQuota):
- (BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
- * Api/WebSettings.h:
- 2012-06-26 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
- https://bugs.webkit.org/show_bug.cgi?id=89960
- Reviewed by Antonio Gomes.
- We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
- HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
- in a page, even though only the one in fullscreen mode will process this.
- With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
- which is either a plugin, or an Video element.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::notifySwipeEvent):
- 2012-06-25 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Fill more data in device motion event
- https://bugs.webkit.org/show_bug.cgi?id=89857
- Reviewed by Antonio Gomes.
- Reviewed internally by Robin Cao.
- Fill acceleration and rotation rate into DeviceMotionData.
- * WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
- (DeviceMotionClientBlackBerry::onMotion):
- 2012-06-25 Yong Li <yoli@rim.com>
- [BlackBerry] Add JSC statistics into about:memory
- https://bugs.webkit.org/show_bug.cgi?id=89779
- Reviewed by Rob Buis.
- Add detailed JS memory statistics to about:memory page.
- * WebCoreSupport/AboutData.cpp:
- (WebCore::dumpJSCTypeCountSetToTableHTML):
- (WebCore):
- (WebCore::memoryPage):
- 2012-06-25 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Use AIR controls if client doesn't support HTML control
- https://bugs.webkit.org/show_bug.cgi?id=89777
- Reviewed by Yong Li.
- Currently HTML controls depend on client implementing CreateWindow event, for those clients
- that don't implement CreateWindow event, use old AIR controls so we don't break them.
- PR 163818.
- Internal reviewed by Mike Fenton.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::openPagePopup):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
- * WebCoreSupport/PagePopupBlackBerry.h:
- (PagePopupBlackBerry):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- 2012-06-25 Rob Buis <rbuis@rim.com>
- [BlackBerry] Require text editable element to be enabled for VKB
- https://bugs.webkit.org/show_bug.cgi?id=89876
- Reviewed by Yong Li.
- After bug 58837 got in, children of <fieldset> now can inherit the disabled
- state of the fieldset. When trying for instance fast/forms/fieldset/fieldset-disabled.html,
- it can be seen that when they are visually disabled, the input handling can still be triggered. So
- add an extra check to isTextBasedContentEditableElement that the element is enabled.
- Reviewed internally by Mike Fenton.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- 2012-06-24 Simon Fraser <simon.fraser@apple.com>
- Rename isPositioned to isOutOfFlowPositioned for clarity
- https://bugs.webkit.org/show_bug.cgi?id=89836
- Reviewed by Antti Koivisto.
-
- RenderObject and RenderStyle had an isPositioned() method that was
- confusing, because it excluded relative positioning. Rename to
- isOutOfFlowPositioned(), which makes it clearer that it only applies
- to absolute and fixed positioning.
- Simple rename; no behavior change.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::isPositionedContainer):
- (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
- (BlackBerry::WebKit::isFixedPositionedContainer):
- 2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r121058.
- http://trac.webkit.org/changeset/121058
- https://bugs.webkit.org/show_bug.cgi?id=89809
- Patch causes plugins tests to crash in GTK debug builds
- (Requested by zdobersek on #webkit).
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- * WebCoreSupport/ClientExtension.cpp:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::installDomFunction):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
- 2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
- JSLock should be per-JSGlobalData
- https://bugs.webkit.org/show_bug.cgi?id=89123
- Reviewed by Gavin Barraclough.
- Changed all sites that used JSLock to instead use the new JSLockHolder
- and pass in the correct JS context that the code is about to interact with that
- needs protection.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- * WebCoreSupport/ClientExtension.cpp:
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::installDomFunction):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
- 2012-06-22 Andrew Lo <anlo@rim.com>
- [BlackBerry] Tap highlight fade animations are added to overlay continuously during pinch zoom.
- https://bugs.webkit.org/show_bug.cgi?id=89772
- Reviewed by Antonio Gomes.
- When pinch zooming, DefaultTapHighlight::hide is continuously
- called from the UI thread. This resulted in fade animations being
- created and added to the override overlay continuously.
- This patch moves the m_visible check so that it applies for both
- threads.
- Internal PR164183
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::draw):
- (BlackBerry::WebKit::DefaultTapHighlight::hide):
- * WebKitSupport/DefaultTapHighlight.h:
- (DefaultTapHighlight):
- 2012-06-22 Yong Li <yoli@rim.com>
- [BlackBerry] Set WebSecurityEnabled flag accordingly.
- https://bugs.webkit.org/show_bug.cgi?id=89602
- Reviewed by Rob Buis.
- Disable web security checks if needed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-06-22 Parth Patel <parpatel@rim.com>
- [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
- https://bugs.webkit.org/show_bug.cgi?id=89684
- Reviewed by Yong Li.
- Build Fix-Typo Update setting instance access to use instance() instead of get().
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
- 2012-06-22 Amy Ousterhout <aousterh@chromium.org>
- Renamed DeviceOrientation to DeviceOrientationData
- https://bugs.webkit.org/show_bug.cgi?id=88663
- Reviewed by Steve Block.
- Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation.
- This change makes DeviceOrientationData consistent with DeviceMotionData.
- * WebCoreSupport/DeviceOrientationClientBlackBerry.h:
- (DeviceOrientationClientBlackBerry):
- 2012-06-22 Joseph Pecoraro <pecoraro@apple.com>
- Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported
- https://bugs.webkit.org/show_bug.cgi?id=89743
- Reviewed by Yury Semikhatsky.
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
- 2012-06-21 Parth Patel <parpatel@rim.com>
- [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
- https://bugs.webkit.org/show_bug.cgi?id=89684
- Reviewed by Yong Li.
-
- Update setting instance access to use instance() instead of get().
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::globalInitialize):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
- * WebCoreSupport/AboutData.cpp:
- (WebCore::configPage):
- * WebCoreSupport/CacheClientBlackBerry.cpp:
- (WebCore::CacheClientBlackBerry::updateCacheCapacity):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getPaddings):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
- (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::initialize):
- 2012-06-21 Genevieve Mak <gmak@rim.com>
- Add a parameter to handletTouchPoint to bypass FatFingers
- on touch up. There are some cases where the user may drag
- their finger off the element and we want to use the actual
- touch point instead of the FatFingers adjusted point.
- https://bugs.webkit.org/show_bug.cgi?id=89677
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- * Api/WebPage.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-06-21 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Input mode should adapt automatically to settings changes
- https://bugs.webkit.org/show_bug.cgi?id=89595
- Reviewed by Antonio Gomes.
- PR 167540.
- Add helper function to check if input is enabled so that
- the override settings can be applied at any time.
- Reviewed Internally by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
- (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::setComposingText):
- * WebKitSupport/InputHandler.h:
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-06-20 Jacky Jiang <zhajiang@rim.com>
- Add a != operator to ViewportArguments
- https://bugs.webkit.org/show_bug.cgi?id=87505
- Reviewed by Antonio Gomes.
- Patch by Jacky Jiang <zhajiang@rim.com>
- Use != operator of ViewportArguments.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- * Api/WebViewportArguments.cpp:
- (BlackBerry::WebKit::WebViewportArguments::operator!=):
- 2012-06-20 Christopher Hutten-Czapski <chutten@rim.com>
- [BlackBerry] Add an API to immediately enable cross-site XHR
- https://bugs.webkit.org/show_bug.cgi?id=89594
- Internally Reviewed by Yong Li.
- Reviewed by Rob Buis.
- There is no API to disable it as clients may rely on legacy behaviour
- of not disabling until the next frame load.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::enableCrossSiteXHRRecursively):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::enableCrossSiteXHR):
- (BlackBerry::WebKit::WebPage::enableCrossSiteXHR):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-20 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Enable setAcceleratedCompositingForFixedPositionEnabled
- https://bugs.webkit.org/show_bug.cgi?id=89575
- Reviewed by Antonio Gomes.
- Enable the flag so that we get position:fixed elemetns to be rendered
- using accelerated compositing.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-06-20 Julien Chaffraix <jchaffraix@webkit.org>
- Use IntSize in RenderLayer to represent scroll offsets
- https://bugs.webkit.org/show_bug.cgi?id=89154
- Reviewed by Eric Seidel.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::scrollRenderer):
- Updated to pass an IntSize to scrollToOffset.
- 2012-06-19 Yong Li <yoli@rim.com>
- [BlackBerry] Should check the return value of fromUTF8() before executing the script.
- https://bugs.webkit.org/show_bug.cgi?id=89500
- Reviewed by Rob Buis.
- PR# 166623.
- WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
- before executing the script to avoid potential crash on invalid script source.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- 2012-06-19 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Missing notifyContentRendered() when resuming rendering
- https://bugs.webkit.org/show_bug.cgi?id=89507
- RIM PR 150049
- Reviewed by Antonio Gomes.
- All the current calls to notifyContentRendered() are
- located in the RenderQueue, but this omits the case
- when we force rendering from resumeBackingStore()
- after rendering had been suspended for a while.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 2012-06-19 Sergio Villar Senin <svillar@igalia.com>
- Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
- https://bugs.webkit.org/show_bug.cgi?id=67582
- Reviewed by David Levin.
- Use synchronousNativeIconForPageURL() to retrieve favicons.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- 2012-06-18 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Overscroll can get reset while interacting with a page, due to style recalculations and scroll position clamping
- https://bugs.webkit.org/show_bug.cgi?id=89371
- PR #166982
- Reviewed by Adam Treat.
- While scrolling, the WebKit thread gets intercalated WebPage::setScrollPosition
- calls dispatched from the UI thread. These calls are wrapped with
- ScrollableArea::setConstrainsScrollingToContentEdge(false|true) calls, which
- can clamp the scroll position (removes overscroll) if set to 'true'.
- The following situation can happen: user is scrolling, and WebKit
- thread is not in the middle of a WebPage::setScrollPosition call
- (so setConstrainsScrollingToContentEdge is 'true'), and a relayout happens.
- In this scenario, the scroll position will get clamped to 0,0, removing any
- possible overscrolling.
- See the stack trace below, paying special attention to frame 16:
- #0 ScrollHandlerUserInterfaceThread::updateScrollPosition
- #1 0x782b4a3e in WebPageClientImpl::scrollChanged
- #2 0x78147484 in BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged
- #3 0x78171f68 in BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation
- #4 0x7816480a in WebCore::ChromeClientBlackBerry::scroll
- #5 0x7a78b290 in WebCore::Chrome::scroll
- #6 0x7a7ac8d0 in WebCore::FrameView::scrollContentsFastPath
- #7 0x7a7eba72 in WebCore::ScrollView::scrollContents
- #8 0x7a7ebb34 in WebCore::ScrollView::scrollTo
- #9 0x7a7a8dae in WebCore::FrameView::scrollTo
- #10 0x7a7e966e in WebCore::ScrollView::setScrollOffset
- #11 0x7a7e77cc in WebCore::ScrollableArea::scrollPositionChanged
- #12 0x7a7e7048 in WebCore::ScrollAnimator::notifyPositionChanged
- #13 0x7a7e700c in WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation
- #14 0x7a7e7588 in WebCore::ScrollableArea::scrollToOffsetWithoutAnimation
- #16 WebCore::ScrollView::updateScrollbars
- #18 WebCore::ScrollView::setContentsSize
- #19 0x7a7accd8 in WebCore::FrameView::setContentsSize
- #20 0x7a7a85f4 in WebCore::FrameView::adjustViewSize
- #22 WebCore::FrameView::layout
- #23 0x7a59d66e in WebCore::Document::updateLayoutIgnorePendingStylesheets
- #24 0x7a5ada92 in WebCore::Element::offsetHeight
- #25 0x7ab226b6 in WebCore::jsElementOffsetHeight
- #27 JSC::JSValue::get
- #28 0x796dd662 in JSC::JITStubThunked_op_get_by_id_generic
- Patch fixes this issue by tying ScrollableArea::setConstrainsScrollingToContentEdge
- to BackingStore::m_isZoomingOrScrolling, when we are sure clamping should not happen.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setScrollPosition):
- 2012-06-15 Eli Fidler <efidler@rim.com>
- [BlackBerry] Use platform font settings for the standard settings.
- https://bugs.webkit.org/show_bug.cgi?id=89232
- Reviewed by Rob Buis.
- RIM PR 159708
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- 2012-06-15 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Remove touch events handling hook for popup
- https://bugs.webkit.org/show_bug.cgi?id=89245
- Reviewed by Rob Buis.
- In the old patches we create our own WebPage for popup, so we need to hook up our own
- touch handling functions, since we don't use our own WebPage any more, no need to keep
- the touch handling code, because it just does nothing other than passing out the events
- which might cause the touch events being handled twice.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- * WebCoreSupport/PagePopupBlackBerry.h:
- (PagePopupBlackBerry):
- 2012-06-15 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
- https://bugs.webkit.org/show_bug.cgi?id=89227
- PR #146642
- Reviewed by Rob Buis.
- Make use of the Settings::supportsMouseDevice setting in order to
- prevent mouse move event to fire as a response to a scroll action.
- We might still want to dynamically toggle this setting ON, in case for
- example of a mouse wheel driven scroll action, but we can revisit it
- when it becomes a fully supported/primary use case.
- Internally reviewed by Eli Fidler.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
- (BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):
- * Api/WebSettings.h:
- 2012-06-15 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen
- https://bugs.webkit.org/show_bug.cgi?id=89211
- Reviewed by Rob Buis.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 135215
- Make simpler rules for zoom to fit scale:
- - Zoom to fit horizontally first without clamping the contents width.
- - Zoom to fit vertically instead without clamping the contents height
- if the horizontal zoom to fit can cause a grey area below the web
- page. Get rid of the virtual viewport guard as there may be cases
- that zooming can cause a grey area without a virtual viewport.
- - Clamp the scale by the minimum zoom to fit scale 0.25 and apply
- this rule to image documents as well. This minimum scale can be
- changed if there is a better vaule in the future.
- In this way, we can get rid of the issue that many web pages don't fit
- the screen.
- Reviewed internally by Arvid Nilsson.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
- 2012-06-15 Yong Li <yoli@rim.com>
- [BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
- https://bugs.webkit.org/show_bug.cgi?id=89210
- Reviewed by Antonio Gomes.
- Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
- calling them is neither nessary nor safe.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
- (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
- * WebKitSupport/BackingStoreClient.cpp:
- * WebKitSupport/BackingStoreClient.h:
- (BackingStoreClient):
- 2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r120404.
- http://trac.webkit.org/changeset/120404
- https://bugs.webkit.org/show_bug.cgi?id=89193
- This patch breaks [BlackBerry]'s text selection handles moving
- in editable elements. (Requested by Sean1 on #webkit).
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2012-06-14 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Selection - Crash when manipulating selection by dragging handle
- https://bugs.webkit.org/show_bug.cgi?id=89160
- RIMBUG:164970
- Avoid to set position in shadow tree to the new selection's base. It
- crashes when setting a shadow position to a selection' base.
- Reviewed by Antonio Gomes.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2012-06-14 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] empty plugin cause browser hang
- https://bugs.webkit.org/show_bug.cgi?id=89091
- Reviewed by Rob Buis.
- Add check before clean pluginView in FrameLoaderBlackBerry in case
- it didn't have any content.
- RIM PR# 165336
- Reviewed internally by George Staikos
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::finishedLoading):
- 2012-06-14 Genevieve Mak <gmak@rim.com>
- Always convert touch events to mouse events if the
- meta-tag TouchEventMode::PureWithMouseConversion is set.
- Minor style fix.
- https://bugs.webkit.org/show_bug.cgi?id=89115
- Reviewed by Antonio Gomes.
- Reviewed Internally by Antonio Gomes.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-06-14 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] add a new Api named setAllowNotification
- https://bugs.webkit.org/show_bug.cgi?id=88950
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setAllowNotification):
- (WebKit):
- * Api/WebPage.h:
- 2012-06-13 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Apply New Style and JS for Select Popup
- https://bugs.webkit.org/show_bug.cgi?id=89020
- Reviewed by Rob Buis.
- PR 162854
- Use new styled CSS files for select popup, also remove most JS functions
- to a separate JS file, only pass the parameters to JS, and use new python
- script for data generating, as the old one is too simple and problematic.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::generateHTML):
- 2012-06-13 Amy Ousterhout <aousterh@chromium.org>
- Rename currentDeviceMotion to lastMotion in DeviceMotionClient
- https://bugs.webkit.org/show_bug.cgi?id=88854
- Reviewed by Adam Barth.
- Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
- This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.
- * WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
- (DeviceMotionClientBlackBerry::lastMotion):
- (DeviceMotionClientBlackBerry::onMotion):
- * WebCoreSupport/DeviceMotionClientBlackBerry.h:
- (DeviceMotionClientBlackBerry):
- 2012-06-13 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Enable MEDIA_STREAM by default
- https://bugs.webkit.org/show_bug.cgi?id=88849
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/UserMediaClientImpl.cpp: Added.
- (WebCore):
- (WebCore::UserMediaClientImpl::UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
- (WebCore::UserMediaClientImpl::pageDestroyed):
- (WebCore::UserMediaClientImpl::requestUserMedia):
- (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
- * WebCoreSupport/UserMediaClientImpl.h: Added.
- (WebKit):
- (WebCore):
- (UserMediaClientImpl):
- 2012-06-12 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Crash when rendering web page that's being destroyed
- https://bugs.webkit.org/show_bug.cgi?id=88915
- Reviewed by Rob Buis.
- PR #164943
- This was a null pointer dereference that happened when the compositor
- was asked to render after being disconnected from its web page.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- 2012-06-12 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Scale was incorrect when reloading a simple web page after initial load
- https://bugs.webkit.org/show_bug.cgi?id=88889
- Reviewed by Adam Treat.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 164442
- When we were reloading a web page with the load type FrameLoadTypeSame
- after the initial load, the first layout timer was fired after the load
- Finished state, in which case the web page would have no chance to zoom
- to the initial scale during the layout as it was only for load
- Committed state. This patch takes care of it.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
- 2012-06-12 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Fix crash in InputHandler
- https://bugs.webkit.org/show_bug.cgi?id=88808
- Reviewed by Antonio Gomes.
- m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::chromeDestroyed():
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::~InputHandler):
- 2012-06-12 Yong Li <yoli@rim.com>
- [BlackBerry] Use a safer way to shrink JS memory usage
- https://bugs.webkit.org/show_bug.cgi?id=88811
- Reviewed by Antonio Gomes.
- We should just make a GC request and JSC will check if it is safe to do anything.
- * Api/BlackBerryGlobal.cpp:
- (BlackBerry::WebKit::clearMemoryCaches):
- 2012-06-11 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Autofill feature implementation for BlackBerry porting
- https://bugs.webkit.org/show_bug.cgi?id=85577
- Reviewed by Rob Buis.
- Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
- is same as the procedure in dispatchWillSendSubmitEvent.
- Some sites will redirect to other url in its login process, which will cause the
- user get notified to save credentials for this provisional redirecting url if we
- put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
- sure we only save the autofill data before the submit event is fired.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- 2012-06-11 Antonio Gomes <agomes@rim.com>
- [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
- https://bugs.webkit.org/show_bug.cgi?id=88809
- Reviewed by Rob Buis.
- Adjust the media container dimensions, whenever the FrameView::frameRect
- (aka viewport rect) changes
- Reviewed internally by Jacky Jiang.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 2012-06-09 Antonio Gomes <agomes@rim.com>
- [BlackBerry] browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen
- https://bugs.webkit.org/show_bug.cgi?id=88719
- PR #164026
- Reviewed by Rob Buis.
- Instead of using WebPage's viewport size, which suffers from
- dealing with transformed coordinates, viewport metatag changes,
- etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
- which abstract all these variations.
- It fixes an overscale issue we were having when video player entered
- fullscreen, and webpage had viewport metatag set.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 2012-06-11 Sam Weinig <sam@webkit.org>
- Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
- https://bugs.webkit.org/show_bug.cgi?id=88723
- Reviewed by Dan Bernstein.
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- 2012-06-10 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Make media (<video> and <audio>) slide draggable again
- https://bugs.webkit.org/show_bug.cgi?id=88742
- PR #158199
- Reviewed by George Staikos.
- First check if the element is a range type then gets its
- shadow DOM ancestor.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::shouldConvertTouchToMouse):
- 2012-06-08 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Fix crash on PagePopupChromeClient
- https://bugs.webkit.org/show_bug.cgi?id=88675
- Reviewed by Antonio Gomes.
- PR 163672.
- Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
- because update() is problematic. Also no need to save pointer in InputHandler.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::openPagePopup):
- (WebCore::ChromeClientBlackBerry::closePagePopup):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::~InputHandler):
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- * WebKitSupport/InputHandler.h:
- (WebCore):
- (InputHandler):
- 2012-06-08 Eli Fidler <efidler@rim.com>
- [BlackBerry] Default font settings are getting deleted
- https://bugs.webkit.org/show_bug.cgi?id=88670
- Reviewed by Rob Buis.
- RIM PR: 163720
- WebSettings is overriding the default font settings with "", which deletes them.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-06-07 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
- https://bugs.webkit.org/show_bug.cgi?id=88576
- Reviewed by Rob Buis.
- When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use
- this to load popup, no need to create a new one. The old code is based on an old solution
- which has been abandoned.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::openPagePopup):
- * WebCoreSupport/PagePopupBlackBerry.cpp:
- (WebCore::PagePopupBlackBerry::init):
- (WebCore::setValueAndClosePopupCallback):
- (WebCore::PagePopupBlackBerry::handleMouseEvent):
- (WebCore::PagePopupBlackBerry::closePopup):
- * WebCoreSupport/PagePopupBlackBerry.h:
- (PagePopupBlackBerry):
- 2012-06-07 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Get rid of unused maximumLayoutSize in WebPage
- https://bugs.webkit.org/show_bug.cgi?id=88574
- Reviewed by Rob Buis.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 164098
- maximumLayoutSize was deprecated when we made use of
- WebCore::computeViewportAttributes for
- WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
- So clean it up.
- * Api/WebPage.cpp:
- (WebKit):
- 2012-06-07 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] User viewport arguments are not respected
- https://bugs.webkit.org/show_bug.cgi?id=88530
- Reviewed by Antonio Gomes.
- RIM PR #163767
- Fixed by applying the user supplied viewport arguments if the page
- specifies default viewport arguments (i.e. the page has no viewport
- meta tag).
- If the user didn't supply any viewport arguments either, the behaviour
- is the same as before the patch, the caller will successfully reset to
- default viewport arguments.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 2012-06-07 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Allow WebPageCompositor to blend a transparent web page
- https://bugs.webkit.org/show_bug.cgi?id=88233
- Reviewed by Rob Buis.
- RIM PR #159998
- Keep track of the web page background color in the compositor so we can
- determine whether the contents of the root layer are transparent.
- Reviewed internally by Jakob Petsovits.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorBackgroundColor):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::createCompositor):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setBackgroundColor):
- (WebKit):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::backgroundColor):
- (WebPageCompositorPrivate):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-07 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Add enable credential autofill and enable form autofill feature control in WebSetting
- https://bugs.webkit.org/show_bug.cgi?id=88513
- Reviewed by Rob Buis.
- RIM PR: #163391
- Implemented credential autofill setting and form autofill setting.
- Internally reviewed by Leo Yang <leo.yang@torchmobile.com.cn>.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::autofillTextField):
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (BlackBerry::WebKit::WebPage::clearCredentials):
- (BlackBerry::WebKit::WebPage::clearAutofillData):
- (BlackBerry::WebKit::WebPage::clearNeverRememberSites):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::isCredentialAutofillEnabled):
- (BlackBerry::WebKit::WebSettings::setCredentialAutofillEnabled):
- (BlackBerry::WebKit::WebSettings::isFormAutofillEnabled):
- (BlackBerry::WebKit::WebSettings::setFormAutofillEnabled):
- * Api/WebSettings.h:
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
- (WebCore::EditorClientBlackBerry::textDidChangeInTextField):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- 2012-06-06 Antonio Gomes <agomes@rim.com>
- [BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
- https://bugs.webkit.org/show_bug.cgi?id=88488
- PR #162991
- Reviewed by George Staikos.
- When we use width:100%/pageScale as the math to calculate the width of the
- FullScreen element, it goes too wide for horizontally scrollable webpages.
- The reason is that 100% is relative to the content size here, and we want 100%
- relative to the viewport size. However, since there is no such a thing in CSS,
- we set an absolute file.
- A known problem with this will be rotating the device when in fullscreen mode
- that we can address when rotating is supported.
- Internally reviewed by Jacky Jiang.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 2012-06-05 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
- https://bugs.webkit.org/show_bug.cgi?id=88254
- PR #125237
- Reviewed by Rob Buis.
- Patch implements a top-down visibleWindowRect calculation for all scrollable
- elements hit-tested by a given point.
- The reason on why this approach is better is that it calculates the visible
- window rect from the outermost scrollable element towards the inner ones, and
- that allows it to use the visible window rect of the previous scrollable element
- as the clipping rect for the current one.
- Patch also changes the return vector to store ScrollViewBase pointers, so
- we can make use of static_cast properly. As now also stated in the header
- file, the client is responsible for deleting the ScrollViewBase
- elements in the vector.
- Internally reviewed by Jakob Petsovits.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::pushBackInRegionScrollable):
- (BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- (BlackBerry::WebKit::InRegionScrollableArea::setVisibleWindowRect):
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollableArea::visibleWindowRect):
- * WebKitSupport/InRegionScrollableArea.h:
- (InRegionScrollableArea):
- 2012-06-06 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
- https://bugs.webkit.org/show_bug.cgi?id=88065
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::indexedDataBasePath):
- (BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
- * Api/WebSettings.h:
- 2012-06-05 Crystal Zhang <haizhang@rim.com>
- [BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
- https://bugs.webkit.org/show_bug.cgi?id=88342
- Reviewed by Rob Buis.
- RIM PR: 163141
- Reviewed internally by Mike Fenton.
- We set all options' type to TypeOption, which can't tell if an option belongs to a group,
- introduce TypeOptionInGroup to fix it.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- 2012-06-05 Adam Barth <abarth@webkit.org>
- Remove support for target-densitydpi in the viewport meta tag
- https://bugs.webkit.org/show_bug.cgi?id=88047
- Reviewed by Kenneth Rohde Christiansen.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- * Api/WebViewportArguments.cpp:
- (BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
- (BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
- * Api/WebViewportArguments.h:
- 2012-06-05 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry]Web Inspector highlight is slow
- https://bugs.webkit.org/show_bug.cgi?id=88331
- Reviewed by Rob Buis.
- Highlight is slow on large pages because of constant repaint calls.
- Change to use the accelerated layer highlight all the time.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::highlight):
- (WebCore::InspectorClientBlackBerry::hideHighlight):
- * WebCoreSupport/InspectorOverlay.cpp:
- (WebCore::InspectorOverlay::clear):
- (WebCore::InspectorOverlay::update):
- 2012-06-04 Andrew Lo <anlo@rim.com>
- [BlackBerry] Split AnimationFrameRateController into its own file
- https://bugs.webkit.org/show_bug.cgi?id=88242
- Reviewed by Antonio Gomes.
- Include new header file to reflect re-organization of platform animation
- header files.
- * Api/WebPageCompositor_p.h:
- 2012-06-02 Antonio Gomes <agomes@rim.com>
- [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
- https://bugs.webkit.org/show_bug.cgi?id=88019
- Reviewed by George Staikos.
- Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
- that it prevents user from scrolling the WebPage, pinch zooming,
- touch-and-hold, enter selection mode, etc ...
- Internally reviewed by Gen Mak.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-02 Antonio Gomes <agomes@rim.com>
- [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART II)
- https://bugs.webkit.org/show_bug.cgi?id=88019
- Reviewed by George Staikos.
- When an element goes fullscreen, its wrapper/container obeys all
- BlackBerry specific fixed position customizations: we fixed
- against Y, but not X. Then, in order to have the wrapper element
- properly positioned when entering fullscreen mode, we
- temporarily scroll x to 0.
- The original x scroll position is restored when we leave
- fullscreen.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-06-02 Antonio Gomes <agomes@rim.com>
- [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART I)
- https://bugs.webkit.org/show_bug.cgi?id=88019
- PR #158266
- Reviewed by George Staikos.
- The way elements go fullscreen with the new FULLSCREEN_API
- is that they get cloned and added to an out-of-DOM wrapper
- element. The wrapper is a normal fixed position element and
- then zoom in/out accordingly to how other layers do: following
- WebPage's scale.
- When going fullscreen, we have to take the current WebPage scale
- into account in order to properly fit the element to the screen,
- regardless the web page scale.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-06-01 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Fix the return value checking in SelectPopupClient
- https://bugs.webkit.org/show_bug.cgi?id=88130
- Reviewed by Rob Buis.
- In SelectPopupClient, return '1' means selected, '0' means not selected,
- the ASCII value of '0' is 48, not 32, use '0' to be more readable.
- * WebCoreSupport/SelectPopupClient.cpp:
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- 2012-06-01 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Add end editing handling into AutofillManager
- https://bugs.webkit.org/show_bug.cgi?id=88071
- Reviewed by Rob Buis.
- RIM PR: 160857
- Implemented EditorClientBlackBerry::textFieldDidEndEditing
- to notify AutofillManager to send the dismissing autofill
- dialog notification to webpage client.
- No new tests since there is no behavior changes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
- (WebKit):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/AutofillManager.cpp:
- (WebCore::AutofillManager::textFieldDidEndEditing):
- (WebCore):
- * WebCoreSupport/AutofillManager.h:
- (AutofillManager):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
- 2012-05-31 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
- https://bugs.webkit.org/show_bug.cgi?id=88033
- Reviewed by Rob Buis.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 142961
- When bridge apps were in carousel mode, the backing store was inactive
- as its memory had been released. When we rotated the device, we would
- call WebPagPrivate:setViewportSize and resume screen and backing store
- to render and blit visible contents. As backing store was inactive and
- the window usage was GLES2Usage, we were neither doing backing store
- rendering nor direct rendering. Therefore, we drew layers directly
- based on the invalid texture contents when blitting contents if
- accelerated compositing was enabled.
- This patch forces compositing mode to let the accelerated compositing
- layer take care of the rendering which can update texture contents
- before drawing when backing store is inactive and is openGL compositing.
- Reviewed internally by George Staikos and Arvid Nilsson.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 2012-05-31 Hajime Morrita <morrita@chromium.org>
- REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
- https://bugs.webkit.org/show_bug.cgi?id=86859
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::requestCheckingOfString):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2012-05-31 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
- https://bugs.webkit.org/show_bug.cgi?id=88012
- Reviewed by George Staikos.
- Properly set up resource sharing between WebKit thread EGL contexts and
- the compositing thread EGL context, so the texture ID produced by WebGL
- and 2D canvas makes sense to the compositing context.
- There's no public API to supply an EGLContext yet, so we're lucky that
- the embedder never makes its context un-current. Just grab the current
- context on the compositing thread and use that as the compositing
- context.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-05-31 George Staikos <staikos@webkit.org>
- [Blackberry] Initialize the select client and delete the pointer
- in the destructor so it doesn't leak. Fixes test crashes.
- https://bugs.webkit.org/show_bug.cgi?id=87992
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::~InputHandler):
- 2012-05-31 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
- https://bugs.webkit.org/show_bug.cgi?id=87968
- Reviewed by Rob Buis.
- The override object is using a compositing thread WebOverlayPrivate
- object with no client because the layer doesn't delegate drawing to the
- WebOverlayPrivate, it's only used to modify the override properties on
- the underlying compositing thread layer.
- Since the m_layerCompositingThreadClient is optional, we have to add
- null checks.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
- 2012-05-31 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] WebKit's fullscreen mode needs to notify page client.
- https://bugs.webkit.org/show_bug.cgi?id=87337
- Reviewed by Antonio Gomes.
- Move "fullScreenVideoCapable" into webpagePrivate to make code
- clean for "fullScreenForElement/Node" of cromeClientBlackberry,
- All Video checks and code path selections are in webpagePrivate now.
- For some UX and secure reasons, we could not apply fullscreen capacity
- for all elements, So we use client's fullscreenStart/Stop only for
- those video elements and those elements containing video tags.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
- (WebKit):
- (BlackBerry::WebKit::containsVideoTags):
- (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- 2012-05-31 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Crash when closing web page if selection is active
- https://bugs.webkit.org/show_bug.cgi?id=87962
- Reviewed by Antonio Gomes.
- The embedder may try to remove a layer from the compositor at a stage
- where the compositor has been set to 0.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
- (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
- 2012-05-30 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
- https://bugs.webkit.org/show_bug.cgi?id=81001
- Reviewed by Antonio Gomes.
-
- Implemented InspectorOverlay using WebOverlayAPI.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
- (WebKit):
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::highlight):
- (WebCore::InspectorClientBlackBerry::hideHighlight):
- (WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
- (WebCore):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- * WebCoreSupport/InspectorOverlay.cpp: Added.
- (WebCore):
- (WebCore::InspectorOverlay::create):
- (WebCore::InspectorOverlay::InspectorOverlay):
- (WebCore::InspectorOverlay::notifySyncRequired):
- (WebCore::InspectorOverlay::paintContents):
- (WebCore::InspectorOverlay::showDebugBorders):
- (WebCore::InspectorOverlay::showRepaintCounter):
- (WebCore::InspectorOverlay::contentsVisible):
- (WebCore::InspectorOverlay::~InspectorOverlay):
- (WebCore::InspectorOverlay::clear):
- (WebCore::InspectorOverlay::update):
- (WebCore::InspectorOverlay::paintWebFrame):
- (WebCore::InspectorOverlay::invalidateWebFrame):
- * WebCoreSupport/InspectorOverlay.h: Added.
- (WebKit):
- (WebCore):
- (InspectorOverlay):
- (InspectorOverlayClient):
- (WebCore::InspectorOverlay::setClient):
- (WebCore::InspectorOverlay::notifyAnimationStarted):
- 2012-05-30 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Browser crashed when selecting in textarea
- https://bugs.webkit.org/show_bug.cgi?id=87484
- The function FatFingers::checkForText() uses host node's whole text
- to checkFingerIntersection(). We should not give the text of shadow
- nodes to it.
- Reviewed by Antonio Gomes.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::getNodesFromRect): Avoid returning
- shadow nodes when the context is Text node.
- 2012-05-30 Zoltan Horvath <zoltan@webkit.org>
- [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
- https://bugs.webkit.org/show_bug.cgi?id=80400
- Get rid of QT_IMAGE_DECODER flag.
- Reviewed by Simon Hausmann.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-05-29 Max Feil <mfeil@rim.com>
- [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
- https://bugs.webkit.org/show_bug.cgi?id=87817
- Reviewed by Antonio Gomes.
- This bug fix in WebKit/blackberry is needed by the changes for
- fullscreen media control sizing in WebCore (bug 87551). The sizing
- of controls depends on the page's deviceScaleFactor(), which was
- not being maintained properly due to errors in logic. Viewport
- changes from non-default to default were being erroneously
- thrown out. Also, when the viewport did change back to default
- the deviceScaleFactor was not being updated.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 2012-05-29 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebOverlay build fixes and bug fixes
- https://bugs.webkit.org/show_bug.cgi?id=87780
- Reviewed by Rob Buis.
- Fix build when accelerated compositing disabled, or debug build.
- Also fix a bug where the selection overlay would not disappear properly
- because of a typo in WebPage::removeOverlay(). Also convert said method
- to early return style.
- Debug build fixes contributed by Ming Xie.
- * Api/WebOverlay.cpp:
- (BlackBerry::WebKit::WebOverlay::addAnimation):
- (BlackBerry::WebKit::WebOverlay::setContentsToImage):
- (WebKit):
- (BlackBerry::WebKit::WebOverlay::setContentsToColor):
- (BlackBerry::WebKit::WebOverlay::setDrawsContent):
- (BlackBerry::WebKit::WebOverlay::invalidate):
- (BlackBerry::WebKit::WebOverlay::setClient):
- (BlackBerry::WebKit::WebOverlay::override):
- (BlackBerry::WebKit::WebOverlay::resetOverrides):
- * Api/WebOverlayOverride.cpp:
- (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
- * Api/WebOverlay_p.h:
- (BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::removeOverlay):
- (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
- (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
- 2012-05-29 Yong Li <yoli@rim.com>
- [BlackBerry] Add malloc info to about:memory page
- https://bugs.webkit.org/show_bug.cgi?id=87676
- Reviewed by Rob Buis.
- Detailed malloc info can tell us how much memory
- in the heaps is being in use.
- * WebCoreSupport/AboutData.cpp:
- (WebCore::memoryPage):
- 2012-05-29 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
- https://bugs.webkit.org/show_bug.cgi?id=87604
- Reviewed by Antonio Gomes.
- Also add a new method to allow the embedder to use the default tap
- highlight instead of replacing it with a custom one just to keep track
- of the "shouldHideAfterScroll" flag.
- PR #160262.
- * Api/WebTapHighlight.h:
- * WebKitSupport/DefaultTapHighlight.cpp:
- (BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
- (BlackBerry::WebKit::DefaultTapHighlight::draw):
- (BlackBerry::WebKit::DefaultTapHighlight::hide):
- (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
- * WebKitSupport/DefaultTapHighlight.h:
- (BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
- (DefaultTapHighlight):
- 2012-05-29 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebKit-side implementation of SelectionOverlay
- https://bugs.webkit.org/show_bug.cgi?id=87605
- Reviewed by Rob Buis.
- Leverage the new WebOverlay API to move SelectionOverlay to the WebKit
- library, so we always draw selection regardless of which embedder is
- integrating WebKit.
- PR #160263
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::selectionOverlay):
- (WebKit):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSelectionOverlay.h: Added.
- (WebKit):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionOverlay.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
- (BlackBerry::WebKit::SelectionOverlay::~SelectionOverlay):
- (BlackBerry::WebKit::SelectionOverlay::draw):
- (BlackBerry::WebKit::SelectionOverlay::hide):
- (BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
- (BlackBerry::WebKit::SelectionOverlay::paintContents):
- * WebKitSupport/SelectionOverlay.h: Added.
- (WebKit):
- (SelectionOverlay):
- (BlackBerry::WebKit::SelectionOverlay::create):
- (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
- (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
- (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
- (BlackBerry::WebKit::SelectionOverlay::contentsVisible):
- 2012-05-29 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] WebOverlay API
- https://bugs.webkit.org/show_bug.cgi?id=87603
- Reviewed by Rob Buis.
- This new API makes it possible to leverage the BlackBerry accelerated
- compositing implementation to draw, transform and fluidly animate
- overlays in the embedding library or application.
- A WebOverlay has an affinity for the thread where it was created. If
- the current thread is the WebKit thread, use WebPage::addOverlay() to
- add it to the page, and manipulate it only from the WebKit thread, with
- exception of the "override" functionality which can be used from the
- compositing thread. If the current thread is the compositing thread,
- use WebPage::addCompositingThreadOverlay() to add it to the page, and
- only manipulate it on the compositing thread.
- A WebOverlay can be painted using Skia, or its contents can be set to
- an image or a solid color.
- PR #156812
- * Api/WebAnimation.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::WebAnimation::fadeAnimation):
- (BlackBerry::WebKit::WebAnimation::name):
- (BlackBerry::WebKit::WebAnimation::WebAnimation):
- (BlackBerry::WebKit::WebAnimation::~WebAnimation):
- (BlackBerry::WebKit::WebAnimation::operator=):
- * Api/WebAnimation.h: Added.
- (WebKit):
- * Api/WebAnimation_p.h: Added.
- (WebKit):
- (WebAnimationPrivate):
- (BlackBerry::WebKit::WebAnimationPrivate::WebAnimationPrivate):
- * Api/WebOverlay.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::WebOverlay::WebOverlay):
- (BlackBerry::WebKit::WebOverlay::~WebOverlay):
- (BlackBerry::WebKit::WebOverlay::position):
- (BlackBerry::WebKit::WebOverlay::setPosition):
- (BlackBerry::WebKit::WebOverlay::anchorPoint):
- (BlackBerry::WebKit::WebOverlay::setAnchorPoint):
- (BlackBerry::WebKit::WebOverlay::size):
- (BlackBerry::WebKit::WebOverlay::setSize):
- (BlackBerry::WebKit::WebOverlay::sizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlay::setSizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlay::transform):
- (BlackBerry::WebKit::WebOverlay::setTransform):
- (BlackBerry::WebKit::WebOverlay::opacity):
- (BlackBerry::WebKit::WebOverlay::setOpacity):
- (BlackBerry::WebKit::WebOverlay::addAnimation):
- (BlackBerry::WebKit::WebOverlay::removeAnimation):
- (BlackBerry::WebKit::WebOverlay::parent):
- (BlackBerry::WebKit::WebOverlay::addChild):
- (BlackBerry::WebKit::WebOverlay::removeFromParent):
- (BlackBerry::WebKit::WebOverlay::setContentsToImage):
- (BlackBerry::WebKit::WebOverlay::setContentsToColor):
- (BlackBerry::WebKit::WebOverlay::setDrawsContent):
- (BlackBerry::WebKit::WebOverlay::invalidate):
- (BlackBerry::WebKit::WebOverlay::setClient):
- (BlackBerry::WebKit::WebOverlay::override):
- (BlackBerry::WebKit::WebOverlay::resetOverrides):
- (BlackBerry::WebKit::WebOverlayPrivate::page):
- (BlackBerry::WebKit::WebOverlayPrivate::override):
- (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
- (BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::override):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::position):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setPosition):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::anchorPoint):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setAnchorPoint):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::size):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSize):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::sizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::transform):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setTransform):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::opacity):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setOpacity):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addAnimation):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeAnimation):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addChild):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeFromParent):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setDrawsContent):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::clear):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::invalidate):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::resetOverrides):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifySyncRequired):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::~WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setDrawsContent):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::override):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::position):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setPosition):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::anchorPoint):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setAnchorPoint):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::size):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSize):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::sizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSizeIsScaleInvariant):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::transform):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setTransform):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::opacity):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setOpacity):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addAnimation):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeAnimation):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addChild):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::clear):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
- (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::resetOverrides):
- * Api/WebOverlay.h: Added.
- (WebCore):
- (WebKit):
- * Api/WebOverlayClient.h: Added.
- (WebKit):
- * Api/WebOverlayOverride.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
- (BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
- (BlackBerry::WebKit::WebOverlayOverride::setPosition):
- (BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
- (BlackBerry::WebKit::WebOverlayOverride::setSize):
- (BlackBerry::WebKit::WebOverlayOverride::setTransform):
- (BlackBerry::WebKit::WebOverlayOverride::setOpacity):
- (BlackBerry::WebKit::WebOverlayOverride::addAnimation):
- (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
- * Api/WebOverlayOverride.h: Added.
- (WebKit):
- * Api/WebOverlay_p.h: Added.
- (WTF):
- (WebCore):
- (WebKit):
- (WebOverlayPrivate):
- (BlackBerry::WebKit::WebOverlayPrivate::WebOverlayPrivate):
- (BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
- (BlackBerry::WebKit::WebOverlayPrivate::setPage):
- (BlackBerry::WebKit::WebOverlayPrivate::setClient):
- (BlackBerry::WebKit::WebOverlayPrivate::layerCompositingThread):
- (BlackBerry::WebKit::WebOverlayPrivate::graphicsLayer):
- (WebOverlayPrivateWebKitThread):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::graphicsLayer):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
- (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::contentsVisible):
- (WebOverlayLayerCompositingThreadClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setLayer):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setClient):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawsContent):
- (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::contents):
- (WebOverlayPrivateCompositingThread):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::addOverlay):
- (WebKit):
- (BlackBerry::WebKit::WebPage::removeOverlay):
- (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
- (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::compositeLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::addOverlay):
- (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::compositingThreadOverlayLayer):
- (WebPageCompositorPrivate):
- 2012-05-28 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
- https://bugs.webkit.org/show_bug.cgi?id=80135
- Reviewed by Rob Buis.
- RIM PR: 145660
- Fixed a regression introduced by r111810, which used the wrong
- credential object.
- Added the interface function didReceivedAuthenticaitonChallenge()
- in interface class DumpRenderTreeClient;
- Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
- WebPagePrivate::authenticationChallenge() when DRT is enabled.
- Test: reuse existing test cases:
- http/tests/loading/basic-credentials-sent-automatically.html
- http/tests/loading/basic-auth-resend-wrong-credentials.html
- Resubmit the patch reverted by r115104 after the digest infinite loop
- issue for BlackBerry porting get identified and fixed.
- Internally reviewed by Joe Mason <jmason@rim.com>
- * Api/DumpRenderTreeClient.h:
- (WebCore):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Always create a compositor
- https://bugs.webkit.org/show_bug.cgi?id=87598
- Reviewed by Rob Buis.
- There will likely be compositing layers either due to web content or
- due to overlays.
- Defer initialization of OpenGL objects (i.e., delay creation of the
- LayerRenderer object) until we actually need to draw and there are such
- layers, to avoid initializing OpenGL in the unlikely case that there
- are no compositing layers or overlay layers.
- PR #156811
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::createCompositor):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
- (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Dangling pointer in WebPagePrivate::setCompositor() message
- https://bugs.webkit.org/show_bug.cgi?id=87590
- Reviewed by Rob Buis.
- A crash would be seen in GuardedPointerBase::getWithGuardLocked when
- attempting to unpickle and execute serialized call to setCompositor.
- The problem was that the message had been created with a dangling
- pointer as the target. The web page failed to inform its compositor
- that it was being destroyed due to an early return in
- WebPagePrivate::destroyCompositor.
- The root cause was that a method called "destroyCompositor" was being
- called in two situations, when navigating to a new page as well as when
- actually deleting the web page. And in one case, we really only wanted
- to free up some memory by clearing textures, while in the other case we
- really did want to destroy the compositor.
- Fixed by calling a method to release textures when that's what we want
- to do, and calling a method to destroy the compositor when that's what
- we want to do, and making that latter method unconditional.
- Reviewed internally by Jeff Rogers.
- PR #156765
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add a default tap highlight
- https://bugs.webkit.org/show_bug.cgi?id=87569
- Reviewed by Rob Buis.
- We used to require the embedder to implement tap highlight drawing.
- Now, a default tap highlight, implemented using the recently added
- accelerated compositing overlay layer support, can be used instead.
- The tap highlight appears instantly but fades out when hidden.
- The default tap highlight can be overridden using the new
- WebPage::setTapHighlight() method.
- Reviewed internally by Mike Lattanzio and Mike Fenton.
- PR #154329
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPage::tapHighlight):
- (WebKit):
- (BlackBerry::WebKit::WebPage::setTapHighlight):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * Api/WebTapHighlight.h: Added.
- (WebKit):
- * WebKitSupport/DefaultTapHighlight.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::fadeAnimationName):
- (BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
- (BlackBerry::WebKit::DefaultTapHighlight::~DefaultTapHighlight):
- (BlackBerry::WebKit::DefaultTapHighlight::draw):
- (BlackBerry::WebKit::DefaultTapHighlight::hide):
- (BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
- (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
- * WebKitSupport/DefaultTapHighlight.h: Added.
- (WebKit):
- (DefaultTapHighlight):
- (BlackBerry::WebKit::DefaultTapHighlight::create):
- (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
- (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
- (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
- (BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add an overlay layer
- https://bugs.webkit.org/show_bug.cgi?id=87567
- Reviewed by Antonio Gomes.
- The overlay layer allows us to have compositing layers even though the
- web page is not currently using accelerated compositing.
- These layers can be used to implement tap highlight, inspector overlay
- and more.
- Reviewed internally by Filip Spacek.
- PR #154335
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
- (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setOverlayLayer):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::overlayLayer):
- (WebPageCompositorPrivate):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Update WebPageCompositor::render() API
- https://bugs.webkit.org/show_bug.cgi?id=87565
- Reviewed by Rob Buis.
- The new API allows the embedder to specify the root transform and many
- OpenGL related parameters to be used when rendering the web page.
- To honor the transform, we have to implement a way to composite the
- BackingStore output using a generic transform. This method,
- BackingStorePrivate::compositeContents(), uses a strategy that differs
- from blitContents(), because that one is optimized for software
- blitting, while this one is optimized for GPU rendering. Specifically,
- instead of drawing the checkerboard first, and the rendered subregions
- of the tile afterward, we draw the whole tile in one call, and then
- draw checkered regions on top, if any.
- Removed the blit generation condvar from the new code paths for drawing
- BackingStore output using a transform, since the condvar is ineffective
- in preventing flicker when we're not in charge of swapping the window.
- Instead, another synchronization solution will be implemented in the
- future.
- Reviewed internally by Filip Spacek.
- Some parts reviewed internally by Jacky Jiang and others by
- Mike Lattanzio.
- PR #151887, #154334
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- * Api/BackingStore_p.h:
- (WebCore):
- (BackingStorePrivate):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
- (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositor::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositor::render):
- * Api/WebPageCompositor.h:
- * Api/WebPageCompositorClient.h:
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- 2012-05-28 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Plumb through the return value of makeCurrent to caller
- https://bugs.webkit.org/show_bug.cgi?id=87564
- Reviewed by Rob Buis.
- This way the caller can take appropriate action if makeCurrent fails,
- for example because we're running out of memory.
- Reviewed internally by George Staikos.
- PR #149721
- * WebKitSupport/GLES2Context.cpp:
- (BlackBerry::WebKit::GLES2Context::makeCurrent):
- 2012-05-27 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Crash when deleting WebPageCompositor
- https://bugs.webkit.org/show_bug.cgi?id=87589
- Reviewed by Rob Buis.
- The WebPageCompositorPrivate is reference counted, so it may outlive
- either the WebPage or the WebPageCompositor, depending on who releases
- its reference first.
- Fixed by disconnecting the objects properly, regardless of who goes
- away first.
- Reviewed internally by Mike Lattanzio.
- PR #156444
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::client):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
- 2012-05-27 Arvid Nilsson <anilsson@rim.com>
- 2012-04-18 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] BackingStore accesses tiles even though it's not active
- https://bugs.webkit.org/show_bug.cgi?id=87563
- Reviewed by Antonio Gomes.
- There are many scenarios that can call render and cause tile access,
- and they used to be rerouted to the direct rendering code when the
- backing store was not active. This was thanks to an implicit check for
- isActive() by virtue of calling shouldDirectRenderingToWindow() from
- render().
- If we're using OpenGL for compositing the backing store contents
- however, direct rendering is always disabled and we jump right into the
- tile based rendering code.
- Fixed by adding an explicit check for isActive() in render(), now that
- the implicit check in shouldDirectRenderingToWindow() is conditional on
- having raster usage.
- Since PR136381/bug83131, when OpenGL compositing is used, and the
- backing store is not active, it is not in charge of drawing the root
- layer. Instead, we switch off the paintingGoesToWindow flag on the root
- RenderLayer so no invalidates will reach the ChromeClient or the
- BackingStore any more. Instead, invalidations will cause the root
- accelerated compositing layer to be repainted. Any BackingStore render
- calls while in this state are pointless, and can safely do an early
- return.
- Reviewed internally by Jakob Petsovits.
- PR #150403
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::render):
- 2012-05-27 Arvid Nilsson <anilsson@rim.com>
- 2012-04-12 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Web page fails to render after clicking link with target=_blank
- https://bugs.webkit.org/show_bug.cgi?id=87562
- Reviewed by Antonio Gomes.
- Clicking such a link opens a new tab. The compositor was briefly in
- charge of drawing the root layer while the backing store was inactive
- and the user was looking at the other tab. The problem was that the
- compositor believed it was still painting the root layer even after the
- backing store became active again. The flag was not properly cleared
- when turning off compositing.
- Fixed by returning false from drawsRootLayer() if we don't have a root
- layer.
- Reviewed internally by Filip Spacek.
- PR #149342
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
- 2012-05-24 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] History navigation caused google.com scale not kept
- https://bugs.webkit.org/show_bug.cgi?id=87438
- Reviewed by Antonio Gomes.
- Patch by Jacky Jiang <zhajiang@rim.com>
- PR: 159923
- For back/forward history navigation, we were trying to keep the values
- set by dispatchViewportDataDidChange. However, when we went back from
- the previous page, if the current page didn't contain the meta viewport
- tag, then those values set by previous page would never be reset.
- Although the current page could get correct saved scale when restoring
- view state, the scale would still be clamped by zoomToFitScale which
- was based on the virtual viewport of the previous page which could make
- the scale incorrect.
- Since we know the viewport arguments of the current document before
- setLoadState on back/forward history navigation, we can reset these
- previous values if the document doesn't have viewport arguments during
- setLoadState.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 2012-05-25 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Pass http headers to loader in download request
- https://bugs.webkit.org/show_bug.cgi?id=87449
- Reviewed by Rob Buis.
- PR# 149283
- This is to support byte-range download and we could pass http headers like
- "Range" in download request to loader.
- Reviewed internally by Lyon Chen.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::download):
- 2012-05-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] InputHandler can hold a ref on an object when document is cleared.
- https://bugs.webkit.org/show_bug.cgi?id=87412
- Reviewed by Rob Buis.
- PR 145234.
- When the document data is cleared, notify the InputHandler
- of the associated frame being unloaded.
- Reviewed Internally by Nima Ghanavatian.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
- 2012-05-24 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Implement select popup and remove old hook to air popup
- https://bugs.webkit.org/show_bug.cgi?id=87419
- Reviewed by Rob Buis.
- Introduce new html select popup client, remove the old hook to air popup.
- * Api/WebPageClient.h:
- * WebCoreSupport/SelectPopupClient.cpp: Added.
- (WebCore):
- (WebCore::SelectPopupClient::SelectPopupClient):
- (WebCore::SelectPopupClient::~SelectPopupClient):
- (WebCore::SelectPopupClient::update):
- (WebCore::SelectPopupClient::generateHTML):
- (WebCore::SelectPopupClient::closePopup):
- (WebCore::SelectPopupClient::contentSize):
- (WebCore::SelectPopupClient::htmlSource):
- (WebCore::SelectPopupClient::setValueAndClosePopup):
- (WebCore::SelectPopupClient::didClosePopup):
- (WebCore::SelectPopupClient::writeDocument):
- * WebCoreSupport/SelectPopupClient.h: Added.
- (WebKit):
- (WebCore):
- (SelectPopupClient):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::openSelectPopup):
- * WebKitSupport/InputHandler.h:
- (WebCore):
- (InputHandler):
- * WebKitSupport/WebPopupType.h: Added.
- (BlackBerry):
- (WebKit):
- 2012-05-24 Antonio Gomes <agomes@rim.com>
- Possible missing layout in Iris browser after hiding VKB
- https://bugs.webkit.org/show_bug.cgi?id=87408
- PR #153056 / MKS_3674963
- Reviewed by Adam Treat.
- Also informally reviewed by Mike Fenton.
- If we are not rotating and we've started a viewport resize with
- the Render tree in dirty state (i.e. it needs layout), lets
- reset the needsLayout flag for now but set our own 'needsLayout'.
- Reason: calls like ScrollView::setFixedLayoutSize can trigger a layout
- if the render tree needs it. We want to avoid it till the viewport resize
- is actually done (i.e. ScrollView::setViewportSize gets called
- further down the method) so we do not get render artifacts.
- Since our WebPage::setViewportSize calls rely on async Virtual
- Keyboard responses, we were getting it called with the render
- tree sometimes in a dirty state, sometimes not. It was flaky!
- Patch ensures a clear render tree state, and sets it as dirty
- afterwards as needed, so layout happens at the proper time.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-05-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Padding adjustment for determining the relative distance for a point was backwards.
- https://bugs.webkit.org/show_bug.cgi?id=87404
- Reviewed by Rob Buis.
- Fix padding calculation for handle adjustment.
- Reviewed Internally by Mike Lattanzio.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::directionOfPointRelativeToRect):
- 2012-05-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove unused API function touchEventCancelAndClearFocusedNode.
- https://bugs.webkit.org/show_bug.cgi?id=87379
- Reviewed by Antonio Gomes.
- Remove unused API, touchEventCancelAndClearFocusedNode.
- Reviewed Internally by Gen Mak.
- * Api/WebPage.cpp:
- * Api/WebPage.h:
- * WebKitSupport/TouchEventHandler.cpp:
- * WebKitSupport/TouchEventHandler.h:
- (TouchEventHandler):
- 2012-05-23 Genevieve Mak <gmak@rim.com>
- Remove minimum and maximum scroll position as they are no
- longer required due to changes in ScrollViewBase.
- https://bugs.webkit.org/show_bug.cgi?id=87298
- Reviewed by Antonio Gomes.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- * WebKitSupport/InRegionScrollableArea.h:
- (InRegionScrollableArea):
- 2012-05-22 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry]Pages contain video or audio tags should be in pageCache
- https://bugs.webkit.org/show_bug.cgi?id=87116
- Reviewed by George Staikos.
-
- There is not any reason to disable pageCache for video/audio
- tags probably. By my testing, Back and Forward are working for
- those pages contain video and audio tags.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::canCachePage):
- 2012-05-22 Konrad Piascik <kpaiscik@rim.com>
- [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
- https://bugs.webkit.org/show_bug.cgi?id=87125
- Reviewed by Rob Buis.
- Removed unimplemented methods that are no longer part of InspectorClient and added
- a new stub for InspectorStateClient::updateInspectorStateCookie
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
- (WebCore):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- 2012-05-18 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Validation of Last Fat Finger result is needed for selection.
- https://bugs.webkit.org/show_bug.cgi?id=86888
- Reviewed by Antonio Gomes.
- PR 128393.
- Cached FatFingersResults must be validatible against
- the desired request to ensure the result is both for
- the same point and of the same type.
- * WebKitSupport/FatFingers.h:
- (WebKit):
- (FatFingersResult):
- (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
- (BlackBerry::WebKit::FatFingersResult::reset):
- (BlackBerry::WebKit::FatFingersResult::resultMatches):
- (BlackBerry::WebKit::FatFingersResult::originPosition):
- (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
- (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
- (BlackBerry::WebKit::FatFingersResult::isTextInput):
- (BlackBerry::WebKit::FatFingersResult::isValid):
- (BlackBerry::WebKit::FatFingersResult::node):
- (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- 2012-05-18 MORITA Hajime <morrita@google.com>
- https://bugs.webkit.org/show_bug.cgi?id=85515
- Stale frame in WebCore::SpellChecker::didCheckSucceeded
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/EditorClientBlackBerry.h:
- (WebCore::EditorClientBlackBerry::frameWillDetachPage):
- 2012-05-17 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] www.thestar.com/iphone Viewport Weirdness
- https://bugs.webkit.org/show_bug.cgi?id=86756
- Reviewed by George Staikos.
- PR 156710
- On high DPI devices, the virtual viewport size of this page was smaller
- than screen size. During the refreshing of the page, we reset the scale
- when the state was Committed, then layouted and rendered contents based
- on the virtual viewport size and default scale 1, which caused a small
- size thumbnail before we restored the previous view state.
- Fixed it by keeping the previous scale, user scalable and
- m_userViewportArguments during the Committed state of refreshing.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 2012-05-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Cleanup headers in SelectionHandler.cpp
- https://bugs.webkit.org/show_bug.cgi?id=86760
- Reviewed by Antonio Gomes.
- Clean up includes in SelectionHandler.cpp.
- * WebKitSupport/SelectionHandler.cpp:
- 2012-05-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
- https://bugs.webkit.org/show_bug.cgi?id=86759
- Reviewed by Antonio Gomes.
- expandSelectionToGranularity unnecesarily converted the
- selection to range and back. Using the selection
- directly is preferred.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::expandSelectionToGranularity):
- 2012-05-17 Hironori Bono <hbono@chromium.org>
- [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
- https://bugs.webkit.org/show_bug.cgi?id=86591
- Reviewed by Ryosuke Niwa.
- This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
- function to remove platform-specific code from Editor::respondToChangedSelection
- function.
- No new tests, no change in behavior.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
- (WebCore):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2012-05-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Build fix, SelectionHandler extra debug logs
- https://bugs.webkit.org/show_bug.cgi?id=86743
- Reviewed by Antonio Gomes.
- Add include for BlackBerryPlatformLog to SelectionHandler.cpp
- * WebKitSupport/SelectionHandler.cpp:
- 2012-05-16 Yongxin Dai <yodai@rim.com>
- [BlackBerry] The FCC shows up on an empty input field
- https://bugs.webkit.org/show_bug.cgi?id=86657
- Reviewed by Antonio Gomes.
- Turn off the caret by sending a caret changed notification with empty caret.
- PR #120620
- Reviewed Internally by Mike Fenton.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-05-16 Eli Fidler <efidler@rim.com>
- [BlackBerry] Don't reset the default font families in WebSettings
- https://bugs.webkit.org/show_bug.cgi?id=86660
- Reviewed by Rob Buis.
- PR 152467
- The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- 2012-05-16 Genevieve Mak <gmak@rim.com>
- Add missing include that was causing build errors.
- https://bugs.webkit.org/show_bug.cgi?id=86502
- Reviewed by Rob Buis.
- Reviewed Internally by Liam Quinn.
- * WebKitSupport/InputHandler.cpp:
- 2012-05-15 Chris Guan <chris.guan@torchmobile.com.cn>
- [BlackBerry] Enhance an API of BackingStore::drawContents
- https://bugs.webkit.org/show_bug.cgi?id=86447
- Reviewed by George Staikos.
- Enhance the current APIs by adding parameters of id and destination
- contentSize, because chrome browser may want different contents from
- the same webview at different times.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStore::drawContents):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2012-05-15 Max Feil <mfeil@rim.com>
- [BlackBerry] Enable the Fullscreen API
- https://bugs.webkit.org/show_bug.cgi?id=86129
- Reviewed by Antonio Gomes.
- This patch enables the new document-based Fullscreen API.
- The ENABLE(FULLSCREEN_API) is already enabled in the
- BlackBerry WebKit build. My patch turns fullscreen on
- in the page settings by default and implements the missing
- ChromeClientBlackBerry::{supports,enter,exit}FullScreenForElement()
- member functions. I am also plumbing through the existing
- "fullScreenVideoCapable" that QNXStageWebView has always been
- sending to allow the presence of a native fullscreen video player
- to be checked.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::fullScreenVideoCapable):
- (BlackBerry::WebKit::WebSettings::setFullScreenVideoCapable):
- * Api/WebSettings.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
- (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-05-15 Hanna Ma <Hanma@rim.com>
- [BlackBerry] adding a functionality for web inspector to inspect current selected element
- https://bugs.webkit.org/show_bug.cgi?id=86394
- Reviewed by Rob Buis.
- Add a way to trigger the remote web inspector on selected element.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::inspectCurrentContextElement):
- (WebKit):
- * Api/WebPage.h:
- 2012-05-14 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar.com/iphone
- https://bugs.webkit.org/show_bug.cgi?id=86391
- Reviewed by Adam Treat.
- PR 156992
- Request layout first if needed before painting contents.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- 2012-05-10 Mike Fenton <mifenton@rim.com>
- Caret node boundary should be adjusted to account for the visible region.
- https://bugs.webkit.org/show_bug.cgi?id=86116
- Reviewed by Antonio Gomes.
- PR 138988.
- Update the node bounding box to be clipped and adjusted
- for the visible region of the frame.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-05-10 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid
- https://bugs.webkit.org/show_bug.cgi?id=86096
- Reviewed by Rob Buis.
- A Frame's FrameView has always to be checked since it is
- a volatile object, and gets created and destroyed all the time.
- We have been facing a particular issue, where during our automated
- interaction tests, the main frame object was being pinch zoomed in
- the middle of it creation, and WebKit thread was blocked by a mutex.
- In practice, it is a case that would not be possible in a real
- world scenario, but shows that the ASSERTs are bogus regardless.
- * WebKitSupport/BackingStoreClient.cpp:
- (BlackBerry::WebKit::BackingStoreClient::scrollPosition):
- (BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
- (BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
- (BlackBerry::WebKit::BackingStoreClient::viewportSize):
- (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
- (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
- (BlackBerry::WebKit::BackingStoreClient::contentsSize):
- 2012-05-09 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Autofill feature implementation for BlackBerry porting
- https://bugs.webkit.org/show_bug.cgi?id=85577
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::autofillTextField): Added this interface
- function to auto fill the inputting text field when user selects
- a autofill candidate value from autofill context dialog.
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog): Added
- this interface function to notify WebPageClient to pop up the autofill
- context dialog with the suggested input items.
- (BlackBerry::WebKit::WebPage::clearAutofillData):
- * Api/WebPage.h:
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * WebCoreSupport/AutofillManager.cpp:
- (WebCore::AutofillManager::didChangeInTextField):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::textDidChangeInTextField): Implemented
- this function to listen to the notification of text field change, and
- notify AutofillManager to handle the autofill.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- Save the name and value pair of every autofillable input text field when
- user submitting a form.
- 2012-05-09 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
- https://bugs.webkit.org/show_bug.cgi?id=85907
- Reviewed by Rob Buis.
- Internal reviewed by Yong Li.
- Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
- Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
- implementation and add methods in WebKit::WebPage that needed for PagePopupClient.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- (BlackBerry::WebKit::WebPage::initPopupWebView):
- (WebKit):
- (BlackBerry::WebKit::WebPage::popupOpened):
- (BlackBerry::WebKit::WebPage::popupClosed):
- (BlackBerry::WebKit::WebPage::hasOpenedPopup):
- (BlackBerry::WebKit::WebPage::popup):
- (BlackBerry::WebKit::WebPagePrivate::setParentPopup):
- * Api/WebPage.h:
- (WebCore):
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::hasOpenedPopup):
- (WebCore::ChromeClientBlackBerry::openPagePopup):
- (WebCore):
- (WebCore::ChromeClientBlackBerry::closePagePopup):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (WebCore):
- (ChromeClientBlackBerry):
- 2012-05-08 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry] Auth credentials set in private mode are reused in public mode.
- https://bugs.webkit.org/show_bug.cgi?id=84697
- Reviewed by Rob Buis.
- Add setPrivateMode function for CredentialStorage.
- We have to change Private Browsing to test, so have to write a manual test case.
- Test: ManualTests/blackberry/http-auth-private-mode-changed.html
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-05-08 Crystal Zhang <haizhang@rim.com>
-
- [BlackBerry] Implement a popup client for HTML controls
- https://bugs.webkit.org/show_bug.cgi?id=85670
-
- Reviewed by Rob Buis.
-
- Implement a popup client for HTML controls, which would be used to load
- different popups according to popup type.
-
- * WebCoreSupport/PagePopupBlackBerry.cpp: Added.
- (WebCore):
- (PagePopupChromeClient):
- (WebCore::PagePopupChromeClient::PagePopupChromeClient):
- (WebCore::PagePopupChromeClient::closeWindowSoon):
- (WebCore::PagePopupChromeClient::webPage):
- (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
- (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
- (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
- (WebCore::PagePopupBlackBerry::init):
- (WebCore::setValueAndClosePopupCallback):
- (WebCore::popUpExtensionInitialize):
- (WebCore::popUpExtensionFinalize):
- (WebCore::PagePopupBlackBerry::installDomFunction):
- (WebCore::PagePopupBlackBerry::handleMouseEvent):
- (WebCore::PagePopupBlackBerry::closePopup):
- (WebCore::PagePopupBlackBerry::closeWebPage):
- * WebCoreSupport/PagePopupBlackBerry.h: Added.
- (WebKit):
- (WebCore):
- (PagePopupBlackBerry):
- 2012-05-08 Andrew Lo <anlo@rim.com>
- [BlackBerry] Over-scroll image should be tiled
- https://bugs.webkit.org/show_bug.cgi?id=85860
- Reviewed by Rob Buis.
- Implement tiling for over-scroll image if image dimension don't match
- the surface dimensions.
- * Api/BackingStore.cpp:
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2012-05-08 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] remove m_isRequestedByPlugin in ResourceRequest
- https://bugs.webkit.org/show_bug.cgi?id=84559
- Reviewed by Antonio Gomes.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- 2012-05-08 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] AutofillManager implementation upstream
- https://bugs.webkit.org/show_bug.cgi?id=85576
- Reviewed by Rob Buis.
- RIM PR: 136405
- Implemented class AutofillManager to handle the form autofill
- interactions.
- It listens to text changed notification from text input, searches
- autofill database for the suggested autofill candidate value,
- and notifies WebPageClient to pop up a context dialog for user;
- it also responds to user's choice by autofilling the text input.
- * WebCoreSupport/AutofillManager.cpp: Added.
- (WebCore):
- (WebCore::AutofillManager::create):
- (WebCore::AutofillManager::didChangeInTextField):
- (WebCore::AutofillManager::autofillTextField):
- (WebCore::AutofillManager::saveTextFields):
- (WebCore::AutofillManager::clear):
- * WebCoreSupport/AutofillManager.h: Added.
- (WTF):
- (WebKit):
- (WebCore):
- (AutofillManager):
- (WebCore::AutofillManager::m_element):
- 2012-05-07 Andrew Lo <anlo@rim.com>
- [BlackBerry] Delete previous buffer when new over-scroll image path is set
- https://bugs.webkit.org/show_bug.cgi?id=85812
- Reviewed by Rob Buis.
- When a new over-scroll image path is set, delete old buffer before creating
- a new one.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
- 2012-05-07 Andrew Lo <anlo@rim.com>
- [BlackBerry] Over-scroll image path property should be relative to local application directory
- https://bugs.webkit.org/show_bug.cgi?id=85814
- Reviewed by Rob Buis.
- Over-scroll image path web setting should be relative to the local directory.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
- 2012-05-07 Crystal Zhang <haizhang@rim.com>
- [BlackBerry] Add methods need by client side
- https://bugs.webkit.org/show_bug.cgi?id=85661
- Reviewed by Antonio Gomes.
- Add methods needed by client side when create and close HTML popup dialogs.
- PR 154360
- * Api/WebPageClient.h:
- 2012-05-06 Mary Wu <mary.wu@torchmobile.com.cn>
- [BlackBerry] Support html5 download attribute.
- https://bugs.webkit.org/show_bug.cgi?id=85044
- Reviewed by Antonio Gomes.
- If a link has download attribute, we should pass that value and be able to
- save file with the name according to HTML5:
- http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPage::download):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::startDownload):
- 2012-05-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Autofill backing store implementation upstream
- https://bugs.webkit.org/show_bug.cgi?id=85575
- Reviewed by Rob Buis.
- Replaced calling static function CredentialBackingStore::instance()
- with calling the helper function credentialBackingStore().
- * WebCoreSupport/CredentialManager.cpp:
- (WebCore::CredentialManager::autofillAuthenticationChallenge):
- (WebCore::CredentialManager::autofillPasswordForms):
- (WebCore::CredentialManager::saveCredentialIfConfirmed):
- (WebCore::CredentialManager::clearCredentials):
- (WebCore::CredentialManager::clearNeverRememberSites):
- 2012-05-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Enable credential persistance and auto fill
- https://bugs.webkit.org/show_bug.cgi?id=85572
- Reviewed by Rob Buis.
- Set autofilled status of credential input fields when credential
- information is auto filled by CredentialManager.
- By doing this the input element will get painted with yellow background
- which can notify user this input field is auto filled by the browser.
- No behavior changes, so no new test.
- * WebCoreSupport/CredentialTransformData.cpp:
- (WebCore::CredentialTransformData::setCredential):
- 2012-05-04 Andrew Lo <anlo@rim.com>
- [Blackberry] Implement over-scroll background image
- https://bugs.webkit.org/show_bug.cgi?id=85538
- Reviewed by Rob Buis.
- Use over-scroll image when set instead of the solid colour.
- Internal PR146652
- * Api/BackingStore.cpp:
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::standardSettings):
- (BlackBerry::WebKit::WebSettings::overScrollImagePath):
- (BlackBerry::WebKit::WebSettings::setOverScrollImagePath):
- * Api/WebSettings.h:
- 2012-05-04 Rob Buis <rbuis@rim.com>
- [BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
- https://bugs.webkit.org/show_bug.cgi?id=85036
- Reviewed by Antonio Gomes.
- Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.
- * Api/WebSettings.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
- * Api/WebSettings.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createPlugin):
- (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
- (WebCore::FrameLoaderClientBlackBerry::objectContentType):
- 2012-05-04 Nate Chapin <japhet@chromium.org>
- Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
- https://bugs.webkit.org/show_bug.cgi?id=85533
- Reviewed by Alexey Proskuryakov.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::finishedLoading):
- 2012-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r116085, r116091, and r116095.
- http://trac.webkit.org/changeset/116085
- http://trac.webkit.org/changeset/116091
- http://trac.webkit.org/changeset/116095
- https://bugs.webkit.org/show_bug.cgi?id=85628
- We are not ready with dependencies on all platform yet (mac) +
- problems with debug builds. (Requested by Zoltan on #webkit).
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-05-04 Zoltan Horvath <zoltan@webkit.org>
- [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
- https://bugs.webkit.org/show_bug.cgi?id=80400
- Get rid off QT_IMAGE_DECODER flag.
- Reviewed by Simon Hausmann.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- 2012-05-03 Fady Samuel <fsamuel@chromium.org>
- Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
- https://bugs.webkit.org/show_bug.cgi?id=70609
- Reviewed by Kenneth Rohde Christiansen.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::dumpConfigurationForViewport):
- 2012-05-03 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add special attribute for alternate selection touch handling.
- https://bugs.webkit.org/show_bug.cgi?id=85284
- Reviewed by Rob Buis.
- Rename the custom attribute and make it a data- attribute.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
- 2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
- FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
- information about the form being submitted
- https://bugs.webkit.org/show_bug.cgi?id=84297
- Reviewed by Andy Estes.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- Updated to use the FormState.
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- Updated method declaration.
- 2012-05-02 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Double tap zooming does nothing on small size table
- https://bugs.webkit.org/show_bug.cgi?id=85383
- Reviewed by George Staikos.
- PR: 153232
- When we search the best node for block zoom, if the initial node's new
- scale exceeds the maximum block zoom scale, we will try to walk through
- it's ancestors and pick the acceptable one. But the reality is that the
- acceptable ancestor's size can be too close to the size of the actual
- contents, we will do nothing for it. As we will still select the
- minimum of the new scale and the maximum block zoom scale as block zoom
- scale, we can ignore such kind of node and use the initial node instead.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomLimits):
- 2012-05-01 Mike Fenton <mifenton@rim.com>
- Add special attribute for alternate selection touch handling.
- https://bugs.webkit.org/show_bug.cgi?id=85284
- Reviewed by Antonio Gomes.
- PR 152975.
- Add attribute -bb-selection-touchoverride to override
- touch handling on selection overlay.
- Reviewed Internally by Gen Mak.
- * Api/WebPageClient.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
- (WebKit):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (SelectionHandler):
- 2012-04-30 Benjamin Poulain <benjamin@webkit.org>
- Add String::startsWith() and endsWith() for string literals
- https://bugs.webkit.org/show_bug.cgi?id=85154
- Reviewed by Darin Adler.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
- 2012-04-27 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Double tap zooming does nothing on table element on bustedtees.com
- https://bugs.webkit.org/show_bug.cgi?id=85104
- Reviewed by George Staikos.
- PR: 147006
- This was caused by the incorrect fix master_33/SHA:612caec4.
- Calculations like this "originalArea / pageArea" would always return 0
- so that the incorrect node and blockRect were used by block zoom. This
- patch takes care of it.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- (BlackBerry::WebKit::WebPage::blockZoom):
- 2012-04-27 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Improve log output in InputHandler.cpp
- https://bugs.webkit.org/show_bug.cgi?id=85007
- Reviewed by Antonio Gomes.
- PR 138292
- Improving logging in InputHandler.
- In setText we had an early return which wasn't being captured.
- Also, cleaning up the output to make it more clear and descriptive.
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::learnText):
- (BlackBerry::WebKit::InputHandler::enableInputMode):
- (BlackBerry::WebKit::InputHandler::setText):
- 2012-04-27 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] remove redundant returns
- https://bugs.webkit.org/show_bug.cgi?id=85033
- Reviewed by Antonio Gomes.
- Remove two redundant returns which were added by accident.
- No new test cases, because no behaviour has changed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setSelection):
- (BlackBerry::WebKit::WebPage::setCaretPosition):
- 2012-04-27 Andy Chen <andchen@rim.com>
- [BlackBerry] Find-in-page fails to deactivate the old active match when moving backwards
- https://bugs.webkit.org/show_bug.cgi?id=84892
- Reviewed by Antonio Gomes.
- Find in page fails to deactivate the old active match when moving backwards
- because searchStartingPoint was incorrectly initialized.
- Create a real range object instead of referencing other range object.
- PR 152009
- Internally reviewed by Yongxin Dai.
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- 2012-04-26 Yong Li <yoli@rim.com>
- [BlackBerry] A quick fix to the previous patch r115245.
- https://bugs.webkit.org/show_bug.cgi?id=84862
- Reviewed by Antonio Gomes.
- Fix an obvious bug in previous patch: DeferredTaskLoadManualScript
- was using a wrong flag.
- * Api/WebPage.cpp:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-04-25 Chris Guan <chris.guan@torchmobile.com.cn>
- [Blackberry] add a new function in BackingStore
- https://bugs.webkit.org/show_bug.cgi?id=84818
- Reviewed by Antonio Gomes.
- Adding two functions in BackingStorePrivate and
- BackingStore, which could render out webpage contents
- into BlackBerry::Platform::Graphics::Drawable.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (WebKit):
- (BlackBerry::WebKit::BackingStore::drawContents):
- * Api/BackingStore.h:
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- 2012-04-25 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Input Range element expects mouse events
- https://bugs.webkit.org/show_bug.cgi?id=84571
- Reviewed by Antonio Gomes.
- This just cleans up the code a bit to make it less code and more readable.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::shouldConvertTouchToMouse):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::spellCheck):
- 2012-04-25 Yong Li <yoli@rim.com>
- [BlackBerry] Possible JS re-entrancy caused by UI events.
- https://bugs.webkit.org/show_bug.cgi?id=84862
- Reviewed by Antonio Gomes.
- 1. block UI events when running in nested event loop
- 2. defer some tasks we still want to perform when it is safe to do,
- with cached data.
- 3. deferred task can be cancelled by clearing the flag. duplicate tasks
- is not a problem because they share same flag and data.
- 4. move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate
- and make it a deferred task
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::load):
- (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
- (BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
- (BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
- (BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
- (BlackBerry::WebKit::WebPage::assignFocus):
- (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
- (BlackBerry::WebKit::WebPage::setInputSelection):
- (BlackBerry::WebKit::WebPage::popupListClosed):
- (BlackBerry::WebKit::WebPage::setDateTimeInput):
- (BlackBerry::WebKit::WebPage::setColorInput):
- (BlackBerry::WebKit::WebPage::mouseEvent):
- (BlackBerry::WebKit::WebPage::touchEvent):
- (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- (BlackBerry::WebKit::WebPage::touchEventCancel):
- (BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
- (BlackBerry::WebKit::WebPage::keyEvent):
- (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
- (BlackBerry::WebKit::WebPage::setComposingText):
- (BlackBerry::WebKit::WebPage::commitText):
- (BlackBerry::WebKit::WebPage::selectionCancelled):
- (BlackBerry::WebKit::WebPage::cutSelectedText):
- (BlackBerry::WebKit::WebPage::insertText):
- (BlackBerry::WebKit::WebPage::clearCurrentInputField):
- (BlackBerry::WebKit::WebPage::cut):
- (BlackBerry::WebKit::WebPage::paste):
- (BlackBerry::WebKit::WebPage::setSelection):
- (BlackBerry::WebKit::WebPage::setCaretPosition):
- (BlackBerry::WebKit::WebPage::selectAtPoint):
- (BlackBerry::WebKit::WebPage::setFocused):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebCore):
- (WebPagePrivate):
- (DeferredTaskBase):
- (BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
- (BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
- (WebCore::FrameLoaderClientBlackBerry::didResumeLoading):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-04-24 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Perform spellcheck before handling TouchRelease event
- https://bugs.webkit.org/show_bug.cgi?id=84744
- After rebasing to master_35, it appears as though some code had been moved around.
- Here, we were handling the TouchReleased event before calling spellcheck. This
- meant that when we finally got the call to spellcheck, the fatFinger result had been
- reset and the spelling markers had been removed.
- In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
- I am also updating the BlackBerry specific documentMarkerContainingPoint to use
- LayoutPoint instead of IntPoint.
- Internally reviewed by Mike Fenton.
- Reviewed by Antonio Gomes.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::spellCheck):
- * dom/DocumentMarkerController.cpp:
- (WebCore::DocumentMarkerController::markerContainingPoint):
- * dom/DocumentMarkerController.h:
- 2012-04-24 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] setUserViewportArguments not always respected.
- https://bugs.webkit.org/show_bug.cgi?id=84738
- Reviewed by Antonio Gomes.
- Remove the unnecessary logic in
- WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
- Instead it is much simpler to just set the m_viewportArguments to
- m_userViewportArguments on LoadCommitted. If there is a viewport
- tag in the content, m_viewportArguments will be replaced with it
- as usual during normal page load.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2012-04-24 Joe Mason <jmason@rim.com>
- [BlackBerry] Revert broken changes to authentication dialog
- https://bugs.webkit.org/show_bug.cgi?id=80135
- Reviewed by Antonio Gomes.
- The previous patches from this bug caused an infinite loop when using digest auth;
- apparently they were only tested with basic.
- * Api/DumpRenderTreeClient.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-04-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add additional details including the bounds of the box for caretPositionChanged.
- https://bugs.webkit.org/show_bug.cgi?id=84728
- Reviewed by Antonio Gomes.
- PR 138988.
- Update caretPositionChanged to include the limit of the input field
- for single line inputs.
- Reviewed Internally by Gen Mak.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
- (WebKit):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 2012-04-24 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Input Range element expects mouse events
- https://bugs.webkit.org/show_bug.cgi?id=84571
- Reviewed by Antonio Gomes.
- Input element with Range type expects mouse events to
- drag the handle. Note that Input Range could appear
- in both the web page directly, or in some shadow tree,
- like the MediaControlTimeline and MediaControlVolume.
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::isRangeControlElement):
- (WebKit):
- (BlackBerry::WebKit::elementExpectsMouseEvents):
- (BlackBerry::WebKit::shouldConvertTouchToMouse):
- 2012-04-23 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled
- https://bugs.webkit.org/show_bug.cgi?id=84563
- Reviewed by Antonio Gomes.
- Fat Finger log code uses obsolete IntRect::toString() for logging,
- which was first implemented interally and removed later.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- 2012-04-21 Benjamin C Meyer <bmeyer@rim.com>
- Don't hard code the plugins that blackberry supports.
- https://bugs.webkit.org/show_bug.cgi?id=84535
- Use the existing PluginDatabase to query for the plugins we can handle.
- The original implemention of FrameLoaderClientBlackBerry::createPlugin
- was a partial copy from another port. In the Qt port there is some
- workarounds for flash which is why this exists there. Sadly the bits
- that were copied made it so only flash worked, but as flash was the only
- plugin on the system this issue was not noticed until QNX tried to get
- jnext working. Tracing it down to this bit of code rather then
- correcting it they hardcoded the jnext into the same block as flash was.
- The blackberry port isn't specifically suppose to only allow jnext and
- flash, but was an accident due to the way this code was developed.
- Reviewed by Adam Treat.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::createPlugin):
- 2012-04-20 Brady Eidson <beidson@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=84512
- Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
- Reviewed by Eric Carlson.
- PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
- They just use WillDeferLoading by default.
- * Api/WebPageGroupLoadDeferrer.cpp:
- (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
- (WebCore::ChromeClientBlackBerry::runOpenPanel):
- 2012-04-20 Brady Eidson <beidson@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=84490
- PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
- Reviewed by Anders Carlsson.
- * Api/WebPageGroupLoadDeferrer.cpp:
- (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
- which used to be the default
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
- (WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
- 2012-04-20 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Expose WebViewportArguments to WebPageClient
- https://bugs.webkit.org/show_bug.cgi?id=84471
- Reviewed by Antonio Gomes.
- Implement the ability for the WebPageClient to specify a fallback
- virtual viewport to be used whenever a meta viewport tag is not
- present in the HTML. This can drastically impact apparent layout.
- This patch is designed to provide a classic "Column View" style of
- layout without breaking the web by simply exposing meta viewport
- arguments to WebPageClients.
- Note: As a side effect of this change. the WebPagePrivate::
- recomputeVirtualViewportFromViewportArguments method no longer
- modifies the targetDensityDpi property of the m_viewportArguments.
- However this does not affect the class because that property itself
- means nothing to us. Only the computeViewportArguments method from
- WebCore uses it, and the currentViewportArguments object we pass
- into that method has the adjusted targetDensityDpi value as before.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setUserViewportArguments):
- (WebKit):
- (BlackBerry::WebKit::WebPage::resetUserViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- * Api/WebPage.h:
- (WebKit):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebViewportArguments.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit:::d):
- (BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
- (BlackBerry::WebKit::WebViewportArguments::initialScale):
- (BlackBerry::WebKit::WebViewportArguments::setInitialScale):
- (BlackBerry::WebKit::WebViewportArguments::minimumScale):
- (BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
- (BlackBerry::WebKit::WebViewportArguments::maximumScale):
- (BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
- (BlackBerry::WebKit::WebViewportArguments::width):
- (BlackBerry::WebKit::WebViewportArguments::setWidth):
- (BlackBerry::WebKit::WebViewportArguments::height):
- (BlackBerry::WebKit::WebViewportArguments::setHeight):
- (BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
- (BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
- (BlackBerry::WebKit::WebViewportArguments::userScalable):
- (BlackBerry::WebKit::WebViewportArguments::setUserScalable):
- (BlackBerry::WebKit::WebViewportArguments::operator==):
- (BlackBerry::WebKit::WebViewportArguments::operator!=):
- * Api/WebViewportArguments.h: Added.
- (WebCore):
- (WebKit):
- 2012-04-19 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Always use the AnimationFrameRateController for accelerated animations
- https://bugs.webkit.org/show_bug.cgi?id=84323
- Reviewed by Antonio Gomes.
- PR 150750
- Regardless of whether there's a WebPageCompositorClient, we want the
- AnimationFrameRateController to manage animation frames.
- Reviewed internally by Andrew Lo.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- 2012-04-18 Max Feil <mfeil@rim.com>
- [BlackBerry] Tab awareness for HTML5 concurrent audio
- https://bugs.webkit.org/show_bug.cgi?id=82930
- Support for concurrent HTML5 audio improvements being made in
- the platform library, which need to be aware of tabs and tab
- visibility. PR96004.
- Reviewed by George Staikos.
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::isVisible):
- 2012-04-17 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Viewport metatag doesn't disable double-tap zoom
- https://bugs.webkit.org/show_bug.cgi?id=84199
- Reviewed by George Staikos.
- PR: 148279
- When we set "user-scalable=no" in viewport meta-tag and change any
- other WebSettings, the WebPage can turn to be scalable.
- This is a regression of the change master_32/SHA:fa0f8ee9. In that
- change, we used setUserScalable(webSettings->isUserScalable())
- in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
- case, as webSettings->isUserScalable() would always return true by
- default.
- Create a new API WebPage::setUserScalable which will be used in
- DumpRenderTree.cpp.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::setUserScalable):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- * Api/WebPage.h:
- 2012-04-17 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Pattern matching should be applied to numbers
- https://bugs.webkit.org/show_bug.cgi?id=84152
- Reviewed by Antonio Gomes.
- PR 148906.
- Add pattern matching for number based on [0-9] to trigger
- input help matching number fields.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
- (DOMSupport):
- (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
- (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputType):
- 2012-04-17 George Staikos <staikos@webkit.org>
- Export the initialization function so it can be called earlier.
- https://bugs.webkit.org/show_bug.cgi?id=84134
- Reviewed by Nikolas Zimmermann.
- * Api/BlackBerryGlobal.h: export globalInitialize()
- (WebKit):
- 2012-04-16 Antonio Gomes <agomes@rim.com>
- Screen shift down when VKB shows by clicking in a input box MKS_3601371
- https://bugs.webkit.org/show_bug.cgi?id=84057
- Reviewed by Rob Buis.
- After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
- we had a less restricted code path allowing/disallowing overscrolling. That caused
- some webpages like google.com to get on overscroll when adjusting the scroll
- position to ensure the focused input field is visible.
- Patch restricts the way we allow overscrolling to the bottom, where the virtual
- keyboard pops up from, clamping it to 0, 0 if it tries to
- overscroll upwards, and to maximum scroll position if it overscrolls
- downwards.
- PR #149846
- Internally reviewed by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-04-16 Yongxin Dai <yodai@rim.com>
- [BlackBerry] Increase padding for text element
- https://bugs.webkit.org/show_bug.cgi?id=83903
- Reviewed by Antonio Gomes.
-
- PR 125888
-
- Increase the padding value for focused text element to make selection handle
- at least partially visible when the user is dragging at edge of viewport
- in in-region scoll mode.
-
- Reviewed internally by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 2012-04-16 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
- https://bugs.webkit.org/show_bug.cgi?id=84031
- Reviewed by Rob Buis.
- Added the interface function didReceivedAuthenticaitonChallenge()
- in interface class DumpRenderTreeClient;
- Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
- WebPagePrivate::authenticationChallenge() when DRT is enabled.
- Test: reuse existing test cases:
- http/tests/loading/basic-credentials-sent-automatically.html
- http/tests/loading/basic-auth-resend-wrong-credentials.html
- * Api/DumpRenderTreeClient.h:
- (WebCore):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- 2012-04-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
- https://bugs.webkit.org/show_bug.cgi?id=83933
- Reviewed by Adam Treat.
- RIM PR: 149609
- This was because I accidentally dropped an exclamation mark when
- upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
- the exclamation mark.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- 2012-04-12 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Web Inspector messages incorrectly converted
- https://bugs.webkit.org/show_bug.cgi?id=83796
- Reviewed by Rob Buis.
- The JSON sent over from the remote Web Inspector front-end was being
- mis interpreted as ISO-8859-1. This caused all non ascii characters to
- become garbled when using the String constructor, so we use fromtUTF8 instead.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
- 2012-04-12 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Speed up processing of Selection region generation.
- https://bugs.webkit.org/show_bug.cgi?id=82766
- Reviewed by Rob Buis.
- PR 136593.
- Re-speed up text selection. The previous patch had a merge
- error causing text selection not to function. The fix
- implemented removed the optimization. This fixes the error
- in the original patch and removes the temporary fix.
- Make style updated as suggested by Antonio Gomes.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- (BlackBerry::WebKit::regionRectListContainsPoint):
- 2012-04-12 Mike Fenton <mifenton@rim.com>
- Pattern matching for hexadecimal should include * as an allowable count.
- https://bugs.webkit.org/show_bug.cgi?id=83779
- Reviewed by Rob Buis.
- Update pattern matching check to allow wildcard for number
- of characters allowed.
- PR 148907.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
- 2012-04-11 Joe Mason <jmason@rim.com>
- [BlackBerry] Update to the thread-safe GuardedPointer API
- https://bugs.webkit.org/show_bug.cgi?id=83603
- Reviewed by Rob Buis.
- RIM PR: 134984
- Make the destructors of all objects inheriting GuardedPointerBase protected or
- private, and delete them using BlackBerry::Platform::deleteGuardedObject.
- Access all GuardedPointers through GuardedPointerLocker.
- No new tests, refactor.
- Reviewed internally by Yong Li and George Staikos.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStore::~BackingStore):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::~WebPage):
- (BlackBerry::WebKit::WebPage::destroy):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-04-10 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
- https://bugs.webkit.org/show_bug.cgi?id=83567
- Reviewed by Antonio Gomes.
- Fixed by checking if there's a layer renderer before calling into it.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
- 2012-04-09 Eli Fidler <efidler@rim.com>
- [BlackBerry] Update about:config page
- https://bugs.webkit.org/show_bug.cgi?id=83515
- Reviewed by Rob Buis.
- * WebCoreSupport/AboutData.cpp:
- (WebCore::configPage):
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutDataHaveFeatures.in:
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2012-04-07 Rob Buis <rbuis@rim.com>
- [BlackBerry] Add Battery Status API support
- https://bugs.webkit.org/show_bug.cgi?id=82615
- Reviewed by George Staikos.
- Add client implementation for Battery API.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init): initialize BatteryClient.
- * WebCoreSupport/BatteryClientBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
- (WebCore::BatteryClientBlackBerry::setController):
- (WebCore::BatteryClientBlackBerry::startUpdating):
- (WebCore::BatteryClientBlackBerry::stopUpdating):
- (WebCore::BatteryClientBlackBerry::batteryControllerDestroyed):
- (WebCore::BatteryClientBlackBerry::onLevelChange):
- (WebCore::BatteryClientBlackBerry::onChargingChange):
- (WebCore::BatteryClientBlackBerry::onChargingTimeChange):
- (WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
- * WebCoreSupport/BatteryClientBlackBerry.h: Added.
- (WebCore):
- (BatteryClientBlackBerry):
- (WebCore::BatteryClientBlackBerry::~BatteryClientBlackBerry):
- 2012-04-06 Benjamin Poulain <bpoulain@apple.com>
- Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
- https://bugs.webkit.org/show_bug.cgi?id=83325
- Reviewed by Ryosuke Niwa.
- * WebCoreSupport/AboutDataUseFeatures.in:
- 2012-04-06 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Text selection - Can't select texts
- https://bugs.webkit.org/show_bug.cgi?id=83355
- Fix the problem of not sending out the result of the function
- SelectionHandler::regionForTextQuads(). This regression issue
- is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.
- Reviewed by George Staikos.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- Add code to return the function result.
- 2012-04-05 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
- https://bugs.webkit.org/show_bug.cgi?id=83252
- Reviewed by George Staikos.
- Test: http/tests/misc/resources/referrer-main-resource.php
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::load):
- 2012-04-05 George Staikos <staikos@webkit.org>
- Add a vibration client for BlackBerry and enable it.
- https://bugs.webkit.org/show_bug.cgi?id=83340
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init): enable the client
- * WebCoreSupport/VibrationClientBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
- (WebCore::VibrationClientBlackBerry::vibrate):
- (WebCore::VibrationClientBlackBerry::cancelVibration):
- (WebCore::VibrationClientBlackBerry::vibrationDestroyed):
- * WebCoreSupport/VibrationClientBlackBerry.h: Added.
- (WebCore):
- (VibrationClientBlackBerry):
- (WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):
- 2012-04-05 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Force compositing mode when backing store is not active
- https://bugs.webkit.org/show_bug.cgi?id=83131
- Reviewed by George Staikos.
- RIM PR: 136381
- Normally, the BlackBerry WebKit port resorts to direct rendering when
- the backing store is not active. However, direct rendering is broken
- with the OpenGL code path. This prevented multiple web pages from being
- displayed at once with the new WebPageCompositor API.
- Fixed by using accelerated compositing layer to render the root layer
- instead of backing store. This will give us a tiled layer backing the
- root layer, which for some use cases is even better than direct
- rendering.
- Reviewed internally by Filip Spacek.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPage::setVisible):
- (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
- (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
- (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
- (BlackBerry::WebKit::WebPagePrivate::createCompositor):
- (BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
- (BlackBerry::WebKit::WebPagePrivate::setNeedsOneShotDrawingSynchronization):
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
- (WebKit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::rootLayer):
- (WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setDrawsRootLayer):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-04-05 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Clear local storage won't take effect until browser exit and relaunch
- https://bugs.webkit.org/show_bug.cgi?id=83253
- Reviewed by Rob Buis.
- RIM PR: #146871
- Cleared the local storage namespace of a WebPage's PageGroup
- when WebPage::clearLocalStorage() get called.
- Also deleted unused global function clearLocalStorage().
- * Api/BlackBerryGlobal.cpp:
- * Api/BlackBerryGlobal.h:
- (WebKit):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::clearLocalStorage):
- 2012-04-04 Rob Buis <rbuis@rim.com>
- [BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
- https://bugs.webkit.org/show_bug.cgi?id=83085
- Reviewed by Antonio Gomes.
- PR 121109
- This way when we add something to the enum and forget to add to the switch we'll get a compile error.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
- 2012-04-03 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
- https://bugs.webkit.org/show_bug.cgi?id=82643
- Enhance BlackBerry::WebKit::WebPage::findNextString()
- This patch adds support for toggling case sensitivity,
- search wrapping, and whether or not to highlight all matches
- in addition to the next found match.
- I refactored and renamed the new setActiveMatchAndMarker() method
- to move the active match from one range to another. This was
- required because in the case of a non wrapped search we do not
- want to adjust the m_activeMatch if another match is not found.
- Internal Review by Andy Chen.
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::findNextString):
- * Api/WebPage.h:
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- (BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- * WebKitSupport/InPageSearchManager.h:
- (InPageSearchManager):
- 2012-04-02 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Adapt WebPagePrivate::webContext to the API change of r109570
- https://bugs.webkit.org/show_bug.cgi?id=82945
- Reviewed by Rob Buis.
- RIM PR: 147163
- Adapt WebPagePrivate::webContext to the API change of the security
- cherry-pick of r109570 and r112023.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- 2012-04-02 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
- https://bugs.webkit.org/show_bug.cgi?id=80519
- Set the right TargetType for main loads if they are not already set in
- dispatchWillSendRequest().
- Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
- and dispatchDecidePolicyForNavigationAction() as they are called before
- dispatchWillSendRequest() is called. Patch to change ResourceRequest
- TargetType earlier has been rejected as in WebKit bug
- https://bugs.webkit.org/show_bug.cgi?id=80713
- Reviewed by Rob Buis.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
- (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
- 2012-04-01 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
- https://bugs.webkit.org/show_bug.cgi?id=82845
- Reviewed by Rob Buis.
- RIM PR: 136381
- The code accounted for a now obsolete setup where we used one OpenGL
- window for accelerated compositing and one native window for backing
- store output, and let the windowing system composite those two. In that
- setup an optimization to try and only update the window that had
- changed was viable.
- Nowadays, we either use an offscreen surface for accelerated
- compositing output, which we blend onto the window containing the
- backing store output, or render both backing store and accelerated
- compositing output directly to one OpenGL window. We always have to
- blit the backingstore contents and draw the accelerated compositing
- output every frame with these code paths, so don't try to be clever
- about it.
- Even when we use an OpenGL window, the compositing surface can be non-
- null, so don't try to glFinish() and swap the compositing surface when
- the GLES2Context is tied to a window.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (WebKit):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
- * WebKitSupport/GLES2Context.cpp:
- (BlackBerry::WebKit::GLES2Context::swapBuffers):
- 2012-03-31 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
- https://bugs.webkit.org/show_bug.cgi?id=80135
- Reviewed by Rob Buis.
- RIM PR: 145660
- Fixed a regression introduced by r111810, which used the wrong
- credential object.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- 2012-03-30 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Speed up processing of Selection region generation.
- https://bugs.webkit.org/show_bug.cgi?id=82766
- Reviewed by Rob Buis.
- PR 136593.
- Refactor generation of Selection IntRectRegion to avoid
- the need for IntRectRegion's helper functions which were
- not available when using it as a container without
- unioning the rects.
- This greatly speeds up rendering by maintaining the distinct
- rects as the union operation was length with large numbers of
- rects.
- Reviewed Internally by Gen Mak, Mike Lattanzio and Tyler Abbott.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
- (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (WebKit):
- (BlackBerry::WebKit::regionRectListContainsPoint):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- * WebKitSupport/SelectionHandler.h:
- (WebCore):
- (SelectionHandler):
- 2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
- GEOLOCATION should be implemented as Page Supplement
- https://bugs.webkit.org/show_bug.cgi?id=82228
- Reviewed by Adam Barth.
- Geolocation is now a Supplement in Page so the interface
- has changed for setting up the page's geolocation client
- initially and accessing the controller later.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
- (GeolocationControllerClientBlackBerry::onLocationUpdate):
- (GeolocationControllerClientBlackBerry::onLocationError):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- (DumpRenderTreeSupport::resetGeolocationMock):
- (DumpRenderTreeSupport::setMockGeolocationError):
- (DumpRenderTreeSupport::setMockGeolocationPermission):
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- 2012-03-30 Keishi Hattori <keishi@webkit.org>
- Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
- https://bugs.webkit.org/show_bug.cgi?id=80972
- Reviewed by Kent Tamura.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isColorInputField):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputType):
- 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r111259.
- http://trac.webkit.org/changeset/111259
- https://bugs.webkit.org/show_bug.cgi?id=82650
- Caused selection regression in calculations due to
- misconstructed IntRectRegion. (Requested by mfenton on
- #webkit).
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
- 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
- Unreviewed, rolling out r112553.
- http://trac.webkit.org/changeset/112553
- https://bugs.webkit.org/show_bug.cgi?id=82638
- It made all tests crash on Qt WK2 (Requested by Ossy_away on
- #webkit).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
- (GeolocationControllerClientBlackBerry::onLocationUpdate):
- (GeolocationControllerClientBlackBerry::onLocationError):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- (DumpRenderTreeSupport::resetGeolocationMock):
- (DumpRenderTreeSupport::setMockGeolocationError):
- (DumpRenderTreeSupport::setMockGeolocationPermission):
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- 2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
- GEOLOCATION should be implemented as Page Supplement
- https://bugs.webkit.org/show_bug.cgi?id=82228
- Reviewed by Adam Barth.
- Geolocation is now a Supplement in Page so the interface
- has changed for setting up the page's geolocation client
- initially and accessing the controller later.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
- (GeolocationControllerClientBlackBerry::onLocationUpdate):
- (GeolocationControllerClientBlackBerry::onLocationError):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- (DumpRenderTreeSupport::resetGeolocationMock):
- (DumpRenderTreeSupport::setMockGeolocationError):
- (DumpRenderTreeSupport::setMockGeolocationPermission):
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- 2012-03-28 Nate Chapin <japhet@chromium.org>
- Remove dispatchDidLoadMainResource callback, since no
- port implements it.
- https://bugs.webkit.org/show_bug.cgi?id=82539
- Reviewed by Alexey Proskuryakov.
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-03-28 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
- https://bugs.webkit.org/show_bug.cgi?id=82420
- Reviewed by Rob Buis.
- In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
- for PlatformMouseEvent, but this method is same as globalPosition() that is available for
- every porting. We should use globalPosition().
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 2012-03-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
- [BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
- https://bugs.webkit.org/show_bug.cgi?id=82292
- Change to check and avoid text selection across frames.
- Internal reviewed by Mike Fenton
- Reviewed by Rob Buis.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- support selection across frames, so check if the *framePoint* is in
- the *frame*.
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- function returns a null VisablePosition, it stands for a invalid position
- or a position in the different frames, therefor we don't execute setting
- handle's position.
- 2012-03-27 Andrew Lo <anlo@rim.com>
- [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
- https://bugs.webkit.org/show_bug.cgi?id=82350
- Switch timer in WebPageCompositor to use AnimationFrameRateController.
- Reviewed by Rob Buis.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- * Api/WebPageCompositor_p.h:
- (WebPageCompositorPrivate):
- 2012-03-27 Chris Guan <chris.guan@torchmobile.com.cn>
- A page containing multiparts with "multipart/x-mixed-replace" should not be cached.
- https://bugs.webkit.org/show_bug.cgi?id=82291
- Reviewed by Rob Buis.
- If we have a multiPart reponse with multipart/x-mixed-replace,
- the current page should not be cached. I use isMultipartPayload()
- API which was supposed to be set in NetworkJob to decide to
- cache page or not.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::canCachePage):
- 2012-03-25 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor
- https://bugs.webkit.org/show_bug.cgi?id=82104
- RIM PR: 145963
- Reviewed by Rob Buis.
- The root layer may be set before we have a layer renderer, because the
- latter is not created until we get an OpenGL context from the embedder.
- Fixed by setting the root layer on the layer renderer when it's created
- instead of assuming a certain order of events.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
- 2012-03-23 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API
- https://bugs.webkit.org/show_bug.cgi?id=81121
- RIM PR: 136687
- Reviewed by Rob Buis.
- The idea is for the API client to use a WebPageCompositor object to
- render the WebPage when there's no screen window available.
- The WebPageCompositorPrivate becomes reference counted in order to be
- kept alive either because it's used for accelerated compositing layers
- or used for the WebPageCompositor API. It can still work standalone.
- Clean up some code - no need to keep track of a separate boolean
- WebPagePrivate::m_isAcceleratedCompositingActive when the state of
- m_compositor can tell you.
- Also remove duplicated code from WebPagePrivate - go directly to the
- compositor object instead, if you need to draw the AC layers.
- Reviewed internally by Robin Cao and the hasBlitJobs/blitOnIdle change
- by Filip Spacek.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStore::hasBlitJobs):
- (BlackBerry::WebKit::BackingStore::blitOnIdle):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- (BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
- (BlackBerry::WebKit::BackingStorePrivate::buffer):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
- (BlackBerry::WebKit::WebPagePrivate::setCompositor):
- (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
- (BlackBerry::WebKit::WebPagePrivate::createCompositor):
- (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- * Api/WebPage.h:
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
- (BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
- (BlackBerry::WebKit::WebPageCompositorPrivate::render):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
- (BlackBerry::WebKit::WebPageCompositorPrivate::compositorDestroyed):
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::client):
- (BlackBerry::WebKit::WebPageCompositor::prepareFrame):
- (BlackBerry::WebKit::WebPageCompositor::render):
- (BlackBerry::WebKit::WebPageCompositor::cleanup):
- (BlackBerry::WebKit::WebPageCompositor::contextLost):
- * Api/WebPageCompositor.h: Added.
- * Api/WebPageCompositorClient.h: Added.
- * Api/WebPageCompositor_p.h:
- (BlackBerry::WebKit::WebPageCompositorPrivate::create):
- (BlackBerry::WebKit::WebPageCompositorPrivate::context):
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameTimestamp):
- (BlackBerry::WebKit::WebPageCompositorPrivate::page):
- (BlackBerry::WebKit::WebPageCompositorPrivate::client):
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::client):
- (BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
- (BlackBerry::WebKit::WebPagePrivate::compositor):
- 2012-03-22 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Need to store the meta info of a page in the ViewState of the history
- https://bugs.webkit.org/show_bug.cgi?id=82000
- Reviewed by Rob Buis.
- Internally reviewed by George Staikos.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 2012-03-22 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
- https://bugs.webkit.org/show_bug.cgi?id=81887
- Reviewed by Rob Buis.
- Added two interface functions clearCredentials() and
- clearNeverRememberSites() into class WebPage, which
- should be used by UI to clear the stored credential
- information and never remember sites.
- Also implemented the corresponding functions in class
- CredentialManager to call CredentialBackingStore
- to perform the actual clear table work.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::clearCredentials):
- (WebKit):
- (BlackBerry::WebKit::WebPage::clearNeverRememberSites):
- * Api/WebPage.h:
- * WebCoreSupport/CredentialManager.cpp:
- (WebCore::CredentialManager::clearCredentials):
- (WebCore):
- (WebCore::CredentialManager::clearNeverRememberSites):
- * WebCoreSupport/CredentialManager.h:
- (CredentialManager):
- 2012-03-22 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
- https://bugs.webkit.org/show_bug.cgi?id=80135
- Reviewed by Rob Buis.
- Modified the interface function authenticationChallenge() in
- class WebPagePrivate by returning a bool to indicate if user
- pressed Ok button or not, and moved the Credential from return
- value to the reference parameter.
- Also updated the corresponding interface functions in class
- WebPageClient.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-03-22 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] DeviceDPI Scaling is broken on mobile.
- https://bugs.webkit.org/show_bug.cgi?id=81966
- Fix our viewport argument handling to only override the
- targetDensityDpi on tablet devices. Allow WebCore to use
- dpi scaling for smaller screen mobile devices.
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2012-03-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Add pattern matching for hexadecimal type input fields
- https://bugs.webkit.org/show_bug.cgi?id=81944
- Reviewed by Rob Buis.
- PR 98504.
- Add mapping of patterns matching hexadecimal input
- to a specialized type and provide input styling based
- on that format.
- Reviewed Internally by Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
- (DOMSupport):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputType):
- (BlackBerry::WebKit::inputStyle):
- 2012-03-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
- https://bugs.webkit.org/show_bug.cgi?id=81929
- Reviewed by Rob Buis.
- Make suggested style clean up and move int offset = 0 directly
- above is actual usage.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isPositionInNode):
- 2012-03-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
- https://bugs.webkit.org/show_bug.cgi?id=81929
- Reviewed by Rob Buis.
- Add early returns in isPositionInNode when either
- node or the position node is null.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::isPositionInNode):
- 2012-03-21 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] Credential save and autofill implemetation
- https://bugs.webkit.org/show_bug.cgi?id=80401
- Reviewed by Rob Buis.
- This patch is intended to implement the credential persist
- and autofill feature for BlackBerry porting.
- Moved interface authenticationChallenge() from class
- FrameLoaderClientBlackBerry to WebPagePrivate (derived from
- PageClientBlackBerry as changes made in its parent interface class);
- Implemented notifyShouldSaveCredential() in WebPagePrivate
- and WebPageClient as well.
- Added credentialManager() to retrive CredentialManager instance
- as a global singleton; removed its m_frameLoaderClient which is
- replaced with a passed in PageClientBlackBerry pointer, and modified
- the interface function accordingly.
- For the http authentication, autofill the input dialog in
- function authenticationChallenge() and save the credential
- information in the same function;
- For the in-form authentication, autofill the username and
- password input fields in function dispatchDidFinishLoad(),
- and save the credential information in function
- dispatchWillSubmitForm() or dispatchWillSendSubmitEvent().
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::notifyShouldSaveCredential):
- * Api/WebPageClient.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * WebCoreSupport/CredentialManager.cpp:
- (WebCore::credentialManager):
- (WebCore::CredentialManager::saveCredentialIfConfirmed):
- * WebCoreSupport/CredentialManager.h:
- (CredentialManager):
- (WebCore::CredentialManager::CredentialManager):
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-03-20 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
- https://bugs.webkit.org/show_bug.cgi?id=81686
- Reviewed by Rob Buis.
- When deciding the policy for navigation action, if the url of the
- request is null, ignore it to avoid the ASSERT failure in
- MainResourceLoader::willSendRequest.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- 2012-03-20 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
- https://bugs.webkit.org/show_bug.cgi?id=81670
- Reviewed by Rob Buis.
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (WebCore::InspectorClientBlackBerry::canClearBrowserCache):
- (WebCore::InspectorClientBlackBerry::canClearBrowserCookies):
- 2012-03-20 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Removing doubly defined methods in BackingStore.cpp
- https://bugs.webkit.org/show_bug.cgi?id=81664
- Reviewed by Rob Buis.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- 2012-03-20 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Crash when dragging the FCC caret over an invalid node.
- https://bugs.webkit.org/show_bug.cgi?id=81654
- Reviewed by Rob Buis.
- PR 144505.
- The position did not have a valid container node and was causing
- a crash. Validate the node pointer before using it.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::DOMContainerNodeForPosition):
- 2012-03-20 Jason Liu <jason.liu@torchmobile.com.cn>
- [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.
- https://bugs.webkit.org/show_bug.cgi?id=80800
- Reviewed by George Staikos.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
- (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
- 2012-03-19 Adam Barth <abarth@webkit.org>
- Remove support for "magic" iframe
- https://bugs.webkit.org/show_bug.cgi?id=81590
- Reviewed by Eric Seidel.
- Remove FrameLoaderClient methods that no longer exist.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- (WebCore::FrameLoaderClientBlackBerry::didDetectXSS):
- 2012-03-19 Tyler Abbott <tabbott@rim.com>
- [BlackBerry] speed up text selection for large selections
- https://bugs.webkit.org/show_bug.cgi?id=81536
- When selecting large disjoint areas of text the cost
- of calculating the IntRectRegion union becomes very
- expensive. Simply placing all of the text quads into
- the IntRectRegion is faster despite the larger memory
- footprint and the additional calculations at render
- time.
- Reviewed by Rob Buis.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
- 2012-03-19 Mike Lattanzio <mlattanzio@rim.com>
- [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
- https://bugs.webkit.org/show_bug.cgi?id=81269
- Generate the UserAgent lazily, using it as the default for the
- WebSettings object. BlackBerry::Platform::DeviceInfo is used
- to ensure the information is accurate to the specific device.
- Remove the !isEmpty() assert when fetching the UA from the
- WebSettings object, as it will now always be properly initialized.
- Add a static initializer block to ensure defaultUserAgent() is
- thread-safe from that moment onward.
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::setUserAgentString):
- * Api/WebSettings.h:
- 2012-03-19 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Input fields with id of e-mail and url should be styled as such.
- https://bugs.webkit.org/show_bug.cgi?id=81364
- Reviewed by Rob Buis.
- Be less aggressive on matching url, and update as suggested by Rob.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::inputStyle):
- 2012-03-19 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
- https://bugs.webkit.org/show_bug.cgi?id=81115
- Reviewed by Benjamin Poulain.
- The compositor tried to avoid rendering the same stuff twice, using a
- mechanism that didn't work properly and has been redundant since we
- introduced deferred blits. Remove this code.
- Reviewed internally by Robin Cao.
- * Api/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::commit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- * Api/WebPageCompositor_p.h:
- 2012-03-17 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Enable Web Timing for performance profiling and improvement.
- https://bugs.webkit.org/show_bug.cgi?id=81085
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-03-16 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
- https://bugs.webkit.org/show_bug.cgi?id=81108
- RIM PR: 136687
- Reviewed by Rob Buis.
- This is done in anticipation of a new WebPageCompositor class in the
- public API. The existing internal class will serve to d-pointerize the
- new public API. In addition, it is and will be possible to create only
- the private class, for cases where existing code paths require
- OpenGL compositing (i.e. due to accelerated compositing layers being
- added to the page).
- Reviewed internally by Robin Cao.
- * Api/BackingStore.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):
- * Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.
- (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
- (BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
- (BlackBerry::WebKit::WebPageCompositorPrivate::commit):
- (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- (BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
- (BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
- * Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.
- (BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
- (BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
- (BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):
- * Api/WebPage_p.h:
- * CMakeListsBlackBerry.txt:
- 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
- https://bugs.webkit.org/show_bug.cgi?id=81118
- Reviewed by Rob Buis.
- This is a consolidation of various changes that are in our local dev branch
- but do not appear in our upstreamed port.
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::SurfacePool::createBuffers):
- (BlackBerry::WebKit::SurfacePool::releaseBuffers):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- * WebKitSupport/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- * WebKitSupport/WebPageCompositor.h:
- (WebPageCompositor):
- 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
- https://bugs.webkit.org/show_bug.cgi?id=81120
- Reviewed by Rob Buis.
- This is a consolidation of various changes that are in our local dev branch
- but do not appear in our upstreamed port.
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/AboutDataHaveFeatures.in:
- * WebCoreSupport/AboutDataUseFeatures.in:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::hasOpenedPopup):
- (WebCore):
- (WebCore::ChromeClientBlackBerry::screenToRootView):
- (WebCore::ChromeClientBlackBerry::rootViewToScreen):
- (WebCore::ChromeClientBlackBerry::invalidateRootView):
- (WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
- (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
- (WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
- (WebCore::ChromeClientBlackBerry::createColorChooser):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- (WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::registerUndoStep):
- (WebCore::EditorClientBlackBerry::registerRedoStep):
- (WebCore::EditorClientBlackBerry::undo):
- (WebCore::EditorClientBlackBerry::redo):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
- (GeolocationControllerClientBlackBerry::requestPermission):
- (GeolocationControllerClientBlackBerry::cancelPermissionRequest):
- * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
- * WebCoreSupport/InspectorClientBlackBerry.cpp:
- (WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
- (WebCore):
- (WebCore::InspectorClientBlackBerry::bringFrontendToFront):
- * WebCoreSupport/InspectorClientBlackBerry.h:
- (InspectorClientBlackBerry):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::show):
- 2012-03-16 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Input fields with id of e-mail and url should be styled as such.
- https://bugs.webkit.org/show_bug.cgi?id=81364
- Reviewed by Rob Buis.
- Treat fields that have name/id's that match url or
- email as url or email fields providing the appropriate
- keyboard.
- PR 137259.
- Reviewed Internally by Gen Mak and Nima Ghanavatian.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
- (DOMSupport):
- (BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
- (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
- (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
- (BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):
- * WebKitSupport/DOMSupport.h:
- (WebCore):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertInputType):
- (BlackBerry::WebKit::inputStyle):
- 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
- https://bugs.webkit.org/show_bug.cgi?id=81105
- Reviewed by Rob Buis.
- This patches fixes up a previous sync done in this directory and adds some new bits
- as well. This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
- local repo.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPage::webContext):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-03-16 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Input processing mode should be cancelled when processing hot keys
- https://bugs.webkit.org/show_bug.cgi?id=81348
- Reviewed by Rob Buis.
- Don't suppress IMF notifications if we are handling
- the event as a hotkey.
- Reviewed Internally by Nima Ghanavatian.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
- 2012-03-16 Robin Cao <robin.cao@torchmobile.com.cn>
- [BlackBerry] Can not open certain links from bridge applications
- https://bugs.webkit.org/show_bug.cgi?id=81197
- Reviewed by Rob Buis.
- Currently, the engine asks the client to handle some type of requests externally.
- But WebPageClient::handleStringPattern is not yet implemented and exposed to
- the client. Before that, we still need to give the client a chance to decide
- how to handle requests such as 'mailto:'.
- To address this problem, r108763 introduced a change that ask the client to
- decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
- This is not intuitive and will bring troubles, because this navigation will
- happen in the new page. So the new page client is to decide how to handle
- the navigation, not the old one.
- This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
- since it's not implemented.
- This way the new window action will continue, and the logic in
- dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
- 2012-03-16 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Crash when going back from an xhtml document containing <img>
- https://bugs.webkit.org/show_bug.cgi?id=81297
- Reviewed by Rob Buis.
- This is manually reverting the offending internal commit which checked-in before upstreaming.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::canCachePage):
- 2012-03-16 Genevieve Mak <gmak@rim.com>
- [BlackBerry] viewportRect has changed to viewportSize
- https://bugs.webkit.org/show_bug.cgi?id=81262
- Reviewed by Antonio Gomes.
- Set size instead of rect in constructor.
- * WebKitSupport/InRegionScrollableArea.cpp:
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 2012-03-16 Andrew Lo <anlo@rim.com>
- [BlackBerry] Enable PAGE_VISIBILITY_API
- https://bugs.webkit.org/show_bug.cgi?id=81257
- Set Page visibility state for BlackBerry port.
- Reviewed by Rob Buis.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- (WebKit):
- (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
- (BlackBerry::WebKit::WebPagePrivate::setVisible):
- (BlackBerry::WebKit::WebPage::setVisible):
- (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
- (BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-03-14 Arvid Nilsson <anilsson@rim.com>
- [BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
- https://bugs.webkit.org/show_bug.cgi?id=81099
- Reviewed by Rob Buis.
- Also rename the "compositing/blitting to main window" variables to
- instead refer to OpenGL compositing. The code paths it triggers are
- related to the BackingStore using OpenGL compositing, and can be useful
- even when there's no window.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
- (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
- (BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
- (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
- (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
- (BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
- (BlackBerry::WebKit::BackingStorePrivate::buffer):
- * Api/BackingStore_p.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
- (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
- (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
- (BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
- (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::windowRect):
- (WebCore::ChromeClientBlackBerry::screenToWindow):
- (WebCore::ChromeClientBlackBerry::windowToScreen):
- * WebKitSupport/GLES2Context.cpp:
- (BlackBerry::WebKit::GLES2Context::GLES2Context):
- * WebKitSupport/TouchEventHandler.h:
- * WebKitSupport/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
- (BlackBerry::WebKit::WebPageCompositor::drawLayers):
- * WebKitSupport/WebPageCompositor.h:
- 2012-03-13 Jon Lee <jonlee@apple.com>
- Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
- https://bugs.webkit.org/show_bug.cgi?id=80922
- <rdar://problem/11035082>
- Reviewed by Jian Li.
- You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
- LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
- new API. Therefore, APIs that are common between the two will have:
- #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
- This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
- the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
- Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- * WebCoreSupport/NotificationPresenterImpl.h:
- 2012-03-14 Nima Ghanavatian <nghanavatian@rim.com>
- [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
- https://bugs.webkit.org/show_bug.cgi?id=81105
- Reviewed by Rob Buis.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (BlackBerry::WebKit::BackingStorePrivate::isActive):
- (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
- (WebKit):
- (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
- * Api/BackingStore.h:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::toWebCoreMouseEventType):
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
- (BlackBerry::WebKit::WebPage::activeNodeContext):
- (BlackBerry::WebKit::WebPagePrivate::updateCursor):
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-03-14 Andrew Lo <anlo@rim.com>
- [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
- https://bugs.webkit.org/show_bug.cgi?id=81000
- Set the platform display ID, needed for DisplayRefreshMonitor.
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-03-14 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
- https://bugs.webkit.org/show_bug.cgi?id=81086
- Reviewed by Rob Buis.
- There was an alias named PlatformCursorHandle for PlatformCursor
- in the internal version of Cursor.h. But it's not necessary so it's
- not included in the upstreaming version of Cursor.h. As a result,
- use PlatformCursor directly.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setCursor):
- * Api/WebPage_p.h:
- (WebPagePrivate):
- 2012-03-13 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Input focus state should unfocus the frame selection instead of the field.
- https://bugs.webkit.org/show_bug.cgi?id=81023
- Reviewed by Antonio Gomes.
- PR 137400.
- Prevent cursor drawing by unfocusing the frame selection
- when input mode is not ready.
- Greatly simplify the decision to focus input fields by removing
- all ties to the page load state and base it on input. Input mode
- is disabled when a page load begins and enabled on any user input.
- The field is focused and ready for input immediately, only the
- frame selection (or cursor) is unfocused.
- Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setLoadState):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * Api/WebPageClient.h:
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldBeginEditing):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::enableInputMode):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::setComposingText):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
- Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
- https://bugs.webkit.org/show_bug.cgi?id=78853
- Reviewed by Adam Barth.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/AboutDataEnableFeatures.in:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (toGeolocationClientMock):
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- (DumpRenderTreeSupport::resetGeolocationMock):
- (DumpRenderTreeSupport::setMockGeolocationError):
- (DumpRenderTreeSupport::setMockGeolocationPermission):
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- 2012-03-13 Mike Lattanzio <mlattanzio@rim.com>
- Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
- https://bugs.webkit.org/show_bug.cgi?id=80984
- Remove ActiveNodeContext, and switch the implementation to
- provide a BlackBerry::Platform::WebContext. The new object
- adds an explicit IsImage flag, as well as IsAudio and IsVideo
- for the HTML5 elements.
- Note that for many videos both IsVideo and IsAudio will be true,
- as videos typically have audio streams as well.
- Reviewed by George Staikos.
- * Api/ActiveNodeContext.h: Removed.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::webContext):
- (BlackBerry::WebKit::WebPage::webContext):
- * Api/WebPage.h:
- * Api/WebPage_p.h:
- 2012-03-12 Andy Chen <andchen@rim.com>
- [Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
- https://bugs.webkit.org/show_bug.cgi?id=80831
- Reviewed by Antonio Gomes.
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
- (BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
- (BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
- (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
- (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
- (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
- (BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
- * WebKitSupport/InPageSearchManager.h:
- 2012-03-09 Jon Lee <jonlee@apple.com>
- Rename NotificationPresenter to NotificationClient
- https://bugs.webkit.org/show_bug.cgi?id=80488
- <rdar://problem/10965558>
- Reviewed by Kentaro Hara.
- Refactor to use renamed WebCore::NotificationClient.
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebCore::NotificationPresenterImpl::instance):
- (WebCore::NotificationPresenterImpl::show):
- (WebCore::NotificationPresenterImpl::checkPermission):
- * WebCoreSupport/NotificationPresenterImpl.h:
- (NotificationPresenterImpl):
- 2012-03-09 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Web Notification not working after rebase
- https://bugs.webkit.org/show_bug.cgi?id=80690
- Reviewed by George Staikos.
- 1. NotificationPresenterImpl should be in namespace WebCore
- 2. Need to connect NotificationPresenterImpl to webcore the new way:
- WebCore::provideNotification(Page*, NotificationPresenter*)
- 3. Remove the old way of connecting the Notification:
- ChromeClientBlackBerry::notificationPresenter()
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- * WebCoreSupport/NotificationPresenterImpl.h:
- 2012-03-08 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Always use the current focused node when processing focus changes
- https://bugs.webkit.org/show_bug.cgi?id=80594
- Reviewed by Antonio Gomes.
- Guard against toRange or fromRange being null when called
- as part of a clear event.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- 2012-03-08 Yong Li <yoli@rim.com>
- [BlackBerry] Block file-to-file access by default
- https://bugs.webkit.org/show_bug.cgi?id=80605
- Reviewed by Rob Buis.
- Turn off allowFileAccessFromFileURLs() by default.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- 2012-03-08 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Always use the current focused node when processing focus changes
- https://bugs.webkit.org/show_bug.cgi?id=80594
- Reviewed by Antonio Gomes.
- Update InputHandler focused node handling to strictly use
- the currently focused node. This prevents a handling loop
- when JS is modifying the focus and we get a late notification
- of a past change from ChromeClientBlackBerry with the previously
- unfocused node.
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- (WebCore::EditorClientBlackBerry::setInputMethodState):
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- * WebKitSupport/InputHandler.h:
- 2012-03-07 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] WebKit rendering problem when show/hide VKB
- https://bugs.webkit.org/show_bug.cgi?id=80448
- RIM PR: 141727
- Reviewed by Antonio Gomes.
- When setting viewport size, layout happens inside
- WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
- outside of the code path of "needsLayout" so that the contents are
- not rendered into the backing store. This is a regression of r108718,
- switch back to do the layout inside the public API
- WebPage::setDefaultLayoutSize().
- We haven't upstreamed the manual tests directory yet, therefore,
- the new manual test case will be upstreamed later.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
- (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
- 2012-03-06 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Set correct ResourceRequest target type.
- https://bugs.webkit.org/show_bug.cgi?id=80430
- Reviewed by Rob Buis.
- Removed unused code in dispatchWillSendRequest(). These codes are too
- late as the target type has already been referred to when calling
- ResourceRequest::initializePlatformRequest().
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
- 2012-03-06 Lianghui Chen <liachen@rim.com>
- [BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
- https://bugs.webkit.org/show_bug.cgi?id=80438
- Reviewed by Antonio Gomes.
- * Api/WebPageClient.h:
- 2012-03-06 Jakob Petsovits <jpetsovits@rim.com>
- [BlackBerry] Don't suspend accel comp when backgrounding a page.
- https://bugs.webkit.org/show_bug.cgi?id=80369
- RIM PR: 137609
- Reviewed by Adam Treat.
- Just because the page is in the background doesn't mean
- it's invisible, doesn't mean it won't have to be redrawn
- at some point - on rotation, for instance.
- We still suspend accelerated compositing on setVisible(false).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::notifyPageBackground):
- (BlackBerry::WebKit::WebPage::notifyPageForeground):
- 2012-03-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
- https://bugs.webkit.org/show_bug.cgi?id=80377
- Reviewed by Rob Buis.
- As some of the function names changed in class MediaPlayerPrivate
- with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we
- should update WebKit/blackberry/Api/WebPage.cpp which uses these
- functions accordingly.
- Renamed functions in class MediaPlayerPrivate:
- windowGet() -> getWindow()
- windowPositionGet() -> getWindowPosition()
- mmrContextNameGet() -> mmrContextName()
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
- 2012-03-05 Eli Fidler <efidler@rim.com>
- The minimum font size WebSetting should actually change the LOGICAL font size in WebCore.
- https://bugs.webkit.org/show_bug.cgi?id=80312
- RIM PR: 139874
- Reviewed by George Staikos.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 2012-03-05 Jakob Petsovits <jpetsovits@rim.com>
- Make accelerated compositing work again with direct rendering.
- https://bugs.webkit.org/show_bug.cgi?id=80181
- RIM PR: 139110
- Reviewed by Antonio Gomes.
- Internally reviewed by Arvid Nilsson.
- The significant amount of refactoring and optimization work
- that has gone into accelerated compositing missed out on
- some of the code paths that are being used in direct rendering.
- Animations were relying on blitVisibleContents() only (which
- is a no-op in direct rendering mode). There were early returns
- which are suitable to determine whether screen contents need
- to be updated at all; however, when we're already forcing a
- re-render then those checks would cause the composition surface
- not to appear at all, or avoid drawing new animation frames.
- We went through dispatchMessage(), potentially causing
- mismatches between rendered (but not yet posted) back content
- and layers composited on top of it. As we're rendering onto
- the sole target surface (the window) directly and posting
- from the same thread, we have to wait for compositing on the
- UI thread to finish before posting the window.
- In turn, this patch combines both drawSubLayers() and
- blendCompositingSurface() calls into one method, reducing
- the number of messages to the UI thread within
- renderDirectToWindow() to one.
- blendCompositingMessage() in renderDirectToScreen() was called
- with contents coordinates rather than viewport coordinates.
- That caused some of the composited content to be cut off when
- the scroll position wasn't (0, 0).
- We called copyPreviousContentsToBackSurfaceOfWindow() twice for
- one frame, in both renderDirectToWindow() and invalidateWindow().
- Only one of those (the latter one) is necessary.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- * Api/BackingStore.h:
- (WebKit):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
- (BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
- * Api/WebPage_p.h:
- (BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
- (WebPagePrivate):
- * WebKitSupport/WebPageCompositor.cpp:
- (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- (BlackBerry::WebKit::WebPageCompositor::drawLayers):
- (BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
- * WebKitSupport/WebPageCompositor.h:
- (WebPageCompositor):
- 2012-03-05 George Staikos <gstaikos@rim.com>
- [BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
- https://bugs.webkit.org/show_bug.cgi?id=80274
- Reviewed by Antonio Gomes.
- A null range can be returned so we should not blindly deref it.
- Reviewed Internally by Mike Fenton.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):
- 2012-03-04 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- [BlackBerry] upstream CredentialManager and CredentialTransformData implementation
- https://bugs.webkit.org/show_bug.cgi?id=80107
- Reviewed by Antonio Gomes.
- Initial upstream of CredentialManager.[h|cpp] and
- CredentialTransformData.[h|cpp].
- No new test.
- * WebCoreSupport/CredentialManager.cpp: Added.
- (WebCore):
- (WebCore::CredentialManager::CredentialManager):
- (WebCore::CredentialManager::autofillAuthenticationChallenge):
- (WebCore::CredentialManager::autofillPasswordForms):
- (WebCore::CredentialManager::saveCredentialIfConfirmed):
- * WebCoreSupport/CredentialManager.h: Added.
- (WebKit):
- (WebCore):
- (CredentialManager):
- * WebCoreSupport/CredentialTransformData.cpp: Added.
- (WebCore::CredentialTransformData::CredentialTransformData):
- (WebCore):
- (WebCore::CredentialTransformData::url):
- (WebCore::CredentialTransformData::credential):
- (WebCore::CredentialTransformData::setCredential):
- (WebCore::CredentialTransformData::findPasswordFormFields):
- * WebCoreSupport/CredentialTransformData.h: Added.
- (WebCore):
- (CredentialTransformData):
- (WebCore::CredentialTransformData::isValid):
- (WebCore::CredentialTransformData::protectionSpace):
- 2012-03-04 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Fixed positioned element not correctly positioned after orientation change, when viewport metatag is used
- https://bugs.webkit.org/show_bug.cgi?id=80228
- PR #138865
- Reviewed by George Staikos.
- Viewport size changes in two main scenarios:
- - orientation changes;
- - virtual keyboard pop up/hide.
- When we are setting a new viewport size, we need to
- update the FixedReportedSize of the mainframe. This size
- is used to return innerWidth|Heigth as well as to calculate
- the fixed position elements height relative to the RenderView [1].
- [1] RenderBox::containingBlockLogicalHeightForPositioned.
- When we are rotating, we need to delay setting the new FixedReportedSize
- till we layout and are able to figure out the new contents size. At this
- time we call setFixedReportedSize, but we do not reposition the fixed elemts
- afterwards.
- Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
- setting the new size.
- Source/WebKit/blackberry:
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 2012-03-02 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Expose WebInspector state to client and clean up WebSettings
- https://bugs.webkit.org/show_bug.cgi?id=80177
- Reviewed by Antonio Gomes.
- Expose the Web Inspector state to WebPage client's and
- re-order initialization of WebSettings to be alphabetical
- matching their definitions.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
- * Api/WebPage.h:
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::WebSettings::standardSettings):
- 2012-03-02 Arvid Nilsson <anilsson@rim.com>
- Accelerated compositing: Checkerboard never goes away
- https://bugs.webkit.org/show_bug.cgi?id=79020
- RIM PR #134164
- Reviewed by Adam Treat.
- Checkerboard appears in accelerated compositing layers when there's no
- texture for (part of) a layer. The layer renderer queues up some render
- jobs and schedules a commit to make the WebKit thread process those
- jobs. Render jobs performed during commit cause texture upload jobs to
- be scheduled on the UI thread. Texture uploads are performed when next
- drawing the layers.
- Unfortunately, sometimes commit operation happens without a subsequent
- call draw the layers.
- In order to implement one-shot drawing sync, I added a call to
- commitRootLayerIfNeeded() in BackingStore::renderContents(), and
- I was lucky that most of the time, renderContents() is followed by
- blit(Visible)Contents() which in turn draws the layers.
- However, render is not always followed by a blit, for example when
- rendering offscreen tiles in BackingStore::renderOnIdle(), and in
- direct rendering mode.
- Fixed by making sure that every call to commitRootLayerIfNeeded() that
- returns true is followed by a call to drawLayersOnCommit(), unless a
- blit was requested already.
- Also tweak the logic for one-shot drawing sync to make the code in
- drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
- (BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
- (BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
- (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
- (BlackBerry::WebKit::BackingStorePrivate::render):
- (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- (BlackBerry::WebKit::BackingStorePrivate::blitContents):
- (BlackBerry::WebKit::BackingStorePrivate::renderContents):
- (WebKit):
- (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
- * Api/BackingStore_p.h:
- (BackingStorePrivate):
- (BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
- 2012-03-02 Adam Treat <atreat@rim.com>
- https://bugs.webkit.org/show_bug.cgi?id=80161
- PR: 141157
- BlackBerryPlatformScreen.h API has been updated. Reflect those
- changes in our usage.
- Reviewed by Antonio Gomes.
- Internally reviewed by Jakob Petsovits.
- * Api/BackingStore.cpp:
- (BlackBerry::WebKit::BackingStorePrivate::tileWidth):
- (BlackBerry::WebKit::BackingStorePrivate::tileHeight):
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::init):
- (BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
- (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
- (BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- * WebKitSupport/SurfacePool.cpp:
- (BlackBerry::WebKit::createCompositingSurface):
- 2012-03-02 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
- https://bugs.webkit.org/show_bug.cgi?id=80160
- Reviewed by Antonio Gomes.
- Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
- Previously when executing window.devicePixelRatio these two pages returned 1 now
- they report the devicePixelRatio returned by computeViewportAttributes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2012-03-02 Jacky Jiang <zhajiang@rim.com>
- Fix a warning in InputHandler::learnText()
- https://bugs.webkit.org/show_bug.cgi?id=80049
- Reviewed by Antonio Gomes.
- Fix a warning of the comparison "textInField.length() <=
- MaxLearnTextDataSize" in InputHandler::learnText().
- Rubber-stamped internally by Mike Fenton.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::learnText):
- 2012-03-01 Andy Chen <andchen@rim.com>
- [BlackBerry] Implement features for find-in-page
- https://bugs.webkit.org/show_bug.cgi?id=79820
- Reviewed by Antonio Gomes.
- - Make it be able to search text around the whole page instead of single frame.
- - Make it be able to start new search from active selection and last active match.
- No new tests as this patch doesn't change behavior.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
- * Api/WebPage_p.h:
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
- (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::incrementFrame):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InPageSearchManager.cpp:
- (BlackBerry::WebKit::InPageSearchManager::findNextString):
- (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
- (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- (BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
- (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- * WebKitSupport/InPageSearchManager.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::frameUnloaded):
- * WebKitSupport/InputHandler.h:
- 2012-03-01 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Web Notification crashes the browser.
- https://bugs.webkit.org/show_bug.cgi?id=79897
- Reviewed by Antonio Gomes.
- The reason of the crash is that it still uses the iterator
- after been removed from the container, which invalidates the
- iterator.
- We should stop processing after we have found the element
- and removed from the container through the iterator.
- This patch only fixes the crash issue, but not any notification
- functionality issue, which is tracked seperatly.
- Test case: http://sandbox.gtaero.net/chrome/notifications.php
- * WebCoreSupport/NotificationPresenterImpl.cpp:
- (WebKit::NotificationPresenterImpl::onPermission):
- (WebKit::NotificationPresenterImpl::notificationClicked):
- 2012-03-01 Mike Fenton <mifenton@rim.com>
- Autocomplete attribute should apply to textarea's.
- https://bugs.webkit.org/show_bug.cgi?id=79929
- Reviewed by Antonio Gomes.
- Add local static Qualified name for autocorrect attribute.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
- 2012-02-29 Mike Fenton <mifenton@rim.com>
- Autocomplete attribute should apply to textarea's.
- https://bugs.webkit.org/show_bug.cgi?id=79929
- Reviewed by Antonio Gomes.
- Allow the autocomplete attribute to bubble back to the form setting.
- Expand support to include checking autocorrect, autocomplete and
- name/id matching to text areas.
- Reviewed internally by Nima Ghanavatian and Gen Mak.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
- (BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
- (BlackBerry::WebKit::DOMSupport::elementAttributeState):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::inputStyle):
- 2012-02-29 Max Feil <mfeil@rim.com>
- [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
- https://bugs.webkit.org/show_bug.cgi?id=79519
- Reviewed by Antonio Gomes.
- * Api/WebSettings.cpp:
- (BlackBerry::WebKit::mimeTypeAssociationMap):
- 2012-02-28 Konrad Piascik <kpiascik@rim.com>
- [BlackBerry] Change the API to use std::string
- https://bugs.webkit.org/show_bug.cgi?id=79818
- Reviewed by Antonio Gomes.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
- * Api/WebPage.h:
- 2012-02-28 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] x86 build fix after cleaning up WebPage.cpp
- https://bugs.webkit.org/show_bug.cgi?id=79814
- Reviewed by Antonio Gomes.
- x86 build fix, keep WebPage::destroyWebPageCompositor() method where it
- was which was outside of USE(ACCELERATED_COMPOSITING).
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
- (WebKit):
- 2012-02-28 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Remove unused focusedNodeChange notifications from the Chrome client.
- https://bugs.webkit.org/show_bug.cgi?id=79794
- Reviewed by Rob Buis.
- Remove unused notification for focusedNodeChanged.
- Internally reviewed by Gen Mak.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
- 2012-02-27 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Upstream BlackBerry API web page related files
- https://bugs.webkit.org/show_bug.cgi?id=74380
- Reviewed by Antonio Gomes.
- Clean up WebPage.{h, cpp} and WebPage_p.h.
- - Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in
- the public API, adapt to the change by adding a new method
- WebPagePrivate::core(Const WebPage*) and expose it to
- DumpRenderTreeSupport.
- - Rename WebPage::spellCheckingEnabled to
- WebPage::setSpellCheckingEnabled.
- - Remove unused WebPage::focusNodeRect().
- - Remove extra blank lines.
- - Put WebPage methods and their associated WebPagePrivate methods
- together.
- No new tests as this patch doesn't change behavior.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPage::WebPage):
- (WebKit):
- (BlackBerry::WebKit::WebPage::~WebPage):
- (BlackBerry::WebKit::WebPagePrivate::core):
- (BlackBerry::WebKit::WebPage::load):
- (BlackBerry::WebKit::WebPage::loadExtended):
- (BlackBerry::WebKit::WebPage::loadFile):
- (BlackBerry::WebKit::WebPage::download):
- (BlackBerry::WebKit::WebPage::loadString):
- (BlackBerry::WebKit::WebPage::executeJavaScript):
- (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
- (BlackBerry::WebKit::WebPage::stopLoading):
- (BlackBerry::WebKit::WebPage::prepareToDestroy):
- (BlackBerry::WebKit::WebPage::setScrollPosition):
- (BlackBerry::WebKit::WebPage::scrollBy):
- (BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
- (BlackBerry::WebKit::WebPage::zoomToFitScale):
- (BlackBerry::WebKit::WebPage::initialScale):
- (BlackBerry::WebKit::WebPage::maximumScale):
- (BlackBerry::WebKit::WebPage::scrollPosition):
- (BlackBerry::WebKit::WebPage::viewportSize):
- (BlackBerry::WebKit::WebPage::activeNodeContext):
- (BlackBerry::WebKit::WebPage::assignFocus):
- (BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
- (BlackBerry::WebKit::WebPage::onInputLocaleChanged):
- (BlackBerry::WebKit::WebPage::setScreenOrientation):
- (BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
- (BlackBerry::WebKit::WebPage::setViewportSize):
- (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
- (BlackBerry::WebKit::WebPage::setScrollOriginPoint):
- (BlackBerry::WebKit::WebPage::textEncoding):
- (BlackBerry::WebKit::WebPage::forcedTextEncoding):
- (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
- (BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
- (BlackBerry::WebKit::parentLayer):
- (BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
- (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
- * Api/WebPage.h:
- (WebCore):
- (WebKit):
- * Api/WebPage_p.h:
- (WebCore):
- (WebKit):
- * WebKitSupport/DumpRenderTreeSupport.cpp:
- (DumpRenderTreeSupport::corePage):
- (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
- (DumpRenderTreeSupport::resetGeolocationMock):
- (DumpRenderTreeSupport::setMockGeolocationError):
- (DumpRenderTreeSupport::setMockGeolocationPermission):
- (DumpRenderTreeSupport::setMockGeolocationPosition):
- (DumpRenderTreeSupport::scalePageBy):
- * WebKitSupport/DumpRenderTreeSupport.h:
- (WebCore):
- (DumpRenderTreeSupport):
- 2012-02-27 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Selection handling should be entirely directional
- https://bugs.webkit.org/show_bug.cgi?id=79692
- Reviewed by Antonio Gomes.
- Make all VisibleSelections directional.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- 2012-02-27 Ed Baker <edbaker@rim.com>
- [BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
- https://bugs.webkit.org/show_bug.cgi?id=78608
- Ensure that when selection handles leave the content bounding box that
- the handle not being dragged remains fixed. Do not apply padding to a
- direction that would cause the selection to shrink when performing the
- handle direction detection.
- Reviewed by Antonio Gomes.
- * WebKitSupport/DOMSupport.cpp:
- (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
- * WebKitSupport/DOMSupport.h:
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::clamp):
- (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
- (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
- * WebKitSupport/SelectionHandler.h:
- 2012-02-27 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Upstream accelerated compositing helper class
- https://bugs.webkit.org/show_bug.cgi?id=78448
- Reviewed by Antonio Gomes.
- Initial upstream, no new tests.
- * WebKitSupport/FrameLayers.cpp: Added.
- * WebKitSupport/FrameLayers.h: Added.
- 2012-02-26 Hajime Morrita <morrita@chromium.org>
- Move ChromeClient::showContextMenu() to ContextMenuClient
- https://bugs.webkit.org/show_bug.cgi?id=79427
- Reviewed by Adam Barth.
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-02-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
- https://bugs.webkit.org/show_bug.cgi?id=79393
- Reviewed by Antonio Gomes.
- Cleanup usage of BlackBerry::Platform in InputHandler.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::convertStringToWchar):
- (BlackBerry::WebKit::convertStringToWcharVector):
- (BlackBerry::WebKit::convertSpannableStringToString):
- (BlackBerry::WebKit::InputHandler::learnText):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::nodeTextChanged):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::frameUnloaded):
- (BlackBerry::WebKit::InputHandler::selectionChanged):
- (BlackBerry::WebKit::InputHandler::setSelection):
- (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
- (BlackBerry::WebKit::InputHandler::deleteText):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::setComposingRegion):
- (BlackBerry::WebKit::InputHandler::finishComposition):
- (BlackBerry::WebKit::InputHandler::setText):
- (BlackBerry::WebKit::InputHandler::setTextAttributes):
- (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
- (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
- (BlackBerry::WebKit::InputHandler::setComposingText):
- (BlackBerry::WebKit::InputHandler::commitText):
- 2012-02-24 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
- https://bugs.webkit.org/show_bug.cgi?id=79391
- Reviewed by Antonio Gomes.
- Clean up usage of BlackBerry::Platform in SelectionHandler and
- explicitly define what namespace to use for ambiguous objects like
- IntRect and IntPoint.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::cancelSelection):
- (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
- (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- (BlackBerry::WebKit::directionOfPointRelativeToRect):
- (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
- (BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
- (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- (BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
- (BlackBerry::WebKit::SelectionHandler::setSelection):
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- (BlackBerry::WebKit::SelectionHandler::selectObject):
- (BlackBerry::WebKit::comparePointsToReferencePoint):
- (BlackBerry::WebKit::minXMinYCorner):
- (BlackBerry::WebKit::maxXMinYCorner):
- (BlackBerry::WebKit::minXMaxYCorner):
- (BlackBerry::WebKit::maxXMaxYCorner):
- (BlackBerry::WebKit::caretLocationForRect):
- (BlackBerry::WebKit::caretComparisonPointForRect):
- (BlackBerry::WebKit::adjustCaretRects):
- (BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
- (BlackBerry::WebKit::referencePoint):
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- (BlackBerry::WebKit::SelectionHandler::selectionContains):
- 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
- SpellCheckRequest needs to know the context where the spellcheck happened.
- https://bugs.webkit.org/show_bug.cgi?id=79320
- Reviewed by Hajime Morita.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::requestCheckingOfString):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2012-02-24 Charles Wei <charles.wei@torchmobile.com.cn>
- [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
- https://bugs.webkit.org/show_bug.cgi?id=79318
- Need to give the client a chance to decide how to handle the new window request.
- Reviewed by Rob Buis.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- 2012-02-23 Mike Fenton <mifenton@rim.com>
- [BlackBerry] Selection handler has compile failure with logs enabled.
- https://bugs.webkit.org/show_bug.cgi?id=79392
- Reviewed by Antonio Gomes.
- Build Fix. Update log to avoid usage of toString which was removed.
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2012-02-19 Antonio Gomes <agomes@rim.com>
- Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
- https://bugs.webkit.org/show_bug.cgi?id=79256
- PR #127814 / MKS_2587410
- Reviewed by Rob Buis.
- Patch adds a cleaner way for call sites of FatFingersResult to
- query for the appropriated target node: shadow or non-shadow DOM nodes.
- It also renames FatFingersResults::validNode to ::node, assuming
- that "invalid" nodes are not applicable in any context.
- * Api/WebPage.cpp:
- (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
- (BlackBerry::WebKit::WebPagePrivate::contextNode):
- (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- * WebKitSupport/FatFingers.h:
- (FatFingersResult):
- (BlackBerry::WebKit::FatFingersResult::node):
- (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-02-23 Jacky Jiang <zhajiang@rim.com>
- [BlackBerry] Upstream BlackBerry API web page related files
- https://bugs.webkit.org/show_bug.cgi?id=74380
- Reviewed by Antonio Gomes.
- Initial upstream, no new tests.
- * Api/WebPage.cpp: Added.
- * Api/WebPage.h: Added.
- * Api/WebPage_p.h: Added.
- 2012-02-23 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Remove unused ChromeClientBlackBerry::platformCompositingWindow(), platformWindow() and WebPageClient::compositingWindow()
- https://bugs.webkit.org/show_bug.cgi?id=78681
- Reviewed by Antonio Gomes.
- * Api/WebPageClient.h:
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore):
- * WebCoreSupport/ChromeClientBlackBerry.h:
- (ChromeClientBlackBerry):
- 2012-02-23 Leo Yang <leo.yang@torchmobile.com.cn>
- [BlackBerry] Upstream GLES2Context.{h, cpp}
- https://bugs.webkit.org/show_bug.cgi?id=79196
- Reviewed by Rob Buis.
- Initial upstream, no new tests.
- * WebKitSupport/GLES2Context.cpp: Added.
- * WebKitSupport/GLES2Context.h: Added.
- 2012-02-23 Mike Fenton <mifenton@rim.com>
- [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
- https://bugs.webkit.org/show_bug.cgi?id=79366
- Reviewed by Rob Buis.
- Cleanup InputHandler navigation based code.
- 1) Remove the concept of NavigationMode and replace it
- with simple showKeyboard calls.
- 2) Remove navigation move events and replace with standard
- key events.
- 3) Standardize function/variable names and remove obsolete
- functions.
- * Api/WebPageClient.h:
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::nodeFocused):
- (BlackBerry::WebKit::InputHandler::setElementUnfocused):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- (BlackBerry::WebKit::InputHandler::setDelayKeyboardVisibilityChange):
- (BlackBerry::WebKit::InputHandler::processPendingKeyboardVisibilityChange):
- (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- * WebKitSupport/SelectionHandler.cpp:
- (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- * WebKitSupport/TouchEventHandler.cpp:
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
- Remove the remaining uses of CSSStyleDeclaration in Editor
- https://bugs.webkit.org/show_bug.cgi?id=78939
- Reviewed by Enrica Casucci.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldApplyStyle):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2012-02-22 Mike Fenton <mifenton@rim.com>
- [BlackBerry] InputHandler has signed vs unsigned comparison.
- https://bugs.webkit.org/show_bug.cgi?id=79261
- Fix warning by casting the unsigned int to an int.
- Reviewed by Rob Buis.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::rectForCaret):
- 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
- Remove the remaining uses of CSSStyleDeclaration in Editor
- https://bugs.webkit.org/show_bug.cgi?id=78939
- Reviewed by Enrica Casucci.
- * WebCoreSupport/EditorClientBlackBerry.cpp:
- (WebCore::EditorClientBlackBerry::shouldApplyStyle):
- * WebCoreSupport/EditorClientBlackBerry.h:
- (EditorClientBlackBerry):
- 2012-02-18 Antonio Gomes <agomes@rim.com>
- Fat fingers - cache the first rect-based hit test so we do not need to do it again
- https://bugs.webkit.org/show_bug.cgi?id=79115
- Reviewed by Adam Treat.
- Our FatFingers implementation runs currently in two phases:
- the first checks for the elements intrinsically clickable;
- the second checks for elements made clickable by the page
- (for example, a div with a onclick event listener attached to it).
- For each phase, we perform a rect hittest, which is not needed since
- the result of each is the same.
- Patch introduces a caching mechanism so we avoid on rect hittest:
- when the first phase runs, it caches each nodeset per document in
- a hashmap. This second phase works with the cached results.
- No behavioral change, but performance is better since we
- avoid one (possibly expensive) rect hittest.
- I measured the performance gain on https://www.kvd.se/, and we
- save up to 0.04 seconds, by caching and re-using the results.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::dumpHitTestResult):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::cachingStrategy):
- (WebKit):
- (BlackBerry::WebKit::FatFingers::getNodesFromRect):
- * WebKitSupport/FatFingers.h:
- 2012-02-20 Antonio Gomes <agomes@rim.com>
- All default video/audio control elements should be rect-hit testable (Part II)
- PR #139518 / MKS_3005538
- Reviewed by George Staikos.
- Add HTMLInputElement::isMediaControlElement as a criteria
- to consider a element as clickable.
- Note that is should be only used while in the "ClickableByDefault"
- phase of FatFingers.
- * WebKitSupport/FatFingers.cpp:
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- 2012-02-16 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Implemented a way to defer client navigation change client notifications
- https://bugs.webkit.org/show_bug.cgi?id=78848
- Reviewed by Rob Buis.
- Currently we postpone touch_down till touch_up if user touches
- the screen and an input field has the WebKit focus. This is done
- so we can scroll the page without hidding the vkb needlessly.
- However, it breaks the conversion of touch to mouse events
- if an input field has the focus in the following scenario:
- an <input type=text> is focused and an user grab and-drag
- a <input type=range> knob/slide. It does not work until the
- user unfocuses the currently focused edit field.
- Patch introduces a way to unfocus a currently focused input field,
- without requesting the client to show or hide the virtual keyboard
- right way. Instead it gets a delayed notification of the vkb mode requested
- at either touch_released/mouse_up or touch_cancel time.
- For now, due to content side issues with major web sites,
- only delay navigation mode notification changes if we are not dealing with
- input modes.
- * WebKitSupport/InputHandler.cpp:
- (BlackBerry::WebKit::InputHandler::InputHandler):
- (BlackBerry::WebKit::InputHandler::nodeFocused):
- (BlackBerry::WebKit::InputHandler::setElementFocused):
- (BlackBerry::WebKit::InputHandler::setNavigationMode):
- (WebKit):
- (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange):
- (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification):
- (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange):
- (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
- (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- (BlackBerry::WebKit::InputHandler::spannableTextInRange):
- (BlackBerry::WebKit::InputHandler::removeComposedText):
- (BlackBerry::WebKit::InputHandler::firstSpanInString):
- (BlackBerry::WebKit::InputHandler::setText):
- (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
- * WebKitSupport/InputHandler.h:
- (InputHandler):
- 2012-02-16 Antonio Gomes <agomes@rim.com>
- Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
- https://bugs.webkit.org/show_bug.cgi?id=78845
- Reviewed by Rob Buis.
- We were trying to operate on a cached Node when its page/frame/document
- were gone to PageCache already. To avoid such problems, lets clean up
- any document data we have cached when the Frame goes into the cache.
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
- (WebCore):
- * WebCoreSupport/FrameLoaderClientBlackBerry.h:
- (FrameLoaderClientBlackBerry):
- 2012-02-16 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Upstream touch handling related classes
- https://bugs.webkit.org/show_bug.cgi?id=78509
- Reviewed by Adam Treat and Rob Buis.
- FatFingers is the class responsible to the whole touch
- accuracy of the BlackBerry port. Initial upstream.
- * WebKitSupport/FatFingers.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
- (BlackBerry::WebKit::hasMousePressListener):
- (BlackBerry::WebKit::FatFingers::isElementClickable):
- (BlackBerry::WebKit::isFieldWithText):
- (BlackBerry::WebKit::distanceBetweenPoints):
- (BlackBerry::WebKit::compareDistanceBetweenPoints):
- (BlackBerry::WebKit::isValidFrameOwner):
- (BlackBerry::WebKit::FatFingers::FatFingers):
- (BlackBerry::WebKit::FatFingers::~FatFingers):
- (BlackBerry::WebKit::FatFingers::findBestPoint):
- (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
- (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- (BlackBerry::WebKit::FatFingers::checkForClickableElement):
- (BlackBerry::WebKit::FatFingers::checkForText):
- (BlackBerry::WebKit::FatFingers::getPaddings):
- (BlackBerry::WebKit::FatFingers::nodesFromRect):
- (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
- (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
- * WebKitSupport/FatFingers.h: Added.
- (WebCore):
- (WebKit):
- (FatFingersResult):
- (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
- (BlackBerry::WebKit::FatFingersResult::reset):
- (BlackBerry::WebKit::FatFingersResult::originPosition):
- (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
- (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
- (BlackBerry::WebKit::FatFingersResult::isTextInput):
- (BlackBerry::WebKit::FatFingersResult::isValid):
- (BlackBerry::WebKit::FatFingersResult::validNode):
- (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
- (FatFingers):
- 2012-02-16 Antonio Gomes <agomes@rim.com>
- [BlackBerry] Upstream touch handling related classes
- https://bugs.webkit.org/show_bug.cgi?id=78509
- Reviewed by Adam Treat.
- Initial upstream of the Blackberry specific single touch event
- handler class.
- * blackberry/WebKitSupport/TouchEventHandler.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::hasMouseMoveListener):
- (BlackBerry::WebKit::hasTouchListener):
- (BlackBerry::WebKit::elementExpectsMouseEvents):
- (BlackBerry::WebKit::shouldConvertTouchToMouse):
- (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
- (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler):
- (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown):
- [BlackBerry] Upstream touch handling related classes
- https://bugs.webkit.org/show_bug.cgi?id=78509
- Reviewed by Rob Buis.
- InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
- working as a read-only wrapper object for a scrollable areas in the page.
- It is used in our client side to control in-region scrolling (scrollable boxes,
- inner frames, etc).
- Initial upstream.
- * WebKitSupport/InRegionScrollableArea.cpp: Added.
- (WebKit):
- (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition):
- (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition):
- (BlackBerry::WebKit::InRegionScrollableArea::layer):
- (BlackBerry):
- * WebKitSupport/InRegionScrollableArea.h: Added.
- (WebCore):
- (WebKit):
- (InRegionScrollableArea):
- 2012-02-16 Antonio Gomes <agomes@rim.com>
- (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
- (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
- (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- (BlackBerry::WebKit::TouchEventHandler::spellCheck):
- (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- (BlackBerry::WebKit::elementForTapHighlight):
- (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- * blackberry/WebKitSupport/TouchEventHandler.h: Added.
- (WebCore):
- (WebKit):
- (TouchEventHandler):
- (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult):
- (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):
|