ChangeLog-2013-04-24 880 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011601260136014601560166017601860196020602160226023602460256026602760286029603060316032603360346035603660376038603960406041604260436044604560466047604860496050605160526053605460556056605760586059606060616062606360646065606660676068606960706071607260736074607560766077607860796080608160826083608460856086608760886089609060916092609360946095609660976098609961006101610261036104610561066107610861096110611161126113611461156116611761186119612061216122612361246125612661276128612961306131613261336134613561366137613861396140614161426143614461456146614761486149615061516152615361546155615661576158615961606161616261636164616561666167616861696170617161726173617461756176617761786179618061816182618361846185618661876188618961906191619261936194619561966197619861996200620162026203620462056206620762086209621062116212621362146215621662176218621962206221622262236224622562266227622862296230623162326233623462356236623762386239624062416242624362446245624662476248624962506251625262536254625562566257625862596260626162626263626462656266626762686269627062716272627362746275627662776278627962806281628262836284628562866287628862896290629162926293629462956296629762986299630063016302630363046305630663076308630963106311631263136314631563166317631863196320632163226323632463256326632763286329633063316332633363346335633663376338633963406341634263436344634563466347634863496350635163526353635463556356635763586359636063616362636363646365636663676368636963706371637263736374637563766377637863796380638163826383638463856386638763886389639063916392639363946395639663976398639964006401640264036404640564066407640864096410641164126413641464156416641764186419642064216422642364246425642664276428642964306431643264336434643564366437643864396440644164426443644464456446644764486449645064516452645364546455645664576458645964606461646264636464646564666467646864696470647164726473647464756476647764786479648064816482648364846485648664876488648964906491649264936494649564966497649864996500650165026503650465056506650765086509651065116512651365146515651665176518651965206521652265236524652565266527652865296530653165326533653465356536653765386539654065416542654365446545654665476548654965506551655265536554655565566557655865596560656165626563656465656566656765686569657065716572657365746575657665776578657965806581658265836584658565866587658865896590659165926593659465956596659765986599660066016602660366046605660666076608660966106611661266136614661566166617661866196620662166226623662466256626662766286629663066316632663366346635663666376638663966406641664266436644664566466647664866496650665166526653665466556656665766586659666066616662666366646665666666676668666966706671667266736674667566766677667866796680668166826683668466856686668766886689669066916692669366946695669666976698669967006701670267036704670567066707670867096710671167126713671467156716671767186719672067216722672367246725672667276728672967306731673267336734673567366737673867396740674167426743674467456746674767486749675067516752675367546755675667576758675967606761676267636764676567666767676867696770677167726773677467756776677767786779678067816782678367846785678667876788678967906791679267936794679567966797679867996800680168026803680468056806680768086809681068116812681368146815681668176818681968206821682268236824682568266827682868296830683168326833683468356836683768386839684068416842684368446845684668476848684968506851685268536854685568566857685868596860686168626863686468656866686768686869687068716872687368746875687668776878687968806881688268836884688568866887688868896890689168926893689468956896689768986899690069016902690369046905690669076908690969106911691269136914691569166917691869196920692169226923692469256926692769286929693069316932693369346935693669376938693969406941694269436944694569466947694869496950695169526953695469556956695769586959696069616962696369646965696669676968696969706971697269736974697569766977697869796980698169826983698469856986698769886989699069916992699369946995699669976998699970007001700270037004700570067007700870097010701170127013701470157016701770187019702070217022702370247025702670277028702970307031703270337034703570367037703870397040704170427043704470457046704770487049705070517052705370547055705670577058705970607061706270637064706570667067706870697070707170727073707470757076707770787079708070817082708370847085708670877088708970907091709270937094709570967097709870997100710171027103710471057106710771087109711071117112711371147115711671177118711971207121712271237124712571267127712871297130713171327133713471357136713771387139714071417142714371447145714671477148714971507151715271537154715571567157715871597160716171627163716471657166716771687169717071717172717371747175717671777178717971807181718271837184718571867187718871897190719171927193719471957196719771987199720072017202720372047205720672077208720972107211721272137214721572167217721872197220722172227223722472257226722772287229723072317232723372347235723672377238723972407241724272437244724572467247724872497250725172527253725472557256725772587259726072617262726372647265726672677268726972707271727272737274727572767277727872797280728172827283728472857286728772887289729072917292729372947295729672977298729973007301730273037304730573067307730873097310731173127313731473157316731773187319732073217322732373247325732673277328732973307331733273337334733573367337733873397340734173427343734473457346734773487349735073517352735373547355735673577358735973607361736273637364736573667367736873697370737173727373737473757376737773787379738073817382738373847385738673877388738973907391739273937394739573967397739873997400740174027403740474057406740774087409741074117412741374147415741674177418741974207421742274237424742574267427742874297430743174327433743474357436743774387439744074417442744374447445744674477448744974507451745274537454745574567457745874597460746174627463746474657466746774687469747074717472747374747475747674777478747974807481748274837484748574867487748874897490749174927493749474957496749774987499750075017502750375047505750675077508750975107511751275137514751575167517751875197520752175227523752475257526752775287529753075317532753375347535753675377538753975407541754275437544754575467547754875497550755175527553755475557556755775587559756075617562756375647565756675677568756975707571757275737574757575767577757875797580758175827583758475857586758775887589759075917592759375947595759675977598759976007601760276037604760576067607760876097610761176127613761476157616761776187619762076217622762376247625762676277628762976307631763276337634763576367637763876397640764176427643764476457646764776487649765076517652765376547655765676577658765976607661766276637664766576667667766876697670767176727673767476757676767776787679768076817682768376847685768676877688768976907691769276937694769576967697769876997700770177027703770477057706770777087709771077117712771377147715771677177718771977207721772277237724772577267727772877297730773177327733773477357736773777387739774077417742774377447745774677477748774977507751775277537754775577567757775877597760776177627763776477657766776777687769777077717772777377747775777677777778777977807781778277837784778577867787778877897790779177927793779477957796779777987799780078017802780378047805780678077808780978107811781278137814781578167817781878197820782178227823782478257826782778287829783078317832783378347835783678377838783978407841784278437844784578467847784878497850785178527853785478557856785778587859786078617862786378647865786678677868786978707871787278737874787578767877787878797880788178827883788478857886788778887889789078917892789378947895789678977898789979007901790279037904790579067907790879097910791179127913791479157916791779187919792079217922792379247925792679277928792979307931793279337934793579367937793879397940794179427943794479457946794779487949795079517952795379547955795679577958795979607961796279637964796579667967796879697970797179727973797479757976797779787979798079817982798379847985798679877988798979907991799279937994799579967997799879998000800180028003800480058006800780088009801080118012801380148015801680178018801980208021802280238024802580268027802880298030803180328033803480358036803780388039804080418042804380448045804680478048804980508051805280538054805580568057805880598060806180628063806480658066806780688069807080718072807380748075807680778078807980808081808280838084808580868087808880898090809180928093809480958096809780988099810081018102810381048105810681078108810981108111811281138114811581168117811881198120812181228123812481258126812781288129813081318132813381348135813681378138813981408141814281438144814581468147814881498150815181528153815481558156815781588159816081618162816381648165816681678168816981708171817281738174817581768177817881798180818181828183818481858186818781888189819081918192819381948195819681978198819982008201820282038204820582068207820882098210821182128213821482158216821782188219822082218222822382248225822682278228822982308231823282338234823582368237823882398240824182428243824482458246824782488249825082518252825382548255825682578258825982608261826282638264826582668267826882698270827182728273827482758276827782788279828082818282828382848285828682878288828982908291829282938294829582968297829882998300830183028303830483058306830783088309831083118312831383148315831683178318831983208321832283238324832583268327832883298330833183328333833483358336833783388339834083418342834383448345834683478348834983508351835283538354835583568357835883598360836183628363836483658366836783688369837083718372837383748375837683778378837983808381838283838384838583868387838883898390839183928393839483958396839783988399840084018402840384048405840684078408840984108411841284138414841584168417841884198420842184228423842484258426842784288429843084318432843384348435843684378438843984408441844284438444844584468447844884498450845184528453845484558456845784588459846084618462846384648465846684678468846984708471847284738474847584768477847884798480848184828483848484858486848784888489849084918492849384948495849684978498849985008501850285038504850585068507850885098510851185128513851485158516851785188519852085218522852385248525852685278528852985308531853285338534853585368537853885398540854185428543854485458546854785488549855085518552855385548555855685578558855985608561856285638564856585668567856885698570857185728573857485758576857785788579858085818582858385848585858685878588858985908591859285938594859585968597859885998600860186028603860486058606860786088609861086118612861386148615861686178618861986208621862286238624862586268627862886298630863186328633863486358636863786388639864086418642864386448645864686478648864986508651865286538654865586568657865886598660866186628663866486658666866786688669867086718672867386748675867686778678867986808681868286838684868586868687868886898690869186928693869486958696869786988699870087018702870387048705870687078708870987108711871287138714871587168717871887198720872187228723872487258726872787288729873087318732873387348735873687378738873987408741874287438744874587468747874887498750875187528753875487558756875787588759876087618762876387648765876687678768876987708771877287738774877587768777877887798780878187828783878487858786878787888789879087918792879387948795879687978798879988008801880288038804880588068807880888098810881188128813881488158816881788188819882088218822882388248825882688278828882988308831883288338834883588368837883888398840884188428843884488458846884788488849885088518852885388548855885688578858885988608861886288638864886588668867886888698870887188728873887488758876887788788879888088818882888388848885888688878888888988908891889288938894889588968897889888998900890189028903890489058906890789088909891089118912891389148915891689178918891989208921892289238924892589268927892889298930893189328933893489358936893789388939894089418942894389448945894689478948894989508951895289538954895589568957895889598960896189628963896489658966896789688969897089718972897389748975897689778978897989808981898289838984898589868987898889898990899189928993899489958996899789988999900090019002900390049005900690079008900990109011901290139014901590169017901890199020902190229023902490259026902790289029903090319032903390349035903690379038903990409041904290439044904590469047904890499050905190529053905490559056905790589059906090619062906390649065906690679068906990709071907290739074907590769077907890799080908190829083908490859086908790889089909090919092909390949095909690979098909991009101910291039104910591069107910891099110911191129113911491159116911791189119912091219122912391249125912691279128912991309131913291339134913591369137913891399140914191429143914491459146914791489149915091519152915391549155915691579158915991609161916291639164916591669167916891699170917191729173917491759176917791789179918091819182918391849185918691879188918991909191919291939194919591969197919891999200920192029203920492059206920792089209921092119212921392149215921692179218921992209221922292239224922592269227922892299230923192329233923492359236923792389239924092419242924392449245924692479248924992509251925292539254925592569257925892599260926192629263926492659266926792689269927092719272927392749275927692779278927992809281928292839284928592869287928892899290929192929293929492959296929792989299930093019302930393049305930693079308930993109311931293139314931593169317931893199320932193229323932493259326932793289329933093319332933393349335933693379338933993409341934293439344934593469347934893499350935193529353935493559356935793589359936093619362936393649365936693679368936993709371937293739374937593769377937893799380938193829383938493859386938793889389939093919392939393949395939693979398939994009401940294039404940594069407940894099410941194129413941494159416941794189419942094219422942394249425942694279428942994309431943294339434943594369437943894399440944194429443944494459446944794489449945094519452945394549455945694579458945994609461946294639464946594669467946894699470947194729473947494759476947794789479948094819482948394849485948694879488948994909491949294939494949594969497949894999500950195029503950495059506950795089509951095119512951395149515951695179518951995209521952295239524952595269527952895299530953195329533953495359536953795389539954095419542954395449545954695479548954995509551955295539554955595569557955895599560956195629563956495659566956795689569957095719572957395749575957695779578957995809581958295839584958595869587958895899590959195929593959495959596959795989599960096019602960396049605960696079608960996109611961296139614961596169617961896199620962196229623962496259626962796289629963096319632963396349635963696379638963996409641964296439644964596469647964896499650965196529653965496559656965796589659966096619662966396649665966696679668966996709671967296739674967596769677967896799680968196829683968496859686968796889689969096919692969396949695969696979698969997009701970297039704970597069707970897099710971197129713971497159716971797189719972097219722972397249725972697279728972997309731973297339734973597369737973897399740974197429743974497459746974797489749975097519752975397549755975697579758975997609761976297639764976597669767976897699770977197729773977497759776977797789779978097819782978397849785978697879788978997909791979297939794979597969797979897999800980198029803980498059806980798089809981098119812981398149815981698179818981998209821982298239824982598269827982898299830983198329833983498359836983798389839984098419842984398449845984698479848984998509851985298539854985598569857985898599860986198629863986498659866986798689869987098719872987398749875987698779878987998809881988298839884988598869887988898899890989198929893989498959896989798989899990099019902990399049905990699079908990999109911991299139914991599169917991899199920992199229923992499259926992799289929993099319932993399349935993699379938993999409941994299439944994599469947994899499950995199529953995499559956995799589959996099619962996399649965996699679968996999709971997299739974997599769977997899799980998199829983998499859986998799889989999099919992999399949995999699979998999910000100011000210003100041000510006100071000810009100101001110012100131001410015100161001710018100191002010021100221002310024100251002610027100281002910030100311003210033100341003510036100371003810039100401004110042100431004410045100461004710048100491005010051100521005310054100551005610057100581005910060100611006210063100641006510066100671006810069100701007110072100731007410075100761007710078100791008010081100821008310084100851008610087100881008910090100911009210093100941009510096100971009810099101001010110102101031010410105101061010710108101091011010111101121011310114101151011610117101181011910120101211012210123101241012510126101271012810129101301013110132101331013410135101361013710138101391014010141101421014310144101451014610147101481014910150101511015210153101541015510156101571015810159101601016110162101631016410165101661016710168101691017010171101721017310174101751017610177101781017910180101811018210183101841018510186101871018810189101901019110192101931019410195101961019710198101991020010201102021020310204102051020610207102081020910210102111021210213102141021510216102171021810219102201022110222102231022410225102261022710228102291023010231102321023310234102351023610237102381023910240102411024210243102441024510246102471024810249102501025110252102531025410255102561025710258102591026010261102621026310264102651026610267102681026910270102711027210273102741027510276102771027810279102801028110282102831028410285102861028710288102891029010291102921029310294102951029610297102981029910300103011030210303103041030510306103071030810309103101031110312103131031410315103161031710318103191032010321103221032310324103251032610327103281032910330103311033210333103341033510336103371033810339103401034110342103431034410345103461034710348103491035010351103521035310354103551035610357103581035910360103611036210363103641036510366103671036810369103701037110372103731037410375103761037710378103791038010381103821038310384103851038610387103881038910390103911039210393103941039510396103971039810399104001040110402104031040410405104061040710408104091041010411104121041310414104151041610417104181041910420104211042210423104241042510426104271042810429104301043110432104331043410435104361043710438104391044010441104421044310444104451044610447104481044910450104511045210453104541045510456104571045810459104601046110462104631046410465104661046710468104691047010471104721047310474104751047610477104781047910480104811048210483104841048510486104871048810489104901049110492104931049410495104961049710498104991050010501105021050310504105051050610507105081050910510105111051210513105141051510516105171051810519105201052110522105231052410525105261052710528105291053010531105321053310534105351053610537105381053910540105411054210543105441054510546105471054810549105501055110552105531055410555105561055710558105591056010561105621056310564105651056610567105681056910570105711057210573105741057510576105771057810579105801058110582105831058410585105861058710588105891059010591105921059310594105951059610597105981059910600106011060210603106041060510606106071060810609106101061110612106131061410615106161061710618106191062010621106221062310624106251062610627106281062910630106311063210633106341063510636106371063810639106401064110642106431064410645106461064710648106491065010651106521065310654106551065610657106581065910660106611066210663106641066510666106671066810669106701067110672106731067410675106761067710678106791068010681106821068310684106851068610687106881068910690106911069210693106941069510696106971069810699107001070110702107031070410705107061070710708107091071010711107121071310714107151071610717107181071910720107211072210723107241072510726107271072810729107301073110732107331073410735107361073710738107391074010741107421074310744107451074610747107481074910750107511075210753107541075510756107571075810759107601076110762107631076410765107661076710768107691077010771107721077310774107751077610777107781077910780107811078210783107841078510786107871078810789107901079110792107931079410795107961079710798107991080010801108021080310804108051080610807108081080910810108111081210813108141081510816108171081810819108201082110822108231082410825108261082710828108291083010831108321083310834108351083610837108381083910840108411084210843108441084510846108471084810849108501085110852108531085410855108561085710858108591086010861108621086310864108651086610867108681086910870108711087210873108741087510876108771087810879108801088110882108831088410885108861088710888108891089010891108921089310894108951089610897108981089910900109011090210903109041090510906109071090810909109101091110912109131091410915109161091710918109191092010921109221092310924109251092610927109281092910930109311093210933109341093510936109371093810939109401094110942109431094410945109461094710948109491095010951109521095310954109551095610957109581095910960109611096210963109641096510966109671096810969109701097110972109731097410975109761097710978109791098010981109821098310984109851098610987109881098910990109911099210993109941099510996109971099810999110001100111002110031100411005110061100711008110091101011011110121101311014110151101611017110181101911020110211102211023110241102511026110271102811029110301103111032110331103411035110361103711038110391104011041110421104311044110451104611047110481104911050110511105211053110541105511056110571105811059110601106111062110631106411065110661106711068110691107011071110721107311074110751107611077110781107911080110811108211083110841108511086110871108811089110901109111092110931109411095110961109711098110991110011101111021110311104111051110611107111081110911110111111111211113111141111511116111171111811119111201112111122111231112411125111261112711128111291113011131111321113311134111351113611137111381113911140111411114211143111441114511146111471114811149111501115111152111531115411155111561115711158111591116011161111621116311164111651116611167111681116911170111711117211173111741117511176111771117811179111801118111182111831118411185111861118711188111891119011191111921119311194111951119611197111981119911200112011120211203112041120511206112071120811209112101121111212112131121411215112161121711218112191122011221112221122311224112251122611227112281122911230112311123211233112341123511236112371123811239112401124111242112431124411245112461124711248112491125011251112521125311254112551125611257112581125911260112611126211263112641126511266112671126811269112701127111272112731127411275112761127711278112791128011281112821128311284112851128611287112881128911290112911129211293112941129511296112971129811299113001130111302113031130411305113061130711308113091131011311113121131311314113151131611317113181131911320113211132211323113241132511326113271132811329113301133111332113331133411335113361133711338113391134011341113421134311344113451134611347113481134911350113511135211353113541135511356113571135811359113601136111362113631136411365113661136711368113691137011371113721137311374113751137611377113781137911380113811138211383113841138511386113871138811389113901139111392113931139411395113961139711398113991140011401114021140311404114051140611407114081140911410114111141211413114141141511416114171141811419114201142111422114231142411425114261142711428114291143011431114321143311434114351143611437114381143911440114411144211443114441144511446114471144811449114501145111452114531145411455114561145711458114591146011461114621146311464114651146611467114681146911470114711147211473114741147511476114771147811479114801148111482114831148411485114861148711488114891149011491114921149311494114951149611497114981149911500115011150211503115041150511506115071150811509115101151111512115131151411515115161151711518115191152011521115221152311524115251152611527115281152911530115311153211533115341153511536115371153811539115401154111542115431154411545115461154711548115491155011551115521155311554115551155611557115581155911560115611156211563115641156511566115671156811569115701157111572115731157411575115761157711578115791158011581115821158311584115851158611587115881158911590115911159211593115941159511596115971159811599116001160111602116031160411605116061160711608116091161011611116121161311614116151161611617116181161911620116211162211623116241162511626116271162811629116301163111632116331163411635116361163711638116391164011641116421164311644116451164611647116481164911650116511165211653116541165511656116571165811659116601166111662116631166411665116661166711668116691167011671116721167311674116751167611677116781167911680116811168211683116841168511686116871168811689116901169111692116931169411695116961169711698116991170011701117021170311704117051170611707117081170911710117111171211713117141171511716117171171811719117201172111722117231172411725117261172711728117291173011731117321173311734117351173611737117381173911740117411174211743117441174511746117471174811749117501175111752117531175411755117561175711758117591176011761117621176311764117651176611767117681176911770117711177211773117741177511776117771177811779117801178111782117831178411785117861178711788117891179011791117921179311794117951179611797117981179911800118011180211803118041180511806118071180811809118101181111812118131181411815118161181711818118191182011821118221182311824118251182611827118281182911830118311183211833118341183511836118371183811839118401184111842118431184411845118461184711848118491185011851118521185311854118551185611857118581185911860118611186211863118641186511866118671186811869118701187111872118731187411875118761187711878118791188011881118821188311884118851188611887118881188911890118911189211893118941189511896118971189811899119001190111902119031190411905119061190711908119091191011911119121191311914119151191611917119181191911920119211192211923119241192511926119271192811929119301193111932119331193411935119361193711938119391194011941119421194311944119451194611947119481194911950119511195211953119541195511956119571195811959119601196111962119631196411965119661196711968119691197011971119721197311974119751197611977119781197911980119811198211983119841198511986119871198811989119901199111992119931199411995119961199711998119991200012001120021200312004120051200612007120081200912010120111201212013120141201512016120171201812019120201202112022120231202412025120261202712028120291203012031120321203312034120351203612037120381203912040120411204212043120441204512046120471204812049120501205112052120531205412055120561205712058120591206012061120621206312064120651206612067120681206912070120711207212073120741207512076120771207812079120801208112082120831208412085120861208712088120891209012091120921209312094120951209612097120981209912100121011210212103121041210512106121071210812109121101211112112121131211412115121161211712118121191212012121121221212312124121251212612127121281212912130121311213212133121341213512136121371213812139121401214112142121431214412145121461214712148121491215012151121521215312154121551215612157121581215912160121611216212163121641216512166121671216812169121701217112172121731217412175121761217712178121791218012181121821218312184121851218612187121881218912190121911219212193121941219512196121971219812199122001220112202122031220412205122061220712208122091221012211122121221312214122151221612217122181221912220122211222212223122241222512226122271222812229122301223112232122331223412235122361223712238122391224012241122421224312244122451224612247122481224912250122511225212253122541225512256122571225812259122601226112262122631226412265122661226712268122691227012271122721227312274122751227612277122781227912280122811228212283122841228512286122871228812289122901229112292122931229412295122961229712298122991230012301123021230312304123051230612307123081230912310123111231212313123141231512316123171231812319123201232112322123231232412325123261232712328123291233012331123321233312334123351233612337123381233912340123411234212343123441234512346123471234812349123501235112352123531235412355123561235712358123591236012361123621236312364123651236612367123681236912370123711237212373123741237512376123771237812379123801238112382123831238412385123861238712388123891239012391123921239312394123951239612397123981239912400124011240212403124041240512406124071240812409124101241112412124131241412415124161241712418124191242012421124221242312424124251242612427124281242912430124311243212433124341243512436124371243812439124401244112442124431244412445124461244712448124491245012451124521245312454124551245612457124581245912460124611246212463124641246512466124671246812469124701247112472124731247412475124761247712478124791248012481124821248312484124851248612487124881248912490124911249212493124941249512496124971249812499125001250112502125031250412505125061250712508125091251012511125121251312514125151251612517125181251912520125211252212523125241252512526125271252812529125301253112532125331253412535125361253712538125391254012541125421254312544125451254612547125481254912550125511255212553125541255512556125571255812559125601256112562125631256412565125661256712568125691257012571125721257312574125751257612577125781257912580125811258212583125841258512586125871258812589125901259112592125931259412595125961259712598125991260012601126021260312604126051260612607126081260912610126111261212613126141261512616126171261812619126201262112622126231262412625126261262712628126291263012631126321263312634126351263612637126381263912640126411264212643126441264512646126471264812649126501265112652126531265412655126561265712658126591266012661126621266312664126651266612667126681266912670126711267212673126741267512676126771267812679126801268112682126831268412685126861268712688126891269012691126921269312694126951269612697126981269912700127011270212703127041270512706127071270812709127101271112712127131271412715127161271712718127191272012721127221272312724127251272612727127281272912730127311273212733127341273512736127371273812739127401274112742127431274412745127461274712748127491275012751127521275312754127551275612757127581275912760127611276212763127641276512766127671276812769127701277112772127731277412775127761277712778127791278012781127821278312784127851278612787127881278912790127911279212793127941279512796127971279812799128001280112802128031280412805128061280712808128091281012811128121281312814128151281612817128181281912820128211282212823128241282512826128271282812829128301283112832128331283412835128361283712838128391284012841128421284312844128451284612847128481284912850128511285212853128541285512856128571285812859128601286112862128631286412865128661286712868128691287012871128721287312874128751287612877128781287912880128811288212883128841288512886128871288812889128901289112892128931289412895128961289712898128991290012901129021290312904129051290612907129081290912910129111291212913129141291512916129171291812919129201292112922129231292412925129261292712928129291293012931129321293312934129351293612937129381293912940129411294212943129441294512946129471294812949129501295112952129531295412955129561295712958129591296012961129621296312964129651296612967129681296912970129711297212973129741297512976129771297812979129801298112982129831298412985129861298712988129891299012991129921299312994129951299612997129981299913000130011300213003130041300513006130071300813009130101301113012130131301413015130161301713018130191302013021130221302313024130251302613027130281302913030130311303213033130341303513036130371303813039130401304113042130431304413045130461304713048130491305013051130521305313054130551305613057130581305913060130611306213063130641306513066130671306813069130701307113072130731307413075130761307713078130791308013081130821308313084130851308613087130881308913090130911309213093130941309513096130971309813099131001310113102131031310413105131061310713108131091311013111131121311313114131151311613117131181311913120131211312213123131241312513126131271312813129131301313113132131331313413135131361313713138131391314013141131421314313144131451314613147131481314913150131511315213153131541315513156131571315813159131601316113162131631316413165131661316713168131691317013171131721317313174131751317613177131781317913180131811318213183131841318513186131871318813189131901319113192131931319413195131961319713198131991320013201132021320313204132051320613207132081320913210132111321213213132141321513216132171321813219132201322113222132231322413225132261322713228132291323013231132321323313234132351323613237132381323913240132411324213243132441324513246132471324813249132501325113252132531325413255132561325713258132591326013261132621326313264132651326613267132681326913270132711327213273132741327513276132771327813279132801328113282132831328413285132861328713288132891329013291132921329313294132951329613297132981329913300133011330213303133041330513306133071330813309133101331113312133131331413315133161331713318133191332013321133221332313324133251332613327133281332913330133311333213333133341333513336133371333813339133401334113342133431334413345133461334713348133491335013351133521335313354133551335613357133581335913360133611336213363133641336513366133671336813369133701337113372133731337413375133761337713378133791338013381133821338313384133851338613387133881338913390133911339213393133941339513396133971339813399134001340113402134031340413405134061340713408134091341013411134121341313414134151341613417134181341913420134211342213423134241342513426134271342813429134301343113432134331343413435134361343713438134391344013441134421344313444134451344613447134481344913450134511345213453134541345513456134571345813459134601346113462134631346413465134661346713468134691347013471134721347313474134751347613477134781347913480134811348213483134841348513486134871348813489134901349113492134931349413495134961349713498134991350013501135021350313504135051350613507135081350913510135111351213513135141351513516135171351813519135201352113522135231352413525135261352713528135291353013531135321353313534135351353613537135381353913540135411354213543135441354513546135471354813549135501355113552135531355413555135561355713558135591356013561135621356313564135651356613567135681356913570135711357213573135741357513576135771357813579135801358113582135831358413585135861358713588135891359013591135921359313594135951359613597135981359913600136011360213603136041360513606136071360813609136101361113612136131361413615136161361713618136191362013621136221362313624136251362613627136281362913630136311363213633136341363513636136371363813639136401364113642136431364413645136461364713648136491365013651136521365313654136551365613657136581365913660136611366213663136641366513666136671366813669136701367113672136731367413675136761367713678136791368013681136821368313684136851368613687136881368913690136911369213693136941369513696136971369813699137001370113702137031370413705137061370713708137091371013711137121371313714137151371613717137181371913720137211372213723137241372513726137271372813729137301373113732137331373413735137361373713738137391374013741137421374313744137451374613747137481374913750137511375213753137541375513756137571375813759137601376113762137631376413765137661376713768137691377013771137721377313774137751377613777137781377913780137811378213783137841378513786137871378813789137901379113792137931379413795137961379713798137991380013801138021380313804138051380613807138081380913810138111381213813138141381513816138171381813819138201382113822138231382413825138261382713828138291383013831138321383313834138351383613837138381383913840138411384213843138441384513846138471384813849138501385113852138531385413855138561385713858138591386013861138621386313864138651386613867138681386913870138711387213873138741387513876138771387813879138801388113882138831388413885138861388713888138891389013891138921389313894138951389613897138981389913900139011390213903139041390513906139071390813909139101391113912139131391413915139161391713918139191392013921139221392313924139251392613927139281392913930139311393213933139341393513936139371393813939139401394113942139431394413945139461394713948139491395013951139521395313954139551395613957139581395913960139611396213963139641396513966139671396813969139701397113972139731397413975139761397713978139791398013981139821398313984139851398613987139881398913990139911399213993139941399513996139971399813999140001400114002140031400414005140061400714008140091401014011140121401314014140151401614017140181401914020140211402214023140241402514026140271402814029140301403114032140331403414035140361403714038140391404014041140421404314044140451404614047140481404914050140511405214053140541405514056140571405814059140601406114062140631406414065140661406714068140691407014071140721407314074140751407614077140781407914080140811408214083140841408514086140871408814089140901409114092140931409414095140961409714098140991410014101141021410314104141051410614107141081410914110141111411214113141141411514116141171411814119141201412114122141231412414125141261412714128141291413014131141321413314134141351413614137141381413914140141411414214143141441414514146141471414814149141501415114152141531415414155141561415714158141591416014161141621416314164141651416614167141681416914170141711417214173141741417514176141771417814179141801418114182141831418414185141861418714188141891419014191141921419314194141951419614197141981419914200142011420214203142041420514206142071420814209142101421114212142131421414215142161421714218142191422014221142221422314224142251422614227142281422914230142311423214233142341423514236142371423814239142401424114242142431424414245142461424714248142491425014251142521425314254142551425614257142581425914260142611426214263142641426514266142671426814269142701427114272142731427414275142761427714278142791428014281142821428314284142851428614287142881428914290142911429214293142941429514296142971429814299143001430114302143031430414305143061430714308143091431014311143121431314314143151431614317143181431914320143211432214323143241432514326143271432814329143301433114332143331433414335143361433714338143391434014341143421434314344143451434614347143481434914350143511435214353143541435514356143571435814359143601436114362143631436414365143661436714368143691437014371143721437314374143751437614377143781437914380143811438214383143841438514386143871438814389143901439114392143931439414395143961439714398143991440014401144021440314404144051440614407144081440914410144111441214413144141441514416144171441814419144201442114422144231442414425144261442714428144291443014431144321443314434144351443614437144381443914440144411444214443144441444514446144471444814449144501445114452144531445414455144561445714458144591446014461144621446314464144651446614467144681446914470144711447214473144741447514476144771447814479144801448114482144831448414485144861448714488144891449014491144921449314494144951449614497144981449914500145011450214503145041450514506145071450814509145101451114512145131451414515145161451714518145191452014521145221452314524145251452614527145281452914530145311453214533145341453514536145371453814539145401454114542145431454414545145461454714548145491455014551145521455314554145551455614557145581455914560145611456214563145641456514566145671456814569145701457114572145731457414575145761457714578145791458014581145821458314584145851458614587145881458914590145911459214593145941459514596145971459814599146001460114602146031460414605146061460714608146091461014611146121461314614146151461614617146181461914620146211462214623146241462514626146271462814629146301463114632146331463414635146361463714638146391464014641146421464314644146451464614647146481464914650146511465214653146541465514656146571465814659146601466114662146631466414665146661466714668146691467014671146721467314674146751467614677146781467914680146811468214683146841468514686146871468814689146901469114692146931469414695146961469714698146991470014701147021470314704147051470614707147081470914710147111471214713147141471514716147171471814719147201472114722147231472414725147261472714728147291473014731147321473314734147351473614737147381473914740147411474214743147441474514746147471474814749147501475114752147531475414755147561475714758147591476014761147621476314764147651476614767147681476914770147711477214773147741477514776147771477814779147801478114782147831478414785147861478714788147891479014791147921479314794147951479614797147981479914800148011480214803148041480514806148071480814809148101481114812148131481414815148161481714818148191482014821148221482314824148251482614827148281482914830148311483214833148341483514836148371483814839148401484114842148431484414845148461484714848148491485014851148521485314854148551485614857148581485914860148611486214863148641486514866148671486814869148701487114872148731487414875148761487714878148791488014881148821488314884148851488614887148881488914890148911489214893148941489514896148971489814899149001490114902149031490414905149061490714908149091491014911149121491314914149151491614917149181491914920149211492214923149241492514926149271492814929149301493114932149331493414935149361493714938149391494014941149421494314944149451494614947149481494914950149511495214953149541495514956149571495814959149601496114962149631496414965149661496714968149691497014971149721497314974149751497614977149781497914980149811498214983149841498514986149871498814989149901499114992149931499414995149961499714998149991500015001150021500315004150051500615007150081500915010150111501215013150141501515016150171501815019150201502115022150231502415025150261502715028150291503015031150321503315034150351503615037150381503915040150411504215043150441504515046150471504815049150501505115052150531505415055150561505715058150591506015061150621506315064150651506615067150681506915070150711507215073150741507515076150771507815079150801508115082150831508415085150861508715088150891509015091150921509315094150951509615097150981509915100151011510215103151041510515106151071510815109151101511115112151131511415115151161511715118151191512015121151221512315124151251512615127151281512915130151311513215133151341513515136151371513815139151401514115142151431514415145151461514715148151491515015151151521515315154151551515615157151581515915160151611516215163151641516515166151671516815169151701517115172151731517415175151761517715178151791518015181151821518315184151851518615187151881518915190151911519215193151941519515196151971519815199152001520115202152031520415205152061520715208152091521015211152121521315214152151521615217152181521915220152211522215223152241522515226152271522815229152301523115232152331523415235152361523715238152391524015241152421524315244152451524615247152481524915250152511525215253152541525515256152571525815259152601526115262152631526415265152661526715268152691527015271152721527315274152751527615277152781527915280152811528215283152841528515286152871528815289152901529115292152931529415295152961529715298152991530015301153021530315304153051530615307153081530915310153111531215313153141531515316153171531815319153201532115322153231532415325153261532715328153291533015331153321533315334153351533615337153381533915340153411534215343153441534515346153471534815349153501535115352153531535415355153561535715358153591536015361153621536315364153651536615367153681536915370153711537215373153741537515376153771537815379153801538115382153831538415385153861538715388153891539015391153921539315394153951539615397153981539915400154011540215403154041540515406154071540815409154101541115412154131541415415154161541715418154191542015421154221542315424154251542615427154281542915430154311543215433154341543515436154371543815439154401544115442154431544415445154461544715448154491545015451154521545315454154551545615457154581545915460154611546215463154641546515466154671546815469154701547115472154731547415475154761547715478154791548015481154821548315484154851548615487154881548915490154911549215493154941549515496154971549815499155001550115502155031550415505155061550715508155091551015511155121551315514155151551615517155181551915520155211552215523155241552515526155271552815529155301553115532155331553415535155361553715538155391554015541155421554315544155451554615547155481554915550155511555215553155541555515556155571555815559155601556115562155631556415565155661556715568155691557015571155721557315574155751557615577155781557915580155811558215583155841558515586155871558815589155901559115592155931559415595155961559715598155991560015601156021560315604156051560615607156081560915610156111561215613156141561515616156171561815619156201562115622156231562415625156261562715628156291563015631156321563315634156351563615637156381563915640156411564215643156441564515646156471564815649156501565115652156531565415655156561565715658156591566015661156621566315664156651566615667156681566915670156711567215673156741567515676156771567815679156801568115682156831568415685156861568715688156891569015691156921569315694156951569615697156981569915700157011570215703157041570515706157071570815709157101571115712157131571415715157161571715718157191572015721157221572315724157251572615727157281572915730157311573215733157341573515736157371573815739157401574115742157431574415745157461574715748157491575015751157521575315754157551575615757157581575915760157611576215763157641576515766157671576815769157701577115772157731577415775157761577715778157791578015781157821578315784157851578615787157881578915790157911579215793157941579515796157971579815799158001580115802158031580415805158061580715808158091581015811158121581315814158151581615817158181581915820158211582215823158241582515826158271582815829158301583115832158331583415835158361583715838158391584015841158421584315844158451584615847158481584915850158511585215853158541585515856158571585815859158601586115862158631586415865158661586715868158691587015871158721587315874158751587615877158781587915880158811588215883158841588515886158871588815889158901589115892158931589415895158961589715898158991590015901159021590315904159051590615907159081590915910159111591215913159141591515916159171591815919159201592115922159231592415925159261592715928159291593015931159321593315934159351593615937159381593915940159411594215943159441594515946159471594815949159501595115952159531595415955159561595715958159591596015961159621596315964159651596615967159681596915970159711597215973159741597515976159771597815979159801598115982159831598415985159861598715988159891599015991159921599315994159951599615997159981599916000160011600216003160041600516006160071600816009160101601116012160131601416015160161601716018160191602016021160221602316024160251602616027160281602916030160311603216033160341603516036160371603816039160401604116042160431604416045160461604716048160491605016051160521605316054160551605616057160581605916060160611606216063160641606516066160671606816069160701607116072160731607416075160761607716078160791608016081160821608316084160851608616087160881608916090160911609216093160941609516096160971609816099161001610116102161031610416105161061610716108161091611016111161121611316114161151611616117161181611916120161211612216123161241612516126161271612816129161301613116132161331613416135161361613716138161391614016141161421614316144161451614616147161481614916150161511615216153161541615516156161571615816159161601616116162161631616416165161661616716168161691617016171161721617316174161751617616177161781617916180161811618216183161841618516186161871618816189161901619116192161931619416195161961619716198161991620016201162021620316204162051620616207162081620916210162111621216213162141621516216162171621816219162201622116222162231622416225162261622716228162291623016231162321623316234162351623616237162381623916240162411624216243162441624516246162471624816249162501625116252162531625416255162561625716258162591626016261162621626316264162651626616267162681626916270162711627216273162741627516276162771627816279162801628116282162831628416285162861628716288162891629016291162921629316294162951629616297162981629916300163011630216303163041630516306163071630816309163101631116312163131631416315163161631716318163191632016321163221632316324163251632616327163281632916330163311633216333163341633516336163371633816339163401634116342163431634416345163461634716348163491635016351163521635316354163551635616357163581635916360163611636216363163641636516366163671636816369163701637116372163731637416375163761637716378163791638016381163821638316384163851638616387163881638916390163911639216393163941639516396163971639816399164001640116402164031640416405164061640716408164091641016411164121641316414164151641616417164181641916420164211642216423164241642516426164271642816429164301643116432164331643416435164361643716438164391644016441164421644316444164451644616447164481644916450164511645216453164541645516456164571645816459164601646116462164631646416465164661646716468164691647016471164721647316474164751647616477164781647916480164811648216483164841648516486164871648816489164901649116492164931649416495164961649716498164991650016501165021650316504165051650616507165081650916510165111651216513165141651516516165171651816519165201652116522165231652416525165261652716528165291653016531165321653316534165351653616537165381653916540165411654216543165441654516546165471654816549165501655116552165531655416555165561655716558165591656016561165621656316564165651656616567165681656916570165711657216573165741657516576165771657816579165801658116582165831658416585165861658716588165891659016591165921659316594165951659616597165981659916600166011660216603166041660516606166071660816609166101661116612166131661416615166161661716618166191662016621166221662316624166251662616627166281662916630166311663216633166341663516636166371663816639166401664116642166431664416645166461664716648166491665016651166521665316654166551665616657166581665916660166611666216663166641666516666166671666816669166701667116672166731667416675166761667716678166791668016681166821668316684166851668616687166881668916690166911669216693166941669516696166971669816699167001670116702167031670416705167061670716708167091671016711167121671316714167151671616717167181671916720167211672216723167241672516726167271672816729167301673116732167331673416735167361673716738167391674016741167421674316744167451674616747167481674916750167511675216753167541675516756167571675816759167601676116762167631676416765167661676716768167691677016771167721677316774167751677616777167781677916780167811678216783167841678516786167871678816789167901679116792167931679416795167961679716798167991680016801168021680316804168051680616807168081680916810168111681216813168141681516816168171681816819168201682116822168231682416825168261682716828168291683016831168321683316834168351683616837168381683916840168411684216843168441684516846168471684816849168501685116852168531685416855168561685716858168591686016861168621686316864168651686616867168681686916870168711687216873168741687516876168771687816879168801688116882168831688416885168861688716888168891689016891168921689316894168951689616897168981689916900169011690216903169041690516906169071690816909169101691116912169131691416915169161691716918169191692016921169221692316924169251692616927169281692916930169311693216933169341693516936169371693816939169401694116942169431694416945169461694716948169491695016951169521695316954169551695616957169581695916960169611696216963169641696516966169671696816969169701697116972169731697416975169761697716978169791698016981169821698316984169851698616987169881698916990169911699216993169941699516996169971699816999170001700117002170031700417005170061700717008170091701017011170121701317014170151701617017170181701917020170211702217023170241702517026170271702817029170301703117032170331703417035170361703717038170391704017041170421704317044170451704617047170481704917050170511705217053170541705517056170571705817059170601706117062170631706417065170661706717068170691707017071170721707317074170751707617077170781707917080170811708217083170841708517086170871708817089170901709117092170931709417095170961709717098170991710017101171021710317104171051710617107171081710917110171111711217113171141711517116171171711817119171201712117122171231712417125171261712717128171291713017131171321713317134171351713617137171381713917140171411714217143171441714517146171471714817149171501715117152171531715417155171561715717158171591716017161171621716317164171651716617167171681716917170171711717217173171741717517176171771717817179171801718117182171831718417185171861718717188171891719017191171921719317194171951719617197171981719917200172011720217203172041720517206172071720817209172101721117212172131721417215172161721717218172191722017221172221722317224172251722617227172281722917230172311723217233172341723517236172371723817239172401724117242172431724417245172461724717248172491725017251172521725317254172551725617257172581725917260172611726217263172641726517266172671726817269172701727117272172731727417275172761727717278172791728017281172821728317284172851728617287172881728917290172911729217293172941729517296172971729817299173001730117302173031730417305173061730717308173091731017311173121731317314173151731617317173181731917320173211732217323173241732517326173271732817329173301733117332173331733417335173361733717338173391734017341173421734317344173451734617347173481734917350173511735217353173541735517356173571735817359173601736117362173631736417365173661736717368173691737017371173721737317374173751737617377173781737917380173811738217383173841738517386173871738817389173901739117392173931739417395173961739717398173991740017401174021740317404174051740617407174081740917410174111741217413174141741517416174171741817419174201742117422174231742417425174261742717428174291743017431174321743317434174351743617437174381743917440174411744217443174441744517446174471744817449174501745117452174531745417455174561745717458174591746017461174621746317464174651746617467174681746917470174711747217473174741747517476174771747817479174801748117482174831748417485174861748717488174891749017491174921749317494174951749617497174981749917500175011750217503175041750517506175071750817509175101751117512175131751417515175161751717518175191752017521175221752317524175251752617527175281752917530175311753217533175341753517536175371753817539175401754117542175431754417545175461754717548175491755017551175521755317554175551755617557175581755917560175611756217563175641756517566175671756817569175701757117572175731757417575175761757717578175791758017581175821758317584175851758617587175881758917590175911759217593175941759517596175971759817599176001760117602176031760417605176061760717608176091761017611176121761317614176151761617617176181761917620176211762217623176241762517626176271762817629176301763117632176331763417635176361763717638176391764017641176421764317644176451764617647176481764917650176511765217653176541765517656176571765817659176601766117662176631766417665176661766717668176691767017671176721767317674176751767617677176781767917680176811768217683176841768517686176871768817689176901769117692176931769417695176961769717698176991770017701177021770317704177051770617707177081770917710177111771217713177141771517716177171771817719177201772117722177231772417725177261772717728177291773017731177321773317734177351773617737177381773917740177411774217743177441774517746177471774817749177501775117752177531775417755177561775717758177591776017761177621776317764177651776617767177681776917770177711777217773177741777517776177771777817779177801778117782177831778417785177861778717788177891779017791177921779317794177951779617797177981779917800178011780217803178041780517806178071780817809178101781117812178131781417815178161781717818178191782017821178221782317824178251782617827178281782917830178311783217833178341783517836178371783817839178401784117842178431784417845178461784717848178491785017851178521785317854178551785617857178581785917860178611786217863178641786517866178671786817869178701787117872178731787417875178761787717878178791788017881178821788317884178851788617887178881788917890178911789217893178941789517896178971789817899179001790117902179031790417905179061790717908179091791017911179121791317914179151791617917179181791917920179211792217923179241792517926179271792817929179301793117932179331793417935179361793717938179391794017941179421794317944179451794617947179481794917950179511795217953179541795517956179571795817959179601796117962179631796417965179661796717968179691797017971179721797317974179751797617977179781797917980179811798217983179841798517986179871798817989179901799117992179931799417995179961799717998179991800018001180021800318004180051800618007180081800918010180111801218013180141801518016180171801818019180201802118022180231802418025180261802718028180291803018031180321803318034180351803618037180381803918040180411804218043180441804518046180471804818049180501805118052180531805418055180561805718058180591806018061180621806318064180651806618067180681806918070180711807218073180741807518076180771807818079180801808118082180831808418085180861808718088180891809018091180921809318094180951809618097180981809918100181011810218103181041810518106181071810818109181101811118112181131811418115181161811718118181191812018121181221812318124181251812618127181281812918130181311813218133181341813518136181371813818139181401814118142181431814418145181461814718148181491815018151181521815318154181551815618157181581815918160181611816218163181641816518166181671816818169181701817118172181731817418175181761817718178181791818018181181821818318184181851818618187181881818918190181911819218193181941819518196181971819818199182001820118202182031820418205182061820718208182091821018211182121821318214182151821618217182181821918220182211822218223182241822518226182271822818229182301823118232182331823418235182361823718238182391824018241182421824318244182451824618247182481824918250182511825218253182541825518256182571825818259182601826118262182631826418265182661826718268182691827018271182721827318274182751827618277182781827918280182811828218283182841828518286182871828818289182901829118292182931829418295182961829718298182991830018301183021830318304183051830618307183081830918310183111831218313183141831518316183171831818319183201832118322183231832418325183261832718328183291833018331183321833318334183351833618337183381833918340183411834218343183441834518346183471834818349183501835118352183531835418355183561835718358183591836018361183621836318364183651836618367183681836918370183711837218373183741837518376183771837818379183801838118382183831838418385183861838718388183891839018391183921839318394183951839618397183981839918400184011840218403184041840518406184071840818409184101841118412184131841418415184161841718418184191842018421184221842318424184251842618427184281842918430184311843218433184341843518436184371843818439184401844118442184431844418445184461844718448184491845018451184521845318454184551845618457184581845918460184611846218463184641846518466184671846818469184701847118472184731847418475184761847718478184791848018481184821848318484184851848618487184881848918490184911849218493184941849518496184971849818499185001850118502185031850418505185061850718508185091851018511185121851318514185151851618517185181851918520185211852218523185241852518526185271852818529185301853118532185331853418535185361853718538185391854018541185421854318544185451854618547185481854918550185511855218553185541855518556185571855818559185601856118562185631856418565185661856718568185691857018571185721857318574185751857618577185781857918580185811858218583185841858518586185871858818589185901859118592185931859418595185961859718598185991860018601186021860318604186051860618607186081860918610186111861218613186141861518616186171861818619186201862118622186231862418625186261862718628186291863018631186321863318634186351863618637186381863918640186411864218643186441864518646186471864818649186501865118652186531865418655186561865718658186591866018661186621866318664186651866618667186681866918670186711867218673186741867518676186771867818679186801868118682186831868418685186861868718688186891869018691186921869318694186951869618697186981869918700187011870218703187041870518706187071870818709187101871118712187131871418715187161871718718187191872018721187221872318724187251872618727187281872918730187311873218733187341873518736187371873818739187401874118742187431874418745187461874718748187491875018751187521875318754187551875618757187581875918760187611876218763187641876518766187671876818769187701877118772187731877418775187761877718778187791878018781187821878318784187851878618787187881878918790187911879218793187941879518796187971879818799188001880118802188031880418805188061880718808188091881018811188121881318814188151881618817188181881918820188211882218823188241882518826188271882818829188301883118832188331883418835188361883718838188391884018841188421884318844188451884618847188481884918850188511885218853188541885518856188571885818859188601886118862188631886418865188661886718868188691887018871188721887318874188751887618877188781887918880188811888218883188841888518886188871888818889188901889118892188931889418895188961889718898188991890018901189021890318904189051890618907189081890918910189111891218913189141891518916189171891818919189201892118922189231892418925189261892718928189291893018931189321893318934189351893618937189381893918940189411894218943189441894518946189471894818949189501895118952189531895418955189561895718958189591896018961189621896318964189651896618967189681896918970189711897218973189741897518976189771897818979189801898118982189831898418985189861898718988189891899018991189921899318994189951899618997189981899919000190011900219003190041900519006190071900819009190101901119012190131901419015190161901719018190191902019021190221902319024190251902619027190281902919030190311903219033190341903519036190371903819039190401904119042190431904419045190461904719048190491905019051190521905319054190551905619057190581905919060190611906219063190641906519066190671906819069190701907119072190731907419075190761907719078190791908019081190821908319084190851908619087190881908919090190911909219093190941909519096190971909819099191001910119102191031910419105191061910719108191091911019111191121911319114191151911619117191181911919120191211912219123191241912519126191271912819129191301913119132191331913419135191361913719138191391914019141191421914319144191451914619147191481914919150191511915219153191541915519156191571915819159191601916119162191631916419165191661916719168191691917019171191721917319174191751917619177191781917919180191811918219183191841918519186191871918819189191901919119192191931919419195191961919719198191991920019201192021920319204192051920619207192081920919210192111921219213192141921519216192171921819219192201922119222192231922419225192261922719228192291923019231192321923319234192351923619237192381923919240192411924219243192441924519246192471924819249192501925119252192531925419255192561925719258192591926019261192621926319264192651926619267192681926919270192711927219273192741927519276192771927819279192801928119282192831928419285192861928719288192891929019291192921929319294192951929619297192981929919300193011930219303193041930519306193071930819309193101931119312193131931419315193161931719318193191932019321193221932319324193251932619327193281932919330193311933219333193341933519336193371933819339193401934119342193431934419345193461934719348193491935019351193521935319354193551935619357193581935919360193611936219363193641936519366193671936819369193701937119372193731937419375193761937719378193791938019381193821938319384193851938619387193881938919390193911939219393193941939519396193971939819399194001940119402194031940419405194061940719408194091941019411194121941319414194151941619417194181941919420194211942219423194241942519426194271942819429194301943119432194331943419435194361943719438194391944019441194421944319444194451944619447194481944919450194511945219453194541945519456194571945819459194601946119462194631946419465194661946719468194691947019471194721947319474194751947619477194781947919480194811948219483194841948519486194871948819489194901949119492194931949419495194961949719498194991950019501195021950319504195051950619507195081950919510195111951219513195141951519516195171951819519195201952119522195231952419525195261952719528195291953019531195321953319534195351953619537195381953919540195411954219543195441954519546195471954819549195501955119552195531955419555195561955719558195591956019561195621956319564195651956619567195681956919570195711957219573195741957519576195771957819579195801958119582195831958419585195861958719588195891959019591195921959319594195951959619597195981959919600196011960219603196041960519606196071960819609196101961119612196131961419615196161961719618196191962019621196221962319624196251962619627196281962919630196311963219633196341963519636196371963819639196401964119642196431964419645196461964719648196491965019651196521965319654196551965619657196581965919660196611966219663196641966519666196671966819669196701967119672196731967419675196761967719678196791968019681196821968319684196851968619687196881968919690196911969219693196941969519696196971969819699197001970119702197031970419705197061970719708197091971019711197121971319714197151971619717197181971919720197211972219723197241972519726197271972819729197301973119732197331973419735197361973719738197391974019741197421974319744197451974619747197481974919750197511975219753197541975519756197571975819759197601976119762197631976419765197661976719768197691977019771197721977319774197751977619777197781977919780197811978219783197841978519786197871978819789197901979119792197931979419795197961979719798197991980019801198021980319804198051980619807198081980919810198111981219813198141981519816198171981819819198201982119822198231982419825198261982719828198291983019831198321983319834198351983619837198381983919840198411984219843198441984519846198471984819849198501985119852198531985419855198561985719858198591986019861198621986319864198651986619867198681986919870198711987219873198741987519876198771987819879198801988119882198831988419885198861988719888198891989019891198921989319894198951989619897198981989919900199011990219903199041990519906199071990819909199101991119912199131991419915199161991719918199191992019921199221992319924199251992619927199281992919930199311993219933199341993519936199371993819939199401994119942199431994419945199461994719948199491995019951199521995319954199551995619957199581995919960199611996219963199641996519966199671996819969199701997119972199731997419975199761997719978199791998019981199821998319984199851998619987199881998919990199911999219993199941999519996199971999819999200002000120002200032000420005200062000720008200092001020011200122001320014200152001620017200182001920020200212002220023200242002520026200272002820029200302003120032200332003420035200362003720038200392004020041200422004320044200452004620047200482004920050200512005220053200542005520056200572005820059200602006120062200632006420065200662006720068200692007020071200722007320074200752007620077200782007920080200812008220083200842008520086200872008820089200902009120092200932009420095200962009720098200992010020101201022010320104201052010620107201082010920110201112011220113201142011520116201172011820119201202012120122201232012420125201262012720128201292013020131201322013320134201352013620137201382013920140201412014220143201442014520146201472014820149201502015120152201532015420155201562015720158201592016020161201622016320164201652016620167201682016920170201712017220173201742017520176201772017820179201802018120182201832018420185201862018720188201892019020191201922019320194201952019620197201982019920200202012020220203202042020520206202072020820209202102021120212202132021420215202162021720218202192022020221202222022320224202252022620227202282022920230202312023220233202342023520236202372023820239202402024120242202432024420245202462024720248202492025020251202522025320254202552025620257202582025920260202612026220263202642026520266202672026820269202702027120272202732027420275202762027720278202792028020281202822028320284202852028620287202882028920290202912029220293202942029520296202972029820299203002030120302203032030420305203062030720308203092031020311203122031320314203152031620317203182031920320203212032220323203242032520326203272032820329203302033120332203332033420335203362033720338203392034020341203422034320344203452034620347203482034920350203512035220353203542035520356203572035820359203602036120362203632036420365203662036720368203692037020371203722037320374203752037620377203782037920380203812038220383203842038520386203872038820389203902039120392203932039420395203962039720398203992040020401204022040320404204052040620407204082040920410204112041220413204142041520416204172041820419204202042120422204232042420425204262042720428204292043020431204322043320434204352043620437204382043920440204412044220443204442044520446204472044820449204502045120452204532045420455204562045720458204592046020461204622046320464204652046620467204682046920470204712047220473204742047520476204772047820479204802048120482204832048420485204862048720488204892049020491204922049320494204952049620497204982049920500205012050220503205042050520506205072050820509205102051120512205132051420515205162051720518205192052020521205222052320524205252052620527205282052920530205312053220533205342053520536205372053820539205402054120542205432054420545205462054720548205492055020551205522055320554205552055620557205582055920560205612056220563205642056520566205672056820569205702057120572205732057420575205762057720578205792058020581205822058320584205852058620587205882058920590205912059220593205942059520596205972059820599206002060120602206032060420605206062060720608206092061020611206122061320614206152061620617206182061920620206212062220623206242062520626206272062820629206302063120632206332063420635206362063720638206392064020641206422064320644206452064620647206482064920650206512065220653206542065520656206572065820659206602066120662206632066420665206662066720668206692067020671206722067320674206752067620677206782067920680206812068220683206842068520686206872068820689206902069120692206932069420695206962069720698206992070020701207022070320704207052070620707207082070920710207112071220713207142071520716207172071820719207202072120722207232072420725207262072720728207292073020731207322073320734207352073620737207382073920740207412074220743207442074520746207472074820749207502075120752207532075420755207562075720758207592076020761207622076320764207652076620767207682076920770207712077220773207742077520776207772077820779207802078120782207832078420785207862078720788207892079020791207922079320794207952079620797207982079920800208012080220803208042080520806208072080820809208102081120812208132081420815208162081720818208192082020821208222082320824208252082620827208282082920830208312083220833208342083520836208372083820839208402084120842208432084420845208462084720848208492085020851208522085320854208552085620857208582085920860208612086220863208642086520866208672086820869208702087120872208732087420875208762087720878208792088020881208822088320884208852088620887208882088920890208912089220893208942089520896208972089820899209002090120902209032090420905209062090720908209092091020911209122091320914209152091620917209182091920920209212092220923209242092520926209272092820929209302093120932209332093420935209362093720938209392094020941209422094320944209452094620947209482094920950209512095220953209542095520956209572095820959209602096120962209632096420965209662096720968209692097020971209722097320974209752097620977209782097920980209812098220983209842098520986209872098820989209902099120992209932099420995209962099720998209992100021001210022100321004210052100621007210082100921010210112101221013210142101521016210172101821019210202102121022210232102421025210262102721028210292103021031210322103321034210352103621037210382103921040210412104221043210442104521046210472104821049210502105121052210532105421055210562105721058210592106021061210622106321064210652106621067210682106921070210712107221073210742107521076210772107821079210802108121082210832108421085210862108721088210892109021091210922109321094210952109621097210982109921100211012110221103211042110521106211072110821109211102111121112211132111421115211162111721118211192112021121211222112321124211252112621127211282112921130211312113221133211342113521136211372113821139211402114121142211432114421145211462114721148211492115021151211522115321154211552115621157211582115921160211612116221163211642116521166211672116821169211702117121172211732117421175211762117721178211792118021181211822118321184211852118621187211882118921190211912119221193211942119521196211972119821199212002120121202212032120421205212062120721208212092121021211212122121321214212152121621217212182121921220212212122221223212242122521226212272122821229212302123121232212332123421235212362123721238212392124021241212422124321244212452124621247212482124921250212512125221253212542125521256212572125821259212602126121262212632126421265212662126721268212692127021271212722127321274212752127621277212782127921280212812128221283212842128521286212872128821289212902129121292212932129421295212962129721298212992130021301213022130321304213052130621307213082130921310213112131221313213142131521316213172131821319213202132121322213232132421325213262132721328213292133021331213322133321334213352133621337213382133921340213412134221343213442134521346213472134821349213502135121352213532135421355213562135721358213592136021361213622136321364213652136621367213682136921370213712137221373213742137521376213772137821379213802138121382213832138421385213862138721388213892139021391213922139321394213952139621397213982139921400214012140221403214042140521406214072140821409214102141121412214132141421415214162141721418214192142021421214222142321424214252142621427214282142921430214312143221433214342143521436214372143821439214402144121442214432144421445214462144721448214492145021451214522145321454214552145621457214582145921460214612146221463214642146521466214672146821469214702147121472214732147421475214762147721478214792148021481214822148321484214852148621487214882148921490214912149221493214942149521496214972149821499215002150121502215032150421505215062150721508215092151021511215122151321514215152151621517215182151921520215212152221523215242152521526215272152821529215302153121532215332153421535215362153721538215392154021541215422154321544215452154621547215482154921550215512155221553215542155521556215572155821559215602156121562215632156421565215662156721568215692157021571215722157321574215752157621577215782157921580215812158221583215842158521586215872158821589215902159121592215932159421595215962159721598215992160021601216022160321604216052160621607216082160921610216112161221613216142161521616216172161821619216202162121622216232162421625216262162721628216292163021631216322163321634216352163621637216382163921640216412164221643216442164521646216472164821649216502165121652216532165421655216562165721658216592166021661216622166321664216652166621667216682166921670216712167221673216742167521676216772167821679216802168121682216832168421685216862168721688216892169021691216922169321694216952169621697216982169921700217012170221703217042170521706217072170821709217102171121712217132171421715217162171721718217192172021721217222172321724217252172621727217282172921730217312173221733217342173521736217372173821739217402174121742217432174421745217462174721748217492175021751217522175321754217552175621757217582175921760217612176221763217642176521766217672176821769217702177121772217732177421775217762177721778217792178021781217822178321784217852178621787217882178921790217912179221793217942179521796217972179821799218002180121802218032180421805218062180721808218092181021811218122181321814218152181621817218182181921820218212182221823218242182521826218272182821829218302183121832218332183421835218362183721838218392184021841218422184321844218452184621847218482184921850218512185221853218542185521856218572185821859218602186121862218632186421865218662186721868218692187021871218722187321874218752187621877218782187921880218812188221883218842188521886218872188821889218902189121892218932189421895218962189721898218992190021901219022190321904219052190621907219082190921910219112191221913219142191521916219172191821919219202192121922219232192421925219262192721928219292193021931219322193321934219352193621937219382193921940219412194221943219442194521946219472194821949219502195121952219532195421955219562195721958219592196021961219622196321964219652196621967219682196921970219712197221973219742197521976219772197821979219802198121982219832198421985219862198721988219892199021991219922199321994219952199621997219982199922000220012200222003220042200522006220072200822009220102201122012220132201422015220162201722018220192202022021220222202322024220252202622027220282202922030220312203222033220342203522036220372203822039220402204122042220432204422045220462204722048220492205022051220522205322054220552205622057220582205922060220612206222063220642206522066220672206822069220702207122072220732207422075220762207722078220792208022081220822208322084220852208622087220882208922090220912209222093220942209522096220972209822099221002210122102221032210422105221062210722108221092211022111221122211322114221152211622117221182211922120221212212222123221242212522126221272212822129221302213122132221332213422135221362213722138221392214022141221422214322144221452214622147221482214922150221512215222153221542215522156221572215822159221602216122162221632216422165221662216722168221692217022171221722217322174221752217622177221782217922180221812218222183221842218522186221872218822189221902219122192221932219422195221962219722198221992220022201222022220322204222052220622207222082220922210222112221222213222142221522216222172221822219222202222122222222232222422225222262222722228222292223022231222322223322234222352223622237222382223922240222412224222243222442224522246222472224822249222502225122252222532225422255222562225722258222592226022261222622226322264222652226622267222682226922270222712227222273222742227522276222772227822279222802228122282222832228422285222862228722288222892229022291222922229322294222952229622297222982229922300
  1. 2013-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
  2. [BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
  3. https://bugs.webkit.org/show_bug.cgi?id=114952
  4. Reviewed by Rob Buis.
  5. Do not assume that Batch requests are only created whe input field
  6. is focused, the Editor can also create Batch requests when pasting
  7. a selection.
  8. * WebKitSupport/InputHandler.cpp:
  9. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  10. Remove invalid assert.
  11. 2013-04-23 Xan Lopez <xlopez@igalia.com>
  12. [BlackBerry] Simplify BackForwardListBlackBerry::clear
  13. https://bugs.webkit.org/show_bug.cgi?id=115029
  14. Reviewed by Carlos Garcia Campos.
  15. Simplify the implementation of the clear method. Instead of asking
  16. the WebCore implementation to search each item and delete it, set
  17. the capacity of the list to zero directly, which will do the same
  18. thing but more efficiently.
  19. No change in behavior, no new tests.
  20. * WebCoreSupport/BackForwardListBlackBerry.cpp:
  21. (WebCore::BackForwardListBlackBerry::clear):
  22. 2013-04-23 Xan Lopez <xlopez@igalia.com>
  23. [BlackBerry] Do not access BackForwardListImpl from DRT
  24. https://bugs.webkit.org/show_bug.cgi?id=115041
  25. Reviewed by Carlos Garcia Campos.
  26. Export the necessary functionality in our BackForwardList port
  27. client in order for DRT to work.
  28. * WebCoreSupport/BackForwardListBlackBerry.cpp:
  29. (WebCore::BackForwardListBlackBerry::backListWithLimit):
  30. (WebCore):
  31. (WebCore::BackForwardListBlackBerry::forwardListWithLimit):
  32. (WebCore::BackForwardListBlackBerry::capacity):
  33. * WebCoreSupport/BackForwardListBlackBerry.h:
  34. (BackForwardListBlackBerry):
  35. 2013-04-23 Charles Wei <charles.wei@torchmobile.com.cn>
  36. [BlackBerry] Need to send out change event for date/color picker
  37. https://bugs.webkit.org/show_bug.cgi?id=114942
  38. Reviewed by Carlos Garcia Campos.
  39. We need to instruct the FormControlElements to send out 'change' event
  40. when the user makes the selection and closes the PagePopup for date/color.
  41. * WebCoreSupport/ColorPickerClient.cpp:
  42. (WebCore::ColorPickerClient::setValueAndClosePopup):
  43. * WebCoreSupport/DatePickerClient.cpp:
  44. (WebCore::DatePickerClient::setValueAndClosePopup):
  45. 2013-04-22 Eli Fidler <efidler@blackberry.com>
  46. [BlackBerry] Update about:config lists
  47. https://bugs.webkit.org/show_bug.cgi?id=114967
  48. Reviewed by Rob Buis.
  49. * WebCoreSupport/AboutDataEnableFeatures.in:
  50. * WebCoreSupport/AboutDataHaveFeatures.in:
  51. * WebCoreSupport/AboutDataUseFeatures.in:
  52. 2013-04-22 Otto Derek Cheung <otcheung@rim.com>
  53. [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
  54. https://bugs.webkit.org/show_bug.cgi?id=114892
  55. Reviewed by Rob Buis.
  56. PR 328147
  57. Modify the client so we only have one listener for battery change events.
  58. The dispatch of different event listeners are handled by BatteryController.
  59. * WebCoreSupport/BatteryClientBlackBerry.cpp:
  60. (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
  61. (WebCore::BatteryClientBlackBerry::startUpdating):
  62. (WebCore::BatteryClientBlackBerry::stopUpdating):
  63. (WebCore::BatteryClientBlackBerry::onStatusChange):
  64. * WebCoreSupport/BatteryClientBlackBerry.h:
  65. (BatteryClientBlackBerry):
  66. 2013-04-22 Xuefei Ren <xren@blackberry.com>
  67. fix build warning(unused parameter)
  68. https://bugs.webkit.org/show_bug.cgi?id=114855
  69. Reviewed by Rob Buis.
  70. remove warning(unused parameter) in
  71. Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
  72. * WebKitSupport/InputHandler.cpp:
  73. (BlackBerry::WebKit::InputHandler::extractedTextRequest):
  74. 2013-04-22 Xan Lopez <xlopez@igalia.com>
  75. [BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
  76. https://bugs.webkit.org/show_bug.cgi?id=114741
  77. Reviewed by George Staikos.
  78. Consider the case where a ResourceHandle won't have a FilterStream
  79. object associated (for example, Blob objects) instead of ASSERTing
  80. pointlessly when asking our network layer for such an object.
  81. This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
  82. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  83. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  84. 2013-04-22 Mike Fenton <mifenton@rim.com>
  85. [BlackBerry] Add additional datalist support.
  86. https://bugs.webkit.org/show_bug.cgi?id=114883
  87. Reviewed by Rob Buis.
  88. PR 210083.
  89. Properly set state when opening a Date/Time popup and simplify
  90. the logic for showing datalist options.
  91. Internally Reviewed by Otto Cheung.
  92. * WebKitSupport/InputHandler.cpp:
  93. (BlackBerry::WebKit::InputHandler::openDatePopup):
  94. (BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
  95. 2013-04-19 Andy Chen <andchen@blackberry.com>
  96. [BlackBerry] Find-on-page should do the scoping again when highlight policy changed
  97. https://bugs.webkit.org/show_bug.cgi?id=114885
  98. Reviewed by Rob Buis.
  99. PR 195773
  100. Internally reviewed by Mike Fenton.
  101. For find on page, we need to treat it as a new search if highlightAllMatches
  102. changes but the text is not changed.
  103. * WebKitSupport/InPageSearchManager.cpp:
  104. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  105. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  106. 2013-04-19 Xuefei Ren <xren@blackberry.com>
  107. fixed debug broken from previous patch
  108. https://bugs.webkit.org/show_bug.cgi?id=114844
  109. Reviewed by Rob Buis.
  110. * WebKitSupport/RenderQueue.cpp:
  111. (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
  112. Add the parameter outstandingJobs which is used in ASSERT(),it was
  113. removed in the r148677 by misstake.now I need to fix it.
  114. 2013-04-19 Alberto Garcia <agarcia@igalia.com>
  115. [BlackBerry] EditorClientBlackBerry: Fix parameter name
  116. https://bugs.webkit.org/show_bug.cgi?id=114856
  117. Reviewed by Carlos Garcia Campos.
  118. Build fix due to a typo in a parameter name.
  119. * WebCoreSupport/EditorClientBlackBerry.cpp:
  120. (WebCore::EditorClientBlackBerry::requestCheckingOfString):
  121. 2013-04-18 Nima Ghanavatian <nghanavatian@blackberry.com>
  122. [BlackBerry] Invalidate spell checking requests in platform code
  123. https://bugs.webkit.org/show_bug.cgi?id=114830
  124. Reviewed by Rob Buis.
  125. Internally reviewed by Mike Fenton.
  126. Cache the value of the last requested sequence id at focus change.
  127. All requests prior to this point will be rejected upon processing.
  128. * WebKitSupport/InputHandler.cpp:
  129. (BlackBerry::WebKit::InputHandler::InputHandler):
  130. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  131. (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
  132. * WebKitSupport/InputHandler.h:
  133. (InputHandler):
  134. 2013-04-17 Geoffrey Garen <ggaren@apple.com>
  135. Renamed JSGlobalData to VM
  136. https://bugs.webkit.org/show_bug.cgi?id=114777
  137. Reviewed by Phil Pizlo.
  138. * Api/BlackBerryGlobal.cpp:
  139. (BlackBerry::WebKit::clearMemoryCaches):
  140. * WebKitSupport/AboutData.cpp:
  141. * WebKitSupport/DumpRenderTreeSupport.cpp:
  142. (DumpRenderTreeSupport::javaScriptObjectsCount):
  143. 2013-04-18 Ed Baker <edbaker@blackberry.com>
  144. [BlackBerry] Should pass through an actual error code when calling notifyLoadFinished
  145. https://bugs.webkit.org/show_bug.cgi?id=114815
  146. Reviewed by Rob Buis.
  147. PR #318079
  148. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  149. (WebCore::FrameLoaderClientBlackBerry::postProgressFinishedNotification):
  150. 2013-04-18 Xuefei Ren <xren@blackberry.com>
  151. remove build warning(unused parameter)
  152. https://bugs.webkit.org/show_bug.cgi?id=114670
  153. Reviewed by Rob Buis.
  154. remove builde warning (unused parameter) in
  155. Source/WebKit/blackberry
  156. * WebKitSupport/InputHandler.cpp:
  157. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  158. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  159. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  160. * WebKitSupport/RenderQueue.cpp:
  161. (BlackBerry::WebKit::RenderQueue::backingStoreRectChanging):
  162. (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
  163. * WebKitSupport/SurfacePool.cpp:
  164. (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
  165. (BlackBerry::WebKit::SurfacePool::waitForBuffer):
  166. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  167. (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
  168. 2013-04-18 Xuefei Ren <xren@blackberry.com>
  169. remove build warning(unused parameter)
  170. https://bugs.webkit.org/show_bug.cgi?id=114670
  171. Reviewed by Rob Buis.
  172. remove build warning in Source/WebKit/blackberry/Api
  173. * Api/BackingStore.cpp:
  174. (BlackBerry::WebKit::BackingStorePrivate::scroll):
  175. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  176. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  177. (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
  178. (BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
  179. * Api/BlackBerryGlobal.cpp:
  180. (BlackBerry::WebKit::clearAppCache):
  181. (BlackBerry::WebKit::clearDatabase):
  182. * Api/WebOverlay.cpp:
  183. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
  184. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
  185. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
  186. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
  187. * Api/WebPage.cpp:
  188. (BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
  189. * Api/WebPageCompositor.cpp:
  190. (BlackBerry::WebKit::WebPageCompositor::cleanup):
  191. 2013-04-18 Xuefei Ren <xren@blackberry.com>
  192. removei build warning (unused parameter )
  193. https://bugs.webkit.org/show_bug.cgi?id=114670
  194. Reviewed by Rob Buis.
  195. remove warning (unused parameter ) in
  196. Source/WebKit/blackberry/WebCoreSupport
  197. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  198. (WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
  199. (WebCore::ChromeClientBlackBerry::needTouchEvents):
  200. (WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
  201. * WebCoreSupport/DatePickerClient.cpp:
  202. (WebCore::DatePickerClient::setValue):
  203. * WebCoreSupport/EditorClientBlackBerry.cpp:
  204. (WebCore::EditorClientBlackBerry::checkSpellingOfString):
  205. (WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
  206. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  207. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
  208. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
  209. (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
  210. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  211. (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
  212. * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
  213. (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
  214. (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
  215. * WebCoreSupport/SelectPopupClient.cpp:
  216. (WebCore::SelectPopupClient::generateHTML):
  217. * WebCoreSupport/UserMediaClientImpl.cpp:
  218. (WebCore::UserMediaClientImpl::requestUserMedia):
  219. 2013-04-17 Nima Ghanavatian <nghanavatian@blackberry.com>
  220. Clean up spellcheck state when changing focus.
  221. https://bugs.webkit.org/show_bug.cgi?id=114758
  222. Reviewed by Rob Buis.
  223. Internally reviewed by Mike Fenton and Gen Mak.
  224. PR325941
  225. If we lose focus while waiting for a spellcheck request to return, we will
  226. never see the reply and continue to queue up future requests. By clearing
  227. the queue we ensure that all requests being processed and waiting to fire
  228. are valid.
  229. * WebKitSupport/InputHandler.cpp:
  230. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  231. * WebKitSupport/SpellingHandler.cpp:
  232. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  233. 2013-04-17 Tiancheng Jiang <tijiang@rim.com>
  234. [BlackBerry] Check image node with usemap attribute isLink failed
  235. https://bugs.webkit.org/show_bug.cgi?id=114751
  236. Reviewed by Rob Buis.
  237. PR 326780
  238. Internally Reviewed by Liam Quinn.
  239. An image node with usemap will crash when call isLink.
  240. If the node is linkNode, bring up the CCM(eg. linked image).
  241. Also use toElement method as agomes suggested in pr 113957.
  242. * Api/WebPage.cpp:
  243. (BlackBerry::WebKit::WebPagePrivate::webContext):
  244. * WebKitSupport/FatFingers.cpp:
  245. (BlackBerry::WebKit::FatFingers::findBestPoint):
  246. 2013-04-16 Nima Ghanavatian <nghanavatian@blackberry.com>
  247. Redo spellchecking of a field if the layout has changed
  248. https://bugs.webkit.org/show_bug.cgi?id=114700
  249. Reviewed by Rob Buis.
  250. Internally reviewed by Mike Fenton.
  251. PR258637
  252. If we insert a child node during spellchecking, the current request along
  253. with the requests in queue become stale. The offsets were calculated when
  254. they were created are no longer valid. We clear the queue by setting sequence
  255. id to -1 and trigger spell checking again. We only trigger re-checking
  256. if the layout change occurred during processing of a request. This is
  257. maintained with the m_request pointer as it should be cleared after use.
  258. * Api/WebPage.cpp:
  259. (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
  260. * WebCoreSupport/EditorClientBlackBerry.cpp:
  261. (WebCore::EditorClientBlackBerry::requestCheckingOfString):
  262. * WebKitSupport/InputHandler.cpp:
  263. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  264. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  265. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  266. (BlackBerry::WebKit::InputHandler::setElementFocused):
  267. (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
  268. (WebKit):
  269. (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
  270. * WebKitSupport/InputHandler.h:
  271. (InputHandler):
  272. 2013-04-16 Jacky Jiang <zhajiang@blackberry.com>
  273. [BlackBerry] Viewport not rendered correctly
  274. https://bugs.webkit.org/show_bug.cgi?id=114704
  275. Reviewed by Rob Buis.
  276. Internally reviewed by Konrad Piascik.
  277. PR: 326260
  278. The applyDeviceScaleFactorInCompositor setting is now generated from
  279. Settings.in after rebase, the setter should be setApplyDeviceScaleFactorInCompositor()
  280. instead of setApplyPageScaleFactorInCompositor().
  281. The setting can be removed from WebSettings and use a simpler way
  282. instead in the future if there are no issues when TextAutoSizer is
  283. enabled. Just keep it for now.
  284. * Api/WebPage.cpp:
  285. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  286. * Api/WebSettings.cpp:
  287. (BlackBerry::WebKit::WebSettings::setApplyDeviceScaleFactorInCompositor):
  288. * Api/WebSettings.h:
  289. 2013-04-16 Leo Yang <leoyang@rim.com>
  290. [BlackBerry] Update WebPage.{h, cpp} for supporting web filesystem
  291. https://bugs.webkit.org/show_bug.cgi?id=114698
  292. Reviewed by Rob Buis.
  293. * Api/WebPage.cpp:
  294. (BlackBerry::WebKit::WebPagePrivate::init):
  295. (BlackBerry::WebKit::WebPage::clearBrowsingData):
  296. (BlackBerry::WebKit::WebPage::clearWebFileSystem):
  297. (WebKit):
  298. * Api/WebPage.h:
  299. 2013-04-16 Arvid Nilsson <anilsson@rim.com>
  300. [BlackBerry] Accelerated animation regression with GL renderer
  301. https://bugs.webkit.org/show_bug.cgi?id=114685
  302. Reviewed by Rob Buis.
  303. Internally reviewed by Filip Spacek.
  304. GL renderer changed the assumption made in accelerated animation
  305. code that rendering the contents of AC layer tiles would be the
  306. slow operation. By starting animations after the slow operation,
  307. the appearance of the animation could be made smooth.
  308. Rendering tiles may still be slow, but now something else can be
  309. slow too: drawing display lists to backing. And it's running on
  310. the compositing thread, can happen at any time and will interrupt
  311. accelerated animations.
  312. Improved the situation by calling an API for updating backing to
  313. schedule the delay at a convenient time. We try to update backing
  314. before starting animations. However, future backing updates can
  315. still interrupt the running animation and cause dropped frames.
  316. Further improvements to animation smoothness will probably require
  317. optimizations in the GL renderer.
  318. * Api/WebPage.cpp:
  319. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  320. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  321. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  322. * Api/WebPage_p.h:
  323. (WebPagePrivate):
  324. * WebKitSupport/FrameLayers.cpp:
  325. (BlackBerry::WebKit::FrameLayers::notifyAnimationsStarted):
  326. (WebKit):
  327. * WebKitSupport/FrameLayers.h:
  328. (FrameLayers):
  329. 2013-04-15 Liam Quinn <lquinn@blackberry.com>
  330. [BlackBerry] Crash from null m_webSettings in WebPagePrivate
  331. https://bugs.webkit.org/show_bug.cgi?id=114633
  332. RIM PR 303745
  333. Reviewed by Rob Buis.
  334. Internally reviewed by Leo Yang.
  335. Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.
  336. * Api/WebPage.cpp:
  337. (BlackBerry::WebKit::WebPagePrivate::init):
  338. 2013-04-15 Andy Chen <andchen@blackberry.com>
  339. [BlackBerry] Forward userGesture when creating a new window
  340. https://bugs.webkit.org/show_bug.cgi?id=114622
  341. Reviewed by Rob Buis.
  342. Client could use this info to decide whether the popup should
  343. be blocked.
  344. PR 291898
  345. Reviewed internally by Mike Fenton
  346. * Api/WebPageClient.h:
  347. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  348. (WebCore::ChromeClientBlackBerry::createWindow):
  349. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  350. (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
  351. 2013-04-15 Xan Lopez <xlopez@igalia.com>
  352. [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
  353. https://bugs.webkit.org/show_bug.cgi?id=114615
  354. Reviewed by Carlos Garcia Campos.
  355. Add a method to enable the style scoped feature to our
  356. DumpRenderTreeSupport class.
  357. * WebKitSupport/DumpRenderTreeSupport.cpp:
  358. (DumpRenderTreeSupport::setStyleScopedEnabled):
  359. * WebKitSupport/DumpRenderTreeSupport.h:
  360. (DumpRenderTreeSupport):
  361. 2013-04-12 Yongxin Dai <yodai@rim.com>
  362. [BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
  363. https://bugs.webkit.org/show_bug.cgi?id=114515
  364. Reviewed by Rob Buis.
  365. PR #317924.
  366. Internally reviewed by Mike Fenton.
  367. It was still hard to select text in URL bar with an inverted selection handle.
  368. We improve the issue by replacing the Y coordinate of selection point with Y
  369. coordinate of start caret for single line input filed. Thus, the Y coordinate
  370. is always valid regardless of the actual location of the selection handle.
  371. * WebKitSupport/SelectionHandler.cpp:
  372. (BlackBerry::WebKit::SelectionHandler::setSelection):
  373. (BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
  374. (WebKit):
  375. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  376. * WebKitSupport/SelectionHandler.h:
  377. (SelectionHandler):
  378. 2013-04-12 Carlos Garcia Campos <cgarcia@igalia.com>
  379. [BlackBerry] Crash running layout tests
  380. https://bugs.webkit.org/show_bug.cgi?id=114503
  381. Reviewed by Xan Lopez.
  382. Hit an assertion in ~GuardedPointerBase when DRT is
  383. deleted. DumpRenderTree class derives from
  384. BlackBerry::Platform::LayoutTestClient that derives from
  385. BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
  386. should no be released with delete but with
  387. BlackBerry::Platform::deleteGuardedObject().
  388. * Api/WebPage.cpp:
  389. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  390. 2013-04-12 Carlos Garcia Campos <cgarcia@igalia.com>
  391. [BlackBerry] Crash running layout tests when WebPage is destroyed
  392. https://bugs.webkit.org/show_bug.cgi?id=114497
  393. Reviewed by Xan Lopez.
  394. PR 324649
  395. Internally reviewed by Konrad Piascik and Rob Buis.
  396. Use a bool member to keep track of whether the inspector is
  397. enabled or not instead of relaying on the enable developer extras
  398. setting, that can be set in other places than enableWebInspector().
  399. * Api/WebPage.cpp:
  400. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
  401. m_inspectorEnabled.
  402. (BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
  403. inspector is already enabled and set m_inspectorEnabled to true.
  404. (BlackBerry::WebKit::WebPage::disableWebInspector): Return early
  405. if inspector is not enabled and set m_inspectorEnabled to false.
  406. (BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
  407. current value of m_inspectorEnabled instead of the developer
  408. extras setting.
  409. * Api/WebPage_p.h:
  410. (WebPagePrivate): Add m_inspectorEnabled.
  411. 2013-04-11 Jacky Jiang <zhajiang@rim.com>
  412. [BlackBerry] Initial scale changes depending on the order of page navigations
  413. https://bugs.webkit.org/show_bug.cgi?id=114448
  414. Reviewed by Rob Buis.
  415. PR: 323941
  416. During page transitions, absoluteVisibleOverflowSize() and contentsSize()
  417. in fixedLayoutSize() were based on the old page when we just started or
  418. committed provisinal load. In that case, fixedLayoutSize() is very old
  419. page dependent and can cause inconsistent behaviors. For example, if
  420. the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
  421. as the new page's fixedLayoutSize; however, we will get 768 if we
  422. navigate to the new page directly.
  423. To fix that, return default layout size if the page doesn't have
  424. virtual viewport and m_loadState is Provisional.
  425. * Api/WebPage.cpp:
  426. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  427. 2013-04-11 Arvid Nilsson <anilsson@rim.com>
  428. [BlackBerry] LayerTexture refactoring
  429. https://bugs.webkit.org/show_bug.cgi?id=114276
  430. Reviewed by Carlos Garcia Campos.
  431. Adapt to the LayerTexture refactoring down in WebCore.
  432. PR 322882
  433. * Api/WebOverlay.cpp:
  434. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  435. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
  436. 2013-04-10 Arvid Nilsson <anilsson@rim.com>
  437. [BlackBerry] Rename BlackBerry specific Texture class
  438. https://bugs.webkit.org/show_bug.cgi?id=95781
  439. Reviewed by Rob Buis.
  440. Texture was a bit too generic and prone to name conflicts. Renamed it
  441. to LayerTexture.
  442. PR 322882
  443. * Api/WebOverlay.cpp:
  444. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  445. * Api/WebOverlay_p.h:
  446. (WebOverlayLayerCompositingThreadClient):
  447. 2013-04-08 Anders Carlsson <andersca@apple.com>
  448. Remove unneeded headers from FrameLoader.h
  449. https://bugs.webkit.org/show_bug.cgi?id=114223
  450. Reviewed by Geoffrey Garen.
  451. Include HistoryController.h from WebCore.
  452. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  453. 2013-04-09 Geoffrey Garen <ggaren@apple.com>
  454. Removed bitrotted TimeoutChecker code
  455. https://bugs.webkit.org/show_bug.cgi?id=114336
  456. Reviewed by Alexey Proskuryakov.
  457. * Api/WebPage.cpp:
  458. (BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):
  459. 2013-04-09 Jacky Jiang <zhajiang@rim.com>
  460. [BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
  461. https://bugs.webkit.org/show_bug.cgi?id=114296
  462. Reviewed by Rob Buis.
  463. PR: 308655
  464. We were relying on the load state Committed to reset m_userPerformedManualZoom
  465. and m_userPerformedManualScroll; however, the main resources of the
  466. articles on read.thestar.com were preloaded and the WebPage didn't get
  467. any load state change callbacks when going back to the main page from
  468. the articles. Therefore, m_userPerformedManualZoom had never been reset
  469. in this case and we picked up the wrong scale when restoring the main page.
  470. Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
  471. we are going back or forward.
  472. * Api/WebPage.cpp:
  473. (BlackBerry::WebKit::WebPage::goBackOrForward):
  474. 2013-04-09 Alberto Garcia <agarcia@igalia.com>
  475. [BlackBerry] InputHandler: fix calls to HTMLInputElement methods
  476. https://bugs.webkit.org/show_bug.cgi?id=114283
  477. Reviewed by Rob Buis.
  478. Fix calls with wrong names.
  479. * WebKitSupport/InputHandler.cpp:
  480. (BlackBerry::WebKit::convertInputType):
  481. 2013-04-08 Benjamin Poulain <benjamin@webkit.org>
  482. Remove HTML Notification
  483. https://bugs.webkit.org/show_bug.cgi?id=114231
  484. Reviewed by Ryosuke Niwa.
  485. * WebCoreSupport/AboutDataEnableFeatures.in:
  486. 2013-04-08 Alberto Garcia <agarcia@igalia.com>
  487. [BlackBerry] WebPage: fix build due to type mismatches
  488. https://bugs.webkit.org/show_bug.cgi?id=114148
  489. Reviewed by Darin Adler.
  490. Add explicit conversions between LayoutUnit and int, and between
  491. LayoutRect and IntRect.
  492. * Api/WebPage.cpp:
  493. (BlackBerry::WebKit::WebPagePrivate::rectForNode):
  494. 2013-04-08 Jeff Rogers <jrogers@rim.com>
  495. [BlackBerry] Update BlackBerry JavaScript API
  496. https://bugs.webkit.org/show_bug.cgi?id=114065
  497. Reviewed by Rob Buis.
  498. Internal PR 317350
  499. Add new API for determining if user gesture is being processed.
  500. Remove obsolete files.
  501. Properly expose JSC global context.
  502. * Api/WebPage.cpp:
  503. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  504. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  505. (BlackBerry::WebKit::WebPage::globalContext):
  506. (BlackBerry::WebKit::WebPage::isProcessingUserGesture):
  507. (WebKit):
  508. * Api/WebPage.h:
  509. * Api/WebPageClient.h:
  510. * Api/WebPage_p.h:
  511. (WebPagePrivate):
  512. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  513. * WebCoreSupport/ChromeClientBlackBerry.h:
  514. (ChromeClientBlackBerry):
  515. * WebCoreSupport/ClientExtension.cpp: Removed.
  516. * WebCoreSupport/ClientExtension.h: Removed.
  517. * WebCoreSupport/ExternalExtension.cpp: Removed.
  518. * WebCoreSupport/ExternalExtension.h: Removed.
  519. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  520. (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
  521. 2013-04-08 Jakob Petsovits <jpetsovits@blackberry.com>
  522. [BlackBerry] More null checks for m_mainFrame
  523. https://bugs.webkit.org/show_bug.cgi?id=114172
  524. Reviewed by Rob Buis.
  525. After r147744, some unit tests were crashing on WebPage
  526. shutdown, because BackingStorePrivate::repaint() now uses
  527. pixelContentsRect() (accessing m_webPage->contentsRect())
  528. instead of BackingStoreClient::contentsRect(). In m_webPage,
  529. m_mainFrame had already been set to 0.
  530. Make us more robust against these errors by checking
  531. the existence of m_mainFrame more diligently.
  532. * Api/WebPage.cpp:
  533. (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
  534. (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
  535. (BlackBerry::WebKit::WebPagePrivate::contentsSize):
  536. (BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
  537. (BlackBerry::WebKit::WebPagePrivate::setViewMode):
  538. 2013-04-08 Iris Wu <shuwu@blackberry.com>
  539. [BlackBerry] Force horizontal list to be horizontal scrollable.
  540. https://bugs.webkit.org/show_bug.cgi?id=114173
  541. Reviewed by Rob Buis.
  542. Force content to be horizontal/vertical overscrollable if it
  543. scrolls in horizontal/vertical way.
  544. PR 237440
  545. Internally Reviewed by Arvid Nilsson.
  546. * WebKitSupport/InRegionScrollableArea.cpp:
  547. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  548. 2013-04-08 Alberto Garcia <agarcia@igalia.com>
  549. [BlackBerry] WebPage: misc build fixes
  550. https://bugs.webkit.org/show_bug.cgi?id=114152
  551. Reviewed by Carlos Garcia Campos.
  552. * Api/WebPage.cpp:
  553. (BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
  554. (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
  555. (BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
  556. (BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
  557. Remove unused parameters.
  558. (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
  559. (BlackBerry::WebKit::WebPage::blockZoom):
  560. Replace TAAUTO with TASTART (this changed in r120495).
  561. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  562. Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
  563. r142220).
  564. (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
  565. Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
  566. r113514).
  567. 2013-04-07 David Kilzer <ddkilzer@apple.com>
  568. Remove the rest of SVG_DOM_OBJC_BINDINGS
  569. <http://webkit.org/b/114112>
  570. Reviewed by Geoffrey Garen.
  571. * WebCoreSupport/AboutDataEnableFeatures.in:
  572. - Remove reference to SVG_DOM_OBJC_BINDINGS.
  573. 2013-04-06 Zan Dobersek <zdobersek@igalia.com>
  574. Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
  575. https://bugs.webkit.org/show_bug.cgi?id=114084
  576. Reviewed by Ryosuke Niwa.
  577. * WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
  578. 2013-04-05 Tiancheng Jiang <tijiang@rim.com>
  579. [BlackBerry] FatFingers Don't check the shadow tree for all elements.
  580. https://bugs.webkit.org/show_bug.cgi?id=114066
  581. Reviewed by Rob Buis.
  582. BlackBerry PR 263078
  583. Internally reviewed by Genevieve Mak.
  584. No need to check shadow tree since sliders use touch events.
  585. * WebKitSupport/FatFingers.cpp:
  586. (BlackBerry::WebKit::FatFingers::isElementClickable):
  587. 2013-04-05 Zan Dobersek <zdobersek@igalia.com>
  588. Remove WTF_USE_GOOGLEURL-guarded code
  589. https://bugs.webkit.org/show_bug.cgi?id=114028
  590. Reviewed by Ryosuke Niwa.
  591. * WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.
  592. 2013-04-04 Jacky Jiang <zhajiang@rim.com>
  593. [BlackBerry] Blitting wrong rect during history navigations
  594. https://bugs.webkit.org/show_bug.cgi?id=113963
  595. Reviewed by Rob Buis.
  596. Internally reviewed by Jakob Petsovits.
  597. On www.bbc.com/news, we blit wrong rect during the second restoration
  598. of the view states when we navigate back from stories to the main page.
  599. Update the contents size and scroll position before we render and blit
  600. if we failed to zoomAboutPoint so that UI thread can still get the
  601. correct rect during blit.
  602. * Api/WebPage.cpp:
  603. (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
  604. 2013-04-05 Jakob Petsovits <jpetsovits@blackberry.com>
  605. [BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
  606. https://bugs.webkit.org/show_bug.cgi?id=113449
  607. Reviewed by Rob Buis.
  608. This removes the WebPage/BackingStoreClient family of coordinate
  609. transformation functions, which were widely disliked for their
  610. naming, with ViewportAccessor API that had previously been
  611. introduced for limited use cases. This commit takes care of the
  612. remaining call sites and leaves us with a single API to use.
  613. No new tests, only a clean-up/refactor of existing code & functionality.
  614. * Api/BackingStore.cpp:
  615. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  616. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  617. (BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
  618. (BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
  619. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  620. (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
  621. * Api/InRegionScroller.cpp:
  622. (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
  623. * Api/WebPage.cpp:
  624. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  625. (BlackBerry::WebKit::WebPagePrivate::init):
  626. (BlackBerry::WebKit::WebPagePrivate::scrollPosition):
  627. (BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
  628. (BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
  629. (BlackBerry::WebKit::WebPagePrivate::viewportSize):
  630. (BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
  631. (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
  632. (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
  633. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  634. (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
  635. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  636. (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
  637. (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
  638. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  639. (BlackBerry::WebKit::WebPage::blockZoom):
  640. * Api/WebPage_p.h:
  641. (WebPagePrivate):
  642. * WebKitSupport/BackingStoreClient.cpp:
  643. (BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
  644. (BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
  645. (BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
  646. (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
  647. * WebKitSupport/BackingStoreClient.h:
  648. (BackingStoreClient):
  649. * WebKitSupport/FatFingers.cpp:
  650. (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
  651. (BlackBerry::WebKit::FatFingers::FatFingers):
  652. (BlackBerry::WebKit::FatFingers::findBestPoint):
  653. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  654. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  655. * WebKitSupport/InRegionScrollableArea.cpp:
  656. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  657. * WebKitSupport/InputHandler.cpp:
  658. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  659. * WebKitSupport/TouchEventHandler.cpp:
  660. (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
  661. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  662. (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
  663. * WebKitSupport/WebKitThreadViewportAccessor.cpp:
  664. (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
  665. (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
  666. (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
  667. 2013-04-05 Alberto Garcia <agarcia@igalia.com>
  668. [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
  669. https://bugs.webkit.org/show_bug.cgi?id=114022
  670. Reviewed by Carlos Garcia Campos.
  671. Naming the 'time' and 'inClip' unused parameters only produces
  672. compiler warnings.
  673. * Api/WebOverlay_p.h:
  674. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
  675. (WebOverlayPrivateWebKitThread):
  676. * Api/WebPage_p.h:
  677. (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
  678. (BlackBerry::WebKit::WebPagePrivate::paintContents):
  679. * WebKitSupport/DefaultTapHighlight.h:
  680. (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
  681. * WebKitSupport/InspectorOverlayBlackBerry.cpp:
  682. (BlackBerry::WebKit::InspectorOverlay::paintContents):
  683. * WebKitSupport/InspectorOverlayBlackBerry.h:
  684. (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
  685. (InspectorOverlay):
  686. * WebKitSupport/SelectionOverlay.h:
  687. (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
  688. 2013-04-05 Alberto Garcia <agarcia@igalia.com>
  689. [BlackBerry] WebOverlay: fix access to m_client
  690. https://bugs.webkit.org/show_bug.cgi?id=114003
  691. Reviewed by Rob Buis.
  692. m_client was replace by m_overlay in r146058.
  693. * Api/WebOverlay.cpp:
  694. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  695. 2013-04-05 Alberto Garcia <agarcia@igalia.com>
  696. [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
  697. https://bugs.webkit.org/show_bug.cgi?id=114009
  698. Reviewed by Carlos Garcia Campos.
  699. These methods were removed in r133517 but were accidentally
  700. introduced again in r145968.
  701. The previous patch didn't remove them all.
  702. * WebKitSupport/DefaultTapHighlight.cpp:
  703. * WebKitSupport/DefaultTapHighlight.h:
  704. (DefaultTapHighlight):
  705. * WebKitSupport/InspectorOverlayBlackBerry.cpp:
  706. * WebKitSupport/InspectorOverlayBlackBerry.h:
  707. (InspectorOverlay):
  708. * WebKitSupport/SelectionOverlay.cpp:
  709. * WebKitSupport/SelectionOverlay.h:
  710. (SelectionOverlay):
  711. 2013-04-05 Alberto Garcia <agarcia@igalia.com>
  712. [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
  713. https://bugs.webkit.org/show_bug.cgi?id=114009
  714. Reviewed by Carlos Garcia Campos.
  715. These methods were removed in r133517 but were accidentally
  716. introduced again in r145968.
  717. * Api/WebOverlay_p.h:
  718. (WebOverlayPrivateWebKitThread):
  719. 2013-04-05 Anthony Scian <ascian@blackberry.com>
  720. [BlackBerry] WebOverlay: check if platformContext is null
  721. https://bugs.webkit.org/show_bug.cgi?id=114005
  722. Reviewed by Carlos Garcia Campos.
  723. RIM PR 256522
  724. Internally reviewed by Mike Lattanzio.
  725. The pointer returned by lockBufferDrawable can be null, so it
  726. needs to be checked first before being used.
  727. * Api/WebOverlay.cpp:
  728. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  729. 2013-04-05 Benjamin Poulain <bpoulain@apple.com>
  730. Remove WTFURL from WebKit
  731. https://bugs.webkit.org/show_bug.cgi?id=113994
  732. Reviewed by Ryosuke Niwa.
  733. * WebCoreSupport/AboutDataUseFeatures.in:
  734. 2013-04-04 Andrew Lo <anlo@rim.com>
  735. [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
  736. https://bugs.webkit.org/show_bug.cgi?id=113944
  737. Reviewed by Rob Buis.
  738. Internally reviewed by Mike Fenton.
  739. Internal PR 320732.
  740. When checking whether a RenderObject is fixed position or has a fixed position
  741. ancestor, we traverse the render tree upwards.
  742. When we reach the root of the tree, check whether the root is an
  743. iframe and has an element owner. If so, we also need to continue iterating
  744. up the tree from the owner to see if the iframe is a descendant of a fixed
  745. position element.
  746. * WebKitSupport/DOMSupport.cpp:
  747. (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
  748. 2013-04-04 Tiancheng Jiang <tijiang@rim.com>
  749. [BlackBerry] Adjust fatfinger result priority
  750. https://bugs.webkit.org/show_bug.cgi?id=113957
  751. Reviewed by Rob Buis.
  752. RIM PR 224781
  753. Internally Reviewed by Genevieve Mak.
  754. Change fatfigner algorithm, return the clickable element rather than
  755. its parent anchor. Modify taphighlight and context menu node selection
  756. accordingly.
  757. * Api/WebPage.cpp:
  758. (BlackBerry::WebKit::WebPagePrivate::webContext):
  759. * WebKitSupport/FatFingers.cpp:
  760. (BlackBerry::WebKit::FatFingers::findBestPoint):
  761. * WebKitSupport/FatFingers.h:
  762. * WebKitSupport/TouchEventHandler.cpp:
  763. (BlackBerry::WebKit::elementForTapHighlight):
  764. 2013-04-03 Arvid Nilsson <anilsson@rim.com>
  765. [BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
  766. https://bugs.webkit.org/show_bug.cgi?id=113872
  767. Reviewed by Carlos Garcia Campos.
  768. Carlos pointed out that recomputeVirtualViewportFromViewportArguments
  769. already contains the check, and returns an empty IntSize if it fails.
  770. So pick up on that to make the code a bit more DRY.
  771. * Api/WebPage.cpp:
  772. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  773. 2013-04-03 Arvid Nilsson <anilsson@rim.com>
  774. [BlackBerry] Decouple layout viewport from visual viewport
  775. https://bugs.webkit.org/show_bug.cgi?id=113829
  776. Reviewed by Carlos Garcia Campos.
  777. Setting the visual viewport would force the layout viewport equal to
  778. the visual viewport. Decouple the viewports by allowing the user to
  779. specify a layout viewport when setting the viewport(s). The layout
  780. viewport could be the exact same value passed for visual viewport, if
  781. the old behavior is desired.
  782. Also reevaluate any viewport arguments when (only) the layout viewport
  783. changes in WebPage::setDefaultLayoutSize() since the layout viewport is
  784. used as input to the calculation.
  785. * Api/WebPage.cpp:
  786. (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
  787. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  788. (BlackBerry::WebKit::WebPage::setViewportSize):
  789. (WebKit):
  790. (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
  791. (BlackBerry::WebKit::WebPage::defaultLayoutSize):
  792. * Api/WebPage.h:
  793. * Api/WebPage_p.h:
  794. (WebPagePrivate):
  795. 2013-04-02 Maxim Mogilnitsky <mmogilnitsky@rim.com>
  796. [BlackBerry] API update for IntRect
  797. https://bugs.webkit.org/show_bug.cgi?id=113824
  798. Reviewed by Rob Buis.
  799. Modifing IntRect and FloatRect API.
  800. * WebKitSupport/SelectionHandler.cpp:
  801. (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
  802. 2013-04-02 Nima Ghanavatian <nghanavatian@blackberry.com>
  803. [BlackBerry] Create a selection from two points irregardless of the caret position.
  804. https://bugs.webkit.org/show_bug.cgi?id=113795
  805. Reviewed by Rob Buis.
  806. Internally reviewed by Mike Fenton.
  807. PR276577
  808. If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
  809. This prevents us from overwriting the previous calculation when setting extent.
  810. Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
  811. create a new directional selection so as to set the base and extent simultaneously.
  812. * WebKitSupport/SelectionHandler.cpp:
  813. (BlackBerry::WebKit::SelectionHandler::setSelection):
  814. 2013-04-01 Konrad Piascik <kpiascik@blackberry.com>
  815. [BlackBerry] Move Path into it's own header
  816. https://bugs.webkit.org/show_bug.cgi?id=113724
  817. Reviewed by Rob Buis.
  818. * WebKitSupport/DefaultTapHighlight.cpp:
  819. 2013-03-29 Charles Wei <charles.wei@torchmobile.com.cn>
  820. [BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
  821. https://bugs.webkit.org/show_bug.cgi?id=113562
  822. Reviewed by George Staikos.
  823. Internally reviewed by Mike Fenton and Gen Mak.
  824. * Api/WebPage.cpp:
  825. (BlackBerry::WebKit::WebPagePrivate::init):
  826. * WebCoreSupport/ContextMenuClientBlackBerry.cpp:
  827. * WebCoreSupport/ContextMenuClientBlackBerry.h:
  828. 2013-03-29 Charles Wei <charles.wei@torchmobile.com.cn>
  829. [BlackBerry] Context menu doesn't showup anymore after rebase.
  830. https://bugs.webkit.org/show_bug.cgi?id=113570
  831. Reviewed by George Staikos.
  832. The upstreaming patch for bug: 103058, reverses the return value of
  833. Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
  834. so we should reverse our logic in webkit part that calls it also.
  835. This only applys to master_41 which is a new rebase, don't apply it to master_40.
  836. * Api/WebPage.cpp:
  837. (BlackBerry::WebKit::WebPagePrivate::webContext):
  838. 2013-03-28 Iris Wu <shuwu@blackberry.com>
  839. [BlackBerry] Don't cross editing boundary when touch hold selection expands
  840. https://bugs.webkit.org/show_bug.cgi?id=113537
  841. Reviewed by Rob Buis.
  842. Set editing boundary crossing rule to make sure it won't cross
  843. editing boundary when selection expands.
  844. Reviewed Internally By Genevieve Mak and Mike Fenton.
  845. * WebKitSupport/SelectionHandler.cpp:
  846. (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
  847. (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
  848. 2013-03-28 Jakob Petsovits <jpetsovits@blackberry.com>
  849. [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
  850. https://bugs.webkit.org/show_bug.cgi?id=113447
  851. Internal PR 313452
  852. Reviewed by Rob Buis.
  853. Potential threading problems are avoided by moving from
  854. WebPage members and mapToTransformed() to the web page
  855. client's userInterfaceViewportAccessor().
  856. As part of this cleaning effort, the WebPageCompositor's
  857. render() method is changed to now take document instead of
  858. pixel coordinates.
  859. * Api/BackingStore.cpp:
  860. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  861. * Api/WebPageCompositor.cpp:
  862. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  863. (BlackBerry::WebKit::WebPageCompositor::render):
  864. * Api/WebPageCompositor.h:
  865. * Api/WebPageCompositor_p.h:
  866. (WebPageCompositorPrivate):
  867. 2013-03-28 Matt Falkenhagen <falken@chromium.org>
  868. Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
  869. https://bugs.webkit.org/show_bug.cgi?id=113273
  870. Reviewed by Kent Tamura.
  871. Element::disabled is about form controls and Element::isEnabledFormControl
  872. is redundant with it, so replace them with a single function
  873. Element::isDisabledFormControl.
  874. * WebCoreSupport/CredentialTransformData.cpp:
  875. (WebCore::CredentialTransformData::findPasswordFormFields):
  876. * WebKitSupport/DOMSupport.cpp:
  877. (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
  878. * WebKitSupport/InputHandler.cpp:
  879. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  880. 2013-03-27 Eli Fidler <efidler@blackberry.com>
  881. [BlackBerry] Show compositing on the Inspector timeline properly
  882. https://bugs.webkit.org/show_bug.cgi?id=113416
  883. Reviewed by Rob Buis.
  884. The call to willComposite was too early and encompased the paint calls
  885. as well. Moving it lower will no longer encompass the paints.
  886. * Api/WebPage.cpp:
  887. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  888. 2013-03-27 Arvid Nilsson <anilsson@rim.com>
  889. [BlackBerry] Populate the mime type of the WebContext for images
  890. https://bugs.webkit.org/show_bug.cgi?id=113272
  891. Reviewed by George Staikos.
  892. PR 278967
  893. Populate the mime type using the file extension reported by the image
  894. decoder. This way we benefit from file type sniffing, instead of
  895. relying on the mime type reported by the resource response.
  896. * Api/WebPage.cpp:
  897. (BlackBerry::WebKit::WebPagePrivate::webContext):
  898. 2013-03-26 Hayato Ito <hayato@chromium.org>
  899. Allow ShadowContents in HitTests by default.
  900. https://bugs.webkit.org/show_bug.cgi?id=113171
  901. Reviewed by Dimitri Glazkov.
  902. * Api/WebPage.cpp:
  903. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  904. * WebKitSupport/FatFingers.cpp:
  905. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  906. * WebKitSupport/ProximityDetector.cpp:
  907. (BlackBerry::WebKit::ProximityDetector::findBestPoint):
  908. * WebKitSupport/SelectionHandler.cpp:
  909. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  910. 2013-03-26 Xiaobo Wang <xbwang@torchmobile.com.cn>
  911. [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
  912. https://bugs.webkit.org/show_bug.cgi?id=112996
  913. Reviewed by Rob Buis.
  914. PR 312552
  915. Internally Reviewed by Anthony Scian.
  916. NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
  917. but not deleted anywhere. Fixed by creating an OwnPtr for it.
  918. Also fixed some webkit-style errors.
  919. * Api/WebPage.cpp:
  920. (BlackBerry::WebKit::WebPagePrivate::init):
  921. * Api/WebPage_p.h:
  922. (WebCore):
  923. (WebPagePrivate):
  924. 2013-03-26 Mike Lattanzio <mlattanzio@blackberry.com>
  925. [BlackBerry] Include accelerated compositing layers in screen captures.
  926. https://bugs.webkit.org/show_bug.cgi?id=113335
  927. Reviewed by Rob Buis.
  928. PR# 280374
  929. Include accelerated compositing layers in screen captures.
  930. Reviewed Internally By: Jakob Petsovits
  931. * Api/BackingStore.cpp:
  932. (BlackBerry::WebKit::BackingStorePrivate::render):
  933. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  934. (BlackBerry::WebKit::BackingStore::drawContents):
  935. * Api/BackingStore_p.h:
  936. 2013-03-26 Tiancheng Jiang <tijiang@rim.com>
  937. [BlackBerry] Set mouse document position for mouse event in updateCursor
  938. https://bugs.webkit.org/show_bug.cgi?id=109094
  939. Reviewed by Rob Buis.
  940. Internally Reviewed by Jakob Petsovits.
  941. Mouse content position should be in document coordinate.
  942. * Api/WebPage.cpp:
  943. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  944. 2013-03-26 Arvid Nilsson <anilsson@rim.com>
  945. [BlackBerry] Scrolling up and down can cause the screen to flash black
  946. https://bugs.webkit.org/show_bug.cgi?id=113269
  947. Reviewed by Rob Buis.
  948. PR 296106
  949. Various flaws in the code could conspire to make the screen cleared to
  950. black before rendering the web page. This only happened when the
  951. BackingStore was inactive, and the LayerTiler takes on the job of
  952. drawing the root layer. When tiles are missing, this made the
  953. "checkerboard" effect especially noticeable since black color was seen
  954. where the tile should have been. It would be better to clear to the web
  955. page background color.
  956. This was actually the intent of the code, but when the document
  957. background color was invalid, we would still use it instead of the
  958. background color from settings. Also, the LayerRenderer would clear to
  959. black when WebPageCompositorPrivate::drawsRootLayer() was true.
  960. Fixed by falling back to the settings background color when the
  961. document background color is invalid, and removing the clearing code
  962. from the LayerRenderer entirely. The appropriate clear already happens
  963. near the beginning of BackingStorePrivate::blitVisibleContents().
  964. Also slightly cleaned up the code for managing the background color.
  965. * Api/WebPage.cpp:
  966. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  967. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  968. (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
  969. (WebKit):
  970. (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
  971. * Api/WebPageCompositor.cpp:
  972. * Api/WebPageCompositor_p.h:
  973. (WebPageCompositorPrivate):
  974. * Api/WebPage_p.h:
  975. (WebPagePrivate):
  976. 2013-03-26 Arvid Nilsson <anilsson@rim.com>
  977. [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
  978. https://bugs.webkit.org/show_bug.cgi?id=113263
  979. Reviewed by Rob Buis.
  980. PR 312404
  981. Fixed by returning pixel viewport coordinates instead of window
  982. coordinates.
  983. * Api/WebOverlay.cpp:
  984. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
  985. 2013-03-26 Xiaobo Wang <xbwang@torchmobile.com.cn>
  986. [BlackBerry] Memory leak in UserMediaClientImpl
  987. https://bugs.webkit.org/show_bug.cgi?id=112998
  988. Reviewed by Rob Buis.
  989. PR 312559
  990. Internally Reviewed by Anthony Scian.
  991. Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
  992. XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().
  993. * WebCoreSupport/UserMediaClientImpl.cpp:
  994. (WebCore::UserMediaClientImpl::pageDestroyed):
  995. 2013-03-25 Kent Tamura <tkent@chromium.org>
  996. Rename ENABLE_INPUT_TYPE_DATETIME
  997. https://bugs.webkit.org/show_bug.cgi?id=113254
  998. Reviewed by Kentaro Hara.
  999. Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
  1000. Actually I'd like to remove the code, but we shouldn't remove it yet
  1001. because we shipped products with it on some platforms.
  1002. * WebCoreSupport/AboutDataEnableFeatures.in:
  1003. 2013-03-25 Mary Wu <mary.wu@torchmobile.com.cn>
  1004. [BlackBerry] add needReferer in WebPage load() api
  1005. https://bugs.webkit.org/show_bug.cgi?id=113167
  1006. Reviewed by Rob Buis.
  1007. PR310175, internally reviewed by Joe Mason.
  1008. Sometimes when client load request, it need to add referer with current frame like
  1009. save link/image in option menu, so we add needRef in load() interface in webpage.
  1010. * Api/WebPage.cpp:
  1011. (BlackBerry::WebKit::WebPagePrivate::load):
  1012. (BlackBerry::WebKit::WebPage::load):
  1013. (BlackBerry::WebKit::WebPage::loadExtended):
  1014. (BlackBerry::WebKit::WebPage::loadFile):
  1015. (BlackBerry::WebKit::WebPage::download):
  1016. * Api/WebPage.h:
  1017. * Api/WebPage_p.h:
  1018. (WebPagePrivate):
  1019. 2013-03-22 Nima Ghanavatian <nghanavatian@blackberry.com>
  1020. [BlackBerry] Build fix in InputHandler
  1021. https://bugs.webkit.org/show_bug.cgi?id=113092
  1022. Reviewed by Rob Buis.
  1023. * WebKitSupport/InputHandler.cpp:
  1024. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  1025. 2013-03-22 Nima Ghanavatian <nghanavatian@blackberry.com>
  1026. Check focused node reference when traversing through history
  1027. https://bugs.webkit.org/show_bug.cgi?id=113082
  1028. Reviewed by Rob Buis.
  1029. PR312101
  1030. Check if we have a valid node and document before attempting to access its frame and
  1031. frame selection. This is causing issues when going back to a page after a redirect
  1032. where a stale pointer is used.
  1033. Further, the focused node should be changed after the frame is fully loaded.
  1034. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1035. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  1036. * WebKitSupport/InputHandler.cpp:
  1037. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  1038. (BlackBerry::WebKit::InputHandler::restoreViewState):
  1039. 2013-03-22 Genevieve Mak <gmak@rim.com>
  1040. [BlackBerry] Hit Test doesn't need to be active
  1041. https://bugs.webkit.org/show_bug.cgi?id=113072
  1042. Reviewed by Rob Buis.
  1043. Reviewed Internally By Mike Lattanzio.
  1044. PR #306074
  1045. * WebKitSupport/ProximityDetector.cpp:
  1046. (BlackBerry::WebKit::ProximityDetector::findBestPoint):
  1047. 2013-03-22 Andrew Lo <anlo@rim.com>
  1048. [BlackBerry] Selection overlay clipped incorrectly
  1049. https://bugs.webkit.org/show_bug.cgi?id=113069
  1050. Reviewed by George Staikos.
  1051. Internally reviewed by Arvid Nilsson.
  1052. As a follow-up to r146278, the clip rect also needs to be
  1053. adjusted by the parent's offset when drawing the
  1054. selection overlay.
  1055. * WebKitSupport/SelectionOverlay.cpp:
  1056. (BlackBerry::WebKit::SelectionOverlay::paintContents):
  1057. 2013-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
  1058. [BlackBerry] Add custom BackForwardList client implementation
  1059. https://bugs.webkit.org/show_bug.cgi?id=113024
  1060. Reviewed by Rob Buis.
  1061. PR 310030
  1062. Internally reviewed by Joe Mason.
  1063. Adds a new class BackForwardListBlackBerry that implements
  1064. BackForwardList client and wraps the BackForwardListImpl including
  1065. the BlackBerry specific changes to notify the API layer when the
  1066. BackForwardList changes.
  1067. * Api/WebPage.cpp:
  1068. (BlackBerry::WebKit::WebPagePrivate::init): Create a
  1069. BackForwardListBlackBerry.
  1070. (BlackBerry::WebKit::WebPage::getBackForwardList): Use
  1071. BackForwardListBlackBerry instead of BackForwardListImpl.
  1072. (BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.
  1073. * WebCoreSupport/BackForwardListBlackBerry.cpp: Added.
  1074. (WebCore):
  1075. (WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
  1076. (WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
  1077. (WebCore::BackForwardListBlackBerry::current):
  1078. (WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
  1079. (WebCore::BackForwardListBlackBerry::addItem):
  1080. (WebCore::BackForwardListBlackBerry::goToItem):
  1081. (WebCore::BackForwardListBlackBerry::itemAtIndex):
  1082. (WebCore::BackForwardListBlackBerry::backListCount):
  1083. (WebCore::BackForwardListBlackBerry::forwardListCount):
  1084. (WebCore::BackForwardListBlackBerry::isActive):
  1085. (WebCore::BackForwardListBlackBerry::close):
  1086. (WebCore::BackForwardListBlackBerry::clear):
  1087. (WebCore::BackForwardListBlackBerry::entries):
  1088. (WebCore::BackForwardListBlackBerry::currentItem):
  1089. * WebCoreSupport/BackForwardListBlackBerry.h: Added.
  1090. (WebKit):
  1091. (WebCore):
  1092. (BackForwardListBlackBerry):
  1093. (WebCore::BackForwardListBlackBerry::create):
  1094. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1095. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  1096. (FrameLoaderClientBlackBerry):
  1097. 2013-03-21 Iris Wu <shuwu@blackberry.com>
  1098. [BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
  1099. https://bugs.webkit.org/show_bug.cgi?id=112966
  1100. Reviewed by Rob Buis.
  1101. PR 312044
  1102. Reviewed Internally By Genevieve Mak.
  1103. If selection reaches the bottom of content, ignore scroll margin
  1104. so the text on the bottom can be selected.
  1105. Stop expanding selection only if the end of document is selected
  1106. or touch is released.
  1107. * WebKitSupport/SelectionHandler.cpp:
  1108. (BlackBerry::WebKit::SelectionHandler::expandSelection):
  1109. (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
  1110. 2013-03-21 Otto Derek Cheung <otcheung@rim.com>
  1111. [BlackBerry] addSearchProvider shouldn't match the full host, only the server
  1112. https://bugs.webkit.org/show_bug.cgi?id=112960
  1113. Reviewed by Rob Buis.
  1114. Internally Reviewed by Jeff Rogers.
  1115. Remove full host matching. only check if domains are from the same server.
  1116. Also, check user gesture before dispatching the addSearchProvider event to the browser.
  1117. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  1118. (WebCore::ChromeClientBlackBerry::addSearchProvider):
  1119. (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
  1120. * WebCoreSupport/ChromeClientBlackBerry.h:
  1121. (ChromeClientBlackBerry):
  1122. * WebCoreSupport/ExternalExtension.cpp:
  1123. (IsSearchProviderInstalledMethod):
  1124. 2013-03-19 Andrew Lo <anlo@rim.com>
  1125. [BlackBerry] Selection overlay is sometimes in wrong position.
  1126. https://bugs.webkit.org/show_bug.cgi?id=112748
  1127. Reviewed by Rob Buis.
  1128. Internally reviewed by Arvid Nilsson.
  1129. Internal PR 305384.
  1130. Translate by parent's offset when drawing selection overlay.
  1131. * WebKitSupport/SelectionOverlay.cpp:
  1132. (BlackBerry::WebKit::SelectionOverlay::paintContents):
  1133. 2013-03-19 Iris Wu <shuwu@blackberry.com>
  1134. [BlackBerry] Hook up scroll position to proximity detector
  1135. https://bugs.webkit.org/show_bug.cgi?id=112743
  1136. Reviewed by Rob Buis.
  1137. PR 243385
  1138. Reviewed Internally By Genevieve Mak.
  1139. * Api/WebPage.cpp:
  1140. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  1141. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  1142. (BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
  1143. (WebKit):
  1144. * Api/WebPage.h:
  1145. * Api/WebPage_p.h:
  1146. (WebPagePrivate):
  1147. 2013-03-19 Chris Hutten-Czapski <chutten@blackberry.com>
  1148. [BlackBerry] Don't handle keyboard scrolling shortcuts in webkit
  1149. https://bugs.webkit.org/show_bug.cgi?id=112716
  1150. Informally Reviewed by Mike Fenton (mifenton@rim.com)
  1151. Reviewed by Rob Buis.
  1152. The comment is right, this isn't the correct place to handle keyboard
  1153. scrolling shortcuts. That's what we have clients for.
  1154. * Api/WebPage.cpp:
  1155. (BlackBerry::WebKit::WebPage::keyEvent):
  1156. 2013-03-19 Andy Chen <andchen@blackberry.com>
  1157. [BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node
  1158. https://bugs.webkit.org/show_bug.cgi?id=112707
  1159. Reviewed by Rob Buis.
  1160. In SelectionHandler, when selecting a new object, we should set focus
  1161. to the anchor node of selection instead of removing it from the old input.
  1162. In InputHandler, when focusedNodeChanged is called, if the new node is
  1163. not an Element node, we need to set focus to its Element parent node,
  1164. instead of removing focus from the old node.
  1165. PR 304631
  1166. Internally reviewed by Mike Fenton.
  1167. * WebKitSupport/InputHandler.cpp:
  1168. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  1169. * WebKitSupport/SelectionHandler.cpp:
  1170. (BlackBerry::WebKit::SelectionHandler::selectObject):
  1171. 2013-03-18 Alberto Garcia <agarcia@igalia.com>
  1172. [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
  1173. https://bugs.webkit.org/show_bug.cgi?id=111733
  1174. Reviewed by Rob Buis.
  1175. Fix missing brace.
  1176. * WebKitSupport/SelectionHandler.cpp:
  1177. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  1178. 2013-03-18 Alberto Garcia <agarcia@igalia.com>
  1179. [BlackBerry] Add Proximity Detector.
  1180. https://bugs.webkit.org/show_bug.cgi?id=112278
  1181. Reviewed by Rob Buis.
  1182. Fix variable names so they actually match the function
  1183. declarations.
  1184. Fix call to rectForPoint(), which was moved from HitTestResult to
  1185. HitTestLocation in r117091 and r126859.
  1186. * WebKitSupport/ProximityDetector.cpp:
  1187. (BlackBerry::WebKit::ProximityDetector::findBestPoint):
  1188. 2013-03-18 Alberto Garcia <agarcia@igalia.com>
  1189. [BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
  1190. https://bugs.webkit.org/show_bug.cgi?id=112556
  1191. Reviewed by Rob Buis.
  1192. This changed in r145849 and broke the BlackBerry build.
  1193. * WebCoreSupport/EditorClientBlackBerry.cpp:
  1194. (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
  1195. (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
  1196. 2013-03-18 Arvid Nilsson <anilsson@rim.com>
  1197. [BlackBerry] Detach overlays from page when compositor is detached
  1198. https://bugs.webkit.org/show_bug.cgi?id=112424
  1199. Reviewed by Rob Buis.
  1200. PR 309160
  1201. If not detached properly, the overlays would have a dangling pointer to
  1202. the page.
  1203. * Api/WebOverlay.cpp:
  1204. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
  1205. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  1206. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
  1207. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
  1208. * Api/WebOverlay_p.h:
  1209. (BlackBerry::WebKit::WebOverlayPrivate::setClient):
  1210. (WebOverlayLayerCompositingThreadClient):
  1211. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
  1212. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
  1213. (WebOverlayPrivateCompositingThread):
  1214. * Api/WebPageCompositor.cpp:
  1215. (BlackBerry::WebKit::WebPageCompositorPrivate::detach):
  1216. (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
  1217. (WebKit):
  1218. (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
  1219. * Api/WebPageCompositor_p.h:
  1220. (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
  1221. (BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
  1222. (WebPageCompositorPrivate):
  1223. 2013-03-18 Alberto Garcia <agarcia@igalia.com>
  1224. [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
  1225. https://bugs.webkit.org/show_bug.cgi?id=112547
  1226. Reviewed by Carlos Garcia Campos.
  1227. * WebKitSupport/BackingStoreClient.cpp:
  1228. (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
  1229. 2013-03-15 Arvid Nilsson <anilsson@rim.com>
  1230. [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
  1231. https://bugs.webkit.org/show_bug.cgi?id=112467
  1232. Reviewed by Rob Buis.
  1233. PR 293208
  1234. This patch contains contributions from many members of the BlackBerry
  1235. WebKit team:
  1236. Mike Lattanzio
  1237. Arvid Nilsson
  1238. Jakob Petsovits
  1239. Konrad Piascik
  1240. Jeff Rogers
  1241. Filip Spacek
  1242. * Api/BackingStore.cpp:
  1243. (BlackBerry::WebKit::BackingStorePrivate::render):
  1244. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  1245. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  1246. (BlackBerry::WebKit::BackingStorePrivate::tileSize):
  1247. * Api/WebOverlay.cpp:
  1248. (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
  1249. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
  1250. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
  1251. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
  1252. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
  1253. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
  1254. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  1255. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
  1256. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
  1257. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
  1258. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
  1259. * Api/WebOverlay.h:
  1260. * Api/WebOverlayClient.h:
  1261. * Api/WebOverlay_p.h:
  1262. (WebOverlayPrivate):
  1263. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
  1264. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
  1265. (WebOverlayLayerCompositingThreadClient):
  1266. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
  1267. (WebOverlayPrivateCompositingThread):
  1268. * Api/WebPageCompositor.cpp:
  1269. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  1270. * WebKitSupport/BackingStoreTile.cpp:
  1271. (BlackBerry::WebKit::TileBuffer::~TileBuffer):
  1272. (BlackBerry::WebKit::TileBuffer::nativeBuffer):
  1273. (BlackBerry::WebKit::TileBuffer::paintBackground):
  1274. * WebKitSupport/DefaultTapHighlight.cpp:
  1275. (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
  1276. (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
  1277. (WebKit):
  1278. (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
  1279. * WebKitSupport/DefaultTapHighlight.h:
  1280. (DefaultTapHighlight):
  1281. * WebKitSupport/InspectorOverlayBlackBerry.cpp:
  1282. (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
  1283. (WebKit):
  1284. (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
  1285. * WebKitSupport/InspectorOverlayBlackBerry.h:
  1286. (InspectorOverlay):
  1287. * WebKitSupport/SelectionOverlay.cpp:
  1288. (BlackBerry::WebKit::SelectionOverlay::draw):
  1289. (BlackBerry::WebKit::SelectionOverlay::hide):
  1290. (BlackBerry::WebKit::SelectionOverlay::paintContents):
  1291. (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
  1292. (WebKit):
  1293. (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
  1294. * WebKitSupport/SelectionOverlay.h:
  1295. (SelectionOverlay):
  1296. * WebKitSupport/SurfacePool.cpp:
  1297. (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
  1298. (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
  1299. (BlackBerry::WebKit::SurfacePool::waitForBuffer):
  1300. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  1301. (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
  1302. * WebKitSupport/SurfacePool.h:
  1303. 2013-03-15 Arvid Nilsson <anilsson@rim.com>
  1304. [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
  1305. https://bugs.webkit.org/show_bug.cgi?id=112255
  1306. Reviewed by Rob Buis.
  1307. PR 308284.
  1308. Reviewed internally by Yongxin Dai.
  1309. The cached draw rectangle is useful for hit testing. Add a getter for
  1310. this compositing thread layer property to the public WebOverlay API.
  1311. We name this getter using terminology familiar from the
  1312. ViewportAccessor interface, to clarify which coordinate system the
  1313. getter uses (pixel coordinates relative to the viewport).
  1314. Note that WebKit-thread flavor of WebOverlay is not currently used by
  1315. any API client and is marked obsolete. It is used internally in WebKit,
  1316. but for that case using GraphicsLayer directly works well. This will
  1317. allow the complexity of WebOverlay to be significantly reduced in the
  1318. future, by removing the WebKit-thread flavor entirely.
  1319. * Api/WebOverlay.cpp:
  1320. (BlackBerry::WebKit::WebOverlay::pixelViewportRect):
  1321. (WebKit):
  1322. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
  1323. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
  1324. * Api/WebOverlay.h:
  1325. (WebKit):
  1326. * Api/WebOverlay_p.h:
  1327. (WebOverlayPrivate):
  1328. (WebOverlayPrivateWebKitThread):
  1329. (WebOverlayPrivateCompositingThread):
  1330. 2013-03-15 Arvid Nilsson <anilsson@rim.com>
  1331. [BlackBerry] Allow an embedder to position child windows using window coordinates
  1332. https://bugs.webkit.org/show_bug.cgi?id=112236
  1333. Reviewed by Rob Buis.
  1334. PR 232752
  1335. Child windows used to always be positioned in document coordinates,
  1336. which requires the
  1337. BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
  1338. window to be kept in sync with the document visible content rect.
  1339. This is easy if there's a one-to-one correspondence between windows
  1340. and scrollable frames.
  1341. However, for an embedder that can display an entire scene graph (where
  1342. the web page is just one of the nodes) in one window, several
  1343. scrollable nodes may be present in that window, and it's difficult to
  1344. know which scrollable node to sync the virtualRect with. It could also
  1345. lead to conflicts, if two scrollable nodes have child windows.
  1346. For the latter scenario, it makes more sense to use window coordinates
  1347. to place child windows.
  1348. The internal default is to use document coordinates, for legacy
  1349. reasons.
  1350. When an external WebPageCompositor is attached, we switch to using
  1351. window coordinates instead of document coordinates by default. The
  1352. behavior is still configurable using the new public
  1353. setChildWindowPlacement method.
  1354. * Api/WebPageCompositor.cpp:
  1355. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  1356. (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
  1357. (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
  1358. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  1359. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  1360. (BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
  1361. (WebKit):
  1362. (BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
  1363. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  1364. (BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):
  1365. * Api/WebPageCompositor.h:
  1366. * Api/WebPageCompositor_p.h:
  1367. (BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
  1368. (WebPageCompositorPrivate):
  1369. 2013-03-15 Nate Chapin <japhet@chromium.org>
  1370. Hide MainResourceLoader from the outside world
  1371. https://bugs.webkit.org/show_bug.cgi?id=109971
  1372. Reviewed by Adam Barth.
  1373. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1374. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  1375. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  1376. (FrameLoaderClientBlackBerry):
  1377. 2013-03-15 Abhishek Arya <inferno@chromium.org>
  1378. Replace static_casts with to* helper functions.
  1379. https://bugs.webkit.org/show_bug.cgi?id=112401
  1380. Reviewed by Stephen Chenney.
  1381. to* helper functions are preferred over static_cast calls since they
  1382. help to catch bad casts easily on the testing infrastructure.
  1383. * Api/WebPage.cpp:
  1384. (BlackBerry::WebKit::frameForNode):
  1385. (BlackBerry::WebKit::needsLayoutRecursive):
  1386. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1387. (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
  1388. * WebKitSupport/InputHandler.cpp:
  1389. (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
  1390. 2013-03-14 Manuel Rego Casasnovas <rego@igalia.com>
  1391. Add selectTrailingWhitespaceEnabled setting to WebCore::Page
  1392. https://bugs.webkit.org/show_bug.cgi?id=109404
  1393. Reviewed by Tony Chang.
  1394. Use new settings for smartInsertDeleteEnabled and
  1395. selectTrailingWhitespaceEnabled.
  1396. Remove code related to DRT as it is not needed anymore.
  1397. * Api/DumpRenderTreeClient.h:
  1398. * WebCoreSupport/EditorClientBlackBerry.cpp:
  1399. (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
  1400. (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
  1401. 2013-03-14 Abhishek Arya <inferno@chromium.org>
  1402. Replace static_casts with to* helper functions.
  1403. https://bugs.webkit.org/show_bug.cgi?id=112296
  1404. Reviewed by Kentaro Hara.
  1405. to* helper functions are preferred over static_cast calls since they
  1406. help to catch bad casts easily on the testing infrastructure.
  1407. * Api/WebPage.cpp:
  1408. (BlackBerry::WebKit::WebPagePrivate::webContext):
  1409. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  1410. (BlackBerry::WebKit::WebPage::setNodeFocus):
  1411. (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
  1412. * WebCoreSupport/EditorClientBlackBerry.cpp:
  1413. (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
  1414. (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
  1415. * WebKitSupport/BackingStoreClient.cpp:
  1416. (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
  1417. * WebKitSupport/DOMSupport.cpp:
  1418. (BlackBerry::WebKit::DOMSupport::toTextControlElement):
  1419. (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
  1420. * WebKitSupport/FatFingers.cpp:
  1421. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
  1422. (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
  1423. * WebKitSupport/InputHandler.cpp:
  1424. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  1425. (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
  1426. * WebKitSupport/SelectionHandler.cpp:
  1427. (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
  1428. * WebKitSupport/TouchEventHandler.cpp:
  1429. (BlackBerry::WebKit::elementForTapHighlight):
  1430. 2013-03-14 Alberto Garcia <agarcia@igalia.com>
  1431. [BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
  1432. https://bugs.webkit.org/show_bug.cgi?id=112244
  1433. Reviewed by Rob Buis.
  1434. Since r143295 visibleContentRect() receives an enum, not a boolean.
  1435. * WebKitSupport/InRegionScrollableArea.cpp:
  1436. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  1437. 2013-03-13 Iris Wu <shuwu@blackberry.com>
  1438. [BlackBerry] Do not do scroll position adjustment if selecting in a subframe
  1439. https://bugs.webkit.org/show_bug.cgi?id=112290
  1440. Reviewed by Rob Buis.
  1441. PR 267394
  1442. In SelectionHandler::ensureSelectedTextVisible(), scroll position
  1443. animation is based on main frame. If selecting in a subframe, don't
  1444. do animation.
  1445. Internally Reviewed By Genevieve Mak.
  1446. * WebKitSupport/SelectionHandler.cpp:
  1447. (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
  1448. 2013-03-13 Genevieve Mak <gmak@rim.com>
  1449. [BlackBerry] Add Proximity Detector.
  1450. https://bugs.webkit.org/show_bug.cgi?id=112278
  1451. Reviewed by Rob Buis.
  1452. Internally Reviewed by Mike Lattanzio.
  1453. PR #243385
  1454. * WebKitSupport/ProximityDetector.cpp: Added.
  1455. (WebKit):
  1456. (BlackBerry::WebKit::getPriorityLevel):
  1457. (BlackBerry::WebKit::ProximityDetector::ProximityDetector):
  1458. (BlackBerry::WebKit::ProximityDetector::~ProximityDetector):
  1459. (BlackBerry::WebKit::ProximityDetector::findBestPoint):
  1460. * WebKitSupport/ProximityDetector.h: Added.
  1461. (WebCore):
  1462. (WebKit):
  1463. (ProximityDetector):
  1464. 2013-03-13 Iris Wu <shuwu@blackberry.com>
  1465. [BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
  1466. https://bugs.webkit.org/show_bug.cgi?id=112259
  1467. Reviewed by Rob Buis.
  1468. PR 267394
  1469. While selecting in a subframe, check that the selection reaches
  1470. the bottom of the current subframe instead of the page.
  1471. Internally Reviewed by Genevieve Mak.
  1472. * Api/InRegionScroller.cpp:
  1473. (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
  1474. * WebKitSupport/SelectionHandler.cpp:
  1475. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  1476. (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
  1477. (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
  1478. (WebKit):
  1479. (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
  1480. * WebKitSupport/SelectionHandler.h:
  1481. (BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
  1482. (SelectionHandler):
  1483. 2013-03-12 Mike Fenton <mifenton@rim.com>
  1484. [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
  1485. https://bugs.webkit.org/show_bug.cgi?id=111733
  1486. Reviewed by Rob Buis.
  1487. PR 305194.
  1488. Skip rendering of selection if it is in a popup driven
  1489. input field. This covers situations where EditorClientBlackBerry::shouldChangeSelectedRange
  1490. is either not called or focus is not complete when called.
  1491. Informally reviewed by Gen Mak.
  1492. * WebKitSupport/SelectionHandler.cpp:
  1493. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  1494. (WebKit):
  1495. 2013-03-12 Genevieve Mak <gmak@rim.com>
  1496. [BlackBerry] Notify client if the selection is in a subframe when started.
  1497. https://bugs.webkit.org/show_bug.cgi?id=112065
  1498. Reviewed by Rob Buis.
  1499. PR #278490
  1500. Internally Reviewed by Mike Fenton.
  1501. * Api/InRegionScroller.cpp:
  1502. (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
  1503. (WebKit):
  1504. * Api/InRegionScroller_p.h:
  1505. (InRegionScrollerPrivate):
  1506. * Api/WebPage.cpp:
  1507. (BlackBerry::WebKit::WebPagePrivate::updateSelectionScrollView):
  1508. (WebKit):
  1509. * Api/WebPageClient.h:
  1510. * Api/WebPage_p.h:
  1511. (WebPagePrivate):
  1512. * WebKitSupport/SelectionHandler.cpp:
  1513. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  1514. (BlackBerry::WebKit::SelectionHandler::setSelection):
  1515. 2013-03-12 Alberto Garcia <agarcia@igalia.com>
  1516. [BlackBerry] SelectionHandler: fix truncated line
  1517. https://bugs.webkit.org/show_bug.cgi?id=112133
  1518. Reviewed by Carlos Garcia Campos.
  1519. One of the calls to fatFingersResult.nodeAsElementIfApplicable()
  1520. was somehow truncated when the selection start animation was
  1521. upstreamed in r144640.
  1522. * WebKitSupport/SelectionHandler.cpp:
  1523. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  1524. 2013-03-12 Alberto Garcia <agarcia@igalia.com>
  1525. [BlackBerry] Fix visible_units.h includes
  1526. https://bugs.webkit.org/show_bug.cgi?id=112131
  1527. Reviewed by Carlos Garcia Campos.
  1528. This file was renamed to VisibleUnits.h in r144911.
  1529. * WebKitSupport/DOMSupport.cpp:
  1530. * WebKitSupport/InputHandler.cpp:
  1531. * WebKitSupport/SelectionHandler.cpp:
  1532. * WebKitSupport/SpellingHandler.cpp:
  1533. 2013-03-11 Jochen Eisinger <jochen@chromium.org>
  1534. Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
  1535. https://bugs.webkit.org/show_bug.cgi?id=111959
  1536. Reviewed by Alexey Proskuryakov.
  1537. * WebKitSupport/NotificationManager.cpp:
  1538. (BlackBerry::WebKit::NotificationManager::notificationClicked):
  1539. 2013-03-11 Genevieve Mak <gmak@rim.com>
  1540. [BlackBerry] Add a method to find the ScrollView for a text selection.
  1541. https://bugs.webkit.org/show_bug.cgi?id=112061
  1542. Reviewed by Rob Buis.
  1543. Internally reviewed by Mike Fenton and Jakob Petsovits.
  1544. PR #278490
  1545. Refactor the code in InRegionScroller so that we can add a method to find
  1546. the InRegionScrollableArea for a text selection.
  1547. * Api/InRegionScroller.cpp:
  1548. (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
  1549. - Pull out recursive clipping code into its own function.
  1550. (WebKit):
  1551. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  1552. (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
  1553. - This new method allows us to get just the first scrollable region instead of looking
  1554. for more nested ones. We may want to refactor in the future because some of the code is
  1555. very similar to calculateInRegionScrollableAreasForPoint.
  1556. (BlackBerry::WebKit::InRegionScrollerPrivate::clipAndCreateInRegionScrollableArea):
  1557. - Add a convenience method for the previous function
  1558. * Api/InRegionScroller.h:
  1559. (WebKit):
  1560. * Api/InRegionScroller_p.h:
  1561. (InRegionScrollerPrivate):
  1562. 2013-03-11 Genevieve Mak <gmak@rim.com>
  1563. [BlackBerry] Set the documentViewportRect and viewport size.
  1564. https://bugs.webkit.org/show_bug.cgi?id=112056
  1565. Reviewed by Rob Buis.
  1566. Internally reviewed by Mike Fenton and Jakob Petsovits.
  1567. PR #278490
  1568. * WebKitSupport/InRegionScrollableArea.cpp:
  1569. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  1570. 2013-03-11 Alberto Garcia <agarcia@igalia.com>
  1571. [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
  1572. https://bugs.webkit.org/show_bug.cgi?id=111972
  1573. Reviewed by Rob Buis.
  1574. This was removed in r144515 but is still needed by
  1575. SelectionHandler::selectionPositionChanged().
  1576. * WebKitSupport/SelectionHandler.h:
  1577. (SelectionHandler):
  1578. 2013-03-07 Otto Derek Cheung <otcheung@rim.com>
  1579. [BlackBerry] RefCounting ParsedCookie to avoid SegFaults
  1580. https://bugs.webkit.org/show_bug.cgi?id=111761
  1581. Reviewed by Rob Buis.
  1582. Making necessary changes to ref-count the ParsedCookie object.
  1583. * Api/WebCookieJar.cpp:
  1584. (BlackBerry::WebKit::WebCookieJar::cookies):
  1585. 2013-03-07 Mike Fenton <mifenton@rim.com>
  1586. [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
  1587. https://bugs.webkit.org/show_bug.cgi?id=111733
  1588. Reviewed by Rob Buis.
  1589. PR 305194.
  1590. Prevent selection for popup input fields as they are buttons.
  1591. Informally Reviewed Gen Mak.
  1592. * WebCoreSupport/EditorClientBlackBerry.cpp:
  1593. (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
  1594. 2013-03-06 Nima Ghanavatian <nghanavatian@rim.com>
  1595. [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
  1596. https://bugs.webkit.org/show_bug.cgi?id=111618
  1597. Reviewed by Rob Buis.
  1598. PR 303712
  1599. If we are using a RTL language, we should ensure that the selection handles are angled the right way.
  1600. Further, when expanding the selection, the start and end handles should be appropriately set so that
  1601. expansion in the natural direction is possible.
  1602. Internally reviewed by Mike Fenton.
  1603. * WebKitSupport/SelectionHandler.cpp:
  1604. (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
  1605. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  1606. * WebKitSupport/SelectionHandler.h:
  1607. (SelectionHandler):
  1608. 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
  1609. [BlackBerry] Use the new authenticationChallenge API in WebPage
  1610. https://bugs.webkit.org/show_bug.cgi?id=111542
  1611. Reviewed by Rob Buis.
  1612. Use the new API that expects requestURL and isProxy parameters.
  1613. * Api/WebPage.cpp:
  1614. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  1615. * Api/WebPageClient.h:
  1616. 2013-03-05 Geoffrey Garen <ggaren@apple.com>
  1617. Removed some dead code in the page cache
  1618. https://bugs.webkit.org/show_bug.cgi?id=111525
  1619. Reviewed by Alexey Proskuryakov.
  1620. Page cache autorelease doesn't exist anymore, so there's no need to keep
  1621. around these olds hacks.
  1622. * Api/BlackBerryGlobal.cpp:
  1623. (BlackBerry::WebKit::clearMemoryCaches):
  1624. * Api/WebPage.cpp:
  1625. (BlackBerry::WebKit::WebPage::destroy):
  1626. 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
  1627. [BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
  1628. https://bugs.webkit.org/show_bug.cgi?id=111555
  1629. Reviewed by Rob Buis.
  1630. CachedResource::data() was renamed to
  1631. CachedResource::resourceBuffer() in r130947.
  1632. * Api/WebPage.cpp:
  1633. (BlackBerry::WebKit::WebPagePrivate::webContext):
  1634. 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
  1635. [BlackBerry] Remove some unneeded header includes
  1636. https://bugs.webkit.org/show_bug.cgi?id=111545
  1637. Reviewed by Rob Buis.
  1638. * WebCoreSupport/CredentialTransformData.cpp:
  1639. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1640. 2013-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
  1641. [BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
  1642. https://bugs.webkit.org/show_bug.cgi?id=111544
  1643. Reviewed by Rob Buis.
  1644. hasLocalName() expects an AtomicString, but we are passing a
  1645. HTMLName which is a QualifiedName.
  1646. * WebCoreSupport/CredentialTransformData.cpp:
  1647. (WebCore::CredentialTransformData::findPasswordFormFields): Use
  1648. hasTagName() instead of hasLocalName().
  1649. 2013-03-05 Otto Derek Cheung <otcheung@rim.com>
  1650. [BlackBerry] Authentication credentials lost when opening a new tab
  1651. https://bugs.webkit.org/show_bug.cgi?id=111445
  1652. PR 286627
  1653. Reviewed by Rob Buis.
  1654. Internally Reviewed by Lianghui Chen.
  1655. Prevent changing the private mode boolean value in didChangeSettings if the value
  1656. hasn't changed.
  1657. Setting the private mode value of credentialstorage every time didChangeSettings gets
  1658. called causes the session credential mapping to be cleared on every tab change in
  1659. non-private mode.
  1660. Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
  1661. if the credentials are cleared. Also ensured the functionality of private mode is not changed.
  1662. * Api/WebPage.cpp:
  1663. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  1664. 2013-03-05 Tiancheng Jiang <tijiang@rim.com>
  1665. [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
  1666. https://bugs.webkit.org/show_bug.cgi?id=111444
  1667. Reviewed by Rob Buis.
  1668. Internal PR 266214
  1669. Internally reviewed by Genevieve Mak.
  1670. Instead of subtracting with the element region, we should get the remaining
  1671. rect by find the intersect region of element region and fatfinger detection
  1672. region.
  1673. * WebKitSupport/FatFingers.cpp:
  1674. (BlackBerry::WebKit::FatFingers::checkForClickableElement):
  1675. 2013-03-05 Andrew Lo <anlo@rim.com>
  1676. [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
  1677. https://bugs.webkit.org/show_bug.cgi?id=111373
  1678. Reviewed by Rob Buis.
  1679. Internally reviewed by Jakob Petsovits.
  1680. Internal PR 285468.
  1681. Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
  1682. animation finishes, rather than keeping those values as instance variables in
  1683. WebPagePrivate.
  1684. Rename some functions & variables to reflect that they are used for both block zoom
  1685. and generic zoom/scroll animations.
  1686. * Api/WebPage.cpp:
  1687. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  1688. (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
  1689. (BlackBerry::WebKit::WebPage::zoomAnimationFinished):
  1690. (BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
  1691. (BlackBerry::WebKit::WebPage::blockZoom):
  1692. (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
  1693. * Api/WebPage.h:
  1694. * Api/WebPageClient.h:
  1695. * Api/WebPage_p.h:
  1696. (WebPagePrivate):
  1697. 2013-03-04 Iris Wu <shuwu@rim.com>
  1698. [BlackBerry] Upstream selection start animation.
  1699. https://bugs.webkit.org/show_bug.cgi?id=111335
  1700. Reviewed by Rob Buis.
  1701. PR 219960
  1702. To indicate selection starts, we draw an overlay rect larger than
  1703. the selected word at the start of selection. Then shrink it down
  1704. to the actual size.
  1705. Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.
  1706. * Api/WebAnimation.cpp:
  1707. (BlackBerry::WebKit::WebAnimation::shrinkAnimation):
  1708. (WebKit):
  1709. * Api/WebAnimation.h:
  1710. * Api/WebPage.cpp:
  1711. (BlackBerry::WebKit::WebPagePrivate::init):
  1712. (BlackBerry::WebKit::WebPage::selectionHighlight):
  1713. (WebKit):
  1714. * Api/WebPage.h:
  1715. * Api/WebPage_p.h:
  1716. (WebPagePrivate):
  1717. * Api/WebTapHighlight.h:
  1718. * WebKitSupport/DefaultTapHighlight.cpp:
  1719. (WebKit):
  1720. (BlackBerry::WebKit::shrinkAnimationName):
  1721. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  1722. * WebKitSupport/DefaultTapHighlight.h:
  1723. (DefaultTapHighlight):
  1724. * WebKitSupport/SelectionHandler.cpp:
  1725. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  1726. (BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
  1727. (WebKit):
  1728. (BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
  1729. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  1730. * WebKitSupport/SelectionHandler.h:
  1731. (SelectionHandler):
  1732. * WebKitSupport/TouchEventHandler.cpp:
  1733. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  1734. 2013-03-02 Benjamin Poulain <bpoulain@apple.com>
  1735. Move computedStyleIncludingVisitedInfo from TestRunner to Internals
  1736. https://bugs.webkit.org/show_bug.cgi?id=109772
  1737. Reviewed by Andreas Kling.
  1738. * WebKitSupport/DumpRenderTreeSupport.cpp:
  1739. * WebKitSupport/DumpRenderTreeSupport.h:
  1740. (DumpRenderTreeSupport):
  1741. 2013-03-01 Iris Wu <shuwu@rim.com>
  1742. [BlackBerry] Upstream smart selection
  1743. https://bugs.webkit.org/show_bug.cgi?id=111226
  1744. Reviewed by Rob Buis.
  1745. 1. Extend the touch hold text selection to next paragraph.
  1746. 2. Draw and expand overlay over text as touch hold selection expands.
  1747. Select paragraph when it's entirely covered by overlay.
  1748. 3. Start scrolling at a constant rate when the end of
  1749. next pargraph is not in the viewport.
  1750. Reviewed Internally By Genevieve Mak and Mike Fenton.
  1751. PR 217897 238485 258279 279042 299779
  1752. * Api/WebPage.cpp:
  1753. (BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
  1754. (BlackBerry::WebKit::WebPage::expandSelection):
  1755. (WebKit):
  1756. (BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
  1757. (BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
  1758. (BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):
  1759. * Api/WebPage.h:
  1760. * Api/WebPageClient.h:
  1761. * Api/WebPage_p.h:
  1762. (WebPagePrivate):
  1763. * WebKitSupport/SelectionHandler.cpp:
  1764. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  1765. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  1766. (BlackBerry::WebKit::isInvalidLine):
  1767. (WebKit):
  1768. (BlackBerry::WebKit::isInvalidParagraph):
  1769. (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
  1770. (BlackBerry::WebKit::SelectionHandler::drawOverlay):
  1771. (BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
  1772. (BlackBerry::WebKit::SelectionHandler::expandSelection):
  1773. (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
  1774. (BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
  1775. (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
  1776. * WebKitSupport/SelectionHandler.h:
  1777. (SelectionHandler):
  1778. (BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):
  1779. 2013-03-01 Jacky Jiang <zhajiang@rim.com>
  1780. [BlackBerry] Screen went black while navigating back/forward on the reddit.com page
  1781. https://bugs.webkit.org/show_bug.cgi?id=111192
  1782. Reviewed by Rob Buis.
  1783. Internally reviewed by Jakob Petsovits.
  1784. PR: 299783
  1785. When going back to the previous reddit.com page, the actual contents
  1786. size was much less than the history contents size. However, we expanded
  1787. the actual contents size to history contents size which caused a huge
  1788. black area below the actual contents.
  1789. To fix that, don't restore the contents size from history contents size
  1790. and scroll back to the valid contents area if we are about to overscroll.
  1791. * Api/WebPage.cpp:
  1792. (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
  1793. * Api/WebPage_p.h:
  1794. (WebPagePrivate):
  1795. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1796. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  1797. 2013-03-01 Mike Fenton <mifenton@rim.com>
  1798. [BlackBerry] Improve input bounds clipping for search fields.
  1799. https://bugs.webkit.org/show_bug.cgi?id=111204
  1800. Reviewed by Rob Buis.
  1801. PR 292673.
  1802. Use the standardized InputHandler function to get the
  1803. bounds of an input field so that search fields are
  1804. truncated smaller to account for the X.
  1805. Reviewed Internally by Gen Mak.
  1806. * WebKitSupport/SelectionHandler.cpp:
  1807. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  1808. 2013-03-01 Nima Ghanavatian <nghanavatian@rim.com>
  1809. [BlackBerry] Reverse the base and extent of a selection when reversing its handles
  1810. https://bugs.webkit.org/show_bug.cgi?id=111098
  1811. Reviewed by Yong Li.
  1812. PR283969
  1813. Swap the base and extent if base does not come first, and set the new selection.
  1814. Internally reviewed by Mike Fenton
  1815. * WebKitSupport/SelectionHandler.cpp:
  1816. (BlackBerry::WebKit::SelectionHandler::setSelection):
  1817. 2013-03-01 Alberto Garcia <albgarcia@rim.com>
  1818. Fix definition of DatePickerClient::setValue()
  1819. https://bugs.webkit.org/show_bug.cgi?id=110336
  1820. Reviewed by Carlos Garcia Campos.
  1821. The definition of DatePickerClient::setValue() introduced in
  1822. r142987 does not match the prototype.
  1823. * WebCoreSupport/DatePickerClient.cpp:
  1824. (WebCore::DatePickerClient::setValue):
  1825. 2013-02-28 Mike Fenton <mifenton@rim.com>
  1826. [BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
  1827. https://bugs.webkit.org/show_bug.cgi?id=111078
  1828. Reviewed by Yong Li.
  1829. PR 295224.
  1830. When using the key navigation to modify the selection, reset the
  1831. directionality of the selection to the original to prevent
  1832. changing the anchor.
  1833. Reviewed Internally by Nima Ghanavatian.
  1834. * WebKitSupport/SelectionHandler.cpp:
  1835. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  1836. 2013-02-28 Lianghui Chen <liachen@rim.com>
  1837. [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
  1838. https://bugs.webkit.org/show_bug.cgi?id=111006
  1839. Internal PR: 295181
  1840. Internal reviewed by Joe Mason.
  1841. Reviewed by Yong Li.
  1842. Check WebSettings::isFormAutofillEnabled() before doing user credential form fill stuff.
  1843. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1844. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  1845. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  1846. 2013-02-28 Alberto Garcia <albgarcia@rim.com>
  1847. [BlackBerry] Misc build fixes
  1848. https://bugs.webkit.org/show_bug.cgi?id=110448
  1849. Reviewed by Rob Buis.
  1850. * Api/WebPage.cpp:
  1851. (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
  1852. WebString was replaced with BlackBerry::Platform::String in r131316.
  1853. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  1854. Some webdatabase APIs are encapuslated in DatabaseManager since r137520.
  1855. (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
  1856. Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844.
  1857. * WebKitSupport/InputHandler.cpp:
  1858. (BlackBerry::WebKit::InputHandler::updateFormState):
  1859. Add closing brace that was missing in r142482.
  1860. 2013-02-28 Xan Lopez <xlopez@rim.com>
  1861. [BlackBerry] DumpRenderTreeSupport: update the set position methods
  1862. https://bugs.webkit.org/show_bug.cgi?id=110578
  1863. Reviewed by Rob Buis.
  1864. TestRunner::setMockGeolocationPosition() changed in r130416:
  1865. http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
  1866. * WebKitSupport/DumpRenderTreeSupport.cpp:
  1867. (DumpRenderTreeSupport::setMockGeolocationPosition):
  1868. * WebKitSupport/DumpRenderTreeSupport.h:
  1869. (DumpRenderTreeSupport):
  1870. 2013-02-27 Andrew Lo <anlo@rim.com>
  1871. [BlackBerry] Need WebPage API for animating scroll position & zoom changes
  1872. https://bugs.webkit.org/show_bug.cgi?id=110912
  1873. Reviewed by Rob Buis.
  1874. Internally reviewed by Jakob Petsovits.
  1875. Internal PR 285468.
  1876. Add an API to WebPage for animated scroll position & zoom level
  1877. adjustments.
  1878. Have InputHandler use the new API.
  1879. Rename some variables to reflect the fact that they are not only
  1880. used by block zoom now.
  1881. * Api/WebPage.cpp:
  1882. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  1883. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  1884. (BlackBerry::WebKit::WebPage::blockZoom):
  1885. (BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
  1886. (WebKit):
  1887. (BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
  1888. * Api/WebPage.h:
  1889. * Api/WebPage_p.h:
  1890. (WebPagePrivate):
  1891. * WebKitSupport/InputHandler.cpp:
  1892. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  1893. 2013-02-27 Lianghui Chen <liachen@rim.com>
  1894. [BlackBerry] User credentials is not correctly handled
  1895. https://bugs.webkit.org/show_bug.cgi?id=110994
  1896. Reviewed by Yong Li.
  1897. Following change are made:
  1898. Remove url from CredentialTransformData, as url is not used anymore.
  1899. Adapt to updated CredentialBackingStore API about removing url.
  1900. * Api/WebPage.cpp:
  1901. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  1902. * WebCoreSupport/CredentialManager.cpp:
  1903. (WebCore::CredentialManager::autofillPasswordForms):
  1904. (WebCore::CredentialManager::saveCredentialIfConfirmed):
  1905. * WebCoreSupport/CredentialTransformData.cpp:
  1906. (WebCore::CredentialTransformData::CredentialTransformData):
  1907. * WebCoreSupport/CredentialTransformData.h:
  1908. (CredentialTransformData):
  1909. 2013-02-27 John Griggs <jgriggs@rim.com>
  1910. 2013-02-27 John Griggs <jgriggs@rim.com>
  1911. Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
  1912. https://bugs.webkit.org/show_bug.cgi?id=110905
  1913. Reviewed by Yong Li.
  1914. Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
  1915. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  1916. (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
  1917. 2013-02-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  1918. [BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
  1919. https://bugs.webkit.org/show_bug.cgi?id=110860
  1920. Reviewed by Yong Li.
  1921. PR 290248 Internally reviewed by Mike Fenton
  1922. Add a parameter to notify the webpage client which parts of selection have
  1923. changed in visual or in its selected DOM content. Refactor the selection details
  1924. parameter to platform repo.
  1925. The reason of this issue is that when javascript triggers webpage layout, the selection
  1926. will update its apperance event when the selected content is not changed. We want
  1927. to hide the context menu only when the selected content is changed not when only its
  1928. visual is changed.
  1929. * Api/WebPageClient.h:
  1930. (Platform):
  1931. * WebKitSupport/SelectionHandler.cpp:
  1932. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  1933. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  1934. * WebKitSupport/SelectionHandler.h:
  1935. (SelectionHandler):
  1936. 2013-02-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  1937. [BlackBerry] The virtual keyboard hides part of Signing In dialog
  1938. https://bugs.webkit.org/show_bug.cgi?id=110836
  1939. Reviewed by Yong Li.
  1940. PR # 283427 Internally reviewed by Mike Fenton.
  1941. Store form credentials before javascript "onSubmit" event and notify
  1942. webpage client to save credentials after that event since javascript
  1943. may check credentials and stop the submission in its event handler.
  1944. * WebCoreSupport/CredentialTransformData.cpp:
  1945. (WebCore::CredentialTransformData::CredentialTransformData):
  1946. (WebCore):
  1947. * WebCoreSupport/CredentialTransformData.h:
  1948. (CredentialTransformData):
  1949. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  1950. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
  1951. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  1952. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  1953. (FrameLoaderClientBlackBerry):
  1954. 2013-02-27 Mike Fenton <mifenton@rim.com>
  1955. [BlackBerry] Accept key events even when composing region is active.
  1956. https://bugs.webkit.org/show_bug.cgi?id=110617
  1957. Reviewed by Rob Buis.
  1958. PR 293598.
  1959. Fix a regression in the previous patch caused
  1960. by an unhandled Alt key down being sent through
  1961. by IMF.
  1962. Reviewed Internally by Nima Ghanavatian.
  1963. * WebKitSupport/InputHandler.cpp:
  1964. (BlackBerry::WebKit::InputHandler::updateFormState):
  1965. * WebKitSupport/InputHandler.h:
  1966. (InputHandler):
  1967. 2013-02-26 Yong Li <yoli@rim.com>
  1968. [BlackBerry] Use APIEntryShim when making JS call
  1969. https://bugs.webkit.org/show_bug.cgi?id=110787
  1970. Reviewed by Rob Buis.
  1971. PR# 301451.
  1972. Use APIEntryShim to fix an assert and ensure it is thread-safe.
  1973. * Api/WebPage.cpp:
  1974. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  1975. 2013-02-26 Alberto Garcia <agarcia@igalia.com>
  1976. [BlackBerry] Upstream the datalist support UI
  1977. https://bugs.webkit.org/show_bug.cgi?id=110736
  1978. Reviewed by Rob Buis.
  1979. Original code by Otto Derek Cheung <otcheung@rim.com>
  1980. * WebCoreSupport/SuggestionBoxElement.cpp: Added.
  1981. (WebCore):
  1982. (WebCore::SuggestionBoxElement::SuggestionBoxElement):
  1983. (WebCore::SuggestionBoxElement::~SuggestionBoxElement):
  1984. (WebCore::SuggestionBoxElement::create):
  1985. (WebCore::SuggestionBoxElement::defaultEventHandler):
  1986. * WebCoreSupport/SuggestionBoxElement.h: Added.
  1987. (WebCore):
  1988. (SuggestionBoxElement):
  1989. * WebCoreSupport/SuggestionBoxHandler.cpp: Added.
  1990. (WebCore):
  1991. (WebCore::SuggestionBoxHandler::SuggestionBoxHandler):
  1992. (WebCore::SuggestionBoxHandler::~SuggestionBoxHandler):
  1993. (WebCore::SuggestionBoxHandler::create):
  1994. (WebCore::SuggestionBoxHandler::setInputElementAndUpdateDisplay):
  1995. (WebCore::SuggestionBoxHandler::showDropdownBox):
  1996. (WebCore::SuggestionBoxHandler::hideDropdownBox):
  1997. (WebCore::SuggestionBoxHandler::changeInputElementInnerTextValue):
  1998. (WebCore::SuggestionBoxHandler::parseSuggestions):
  1999. (WebCore::SuggestionBoxHandler::insertSuggestionsToDropdownBox):
  2000. (WebCore::adjustDropdownBoxPosition):
  2001. (WebCore::SuggestionBoxHandler::buildDropdownBoxTree):
  2002. * WebCoreSupport/SuggestionBoxHandler.h: Added.
  2003. (WebCore):
  2004. (SuggestionBoxHandler):
  2005. (WebCore::SuggestionBoxHandler::focusedElement):
  2006. * WebKitSupport/InputHandler.cpp:
  2007. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  2008. (BlackBerry::WebKit::InputHandler::updateFormState):
  2009. * WebKitSupport/InputHandler.h:
  2010. (WebCore):
  2011. (InputHandler):
  2012. * WebKitSupport/TouchEventHandler.cpp:
  2013. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  2014. 2013-02-25 Yongxin Dai <yodai@rim.com>
  2015. [BlackBerry] Add isInputMode() method to WebPage class.
  2016. https://bugs.webkit.org/show_bug.cgi?id=110754
  2017. Reviewed by Rob Buis.
  2018. PR #262569.
  2019. There is a case we need to know if the active node is content editable
  2020. from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
  2021. InputHandler::isInputMode().
  2022. Reviewed Internally by Mike Fenton.
  2023. * Api/WebPage.cpp:
  2024. (BlackBerry::WebKit::WebPage::isInputMode):
  2025. (WebKit):
  2026. * Api/WebPage.h:
  2027. 2013-02-25 Mike Fenton <mifenton@rim.com>
  2028. [BlackBerry] Force form submission when implicit submission fails.
  2029. https://bugs.webkit.org/show_bug.cgi?id=110627
  2030. Reviewed by Rob Buis.
  2031. PR 286023.
  2032. When implicit form submission does not submit the form
  2033. do a direct submission of the form.
  2034. Reviewed Internally by Nima Ghanavatian.
  2035. * WebKitSupport/InputHandler.cpp:
  2036. (BlackBerry::WebKit::InputHandler::updateFormState):
  2037. 2013-02-25 Tiancheng Jiang <tijiang@rim.com>
  2038. [BlackBerry]Adjust fatfinger detection rect size.
  2039. https://bugs.webkit.org/show_bug.cgi?id=108678
  2040. Reviewed by Rob Buis.
  2041. Fix a typo in function names.
  2042. * WebKitSupport/FatFingers.cpp:
  2043. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  2044. 2013-02-25 Alberto Garcia <albgarcia@rim.com>
  2045. [BlackBerry] ChromeClientBlackBerry: fix variable names
  2046. https://bugs.webkit.org/show_bug.cgi?id=110562
  2047. Reviewed by Rob Buis.
  2048. manager was incorrectly renamed back to tracker in r138696:
  2049. http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
  2050. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  2051. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  2052. 2013-02-24 Alberto Garcia <albgarcia@rim.com>
  2053. [BlackBerry] GeolocationClientBlackBerry: add missing headers
  2054. https://bugs.webkit.org/show_bug.cgi?id=110563
  2055. Reviewed by Benjamin Poulain.
  2056. Frame.h and SecurityOrigin.h are necessary since r136969.
  2057. GeolocationPosition.h since r132360.
  2058. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  2059. 2013-02-24 Alberto Garcia <albgarcia@rim.com>
  2060. [BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
  2061. https://bugs.webkit.org/show_bug.cgi?id=110570
  2062. Reviewed by Allan Sandfeld Jensen.
  2063. HitTestResult is no longer a HitTestLocation:
  2064. http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h
  2065. * WebKitSupport/FatFingers.cpp:
  2066. (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
  2067. 2013-02-22 Mike Fenton <mifenton@rim.com>
  2068. [BlackBerry] Eliminate invalid clipping for content editable selections
  2069. https://bugs.webkit.org/show_bug.cgi?id=110630
  2070. Reviewed by Rob Buis.
  2071. PR 284629.
  2072. Remove selection clipping for content editable
  2073. fields as the bounds aren't valid and cause
  2074. clipping based on starting node rather than the
  2075. union of nodes.
  2076. Reviewed Internally by Nima Ghanavatian.
  2077. * WebKitSupport/InputHandler.cpp:
  2078. (BlackBerry::WebKit::InputHandler::updateFormState):
  2079. * WebKitSupport/SelectionHandler.cpp:
  2080. (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
  2081. 2013-02-22 Tiancheng Jiang <tijiang@rim.com>
  2082. [BlackBerry]Adjust fatfinger detection rect size
  2083. https://bugs.webkit.org/show_bug.cgi?id=108678.
  2084. Reviewed by Antonio Gomes.
  2085. Changing HitTestRequest::IgnoreClipping does not solve the problem that
  2086. FatFinger rect detect the element out of the viewport. We have to clip
  2087. the fatfinger rect according to the current viewport size to avoid picking
  2088. the element out of the viewport.
  2089. * WebKitSupport/FatFingers.cpp:
  2090. (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
  2091. (BlackBerry::WebKit::FatFingers::findBestPoint):
  2092. (BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
  2093. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  2094. * WebKitSupport/FatFingers.h:
  2095. 2013-02-22 Mike Fenton <mifenton@rim.com>
  2096. [BlackBerry] Accept key events even when composing region is active.
  2097. https://bugs.webkit.org/show_bug.cgi?id=110617
  2098. Reviewed by Rob Buis.
  2099. PR 293598.
  2100. Don't reject key events that arrive when composing region is active,
  2101. this can prevent navigation events from firing, instead end
  2102. the composition and process the key.
  2103. Reviewed Internally by Nima Ghanavatian.
  2104. * WebKitSupport/InputHandler.cpp:
  2105. (BlackBerry::WebKit::InputHandler::updateFormState):
  2106. 2013-02-22 Carlos Garcia Campos <cargarcia@rim.com>
  2107. [BlackBerry] Rename first/second to key/value in HashMap iterators
  2108. https://bugs.webkit.org/show_bug.cgi?id=110577
  2109. Reviewed by Rob Buis.
  2110. Iterators were renamed to key/value in r130612.
  2111. * WebKitSupport/NotificationManager.cpp:
  2112. (BlackBerry::WebKit::NotificationManager::show):
  2113. (BlackBerry::WebKit::NotificationManager::clearNotifications):
  2114. (BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):
  2115. 2013-02-22 Carlos Garcia Campos <cargarcia@rim.com>
  2116. [BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
  2117. https://bugs.webkit.org/show_bug.cgi?id=110567
  2118. Reviewed by Rob Buis.
  2119. They were removed from ChromeClient in r122810 and are now
  2120. implemented in NavigatorContentUtilsClientBlackBerry since r131056.
  2121. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  2122. * WebCoreSupport/ChromeClientBlackBerry.h:
  2123. (ChromeClientBlackBerry):
  2124. 2013-02-22 Xan Lopez <xlopez@rim.com>
  2125. [BlackBerry] DomSupport: use NodeTraversal APIs
  2126. https://bugs.webkit.org/show_bug.cgi?id=110467
  2127. Reviewed by Antonio Gomes.
  2128. * WebKitSupport/DOMSupport.cpp:
  2129. (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
  2130. 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
  2131. Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
  2132. https://bugs.webkit.org/show_bug.cgi?id=110208
  2133. Reviewed by Hajime Morrita.
  2134. * WebKitSupport/InputHandler.cpp:
  2135. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  2136. Extract the request data as it is the member of 'TextCheckingRequest'.
  2137. 2013-02-21 Andrew Lo <anlo@rim.com>
  2138. [BlackBerry] WebPagePrivate::load should not check new window policy
  2139. https://bugs.webkit.org/show_bug.cgi?id=110403
  2140. Reviewed by Rob Buis.
  2141. Based on my understanding of changeset 135952, we should
  2142. not check the new window policy in WebPagePrivate::load.
  2143. None of the other ports seem to do this, except for plugins.
  2144. * Api/WebPage.cpp:
  2145. (BlackBerry::WebKit::WebPagePrivate::load):
  2146. 2013-02-21 Alberto Garcia <albgarcia@rim.com>
  2147. [BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
  2148. https://bugs.webkit.org/show_bug.cgi?id=110460
  2149. Reviewed by Rob Buis.
  2150. This was renamed incorrectly in r142879.
  2151. * Api/BackingStore.cpp:
  2152. (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
  2153. (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
  2154. 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
  2155. [BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
  2156. https://bugs.webkit.org/show_bug.cgi?id=110451
  2157. Reviewed by Rob Buis.
  2158. Remove the extra ResourceRequest parameter from
  2159. FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.
  2160. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  2161. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  2162. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  2163. (FrameLoaderClientBlackBerry):
  2164. 2013-02-21 Xan Lopez <xlopez@rim.com>
  2165. [BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
  2166. https://bugs.webkit.org/show_bug.cgi?id=110469
  2167. Reviewed by Rob Buis.
  2168. This changed in r134765.
  2169. * Api/WebViewportArguments.cpp:
  2170. (BlackBerry::WebKit::WebViewportArguments::zoom):
  2171. (BlackBerry::WebKit::WebViewportArguments::setZoom):
  2172. (BlackBerry::WebKit::WebViewportArguments::minZoom):
  2173. (BlackBerry::WebKit::WebViewportArguments::setMinZoom):
  2174. (BlackBerry::WebKit::WebViewportArguments::maxZoom):
  2175. (BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
  2176. (BlackBerry::WebKit::WebViewportArguments::userZoom):
  2177. (BlackBerry::WebKit::WebViewportArguments::setUserZoom):
  2178. * Api/WebViewportArguments.h:
  2179. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  2180. (WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):
  2181. 2013-02-21 Jakob Petsovits <jpetsovits@rim.com>
  2182. [BlackBerry] Move posting and scrollbar updates to the page client.
  2183. https://bugs.webkit.org/show_bug.cgi?id=110256
  2184. Internal PR 297099
  2185. Reviewed by Rob Buis.
  2186. In blitVisibleContents(), we were calling the WebKit thread
  2187. functions BackingStorePrivate::isScrollingOrZooming() and
  2188. WebPage::isVisible(). This is not the right spot to do it.
  2189. Furthermore, we want to move away from direct window access
  2190. in WebKit and leave that kind of dirtywork to the client.
  2191. This patch removes invalidateWindow() as well as the two
  2192. virtual scrollbar drawing functions and replaces it with
  2193. one new virtual, WebPageClient::postToSurface().
  2194. This clears up threading issues and gets us another step
  2195. further towards pure WebPageCompositor rendering.
  2196. * Api/BackingStore.cpp:
  2197. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  2198. * Api/BackingStore_p.h:
  2199. (BackingStorePrivate):
  2200. * Api/WebPageClient.h:
  2201. 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
  2202. [BlackBerry] Rename Localizer to Locale
  2203. https://bugs.webkit.org/show_bug.cgi?id=110449
  2204. Reviewed by Rob Buis.
  2205. * WebCoreSupport/ColorPickerClient.cpp:
  2206. (WebCore::ColorPickerClient::locale):
  2207. * WebCoreSupport/ColorPickerClient.h:
  2208. (ColorPickerClient):
  2209. * WebCoreSupport/DatePickerClient.cpp:
  2210. (WebCore::DatePickerClient::locale):
  2211. * WebCoreSupport/DatePickerClient.h:
  2212. (DatePickerClient):
  2213. * WebCoreSupport/SelectPopupClient.cpp:
  2214. (WebCore::SelectPopupClient::locale):
  2215. * WebCoreSupport/SelectPopupClient.h:
  2216. (SelectPopupClient):
  2217. 2013-02-21 Carlos Garcia Campos <cargarcia@rim.com>
  2218. [BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
  2219. https://bugs.webkit.org/show_bug.cgi?id=110437
  2220. Reviewed by Yong Li.
  2221. * Api/WebKitTextCodec.cpp:
  2222. (WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
  2223. check enum values match between WebKit and WTF.
  2224. (BlackBerry::WebKit::base64Decode): Use a static cast directly to
  2225. convert from WebKit Base64DecodePolicy to WTF.
  2226. (BlackBerry::WebKit::base64Encode): Use a static cast directly to
  2227. convert from WebKit Base64EncodePolicy to WTF.
  2228. 2013-02-21 Alberto Garcia <albgarcia@rim.com>
  2229. [BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
  2230. https://bugs.webkit.org/show_bug.cgi?id=110439
  2231. Reviewed by Antonio Gomes.
  2232. This was changed in r142827.
  2233. * Api/WebPage.cpp:
  2234. (BlackBerry::WebKit::WebPagePrivate::webContext):
  2235. 2013-02-21 Alberto Garcia <albgarcia@rim.com>
  2236. [BlackBerry] willComposite() and didComposite() are now in InspectorController
  2237. https://bugs.webkit.org/show_bug.cgi?id=110343
  2238. Reviewed by Carlos Garcia Campos.
  2239. This was changed in r142879.
  2240. * Api/WebPage.cpp:
  2241. (BlackBerry::WebKit::WebPagePrivate::willComposite):
  2242. (BlackBerry::WebKit::WebPagePrivate::didComposite):
  2243. 2013-02-20 Nima Ghanavatian <nghanavatian@rim.com>
  2244. [BlackBerry] Check offset for initialized value
  2245. https://bugs.webkit.org/show_bug.cgi?id=110390
  2246. Reviewed by Rob Buis.
  2247. Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
  2248. for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
  2249. triggers the restore from cache in requestSpellingCheckingOptions.
  2250. Internally reviewed by Gen Mak.
  2251. * WebKitSupport/InputHandler.cpp:
  2252. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  2253. 2013-02-20 Jakob Petsovits <jpetsovits@rim.com>
  2254. [BlackBerry] Make sure to always sync before reusing backingstore tiles.
  2255. https://bugs.webkit.org/show_bug.cgi?id=109863
  2256. PR 296118
  2257. Reviewed by Rob Buis.
  2258. Internally reviewed by Mike Lattanzio and Konrad Piascik.
  2259. In SVN r142137, I replaced a syncToCurrentMessage() call
  2260. with updateSuspendScreenUpdateState() in some cases,
  2261. which internally calls the same function.
  2262. Unfortunately, when I optimized updateSuspendScreenUpdateState()
  2263. to only sync when the state is actually being changed,
  2264. I omitted an adaptation of adoptAsFrontState() which would
  2265. rely on this sync but now didn't always perform it.
  2266. This caused a bad race condition as tile buffers could now
  2267. be accessed from the WebKit thread and the UI thread at
  2268. the same time. Fix it by (optionally) letting the caller
  2269. of updateSuspendScreenUpdateState() know whether a sync
  2270. was performed, and adapt adoptAsFrontState() accordingly.
  2271. Also fixes some excessive flicker caused by the same
  2272. race condition.
  2273. * Api/BackingStore.cpp:
  2274. (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
  2275. (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
  2276. * Api/BackingStore_p.h:
  2277. 2013-02-20 Yongxin Dai <yodai@rim.com>
  2278. [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
  2279. https://bugs.webkit.org/show_bug.cgi?id=110235
  2280. Reviewed by Yong Li.
  2281. PR #257207.
  2282. Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
  2283. with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
  2284. is specified in the element, the selection handle is always flipped to the required position.
  2285. along with selected text within element.
  2286. Reviewed Internally by Mike Fenton.
  2287. * Api/WebPageClient.h:
  2288. * WebKitSupport/DOMSupport.cpp:
  2289. (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
  2290. (DOMSupport):
  2291. (BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):
  2292. * WebKitSupport/DOMSupport.h:
  2293. * WebKitSupport/SelectionHandler.cpp:
  2294. (BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
  2295. (WebKit):
  2296. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  2297. * WebKitSupport/SelectionHandler.h:
  2298. (SelectionHandler):
  2299. 2013-02-20 Alberto Garcia <albgarcia@rim.com>
  2300. [BlackBerry] Fix usage of HitTestRequest::RequestType
  2301. https://bugs.webkit.org/show_bug.cgi?id=110342
  2302. Reviewed by Carlos Garcia Campos.
  2303. Rename HitTestResult::* -> HitTestRequest::*
  2304. This was introduced by mistake in r142977.
  2305. * Api/WebPage.cpp:
  2306. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  2307. 2013-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
  2308. Unreviewed BlackBerry build fix.
  2309. WebPage::download was renamed in the header by mistake to
  2310. convertMainResourceLoadToDownload in r137845.
  2311. * Api/WebPage.h:
  2312. 2013-02-19 Nima Ghanavatian <nghanavatian@rim.com>
  2313. [BlackBerry] Appropriately handle word wrapping in SpellingHandler
  2314. https://bugs.webkit.org/show_bug.cgi?id=110253
  2315. Reviewed by Rob Buis.
  2316. PR286001
  2317. Since we traverse through text by visual lines instead of blocks, word wrapping causes some
  2318. bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
  2319. mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
  2320. processing to continue. This gives priority to user actions while still completing a large
  2321. paragraph in a reasonable amount of time.
  2322. Internally reviewed by Mike Fenton
  2323. * WebKitSupport/InputHandler.cpp:
  2324. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  2325. * WebKitSupport/SpellingHandler.cpp:
  2326. (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
  2327. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  2328. (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
  2329. (BlackBerry::WebKit::SpellingHandler::startOfNextWord):
  2330. (WebKit):
  2331. (BlackBerry::WebKit::SpellingHandler::incrementByWord):
  2332. (BlackBerry::WebKit::SpellingHandler::doesWordWrap):
  2333. * WebKitSupport/SpellingHandler.h:
  2334. (SpellingHandler):
  2335. 2013-02-18 Simon Fraser <simon.fraser@apple.com>
  2336. Clean up the boolean argument to visibleContentRect
  2337. https://bugs.webkit.org/show_bug.cgi?id=110167
  2338. Reviewed by Simon Fraser.
  2339. Replace the boolean argument to visibleContentRect() with
  2340. an enum.
  2341. * Api/WebPage.cpp:
  2342. (BlackBerry::WebKit::WebPagePrivate::getRecursiveVisibleWindowRect):
  2343. * WebKitSupport/InRegionScrollableArea.cpp:
  2344. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  2345. 2013-02-15 Keishi Hattori <keishi@webkit.org>
  2346. Add setValue and closePopup methods to PagePopupController
  2347. https://bugs.webkit.org/show_bug.cgi?id=109897
  2348. Reviewed by Kent Tamura.
  2349. * WebCoreSupport/ColorPickerClient.cpp:
  2350. (WebCore::ColorPickerClient::setValue): Added empty implementation.
  2351. (WebCore):
  2352. * WebCoreSupport/ColorPickerClient.h:
  2353. (ColorPickerClient):
  2354. * WebCoreSupport/DatePickerClient.cpp:
  2355. (WebCore::DatePickerClient::setValue): Ditto.
  2356. (WebCore):
  2357. * WebCoreSupport/DatePickerClient.h:
  2358. (DatePickerClient):
  2359. * WebCoreSupport/SelectPopupClient.cpp:
  2360. (WebCore::SelectPopupClient::setValue): Ditto.
  2361. (WebCore):
  2362. * WebCoreSupport/SelectPopupClient.h:
  2363. (SelectPopupClient):
  2364. 2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
  2365. Simplify hitTestResultAtPoint and nodesFromRect APIs
  2366. https://bugs.webkit.org/show_bug.cgi?id=95720
  2367. Reviewed by Julien Chaffraix.
  2368. Update calls to new API.
  2369. * Api/WebPage.cpp:
  2370. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  2371. (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
  2372. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  2373. (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
  2374. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  2375. * WebKitSupport/SelectionHandler.cpp:
  2376. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  2377. 2013-02-14 Mike Fenton <mifenton@rim.com>
  2378. [BlackBerry] Update keyboard event details to match platform details.
  2379. https://bugs.webkit.org/show_bug.cgi?id=109693
  2380. Reviewed by Yong Li.
  2381. PR 220170.
  2382. When re-creating the Platform::Keyboard event ensure
  2383. all values are updated.
  2384. Reviewed Internally by Nima Ghanavatian.
  2385. * WebKitSupport/InputHandler.cpp:
  2386. (BlackBerry::WebKit::InputHandler::updateFormState):
  2387. 2013-02-14 Mike Fenton <mifenton@rim.com>
  2388. [BlackBerry] Update keyboard event details to match platform details.
  2389. https://bugs.webkit.org/show_bug.cgi?id=109693
  2390. Reviewed by Yong Li.
  2391. PR 220170.
  2392. Update keyboard event details.
  2393. Reviewed Internally by Nima Ghanavatian and Gen Mak.
  2394. * Api/WebPage.cpp:
  2395. (BlackBerry::WebKit::WebPage::keyEvent):
  2396. 2013-02-08 Andrey Kosyakov <caseq@chromium.org>
  2397. Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
  2398. https://bugs.webkit.org/show_bug.cgi?id=109192
  2399. Reviewed by Pavel Feldman.
  2400. - invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.
  2401. * Api/BackingStore.cpp:
  2402. (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
  2403. (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
  2404. 2013-02-12 Jakob Petsovits <jpetsovits@rim.com>
  2405. [BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
  2406. https://bugs.webkit.org/show_bug.cgi?id=109614
  2407. Internal PR 294513
  2408. Reviewed by Rob Buis.
  2409. Internally reviewed by Arvid Nilsson.
  2410. With this further simplification of threading assumptions,
  2411. we can get rid of atomic integer access as well as the
  2412. backing store mutex which was otherwise unused.
  2413. * Api/BackingStore.cpp:
  2414. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  2415. (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
  2416. (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
  2417. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  2418. (BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
  2419. (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
  2420. * Api/BackingStore_p.h:
  2421. (BackingStorePrivate):
  2422. 2013-02-12 Jakob Petsovits <jpetsovits@rim.com>
  2423. [BlackBerry] Eliminate the direct rendering option.
  2424. https://bugs.webkit.org/show_bug.cgi?id=109608
  2425. RIM PR 293298
  2426. Reviewed by Rob Buis.
  2427. Internally reviewed by Arvid Nilsson.
  2428. It added a lot of complexity and we're not going to use it anymore.
  2429. This patch removes direct rendering functionality from
  2430. WebKit/blackberry together with the assumption that blitting on the
  2431. WebKit thread is possible or acceptable. It now isn't anymore.
  2432. * Api/BackingStore.cpp:
  2433. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  2434. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  2435. (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
  2436. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  2437. (BlackBerry::WebKit::BackingStorePrivate::scroll):
  2438. (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
  2439. (BlackBerry::WebKit::BackingStorePrivate::render):
  2440. (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
  2441. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  2442. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  2443. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  2444. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  2445. (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
  2446. (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
  2447. (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
  2448. * Api/BackingStore.h:
  2449. * Api/BackingStore_p.h:
  2450. (BackingStorePrivate):
  2451. * Api/WebPage.cpp:
  2452. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  2453. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  2454. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  2455. (WebKit):
  2456. (BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
  2457. * Api/WebPageCompositor.cpp:
  2458. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
  2459. * Api/WebPage_p.h:
  2460. (WebPagePrivate):
  2461. * Api/WebSettings.cpp:
  2462. (WebKit):
  2463. * Api/WebSettings.h:
  2464. * WebKitSupport/RenderQueue.cpp:
  2465. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
  2466. (BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):
  2467. * WebKitSupport/SurfacePool.cpp:
  2468. (BlackBerry::WebKit::SurfacePool::initialize):
  2469. 2013-02-12 Andrew Lo <anlo@rim.com>
  2470. [BlackBerry] CSS animations stop running during zoom
  2471. https://bugs.webkit.org/show_bug.cgi?id=109606
  2472. Reviewed by Rob Buis.
  2473. Internally reviewed by Jakob Petsovits.
  2474. Internal PR 286160.
  2475. New BackingStore API for suspending/resuming geometry updates.
  2476. This is needed because we want to allow render jobs to continue during
  2477. zoom, but we don't want to allow geometry updates during zoom.
  2478. Prevent scroll/zoom render jobs from being added to the queue if
  2479. the tile is outside the expanded content rect.
  2480. * Api/BackingStore.cpp:
  2481. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  2482. (BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
  2483. (WebKit):
  2484. (BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
  2485. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  2486. (BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
  2487. (BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):
  2488. * Api/BackingStore.h:
  2489. * Api/BackingStore_p.h:
  2490. (BackingStorePrivate):
  2491. * WebKitSupport/RenderQueue.cpp:
  2492. (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
  2493. 2013-02-12 Christophe Dumez <ch.dumez@sisa.samsung.com>
  2494. Remove remaining traces of Web Intents
  2495. https://bugs.webkit.org/show_bug.cgi?id=109586
  2496. Reviewed by Eric Seidel.
  2497. Remove remaining traces of Web Intents from Blackberry port
  2498. configuration as the functionality was removed in r142549.
  2499. * WebCoreSupport/AboutDataEnableFeatures.in:
  2500. 2013-02-12 Zan Dobersek <zdobersek@igalia.com>
  2501. Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
  2502. https://bugs.webkit.org/show_bug.cgi?id=109481
  2503. Reviewed by Daniel Bates.
  2504. The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
  2505. back in r120574. There are still occurrences of it in various build systems
  2506. which should all be removed as they are useless.
  2507. * WebCoreSupport/AboutDataEnableFeatures.in:
  2508. 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
  2509. Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
  2510. https://bugs.webkit.org/show_bug.cgi?id=109534
  2511. Reviewed by Anders Carlsson.
  2512. * WebCoreSupport/EditorClientBlackBerry.cpp:
  2513. (WebCore):
  2514. * WebCoreSupport/EditorClientBlackBerry.h:
  2515. (EditorClientBlackBerry):
  2516. 2013-02-11 Mike Fenton <mifenton@rim.com>
  2517. [BlackBerry] Add form navigation control state tracking.
  2518. https://bugs.webkit.org/show_bug.cgi?id=109300
  2519. Reviewed by Rob Buis.
  2520. Add form navigation control state tracking.
  2521. * Api/WebPage.cpp:
  2522. (BlackBerry::WebKit::WebPage::focusNextField):
  2523. (WebKit):
  2524. (BlackBerry::WebKit::WebPage::focusPreviousField):
  2525. (BlackBerry::WebKit::WebPage::submitForm):
  2526. * Api/WebPage.h:
  2527. * Api/WebPageClient.h:
  2528. * WebKitSupport/InputHandler.cpp:
  2529. (BlackBerry::WebKit::InputHandler::InputHandler):
  2530. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  2531. (BlackBerry::WebKit::InputHandler::updateFormState):
  2532. * WebKitSupport/InputHandler.h:
  2533. (InputHandler):
  2534. 2013-02-09 Tiancheng Jiang <tijiang@rim.com>
  2535. [BlackBerry] Set mouse document position for mouse event in updateCursor.
  2536. https://bugs.webkit.org/show_bug.cgi?id=109094.
  2537. Reviewed by Rob Buis.
  2538. RIM PR 246976
  2539. Internally Reviewed by Genevieve Mak.
  2540. BlackBerry::Platform::MouseEvent have document viewport and document
  2541. content position as members. When we create the event, we should initial
  2542. them as well.
  2543. * Api/WebPage.cpp:
  2544. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  2545. 2013-02-07 Charles Wei <charles.wei@torchmobile.com.cn>
  2546. webpage needs null check in BackingStore::setCurrentBackingStoreOwner
  2547. https://bugs.webkit.org/show_bug.cgi?id=109253
  2548. Reviewed by George Staikos.
  2549. * Api/BackingStore.cpp:
  2550. (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
  2551. 2013-02-07 Mary Wu <mary.wu@torchmobile.com.cn>
  2552. [BlackBerry] Enable non-video element enter/exit fullscreen.
  2553. https://bugs.webkit.org/show_bug.cgi?id=108314
  2554. Reviewed by Antonio Gomes.
  2555. Webkit support non-video element (like div) to enter/exit
  2556. fullscreen. We should pass this capability in blackberry porting.
  2557. RIM PR 256370, internally reviewed by Max Feil.
  2558. * Api/WebPage.cpp:
  2559. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  2560. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
  2561. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  2562. (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
  2563. (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
  2564. (BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
  2565. (WebKit):
  2566. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  2567. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  2568. (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
  2569. * Api/WebPage_p.h:
  2570. (WebPagePrivate):
  2571. 2013-02-07 Jakob Petsovits <jpetsovits@rim.com>
  2572. [BlackBerry] Fix all flicker caused by empty/incomplete geometries.
  2573. https://bugs.webkit.org/show_bug.cgi?id=108951
  2574. RIM PR 286925
  2575. Reviewed by Rob Buis.
  2576. Internally reviewed by Arvid Nilsson.
  2577. The main idea for this patch is that whenever we adopt
  2578. a new backingstore geometry that doesn't contain any
  2579. rendered tiles, or VisibleZoom render jobs that need more
  2580. tiles to be rendered to be considered complete, we'll then
  2581. suspend blitting until there is valid content to show.
  2582. This main idea is codified as checks for empty buffers
  2583. in adoptAsFrontState(), and checks for the current state
  2584. of the render queue after rendering content in render().
  2585. However, as BackingStore objects with disabled surface pools
  2586. or pure use of accelerated compositing also swap geometries
  2587. in some circumstances, the use of suspend counters grows
  2588. increasingly fragile.
  2589. To make this patch more resilient against regressions,
  2590. the current suspend counter is complemented with several
  2591. explicit conditions for suspending screen updates,
  2592. and both subsequently combined into a single cached
  2593. boolean value telling the UI thread whether or not to
  2594. suspend. In the future, other suspend calls can be
  2595. migrated to this "state machine" design as well,
  2596. potentially phasing out the suspend counter altogether.
  2597. The immediate result is that there will be no flashing
  2598. of background color between page loads or after discarding
  2599. tiles on scale changes until the content has been rendered.
  2600. * Api/BackingStore.cpp:
  2601. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  2602. (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
  2603. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
  2604. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  2605. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  2606. (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
  2607. (WebKit):
  2608. (BlackBerry::WebKit::BackingStorePrivate::render):
  2609. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  2610. (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
  2611. (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
  2612. (BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
  2613. * Api/BackingStore_p.h:
  2614. (BackingStorePrivate):
  2615. * Api/WebPage.cpp:
  2616. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  2617. (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
  2618. 2013-02-07 Xiaobo Wang <xbwang@torchmobile.com.cn>
  2619. [BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
  2620. https://bugs.webkit.org/show_bug.cgi?id=109126
  2621. PR 292540
  2622. Reviewed by Yong Li.
  2623. Internally reviewed by Mike Fenton.
  2624. Key char is UTF32 encoded, should be 4 bytes.
  2625. * Api/WebPage.cpp:
  2626. (BlackBerry::WebKit::handleScrolling):
  2627. * WebKitSupport/InputHandler.cpp:
  2628. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  2629. * WebKitSupport/InputHandler.h:
  2630. (InputHandler):
  2631. * WebKitSupport/SelectionHandler.cpp:
  2632. (BlackBerry::WebKit::directionOfPointRelativeToRect):
  2633. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  2634. (BlackBerry::WebKit::shouldExtendSelectionInDirection):
  2635. (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
  2636. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  2637. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  2638. * WebKitSupport/SelectionHandler.h:
  2639. (SelectionHandler):
  2640. 2013-02-07 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  2641. [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
  2642. https://bugs.webkit.org/show_bug.cgi?id=109124
  2643. Reviewed by Yong Li.
  2644. RIM BUG 291246 Internally reviewed by YongLi.
  2645. Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
  2646. into WebPageClientImpl::createWindow() to make it more close to its protecting place.
  2647. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  2648. (WebCore::ChromeClientBlackBerry::createWindow):
  2649. 2013-02-07 Mike Fenton <mifenton@rim.com>
  2650. [BlackBerry] Send type details with IMF mask as part of focus gained.
  2651. https://bugs.webkit.org/show_bug.cgi?id=109086
  2652. Reviewed by Yong Li.
  2653. PR 292609.
  2654. Add masking options based on VKB type to the IMF mask.
  2655. Reviewed Internally by Nima Ghanavatian.
  2656. * WebKitSupport/InputHandler.cpp:
  2657. (BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
  2658. (WebKit):
  2659. (BlackBerry::WebKit::InputHandler::setElementFocused):
  2660. 2013-02-06 Jakob Petsovits <jpetsovits@rim.com>
  2661. [BlackBerry] Refactor renderContents() for cleaner code.
  2662. https://bugs.webkit.org/show_bug.cgi?id=109059
  2663. RIM PR 280374
  2664. Reviewed by Rob Buis.
  2665. Internally reviewed by Arvid Nilsson.
  2666. The fact that we've got two renderContents() implementations
  2667. in BackingStore.cpp, one of which was tailored to just
  2668. being called from drawContents(), is a major annoyance.
  2669. With this patch, the regular renderContents() is modified
  2670. in a way so that drawContents() can make use of it as well.
  2671. This includes an API change for both functions which makes
  2672. it more flexible and enables further cleanups and improvements
  2673. to accuracy. The second, unloved renderContents() is removed.
  2674. The user-visible changes are improved (float) accuracy for
  2675. render offsets, clipping to exactly the dstRect that has
  2676. been specified, and the changed public drawContents() API.
  2677. * Api/BackingStore.cpp:
  2678. (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
  2679. (BlackBerry::WebKit::BackingStorePrivate::render):
  2680. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  2681. (BlackBerry::WebKit::BackingStore::drawContents):
  2682. * Api/BackingStore.h:
  2683. (Platform):
  2684. (Graphics):
  2685. * Api/BackingStore_p.h:
  2686. (WebCore):
  2687. (BackingStorePrivate):
  2688. * WebKitSupport/SurfacePool.cpp:
  2689. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  2690. (BlackBerry::WebKit::SurfacePool::initialize):
  2691. (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
  2692. * WebKitSupport/SurfacePool.h:
  2693. (SurfacePool):
  2694. 2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>
  2695. [BlackBerry] Check range before use in parseBlockForSpellChecking
  2696. https://bugs.webkit.org/show_bug.cgi?id=109080
  2697. Reviewed by Yong Li.
  2698. PR291394
  2699. This was missed during patch webkit/5aea04f6ea625827. Since getRangeForSpellCheckWithFineGranularity
  2700. now returns null values, we need a check here before using the range object here as well.
  2701. Internally reviewed by Mike Fenton.
  2702. * WebKitSupport/SpellingHandler.cpp:
  2703. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  2704. 2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>
  2705. [BlackBerry] Check for a valid range object before using it
  2706. https://bugs.webkit.org/show_bug.cgi?id=109058
  2707. Reviewed by Rob Buis.
  2708. PR291394
  2709. Crash occurs if makeRange returns null, since we are using this value without checking
  2710. its validity. We had an assert before which I'm replacing with just a check for null.
  2711. Internally reviewed by Mike Fenton.
  2712. * WebKitSupport/SpellingHandler.cpp:
  2713. (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
  2714. 2013-02-05 Andrew Lo <anlo@rim.com>
  2715. [BlackBerry] Scrolling performance drops doing page load
  2716. https://bugs.webkit.org/show_bug.cgi?id=108949
  2717. Reviewed by Yong Li.
  2718. Internally reviewed by Jakob Petsovits.
  2719. Internal PR 291390.
  2720. The intention of this code was to not update non-visible tiles during page load.
  2721. Before this patch, the code would update tiles that have already been rendered
  2722. during page load.
  2723. * Api/BackingStore.cpp:
  2724. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  2725. 2013-02-04 Tiancheng Jiang <tijiang@rim.com>
  2726. [BlackBerry]Adjust fatfinger detection rect size
  2727. https://bugs.webkit.org/show_bug.cgi?id=108678
  2728. Reviewed by Antonio Gomes.
  2729. RIM Bug 246976
  2730. We still need to clip the fatfinger detection rect to the viewport to
  2731. avoid wrong hitTest result.
  2732. * Api/WebPage.cpp:
  2733. (BlackBerry::WebKit::WebPage::mouseEvent):
  2734. * WebKitSupport/FatFingers.cpp:
  2735. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  2736. 2013-02-04 Abhishek Arya <inferno@chromium.org>
  2737. Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
  2738. https://bugs.webkit.org/show_bug.cgi?id=108688
  2739. Reviewed by Eric Seidel.
  2740. * Api/WebPage.cpp:
  2741. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  2742. * WebKitSupport/FatFingers.cpp:
  2743. (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
  2744. 2013-02-04 Andrew Lo <anlo@rim.com>
  2745. [BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
  2746. https://bugs.webkit.org/show_bug.cgi?id=108760
  2747. Reviewed by Yong Li.
  2748. Internally reviewed by Arvid Nilsson.
  2749. Internal PR 286218.
  2750. When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
  2751. we need to set the needs one-shot drawing synchronization flag
  2752. before rendering, so that when the render is completed we
  2753. commit the root layer.
  2754. * Api/WebPage.cpp:
  2755. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  2756. 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
  2757. Fix build warning after r141473
  2758. https://bugs.webkit.org/show_bug.cgi?id=108782
  2759. Reviewed by Kentaro Hara.
  2760. Fix -Wunused-parameter build warning.
  2761. * WebCoreSupport/EditorClientBlackBerry.cpp:
  2762. (WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
  2763. 2013-02-01 Jacky Jiang <zhajiang@rim.com>
  2764. [BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
  2765. https://bugs.webkit.org/show_bug.cgi?id=108252
  2766. Reviewed by Yong Li.
  2767. Internally reviewed by Konrad Piascik.
  2768. PR: 284828
  2769. We got float layoutSize(342.284122, 521.448467) and
  2770. m_maximumScale(2.243750) after computing viewport meta based on the
  2771. device pixel ratio and laid out the contents at IntSize(342, 521).
  2772. Therefore, zoomToFitScale(2.245681) would be a bit larger than
  2773. m_maximumScale based on that contents size and resulted in
  2774. maximumScale()!=minimumScale(), which made the non-scalable page
  2775. scalable.
  2776. Return zoomToFitScale for maximumScale() in such kind of case.
  2777. * Api/WebPage.cpp:
  2778. (BlackBerry::WebKit::WebPagePrivate::maximumScale):
  2779. 2013-02-01 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  2780. [BlackBerry] InputHandler status is not restored when page history goes back
  2781. https://bugs.webkit.org/show_bug.cgi?id=108448
  2782. Reviewed by Yong Li.
  2783. PR288406 Internally reviewed by Mike Fenton
  2784. When webpage goes back, it restores the old frame's selection and focused node,
  2785. but we don't save the InputHandler's status, it becomes non-input mode when page
  2786. goes back. When it restores the focus, since the new focus node is same as the old
  2787. document focused node, webcore will not notify client to update the input handler.
  2788. This patch updates the input handler's status by notifying it focus node changed.
  2789. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  2790. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  2791. * WebKitSupport/InputHandler.cpp:
  2792. (BlackBerry::WebKit::InputHandler::restoreViewState):
  2793. (WebKit):
  2794. * WebKitSupport/InputHandler.h:
  2795. (InputHandler):
  2796. 2013-01-31 Jacky Jiang <zhajiang@rim.com>
  2797. [BlackBerry] Bing Images viewport causes layout "fun"
  2798. https://bugs.webkit.org/show_bug.cgi?id=108393
  2799. Reviewed by Yong Li.
  2800. Internally reviewed by Arvid Nilsson and partially reviewed by Konrad Piascik.
  2801. PR: 277855
  2802. Set applyPageScaleFactorInCompositor settting to false by default.
  2803. Scale down chrome window rect to density-independent pixels.
  2804. * Api/WebPage.cpp:
  2805. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  2806. * Api/WebSettings.cpp:
  2807. (WebKit):
  2808. (BlackBerry::WebKit::WebSettings::standardSettings):
  2809. (BlackBerry::WebKit::WebSettings::applyDeviceScaleFactorInCompositor):
  2810. (BlackBerry::WebKit::WebSettings::setApplyPageScaleFactorInCompositor):
  2811. * Api/WebSettings.h:
  2812. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  2813. (WebCore::ChromeClientBlackBerry::windowRect):
  2814. 2013-01-31 Enrica Casucci <enrica@apple.com>
  2815. WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
  2816. https://bugs.webkit.org/show_bug.cgi?id=108396.
  2817. <rdar://problem/12920461>
  2818. Reviewed by Alexey Proskuryakov.
  2819. Adds stub implementation for WebKit of the new EditorClient methods.
  2820. * WebCoreSupport/EditorClientBlackBerry.cpp:
  2821. (WebCore::EditorClientBlackBerry::willWriteSelectionToPasteboard):
  2822. (WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
  2823. * WebCoreSupport/EditorClientBlackBerry.h:
  2824. 2013-01-30 Ed Baker <edbaker@rim.com>
  2825. [BlackBerry] Screenshot is clipped when content is smaller than the desintation size
  2826. https://bugs.webkit.org/show_bug.cgi?id=107735
  2827. Reviewed by Rob Buis.
  2828. Internal PR #284662
  2829. Don't scale the transformed content rect when the content is smaller than the destination
  2830. size. Scale the graphics context when it has a scale factor that isn't 1.0.
  2831. Internally reviewed by Andrew Lo
  2832. * Api/BackingStore.cpp:
  2833. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  2834. 2013-01-30 Xiaobo Wang <xbwang@torchmobile.com.cn>
  2835. [BlackBerry] Webpage was cut off after rotating to landscape and then rotating back to portrait on specific website
  2836. https://bugs.webkit.org/show_bug.cgi?id=108281
  2837. PR 284985
  2838. Reviewed by Rob Buis.
  2839. Internally reviewed by Jacky Jiang.
  2840. Return correct fixedLayoutSize when overflow exceeds contents size.
  2841. * Api/WebPage.cpp:
  2842. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  2843. 2013-01-30 Simon Hausmann <simon.hausmann@digia.com>
  2844. [Qt] Remove QT4_UNICODE related code paths
  2845. https://bugs.webkit.org/show_bug.cgi?id=108316
  2846. Reviewed by Kenneth Rohde Christiansen.
  2847. * WebCoreSupport/AboutDataUseFeatures.in: The feature macro has been removed.
  2848. 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
  2849. Unreviewed, rolling out r140983.
  2850. http://trac.webkit.org/changeset/140983
  2851. https://bugs.webkit.org/show_bug.cgi?id=108277
  2852. Unfortunately, this API has one last client (Requested by
  2853. abarth on #webkit).
  2854. * WebCoreSupport/AboutDataEnableFeatures.in:
  2855. 2013-01-28 Andrew Lo <anlo@rim.com>
  2856. [BlackBerry] Small animated zoom level adjustments are unnecessary
  2857. https://bugs.webkit.org/show_bug.cgi?id=108104
  2858. Reviewed by Rob Buis.
  2859. Internally reviewed by Mike Fenton.
  2860. Internal PR 285861.
  2861. If the difference between the target scale and current scale is
  2862. less than a given threshold, don't perform a zoom animation.
  2863. * WebKitSupport/InputHandler.cpp:
  2864. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  2865. 2013-01-28 Nima Ghanavatian <nghanavatian@rim.com>
  2866. [BlackBerry] Reduce the region that is spellchecked on keystroke
  2867. https://bugs.webkit.org/show_bug.cgi?id=108115
  2868. Reviewed by Rob Buis.
  2869. PR288217
  2870. Instead of blindly checking text until endOfDocument, we should be honoring the boundaries of
  2871. the VisibleSelection that is passed into SpellingHandler. Though this results in the same behavior
  2872. on focus, this dramatically reduces the region that is rechecked when a key is hit.
  2873. Internally reviewed by Mike Fenton.
  2874. * WebKitSupport/InputHandler.cpp:
  2875. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  2876. * WebKitSupport/SpellingHandler.cpp:
  2877. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  2878. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  2879. * WebKitSupport/SpellingHandler.h:
  2880. (SpellingHandler):
  2881. 2013-01-28 Adam Barth <abarth@webkit.org>
  2882. Remove webkitNotifications.createHTMLNotification
  2883. https://bugs.webkit.org/show_bug.cgi?id=107598
  2884. Reviewed by Benjamin Poulain.
  2885. * WebCoreSupport/AboutDataEnableFeatures.in:
  2886. 2013-01-28 Otto Derek Cheung <otcheung@rim.com>
  2887. [BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
  2888. https://bugs.webkit.org/show_bug.cgi?id=108085
  2889. Reviewed by Rob Buis.
  2890. Fix a merge error that duplicated a function declaration in InputHandler.h.
  2891. * WebKitSupport/InputHandler.h:
  2892. 2013-01-28 Otto Derek Cheung <otcheung@rim.com>
  2893. [BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
  2894. https://bugs.webkit.org/show_bug.cgi?id=108085
  2895. PR 286165
  2896. Reviewed by Rob Buis.
  2897. Internally reviewed by Nima Ghanavatian.
  2898. Adding a check for the system spell check status in InputHandler::shouldSpellCheckElement so
  2899. we won't bother sending a spellcheck request if system spell check is turned off.
  2900. However, on a fresh browser start up and on the first setElementFocus, the spellcheck value isn't defined yet.
  2901. The first spell check request is therefore necessary to connect to imf to determine whether spell check is turned on.
  2902. If spell check is turned off, we will turn spellinghandler off.
  2903. Tested the patch using a test site that contains editable text in text-areas and content-editable divs. Also tested on
  2904. an extreme test case where we try to edit a content-editable div with 30000 characters. Confirmed spell-check requests are
  2905. being canceled if system spell check is off.
  2906. In theory, this patch should also fix PR 284229 . However, because of issues with getting the system spell check values from IMF,
  2907. additional work needs to be done for that PR.
  2908. * Api/WebPage.cpp:
  2909. (BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
  2910. * WebKitSupport/InputHandler.cpp:
  2911. (BlackBerry::WebKit::InputHandler::InputHandler):
  2912. (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
  2913. (WebKit):
  2914. (BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
  2915. * WebKitSupport/InputHandler.h:
  2916. (InputHandler):
  2917. (BlackBerry::WebKit::InputHandler::setSystemSpellCheckStatus):
  2918. 2013-01-25 Andrew Lo <anlo@rim.com>
  2919. [BlackBerry] Pop-up WebViews should not take ownership of the backing store.
  2920. https://bugs.webkit.org/show_bug.cgi?id=107957
  2921. Reviewed by Rob Buis.
  2922. Internally reviewed by Jakob Petsovits.
  2923. Internal PR 274581.
  2924. Add web setting for whether a WebPage should take the backing store.
  2925. Prevent pop-up WebView from taking ownership of the backing
  2926. store when it becomes visible.
  2927. * Api/WebPage.cpp:
  2928. (BlackBerry::WebKit::WebPage::setVisible):
  2929. * Api/WebSettings.cpp:
  2930. (WebKit):
  2931. (BlackBerry::WebKit::WebSettings::standardSettings):
  2932. (BlackBerry::WebKit::WebSettings::isBackingStoreEnabled):
  2933. (BlackBerry::WebKit::WebSettings::setBackingStoreEnabled):
  2934. * Api/WebSettings.h:
  2935. * WebCoreSupport/PagePopupBlackBerry.cpp:
  2936. (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
  2937. (WebCore::PagePopupBlackBerry::init):
  2938. 2013-01-25 Arvid Nilsson <anilsson@rim.com>
  2939. [BlackBerry] AC layers appear in the wrong place on RTL page
  2940. https://bugs.webkit.org/show_bug.cgi?id=107930
  2941. Reviewed by George Staikos.
  2942. The public API of the BlackBerry port always reports a minimum scroll
  2943. position of (0, 0), even on RTL pages with left overflow. We
  2944. accomplish this by translating the WebCore scroll position by an
  2945. amount equal in size to the minimum scroll position, to obtain the API
  2946. scroll position reported to the API client.
  2947. This means the API client will ask us to render a rect that needs to
  2948. be corrected for the minimum scroll position, or we'll render the wrong
  2949. part. This is done for BackingStore, but not for WebPageCompositor.
  2950. WebPageCompositor was rendering the wrong part of the web page when
  2951. the minimum scroll position was non-zero. Fixed by communicating the
  2952. minimum scroll position to the WebPageCompositor, and accounting for it
  2953. when interpreting the requested content rectangle to render.
  2954. PR 280229.
  2955. * Api/WebPage.cpp:
  2956. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  2957. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  2958. * Api/WebPageCompositor.cpp:
  2959. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  2960. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  2961. * Api/WebPageCompositor_p.h:
  2962. (BlackBerry::WebKit::WebPageCompositorPrivate::layoutRect):
  2963. (BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRect):
  2964. (BlackBerry::WebKit::WebPageCompositorPrivate::documentRect):
  2965. (BlackBerry::WebKit::WebPageCompositorPrivate::setDocumentRect):
  2966. (WebPageCompositorPrivate):
  2967. * Api/WebPage_p.h:
  2968. (WebPagePrivate):
  2969. 2013-01-24 Nima Ghanavatian <nghanavatian@rim.com>
  2970. [BlackBerry] Fix crash in SpellingHandler
  2971. https://bugs.webkit.org/show_bug.cgi?id=107842
  2972. Reviewed by Rob Buis.
  2973. If we have an empty range or one with all spaces, we can simply return 0 instead of
  2974. still creating a range. Putting in a null check after trimming to catch this case
  2975. which was causing the crash in some DRT tests.
  2976. Internally reviewed by Mike Fenton.
  2977. * WebKitSupport/DOMSupport.cpp:
  2978. (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
  2979. * WebKitSupport/SpellingHandler.cpp:
  2980. (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
  2981. 2013-01-24 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  2982. [BlackBerry] It can't Select texts in main frame when the current focus is in a IFrame
  2983. https://bugs.webkit.org/show_bug.cgi?id=107773
  2984. Reviewed by Antonio Gomes.
  2985. PR285211 Internally reviewed by Genevieve Mak
  2986. When touch hold in the unfocused frame, it doesn't switch frame focus. Many
  2987. places in code depends on the webpage->forcusOrMainFrame(), including the
  2988. SelectionHandler, so it can't select in an unfocused frame. This patch switchs
  2989. frame focus when touch starts.
  2990. * WebKitSupport/TouchEventHandler.cpp:
  2991. (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
  2992. 2013-01-23 Nima Ghanavatian <nghanavatian@rim.com>
  2993. [BlackBerry] Take a better guess as to what text the user wants learned
  2994. https://bugs.webkit.org/show_bug.cgi?id=107706
  2995. Reviewed by Rob Buis.
  2996. If we still have a valid caret position, use it to give priority to a region
  2997. of text. We now take the text before the caret, instead of the text at the end
  2998. of the field. If the caret is not present, we start from the beginning of the field.
  2999. This helps learning in email where the region of interest is generally at the start,
  3000. not end of the field.
  3001. Internally reviewed by Mike Fenton
  3002. * WebKitSupport/InputHandler.cpp:
  3003. (BlackBerry::WebKit::InputHandler::learnText):
  3004. 2013-01-23 Nima Ghanavatian <nghanavatian@rim.com>
  3005. [BlackBerry] Optimize spellchecking by coalescing messages
  3006. https://bugs.webkit.org/show_bug.cgi?id=107707
  3007. Reviewed by Rob Buis.
  3008. PR233604
  3009. Instead of taking chunks one line at a time, coalesce them together
  3010. to fire off messages as close to our character limit as possible.
  3011. This should dramatically reduce the total number of messages in email
  3012. giving us a little performance bump.
  3013. Internally reviewed by Mike Fenton and Gen Mak.
  3014. * WebKitSupport/DOMSupport.cpp:
  3015. (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
  3016. (DOMSupport):
  3017. * WebKitSupport/DOMSupport.h:
  3018. * WebKitSupport/InputHandler.cpp:
  3019. * WebKitSupport/InputHandler.h:
  3020. (InputHandler):
  3021. * WebKitSupport/SpellingHandler.cpp:
  3022. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  3023. (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
  3024. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  3025. (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
  3026. * WebKitSupport/SpellingHandler.h:
  3027. 2013-01-23 Shinya Kawanaka <shinyak@chromium.org>
  3028. shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
  3029. https://bugs.webkit.org/show_bug.cgi?id=107624
  3030. Reviewed by Dimitri Glazkov.
  3031. Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
  3032. * Api/WebPage.cpp:
  3033. (BlackBerry::WebKit::WebPagePrivate::webContext):
  3034. * WebKitSupport/FatFingers.h:
  3035. (BlackBerry::WebKit::FatFingersResult::node):
  3036. * WebKitSupport/InPageSearchManager.cpp:
  3037. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  3038. 2013-01-22 Andrew Lo <anlo@rim.com>
  3039. [BlackBerry] GIF & RAF animations sometimes don't resume after zoom
  3040. https://bugs.webkit.org/show_bug.cgi?id=107590
  3041. Reviewed by Rob Buis.
  3042. Internally reviewed by Jakob Petsovits.
  3043. Internal PR 276907.
  3044. Dispatch render jobs when resuming backing store updates to perform jobs
  3045. queued when updates were suspended.
  3046. * Api/BackingStore.cpp:
  3047. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  3048. 2013-01-21 Nima Ghanavatian <nghanavatian@rim.com>
  3049. [BlackBerry] Skip spell checking on single character strings
  3050. https://bugs.webkit.org/show_bug.cgi?id=107463
  3051. Reviewed by Yong Li.
  3052. Check for a minimum string length when firing off spellcheck since we don't
  3053. want to mark single letter words.
  3054. Internally reviewed by Mike Fenton.
  3055. * WebKitSupport/InputHandler.cpp:
  3056. * WebKitSupport/SpellingHandler.cpp:
  3057. (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
  3058. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  3059. 2013-01-20 Charles Wei <charles.wei@torchmobile.com.cn>
  3060. [BlackBerry] some websites only takes half of the screen after rotating from landscape to portrait mode.
  3061. https://bugs.webkit.org/show_bug.cgi?id=107103
  3062. Reviewed by George Staikos.
  3063. Internally reviewed by Jacky Jiang.
  3064. When the document size changes (by some javascript) which makes it too small to fit the viewport, we should
  3065. automatically zoom it to fit the viewport.
  3066. * Api/WebPage.cpp:
  3067. (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
  3068. 2013-01-20 Tiancheng Jiang <tijiang@rim.com>
  3069. [BlackBerry] Improve Fatfinger phase.
  3070. https://bugs.webkit.org/show_bug.cgi?id=107403
  3071. Reviewed by Rob Buis.
  3072. RIM PR 219489
  3073. Internally reviewd by Mike Fenton & Gen Mak.
  3074. Treat ClickableByDefault and MadeClickableByTheWebpage elements as
  3075. same category. Avoid unnecessary nodes check step.
  3076. * WebKitSupport/FatFingers.cpp:
  3077. (BlackBerry::WebKit::FatFingers::isElementClickable):
  3078. (BlackBerry::WebKit::FatFingers::FatFingers):
  3079. (BlackBerry::WebKit::FatFingers::findBestPoint):
  3080. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  3081. * WebKitSupport/FatFingers.h:
  3082. 2013-01-18 Andrew Lo <anlo@rim.com>
  3083. [BlackBerry] When acquiring/releasing backing store memory, allow web page client control suspend/resuming of backing store
  3084. https://bugs.webkit.org/show_bug.cgi?id=107307
  3085. Reviewed by Rob Buis.
  3086. Internally reviewed by Jakob Petsovits.
  3087. Internal PR276660
  3088. Have BackingStore::createBackingStoreMemory & releaseBackingStoreMemory only
  3089. acquire & release the surface pool. It doesn't matter if either is called
  3090. redundantly since SurfacePool has internal state to protect against that.
  3091. Resuming & suspending backing store and screen updates will be handled by
  3092. the WebPageClient.
  3093. * Api/BackingStore.cpp:
  3094. (BlackBerry::WebKit::BackingStore::acquireBackingStoreMemory):
  3095. (BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
  3096. * Api/BackingStore.h:
  3097. 2013-01-18 Nima Ghanavatian <nghanavatian@rim.com>
  3098. [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread
  3099. https://bugs.webkit.org/show_bug.cgi?id=107284
  3100. Reviewed by Rob Buis.
  3101. PR282351
  3102. Firing off spellcheck requests is tieing up the WebKit thread for an
  3103. extended period of time. In testing with large blocks of text, this
  3104. can be in the matter of 5-10 seconds. Though we are using asynchronous
  3105. spellchecking, the process in which we break down blocks of text based
  3106. on input_service limitations is the issue.
  3107. Using a timer here which fires with an arbitrary timeout to allow for
  3108. focus and interaction to maintain at a reasonable level.
  3109. Further, pulling this code out of InputHandler and into its own class.
  3110. Internally reviewed by Mike Fenton and Gen Mak.
  3111. * WebKitSupport/InputHandler.cpp:
  3112. (BlackBerry::WebKit::InputHandler::InputHandler):
  3113. (BlackBerry::WebKit::InputHandler::~InputHandler):
  3114. (BlackBerry::WebKit::InputHandler::callRequestCheckingFor):
  3115. (WebKit):
  3116. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  3117. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  3118. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  3119. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  3120. (BlackBerry::WebKit::InputHandler::setElementFocused):
  3121. * WebKitSupport/InputHandler.h:
  3122. (WebCore):
  3123. (WebKit):
  3124. (InputHandler):
  3125. * WebKitSupport/SpellingHandler.cpp: Added.
  3126. (WebKit):
  3127. (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
  3128. (BlackBerry::WebKit::SpellingHandler::~SpellingHandler):
  3129. (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
  3130. (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
  3131. (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
  3132. (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
  3133. * WebKitSupport/SpellingHandler.h: Added.
  3134. (WebCore):
  3135. (WebKit):
  3136. (SpellingHandler):
  3137. (BlackBerry::WebKit::SpellingHandler::isSpellCheckActive):
  3138. (BlackBerry::WebKit::SpellingHandler::setSpellCheckActive):
  3139. 2013-01-18 Nima Ghanavatian <nghanavatian@rim.com>
  3140. [BlackBerry] Check if continuous spellchecking is enabled before processing a request
  3141. https://bugs.webkit.org/show_bug.cgi?id=107169
  3142. Reviewed by Rob Buis.
  3143. PR265815
  3144. We set this value based on the global settings page. The
  3145. spellcheck-on-focus codepath did not hit this, so focusing a
  3146. field would not uphold the setting.
  3147. Internally reviewed by Mike Fenton and Gen Mak.
  3148. * WebKitSupport/DOMSupport.cpp:
  3149. (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
  3150. (DOMSupport):
  3151. * WebKitSupport/DOMSupport.h:
  3152. * WebKitSupport/InputHandler.cpp:
  3153. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  3154. 2013-01-18 Seokju Kwon <seokju.kwon@gmail.com>
  3155. Add explicit keyword to constructors in platform-specific InspectorClient
  3156. https://bugs.webkit.org/show_bug.cgi?id=107255
  3157. Reviewed by Kentaro Hara.
  3158. Add explicit keyword to constructors that take one argument
  3159. in platform-specific implementation of InspectorClient.
  3160. * WebCoreSupport/InspectorClientBlackBerry.h:
  3161. (InspectorClientBlackBerry):
  3162. 2013-01-18 Andrew Lo <anlo@rim.com>
  3163. [BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
  3164. https://bugs.webkit.org/show_bug.cgi?id=107215
  3165. Reviewed by Rob Buis.
  3166. Internally reviewed by Jakob Petsovits.
  3167. Internal PR276660
  3168. Render jobs should not be performed if the backing store is inactive.
  3169. This occured when the browser was invoked, causing a web page to be made
  3170. visible before the surface pool was resumed.
  3171. * Api/BackingStore.cpp:
  3172. (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
  3173. 2013-01-17 Yong Li <yoli@rim.com>
  3174. [BlackBerry] InRegionScroller should notify client before it deletes all the scrollables
  3175. https://bugs.webkit.org/show_bug.cgi?id=107162
  3176. Reviewed by Rob Buis.
  3177. Internally reviewed by Gen Mak and Mike Fenton.
  3178. Move the notification code from notifyInRegionScrollStopped() to reset() as there are
  3179. other places where reset() gets called.
  3180. * Api/InRegionScroller.cpp:
  3181. (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
  3182. * Api/WebPage.cpp:
  3183. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
  3184. 2013-01-17 Mike Fenton <mifenton@rim.com>
  3185. [BlackBerry] Fix selection handle appearance for RTL text.
  3186. https://bugs.webkit.org/show_bug.cgi?id=107043
  3187. Reviewed by Rob Buis.
  3188. PR 263585.
  3189. Invert the reported selection handle position if to match
  3190. the visual order instead of the logical order to create the
  3191. desired appearance for RTL text and directional selections.
  3192. Reviewed Internally by Gen Mak and Nima Ghanavatian.
  3193. * WebKitSupport/SelectionHandler.cpp:
  3194. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  3195. 2013-01-16 Charles Wei <charles.wei@torchmobile.com.cn>
  3196. [BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's
  3197. device rotation in fullscreen mode
  3198. https://bugs.webkit.org/show_bug.cgi?id=107085
  3199. Reviewed by George STaikos.
  3200. Also internally reviewed by Jacky Jiang.
  3201. We saved the scale and scroll position before entering full screen mode, so that we can restore
  3202. them after leaving fullscreen mode, because entering fullscreen mode automatically changes the
  3203. scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen,
  3204. the scale and scroll position saved before may or may not apply anymore, we need to adjust the
  3205. scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation.
  3206. * Api/WebPage.cpp:
  3207. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  3208. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  3209. * Api/WebPage_p.h:
  3210. (WebPagePrivate):
  3211. 2013-01-16 Joe Mason <jmason@rim.com>
  3212. [BlackBerry] Remove bogus assert in GeolocationClientBlackBerry
  3213. https://bugs.webkit.org/show_bug.cgi?id=105651
  3214. Reviewed by Darin Adler.
  3215. GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is
  3216. in m_geolocationRequestMap. But it's perfectly valid for the origin to not be in the map -
  3217. for instance, if GeolocationClientBlackBerry::requestPermission returned immediately,
  3218. without putting it in the map, because geolocation was disabled. In this case the correct
  3219. thing to do is just return - there is nothing to be done to cancel the permission.
  3220. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  3221. (GeolocationClientBlackBerry::cancelPermissionRequest):
  3222. 2013-01-15 Mike Fenton <mifenton@rim.com>
  3223. [BlackBerry] Don't overwrite field dir with current locale.
  3224. https://bugs.webkit.org/show_bug.cgi?id=106932
  3225. Reviewed by Yong Li.
  3226. PR 212267.
  3227. Remove uncalled onInputLocaleChanged and stop re-writing the dir
  3228. on input focus which prevented RTL fields from rendering properly.
  3229. Reviewed Internally by Eli Fidler.
  3230. * Api/WebPage.cpp:
  3231. * Api/WebPage.h:
  3232. * Api/WebPage_p.h:
  3233. (WebPagePrivate):
  3234. * WebKitSupport/InputHandler.cpp:
  3235. * WebKitSupport/InputHandler.h:
  3236. (InputHandler):
  3237. 2013-01-15 Jacky Jiang <zhajiang@rim.com>
  3238. [BlackBerry] Manual zoom propagates to next page load
  3239. https://bugs.webkit.org/show_bug.cgi?id=106914
  3240. Reviewed by Yong Li.
  3241. Internally reviewed by Eli Fidler and Jakob Petsovits.
  3242. PR: 280481
  3243. During load committed, the web page scale was reset. However, UI thread
  3244. still kept the old scale in UserInterfaceViewportAccessor so that it
  3245. blitted the contents at the old scale although WebKit thread could
  3246. update the UI thread scale later when finished the load.
  3247. We should update the scale of the UI thread right after we reset it in
  3248. WebKit thread to keep them in sync.
  3249. * Api/WebPage.cpp:
  3250. (BlackBerry::WebKit::WebPagePrivate::resetScales):
  3251. 2013-01-14 Otto Derek Cheung <otcheung@rim.com>
  3252. [BlackBerry] FCC appears when switching search engine providers
  3253. https://bugs.webkit.org/show_bug.cgi?id=106824
  3254. Magnifying glass appears when switching search engine providers
  3255. PR 279178
  3256. Reviewed by Rob Buis.
  3257. Internal Reviewed by Mike Fenton.
  3258. We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
  3259. to show the FCC.
  3260. This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
  3261. when the user touches an element that is not a textfield and changes the caret in the inputbar..
  3262. Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
  3263. search engine providers.
  3264. * WebKitSupport/SelectionHandler.cpp:
  3265. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  3266. 2013-01-14 Jacky Jiang <zhajiang@rim.com>
  3267. [BlackBerry] Zoom is still possible when user-scalable=no
  3268. https://bugs.webkit.org/show_bug.cgi?id=106809
  3269. Reviewed by George Staikos.
  3270. PR: 274566
  3271. On wordpress.com, the contents were rendered at the width 343 which was
  3272. 1 css pixel larger than the expected device-width 342 so that we didn't
  3273. respect the viewport.
  3274. There was a RenderBlock on the page which contained "\n" and an
  3275. inline-block. "\n" took 0.78 width and the inline-block took 342 width
  3276. and they were unfortunately placed in the same InlineBox which caused
  3277. the contents width 1 css pixels larger than the device-width.
  3278. Allow the contents width to be 1 css pixel larger and still respect the
  3279. viewport in such a special case.
  3280. * Api/WebPage.cpp:
  3281. (BlackBerry::WebKit::WebPagePrivate::respectViewport):
  3282. 2013-01-13 Xiaobo Wang <xbwang@torchmobile.com.cn>
  3283. [BlackBerry] Add a public function WebPage::isLoading()
  3284. https://bugs.webkit.org/show_bug.cgi?id=106751
  3285. PR 274392
  3286. Reviewed by George Staikos.
  3287. Need to get the load state in WebPageClient when resolving PR 274392.
  3288. * Api/WebPage.cpp:
  3289. (BlackBerry::WebKit::WebPage::isLoading):
  3290. (WebKit):
  3291. * Api/WebPage.h:
  3292. 2013-01-11 Andrew Lo <anlo@rim.com>
  3293. [BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
  3294. https://bugs.webkit.org/show_bug.cgi?id=106719
  3295. Reviewed by Yong Li.
  3296. Internally reviewed by Mike Fenton.
  3297. Internal PR 278687
  3298. Always ensureFocusTextElementVisible if an element is focused when
  3299. the device has a physical keyboard.
  3300. * WebKitSupport/InputHandler.cpp:
  3301. (BlackBerry::WebKit::InputHandler::setElementFocused):
  3302. 2013-01-11 Otto Derek Cheung <otcheung@rim.com>
  3303. [BlackBerry] Modifying the databaseQuota call to WebPageClient
  3304. https://bugs.webkit.org/show_bug.cgi?id=106703
  3305. Reviewed by Yong Li.
  3306. The databaseQuota call in WebPageClientImpl is modified to take in
  3307. BP:Strings directly. Also, we want to use the origin URL from the security origin.
  3308. Not the database identifier.
  3309. * Api/WebPageClient.h:
  3310. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3311. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  3312. 2013-01-10 Yongxin Dai <yodai@rim.com>
  3313. [BlackBerry] Handle the case that start/end position is out of unclipped selection region
  3314. https://bugs.webkit.org/show_bug.cgi?id=106486
  3315. Reviewed by Rob Buis.
  3316. PR #270624
  3317. Unclipped selection region should cover start/end position of the selection.
  3318. Since we exclude hidden text when calculating unclipped selection region, the
  3319. start/end position can be out of unclipped selection region if it is for hidden
  3320. text. If that is the case, start/end handle will be invisible. To avoid invisible
  3321. handle, we take unclipped selection region as reference rectangle in the case.
  3322. Internally reviewed by Genevieve Mak, Mike Fenton
  3323. * WebKitSupport/SelectionHandler.cpp:
  3324. (BlackBerry::WebKit::referencePoint):
  3325. 2013-01-09 Genevieve Mak <gmak@rim.com>
  3326. [BlackBerry] Useless if statement check
  3327. https://bugs.webkit.org/show_bug.cgi?id=106113
  3328. Reviewed by Yong Li.
  3329. Remove stray ! in if statement which was mistakenly left in during
  3330. refactoring. Since Injected events are checked before they are sent to
  3331. webkit, it didn't have an effect on behaviour.
  3332. * Api/WebPage.cpp:
  3333. (BlackBerry::WebKit::WebPage::touchEvent):
  3334. 2013-01-08 Otto Derek Cheung <otcheung@rim.com>
  3335. [BlackBerry] Removing the totalusage variable in ChromeClientBB::exceededDatabaseQuota
  3336. https://bugs.webkit.org/show_bug.cgi?id=106370
  3337. Reviewed by Yong Li.
  3338. Removing totalUsage in ChromeClientBlackBerry as we no longer use that variable.
  3339. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3340. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  3341. 2013-01-08 Jacky Jiang <zhajiang@rim.com>
  3342. [Blackberry][FullScreen] Create a helper method to adjust the fullscreen renderer dimensions
  3343. https://bugs.webkit.org/show_bug.cgi?id=91748
  3344. Reviewed by Antonio Gomes.
  3345. PR: 195524
  3346. The was originally from Antonio Gomes on PR195524. Bug 105488 has
  3347. partially upstreamed that patch. This patch upstreams the rest of it.
  3348. * Api/WebPage.cpp:
  3349. (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
  3350. (BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
  3351. * Api/WebPage_p.h:
  3352. (WebPagePrivate):
  3353. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3354. (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
  3355. 2013-01-08 Mark Lam <mark.lam@apple.com>
  3356. Removed the need for the ProposedDatabase mechanism.
  3357. https://bugs.webkit.org/show_bug.cgi?id=106292.
  3358. Reviewed by Sam Weinig.
  3359. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3360. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  3361. * WebCoreSupport/ChromeClientBlackBerry.h:
  3362. (ChromeClientBlackBerry):
  3363. 2013-01-08 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  3364. [BlackBerry] Can't select text out of current focused input
  3365. https://bugs.webkit.org/show_bug.cgi?id=106322
  3366. Reviewed by Rob Buis.
  3367. PR270755
  3368. Internally reviewed by Mike Fenton
  3369. When selection changed, the selection handler clips new selection with
  3370. current focused node's boundary. So we clear focus before selectObject.
  3371. This patch clear focus when selectObject is at a point but not at a node.
  3372. * WebKitSupport/SelectionHandler.cpp:
  3373. (BlackBerry::WebKit::SelectionHandler::selectObject):
  3374. 2013-01-08 Steve Block <steveblock@chromium.org>
  3375. Rename 'IntSize toSize(const IntPoint&)' to 'toIntSize'
  3376. https://bugs.webkit.org/show_bug.cgi?id=106307
  3377. This matches other method names which distinguish between sizes and
  3378. points. See https://bugs.webkit.org/show_bug.cgi?id=105992#c4.
  3379. Reviewed by Kentaro Hara.
  3380. * Api/InRegionScroller.cpp:
  3381. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  3382. 2013-01-07 Genevieve Mak <gmak@rim.com>
  3383. [BlackBerry] Touch Events are falling through fullscreen video
  3384. https://bugs.webkit.org/show_bug.cgi?id=106112
  3385. Reviewed by Rob Buis.
  3386. Reviewed Internally by Jakob Petsovits.
  3387. PR #274326
  3388. Do not do viewport centering calculations if in fullscreen video.
  3389. The offset should be zero.
  3390. * Api/WebPage.cpp:
  3391. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  3392. 2013-01-07 Jacky Jiang <zhajiang@rim.com>
  3393. [BlackBerry] Roll out r136173 as there are alternative approaches from the client sides now
  3394. https://bugs.webkit.org/show_bug.cgi?id=106236
  3395. Unreviewed, rolling out r136173.
  3396. This becomes unnecessary now as there are alternative approaches to
  3397. solve the issue from the client sides.
  3398. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3399. (WebCore::ChromeClientBlackBerry::createWindow):
  3400. 2013-01-07 Jakob Petsovits <jpetsovits@rim.com>
  3401. [BlackBerry] Never avoid blitting when one-shot drawing sync is involved.
  3402. https://bugs.webkit.org/show_bug.cgi?id=106225
  3403. RIM PR 274948
  3404. Reviewed by George Staikos.
  3405. Based on a patch by Chris Guan.
  3406. didRenderContent() has a mechanism to avoid double blits;
  3407. when scrolling or zooming is enabled then we don't issue
  3408. blitContents() as the client would (continually) do that
  3409. already.
  3410. However, since r138024, didRenderContents() also deals
  3411. with one-shot drawing synchronization and commits.
  3412. When these are required, we can't just skip out or the
  3413. backingstore and overlaying composited layers are likely
  3414. to get out of sync. The condition also doesn't make much
  3415. sense for direct rendering as no blit calls are issued
  3416. at all when it is enabled.
  3417. Fix the issue by limiting the impact of the scroll/zoom
  3418. early return to only regular blit operations.
  3419. * Api/BackingStore.cpp:
  3420. (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
  3421. 2013-01-05 Andy Chen <andchen@rim.com>
  3422. [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link
  3423. https://bugs.webkit.org/show_bug.cgi?id=106141
  3424. Reviewed by Rob Buis.
  3425. If last fat finger result is a link, select it directly when
  3426. SelectionHandler::selectAtPoint is called.
  3427. PR 263449
  3428. Internally reviewed by Mike Fenton and Yongxin Dai.
  3429. * WebKitSupport/SelectionHandler.cpp:
  3430. (BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
  3431. (WebKit):
  3432. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  3433. * WebKitSupport/SelectionHandler.h:
  3434. (WebKit):
  3435. (SelectionHandler):
  3436. 2013-01-04 Mike Lattanzio <mlattanzio@rim.com>
  3437. [BlackBerry] Last text input caret left visible when WebView entirely loses focus.
  3438. https://bugs.webkit.org/show_bug.cgi?id=106124
  3439. Reviewed by George Staikos.
  3440. Internal PR 248834
  3441. There are numerous code paths that lead to repainting of the focus node
  3442. when the focus moves to another node, but none seem to cover the case
  3443. of focus leaving the document when there are no DocumentMarkers present.
  3444. * WebKitSupport/InputHandler.cpp:
  3445. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  3446. 2013-01-04 Otto Derek Cheung <otcheung@rim.com>
  3447. [BlackBerry] FCC will show up as you type if you tap on the same input bar twice before typing
  3448. https://bugs.webkit.org/show_bug.cgi?id=106116
  3449. Reviewed by Yong Li.
  3450. Internal reviewed by Gen Mak.
  3451. PR 267177
  3452. FCC is being invoked because the fatfinger result is no longer a reliable source
  3453. to tell whether the caret change is caused by user touch input. Instead, we recognize all
  3454. notifyCaretChange calls with userTouchInput as true except when caretPositionChanged is invoked
  3455. by SelectionHandler:inputHandlerDidFinishProcessingChange.
  3456. * WebKitSupport/SelectionHandler.cpp:
  3457. (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
  3458. (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
  3459. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  3460. * WebKitSupport/SelectionHandler.h:
  3461. (SelectionHandler):
  3462. 2013-01-04 Yong Li <yoli@rim.com>
  3463. [BlackBerry] Cached frame shouldn't access the page when being destroyed
  3464. https://bugs.webkit.org/show_bug.cgi?id=105942
  3465. Reviewed by George Staikos.
  3466. Fix regression of previous patch. dispatchDidHandleOnloadEvents() can be called
  3467. after Frame has been detached.
  3468. RIM PR# 271237.
  3469. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3470. (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
  3471. 2013-01-04 Nima Ghanavatian <nghanavatian@rim.com>
  3472. [BlackBerry] Allow defaultTabEventHandler to trigger on tab
  3473. https://bugs.webkit.org/show_bug.cgi?id=106118
  3474. Reviewed by Yong Li.
  3475. In order to support tabbing through input elements, amongst
  3476. other things, we need to bipass the processing of the tab key as
  3477. '\t'. This will simply insert 4 spaces in the field. Remove tab
  3478. support from the key down map so that we don't translate it to
  3479. an editor command.
  3480. Internally reviewed by Mike Fenton.
  3481. * WebCoreSupport/EditorClientBlackBerry.cpp:
  3482. (WebCore):
  3483. 2013-01-04 Mike Fenton <mifenton@rim.com>
  3484. [BlackBerry] Enable Input Focus when handling touch events for JS
  3485. https://bugs.webkit.org/show_bug.cgi?id=106109
  3486. Reviewed by Yong Li.
  3487. PR 273325.
  3488. Toggle input mode active when a touch event is
  3489. received for JS processing to ensure state
  3490. is updated even when event is consumed.
  3491. Reviewed Internally by Gen Mak.
  3492. * Api/WebPage.cpp:
  3493. (BlackBerry::WebKit::WebPage::touchEvent):
  3494. 2013-01-04 Adam Klein <adamk@chromium.org>
  3495. Remove ENABLE_MUTATION_OBSERVERS #define
  3496. https://bugs.webkit.org/show_bug.cgi?id=105459
  3497. Reviewed by Ryosuke Niwa.
  3498. * WebCoreSupport/AboutDataEnableFeatures.in:
  3499. 2013-01-04 Anthony Scian <ascian@rim.com>
  3500. [Blackberry] Static code analysis warning fixes
  3501. https://bugs.webkit.org/show_bug.cgi?id=105679
  3502. Reviewed by Rob Buis.
  3503. Klocwork issue 959: check layer against NULL since it is used in both cases
  3504. of the subsequent if-stmt
  3505. * Api/InRegionScroller.cpp:
  3506. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  3507. 2013-01-02 Jacky Jiang <zhajiang@rim.com>
  3508. [BlackBerry] file:/// pages don't get correct scales after several rotations and history navigations
  3509. https://bugs.webkit.org/show_bug.cgi?id=105996
  3510. Reviewed by George Staikos.
  3511. PR: 273541
  3512. When navigating back to the previous page on portrait mode, we were
  3513. trying to set virtual viewport after recalculation. However, we didn't
  3514. change the fixed layout size so that we still layouted the contents at
  3515. the old virtual viewport size. In this case, the old virtual viewport
  3516. was 570 * 293 which was set in landscape mode unfortunately. There
  3517. would be no chance for such kind of contents size to fit the portrait
  3518. mode screen size nicely.
  3519. This was a regression of webkit/cc31d9bad where setViewMode() was
  3520. removed as a noop. So just get setViewMode() back to apply the fixed
  3521. layout size with a little bit change as SVG document path was proved
  3522. invalid in that patch. Thanks to George for the float comparison change.
  3523. Put a FIXME as we don't have a way to save the scale precisely before
  3524. the rotation and history navigation currently.
  3525. * Api/WebPage.cpp:
  3526. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  3527. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3528. (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
  3529. 2013-01-02 Otto Derek Cheung <otcheung@rim.com>
  3530. [BlackBerry] Do not determine db quota limit using db file size
  3531. https://bugs.webkit.org/show_bug.cgi?id=105991
  3532. PR 267191
  3533. Reviewed by George Staikos.
  3534. Passing the current quota to WebPageClientImpl::databaseQuota so we can determine a better
  3535. quota limit without using the db file size.
  3536. * Api/WebPageClient.h:
  3537. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  3538. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  3539. 2013-01-02 Yong Li <yoli@rim.com>
  3540. [BlackBerry] Cached frame shouldn't access the page when being destroyed
  3541. https://bugs.webkit.org/show_bug.cgi?id=105942
  3542. Reviewed by George Staikos.
  3543. In order to prevent our FrameLoaderClient from dangling WebPagePrivate object in any case,
  3544. this patches clear the m_webPagePrivate pointer when the frame is detached or cached.
  3545. RIM PR# 272137.
  3546. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3547. (WebCore::FrameLoaderClientBlackBerry::isMainFrame):
  3548. (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
  3549. (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
  3550. (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
  3551. 2013-01-02 Nima Ghanavatian <nghanavatian@rim.com>
  3552. [BlackBerry] Use fatfingers result when checking for misspelled words
  3553. https://bugs.webkit.org/show_bug.cgi?id=105923
  3554. Reviewed by Yong Li.
  3555. PR270866
  3556. Currently we are using the raw touch point when checking to see if spell check
  3557. is required on a word. When tapping close to a boundary, the raw point can be
  3558. placed off but fatfingers moves the point onto the word. This causes the caret
  3559. to be placed on a word but no spell check request triggered.
  3560. Internally reviewed by Mike Fenton and Tiancheng Jiang
  3561. * WebKitSupport/TouchEventHandler.cpp:
  3562. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  3563. 2012-12-28 Charles Wei <charles.wei@torchmobile.com.cn>
  3564. [BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
  3565. https://bugs.webkit.org/show_bug.cgi?id=105811
  3566. RIM PR 272067
  3567. Reviewed by George Staikos.
  3568. Internally Reviewed by Jakob Petsovits.
  3569. BackingStorePrivate::m_defersBlit is not used anywhere, it should
  3570. be removed to simplify the code and to avoid confusion.
  3571. * Api/BackingStore.cpp:
  3572. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  3573. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  3574. * Api/BackingStore.h:
  3575. * Api/BackingStore_p.h:
  3576. (BackingStorePrivate):
  3577. 2012-12-26 Jakob Petsovits <jpetsovits@rim.com>
  3578. [BlackBerry] Set load state for popups manually, in absence of a loader.
  3579. https://bugs.webkit.org/show_bug.cgi?id=105708
  3580. RIM PR 257216
  3581. Reviewed by George Staikos.
  3582. Internally reviewed by Chris Guan.
  3583. The WebPage class relies on the load state for various things,
  3584. among others it will only emit contents size changes after
  3585. layouts if a load state other than None is set.
  3586. Given that popups write the web page content itself with no
  3587. loader that would issue such notifications, the load state
  3588. should probably just be set manually in this case.
  3589. * WebCoreSupport/PagePopupBlackBerry.cpp:
  3590. (WebCore::PagePopupBlackBerry::init):
  3591. 2012-12-26 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  3592. [BlackBerry] Caret doesn't update position when scrolling text in Input element
  3593. https://bugs.webkit.org/show_bug.cgi?id=105757
  3594. Reviewed by George Staikos.
  3595. PR 271627
  3596. Internally reviewed by George Staikos.
  3597. Call FrameSelection's updateAppearence instead of SelectionHandler's
  3598. selectionPositionChanged to update the caret position.
  3599. * Api/InRegionScroller.cpp:
  3600. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  3601. 2012-12-25 Charles Wei <charles.wei@torchmobile.com.cn>
  3602. [BlackBerry] Need to initialize the onLine in the global
  3603. https://bugs.webkit.org/show_bug.cgi?id=105749
  3604. Reviewed by George Staikos.
  3605. The NetworkStatus is initialized to online in the constructor by default,
  3606. we need to update it correctly with the network status at startup.
  3607. * Api/BlackBerryGlobal.cpp:
  3608. (BlackBerry::WebKit::globalInitialize):
  3609. 2012-12-24 Jakob Petsovits <jpetsovits@rim.com>
  3610. [BlackBerry] Fix various RenderQueue bugs introduced by r138024.
  3611. https://bugs.webkit.org/show_bug.cgi?id=105717
  3612. RIM PR 269029
  3613. Reviewed by George Staikos.
  3614. Scroll/zoom jobs were pretty solid, but I managed to
  3615. leave some bugs in the region handling of RenderQueue's
  3616. renderRegularRenderJobs() function, causing us to skip
  3617. a desired blit or render operation in cases where the
  3618. region and tile tracking did not match up.
  3619. This commit fixes these errors.
  3620. * WebKitSupport/RenderQueue.cpp:
  3621. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
  3622. 2012-12-24 Charles Wei <charles.wei@torchmobile.com.cn>
  3623. [BlackBerry] Close page popup when a page becomes invisible.
  3624. https://bugs.webkit.org/show_bug.cgi?id=105704
  3625. Reviewed by George Staikos.
  3626. Reviewed internally by Jakob Petsovits.
  3627. * Api/WebPage.cpp:
  3628. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  3629. 2012-12-23 Mary Wu <mary.wu@torchmobile.com.cn>
  3630. [BlackBerry] give url when createWindow
  3631. https://bugs.webkit.org/show_bug.cgi?id=105702
  3632. RIM bug# 257329
  3633. Reviewed by George Staikos.
  3634. This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
  3635. for integration issue of cascade and air, as old app side still use the url
  3636. to invoke. It would unrevert after resolving the integration issue.
  3637. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3638. (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
  3639. 2012-12-23 Jakob Petsovits <jpetsovits@rim.com>
  3640. [BlackBerry] Specify tile usage enum for backingstore tiles.
  3641. https://bugs.webkit.org/show_bug.cgi?id=105688
  3642. RIM PR 262120
  3643. Reviewed by George Staikos.
  3644. This enables us to have separate tile sizes for
  3645. backingstore / root layer purposes and generic layers.
  3646. * Api/BackingStore.cpp:
  3647. (BlackBerry::WebKit::BackingStorePrivate::tileSize):
  3648. 2012-12-21 Max Feil <mfeil@rim.com>
  3649. [BlackBerry] Fullscreen video fixed position container horizontal position is wrong
  3650. https://bugs.webkit.org/show_bug.cgi?id=105488
  3651. Reviewed by George Staikos.
  3652. The fix for https://bugs.webkit.org/show_bug.cgi?id=105333 has
  3653. broken fullscreen video, which was compensating by doing its
  3654. own positioning in x. My patch fixes things by making vertical
  3655. and horizontal handling symmetrical.
  3656. NOTE: This function was not upstreamed before, so you can't
  3657. actually see my diff. See the bug.
  3658. * Api/WebPage.cpp:
  3659. (WebKit):
  3660. (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
  3661. 2012-12-18 Nima Ghanavatian <nghanavatian@rim.com>
  3662. [BlackBerry] Calculate correct word offsets for form elements.
  3663. https://bugs.webkit.org/show_bug.cgi?id=105354
  3664. Reviewed by Rob Buis.
  3665. PR266117
  3666. We need to calculate correct offsets for form elements, such as
  3667. textareas, relative to the start of the field. This allows for correct
  3668. spell checking of words in a textarea element after line breaks.
  3669. Internally reviewed by Mike Fenton.
  3670. * WebKitSupport/InputHandler.cpp:
  3671. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  3672. 2012-12-18 Genevieve Mak <gmak@rim.com>
  3673. [BlackBerry] Remove extra call to doFatFingers.
  3674. https://bugs.webkit.org/show_bug.cgi?id=105347
  3675. Reviewed by Rob Buis.
  3676. Reviewed Internally by Mike Fenton.
  3677. Now that we do fat fingers on touch start, we don't need this anymore.
  3678. * Api/WebPage.cpp:
  3679. (BlackBerry::WebKit::WebPage::touchEvent):
  3680. 2012-12-18 Genevieve Mak <gmak@rim.com>
  3681. Bug 105344 - [BlackBerry] Make single line text edits touch scrollable.
  3682. https://bugs.webkit.org/show_bug.cgi?id=105344
  3683. Reviewed by Antonio Gomes.
  3684. Reviewed Internally by Mike Fenton.
  3685. We don't need to check the overflow for editable layers because there's
  3686. no need for overflow to be set by the content.
  3687. PR #231776
  3688. * WebKitSupport/InRegionScrollableArea.cpp:
  3689. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  3690. 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
  3691. [BlackBerry] Build fix for r138024.
  3692. https://bugs.webkit.org/show_bug.cgi?id=105199
  3693. RIM PR 260232
  3694. Reviewed by Yong Li.
  3695. The clearVisibleTiles() function doesn't exist anymore
  3696. and apparently I fail at merge conflict resolution.
  3697. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3698. (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
  3699. 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
  3700. [BlackBerry] Clean up "frontState" vs. "geometry" naming confusion.
  3701. https://bugs.webkit.org/show_bug.cgi?id=105331
  3702. RIM PR 260232
  3703. Reviewed by Adam Treat.
  3704. The concept of the "front state" is going away or will be
  3705. marginalized/renamed, but I don't want to clutter upcoming
  3706. patches with renames. So do the variable renames in here,
  3707. once, and have future patches focus on actual behavior changes.
  3708. * Api/BackingStore.cpp:
  3709. (BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
  3710. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  3711. (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
  3712. (BlackBerry::WebKit::BackingStorePrivate::render):
  3713. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  3714. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  3715. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  3716. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  3717. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  3718. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  3719. 2012-12-18 Nima Ghanavatian <nghanavatian@rim.com>
  3720. [BlackBerry] Reduce calls to IMF on return
  3721. https://bugs.webkit.org/show_bug.cgi?id=105308
  3722. Reviewed by Yong Li.
  3723. PR207743
  3724. The extra calls of selection change and most importantly, end composition
  3725. are sent incorrectly on return. This is causing our state to be reset
  3726. every time we hit enter.
  3727. Internally reviewed by Mike Fenton and Gen Mak.
  3728. * WebKitSupport/InputHandler.cpp:
  3729. (BlackBerry::WebKit::InputHandler::InputHandler):
  3730. (BlackBerry::WebKit::InputHandler::nodeTextChanged):
  3731. (BlackBerry::WebKit::InputHandler::selectionChanged):
  3732. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  3733. (BlackBerry::WebKit::InputHandler::shouldNotifyWebView):
  3734. (WebKit):
  3735. * WebKitSupport/InputHandler.h:
  3736. (InputHandler):
  3737. 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
  3738. [BlackBerry] Remove the visible tile buffer from the BackingStore.
  3739. https://bugs.webkit.org/show_bug.cgi?id=105302
  3740. RIM PR 260232
  3741. Reviewed by George Staikos.
  3742. The visible tile buffer was introduced as an additional
  3743. buffering solution that was necessary because other
  3744. buffers would only cover part of the screen and could
  3745. only be swapped one by one, with long blocking calls
  3746. between each newly rendered tile. By carrying an old copy
  3747. of all tiles at once, we were avoiding checkerboard and
  3748. visual artifacts during load time when much zoom-to-fit
  3749. action is going on.
  3750. These days, the visual tile buffer hurts more than it helps,
  3751. not only taking up lots of memory but also requiring
  3752. complexity that we'd rather get rid of. Now that multiple
  3753. buffers are being swapped into the user interface thread
  3754. at once, the need for the visible tile buffer is no longer
  3755. there and can be exchanged for standard geometry behavior.
  3756. This patch simply deletes the visible tile buffer to use
  3757. existing other code instead. Differences in behavior are
  3758. non-existent or negligible.
  3759. * Api/BackingStore.cpp:
  3760. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  3761. (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
  3762. (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
  3763. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  3764. * Api/BackingStore_p.h:
  3765. (BackingStorePrivate):
  3766. * Api/WebPage.cpp:
  3767. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  3768. * WebKitSupport/SurfacePool.cpp:
  3769. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  3770. (BlackBerry::WebKit::SurfacePool::initialize):
  3771. (BlackBerry::WebKit::SurfacePool::createBuffers):
  3772. (BlackBerry::WebKit::SurfacePool::releaseBuffers):
  3773. * WebKitSupport/SurfacePool.h:
  3774. (SurfacePool):
  3775. 2012-12-18 Jakob Petsovits <jpetsovits@rim.com>
  3776. [BlackBerry] Restructure the render queue to process multiple tiles at once.
  3777. https://bugs.webkit.org/show_bug.cgi?id=105199
  3778. RIM PR 260232
  3779. Reviewed by George Staikos.
  3780. Internally reviewed by Arvid Nilsson.
  3781. Since my last big commit, r136442, the BackingStore's render()
  3782. function is able to fetch multiple back buffers and swap them
  3783. into the user interface thread in one go. However, it turns out
  3784. that this is not enough to actually render to all of the
  3785. available back buffers at once. The RenderQueue class was still
  3786. working with a model based on processing one rectangle after
  3787. another.
  3788. This commit rewrites large parts of RenderQueue to issue
  3789. render() calls for multiple tiles at once. As WebCore painting
  3790. gets cheaper and blocking becomes more of an issue, this commit
  3791. does away with paints smaller than tile size and always renders
  3792. whole tiles at once. This means the demise of RenderRect.
  3793. As an additional benefit, this means we can remove the
  3794. copyPreviousContentsToTileBuffer() function which caused
  3795. potential threading issues as it was accessing a buffer
  3796. now owned by the UI thread from the WebKit thread.
  3797. RenderQueue is also smarter than before in assigning batches,
  3798. it now takes into account the number of available back buffers
  3799. for rendering as well as excludes tiles outside contents
  3800. boundaries. Regular render jobs continue being tracked as
  3801. regions (and are being issued to didRenderContent()) with only
  3802. the changed content regions. Everything else switches over to
  3803. tile index lists from previously lists of rectangles.
  3804. By default, we render as many tiles at once as we can grab
  3805. back buffers, or until a given set of jobs is done.
  3806. For high-priority jobs, render() will be called in a loop.
  3807. To allow for the necessary changes in render() and improve
  3808. reliability in the same go, we now call render() almost
  3809. exclusively through RenderQueue. Other places would often
  3810. call renderVisibleContents() in situations where rendering
  3811. is not possible, geometries don't get updated, or content
  3812. rendered notifications would not get issued to the client.
  3813. By replacing renderVisibleContents() with a scheduled
  3814. high-priority queue that's immediately being processed
  3815. (but only if possible), these problems go away.
  3816. * Api/BackingStore.cpp:
  3817. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  3818. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  3819. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  3820. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  3821. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  3822. (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
  3823. (BlackBerry::WebKit::BackingStorePrivate::indexesForBackingStoreRect):
  3824. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  3825. (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
  3826. (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
  3827. (BlackBerry::WebKit::BackingStorePrivate::render):
  3828. (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitVisibleContentsImmediately):
  3829. (BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
  3830. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  3831. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  3832. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  3833. (BlackBerry::WebKit::BackingStorePrivate::visibleTileIndexes):
  3834. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  3835. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  3836. (BlackBerry::WebKit::BackingStorePrivate::updateTile):
  3837. (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
  3838. (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
  3839. * Api/BackingStore_p.h:
  3840. (BackingStorePrivate):
  3841. * Api/WebPage.cpp:
  3842. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  3843. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  3844. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  3845. * Api/WebPageCompositor.cpp:
  3846. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
  3847. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  3848. (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
  3849. * WebKitSupport/RenderQueue.cpp:
  3850. (BlackBerry::WebKit::compareRectOneDirection):
  3851. (BlackBerry::WebKit::tileIndexIsLessThan):
  3852. (WebKit):
  3853. (BlackBerry::WebKit::tileIndexLessThanFunction):
  3854. (BlackBerry::WebKit::TileIndexLessThan::TileIndexLessThan):
  3855. (BlackBerry::WebKit::TileIndexLessThan::operator()):
  3856. (TileIndexLessThan):
  3857. (BlackBerry::WebKit::RenderQueue::reset):
  3858. (BlackBerry::WebKit::RenderQueue::isEmpty):
  3859. (BlackBerry::WebKit::RenderQueue::hasCurrentRegularRenderJob):
  3860. (BlackBerry::WebKit::RenderQueue::hasCurrentVisibleZoomJob):
  3861. (BlackBerry::WebKit::RenderQueue::hasCurrentVisibleScrollJob):
  3862. (BlackBerry::WebKit::RenderQueue::isCurrentVisibleZoomJob):
  3863. (BlackBerry::WebKit::RenderQueue::isCurrentVisibleZoomJobCompleted):
  3864. (BlackBerry::WebKit::RenderQueue::isCurrentVisibleScrollJob):
  3865. (BlackBerry::WebKit::RenderQueue::isCurrentVisibleScrollJobCompleted):
  3866. (BlackBerry::WebKit::RenderQueue::isCurrentRegularRenderJob):
  3867. (BlackBerry::WebKit::RenderQueue::tileIndexesIntersectingRegion):
  3868. (BlackBerry::WebKit::RenderQueue::tileIndexesFullyContainedInRegion):
  3869. (BlackBerry::WebKit::RenderQueue::tileRegion):
  3870. (BlackBerry::WebKit::RenderQueue::addToQueue):
  3871. (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
  3872. (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
  3873. (BlackBerry::WebKit::RenderQueue::quickSort):
  3874. (BlackBerry::WebKit::RenderQueue::visibleContentChanged):
  3875. (BlackBerry::WebKit::RenderQueue::backingStoreRectChanging):
  3876. (BlackBerry::WebKit::RenderQueue::clear):
  3877. (BlackBerry::WebKit::RenderQueue::clearRegions):
  3878. (BlackBerry::WebKit::RenderQueue::clearTileIndexes):
  3879. (BlackBerry::WebKit::RenderQueue::render):
  3880. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
  3881. (BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):
  3882. (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
  3883. * WebKitSupport/RenderQueue.h:
  3884. (WebKit):
  3885. (RenderQueue):
  3886. * WebKitSupport/SurfacePool.cpp:
  3887. (BlackBerry::WebKit::SurfacePool::numberOfAvailableBackBuffers):
  3888. (BlackBerry::WebKit::SurfacePool::takeBackBuffer):
  3889. * WebKitSupport/SurfacePool.h:
  3890. (SurfacePool):
  3891. * WebKitSupport/TileIndex.h:
  3892. (WebKit):
  3893. 2012-12-17 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  3894. [BlackBerry] Editable text element can't be selected
  3895. https://bugs.webkit.org/show_bug.cgi?id=105240
  3896. Reviewed by Rob Buis.
  3897. Internally reviewed by Genevieve Mak and Mike Fenton.
  3898. Internal PR266755
  3899. When the target is Text, we should allow it to collect text nodes in
  3900. the shadow tree of text editable elements.
  3901. * WebKitSupport/FatFingers.cpp:
  3902. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  3903. 2012-12-17 Yongxin Dai <yodai@rim.com>
  3904. [BlackBerry] Prevent selection handles from being rendered after selection was canceled
  3905. https://bugs.webkit.org/show_bug.cgi?id=105203
  3906. Reviewed by Rob Buis.
  3907. PR255438
  3908. Here is the explanation why handles occur without selection overlay.
  3909. 1. Still touch at current selection (Selection A) initiated by touch-hold
  3910. 2. Selection expanding (Selection B) is ongoing
  3911. 3. Finger moves. In UI thread:
  3912. 1) SelectionHander::cancelSelection() gets called.
  3913. a. Selection A is canceled immediately (clear selecting state and hide handles)
  3914. b. Post a request to webkit thread to cancel Selection A.
  3915. 4. In webkit thread:
  3916. 1) Selection B becomes active selection
  3917. a. Show selection overlay for Selection B
  3918. b. Dispatch Selection B to UI thread to show handles
  3919. 2) Handle the request of canceling Selection A. The selection A was gone. Instead the active Selection B is canceled.
  3920. The visual change is Selection overlay for Selection B becomes invisible..
  3921. 5. In UI thread:
  3922. Selection B is rendered. The start handle and the end handle occur without selection overlay.
  3923. The fix is to notify client with a empty selection whenever the selection is canceled in webkit thread.
  3924. Reviewed Internally by Mike Fenton.
  3925. * WebKitSupport/SelectionHandler.cpp:
  3926. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  3927. 2012-12-17 Yong Li <yoli@rim.com>
  3928. [BlackBerry] Null pointer access in compositorDrawsRootLayer
  3929. https://bugs.webkit.org/show_bug.cgi?id=105204
  3930. Reviewed by Rob Buis.
  3931. PR# 267188.
  3932. Add a null check for m_mainFrame in the function.
  3933. * Api/WebPage.cpp:
  3934. (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
  3935. 2012-12-17 Andrew Lo <anlo@rim.com>
  3936. [BlackBerry] Use application size rather than screen size where appropriate.
  3937. https://bugs.webkit.org/show_bug.cgi?id=105201
  3938. Reviewed by Rob Buis.
  3939. Internally reviewed by Jeff Rogers.
  3940. Switch from screenSize to applicationSize where appropriate.
  3941. Internal PR266400
  3942. * Api/WebPage.cpp:
  3943. (BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
  3944. (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
  3945. * WebKitSupport/SurfacePool.cpp:
  3946. (BlackBerry::WebKit::SurfacePool::initialize):
  3947. 2012-12-17 Mike Fenton <mifenton@rim.com>
  3948. [BlackBerry] Improve DOMSupport visibleSelectionForClosestActualWordStart for content editable.
  3949. https://bugs.webkit.org/show_bug.cgi?id=105198
  3950. Reviewed by Rob Buis.
  3951. PR 258038.
  3952. Improve closest word matching by giving preference to the left when
  3953. distances are equal.
  3954. Also enforce container matching to avoid selecting the paragraph
  3955. marker if a CE div is followed immediately by a CE paragraph.
  3956. Minor refactor - don't calculate the distance if the selection
  3957. isn't on a word.
  3958. Reviewed Internally by Gen Mak and Nima Ghanavatian.
  3959. * WebKitSupport/DOMSupport.cpp:
  3960. (BlackBerry::WebKit::DOMSupport::visibleSelectionForClosestActualWordStart):
  3961. 2012-12-17 Jakob Petsovits <jpetsovits@rim.com>
  3962. [BlackBerry] Clean up log output in WebKit/blackberry.
  3963. https://bugs.webkit.org/show_bug.cgi?id=104823
  3964. Reviewed by George Staikos.
  3965. Behavior-preserving change, fixing many issues with logging:
  3966. - Call logAlways() instead of BBLOG() in already defined-out debug blocks.
  3967. - Call logAlways() instead of BBLOG() for serious errors, too.
  3968. - Fix build for the DEBUG_OVERFLOW_DETECTION block in ChromeClientBlackBerry.
  3969. - Fix build for double declarations of "elapsed" variables in RenderQueue.
  3970. - Fix compiler warnings due to format string / parameter mismatches.
  3971. - Remove unnecessary trailing newlines in logged strings.
  3972. - Consistently use Platform:: as prefix except inside WebCore-namespaced code.
  3973. - Use indentation that actually passes WebKit style checks.
  3974. - Change point/size/rect output to use Platform toString() formats for consistency.
  3975. * Api/BackingStore.cpp:
  3976. (BlackBerry::WebKit::bestDivisor):
  3977. (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
  3978. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
  3979. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  3980. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  3981. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  3982. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  3983. (BlackBerry::WebKit::BackingStorePrivate::scroll):
  3984. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  3985. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  3986. (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
  3987. (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
  3988. (BlackBerry::WebKit::BackingStorePrivate::render):
  3989. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  3990. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  3991. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  3992. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  3993. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  3994. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  3995. (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
  3996. * Api/WebPage.cpp:
  3997. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  3998. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  3999. (BlackBerry::WebKit::WebPagePrivate::contentsSizeChanged):
  4000. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  4001. (BlackBerry::WebKit::WebPage::touchEvent):
  4002. (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
  4003. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  4004. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  4005. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  4006. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  4007. (WebCore::ChromeClientBlackBerry::overflowExceedsContentsSize):
  4008. * WebKitSupport/FatFingers.cpp:
  4009. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  4010. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  4011. (BlackBerry::WebKit::FatFingers::checkForText):
  4012. * WebKitSupport/InputHandler.cpp:
  4013. (BlackBerry::WebKit::convertStringToWchar):
  4014. (BlackBerry::WebKit::convertStringToWcharVector):
  4015. (BlackBerry::WebKit::convertSpannableStringToString):
  4016. (BlackBerry::WebKit::InputHandler::learnText):
  4017. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  4018. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  4019. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  4020. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  4021. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  4022. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  4023. (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
  4024. (BlackBerry::WebKit::InputHandler::setElementFocused):
  4025. (BlackBerry::WebKit::InputHandler::spellCheckBlock):
  4026. (BlackBerry::WebKit::InputHandler::nodeTextChanged):
  4027. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  4028. (BlackBerry::WebKit::InputHandler::frameUnloaded):
  4029. (BlackBerry::WebKit::InputHandler::selectionChanged):
  4030. (BlackBerry::WebKit::InputHandler::setSelection):
  4031. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  4032. (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
  4033. (BlackBerry::WebKit::InputHandler::deleteText):
  4034. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  4035. (BlackBerry::WebKit::InputHandler::setComposingRegion):
  4036. (BlackBerry::WebKit::InputHandler::finishComposition):
  4037. (BlackBerry::WebKit::InputHandler::setText):
  4038. (BlackBerry::WebKit::InputHandler::setTextAttributes):
  4039. (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
  4040. (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
  4041. (BlackBerry::WebKit::InputHandler::setComposingText):
  4042. (BlackBerry::WebKit::InputHandler::commitText):
  4043. * WebKitSupport/RenderQueue.cpp:
  4044. (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
  4045. (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
  4046. (BlackBerry::WebKit::RenderQueue::render):
  4047. (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
  4048. (BlackBerry::WebKit::RenderQueue::startRegularRenderJobBatchIfNeeded):
  4049. (BlackBerry::WebKit::RenderQueue::renderVisibleZoomJob):
  4050. (BlackBerry::WebKit::RenderQueue::renderVisibleScrollJob):
  4051. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
  4052. (BlackBerry::WebKit::RenderQueue::renderNonVisibleScrollJob):
  4053. * WebKitSupport/SelectionHandler.cpp:
  4054. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  4055. (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
  4056. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  4057. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  4058. (BlackBerry::WebKit::SelectionHandler::setSelection):
  4059. (BlackBerry::WebKit::SelectionHandler::selectObject):
  4060. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  4061. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  4062. * WebKitSupport/SurfacePool.cpp:
  4063. (BlackBerry::WebKit::SurfacePool::initialize):
  4064. 2012-12-17 Anthony Scian <ascian@rim.com>
  4065. [Blackberry] Static code analysis warning fixes
  4066. https://bugs.webkit.org/show_bug.cgi?id=105129
  4067. Reviewed by Rob Buis.
  4068. - disable copy/op= in BackingStore
  4069. - cache and check intermediate values in parentLayer
  4070. - disable copy/op= in InRegionScroller
  4071. - disable copy/op= in WebPageGroupLoadDeferrer
  4072. - disable copy/op= in WebSettings
  4073. - disable copy/op= in WebViewportArguments
  4074. - disable copy/op= in BackingStoreClient
  4075. - disable copy/op= in TileBuffer
  4076. - if stopNode is not NULL, loop could iterate past NULL; added NULL check to loop
  4077. to make the code more robust
  4078. * Api/BackingStore.h:
  4079. * Api/InRegionScroller.cpp:
  4080. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  4081. (BlackBerry::WebKit::parentLayer):
  4082. * Api/InRegionScroller.h:
  4083. * Api/WebPageGroupLoadDeferrer.h:
  4084. * Api/WebSettings.h:
  4085. * Api/WebViewportArguments.h:
  4086. * WebKitSupport/BackingStoreClient.h:
  4087. (BackingStoreClient):
  4088. * WebKitSupport/BackingStoreTile.h:
  4089. (TileBuffer):
  4090. * WebKitSupport/DOMSupport.cpp:
  4091. (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
  4092. 2012-12-16 Arvid Nilsson <anilsson@rim.com>
  4093. [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
  4094. https://bugs.webkit.org/show_bug.cgi?id=105143
  4095. RIM PR 171941
  4096. Reviewed by Rob Buis.
  4097. Internally reviewed by George Staikos.
  4098. TouchPoint instances now provide document coordinates for the viewport
  4099. and content position of the touch event. The pixel coordinates stored
  4100. in the TouchPoint should no longer be needed in WebKit. One exception
  4101. is when passing events to a full screen plugin.
  4102. Also adapt to new method names and encapsulation of TouchPoint data
  4103. members.
  4104. * Api/WebPage.cpp:
  4105. (BlackBerry::WebKit::WebPage::touchEvent):
  4106. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  4107. (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
  4108. (BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
  4109. * WebKitSupport/InputHandler.cpp:
  4110. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  4111. * WebKitSupport/InputHandler.h:
  4112. (InputHandler):
  4113. * WebKitSupport/TouchEventHandler.cpp:
  4114. (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
  4115. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  4116. * WebKitSupport/TouchEventHandler.h:
  4117. (TouchEventHandler):
  4118. 2012-12-15 Anders Carlsson <andersca@apple.com>
  4119. Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
  4120. https://bugs.webkit.org/show_bug.cgi?id=105122
  4121. Reviewed by Andreas Kling.
  4122. Update for WebCore changes.
  4123. * Api/WebPage.h:
  4124. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  4125. (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
  4126. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  4127. (FrameLoaderClientBlackBerry):
  4128. 2012-12-16 Jacky Jiang <zhajiang@rim.com>
  4129. [BlackBerry] GUIMark3 page is rendered at a large scale during history navigation back
  4130. https://bugs.webkit.org/show_bug.cgi?id=105130
  4131. Reviewed by George Staikos.
  4132. PR: 265999
  4133. During history navigation, UI thread can blit the contents at a bad
  4134. view state before WebKit thread restores the view state.
  4135. Suspend screen updates before goBackOrForward() and resume thereafter
  4136. so that screen can be updated after the correct view state is updated.
  4137. No need to render or blit here, as goBackOrForward() can dispatch a
  4138. message to WebKit thread to do that in WebPagePrivate::restoreHistoryViewState().
  4139. * Api/WebPage.cpp:
  4140. (BlackBerry::WebKit::WebPage::goBackOrForward):
  4141. 2012-12-15 Nima Ghanavatian <nghanavatian@rim.com>
  4142. [BlackBerry] Pass key modifiers with touch and mouse events
  4143. https://bugs.webkit.org/show_bug.cgi?id=105108
  4144. Reviewed by Rob Buis.
  4145. Pass key modifiers to allow for added functionality, such as
  4146. shift+click to highlight.
  4147. Internally reviewed by Gen Mak.
  4148. * Api/WebPage.cpp:
  4149. (BlackBerry::WebKit::WebPagePrivate::webContext):
  4150. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  4151. (BlackBerry::WebKit::WebPage::mouseEvent):
  4152. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  4153. * Api/WebPage.h:
  4154. * WebKitSupport/TouchEventHandler.cpp:
  4155. (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
  4156. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  4157. (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
  4158. * WebKitSupport/TouchEventHandler.h:
  4159. (TouchEventHandler):
  4160. 2012-12-15 Nima Ghanavatian <nghanavatian@rim.com>
  4161. [BlackBerry] Clean up allocated memory from InputMethodSupport
  4162. https://bugs.webkit.org/show_bug.cgi?id=105110
  4163. Reviewed by Rob Buis.
  4164. PR265919
  4165. We are deep copying the spannable_string from IMF and freeing
  4166. here once we're done with it.
  4167. Internally reviewed by Jeff Rogers.
  4168. * WebKitSupport/InputHandler.cpp:
  4169. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  4170. 2012-12-14 Parth Patel <parpatel@rim.com>
  4171. [BlackBerry] Allow plugins to be disabled by shared library filename
  4172. https://bugs.webkit.org/show_bug.cgi?id=101274
  4173. Reviewed by Yong Li.
  4174. Fixing build error.
  4175. * Api/WebPage.cpp:
  4176. (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
  4177. 2012-12-13 Jacky Jiang <zhajiang@rim.com>
  4178. [BlackBerry][Fullscreen] Exiting fullscreen does not set the correct scroll position
  4179. https://bugs.webkit.org/show_bug.cgi?id=104958
  4180. Reviewed by Antonio Gomes.
  4181. Internally reviewed by Arvid Nilsson and Max Feil.
  4182. PR: 231174
  4183. When leaving fullscreen, WebPage scale and scroll position can't return
  4184. to the original scale and scroll position.
  4185. We can't restore them in WebPagePrivate::exitFullScreenForElement()
  4186. as they can still be changed thereafter during the async
  4187. setViewportSize(). And also the async setViewportSize() from the app
  4188. side isn't guaranteed as some apps don't need to resize the viewport if
  4189. their windows are already fullscreen.
  4190. The restoration is basically only needed if viewport size is changed.
  4191. At the point of entering fullscreen, we can safely assume that there
  4192. would be a viewport size change thereafter if the current visible size
  4193. and screen size are not equal. Based on this assumption, we can save
  4194. the scale and position before entering fullscreen and restore them in
  4195. setViewportSize() thereafter.
  4196. * Api/WebPage.cpp:
  4197. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  4198. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  4199. * Api/WebPage_p.h:
  4200. (WebPagePrivate):
  4201. 2012-12-13 Yong Li <yoli@rim.com>
  4202. [BlackBerry] Possible JS re-entrancy caused by UI event handler
  4203. https://bugs.webkit.org/show_bug.cgi?id=84862
  4204. Reviewed by Rob Buis.
  4205. Fix an obvious bug in previous patch.
  4206. * Api/WebPage.cpp:
  4207. (BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
  4208. 2012-12-13 Parth Patel <parpatel@rim.com>, Max Feil <mfeil@rim.com>
  4209. Allow plugins to be disabled by shared library filename
  4210. https://bugs.webkit.org/show_bug.cgi?id=101274
  4211. Reviewed by Antonio Gomes.
  4212. Mechanism allows plugins to be disabled by specifying their shared library filenames.
  4213. Once disabled, a plugin's shared library should never be loaded.
  4214. * Api/WebPage.cpp:
  4215. (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
  4216. (WebKit):
  4217. (BlackBerry::WebKit::WebPage::updateDisabledPluginFiles):
  4218. * Api/WebPage.h:
  4219. 2012-12-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  4220. NetworkInfoController needs to support destructor
  4221. https://bugs.webkit.org/show_bug.cgi?id=104642
  4222. Reviewed by Kentaro Hara.
  4223. Though NetworkInfoController can be referenced by each port in order to update network status change,
  4224. there is no virtual interface to destroy it. Beside each port client also needs to be destroyed when
  4225. controller is destroyed.
  4226. * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
  4227. (WebCore::NetworkInfoClientBlackBerry::networkInfoControllerDestroyed):
  4228. (WebCore):
  4229. * WebCoreSupport/NetworkInfoClientBlackBerry.h:
  4230. (NetworkInfoClientBlackBerry):
  4231. 2012-12-12 Mike Lattanzio <mlattanzio@rim.com>
  4232. [BlackBerry] Ensure InRegionScrollableArea is valid before using.
  4233. https://bugs.webkit.org/show_bug.cgi?id=104832
  4234. Reviewed by Antonio Gomes.
  4235. Make sure the InRegionScrollableArea we are about to scroll is
  4236. still valid by ensuring its present in our cache of scrollable areas.
  4237. Internal PR: 258475
  4238. Internal Review: Gen Mak
  4239. We cache a RefPtr for each scrollable area at the time we discover them,
  4240. but this cache can get cleared anytime and then the references will be
  4241. released. If a request comes in to scroll a region which no longer
  4242. exists we have to ignore it.
  4243. * Api/InRegionScroller.cpp:
  4244. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
  4245. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
  4246. (BlackBerry::WebKit::InRegionScrollerPrivate::isValidScrollableLayerWebKitThread):
  4247. (WebKit):
  4248. (BlackBerry::WebKit::InRegionScrollerPrivate::isValidScrollableNode):
  4249. * Api/InRegionScroller_p.h:
  4250. (WebCore):
  4251. (InRegionScrollerPrivate):
  4252. * WebKitSupport/InRegionScrollableArea.cpp:
  4253. (BlackBerry::WebKit::InRegionScrollableArea::cachedScrollableLayer):
  4254. (WebKit):
  4255. (BlackBerry::WebKit::InRegionScrollableArea::cachedScrollableNode):
  4256. * WebKitSupport/InRegionScrollableArea.h:
  4257. (InRegionScrollableArea):
  4258. 2012-12-12 Mark Lam <mark.lam@apple.com>
  4259. Encapsulate externally used webdatabase APIs in DatabaseManager.
  4260. https://bugs.webkit.org/show_bug.cgi?id=104741.
  4261. Reviewed by Sam Weinig.
  4262. Use DatabaseManager instead of accessing DatabaseTracker, AbstractDatabase,
  4263. and DatabaseContext directly. This is to prepare for upcoming webkit2
  4264. refactoring.
  4265. * Api/WebPage.cpp:
  4266. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  4267. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  4268. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  4269. 2012-12-12 Mike Fenton <mifenton@rim.com>
  4270. [BlackBerry] Fix word matching algorithm to account for adjacent divs with no whitespace between them.
  4271. https://bugs.webkit.org/show_bug.cgi?id=104837
  4272. Reviewed by Rob Buis.
  4273. PR 258038.
  4274. Fix selection at the end of content editable text block.
  4275. The next character may be in the next block bypassing the distance
  4276. comparison logic we have, remove the check for next character being
  4277. whitespace
  4278. Reviewed Internally by Nima Ghanavatian.
  4279. * WebKitSupport/DOMSupport.cpp:
  4280. (BlackBerry::WebKit::DOMSupport::visibleSelectionForClosestActualWordStart):
  4281. 2012-12-12 Alexey Proskuryakov <ap@apple.com>
  4282. Make LOG() work in WebProcess and NetworkProcess
  4283. https://bugs.webkit.org/show_bug.cgi?id=104718
  4284. Reviewed by Tim Horton.
  4285. * Api/BlackBerryGlobal.cpp: Include InitializeLogging.h
  4286. 2012-12-11 Kihong Kwon <kihong.kwon@samsung.com>
  4287. Vibration API: IDL type doesn't match implementation type
  4288. https://bugs.webkit.org/show_bug.cgi?id=103899
  4289. Reviewed by Kentaro Hara.
  4290. According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
  4291. Therefore unsigned long need to be changed to unsigned for the Vibration API.
  4292. - Change a parameter type of vibrate function from unsigned long to unsigned.
  4293. * WebCoreSupport/VibrationClientBlackBerry.cpp:
  4294. (WebCore::VibrationClientBlackBerry::vibrate):
  4295. * WebCoreSupport/VibrationClientBlackBerry.h:
  4296. (VibrationClientBlackBerry):
  4297. 2012-12-11 Nima Ghanavatian <nghanavatian@rim.com>
  4298. [BlackBerry] Redraw spell check dialog after rotation.
  4299. https://bugs.webkit.org/show_bug.cgi?id=104737
  4300. Reviewed by Rob Buis.
  4301. After rotating the device, all dialogs are dismissed. We should
  4302. restore the spell check dialog as it is still valid after
  4303. rotation and the user will expect it there.
  4304. Internally reviewed by Mike Fenton and Gen Mak.
  4305. * Api/WebPage.cpp:
  4306. (BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
  4307. 2012-12-11 Nima Ghanavatian <nghanavatian@rim.com>
  4308. [BlackBerry] Shift the spell check dialog to align with text after transformation
  4309. https://bugs.webkit.org/show_bug.cgi?id=104716
  4310. Reviewed by Rob Buis.
  4311. PR245033
  4312. As the page is transformed, we should redraw the dialog box to align
  4313. with the new text position. We send a message to move the dialog
  4314. box from different spots to account for scrolling. This includes
  4315. keyboard transitions from hidden to displayed and centering of
  4316. focus around a new touch point. We do not reposition on manual user
  4317. scrolling of the page, as this simply dismisses the dialog.
  4318. Internally reviewed by Mike Fenton and Gen Mak.
  4319. * Api/WebPage.cpp:
  4320. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  4321. * Api/WebPageClient.h:
  4322. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  4323. (WebCore::ChromeClientBlackBerry::scroll):
  4324. * WebKitSupport/InputHandler.cpp:
  4325. (BlackBerry::WebKit::InputHandler::InputHandler):
  4326. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  4327. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  4328. (BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
  4329. (WebKit):
  4330. * WebKitSupport/InputHandler.h:
  4331. (InputHandler):
  4332. (BlackBerry::WebKit::InputHandler::clearDidSpellCheckState):
  4333. (BlackBerry::WebKit::InputHandler::didSpellCheckWord):
  4334. * WebKitSupport/TouchEventHandler.cpp:
  4335. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  4336. 2012-12-11 Genevieve Mak <gmak@rim.com>
  4337. [BlackBerry] Avoid multiple calls to fat fingers
  4338. https://bugs.webkit.org/show_bug.cgi?id=104703
  4339. Reviewed by Rob Buis.
  4340. We already run fat fingers on touch start. No need to do it again
  4341. in the general use case.
  4342. * WebKitSupport/TouchEventHandler.cpp:
  4343. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  4344. 2012-12-11 Mike West <mkwst@chromium.org>
  4345. Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector.
  4346. https://bugs.webkit.org/show_bug.cgi?id=66371
  4347. Reviewed by Pavel Feldman.
  4348. Drops WebCore::MessageType from the addMessageToConsole method.
  4349. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  4350. (WebCore::ChromeClientBlackBerry::addMessageToConsole):
  4351. * WebCoreSupport/ChromeClientBlackBerry.h:
  4352. (ChromeClientBlackBerry):
  4353. 2012-12-10 Max Feil <mfeil@rim.com>
  4354. [BlackBerry] Flash content is being rendered as garbled characters when Flashplayer is disabled
  4355. https://bugs.webkit.org/show_bug.cgi?id=104505
  4356. Reviewed by Antonio Gomes.
  4357. The check to allow video and audio as the source of embed and
  4358. object elements is causing a problem when the Flashplayer plugin
  4359. is disabled. We have to take Flash content into account in this
  4360. check otherwise the swf contents will be rendered as garbled
  4361. text characters where there should just be blank space.
  4362. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  4363. (WebCore::FrameLoaderClientBlackBerry::createPlugin):
  4364. 2012-12-10 Parth Patel <parpatel@rim.com>
  4365. [BlackBerry] Make hiddenPageDomTimerInterval a setting
  4366. https://bugs.webkit.org/show_bug.cgi?id=104555
  4367. Reviewed by Yong Li.
  4368. HiddenPageDomTimerInterval in setting in webcore can be utilized by browser application
  4369. when needed.
  4370. * Api/BlackBerryGlobal.cpp:
  4371. (BlackBerry::WebKit::globalInitialize):
  4372. 2012-12-10 Nima Ghanavatian <nghanavatian@rim.com>
  4373. [BlackBerry] Fix warning for comparison between signed and unsigned
  4374. https://bugs.webkit.org/show_bug.cgi?id=104563
  4375. Reviewed by Rob Buis.
  4376. * WebKitSupport/InputHandler.cpp:
  4377. (BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
  4378. 2012-12-10 Charles Wei <charles.wei@torchmobile.com.cn>
  4379. [BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
  4380. https://bugs.webkit.org/show_bug.cgi?id=104504
  4381. Reviewed by George Staikos.
  4382. When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
  4383. to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
  4384. doing a blit after it has deleted the viewport accessor and before the webkit thread gets
  4385. the time slot to resume it's operation to clean up the webview, which leaves a very short
  4386. time that viewport accessor of a webpage has been deleted while the webpage is still in
  4387. the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.
  4388. So we need to check if the viewport accessor is NULL before using it in the backingstore code.
  4389. * Api/BackingStore.cpp:
  4390. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  4391. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  4392. 2012-12-10 Kent Tamura <tkent@chromium.org>
  4393. Refactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
  4394. https://bugs.webkit.org/show_bug.cgi?id=104508
  4395. Reviewed by Kentaro Hara.
  4396. * WebKitSupport/InputHandler.cpp:
  4397. (BlackBerry::WebKit::InputHandler::openDatePopup): Use isDisabledOrReadOnly.
  4398. (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
  4399. 2012-12-08 Jacky Jiang <zhajiang@rim.com>
  4400. [BlackBerry] Google results page rendering issue with RTL languages like arabic/hebrew
  4401. https://bugs.webkit.org/show_bug.cgi?id=104451
  4402. Reviewed by Rob Buis.
  4403. PR: 206372
  4404. On Google results page, we layout the contents at the width of 833.
  4405. However, "appbar" and "top_nav" elements which have width 980 cause
  4406. overflow during the last layout and make the contents width larger.
  4407. The other renderers still stay at the old width unfortunately which
  4408. results in blank areas on the left side of the Google results RTL page.
  4409. Give it a chance to request another layout if overflow exceeds the
  4410. contents size and the page doesn't have virtual viewport, as this
  4411. layout will pick up the absolute visible overflow width within
  4412. DEFAULT_MAX_LAYOUT_WIDTH and update the other renderers.
  4413. * Api/WebPage.cpp:
  4414. (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
  4415. (WebKit):
  4416. * Api/WebPage_p.h:
  4417. (WebPagePrivate):
  4418. 2012-12-08 Mike Fenton <mifenton@rim.com>
  4419. [BlackBerry] Enforce selection of last work when triggering caret based selection
  4420. https://bugs.webkit.org/show_bug.cgi?id=104447
  4421. Reviewed by Rob Buis.
  4422. PR 249225.
  4423. When the selection has reached the end of an input field,
  4424. ensure the last word is selected by adjusting the caret.
  4425. Reviewed Internally by Gen Mak.
  4426. * WebKitSupport/InputHandler.cpp:
  4427. (BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
  4428. (WebKit):
  4429. * WebKitSupport/InputHandler.h:
  4430. (InputHandler):
  4431. * WebKitSupport/SelectionHandler.cpp:
  4432. (BlackBerry::WebKit::SelectionHandler::selectObject):
  4433. 2012-12-08 Chris Hutten-Czapski <chutten@rim.com>
  4434. [BlackBerry] Remove about:credits
  4435. https://bugs.webkit.org/show_bug.cgi?id=104399
  4436. Reviewed by Rob Buis.
  4437. Just a simple removal.
  4438. * WebKitSupport/AboutData.cpp:
  4439. 2012-12-08 Rob Buis <rbuis@rim.com>
  4440. [BlackBerry] Remove no-op line in WebPage.cpp
  4441. https://bugs.webkit.org/show_bug.cgi?id=104385
  4442. Reviewed by Antonio Gomes.
  4443. Remove self-assignment no-op line. Must have been left when I removed the
  4444. mapFromTransformed part.
  4445. * Api/WebPage.cpp:
  4446. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  4447. 2012-12-07 Nima Ghanavatian <nghanavatian@rim.com>
  4448. [BlackBerry] General code cleanup and improved logging.
  4449. https://bugs.webkit.org/show_bug.cgi?id=104389
  4450. Reviewed by Rob Buis.
  4451. Internally reviewed by Mike Fenton
  4452. * WebKitSupport/InputHandler.cpp:
  4453. (BlackBerry::WebKit::convertStringToWchar):
  4454. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  4455. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  4456. 2012-12-07 Nima Ghanavatian <nghanavatian@rim.com>
  4457. [BlackBerry] Strip whitespace from learned text.
  4458. https://bugs.webkit.org/show_bug.cgi?id=104391
  4459. Reviewed by Rob Buis.
  4460. This was removing the first word from the sentence being learned. Using
  4461. stripWhiteSpace to remove spaces from the start and end of the text.
  4462. Internally reviewed by Mike Fenton.
  4463. * WebKitSupport/InputHandler.cpp:
  4464. (BlackBerry::WebKit::InputHandler::learnText):
  4465. 2012-12-07 Otto Derek Cheung <otcheung@rim.com>
  4466. [BlackBerry] GeolocationClientBB should show file system path in prompts when host is not avaliable
  4467. https://bugs.webkit.org/show_bug.cgi?id=103785
  4468. PR 247656
  4469. Reviewed by Rob Buis.
  4470. Adding a special case for origins with protocol "file". We will use the filepath as
  4471. an origin when asking for geolocation permission.
  4472. If the origin is unique (ie. from a sandboxed iframe), we will fail the location request
  4473. right away.
  4474. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  4475. (getOrigin):
  4476. (GeolocationClientBlackBerry::requestPermission):
  4477. (GeolocationClientBlackBerry::cancelPermissionRequest):
  4478. 2012-12-07 Mike Lattanzio <mlattanzio@rim.com>
  4479. [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
  4480. https://bugs.webkit.org/show_bug.cgi?id=104121
  4481. Reviewed by Rob Buis.
  4482. Update createBuffer calls to reflect new BufferType enum.
  4483. Set buffers opaque if possible to avoid unnecessary blends.
  4484. Internal PR 254649
  4485. Internal Review: Jakob Petsovits
  4486. * WebKitSupport/BackingStoreTile.cpp:
  4487. (BlackBerry::WebKit::TileBuffer::nativeBuffer):
  4488. 2012-12-07 Andrew Lo <anlo@rim.com>
  4489. [BlackBerry] Double zoom animation when focusing on input field.
  4490. https://bugs.webkit.org/show_bug.cgi?id=104375
  4491. Reviewed by Rob Buis.
  4492. Internally reviewed by Jakob Petsovits.
  4493. UI thread does not need to be notified of a scale change if the WebKit
  4494. thread scale has not changed.
  4495. This caused issues when two viewport resizes occured one after the other.
  4496. Before the scale change due to the first resize could be set in the WK
  4497. thread's scale value, it caused WK thread to dispatch a scaleChanged,
  4498. overwritting & resetting the new UI thread scale value, resulting in the
  4499. double zoom animation.
  4500. The larger issue dealing with synchronization between the threads where
  4501. scale changes could occur on either thread, however that is beyond the
  4502. scope of this change.
  4503. Internal PR253122
  4504. * Api/WebPage.cpp:
  4505. (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
  4506. 2012-12-07 Xiaobo Wang <xbwang@torchmobile.com.cn>
  4507. [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
  4508. https://bugs.webkit.org/show_bug.cgi?id=104243
  4509. RIM PR 259337
  4510. Reviewed by Rob Buis.
  4511. 1. Add DRT callback in dispatchDecidePolicyForResponse.
  4512. 2. Pass frame pointer to DRT callback in
  4513. dispatchDecidePolicyForNavigationAction, so that it can be used to
  4514. calculate originating.
  4515. 3. Fix some webkit style errors.
  4516. The patch fixed the following tests:
  4517. - http/tests/download
  4518. - fast/forms/mailto/formenctype-attribute-button-html.html
  4519. - fast/forms/mailto/formenctype-attribute-input-html.html
  4520. - fast/encoding/mailto-always-utf-8.html
  4521. * Api/DumpRenderTreeClient.h:
  4522. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  4523. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
  4524. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  4525. (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
  4526. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  4527. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  4528. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  4529. (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
  4530. 2012-12-05 Otto Derek Cheung <otcheung@rim.com>
  4531. [BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
  4532. https://bugs.webkit.org/show_bug.cgi?id=104162
  4533. PR 257505
  4534. Reviewed by Yong Li.
  4535. GeolocationClientBlackBerry will register itself to GeolocationHandler when it has
  4536. a pending request. When browser responds with WebPageClientImpl::setAllowGeolocation,
  4537. we go through the list and let all the pending GeolocationListeners know that a certain
  4538. origin has been aceepted/denied.
  4539. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  4540. (GeolocationClientBlackBerry::geolocationDestroyed):
  4541. (GeolocationClientBlackBerry::requestPermission):
  4542. (GeolocationClientBlackBerry::cancelPermissionRequest):
  4543. (GeolocationClientBlackBerry::onPermission):
  4544. 2012-12-05 Jakob Petsovits <jpetsovits@rim.com>
  4545. [BlackBerry] Better crash fix for resetting tiles on a backingstore takeover.
  4546. https://bugs.webkit.org/show_bug.cgi?id=103969
  4547. RIM PR 258415
  4548. Reviewed by Adam Treat.
  4549. The previous attempt for releasing tile buffers from the
  4550. previously active backingstore did not take into account
  4551. that resetTiles() would sometimes return early without
  4552. having swapped the tiles and thus reclaiming them.
  4553. This patch removes the early returns, because it's safe
  4554. to swap in an empty geometry at any time and we should
  4555. always take the chance when we get it.
  4556. Also put the code that calls resetTiles() on an owner
  4557. switch right into setCurrentBackingStoreOwner(), so that
  4558. it will also release the buffers when the BackingStore
  4559. is destroyed (the function is then called with 0).
  4560. * Api/BackingStore.cpp:
  4561. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  4562. (WebKit):
  4563. (BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
  4564. * Api/BackingStore.h: Had to add the friend here to make the moved code work from the static function.
  4565. * Api/BackingStore_p.h:
  4566. (BackingStorePrivate):
  4567. * Api/WebPage.cpp:
  4568. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  4569. 2012-12-05 Jakob Petsovits <jpetsovits@rim.com>
  4570. [BlackBerry] Keep screen updates suspended until after a viewport resize.
  4571. https://bugs.webkit.org/show_bug.cgi?id=104041
  4572. Reviewed by Adam Treat.
  4573. Now that screen and backing store updates can be suspended
  4574. and resumed separately from each other, prevent blits for
  4575. the whole duration of setViewportSize() and always issue
  4576. a blit at the end.
  4577. Makes WebPage::setViewportSize() more robust in threaded usage,
  4578. easier to read/understand, and gets rid of a couple of FIXMEs.
  4579. * Api/WebPage.cpp:
  4580. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  4581. 2012-12-05 Andrew Lo <anlo@rim.com>
  4582. [BlackBerry] Scroll position shifts while FCC & selection handle are dragged
  4583. https://bugs.webkit.org/show_bug.cgi?id=104156
  4584. Reviewed by Rob Buis.
  4585. Internally reviewed by Mike Fenton.
  4586. Only ensureFocusTextElementVisible on selectionChanged when
  4587. an element is being re-focused.
  4588. Internal PR256329
  4589. * WebKitSupport/InputHandler.cpp:
  4590. (BlackBerry::WebKit::InputHandler::InputHandler):
  4591. (BlackBerry::WebKit::InputHandler::setElementFocused):
  4592. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  4593. (BlackBerry::WebKit::InputHandler::selectionChanged):
  4594. * WebKitSupport/InputHandler.h:
  4595. (InputHandler):
  4596. 2012-12-05 Leo Yang <leoyang@rim.com>
  4597. [BlackBerry] Enable CSS_IMAGE_RESOLUTION
  4598. https://bugs.webkit.org/show_bug.cgi?id=104132
  4599. Reviewed by Yong Li.
  4600. * WebCoreSupport/AboutDataEnableFeatures.in:
  4601. 2012-12-05 Jacky Jiang <zhajiang@rim.com>
  4602. [BlackBerry] meta viewport pages are rendered at a bad initial scale
  4603. https://bugs.webkit.org/show_bug.cgi?id=104122
  4604. Reviewed by Rob Buis.
  4605. Internally reviewed by Arvid Nilsson.
  4606. PR: 240378
  4607. Many websites are rendered at a very bad initial scale because they
  4608. both specify meta viewport tag and have large width elements. In such
  4609. a case we will think the meta viewport tag is broken if the width of
  4610. any element is larger than the calculated layout viewport width.
  4611. The fix to this is straightforward that we will zoom the page to fit
  4612. the screen to have better user experience instead of respecting the
  4613. meta viewport. This can fix the issue on the websites such as
  4614. www.travelpod.com, www.forbes.com, interfacelift.com, www.sky.com,
  4615. raphaeljs.com and so on.
  4616. If non-empty m_userViewportArguments is applied, then we will force to
  4617. respect the viewport arguments. In this way we will restrict the fix to
  4618. browser only.
  4619. * Api/WebPage.cpp:
  4620. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  4621. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  4622. (BlackBerry::WebKit::WebPagePrivate::respectViewport):
  4623. (WebKit):
  4624. (BlackBerry::WebKit::WebPagePrivate::initialScale):
  4625. (BlackBerry::WebKit::WebPagePrivate::maximumScale):
  4626. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  4627. * Api/WebPage_p.h:
  4628. (BlackBerry::WebKit::WebPagePrivate::isUserScalable):
  4629. (WebPagePrivate):
  4630. (BlackBerry::WebKit::WebPagePrivate::minimumScale):
  4631. 2012-12-05 Otto Derek Cheung <otcheung@rim.com>
  4632. [BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
  4633. https://bugs.webkit.org/show_bug.cgi?id=104123
  4634. PR 256089
  4635. Reviewed by Yong Li.
  4636. Add a mapping between origin URL and it's geolocation object so we could
  4637. respond to the correct geolocation when libwebview responds with onPermission
  4638. in GeolocationClient.
  4639. Using the mapping, we could also prevent requestGeolocation requests from the same origin
  4640. to be sent twice. This prevents pages that hold two iframes to the same resource to request
  4641. geolocation permission on the same security origin twice.
  4642. Tested this by running a page that includes 2 or more iframes that requests geolocation
  4643. permission.
  4644. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  4645. (GeolocationClientBlackBerry::requestPermission):
  4646. (GeolocationClientBlackBerry::cancelPermissionRequest):
  4647. (GeolocationClientBlackBerry::onPermission):
  4648. * WebCoreSupport/GeolocationClientBlackBerry.h:
  4649. (GeolocationClientBlackBerry):
  4650. 2012-12-05 Yongxin Dai <yodai@rim.com>
  4651. [BlackBerry] Avoid showing FCC on empty text field in a different way
  4652. https://bugs.webkit.org/show_bug.cgi?id=104019
  4653. Reviewed by Rob Buis.
  4654. PR #222796
  4655. Add text field empty flag along with the caret change notification so that
  4656. FineCursorContnrol is able to avoid showing FCC on empty text filed.
  4657. Previous approach, notifying client with empty caret on empty text field,
  4658. causes problem. Its code is removed.
  4659. Reviewed Internally by Mike Fenton.
  4660. * Api/WebPageClient.h:
  4661. * WebKitSupport/SelectionHandler.cpp:
  4662. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  4663. 2012-12-04 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  4664. [BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar
  4665. https://bugs.webkit.org/show_bug.cgi?id=103874
  4666. PR245678
  4667. Reviewed by Rob Buis.
  4668. Internally reviewed by Mike Fenton.
  4669. When the virtual keyboard is hiding, the viewport is changed and the page needs
  4670. to relayout.At the same time, the user interface thread is executing compositeLayers
  4671. and it will dispatch the updateDelegatedOverlays() to webkit thread which will trigger
  4672. the selectionPositionChanged() in webkit thread.
  4673. When the selectionPositionChanged() calls frame->selection()->selection().
  4674. visibleStart() and frame->selection()->selection().visibleEnd(), it will
  4675. trigger page relayout and return the relayouted selection start and end position.
  4676. These positions are out of the range which is recorded before its relayout.
  4677. As a result it think the selection start and end are all clipped out and it send
  4678. out an "empty selection"(not selected) changing event.
  4679. When the WebPageClient receives the empty selection changing event, it will consider
  4680. the selection process aborted and might cancel selection-related user interaction.
  4681. This is not what we intend to happen.
  4682. This patch stops the changing handling process and returns when the page needs relayout,
  4683. and the selection will be updated again when the page finishs relayout.
  4684. * WebKitSupport/SelectionHandler.cpp:
  4685. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  4686. 2012-12-04 Andrew Lo <anlo@rim.com>
  4687. [BlackBerry] Scroll adjustments while typing scroll off page, then bounce back.
  4688. https://bugs.webkit.org/show_bug.cgi?id=104045
  4689. Reviewed by Rob Buis.
  4690. Internally reviewed by Mike Fenton & Jakob Petsovits.
  4691. Internal PR253845
  4692. The main frame's view should only be temporarily set to
  4693. not constrain scrolling to the content edge while the
  4694. scroll position is set at the end of the scroll animation.
  4695. Remove ensureFocusTextElementVisible from setSpannableTextAndRelativeCursor
  4696. in InputHandler since FrameSelection::revealSelection
  4697. already implements scroll adjustments due to typing.
  4698. * Api/WebPage.cpp:
  4699. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  4700. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  4701. (BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
  4702. * Api/WebPage_p.h:
  4703. (WebPagePrivate):
  4704. * WebKitSupport/InputHandler.cpp:
  4705. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  4706. (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
  4707. 2012-12-04 Mike Fenton <mifenton@rim.com>
  4708. [BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHandler::spannableTextInRange
  4709. https://bugs.webkit.org/show_bug.cgi?id=104001
  4710. Reviewed by Rob Buis.
  4711. PR 257723.
  4712. Remove assert and update early return to allow out of bounds
  4713. request at end of field.
  4714. Reviewed Internally by Gen Mak.
  4715. * WebKitSupport/InputHandler.cpp:
  4716. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  4717. 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
  4718. [BlackBerry] Store rendered regions in pixel contents coordinates.
  4719. https://bugs.webkit.org/show_bug.cgi?id=103930
  4720. PR 253496
  4721. Reviewed by Rob Buis.
  4722. Internally reviewed by Adam Treat.
  4723. Previously, the rendered region of a tile used to be
  4724. stored in coordinates relative to the tile origin.
  4725. This brings no benefits whatsoever and causes a lot
  4726. of unnecessary transformations, together with the
  4727. potential of incorrectly transforming rendered regions.
  4728. By storing the rendered region as what it is,
  4729. everything is more compact, easier to understand
  4730. and easier to use with other existing functionality.
  4731. * Api/BackingStore.cpp:
  4732. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  4733. (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
  4734. (BlackBerry::WebKit::BackingStorePrivate::render):
  4735. (BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
  4736. (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
  4737. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  4738. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  4739. (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
  4740. (BlackBerry::WebKit::BackingStorePrivate::isTileVisible):
  4741. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  4742. (BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
  4743. (BlackBerry::WebKit::BackingStorePrivate::tileContentsRect):
  4744. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  4745. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  4746. (BlackBerry::WebKit::BackingStorePrivate::mapFromPixelContentsToTiles):
  4747. (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
  4748. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  4749. * Api/BackingStore_p.h:
  4750. (BackingStorePrivate):
  4751. * WebKitSupport/BackingStoreTile.cpp:
  4752. (BlackBerry::WebKit::TileBuffer::surfaceRect):
  4753. (BlackBerry::WebKit::TileBuffer::pixelContentsRect):
  4754. (WebKit):
  4755. (BlackBerry::WebKit::TileBuffer::isRendered):
  4756. (BlackBerry::WebKit::TileBuffer::notRenderedRegion):
  4757. * WebKitSupport/BackingStoreTile.h:
  4758. (TileBuffer):
  4759. 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
  4760. [BlackBerry] Use updated API for backingstore tiles.
  4761. https://bugs.webkit.org/show_bug.cgi?id=103970
  4762. PR 212369
  4763. Reviewed by George Staikos.
  4764. Internally reviewed by Arvid Nilsson.
  4765. We now make use of Platform::Settings::tileSize() in the
  4766. backingstore and don't hardcode the number of back buffers
  4767. like we used to.
  4768. * Api/BackingStore.cpp:
  4769. (BlackBerry::WebKit::bestDivisor):
  4770. (BlackBerry::WebKit::BackingStorePrivate::tileWidth):
  4771. (BlackBerry::WebKit::BackingStorePrivate::tileHeight):
  4772. (BlackBerry::WebKit::BackingStorePrivate::tileSize):
  4773. * WebKitSupport/AboutData.cpp:
  4774. (BlackBerry::WebKit::configPage):
  4775. * WebKitSupport/SurfacePool.cpp:
  4776. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  4777. (BlackBerry::WebKit::SurfacePool::numberOfBackingStoreFrontBuffers):
  4778. (BlackBerry::WebKit::SurfacePool::initialize):
  4779. * WebKitSupport/SurfacePool.h:
  4780. (SurfacePool):
  4781. 2012-12-04 Jakob Petsovits <jpetsovits@rim.com>
  4782. [BlackBerry] On taking over a backingstore, reset the previous page's tiles.
  4783. https://bugs.webkit.org/show_bug.cgi?id=103969
  4784. RIM PR 253496
  4785. Reviewed by George Staikos.
  4786. With buffers being explicitly reclaimed from backingstore
  4787. geometries, we have to make sure that the previously
  4788. active backingstore releases its front buffers for use
  4789. in the newly active one.
  4790. Previously, this clearing of backingstore tiles occurred
  4791. after the dormant backingstore is reactivated,
  4792. the backingstore active in the meantime would just use
  4793. the back buffer anyway and leave the dormant one with
  4794. dangling pointers that would just not be shown.
  4795. Now that we have a counted list of back buffers,
  4796. we need to be explicit about this thing upfront.
  4797. Fixes a crash that would occur after switching ownership
  4798. of the backingstore to a different WebPage.
  4799. * Api/WebPage.cpp:
  4800. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  4801. 2012-12-03 Jakob Petsovits <jpetsovits@rim.com>
  4802. [BlackBerry] Refactor the backingstore to swap full geometries.
  4803. https://bugs.webkit.org/show_bug.cgi?id=103924
  4804. RIM PR 253496
  4805. Reviewed by Yong Li.
  4806. Internally reviewed by Adam Treat and Arvid Nilsson.
  4807. The backingstore had a working split between front and
  4808. back state, but it was multilayered and hard to grasp.
  4809. This commit cleanly divides the responsibilities of
  4810. BackingStoreGeometry and TileBuffer, with the latter
  4811. now being able to function on its own without the help
  4812. of its geometry. The BackingStoreTile class was an
  4813. unnecessary middleman and can be removed wholesale.
  4814. A BackingStoreGeometry can now function with null tiles
  4815. being assigned to its indices, which enables us to reclaim
  4816. tile buffers outside of the visible contents area as back
  4817. buffers. This reduces the need to swap and block when the
  4818. backingstore size exceeds the contents size, and also lets
  4819. us use more tiles for initial rendering after a call to
  4820. resetTiles() which is now implemented as swapping in a
  4821. geometry with only null buffers.
  4822. setBackingStoreRect() was the only function that had to
  4823. get a change of behavior. Because we're now constructing
  4824. new BackingStoreGeometry objects every time the front
  4825. geometry is being exchanged for a new one, it is only
  4826. safe to call other functions reliant on the new geometry
  4827. after it has been finalized and put in place. Therefore,
  4828. updateTilesForScrollOrNotRenderedRegion() takes on the
  4829. render queue maintenance tasks that setBackingStoreRect()
  4830. had performed previously. It was already doing something
  4831. very similar so only few changes to the function were
  4832. necessary.
  4833. This commit will make subsequent changes to the
  4834. backingstore geometry and tile logic a lot easier.
  4835. * Api/BackingStore.cpp:
  4836. (BlackBerry::WebKit::BackingStoreGeometry::isTileCorrespondingToBuffer):
  4837. (WebKit):
  4838. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  4839. (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
  4840. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  4841. (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
  4842. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  4843. (BlackBerry::WebKit::BackingStorePrivate::clearRenderedRegion):
  4844. (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
  4845. (BlackBerry::WebKit::BackingStorePrivate::render):
  4846. (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
  4847. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  4848. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  4849. (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
  4850. (BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
  4851. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  4852. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  4853. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  4854. (BlackBerry::WebKit::BackingStorePrivate::mapFromTilesToTransformedContents):
  4855. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  4856. (BlackBerry::WebKit::BackingStorePrivate::transformChanged):
  4857. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  4858. (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
  4859. (BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
  4860. * Api/BackingStore_p.h:
  4861. (WebKit):
  4862. (BackingStoreGeometry):
  4863. (BlackBerry::WebKit::BackingStoreGeometry::tileBufferAt):
  4864. (BackingStorePrivate):
  4865. * Api/WebPage.cpp:
  4866. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  4867. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  4868. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  4869. * Api/WebPage_p.h:
  4870. (WebKit):
  4871. * WebKitSupport/BackingStoreTile.cpp:
  4872. (BlackBerry::WebKit::TileBuffer::TileBuffer):
  4873. (BlackBerry::WebKit::TileBuffer::~TileBuffer):
  4874. (BlackBerry::WebKit::TileBuffer::isRendered):
  4875. (BlackBerry::WebKit::TileBuffer::nativeBuffer):
  4876. (BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
  4877. (BlackBerry::WebKit::TileBuffer::paintBackground):
  4878. * WebKitSupport/BackingStoreTile.h:
  4879. (BlackBerry::WebKit::TileBuffer::lastRenderOrigin):
  4880. (BlackBerry::WebKit::TileBuffer::setLastRenderOrigin):
  4881. (BlackBerry::WebKit::TileBuffer::lastRenderScale):
  4882. (BlackBerry::WebKit::TileBuffer::setLastRenderScale):
  4883. (TileBuffer):
  4884. (BlackBerry::WebKit::TileBuffer::backgroundPainted):
  4885. * WebKitSupport/SurfacePool.cpp:
  4886. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  4887. (BlackBerry::WebKit::SurfacePool::size):
  4888. (WebKit):
  4889. (BlackBerry::WebKit::SurfacePool::initialize):
  4890. (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
  4891. (BlackBerry::WebKit::SurfacePool::hasBackBuffer):
  4892. (BlackBerry::WebKit::SurfacePool::takeBackBuffer):
  4893. (BlackBerry::WebKit::SurfacePool::addBackBuffer):
  4894. (BlackBerry::WebKit::SurfacePool::createBuffers):
  4895. (BlackBerry::WebKit::SurfacePool::releaseBuffers):
  4896. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  4897. * WebKitSupport/SurfacePool.h:
  4898. (BlackBerry::WebKit::SurfacePool::isActive):
  4899. (BlackBerry::WebKit::SurfacePool::isEmpty):
  4900. (SurfacePool):
  4901. (BlackBerry::WebKit::SurfacePool::visibleTileBuffer):
  4902. 2012-12-03 Cosmin Truta <ctruta@rim.com>
  4903. [BlackBerry] Enable HIDDEN_PAGE_DOM_TIMER_THROTTLING
  4904. https://bugs.webkit.org/show_bug.cgi?id=103842
  4905. Reviewed by Yong Li.
  4906. Add HIDDEN_PAGE_DOM_TIMER_THROTTLING.
  4907. * WebCoreSupport/AboutDataEnableFeatures.in:
  4908. 2012-12-02 Tiancheng Jiang <tijiang@rim.com>
  4909. [BlackBerry]Tap highlight
  4910. https://bugs.webkit.org/show_bug.cgi?id=103787
  4911. Reviewed by Rob Buis.
  4912. RIM PR 248626
  4913. Internally Reviewed by Genevieve Mak.
  4914. Draw tap highlight as soon as tap on element.
  4915. * Api/WebPage.cpp:
  4916. (BlackBerry::WebKit::WebPage::touchEvent):
  4917. * WebKitSupport/TouchEventHandler.cpp:
  4918. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  4919. * WebKitSupport/TouchEventHandler.h:
  4920. (TouchEventHandler):
  4921. 2012-11-28 Cosmin Truta <ctruta@rim.com>
  4922. [BlackBerry] Set the minimal DOM timer interval to 4 milliseconds
  4923. https://bugs.webkit.org/show_bug.cgi?id=103534
  4924. Reviewed by Yong Li.
  4925. We align this behavior with other platforms.
  4926. * Api/BlackBerryGlobal.cpp:
  4927. (BlackBerry::WebKit::globalInitialize):
  4928. 2012-11-29 Otto Derek Cheung <otcheung@rim.com>
  4929. [BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
  4930. https://bugs.webkit.org/show_bug.cgi?id=103666
  4931. Reviewed by Yong Li.
  4932. Internally reviewed by Yong Li.
  4933. PR 243420
  4934. Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
  4935. calls setEnableHighAccuracy.
  4936. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  4937. (GeolocationClientBlackBerry::startUpdating):
  4938. (GeolocationClientBlackBerry::setEnableHighAccuracy):
  4939. 2012-11-29 Andrew Lo <anlo@rim.com>
  4940. [BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related
  4941. https://bugs.webkit.org/show_bug.cgi?id=103659
  4942. Reviewed by Rob Buis.
  4943. Internally reviewed by Gen Mak.
  4944. Internal PR253893.
  4945. Only adjust scroll position during an orientation change
  4946. when setting viewport size.
  4947. We don't want the scroll position jumping around when opening
  4948. & closing the VKB.
  4949. * Api/WebPage.cpp:
  4950. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  4951. 2012-11-28 Otto Derek Cheung <otcheung@rim.com>
  4952. [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled
  4953. https://bugs.webkit.org/show_bug.cgi?id=103560
  4954. Reviewed by Rob Buis.
  4955. PR 253490
  4956. Syncing platform Websetting's cookieEnabled value with Page->setting's cookieEnabled
  4957. value.
  4958. * Api/WebPage.cpp:
  4959. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  4960. 2012-11-27 James Simonsen <simonjam@chromium.org>
  4961. Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
  4962. https://bugs.webkit.org/show_bug.cgi?id=102151
  4963. Reviewed by Adam Barth.
  4964. * Api/WebPage.cpp:
  4965. (BlackBerry::WebKit::WebPagePrivate::load):
  4966. (BlackBerry::WebKit::WebPagePrivate::loadString):
  4967. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  4968. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  4969. 2012-11-27 Jacky Jiang <zhajiang@rim.com>
  4970. [BlackBerry] http:// origins can navigate to privileged local:// origins
  4971. https://bugs.webkit.org/show_bug.cgi?id=103437
  4972. Reviewed by Yong Li.
  4973. PR: 251489
  4974. When we aren't allowed to display the destination origin, we shouldn't
  4975. even create the window for it. In this way we can block the remote
  4976. origins(like http://) window.open local origins(like file:// and
  4977. local://) and avoid further security issues.
  4978. Chrome and Safari will open a blank window and fail to load. Firefox
  4979. will fail to open the window and report a load failure error which has
  4980. the same behavior as us. I would prefer this way as the window would
  4981. be useless and the calls after that would be harmful to us.
  4982. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  4983. (WebCore::ChromeClientBlackBerry::createWindow):
  4984. 2012-11-27 Andrew Lo <anlo@rim.com>
  4985. [BlackBerry] Remove unnecessary backing store suspension in InputHandler::ensureFocusTextElementVisible
  4986. https://bugs.webkit.org/show_bug.cgi?id=103441
  4987. Reviewed by Rob Buis.
  4988. Internally reviewed by Mike Fenton.
  4989. Remove unnecessary backing store suspension in
  4990. InputHandler::ensureFocusTextElementVisible.
  4991. Not necessary anymore since both zoom and scroll adjustments
  4992. happen in an animation.
  4993. * WebKitSupport/InputHandler.cpp:
  4994. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  4995. 2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
  4996. Unreviewed, rolling out r135786.
  4997. http://trac.webkit.org/changeset/135786
  4998. https://bugs.webkit.org/show_bug.cgi?id=103379
  4999. It made 3 plugin tests timeout on several platforms (Requested
  5000. by Ossy on #webkit).
  5001. * Api/WebPage.cpp:
  5002. (BlackBerry::WebKit::WebPagePrivate::load):
  5003. (BlackBerry::WebKit::WebPagePrivate::loadString):
  5004. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5005. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5006. 2012-11-26 James Simonsen <simonjam@chromium.org>
  5007. Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
  5008. https://bugs.webkit.org/show_bug.cgi?id=102151
  5009. Reviewed by Adam Barth.
  5010. * Api/WebPage.cpp:
  5011. (BlackBerry::WebKit::WebPagePrivate::load):
  5012. (BlackBerry::WebKit::WebPagePrivate::loadString):
  5013. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5014. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5015. 2012-11-26 Genevieve Mak <gmak@rim.com>
  5016. [BlackBerry] Form controls don't show pressed state.
  5017. https://bugs.webkit.org/show_bug.cgi?id=103292
  5018. Reviewed by Rob Buis.
  5019. Reviewed internally by Eli Fidler and Mike Lattanzio.
  5020. We weren't sending touch events to webpages unless they
  5021. had JS touch event listeners which form controls don't have.
  5022. Now send them always and do a little cleanup.
  5023. PR #249791
  5024. * Api/WebPage.cpp:
  5025. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  5026. (BlackBerry::WebKit::WebPage::touchEvent):
  5027. * Api/WebPageClient.h:
  5028. * Api/WebPage_p.h:
  5029. (WebPagePrivate):
  5030. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  5031. (WebCore::ChromeClientBlackBerry::needTouchEvents):
  5032. 2012-11-26 Nima Ghanavatian <nghanavatian@rim.com>
  5033. [BlackBerry] Null check calls associated with retrieving the caret rect.
  5034. https://bugs.webkit.org/show_bug.cgi?id=103281
  5035. Reviewed by Rob Buis.
  5036. Some of these calls can return null, which could lead to a crash.
  5037. Internally reviewed by Gen Mak.
  5038. * WebKitSupport/InputHandler.cpp:
  5039. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  5040. 2012-11-26 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  5041. [BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
  5042. https://bugs.webkit.org/show_bug.cgi?id=103104
  5043. Reviewed by Rob Buis.
  5044. RIM PR: 245334
  5045. Added the oldPassword detection back into the password input
  5046. detection logic, which was removed for simplicity when imported
  5047. those pieces of codes from Chromium. And we won't do autofill
  5048. when there're more than one password field detected.
  5049. Internally reviewed by Rob Buis.
  5050. * WebCoreSupport/CredentialTransformData.cpp:
  5051. (WebCore::CredentialTransformData::CredentialTransformData):
  5052. (WebCore::CredentialTransformData::findPasswordFormFields):
  5053. * WebCoreSupport/CredentialTransformData.h:
  5054. (CredentialTransformData):
  5055. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5056. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  5057. 2012-11-25 Jacky Jiang <zhajiang@rim.com>
  5058. [BlackBerry] Get rid of resetBitmapZoomScale()
  5059. https://bugs.webkit.org/show_bug.cgi?id=103200
  5060. Reviewed by Rob Buis.
  5061. Internally reviewed by Gen Mak.
  5062. PR: 235707
  5063. Right now, resetBitmapZoomScale() takes an unused paramter and
  5064. dispatches a message to end the bitmap zooming. However, the
  5065. interaction has its own state machine to start bitmap zooming when it
  5066. is active and end bitmap zooming when it is inactive. This is
  5067. expecially for pinch zoom and scroll. From WebKit side, block zoom
  5068. which will call zoomBlock when the bitmap zoom finished doesn't even
  5069. need to dispatch the useless ending message to ZoomHandler.
  5070. resetBitmapZoomScale() is basically a noop for block zoom. And likewise
  5071. that is useless for zoomToInitialScaleOnLoad(). It can also potentially
  5072. cause problem if it is used somewhere else in the future and
  5073. incidentally breaks the interaction's own state machine. So just remove
  5074. this completely.
  5075. * Api/WebPage.cpp:
  5076. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  5077. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  5078. * Api/WebPageClient.h:
  5079. 2012-11-24 Andy Chen <andchen@rim.com>
  5080. [BlackBerry] Find-on-page keeps stale pointer
  5081. https://bugs.webkit.org/show_bug.cgi?id=103190
  5082. Reviewed by Rob Buis.
  5083. Find on page: pendingScopingEffort stores stale pointer when frames unload,
  5084. we need to cancel those scoping efforts.
  5085. PR 250807.
  5086. Internally reviewed by Yongxin Dai and Mike Fenton.
  5087. * WebKitSupport/InPageSearchManager.cpp:
  5088. (InPageSearchManager::DeferredScopeStringMatches):
  5089. (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
  5090. 2012-11-24 Genevieve Mak <gmak@rim.com>
  5091. [BlackBerry] Text not selected when input field focused.
  5092. https://bugs.webkit.org/show_bug.cgi?id=103182
  5093. Reviewed by George Staikos.
  5094. Reviewed Internally by: Mike Fenton, Eli Fidler
  5095. PR #250163
  5096. * WebKitSupport/SelectionHandler.cpp:
  5097. (BlackBerry::WebKit::SelectionHandler::selectObject):
  5098. 2012-11-23 Nima Ghanavatian <nghanavatian@rim.com>
  5099. [BlackBerry] Define platform limitations in platform layer
  5100. https://bugs.webkit.org/show_bug.cgi?id=103160
  5101. Reviewed by Rob Buis.
  5102. Taking length as const unsigned in checkSpellingOfStringAsync.
  5103. This value is unchanging and should never be less than 0, even
  5104. in an error case.
  5105. Internally reviewed by Mike Fenton.
  5106. * Api/WebPageClient.h:
  5107. * WebKitSupport/InputHandler.cpp:
  5108. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  5109. 2012-11-23 Jacky Jiang <zhajiang@rim.com>
  5110. [BlackBerry] Meta viewport can't be changed dynamically
  5111. https://bugs.webkit.org/show_bug.cgi?id=103098
  5112. Reviewed by Rob Buis.
  5113. Internally reviewed by Arvid Nilsson.
  5114. PR: 237072
  5115. Reset m_userPerformedManualZoom and enable
  5116. m_shouldZoomToInitialScaleAfterLoadFinished so that we can relayout the
  5117. page and zoom it to fit the screen when we dynamically change the meta
  5118. viewport after the load is finished.
  5119. * Api/WebPage.cpp:
  5120. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  5121. 2012-11-23 Genevieve Mak <gmak@rim.com>
  5122. [BlackBerry] Drop Synchronous Mouse Events
  5123. https://bugs.webkit.org/show_bug.cgi?id=102980
  5124. Reviewed by Rob Buis.
  5125. Reviewed Internally by George Staikos and Mike Lattanzio.
  5126. Don't send actual Touch Events to fullscreen plugins unless
  5127. its a Touch Cancel, DoubleTap or TouchHold.
  5128. Instead send mouse events as long as its a single finger.
  5129. PR #242781
  5130. * Api/WebPage.cpp:
  5131. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  5132. (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
  5133. (WebKit):
  5134. (BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
  5135. 2012-11-23 Andrew Lo <anlo@rim.com>
  5136. [BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
  5137. https://bugs.webkit.org/show_bug.cgi?id=103091
  5138. Reviewed by Yong Li.
  5139. Internally reviewed by Mike Fenton.
  5140. Internal PR249523
  5141. Incorrectly used y coordinate as x coordinate in
  5142. InputHandler::ensureFocusTextElementVisible.
  5143. * WebKitSupport/InputHandler.cpp:
  5144. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  5145. 2012-11-22 Jeff Rogers <jrogers@rim.com>
  5146. [BlackBerry] Update Web Notifications Implementation
  5147. https://bugs.webkit.org/show_bug.cgi?id=102621
  5148. Reviewed by George Staikos.
  5149. Reviewed internally by George Staikos and Joe Mason
  5150. Internal PR 172120
  5151. Add new notifications implementation for the BlackBerry port. Rename
  5152. existing class to match Client naming. Adds NotificationManager
  5153. implementation for managing notifications and permissions, and logic
  5154. for passing the notifications to the platform provider.
  5155. * Api/WebPage.cpp:
  5156. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  5157. (BlackBerry::WebKit::WebPagePrivate::init):
  5158. (BlackBerry::WebKit::WebPage::updateNotificationPermission):
  5159. (WebKit):
  5160. (BlackBerry::WebKit::WebPage::notificationClicked):
  5161. (BlackBerry::WebKit::WebPage::notificationClosed):
  5162. (BlackBerry::WebKit::WebPage::notificationError):
  5163. (BlackBerry::WebKit::WebPage::notificationShown):
  5164. * Api/WebPage.h:
  5165. * Api/WebPageClient.h:
  5166. * Api/WebPage_p.h:
  5167. (WebPagePrivate):
  5168. (BlackBerry::WebKit::WebPagePrivate::notificationManager):
  5169. * WebCoreSupport/NotificationClientBlackBerry.cpp: Added.
  5170. (WebCore):
  5171. (WebCore::NotificationClientBlackBerry::NotificationClientBlackBerry):
  5172. (WebCore::NotificationClientBlackBerry::show):
  5173. (WebCore::NotificationClientBlackBerry::cancel):
  5174. (WebCore::NotificationClientBlackBerry::clearNotifications):
  5175. (WebCore::NotificationClientBlackBerry::notificationObjectDestroyed):
  5176. (WebCore::NotificationClientBlackBerry::notificationControllerDestroyed):
  5177. (WebCore::NotificationClientBlackBerry::requestPermission):
  5178. (WebCore::NotificationClientBlackBerry::cancelRequestsForPermission):
  5179. (WebCore::NotificationClientBlackBerry::checkPermission):
  5180. * WebCoreSupport/NotificationClientBlackBerry.h: Added.
  5181. (WebKit):
  5182. (WebCore):
  5183. (NotificationClientBlackBerry):
  5184. * WebCoreSupport/NotificationPresenterImpl.cpp: Removed.
  5185. * WebCoreSupport/NotificationPresenterImpl.h: Removed.
  5186. * WebKitSupport/NotificationManager.cpp: Added.
  5187. (WebKit):
  5188. (BlackBerry::WebKit::NotificationManager::NotificationManager):
  5189. (BlackBerry::WebKit::NotificationManager::~NotificationManager):
  5190. (BlackBerry::WebKit::NotificationManager::show):
  5191. (BlackBerry::WebKit::NotificationManager::cancel):
  5192. (BlackBerry::WebKit::NotificationManager::clearNotifications):
  5193. (BlackBerry::WebKit::NotificationManager::notificationObjectDestroyed):
  5194. (BlackBerry::WebKit::NotificationManager::requestPermission):
  5195. (BlackBerry::WebKit::NotificationManager::cancelRequestsForPermission):
  5196. (BlackBerry::WebKit::NotificationManager::checkPermission):
  5197. (BlackBerry::WebKit::NotificationManager::updatePermission):
  5198. (BlackBerry::WebKit::NotificationManager::notificationClicked):
  5199. (BlackBerry::WebKit::NotificationManager::notificationClosed):
  5200. (BlackBerry::WebKit::NotificationManager::notificationError):
  5201. (BlackBerry::WebKit::NotificationManager::notificationShown):
  5202. (BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):
  5203. * WebKitSupport/NotificationManager.h: Added.
  5204. (WebKit):
  5205. (NotificationManager):
  5206. 2012-11-22 Mike Fenton <mifenton@rim.com>
  5207. [BlackBerry] Guard against a lost focusedNode that input handler isn't yet informed of.
  5208. https://bugs.webkit.org/show_bug.cgi?id=103071
  5209. Reviewed by Rob Buis.
  5210. Fix potential for a crash if input mode is active but
  5211. we can't get a focusedNode.
  5212. Reviewed Internally by Gen Mak.
  5213. * WebKitSupport/SelectionHandler.cpp:
  5214. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  5215. 2012-11-21 Genevieve Mak <gmak@rim.com>
  5216. [BlackBerry] Drop Synchronous Mouse Events
  5217. https://bugs.webkit.org/show_bug.cgi?id=102980
  5218. Reviewed by Rob Buis.
  5219. Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
  5220. Get rid of unneeded methods and simplify code.
  5221. Send click if getting context over an empty text field
  5222. so that it will be focused and have a caret.
  5223. PR #242781
  5224. * Api/WebPage.cpp:
  5225. (BlackBerry::WebKit::WebPagePrivate::webContext):
  5226. (BlackBerry::WebKit::WebPage::touchEvent):
  5227. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  5228. (BlackBerry::WebKit::WebPage::touchEventCancel):
  5229. * Api/WebPage.h:
  5230. * WebKitSupport/TouchEventHandler.cpp:
  5231. (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
  5232. (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
  5233. (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
  5234. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  5235. (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
  5236. * WebKitSupport/TouchEventHandler.h:
  5237. (TouchEventHandler):
  5238. 2012-11-21 Konrad Piascik <kpiascik@rim.com>
  5239. [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
  5240. https://bugs.webkit.org/show_bug.cgi?id=102978
  5241. Reviewed by Rob Buis.
  5242. Internal PR 200848
  5243. We prevent screen from going dim when the front-end is connected and return to normal when
  5244. the front-end disconnects.
  5245. * Api/WebPage.cpp:
  5246. (BlackBerry::WebKit::WebPage::enableWebInspector):
  5247. (BlackBerry::WebKit::WebPage::disableWebInspector):
  5248. 2012-11-21 Konrad Piascik <kpiascik@rim.com>
  5249. [BlackBerry] Don't add empty rects to the tap highlight region.
  5250. https://bugs.webkit.org/show_bug.cgi?id=102966
  5251. Reviewed by George Staikos.
  5252. Internal PR 246960
  5253. Tap highlight is way too large sometimes.
  5254. When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.
  5255. * WebKitSupport/TouchEventHandler.cpp:
  5256. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  5257. 2012-11-21 Mike Fenton <mifenton@rim.com>
  5258. [BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
  5259. https://bugs.webkit.org/show_bug.cgi?id=102962
  5260. Reviewed by Rob Buis.
  5261. PR 247270.
  5262. Switch from using VisiblePosition to determine if we are in a node
  5263. to a comparison of the field bounds. This fixes the case where
  5264. there is no node before the target node to match.
  5265. Reviewed Internally by Gen Mak.
  5266. * WebKitSupport/DOMSupport.cpp:
  5267. * WebKitSupport/DOMSupport.h:
  5268. * WebKitSupport/SelectionHandler.cpp:
  5269. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  5270. 2012-11-20 Andrew Lo <anlo@rim.com>
  5271. [BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after scroll or zoom completes
  5272. https://bugs.webkit.org/show_bug.cgi?id=102838
  5273. Reviewed by Rob Buis.
  5274. Internally reviewed by Adam Treat.
  5275. Internal PR244646
  5276. When entering scrolling & zooming, we suspend regular render jobs
  5277. in order to pause animations. When finishing scrolling or zooming,
  5278. dispatch a render job in order to resume those animations.
  5279. If an animation requests a repaint while the backing store is suspended,
  5280. add the regular render job to the render queue so that it can be
  5281. processed later.
  5282. * Api/BackingStore.cpp:
  5283. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  5284. (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
  5285. 2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
  5286. Unreviewed, rolling out r135295.
  5287. http://trac.webkit.org/changeset/135295
  5288. https://bugs.webkit.org/show_bug.cgi?id=102834
  5289. This patch causes assertion to some layout tests on chromium
  5290. (Requested by jianli on #webkit).
  5291. * Api/WebPage.cpp:
  5292. (BlackBerry::WebKit::WebPagePrivate::load):
  5293. (BlackBerry::WebKit::WebPagePrivate::loadString):
  5294. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5295. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5296. 2012-11-20 James Simonsen <simonjam@chromium.org>
  5297. Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
  5298. https://bugs.webkit.org/show_bug.cgi?id=102151
  5299. Reviewed by Adam Barth.
  5300. * Api/WebPage.cpp:
  5301. (BlackBerry::WebKit::WebPagePrivate::load):
  5302. (BlackBerry::WebKit::WebPagePrivate::loadString):
  5303. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5304. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5305. 2012-11-19 Genevieve Mak <gmak@rim.com>
  5306. [BlackBerry] Block Zoom picks wrong block
  5307. https://bugs.webkit.org/show_bug.cgi?id=102728
  5308. Reviewed by Rob Buis.
  5309. Reviewed Internally by Jakob Petsovits
  5310. Remove transform missed in previous commit for
  5311. https://bugs.webkit.org/show_bug.cgi?id=101608
  5312. PR #247198
  5313. * Api/WebPage.cpp:
  5314. (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
  5315. 2012-11-19 Liam Quinn <lquinn@rim.com>
  5316. [BlackBerry] Remove RTSP handling from FrameLoaderClientBlackBerry
  5317. https://bugs.webkit.org/show_bug.cgi?id=102692
  5318. Reviewed by Rob Buis.
  5319. Reviewed internally by George Staikos. Internal PR 242750.
  5320. Our RTSP handling in FrameLoaderClientBlackBerry causes HTTP redirects to "rtsp:" URIs to fail. Remove handling of RTSP from this class; it will be moved to the network layer alongside other URI schemes like "data:" and "file:".
  5321. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5322. (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
  5323. 2012-11-16 Adam Treat <atreat@rim.com>
  5324. https://bugs.webkit.org/show_bug.cgi?id=102540
  5325. [BlackBerry] Checkerboard flicker when pinch zooming out on google.com/nwshp
  5326. Reviewed by George Staikos.
  5327. PR 245827
  5328. Disable updates to the backingstore tile matrix when backingstore updates
  5329. are disabled. This prevents changes to the tile matrix when we are in the
  5330. middle of a pinch zoom which can cause checkebroard flickering.
  5331. * Api/BackingStore.cpp:
  5332. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  5333. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  5334. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  5335. (BlackBerry::WebKit::BackingStorePrivate::render):
  5336. (BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
  5337. (BlackBerry::WebKit::BackingStorePrivate::renderBackingStore):
  5338. (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
  5339. (BlackBerry::WebKit::BackingStorePrivate::contentsSizeChanged):
  5340. (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
  5341. * Api/BackingStore_p.h:
  5342. (BlackBerry::WebKit::BackingStorePrivate::setTileMatrixNeedsUpdate):
  5343. (BackingStorePrivate):
  5344. 2012-11-16 Rob Buis <rbuis@rim.com>
  5345. [BlackBerry] FCC doesn't work in textarea
  5346. https://bugs.webkit.org/show_bug.cgi?id=102088
  5347. Reviewed by Antonio Gomes.
  5348. Remove the cancel button specializations, it was needed at some point but hitting it
  5349. works just as well without it. This unbreaks FCC in textarea's.
  5350. * WebKitSupport/FatFingers.cpp:
  5351. (BlackBerry::WebKit::FatFingers::isElementClickable):
  5352. 2012-11-16 Adam Treat <atreat@rim.com>
  5353. [BlackBerry] Fix regression causing checkerboard flicker after app wake-up
  5354. https://bugs.webkit.org/show_bug.cgi?id=102526
  5355. Reviewed by George Staikos.
  5356. PR 245027
  5357. The webkit patch for 219976 introduced an undesirable behavior change
  5358. resulting in a regression where there was checkerboard flickering on
  5359. resuming from an inactive application state. This patch restores the
  5360. previous behavior and fixes the regression.
  5361. * Api/BackingStore.cpp:
  5362. (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
  5363. (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
  5364. 2012-11-16 Mike Fenton <mifenton@rim.com>
  5365. [BlackBerry] Use proper keycode value for space instead of hardcoded value.
  5366. https://bugs.webkit.org/show_bug.cgi?id=102518
  5367. Reviewed by Rob Buis.
  5368. Remove hard coded value for space.
  5369. Reviewed Internally by Gen Mak.
  5370. * WebKitSupport/InputHandler.cpp:
  5371. (BlackBerry::WebKit::InputHandler::setText):
  5372. 2012-11-15 Andrew Lo <anlo@rim.com>
  5373. [BlackBerry] Animate changes to viewport due to input focus changes.
  5374. https://bugs.webkit.org/show_bug.cgi?id=102410
  5375. Reviewed by Rob Buis.
  5376. When changing scroll position or zoom level for input field focus,
  5377. animate the change.
  5378. Internal PR 231937
  5379. Internally reviewed by Mike Fenton.
  5380. * WebKitSupport/InputHandler.cpp:
  5381. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  5382. 2012-11-15 Mike Fenton <mifenton@rim.com>
  5383. [BlackBerry] Don't restore zoom and scroll when leaving an input field.
  5384. https://bugs.webkit.org/show_bug.cgi?id=102376
  5385. Reviewed by Yong Li.
  5386. Restoring the zoom causes undesirable behavior when switching between fields.
  5387. Reviewed Internally by Andrew Lo.
  5388. * WebKitSupport/InputHandler.cpp:
  5389. (BlackBerry::WebKit::InputHandler::InputHandler):
  5390. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  5391. * WebKitSupport/InputHandler.h:
  5392. (InputHandler):
  5393. 2012-11-15 Jakob Petsovits <jpetsovits@rim.com>
  5394. [BlackBerry] Fix suspend/resume assertion in setCompositor().
  5395. https://bugs.webkit.org/show_bug.cgi?id=102397
  5396. RIM PR 244701
  5397. Reviewed by Adam Treat.
  5398. If a compositor is used but no surface pool is ever
  5399. allocated (which is a perfectly valid use case), initial
  5400. suspension of the backingstore is skipped because of an
  5401. early return. This will cause an assertion to be triggered
  5402. and a bug. Fix this by suspending it before the return.
  5403. With Adam Treat's recent change to split suspension of
  5404. screen and backingstore into two different functions,
  5405. this can now be reduced to a mere screen (blitting)
  5406. suspension. That was the original intention of this code.
  5407. * Api/BackingStore.cpp:
  5408. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  5409. * Api/WebPage.cpp:
  5410. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  5411. 2012-11-15 Jakob Petsovits <jpetsovits@rim.com>
  5412. [BlackBerry] Leave surface resizing to the client.
  5413. https://bugs.webkit.org/show_bug.cgi?id=102280
  5414. RIM PR 235034
  5415. RIM PR 160619
  5416. Reviewed by Adam Treat.
  5417. Now that we always blit on the user interface thread and
  5418. use the client's userInterfaceViewportAccessor() to determine
  5419. the destination rectangle for blitting, changing the viewport
  5420. size does not affect the window or target surface directly.
  5421. The only way that blitted output is affected is through
  5422. layout, scroll position or scale changes. None of these
  5423. require us to synchronize with the UI thread to resize its
  5424. target surface.
  5425. This commit simplifies setViewportSize() and removes a
  5426. blocking message dispatch by simply offloading all surface
  5427. resizing responsibilities to the client. This is safer,
  5428. cleaner and easier.
  5429. * Api/WebPage.cpp:
  5430. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  5431. (BlackBerry::WebKit::WebPage::setScreenOrientation):
  5432. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  5433. * Api/WebPage.h:
  5434. * Api/WebPageClient.h:
  5435. * Api/WebPage_p.h:
  5436. (WebPagePrivate):
  5437. 2012-11-14 Nima Ghanavatian <nghanavatian@rim.com>
  5438. [BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
  5439. https://bugs.webkit.org/show_bug.cgi?id=102284
  5440. Reviewed by Rob Buis.
  5441. PR237497
  5442. When holding backspace, clearing the state forces a keyboard
  5443. update which resets the state of the keyboard. Handling this
  5444. specific corner case separate from all other editor commands.
  5445. Internally reviewed by Mike Fenton.
  5446. * WebCoreSupport/EditorClientBlackBerry.cpp:
  5447. (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
  5448. 2012-11-14 Rob Buis <rbuis@rim.com>
  5449. [BlackBerry] Improve debug functionality in FatFingers
  5450. https://bugs.webkit.org/show_bug.cgi?id=102263
  5451. Reviewed by Antonio Gomes.
  5452. - use logAlways to log even in release.
  5453. - dump shadow tree info if available.
  5454. * WebKitSupport/FatFingers.cpp:
  5455. (BlackBerry::WebKit::FatFingers::isElementClickable):
  5456. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  5457. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  5458. (BlackBerry::WebKit::FatFingers::checkForText):
  5459. 2012-11-14 Adam Treat <atreat@rim.com>
  5460. [BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
  5461. https://bugs.webkit.org/show_bug.cgi?id=102126
  5462. Reviewed by George Staikos.
  5463. PR 219976
  5464. Modify the suspend/resume methods so that they can be called from the UI thread
  5465. itself and split up the suspend/resume methods so that we can suspend/resume
  5466. the screen or backingstore separately.
  5467. * Api/BackingStore.cpp:
  5468. (BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
  5469. (WebKit):
  5470. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
  5471. (BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
  5472. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
  5473. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  5474. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  5475. (BlackBerry::WebKit::BackingStore::suspendBackingStoreUpdates):
  5476. (BlackBerry::WebKit::BackingStore::resumeBackingStoreUpdates):
  5477. (BlackBerry::WebKit::BackingStore::suspendScreenUpdates):
  5478. (BlackBerry::WebKit::BackingStore::resumeScreenUpdates):
  5479. (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
  5480. (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
  5481. * Api/BackingStore.h:
  5482. * Api/BackingStore_p.h:
  5483. (BackingStorePrivate):
  5484. * Api/WebPage.cpp:
  5485. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  5486. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  5487. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  5488. (BlackBerry::WebKit::WebPage::destroy):
  5489. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  5490. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  5491. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  5492. (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
  5493. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5494. (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
  5495. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  5496. * WebKitSupport/InputHandler.cpp:
  5497. (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
  5498. 2012-11-14 Andy Chen <andchen@rim.com>
  5499. [BlackBerry] Add FocusBased context node detection strategy
  5500. https://bugs.webkit.org/show_bug.cgi?id=102238
  5501. Reviewed by Rob Buis.
  5502. If last fat finger result is invalid, we need to return current
  5503. focus element as context node, because when user tap on selection
  5504. overlay, there is not touch event sent to webkit.
  5505. PR 241382
  5506. Internally reviewed by Genevieve Mak and Mike Fenton.
  5507. * Api/WebPage.cpp:
  5508. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  5509. * Api/WebPage.h:
  5510. * WebKitSupport/InputHandler.h:
  5511. (BlackBerry::WebKit::InputHandler::currentFocusElement):
  5512. 2012-11-14 Nima Ghanavatian <nghanavatian@rim.com>
  5513. [BlackBerry] Use mispelled-marker offsets relative to the element
  5514. https://bugs.webkit.org/show_bug.cgi?id=102236
  5515. Reviewed by Rob Buis.
  5516. DocumentMarker offsets are calculated relative to a node. This is causing
  5517. problems for contenteditable which can have numerous nodes. Creating a Range around a word
  5518. and calculating its location and length gives us the correct override in this case for starting
  5519. and ending points to pass to IMF.
  5520. Internally reviewed by Mike Fenton.
  5521. * WebKitSupport/InputHandler.cpp:
  5522. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  5523. 2012-11-13 Mike Fenton <mifenton@rim.com>
  5524. [BlackBerry] Fully restore both zoom and scroll when leaving an input field.
  5525. https://bugs.webkit.org/show_bug.cgi?id=102094
  5526. Reviewed by Rob Buis.
  5527. PR 234187.
  5528. Cache both the zoom and scroll position prior to adjusting
  5529. for input focus so that state can be reset fully.
  5530. Reviewed Internally by Gen Mak.
  5531. * WebKitSupport/InputHandler.cpp:
  5532. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  5533. * WebKitSupport/InputHandler.h:
  5534. (InputHandler):
  5535. 2012-11-12 Nima Ghanavatian <nghanavatian@rim.com>
  5536. [BlackBerry] Ensure we only receive one KeyUp per key event
  5537. https://bugs.webkit.org/show_bug.cgi?id=101967
  5538. Reviewed by Rob Buis.
  5539. We are creating synthetic KeyUps too often, and get into trouble since IMF will send up a KeyUp on all key events.
  5540. Furthermore, these KeyUps can arrive both when we are composing and not. To bypass this check, we are storing the KeyDown
  5541. character and comparing against it on KeyUp.
  5542. Internally reviewed by Mike Fenton.
  5543. * WebKitSupport/InputHandler.cpp:
  5544. (BlackBerry::WebKit::InputHandler::InputHandler):
  5545. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  5546. (BlackBerry::WebKit::InputHandler::insertText):
  5547. (BlackBerry::WebKit::InputHandler::setText):
  5548. * WebKitSupport/InputHandler.h:
  5549. (InputHandler):
  5550. 2012-11-12 Jacky Jiang <zhajiang@rim.com>
  5551. [BlackBerry] When opening an image it does not scale to fit our window
  5552. https://bugs.webkit.org/show_bug.cgi?id=101778
  5553. Reviewed by Rob Buis.
  5554. Internally reviewed by Konrad Piascik.
  5555. PR: 230935
  5556. For image document, the actual image size can be different with the
  5557. contents size. Zoom the document based on the image width so that
  5558. images can fit the screen horizontally. Set 2.0 as the maximum zoom to
  5559. fit scale for image document so that very small images won't get
  5560. ridiculous large scales during the initial load.
  5561. * Api/WebPage.cpp:
  5562. (WebKit):
  5563. (BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
  5564. 2012-11-12 Nima Ghanavatian <nghanavatian@rim.com>
  5565. [BlackBerry] Use keyevents instead of editor commands for backspace
  5566. https://bugs.webkit.org/show_bug.cgi?id=101663
  5567. Reviewed by Rob Buis.
  5568. PR229395
  5569. Sending keyEvents for backspace and switching from KeyChar
  5570. to KeyDown since we are still receiving an unadultered KeyUp
  5571. from the input service. This was causing us to get two keyUps
  5572. for regular keys and no key downs for backspace since it was
  5573. triggering an editor command and bypassing JS listeners.
  5574. Reviewed internally by Mike Fenton.
  5575. * WebKitSupport/InputHandler.cpp:
  5576. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  5577. (BlackBerry::WebKit::relativeRightOffset):
  5578. (WebKit):
  5579. (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
  5580. (BlackBerry::WebKit::InputHandler::setText):
  5581. 2012-11-12 Rob Buis <rbuis@rim.com>
  5582. [BlackBerry] Crash in InRegionScrollerPrivate.
  5583. https://bugs.webkit.org/show_bug.cgi?id=101399
  5584. Reviewed by Yong Li.
  5585. Fix warning caused by the previous patch for this bug (r133679).
  5586. * WebKitSupport/InRegionScrollableArea.cpp:
  5587. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  5588. 2012-11-11 George Staikos <staikos@webkit.org>
  5589. [BlackBerry] The QNX extension method should not be enabled by default
  5590. https://bugs.webkit.org/show_bug.cgi?id=101863
  5591. Reviewed by Rob Buis.
  5592. Simply change the default to false.
  5593. * Api/WebPage.cpp:
  5594. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  5595. 2012-11-09 Otto Derek Cheung <otcheung@rim.com>
  5596. [BlackBerry] Adding a sound to touch events on anchor elements
  5597. https://bugs.webkit.org/show_bug.cgi?id=101655
  5598. Reviewed by Antonio Gomes.
  5599. Adding audio feedback to touchevents on html anchor elements.
  5600. The feedback is called directly from client instead of using the
  5601. mouseup event to avoid the delay between touch start and end caused
  5602. by the tap sequence recognizer.
  5603. * Api/WebPage.cpp:
  5604. (BlackBerry::WebKit::WebPage::playSoundIfAnchorIsTarget):
  5605. (WebKit):
  5606. * Api/WebPage.h:
  5607. * WebKitSupport/TouchEventHandler.cpp:
  5608. (WebKit):
  5609. (BlackBerry::WebKit::TouchEventHandler::playSoundIfAnchorIsTarget):
  5610. * WebKitSupport/TouchEventHandler.h:
  5611. (TouchEventHandler):
  5612. 2012-11-09 George Staikos <staikos@webkit.org>
  5613. [BlackBerry] Remove obsolete tokenizer settings
  5614. https://bugs.webkit.org/show_bug.cgi?id=101689
  5615. Reviewed by Yong Li.
  5616. These tokenizer settings are obsolete and should not be here. Remove them.
  5617. * Api/WebPage.cpp:
  5618. (BlackBerry::WebKit::WebPagePrivate::init):
  5619. 2012-11-08 Chris Guan <chris.guan@torchmobile.com.cn>
  5620. [BlackBerry] need to call closePopup at setValueAndClosePopup
  5621. https://bugs.webkit.org/show_bug.cgi?id=101568
  5622. Reviewed by George Staikos.
  5623. When early return occurs, we need to call closePopup
  5624. at setValueAndClosePopup function. See the comments
  5625. in WebCore/page/PagePopupClient.h. If we have not it,
  5626. Webkit thread is held and browser will be unresponsive
  5627. in BlackBerry port.
  5628. RIM PR 232962
  5629. Internally reviewed by Charles Wei.
  5630. * WebCoreSupport/SelectPopupClient.cpp:
  5631. (WebCore::SelectPopupClient::setValueAndClosePopup):
  5632. 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
  5633. [BlackBerry] Replace checkerboard with page background color.
  5634. https://bugs.webkit.org/show_bug.cgi?id=101652
  5635. RIM PR 188235
  5636. Reviewed by George Staikos.
  5637. In order to do this, we introduce a new member variable for
  5638. BackingStore because when blitting, we can't access the
  5639. page background color in a threadsafe way.
  5640. Solid background color fill is still only used for public builds.
  5641. Developers and beta testers should still see checkerboard and
  5642. do something about it.
  5643. * Api/BackingStore.cpp:
  5644. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  5645. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  5646. (BlackBerry::WebKit::BackingStorePrivate::webPageBackgroundColorUserInterfaceThread):
  5647. (WebKit):
  5648. (BlackBerry::WebKit::BackingStorePrivate::setWebPageBackgroundColor):
  5649. * Api/BackingStore_p.h:
  5650. (BackingStorePrivate):
  5651. * Api/WebPage.cpp:
  5652. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  5653. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  5654. 2012-11-08 Tiancheng Jiang <tijiang@rim.com>
  5655. [BlackBerry] Update BB10 date input form.
  5656. https://bugs.webkit.org/show_bug.cgi?id=101075
  5657. Reviewed by Rob Buis.
  5658. RIM PR 234531
  5659. Internally Reviewed by Mike Fenton.
  5660. Change date input appearance to button and hide caret when click on them.
  5661. * WebCoreSupport/DatePickerClient.cpp:
  5662. (WebCore::DatePickerClient::setValueAndClosePopup):
  5663. * WebKitSupport/InputHandler.cpp:
  5664. (BlackBerry::WebKit::InputHandler::openDatePopup):
  5665. 2012-11-08 Nima Ghanavatian <nghanavatian@rim.com>
  5666. [BlackBerry] Provide pixel coordinates to IMF relative to the screen
  5667. https://bugs.webkit.org/show_bug.cgi?id=101628
  5668. Reviewed by Rob Buis.
  5669. Reviewed internally by Mike Fenton and Jakob Petsovits.
  5670. We need to provide the correct pixel coordinates to IMF,
  5671. accounting for webkit based fields in UIB as well as browser.
  5672. Getting an offset value from the screen point to the document
  5673. content point allows us to adjust for when the document,
  5674. such as in UIB, does not start at 0,0.
  5675. * Api/WebPageClient.h:
  5676. * WebKitSupport/InputHandler.cpp:
  5677. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  5678. * WebKitSupport/InputHandler.h:
  5679. (InputHandler):
  5680. * WebKitSupport/TouchEventHandler.cpp:
  5681. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  5682. 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
  5683. [BlackBerry] Janitor: Remove unused m_isValid bool
  5684. https://bugs.webkit.org/show_bug.cgi?id=101610
  5685. Reviewed by Rob Buis.
  5686. It's not used anywhere, but as we have a constructor
  5687. that creates an invalid TileIndex, let's add another
  5688. method to check validity - now a correct check.
  5689. On top of that, make the stylebot happy by reducing
  5690. "unsigned int" to just "unsigned".
  5691. * WebKitSupport/TileIndex.h:
  5692. (BlackBerry::WebKit::TileIndex::TileIndex):
  5693. (BlackBerry::WebKit::TileIndex::i):
  5694. (BlackBerry::WebKit::TileIndex::j):
  5695. (BlackBerry::WebKit::TileIndex::setIndex):
  5696. (BlackBerry::WebKit::TileIndex::isValid):
  5697. (TileIndex):
  5698. 2012-11-08 Eli Fidler <efidler@rim.com>
  5699. [BlackBerry] Increase memory cache size
  5700. https://bugs.webkit.org/show_bug.cgi?id=101622
  5701. Reviewed by Yong Li.
  5702. * WebCoreSupport/CacheClientBlackBerry.cpp:
  5703. (WebCore::CacheClientBlackBerry::updateCacheCapacity):
  5704. * WebCoreSupport/CacheClientBlackBerry.h:
  5705. (CacheClientBlackBerry):
  5706. 2012-11-08 Jakob Petsovits <jpetsovits@rim.com>
  5707. [BlackBerry] Rework the API to use document coordinates
  5708. https://bugs.webkit.org/show_bug.cgi?id=101608
  5709. RIM PR 173292
  5710. Reviewed by Adam Treat.
  5711. Scrolling and zooming APIs used to operate on
  5712. transformed coordinates, which is a bad idea:
  5713. The UI thread might long have moved on to a
  5714. different scale and scroll position so outdated
  5715. pixel coordinates are of limited value.
  5716. Moreover, more transformation calculations are
  5717. needed than if we operate purely on document
  5718. coordinates.
  5719. With webkitThreadViewportAccessor() exposed,
  5720. the caller has a choice between how to handle
  5721. coordinates and the means to perform conversions
  5722. with little effort and overhead if needed.
  5723. Therefore, we should remove pixel coordinates
  5724. from the public API. This commit makes this change.
  5725. * Api/BackingStore.cpp:
  5726. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  5727. (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
  5728. * Api/InRegionScroller.cpp:
  5729. (BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionCompositingThread):
  5730. (BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionWebKitThread):
  5731. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  5732. * Api/InRegionScroller.h:
  5733. * Api/WebPage.cpp:
  5734. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  5735. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  5736. (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
  5737. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  5738. (BlackBerry::WebKit::WebPage::setDocumentScrollPosition):
  5739. (BlackBerry::WebKit::WebPagePrivate::hasVirtualViewport):
  5740. (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
  5741. (BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
  5742. (BlackBerry::WebKit::WebPagePrivate::setCursor):
  5743. (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
  5744. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  5745. (BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
  5746. (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
  5747. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  5748. (BlackBerry::WebKit::WebPage::setVirtualViewportSize):
  5749. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  5750. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  5751. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  5752. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  5753. (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
  5754. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
  5755. (BlackBerry::WebKit::WebPage::setDocumentScrollOriginPoint):
  5756. (BlackBerry::WebKit::handleScrolling):
  5757. (BlackBerry::WebKit::WebPage::selectionContainsDocumentPoint):
  5758. (BlackBerry::WebKit::WebPage::setDocumentSelection):
  5759. (BlackBerry::WebKit::WebPage::setDocumentCaretPosition):
  5760. (BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
  5761. (BlackBerry::WebKit::WebPagePrivate::setTextReflowAnchorPoint):
  5762. (BlackBerry::WebKit::WebPage::pinchZoomAboutPoint):
  5763. (BlackBerry::WebKit::WebPage::blockZoom):
  5764. (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
  5765. (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
  5766. * Api/WebPage.h:
  5767. (Platform):
  5768. * Api/WebPageClient.h:
  5769. * Api/WebPage_p.h:
  5770. (WebPagePrivate):
  5771. * WebCoreSupport/AutofillManager.cpp:
  5772. (WebCore::AutofillManager::didChangeInTextField):
  5773. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5774. (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
  5775. * WebKitSupport/SelectionHandler.cpp:
  5776. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  5777. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  5778. 2012-11-08 Nima Ghanavatian <nghanavatian@rim.com>
  5779. [BlackBerry] Verify touched element using the rootEditableElement
  5780. https://bugs.webkit.org/show_bug.cgi?id=101510
  5781. Reviewed by Rob Buis.
  5782. Reviewed internally by Mike Fenton.
  5783. Move up the tree until we find the rootEditableElement and use
  5784. that to compare with the touched element.
  5785. * WebKitSupport/FatFingers.h:
  5786. (BlackBerry::WebKit::FatFingersResult::node):
  5787. (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
  5788. * WebKitSupport/InputHandler.cpp:
  5789. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  5790. * WebKitSupport/TouchEventHandler.cpp:
  5791. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  5792. 2012-11-07 Rob Buis <rbuis@rim.com>
  5793. [BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
  5794. https://bugs.webkit.org/show_bug.cgi?id=101490
  5795. Reviewed by Yong Li.
  5796. We no longer need this API.
  5797. * Api/WebPage.cpp:
  5798. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  5799. * Api/WebSettings.cpp:
  5800. (WebKit):
  5801. * Api/WebSettings.h:
  5802. 2012-11-07 Christophe Dumez <christophe.dumez@intel.com>
  5803. Add replaceWithLiteral() method to WTF::String
  5804. https://bugs.webkit.org/show_bug.cgi?id=101257
  5805. Reviewed by Benjamin Poulain.
  5806. Substitute String::replace() calls by String::replaceWithLiteral() where
  5807. adequate, for efficiency.
  5808. * WebCoreSupport/SelectPopupClient.cpp:
  5809. (WebCore::SelectPopupClient::generateHTML):
  5810. 2012-11-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
  5811. Remove support for "desktop-width" in the viewport meta tag
  5812. https://bugs.webkit.org/show_bug.cgi?id=101217
  5813. Reviewed by Gyuyoung Kim.
  5814. Sync WebViewportArguments enum with the one in
  5815. WebCore::ViewportArguments
  5816. * Api/WebViewportArguments.h:
  5817. 2012-11-06 Genevieve Mak <gmak@rim.com>
  5818. [BlackBerry] Crash in InRegionScrollerPrivate.
  5819. https://bugs.webkit.org/show_bug.cgi?id=101399
  5820. Reviewed by Rob Buis.
  5821. Add a pointer to the enclosing document as the pointer to layer
  5822. or node along the way may become invalid.
  5823. Use document pointer in clearDocumentData.
  5824. PR #238469
  5825. * Api/InRegionScroller.cpp:
  5826. (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
  5827. * WebKitSupport/InRegionScrollableArea.cpp:
  5828. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  5829. (BlackBerry::WebKit::InRegionScrollableArea::document):
  5830. (WebKit):
  5831. * WebKitSupport/InRegionScrollableArea.h:
  5832. (WebCore):
  5833. (InRegionScrollableArea):
  5834. 2012-11-06 Otto Derek Cheung <otcheung@rim.com>
  5835. [BlackBerry] Pushing window.external.* events to webplatform
  5836. https://bugs.webkit.org/show_bug.cgi?id=101386
  5837. Reviewed by Rob Buis.
  5838. Adding calls to trigger window.external events so we can handle them on the
  5839. browser side.
  5840. PR 170059
  5841. * Api/WebPageClient.h:
  5842. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  5843. (WebCore::ChromeClientBlackBerry::addSearchProvider):
  5844. (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
  5845. 2012-11-06 Otto Derek Cheung <otcheung@rim.com>
  5846. [BlackBerry] Adding window.external to our port
  5847. https://bugs.webkit.org/show_bug.cgi?id=100868
  5848. Reviewed by Rob Buis.
  5849. Patching the method names to match the ones in the spec.
  5850. * WebCoreSupport/ExternalExtension.cpp:
  5851. 2012-11-06 Jacky Jiang <zhajiang@rim.com>
  5852. [BlackBerry] Page can't back to whole screen after zoom out and orientation change
  5853. https://bugs.webkit.org/show_bug.cgi?id=101350
  5854. Reviewed by Rob Buis.
  5855. Internally reviewed by Arvid Nilsson.
  5856. PR: 229321
  5857. When rotating device during touch interaction, bitmap zooming was
  5858. unexpected ended by resetBitmapZoomScale() so that it couldn't bounce
  5859. back. The call resetBitmapZoomScale() is ancient, which just resets the
  5860. scale of the bitmap before. Right now it only ends the bitmap zooming
  5861. which caused the issue. As UI viewport will be updated by zoomChanged()
  5862. right after that, we can remove this trouble maker.
  5863. Update the interaction views if the rotation is being changed so that
  5864. ZoomHandler can get the updated views.
  5865. * Api/WebPage.cpp:
  5866. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  5867. * Api/WebPageClient.h:
  5868. 2012-11-05 Lianghui Chen <liachen@rim.com>
  5869. [BlackBerry] Do not show error page for main loads denied by client application
  5870. https://bugs.webkit.org/show_bug.cgi?id=101287
  5871. Internal PR: 237574.
  5872. Internally reviewed by Arvid Nilsson, Joe Mason.
  5873. Reviewed by George Staikos.
  5874. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5875. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5876. 2012-11-05 Lianghui Chen <liachen@rim.com>
  5877. [BlackBerry] Do not display error page for failed downloads
  5878. https://bugs.webkit.org/show_bug.cgi?id=101246
  5879. Internal PR: 236318
  5880. Internal reviewed by Joe Mason, Leo Yang.
  5881. Reviewed by Rob Buis.
  5882. Right now when a main load, including all downloads, failed, it will
  5883. display an error page. This is not very user friendly, especially for
  5884. WebWorks application, which want to use its own user interface to info
  5885. user about the failure.
  5886. So we just stop displaying error page for downloads.
  5887. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  5888. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  5889. 2012-11-05 Simon Fraser <simon.fraser@apple.com>
  5890. Fix layer borders to cleaning appear and disappear on switching
  5891. https://bugs.webkit.org/show_bug.cgi?id=101136
  5892. Reviewed by Sam Weinig.
  5893. Remove the GraphicsLayerClient methods showDebugBorders() and
  5894. showRepaintCounter().
  5895. * Api/WebOverlay_p.h:
  5896. (WebOverlayPrivateWebKitThread):
  5897. * Api/WebPage.cpp:
  5898. (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
  5899. * Api/WebPage_p.h:
  5900. * WebKitSupport/DefaultTapHighlight.cpp:
  5901. * WebKitSupport/DefaultTapHighlight.h:
  5902. (DefaultTapHighlight):
  5903. * WebKitSupport/InspectorOverlayBlackBerry.cpp:
  5904. * WebKitSupport/InspectorOverlayBlackBerry.h:
  5905. (InspectorOverlay):
  5906. * WebKitSupport/SelectionOverlay.cpp:
  5907. * WebKitSupport/SelectionOverlay.h:
  5908. (SelectionOverlay):
  5909. 2012-11-05 Rob Buis <rbuis@rim.com>
  5910. [BlackBerry] screenX/Y gives wrong values
  5911. https://bugs.webkit.org/show_bug.cgi?id=101259
  5912. Reviewed by Yong Li.
  5913. PR 237071
  5914. Reviewed internally by Gen Mak.
  5915. Do not transform screenPos coordinates.
  5916. * Api/WebPage.cpp:
  5917. (BlackBerry::WebKit::WebPage::mouseEvent):
  5918. (BlackBerry::WebKit::WebPage::touchEvent):
  5919. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  5920. 2012-11-05 Rob Buis <rbuis@rim.com>
  5921. [BlackBerry] Input date should not popup dialog when readonly is set
  5922. https://bugs.webkit.org/show_bug.cgi?id=101234
  5923. Reviewed by Yong Li.
  5924. PR 236114
  5925. Reviewed internally by Mike Fenton.
  5926. Suppress popup dialog if the input element has readonly attribute set.
  5927. * WebKitSupport/InputHandler.cpp:
  5928. (BlackBerry::WebKit::InputHandler::openDatePopup):
  5929. (BlackBerry::WebKit::InputHandler::openColorPopup):
  5930. 2012-11-05 Genevieve Mak <gmak@rim.com>
  5931. [BLACKBERRY] Update touch code to reflect touch refactor
  5932. https://bugs.webkit.org/show_bug.cgi?id=101227
  5933. Reviewed by Rob Buis.
  5934. PR #2706785
  5935. Reviewed Internally by: Mike Lattanzio
  5936. * Api/WebPage.cpp:
  5937. (BlackBerry::WebKit::WebPage::touchEvent):
  5938. (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
  5939. 2012-11-05 Konrad Piascik <kpiascik@rim.com>
  5940. [BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
  5941. https://bugs.webkit.org/show_bug.cgi?id=101213
  5942. RIM PR 178131
  5943. Reviewed by Rob Buis.
  5944. Internally Reviewed by Arvid Nilsson.
  5945. Added compositing events to the timeline for BlackBerry.
  5946. * Api/WebPage.cpp:
  5947. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  5948. (BlackBerry::WebKit::WebPagePrivate::willComposite):
  5949. (WebKit):
  5950. (BlackBerry::WebKit::WebPagePrivate::didComposite):
  5951. * Api/WebPage_p.h:
  5952. (WebPagePrivate):
  5953. 2012-11-03 Alexey Proskuryakov <ap@apple.com>
  5954. Get rid of USE(CFURLSTORAGESESSIONS)
  5955. https://bugs.webkit.org/show_bug.cgi?id=101131
  5956. Reviewed by Sam Weinig.
  5957. * WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
  5958. CFURLSTORAGESESSIONS probably doesn't need to stay here.
  5959. 2012-11-02 Nima Ghanavatian <nghanavatian@rim.com>
  5960. [BlackBerry] Fix compile-time warning of a possible empty-body if statement
  5961. https://bugs.webkit.org/show_bug.cgi?id=101095
  5962. Reviewed by Yong Li.
  5963. Internally reviewed by Jeff Rogers.
  5964. BBLOG might be compiled out leaving an if statement with an empty
  5965. body. This is giving us a warning at the moment. Simply putting braces
  5966. around it will fail as well because then we'd have braces around a
  5967. single-line if. So, in following with the style observed in other parts
  5968. of BackingStore.cpp, break up the log message and add braces.
  5969. * Api/BackingStore.cpp:
  5970. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  5971. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  5972. (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
  5973. 2012-11-02 Nima Ghanavatian <nghanavatian@rim.com>
  5974. [BlackBerry] Optimize backspace key handling
  5975. https://bugs.webkit.org/show_bug.cgi?id=101083
  5976. PR233591
  5977. Optimize backspace key handling. Some of these calls are not
  5978. required by IMF since the input_service already processes the backspace key
  5979. and updates the state before passing us the key.
  5980. Internally reviewed by Mike Fenton.
  5981. Reviewed by Yong Li.
  5982. Blocking calls with a flag that we clear immediately after
  5983. processing a backspace keydown.
  5984. * WebKitSupport/InputHandler.cpp:
  5985. (BlackBerry::WebKit::InputHandler::nodeTextChanged):
  5986. (BlackBerry::WebKit::InputHandler::selectionChanged):
  5987. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  5988. * WebKitSupport/InputHandler.h:
  5989. (InputHandler):
  5990. 2012-11-02 Otto Derek Cheung <otcheung@rim.com>
  5991. [BlackBerry] Adding window.external to our port
  5992. https://bugs.webkit.org/show_bug.cgi?id=100868
  5993. Reviewed by Rob Buis.
  5994. PR 158809
  5995. Patch up an error where we were dereferencing a null pointer.
  5996. * WebCoreSupport/ExternalExtension.cpp:
  5997. (addSearchProviderMethod):
  5998. (IsSearchProviderInstalledMethod):
  5999. 2012-11-01 Peter Wang <peter.wang@torchmobile.com.cn>
  6000. [BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
  6001. https://bugs.webkit.org/show_bug.cgi?id=100941
  6002. Reviewed by Yong Li.
  6003. Remove the unnecessary steps, just directly deal with returned JSValue.
  6004. * Api/WebPage.cpp:
  6005. (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
  6006. (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
  6007. 2012-11-01 Otto Derek Cheung <otcheung@rim.com>
  6008. [BlackBerry] Add a prompt to enable global location services
  6009. https://bugs.webkit.org/show_bug.cgi?id=100992
  6010. PR 227897
  6011. Reviewed by Rob Buis.
  6012. Adding a dialog to let the user know location services isn't enabled.
  6013. Currently, the browser app does not check whether the global setting for
  6014. location service is enabled. This patch adds a dialog to allow the user
  6015. to open the settings app and change that setting. This infobar will only
  6016. show once per session. If the user fails to turn on location services after
  6017. the first prompt, all geolocation requests will automatically fail.
  6018. Also, adapting GeolocationClientBlackBerry to the removal of GeoTracker.
  6019. The class now talks directly to the geo handler singleton.
  6020. * Api/WebPageClient.h:
  6021. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  6022. (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
  6023. (GeolocationClientBlackBerry::geolocationDestroyed):
  6024. (GeolocationClientBlackBerry::startUpdating):
  6025. (GeolocationClientBlackBerry::stopUpdating):
  6026. (GeolocationClientBlackBerry::requestPermission):
  6027. (GeolocationClientBlackBerry::setEnableHighAccuracy):
  6028. * WebCoreSupport/GeolocationClientBlackBerry.h:
  6029. (WebCore::GeolocationClientBlackBerry::requiresHighAccuracy):
  6030. (GeolocationClientBlackBerry):
  6031. 2012-11-01 Michael Matovsky <mmatovsky@rim.com>
  6032. [BlackBerry] Web page view state should be preserved for pages loaded from page cache
  6033. https://bugs.webkit.org/show_bug.cgi?id=100694
  6034. Internal PR: 220488
  6035. Internally reviewed by Lianghui Chen, Joe Mason
  6036. Reviewed by Rob Buis.
  6037. The web page view specific metadata should be preserved for web pages loaded from page cache (by using back/forward).
  6038. This requires web page view state to be saved in and restored from the corresponding page cache history item.
  6039. * Api/WebPageClient.h:
  6040. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6041. (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
  6042. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  6043. 2012-11-01 Leo Yang <leoyang@rim.com>
  6044. [BlackBerry] Use clipped background rect in backing store
  6045. https://bugs.webkit.org/show_bug.cgi?id=100960
  6046. Reviewed by Yong Li.
  6047. Reviewed internally by Arvid Nilsson.
  6048. We calculated clipped background rect but didn't really use it when painting
  6049. the background. Use the correct rect to avoid ASSERT failure in platform code.
  6050. * Api/BackingStore.cpp:
  6051. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  6052. 2012-10-31 George Staikos <staikos@webkit.org>
  6053. [BlackBerry] Crash on html popup form control when element is deleted
  6054. https://bugs.webkit.org/show_bug.cgi?id=100869
  6055. Reviewed by Yong Li.
  6056. Make the element pointers RefPtr so they don't go away before the popup
  6057. is closed.
  6058. * WebCoreSupport/ColorPickerClient.h:
  6059. (ColorPickerClient):
  6060. * WebCoreSupport/DatePickerClient.h:
  6061. (DatePickerClient):
  6062. * WebCoreSupport/SelectPopupClient.h:
  6063. (SelectPopupClient):
  6064. 2012-10-31 Genevieve Mak <gmak@rim.com>
  6065. [BLACKBERRY] Custom WebWorks context menus don't always work.
  6066. https://bugs.webkit.org/show_bug.cgi?id=100891
  6067. Reviewed by Rob Buis.
  6068. Walk up the dom tree until we find the webworks attribute or run out
  6069. of parent nodes.
  6070. PR# 227732
  6071. * Api/WebPage.cpp:
  6072. (BlackBerry::WebKit::WebPagePrivate::webContext):
  6073. 2012-10-31 Otto Derek Cheung <otcheung@rim.com>
  6074. [BlackBerry] Adding window.external to our port
  6075. https://bugs.webkit.org/show_bug.cgi?id=100868
  6076. Reviewed by Rob Buis.
  6077. Attaching the window.external interface to the frame when
  6078. it loads up.
  6079. When called, the external interface methods call stubs declared
  6080. in ChromeClientBlackBerry. The method passes in the url of the search
  6081. provider and the url of the frame. Cross-site check has to be done in the
  6082. implementation PR.
  6083. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6084. (WebCore::ChromeClientBlackBerry::addSearchProvider):
  6085. (WebCore):
  6086. (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
  6087. * WebCoreSupport/ChromeClientBlackBerry.h:
  6088. (ChromeClientBlackBerry):
  6089. * WebCoreSupport/ExternalExtension.cpp: Added.
  6090. (addSearchProviderMethod):
  6091. (IsSearchProviderInstalledMethod):
  6092. (externalExtensionInitialize):
  6093. (externalExtensionFinalize):
  6094. * WebCoreSupport/ExternalExtension.h: Added.
  6095. (WebCore):
  6096. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6097. (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
  6098. 2012-10-30 Peter Wang <peter.wang@torchmobile.com.cn>
  6099. [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
  6100. https://bugs.webkit.org/show_bug.cgi?id=100724
  6101. Reviewed by Rob Buis.
  6102. Remove the code of JavaScriptDebuggerBlackBerry.
  6103. * Api/WebPage.cpp:
  6104. * Api/WebPage.h:
  6105. * Api/WebPage_p.h:
  6106. (WebCore):
  6107. (WebPagePrivate):
  6108. * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Removed.
  6109. * WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Removed.
  6110. 2012-10-29 Rob Buis <rbuis@rim.com>
  6111. [BlackBerry] Simplify AuthenticationChallengeManager::instance
  6112. https://bugs.webkit.org/show_bug.cgi?id=100614
  6113. Reviewed by Yong Li.
  6114. Internally reviewed by Lyon Chen.
  6115. No need to call AuthenticationChallengeManager::init anymore.
  6116. * Api/BlackBerryGlobal.cpp:
  6117. (BlackBerry::WebKit::globalInitialize):
  6118. 2012-10-29 Mike Lattanzio <mlattanzio@rim.com>
  6119. [BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle()
  6120. https://bugs.webkit.org/show_bug.cgi?id=100377
  6121. Reviewed by Adam Treat.
  6122. Should be void, not bool.
  6123. * Api/WebPage.cpp:
  6124. (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
  6125. * Api/WebPage_p.h:
  6126. (WebPagePrivate):
  6127. 2012-10-29 Robin Cao <robin.cao@torchmobile.com.cn>
  6128. [BlackBerry] Fix a build error
  6129. https://bugs.webkit.org/show_bug.cgi?id=100649
  6130. Reviewed by Kentaro Hara.
  6131. r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
  6132. and this commit was later reverted. We need to update a call site in the
  6133. BlackBerry port to make it build.
  6134. * Api/WebPage.cpp:
  6135. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  6136. 2012-10-26 Jacky Jiang <zhajiang@rim.com>
  6137. [BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
  6138. https://bugs.webkit.org/show_bug.cgi?id=100421
  6139. Reviewed by Yong Li.
  6140. PR: 231173
  6141. When leaving fullscreen, we need to suspend screen and backing store
  6142. updates before setting scroll position and changing transformation and
  6143. resume after they are done. In which way, we can get rid of a noticeable
  6144. glitch during the transition.
  6145. * Api/WebPage.cpp:
  6146. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  6147. 2012-10-26 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  6148. [BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
  6149. https://bugs.webkit.org/show_bug.cgi?id=100504
  6150. Reviewed by Yong Li.
  6151. PR #232038 The similar PR # 200724.
  6152. Reviewed internally by Petter Wang.
  6153. This issue is same as bug 95492, and this patch is same as its patch.
  6154. Hold the JSLock for the current thread before we call toRef to avoid
  6155. the ASSERT failure.
  6156. * Api/WebPage.cpp:
  6157. (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
  6158. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  6159. 2012-10-25 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  6160. [BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
  6161. https://bugs.webkit.org/show_bug.cgi?id=100330
  6162. Reviewed by Rob Buis.
  6163. Reviewed internally by Charles Wei.
  6164. PR #231232
  6165. Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
  6166. visible needs AuthenticationChallengeManager to update its records, deleting
  6167. webpage from AuthenticationChallengeManager's map should be done after setting
  6168. webpage visibility.
  6169. * Api/WebPage.cpp:
  6170. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  6171. 2012-10-24 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  6172. [BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
  6173. https://bugs.webkit.org/show_bug.cgi?id=100214
  6174. Reviewed by Rob Buis.
  6175. ViewportSize has been changed before committing root layer, it asserts
  6176. that it needs relayout and render if needed before committing if it
  6177. Needs One Shot Drawing Synchronization.
  6178. This patch calls requestLayoutIfNeeded() when resumeScreenAndBackingStoreUpdates().
  6179. Fix a coding style in the BackingStore.cpp as well.
  6180. Reviewed internally by Arvid Nilsson.
  6181. PR #230253
  6182. * Api/BackingStore.cpp:
  6183. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  6184. 2012-10-24 Otto Derek Cheung <otcheung@rim.com>
  6185. [BlackBerry] Geolocation is segfaulting
  6186. https://bugs.webkit.org/show_bug.cgi?id=100305
  6187. Reviewed by Rob Buis.
  6188. We weren't wrapping the Geolocation object in a RefPtr when we call setIsAllowed in
  6189. GeolocationClientBlackBerry::onPermission.
  6190. This patch also removes all references of the Geolocation object in WebPageClientImpl.
  6191. One RefPtr<Geolocation> is used to store the reference of the WebCore object on our port.
  6192. We don't need a mapping between origin -> context of Geolocation because in our port,
  6193. one WebPage.cpp contains one GeolocationController only.
  6194. * Api/WebPageClient.h:
  6195. * WebCoreSupport/GeolocationClientBlackBerry.cpp:
  6196. (frameOrigin):
  6197. (GeolocationClientBlackBerry::requestPermission):
  6198. (GeolocationClientBlackBerry::cancelPermissionRequest):
  6199. (GeolocationClientBlackBerry::onPermission):
  6200. * WebCoreSupport/GeolocationClientBlackBerry.h:
  6201. (GeolocationClientBlackBerry):
  6202. 2012-10-24 Jacky Jiang <zhajiang@rim.com>
  6203. [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
  6204. https://bugs.webkit.org/show_bug.cgi?id=100259
  6205. Reviewed by Rob Buis.
  6206. PR: 219666
  6207. Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
  6208. This rolls out r128772.
  6209. The patches relies on the viewport size change of the client side to
  6210. resume the screen and backing store updates. However, some client
  6211. sides don't need or wish to resize the WebKit viewport at all which
  6212. will result in upexpected screen and backing store suspensions.
  6213. * Api/WebPage.cpp:
  6214. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  6215. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  6216. * Api/WebPage_p.h:
  6217. (WebPagePrivate):
  6218. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6219. (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
  6220. (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
  6221. 2012-10-24 Jacky Jiang <zhajiang@rim.com>
  6222. [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
  6223. https://bugs.webkit.org/show_bug.cgi?id=100259
  6224. Reviewed by Rob Buis.
  6225. PR: 219666
  6226. Roll out r130392 and r129909.
  6227. The patches rely on the viewport size change of the client side to
  6228. update the scale and scroll position of the video. However, some client
  6229. sides don't need or wish to resize the WebKit viewport at all.
  6230. * Api/WebPage.cpp:
  6231. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  6232. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  6233. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  6234. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  6235. * Api/WebPage_p.h:
  6236. (WebPagePrivate):
  6237. 2012-10-24 Otto Derek Cheung <otcheung@rim.com>
  6238. [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
  6239. https://bugs.webkit.org/show_bug.cgi?id=100250
  6240. Reviewed by Rob Buis.
  6241. Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
  6242. to prevent confusion.
  6243. PR 230196
  6244. * Api/WebPage.cpp:
  6245. (BlackBerry::WebKit::WebPagePrivate::init):
  6246. * Api/WebPage_p.h:
  6247. (WebCore):
  6248. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6249. * WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.
  6250. (frameOrigin):
  6251. (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
  6252. (GeolocationClientBlackBerry::geolocationDestroyed):
  6253. (GeolocationClientBlackBerry::startUpdating):
  6254. (GeolocationClientBlackBerry::stopUpdating):
  6255. (GeolocationClientBlackBerry::lastPosition):
  6256. (GeolocationClientBlackBerry::requestPermission):
  6257. (GeolocationClientBlackBerry::cancelPermissionRequest):
  6258. (GeolocationClientBlackBerry::onLocationUpdate):
  6259. (GeolocationClientBlackBerry::onLocationError):
  6260. (GeolocationClientBlackBerry::onPermission):
  6261. (GeolocationClientBlackBerry::setEnableHighAccuracy):
  6262. * WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.
  6263. (WebKit):
  6264. (WebCore):
  6265. (GeolocationClientBlackBerry):
  6266. (WebCore::GeolocationClientBlackBerry::tracker):
  6267. 2012-10-24 Parth Patel <parpatel@rim.com>
  6268. [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
  6269. Generic ThreadUnsafe Singleton
  6270. https://bugs.webkit.org/show_bug.cgi?id=100145
  6271. Reviewed by Rob Buis.
  6272. Extending the singletons to generic singleton and changing
  6273. getInstance() in IconDatabaseClientBlackBerry to instance()
  6274. to match the generic singleton template.
  6275. Reviewed Internally by Yong Li.
  6276. * Api/WebPage.cpp:
  6277. (BlackBerry::WebKit::WebPage::initializeIconDataBase):
  6278. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  6279. (WebCore):
  6280. * WebCoreSupport/IconDatabaseClientBlackBerry.h:
  6281. (IconDatabaseClientBlackBerry):
  6282. 2012-10-23 Robin Cao <robin.cao@torchmobile.com.cn>
  6283. [BlackBerry] Web page renders at the wrong zoom level after viewport changes
  6284. https://bugs.webkit.org/show_bug.cgi?id=100096
  6285. Reviewed by Rob Buis.
  6286. Notify the client of the zoom level change before resuming screen updates.
  6287. Otherwise, the user interface thread may blit the content at the wrong
  6288. zoom level in some cases. This can also prevent potential flickering.
  6289. Reviewed internally by Arvid Nilsson.
  6290. PR #225741
  6291. * Api/WebPage.cpp:
  6292. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  6293. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  6294. 2012-10-23 Mike Lattanzio <mlattanzio@rim.com>
  6295. [BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
  6296. https://bugs.webkit.org/show_bug.cgi?id=99649
  6297. Reviewed by George Staikos.
  6298. Random latency before scroll starts on sites like http://pintrest.com
  6299. Internal PR225398
  6300. The chief problem here is the all the hit testing that we do for
  6301. touch events and simulated mouse events. If the render tree is dirty
  6302. hit tests can take a long time in Document::recalcStyle(). Masking
  6303. the flags that force style recalculations will make them fast, at the
  6304. expense that they might be happening on stale data.
  6305. Since we are only using these hit tests to look for event handlers -
  6306. we're not actually modifying anything, it is better to skip the
  6307. Document::recalcStyle() and save ourselves tons of time.
  6308. * Api/InRegionScroller.cpp:
  6309. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  6310. * Api/WebPage.cpp:
  6311. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  6312. (BlackBerry::WebKit::WebPage::touchEvent):
  6313. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
  6314. (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
  6315. (WebKit):
  6316. (BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
  6317. (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
  6318. (BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):
  6319. * Api/WebPage_p.h:
  6320. (WebPagePrivate):
  6321. * WebKitSupport/FatFingers.cpp:
  6322. (BlackBerry::WebKit::FatFingers::findBestPoint):
  6323. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
  6324. * WebKitSupport/FatFingers.h:
  6325. * WebKitSupport/TouchEventHandler.cpp:
  6326. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  6327. 2012-10-23 Rob Buis <rbuis@rim.com>
  6328. [BlackBerry] Make selection in search input box not overlap cancel button
  6329. https://bugs.webkit.org/show_bug.cgi?id=100130
  6330. Reviewed by Antonio Gomes.
  6331. This ensures that even when selection is active, the user can still press 'cancel'.
  6332. * WebKitSupport/InputHandler.cpp:
  6333. (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
  6334. 2012-10-23 Arvid Nilsson <anilsson@rim.com>
  6335. [BlackBerry] Let WebKit manage the SelectionOverlay
  6336. https://bugs.webkit.org/show_bug.cgi?id=99585
  6337. Reviewed by Rob Buis.
  6338. The SelectionOverlay was exposed to clients of the BlackBerry::WebKit
  6339. API. However, all the information and notifications necessary to manage
  6340. the SelectionOverlay are available within WebKit, so the client does
  6341. not have to shoulder this responsibility.
  6342. Remove WebSelection and all the related plumbing. Now that nobody is
  6343. using the class from the user interface thread, remove the message
  6344. related code in SelectionOverlay.
  6345. Add two calls to SelectionOverlay::hide() that are necessary now that
  6346. the client is no longer responsible for hiding it.
  6347. RIM PR: 225789
  6348. Reviewed internally by Mike Fenton.
  6349. * Api/WebPage.cpp:
  6350. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  6351. * Api/WebPage.h:
  6352. (WebKit):
  6353. * Api/WebPage_p.h:
  6354. (WebPagePrivate):
  6355. * Api/WebSelectionOverlay.h: Removed.
  6356. * WebKitSupport/SelectionHandler.cpp:
  6357. (BlackBerry::WebKit::SelectionHandler::cancelSelection): Hide the overlay here, because state is reset and selection mode is no longer active
  6358. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): Also hide overlay here, to go with the call to cancelSelectionVisuals
  6359. * WebKitSupport/SelectionOverlay.cpp:
  6360. (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
  6361. * WebKitSupport/SelectionOverlay.h:
  6362. (BlackBerry::WebKit::SelectionOverlay::create):
  6363. (SelectionOverlay):
  6364. 2012-10-22 Mike Fenton <mifenton@rim.com>
  6365. [BlackBerry] Remove specialized handling for isIndex fields.
  6366. https://bugs.webkit.org/show_bug.cgi?id=100004
  6367. Reviewed by Rob Buis.
  6368. PR 214342.
  6369. Remove special handling for isIndex field as the tag
  6370. is rewritten.
  6371. Reviewed Internally by Yongxin Dai and Nima Ghanavatian.
  6372. * WebKitSupport/InputHandler.cpp:
  6373. (BlackBerry::WebKit::inputStyle):
  6374. (BlackBerry::WebKit::InputHandler::elementType):
  6375. 2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
  6376. [Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
  6377. https://bugs.webkit.org/show_bug.cgi?id=98514
  6378. Reviewed by Kenneth Rohde Christiansen.
  6379. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6380. (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
  6381. 2012-10-20 Andrew Lo <anlo@rim.com>
  6382. [BlackBerry] m_mainFrame should be null checked before use in WebPagePrivate destructor
  6383. https://bugs.webkit.org/show_bug.cgi?id=99916
  6384. Reviewed by George Staikos.
  6385. Internally reviewed by Arvid Nilsson.
  6386. Internal PR228029
  6387. Add null checks for m_mainFrame for things that happen during
  6388. WebPage destruction.
  6389. * Api/WebPage.cpp:
  6390. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  6391. (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
  6392. 2012-10-19 Mike Fenton <mifenton@rim.com>
  6393. [BlackBerry] Convert input style to int64_t
  6394. https://bugs.webkit.org/show_bug.cgi?id=99848
  6395. Reviewed by Yong Li.
  6396. PR 227381.
  6397. Switch input style mask to int64_t to match the the updated definition.
  6398. Reviewed Internally by Nima Ghanavatian.
  6399. * Api/WebPageClient.h:
  6400. * WebKitSupport/InputHandler.cpp:
  6401. (BlackBerry::WebKit::inputStyle):
  6402. * WebKitSupport/InputHandler.h:
  6403. (InputHandler):
  6404. 2012-10-19 Mike Fenton <mifenton@rim.com>
  6405. [BlackBerry] Move all keyboard type calculations into InputHandler.
  6406. https://bugs.webkit.org/show_bug.cgi?id=99847
  6407. Reviewed by Yong Li.
  6408. PR 227381.
  6409. Move all keyboard type calculations into webkit and avoid passing type
  6410. information to the webview.
  6411. Reviewed Internally by Nima Ghanavatian.
  6412. * Api/WebPageClient.h:
  6413. * WebKitSupport/InputHandler.cpp:
  6414. (BlackBerry::WebKit::convertInputTypeToVKBType):
  6415. (WebKit):
  6416. (BlackBerry::WebKit::InputHandler::setElementFocused):
  6417. 2012-10-19 Jacky Jiang <zhajiang@rim.com>
  6418. [BlackBerry] Page viewport aspect ratio not kept on navigating back
  6419. https://bugs.webkit.org/show_bug.cgi?id=99760
  6420. Reviewed by Yong Li.
  6421. Internally reviewed by Konrad Piascik
  6422. PR: 222437
  6423. This is to fix the second issue on PR222437 that the viewport not kept
  6424. when navigating back from google after rotation to bloomberg.
  6425. We were trying to restore the history contents size and scale of
  6426. bloomberg which has virtual viewport. The scale would be recalculated
  6427. based on the new screen size. However, we would still use the current
  6428. contents size if it was greater than the history contents size in
  6429. FrameView::setContentsSize which made the contents seem to be scaled
  6430. too much.
  6431. Actually when we relayout the contents after rotation change, the
  6432. current contents size which is based on the virtual viewport has taken
  6433. the screen size into account. Shrinking the contents size will be
  6434. expensive. So we can ignore screen size based scale calculation here.
  6435. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6436. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  6437. 2012-10-19 Mike Fenton <mifenton@rim.com>
  6438. [BlackBerry] Add input logs to InputHandler::ensureFocusTextElementVisible.
  6439. https://bugs.webkit.org/show_bug.cgi?id=99837
  6440. Reviewed by Antonio Gomes.
  6441. Add input logs for InputHandler::ensureFocusTextElementVisible.
  6442. Reviewed Internally by Nima Ghanavatian.
  6443. * WebKitSupport/InputHandler.cpp:
  6444. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  6445. 2012-10-19 Andrew Lo <anlo@rim.com>
  6446. [BlackBerry] Should suspend AnimationController when WebPage becomes invisible.
  6447. https://bugs.webkit.org/show_bug.cgi?id=99844
  6448. Reviewed by Yong Li.
  6449. Internally reviewed by Arvid Nilsson & Yong Li.
  6450. Suspend animation controller when the tab becomes invisible,
  6451. in addition to suspending scripted animations.
  6452. * Api/WebPage.cpp:
  6453. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  6454. 2012-10-19 Mike Fenton <mifenton@rim.com>
  6455. [BlackBerry] Don't attempt to auto scroll on input for Fixed Position elements.
  6456. https://bugs.webkit.org/show_bug.cgi?id=99833
  6457. Reviewed by Antonio Gomes.
  6458. PR 195024.
  6459. Don't attempt to scroll fixed position elements.
  6460. Reviewed Internally by Arvid Nilsson.
  6461. * WebKitSupport/DOMSupport.cpp:
  6462. (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
  6463. (DOMSupport):
  6464. * WebKitSupport/DOMSupport.h:
  6465. (WebCore):
  6466. * WebKitSupport/InputHandler.cpp:
  6467. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  6468. 2012-10-18 Jacky Jiang <zhajiang@rim.com>
  6469. [BlackBerry] Page viewport aspect ratio not kept on navigating back
  6470. https://bugs.webkit.org/show_bug.cgi?id=99760
  6471. Reviewed by Rob Buis.
  6472. Internally reviewed by Konrad Piascik.
  6473. PR: 190469
  6474. This was added in r127628 which was trying to fix some rendering
  6475. defects on maps.google.com and news.qq.com, however it was very harmful
  6476. and caused regressions.
  6477. zoomToFitScale() depends on the current contents size. During history
  6478. navigation and device rotation, if zoomToFitScale() is based on the
  6479. final contents size which is expected, there will still be a scale
  6480. calculation like this afterwards
  6481. screenSize.width()/screenSize.height()*zoomToFitScale() which will
  6482. result in a wrong scale. During the history navigation, if
  6483. zoomToFitScale() isn't based on the final contents size, then we will
  6484. get the wrong scale as well for sure.
  6485. This issue will be fixed by removing the wrong calculation.
  6486. The original issue of r127628 was fixed by the patch of PR225981.
  6487. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6488. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  6489. 2012-10-18 John Griggs <jgriggs@rim.com>
  6490. 2012-10-18 John Griggs <jgriggs@rim.com>
  6491. Crash in InRegionScrollableArea constructor while loading page
  6492. https://bugs.webkit.org/show_bug.cgi?id=99733
  6493. Reviewed by Antonio Gomes.
  6494. Check scrollLayer and avoid constructing InRegionScrollableArea when it is NULL.
  6495. * Api/InRegionScroller.cpp:
  6496. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  6497. 2012-10-17 Jacky Jiang <zhajiang@rim.com>
  6498. [BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
  6499. https://bugs.webkit.org/show_bug.cgi?id=99624
  6500. Reviewed by Rob Buis.
  6501. Internally reviewed by Arvid Nilsson
  6502. PR: 225981
  6503. Several reasons to eliminate the ancient unnecessary
  6504. zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:
  6505. - At this point, we have only committed the data we received.
  6506. - For the new load, we haven't started parsing the tokens and building
  6507. the DOM tree and the first layout will happen after that.
  6508. - For the load restored from cache, the first layout will happen after
  6509. setLoadState committed which is called by
  6510. FrameLoader::dispatchDidCommitLoad().
  6511. - zoomToInitialScaleOnLoad() can still be called after the first
  6512. layout finished.
  6513. - zoomToInitialScaleOnLoad() is expensive and it will boost the load
  6514. performance after the removal.
  6515. - Removal of this can fix some weird rendering defects on yahoo.com,
  6516. maps.google.com, news.qq.com and so on during load and rotation
  6517. mentioned on the PR.
  6518. * Api/WebPage.cpp:
  6519. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  6520. 2012-10-17 Mike Fenton <mifenton@rim.com>
  6521. [BlackBerry] Prevent focus zoom on non-userscalable pages.
  6522. https://bugs.webkit.org/show_bug.cgi?id=99608
  6523. Reviewed by Rob Buis.
  6524. PR 222378.
  6525. Disable focus zoom when the page is non-user scalable.
  6526. Reviewed Internally by Nima Ghanavatian.
  6527. * WebKitSupport/InputHandler.cpp:
  6528. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  6529. 2012-10-16 Mike Lattanzio <mlattanzio@rim.com>
  6530. 2012-10-16 Mike Lattanzio <mlattanzio@rim.com>
  6531. [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
  6532. https://bugs.webkit.org/show_bug.cgi?id=99497
  6533. Reviewed by Antonio Gomes.
  6534. Fix calculateInRegionScrollableAreasForPoint to use a ReadOnly
  6535. hit test to improve its performance.
  6536. * Api/InRegionScroller.cpp:
  6537. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  6538. 2012-10-15 Peter Wang <peter.wang@torchmobile.com.cn>
  6539. [BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
  6540. https://bugs.webkit.org/show_bug.cgi?id=99404
  6541. Reviewed by George Staikos.
  6542. In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.
  6543. * WebCoreSupport/inspectorBB.js:
  6544. 2012-10-15 Jakob Petsovits <jpetsovits@rim.com>
  6545. [BlackBerry] Only reallocate buffers that were allocated before suspending
  6546. https://bugs.webkit.org/show_bug.cgi?id=99205
  6547. RIM PR 99395
  6548. Reviewed by Antonio Gomes.
  6549. When we call releaseBuffers(), not all of the backingstore
  6550. tile buffers might have been allocated yet. Still we try
  6551. to release all of them, which causes us to lazy-initialize
  6552. the tile buffers so we can release them again.
  6553. This is stupid and we should just ignore buffers that
  6554. haven't been initialized yet. This patch makes that change.
  6555. * WebKitSupport/BackingStoreTile.cpp:
  6556. (BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
  6557. (WebKit):
  6558. * WebKitSupport/BackingStoreTile.h:
  6559. (TileBuffer):
  6560. * WebKitSupport/SurfacePool.cpp:
  6561. (BlackBerry::WebKit::SurfacePool::createBuffers):
  6562. (BlackBerry::WebKit::SurfacePool::releaseBuffers):
  6563. 2012-10-15 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  6564. [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
  6565. https://bugs.webkit.org/show_bug.cgi?id=99302
  6566. Reviewed by Rob Buis.
  6567. RIM PR: 210884
  6568. The marco BBLOG() is defined as a no-op in release mode which will
  6569. save a function call in the release build.
  6570. Internally reviewed by Charles Wei.
  6571. * Api/BackingStore.cpp:
  6572. (BlackBerry::WebKit::bestDivisor):
  6573. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
  6574. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  6575. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  6576. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  6577. (BlackBerry::WebKit::BackingStorePrivate::scroll):
  6578. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  6579. (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
  6580. (BlackBerry::WebKit::BackingStorePrivate::render):
  6581. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  6582. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  6583. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  6584. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  6585. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  6586. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  6587. (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
  6588. * Api/WebPage.cpp:
  6589. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  6590. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  6591. (BlackBerry::WebKit::WebPagePrivate::contentsSizeChanged):
  6592. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  6593. (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
  6594. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  6595. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  6596. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  6597. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6598. (WebCore::ChromeClientBlackBerry::overflowExceedsContentsSize):
  6599. (WebCore::ChromeClientBlackBerry::didDiscoverFrameSet):
  6600. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6601. (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
  6602. * WebKitSupport/FatFingers.cpp:
  6603. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  6604. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  6605. (BlackBerry::WebKit::FatFingers::checkForText):
  6606. * WebKitSupport/RenderQueue.cpp:
  6607. (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
  6608. (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
  6609. (BlackBerry::WebKit::RenderQueue::render):
  6610. (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
  6611. (BlackBerry::WebKit::RenderQueue::startRegularRenderJobBatchIfNeeded):
  6612. (BlackBerry::WebKit::RenderQueue::renderVisibleZoomJob):
  6613. (BlackBerry::WebKit::RenderQueue::renderVisibleScrollJob):
  6614. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
  6615. (BlackBerry::WebKit::RenderQueue::renderNonVisibleScrollJob):
  6616. * WebKitSupport/SurfacePool.cpp:
  6617. (BlackBerry::WebKit::SurfacePool::initialize):
  6618. 2012-10-15 Xiaobo Wang <xbwang@torchmobile.com.cn>
  6619. [BlackBerry] [DRT] Skip region of interest zooming when running DRT
  6620. https://bugs.webkit.org/show_bug.cgi?id=97663
  6621. Reviewed by Rob Buis.
  6622. This patch fixes test fast/forms/textarea-scrolled-endline-caret.html, and
  6623. 1. Add a global function isRunningDrt to check if we're currently running DRT.
  6624. 2. Use the new function in places where getenv("drtRun") is used.
  6625. * Api/BlackBerryGlobal.cpp:
  6626. (BlackBerry::WebKit::isRunningDrt):
  6627. (WebKit):
  6628. * Api/BlackBerryGlobal.h:
  6629. (WebKit):
  6630. * Api/WebPage.cpp:
  6631. (BlackBerry::WebKit::WebPagePrivate::init):
  6632. * WebKitSupport/DumpRenderTreeSupport.cpp:
  6633. (toGeolocationClientMock):
  6634. * WebKitSupport/InputHandler.cpp:
  6635. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  6636. 2012-10-15 George Staikos <staikos@webkit.org>
  6637. [BlackBerry] Adapt to Platform API changes in string handling
  6638. https://bugs.webkit.org/show_bug.cgi?id=99248
  6639. Reviewed by Yong Li.
  6640. Convert usage of WebString, char* and std::string to BlackBerry::Platform::String.
  6641. * Api/BlackBerryGlobal.cpp:
  6642. (BlackBerry::WebKit::clearAppCache):
  6643. (BlackBerry::WebKit::clearDatabase):
  6644. * Api/BlackBerryGlobal.h:
  6645. (Platform):
  6646. (WebKit):
  6647. * Api/JavaScriptVariant.cpp:
  6648. (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
  6649. (BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
  6650. (BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
  6651. (WebKit):
  6652. (BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
  6653. (BlackBerry::WebKit::JavaScriptVariant::setType):
  6654. (BlackBerry::WebKit::JavaScriptVariant::setString):
  6655. (BlackBerry::WebKit::JavaScriptVariant::stringValue):
  6656. * Api/JavaScriptVariant.h:
  6657. * Api/WebAnimation.cpp:
  6658. (BlackBerry::WebKit::WebAnimation::fadeAnimation):
  6659. (BlackBerry::WebKit::WebAnimation::name):
  6660. * Api/WebAnimation.h:
  6661. * Api/WebCookieJar.cpp:
  6662. (BlackBerry::WebKit::WebCookieJar::cookies):
  6663. (BlackBerry::WebKit::WebCookieJar::setCookies):
  6664. * Api/WebCookieJar.h:
  6665. (Platform):
  6666. (BlackBerry):
  6667. (WebKit):
  6668. * Api/WebKitMIMETypeConverter.cpp:
  6669. (BlackBerry::WebKit::getExtensionForMimeType):
  6670. (BlackBerry::WebKit::getMimeTypeForExtension):
  6671. * Api/WebKitMIMETypeConverter.h:
  6672. (Platform):
  6673. (BlackBerry):
  6674. (WebKit):
  6675. * Api/WebKitTextCodec.cpp:
  6676. (BlackBerry::WebKit::base64Decode):
  6677. (BlackBerry::WebKit::base64Encode):
  6678. (BlackBerry::WebKit::unescapeURL):
  6679. (BlackBerry::WebKit::escapeURL):
  6680. * Api/WebKitTextCodec.h:
  6681. (Platform):
  6682. (BlackBerry):
  6683. * Api/WebOverlay.cpp:
  6684. (BlackBerry::WebKit::WebOverlay::removeAnimation):
  6685. * Api/WebOverlay.h:
  6686. (Platform):
  6687. (BlackBerry):
  6688. (WebKit):
  6689. * Api/WebOverlayOverride.cpp:
  6690. (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
  6691. * Api/WebOverlayOverride.h:
  6692. (Platform):
  6693. (BlackBerry):
  6694. (WebKit):
  6695. * Api/WebPage.cpp:
  6696. (BlackBerry::WebKit::WebPage::autofillTextField):
  6697. (BlackBerry::WebKit::WebPage::renderTreeAsText):
  6698. (BlackBerry::WebKit::WebPage::WebPage):
  6699. (BlackBerry::WebKit::WebPagePrivate::init):
  6700. (BlackBerry::WebKit::WebPagePrivate::load):
  6701. (BlackBerry::WebKit::WebPage::load):
  6702. (BlackBerry::WebKit::WebPage::loadFile):
  6703. (BlackBerry::WebKit::WebPage::download):
  6704. (BlackBerry::WebKit::WebPagePrivate::loadString):
  6705. (BlackBerry::WebKit::WebPage::loadString):
  6706. (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
  6707. (BlackBerry::WebKit::WebPage::executeJavaScript):
  6708. (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
  6709. (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
  6710. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  6711. (BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
  6712. (BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
  6713. (BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
  6714. (BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
  6715. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  6716. (BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
  6717. (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
  6718. (BlackBerry::WebKit::WebPagePrivate::webContext):
  6719. (BlackBerry::WebKit::WebPage::setDateTimeInput):
  6720. (BlackBerry::WebKit::WebPage::setColorInput):
  6721. (BlackBerry::WebKit::WebPage::textEncoding):
  6722. (BlackBerry::WebKit::WebPage::forcedTextEncoding):
  6723. (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
  6724. (BlackBerry::WebKit::WebPage::title):
  6725. (BlackBerry::WebKit::WebPage::selectedText):
  6726. (BlackBerry::WebKit::WebPage::cutSelectedText):
  6727. (BlackBerry::WebKit::WebPage::insertText):
  6728. (BlackBerry::WebKit::WebPage::getBackForwardList):
  6729. (BlackBerry::WebKit::WebPage::onCertificateStoreLocationSet):
  6730. (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
  6731. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  6732. (BlackBerry::WebKit::WebPage::textHasAttribute):
  6733. (BlackBerry::WebKit::WebPage::setAllowNotification):
  6734. (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
  6735. * Api/WebPage.h:
  6736. * Api/WebPageClient.h:
  6737. * Api/WebPage_p.h:
  6738. (WebPagePrivate):
  6739. * Api/WebSettings.cpp:
  6740. (BlackBerry::WebKit::WebSettings::standardSettings):
  6741. (BlackBerry::WebKit::WebSettings::addSupportedObjectPluginMIMEType):
  6742. (BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
  6743. (BlackBerry::WebKit::WebSettings::serifFontFamily):
  6744. (BlackBerry::WebKit::WebSettings::setSerifFontFamily):
  6745. (BlackBerry::WebKit::WebSettings::fixedFontFamily):
  6746. (BlackBerry::WebKit::WebSettings::setFixedFontFamily):
  6747. (BlackBerry::WebKit::WebSettings::sansSerifFontFamily):
  6748. (BlackBerry::WebKit::WebSettings::setSansSerifFontFamily):
  6749. (BlackBerry::WebKit::WebSettings::standardFontFamily):
  6750. (BlackBerry::WebKit::WebSettings::setStandardFontFamily):
  6751. (BlackBerry::WebKit::WebSettings::userAgentString):
  6752. (BlackBerry::WebKit::WebSettings::setUserAgentString):
  6753. (BlackBerry::WebKit::WebSettings::defaultTextEncodingName):
  6754. (BlackBerry::WebKit::WebSettings::setDefaultTextEncodingName):
  6755. (BlackBerry::WebKit::WebSettings::userStyleSheetString):
  6756. (BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
  6757. (BlackBerry::WebKit::WebSettings::userStyleSheetLocation):
  6758. (BlackBerry::WebKit::WebSettings::setUserStyleSheetLocation):
  6759. (BlackBerry::WebKit::WebSettings::localStoragePath):
  6760. (BlackBerry::WebKit::WebSettings::setLocalStoragePath):
  6761. (BlackBerry::WebKit::WebSettings::indexedDataBasePath):
  6762. (BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
  6763. (BlackBerry::WebKit::WebSettings::databasePath):
  6764. (BlackBerry::WebKit::WebSettings::setDatabasePath):
  6765. (BlackBerry::WebKit::WebSettings::appCachePath):
  6766. (BlackBerry::WebKit::WebSettings::setAppCachePath):
  6767. (BlackBerry::WebKit::WebSettings::pageGroupName):
  6768. (BlackBerry::WebKit::WebSettings::setPageGroupName):
  6769. * Api/WebSettings.h:
  6770. * Api/WebString.cpp: Removed.
  6771. * Api/WebString.h: Removed.
  6772. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6773. (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
  6774. (WebCore::ChromeClientBlackBerry::createWindow):
  6775. (WebCore::ChromeClientBlackBerry::runOpenPanel):
  6776. (WebCore):
  6777. * WebCoreSupport/ChromeClientBlackBerry.h:
  6778. (ChromeClientBlackBerry):
  6779. * WebCoreSupport/ClientExtension.cpp:
  6780. (clientExtensionMethod):
  6781. * WebCoreSupport/ColorPickerClient.cpp:
  6782. (WebCore::ColorPickerClient::ColorPickerClient):
  6783. (WebCore::ColorPickerClient::generateHTML):
  6784. * WebCoreSupport/ColorPickerClient.h:
  6785. (Platform):
  6786. (BlackBerry):
  6787. (WebKit):
  6788. (ColorPickerClient):
  6789. * WebCoreSupport/CredentialManager.cpp:
  6790. (WebCore::CredentialManager::autofillAuthenticationChallenge):
  6791. * WebCoreSupport/CredentialManager.h:
  6792. (Platform):
  6793. (CredentialManager):
  6794. * WebCoreSupport/DatePickerClient.cpp:
  6795. (WebCore::DatePickerClient::DatePickerClient):
  6796. (WebCore::DatePickerClient::generateHTML):
  6797. * WebCoreSupport/DatePickerClient.h:
  6798. (Platform):
  6799. (BlackBerry):
  6800. (WebKit):
  6801. (DatePickerClient):
  6802. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6803. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
  6804. (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
  6805. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  6806. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
  6807. (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
  6808. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  6809. (WebCore::FrameLoaderClientBlackBerry::loadIconExternally):
  6810. (WebCore::FrameLoaderClientBlackBerry::startDownload):
  6811. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
  6812. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  6813. * WebCoreSupport/NotificationPresenterImpl.cpp:
  6814. (WebCore::NotificationPresenterImpl::show):
  6815. (WebCore::NotificationPresenterImpl::cancel):
  6816. (WebCore::NotificationPresenterImpl::requestPermission):
  6817. (WebCore::NotificationPresenterImpl::onPermission):
  6818. (WebCore::NotificationPresenterImpl::notificationClicked):
  6819. * WebCoreSupport/NotificationPresenterImpl.h:
  6820. (Platform):
  6821. (NotificationPresenterImpl):
  6822. * WebCoreSupport/SelectPopupClient.cpp:
  6823. (WebCore::SelectPopupClient::SelectPopupClient):
  6824. (WebCore::SelectPopupClient::update):
  6825. (WebCore::SelectPopupClient::generateHTML):
  6826. * WebCoreSupport/SelectPopupClient.h:
  6827. (Platform):
  6828. (BlackBerry):
  6829. (SelectPopupClient):
  6830. * WebCoreSupport/UserMediaClientImpl.cpp:
  6831. (WebCore::toMediaStreamSource):
  6832. (WebCore::toMediaStreamDescriptor):
  6833. (WebCore::UserMediaClientImpl::requestUserMedia):
  6834. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  6835. * WebKitSupport/AboutData.cpp:
  6836. (BlackBerry::WebKit::cachePage):
  6837. * WebKitSupport/InputHandler.cpp:
  6838. (BlackBerry::WebKit::convertStringToWchar):
  6839. (BlackBerry::WebKit::convertStringToWcharVector):
  6840. (BlackBerry::WebKit::convertSpannableStringToString):
  6841. (BlackBerry::WebKit::InputHandler::learnText):
  6842. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  6843. (BlackBerry::WebKit::InputHandler::openDatePopup):
  6844. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  6845. (BlackBerry::WebKit::InputHandler::setText):
  6846. * WebKitSupport/SelectionHandler.cpp:
  6847. (BlackBerry::WebKit::SelectionHandler::selectedText):
  6848. * WebKitSupport/SelectionHandler.h:
  6849. (Platform):
  6850. (WebKit):
  6851. (SelectionHandler):
  6852. * WebKitSupport/SurfacePool.cpp:
  6853. (BlackBerry::WebKit::SurfacePool::sharedPixmapGroup):
  6854. * WebKitSupport/SurfacePool.h:
  6855. (SurfacePool):
  6856. 2012-10-15 Antonio Gomes <agomes@rim.com>
  6857. [BlackBerry] Clean up BackingStoreClient (part II)
  6858. https://bugs.webkit.org/show_bug.cgi?id=99327
  6859. Reviewed by Yong Li.
  6860. Remove more unneeded BackingStoreClient <-> WebPageClient integration
  6861. methods:
  6862. - BackingStoreClient* backingStoreClientForFrame(...)
  6863. - void addBackingStoreClientForFrame(...)
  6864. - void removeBackingStoreClientForFrame(...)
  6865. Change places calling WPPriv::backingStoreClientForFrame to directly
  6866. access WPPriv::backingStoreClient instead, since only the main frame will
  6867. have a BackingStoreClient instance associated with it, and it is owned by
  6868. the WKPriv.
  6869. Remove non-mainframe only references to BackingStoreClient completely,
  6870. since it is dead code now.
  6871. * Api/InRegionScroller.cpp:
  6872. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  6873. * Api/WebPage.cpp:
  6874. (BlackBerry::WebKit::WebPagePrivate::backingStoreClient):
  6875. (BlackBerry::WebKit::WebPage::destroy):
  6876. * Api/WebPage_p.h:
  6877. (WebPagePrivate):
  6878. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  6879. (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
  6880. (WebCore::ChromeClientBlackBerry::scroll):
  6881. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  6882. (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
  6883. (WebCore::FrameLoaderClientBlackBerry::createFrame):
  6884. (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
  6885. * WebKitSupport/BackingStoreClient.cpp:
  6886. (BlackBerry::WebKit::BackingStoreClient::create):
  6887. (BlackBerry::WebKit::BackingStoreClient::BackingStoreClient):
  6888. (BlackBerry::WebKit::BackingStoreClient::~BackingStoreClient):
  6889. * WebKitSupport/BackingStoreClient.h:
  6890. (BackingStoreClient):
  6891. * WebKitSupport/InputHandler.cpp:
  6892. (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
  6893. 2012-10-15 Antonio Gomes <agomes@rim.com>
  6894. [BlackBerry] Clean up BackingStoreClient (part I)
  6895. https://bugs.webkit.org/show_bug.cgi?id=99327
  6896. Reviewed by Yong Li.
  6897. Now that we won't use the BackingStoreClient code path to scroll inner frames at all
  6898. (instead we use AC layers!), we can remove all "!isMainFrame" code paths.
  6899. No behavior change, since the code path being removed was not in use.
  6900. * WebKitSupport/BackingStoreClient.cpp:
  6901. (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
  6902. (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
  6903. (BlackBerry::WebKit::BackingStoreClient::viewportSize):
  6904. (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
  6905. (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
  6906. (BlackBerry::WebKit::BackingStoreClient::transformedVisibleContentsRect):
  6907. (BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation):
  6908. 2012-10-13 Jakob Petsovits <jpetsovits@rim.com>
  6909. [BlackBerry] Fetch blit rects from a viewport accessor
  6910. https://bugs.webkit.org/show_bug.cgi?id=98581
  6911. RIM PR 173292
  6912. Reviewed by George Staikos.
  6913. Internally reviewed by Arvid Nilsson.
  6914. The long-standing userInterfaceBlittedVisibleContentsRect()
  6915. method in WebPageClient has long been a major annoyance,
  6916. as it returns the source rect for WebKit contents but in
  6917. backingstore pixel coordinates. This makes it not only
  6918. unwieldy but also terribly fragile, especially when
  6919. both pinch zoom and a backingstore re-render both deal
  6920. with the same rectangle. On different threads, even.
  6921. BlackBerry::Platform now exposes a ViewportAccessor
  6922. interface, which can be used to get the various rects
  6923. in document coordinates or target pixel coordinates,
  6924. both being a better choice than the ones dependent
  6925. on an implentation detail.
  6926. This commit makes use of this new functionality.
  6927. Instead of relying on the passed rectangle to contain
  6928. implicit information about the scale factor, we now
  6929. track the scale of each backingstore geometry by making
  6930. a snapshot of the current WebKit-thread scale when the
  6931. geometry is generated. Once the geometry is swapped to
  6932. the front, we can then calculate the remaining
  6933. backingstore-to-viewport transformation in a threadsafe
  6934. way. We now only calculate this if we actually blit from
  6935. backingstore tiles and don't go through a configuration
  6936. of pure accelerated compositing.
  6937. As a result, we are now a lot more robust against
  6938. synchonization issues related to backingstore
  6939. geometry changes. As an additional gimmick, the scale
  6940. is also stored with each tile buffer to doubly secure
  6941. that a tile rendered in one scale is not transferred
  6942. to a different geometry and then rendered there without
  6943. being rerendered at the new scale, even if the rendered
  6944. pixel coordinates are still the same.
  6945. Having per-geometry scale information also opens up
  6946. opportunities to further improve backingstore rendering
  6947. later. For instance, we could pre-render a low-res
  6948. version of the page onto one buffer and combine that one
  6949. with a higher-res array of tiles covering a smaller area.
  6950. Or we could steal some tiles from the front geometry to
  6951. render them at a new scale while a pinch-zoom operation
  6952. is in progress.
  6953. No such thing is implemented in this patch though.
  6954. In adapting/fixing the backingstore visualization
  6955. debug mode and the default background painting in
  6956. renderDirectToWindow(), we also introduce new
  6957. ViewportAccessor subclasses that can subsequently
  6958. be used to replace methods from WebPage and elsewhere.
  6959. * Api/BackingStore.cpp:
  6960. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  6961. (BlackBerry::WebKit::BackingStorePrivate::scroll):
  6962. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  6963. (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
  6964. (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
  6965. (BlackBerry::WebKit::BackingStorePrivate::render):
  6966. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  6967. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  6968. (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
  6969. (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
  6970. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  6971. (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
  6972. (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
  6973. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  6974. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  6975. * Api/BackingStore_p.h:
  6976. (BlackBerry):
  6977. (Platform):
  6978. (BlackBerry::WebKit::BackingStoreGeometry::BackingStoreGeometry):
  6979. (BlackBerry::WebKit::BackingStoreGeometry::scale):
  6980. (BlackBerry::WebKit::BackingStoreGeometry::setScale):
  6981. (BackingStoreGeometry):
  6982. (BackingStorePrivate):
  6983. * Api/WebPage.cpp:
  6984. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  6985. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  6986. (BlackBerry::WebKit::WebPagePrivate::init):
  6987. (BlackBerry::WebKit::WebPage::webkitThreadViewportAccessor):
  6988. (WebKit):
  6989. * Api/WebPage.h:
  6990. (Platform):
  6991. * Api/WebPageClient.h:
  6992. (Platform):
  6993. * Api/WebPageCompositor.cpp:
  6994. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
  6995. * Api/WebPage_p.h:
  6996. (WebKit):
  6997. (WebPagePrivate):
  6998. * WebKitSupport/BackingStoreTile.cpp:
  6999. (BlackBerry::WebKit::TileBuffer::TileBuffer):
  7000. (BlackBerry::WebKit::TileBuffer::isRendered):
  7001. * WebKitSupport/BackingStoreTile.h:
  7002. (TileBuffer):
  7003. (BlackBerry::WebKit::TileBuffer::scale):
  7004. (BlackBerry::WebKit::TileBuffer::setScale):
  7005. * WebKitSupport/BackingStoreVisualizationViewportAccessor.cpp: Added.
  7006. (WebKit):
  7007. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::BackingStoreVisualizationViewportAccessor):
  7008. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelContentsSize):
  7009. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentContentsSize):
  7010. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelScrollPosition):
  7011. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentScrollPosition):
  7012. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelViewportSize):
  7013. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentViewportSize):
  7014. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::destinationSurfaceOffset):
  7015. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::scale):
  7016. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::state):
  7017. * WebKitSupport/BackingStoreVisualizationViewportAccessor.h: Added.
  7018. (BlackBerry):
  7019. (Platform):
  7020. (WebKit):
  7021. (BackingStoreVisualizationViewportAccessor):
  7022. (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::~BackingStoreVisualizationViewportAccessor):
  7023. * WebKitSupport/WebKitThreadViewportAccessor.cpp: Added.
  7024. (WebKit):
  7025. (BlackBerry::WebKit::WebKitThreadViewportAccessor::WebKitThreadViewportAccessor):
  7026. (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
  7027. (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentContentsSize):
  7028. (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
  7029. (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentScrollPosition):
  7030. (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelViewportSize):
  7031. (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
  7032. (BlackBerry::WebKit::WebKitThreadViewportAccessor::destinationSurfaceOffset):
  7033. (BlackBerry::WebKit::WebKitThreadViewportAccessor::scale):
  7034. * WebKitSupport/WebKitThreadViewportAccessor.h: Added.
  7035. (BlackBerry):
  7036. (Platform):
  7037. (WebKit):
  7038. (WebKitThreadViewportAccessor):
  7039. (BlackBerry::WebKit::WebKitThreadViewportAccessor::~WebKitThreadViewportAccessor):
  7040. 2012-10-11 Peter Wang <peter.wang@torchmobile.com.cn>
  7041. [BlackBerry] Paused in Inspector, Browser doesn't exit cleanly
  7042. https://bugs.webkit.org/show_bug.cgi?id=97962
  7043. Reviewed by George Staikos.
  7044. Before destroying webpage, close the inspector, so if the JSC is paused it will be resumed.
  7045. * Api/WebPage.cpp:
  7046. (BlackBerry::WebKit::WebPage::destroy):
  7047. 2012-10-11 Konrad Piascik <kpiascik@rim.com>
  7048. Web Inspector: node search does not work with elements on touch start listener
  7049. https://bugs.webkit.org/show_bug.cgi?id=95252
  7050. Reviewed by Pavel Feldman.
  7051. Removed calls to InspectorInstrumentation that no didn't work anyway.
  7052. * Api/WebPage.cpp:
  7053. (BlackBerry::WebKit::WebPage::touchEvent):
  7054. 2012-10-11 Chris Guan <chris.guan@torchmobile.com.cn>
  7055. [Blackberry] makes NavigatorContentUtils work
  7056. https://bugs.webkit.org/show_bug.cgi?id=99022
  7057. Reviewed by Rob Buis.
  7058. Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and
  7059. r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler,
  7060. we need sync up code:
  7061. 1. Add NavigatorContentUtilsClientBlackBerry class.
  7062. 2. use new API provideNavigatorContentUtilsTo.
  7063. No new tests. Covered by existing tests.
  7064. * Api/WebPage.cpp:
  7065. (BlackBerry::WebKit::WebPagePrivate::init):
  7066. * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.cpp: Added.
  7067. (WebCore):
  7068. (WebCore::NavigatorContentUtilsClientBlackBerry::NavigatorContentUtilsClientBlackBerry):
  7069. (WebCore::NavigatorContentUtilsClientBlackBerry::registerProtocolHandler):
  7070. (WebCore::NavigatorContentUtilsClientBlackBerry::isProtocolHandlerRegistered):
  7071. (WebCore::NavigatorContentUtilsClientBlackBerry::unregisterProtocolHandler):
  7072. * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.h: Added.
  7073. (WebKit):
  7074. (NavigatorContentUtilsClientBlackBerry):
  7075. (WebCore::NavigatorContentUtilsClientBlackBerry::~NavigatorContentUtilsClientBlackBerry):
  7076. 2012-10-10 Lianghui Chen <liachen@rim.com>
  7077. [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
  7078. https://bugs.webkit.org/show_bug.cgi?id=97397
  7079. Internal PR: 186597.
  7080. Internally reviewed by Yong Li, Joe Mason.
  7081. Reviewed by George Staikos.
  7082. Update WebPage to use new AuthenticationChallengeManager.
  7083. Register page creation/deletion and visibility change to the new
  7084. AuthenticationChallengeManager.
  7085. Initialize AuthenticationChallengeManager in GlobalInitialize() function.
  7086. * Api/BlackBerryGlobal.cpp:
  7087. (BlackBerry::WebKit::globalInitialize):
  7088. * Api/WebPage.cpp:
  7089. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7090. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  7091. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  7092. (BlackBerry::WebKit::WebPage::setVisible):
  7093. * Api/WebPage_p.h:
  7094. (WebPagePrivate):
  7095. 2012-10-10 Andrew Lo <anlo@rim.com>
  7096. [BlackBerry] Do not perform backing store blit for animations during one-shot drawing synchronization
  7097. https://bugs.webkit.org/show_bug.cgi?id=98944
  7098. Reviewed by Rob Buis.
  7099. Internally reviewed by: Arvid Nilsson.
  7100. Internal PR 220014
  7101. Prevent animations from causing a backing store blit during a
  7102. one-shot drawing synchronization.
  7103. * Api/WebPageCompositor.cpp:
  7104. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
  7105. 2012-10-10 Mike Fenton <mifenton@rim.com>
  7106. [BlackBerry] Fix crash for detached node when validating selection change.
  7107. https://bugs.webkit.org/show_bug.cgi?id=98926
  7108. Reviewed by Rob Buis.
  7109. PR 220628.
  7110. Guard against detached nodes when generating selection rect.
  7111. * WebKitSupport/DOMSupport.cpp:
  7112. (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
  7113. 2012-10-10 Mike Fenton <mifenton@rim.com>
  7114. [BlackBerry] Adjust spell checking location to update after the cursor position is set.
  7115. https://bugs.webkit.org/show_bug.cgi?id=98904
  7116. Reviewed by Rob Buis.
  7117. PR 215172.
  7118. Delay calculation of caret position until it is updated on mouse release
  7119. handling.
  7120. Reviewed Internally by Nima Ghanavatian.
  7121. * WebKitSupport/InputHandler.cpp:
  7122. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  7123. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  7124. 2012-10-10 Mike Fenton <mifenton@rim.com>
  7125. [BlackBerry] Suppress keyboard requests while processing spell checking suggestions unless focus change is occurring..
  7126. https://bugs.webkit.org/show_bug.cgi?id=98903
  7127. Reviewed by Rob Buis.
  7128. PR 221143.
  7129. Suppress keyboard state changes when they are not triggered by
  7130. focus changes.
  7131. Reviewed Internally by Nima Ghanavatian.
  7132. * WebKitSupport/InputHandler.cpp:
  7133. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  7134. (BlackBerry::WebKit::InputHandler::setElementFocused):
  7135. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  7136. * WebKitSupport/InputHandler.h:
  7137. 2012-10-09 Rob Buis <rbuis@rim.com>
  7138. [BlackBerry] Cleanup FatFingers.cpp
  7139. https://bugs.webkit.org/show_bug.cgi?id=98806
  7140. Reviewed by Antonio Gomes.
  7141. Cleanup namespace usage and sync up FatFingers.cpp.
  7142. * WebKitSupport/FatFingers.cpp:
  7143. (BlackBerry::WebKit::compareDistanceBetweenPoints):
  7144. (BlackBerry::WebKit::FatFingers::findBestPoint):
  7145. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  7146. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  7147. (BlackBerry::WebKit::FatFingers::checkForClickableElement):
  7148. (BlackBerry::WebKit::FatFingers::checkForText):
  7149. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  7150. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
  7151. 2012-10-09 Antonio Gomes <agomes@rim.com>
  7152. Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
  7153. https://bugs.webkit.org/show_bug.cgi?id=98756
  7154. Reviewed by Rob Buis.
  7155. * Api/WebPage.cpp:
  7156. (BlackBerry::WebKit::WebPagePrivate::init):
  7157. 2012-10-09 Charles Wei <charles.wei@torchmobile.com.cn>
  7158. [BlackBerry] Need API to control the DNS Prefetching
  7159. https://bugs.webkit.org/show_bug.cgi?id=98713
  7160. Reviewed by George Staikos.
  7161. * Api/WebPage.cpp:
  7162. (BlackBerry::WebKit::WebPagePrivate::init):
  7163. (BlackBerry::WebKit::WebPage::enableDNSPrefetch):
  7164. (WebKit):
  7165. (BlackBerry::WebKit::WebPage::disableDNSPrefetch):
  7166. (BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
  7167. * Api/WebPage.h:
  7168. 2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  7169. Rename first/second to key/value in HashMap iterators
  7170. https://bugs.webkit.org/show_bug.cgi?id=82784
  7171. Reviewed by Eric Seidel.
  7172. * Api/BackingStore.cpp:
  7173. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  7174. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  7175. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  7176. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  7177. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  7178. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  7179. * WebCoreSupport/NotificationPresenterImpl.cpp:
  7180. (WebCore::NotificationPresenterImpl::cancel):
  7181. (WebCore::NotificationPresenterImpl::onPermission):
  7182. (WebCore::NotificationPresenterImpl::notificationClicked):
  7183. * WebCoreSupport/UserMediaClientImpl.cpp:
  7184. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  7185. * WebKitSupport/AboutData.cpp:
  7186. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  7187. * WebKitSupport/FrameLayers.cpp:
  7188. (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
  7189. (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
  7190. (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
  7191. 2012-10-05 Rob Buis <rbuis@rim.com>
  7192. [BlackBerry] Implement TestRunner.setMockDeviceOrientation
  7193. https://bugs.webkit.org/show_bug.cgi?id=98542
  7194. Reviewed by Antonio Gomes.
  7195. PR 120681
  7196. Provide framework for mock device motion.
  7197. * Api/WebPage.cpp:
  7198. (BlackBerry::WebKit::WebPagePrivate::init):
  7199. * WebKitSupport/DumpRenderTreeSupport.cpp:
  7200. (toDeviceOrientationClientMock):
  7201. (DumpRenderTreeSupport::setMockDeviceOrientation):
  7202. * WebKitSupport/DumpRenderTreeSupport.h:
  7203. (DumpRenderTreeSupport):
  7204. 2012-10-05 Konrad Piascik <kpiascik@rim.com>
  7205. [BlackBerry] Remove unnecessary html file.
  7206. https://bugs.webkit.org/show_bug.cgi?id=98531
  7207. Reviewed by Yong Li.
  7208. We now just use Source/WebCore/inspector/front-end/inspector.html
  7209. instead.
  7210. * WebCoreSupport/inspectorBB.html: Removed.
  7211. 2012-10-05 Antonio Gomes <agomes@rim.com>
  7212. [BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
  7213. https://bugs.webkit.org/show_bug.cgi?id=98517
  7214. PR #137382
  7215. Reviewed by Yong Li.
  7216. We've generalized composited in-region scrolling, originally only applicable
  7217. to block elements, to inner frames (see PR #197093). Past that, we no longer
  7218. need to force repaints of offscreen areas when we finish scrolling, since translating
  7219. the Layer takes care of properly invalidating it. Thus, remove this method.
  7220. * Api/WebPage.cpp:
  7221. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
  7222. * Api/WebPage_p.h:
  7223. (WebPagePrivate):
  7224. 2012-10-05 Mike Fenton <mifenton@rim.com>
  7225. [BlackBerry] Update default input support style for single line inputs.
  7226. https://bugs.webkit.org/show_bug.cgi?id=98510
  7227. Reviewed by Antonio Gomes.
  7228. PR 219588.
  7229. Update style calculations to eliminate automatic changes
  7230. by default on single line input fields.
  7231. Reviewed Internally by Gen Mak.
  7232. * WebKitSupport/InputHandler.cpp:
  7233. (BlackBerry::WebKit::inputStyle):
  7234. 2012-10-04 Simon Fraser <simon.fraser@apple.com>
  7235. Final part of "sync" to "flush" renaming
  7236. https://bugs.webkit.org/show_bug.cgi?id=98430
  7237. Reviewed by Tim Horton.
  7238. Change method names on GraphicsLayer and GraphicsLayerClient that
  7239. refer to "sync" to use the term "flush" instead, to be consistent
  7240. with the rest of the code.
  7241. * Api/WebOverlay.cpp:
  7242. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
  7243. * Api/WebOverlay_p.h:
  7244. (WebOverlayPrivateWebKitThread):
  7245. * Api/WebPage.cpp:
  7246. (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
  7247. * Api/WebPage_p.h:
  7248. (WebPagePrivate):
  7249. * WebKitSupport/DefaultTapHighlight.cpp:
  7250. (BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
  7251. * WebKitSupport/DefaultTapHighlight.h:
  7252. (DefaultTapHighlight):
  7253. * WebKitSupport/InspectorOverlayBlackBerry.cpp:
  7254. (BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
  7255. * WebKitSupport/InspectorOverlayBlackBerry.h:
  7256. (InspectorOverlay):
  7257. * WebKitSupport/SelectionOverlay.cpp:
  7258. (BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
  7259. * WebKitSupport/SelectionOverlay.h:
  7260. (SelectionOverlay):
  7261. 2012-10-04 Simon Fraser <simon.fraser@apple.com>
  7262. Standardize on "flush" terminology for compositing layer flushing/syncing
  7263. https://bugs.webkit.org/show_bug.cgi?id=98321
  7264. Reviewed by Simon Fraser.
  7265. Rename compositing-related methods that refer to "syncing" to instead
  7266. refer to "flushing".
  7267. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  7268. (WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):
  7269. * WebCoreSupport/ChromeClientBlackBerry.h:
  7270. (ChromeClientBlackBerry):
  7271. 2012-10-03 Antonio Gomes <agomes@rim.com>
  7272. [BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
  7273. https://bugs.webkit.org/show_bug.cgi?id=97917
  7274. PR #212920
  7275. Reviewed by Yong Li.
  7276. Internally reviewed by Jacky Jiang.
  7277. Inform the client of transform change so that we avoid
  7278. getting stuck on overscroll.
  7279. * Api/WebPage.cpp:
  7280. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  7281. 2012-10-03 Otto Derek Cheung <otcheung@rim.com>
  7282. [BlackBerry] Implementing the NetworkInfo API for BB port
  7283. https://bugs.webkit.org/show_bug.cgi?id=98273
  7284. Reviewed by Rob Buis.
  7285. Adding new class NetworkInfoClientBlackBerry to implement
  7286. NetworkInfoClient for the BlackBerry port.
  7287. * Api/WebPage.cpp:
  7288. (BlackBerry::WebKit::WebPagePrivate::init):
  7289. * WebCoreSupport/NetworkInfoClientBlackBerry.cpp: Added.
  7290. (WebCore):
  7291. (WebCore::NetworkInfoClientBlackBerry::NetworkInfoClientBlackBerry):
  7292. (WebCore::NetworkInfoClientBlackBerry::startUpdating):
  7293. (WebCore::NetworkInfoClientBlackBerry::stopUpdating):
  7294. (WebCore::NetworkInfoClientBlackBerry::bandwidth):
  7295. (WebCore::NetworkInfoClientBlackBerry::metered):
  7296. (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkChange):
  7297. (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
  7298. * WebCoreSupport/NetworkInfoClientBlackBerry.h: Added.
  7299. (WebKit):
  7300. (WebCore):
  7301. (NetworkInfoClientBlackBerry):
  7302. (WebCore::NetworkInfoClientBlackBerry::~NetworkInfoClientBlackBerry):
  7303. 2012-10-02 Anders Carlsson <andersca@apple.com>
  7304. Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
  7305. https://bugs.webkit.org/show_bug.cgi?id=98217
  7306. Reviewed by Andreas Kling.
  7307. * Api/WebPage.cpp:
  7308. (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
  7309. 2012-10-02 Yong Li <yoli@rim.com>
  7310. [BlackBerry] Prevent window.close() from closing pages that are not opened by JS
  7311. https://bugs.webkit.org/show_bug.cgi?id=98190
  7312. Reviewed by Antonio Gomes.
  7313. RIM PR# 217812.
  7314. Only pages opened by JS can be closed by JS.
  7315. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  7316. (WebCore::ChromeClientBlackBerry::closeWindowSoon):
  7317. 2012-10-01 Brady Eidson <beidson@apple.com>
  7318. Remove the Safari 2 -> Safari 3 icon database import code.
  7319. https://bugs.webkit.org/show_bug.cgi?id=98113
  7320. Reviewed by Maciej Stachowiak.
  7321. Nuke the performImport() IconDatabaseClient method.
  7322. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  7323. * WebCoreSupport/IconDatabaseClientBlackBerry.h:
  7324. (IconDatabaseClientBlackBerry):
  7325. 2012-10-01 Jakob Petsovits <jpetsovits@rim.com>
  7326. [BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
  7327. https://bugs.webkit.org/show_bug.cgi?id=98107
  7328. RIM PR 173292
  7329. Reviewed by George Staikos.
  7330. This method is not referenced anywhere anymore,
  7331. so we should stop requiring it from WebPageClient
  7332. implementations.
  7333. * Api/WebPageClient.h:
  7334. 2012-10-01 Mike Fenton <mifenton@rim.com>
  7335. [BlackBerry] Remove suppressing of VKB hiding when processing changes.
  7336. https://bugs.webkit.org/show_bug.cgi?id=98023
  7337. Reviewed by Rob Buis.
  7338. PR 215881.
  7339. Allow JS to blur the input field while processing key handling.
  7340. Reviewed Internally by Chris Hutten-Czapski
  7341. * WebKitSupport/InputHandler.cpp:
  7342. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  7343. 2012-09-28 Konrad Piascik <kpiascik@rim.com>
  7344. [BlackBerry] Update the value of window.devicePixelRation when it is set programmatically
  7345. https://bugs.webkit.org/show_bug.cgi?id=97512
  7346. Reviewed by Rob Buis.
  7347. RIM PR 213984
  7348. Set the deviceScaleFactor of the page explicity when the
  7349. devicePixelRatio is changed.
  7350. * Api/WebPage.cpp:
  7351. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  7352. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  7353. 2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  7354. Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
  7355. https://bugs.webkit.org/show_bug.cgi?id=97547
  7356. Reviewed by Adam Barth.
  7357. Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
  7358. inside WebCore::FrameLoaderClientBlackBerry::canShowMIMEType().
  7359. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7360. (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
  7361. 2012-09-28 Rob Buis <rbuis@rim.com>
  7362. [BlackBerry] Hard to tap on x to clear a text field
  7363. https://bugs.webkit.org/show_bug.cgi?id=97923
  7364. Reviewed by Antonio Gomes.
  7365. Allow the shadow element for 'X' to be clickable and do not prefer
  7366. shadow content-editable div's over the 'X'.
  7367. * WebKitSupport/FatFingers.cpp:
  7368. (BlackBerry::WebKit::FatFingers::isElementClickable):
  7369. 2012-09-28 Antonio Gomes <agomes@rim.com>
  7370. [BlackBerry] Extend composited in-region scrolling to iframes/frames
  7371. https://bugs.webkit.org/show_bug.cgi?id=97922
  7372. PR #197093
  7373. Reviewed by Yong Li.
  7374. Internaly reviewed by Arvid Nilsson.
  7375. Add support for composited scrolling in a inner frame level:
  7376. 1) When creating an InRegionScrollableArea, for a inner scrollable frame,
  7377. cache and camouflag the appropriated scroll layer (i.e. RenderLayerCompositor::scrollLayer);
  7378. 2) Differentiate what type of scroll target we are at: BlockElement or
  7379. InnerFrame;
  7380. 3) Change the signature of the public methods to support and newly passed
  7381. in ScrollTarget parameter;
  7382. As a side note, this parameter is needed in order to know what class to static_cast
  7383. the GraphicsLayer::client to: in the case of a composited scrollable inner frame, the client
  7384. is a RenderLayerCompositor; in case of a composited scrollable block element, the client
  7385. is a RenderLayerBacking.
  7386. * Api/InRegionScroller.cpp:
  7387. (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
  7388. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
  7389. * Api/InRegionScroller.h:
  7390. * Api/InRegionScroller_p.h:
  7391. (InRegionScrollerPrivate):
  7392. * WebCoreSupport/ChromeClientBlackBerry.h:
  7393. (WebCore::ChromeClientBlackBerry::allowedCompositingTriggers):
  7394. * WebKitSupport/InRegionScrollableArea.cpp:
  7395. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  7396. 2012-09-28 Antonio Gomes <agomes@rim.com>
  7397. [BlackBerry] Exiting fullscreen does not set the correct scroll position
  7398. https://bugs.webkit.org/show_bug.cgi?id=97917
  7399. PR #212920
  7400. Reviewed by Yong Li.
  7401. Internally reviewed by Jacky Jiang.
  7402. Restore the zoom level and scroll position at the time when know
  7403. the fullscreen exit routine has ended (i.e. in ::setViewportSize
  7404. instead of ::exitFullScreenForElement).
  7405. Also patch caches now the scroll position instead of only the
  7406. "x scroll position.
  7407. * Api/WebPage.cpp:
  7408. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7409. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  7410. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  7411. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  7412. * Api/WebPage_p.h:
  7413. (WebPagePrivate):
  7414. 2012-09-28 Kent Tamura <tkent@chromium.org>
  7415. Clean up Localizer-related functions
  7416. https://bugs.webkit.org/show_bug.cgi?id=97899
  7417. Reviewed by Kentaro Hara.
  7418. * WebCoreSupport/ColorPickerClient.cpp:
  7419. (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
  7420. * WebCoreSupport/DatePickerClient.cpp:
  7421. (WebCore::SelectPopupClient::localizer): ditto.
  7422. * WebCoreSupport/SelectPopupClient.cpp:
  7423. (WebCore::SelectPopupClient::localizer): ditto.
  7424. 2012-09-28 Genevieve Mak <gmak@rim.com>
  7425. [BLACKBERRY] Add isVisible method to WebTapHighlight
  7426. https://bugs.webkit.org/show_bug.cgi?id=97915
  7427. Reviewed by Rob Buis.
  7428. Reviewed Internally By Andrew Lo
  7429. The isVisible() method lets us avoid dispatching to the webkit thread
  7430. if the tap highlight isn't visible.
  7431. Always clear tap highlight on Touch up when converting Touch Events
  7432. to Mouse Events.
  7433. * Api/WebTapHighlight.h:
  7434. * WebKitSupport/DefaultTapHighlight.h:
  7435. (BlackBerry::WebKit::DefaultTapHighlight::isVisible):
  7436. * WebKitSupport/TouchEventHandler.cpp:
  7437. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  7438. 2012-09-28 Andrew Lo <anlo@rim.com>
  7439. [BlackBerry] Should suspend page's scripted animations when WebPage is invisible
  7440. https://bugs.webkit.org/show_bug.cgi?id=97856
  7441. Reviewed by Antonio Gomes.
  7442. Suspend page animations when setting WebPage invisible, resume when visible.
  7443. Internal PR212788.
  7444. * Api/WebPage.cpp:
  7445. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  7446. 2012-09-28 Arvid Nilsson <anilsson@rim.com>
  7447. [BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
  7448. https://bugs.webkit.org/show_bug.cgi?id=97674
  7449. Reviewed by Rob Buis.
  7450. A new API was added to BlackBerry::Platform::Graphics for destroying
  7451. thread-specific data generated on the compositing thread when we blit
  7452. buffers. The buffers are otherwise created and destroyed on the WebKit
  7453. thread, which doesn't give platform any opportunity to destroy the
  7454. thread-specific data.
  7455. This patch adds calls to the new API to avoid leaking resources.
  7456. Reviewed internally by Jakob Petsovits and Filip Spacek.
  7457. PR 214644
  7458. * WebKitSupport/SurfacePool.cpp:
  7459. (BlackBerry::WebKit::SurfacePool::initialize):
  7460. (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
  7461. (BlackBerry::WebKit::SurfacePool::lockTileRenderingSurface):
  7462. (BlackBerry::WebKit::SurfacePool::releaseTileRenderingSurface):
  7463. (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
  7464. (BlackBerry::WebKit::SurfacePool::createBuffers):
  7465. (BlackBerry::WebKit::SurfacePool::releaseBuffers):
  7466. 2012-09-27 Kent Tamura <tkent@chromium.org>
  7467. Use Localizer in PagePopupController
  7468. https://bugs.webkit.org/show_bug.cgi?id=97862
  7469. Reviewed by Hajime Morita.
  7470. We need to implement PagePopupClient::localizer. These clients know the
  7471. host elements. Localizer implementations get Localizer objects from the
  7472. owner documents of the elements for the browser locale.
  7473. * WebCoreSupport/ColorPickerClient.cpp:
  7474. (WebCore::ColorPickerClient::localizer): Added.
  7475. * WebCoreSupport/ColorPickerClient.h:
  7476. (ColorPickerClient): Declare "localizer."
  7477. * WebCoreSupport/DatePickerClient.cpp:
  7478. (WebCore::SelectPopupClient::localizer): Added.
  7479. * WebCoreSupport/DatePickerClient.h:
  7480. (DatePickerClient): Declare "localizer."
  7481. * WebCoreSupport/SelectPopupClient.cpp:
  7482. (WebCore::SelectPopupClient::localizer): Added.
  7483. * WebCoreSupport/SelectPopupClient.h:
  7484. (SelectPopupClient): Declare "localizer."
  7485. 2012-09-27 Charles Wei <charles.wei@torchmobile.com.cn>
  7486. Empty URL gets through to acceptNavigationRequest()
  7487. https://bugs.webkit.org/show_bug.cgi?id=97076
  7488. Reviewed by George Staikos.
  7489. Invalid URLs in iframe src results in an empty URL in platform request, we should reject
  7490. such URL as early as we identify it.
  7491. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7492. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  7493. 2012-09-26 Jakob Petsovits <jpetsovits@rim.com>
  7494. [BlackBerry] Remove blitContents() in favor of blitVisibleContents().
  7495. https://bugs.webkit.org/show_bug.cgi?id=97718
  7496. Reviewed by Antonio Gomes.
  7497. After the last calling sites of blitContents() have
  7498. been removed or reworked, the actual method itself
  7499. can now retire. All blits now go through
  7500. blitVisibleContents(). The knowledge that we always
  7501. blit the full visible surface can facilitate further
  7502. optimizations; we will get to that in time.
  7503. * Api/BackingStore.cpp:
  7504. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
  7505. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  7506. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  7507. * Api/BackingStore.h:
  7508. * Api/BackingStore_p.h:
  7509. (BackingStorePrivate):
  7510. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7511. (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
  7512. 2012-09-26 Mike Fenton <mifenton@rim.com>
  7513. [BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
  7514. https://bugs.webkit.org/show_bug.cgi?id=97684
  7515. Reviewed by Rob Buis.
  7516. Update padding in ensureFocusTextElementVisible to be DPI
  7517. independent and relative to the current zoom level.
  7518. Reviewed Internally by Gen Mak.
  7519. * WebKitSupport/InputHandler.cpp:
  7520. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  7521. 2012-09-25 Genevieve Mak <gmak@rim.com>
  7522. Fat Fingers doesn't work on non-scrollable pages.
  7523. PR #209609
  7524. https://bugs.webkit.org/show_bug.cgi?id=97607
  7525. Reviewed by Antonio Gomes.
  7526. Only bypass Fat Fingers and use the actual touch point if its specifically
  7527. requested and the page has a mouse move listener or if using the Touch Event
  7528. Mode meta-tag.
  7529. * WebKitSupport/TouchEventHandler.cpp:
  7530. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  7531. 2012-09-25 Rob Buis <rbuis@rim.com>
  7532. [BlackBerry] Make COMPUTED_GOTO part of the HAVE section
  7533. https://bugs.webkit.org/show_bug.cgi?id=97600
  7534. Reviewed by Yong Li.
  7535. Also get rid of COMPUTED_GOTO_INTERPRETER and add COMPUTED_GOTO_OPCODES.
  7536. * WebCoreSupport/AboutDataEnableFeatures.in:
  7537. * WebCoreSupport/AboutDataHaveFeatures.in:
  7538. 2012-09-25 Mike Fenton <mifenton@rim.com>
  7539. [BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
  7540. https://bugs.webkit.org/show_bug.cgi?id=97595
  7541. Reviewed by Antonio Gomes.
  7542. PR 188751.
  7543. Avoid jumpiness when both a scroll and zoom are required to
  7544. move an input field into focus by suspending the backingstore.
  7545. * WebKitSupport/InputHandler.cpp:
  7546. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  7547. 2012-09-25 Pratik Solanki <psolanki@apple.com>
  7548. Remove HAVE_SBRK since we never set use_sbrk to true
  7549. https://bugs.webkit.org/show_bug.cgi?id=97525
  7550. <rdar://problem/12363601>
  7551. Reviewed by Geoffrey Garen.
  7552. * WebCoreSupport/AboutDataHaveFeatures.in: Remove SBRK from list.
  7553. 2012-09-25 Beth Dakin <bdakin@apple.com>
  7554. https://bugs.webkit.org/show_bug.cgi?id=95397
  7555. Need to merge didFirstVisuallyNonEmptyLayout and
  7556. didNewFirstVisuallyNonEmptyLayout
  7557. -and corresponding-
  7558. <rdar://problem/10791680>
  7559. Reviewed by Sam Weinig.
  7560. Remove dispatchDidFirstLayout,
  7561. dispatchDidFirstVisuallyNonEmptyLayout, and
  7562. dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
  7563. is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
  7564. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7565. (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
  7566. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  7567. (FrameLoaderClientBlackBerry):
  7568. It is now necessary to opt into getting any of the
  7569. "layout milestone" notifications.
  7570. * Api/WebPage.cpp:
  7571. (BlackBerry::WebKit::WebPagePrivate::init):
  7572. 2012-09-25 Mike Fenton <mifenton@rim.com>
  7573. [BlackBerry] When zooming into an input field take the current zoom level into account.
  7574. https://bugs.webkit.org/show_bug.cgi?id=97594
  7575. Reviewed by Antonio Gomes.
  7576. PR 188751.
  7577. Perform the zoom action prior to scroll to avoid breaking scrolling
  7578. rules. Take the current scale into account when calculating the
  7579. zoom factor.
  7580. * WebKitSupport/InputHandler.cpp:
  7581. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  7582. 2012-09-25 Nima Ghanavatian <nghanavatian@rim.com>
  7583. [BlackBerry] Handling required for multiple consecutive whitespace
  7584. https://bugs.webkit.org/show_bug.cgi?id=97575
  7585. Reviewed by Rob Buis.
  7586. PR211670
  7587. Need specific handling in the case where we have multiple
  7588. consecutive whitespaces which exceeds our character limit. This
  7589. breaks some of the functionality employed with the visible_units
  7590. methods used here to tranverse the text.
  7591. Internally reviewed by Mike Fenton.
  7592. * WebKitSupport/DOMSupport.cpp:
  7593. (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
  7594. (DOMSupport):
  7595. (BlackBerry::WebKit::DOMSupport::isEmptyRangeOrAllSpaces):
  7596. * WebKitSupport/DOMSupport.h:
  7597. (WebCore):
  7598. * WebKitSupport/InputHandler.cpp:
  7599. (BlackBerry::WebKit::InputHandler::spellCheckBlock):
  7600. (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
  7601. 2012-09-24 Mark Lam <mark.lam@apple.com>
  7602. Deleting the classic interpreter and cleaning up some build options.
  7603. https://bugs.webkit.org/show_bug.cgi?id=96969.
  7604. Reviewed by Geoffrey Garen.
  7605. * WebCoreSupport/AboutDataEnableFeatures.in:
  7606. 2012-09-24 Benjamin Poulain <bpoulain@apple.com>
  7607. Fix Geolocation error reporting in the test support
  7608. https://bugs.webkit.org/show_bug.cgi?id=97386
  7609. Reviewed by Sam Weinig.
  7610. * WebKitSupport/DumpRenderTreeSupport.cpp:
  7611. (DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
  7612. * WebKitSupport/DumpRenderTreeSupport.h:
  7613. (DumpRenderTreeSupport):
  7614. 2012-09-24 Otto Derek Cheung <otcheung@rim.com>
  7615. [BlackBerry] Reverting implementation for 407 error pages
  7616. https://bugs.webkit.org/show_bug.cgi?id=97455
  7617. Reviewed by Rob Buis.
  7618. Revert "[BlackBerry] Really fix bug 95488 that user can get the
  7619. authentication challenge dialog while the other tab has focus."
  7620. https://bugs.webkit.org/show_bug.cgi?id=97348
  7621. This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.
  7622. * Api/BlackBerryGlobal.cpp:
  7623. (BlackBerry::WebKit::globalInitialize):
  7624. * Api/WebPage.cpp:
  7625. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7626. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  7627. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  7628. (BlackBerry::WebKit::WebPage::setVisible):
  7629. * Api/WebPage_p.h:
  7630. (WebPagePrivate):
  7631. 2012-09-24 Arvid Nilsson <anilsson@rim.com>
  7632. [BlackBerry] Add cookie database API
  7633. https://bugs.webkit.org/show_bug.cgi?id=97102
  7634. Reviewed by Antonio Gomes.
  7635. The cookie database is exposed through WebCookieJar, which has only two
  7636. methods: cookies() and setCookies().
  7637. Also add a new WebString::fromUTF8 overload that takes a const char*
  7638. and a length, in order to avoid a strlen call when converting from
  7639. other string classes to WebString. This is useful for callers of the
  7640. new cookie API when converting cookies to WebString.
  7641. Reviewed internally by Otto D. Cheung.
  7642. PR 209282
  7643. * Api/WebCookieJar.cpp: Added.
  7644. (WebKit):
  7645. (BlackBerry::WebKit::WebCookieJar::WebCookieJar):
  7646. (BlackBerry::WebKit::WebCookieJar::cookies):
  7647. (BlackBerry::WebKit::WebCookieJar::setCookies):
  7648. * Api/WebCookieJar.h: Added.
  7649. (WebKit):
  7650. * Api/WebPage.cpp:
  7651. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7652. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  7653. (BlackBerry::WebKit::WebPage::cookieJar):
  7654. (WebKit):
  7655. * Api/WebPage.h:
  7656. (WebKit):
  7657. * Api/WebPage_p.h:
  7658. (WebKit):
  7659. (WebPagePrivate):
  7660. * Api/WebString.cpp:
  7661. (BlackBerry::WebKit::WebString::fromUtf8):
  7662. (WebKit):
  7663. * Api/WebString.h:
  7664. 2012-09-21 Lianghui Chen <liachen@rim.com>
  7665. [BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
  7666. https://bugs.webkit.org/show_bug.cgi?id=97348
  7667. Internal PR: 186597.
  7668. Internally reviewed by Yong Li, Joe Mason.
  7669. Reviewed by Yong Li.
  7670. Update WebPage to use new AuthenticationChallengeManager.
  7671. Register page creation/deletion and visibility change to the new
  7672. AuthenticationChallengeManager.
  7673. Initialize AuthenticationChallengeManager in GlobalInitialize() function.
  7674. * Api/BlackBerryGlobal.cpp:
  7675. (BlackBerry::WebKit::globalInitialize):
  7676. * Api/WebPage.cpp:
  7677. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7678. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  7679. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  7680. (BlackBerry::WebKit::WebPage::setVisible):
  7681. * Api/WebPage_p.h:
  7682. (WebPagePrivate):
  7683. 2012-09-21 Charles Wei <charles.wei@torchmobile.com.cn>
  7684. Wrong seperator for viewport meta in Popup scripts
  7685. https://bugs.webkit.org/show_bug.cgi?id=97313
  7686. Reviewed by Yong Li.
  7687. The valid seperator for viewport meta is ',' instead of ';'.
  7688. * WebCoreSupport/PagePopupBlackBerry.cpp:
  7689. (WebCore::PagePopupBlackBerry::generateHTML):
  7690. 2012-09-21 Arvid Nilsson <anilsson@rim.com>
  7691. [BlackBerry] Remove obsolete compositing surface code
  7692. https://bugs.webkit.org/show_bug.cgi?id=97314
  7693. Reviewed by Antonio Gomes.
  7694. The removed code allowed rendering of sublayers to a separate offscreen
  7695. surface.
  7696. Now that we composite root layer and all sublayers to the window
  7697. surface, this code is not needed anymore. In addition, we save some
  7698. memory by not allocating the unused offscreen surface.
  7699. PR 208038.
  7700. * Api/BackingStore.cpp:
  7701. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
  7702. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  7703. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  7704. * Api/BackingStore_p.h:
  7705. (BackingStorePrivate):
  7706. * Api/WebPage.cpp:
  7707. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  7708. (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
  7709. (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
  7710. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  7711. (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
  7712. * Api/WebPage_p.h:
  7713. (WebPagePrivate):
  7714. * WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
  7715. * WebKitSupport/BackingStoreCompositingSurface.h: Removed.
  7716. * WebKitSupport/GLES2Context.cpp:
  7717. (BlackBerry::WebKit::GLES2Context::buffer):
  7718. (BlackBerry::WebKit::GLES2Context::surfaceSize):
  7719. (BlackBerry::WebKit::GLES2Context::swapBuffers):
  7720. * WebKitSupport/GLES2Context.h:
  7721. (GLES2Context):
  7722. * WebKitSupport/SurfacePool.cpp:
  7723. (WebKit):
  7724. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  7725. (BlackBerry::WebKit::SurfacePool::initialize):
  7726. * WebKitSupport/SurfacePool.h:
  7727. (SurfacePool):
  7728. 2012-09-20 Peter Wang <peter.wang@torchmobile.com.cn>
  7729. [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
  7730. https://bugs.webkit.org/show_bug.cgi?id=96077
  7731. Reviewed by Pavel Feldman.
  7732. A minor modification to make the inspecting results more accurate.
  7733. Internally reviewd by Arvid, Robin.C, and Konrad.
  7734. * Api/BackingStore.cpp:
  7735. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  7736. * Api/WebPage.cpp:
  7737. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  7738. * WebKitSupport/RenderQueue.cpp:
  7739. (BlackBerry::WebKit::RenderQueue::render):
  7740. 2012-09-19 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  7741. [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
  7742. https://bugs.webkit.org/show_bug.cgi?id=96362
  7743. Reviewed by Rob Buis.
  7744. Make the FrameLoaderClient use credential storage according to the macro
  7745. BLACKBERRY_CREDENTIAL_PERSIST
  7746. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7747. (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
  7748. (WebCore):
  7749. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  7750. (FrameLoaderClientBlackBerry):
  7751. 2012-09-19 Mike Fenton <mifenton@rim.com>
  7752. [BlackBerry] After zooming into an input field, zoom out when focus is lost.
  7753. https://bugs.webkit.org/show_bug.cgi?id=97128
  7754. Reviewed by Rob Buis.
  7755. When the page has automatically zoomed in for input
  7756. focus, unzoom it when input focus is lost or keyboard hidden.
  7757. Reviewed Internally by Gen Mak.
  7758. * WebKitSupport/InputHandler.cpp:
  7759. (BlackBerry::WebKit::InputHandler::InputHandler):
  7760. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  7761. * WebKitSupport/InputHandler.h:
  7762. (InputHandler):
  7763. 2012-09-19 Nima Ghanavatian <nghanavatian@rim.com>
  7764. [BlackBerry] Clean up the SpellingLog output
  7765. https://bugs.webkit.org/show_bug.cgi?id=97129
  7766. Reviewed by Rob Buis.
  7767. Internally reviewed by Mike Fenton.
  7768. * WebKitSupport/InputHandler.cpp:
  7769. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  7770. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  7771. 2012-09-19 Mike Fenton <mifenton@rim.com>
  7772. [BlackBerry] Add SpellingLog for spell checking options request.
  7773. https://bugs.webkit.org/show_bug.cgi?id=97125
  7774. Reviewed by Rob Buis.
  7775. Add spell checking log to indicate the calculated
  7776. text position for spell checking option requests.
  7777. Reviewed Internally by Nima Ghanavatian.
  7778. * WebKitSupport/InputHandler.cpp:
  7779. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  7780. 2012-09-19 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  7781. [BlackBerry] Add function playerId() in class PageClientBlackBerry
  7782. https://bugs.webkit.org/show_bug.cgi?id=97099
  7783. Reviewed by Yong Li.
  7784. Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
  7785. and replaced the implementation of FrameLoaderClientBlackBerry::playerId().
  7786. Internally reviewed by Charles Wei.
  7787. * Api/WebPage.cpp:
  7788. (BlackBerry::WebKit::WebPagePrivate::playerID):
  7789. (WebKit):
  7790. * Api/WebPage_p.h:
  7791. (WebPagePrivate):
  7792. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  7793. (WebCore::FrameLoaderClientBlackBerry::playerId):
  7794. 2012-09-19 Abbas Sherawala <asherawala@rim.com>
  7795. [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
  7796. Added a missing 'if' statement.
  7797. https://bugs.webkit.org/show_bug.cgi?id=96925
  7798. PR #180866
  7799. Internally Reviewed by Antonio Gomes.
  7800. Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)
  7801. Reviewed by Antonio Gomes.
  7802. * Api/BackingStore.cpp:
  7803. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  7804. 2012-09-18 Nima Ghanavatian <nghanavatian@rim.com>
  7805. [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
  7806. https://bugs.webkit.org/show_bug.cgi?id=97033
  7807. Reviewed by Rob Buis.
  7808. Using these preferred public methods (the latter has a note to be made private) ensures that
  7809. the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
  7810. and spellCheckingRequestCancelled.
  7811. Internally reviewed by Mike Fenton.
  7812. By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
  7813. SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.
  7814. * WebKitSupport/InputHandler.cpp:
  7815. (BlackBerry::WebKit::InputHandler::InputHandler):
  7816. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  7817. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  7818. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  7819. (BlackBerry::WebKit::InputHandler::getSpellChecker):
  7820. * WebKitSupport/InputHandler.h:
  7821. (InputHandler):
  7822. 2012-09-18 Jessica Cao <jecao@rim.com>
  7823. [BlackBerry] Date picker isn't inputting after 'OK'
  7824. https://bugs.webkit.org/show_bug.cgi?id=97031
  7825. PR208052
  7826. Reviewed by Rob Buis
  7827. Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
  7828. * WebCoreSupport/DatePickerClient.cpp:
  7829. (WebCore::DatePickerClient::setValueAndClosePopup):
  7830. 2012-09-18 Yong Li <yoli@rim.com>
  7831. [BlackBerry] Popup page should reference the client with a weak pointer
  7832. https://bugs.webkit.org/show_bug.cgi?id=97028
  7833. Reviewed by Rob Buis.
  7834. RIM PR# 209847.
  7835. Internally reviewed by Mike Fenton.
  7836. Store the pointer in a ref-coutned shared object, and clear the pointer
  7837. when the client is going to be destroyed, so it won't be accessed by
  7838. the JS function afterwards.
  7839. * WebCoreSupport/PagePopupBlackBerry.cpp:
  7840. (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
  7841. (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
  7842. (WebCore::PagePopupBlackBerry::init):
  7843. (WebCore::setValueAndClosePopupCallback):
  7844. (WebCore::popUpExtensionFinalize):
  7845. (WebCore::PagePopupBlackBerry::installDOMFunction):
  7846. (WebCore::PagePopupBlackBerry::closePopup):
  7847. * WebCoreSupport/PagePopupBlackBerry.h:
  7848. (PagePopupBlackBerry):
  7849. (SharedClientPointer):
  7850. (WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
  7851. (WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
  7852. (WebCore::PagePopupBlackBerry::SharedClientPointer::get):
  7853. 2012-09-18 Arvid Nilsson <anilsson@rim.com>
  7854. [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
  7855. https://bugs.webkit.org/show_bug.cgi?id=96750
  7856. Reviewed by Antonio Gomes.
  7857. The region of interest mechanism replaces the scrolling/zooming
  7858. functionality in InputHandler::ensureFocusTextElementVisible().
  7859. We introduce a new fine-grained setting for the various adjustment
  7860. modes. The WebKit embedder can disable all scroll types in favor of the
  7861. region of interest mechanism by using the new setting.
  7862. PR #208387
  7863. Reviewed internally by Mike Fenton.
  7864. * WebKitSupport/AboutData.cpp:
  7865. (BlackBerry::WebKit::configPage):
  7866. * WebKitSupport/InputHandler.cpp:
  7867. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  7868. * WebKitSupport/InputHandler.h:
  7869. 2012-09-17 Jakob Petsovits <jpetsovits@rim.com>
  7870. [BlackBerry] Remove dysfunctional zoom blit in setViewportSize().
  7871. https://bugs.webkit.org/show_bug.cgi?id=96954
  7872. PR 178411
  7873. Reviewed by Antonio Gomes.
  7874. The blitContents() call removed by this patch used to
  7875. be part of scheduleZoomAboutPoint(). Its goal was to
  7876. display a preview of the zoomed contents, primarily
  7877. when auto-zoomed after rotation. Nested inside a pair
  7878. of screen suspend/resume calls, it has been a pointless
  7879. no-op for a while.
  7880. Antonio's recent change to remove scheduleZoomAboutPoint()
  7881. and call zoomAboutPoint() from setViewportSize() directly
  7882. (the only call site) obsoletes the call completely.
  7883. The zoomAboutPoint() call itself will cause a re-render
  7884. and blit right away, so we don't care about any preview.
  7885. zoomAboutPoint() will also take care of the necessary
  7886. screen/backingstore suspension.
  7887. The result is a vastly simplified block of code.
  7888. * Api/WebPage.cpp:
  7889. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  7890. 2012-09-17 Antonio Gomes <agomes@rim.com>
  7891. [BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
  7892. https://bugs.webkit.org/show_bug.cgi?id=96927
  7893. PR #180866
  7894. Reviewed by Yong Li.
  7895. Suspend backing store and screen updates while entering fullscreen,
  7896. and only resume at the end, when viewport is resized.
  7897. * Api/WebPage.cpp:
  7898. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  7899. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  7900. * Api/WebPage_p.h:
  7901. (WebPagePrivate):
  7902. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  7903. (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
  7904. (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
  7905. 2012-09-17 Rob Buis <rbuis@rim.com>
  7906. [BlackBerry] Fix compile problems in WebKit/blackberry
  7907. https://bugs.webkit.org/show_bug.cgi?id=96926
  7908. Reviewed by Antonio Gomes.
  7909. This code is slightly out of date and so will not compile, fix it.
  7910. * WebCoreSupport/BatteryClientBlackBerry.cpp:
  7911. (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
  7912. * WebCoreSupport/BatteryClientBlackBerry.h:
  7913. (WebKit):
  7914. * WebCoreSupport/CredentialTransformData.h:
  7915. * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
  7916. (DeviceOrientationClientBlackBerry::onOrientation):
  7917. * WebCoreSupport/InspectorClientBlackBerry.h:
  7918. * WebCoreSupport/PagePopupBlackBerry.cpp:
  7919. * WebKitSupport/DOMSupport.cpp:
  7920. (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
  7921. (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
  7922. * WebKitSupport/DumpRenderTreeSupport.cpp:
  7923. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  7924. * WebKitSupport/InPageSearchManager.cpp:
  7925. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  7926. 2012-09-17 Antonio Gomes <agomes@rim.com>
  7927. [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
  7928. https://bugs.webkit.org/show_bug.cgi?id=96925
  7929. [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
  7930. PR #180866
  7931. Reviewed by Rob Buis.
  7932. Internally reviewed by Arvid Nilsson.
  7933. Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
  7934. Well more atomic than it was before, with regards to a mix of accelerated and
  7935. non-accelerated compositing content".
  7936. I.e. by committing the root layer (if needed) when resuming the Backing
  7937. Store, we call blitVisibleContents right way, so we are actually shortcutting when
  7938. AC content will get on screen.
  7939. * Api/BackingStore.cpp:
  7940. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  7941. 2012-09-17 Peter Wang <peter.wang@torchmobile.com.cn>
  7942. [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
  7943. https://bugs.webkit.org/show_bug.cgi?id=96077
  7944. Reviewed by Rob Buis.
  7945. Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
  7946. render message to record one time of page's update.
  7947. * Api/BackingStore.cpp:
  7948. (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
  7949. (WebKit):
  7950. (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
  7951. * Api/BackingStore_p.h:
  7952. * WebKitSupport/RenderQueue.cpp:
  7953. (BlackBerry::WebKit::RenderQueue::render):
  7954. 2012-09-17 Jakob Petsovits <jpetsovits@rim.com>
  7955. [BlackBerry] Support copying image data in WebOverlay.
  7956. https://bugs.webkit.org/show_bug.cgi?id=96684
  7957. RIM PR 195444
  7958. Reviewed by Rob Buis.
  7959. Internally reviewed by Arvid Nilsson.
  7960. The publicly exposed WebOverlay class provides a method
  7961. setContentsToImage() to assign a pointer to pixel data,
  7962. which is later used to provide texture data for the
  7963. underlying compositing layer. This works well for static
  7964. images that stay in memory and never change, but not
  7965. so well for images with changing contents or where the
  7966. image data is being reassigned from different image
  7967. sources that are not constantly kept around in memory.
  7968. Due to the delayed upload and delayed fetching of
  7969. EGLImage data by the GPU, we shouldn't assume the caller
  7970. to know how long the image should be retained. Instead,
  7971. we should offer another method of setting image data
  7972. that takes ownership of the pixel data.
  7973. This patch adds an option to setContentsToImage() that
  7974. copies the passed pixel data and doesn't destroy it
  7975. until both the texture is destroyed and the image
  7976. contents are changed. Using this method, the caller can
  7977. withdraw the passed pixel array right after the
  7978. setContentsToImage() call without consequences.
  7979. * Api/WebOverlay.cpp:
  7980. (BlackBerry::WebKit::WebOverlay::setContentsToImage):
  7981. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
  7982. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
  7983. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
  7984. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
  7985. (WebKit):
  7986. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
  7987. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
  7988. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  7989. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
  7990. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
  7991. * Api/WebOverlay.h:
  7992. * Api/WebOverlay_p.h:
  7993. (WebOverlayPrivate):
  7994. (WebOverlayPrivateWebKitThread):
  7995. (WebOverlayLayerCompositingThreadClient):
  7996. (WebOverlayPrivateCompositingThread):
  7997. 2012-09-14 Dana Jansens <danakj@chromium.org>
  7998. Minimize collisions when hashing pairs
  7999. https://bugs.webkit.org/show_bug.cgi?id=96022
  8000. Reviewed by Adrienne Walker.
  8001. Use WTF::pairIntHash() to hash a pair of integers.
  8002. * WebKitSupport/TileIndexHash.h:
  8003. 2012-09-14 Genevieve Mak <gmak@rim.com>
  8004. Always send mouse events on pages that don't scroll even if there
  8005. is no mouse move listener attatched.
  8006. PR #208228
  8007. https://bugs.webkit.org/show_bug.cgi?id=96800
  8008. Reviewed by Antonio Gomes.
  8009. Reviewed Internally By Antonio Gomes.
  8010. * WebKitSupport/TouchEventHandler.cpp:
  8011. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  8012. 2012-09-14 Mike Fenton <mifenton@rim.com>
  8013. [BlackBerry] Update the minimum zoom scale when focusing an input field.
  8014. https://bugs.webkit.org/show_bug.cgi?id=96789
  8015. Reviewed by Antonio Gomes.
  8016. PR 188751.
  8017. Increase the minimum font fix and base it on mm instead of pixels.
  8018. Reviewed Internally by Gen Mak.
  8019. * WebKitSupport/InputHandler.cpp:
  8020. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  8021. 2012-09-13 Antonio Gomes <agomes@rim.com>
  8022. [BlackBerry] Remove the ability to schedule a zoom about point call.
  8023. https://bugs.webkit.org/show_bug.cgi?id=96696
  8024. [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
  8025. PR #180866
  8026. Reviewed by Rob Buis.
  8027. Internally reviewed by Jacky Jiang and Arvid Nilsson.
  8028. Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
  8029. Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
  8030. and in the end call zoomAboutPoint directly.
  8031. Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
  8032. zoom about point be async.. That was a hack I did for BB6, back when we were doing everything on the WK
  8033. thread and needed manual time slicing betwren rendering and user interaction."
  8034. The bigger goal though is to be able to remove screen glitches while entering/leaving
  8035. fullscreen mode: since we could accurately use the count-based suspend/resume backing
  8036. store mechanism to prevent it.
  8037. * Api/WebPage.cpp:
  8038. (WebKit):
  8039. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  8040. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  8041. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  8042. * Api/WebPage_p.h:
  8043. (WebPagePrivate):
  8044. 2012-09-14 Arvid Nilsson <anilsson@rim.com>
  8045. [BlackBerry] Add renderTreeAsText API to WebPage
  8046. https://bugs.webkit.org/show_bug.cgi?id=96629
  8047. Reviewed by Antonio Gomes.
  8048. This will be used for automated testing.
  8049. PR #198595
  8050. * Api/WebPage.cpp:
  8051. (BlackBerry::WebKit::WebPage::renderTreeAsText):
  8052. (WebKit):
  8053. * Api/WebPage.h:
  8054. 2012-09-13 Rob Buis <rbuis@rim.com>
  8055. [BlackBerry] Cleanup AboutDataEnableFeatures.in
  8056. https://bugs.webkit.org/show_bug.cgi?id=96695
  8057. Reviewed by Antonio Gomes.
  8058. Remove unused features.
  8059. * WebCoreSupport/AboutDataEnableFeatures.in:
  8060. 2012-09-13 Rob Buis <rbuis@rim.com>
  8061. [BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
  8062. https://bugs.webkit.org/show_bug.cgi?id=96689
  8063. Reviewed by Antonio Gomes.
  8064. Rename to InspectorClientBlackBerry to avoid include problems.
  8065. * WebCoreSupport/InspectorClientBlackBerry.h:
  8066. * WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
  8067. (WebKit):
  8068. (BlackBerry::WebKit::InspectorOverlay::create):
  8069. (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
  8070. (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
  8071. (BlackBerry::WebKit::InspectorOverlay::paintContents):
  8072. (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
  8073. (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
  8074. (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
  8075. (BlackBerry::WebKit::InspectorOverlay::clear):
  8076. (BlackBerry::WebKit::InspectorOverlay::update):
  8077. * WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
  8078. (WebCore):
  8079. (WebKit):
  8080. (InspectorOverlay):
  8081. (InspectorOverlayClient):
  8082. (BlackBerry::WebKit::InspectorOverlay::setClient):
  8083. (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
  8084. 2012-09-13 Antonio Gomes <agomes@rim.com>
  8085. Unreviewed, warning fix left over from r128456 (bug 96645)
  8086. * Api/InRegionScroller.cpp:
  8087. (WebKit):
  8088. 2012-09-13 Genevieve Mak <gmak@rim.com>
  8089. Continue to send mouse move events to a non-scrollable page
  8090. even if they are not consumed.
  8091. PR #207024
  8092. https://bugs.webkit.org/show_bug.cgi?id=96655
  8093. Reviewed by Antonio Gomes.
  8094. * WebKitSupport/TouchEventHandler.cpp:
  8095. (BlackBerry::WebKit::isMainFrameScrollable):
  8096. (WebKit):
  8097. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  8098. 2012-09-13 Jacky Jiang <zhajiang@rim.com>
  8099. [BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
  8100. https://bugs.webkit.org/show_bug.cgi?id=96660
  8101. Reviewed by Antonio Gomes.
  8102. PR: 207884
  8103. According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
  8104. bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
  8105. RenderBox's scroll height equals the client height and the scroll width
  8106. equals the client width. Otherwise, we will miss the conditions.
  8107. * Api/InRegionScroller.cpp:
  8108. (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
  8109. 2012-09-13 Jessica Cao <jecao@rim.com>
  8110. [BlackBerry] Page Popup for Month is non-functional.
  8111. https://bugs.webkit.org/show_bug.cgi?id=96651
  8112. Reviewed by Rob Buis.
  8113. Hook up support for Month popup.
  8114. * WebCoreSupport/DatePickerClient.cpp:
  8115. (WebCore::DatePickerClient::generateHTML):
  8116. * WebKitSupport/InputHandler.cpp:
  8117. (BlackBerry::WebKit::InputHandler::openDatePopup):
  8118. 2012-09-13 Antonio Gomes <agomes@rim.com>
  8119. [BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
  8120. https://bugs.webkit.org/show_bug.cgi?id=96645
  8121. PR #207307
  8122. Reviewed by George Staikos.
  8123. We use canScrollRenderBox to promote the layer as scrollable instead
  8124. of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
  8125. We should assert against the former as well.
  8126. * Api/InRegionScroller.cpp:
  8127. (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
  8128. * Api/InRegionScroller_p.h:
  8129. (WebCore):
  8130. (InRegionScrollerPrivate):
  8131. * WebKitSupport/InRegionScrollableArea.cpp:
  8132. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  8133. 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
  8134. Unreviewed, rolling out r127876.
  8135. http://trac.webkit.org/changeset/127876
  8136. https://bugs.webkit.org/show_bug.cgi?id=96600
  8137. mouse click doesn't work for spin button if spin button in
  8138. iframe (Requested by yosin on #webkit).
  8139. * Api/WebPage.cpp:
  8140. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  8141. (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
  8142. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  8143. (BlackBerry::WebKit::WebPage::nodeAtPoint):
  8144. * WebKitSupport/FatFingers.cpp:
  8145. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  8146. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
  8147. * WebKitSupport/SelectionHandler.cpp:
  8148. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  8149. 2012-09-12 Sami Kyostila <skyostil@google.com>
  8150. Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
  8151. https://bugs.webkit.org/show_bug.cgi?id=96251
  8152. Reviewed by Simon Fraser.
  8153. Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
  8154. the feature it controls.
  8155. * WebCoreSupport/AboutDataEnableFeatures.in:
  8156. 2012-09-11 Antonio Gomes <agomes@rim.com>
  8157. [BlackBerry] add a way to overscroll non-overflown content
  8158. https://bugs.webkit.org/show_bug.cgi?id=96331
  8159. PR #195305
  8160. Reviewed by Yong Li.
  8161. Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
  8162. of checking a custom HTML5 attribute.
  8163. No behavioural change. Mostly a rework of r128142.
  8164. * Api/InRegionScroller.cpp:
  8165. (BlackBerry::WebKit::canScrollRenderBox):
  8166. 2012-09-11 Rob Buis <rbuis@rim.com>
  8167. [BlackBerry] make pickers/dialogs use appendLiteral
  8168. https://bugs.webkit.org/show_bug.cgi?id=96424
  8169. Reviewed by Antonio Gomes.
  8170. PR 204032
  8171. Other pickers were updated in r128204.
  8172. * WebCoreSupport/ColorPickerClient.cpp:
  8173. (WebCore::ColorPickerClient::generateHTML):
  8174. * WebCoreSupport/PagePopupBlackBerry.cpp:
  8175. (WebCore::PagePopupBlackBerry::generateHTML):
  8176. 2012-09-11 Konrad Piascik <kpiascik@rim.com>
  8177. [BlackBerry] Fix history navigation for error pages.
  8178. https://bugs.webkit.org/show_bug.cgi?id=96410
  8179. Reviewed by Rob Buis.
  8180. Fix how history navigation handles restoring view state when navigating between error pages.
  8181. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  8182. (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
  8183. (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
  8184. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  8185. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  8186. (FrameLoaderClientBlackBerry):
  8187. 2012-09-11 Jinwoo Song <jinwoo7.song@samsung.com>
  8188. Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places
  8189. https://bugs.webkit.org/show_bug.cgi?id=96344
  8190. Reviewed by Benjamin Poulain.
  8191. Use StringBuilder::appendNumber() instead of String::number(). Also deploy
  8192. StringBuilder::appendLiteral() instead of String::append() in the surrounding code.
  8193. * WebCoreSupport/DatePickerClient.cpp:
  8194. (WebCore::DatePickerClient::generateHTML):
  8195. * WebCoreSupport/SelectPopupClient.cpp:
  8196. (WebCore::SelectPopupClient::generateHTML):
  8197. 2012-09-11 Jacky Jiang <zhajiang@rim.com>
  8198. [BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread
  8199. https://bugs.webkit.org/show_bug.cgi?id=96318
  8200. Reviewed by Antonio Gomes.
  8201. PR: 204066
  8202. Dangling pointers were accessed in UI thread, as the actual InRegion
  8203. scrollable areas of WebKit side had been destroyed before that in
  8204. WebKit thread after UI thread set scrolling to false.
  8205. Notify the client side to clear InRegion scrollable areas before we
  8206. destroy them in WebKit side.
  8207. Internally reviewed by Gen Mak and George Staikos.
  8208. * Api/WebPage.cpp:
  8209. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
  8210. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
  8211. * Api/WebPageClient.h:
  8212. 2012-09-11 Mike Fenton <mifenton@rim.com>
  8213. [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
  8214. https://bugs.webkit.org/show_bug.cgi?id=96394
  8215. Reviewed by Rob Buis.
  8216. Suppress the VKB notification when the touch event
  8217. is a spell checking request.
  8218. PR 192925.
  8219. Reviewed Internally by Gen Mak.
  8220. * WebKitSupport/TouchEventHandler.cpp:
  8221. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  8222. 2012-09-11 Mike Fenton <mifenton@rim.com>
  8223. [BlackBerry] Colour Dialog popup request should return proper state.
  8224. https://bugs.webkit.org/show_bug.cgi?id=96392
  8225. Reviewed by Rob Buis.
  8226. Return proper state from openColorPopup dependent on
  8227. whether the popup actually opened.
  8228. Reviewed Internally by Chris Hutten-Czapski
  8229. * WebKitSupport/InputHandler.cpp:
  8230. (BlackBerry::WebKit::InputHandler::openColorPopup):
  8231. 2012-09-11 Nima Ghanavatian <nghanavatian@rim.com>
  8232. [BlackBerry] Take account for single words that exceed our client character limit
  8233. https://bugs.webkit.org/show_bug.cgi?id=96389
  8234. Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
  8235. This was failing if a single word was longer than our maximum allowed limit.
  8236. Internally reviewed by Mike Fenton.
  8237. Reviewed by Rob Buis.
  8238. * WebKitSupport/InputHandler.cpp:
  8239. (WebKit):
  8240. (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
  8241. 2012-09-11 Arvid Nilsson <anilsson@rim.com>
  8242. [BlackBerry] SelectionHandler drops caret change notifications
  8243. https://bugs.webkit.org/show_bug.cgi?id=96378
  8244. Reviewed by Antonio Gomes.
  8245. The selection handler deliberately drops caret change notifications
  8246. while the input handler is processing changes, to avoid displaying
  8247. intermediate state during a complex change.
  8248. However, this meant that the client was never informed of the final
  8249. caret position.
  8250. Fixed by notifying client about caret change after processing ends, if
  8251. one or more caret change notifications were dropped during processing.
  8252. PR #205073
  8253. Reviewed internally by Mike Fenton.
  8254. * WebKitSupport/InputHandler.cpp:
  8255. (BlackBerry::WebKit::InputHandler::setProcessingChange):
  8256. (WebKit):
  8257. * WebKitSupport/InputHandler.h:
  8258. (InputHandler):
  8259. * WebKitSupport/SelectionHandler.cpp:
  8260. (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
  8261. (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
  8262. (WebKit):
  8263. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  8264. (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
  8265. * WebKitSupport/SelectionHandler.h:
  8266. (SelectionHandler):
  8267. 2012-09-10 Antonio Gomes <agomes@rim.com>
  8268. [BlackBerry] add a way to overscroll non-overflown content
  8269. https://bugs.webkit.org/show_bug.cgi?id=96331
  8270. [UxD] Vertical lists should always be scrollable
  8271. PR #195305
  8272. Reviewed by Yong Li.
  8273. Internally reviewed by Gen Mak.
  8274. Check if the RenderLayer is composited / hardware acceleratable prior to
  8275. check if its contents overflows. If that is the case, check if
  8276. our custom data-blackberry-force-overscroll is present.
  8277. That makes it possible for us to align to UX requirements: settings
  8278. and CCM panels should be always scrollable.
  8279. * Api/InRegionScroller.cpp:
  8280. (BlackBerry::WebKit::canScrollRenderBox):
  8281. * WebKitSupport/InRegionScrollableArea.cpp:
  8282. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  8283. 2012-09-10 Genevieve Mak <gmak@rim.com>
  8284. Change -data-blackberry-webworks-context to -data-webworks-context
  8285. because not all webworks apps are blackberry apps.
  8286. https://bugs.webkit.org/show_bug.cgi?id=96297
  8287. Reviewed by Antonio Gomes.
  8288. PR #193726
  8289. Rubber Stamped interally by Mike Fenton.
  8290. * WebKitSupport/DOMSupport.cpp:
  8291. (BlackBerry::WebKit::DOMSupport::webWorksContext):
  8292. 2012-09-09 Arvid Nilsson <anilsson@rim.com>
  8293. [BlackBerry] Fix flicker due to introduction of the fence extension.
  8294. https://bugs.webkit.org/show_bug.cgi?id=96207
  8295. Reviewed by George Staikos.
  8296. Don't immediately add fence to garbage list, so it is destroyed
  8297. after only one swap, for a set of tiles just because one tile in
  8298. the set gets a new fence, the old fence may still not be signalled
  8299. and before rendering the other tiles in the set we have to wait for it.
  8300. * WebKitSupport/BackingStoreTile.cpp:
  8301. (BlackBerry::WebKit::Fence::~Fence):
  8302. (WebKit):
  8303. * WebKitSupport/BackingStoreTile.h:
  8304. (WebKit):
  8305. (Fence):
  8306. * WebKitSupport/SurfacePool.cpp:
  8307. (BlackBerry::WebKit::SurfacePool::initialize):
  8308. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  8309. (WebKit):
  8310. (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
  8311. * WebKitSupport/SurfacePool.h:
  8312. (SurfacePool):
  8313. 2012-09-08 Max Feil <mfeil@rim.com>
  8314. [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
  8315. https://bugs.webkit.org/show_bug.cgi?id=96027
  8316. Reviewed by Antonio Gomes.
  8317. The changes for bug 87337 (landed as trunk svn revision 119119)
  8318. introduced a bug. The same conditions are not checked on enter
  8319. fullscreen vs. exit. Web sites such as http://videojs.com
  8320. and youtube's mobile HTML5 player make the div container
  8321. of the video element go fullscreen. This is allowed in
  8322. WebPagePrivate::enterFullScreenForElement() but disallowed in
  8323. WebPagePrivate::exitFullScreenForElement(). I am fixing this by
  8324. allowing containers of video elements to exit fullscreen.
  8325. * Api/WebPage.cpp:
  8326. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  8327. 2012-09-07 Ming Xie <mxie@rim.com>
  8328. [BlackBerry] Remove browser from the build info page
  8329. https://bugs.webkit.org/show_bug.cgi?id=96162
  8330. Reviewed by George Staikos.
  8331. Internal reviewed by Jeff Rogers.
  8332. WebKit build should not have the build info for browser which is
  8333. built on top of webkit.
  8334. * WebKitSupport/AboutData.cpp:
  8335. (BlackBerry::WebKit::buildPage):
  8336. 2012-09-07 Yongxin Dai <yodai@rim.com>
  8337. [BlackBerry] Initialize caret rectangle with invalid location
  8338. https://bugs.webkit.org/show_bug.cgi?id=96011
  8339. Reviewed by Rob Buis.
  8340. In SelectionHandler::selectionPositionChanged() method, startCaret and
  8341. endCaret are used to notify clients about new caret positions. This patch
  8342. initializes startCaret and endCaret with location(-1. -1), and keeps them
  8343. empty before they are assigned to valid values. This would help for other
  8344. classes to check validity of the caret correctly.
  8345. Internal reviewed by Mike Fenton.
  8346. * WebKitSupport/SelectionHandler.cpp:
  8347. (BlackBerry::WebKit::adjustCaretRects):
  8348. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  8349. 2012-09-07 Lianghui Chen <liachen@rim.com>
  8350. [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
  8351. https://bugs.webkit.org/show_bug.cgi?id=95488
  8352. PR: 186597.
  8353. Internally reviewed by Joe Mason.
  8354. Reviewed by Yong Li.
  8355. Use new AuthenticationChallengeClient interface to make authentication
  8356. challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
  8357. other module that will use HTTP authentication. WebPage itself still use
  8358. synchronous authentication though. Switching to asynchronous authentication
  8359. in WebPage will require bigger platform layer change and not very necessary
  8360. at the moment for this bug.
  8361. * Api/WebPage.cpp:
  8362. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  8363. * Api/WebPage_p.h:
  8364. (WebCore):
  8365. (WebPagePrivate):
  8366. 2012-09-07 Rob Buis <rbuis@rim.com>
  8367. [BlackBerry] Remove feature about:cache/disable and about:cache/enable
  8368. https://bugs.webkit.org/show_bug.cgi?id=95820
  8369. Reviewed by Yong Li.
  8370. Fix warning that was caused by r127680.
  8371. * WebKitSupport/AboutData.cpp:
  8372. (BlackBerry::WebKit::cachePage):
  8373. 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  8374. Simplify hitTestResultAtPoint and nodesFromRect APIs
  8375. https://bugs.webkit.org/show_bug.cgi?id=95720
  8376. Reviewed by Antonio Gomes.
  8377. Update calls to new API.
  8378. * Api/WebPage.cpp:
  8379. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  8380. (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
  8381. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  8382. (BlackBerry::WebKit::WebPage::nodeAtPoint):
  8383. * WebKitSupport/FatFingers.cpp:
  8384. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  8385. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
  8386. * WebKitSupport/SelectionHandler.cpp:
  8387. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  8388. 2012-09-07 Robin Cao <robin.cao@torchmobile.com.cn>
  8389. [BlackBerry] Rendering issue after rotation
  8390. https://bugs.webkit.org/show_bug.cgi?id=96094
  8391. PR #201930
  8392. Reviewed by George Staikos.
  8393. The cause of the rendering issue is that the BackingStore tiles
  8394. are not reset after layout. This is a regression of r125680, which
  8395. overwrites a local variable that are used later in the function.
  8396. * Api/WebPage.cpp:
  8397. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  8398. 2012-09-06 Crystal Zhang <haizhang@rim.com>
  8399. [BlackBerry] Implement a color picker
  8400. https://bugs.webkit.org/show_bug.cgi?id=96001
  8401. Reviewed by Rob Buis.
  8402. Add files for color picker, replace old hook to AIR color picker.
  8403. * WebCoreSupport/ColorPickerClient.cpp: Added.
  8404. (WebCore):
  8405. (WebCore::ColorPickerClient::ColorPickerClient):
  8406. (WebCore::ColorPickerClient::~ColorPickerClient):
  8407. (WebCore::ColorPickerClient::generateHTML):
  8408. (WebCore::ColorPickerClient::closePopup):
  8409. (WebCore::ColorPickerClient::contentSize):
  8410. (WebCore::ColorPickerClient::htmlSource):
  8411. (WebCore::ColorPickerClient::setValueAndClosePopup):
  8412. (WebCore::ColorPickerClient::didClosePopup):
  8413. (WebCore::ColorPickerClient::writeDocument):
  8414. * WebCoreSupport/ColorPickerClient.h: Added.
  8415. (WebKit):
  8416. (WebCore):
  8417. (ColorPickerClient):
  8418. * WebKitSupport/InputHandler.cpp:
  8419. (BlackBerry::WebKit::InputHandler::openColorPopup):
  8420. 2012-09-06 Genevieve Mak <gmak@rim.com>
  8421. Add data-blackberry-webworks-context attribute and set the custom context when
  8422. getting context.
  8423. https://bugs.webkit.org/show_bug.cgi?id=95993
  8424. Reviewed by Antonio Gomes.
  8425. PR #193726
  8426. Reviewed Internally by Mike Fenton.
  8427. * Api/WebPage.cpp:
  8428. (BlackBerry::WebKit::WebPagePrivate::webContext):
  8429. - Check for custom WebWorks context and add it if there.
  8430. * WebKitSupport/DOMSupport.cpp:
  8431. (BlackBerry::WebKit::DOMSupport::webWorksContext):
  8432. (DOMSupport):
  8433. * WebKitSupport/DOMSupport.h:
  8434. - Add a method that checks a given element for the data-webworks-context
  8435. attribute and returns its value if present.
  8436. 2012-09-06 Antonio Gomes <agomes@rim.com>
  8437. [BlackBerry] Allow overscroll to composited scroll layers
  8438. https://bugs.webkit.org/show_bug.cgi?id=95998
  8439. PR #195305
  8440. Reviewed by Rob Buis.
  8441. Internally reviewed by Gen Mak.
  8442. No need to reset the overscroll limit factor at creation to 0.
  8443. It is already 0 by default, and later on the client sets the
  8444. appropriated value.
  8445. * WebKitSupport/InRegionScrollableArea.cpp:
  8446. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  8447. 2012-09-05 Sam Weinig <sam@webkit.org>
  8448. Part 2 of removing PlatformString.h, remove PlatformString.h
  8449. https://bugs.webkit.org/show_bug.cgi?id=95931
  8450. Reviewed by Adam Barth.
  8451. Remove PlatformString.h
  8452. * Api/DumpRenderTreeClient.h:
  8453. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  8454. * WebCoreSupport/InspectorClientBlackBerry.h:
  8455. * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
  8456. * WebKitSupport/AboutData.h:
  8457. 2012-09-05 Jason Liu <jason.liu@torchmobile.com.cn>
  8458. [BlackBerry] Remove feature about:cache/disable and about:cache/enable
  8459. https://bugs.webkit.org/show_bug.cgi?id=95820
  8460. Reviewed by Rob Buis.
  8461. Remove this feature since we need to add a button in settings.
  8462. * WebKitSupport/AboutData.cpp:
  8463. (BlackBerry::WebKit::cachePage):
  8464. 2012-09-05 Mike Fenton <mifenton@rim.com>
  8465. [BlackBerry] Remove deprecated dialog connections.
  8466. https://bugs.webkit.org/show_bug.cgi?id=95868
  8467. Reviewed by Rob Buis.
  8468. PR 187481.
  8469. Remove deprecated logic for unsupported
  8470. Dialog types.
  8471. * Api/WebPageClient.h:
  8472. * WebKitSupport/InputHandler.cpp:
  8473. (BlackBerry::WebKit::InputHandler::openDatePopup):
  8474. (BlackBerry::WebKit::InputHandler::openColorPopup):
  8475. 2012-09-05 George Staikos <staikos@webkit.org>
  8476. [BlackBerry] Assignment operators missing self-check
  8477. https://bugs.webkit.org/show_bug.cgi?id=95774
  8478. Reviewed by Rob Buis.
  8479. Add a test for self-assignment.
  8480. * Api/WebAnimation.cpp:
  8481. (BlackBerry::WebKit::WebAnimation::operator=):
  8482. * Api/WebString.cpp:
  8483. (BlackBerry::WebKit::WebString::operator=):
  8484. 2012-09-05 Leo Yang <leoyang@rim.com>
  8485. [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
  8486. https://bugs.webkit.org/show_bug.cgi?id=95897
  8487. Reviewed by Antonio Gomes.
  8488. Bail out the loop early if one of the not-rendered rectangle is
  8489. not current regular render job.
  8490. No behavior change, just code optimization.
  8491. * Api/BackingStore.cpp:
  8492. (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
  8493. 2012-09-05 Benjamin C Meyer <bmeyer@rim.com>
  8494. [BlackBerry] JavaScriptVariant can crash when operator= is called with itself
  8495. https://bugs.webkit.org/show_bug.cgi?id=95859
  8496. Reviewed by George Staikos.
  8497. * Api/JavaScriptVariant.cpp:
  8498. (BlackBerry::WebKit::JavaScriptVariant::operator=):
  8499. When JavaScriptVariant contains a string and operator= is
  8500. called with itself the memory will be free'd in 'this' and
  8501. then a copy will be attempted from 'that' resulting in a crash.
  8502. 2012-09-05 Leo Yang <leoyang@rim.com>
  8503. [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
  8504. https://bugs.webkit.org/show_bug.cgi?id=95870
  8505. Reviewed by George Staikos.
  8506. Reviewed internally by Jacky Jiang.
  8507. Use the new zoom to fit scale if the page was zoomed to fit initial scale
  8508. When a page is reloaded the layout size may be changed. So the contents
  8509. size on which the initial scale depends may be changed. Use the new initial
  8510. scale in this case to make sure the page will be zoomed to correct scale.
  8511. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  8512. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  8513. 2012-09-05 Robin Cao <robin.cao@torchmobile.com.cn>
  8514. [BlackBerry] Do not release shared backingstore memory prematurely
  8515. https://bugs.webkit.org/show_bug.cgi?id=95841
  8516. PR #202517
  8517. Reviewed by George Staikos.
  8518. The BackingStore memory is shared by all web pages. We should check if
  8519. the current backingStore is active before create/release this shared memory.
  8520. * Api/BackingStore.cpp:
  8521. (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
  8522. (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
  8523. 2012-09-05 Andy Chen <andchen@rim.com>
  8524. [BlackBerry] Implement number of matches and current active match index for find-on-page
  8525. https://bugs.webkit.org/show_bug.cgi?id=95801
  8526. Reviewed by Antonio Gomes.
  8527. - Calculate current match index for find-on-page
  8528. - Notify client when number of matches and current match index update.
  8529. PR 162090 162091.
  8530. Internally reviewed by Mike Fenton and Joe Mason
  8531. * Api/WebPageClient.h:
  8532. * WebKitSupport/InPageSearchManager.cpp:
  8533. (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
  8534. (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
  8535. (InPageSearchManager::DeferredScopeStringMatches):
  8536. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  8537. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  8538. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  8539. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
  8540. (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
  8541. * WebKitSupport/InPageSearchManager.h:
  8542. (InPageSearchManager):
  8543. 2012-09-04 Rob Buis <rbuis@rim.com>
  8544. [BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
  8545. https://bugs.webkit.org/show_bug.cgi?id=95783
  8546. Reviewed by Antonio Gomes.
  8547. Use the correct enum values.
  8548. * WebKitSupport/FatFingers.cpp:
  8549. (BlackBerry::WebKit::FatFingers::cachingStrategy):
  8550. 2012-09-04 Antonio Gomes <agomes@rim.com>
  8551. [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
  8552. https://bugs.webkit.org/show_bug.cgi?id=95778
  8553. PR #202252
  8554. Reviewed by Rob Buis.
  8555. Internally reviewed by Arvid Nilsson.
  8556. Upstream has switch away from using the parent scroll layer's bounds origin
  8557. in order to translate contents of all its child layers. Instead now, it directly
  8558. sets the scroll position of the child scrollable contents layer.
  8559. Source/WebKit/blackberry:
  8560. * Api/InRegionScroller.cpp:
  8561. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
  8562. * WebKitSupport/InRegionScrollableArea.cpp:
  8563. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  8564. No new tests, since it is a catch-up with upstreaming code.
  8565. 2012-09-04 George Staikos <staikos@webkit.org>
  8566. [BlackBerry] Fix memory leak in InputHandler
  8567. https://bugs.webkit.org/show_bug.cgi?id=95771
  8568. Reviewed by Rob Buis.
  8569. Simply delete the arrays at function exit.
  8570. * WebKitSupport/InputHandler.cpp:
  8571. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  8572. 2012-09-04 George Staikos <staikos@webkit.org>
  8573. [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
  8574. https://bugs.webkit.org/show_bug.cgi?id=95766
  8575. Reviewed by Rob Buis.
  8576. Passing the frame status through will allow the client to make better
  8577. decisions about how to act on the onload.
  8578. * Api/WebPageClient.h:
  8579. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  8580. (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
  8581. 2012-09-04 Rob Buis <rbuis@rim.com>
  8582. [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
  8583. https://bugs.webkit.org/show_bug.cgi?id=95769
  8584. Reviewed by Yong Li.
  8585. Also remove WTF prefixes.
  8586. * Api/DumpRenderTreeClient.h:
  8587. 2012-09-04 Mary Wu <mary.wu@torchmobile.com.cn>
  8588. [BlackBerry] Add webplatform and browser to build info
  8589. https://bugs.webkit.org/show_bug.cgi?id=95715
  8590. Reviewed by George Staikos.
  8591. PR# 202102
  8592. * WebKitSupport/AboutData.cpp:
  8593. (BlackBerry::WebKit::buildPage):
  8594. 2012-08-31 Jacky Jiang <zhajiang@rim.com>
  8595. [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
  8596. https://bugs.webkit.org/show_bug.cgi?id=95611
  8597. Reviewed by Antonio Gomes.
  8598. PR:200127
  8599. Remove r118405 now as we already have a new fix webkit/43f8394b for
  8600. that issue and it is not reproducible anymore after the removal.
  8601. In this way, we can get rid of this ASSERT failure as well.
  8602. Thanks Antonio for the suggestion.
  8603. * Api/WebPage.cpp:
  8604. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  8605. 2012-08-31 Joshua Netterfield <jnetterfield@rim.com>
  8606. [BlackBerry] Eliminate WebGL IT policy
  8607. https://bugs.webkit.org/show_bug.cgi?id=95604
  8608. Internal RIM PR #198764
  8609. Reviewed by Rob Buis.
  8610. This is no longer a requirement for the BlackBerry port.
  8611. * Api/WebPage.cpp:
  8612. (BlackBerry::WebKit::WebPagePrivate::init):
  8613. (BlackBerry::WebKit::WebPage::setWebGLEnabled):
  8614. * WebKitSupport/AboutData.cpp:
  8615. (BlackBerry::WebKit::configPage):
  8616. 2012-08-30 Benjamin Poulain <bpoulain@apple.com>
  8617. Replace JSC::UString by WTF::String
  8618. https://bugs.webkit.org/show_bug.cgi?id=95271
  8619. Reviewed by Geoffrey Garen.
  8620. Replace UString by String.
  8621. * WebCoreSupport/ClientExtension.cpp:
  8622. * WebCoreSupport/PagePopupBlackBerry.cpp:
  8623. (WebCore::PagePopupBlackBerry::installDomFunction):
  8624. 2012-08-30 Jacky Jiang <zhajiang@rim.com>
  8625. [BlackBerry] ASSERT failure in JSC::MarkedAllocator::allocateSlowCase
  8626. https://bugs.webkit.org/show_bug.cgi?id=95492
  8627. Reviewed by Yong Li.
  8628. PR: 200724
  8629. Hold the JSLock for the current thread before we call toRef to avoid
  8630. the ASSERT failure.
  8631. * Api/WebPage.cpp:
  8632. (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
  8633. 2012-08-30 Antonio Gomes <agomes@rim.com>
  8634. [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition
  8635. https://bugs.webkit.org/show_bug.cgi?id=95476
  8636. PR #200704
  8637. Reviewed by Yong Li.
  8638. This code is not needed at this point for neither the fast nor slow in-region
  8639. scroll codepaths, and it is a huge performance beast as it forces all
  8640. containers to get full-repainted per scroll call (in webkit thread).
  8641. Patch also take this opportunity to remove an early-return we
  8642. have in the {i}frame slow scrolling code path so that we can
  8643. adjust the selection handles in this case as well.
  8644. * Api/InRegionScroller.cpp:
  8645. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  8646. 2012-08-30 Hanna Ma <Hanma@rim.com>
  8647. [BlackBerry] node search does not work with elements on touch start listener
  8648. https://bugs.webkit.org/show_bug.cgi?id=95252
  8649. Reviewed by Antonio Gomes.
  8650. Fix the node search function of web insepctor on elements with touch start listener.
  8651. Add methods from webPage to check if the node search functionality is enabled before handling touch events.
  8652. PR194107
  8653. * Api/WebPage.cpp:
  8654. (BlackBerry::WebKit::WebPage::touchEvent):
  8655. 2012-08-30 Arvid Nilsson <anilsson@rim.com>
  8656. [BlackBerry] One shot drawing sync flag never cleared when there's no layers
  8657. https://bugs.webkit.org/show_bug.cgi?id=95447
  8658. Reviewed by Antonio Gomes.
  8659. PR 199866
  8660. When we remove the layers, WebKit could tell us we need a one shot
  8661. drawing sync to repaint the BackingStore with the content that was
  8662. previously drawn by layers. We also sometimes set the one shot drawing
  8663. sync flag manually.
  8664. We would bail from commit if there were no layers and not actually
  8665. perform the osds, so it left the osds flag set forever and the
  8666. situation prevails, because nobody will ever clear the osds flag.
  8667. The BackingStore surrenders the responsibility of blitting to the AC
  8668. commit mechanism when a one shot drawing sync is pending, because we
  8669. want the operations render, commit and blit to happen in the correct
  8670. order with no intermediate blits.
  8671. So, no commit means no blit, and the result of regular rendering did
  8672. not show up on screen.
  8673. Fixed by not bailing from commit if there's no layers, instead clearing
  8674. the "needs commit" and osds flags and performing a blit.
  8675. Reviewed internally by Andrew Lo.
  8676. * Api/WebPage.cpp:
  8677. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  8678. 2012-08-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  8679. Use ASCIILiteral for DEFINE_STATIC_LOCAL string
  8680. https://bugs.webkit.org/show_bug.cgi?id=95420
  8681. Reviewed by Benjamin Poulain.
  8682. As recommended by http://trac.webkit.org/wiki/EfficientStrings,
  8683. WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.
  8684. * Api/WebSettings.cpp:
  8685. (WebKit):
  8686. 2012-08-29 Nima Ghanavatian <nghanavatian@rim.com>
  8687. [BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger.
  8688. https://bugs.webkit.org/show_bug.cgi?id=95372
  8689. By using the shadow tree we were getting a mismatch between elements of the
  8690. current element under focus and the one return to us from FatFingers.
  8691. Passing ShadowContentNotAllowed to get the right handle.
  8692. Reviewed by Antonio Gomes.
  8693. * WebKitSupport/TouchEventHandler.cpp:
  8694. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  8695. 2012-08-29 Robin Cao <robin.cao@torchmobile.com.cn>
  8696. [BlackBerry] Move the handling of UserMedia requests to the client
  8697. https://bugs.webkit.org/show_bug.cgi?id=95317
  8698. PR #197283
  8699. Reviewed by George Staikos.
  8700. Internally reviewed by George Staikos.
  8701. Move the logic for user media requests handling to the client, as it requires
  8702. inputs from users. Also adds a origin field to WebUserMediaRequest.
  8703. * Api/WebPageClient.h:
  8704. (Platform):
  8705. * WebCoreSupport/UserMediaClientImpl.cpp:
  8706. (WebCore::UserMediaClientImpl::UserMediaClientImpl):
  8707. (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
  8708. (WebCore::UserMediaClientImpl::requestUserMedia):
  8709. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  8710. * WebCoreSupport/UserMediaClientImpl.h:
  8711. (UserMediaClientImpl):
  8712. 2012-08-29 Antonio Gomes <agomes@rim.com>
  8713. [BlackBerry] Replace blackberry specific HitTestRequest::FingerUp by TouchEvent + Release
  8714. https://bugs.webkit.org/show_bug.cgi?id=95383
  8715. Reviewed by Rob Buis.
  8716. * WebKitSupport/TouchEventHandler.cpp:
  8717. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  8718. 2012-08-29 Rob Buis <rbuis@rim.com>
  8719. [BlackBerry] Adjust wtf include header style
  8720. https://bugs.webkit.org/show_bug.cgi?id=95368
  8721. Reviewed by Yong Li.
  8722. Switch to #include <wtf/...> like the other ports.
  8723. * Api/BlackBerryGlobal.cpp:
  8724. * Api/WebPage.cpp:
  8725. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  8726. * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
  8727. * WebCoreSupport/SelectPopupClient.h:
  8728. * WebKitSupport/AboutData.cpp:
  8729. * WebKitSupport/DOMSupport.cpp:
  8730. * WebKitSupport/GLES2Context.cpp:
  8731. * WebKitSupport/InPageSearchManager.h:
  8732. * WebKitSupport/InputHandler.cpp:
  8733. 2012-08-29 Jacky Jiang <zhajiang@rim.com>
  8734. [BlackBerry] Remove unused tapGesture in WebPage.cpp
  8735. https://bugs.webkit.org/show_bug.cgi?id=95357
  8736. Reviewed by Rob Buis.
  8737. Remove unused variable tapGesture in WebPage.cpp.
  8738. Internally reviewed by Gen Mak.
  8739. * Api/WebPage.cpp:
  8740. (BlackBerry::WebKit::WebPage::touchEvent):
  8741. 2012-08-28 Antonio Gomes <agomes@rim.com>
  8742. [BlackBerry] crash while trying to scroll any inner frame
  8743. https://bugs.webkit.org/show_bug.cgi?id=95287
  8744. PR #198510
  8745. Reviewed by George Staikos.
  8746. Set the starting point of scrolling (slow path only still)
  8747. for inner frames. It was left over as set to 0 by r126474.
  8748. In practice, patch fixes a crash on gmail.com desktop edition.
  8749. * WebKitSupport/InRegionScrollableArea.cpp:
  8750. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  8751. 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
  8752. Unreviewed, rolling out r126914.
  8753. http://trac.webkit.org/changeset/126914
  8754. https://bugs.webkit.org/show_bug.cgi?id=95239
  8755. it breaks everything and fixes nothing (Requested by pizlo on
  8756. #webkit).
  8757. * Api/BackingStore.cpp:
  8758. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  8759. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  8760. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  8761. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  8762. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  8763. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  8764. * WebCoreSupport/NotificationPresenterImpl.cpp:
  8765. (WebCore::NotificationPresenterImpl::cancel):
  8766. (WebCore::NotificationPresenterImpl::onPermission):
  8767. (WebCore::NotificationPresenterImpl::notificationClicked):
  8768. * WebCoreSupport/UserMediaClientImpl.cpp:
  8769. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  8770. * WebKitSupport/AboutData.cpp:
  8771. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  8772. * WebKitSupport/FrameLayers.cpp:
  8773. (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
  8774. (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
  8775. (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
  8776. 2012-08-28 Nima Ghanavatian <nghanavatian@rim.com>
  8777. [BlackBerry] Spellcheck should be enabled if undefined in content.
  8778. https://bugs.webkit.org/show_bug.cgi?id=95139
  8779. Currently we only enable spellcheck if it is defined as such in
  8780. the web content explicitly.
  8781. Making this change to enable by default, and only turn off if it is
  8782. explicitly set, or if we expect the field to be a username, email or
  8783. url.
  8784. Internally reviewed by Mike Fenton.
  8785. Reviewed by Rob Buis.
  8786. * WebKitSupport/InputHandler.cpp:
  8787. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  8788. (BlackBerry::WebKit::InputHandler::setElementFocused):
  8789. (BlackBerry::WebKit::InputHandler::unlockSequenceMap):
  8790. (WebKit):
  8791. (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
  8792. * WebKitSupport/InputHandler.h:
  8793. (InputHandler):
  8794. 2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  8795. Rename first/second to key/value in HashMap iterators
  8796. https://bugs.webkit.org/show_bug.cgi?id=82784
  8797. Reviewed by Eric Seidel.
  8798. * Api/BackingStore.cpp:
  8799. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  8800. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  8801. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  8802. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  8803. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  8804. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  8805. * WebCoreSupport/NotificationPresenterImpl.cpp:
  8806. (WebCore::NotificationPresenterImpl::cancel):
  8807. (WebCore::NotificationPresenterImpl::onPermission):
  8808. (WebCore::NotificationPresenterImpl::notificationClicked):
  8809. * WebKitSupport/AboutData.cpp:
  8810. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  8811. * WebKitSupport/FrameLayers.cpp:
  8812. (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
  8813. (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
  8814. (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
  8815. * WebCoreSupport/UserMediaClientImpl.cpp:
  8816. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  8817. 2012-08-28 Nima Ghanavatian <nghanavatian@rim.com>
  8818. [BlackBerry] Range boundaries should use endOfBlock instead of endOfLine.
  8819. https://bugs.webkit.org/show_bug.cgi?id=95135
  8820. The original implementation used nextLinePosition to iterate
  8821. through the field from the start of each line, and was bounded in
  8822. comparison to the endOfLine. This works fine as long as there aren't any
  8823. empty lines between paragraphs of text, since these will have
  8824. startOfLine == endOfLine and break out.
  8825. Also, protect map access with a mutex in case we get a response
  8826. before updating the map. Further, we should check the Range pointer
  8827. before using it, since its not guaranteed to be valid.
  8828. Internally reviewed by Mike Fenton.
  8829. Reviewed by Antonio Gomes.
  8830. * WebKitSupport/InputHandler.cpp:
  8831. (BlackBerry::WebKit::InputHandler::spellCheckBlock):
  8832. 2012-08-28 Andrew Lo <anlo@rim.com>
  8833. [BlackBerry] One shot drawing synchronization broken
  8834. https://bugs.webkit.org/show_bug.cgi?id=95179
  8835. Reviewed by Antonio Gomes.
  8836. Internally reviewed by Arvid Nilsson.
  8837. Make sure no backing store blits happen during one shot drawing
  8838. synchronization.
  8839. Since we always blit during commit now, make sure we don't blit if
  8840. we commit after a render.
  8841. We no longer need a deferred blit since we don't commit during renderContents
  8842. now. Instead, we only commit & blit once after a full render job.
  8843. * Api/BackingStore.cpp:
  8844. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  8845. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  8846. (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
  8847. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  8848. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  8849. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  8850. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  8851. (WebKit):
  8852. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  8853. (BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
  8854. * Api/BackingStore_p.h:
  8855. (BackingStorePrivate):
  8856. * Api/WebPage.cpp:
  8857. (WebKit):
  8858. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  8859. * Api/WebPage_p.h:
  8860. (WebPagePrivate):
  8861. * WebKitSupport/RenderQueue.cpp:
  8862. (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
  8863. (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
  8864. (BlackBerry::WebKit::RenderQueue::visibleScrollJobsCompleted):
  8865. 2012-08-28 Parth Patel <parpatel@rim.com>
  8866. [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient
  8867. https://bugs.webkit.org/show_bug.cgi?id=95113
  8868. Reviewed by Kentaro Hara.
  8869. Refactoring has lead to relocation of many or all methods from Class
  8870. BlackBerryPlatformClient to other classes. Some files include
  8871. BlackBerryPlatformClient but does not use its instance thus these
  8872. includes has to be removed.
  8873. * Api/BackingStore.cpp:
  8874. 2012-08-28 Andy Chen <andchen@rim.com>
  8875. [BlackBerry] UpdateViewport uses wrong size for frameView
  8876. https://bugs.webkit.org/show_bug.cgi?id=95138
  8877. Reviewed by Antonio Gomes.
  8878. Internally reviewed by Jakob Petsovits.
  8879. Use actual visible size instead of screen size when updating viewport size,
  8880. otherwise, frameView size would be too big.
  8881. * Api/WebPage.cpp:
  8882. (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
  8883. 2012-08-28 Andy Chen <andchen@rim.com>
  8884. [BlackBerry] Pseudo class "active" is broken
  8885. https://bugs.webkit.org/show_bug.cgi?id=95142
  8886. Reviewed by Antonio Gomes.
  8887. Check if an element is affected by active rule before cancelling
  8888. the touch event.
  8889. PR 198544.
  8890. * WebKitSupport/TouchEventHandler.cpp:
  8891. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  8892. 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
  8893. Unreviewed, rolling out r126836.
  8894. http://trac.webkit.org/changeset/126836
  8895. https://bugs.webkit.org/show_bug.cgi?id=95163
  8896. Broke all Apple ports, EFL, and Qt. (Requested by tkent on
  8897. #webkit).
  8898. * Api/BackingStore.cpp:
  8899. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  8900. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  8901. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  8902. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  8903. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  8904. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  8905. * WebCoreSupport/NotificationPresenterImpl.cpp:
  8906. (WebCore::NotificationPresenterImpl::cancel):
  8907. (WebCore::NotificationPresenterImpl::onPermission):
  8908. (WebCore::NotificationPresenterImpl::notificationClicked):
  8909. * WebKitSupport/AboutData.cpp:
  8910. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  8911. * WebKitSupport/FrameLayers.cpp:
  8912. (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
  8913. (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
  8914. (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
  8915. 2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  8916. Rename first/second to key/value in HashMap iterators
  8917. https://bugs.webkit.org/show_bug.cgi?id=82784
  8918. Reviewed by Eric Seidel.
  8919. * Api/BackingStore.cpp:
  8920. (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
  8921. (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
  8922. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  8923. (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
  8924. (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
  8925. (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
  8926. * WebCoreSupport/NotificationPresenterImpl.cpp:
  8927. (WebCore::NotificationPresenterImpl::cancel):
  8928. (WebCore::NotificationPresenterImpl::onPermission):
  8929. (WebCore::NotificationPresenterImpl::notificationClicked):
  8930. * WebKitSupport/AboutData.cpp:
  8931. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  8932. * WebKitSupport/FrameLayers.cpp:
  8933. (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
  8934. (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
  8935. (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
  8936. 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
  8937. Unreviewed, rolling out r126772.
  8938. http://trac.webkit.org/changeset/126772
  8939. https://bugs.webkit.org/show_bug.cgi?id=95137
  8940. "This change breaks news.qq.com" (Requested by leoyang on
  8941. #webkit).
  8942. * Api/WebPage.cpp:
  8943. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  8944. 2012-08-27 Leo Yang <leoyang@rim.com>
  8945. [BlackBerry] Not using absoluteVisibleOverSize when rotating
  8946. https://bugs.webkit.org/show_bug.cgi?id=95092
  8947. PR #190469
  8948. Reviewed by Antonio Gomes.
  8949. Reviewed internally by Arvid Nilsson.
  8950. When we are rotating don't count absolute overflow visible size
  8951. into fixed layout size because we are in a transient state. The
  8952. absolute overflow visible size remains old size during rotation.
  8953. * Api/WebPage.cpp:
  8954. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  8955. 2012-08-25 Antonio Gomes <agomes@rim.com>
  8956. [BlackBerry] Remove the 'in region scrollable starting node' concept from InRegionScroller
  8957. https://bugs.webkit.org/show_bug.cgi?id=95020
  8958. Reviewed by Rob Buis.
  8959. 'In-region start scrolling node' is an obsolete concept, and we can remove it
  8960. in favor of using the information from the cached layers.
  8961. * Api/InRegionScroller.cpp:
  8962. (WebKit):
  8963. (BlackBerry::WebKit::InRegionScrollerPrivate::reset): Adjusted as it used to clear
  8964. the cached 'node'.
  8965. (BlackBerry::WebKit::InRegionScrollerPrivate::isActive): Added method to be
  8966. checked directly instead of only null-checking the previously cached 'node'.
  8967. (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData): New method to
  8968. clear the cached resources if its document is done.
  8969. (BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): Adjusted
  8970. to not care about the cached 'node' anymore.
  8971. * Api/InRegionScroller_p.h:
  8972. (InRegionScrollerPrivate):
  8973. * Api/WebPage.cpp:
  8974. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped): Check ::isActive instead
  8975. of ::hasNode, since the later is gone.
  8976. (BlackBerry::WebKit::WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableAreaAfterInRegionScrolling):
  8977. Changed the method signature, given that we do have a cached 'node' to pass in as parameter anymore.
  8978. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData): Delegate all the related work to InRegionScroller.
  8979. * Api/WebPage_p.h:
  8980. (WebPagePrivate):
  8981. * WebKitSupport/TouchEventHandler.cpp:
  8982. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  8983. .
  8984. 2012-08-25 Antonio Gomes <agomes@rim.com>
  8985. BlackBerry] Shrink the in-region nested scrollable list as soon as we can
  8986. https://bugs.webkit.org/show_bug.cgi?id=95019
  8987. Reviewed by Rob Buis.
  8988. We cache all possible nested scrollable in-region layers given a point.
  8989. It is up to the client to pick a view, based on the scroll position and limits
  8990. of each layer, and on the direction user swipes its finger.
  8991. From the point we pick a view on, we stick with it, and any other
  8992. possibly cached layer can be uncached, as it won't be needed.
  8993. Patch provides a simple solution to that.
  8994. * Api/InRegionScroller.cpp:
  8995. (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
  8996. (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
  8997. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
  8998. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateActiveAndShrinkCachedScrollableAreas):
  8999. (WebKit):
  9000. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  9001. * Api/InRegionScroller_p.h:
  9002. (InRegionScrollerPrivate):
  9003. 2012-08-25 Antonio Gomes <agomes@rim.com>
  9004. For convenience, make RenderLayer::enclosingElement a public method.
  9005. https://bugs.webkit.org/show_bug.cgi?id=95018
  9006. Reviewed by George Staikos.
  9007. Make use of the new public RenderLayer::enclosingElement method and
  9008. remove duplicated code.
  9009. * WebKitSupport/InRegionScrollableArea.cpp:
  9010. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  9011. 2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  9012. Rename RegisterProtocolHandler API to NavigatorContentUtils
  9013. https://bugs.webkit.org/show_bug.cgi?id=94920
  9014. Reviewed by Adam Barth.
  9015. Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
  9016. * WebCoreSupport/AboutDataEnableFeatures.in:
  9017. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  9018. (WebCore):
  9019. (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
  9020. * WebCoreSupport/ChromeClientBlackBerry.h:
  9021. (ChromeClientBlackBerry):
  9022. 2012-08-26 Arvid Nilsson <anilsson@rim.com>
  9023. [BlackBerry] ASSERT failed in WebPagePrivate::commitRootLayerIfNeeded()
  9024. https://bugs.webkit.org/show_bug.cgi?id=94921
  9025. PR 104676
  9026. As visibility changed due to WebPage::setVisible(true),
  9027. resumeRootLayerCommit() would call commitRootLayerIfNeeded(), without
  9028. layouting or rendering. If a one shot drawing sync was pending at this
  9029. time, it would cause the condition
  9030. ASSERT(!needsOneShotDrawingSynchronization()) to fail.
  9031. The comment immediately before the assert states that "In case of one
  9032. shot drawing synchronization, you should first layoutIfNeeded, render,
  9033. then commit and draw the layers". However, resumeRootLayerCommit() did
  9034. no such thing.
  9035. Fixed by removing the call to commitRootLayerIfNeeded() from
  9036. resumeRootLayerCommit(), because the latter is only called in a code
  9037. path where we're going to layout, render and then commit anyway. These
  9038. operations will be performed from resumeBackingStore() which is called
  9039. at the end of setVisible().
  9040. Reviewed by George Staikos.
  9041. * Api/WebPage.cpp:
  9042. (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
  9043. 2012-08-24 Adam Treat <atreat@rim.com>
  9044. [BlackBerry] Web pages are zoomed out to much on initial load
  9045. https://bugs.webkit.org/show_bug.cgi?id=94830
  9046. The previous patch caused a slight regression to the calculation we do
  9047. for the default splitting factor in the render queue. The default value
  9048. we use to represent the max area should be the tile size. This was true
  9049. with the old calculation of default max layout width since it was the
  9050. screen size. The fix is to be explicit and use the tile size directly.
  9051. Reviewed by George Staikos.
  9052. * WebKitSupport/RenderQueue.cpp:
  9053. (BlackBerry::WebKit::RenderQueue::splittingFactor):
  9054. 2012-08-24 Parth Patel <parpatel@rim.com>
  9055. [BlackBerry] Changes resulting from moving network related methods
  9056. from platform client to platform settings.
  9057. https://bugs.webkit.org/show_bug.cgi?id=94963
  9058. Reviewed by Yong Li.
  9059. Changes in response to Network methods moved from
  9060. class BlackBerryPlatformClient to class BlackBerryPlatformSettings
  9061. in platform repository.
  9062. * WebKitSupport/AboutData.cpp:
  9063. (BlackBerry::WebKit::cachePage):
  9064. 2012-08-24 Liam Quinn <lquinn@rim.com>
  9065. [BlackBerry] Debug assertion fires in BackingStorePrivate::renderJob()
  9066. https://bugs.webkit.org/show_bug.cgi?id=94960
  9067. Reviewed by Adam Treat.
  9068. Change the assertion into an early return as recommended by Adam Treat.
  9069. * Api/BackingStore.cpp:
  9070. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  9071. 2012-08-24 Andrew Lo <anlo@rim.com>
  9072. [BlackBerry] Animation & UI lag when rendering
  9073. https://bugs.webkit.org/show_bug.cgi?id=94943
  9074. Reviewed by Rob Buis.
  9075. Schedule a backing store blit & composite when commiting root layer.
  9076. This results in compositing not having to wait until after a long render
  9077. operation, increasing responsiveness & fixing animations which skip to
  9078. the last frame due to lag.
  9079. This can cause a blit during a "one shot drawing synchronization", which is
  9080. a render & commit on the AC layers, which may result in flashing.
  9081. However, this can happen in other situations as well, and we feel that
  9082. the responsiveness, reduced lag, and smoothness of animations is
  9083. more important.
  9084. Internal PR194209
  9085. Internally reviewed by: George Staikos.
  9086. * Api/WebPage.cpp:
  9087. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  9088. 2012-08-24 Parth Patel <parpatel@rim.com>
  9089. [BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings.
  9090. https://bugs.webkit.org/show_bug.cgi?id=94249
  9091. Reviewed by Rob Buis.
  9092. PR# 170160
  9093. Changes in response to Application Directory methods moved from
  9094. Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
  9095. platform respository since these methods are more appropriate in
  9096. class BlackBerryPlatformSettings.
  9097. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  9098. (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
  9099. 2012-08-24 Antonio Gomes <agomes@rim.com>
  9100. [BlackBerry] Touch cancel can cause huge and needless invalidations
  9101. https://bugs.webkit.org/show_bug.cgi?id=94938
  9102. PR #198051
  9103. Reviewed by George Staikos.
  9104. Internally reviewed by Gen Mak.
  9105. In order to remove the possible hover effect on touch_cancel, we always
  9106. invalidate the node under the fat finger, being the fat finger valid or not.
  9107. Point is: having a valid fat finger node does not mean the original touch
  9108. position was actually adjust for clicking or that the fat finger is actually
  9109. valid. We set the fat finger node to be the result of the point-based hit-test
  9110. regardless if it is a click target or not (in order to make our mouse-move
  9111. machinery to work).
  9112. We should can less aggressively invalidate the fat finger node, since it can
  9113. be rather an expensive call (longer than 1s in the worst scenario).
  9114. * WebKitSupport/TouchEventHandler.cpp:
  9115. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  9116. 2012-08-24 Arvid Nilsson <anilsson@rim.com>
  9117. [BlackBerry] Add WebPage API to reset block zoom
  9118. https://bugs.webkit.org/show_bug.cgi?id=94863
  9119. PR 187478
  9120. This is an alternative to WebPage::blockZoomAnimationFinished() when
  9121. it's desirable to avoid rerendering of the whole web page at the end
  9122. of block zoom. This is the case when the planned "incremental zoom
  9123. factor" is used instead of zoomAboutPoint and it's relatives.
  9124. Ideally, the block zoom algorithm would be clever enough not to need
  9125. a reset or any form of callback when the animation finishes, but that
  9126. requires the implementation of said incremental zoom factor, which is
  9127. not done yet.
  9128. Reviewed by Antonio Gomes.
  9129. * Api/WebPage.cpp:
  9130. (BlackBerry::WebKit::WebPage::resetBlockZoom):
  9131. (WebKit):
  9132. * Api/WebPage.h:
  9133. 2012-08-23 Antonio Gomes <agomes@rim.com>
  9134. [BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
  9135. https://bugs.webkit.org/show_bug.cgi?id=94839
  9136. PR #197775
  9137. Reviewed by George Staikos.
  9138. This codepath is not needed anymore, so lets let it RIP.
  9139. The only code addition is due to some code I've moved from WebPagePrivate::scrollNodeRecursively
  9140. and WebPagePrivate::scrollBy to InRegionScrollerPrivate::setLayerScrollPosition.
  9141. Rest is code removal ...
  9142. * Api/InRegionScroller.cpp:
  9143. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  9144. * Api/InRegionScroller_p.h:
  9145. (InRegionScrollerPrivate):
  9146. * Api/WebPage.cpp:
  9147. (BlackBerry::WebKit::WebPagePrivate::scrollBy):
  9148. (BlackBerry::WebKit::WebPage::scrollBy):
  9149. * Api/WebPage.h:
  9150. * Api/WebPage_p.h:
  9151. (WebPagePrivate):
  9152. 2012-08-23 Adam Treat <atreat@rim.com>
  9153. [BlackBerry] Replace the three different rendering mechanisms for clearing the render queue
  9154. https://bugs.webkit.org/show_bug.cgi?id=94837
  9155. Reviewed by George Staikos.
  9156. PR 197738
  9157. Currently, we have three different mechanisms for clearing the render queue.
  9158. The first mechanism is render on idle. Whenever the webkit thread becomes idle
  9159. (read: no more events in its queue) we render the next job in the render queue.
  9160. This is the primary means we use for clearing the render queue. However, this
  9161. mechanism has a flaw, it is such a low priority mechanism that sometimes the
  9162. queue grows so fast due to higher priority events adding rects to the queue
  9163. that this mechanism can't possibly keep up. That is what leads to the second
  9164. mechanism: rendering right before a timer is fired when we discover that the
  9165. render queue is under pressure and rendering on idle can't keep up. However,
  9166. there are still degenerate cases where even this mechanism does not allow us to
  9167. keep up. That brings us to the third mechanism: rendering based on a timer
  9168. that is a catch-all.
  9169. The second and third mechanisms lead to very large render jobs as they try and
  9170. clear the queue faster when it comes under pressure. These very large render
  9171. jobs end up keeping the webkit thread busy with a message that can take large
  9172. fractions of a second to resolve.
  9173. These three mechanisms were put in place when the backingstore had a different
  9174. overall design that was not truly asynchronous. This patch replaces these
  9175. three mechanisms with a single one that uses the platform messaging classes to
  9176. full purpose - a uniquely coalescing message that has a higher priority level
  9177. than timers making sure the render queue can never come under pressure.
  9178. * Api/BackingStore.cpp:
  9179. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  9180. (WebKit):
  9181. (RenderJobMessage):
  9182. (BlackBerry::WebKit::RenderJobMessage::RenderJobMessage):
  9183. (BlackBerry::WebKit::BackingStorePrivate::dispatchRenderJob):
  9184. (BlackBerry::WebKit::BackingStorePrivate::renderJob):
  9185. (BlackBerry::WebKit::BackingStore::blitContents):
  9186. * Api/BackingStore.h:
  9187. * Api/BackingStore_p.h:
  9188. (BackingStorePrivate):
  9189. * Api/WebPage.cpp:
  9190. * Api/WebPage.h:
  9191. * WebKitSupport/RenderQueue.cpp:
  9192. (BlackBerry::WebKit::RenderQueue::reset):
  9193. (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
  9194. (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
  9195. (BlackBerry::WebKit::RenderQueue::clear):
  9196. (BlackBerry::WebKit::RenderQueue::clearVisibleZoom):
  9197. (BlackBerry::WebKit::RenderQueue::render):
  9198. 2012-08-23 Antonio Gomes <agomes@rim.com>
  9199. [BlackBerry] Unify slow and fast in-region scrolling code paths
  9200. https://bugs.webkit.org/show_bug.cgi?id=94834
  9201. PR #197662
  9202. Reviewed by Rob Buis.
  9203. Internally reviewed by Arvid Nilsson.
  9204. In order to be able to remove a bunch of obsolete code from
  9205. InRegionScroller.cpp, we need to unify the codepaths for slow
  9206. and fast in-region scrolling.
  9207. This patch caches the root scrollable node of each scrollable block
  9208. in InRegionScrollableArea also for the non-composited-scrolling case now too
  9209. (analogly to the way we cache LayerWebKitThread for the composited scrolling case).
  9210. Now the client (libwebview) can dispatch an in-region scrolling with one single code path,
  9211. making use of a boolean (argh!) to inform if the scroll of the given
  9212. layer supports compositing or not. Later on, this boolean is used to casting the proper element.
  9213. * Api/InRegionScroller.cpp:
  9214. (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
  9215. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
  9216. * Api/InRegionScroller.h:
  9217. * Api/InRegionScroller_p.h:
  9218. (InRegionScrollerPrivate):
  9219. * WebKitSupport/InRegionScrollableArea.cpp:
  9220. (WebKit):
  9221. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  9222. (BlackBerry::WebKit::enclosingLayerNode):
  9223. * WebKitSupport/InRegionScrollableArea.h:
  9224. (WebCore):
  9225. (InRegionScrollableArea):
  9226. 2012-08-23 Jacky Jiang <zhajiang@rim.com>
  9227. [BlackBerry] Web pages are zoomed out to much on initial load
  9228. https://bugs.webkit.org/show_bug.cgi?id=94830
  9229. Reviewed by Adam Treat.
  9230. PR: 193943
  9231. Browser continuously adds paddings to the left and right sides of the
  9232. main contents which makes the main contents even smaller.
  9233. The issue can be reproduced on the desktop websites such as
  9234. huffingtonpost.ca, bloomberg.com, online.wsj.com, nytimes.com,
  9235. yahoo.com, thestar.com, sina.com.cn, sohu.com and so on.
  9236. The root cause is that we layout those contents at the width of 1280
  9237. although the fixed width of the main contents of those websites is
  9238. less than 1000, which results in adding the paddings.
  9239. To fix this, we need to get back to the default max layout size
  9240. 1024 * 768, which will make the main contents of those popular websites
  9241. take full advantage of the screen real estate and look much better.
  9242. Internally reviewed by Adam Treat.
  9243. * Api/WebPage.cpp:
  9244. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  9245. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  9246. * Api/WebPage_p.h:
  9247. (WebPagePrivate):
  9248. * WebKitSupport/RenderQueue.cpp:
  9249. (BlackBerry::WebKit::RenderQueue::splittingFactor):
  9250. 2012-08-22 Crystal Zhang <haizhang@rim.com>
  9251. [BlackBerry] Make all pickers non-zoomable
  9252. https://bugs.webkit.org/show_bug.cgi?id=94729
  9253. Reviewed by Antonio Gomes.
  9254. Move HTML header initialization to PagePopupBlackBerry as that part are all the same, and make all pickers non-zoomable.
  9255. * Api/WebPage.cpp:
  9256. (BlackBerry::WebKit::WebPagePrivate::screenSize):
  9257. (WebKit):
  9258. * Api/WebPage_p.h:
  9259. (WebPagePrivate):
  9260. * WebCoreSupport/DatePickerClient.cpp:
  9261. (WebCore::DatePickerClient::generateHTML):
  9262. (WebCore::DatePickerClient::writeDocument):
  9263. * WebCoreSupport/PagePopupBlackBerry.cpp:
  9264. (WebCore::PagePopupBlackBerry::init):
  9265. (WebCore::PagePopupBlackBerry::generateHTML):
  9266. (WebCore):
  9267. * WebCoreSupport/PagePopupBlackBerry.h:
  9268. (PagePopupBlackBerry):
  9269. * WebCoreSupport/SelectPopupClient.cpp:
  9270. (WebCore::SelectPopupClient::generateHTML):
  9271. (WebCore::SelectPopupClient::writeDocument):
  9272. 2012-08-21 Benjamin C Meyer <bmeyer@rim.com>
  9273. [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
  9274. https://bugs.webkit.org/show_bug.cgi?id=94621
  9275. Reviewed by Yong Li.
  9276. * Api/WebPage.cpp:
  9277. (BlackBerry::WebKit::WebPage::enableQnxJavaScriptObject):
  9278. (WebKit):
  9279. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  9280. * Api/WebPage.h:
  9281. * Api/WebPage_p.h:
  9282. (WebPagePrivate):
  9283. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  9284. (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
  9285. 2012-08-21 Robin Cao <robin.cao@torchmobile.com.cn>
  9286. [BlackBerry] Add support for getUserMedia
  9287. https://bugs.webkit.org/show_bug.cgi?id=94591
  9288. Reviewed by George Staikos.
  9289. Implement getUserMedia feature using the platform API.
  9290. PR #153571
  9291. Reviewed internally by George Staikos.
  9292. * WebCoreSupport/UserMediaClientImpl.cpp:
  9293. (WebCore):
  9294. (WebCore::userMediaRequestsMap):
  9295. (WebCore::toMediaStreamSource):
  9296. (WebCore::toMediaStreamDescriptor):
  9297. (WebUserMediaRequestClientImpl):
  9298. (WebCore::WebUserMediaRequestClientImpl::WebUserMediaRequestClientImpl):
  9299. (WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
  9300. (WebCore::WebUserMediaRequestClientImpl::requestFailed):
  9301. (WebCore::UserMediaClientImpl::UserMediaClientImpl):
  9302. (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
  9303. (WebCore::UserMediaClientImpl::requestUserMedia):
  9304. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  9305. (WebCore::UserMediaClientImpl::webUserMedia):
  9306. * WebCoreSupport/UserMediaClientImpl.h:
  9307. (BlackBerry):
  9308. (Platform):
  9309. (UserMediaClientImpl):
  9310. 2012-08-21 Kihong Kwon <kihong.kwon@samsung.com>
  9311. [EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
  9312. https://bugs.webkit.org/show_bug.cgi?id=94586
  9313. Reviewed by Kentaro Hara.
  9314. Fix build error in the DeviceOrientationClientBlackBerry.cpp.
  9315. It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
  9316. * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
  9317. (DeviceOrientationClientBlackBerry::lastOrientation):
  9318. 2012-08-21 Jacky Jiang <zhajiang@rim.com>
  9319. [BlackBerry] about:memory and about:memory-live should show numbers for the chrome process
  9320. https://bugs.webkit.org/show_bug.cgi?id=94531
  9321. Reviewed by Rob Buis.
  9322. Patch by Jacky Jiang <zhajiang@rim.com>
  9323. PR: 190504
  9324. Add total committed memory of chrome process into about:memory and add
  9325. its peak into about:memory-live.
  9326. Internally reviewed by Yong Li and George Staikos.
  9327. * WebKitSupport/AboutData.cpp:
  9328. (BlackBerry::WebKit::memoryPage):
  9329. (BlackBerry::WebKit::MemoryTracker::clear):
  9330. (MemoryTracker):
  9331. (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfCurrentProcess):
  9332. (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfChromeProcess):
  9333. (BlackBerry::WebKit::MemoryTracker::MemoryTracker):
  9334. (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
  9335. (BlackBerry::WebKit::memoryPeaksToHtmlTable):
  9336. 2012-08-21 Antonio Gomes <agomes@rim.com>
  9337. [BlackBerry] Accelerated In-Region Scrolling does not render correctly on rotation
  9338. https://bugs.webkit.org/show_bug.cgi?id=94608
  9339. PR #194754
  9340. Reviewed by Goerge Staikos.
  9341. When one translates/scrolls a HW accelerated scrollable layer, it makes use of
  9342. the OVERRIDE mechanism. Suppose the following scenario:
  9343. - In landscape, the overflow menu is scrollable. Then the user scrolls it so
  9344. that is has scroll position of 0, -100.
  9345. - when he rotates to portrait, the menus fit well to the available space but it
  9346. still has the OVERRIDE set, so it keeps the layer translated at 0, -100.
  9347. Fix is simple: clear the override when we stop scrolling a HW accelerated layer,
  9348. when we destroy the objects.
  9349. * WebKitSupport/InRegionScrollableArea.cpp:
  9350. (BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea):
  9351. 2012-08-21 Antonio Gomes <agomes@rim.com>
  9352. [BlackBerry] Properly notify WebKit when Client stops in-region scrolling
  9353. https://bugs.webkit.org/show_bug.cgi?id=94603
  9354. PR #195813
  9355. Reviewed by Goerge Staikos.
  9356. Simplify the API to get a notification of when a in-region
  9357. scrolling has finished.
  9358. * Api/WebPage.cpp:
  9359. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
  9360. Removed an unneeded parameter.
  9361. (BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
  9362. Ditto.
  9363. * Api/WebPage.h:
  9364. * Api/WebPage_p.h:
  9365. (WebPagePrivate):
  9366. 2012-08-20 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  9367. [BlackBerry] Select popup shows blank content when its option tags contain '\' characters
  9368. https://bugs.webkit.org/show_bug.cgi?id=94321
  9369. Reviewed by George Staikos.
  9370. PR 194224
  9371. When the SelectPopupClient generates HTML, if there is a character '\' in the select options'
  9372. description, we should escape it to avoid the character being interpreted as an escape character.
  9373. * WebCoreSupport/SelectPopupClient.cpp:
  9374. (WebCore::SelectPopupClient::generateHTML):
  9375. 2012-08-20 Genevieve Mak <gmak@rim.com>
  9376. [BLACKBERRY] Add notification if an element does not have touch move or mouse move handlers.
  9377. https://bugs.webkit.org/show_bug.cgi?id=94529
  9378. Reviewed by George Staikos.
  9379. Send a notification to the client if the fat finger element does
  9380. not have a mouse move or touch move handler or if it is empty.
  9381. PR #177701
  9382. Reviewed Internally By Mike Lattanzio and Antonio Gomes.
  9383. * Api/WebPageClient.h:
  9384. * WebKitSupport/TouchEventHandler.cpp:
  9385. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  9386. 2012-08-17 Antonio Gomes <agomes@rim.com>
  9387. [BlackBerry] Allow in-region accelerated scrolling take advantage of defer_blits
  9388. https://bugs.webkit.org/show_bug.cgi?id=94379
  9389. PR #194595
  9390. Reviewed by Yong Li.
  9391. Client does the blitting now.
  9392. * Api/InRegionScroller.cpp:
  9393. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
  9394. 2012-08-17 Jacky Jiang <zhajiang@rim.com>
  9395. [BlackBerry] On reload, www.sohu.com renders part white background, part overscroll pattern
  9396. https://bugs.webkit.org/show_bug.cgi?id=94348
  9397. Reviewed by Yong Li.
  9398. Jacky Jiang <zhajiang@rim.com>
  9399. PR: 179200
  9400. This can fix the reload issues of sohu.com, yahoo.com and
  9401. thestar.com/iphone(PR158041). And it is also related with PR178305.
  9402. Internally reviewed by George Staikos.
  9403. * Api/WebPage.cpp:
  9404. (BlackBerry::WebKit::WebPagePrivate::setLoadState): Keeping scales for
  9405. reload was doing more harm than good. Two reasons to remove this:
  9406. (1) During reload, contents rect is changing due to layout updates,
  9407. it is possible that the contents or the white background can't cover
  9408. the whole screen if we are using the previous scales.
  9409. (2) Before reload, the source of the web page can be changed, therefore
  9410. previous scales won't be valid anymore.
  9411. Remove shouldRestoreViewState() as this check here is useless now.
  9412. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad): During
  9413. reload, we should give it a chance to zoom to fit the screen,
  9414. otherwise, it happens that the contents can't cover the whole screen
  9415. until we restore the view state, see PR158041.
  9416. Remove shouldRestoreViewState() as the error page issue PR178305 can be
  9417. covered by reload now.
  9418. * WebCoreSupport/FrameLoaderClientBlackBerry.h: Remove unused shouldRestoreViewState().
  9419. 2012-08-16 Mike Fenton <mifenton@rim.com>
  9420. [BlackBerry] Use form state to determine the VKB enter key.
  9421. https://bugs.webkit.org/show_bug.cgi?id=94239
  9422. Reviewed by Rob Buis.
  9423. PR 188234.
  9424. If the enter key for the VKB is not explicitly set, use
  9425. submit if we are in a single line input and a default
  9426. button exists for the form.
  9427. Reviewed Internally by Gen Mak.
  9428. * WebKitSupport/InputHandler.cpp:
  9429. (BlackBerry::WebKit::InputHandler::setElementFocused):
  9430. 2012-08-16 Konrad Piascik <kpiascik@rim.com>
  9431. [BlackBerry] Reload valid page from Error Page keeps history ViewState and zoom.
  9432. https://bugs.webkit.org/show_bug.cgi?id=94123
  9433. Reviewed by Antonio Gomes.
  9434. Reviewed internally by Leo Yang, Jacky Jiang.
  9435. PR 178305
  9436. * Api/WebPage.cpp:
  9437. (BlackBerry::WebKit::WebPagePrivate::setLoadState):Reset the scales and
  9438. the user scalable flag if we're reloading from an error page.
  9439. (BlackBerry::WebKit::WebPagePrivate::updateViewportSize): Don't update the
  9440. viewport size if we're still in the WebPagePrivate::init method.
  9441. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  9442. Properly set the shouldZoom flag if we're not going to restore the
  9443. view state.
  9444. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  9445. (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
  9446. (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad): Set the
  9447. ViewState's shouldSaveViewState flag if we're coming from an error page.
  9448. (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem): Set the
  9449. new member variable m_shouldRestoreViewState based on the ViewState's
  9450. shouldSaveViewState flag.
  9451. (WebCore::FrameLoaderClientBlackBerry::restoreViewState): Added early
  9452. return if m_shouldRestoreViewState is false.
  9453. * WebCoreSupport/FrameLoaderClientBlackBerry.h: Add new method to have
  9454. the client track whether we should restore the view state.
  9455. (WebCore::FrameLoaderClientBlackBerry::shouldRestoreViewState):
  9456. (FrameLoaderClientBlackBerry):
  9457. 2012-08-16 Leo Yang <leoyang@rim.com>
  9458. [BlackBerry] Remove Mobile mode from WebPage.cpp and WebPage_p.h
  9459. https://bugs.webkit.org/show_bug.cgi?id=94223
  9460. PR #192773
  9461. Reviewed by Rob Buis.
  9462. Reviewed internally by Arvid Nilsson.
  9463. Remove Mobile mode as it's not been used. Also remove code that
  9464. handle top-level SVG document because now we can handle it in Desktop mode.
  9465. * Api/WebPage.cpp:
  9466. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  9467. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  9468. * Api/WebPage_p.h:
  9469. 2012-08-16 Arvid Nilsson <anilsson@rim.com>
  9470. [BlackBerry] SurfacePool::waitForBuffer() sometimes waits for deleted EGLSyncKHR object
  9471. https://bugs.webkit.org/show_bug.cgi?id=94208
  9472. Reviewed by Rob Buis.
  9473. SurfacePool::notifyBuffersComposited() adds a tile's previous
  9474. sync object to the garbage list before replacing it with a new one.
  9475. However, it failed to thoroughly clear all tiles that were referencing
  9476. the old sync object.
  9477. Thus it could happen that if a set of tiles A was composited, then
  9478. another set of tiles B was composited, only the intersection of A and B
  9479. was cleared of the soon-to-be-deleted sync object, and the subtraction
  9480. A - B would reference an invalid sync object in case the BackingStore
  9481. decided to render to one of the tiles in A - B before they were
  9482. composited again.
  9483. Fixed by storing each individual sync object in only one place so we
  9484. don't have to rummage through all tiles and remove stale references to
  9485. sync objects that are about to be destroyed.
  9486. A new reference counted Fence class is added for this purpose, to store
  9487. a sync object. Tiles refer to Fence instances instead of holding a sync
  9488. object directly. Since Fence is reference counted, several tiles can
  9489. refer to the same Fence instance, and clearing its sync object will
  9490. instantly remove it from the grasp of all tiles that depend on that
  9491. Fence.
  9492. Since there's no point in waiting for the same Fence twice, the only
  9493. operation provided on Fence is takePlatformSync() which returns the
  9494. sync object and clears the Fence of its sync object.
  9495. Reviewed internally by Filip Spacek.
  9496. PR 193610
  9497. * WebKitSupport/BackingStoreTile.cpp:
  9498. (BlackBerry::WebKit::TileBuffer::TileBuffer):
  9499. * WebKitSupport/BackingStoreTile.h:
  9500. (BlackBerry):
  9501. (Fence):
  9502. (BlackBerry::Fence::create):
  9503. (BlackBerry::Fence::takePlatformSync):
  9504. (BlackBerry::Fence::Fence):
  9505. (BlackBerry::WebKit::TileBuffer::fence):
  9506. (BlackBerry::WebKit::TileBuffer::setFence):
  9507. (TileBuffer):
  9508. * WebKitSupport/SurfacePool.cpp:
  9509. (BlackBerry::WebKit::SurfacePool::waitForBuffer):
  9510. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  9511. * WebKitSupport/SurfacePool.h:
  9512. (SurfacePool):
  9513. 2012-08-16 Rob Buis <rbuis@rim.com>
  9514. [BlackBerry] Suppress non DRT JS Console output.
  9515. https://bugs.webkit.org/show_bug.cgi?id=94058
  9516. Reviewed by Yong Li.
  9517. Reviewed internally by Ming Xie.
  9518. Some actual test results show JS Console showing up twice, for
  9519. instance traversal/moz-bug559526.html. Only print the DRT specific
  9520. Console message.
  9521. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  9522. (WebCore::ChromeClientBlackBerry::addMessageToConsole):
  9523. 2012-08-16 Arvid Nilsson <anilsson@rim.com>
  9524. [BlackBerry] WebGL and Canvas fail to display after being restored from page cache
  9525. https://bugs.webkit.org/show_bug.cgi?id=94105
  9526. Reviewed by George Staikos.
  9527. The EGLImage was being destroyed when releasing layer resources on the
  9528. compositing thread, but the WebKit thread layer never found out and
  9529. failed to create a new image.
  9530. Fixed by extending the release layer resources mechanism to also make a
  9531. pass on the WebKit thread so that thread's layers have a chance to
  9532. delete their textures and related resources.
  9533. Reviewed internally by Filip Spacek.
  9534. PR 192899
  9535. * Api/WebPage.cpp:
  9536. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  9537. (BlackBerry::WebKit::WebPagePrivate::releaseLayerResources):
  9538. (WebKit):
  9539. (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
  9540. (BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
  9541. * Api/WebPage_p.h:
  9542. (WebPagePrivate):
  9543. * WebKitSupport/FrameLayers.cpp:
  9544. (BlackBerry::WebKit::FrameLayers::releaseLayerResources):
  9545. (WebKit):
  9546. * WebKitSupport/FrameLayers.h:
  9547. (FrameLayers):
  9548. 2012-08-16 Pierre Rossi <pierre.rossi@gmail.com>
  9549. [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
  9550. https://bugs.webkit.org/show_bug.cgi?id=93960
  9551. Reviewed by Simon Hausmann.
  9552. Following the removal of Qt 4 support from trunk in r124879.
  9553. * WebCoreSupport/AboutDataHaveFeatures.in: Remove all traces of HAVE_QRAWFONT's existence.
  9554. 2012-08-15 Benjamin C Meyer <bmeyer@rim.com>
  9555. [BlackBerry] When there is an exception we want to check if the ref is 0, not the
  9556. value as JSObjectCallAsFunction returns 0 in that case.
  9557. https://bugs.webkit.org/show_bug.cgi?id=94153
  9558. Reviewed by Yong Li.
  9559. * Api/WebPage.cpp:
  9560. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  9561. 2012-08-15 Yong Li <yoli@rim.com>
  9562. [BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
  9563. https://bugs.webkit.org/show_bug.cgi?id=94139
  9564. Reviewed by Antonio Gomes.
  9565. Keep same security origin when a file URL automatically redirects to its child folder.
  9566. This patch will be reverted when we finish the better solution.
  9567. PR# 172333 and PR# 180590.
  9568. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  9569. (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
  9570. (WebCore::FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad):
  9571. (WebCore::FrameLoaderClientBlackBerry::securityOriginForNewDocument):
  9572. (WebCore):
  9573. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  9574. (FrameLoaderClientBlackBerry):
  9575. 2012-08-15 Yong Li <yoli@rim.com>
  9576. [BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
  9577. https://bugs.webkit.org/show_bug.cgi?id=94136
  9578. Reviewed by Rob Buis.
  9579. Internally reviewed by Lyon Chen.
  9580. PR# 192401.
  9581. 1. The prototype of GeoTracker::create() has changed.
  9582. 2. Fix the issue that it could recreate tracker unnecessarily when
  9583. setEnableHighAccuracy() is called but accuracy requirment hasn't
  9584. changed.
  9585. 3. Fix the issue setEnableHighAccuracy() could start tracking when
  9586. tracker was suspended.
  9587. * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
  9588. (GeolocationControllerClientBlackBerry::startUpdating):
  9589. (GeolocationControllerClientBlackBerry::setEnableHighAccuracy):
  9590. 2012-08-15 Mike Fenton <mifenton@rim.com>
  9591. [BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input.
  9592. https://bugs.webkit.org/show_bug.cgi?id=94132
  9593. Reviewed by Rob Buis.
  9594. PR 139838.
  9595. Switch direct key input handling to be based on the unconverted
  9596. attribute being present. Converted keys, even during composition
  9597. are now input directly.
  9598. Reviewed Internally by Nima Ghanavatian.
  9599. * WebKitSupport/InputHandler.cpp:
  9600. (BlackBerry::WebKit::InputHandler::setText):
  9601. 2012-08-15 Joshua Netterfield <jnetterfield@rim.com>
  9602. [BlackBerry] Upstream BlackBerry build fixes
  9603. https://bugs.webkit.org/show_bug.cgi?id=94121
  9604. Reviewed by Rob Buis.
  9605. This includes several build fixes due to incorrect upstream patches.
  9606. These mistakes were never present downstream.
  9607. No new tests, because no new functionality is added.
  9608. * WebCoreSupport/AboutDataEnableFeatures.in:
  9609. * WebCoreSupport/AboutTemplate.html.cpp:
  9610. (writeHeader):
  9611. 2012-08-15 Leo Yang <leoyang@rim.com>
  9612. [BlackBerry] Use nested layout when rotating
  9613. https://bugs.webkit.org/show_bug.cgi?id=94117
  9614. Partially patched by Arvid Nilsson.
  9615. Reviewed by George Staikos.
  9616. Reviewed internally by Arvid Nilsson.
  9617. When rotating the content width used for fixedLayoutSize is not
  9618. correct because we are changing the rotation and the content with
  9619. should be determined after layout. So we set the with to 0 if we
  9620. are rotating and beginning the nested layout. And in setViewportSize
  9621. we need a nested layout loop to trigger zoom-to-fit.
  9622. * Api/WebPage.cpp:
  9623. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  9624. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  9625. 2012-08-14 Antonio Gomes <agomes@rim.com>
  9626. [BlackBerry] Stop copying ScrollViewBase vector all over
  9627. https://bugs.webkit.org/show_bug.cgi?id=94021
  9628. Reviewed by Rob Buis.
  9629. It outlives long enough in WebKit that we can
  9630. just pass a const+ref of it.
  9631. Internally reviewed by Gen Mak.
  9632. * Api/WebPageClient.h:
  9633. 2012-08-14 Antonio Gomes <agomes@rim.com>
  9634. [BlackBerry] Robust-fy the LayerWebKitThread ownership with InRegionScroller
  9635. https://bugs.webkit.org/show_bug.cgi?id=93983
  9636. PR #191737
  9637. Reviewed by Yong Li.
  9638. Patch changes the way we currently keep track of the active scrollable area
  9639. objects: before, we acquired the scrollable areas and just passed them in a vector up
  9640. to the client, copying it over and over again. Also, it was a client responsability to
  9641. delete stuff (BAD!).
  9642. Now, we keep track of vector within InRegionScroller, as a class member, which allows us to
  9643. avoid copies (in follow up patch), and control until when these objects outlive.
  9644. Patch also changes InRegionScrollableArea to "retptr" the composited layer
  9645. associated to it (if any). This ensure we have a non-null scrollable element always.
  9646. As mentioned, InRegionScroller is now responsible for deleting and vector of scrollable areas.
  9647. Internally reviewed by Arvid Nilsson.
  9648. * Api/InRegionScroller.cpp:
  9649. (WebKit):
  9650. (BlackBerry::WebKit::InRegionScrollerPrivate::reset): Method is now responsible for
  9651. deleting the tracked scrollable areas.
  9652. (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
  9653. Renamed from 'inRegionScrollableAreasForPoint'. It was changed in order to store the
  9654. scrollable area objects instead of just pass a copy of them up to the client.
  9655. (BlackBerry::WebKit::InRegionScrollerPrivate::activeInRegionScrollableAreas): Getter.
  9656. (BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): It was
  9657. promoted to a class method instead of a local helper.
  9658. * Api/InRegionScroller_p.h:
  9659. (WebKit):
  9660. (InRegionScrollerPrivate):
  9661. * Api/WebPage.cpp:
  9662. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint): Adjustments needed due to the
  9663. above changed.
  9664. * WebKitSupport/InRegionScrollableArea.cpp:
  9665. (BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea): Clear up the cached layer.
  9666. (WebKit):
  9667. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  9668. * WebKitSupport/InRegionScrollableArea.h:
  9669. (InRegionScrollableArea):
  9670. 2012-08-15 Nima Ghanavatian <nghanavatian@rim.com>
  9671. [BlackBerry] Check for valid field focus before processing a spellcheck request
  9672. https://bugs.webkit.org/show_bug.cgi?id=94115
  9673. Reviewed by Rob Buis.
  9674. PR192891
  9675. Checking for valid field focus before processing the spellcheck
  9676. request.
  9677. Internally reviewed by Mike Fenton.
  9678. * WebKitSupport/InputHandler.cpp:
  9679. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  9680. 2012-08-14 Adam Barth <abarth@webkit.org>
  9681. Delete Frame::domWindow() and Frame::existingDOMWindow()
  9682. https://bugs.webkit.org/show_bug.cgi?id=93990
  9683. Reviewed by Eric Seidel.
  9684. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  9685. (WebCore::toOriginString):
  9686. (WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
  9687. (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
  9688. (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
  9689. (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
  9690. (WebCore::ChromeClientBlackBerry::requestWebGLPermission):
  9691. 2012-08-14 Leo Yang <leoyang@rim.com>
  9692. [BlackBerry] Checkerboard flashes on Go Back
  9693. https://bugs.webkit.org/show_bug.cgi?id=94018
  9694. Reviewed by Yong Li.
  9695. Reviewed internally by Yong Li.
  9696. The backing store need to be suspended before the
  9697. WebPagePrivate::restoreHistoryViewState() is called to avoid UI thread
  9698. drawing checkerboard.
  9699. * Api/WebPage.cpp:
  9700. (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
  9701. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  9702. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  9703. 2012-08-14 Mike Fenton <mifenton@rim.com>
  9704. [BlackBerry] Remove unnecessary \n's from InputHandler log messages.
  9705. https://bugs.webkit.org/show_bug.cgi?id=94015
  9706. Reviewed by Rob Buis.
  9707. Remove many unnecessary \n's from the end of log messages.
  9708. Reviewed Internally by Nima Ghanavatian.
  9709. * WebKitSupport/InputHandler.cpp:
  9710. (BlackBerry::WebKit::convertStringToWcharVector):
  9711. (BlackBerry::WebKit::convertSpannableStringToString):
  9712. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  9713. (BlackBerry::WebKit::InputHandler::setText):
  9714. (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
  9715. 2012-08-14 Nima Ghanavatian <nghanavatian@rim.com>
  9716. [BlackBerry] Queue spellcheck requests with char-count limitations
  9717. https://bugs.webkit.org/show_bug.cgi?id=93866
  9718. Reviewed by Rob Buis.
  9719. PR184196
  9720. Making spellcheck a little more granular so as to work around
  9721. the limitations of the inputservice.
  9722. Also, spellcheck the entire field on focus only if
  9723. spellcheck="on" is explicitly set.
  9724. Internally reviewed by Mike Fenton.
  9725. * WebKitSupport/InputHandler.cpp:
  9726. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  9727. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  9728. 2012-08-14 Mike Fenton <mifenton@rim.com>
  9729. [BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
  9730. https://bugs.webkit.org/show_bug.cgi?id=93992
  9731. Reviewed by Antonio Gomes.
  9732. Use form control helper functions to determine the editable state
  9733. of the input field.
  9734. * WebKitSupport/DOMSupport.cpp:
  9735. (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
  9736. 2012-08-14 Mike Fenton <mifenton@rim.com>
  9737. [BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
  9738. https://bugs.webkit.org/show_bug.cgi?id=93988
  9739. Reviewed by Antonio Gomes.
  9740. Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
  9741. * WebKitSupport/TouchEventHandler.cpp:
  9742. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  9743. 2012-08-14 Mike Fenton <mifenton@rim.com>
  9744. [BlackBerry] Fix use of endsWith to use string instead of char.
  9745. https://bugs.webkit.org/show_bug.cgi?id=93994
  9746. Reviewed by Antonio Gomes.
  9747. Regex comparison should use string instead of char comparison.
  9748. * WebKitSupport/DOMSupport.cpp:
  9749. (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
  9750. 2012-08-14 Jacky Jiang <zhajiang@rim.com>
  9751. [BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
  9752. https://bugs.webkit.org/show_bug.cgi?id=93895
  9753. Reviewed by Antonio Gomes.
  9754. Patch by Jacky Jiang <zhajiang@rim.com>
  9755. PR: 188232
  9756. When adjusting block zoom node, don't choose a node if the width of the
  9757. node size is very close to the width of the actual visible size as
  9758. block zoom can do nothing on such kind of node. This condition is more
  9759. restrictive than the one based on area and can bail out early.
  9760. In this way, we can get a better node for double-tap zoom.
  9761. * Api/WebPage.cpp:
  9762. (BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
  9763. (BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
  9764. * Api/WebPage_p.h:
  9765. (WebPagePrivate):
  9766. 2012-08-14 Konrad Piascik <kpiascik@rim.com>
  9767. [BlackBerry] Change the call to setUserScalable to use the setting.
  9768. https://bugs.webkit.org/show_bug.cgi?id=93974
  9769. Reviewed by Rob Buis.
  9770. We should be using the WebSetting and not the current value of m_userScalable.
  9771. * Api/WebPage.cpp:
  9772. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  9773. 2012-08-14 Charles Wei <charles.wei@torchmobile.com.cn>
  9774. [BlackBerry] Some callback of Select onchange doesn't work
  9775. https://bugs.webkit.org/show_bug.cgi?id=93944
  9776. Reviewed by George Staikos.
  9777. The Selection element is implemented with PagePopup, an HTML-based WebView with
  9778. some Javascripts to make the UI of the select and option lists; The selection
  9779. change is initiated from the javascript code in the Select Webview, and back to
  9780. the native code of SelectPopupClient, which now in turn dispatches
  9781. FormControlChangeEvent to the select element directly, and that causes the
  9782. javascript callback been invoked in the same cycle as the javascript in the
  9783. Popup View, and causes some Javascript Context problem.
  9784. The solution is to send the FormControlChangeEvent asynchronously by a timer,
  9785. when the JavaScript in the Popup view finishes execution, we then send the
  9786. FormControlChangeEvent to the select element in the content page, that avoids
  9787. the concurrent Javascript context issue.
  9788. * WebCoreSupport/SelectPopupClient.cpp:
  9789. (WebCore::SelectPopupClient::SelectPopupClient):
  9790. (WebCore::SelectPopupClient::setValueAndClosePopup):
  9791. (WebCore):
  9792. (WebCore::SelectPopupClient::notifySelectionChange):
  9793. * WebCoreSupport/SelectPopupClient.h:
  9794. (SelectPopupClient):
  9795. 2012-08-14 Arvid Nilsson <anilsson@rim.com>
  9796. [BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
  9797. https://bugs.webkit.org/show_bug.cgi?id=93614
  9798. Reviewed by Antonio Gomes.
  9799. We used to set up resource sharing between the compositing thread
  9800. context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
  9801. get a copy of the framebuffer to use as front buffer for compositing
  9802. purposes.
  9803. Now we instead create an EGLImage and blit the Canvas/WebGL output to
  9804. it. The compositing thread creates a texture from the EGLImage in order
  9805. to composite the output.
  9806. This allows us to turn off resource sharing, so the WebPageCompositor
  9807. no longer needs to pass the compositing thread context to the webkit
  9808. thread.
  9809. Reviewed internally by Filip Spacek.
  9810. PR 188472
  9811. * Api/WebPage.cpp:
  9812. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  9813. (BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
  9814. * Api/WebPageCompositor.cpp:
  9815. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  9816. (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
  9817. * Api/WebPage_p.h:
  9818. (WebPagePrivate):
  9819. 2012-08-14 Charles Wei <charles.wei@torchmobile.com.cn>
  9820. [BlackBerry] Enable DNS prefetch
  9821. https://bugs.webkit.org/show_bug.cgi?id=93846
  9822. Reviewed by George Staikos.
  9823. * Api/WebPage.cpp:
  9824. (BlackBerry::WebKit::WebPagePrivate::init):
  9825. 2012-08-13 Tom Sepez <tsepez@chromium.org>
  9826. [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
  9827. https://bugs.webkit.org/show_bug.cgi?id=93283
  9828. Reviewed by Eric Seidel.
  9829. Change the client redirectDataToPlugin method(s) to expect the possibility of
  9830. a NULL argument, keeping existing behaviour otherwise.
  9831. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  9832. (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
  9833. 2012-08-13 Mike Fenton <mifenton@rim.com>
  9834. [BlackBerry] Update API for spell checking suggestions again.
  9835. https://bugs.webkit.org/show_bug.cgi?id=93877
  9836. Reviewed by Antonio Gomes.
  9837. PR 163283.
  9838. Update the spell checking options request API
  9839. to include the caret positions.
  9840. Reviewed internally by Nima Ghanavatian.
  9841. * Api/WebPageClient.h:
  9842. * WebKitSupport/InputHandler.cpp:
  9843. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  9844. (WebKit):
  9845. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  9846. * WebKitSupport/InputHandler.h:
  9847. (Platform):
  9848. (InputHandler):
  9849. * WebKitSupport/TouchEventHandler.cpp:
  9850. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  9851. * WebKitSupport/TouchEventHandler.h:
  9852. (TouchEventHandler):
  9853. 2012-08-13 Antonio Gomes <agomes@rim.com>
  9854. [BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
  9855. https://bugs.webkit.org/show_bug.cgi?id=93848
  9856. PR #190986
  9857. Reviewed by Yong Li.
  9858. Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
  9859. It fixes a mismatch we had of setting a layer's scroll positing directly via
  9860. ::setScrollPosition on the UI thread, but dispatching a coalesceable
  9861. scrollBy(delta) message to WebKit thread.
  9862. * Api/InRegionScroller.cpp:
  9863. (BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
  9864. Changed the API name to match other thread specific methods naming.
  9865. (WebKit):
  9866. (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
  9867. Added a setScrollPosition-like method to InRegionScroller public API. Used
  9868. together with its UI-thread counterpart, it can fix some rounding
  9869. errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
  9870. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
  9871. Method renamed. See reasons above.
  9872. (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
  9873. Calls fowards the call to ::setLayerScrollPosition (below).
  9874. (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
  9875. Sets the scroll position of a given RenderLayer.
  9876. * Api/InRegionScroller.h:
  9877. (InRegionScroller):
  9878. * Api/InRegionScroller_p.h:
  9879. (WebCore):
  9880. (InRegionScrollerPrivate):
  9881. * WebKitSupport/InRegionScrollableArea.cpp:
  9882. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  9883. Cache the RenderLayer object associated to a given scrollable area
  9884. instead of its LayerCompositingThread. This way we can use it for
  9885. scrolling from both Compositing/UI and WebKit threads.
  9886. 2012-08-12 Arvid Nilsson <anilsson@rim.com>
  9887. [BlackBerry] Tap highlight flashes checkerboard after pinch zoom
  9888. https://bugs.webkit.org/show_bug.cgi?id=93601
  9889. Reviewed by Antonio Gomes.
  9890. Since the tap highlight is usually rather small, we can reimplement
  9891. GraphicsLayerClient::contentsVisible() to always return true in order
  9892. to keep all AC layer tiles cached all the time.
  9893. PR 189895
  9894. * WebKitSupport/DefaultTapHighlight.cpp:
  9895. (BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
  9896. (WebKit):
  9897. * WebKitSupport/DefaultTapHighlight.h:
  9898. (DefaultTapHighlight):
  9899. 2012-08-12 Arvid Nilsson <anilsson@rim.com>
  9900. [BlackBerry] Tap highlight sometimes doesn't disappear
  9901. https://bugs.webkit.org/show_bug.cgi?id=93711
  9902. Reviewed by Antonio Gomes.
  9903. The WebOverlayOverride implementation just changes properties of a
  9904. LayerCompositingThread directly, which means the changes will
  9905. immediately be overwritten on the next commit. Therefore, when the tap
  9906. highlight implementation adds a fade out animation, that animation will
  9907. instantly be removed again if a commit happens for any reason.
  9908. The reason is I totally botched the implementation of
  9909. WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
  9910. instead for some reason it's manipulating the LayerCompositingThread
  9911. directly.
  9912. Fixed by actually mapping WebOverlayOverride calls to the corresponding
  9913. WebCore::LayerOverride method, and scheduling a compositing run to make
  9914. the change visible and kick off animations.
  9915. Reviewed internally by Sean Wang.
  9916. PR 188453
  9917. * Api/WebOverlay.cpp:
  9918. (BlackBerry::WebKit::WebOverlayPrivate::override):
  9919. * Api/WebOverlayOverride.cpp:
  9920. (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
  9921. (BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
  9922. (BlackBerry::WebKit::WebOverlayOverride::setPosition):
  9923. (BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
  9924. (BlackBerry::WebKit::WebOverlayOverride::setSize):
  9925. (BlackBerry::WebKit::WebOverlayOverride::setTransform):
  9926. (BlackBerry::WebKit::WebOverlayOverride::setOpacity):
  9927. (BlackBerry::WebKit::WebOverlayOverride::addAnimation):
  9928. (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
  9929. * Api/WebOverlayOverride.h:
  9930. * Api/WebOverlay_p.h:
  9931. (WebOverlayPrivate):
  9932. (WebOverlayPrivateWebKitThread):
  9933. (WebOverlayPrivateCompositingThread):
  9934. 2012-08-10 Benjamin C Meyer <bmeyer@rim.com>
  9935. Introduce JavaScriptVariant object.
  9936. https://bugs.webkit.org/show_bug.cgi?id=93644
  9937. The JavaScriptVariant can be used for functions that return results from
  9938. JavaScript such as executeJavaScript or functions that take arguments
  9939. to pass a variable to JavaScript and they want to make sure the type
  9940. is correct.
  9941. Convert executeJavaScriptFunction() to use this data type as the
  9942. example, other functions will be converted in the future.
  9943. PR 14929
  9944. Internally reviewed by Joe Mason
  9945. Reviewed by Adam Treat
  9946. * Api/JavaScriptVariant.cpp: Added.
  9947. (WebKit):
  9948. (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
  9949. (BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
  9950. (BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
  9951. (BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
  9952. (BlackBerry::WebKit::JavaScriptVariant::operator=):
  9953. (BlackBerry::WebKit::JavaScriptVariant::setType):
  9954. (BlackBerry::WebKit::JavaScriptVariant::type):
  9955. (BlackBerry::WebKit::JavaScriptVariant::setDouble):
  9956. (BlackBerry::WebKit::JavaScriptVariant::doubleValue):
  9957. (BlackBerry::WebKit::JavaScriptVariant::setString):
  9958. (BlackBerry::WebKit::JavaScriptVariant::stringValue):
  9959. (BlackBerry::WebKit::JavaScriptVariant::setBoolean):
  9960. (BlackBerry::WebKit::JavaScriptVariant::booleanValue):
  9961. * Api/JavaScriptVariant.h: Added.
  9962. (WebKit):
  9963. * Api/JavaScriptVariant_p.h: Added.
  9964. (WebKit):
  9965. * Api/WebPage.cpp:
  9966. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  9967. * Api/WebPage.h:
  9968. 2012-08-09 Leo Yang <leoyang@rim.com>
  9969. [BlackBerry] Export InRegionScroller to fix build
  9970. https://bugs.webkit.org/show_bug.cgi?id=93635
  9971. Reviewed by Antonio Gomes.
  9972. Build fix.
  9973. * Api/InRegionScroller.h:
  9974. 2012-08-08 Jacky Jiang <zhajiang@rim.com>
  9975. [BlackBerry] Implement about:memory-live
  9976. https://bugs.webkit.org/show_bug.cgi?id=93153
  9977. Reviewed by Yong Li.
  9978. Patch by Jacky Jiang <zhajiang@rim.com>
  9979. Implementing about:memory-live to track memory peaks:
  9980. - about:memory-live/start: start tracking memory peaks.
  9981. - about:memory-live: show memory peaks every 30ms.
  9982. - about:memory-live/stop: stop tracking and show memory peaks.
  9983. Mainly track the following memory peaks:
  9984. - Total used memory (malloc + JSC).
  9985. - Total committed memory.
  9986. - Total mapped memory.
  9987. Add total committed memory for about:memory
  9988. * WebKitSupport/AboutData.cpp:
  9989. (BlackBerry::WebKit::memoryPage):
  9990. (WebKit):
  9991. (MemoryTracker):
  9992. (BlackBerry::WebKit::MemoryTracker::isActive):
  9993. (BlackBerry::WebKit::MemoryTracker::clear):
  9994. (BlackBerry::WebKit::MemoryTracker::peakTotalUsedMemory):
  9995. (BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemory):
  9996. (BlackBerry::WebKit::MemoryTracker::peakTotalMappedMemory):
  9997. (BlackBerry::WebKit::MemoryTracker::MemoryTracker):
  9998. (BlackBerry::WebKit::MemoryTracker::instance):
  9999. (BlackBerry::WebKit::MemoryTracker::start):
  10000. (BlackBerry::WebKit::MemoryTracker::stop):
  10001. (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
  10002. (BlackBerry::WebKit::memoryPeaksToHtmlTable):
  10003. (BlackBerry::WebKit::memoryLivePage):
  10004. (BlackBerry::WebKit::aboutData):
  10005. 2012-08-08 Antonio Gomes <agomes@rim.com>
  10006. [BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable for in-region scroll
  10007. https://bugs.webkit.org/show_bug.cgi?id=93482
  10008. PR #187672
  10009. Make InRegionScroller a simple public webkit/ API
  10010. PR #188677
  10011. Reviewed by Rob Buis.
  10012. In order to prepare InRegionScroller to be a public API
  10013. in webkit/, the patch:
  10014. 1) Renamed the current InRegionScroller class to InRegionScrollerPrivate;
  10015. 2) Moved InRegionScroller.cpp|h from WebKitSupport/ to Api/;
  10016. 3) Renamed InRegionScroller.h to InRegionScroller_p.h;
  10017. 4) Added a new public class implementation to InRegionScroller.h;
  10018. 5) Adapted WebPage and TouchEventHandler classes to use InRegionScroller::d directly.
  10019. The most important API here is '::compositedSetScrollPosition'
  10020. It is a UI/Compositing thread method only and sets the associated LayerCompositingThread
  10021. (camouflaged as a unsigned) for each created InRegionScrollableArea that supports
  10022. composited scrolling.
  10023. The way ::compositedSetScrollPosition "scrolls" a layer is by setting the boundsOrigin
  10024. property to the LayerCompositingThread's 'override' property in the UI/Compositing thread.
  10025. * Api/InRegionScroller.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp.
  10026. (WebKit):
  10027. (BlackBerry::WebKit::InRegionScroller::InRegionScroller):
  10028. (BlackBerry::WebKit::InRegionScroller::~InRegionScroller):
  10029. (BlackBerry::WebKit::InRegionScroller::compositedSetScrollPosition):
  10030. (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
  10031. (BlackBerry::WebKit::InRegionScrollerPrivate::setNode):
  10032. (BlackBerry::WebKit::InRegionScrollerPrivate::node):
  10033. (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
  10034. (BlackBerry::WebKit::InRegionScrollerPrivate::hasNode):
  10035. (BlackBerry::WebKit::InRegionScrollerPrivate::canScroll):
  10036. (BlackBerry::WebKit::InRegionScrollerPrivate::compositedSetScrollPosition):
  10037. (BlackBerry::WebKit::InRegionScrollerPrivate::scrollBy):
  10038. (BlackBerry::WebKit::InRegionScrollerPrivate::inRegionScrollableAreasForPoint):
  10039. (BlackBerry::WebKit::InRegionScrollerPrivate::scrollNodeRecursively):
  10040. (BlackBerry::WebKit::InRegionScrollerPrivate::scrollRenderer):
  10041. (BlackBerry::WebKit::InRegionScrollerPrivate::adjustScrollDelta):
  10042. (BlackBerry::WebKit::canScrollInnerFrame):
  10043. (BlackBerry::WebKit::canScrollRenderBox):
  10044. (BlackBerry::WebKit::parentLayer):
  10045. (BlackBerry::WebKit::enclosingLayerNode):
  10046. (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
  10047. (BlackBerry::WebKit::pushBackInRegionScrollable):
  10048. * Api/InRegionScroller.h: Copied from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
  10049. (WebKit):
  10050. (InRegionScroller):
  10051. * Api/InRegionScroller_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
  10052. (WebCore):
  10053. (WebKit):
  10054. (InRegionScrollerPrivate):
  10055. * Api/WebPage.cpp:
  10056. (BlackBerry::WebKit::WebPagePrivate::scrollBy):
  10057. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
  10058. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
  10059. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
  10060. (BlackBerry::WebKit::WebPage::inRegionScroller):
  10061. (WebKit):
  10062. * Api/WebPage.h:
  10063. (WebKit):
  10064. * WebKitSupport/InRegionScrollableArea.cpp:
  10065. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  10066. * WebKitSupport/TouchEventHandler.cpp:
  10067. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  10068. 2012-08-08 Antonio Gomes <agomes@rim.com>
  10069. [BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
  10070. https://bugs.webkit.org/show_bug.cgi?id=93480
  10071. PR #188682
  10072. Reviewed by Rob Buis.
  10073. ... this way it can be used by others.
  10074. No behavioural change. Another preparation patch.
  10075. * Api/WebOverlay.cpp:
  10076. (BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
  10077. * Api/WebPage.cpp:
  10078. (WebKit):
  10079. (BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
  10080. * Api/WebPage_p.h:
  10081. (WebPagePrivate):
  10082. 2012-08-08 Sheriff Bot <webkit.review.bot@gmail.com>
  10083. Unreviewed, rolling out r124887.
  10084. http://trac.webkit.org/changeset/124887
  10085. https://bugs.webkit.org/show_bug.cgi?id=93504
  10086. Dependent API being removed. (Requested by mfenton on
  10087. #webkit).
  10088. * Api/WebPageClient.h:
  10089. * WebKitSupport/InputHandler.cpp:
  10090. * WebKitSupport/InputHandler.h:
  10091. (InputHandler):
  10092. * WebKitSupport/TouchEventHandler.cpp:
  10093. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  10094. (BlackBerry::WebKit::TouchEventHandler::spellCheck):
  10095. (WebKit):
  10096. * WebKitSupport/TouchEventHandler.h:
  10097. (TouchEventHandler):
  10098. 2012-08-08 Ed Baker <edbaker@rim.com>
  10099. [BlackBerry] Add relayout after updating fixed reported size
  10100. https://bugs.webkit.org/show_bug.cgi?id=93116
  10101. PR #160059
  10102. Reviewed by Antonio Gomes.
  10103. Reviewed internally by Antonio Gomes.
  10104. On an orientation change and after fixed reported size is
  10105. updated perform a layout and update the fixed elements after
  10106. scrolling. This will recalculate the height and width of
  10107. fixed position elements using percentage values with the
  10108. new fixed reported size. Otherwise using the old fixed reported
  10109. size in the new orientation overflowing or clipping could occur.
  10110. * Api/WebPage.cpp:
  10111. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  10112. 2012-08-07 Charles Wei <charles.wei@torchmobile.com.cn>
  10113. [BlackBerry] always set PolicyAction to PolicyIgnore if the chrome returns false for acceptNavigationRequest
  10114. https://bugs.webkit.org/show_bug.cgi?id=93251
  10115. Reviewed by George Staikos.
  10116. In acceptNavigationRequest(), webkit will ask if the chrome will accept the navigation request.
  10117. We will take this chance to see if the request is an internal-webkit protocol, otherwise,
  10118. we will try to launch an external application to handle the request, and ask webkit to ignore
  10119. the request by returning false in acceptNavigationRequest().
  10120. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10121. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  10122. 2012-08-07 Konrad Piascik <kpiascik@rim.com>
  10123. [BlackBerry] Change how devicePixelRatio is set.
  10124. https://bugs.webkit.org/show_bug.cgi?id=93385
  10125. Reviewed by Antonio Gomes.
  10126. Change devicePixelRatio to be set immediately after the page is created based
  10127. on the WebSetting.
  10128. * Api/WebPage.cpp:
  10129. (BlackBerry::WebKit::WebPagePrivate::init):
  10130. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  10131. 2012-08-07 Antonio Gomes <agomes@rim.com>
  10132. [BlackBerry] [FullScreen] No need to scroll 'x' to 0 before entering fullscreen
  10133. https://bugs.webkit.org/show_bug.cgi?id=91750
  10134. PR #178293
  10135. Reviewed by Rob Buis.
  10136. We are not adjusting the 'left' CSS property of the fullscreen wrapper
  10137. properly, so no need to scroll 'x' to 0 anymore.
  10138. Internally reviewed by Jacky Jiang.
  10139. * Api/WebPage.cpp:
  10140. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  10141. 2012-08-07 Antonio Gomes <agomes@rim.com>
  10142. [BlackBerry][FullScreen] Remove the set/reset of touch modes code when entering/leaving fullscreen
  10143. https://bugs.webkit.org/show_bug.cgi?id=92520
  10144. PR #184511
  10145. Reviewed by Yong Li.
  10146. Internally reviewed by Gen Mak.
  10147. Remove touch mode set/reset when entering/leaving fullscreen
  10148. for media elements through the new FULLSCREEN_API code path.
  10149. The client now handles it.
  10150. * Api/WebPage.cpp:
  10151. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  10152. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  10153. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  10154. * Api/WebPage_p.h:
  10155. (WebPagePrivate):
  10156. 2012-08-07 Konrad Piascik <kpiascik@rim.com>
  10157. [BlackBerry] Add missing include in FrameLoaderClienBlackBerry after Base64 moved.
  10158. https://bugs.webkit.org/show_bug.cgi?id=93383
  10159. Reviewed by Rob Buis.
  10160. Base64 moved from platform/text to wtf/text, need to add mssing
  10161. include.
  10162. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10163. 2012-08-07 Konrad Piascik <kpiascik@rim.com>
  10164. [BlackBerry] InspectorOverlay class duplicated in WebCore
  10165. https://bugs.webkit.org/show_bug.cgi?id=93124
  10166. Reviewed by Rob Buis.
  10167. Moved files to better align with namespace names.
  10168. * WebKitSupport/InspectorOverlay.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp.
  10169. (WebKit):
  10170. (BlackBerry::WebKit::InspectorOverlay::create):
  10171. (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
  10172. (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
  10173. (BlackBerry::WebKit::InspectorOverlay::paintContents):
  10174. (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
  10175. (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
  10176. (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
  10177. (BlackBerry::WebKit::InspectorOverlay::clear):
  10178. (BlackBerry::WebKit::InspectorOverlay::update):
  10179. * WebKitSupport/InspectorOverlay.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h.
  10180. (WebCore):
  10181. (WebKit):
  10182. (InspectorOverlay):
  10183. (InspectorOverlayClient):
  10184. (BlackBerry::WebKit::InspectorOverlay::setClient):
  10185. (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
  10186. 2012-08-07 Mike Fenton <mifenton@rim.com>
  10187. [BlackBerry] Update API for spell checking suggestions.
  10188. https://bugs.webkit.org/show_bug.cgi?id=93356
  10189. Reviewed by Antonio Gomes.
  10190. PR 163283.
  10191. Add connections for updated spell checking options request API. Move
  10192. all this logic into InputHandler.
  10193. Reviewed Internally by Gen Mak and Nima Ghanavatian.
  10194. * Api/WebPageClient.h:
  10195. * WebKitSupport/InputHandler.cpp:
  10196. (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
  10197. (WebKit):
  10198. (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
  10199. * WebKitSupport/InputHandler.h:
  10200. (Platform):
  10201. (InputHandler):
  10202. * WebKitSupport/TouchEventHandler.cpp:
  10203. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  10204. * WebKitSupport/TouchEventHandler.h:
  10205. (TouchEventHandler):
  10206. 2012-08-06 Charles Wei <charles.wei@torchmobile.com.cn>
  10207. [BlackBerry] About: shows PAGE_CACHE not enabled.
  10208. https://bugs.webkit.org/show_bug.cgi?id=93216
  10209. Reviewed by Antonio Gomes.
  10210. Page cache is a feature that can be enabled/disabled at runtime, there's no
  10211. MACRO named PAGE_CACHE to control the feature.
  10212. * WebCoreSupport/AboutDataEnableFeatures.in:
  10213. 2012-08-03 Yong Li <yoli@rim.com>
  10214. [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
  10215. https://bugs.webkit.org/show_bug.cgi?id=93141
  10216. Reviewed by Rob Buis.
  10217. PR# 172041.
  10218. It is not always safe to render the page at this point. So we post a message
  10219. instead.
  10220. * Api/WebPage.cpp:
  10221. (WebKit):
  10222. (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
  10223. * Api/WebPage_p.h:
  10224. (WebPagePrivate):
  10225. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10226. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  10227. 2012-08-03 Konrad Piascik <kpiascik@rim.com>
  10228. [BlackBerry] InspectorOverlay class duplicated in WebCore
  10229. https://bugs.webkit.org/show_bug.cgi?id=93124
  10230. Reviewed by Rob Buis.
  10231. Changed namespace of InspectorOverlay from WebCore to
  10232. BlackBerry::WebKit
  10233. * Api/WebPage.cpp:
  10234. (WebKit):
  10235. (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
  10236. * Api/WebPage_p.h:
  10237. (WebPagePrivate):
  10238. * WebCoreSupport/InspectorClientBlackBerry.h:
  10239. * WebCoreSupport/InspectorOverlay.cpp:
  10240. (BlackBerry::WebKit::InspectorOverlay::create):
  10241. (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
  10242. (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
  10243. (BlackBerry::WebKit::InspectorOverlay::paintContents):
  10244. (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
  10245. (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
  10246. (BlackBerry::WebKit::InspectorOverlay::contentsVisible):
  10247. (BlackBerry::WebKit::InspectorOverlay::update):
  10248. * WebCoreSupport/InspectorOverlay.h:
  10249. (WebKit):
  10250. (InspectorOverlayClient):
  10251. (InspectorOverlay):
  10252. (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
  10253. 2012-08-03 Arvid Nilsson <anilsson@rim.com>
  10254. [BlackBerry] Overlays display checkerboard that doesn't resolve
  10255. https://bugs.webkit.org/show_bug.cgi?id=93099
  10256. Reviewed by Antonio Gomes.
  10257. The WebKit-thread overlays, like tap highlight, inspector highlight and
  10258. selection are all part of a separate graphics layer tree rooted in
  10259. WebPagePrivate::m_overlayLayer.
  10260. When LayerRenderer needs to schedule a commit to reactively render
  10261. tiles and resolve checkerboard, it does so through the root layer.
  10262. Since the overlay layer root didn't have a GraphicsLayerClient, there
  10263. was no implementation of GraphicsLayerClient::notifySyncRequired() to
  10264. call, and a commit was never scheduled, thus checkerboard never
  10265. resolved.
  10266. Fixed by adding a fallback implementation of GraphicsLayerClient in
  10267. WebPagePrivate and hooking up the overlay root to it. Also, this
  10268. implementation can be shared by the various overlays to avoide code
  10269. duplication, specifically to implement notifySyncRequired(),
  10270. showDebugBorders() and showRepaintCounter() only once.
  10271. Fixing this revealed a bug where the web page would get stuck in an
  10272. endless sequence of commits. It turned out that
  10273. WebPagePrivate::updateDelegatedOverlays() was called right in the
  10274. middle of the commit operation, after performing the webkit thread part
  10275. of the commit operation but before we continued on the compositing
  10276. thread. Since updateDelegatedOverlays() typically mutates layers, this
  10277. is very bad (layers should not be mutated mid-commit). The mutations
  10278. also cause a new commit to scheduled from within the current, which
  10279. results in an endless sequence of commits.
  10280. Fixed this latter bug by moving the updateDelegatedOverlays() call to
  10281. the beginning of the method where it can cause no harm. This is before
  10282. we mark the web page as no longer needing commit, so even if the
  10283. implementation flips the "needs commit" bit, we will immediately flip
  10284. it back and proceed with commit as usual.
  10285. PR 187458, 184377
  10286. * Api/WebPage.cpp:
  10287. (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
  10288. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  10289. (WebKit):
  10290. (BlackBerry::WebKit::WebPagePrivate::notifySyncRequired):
  10291. (BlackBerry::WebKit::WebPagePrivate::showDebugBorders):
  10292. (BlackBerry::WebKit::WebPagePrivate::showRepaintCounter):
  10293. * Api/WebPage_p.h:
  10294. (WebPagePrivate):
  10295. (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
  10296. (BlackBerry::WebKit::WebPagePrivate::paintContents):
  10297. * WebCoreSupport/InspectorOverlay.cpp:
  10298. (WebCore::InspectorOverlay::notifySyncRequired):
  10299. (WebCore::InspectorOverlay::showDebugBorders):
  10300. (WebCore::InspectorOverlay::showRepaintCounter):
  10301. * WebKitSupport/DefaultTapHighlight.cpp:
  10302. (BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
  10303. (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
  10304. (WebKit):
  10305. (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
  10306. * WebKitSupport/DefaultTapHighlight.h:
  10307. (DefaultTapHighlight):
  10308. * WebKitSupport/SelectionOverlay.cpp:
  10309. (BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
  10310. (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
  10311. (WebKit):
  10312. (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
  10313. * WebKitSupport/SelectionOverlay.h:
  10314. (SelectionOverlay):
  10315. 2012-08-02 Arvid Nilsson <anilsson@rim.com>
  10316. [BlackBerry] Add default implementation of GraphicsLayerClient::contentsVisible()
  10317. https://bugs.webkit.org/show_bug.cgi?id=93036
  10318. Reviewed by George Staikos.
  10319. Remove implementation of GraphicsLayerClient::contentsVisible() now
  10320. that it has a default implementation.
  10321. This also fixes a bug where memory usage for the inspector highlight
  10322. overlay would balloon because it returned true from contentsVisible()
  10323. which would cause the LayerTiler to populate all tiles. The default
  10324. implementation returns false instead.
  10325. PR 187458, 184377
  10326. * WebCoreSupport/InspectorOverlay.cpp:
  10327. (WebCore::InspectorOverlay::showRepaintCounter):
  10328. * WebCoreSupport/InspectorOverlay.h:
  10329. (InspectorOverlay):
  10330. * WebKitSupport/DefaultTapHighlight.h:
  10331. * WebKitSupport/SelectionOverlay.h:
  10332. 2012-08-02 Antonio Gomes <agomes@rim.com>
  10333. Unreviewed debug build fix (bug 92889)
  10334. * WebKitSupport/InRegionScroller.cpp:
  10335. (BlackBerry::WebKit::pushBackInRegionScrollable):
  10336. 2012-08-02 Leo Yang <leoyang@rim.com>
  10337. [BlackBerry] Rounding error of destination rect of checkerboard
  10338. https://bugs.webkit.org/show_bug.cgi?id=93012
  10339. Reviewed by Rob Buis.
  10340. Reviewed internally by Jakob Petsovits.
  10341. Intersect with the destination rectangle to eliminate the rounding error.
  10342. * Api/BackingStore.cpp:
  10343. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  10344. 2012-08-01 Antonio Gomes <agomes@rim.com>
  10345. [BlackBerry] Implement InRegionScroller class as a in-region scroll controller
  10346. https://bugs.webkit.org/show_bug.cgi?id=92889
  10347. PR #186587
  10348. Reviewed by Yong Li.
  10349. Internally reviewed by Arvid Nilsson.
  10350. Moved all in-region scrolling code out of WebPagePrivate to the just
  10351. created InRegionScroller class. This class aims to:
  10352. 1) Centralize all in-region scroll code and clean up WebPagePrivate as a consequence.
  10353. 2) Be the bases to add UI/Compositing thread driven scrolls to in-region.
  10354. The patch does not change any functionallity change.
  10355. * Api/WebPage.cpp:
  10356. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  10357. (BlackBerry::WebKit::WebPagePrivate::init):
  10358. (BlackBerry::WebKit::WebPagePrivate::scrollBy):
  10359. (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
  10360. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
  10361. (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
  10362. * Api/WebPage_p.h:
  10363. (WebPagePrivate):
  10364. * WebKitSupport/InRegionScrollableArea.cpp:
  10365. (BlackBerry::WebKit::InRegionScrollableArea::layer):
  10366. * WebKitSupport/InRegionScroller.cpp: Added.
  10367. (WebKit):
  10368. (BlackBerry::WebKit::canScrollInnerFrame):
  10369. (BlackBerry::WebKit::canScrollRenderBox):
  10370. (BlackBerry::WebKit::parentLayer):
  10371. (BlackBerry::WebKit::enclosingLayerNode):
  10372. (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
  10373. (BlackBerry::WebKit::pushBackInRegionScrollable):
  10374. (BlackBerry::WebKit::InRegionScroller::InRegionScroller):
  10375. (BlackBerry::WebKit::InRegionScroller::setNode):
  10376. (BlackBerry::WebKit::InRegionScroller::node):
  10377. (BlackBerry::WebKit::InRegionScroller::reset):
  10378. (BlackBerry::WebKit::InRegionScroller::isNull):
  10379. (BlackBerry::WebKit::InRegionScroller::scrollBy):
  10380. (BlackBerry::WebKit::InRegionScroller::inRegionScrollableAreasForPoint):
  10381. (BlackBerry::WebKit::InRegionScroller::scrollNodeRecursively):
  10382. (BlackBerry::WebKit::InRegionScroller::scrollRenderer):
  10383. (BlackBerry::WebKit::InRegionScroller::adjustScrollDelta):
  10384. * WebKitSupport/InRegionScroller.h: Added.
  10385. (WebCore):
  10386. (WebKit):
  10387. (InRegionScroller):
  10388. * WebKitSupport/TouchEventHandler.cpp:
  10389. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  10390. 2012-08-01 Charles Wei <charles.wei@torchmobile.com.cn>
  10391. [BlackBerry] Favicon should be Base64 encoded for cross-process passing
  10392. https://bugs.webkit.org/show_bug.cgi?id=92857
  10393. Reviewed by George Staikos.
  10394. The current implementation just passes the internal of SkPixels data to the client,
  10395. which can't be passed accross the process boundary to chrome for processing.
  10396. This patch makes the favicon Base64 encoded so that can be passed to chrome in another process.
  10397. * Api/WebPageClient.h:
  10398. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10399. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
  10400. 2012-08-01 Jacky Jiang <zhajiang@rim.com>
  10401. [BlackBerry] Allow client side to add and remove origin access whitelist entries
  10402. https://bugs.webkit.org/show_bug.cgi?id=92790
  10403. Reviewed by Yong Li.
  10404. PR: 172658
  10405. Add two new APIs to add and remove origin access whitelist entries.
  10406. Initialize the BlackBerryAllowCrossSiteRequests WebSetting to false.
  10407. * Api/WebPage.cpp:
  10408. (BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
  10409. (WebKit):
  10410. (BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
  10411. (BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
  10412. (BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
  10413. * Api/WebPage.h:
  10414. * Api/WebPage_p.h:
  10415. (WebPagePrivate):
  10416. * Api/WebSettings.cpp:
  10417. (BlackBerry::WebKit::WebSettings::standardSettings):
  10418. 2012-08-01 Mike Fenton <mifenton@rim.com>
  10419. [BlackBerry] Consolidate suppression of keyboard requests.
  10420. https://bugs.webkit.org/show_bug.cgi?id=92871
  10421. Reviewed by Antonio Gomes.
  10422. Reduce VKB requests even more by applying the filter on
  10423. all requests during processing.
  10424. Reviewed Internally by Gen Mak.
  10425. * WebKitSupport/InputHandler.cpp:
  10426. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  10427. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  10428. 2012-08-01 Arvid Nilsson <anilsson@rim.com>
  10429. [BlackBerry] Disable tap highlight when transparent color is specified
  10430. https://bugs.webkit.org/show_bug.cgi?id=92849
  10431. Reviewed by Antonio Gomes.
  10432. When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
  10433. or any color with alpha value 0, we should disable the tap highlight.
  10434. * WebKitSupport/DefaultTapHighlight.cpp:
  10435. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  10436. 2012-07-31 Robin Cao <robin.cao@torchmobile.com.cn>
  10437. [BlackBerry] Pass all file chooser settings to clients
  10438. https://bugs.webkit.org/show_bug.cgi?id=92237
  10439. Reviewed by Rob Buis.
  10440. Expose all file chooser settings to clients.
  10441. * Api/WebPageClient.h:
  10442. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  10443. (WebCore::ChromeClientBlackBerry::runOpenPanel):
  10444. 2012-07-31 Mike Fenton <mifenton@rim.com>
  10445. [BlackBerry] Fix crash in InputHandler spell checking.
  10446. https://bugs.webkit.org/show_bug.cgi?id=92763
  10447. Reviewed by Antonio Gomes.
  10448. PR 185574.
  10449. Fix crash in getSpellChecker by guarding the calling paths
  10450. to ensure that m_currentFocusElement is valid.
  10451. Also add ASSERTs for previous crash.
  10452. * WebKitSupport/InputHandler.cpp:
  10453. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  10454. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  10455. (BlackBerry::WebKit::InputHandler::getSpellChecker):
  10456. 2012-07-31 Genevieve Mak <gmak@rim.com>
  10457. Send an onContextMenu event to the page content
  10458. so that context menus can be prevented. We use
  10459. the node's event handler because we want to use
  10460. the fat finger's node. If we use the EventHandler's
  10461. sendContextMenuEvent it will hit test with the mouse
  10462. position which may not be what we want.
  10463. PR #184032
  10464. https://bugs.webkit.org/show_bug.cgi?id=92766
  10465. Reviewed by Antonio Gomes.
  10466. Reviewed Internally by Antonio Gomes.
  10467. * Api/WebPage.cpp:
  10468. (BlackBerry::WebKit::WebPagePrivate::webContext):
  10469. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  10470. 2012-07-31 Arvid Nilsson <anilsson@rim.com>
  10471. [BlackBerry] Backing store output flickers when using WebPageCompositor
  10472. https://bugs.webkit.org/show_bug.cgi?id=90291
  10473. Reviewed by Antonio Gomes.
  10474. The backing store doesn't know when the API client swaps the buffers,
  10475. so it doesn't know when to signal the blit generation condition
  10476. variable. Fixed by using EGL fence sync instead, when available, so we
  10477. don't have to know.
  10478. Reviewed internally by Filip Spacek.
  10479. * Api/BackingStore.cpp:
  10480. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  10481. (BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
  10482. (BlackBerry::WebKit::BackingStorePrivate::render):
  10483. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  10484. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  10485. * Api/BackingStore_p.h:
  10486. (BackingStorePrivate):
  10487. * WebKitSupport/BackingStoreTile.cpp:
  10488. (BlackBerry::WebKit::TileBuffer::TileBuffer):
  10489. * WebKitSupport/BackingStoreTile.h:
  10490. (BlackBerry::WebKit::TileBuffer::syncObject):
  10491. (BlackBerry::WebKit::TileBuffer::setSyncObject):
  10492. (TileBuffer):
  10493. * WebKitSupport/SurfacePool.cpp:
  10494. (WebKit):
  10495. (BlackBerry::WebKit::SurfacePool::SurfacePool):
  10496. (BlackBerry::WebKit::SurfacePool::initialize):
  10497. (BlackBerry::WebKit::SurfacePool::waitForBuffer):
  10498. (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
  10499. * WebKitSupport/SurfacePool.h:
  10500. (SurfacePool):
  10501. 2012-07-30 Yoshifumi Inoue <yosin@chromium.org>
  10502. [Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
  10503. https://bugs.webkit.org/show_bug.cgi?id=92612
  10504. Reviewed by Kent Tamura.
  10505. This patch replaces Element::isReadOnlyFormControl() to
  10506. HTMLFormControlElement::readOnly() for preparation of introducing
  10507. Element::shouldMatchReadWriteSelector(), bug 92602.
  10508. * WebKitSupport/DOMSupport.cpp:
  10509. (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().
  10510. 2012-07-30 Mike Fenton <mifenton@rim.com>
  10511. [BlackBerry] Optimize the generation of selection details generation.
  10512. https://bugs.webkit.org/show_bug.cgi?id=92522
  10513. Reviewed by Antonio Gomes.
  10514. PR 179264.
  10515. Reduce the number of times we generate selection details notifications.
  10516. This removes several notifications that are handled by the standard
  10517. notification path and makes skipping duplicate notifications the default
  10518. so that only those that must generate a response do.
  10519. Reviewed Internally by Gen Mak.
  10520. * Api/WebPage.cpp:
  10521. (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
  10522. (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
  10523. * WebKitSupport/InputHandler.cpp:
  10524. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  10525. * WebKitSupport/SelectionHandler.cpp:
  10526. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  10527. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  10528. (BlackBerry::WebKit::SelectionHandler::setSelection):
  10529. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  10530. * WebKitSupport/SelectionHandler.h:
  10531. (SelectionHandler):
  10532. 2012-07-30 Robin Cao <robin.cao@torchmobile.com.cn>
  10533. [BlackBerry] Adapt to changes in the SharedArray platform API
  10534. https://bugs.webkit.org/show_bug.cgi?id=92631
  10535. Reviewed by Rob Buis.
  10536. Adapt to changes in the SharedArray platform API. No behavioural change.
  10537. Reviewed internally by Joe Mason.
  10538. * Api/WebPage.cpp:
  10539. (BlackBerry::WebKit::WebPage::getBackForwardList):
  10540. * Api/WebPage.h:
  10541. * Api/WebPageClient.h:
  10542. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  10543. (WebCore::ChromeClientBlackBerry::runOpenPanel):
  10544. 2012-07-30 Patrick Gansterer <paroga@webkit.org>
  10545. Replace UnicodeWinCE with UnicodeWchar
  10546. https://bugs.webkit.org/show_bug.cgi?id=92539
  10547. Reviewed by Ryosuke Niwa.
  10548. UnicodeWinCE never contained WinCE specific code. UnicodeWchar
  10549. is a replacement for it, which is mainly based on the functions
  10550. from <wchar.h>. It is ment as a minimal Unicode backend, which
  10551. can be used very easy and has no external dependencies.
  10552. * WebCoreSupport/AboutDataUseFeatures.in:
  10553. 2012-07-27 Eli Fidler <efidler@rim.com>
  10554. [BlackBerry] Adapt to change in the FontInfo platform API.
  10555. https://bugs.webkit.org/show_bug.cgi?id=92547
  10556. Reviewed by Yong Li
  10557. RIM PR 161263
  10558. * Api/WebSettings.cpp:
  10559. (BlackBerry::WebKit::WebSettings::standardSettings):
  10560. 2012-07-27 Yong Li <yoli@rim.com>
  10561. [BlackBerry] Should support onbeforeunload event and show confirmation dialog
  10562. https://bugs.webkit.org/show_bug.cgi?id=92510
  10563. Reviewed by Antonio Gomes.
  10564. RIM PR# 155878.
  10565. 1. Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
  10566. 2. Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.
  10567. * Api/WebPage.cpp:
  10568. (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
  10569. (WebKit):
  10570. * Api/WebPage.h:
  10571. * Api/WebPageClient.h:
  10572. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  10573. (WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
  10574. (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
  10575. 2012-07-27 Mike Fenton <mifenton@rim.com>
  10576. [BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
  10577. https://bugs.webkit.org/show_bug.cgi?id=92508
  10578. Reviewed by Yong Li.
  10579. Replace common uses of malloc with fastMalloc rather
  10580. than trying to recover gracefully. If we are truly
  10581. out of memory, crash before corruption occurs.
  10582. * WebKitSupport/InputHandler.cpp:
  10583. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  10584. (BlackBerry::WebKit::InputHandler::extractedTextRequest):
  10585. 2012-07-26 Nima Ghanavatian <nghanavatian@rim.com>
  10586. [BlackBerry] Remove synchronous spellchecking code
  10587. https://bugs.webkit.org/show_bug.cgi?id=92415
  10588. Removing synchronous spellchecking code path.
  10589. Reviewed by Rob Buis.
  10590. Internally reviewed by Mike Fenton.
  10591. * Api/WebPageClient.h:
  10592. * WebCoreSupport/EditorClientBlackBerry.cpp:
  10593. (WebCore::EditorClientBlackBerry::checkSpellingOfString):
  10594. 2012-07-26 Nima Ghanavatian <nghanavatian@rim.com>
  10595. [BlackBerry] Support async spellcheck for the blackberry port
  10596. https://bugs.webkit.org/show_bug.cgi?id=92160
  10597. PR124517
  10598. Implementing support for async spellcheck.
  10599. Reviewed by Rob Buis.
  10600. Internally reviewed by Mike Fenton.
  10601. * Api/WebPage.cpp:
  10602. (BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
  10603. (WebKit):
  10604. (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
  10605. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  10606. * Api/WebPage.h:
  10607. * Api/WebSettings.cpp:
  10608. (WebKit):
  10609. (BlackBerry::WebKit::WebSettings::standardSettings):
  10610. (BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
  10611. (BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):
  10612. * Api/WebSettings.h:
  10613. * WebCoreSupport/EditorClientBlackBerry.cpp:
  10614. (WebCore):
  10615. (WebCore::EditorClientBlackBerry::requestCheckingOfString):
  10616. (WebCore::EditorClientBlackBerry::checkTextOfParagraph):
  10617. * WebCoreSupport/EditorClientBlackBerry.h:
  10618. (EditorClientBlackBerry):
  10619. * WebKitSupport/InputHandler.cpp:
  10620. (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
  10621. (BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
  10622. (WebKit):
  10623. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  10624. (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
  10625. (BlackBerry::WebKit::InputHandler::getSpellChecker):
  10626. * WebKitSupport/InputHandler.h:
  10627. (WebCore):
  10628. (InputHandler):
  10629. 2012-07-26 Mike Fenton <mifenton@rim.com>
  10630. [BlackBerry] Improve the logs in Selection Handler.
  10631. https://bugs.webkit.org/show_bug.cgi?id=92405
  10632. Reviewed by Rob Buis.
  10633. Clean up selection logging, fix priority and style
  10634. of helper function.
  10635. Reviewed Internally by Nima Ghanavatian.
  10636. * WebKitSupport/SelectionHandler.cpp:
  10637. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  10638. (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
  10639. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  10640. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  10641. (BlackBerry::WebKit::SelectionHandler::setSelection):
  10642. (BlackBerry::WebKit::SelectionHandler::selectObject):
  10643. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  10644. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  10645. 2012-07-26 Mike Fenton <mifenton@rim.com>
  10646. [BlackBerry] Add timing logs to SelectionHandler.
  10647. https://bugs.webkit.org/show_bug.cgi?id=92404
  10648. Reviewed by Rob Buis.
  10649. Add selection timing logs.
  10650. Reviewed Internally by Nima Ghanavatian.
  10651. * WebKitSupport/SelectionHandler.cpp:
  10652. (BlackBerry::WebKit::SelectionHandler::setSelection):
  10653. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  10654. * WebKitSupport/SelectionHandler.h:
  10655. (SelectionHandler):
  10656. 2012-07-26 Mike Fenton <mifenton@rim.com>
  10657. [BlackBerry] InputHandler failure logs should be logAlways and critical.
  10658. https://bugs.webkit.org/show_bug.cgi?id=92403
  10659. Reviewed by Rob Buis.
  10660. Update Log level for failures and fix mask in log.
  10661. Reviewed Internally by Nima Ghanavatian.
  10662. * WebKitSupport/InputHandler.cpp:
  10663. (BlackBerry::WebKit::convertStringToWchar):
  10664. (BlackBerry::WebKit::convertStringToWcharVector):
  10665. (BlackBerry::WebKit::convertSpannableStringToString):
  10666. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  10667. (BlackBerry::WebKit::InputHandler::setTextAttributes):
  10668. 2012-07-26 Arvid Nilsson <anilsson@rim.com>
  10669. [BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion() to avoid touching tile frontbuffer
  10670. https://bugs.webkit.org/show_bug.cgi?id=92095
  10671. Reviewed by George Staikos.
  10672. PR: 141439
  10673. Specifically, we want to avoid changing the rendered region of the
  10674. front buffer without proper synchronization.
  10675. The method is trying to force checkerboard to appear on screen because
  10676. an area was invalidated but the render job was dropped, so the tile
  10677. contents are now invalid.
  10678. Unfortunately it did this in a way which is not thread safe. Fixed by
  10679. making it thread safe, in a way that minimizes memory bandwidth usage.
  10680. Instead of using the customary sequence of copy-back, modify and swap,
  10681. we send a synchronous message to the compositing thread to avoid the
  10682. copy-back step and save memory bandwidth. The trade-off is that the
  10683. WebKit thread might wait a little longer for the compositing thread
  10684. than it would from a waitForCurrentMessage() call.
  10685. The way we synchronize this is rather expensive for the WebKit thread,
  10686. and this method is called rather carelessly, so add various early
  10687. returns to avoid doing it redundantly.
  10688. Internally reviewed by Jakob Petsovits and Adam Treat.
  10689. * Api/BackingStore.cpp:
  10690. (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
  10691. (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
  10692. * Api/BackingStore_p.h:
  10693. (BackingStorePrivate):
  10694. 2012-07-26 Arvid Nilsson <anilsson@rim.com>
  10695. [BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
  10696. https://bugs.webkit.org/show_bug.cgi?id=91989
  10697. Reviewed by George Staikos.
  10698. PR: 141439
  10699. Specifically, we want to avoid changing the rendered region of the
  10700. front buffer. The code only touched the front buffer rendered region
  10701. if the tile was not committed.
  10702. Instead of immediately marking the tile as committed, and clearing the
  10703. front buffer's rendered region to make it appear as checkerboard, we
  10704. leave the front buffer alone and only mark the tile as committed once
  10705. the front buffer has valid content. Un-committed tiles will also be
  10706. rendered as checkerboard, so leaving it uncommitted is equivalent to
  10707. clearing the front buffer rendered region here.
  10708. In addition to the main change, some related changes follow naturally.
  10709. The copyPreviousContentsToBackSurfaceOfTile() call only makes sense if
  10710. the tile is committed, and the front buffer has valid content.
  10711. Otherwise, clearing the back buffer is equivalent. The code has been
  10712. updated to this effect.
  10713. Since copyPreviousContentsToBackSurfaceOfTile() always sets the
  10714. rendered region to the union of the front and back buffer regions,
  10715. there is no point in the "backBufferIsValid" check. It has been turned
  10716. into an ASSERT instead, just to make sure.
  10717. Internally reviewed by Jakob Petsovits.
  10718. * Api/BackingStore.cpp:
  10719. (BlackBerry::WebKit::BackingStorePrivate::render):
  10720. 2012-07-25 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  10721. [BlackBerry] Support RTSP in browser
  10722. https://bugs.webkit.org/show_bug.cgi?id=92233
  10723. Reviewed by Rob Buis.
  10724. Handle URL scheme "rtsp://" before creating the DocumentLoader
  10725. and send the request to webkit. As we don't have any application
  10726. which can deal with rtsp invocation for now, we need to create
  10727. a media document to wrap the rtsp url within a video tag which
  10728. makes it load as a normal video clip.
  10729. RIM PR: 169669
  10730. Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>.
  10731. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10732. (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
  10733. 2012-07-25 Jakob Petsovits <jpetsovits@rim.com>
  10734. [BlackBerry] Rephrase suspend/resume condition to guard against crashes
  10735. https://bugs.webkit.org/show_bug.cgi?id=92300
  10736. PR 182125
  10737. Reviewed by George Staikos.
  10738. When the compositor is removed from a WebPage, it might
  10739. already have unset its context, and issuing a call to
  10740. BackingStore::buffer() would therefore cause a crash.
  10741. Just guarding buffer() from this crash isn't fully
  10742. correct, because then we wouldn't suspend rendering
  10743. for a compositor that had been previously enabled.
  10744. Instead, change the condition to suspend/resume in
  10745. WebPagePrivate::setCompositor() to focus on the
  10746. object that delivers us the buffer. If we can't
  10747. listen to the context or buffer being set, better
  10748. just take the compositor object itself to determine
  10749. whether we have something valid or not... and hope
  10750. that they give us a valid context & buffer in all
  10751. situations when we can actually be rendering.
  10752. Also check compositor->context() in buffer() to be
  10753. non-zero before accessing the context's buffer,
  10754. because more defensive coding can't hurt here.
  10755. * Api/BackingStore.cpp:
  10756. (BlackBerry::WebKit::BackingStorePrivate::buffer):
  10757. * Api/WebPage.cpp:
  10758. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  10759. 2012-07-25 Joshua Netterfield <jnetterfield@rim.com>
  10760. [BlackBerry] Update about:config lists
  10761. https://bugs.webkit.org/show_bug.cgi?id=92118
  10762. Reviewed by Rob Buis.
  10763. Remove features from list that have either been removed from WebKit
  10764. or that have been moved from one list to another.
  10765. * WebCoreSupport/AboutDataEnableFeatures.in:
  10766. * WebCoreSupport/AboutDataHaveFeatures.in:
  10767. * WebCoreSupport/AboutDataUseFeatures.in:
  10768. 2012-07-25 Jacky Jiang <zhajiang@rim.com>
  10769. [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
  10770. https://bugs.webkit.org/show_bug.cgi?id=91898
  10771. Reviewed by Yong Li.
  10772. Let pthread condition variable in BackingStore.cpp use monotonic clock
  10773. to fix a regression caused by r123266.
  10774. * Api/BackingStore.cpp:
  10775. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  10776. 2012-07-25 Andy Chen <andchen@rim.com>
  10777. [BlackBerry] Add "SelectAll" to WebPage
  10778. https://bugs.webkit.org/show_bug.cgi?id=92246
  10779. Reviewed by Antonio Gomes.
  10780. Add "Select All" editor command to WebPage.
  10781. Internally reviewed by Mike Fenton.
  10782. * Api/WebPage.cpp:
  10783. (BlackBerry::WebKit::WebPage::selectAll):
  10784. (WebKit):
  10785. * Api/WebPage.h:
  10786. * WebKitSupport/InputHandler.cpp:
  10787. (BlackBerry::WebKit::InputHandler::selectAll):
  10788. (WebKit):
  10789. * WebKitSupport/InputHandler.h:
  10790. 2012-07-25 Arvid Nilsson <anilsson@rim.com>
  10791. [BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
  10792. https://bugs.webkit.org/show_bug.cgi?id=91992
  10793. Reviewed by Adam Treat.
  10794. PR: 141439
  10795. The copyPreviousContentsToBackSurfaceOfTile() call will also modify
  10796. buffer contents, move it after the blit generation condvar to make sure
  10797. we've waited for the buffer to become available first.
  10798. This is done as part of some general BackingStorePrivate::render()
  10799. cleanup in PR 141439.
  10800. Internally reviewed by Jakob Petsovits.
  10801. * Api/BackingStore.cpp:
  10802. (BlackBerry::WebKit::BackingStorePrivate::render):
  10803. 2012-07-25 Jakob Petsovits <jpetsovits@rim.com>
  10804. [BlackBerry] notifyContentRendered() call missing in two spots
  10805. https://bugs.webkit.org/show_bug.cgi?id=92153
  10806. RIM PR 173340
  10807. Reviewed by Antonio Gomes.
  10808. In dispatchDidFirstVisualLayout() and repaint() in
  10809. immediate mode, we render but don't notify the
  10810. WebPageClient that the content was modified.
  10811. In the long run, we should probably keep track of
  10812. the modified reason from within render() itself
  10813. and use this to automatically notify the client
  10814. from within blitContents() and/or invalidateWindow(),
  10815. depending on the rendering path. That's somewhat of
  10816. a medium-size undertaking though; for now, adding
  10817. the call directly to the renderVisibleContents()
  10818. call sites will do.
  10819. This patch also adds a blitVisibleContents() to
  10820. dispatchDidFirstVisualLayout() where it was
  10821. inexplicably missing, probably on account of
  10822. old code that was never updated.
  10823. * Api/BackingStore.cpp:
  10824. (BlackBerry::WebKit::BackingStorePrivate::repaint):
  10825. * Api/WebPage.cpp:
  10826. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  10827. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10828. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
  10829. 2012-07-24 Rob Buis <rbuis@rim.com>
  10830. [BlackBerry] Do not call settings setters twice on page construction
  10831. https://bugs.webkit.org/show_bug.cgi?id=92157
  10832. Reviewed by Yong Li.
  10833. The WebPagePrivate init method sets some settings value that were
  10834. already set in didChangeSettings. setUseHixie76WebSocketProtocol just
  10835. sets the default value, no need to set it again.
  10836. Also call didChangeSettings explicitly from init, before that we are
  10837. not calling it since the delegate is not set yet.
  10838. * Api/WebPage.cpp:
  10839. (BlackBerry::WebKit::WebPagePrivate::init):
  10840. 2012-07-24 Mike Fenton <mifenton@rim.com>
  10841. Throttle calls to request the virtual keyboard be shown.
  10842. https://bugs.webkit.org/show_bug.cgi?id=92138
  10843. Reviewed by Rob Buis.
  10844. PR 178465.
  10845. Do not request keyboard visibility change when
  10846. we are actively processing an input event.
  10847. Reviewed Internally by Gen Mak.
  10848. * WebKitSupport/InputHandler.cpp:
  10849. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  10850. 2012-07-24 Joshua Netterfield <jnetterfield@rim.com>
  10851. [BlackBerry] Update about:config lists
  10852. https://bugs.webkit.org/show_bug.cgi?id=92118
  10853. Reviewed by Rob Buis.
  10854. We want to have all flags which could be used / have been used by any platform. These lists were created by running:
  10855. * WebCoreSupport/AboutDataEnableFeatures.in: `git grep "ENABLE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
  10856. * WebCoreSupport/AboutDataHaveFeatures.in: `git grep "HAVE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
  10857. * WebCoreSupport/AboutDataUseFeatures.in: `git grep "USE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
  10858. 2012-07-24 Arvid Nilsson <anilsson@rim.com>
  10859. [BlackBerry] Remove unused variable in BackingStore.cpp
  10860. https://bugs.webkit.org/show_bug.cgi?id=91987
  10861. Reviewed by Antonio Gomes.
  10862. PR: 141439
  10863. This is done as part of some general BackingStorePrivate::render()
  10864. cleanup in PR 141439.
  10865. * Api/BackingStore.cpp:
  10866. (BlackBerry::WebKit::BackingStorePrivate::render):
  10867. 2012-07-23 Yong Li <yoli@rim.com>
  10868. [BlackBerry] Move about: URL handling out of WebCore
  10869. https://bugs.webkit.org/show_bug.cgi?id=91541
  10870. Reviewed by Rob Buis.
  10871. PR# 181304.
  10872. Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
  10873. reload and history navigation can work.
  10874. Other changes: Remove about:version which makes little sense. Make about:memory partially visible.
  10875. * Api/WebPage.cpp:
  10876. (BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()
  10877. * Api/WebPage_p.h: Remove loadAbout()
  10878. (WebPagePrivate):
  10879. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10880. (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.
  10881. * WebKitSupport/AboutData.cpp:
  10882. (BlackBerry::WebKit::numberToHTMLTr): Make it static
  10883. (BlackBerry::WebKit::configPage): Make it static
  10884. (BlackBerry::WebKit::memoryPage): Make it static
  10885. (BlackBerry::WebKit::cachePage):
  10886. (BlackBerry::WebKit::buildPage):
  10887. (BlackBerry::WebKit::creditsPage):
  10888. (BlackBerry::WebKit::cookiePage):
  10889. (BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
  10890. (WebKit):
  10891. * WebKitSupport/AboutData.h:
  10892. (WebKit):
  10893. 2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
  10894. Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
  10895. https://bugs.webkit.org/show_bug.cgi?id=91006
  10896. Reviewed by Ryosuke Niwa.
  10897. Removed numTouchEventHandlersChanged stub.
  10898. * WebCoreSupport/ChromeClientBlackBerry.h:
  10899. 2012-07-22 Kent Tamura <tkent@chromium.org>
  10900. Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
  10901. https://bugs.webkit.org/show_bug.cgi?id=91941
  10902. Reviewed by Kentaro Hara.
  10903. A flag name for an elmement should be ENABLE_*_ELEMENT.
  10904. * WebCoreSupport/AboutDataEnableFeatures.in:
  10905. 2012-07-20 Jacky Jiang <zhajiang@rim.com>
  10906. [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
  10907. https://bugs.webkit.org/show_bug.cgi?id=91898
  10908. Reviewed by Yong Li.
  10909. PR: 181043
  10910. Use CLOCK_MONOTONIC when we do expect a monotonic timer.
  10911. * Api/BackingStore.cpp:
  10912. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  10913. 2012-07-20 Crystal Zhang <haizhang@rim.com>
  10914. [BlackBerry] Add Cancel button for Select popup
  10915. https://bugs.webkit.org/show_bug.cgi?id=91887
  10916. Reviewed by Yong Li.
  10917. PR 177706
  10918. * WebCoreSupport/SelectPopupClient.cpp:
  10919. (WebCore::SelectPopupClient::generateHTML):
  10920. (WebCore::SelectPopupClient::setValueAndClosePopup):
  10921. 2012-07-19 Mary Wu <mary.wu@torchmobile.com.cn>
  10922. [BlackBerry] Make sure to send favicon when go back/forward
  10923. https://bugs.webkit.org/show_bug.cgi?id=91808
  10924. Reviewed by George Staikos.
  10925. When go back/forward, if the page was in page cache, it would have no chance
  10926. to send favicon. So we'll send it in commitLoad right after send the blank
  10927. icon.
  10928. RIM PR# 177495
  10929. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  10930. (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
  10931. 2012-07-19 Jakob Petsovits <jpetsovits@rim.com>
  10932. [BlackBerry] Suspend when there's no target buffer until an external compositor is set
  10933. https://bugs.webkit.org/show_bug.cgi?id=91686
  10934. RIM PR 174365
  10935. Reviewed by Antonio Gomes.
  10936. If we don't have a client window (i.e. rendering to
  10937. GL directly) and a WebPageCompositor is only set
  10938. after a rendering operation, then we'll try to render
  10939. to BackingStorePrivate::buffer() which doesn't exist
  10940. at this point. That's bad, and gets us various
  10941. assertions and possibly worse.
  10942. Fix it by starting in a screen-suspended state and only
  10943. resuming screen and backingstore once a compositor is
  10944. actually set.
  10945. So, in effect, with this patch applied, the sequence
  10946. of events will look like this:
  10947. 1) WebPage & BackingStore are initialize, neither window
  10948. nor compositor exists, therefore buffer() returns 0.
  10949. createSurface() therefore suspends screen and
  10950. backingstore.
  10951. 2) loadURL() or loadData() is called, web page is
  10952. fully loaded, however we don't try to render because
  10953. we're still suspended, still have no target buffer.
  10954. 3) A WebPageCompositor is being set from outside.
  10955. At the beginning of WebPage::setCompositor() we still
  10956. don't have a buffer() so there's nothing to suspend,
  10957. however, after the sync call to setCompositorHelper()
  10958. the compositor is set so buffer() will return a
  10959. nonzero value, causing us to resume at this point.
  10960. Using the existence of a target buffer to determine
  10961. whether or not to enable rendering or keep it suspended
  10962. seems like a good idea, and the implementation (while
  10963. not quite perfect yet) is a step forward from before.
  10964. * Api/BackingStore.cpp:
  10965. (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
  10966. * Api/WebPage.cpp:
  10967. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  10968. (BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
  10969. * Api/WebPage_p.h:
  10970. (WebPagePrivate):
  10971. 2012-07-19 Jakob Petsovits <jpetsovits@rim.com>
  10972. [BlackBerry] Allow nested suspend/resume screen & backingstore calls.
  10973. https://bugs.webkit.org/show_bug.cgi?id=91644
  10974. RIM PR 174365
  10975. Reviewed by Adam Treat and Antonio Gomes.
  10976. We expose suspendScreenAndBackingStoreUpdates() to the
  10977. outside API, but also use it internally when reacting
  10978. to a number of happenings, i.e. zooming, viewport resize,
  10979. resetting view state on Committed state or when restoring
  10980. it from previous pages, etc.
  10981. These two can clash. For instance, if we get a suspend
  10982. call from outside that suspends us for app inactivity,
  10983. or we are told to suspend because the main target surface
  10984. is not available at the time, and while being suspended
  10985. we try to rotate, finish loading a page, the we'll end up
  10986. resuming operations even though we shouldn't.
  10987. This patch changes the suspend flag to be a counter
  10988. instead, allowing nested suspend/resume calls and making
  10989. suspend/resume more robust this way. It also changes
  10990. several call sites to make sure suspend/resume calls are
  10991. paired up correctly.
  10992. * Api/BackingStore.cpp:
  10993. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  10994. (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
  10995. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  10996. * Api/BackingStore_p.h:
  10997. (BackingStorePrivate):
  10998. * Api/WebPage.cpp:
  10999. (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
  11000. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPointTimerFired):
  11001. (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
  11002. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  11003. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  11004. 2012-07-18 Yong Li <yoli@rim.com>
  11005. [BlackBerry] Move about: URL handling out of WebCore
  11006. https://bugs.webkit.org/show_bug.cgi?id=91541
  11007. Reviewed by Rob Buis.
  11008. Move about URL handling code to WebKit/blackberry. Now when WebPage is asked to load an about URL,
  11009. it directly calls loadString() with the generated source.
  11010. Also move AboutData.h/cpp from WebCoreSupport to WebKitSupport and change their namespace from WebCore
  11011. to BlackBerry::WebKit.
  11012. The change is very mechanical except "procss total memory usage" in about:memory now only accounts used
  11013. bytes and ignore free spaces in malloc.
  11014. * Api/WebPage.cpp:
  11015. (BlackBerry::WebKit::WebPagePrivate::loadAbout):
  11016. (WebKit):
  11017. (BlackBerry::WebKit::WebPage::load):
  11018. * Api/WebPage_p.h:
  11019. (WebPagePrivate):
  11020. * WebKitSupport/AboutData.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp.
  11021. (WebKit):
  11022. (BlackBerry::WebKit::writeFeatures):
  11023. (BlackBerry::WebKit::numberToHTMLTr):
  11024. (BlackBerry::WebKit::bool):
  11025. (BlackBerry::WebKit::configPage):
  11026. (BlackBerry::WebKit::cacheTypeStatisticToHTMLTr):
  11027. (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
  11028. (BlackBerry::WebKit::memoryPage):
  11029. * WebKitSupport/AboutData.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.h.
  11030. (WebKit):
  11031. 2012-07-17 Jakob Petsovits <jpetsovits@rim.com>
  11032. [BlackBerry] Remove unnecessary clearWindow() calls and the method itself
  11033. https://bugs.webkit.org/show_bug.cgi?id=91540
  11034. RIM PR 174365
  11035. Reviewed by Adam Treat.
  11036. If we resume the backingstore right afterwards with
  11037. RenderAndBlit then that'll fill the whole visible area
  11038. with content, making a clearWindow() call unnecessary.
  11039. This call is a remnant from ages ago, and is well suited
  11040. to disappear into nothingness.
  11041. (There is still a clearWindow() call, with rect argument,
  11042. which we continue using. This commit only removes the
  11043. rect-less version.)
  11044. * Api/BackingStore.cpp:
  11045. * Api/BackingStore_p.h:
  11046. (BackingStorePrivate):
  11047. * Api/WebPage.cpp:
  11048. (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
  11049. (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
  11050. 2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
  11051. Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
  11052. https://bugs.webkit.org/show_bug.cgi?id=91196
  11053. Reviewed by Pavel Feldman.
  11054. Refactoring InspectorClients. InspectorClient::openInspectorFrontend
  11055. now returning the InspectorFrontendChannel.
  11056. * Api/WebPage.cpp:
  11057. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  11058. (BlackBerry::WebKit::WebPagePrivate::init):
  11059. (BlackBerry::WebKit::WebPage::enableWebInspector):
  11060. * Api/WebPage_p.h:
  11061. (WebPagePrivate):
  11062. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  11063. (WebCore::InspectorClientBlackBerry::openInspectorFrontend):
  11064. * WebCoreSupport/InspectorClientBlackBerry.h:
  11065. (InspectorClientBlackBerry):
  11066. 2012-07-17 Chris Guan <chris.guan@torchmobile.com.cn>
  11067. [BlackBerry] Enable registerProtocolHandler for Blackberry
  11068. https://bugs.webkit.org/show_bug.cgi?id=90422
  11069. Reviewed by George Staikos.
  11070. Implements APIs were added in Custom Scheme Handler specification
  11071. which is at http://dev.w3.org/html5/spec/Overview.html#custom-handlers.
  11072. Test cases:
  11073. fast/dom/register-protocol-handler.html
  11074. fast/dom/unregister-protocol-handler.html
  11075. * Api/WebPageClient.h:
  11076. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11077. (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
  11078. (WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
  11079. (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
  11080. * WebCoreSupport/ChromeClientBlackBerry.h:
  11081. (ChromeClientBlackBerry):
  11082. 2012-07-16 Benjamin C Meyer <bmeyer@rim.com>
  11083. Any webpage can crash webkit via qnx.callExtensionMethod assuming 'this' is the 'qnx' object.
  11084. https://bugs.webkit.org/show_bug.cgi?id=91419
  11085. Run the following in inspector to crash WebKit
  11086. qnx.callExtensionMethod.apply(window, []);
  11087. In the c++ that handles the function it assumes that when callExtensionMethod
  11088. is called that 'this' is the object 'qnx'. The qnx object has a hidden
  11089. variable that the code casts and uses, but when 'this' is not qnx such as the
  11090. example this will cause a crash. Any website can insert the above JavaScript
  11091. to cause the crash.
  11092. Reviewed by Yong Li.
  11093. * WebCoreSupport/ClientExtension.cpp:
  11094. (clientExtensionMethod):
  11095. 2012-07-16 Yong Li <yoli@rim.com>
  11096. [BlackBerry] Improve about:memory page
  11097. https://bugs.webkit.org/show_bug.cgi?id=87676
  11098. Reviewed by Rob Buis.
  11099. Add a table for process memory usage summary for easy read.
  11100. * WebCoreSupport/AboutData.cpp:
  11101. (WebCore::memoryPage):
  11102. 2012-07-16 Kihong Kwon <kihong.kwon@samsung.com>
  11103. Remove setController from BatteryClient
  11104. https://bugs.webkit.org/show_bug.cgi?id=90944
  11105. Reviewed by Adam Barth.
  11106. BatteryClient doesn't need to keep m_controller,
  11107. because BatteryController can be accessed using BatteryController::from().
  11108. Remove m_controller and Add webPagePrivate to BatteryClientBlackBerry.
  11109. And change all m_controller to BatteryController::from.
  11110. * Api/WebPage.cpp:
  11111. (BlackBerry::WebKit::WebPagePrivate::init):
  11112. * WebCoreSupport/BatteryClientBlackBerry.cpp:
  11113. (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
  11114. (WebCore::BatteryClientBlackBerry::onLevelChange):
  11115. (WebCore::BatteryClientBlackBerry::onChargingChange):
  11116. (WebCore::BatteryClientBlackBerry::onChargingTimeChange):
  11117. (WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
  11118. * WebCoreSupport/BatteryClientBlackBerry.h:
  11119. (BatteryClientBlackBerry):
  11120. 2012-07-16 Yongxin Dai <yodai@rim.com>
  11121. [BlackBerry] Text selection with touch hold does not start on text field in some cases
  11122. https://bugs.webkit.org/show_bug.cgi?id=91267
  11123. Reviewed by Antonio Gomes.
  11124. Input fields host node is by spec non-editable unless the field itself has content editable enabled.
  11125. We enable selection if the shadow tree for the input field is selectable.
  11126. PR # 173450
  11127. Reviewed Internally by Mike Fenton.
  11128. * Api/WebPage.cpp:
  11129. (BlackBerry::WebKit::WebPagePrivate::webContext):
  11130. * Api/WebPage.cpp:
  11131. (BlackBerry::WebKit::WebPagePrivate::webContext):
  11132. 2012-07-15 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  11133. [BlackBerry] Move icon database to application data directory.
  11134. https://bugs.webkit.org/show_bug.cgi?id=91195
  11135. Reviewed by Rob Buis.
  11136. RIM PR: 156852
  11137. Create icon database in application data directory instead of
  11138. database or local storage directory, by doing this we can make
  11139. things easier when clearing database or local storage data files.
  11140. Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>
  11141. * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  11142. (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
  11143. 2012-07-13 Xianzhu Wang <wangxianzhu@chromium.org>
  11144. Move WebCore/platform/text/Base64 to WTF/wtf/text
  11145. https://bugs.webkit.org/show_bug.cgi?id=91162
  11146. Reviewed by Adam Barth.
  11147. * Api/WebKitTextCodec.cpp:
  11148. (BlackBerry::WebKit::base64DecodePolicyForWTF):
  11149. (BlackBerry::WebKit::base64Decode):
  11150. (BlackBerry::WebKit::base64EncodePolicyForWTF):
  11151. (BlackBerry::WebKit::base64Encode):
  11152. * Api/WebSettings.cpp:
  11153. (BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
  11154. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  11155. 2012-07-13 George Staikos <staikos@webkit.org>
  11156. [BlackBerry] Fix crash due to unguarded use of renderer in select
  11157. popup.
  11158. https://bugs.webkit.org/show_bug.cgi?id=91287
  11159. Reviewed by Rob Buis.
  11160. No known testcase for this. Found in the wild.
  11161. * WebCoreSupport/SelectPopupClient.cpp:
  11162. (WebCore::SelectPopupClient::setValueAndClosePopup):
  11163. 2012-07-13 Mike Fenton <mifenton@rim.com>
  11164. [BlackBerry] Add support for attributes to define keyboard and enter key type on the Virtual Keyboard
  11165. https://bugs.webkit.org/show_bug.cgi?id=91248
  11166. Reviewed by Antonio Gomes.
  11167. PR 174733.
  11168. Add data-blackberry-virtual-keyboard-type and
  11169. data-blackberry-virtual-keyboard-enter-key to
  11170. enable configuration of the desired virtual keyboard
  11171. using element attributes.
  11172. Reviewed Internally by Gen Mak.
  11173. * Api/WebPageClient.h:
  11174. * WebKitSupport/InputHandler.cpp:
  11175. (BlackBerry::WebKit::convertStringToKeyboardType):
  11176. (WebKit):
  11177. (BlackBerry::WebKit::keyboardTypeAttribute):
  11178. (BlackBerry::WebKit::convertStringToKeyboardEnterKeyType):
  11179. (BlackBerry::WebKit::keyboardEnterKeyTypeAttribute):
  11180. (BlackBerry::WebKit::InputHandler::setElementFocused):
  11181. 2012-07-13 Jacky Jiang <zhajiang@rim.com>
  11182. [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
  11183. https://bugs.webkit.org/show_bug.cgi?id=91247
  11184. Reviewed by Antonio Gomes.
  11185. PR: 175432
  11186. On yahoo.com, the web page stopped zooming while trying to pinch as
  11187. WebPageClient::resetBitmapZoomScale(double) was being called by
  11188. WebPagePrivate::zoomToInitialScaleOnLoad() after load finished.
  11189. And also yahoo.com was keeping updating layout, which made it really
  11190. bad that zoomToInitialScaleOnLoad() was called many times when load
  11191. finished and the load type was FrameLoadTypeStandard or FrameLoadTypeSame.
  11192. As we only care about the situation that dispatchDidFirstVisuallyNonEmptyLayout()
  11193. happens after load finished, we can move the code to that method and
  11194. set a flag for WebPage layoutFinished() and zoomToInitialScaleOnLoad()
  11195. instead. In this way, we can ensure that the flag is only enabled when
  11196. dispatchDidFirstVisuallyNonEmptyLayout() is called after load finished
  11197. and get rid of calling zoomToInitialScaleOnLoad() lots of times when
  11198. keeping updating layout in such kind of situation.
  11199. Internally reviewed by Arvid Nilsson
  11200. * Api/WebPage.cpp:
  11201. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  11202. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  11203. (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
  11204. * Api/WebPage_p.h:
  11205. (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
  11206. (BlackBerry::WebKit::WebPagePrivate::setShouldZoomToInitialScaleAfterLoadFinished):
  11207. (WebPagePrivate):
  11208. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  11209. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
  11210. 2012-07-13 Jakob Petsovits <jpetsovits@rim.com>
  11211. [BlackBerry] Use fillBuffer() instead of a user-defined background image.
  11212. https://bugs.webkit.org/show_bug.cgi?id=91180
  11213. RIM PR 171458
  11214. Reviewed by Rob Buis.
  11215. Internally reviewed by Andrew Lo.
  11216. By using Platform::Graphics::fillBuffer() to fill the
  11217. overscroll area, we save graphics memory for the buffer
  11218. that the background image was occupying.
  11219. Also adapt checkerboard drawing as it is now done using
  11220. fillBuffer() which replaces checkerBuffer().
  11221. In the same go, use the opportunity of the WebSettings
  11222. API change to make it more consistent, renaming the
  11223. OverZoomColor setting to OverScrollColor.
  11224. * Api/BackingStore.cpp:
  11225. (WebKit):
  11226. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  11227. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  11228. (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
  11229. * Api/BackingStore_p.h:
  11230. (BackingStorePrivate):
  11231. * Api/WebSettings.cpp:
  11232. (WebKit):
  11233. (BlackBerry::WebKit::WebSettings::standardSettings):
  11234. (BlackBerry::WebKit::WebSettings::overScrollColor):
  11235. (BlackBerry::WebKit::WebSettings::setOverScrollColor):
  11236. (BlackBerry::WebKit::WebSettings::isEnableDefaultOverScrollBackground):
  11237. (BlackBerry::WebKit::WebSettings::setEnableDefaultOverScrollBackground):
  11238. * Api/WebSettings.h:
  11239. 2012-07-13 Joshua Netterfield <jnetterfield@rim.com>
  11240. [BlackBerry] Update about:* pages
  11241. https://bugs.webkit.org/show_bug.cgi?id=91121
  11242. Reviewed by Yong Li.
  11243. Update the about:config pages, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.
  11244. No new tests, because there is no new funtionality.
  11245. * WebCoreSupport/AboutData.cpp:
  11246. (WebCore):
  11247. (WebCore::writeFeatures):
  11248. (WebCore::numberToHTMLTr): Converted to template function, added bool specialization to write "true" and "false" instead of "1" and "0"
  11249. (WebCore::configPage):
  11250. (WebCore::memoryPage):
  11251. * WebCoreSupport/AboutTemplate.html.cpp: Template for BlackBerry about:* pages.
  11252. 2012-07-12 Benjamin C Meyer <bmeyer@rim.com>
  11253. WebPage::executeJavaScriptFunction crashes when there is an exception
  11254. https://bugs.webkit.org/show_bug.cgi?id=91098
  11255. RIM PR #149294
  11256. When there is an exception currently the code tries to get the string of
  11257. the exception via JSValueToStringCopy to pass back, but this cases a
  11258. crash inside JavaScriptCore, so change it to simply return false and not
  11259. set the return value with the exception string.
  11260. Reviewed by George Staikos.
  11261. * Api/WebPage.cpp:
  11262. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  11263. 2012-07-12 Pawel Chomicki <pchomicki@rim.com>
  11264. [BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
  11265. https://bugs.webkit.org/show_bug.cgi?id=91002
  11266. Reviewed by Antonio Gomes.
  11267. Reviewed internally by Genevieve Mak.
  11268. Updated DEBUG_TOUCH_EVENTS section of touchEvent method to utilize
  11269. Platform::TouchEvent's toString method.
  11270. * Api/WebPage.cpp:
  11271. (BlackBerry::WebKit::WebPage::touchEvent):
  11272. 2012-07-12 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  11273. [BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time
  11274. https://bugs.webkit.org/show_bug.cgi?id=91054
  11275. Reviewed by George Staikos.
  11276. Implemented interface function syncProxyCredential() derived
  11277. from class PageClientBlackBerry.
  11278. Internally reviewed by Jason Liu <jason.liu@torchmobile.com.cn>
  11279. * Api/WebPage.cpp:
  11280. (BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
  11281. (WebKit):
  11282. * Api/WebPageClient.h:
  11283. * Api/WebPage_p.h:
  11284. (WebPagePrivate):
  11285. 2012-07-11 Mike Lattanzio <mlattanzio@rim.com>
  11286. [BlackBerry] UserViewportArguments are not properly respected.
  11287. https://bugs.webkit.org/show_bug.cgi?id=91005
  11288. Reviewed by Rob Buis.
  11289. PR# 170088.
  11290. Move scale and zooming reset on Committed before applying
  11291. the user viewport to avoid overriding it immediately.
  11292. Internal review by Konrad Piascik, Jacky Jiang.
  11293. * Api/WebPage.cpp:
  11294. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  11295. 2012-07-11 Crystal Zhang <haizhang@rim.com>
  11296. [BlackBerry] Implement Date/Time picker
  11297. https://bugs.webkit.org/show_bug.cgi?id=90911
  11298. Reviewed by Rob Buis.
  11299. Implement HTML Date/Time picker, also should delete popup when closing popup.
  11300. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11301. (WebCore::ChromeClientBlackBerry::closePagePopup):
  11302. * WebCoreSupport/DatePickerClient.cpp: Added.
  11303. (WebCore):
  11304. (WebCore::DatePickerClient::DatePickerClient):
  11305. (WebCore::DatePickerClient::~DatePickerClient):
  11306. (WebCore::DatePickerClient::generateHTML):
  11307. (WebCore::DatePickerClient::closePopup):
  11308. (WebCore::DatePickerClient::contentSize):
  11309. (WebCore::DatePickerClient::htmlSource):
  11310. (WebCore::DatePickerClient::setValueAndClosePopup):
  11311. (WebCore::DatePickerClient::didClosePopup):
  11312. (WebCore::DatePickerClient::writeDocument):
  11313. * WebCoreSupport/DatePickerClient.h: Added.
  11314. (WebKit):
  11315. (WebCore):
  11316. (DatePickerClient):
  11317. * WebKitSupport/InputHandler.cpp:
  11318. (BlackBerry::WebKit::InputHandler::openDatePopup):
  11319. 2012-07-10 Adam Barth <abarth@webkit.org>
  11320. WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
  11321. https://bugs.webkit.org/show_bug.cgi?id=90910
  11322. Reviewed by Eric Seidel.
  11323. * Api/WebPage.cpp:
  11324. (BlackBerry::WebKit::WebPagePrivate::init):
  11325. 2012-07-10 Adam Barth <abarth@webkit.org>
  11326. LayoutTestController.dumpConfigurationForViewport should move to Internals
  11327. https://bugs.webkit.org/show_bug.cgi?id=45652
  11328. Reviewed by Eric Seidel.
  11329. * WebKitSupport/DumpRenderTreeSupport.cpp:
  11330. * WebKitSupport/DumpRenderTreeSupport.h:
  11331. (DumpRenderTreeSupport):
  11332. 2012-07-09 Yong Li <yoli@rim.com>
  11333. [BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate
  11334. https://bugs.webkit.org/show_bug.cgi?id=90817
  11335. Reviewed by Rob Buis.
  11336. PR# 174085.
  11337. PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
  11338. This patch also removes unused variable m_parentPopup and its setter.
  11339. * Api/WebPage.cpp:
  11340. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.
  11341. * Api/WebPage_p.h:
  11342. (WebPagePrivate):
  11343. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11344. (WebCore::ChromeClientBlackBerry::closePagePopup):
  11345. * WebCoreSupport/PagePopupBlackBerry.cpp:
  11346. (WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
  11347. (WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.
  11348. * WebCoreSupport/SelectPopupClient.cpp:
  11349. (WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.
  11350. 2012-07-09 Mike Lattanzio <mlattanzio@rim.com>
  11351. [BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
  11352. https://bugs.webkit.org/show_bug.cgi?id=90575
  11353. Reviewed by Rob Buis.
  11354. Refactor meta viewport handling to multiply the developer
  11355. specified scale properties by the devicePixelRatio. This
  11356. required moving the setting of these values until after
  11357. the call to computeViewportAttributes.
  11358. This fixes an isssue where content wider than the meta viewport
  11359. would case a zoom-out-to-fit scenario because we misinterpreted
  11360. the specified initial-scale.
  11361. New test to verify wide content doesn't affect initial-scale:
  11362. ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html
  11363. Internal review from Konrad Piascik, Arvid Nilsson.
  11364. * Api/WebPage.cpp:
  11365. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  11366. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  11367. 2012-07-07 George Staikos <staikos@webkit.org>
  11368. Detach animation clients properly if we clear the web page pointer.
  11369. https://bugs.webkit.org/show_bug.cgi?id=90730
  11370. Reviewed by Adam Treat.
  11371. * Api/WebPage.cpp:
  11372. (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
  11373. * Api/WebPageCompositor.cpp:
  11374. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  11375. (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
  11376. (WebKit):
  11377. (BlackBerry::WebKit::WebPageCompositorPrivate::detach):
  11378. (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
  11379. * Api/WebPageCompositor_p.h:
  11380. (WebPageCompositorPrivate):
  11381. 2012-07-06 Max Feil <mfeil@rim.com>
  11382. [BlackBerry] exitFullScreenForElement() is not working for fullscreen elements in iframes
  11383. https://bugs.webkit.org/show_bug.cgi?id=90327
  11384. Reviewed by Antonio Gomes.
  11385. Fix exit fullscreen problem for elements in iframes. The
  11386. exitFullScreenForElement() call is passed a null element in
  11387. this case, instead of the original element which entered
  11388. fullscreen. If you look in Document.cpp you can see the
  11389. exitFullScreenForElement() call being made on the topDocument
  11390. (which has a null m_fullScreenElement) instead of the iframe's
  11391. document.
  11392. The Chromium and Windows ports get around this problem by
  11393. storing either the fullscreen element or its frame during
  11394. enterFullScreenForElement(), so I will bring the BlackBerry port
  11395. in line with this. See also bug 89817.
  11396. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11397. (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
  11398. (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
  11399. * WebCoreSupport/ChromeClientBlackBerry.h:
  11400. (ChromeClientBlackBerry):
  11401. 2012-07-06 Benjamin C Meyer <bmeyer@rim.com>
  11402. Add an API to explicitly call a JavaScript function with args.
  11403. https://bugs.webkit.org/show_bug.cgi?id=90694
  11404. Currently the Blackberry port doesn't expose the JavaScript
  11405. engine to 3rd parties so they rely upon executeJavaScript
  11406. which can be slower than necessary and unsafe as eval is used.
  11407. This new API provides a way to explicitly call a specific
  11408. JavaScript function with a list of args preventing the case
  11409. where an argument comes from a untrusted source and tries to
  11410. escape the arg list to take control of the JavaScript engine.
  11411. In the future if the Blackberry port introduces a formal
  11412. way to interact with the JavaScript engine this function should
  11413. be removed.
  11414. PR 149294
  11415. Reviewed by Unreviewed
  11416. * Api/WebPage.cpp:
  11417. (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
  11418. (WebKit):
  11419. * Api/WebPage.h:
  11420. 2012-07-05 Charles Wei <charles.wei@torchmobile.com.cn>
  11421. [BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
  11422. https://bugs.webkit.org/show_bug.cgi?id=90588
  11423. Reviewed by Rob Buis.
  11424. Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
  11425. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11426. (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
  11427. 2012-07-04 Hanna Ma <Hanma@rim.com>
  11428. [BlackBerry] Implement device metrics for blackberry.
  11429. https://bugs.webkit.org/show_bug.cgi?id=90494
  11430. RIM PR #159034
  11431. Reviewed by Rob Buis.
  11432. Implement calls to the application to change the device metrics for
  11433. the web inspector.
  11434. * Api/WebPage.cpp:
  11435. (BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
  11436. (WebKit):
  11437. (BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
  11438. * Api/WebPage_p.h:
  11439. (WebPagePrivate):
  11440. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  11441. (WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
  11442. (WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
  11443. (WebCore):
  11444. (WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
  11445. (WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
  11446. * WebCoreSupport/InspectorClientBlackBerry.h:
  11447. (InspectorClientBlackBerry):
  11448. 2012-07-03 Leo Yang <leo.yang@torchmobile.com.cn>
  11449. [BlackBerry] Checkerboard shown when clicking on error page buttons
  11450. https://bugs.webkit.org/show_bug.cgi?id=90152
  11451. RIM PR #161867
  11452. Reviewed by George Staikos.
  11453. r121514 just made the race occur in lower possibility but can't avoid it.
  11454. This path is using another approach to fix the problem. When we are resetting
  11455. backingstore while committing a page we need to suspend backingstore and
  11456. screen update to make sure no other threads can update backingstore and screen.
  11457. * Api/BackingStore.cpp:
  11458. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  11459. * Api/WebPage.cpp:
  11460. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  11461. 2012-07-03 George Staikos <staikos@webkit.org>
  11462. [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
  11463. https://bugs.webkit.org/show_bug.cgi?id=90422
  11464. Reviewed by Rob Buis.
  11465. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11466. (WebCore):
  11467. (WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
  11468. (WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
  11469. * WebCoreSupport/ChromeClientBlackBerry.h:
  11470. (ChromeClientBlackBerry):
  11471. 2012-07-03 George Staikos <staikos@webkit.org>
  11472. [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
  11473. https://bugs.webkit.org/show_bug.cgi?id=90422
  11474. Reviewed by Rob Buis.
  11475. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11476. (WebCore):
  11477. (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
  11478. * WebCoreSupport/ChromeClientBlackBerry.h:
  11479. (ChromeClientBlackBerry):
  11480. 2012-07-03 Jan Keromnes <janx@linux.com>
  11481. Web Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
  11482. https://bugs.webkit.org/show_bug.cgi?id=89939
  11483. Reviewed by Vsevolod Vlasov.
  11484. * WebCoreSupport/inspectorBB.html:
  11485. 2012-07-02 Xiaobo Wang <xbwang@torchmobile.com.cn>
  11486. [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
  11487. https://bugs.webkit.org/show_bug.cgi?id=90271
  11488. Reviewed by George Staikos.
  11489. RIM PR #154707
  11490. Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
  11491. defined by default.
  11492. We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
  11493. need to rebuild webkit before running DRT.
  11494. * Api/WebPage.cpp:
  11495. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  11496. (BlackBerry::WebKit::WebPagePrivate::init):
  11497. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  11498. (BlackBerry::WebKit::WebPage::runLayoutTests):
  11499. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11500. (WebCore::ChromeClientBlackBerry::addMessageToConsole):
  11501. (WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
  11502. (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
  11503. (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
  11504. (WebCore::ChromeClientBlackBerry::createWindow):
  11505. (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
  11506. (WebCore::ChromeClientBlackBerry::setStatusbarText):
  11507. (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
  11508. (WebCore::ChromeClientBlackBerry::keyboardUIMode):
  11509. 2012-07-02 George Staikos <staikos@webkit.org>
  11510. [BlackBerry] Implement cancelVibration, and make sure it's canceled on
  11511. destruction.
  11512. https://bugs.webkit.org/show_bug.cgi?id=90406
  11513. Reviewed by Rob Buis.
  11514. * WebCoreSupport/VibrationClientBlackBerry.cpp:
  11515. (WebCore::VibrationClientBlackBerry::cancelVibration):
  11516. (WebCore::VibrationClientBlackBerry::vibrationDestroyed):
  11517. 2012-07-02 Benjamin Poulain <bpoulain@apple.com>
  11518. Do not do any logging initialization when logging is disabled
  11519. https://bugs.webkit.org/show_bug.cgi?id=90228
  11520. Reviewed by Simon Fraser.
  11521. * Api/BlackBerryGlobal.cpp:
  11522. (BlackBerry::WebKit::globalInitialize):
  11523. 2012-07-01 George Staikos <staikos@webkit.org>
  11524. Clear visited links when clearing history.
  11525. https://bugs.webkit.org/show_bug.cgi?id=90345
  11526. Reviewed by Antonio Gomes.
  11527. * Api/WebPage.cpp:
  11528. (BlackBerry::WebKit::WebPage::clearHistory):
  11529. 2012-06-30 Jason Liu <jason.liu@torchmobile.com.cn>
  11530. [BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
  11531. https://bugs.webkit.org/show_bug.cgi?id=90241
  11532. This issue is caused by single quotes in option's labels.
  11533. We should use the escape character of single quotes in JavaScript's string which
  11534. starts and ends with single quotes.
  11535. So we replace lablels' single quotes with its escape character during generating the
  11536. select popUp's HTML.
  11537. Reviewed by George Staikos.
  11538. * WebCoreSupport/SelectPopupClient.cpp:
  11539. (WebCore::SelectPopupClient::generateHTML):
  11540. 2012-06-30 Jakob Petsovits <jpetsovits@rim.com>
  11541. [BlackBerry] Allow surface resizing for use cases other than rotation.
  11542. https://bugs.webkit.org/show_bug.cgi?id=90295
  11543. RIM PR 171459
  11544. Reviewed by George Staikos.
  11545. A new API method setHasPendingSurfaceSizeChange() is
  11546. introduced for that effect, and used inside of
  11547. setViewportSize() to let the WebPageClient do the
  11548. resizing. Methods are renamed to reflect that this
  11549. is not exclusively meant for rotation anymore.
  11550. * Api/WebPage.cpp:
  11551. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  11552. (BlackBerry::WebKit::WebPage::setScreenOrientation):
  11553. (WebKit):
  11554. (BlackBerry::WebKit::WebPage::setHasPendingSurfaceSizeChange):
  11555. (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
  11556. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  11557. * Api/WebPage.h:
  11558. * Api/WebPageClient.h:
  11559. * Api/WebPage_p.h:
  11560. (WebPagePrivate):
  11561. 2012-06-29 Jacky Jiang <zhajiang@rim.com>
  11562. [BlackBerry] Page jumps after post-pinch-zoom re-render
  11563. https://bugs.webkit.org/show_bug.cgi?id=90282
  11564. Reviewed by Antonio Gomes.
  11565. PR: 170255
  11566. In r120622, we moved ScrollableArea::setConstrainsScrollingToContentEdge(false|true)
  11567. from WebPage::setScrollPosition() to BackingStorePrivate::setScrollingOrZooming()
  11568. to address an overscroll reset issue.
  11569. However, when we are ending bitmap zooming, UI thread can call
  11570. BackingStorePrivate::setScrollingOrZooming(false) before WebKit thread
  11571. calls WebPage::setScrollPosition(), in which case it will set
  11572. ScrollableArea::m_constrainsScrollingToContentEdge to true earlier.
  11573. To fix this, we can cache ScrollableArea::m_constrainsScrollingToContentEdge
  11574. and always set it to false before we set scroll position in WebKit
  11575. thread to avoid scroll position clamping during scrolling, and restore
  11576. it to what it was after that.
  11577. * Api/WebPage.cpp:
  11578. (BlackBerry::WebKit::WebPage::setScrollPosition):
  11579. 2012-06-29 Jakob Petsovits <jpetsovits@rim.com>
  11580. Add blitVisibleContents() as public API.
  11581. https://bugs.webkit.org/show_bug.cgi?id=90211
  11582. Reviewed by Adam Treat.
  11583. We keep blitContents() (with src/dst rectangles)
  11584. for compatibility with older Cascades sprints for now,
  11585. but want to switch to always blitting the full viewport
  11586. and this is a good first step.
  11587. * Api/BackingStore.cpp:
  11588. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  11589. (BlackBerry::WebKit::BackingStore::blitVisibleContents):
  11590. (WebKit):
  11591. * Api/BackingStore.h:
  11592. 2012-06-29 Konrad Piascik <kpiascik@rim.com>
  11593. Don't hardcode target dpi of 160 (it should be 96 on desktop)
  11594. https://bugs.webkit.org/show_bug.cgi?id=88114
  11595. Reviewed by Adam Barth.
  11596. Added new WebSetting to specify what the devicePixelRatio should be.
  11597. Updated the call to computeViewportAttributes.
  11598. * Api/WebPage.cpp:
  11599. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  11600. * Api/WebSettings.cpp:
  11601. (WebKit):
  11602. (BlackBerry::WebKit::WebSettings::standardSettings):
  11603. (BlackBerry::WebKit::WebSettings::devicePixelRatio):
  11604. (BlackBerry::WebKit::WebSettings::setDevicePixelRatio):
  11605. * Api/WebSettings.h:
  11606. * WebKitSupport/DumpRenderTreeSupport.cpp:
  11607. (DumpRenderTreeSupport::dumpConfigurationForViewport):
  11608. 2012-06-28 Jason Liu <jason.liu@torchmobile.com.cn>
  11609. [BlackBerry] Selection items show as garbage for non-ascii characters.
  11610. https://bugs.webkit.org/show_bug.cgi?id=89969
  11611. Add charset utf-8 to the select popup's page.
  11612. Reviewed by Antonio Gomes.
  11613. * WebCoreSupport/SelectPopupClient.cpp:
  11614. (WebCore::SelectPopupClient::generateHTML):
  11615. 2012-06-28 Leo Yang <leo.yang@torchmobile.com.cn>
  11616. [BlackBerry] Checkerboard shown when clicking on error page buttons
  11617. https://bugs.webkit.org/show_bug.cgi?id=90152
  11618. RIM PR #161867
  11619. Reviewed by George Staikos.
  11620. Reset m_hasBlitJobs when resetting tiles to prevent ui thread from drawing checkerboard unintentionally.
  11621. * Api/BackingStore.cpp:
  11622. (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
  11623. 2012-06-27 Andrew Lo <anlo@rim.com>
  11624. [BlackBerry] Selection overlay can become visible after it has been hidden
  11625. https://bugs.webkit.org/show_bug.cgi?id=90105
  11626. Reviewed by George Staikos.
  11627. When SelectionOverlay::hide is called from UI thread,
  11628. rather than setting the override opacity, dispatch to the
  11629. WebKit thread, which removes the overlay (normal case).
  11630. Internal PR164183.
  11631. Internally Reviewed by: Arvid Nilsson.
  11632. * Api/WebPage.cpp:
  11633. (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
  11634. (BlackBerry::WebKit::WebPage::selectionOverlay):
  11635. * Api/WebPage_p.h:
  11636. (WebPagePrivate):
  11637. * Api/WebSelectionOverlay.h:
  11638. * WebKitSupport/SelectionOverlay.cpp:
  11639. (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
  11640. (BlackBerry::WebKit::SelectionOverlay::hide):
  11641. * WebKitSupport/SelectionOverlay.h:
  11642. (BlackBerry::WebKit::SelectionOverlay::create):
  11643. (SelectionOverlay):
  11644. 2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
  11645. JSLock should be per-JSGlobalData
  11646. https://bugs.webkit.org/show_bug.cgi?id=89123
  11647. Reviewed by Geoffrey Garen.
  11648. Changed all sites that used JSLock to instead use the new JSLockHolder
  11649. and pass in the correct JS context that the code is about to interact with that
  11650. needs protection. Also added a couple JSLocks to places that didn't already
  11651. have it that needed it.
  11652. * Api/BlackBerryGlobal.cpp:
  11653. (BlackBerry::WebKit::clearMemoryCaches):
  11654. * WebCoreSupport/ClientExtension.cpp:
  11655. * WebCoreSupport/PagePopupBlackBerry.cpp:
  11656. (WebCore::PagePopupBlackBerry::installDomFunction):
  11657. * WebKitSupport/DumpRenderTreeSupport.cpp:
  11658. (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
  11659. 2012-06-27 Jacky Jiang <zhajiang@rim.com>
  11660. [BlackBerry] Wrong scale after leaving fullscreen <video>
  11661. https://bugs.webkit.org/show_bug.cgi?id=89546
  11662. Reviewed by Antonio Gomes.
  11663. PR: 164948
  11664. When we were entering fullscreen, the current scale A was clamped to a
  11665. greater minimum scale B as we relayouted the contents during the change
  11666. of the viewport size. When leaving fullscreen, we still used that scale
  11667. B as the current scale which was incorrect.
  11668. To fix this, we can save the current scale when entering fullscreen and
  11669. restore it when leaving fullscreen.
  11670. * Api/WebPage.cpp:
  11671. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  11672. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  11673. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  11674. * Api/WebPage_p.h:
  11675. (WebPagePrivate):
  11676. 2012-06-27 Jacky Jiang <zhajiang@rim.com>
  11677. [BlackBerry] Scale was incorrect when reloading a simple web page after initial load
  11678. https://bugs.webkit.org/show_bug.cgi?id=88889
  11679. Reviewed by Antonio Gomes.
  11680. PR: 164442
  11681. For FrameLoadTypeStandard load, the layout timer can be fired which can
  11682. call dispatchDidFirstVisuallyNonEmptyLayout() after the load Finished
  11683. state, in which case the web page will have no chance to zoom to
  11684. initial scale. We should give it a chance as well as FrameLoadTypeSame
  11685. load.
  11686. * Api/WebPage.cpp:
  11687. (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
  11688. 2012-06-26 Mike Fenton <mifenton@rim.com>
  11689. [BlackBerry] Add WebPage interface for Async spell check.
  11690. https://bugs.webkit.org/show_bug.cgi?id=89999
  11691. Reviewed by Rob Buis.
  11692. PR 124517.
  11693. Add interface for IMS async spell checking.
  11694. Reviewed Internally by Nima Ghanavatian.
  11695. * Api/WebPage.cpp:
  11696. (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
  11697. (WebKit):
  11698. * Api/WebPage.h:
  11699. * Api/WebPageClient.h:
  11700. * WebKitSupport/InputHandler.cpp:
  11701. (WebKit):
  11702. (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
  11703. * WebKitSupport/InputHandler.h:
  11704. (InputHandler):
  11705. 2012-06-26 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  11706. [BlackBerry] Limit session storage quota to 5MB by default
  11707. https://bugs.webkit.org/show_bug.cgi?id=89941
  11708. Reviewed by Rob Buis.
  11709. Limit session storage quota to 5MB by default for BlackBerry
  11710. porting.
  11711. Internally reviewed by George Staikos.
  11712. * Api/WebPage.cpp:
  11713. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  11714. * Api/WebSettings.cpp:
  11715. (WebKit):
  11716. (BlackBerry::WebKit::WebSettings::standardSettings):
  11717. (BlackBerry::WebKit::WebSettings::sessionStorageQuota):
  11718. (BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
  11719. * Api/WebSettings.h:
  11720. 2012-06-26 Charles Wei <charles.wei@torchmobile.com.cn>
  11721. [BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
  11722. https://bugs.webkit.org/show_bug.cgi?id=89960
  11723. Reviewed by Antonio Gomes.
  11724. We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
  11725. HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
  11726. in a page, even though only the one in fullscreen mode will process this.
  11727. With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
  11728. which is either a plugin, or an Video element.
  11729. * Api/WebPage.cpp:
  11730. (BlackBerry::WebKit::WebPage::notifySwipeEvent):
  11731. 2012-06-25 Leo Yang <leo.yang@torchmobile.com.cn>
  11732. [BlackBerry] Fill more data in device motion event
  11733. https://bugs.webkit.org/show_bug.cgi?id=89857
  11734. Reviewed by Antonio Gomes.
  11735. Reviewed internally by Robin Cao.
  11736. Fill acceleration and rotation rate into DeviceMotionData.
  11737. * WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
  11738. (DeviceMotionClientBlackBerry::onMotion):
  11739. 2012-06-25 Yong Li <yoli@rim.com>
  11740. [BlackBerry] Add JSC statistics into about:memory
  11741. https://bugs.webkit.org/show_bug.cgi?id=89779
  11742. Reviewed by Rob Buis.
  11743. Add detailed JS memory statistics to about:memory page.
  11744. * WebCoreSupport/AboutData.cpp:
  11745. (WebCore::dumpJSCTypeCountSetToTableHTML):
  11746. (WebCore):
  11747. (WebCore::memoryPage):
  11748. 2012-06-25 Crystal Zhang <haizhang@rim.com>
  11749. [BlackBerry] Use AIR controls if client doesn't support HTML control
  11750. https://bugs.webkit.org/show_bug.cgi?id=89777
  11751. Reviewed by Yong Li.
  11752. Currently HTML controls depend on client implementing CreateWindow event, for those clients
  11753. that don't implement CreateWindow event, use old AIR controls so we don't break them.
  11754. PR 163818.
  11755. Internal reviewed by Mike Fenton.
  11756. * Api/WebPageClient.h:
  11757. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  11758. (WebCore::ChromeClientBlackBerry::openPagePopup):
  11759. * WebCoreSupport/PagePopupBlackBerry.cpp:
  11760. (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
  11761. * WebCoreSupport/PagePopupBlackBerry.h:
  11762. (PagePopupBlackBerry):
  11763. * WebKitSupport/InputHandler.cpp:
  11764. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  11765. 2012-06-25 Rob Buis <rbuis@rim.com>
  11766. [BlackBerry] Require text editable element to be enabled for VKB
  11767. https://bugs.webkit.org/show_bug.cgi?id=89876
  11768. Reviewed by Yong Li.
  11769. After bug 58837 got in, children of <fieldset> now can inherit the disabled
  11770. state of the fieldset. When trying for instance fast/forms/fieldset/fieldset-disabled.html,
  11771. it can be seen that when they are visually disabled, the input handling can still be triggered. So
  11772. add an extra check to isTextBasedContentEditableElement that the element is enabled.
  11773. Reviewed internally by Mike Fenton.
  11774. * WebKitSupport/DOMSupport.cpp:
  11775. (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
  11776. 2012-06-24 Simon Fraser <simon.fraser@apple.com>
  11777. Rename isPositioned to isOutOfFlowPositioned for clarity
  11778. https://bugs.webkit.org/show_bug.cgi?id=89836
  11779. Reviewed by Antti Koivisto.
  11780. RenderObject and RenderStyle had an isPositioned() method that was
  11781. confusing, because it excluded relative positioning. Rename to
  11782. isOutOfFlowPositioned(), which makes it clearer that it only applies
  11783. to absolute and fixed positioning.
  11784. Simple rename; no behavior change.
  11785. * Api/WebPage.cpp:
  11786. (BlackBerry::WebKit::isPositionedContainer):
  11787. (BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
  11788. (BlackBerry::WebKit::isFixedPositionedContainer):
  11789. 2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
  11790. Unreviewed, rolling out r121058.
  11791. http://trac.webkit.org/changeset/121058
  11792. https://bugs.webkit.org/show_bug.cgi?id=89809
  11793. Patch causes plugins tests to crash in GTK debug builds
  11794. (Requested by zdobersek on #webkit).
  11795. * Api/BlackBerryGlobal.cpp:
  11796. (BlackBerry::WebKit::clearMemoryCaches):
  11797. * WebCoreSupport/ClientExtension.cpp:
  11798. * WebCoreSupport/PagePopupBlackBerry.cpp:
  11799. (WebCore::PagePopupBlackBerry::installDomFunction):
  11800. * WebKitSupport/DumpRenderTreeSupport.cpp:
  11801. (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
  11802. 2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
  11803. JSLock should be per-JSGlobalData
  11804. https://bugs.webkit.org/show_bug.cgi?id=89123
  11805. Reviewed by Gavin Barraclough.
  11806. Changed all sites that used JSLock to instead use the new JSLockHolder
  11807. and pass in the correct JS context that the code is about to interact with that
  11808. needs protection.
  11809. * Api/BlackBerryGlobal.cpp:
  11810. (BlackBerry::WebKit::clearMemoryCaches):
  11811. * WebCoreSupport/ClientExtension.cpp:
  11812. * WebCoreSupport/PagePopupBlackBerry.cpp:
  11813. (WebCore::PagePopupBlackBerry::installDomFunction):
  11814. * WebKitSupport/DumpRenderTreeSupport.cpp:
  11815. (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
  11816. 2012-06-22 Andrew Lo <anlo@rim.com>
  11817. [BlackBerry] Tap highlight fade animations are added to overlay continuously during pinch zoom.
  11818. https://bugs.webkit.org/show_bug.cgi?id=89772
  11819. Reviewed by Antonio Gomes.
  11820. When pinch zooming, DefaultTapHighlight::hide is continuously
  11821. called from the UI thread. This resulted in fade animations being
  11822. created and added to the override overlay continuously.
  11823. This patch moves the m_visible check so that it applies for both
  11824. threads.
  11825. Internal PR164183
  11826. * WebKitSupport/DefaultTapHighlight.cpp:
  11827. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  11828. (BlackBerry::WebKit::DefaultTapHighlight::hide):
  11829. * WebKitSupport/DefaultTapHighlight.h:
  11830. (DefaultTapHighlight):
  11831. 2012-06-22 Yong Li <yoli@rim.com>
  11832. [BlackBerry] Set WebSecurityEnabled flag accordingly.
  11833. https://bugs.webkit.org/show_bug.cgi?id=89602
  11834. Reviewed by Rob Buis.
  11835. Disable web security checks if needed.
  11836. * Api/WebPage.cpp:
  11837. (BlackBerry::WebKit::WebPagePrivate::init):
  11838. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  11839. 2012-06-22 Parth Patel <parpatel@rim.com>
  11840. [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
  11841. https://bugs.webkit.org/show_bug.cgi?id=89684
  11842. Reviewed by Yong Li.
  11843. Build Fix-Typo Update setting instance access to use instance() instead of get().
  11844. * WebKitSupport/InputHandler.cpp:
  11845. (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
  11846. 2012-06-22 Amy Ousterhout <aousterh@chromium.org>
  11847. Renamed DeviceOrientation to DeviceOrientationData
  11848. https://bugs.webkit.org/show_bug.cgi?id=88663
  11849. Reviewed by Steve Block.
  11850. Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation.
  11851. This change makes DeviceOrientationData consistent with DeviceMotionData.
  11852. * WebCoreSupport/DeviceOrientationClientBlackBerry.h:
  11853. (DeviceOrientationClientBlackBerry):
  11854. 2012-06-22 Joseph Pecoraro <pecoraro@apple.com>
  11855. Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported
  11856. https://bugs.webkit.org/show_bug.cgi?id=89743
  11857. Reviewed by Yury Semikhatsky.
  11858. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  11859. (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
  11860. 2012-06-21 Parth Patel <parpatel@rim.com>
  11861. [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
  11862. https://bugs.webkit.org/show_bug.cgi?id=89684
  11863. Reviewed by Yong Li.
  11864. Update setting instance access to use instance() instead of get().
  11865. * Api/BlackBerryGlobal.cpp:
  11866. (BlackBerry::WebKit::globalInitialize):
  11867. * Api/WebPage.cpp:
  11868. (BlackBerry::WebKit::WebPagePrivate::init):
  11869. (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
  11870. * WebCoreSupport/AboutData.cpp:
  11871. (WebCore::configPage):
  11872. * WebCoreSupport/CacheClientBlackBerry.cpp:
  11873. (WebCore::CacheClientBlackBerry::updateCacheCapacity):
  11874. * WebKitSupport/FatFingers.cpp:
  11875. (BlackBerry::WebKit::FatFingers::getPaddings):
  11876. * WebKitSupport/InputHandler.cpp:
  11877. (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
  11878. (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
  11879. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  11880. * WebKitSupport/SurfacePool.cpp:
  11881. (BlackBerry::WebKit::SurfacePool::initialize):
  11882. 2012-06-21 Genevieve Mak <gmak@rim.com>
  11883. Add a parameter to handletTouchPoint to bypass FatFingers
  11884. on touch up. There are some cases where the user may drag
  11885. their finger off the element and we want to use the actual
  11886. touch point instead of the FatFingers adjusted point.
  11887. https://bugs.webkit.org/show_bug.cgi?id=89677
  11888. Reviewed by Antonio Gomes.
  11889. * Api/WebPage.cpp:
  11890. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  11891. * Api/WebPage.h:
  11892. * WebKitSupport/TouchEventHandler.cpp:
  11893. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  11894. * WebKitSupport/TouchEventHandler.h:
  11895. (TouchEventHandler):
  11896. 2012-06-21 Mike Fenton <mifenton@rim.com>
  11897. [BlackBerry] Input mode should adapt automatically to settings changes
  11898. https://bugs.webkit.org/show_bug.cgi?id=89595
  11899. Reviewed by Antonio Gomes.
  11900. PR 167540.
  11901. Add helper function to check if input is enabled so that
  11902. the override settings can be applied at any time.
  11903. Reviewed Internally by Gen Mak.
  11904. * Api/WebPage.cpp:
  11905. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  11906. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  11907. * WebKitSupport/InputHandler.cpp:
  11908. (BlackBerry::WebKit::InputHandler::isInputModeEnabled):
  11909. (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
  11910. (BlackBerry::WebKit::InputHandler::setElementFocused):
  11911. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  11912. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  11913. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  11914. (BlackBerry::WebKit::InputHandler::setComposingText):
  11915. * WebKitSupport/InputHandler.h:
  11916. * WebKitSupport/TouchEventHandler.cpp:
  11917. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  11918. 2012-06-20 Jacky Jiang <zhajiang@rim.com>
  11919. Add a != operator to ViewportArguments
  11920. https://bugs.webkit.org/show_bug.cgi?id=87505
  11921. Reviewed by Antonio Gomes.
  11922. Patch by Jacky Jiang <zhajiang@rim.com>
  11923. Use != operator of ViewportArguments.
  11924. * Api/WebPage.cpp:
  11925. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  11926. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  11927. * Api/WebViewportArguments.cpp:
  11928. (BlackBerry::WebKit::WebViewportArguments::operator!=):
  11929. 2012-06-20 Christopher Hutten-Czapski <chutten@rim.com>
  11930. [BlackBerry] Add an API to immediately enable cross-site XHR
  11931. https://bugs.webkit.org/show_bug.cgi?id=89594
  11932. Internally Reviewed by Yong Li.
  11933. Reviewed by Rob Buis.
  11934. There is no API to disable it as clients may rely on legacy behaviour
  11935. of not disabling until the next frame load.
  11936. * Api/WebPage.cpp:
  11937. (BlackBerry::WebKit::enableCrossSiteXHRRecursively):
  11938. (WebKit):
  11939. (BlackBerry::WebKit::WebPagePrivate::enableCrossSiteXHR):
  11940. (BlackBerry::WebKit::WebPage::enableCrossSiteXHR):
  11941. * Api/WebPage.h:
  11942. * Api/WebPage_p.h:
  11943. (WebPagePrivate):
  11944. 2012-06-20 Konrad Piascik <kpiascik@rim.com>
  11945. [BlackBerry] Enable setAcceleratedCompositingForFixedPositionEnabled
  11946. https://bugs.webkit.org/show_bug.cgi?id=89575
  11947. Reviewed by Antonio Gomes.
  11948. Enable the flag so that we get position:fixed elemetns to be rendered
  11949. using accelerated compositing.
  11950. * Api/WebPage.cpp:
  11951. (BlackBerry::WebKit::WebPagePrivate::init):
  11952. 2012-06-20 Julien Chaffraix <jchaffraix@webkit.org>
  11953. Use IntSize in RenderLayer to represent scroll offsets
  11954. https://bugs.webkit.org/show_bug.cgi?id=89154
  11955. Reviewed by Eric Seidel.
  11956. * Api/WebPage.cpp:
  11957. (BlackBerry::WebKit::WebPagePrivate::scrollRenderer):
  11958. Updated to pass an IntSize to scrollToOffset.
  11959. 2012-06-19 Yong Li <yoli@rim.com>
  11960. [BlackBerry] Should check the return value of fromUTF8() before executing the script.
  11961. https://bugs.webkit.org/show_bug.cgi?id=89500
  11962. Reviewed by Rob Buis.
  11963. PR# 166623.
  11964. WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
  11965. before executing the script to avoid potential crash on invalid script source.
  11966. * Api/WebPage.cpp:
  11967. (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
  11968. 2012-06-19 Jakob Petsovits <jpetsovits@rim.com>
  11969. [BlackBerry] Missing notifyContentRendered() when resuming rendering
  11970. https://bugs.webkit.org/show_bug.cgi?id=89507
  11971. RIM PR 150049
  11972. Reviewed by Antonio Gomes.
  11973. All the current calls to notifyContentRendered() are
  11974. located in the RenderQueue, but this omits the case
  11975. when we force rendering from resumeBackingStore()
  11976. after rendering had been suspended for a while.
  11977. * Api/WebPage.cpp:
  11978. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  11979. 2012-06-19 Sergio Villar Senin <svillar@igalia.com>
  11980. Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
  11981. https://bugs.webkit.org/show_bug.cgi?id=67582
  11982. Reviewed by David Levin.
  11983. Use synchronousNativeIconForPageURL() to retrieve favicons.
  11984. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  11985. (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
  11986. 2012-06-18 Antonio Gomes <agomes@rim.com>
  11987. [BlackBerry] Overscroll can get reset while interacting with a page, due to style recalculations and scroll position clamping
  11988. https://bugs.webkit.org/show_bug.cgi?id=89371
  11989. PR #166982
  11990. Reviewed by Adam Treat.
  11991. While scrolling, the WebKit thread gets intercalated WebPage::setScrollPosition
  11992. calls dispatched from the UI thread. These calls are wrapped with
  11993. ScrollableArea::setConstrainsScrollingToContentEdge(false|true) calls, which
  11994. can clamp the scroll position (removes overscroll) if set to 'true'.
  11995. The following situation can happen: user is scrolling, and WebKit
  11996. thread is not in the middle of a WebPage::setScrollPosition call
  11997. (so setConstrainsScrollingToContentEdge is 'true'), and a relayout happens.
  11998. In this scenario, the scroll position will get clamped to 0,0, removing any
  11999. possible overscrolling.
  12000. See the stack trace below, paying special attention to frame 16:
  12001. #0 ScrollHandlerUserInterfaceThread::updateScrollPosition
  12002. #1 0x782b4a3e in WebPageClientImpl::scrollChanged
  12003. #2 0x78147484 in BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged
  12004. #3 0x78171f68 in BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation
  12005. #4 0x7816480a in WebCore::ChromeClientBlackBerry::scroll
  12006. #5 0x7a78b290 in WebCore::Chrome::scroll
  12007. #6 0x7a7ac8d0 in WebCore::FrameView::scrollContentsFastPath
  12008. #7 0x7a7eba72 in WebCore::ScrollView::scrollContents
  12009. #8 0x7a7ebb34 in WebCore::ScrollView::scrollTo
  12010. #9 0x7a7a8dae in WebCore::FrameView::scrollTo
  12011. #10 0x7a7e966e in WebCore::ScrollView::setScrollOffset
  12012. #11 0x7a7e77cc in WebCore::ScrollableArea::scrollPositionChanged
  12013. #12 0x7a7e7048 in WebCore::ScrollAnimator::notifyPositionChanged
  12014. #13 0x7a7e700c in WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation
  12015. #14 0x7a7e7588 in WebCore::ScrollableArea::scrollToOffsetWithoutAnimation
  12016. #16 WebCore::ScrollView::updateScrollbars
  12017. #18 WebCore::ScrollView::setContentsSize
  12018. #19 0x7a7accd8 in WebCore::FrameView::setContentsSize
  12019. #20 0x7a7a85f4 in WebCore::FrameView::adjustViewSize
  12020. #22 WebCore::FrameView::layout
  12021. #23 0x7a59d66e in WebCore::Document::updateLayoutIgnorePendingStylesheets
  12022. #24 0x7a5ada92 in WebCore::Element::offsetHeight
  12023. #25 0x7ab226b6 in WebCore::jsElementOffsetHeight
  12024. #27 JSC::JSValue::get
  12025. #28 0x796dd662 in JSC::JITStubThunked_op_get_by_id_generic
  12026. Patch fixes this issue by tying ScrollableArea::setConstrainsScrollingToContentEdge
  12027. to BackingStore::m_isZoomingOrScrolling, when we are sure clamping should not happen.
  12028. * Api/BackingStore.cpp:
  12029. (BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
  12030. * Api/WebPage.cpp:
  12031. (BlackBerry::WebKit::WebPage::setScrollPosition):
  12032. 2012-06-15 Eli Fidler <efidler@rim.com>
  12033. [BlackBerry] Use platform font settings for the standard settings.
  12034. https://bugs.webkit.org/show_bug.cgi?id=89232
  12035. Reviewed by Rob Buis.
  12036. RIM PR 159708
  12037. * Api/WebSettings.cpp:
  12038. (BlackBerry::WebKit::WebSettings::standardSettings):
  12039. 2012-06-15 Crystal Zhang <haizhang@rim.com>
  12040. [BlackBerry] Remove touch events handling hook for popup
  12041. https://bugs.webkit.org/show_bug.cgi?id=89245
  12042. Reviewed by Rob Buis.
  12043. In the old patches we create our own WebPage for popup, so we need to hook up our own
  12044. touch handling functions, since we don't use our own WebPage any more, no need to keep
  12045. the touch handling code, because it just does nothing other than passing out the events
  12046. which might cause the touch events being handled twice.
  12047. * Api/WebPage.cpp:
  12048. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  12049. * WebCoreSupport/PagePopupBlackBerry.cpp:
  12050. * WebCoreSupport/PagePopupBlackBerry.h:
  12051. (PagePopupBlackBerry):
  12052. 2012-06-15 Antonio Gomes <agomes@rim.com>
  12053. [BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
  12054. https://bugs.webkit.org/show_bug.cgi?id=89227
  12055. PR #146642
  12056. Reviewed by Rob Buis.
  12057. Make use of the Settings::supportsMouseDevice setting in order to
  12058. prevent mouse move event to fire as a response to a scroll action.
  12059. We might still want to dynamically toggle this setting ON, in case for
  12060. example of a mouse wheel driven scroll action, but we can revisit it
  12061. when it becomes a fully supported/primary use case.
  12062. Internally reviewed by Eli Fidler.
  12063. * Api/WebPage.cpp:
  12064. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  12065. * Api/WebSettings.cpp:
  12066. (WebKit):
  12067. (BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
  12068. (BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):
  12069. * Api/WebSettings.h:
  12070. 2012-06-15 Jacky Jiang <zhajiang@rim.com>
  12071. [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen
  12072. https://bugs.webkit.org/show_bug.cgi?id=89211
  12073. Reviewed by Rob Buis.
  12074. Patch by Jacky Jiang <zhajiang@rim.com>
  12075. PR: 135215
  12076. Make simpler rules for zoom to fit scale:
  12077. - Zoom to fit horizontally first without clamping the contents width.
  12078. - Zoom to fit vertically instead without clamping the contents height
  12079. if the horizontal zoom to fit can cause a grey area below the web
  12080. page. Get rid of the virtual viewport guard as there may be cases
  12081. that zooming can cause a grey area without a virtual viewport.
  12082. - Clamp the scale by the minimum zoom to fit scale 0.25 and apply
  12083. this rule to image documents as well. This minimum scale can be
  12084. changed if there is a better vaule in the future.
  12085. In this way, we can get rid of the issue that many web pages don't fit
  12086. the screen.
  12087. Reviewed internally by Arvid Nilsson.
  12088. * Api/WebPage.cpp:
  12089. (WebKit):
  12090. (BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
  12091. 2012-06-15 Yong Li <yoli@rim.com>
  12092. [BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
  12093. https://bugs.webkit.org/show_bug.cgi?id=89210
  12094. Reviewed by Antonio Gomes.
  12095. Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
  12096. calling them is neither nessary nor safe.
  12097. * Api/BackingStore.cpp:
  12098. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  12099. (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
  12100. (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
  12101. * WebKitSupport/BackingStoreClient.cpp:
  12102. * WebKitSupport/BackingStoreClient.h:
  12103. (BackingStoreClient):
  12104. 2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
  12105. Unreviewed, rolling out r120404.
  12106. http://trac.webkit.org/changeset/120404
  12107. https://bugs.webkit.org/show_bug.cgi?id=89193
  12108. This patch breaks [BlackBerry]'s text selection handles moving
  12109. in editable elements. (Requested by Sean1 on #webkit).
  12110. * WebKitSupport/SelectionHandler.cpp:
  12111. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  12112. 2012-06-14 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  12113. [BlackBerry] Selection - Crash when manipulating selection by dragging handle
  12114. https://bugs.webkit.org/show_bug.cgi?id=89160
  12115. RIMBUG:164970
  12116. Avoid to set position in shadow tree to the new selection's base. It
  12117. crashes when setting a shadow position to a selection' base.
  12118. Reviewed by Antonio Gomes.
  12119. * WebKitSupport/SelectionHandler.cpp:
  12120. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  12121. 2012-06-14 Mary Wu <mary.wu@torchmobile.com.cn>
  12122. [BlackBerry] empty plugin cause browser hang
  12123. https://bugs.webkit.org/show_bug.cgi?id=89091
  12124. Reviewed by Rob Buis.
  12125. Add check before clean pluginView in FrameLoaderBlackBerry in case
  12126. it didn't have any content.
  12127. RIM PR# 165336
  12128. Reviewed internally by George Staikos
  12129. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  12130. (WebCore::FrameLoaderClientBlackBerry::finishedLoading):
  12131. 2012-06-14 Genevieve Mak <gmak@rim.com>
  12132. Always convert touch events to mouse events if the
  12133. meta-tag TouchEventMode::PureWithMouseConversion is set.
  12134. Minor style fix.
  12135. https://bugs.webkit.org/show_bug.cgi?id=89115
  12136. Reviewed by Antonio Gomes.
  12137. Reviewed Internally by Antonio Gomes.
  12138. * WebKitSupport/TouchEventHandler.cpp:
  12139. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  12140. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  12141. 2012-06-14 Chris Guan <chris.guan@torchmobile.com.cn>
  12142. [Blackberry] add a new Api named setAllowNotification
  12143. https://bugs.webkit.org/show_bug.cgi?id=88950
  12144. Reviewed by Antonio Gomes.
  12145. * Api/WebPage.cpp:
  12146. (BlackBerry::WebKit::WebPage::setAllowNotification):
  12147. (WebKit):
  12148. * Api/WebPage.h:
  12149. 2012-06-13 Crystal Zhang <haizhang@rim.com>
  12150. [BlackBerry] Apply New Style and JS for Select Popup
  12151. https://bugs.webkit.org/show_bug.cgi?id=89020
  12152. Reviewed by Rob Buis.
  12153. PR 162854
  12154. Use new styled CSS files for select popup, also remove most JS functions
  12155. to a separate JS file, only pass the parameters to JS, and use new python
  12156. script for data generating, as the old one is too simple and problematic.
  12157. * WebCoreSupport/SelectPopupClient.cpp:
  12158. (WebCore::SelectPopupClient::generateHTML):
  12159. 2012-06-13 Amy Ousterhout <aousterh@chromium.org>
  12160. Rename currentDeviceMotion to lastMotion in DeviceMotionClient
  12161. https://bugs.webkit.org/show_bug.cgi?id=88854
  12162. Reviewed by Adam Barth.
  12163. Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
  12164. This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.
  12165. * WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
  12166. (DeviceMotionClientBlackBerry::lastMotion):
  12167. (DeviceMotionClientBlackBerry::onMotion):
  12168. * WebCoreSupport/DeviceMotionClientBlackBerry.h:
  12169. (DeviceMotionClientBlackBerry):
  12170. 2012-06-13 Robin Cao <robin.cao@torchmobile.com.cn>
  12171. [BlackBerry] Enable MEDIA_STREAM by default
  12172. https://bugs.webkit.org/show_bug.cgi?id=88849
  12173. Reviewed by Antonio Gomes.
  12174. * Api/WebPage.cpp:
  12175. (BlackBerry::WebKit::WebPagePrivate::init):
  12176. * WebCoreSupport/UserMediaClientImpl.cpp: Added.
  12177. (WebCore):
  12178. (WebCore::UserMediaClientImpl::UserMediaClientImpl):
  12179. (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
  12180. (WebCore::UserMediaClientImpl::pageDestroyed):
  12181. (WebCore::UserMediaClientImpl::requestUserMedia):
  12182. (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
  12183. * WebCoreSupport/UserMediaClientImpl.h: Added.
  12184. (WebKit):
  12185. (WebCore):
  12186. (UserMediaClientImpl):
  12187. 2012-06-12 Arvid Nilsson <anilsson@rim.com>
  12188. [BlackBerry] Crash when rendering web page that's being destroyed
  12189. https://bugs.webkit.org/show_bug.cgi?id=88915
  12190. Reviewed by Rob Buis.
  12191. PR #164943
  12192. This was a null pointer dereference that happened when the compositor
  12193. was asked to render after being disconnected from its web page.
  12194. * Api/WebPageCompositor.cpp:
  12195. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  12196. 2012-06-12 Jacky Jiang <zhajiang@rim.com>
  12197. [BlackBerry] Scale was incorrect when reloading a simple web page after initial load
  12198. https://bugs.webkit.org/show_bug.cgi?id=88889
  12199. Reviewed by Adam Treat.
  12200. Patch by Jacky Jiang <zhajiang@rim.com>
  12201. PR: 164442
  12202. When we were reloading a web page with the load type FrameLoadTypeSame
  12203. after the initial load, the first layout timer was fired after the load
  12204. Finished state, in which case the web page would have no chance to zoom
  12205. to the initial scale during the layout as it was only for load
  12206. Committed state. This patch takes care of it.
  12207. * Api/WebPage.cpp:
  12208. (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
  12209. (BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
  12210. (WebKit):
  12211. (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
  12212. * Api/WebPage_p.h:
  12213. (WebPagePrivate):
  12214. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  12215. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
  12216. 2012-06-12 Crystal Zhang <haizhang@rim.com>
  12217. [BlackBerry] Fix crash in InputHandler
  12218. https://bugs.webkit.org/show_bug.cgi?id=88808
  12219. Reviewed by Antonio Gomes.
  12220. m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().
  12221. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12222. (WebCore::ChromeClientBlackBerry::chromeDestroyed():
  12223. * WebKitSupport/InputHandler.cpp:
  12224. (BlackBerry::WebKit::InputHandler::~InputHandler):
  12225. 2012-06-12 Yong Li <yoli@rim.com>
  12226. [BlackBerry] Use a safer way to shrink JS memory usage
  12227. https://bugs.webkit.org/show_bug.cgi?id=88811
  12228. Reviewed by Antonio Gomes.
  12229. We should just make a GC request and JSC will check if it is safe to do anything.
  12230. * Api/BlackBerryGlobal.cpp:
  12231. (BlackBerry::WebKit::clearMemoryCaches):
  12232. 2012-06-11 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  12233. [BlackBerry] Autofill feature implementation for BlackBerry porting
  12234. https://bugs.webkit.org/show_bug.cgi?id=85577
  12235. Reviewed by Rob Buis.
  12236. Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
  12237. is same as the procedure in dispatchWillSendSubmitEvent.
  12238. Some sites will redirect to other url in its login process, which will cause the
  12239. user get notified to save credentials for this provisional redirecting url if we
  12240. put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
  12241. sure we only save the autofill data before the submit event is fired.
  12242. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  12243. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
  12244. 2012-06-11 Antonio Gomes <agomes@rim.com>
  12245. [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
  12246. https://bugs.webkit.org/show_bug.cgi?id=88809
  12247. Reviewed by Rob Buis.
  12248. Adjust the media container dimensions, whenever the FrameView::frameRect
  12249. (aka viewport rect) changes
  12250. Reviewed internally by Jacky Jiang.
  12251. * Api/WebPage.cpp:
  12252. (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
  12253. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12254. (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
  12255. 2012-06-09 Antonio Gomes <agomes@rim.com>
  12256. [BlackBerry] browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen
  12257. https://bugs.webkit.org/show_bug.cgi?id=88719
  12258. PR #164026
  12259. Reviewed by Rob Buis.
  12260. Instead of using WebPage's viewport size, which suffers from
  12261. dealing with transformed coordinates, viewport metatag changes,
  12262. etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
  12263. which abstract all these variations.
  12264. It fixes an overscale issue we were having when video player entered
  12265. fullscreen, and webpage had viewport metatag set.
  12266. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12267. (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
  12268. 2012-06-11 Sam Weinig <sam@webkit.org>
  12269. Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
  12270. https://bugs.webkit.org/show_bug.cgi?id=88723
  12271. Reviewed by Dan Bernstein.
  12272. * WebKitSupport/InPageSearchManager.cpp:
  12273. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  12274. 2012-06-10 Antonio Gomes <agomes@rim.com>
  12275. [BlackBerry] Make media (<video> and <audio>) slide draggable again
  12276. https://bugs.webkit.org/show_bug.cgi?id=88742
  12277. PR #158199
  12278. Reviewed by George Staikos.
  12279. First check if the element is a range type then gets its
  12280. shadow DOM ancestor.
  12281. * WebKitSupport/TouchEventHandler.cpp:
  12282. (BlackBerry::WebKit::shouldConvertTouchToMouse):
  12283. 2012-06-08 Crystal Zhang <haizhang@rim.com>
  12284. [BlackBerry] Fix crash on PagePopupChromeClient
  12285. https://bugs.webkit.org/show_bug.cgi?id=88675
  12286. Reviewed by Antonio Gomes.
  12287. PR 163672.
  12288. Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
  12289. because update() is problematic. Also no need to save pointer in InputHandler.
  12290. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12291. (WebCore::ChromeClientBlackBerry::openPagePopup):
  12292. (WebCore::ChromeClientBlackBerry::closePagePopup):
  12293. * WebKitSupport/InputHandler.cpp:
  12294. (BlackBerry::WebKit::InputHandler::InputHandler):
  12295. (BlackBerry::WebKit::InputHandler::~InputHandler):
  12296. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  12297. * WebKitSupport/InputHandler.h:
  12298. (WebCore):
  12299. (InputHandler):
  12300. 2012-06-08 Eli Fidler <efidler@rim.com>
  12301. [BlackBerry] Default font settings are getting deleted
  12302. https://bugs.webkit.org/show_bug.cgi?id=88670
  12303. Reviewed by Rob Buis.
  12304. RIM PR: 163720
  12305. WebSettings is overriding the default font settings with "", which deletes them.
  12306. * Api/WebPage.cpp:
  12307. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  12308. 2012-06-07 Crystal Zhang <haizhang@rim.com>
  12309. [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
  12310. https://bugs.webkit.org/show_bug.cgi?id=88576
  12311. Reviewed by Rob Buis.
  12312. When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use
  12313. this to load popup, no need to create a new one. The old code is based on an old solution
  12314. which has been abandoned.
  12315. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12316. (WebCore::ChromeClientBlackBerry::openPagePopup):
  12317. * WebCoreSupport/PagePopupBlackBerry.cpp:
  12318. (WebCore::PagePopupBlackBerry::init):
  12319. (WebCore::setValueAndClosePopupCallback):
  12320. (WebCore::PagePopupBlackBerry::handleMouseEvent):
  12321. (WebCore::PagePopupBlackBerry::closePopup):
  12322. * WebCoreSupport/PagePopupBlackBerry.h:
  12323. (PagePopupBlackBerry):
  12324. 2012-06-07 Jacky Jiang <zhajiang@rim.com>
  12325. [BlackBerry] Get rid of unused maximumLayoutSize in WebPage
  12326. https://bugs.webkit.org/show_bug.cgi?id=88574
  12327. Reviewed by Rob Buis.
  12328. Patch by Jacky Jiang <zhajiang@rim.com>
  12329. PR: 164098
  12330. maximumLayoutSize was deprecated when we made use of
  12331. WebCore::computeViewportAttributes for
  12332. WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
  12333. So clean it up.
  12334. * Api/WebPage.cpp:
  12335. (WebKit):
  12336. 2012-06-07 Arvid Nilsson <anilsson@rim.com>
  12337. [BlackBerry] User viewport arguments are not respected
  12338. https://bugs.webkit.org/show_bug.cgi?id=88530
  12339. Reviewed by Antonio Gomes.
  12340. RIM PR #163767
  12341. Fixed by applying the user supplied viewport arguments if the page
  12342. specifies default viewport arguments (i.e. the page has no viewport
  12343. meta tag).
  12344. If the user didn't supply any viewport arguments either, the behaviour
  12345. is the same as before the patch, the caller will successfully reset to
  12346. default viewport arguments.
  12347. * Api/WebPage.cpp:
  12348. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  12349. 2012-06-07 Arvid Nilsson <anilsson@rim.com>
  12350. [BlackBerry] Allow WebPageCompositor to blend a transparent web page
  12351. https://bugs.webkit.org/show_bug.cgi?id=88233
  12352. Reviewed by Rob Buis.
  12353. RIM PR #159998
  12354. Keep track of the web page background color in the compositor so we can
  12355. determine whether the contents of the root layer are transparent.
  12356. Reviewed internally by Jakob Petsovits.
  12357. * Api/BackingStore.cpp:
  12358. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  12359. * Api/BackingStore_p.h:
  12360. (BackingStorePrivate):
  12361. * Api/WebPage.cpp:
  12362. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  12363. (BlackBerry::WebKit::WebPagePrivate::setCompositorBackgroundColor):
  12364. (WebKit):
  12365. (BlackBerry::WebKit::WebPagePrivate::createCompositor):
  12366. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  12367. * Api/WebPageCompositor.cpp:
  12368. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  12369. (BlackBerry::WebKit::WebPageCompositorPrivate::setBackgroundColor):
  12370. (WebKit):
  12371. * Api/WebPageCompositor_p.h:
  12372. (BlackBerry::WebKit::WebPageCompositorPrivate::backgroundColor):
  12373. (WebPageCompositorPrivate):
  12374. * Api/WebPage_p.h:
  12375. (WebPagePrivate):
  12376. 2012-06-07 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  12377. [BlackBerry] Add enable credential autofill and enable form autofill feature control in WebSetting
  12378. https://bugs.webkit.org/show_bug.cgi?id=88513
  12379. Reviewed by Rob Buis.
  12380. RIM PR: #163391
  12381. Implemented credential autofill setting and form autofill setting.
  12382. Internally reviewed by Leo Yang <leo.yang@torchmobile.com.cn>.
  12383. * Api/WebPage.cpp:
  12384. (BlackBerry::WebKit::WebPage::autofillTextField):
  12385. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  12386. (BlackBerry::WebKit::WebPage::clearCredentials):
  12387. (BlackBerry::WebKit::WebPage::clearAutofillData):
  12388. (BlackBerry::WebKit::WebPage::clearNeverRememberSites):
  12389. * Api/WebSettings.cpp:
  12390. (WebKit):
  12391. (BlackBerry::WebKit::WebSettings::standardSettings):
  12392. (BlackBerry::WebKit::WebSettings::isCredentialAutofillEnabled):
  12393. (BlackBerry::WebKit::WebSettings::setCredentialAutofillEnabled):
  12394. (BlackBerry::WebKit::WebSettings::isFormAutofillEnabled):
  12395. (BlackBerry::WebKit::WebSettings::setFormAutofillEnabled):
  12396. * Api/WebSettings.h:
  12397. * WebCoreSupport/EditorClientBlackBerry.cpp:
  12398. (WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
  12399. (WebCore::EditorClientBlackBerry::textDidChangeInTextField):
  12400. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  12401. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  12402. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
  12403. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  12404. 2012-06-06 Antonio Gomes <agomes@rim.com>
  12405. [BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
  12406. https://bugs.webkit.org/show_bug.cgi?id=88488
  12407. PR #162991
  12408. Reviewed by George Staikos.
  12409. When we use width:100%/pageScale as the math to calculate the width of the
  12410. FullScreen element, it goes too wide for horizontally scrollable webpages.
  12411. The reason is that 100% is relative to the content size here, and we want 100%
  12412. relative to the viewport size. However, since there is no such a thing in CSS,
  12413. we set an absolute file.
  12414. A known problem with this will be rotating the device when in fullscreen mode
  12415. that we can address when rotating is supported.
  12416. Internally reviewed by Jacky Jiang.
  12417. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12418. (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
  12419. 2012-06-05 Antonio Gomes <agomes@rim.com>
  12420. [BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
  12421. https://bugs.webkit.org/show_bug.cgi?id=88254
  12422. PR #125237
  12423. Reviewed by Rob Buis.
  12424. Patch implements a top-down visibleWindowRect calculation for all scrollable
  12425. elements hit-tested by a given point.
  12426. The reason on why this approach is better is that it calculates the visible
  12427. window rect from the outermost scrollable element towards the inner ones, and
  12428. that allows it to use the visible window rect of the previous scrollable element
  12429. as the clipping rect for the current one.
  12430. Patch also changes the return vector to store ScrollViewBase pointers, so
  12431. we can make use of static_cast properly. As now also stated in the header
  12432. file, the client is responsible for deleting the ScrollViewBase
  12433. elements in the vector.
  12434. Internally reviewed by Jakob Petsovits.
  12435. * Api/WebPage.cpp:
  12436. (BlackBerry::WebKit::pushBackInRegionScrollable):
  12437. (BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
  12438. * Api/WebPageClient.h:
  12439. * Api/WebPage_p.h:
  12440. (WebPagePrivate):
  12441. * WebKitSupport/InRegionScrollableArea.cpp:
  12442. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  12443. (BlackBerry::WebKit::InRegionScrollableArea::setVisibleWindowRect):
  12444. (WebKit):
  12445. (BlackBerry::WebKit::InRegionScrollableArea::visibleWindowRect):
  12446. * WebKitSupport/InRegionScrollableArea.h:
  12447. (InRegionScrollableArea):
  12448. 2012-06-06 Charles Wei <charles.wei@torchmobile.com.cn>
  12449. [BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
  12450. https://bugs.webkit.org/show_bug.cgi?id=88065
  12451. Reviewed by George Staikos.
  12452. * Api/WebPage.cpp:
  12453. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  12454. * Api/WebSettings.cpp:
  12455. (WebKit):
  12456. (BlackBerry::WebKit::WebSettings::indexedDataBasePath):
  12457. (BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
  12458. * Api/WebSettings.h:
  12459. 2012-06-05 Crystal Zhang <haizhang@rim.com>
  12460. [BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
  12461. https://bugs.webkit.org/show_bug.cgi?id=88342
  12462. Reviewed by Rob Buis.
  12463. RIM PR: 163141
  12464. Reviewed internally by Mike Fenton.
  12465. We set all options' type to TypeOption, which can't tell if an option belongs to a group,
  12466. introduce TypeOptionInGroup to fix it.
  12467. * WebKitSupport/InputHandler.cpp:
  12468. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  12469. 2012-06-05 Adam Barth <abarth@webkit.org>
  12470. Remove support for target-densitydpi in the viewport meta tag
  12471. https://bugs.webkit.org/show_bug.cgi?id=88047
  12472. Reviewed by Kenneth Rohde Christiansen.
  12473. * Api/WebPage.cpp:
  12474. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  12475. * Api/WebViewportArguments.cpp:
  12476. (BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
  12477. (BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
  12478. * Api/WebViewportArguments.h:
  12479. 2012-06-05 Konrad Piascik <kpiascik@rim.com>
  12480. [BlackBerry]Web Inspector highlight is slow
  12481. https://bugs.webkit.org/show_bug.cgi?id=88331
  12482. Reviewed by Rob Buis.
  12483. Highlight is slow on large pages because of constant repaint calls.
  12484. Change to use the accelerated layer highlight all the time.
  12485. * Api/BackingStore.cpp:
  12486. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  12487. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  12488. (WebCore::InspectorClientBlackBerry::highlight):
  12489. (WebCore::InspectorClientBlackBerry::hideHighlight):
  12490. * WebCoreSupport/InspectorOverlay.cpp:
  12491. (WebCore::InspectorOverlay::clear):
  12492. (WebCore::InspectorOverlay::update):
  12493. 2012-06-04 Andrew Lo <anlo@rim.com>
  12494. [BlackBerry] Split AnimationFrameRateController into its own file
  12495. https://bugs.webkit.org/show_bug.cgi?id=88242
  12496. Reviewed by Antonio Gomes.
  12497. Include new header file to reflect re-organization of platform animation
  12498. header files.
  12499. * Api/WebPageCompositor_p.h:
  12500. 2012-06-02 Antonio Gomes <agomes@rim.com>
  12501. [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
  12502. https://bugs.webkit.org/show_bug.cgi?id=88019
  12503. Reviewed by George Staikos.
  12504. Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
  12505. that it prevents user from scrolling the WebPage, pinch zooming,
  12506. touch-and-hold, enter selection mode, etc ...
  12507. Internally reviewed by Gen Mak.
  12508. * Api/WebPage.cpp:
  12509. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  12510. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  12511. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  12512. * Api/WebPage_p.h:
  12513. (WebPagePrivate):
  12514. 2012-06-02 Antonio Gomes <agomes@rim.com>
  12515. [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART II)
  12516. https://bugs.webkit.org/show_bug.cgi?id=88019
  12517. Reviewed by George Staikos.
  12518. When an element goes fullscreen, its wrapper/container obeys all
  12519. BlackBerry specific fixed position customizations: we fixed
  12520. against Y, but not X. Then, in order to have the wrapper element
  12521. properly positioned when entering fullscreen mode, we
  12522. temporarily scroll x to 0.
  12523. The original x scroll position is restored when we leave
  12524. fullscreen.
  12525. * Api/WebPage.cpp:
  12526. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  12527. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  12528. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  12529. * Api/WebPage_p.h:
  12530. (WebPagePrivate):
  12531. 2012-06-02 Antonio Gomes <agomes@rim.com>
  12532. [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART I)
  12533. https://bugs.webkit.org/show_bug.cgi?id=88019
  12534. PR #158266
  12535. Reviewed by George Staikos.
  12536. The way elements go fullscreen with the new FULLSCREEN_API
  12537. is that they get cloned and added to an out-of-DOM wrapper
  12538. element. The wrapper is a normal fixed position element and
  12539. then zoom in/out accordingly to how other layers do: following
  12540. WebPage's scale.
  12541. When going fullscreen, we have to take the current WebPage scale
  12542. into account in order to properly fit the element to the screen,
  12543. regardless the web page scale.
  12544. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12545. (WebCore):
  12546. (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
  12547. * WebCoreSupport/ChromeClientBlackBerry.h:
  12548. (ChromeClientBlackBerry):
  12549. 2012-06-01 Crystal Zhang <haizhang@rim.com>
  12550. [BlackBerry] Fix the return value checking in SelectPopupClient
  12551. https://bugs.webkit.org/show_bug.cgi?id=88130
  12552. Reviewed by Rob Buis.
  12553. In SelectPopupClient, return '1' means selected, '0' means not selected,
  12554. the ASCII value of '0' is 48, not 32, use '0' to be more readable.
  12555. * WebCoreSupport/SelectPopupClient.cpp:
  12556. (WebCore::SelectPopupClient::setValueAndClosePopup):
  12557. 2012-06-01 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  12558. [BlackBerry] Add end editing handling into AutofillManager
  12559. https://bugs.webkit.org/show_bug.cgi?id=88071
  12560. Reviewed by Rob Buis.
  12561. RIM PR: 160857
  12562. Implemented EditorClientBlackBerry::textFieldDidEndEditing
  12563. to notify AutofillManager to send the dismissing autofill
  12564. dialog notification to webpage client.
  12565. No new tests since there is no behavior changes.
  12566. * Api/WebPage.cpp:
  12567. (BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
  12568. (WebKit):
  12569. * Api/WebPageClient.h:
  12570. * Api/WebPage_p.h:
  12571. (WebPagePrivate):
  12572. * WebCoreSupport/AutofillManager.cpp:
  12573. (WebCore::AutofillManager::textFieldDidEndEditing):
  12574. (WebCore):
  12575. * WebCoreSupport/AutofillManager.h:
  12576. (AutofillManager):
  12577. * WebCoreSupport/EditorClientBlackBerry.cpp:
  12578. (WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
  12579. 2012-05-31 Jacky Jiang <zhajiang@rim.com>
  12580. [BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
  12581. https://bugs.webkit.org/show_bug.cgi?id=88033
  12582. Reviewed by Rob Buis.
  12583. Patch by Jacky Jiang <zhajiang@rim.com>
  12584. PR: 142961
  12585. When bridge apps were in carousel mode, the backing store was inactive
  12586. as its memory had been released. When we rotated the device, we would
  12587. call WebPagPrivate:setViewportSize and resume screen and backing store
  12588. to render and blit visible contents. As backing store was inactive and
  12589. the window usage was GLES2Usage, we were neither doing backing store
  12590. rendering nor direct rendering. Therefore, we drew layers directly
  12591. based on the invalid texture contents when blitting contents if
  12592. accelerated compositing was enabled.
  12593. This patch forces compositing mode to let the accelerated compositing
  12594. layer take care of the rendering which can update texture contents
  12595. before drawing when backing store is inactive and is openGL compositing.
  12596. Reviewed internally by George Staikos and Arvid Nilsson.
  12597. * Api/BackingStore.cpp:
  12598. (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
  12599. 2012-05-31 Hajime Morrita <morrita@chromium.org>
  12600. REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
  12601. https://bugs.webkit.org/show_bug.cgi?id=86859
  12602. Reviewed by Ryosuke Niwa.
  12603. * WebCoreSupport/EditorClientBlackBerry.cpp:
  12604. (WebCore::EditorClientBlackBerry::requestCheckingOfString):
  12605. * WebCoreSupport/EditorClientBlackBerry.h:
  12606. (EditorClientBlackBerry):
  12607. 2012-05-31 Arvid Nilsson <anilsson@rim.com>
  12608. [BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
  12609. https://bugs.webkit.org/show_bug.cgi?id=88012
  12610. Reviewed by George Staikos.
  12611. Properly set up resource sharing between WebKit thread EGL contexts and
  12612. the compositing thread EGL context, so the texture ID produced by WebGL
  12613. and 2D canvas makes sense to the compositing context.
  12614. There's no public API to supply an EGLContext yet, so we're lucky that
  12615. the embedder never makes its context un-current. Just grab the current
  12616. context on the compositing thread and use that as the compositing
  12617. context.
  12618. * Api/WebPage.cpp:
  12619. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  12620. * Api/WebPageCompositor.cpp:
  12621. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  12622. (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
  12623. * Api/WebPage_p.h:
  12624. (WebPagePrivate):
  12625. 2012-05-31 George Staikos <staikos@webkit.org>
  12626. [Blackberry] Initialize the select client and delete the pointer
  12627. in the destructor so it doesn't leak. Fixes test crashes.
  12628. https://bugs.webkit.org/show_bug.cgi?id=87992
  12629. Reviewed by Rob Buis.
  12630. * WebKitSupport/InputHandler.cpp:
  12631. (BlackBerry::WebKit::InputHandler::InputHandler):
  12632. (BlackBerry::WebKit::InputHandler::~InputHandler):
  12633. 2012-05-31 Arvid Nilsson <anilsson@rim.com>
  12634. [BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
  12635. https://bugs.webkit.org/show_bug.cgi?id=87968
  12636. Reviewed by Rob Buis.
  12637. The override object is using a compositing thread WebOverlayPrivate
  12638. object with no client because the layer doesn't delegate drawing to the
  12639. WebOverlayPrivate, it's only used to modify the override properties on
  12640. the underlying compositing thread layer.
  12641. Since the m_layerCompositingThreadClient is optional, we have to add
  12642. null checks.
  12643. * Api/WebOverlay.cpp:
  12644. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
  12645. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
  12646. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
  12647. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
  12648. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
  12649. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
  12650. 2012-05-31 Chris Guan <chris.guan@torchmobile.com.cn>
  12651. [Blackberry] WebKit's fullscreen mode needs to notify page client.
  12652. https://bugs.webkit.org/show_bug.cgi?id=87337
  12653. Reviewed by Antonio Gomes.
  12654. Move "fullScreenVideoCapable" into webpagePrivate to make code
  12655. clean for "fullScreenForElement/Node" of cromeClientBlackberry,
  12656. All Video checks and code path selections are in webpagePrivate now.
  12657. For some UX and secure reasons, we could not apply fullscreen capacity
  12658. for all elements, So we use client's fullscreenStart/Stop only for
  12659. those video elements and those elements containing video tags.
  12660. * Api/WebPage.cpp:
  12661. (BlackBerry::WebKit::WebPagePrivate::webContext):
  12662. (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
  12663. (WebKit):
  12664. (BlackBerry::WebKit::containsVideoTags):
  12665. (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
  12666. (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
  12667. * Api/WebPageClient.h:
  12668. * Api/WebPage_p.h:
  12669. (WebCore):
  12670. (WebPagePrivate):
  12671. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  12672. (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
  12673. (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
  12674. 2012-05-31 Arvid Nilsson <anilsson@rim.com>
  12675. [BlackBerry] Crash when closing web page if selection is active
  12676. https://bugs.webkit.org/show_bug.cgi?id=87962
  12677. Reviewed by Antonio Gomes.
  12678. The embedder may try to remove a layer from the compositor at a stage
  12679. where the compositor has been set to 0.
  12680. * Api/WebPage.cpp:
  12681. (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
  12682. (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
  12683. 2012-05-30 Konrad Piascik <kpiascik@rim.com>
  12684. [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
  12685. https://bugs.webkit.org/show_bug.cgi?id=81001
  12686. Reviewed by Antonio Gomes.
  12687. Implemented InspectorOverlay using WebOverlayAPI.
  12688. * Api/BackingStore.cpp:
  12689. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  12690. * Api/WebPage.cpp:
  12691. (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
  12692. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  12693. (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
  12694. (WebKit):
  12695. * Api/WebPage_p.h:
  12696. (WebCore):
  12697. (WebPagePrivate):
  12698. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  12699. (WebCore::InspectorClientBlackBerry::highlight):
  12700. (WebCore::InspectorClientBlackBerry::hideHighlight):
  12701. (WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
  12702. (WebCore):
  12703. * WebCoreSupport/InspectorClientBlackBerry.h:
  12704. (InspectorClientBlackBerry):
  12705. * WebCoreSupport/InspectorOverlay.cpp: Added.
  12706. (WebCore):
  12707. (WebCore::InspectorOverlay::create):
  12708. (WebCore::InspectorOverlay::InspectorOverlay):
  12709. (WebCore::InspectorOverlay::notifySyncRequired):
  12710. (WebCore::InspectorOverlay::paintContents):
  12711. (WebCore::InspectorOverlay::showDebugBorders):
  12712. (WebCore::InspectorOverlay::showRepaintCounter):
  12713. (WebCore::InspectorOverlay::contentsVisible):
  12714. (WebCore::InspectorOverlay::~InspectorOverlay):
  12715. (WebCore::InspectorOverlay::clear):
  12716. (WebCore::InspectorOverlay::update):
  12717. (WebCore::InspectorOverlay::paintWebFrame):
  12718. (WebCore::InspectorOverlay::invalidateWebFrame):
  12719. * WebCoreSupport/InspectorOverlay.h: Added.
  12720. (WebKit):
  12721. (WebCore):
  12722. (InspectorOverlay):
  12723. (InspectorOverlayClient):
  12724. (WebCore::InspectorOverlay::setClient):
  12725. (WebCore::InspectorOverlay::notifyAnimationStarted):
  12726. 2012-05-30 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  12727. [BlackBerry] Browser crashed when selecting in textarea
  12728. https://bugs.webkit.org/show_bug.cgi?id=87484
  12729. The function FatFingers::checkForText() uses host node's whole text
  12730. to checkFingerIntersection(). We should not give the text of shadow
  12731. nodes to it.
  12732. Reviewed by Antonio Gomes.
  12733. * WebKitSupport/FatFingers.cpp:
  12734. (BlackBerry::WebKit::FatFingers::getNodesFromRect): Avoid returning
  12735. shadow nodes when the context is Text node.
  12736. 2012-05-30 Zoltan Horvath <zoltan@webkit.org>
  12737. [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
  12738. https://bugs.webkit.org/show_bug.cgi?id=80400
  12739. Get rid of QT_IMAGE_DECODER flag.
  12740. Reviewed by Simon Hausmann.
  12741. * WebCoreSupport/AboutDataEnableFeatures.in:
  12742. 2012-05-29 Max Feil <mfeil@rim.com>
  12743. [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
  12744. https://bugs.webkit.org/show_bug.cgi?id=87817
  12745. Reviewed by Antonio Gomes.
  12746. This bug fix in WebKit/blackberry is needed by the changes for
  12747. fullscreen media control sizing in WebCore (bug 87551). The sizing
  12748. of controls depends on the page's deviceScaleFactor(), which was
  12749. not being maintained properly due to errors in logic. Viewport
  12750. changes from non-default to default were being erroneously
  12751. thrown out. Also, when the viewport did change back to default
  12752. the deviceScaleFactor was not being updated.
  12753. * Api/WebPage.cpp:
  12754. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  12755. (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
  12756. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  12757. [BlackBerry] WebOverlay build fixes and bug fixes
  12758. https://bugs.webkit.org/show_bug.cgi?id=87780
  12759. Reviewed by Rob Buis.
  12760. Fix build when accelerated compositing disabled, or debug build.
  12761. Also fix a bug where the selection overlay would not disappear properly
  12762. because of a typo in WebPage::removeOverlay(). Also convert said method
  12763. to early return style.
  12764. Debug build fixes contributed by Ming Xie.
  12765. * Api/WebOverlay.cpp:
  12766. (BlackBerry::WebKit::WebOverlay::addAnimation):
  12767. (BlackBerry::WebKit::WebOverlay::setContentsToImage):
  12768. (WebKit):
  12769. (BlackBerry::WebKit::WebOverlay::setContentsToColor):
  12770. (BlackBerry::WebKit::WebOverlay::setDrawsContent):
  12771. (BlackBerry::WebKit::WebOverlay::invalidate):
  12772. (BlackBerry::WebKit::WebOverlay::setClient):
  12773. (BlackBerry::WebKit::WebOverlay::override):
  12774. (BlackBerry::WebKit::WebOverlay::resetOverrides):
  12775. * Api/WebOverlayOverride.cpp:
  12776. (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
  12777. * Api/WebOverlay_p.h:
  12778. (BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
  12779. * Api/WebPage.cpp:
  12780. (BlackBerry::WebKit::WebPage::removeOverlay):
  12781. (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
  12782. (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
  12783. 2012-05-29 Yong Li <yoli@rim.com>
  12784. [BlackBerry] Add malloc info to about:memory page
  12785. https://bugs.webkit.org/show_bug.cgi?id=87676
  12786. Reviewed by Rob Buis.
  12787. Detailed malloc info can tell us how much memory
  12788. in the heaps is being in use.
  12789. * WebCoreSupport/AboutData.cpp:
  12790. (WebCore::memoryPage):
  12791. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  12792. [BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
  12793. https://bugs.webkit.org/show_bug.cgi?id=87604
  12794. Reviewed by Antonio Gomes.
  12795. Also add a new method to allow the embedder to use the default tap
  12796. highlight instead of replacing it with a custom one just to keep track
  12797. of the "shouldHideAfterScroll" flag.
  12798. PR #160262.
  12799. * Api/WebTapHighlight.h:
  12800. * WebKitSupport/DefaultTapHighlight.cpp:
  12801. (BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
  12802. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  12803. (BlackBerry::WebKit::DefaultTapHighlight::hide):
  12804. (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
  12805. * WebKitSupport/DefaultTapHighlight.h:
  12806. (BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
  12807. (DefaultTapHighlight):
  12808. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  12809. [BlackBerry] WebKit-side implementation of SelectionOverlay
  12810. https://bugs.webkit.org/show_bug.cgi?id=87605
  12811. Reviewed by Rob Buis.
  12812. Leverage the new WebOverlay API to move SelectionOverlay to the WebKit
  12813. library, so we always draw selection regardless of which embedder is
  12814. integrating WebKit.
  12815. PR #160263
  12816. * Api/WebPage.cpp:
  12817. (BlackBerry::WebKit::WebPagePrivate::init):
  12818. (BlackBerry::WebKit::WebPage::selectionOverlay):
  12819. (WebKit):
  12820. * Api/WebPage.h:
  12821. (WebKit):
  12822. * Api/WebPage_p.h:
  12823. (WebPagePrivate):
  12824. * Api/WebSelectionOverlay.h: Added.
  12825. (WebKit):
  12826. * WebKitSupport/SelectionHandler.cpp:
  12827. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  12828. * WebKitSupport/SelectionOverlay.cpp: Added.
  12829. (WebKit):
  12830. (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
  12831. (BlackBerry::WebKit::SelectionOverlay::~SelectionOverlay):
  12832. (BlackBerry::WebKit::SelectionOverlay::draw):
  12833. (BlackBerry::WebKit::SelectionOverlay::hide):
  12834. (BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
  12835. (BlackBerry::WebKit::SelectionOverlay::paintContents):
  12836. * WebKitSupport/SelectionOverlay.h: Added.
  12837. (WebKit):
  12838. (SelectionOverlay):
  12839. (BlackBerry::WebKit::SelectionOverlay::create):
  12840. (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
  12841. (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
  12842. (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
  12843. (BlackBerry::WebKit::SelectionOverlay::contentsVisible):
  12844. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  12845. [BlackBerry] WebOverlay API
  12846. https://bugs.webkit.org/show_bug.cgi?id=87603
  12847. Reviewed by Rob Buis.
  12848. This new API makes it possible to leverage the BlackBerry accelerated
  12849. compositing implementation to draw, transform and fluidly animate
  12850. overlays in the embedding library or application.
  12851. A WebOverlay has an affinity for the thread where it was created. If
  12852. the current thread is the WebKit thread, use WebPage::addOverlay() to
  12853. add it to the page, and manipulate it only from the WebKit thread, with
  12854. exception of the "override" functionality which can be used from the
  12855. compositing thread. If the current thread is the compositing thread,
  12856. use WebPage::addCompositingThreadOverlay() to add it to the page, and
  12857. only manipulate it on the compositing thread.
  12858. A WebOverlay can be painted using Skia, or its contents can be set to
  12859. an image or a solid color.
  12860. PR #156812
  12861. * Api/WebAnimation.cpp: Added.
  12862. (WebKit):
  12863. (BlackBerry::WebKit::WebAnimation::fadeAnimation):
  12864. (BlackBerry::WebKit::WebAnimation::name):
  12865. (BlackBerry::WebKit::WebAnimation::WebAnimation):
  12866. (BlackBerry::WebKit::WebAnimation::~WebAnimation):
  12867. (BlackBerry::WebKit::WebAnimation::operator=):
  12868. * Api/WebAnimation.h: Added.
  12869. (WebKit):
  12870. * Api/WebAnimation_p.h: Added.
  12871. (WebKit):
  12872. (WebAnimationPrivate):
  12873. (BlackBerry::WebKit::WebAnimationPrivate::WebAnimationPrivate):
  12874. * Api/WebOverlay.cpp: Added.
  12875. (WebKit):
  12876. (BlackBerry::WebKit::WebOverlay::WebOverlay):
  12877. (BlackBerry::WebKit::WebOverlay::~WebOverlay):
  12878. (BlackBerry::WebKit::WebOverlay::position):
  12879. (BlackBerry::WebKit::WebOverlay::setPosition):
  12880. (BlackBerry::WebKit::WebOverlay::anchorPoint):
  12881. (BlackBerry::WebKit::WebOverlay::setAnchorPoint):
  12882. (BlackBerry::WebKit::WebOverlay::size):
  12883. (BlackBerry::WebKit::WebOverlay::setSize):
  12884. (BlackBerry::WebKit::WebOverlay::sizeIsScaleInvariant):
  12885. (BlackBerry::WebKit::WebOverlay::setSizeIsScaleInvariant):
  12886. (BlackBerry::WebKit::WebOverlay::transform):
  12887. (BlackBerry::WebKit::WebOverlay::setTransform):
  12888. (BlackBerry::WebKit::WebOverlay::opacity):
  12889. (BlackBerry::WebKit::WebOverlay::setOpacity):
  12890. (BlackBerry::WebKit::WebOverlay::addAnimation):
  12891. (BlackBerry::WebKit::WebOverlay::removeAnimation):
  12892. (BlackBerry::WebKit::WebOverlay::parent):
  12893. (BlackBerry::WebKit::WebOverlay::addChild):
  12894. (BlackBerry::WebKit::WebOverlay::removeFromParent):
  12895. (BlackBerry::WebKit::WebOverlay::setContentsToImage):
  12896. (BlackBerry::WebKit::WebOverlay::setContentsToColor):
  12897. (BlackBerry::WebKit::WebOverlay::setDrawsContent):
  12898. (BlackBerry::WebKit::WebOverlay::invalidate):
  12899. (BlackBerry::WebKit::WebOverlay::setClient):
  12900. (BlackBerry::WebKit::WebOverlay::override):
  12901. (BlackBerry::WebKit::WebOverlay::resetOverrides):
  12902. (BlackBerry::WebKit::WebOverlayPrivate::page):
  12903. (BlackBerry::WebKit::WebOverlayPrivate::override):
  12904. (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
  12905. (BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
  12906. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
  12907. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::override):
  12908. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::position):
  12909. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setPosition):
  12910. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::anchorPoint):
  12911. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setAnchorPoint):
  12912. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::size):
  12913. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSize):
  12914. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::sizeIsScaleInvariant):
  12915. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSizeIsScaleInvariant):
  12916. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::transform):
  12917. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setTransform):
  12918. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::opacity):
  12919. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setOpacity):
  12920. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addAnimation):
  12921. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeAnimation):
  12922. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addChild):
  12923. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeFromParent):
  12924. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
  12925. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToColor):
  12926. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setDrawsContent):
  12927. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::clear):
  12928. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::invalidate):
  12929. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::resetOverrides):
  12930. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifySyncRequired):
  12931. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
  12932. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
  12933. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::~WebOverlayLayerCompositingThreadClient):
  12934. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setDrawsContent):
  12935. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
  12936. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
  12937. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
  12938. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed):
  12939. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
  12940. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
  12941. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
  12942. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
  12943. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
  12944. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
  12945. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
  12946. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::override):
  12947. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::position):
  12948. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setPosition):
  12949. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::anchorPoint):
  12950. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setAnchorPoint):
  12951. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::size):
  12952. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSize):
  12953. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::sizeIsScaleInvariant):
  12954. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSizeIsScaleInvariant):
  12955. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::transform):
  12956. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setTransform):
  12957. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::opacity):
  12958. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setOpacity):
  12959. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addAnimation):
  12960. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeAnimation):
  12961. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addChild):
  12962. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
  12963. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
  12964. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
  12965. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
  12966. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::clear):
  12967. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
  12968. (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::resetOverrides):
  12969. * Api/WebOverlay.h: Added.
  12970. (WebCore):
  12971. (WebKit):
  12972. * Api/WebOverlayClient.h: Added.
  12973. (WebKit):
  12974. * Api/WebOverlayOverride.cpp: Added.
  12975. (WebKit):
  12976. (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
  12977. (BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
  12978. (BlackBerry::WebKit::WebOverlayOverride::setPosition):
  12979. (BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
  12980. (BlackBerry::WebKit::WebOverlayOverride::setSize):
  12981. (BlackBerry::WebKit::WebOverlayOverride::setTransform):
  12982. (BlackBerry::WebKit::WebOverlayOverride::setOpacity):
  12983. (BlackBerry::WebKit::WebOverlayOverride::addAnimation):
  12984. (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
  12985. * Api/WebOverlayOverride.h: Added.
  12986. (WebKit):
  12987. * Api/WebOverlay_p.h: Added.
  12988. (WTF):
  12989. (WebCore):
  12990. (WebKit):
  12991. (WebOverlayPrivate):
  12992. (BlackBerry::WebKit::WebOverlayPrivate::WebOverlayPrivate):
  12993. (BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
  12994. (BlackBerry::WebKit::WebOverlayPrivate::setPage):
  12995. (BlackBerry::WebKit::WebOverlayPrivate::setClient):
  12996. (BlackBerry::WebKit::WebOverlayPrivate::layerCompositingThread):
  12997. (BlackBerry::WebKit::WebOverlayPrivate::graphicsLayer):
  12998. (WebOverlayPrivateWebKitThread):
  12999. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::graphicsLayer):
  13000. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
  13001. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
  13002. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
  13003. (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::contentsVisible):
  13004. (WebOverlayLayerCompositingThreadClient):
  13005. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setLayer):
  13006. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setClient):
  13007. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawsContent):
  13008. (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::contents):
  13009. (WebOverlayPrivateCompositingThread):
  13010. * Api/WebPage.cpp:
  13011. (BlackBerry::WebKit::WebPage::addOverlay):
  13012. (WebKit):
  13013. (BlackBerry::WebKit::WebPage::removeOverlay):
  13014. (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
  13015. (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
  13016. * Api/WebPage.h:
  13017. (WebKit):
  13018. * Api/WebPageCompositor.cpp:
  13019. (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
  13020. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  13021. (WebKit):
  13022. (BlackBerry::WebKit::WebPageCompositorPrivate::compositeLayers):
  13023. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  13024. (BlackBerry::WebKit::WebPageCompositorPrivate::addOverlay):
  13025. (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
  13026. * Api/WebPageCompositor_p.h:
  13027. (BlackBerry::WebKit::WebPageCompositorPrivate::compositingThreadOverlayLayer):
  13028. (WebPageCompositorPrivate):
  13029. 2012-05-28 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  13030. [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
  13031. https://bugs.webkit.org/show_bug.cgi?id=80135
  13032. Reviewed by Rob Buis.
  13033. RIM PR: 145660
  13034. Fixed a regression introduced by r111810, which used the wrong
  13035. credential object.
  13036. Added the interface function didReceivedAuthenticaitonChallenge()
  13037. in interface class DumpRenderTreeClient;
  13038. Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
  13039. WebPagePrivate::authenticationChallenge() when DRT is enabled.
  13040. Test: reuse existing test cases:
  13041. http/tests/loading/basic-credentials-sent-automatically.html
  13042. http/tests/loading/basic-auth-resend-wrong-credentials.html
  13043. Resubmit the patch reverted by r115104 after the digest infinite loop
  13044. issue for BlackBerry porting get identified and fixed.
  13045. Internally reviewed by Joe Mason <jmason@rim.com>
  13046. * Api/DumpRenderTreeClient.h:
  13047. (WebCore):
  13048. * Api/WebPage.cpp:
  13049. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  13050. * Api/WebPageClient.h:
  13051. * Api/WebPage_p.h:
  13052. (WebPagePrivate):
  13053. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13054. [BlackBerry] Always create a compositor
  13055. https://bugs.webkit.org/show_bug.cgi?id=87598
  13056. Reviewed by Rob Buis.
  13057. There will likely be compositing layers either due to web content or
  13058. due to overlays.
  13059. Defer initialization of OpenGL objects (i.e., delay creation of the
  13060. LayerRenderer object) until we actually need to draw and there are such
  13061. layers, to avoid initializing OpenGL in the unlikely case that there
  13062. are no compositing layers or overlay layers.
  13063. PR #156811
  13064. * Api/WebPage.cpp:
  13065. (BlackBerry::WebKit::WebPagePrivate::init):
  13066. (BlackBerry::WebKit::WebPagePrivate::createCompositor):
  13067. * Api/WebPageCompositor.cpp:
  13068. (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
  13069. (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
  13070. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  13071. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  13072. * Api/WebPageCompositor_p.h:
  13073. (WebPageCompositorPrivate):
  13074. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13075. [BlackBerry] Dangling pointer in WebPagePrivate::setCompositor() message
  13076. https://bugs.webkit.org/show_bug.cgi?id=87590
  13077. Reviewed by Rob Buis.
  13078. A crash would be seen in GuardedPointerBase::getWithGuardLocked when
  13079. attempting to unpickle and execute serialized call to setCompositor.
  13080. The problem was that the message had been created with a dangling
  13081. pointer as the target. The web page failed to inform its compositor
  13082. that it was being destroyed due to an early return in
  13083. WebPagePrivate::destroyCompositor.
  13084. The root cause was that a method called "destroyCompositor" was being
  13085. called in two situations, when navigating to a new page as well as when
  13086. actually deleting the web page. And in one case, we really only wanted
  13087. to free up some memory by clearing textures, while in the other case we
  13088. really did want to destroy the compositor.
  13089. Fixed by calling a method to release textures when that's what we want
  13090. to do, and calling a method to destroy the compositor when that's what
  13091. we want to do, and making that latter method unconditional.
  13092. Reviewed internally by Jeff Rogers.
  13093. PR #156765
  13094. * Api/WebPage.cpp:
  13095. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  13096. (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
  13097. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13098. [BlackBerry] Add a default tap highlight
  13099. https://bugs.webkit.org/show_bug.cgi?id=87569
  13100. Reviewed by Rob Buis.
  13101. We used to require the embedder to implement tap highlight drawing.
  13102. Now, a default tap highlight, implemented using the recently added
  13103. accelerated compositing overlay layer support, can be used instead.
  13104. The tap highlight appears instantly but fades out when hidden.
  13105. The default tap highlight can be overridden using the new
  13106. WebPage::setTapHighlight() method.
  13107. Reviewed internally by Mike Lattanzio and Mike Fenton.
  13108. PR #154329
  13109. * Api/WebPage.cpp:
  13110. (BlackBerry::WebKit::WebPagePrivate::init):
  13111. (BlackBerry::WebKit::WebPage::tapHighlight):
  13112. (WebKit):
  13113. (BlackBerry::WebKit::WebPage::setTapHighlight):
  13114. * Api/WebPage.h:
  13115. (WebKit):
  13116. * Api/WebPageClient.h:
  13117. * Api/WebPage_p.h:
  13118. (WebCore):
  13119. (WebPagePrivate):
  13120. * Api/WebTapHighlight.h: Added.
  13121. (WebKit):
  13122. * WebKitSupport/DefaultTapHighlight.cpp: Added.
  13123. (WebKit):
  13124. (BlackBerry::WebKit::fadeAnimationName):
  13125. (BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
  13126. (BlackBerry::WebKit::DefaultTapHighlight::~DefaultTapHighlight):
  13127. (BlackBerry::WebKit::DefaultTapHighlight::draw):
  13128. (BlackBerry::WebKit::DefaultTapHighlight::hide):
  13129. (BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
  13130. (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
  13131. * WebKitSupport/DefaultTapHighlight.h: Added.
  13132. (WebKit):
  13133. (DefaultTapHighlight):
  13134. (BlackBerry::WebKit::DefaultTapHighlight::create):
  13135. (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
  13136. (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
  13137. (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
  13138. (BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
  13139. * WebKitSupport/TouchEventHandler.cpp:
  13140. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  13141. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13142. [BlackBerry] Add an overlay layer
  13143. https://bugs.webkit.org/show_bug.cgi?id=87567
  13144. Reviewed by Antonio Gomes.
  13145. The overlay layer allows us to have compositing layers even though the
  13146. web page is not currently using accelerated compositing.
  13147. These layers can be used to implement tap highlight, inspector overlay
  13148. and more.
  13149. Reviewed internally by Filip Spacek.
  13150. PR #154335
  13151. * Api/WebPage.cpp:
  13152. (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
  13153. (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
  13154. (WebKit):
  13155. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  13156. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  13157. * Api/WebPageCompositor.cpp:
  13158. (BlackBerry::WebKit::WebPageCompositorPrivate::setOverlayLayer):
  13159. (WebKit):
  13160. (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
  13161. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  13162. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  13163. * Api/WebPageCompositor_p.h:
  13164. (BlackBerry::WebKit::WebPageCompositorPrivate::overlayLayer):
  13165. (WebPageCompositorPrivate):
  13166. * Api/WebPage_p.h:
  13167. (WebPagePrivate):
  13168. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13169. [BlackBerry] Update WebPageCompositor::render() API
  13170. https://bugs.webkit.org/show_bug.cgi?id=87565
  13171. Reviewed by Rob Buis.
  13172. The new API allows the embedder to specify the root transform and many
  13173. OpenGL related parameters to be used when rendering the web page.
  13174. To honor the transform, we have to implement a way to composite the
  13175. BackingStore output using a generic transform. This method,
  13176. BackingStorePrivate::compositeContents(), uses a strategy that differs
  13177. from blitContents(), because that one is optimized for software
  13178. blitting, while this one is optimized for GPU rendering. Specifically,
  13179. instead of drawing the checkerboard first, and the rendered subregions
  13180. of the tile afterward, we draw the whole tile in one call, and then
  13181. draw checkered regions on top, if any.
  13182. Removed the blit generation condvar from the new code paths for drawing
  13183. BackingStore output using a transform, since the condvar is ineffective
  13184. in preventing flicker when we're not in charge of swapping the window.
  13185. Instead, another synchronization solution will be implemented in the
  13186. future.
  13187. Reviewed internally by Filip Spacek.
  13188. Some parts reviewed internally by Jacky Jiang and others by
  13189. Mike Lattanzio.
  13190. PR #151887, #154334
  13191. * Api/BackingStore.cpp:
  13192. (BlackBerry::WebKit::BackingStorePrivate::render):
  13193. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  13194. (WebKit):
  13195. (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
  13196. * Api/BackingStore_p.h:
  13197. (WebCore):
  13198. (BackingStorePrivate):
  13199. * Api/WebPageCompositor.cpp:
  13200. (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
  13201. (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
  13202. (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
  13203. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  13204. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  13205. (BlackBerry::WebKit::WebPageCompositor::prepareFrame):
  13206. (BlackBerry::WebKit::WebPageCompositor::render):
  13207. * Api/WebPageCompositor.h:
  13208. * Api/WebPageCompositorClient.h:
  13209. * Api/WebPageCompositor_p.h:
  13210. (WebPageCompositorPrivate):
  13211. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  13212. 2012-05-28 Arvid Nilsson <anilsson@rim.com>
  13213. [BlackBerry] Plumb through the return value of makeCurrent to caller
  13214. https://bugs.webkit.org/show_bug.cgi?id=87564
  13215. Reviewed by Rob Buis.
  13216. This way the caller can take appropriate action if makeCurrent fails,
  13217. for example because we're running out of memory.
  13218. Reviewed internally by George Staikos.
  13219. PR #149721
  13220. * WebKitSupport/GLES2Context.cpp:
  13221. (BlackBerry::WebKit::GLES2Context::makeCurrent):
  13222. 2012-05-27 Arvid Nilsson <anilsson@rim.com>
  13223. [BlackBerry] Crash when deleting WebPageCompositor
  13224. https://bugs.webkit.org/show_bug.cgi?id=87589
  13225. Reviewed by Rob Buis.
  13226. The WebPageCompositorPrivate is reference counted, so it may outlive
  13227. either the WebPage or the WebPageCompositor, depending on who releases
  13228. its reference first.
  13229. Fixed by disconnecting the objects properly, regardless of who goes
  13230. away first.
  13231. Reviewed internally by Mike Lattanzio.
  13232. PR #156444
  13233. * Api/WebPage.cpp:
  13234. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  13235. (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
  13236. * Api/WebPageCompositor.cpp:
  13237. (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
  13238. (BlackBerry::WebKit::WebPageCompositor::client):
  13239. * Api/WebPageCompositor_p.h:
  13240. (BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
  13241. 2012-05-27 Arvid Nilsson <anilsson@rim.com>
  13242. 2012-04-18 Arvid Nilsson <anilsson@rim.com>
  13243. [BlackBerry] BackingStore accesses tiles even though it's not active
  13244. https://bugs.webkit.org/show_bug.cgi?id=87563
  13245. Reviewed by Antonio Gomes.
  13246. There are many scenarios that can call render and cause tile access,
  13247. and they used to be rerouted to the direct rendering code when the
  13248. backing store was not active. This was thanks to an implicit check for
  13249. isActive() by virtue of calling shouldDirectRenderingToWindow() from
  13250. render().
  13251. If we're using OpenGL for compositing the backing store contents
  13252. however, direct rendering is always disabled and we jump right into the
  13253. tile based rendering code.
  13254. Fixed by adding an explicit check for isActive() in render(), now that
  13255. the implicit check in shouldDirectRenderingToWindow() is conditional on
  13256. having raster usage.
  13257. Since PR136381/bug83131, when OpenGL compositing is used, and the
  13258. backing store is not active, it is not in charge of drawing the root
  13259. layer. Instead, we switch off the paintingGoesToWindow flag on the root
  13260. RenderLayer so no invalidates will reach the ChromeClient or the
  13261. BackingStore any more. Instead, invalidations will cause the root
  13262. accelerated compositing layer to be repainted. Any BackingStore render
  13263. calls while in this state are pointless, and can safely do an early
  13264. return.
  13265. Reviewed internally by Jakob Petsovits.
  13266. PR #150403
  13267. * Api/BackingStore.cpp:
  13268. (BlackBerry::WebKit::BackingStorePrivate::render):
  13269. 2012-05-27 Arvid Nilsson <anilsson@rim.com>
  13270. 2012-04-12 Arvid Nilsson <anilsson@rim.com>
  13271. [BlackBerry] Web page fails to render after clicking link with target=_blank
  13272. https://bugs.webkit.org/show_bug.cgi?id=87562
  13273. Reviewed by Antonio Gomes.
  13274. Clicking such a link opens a new tab. The compositor was briefly in
  13275. charge of drawing the root layer while the backing store was inactive
  13276. and the user was looking at the other tab. The problem was that the
  13277. compositor believed it was still painting the root layer even after the
  13278. backing store became active again. The flag was not properly cleared
  13279. when turning off compositing.
  13280. Fixed by returning false from drawsRootLayer() if we don't have a root
  13281. layer.
  13282. Reviewed internally by Filip Spacek.
  13283. PR #149342
  13284. * Api/WebPageCompositor.cpp:
  13285. (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
  13286. 2012-05-24 Jacky Jiang <zhajiang@rim.com>
  13287. [BlackBerry] History navigation caused google.com scale not kept
  13288. https://bugs.webkit.org/show_bug.cgi?id=87438
  13289. Reviewed by Antonio Gomes.
  13290. Patch by Jacky Jiang <zhajiang@rim.com>
  13291. PR: 159923
  13292. For back/forward history navigation, we were trying to keep the values
  13293. set by dispatchViewportDataDidChange. However, when we went back from
  13294. the previous page, if the current page didn't contain the meta viewport
  13295. tag, then those values set by previous page would never be reset.
  13296. Although the current page could get correct saved scale when restoring
  13297. view state, the scale would still be clamped by zoomToFitScale which
  13298. was based on the virtual viewport of the previous page which could make
  13299. the scale incorrect.
  13300. Since we know the viewport arguments of the current document before
  13301. setLoadState on back/forward history navigation, we can reset these
  13302. previous values if the document doesn't have viewport arguments during
  13303. setLoadState.
  13304. * Api/WebPage.cpp:
  13305. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  13306. 2012-05-25 Mary Wu <mary.wu@torchmobile.com.cn>
  13307. [BlackBerry] Pass http headers to loader in download request
  13308. https://bugs.webkit.org/show_bug.cgi?id=87449
  13309. Reviewed by Rob Buis.
  13310. PR# 149283
  13311. This is to support byte-range download and we could pass http headers like
  13312. "Range" in download request to loader.
  13313. Reviewed internally by Lyon Chen.
  13314. * Api/WebPage.cpp:
  13315. (BlackBerry::WebKit::WebPage::download):
  13316. 2012-05-24 Mike Fenton <mifenton@rim.com>
  13317. [BlackBerry] InputHandler can hold a ref on an object when document is cleared.
  13318. https://bugs.webkit.org/show_bug.cgi?id=87412
  13319. Reviewed by Rob Buis.
  13320. PR 145234.
  13321. When the document data is cleared, notify the InputHandler
  13322. of the associated frame being unloaded.
  13323. Reviewed Internally by Nima Ghanavatian.
  13324. * Api/WebPage.cpp:
  13325. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
  13326. 2012-05-24 Crystal Zhang <haizhang@rim.com>
  13327. [BlackBerry] Implement select popup and remove old hook to air popup
  13328. https://bugs.webkit.org/show_bug.cgi?id=87419
  13329. Reviewed by Rob Buis.
  13330. Introduce new html select popup client, remove the old hook to air popup.
  13331. * Api/WebPageClient.h:
  13332. * WebCoreSupport/SelectPopupClient.cpp: Added.
  13333. (WebCore):
  13334. (WebCore::SelectPopupClient::SelectPopupClient):
  13335. (WebCore::SelectPopupClient::~SelectPopupClient):
  13336. (WebCore::SelectPopupClient::update):
  13337. (WebCore::SelectPopupClient::generateHTML):
  13338. (WebCore::SelectPopupClient::closePopup):
  13339. (WebCore::SelectPopupClient::contentSize):
  13340. (WebCore::SelectPopupClient::htmlSource):
  13341. (WebCore::SelectPopupClient::setValueAndClosePopup):
  13342. (WebCore::SelectPopupClient::didClosePopup):
  13343. (WebCore::SelectPopupClient::writeDocument):
  13344. * WebCoreSupport/SelectPopupClient.h: Added.
  13345. (WebKit):
  13346. (WebCore):
  13347. (SelectPopupClient):
  13348. * WebKitSupport/InputHandler.cpp:
  13349. (BlackBerry::WebKit::InputHandler::openSelectPopup):
  13350. * WebKitSupport/InputHandler.h:
  13351. (WebCore):
  13352. (InputHandler):
  13353. * WebKitSupport/WebPopupType.h: Added.
  13354. (BlackBerry):
  13355. (WebKit):
  13356. 2012-05-24 Antonio Gomes <agomes@rim.com>
  13357. Possible missing layout in Iris browser after hiding VKB
  13358. https://bugs.webkit.org/show_bug.cgi?id=87408
  13359. PR #153056 / MKS_3674963
  13360. Reviewed by Adam Treat.
  13361. Also informally reviewed by Mike Fenton.
  13362. If we are not rotating and we've started a viewport resize with
  13363. the Render tree in dirty state (i.e. it needs layout), lets
  13364. reset the needsLayout flag for now but set our own 'needsLayout'.
  13365. Reason: calls like ScrollView::setFixedLayoutSize can trigger a layout
  13366. if the render tree needs it. We want to avoid it till the viewport resize
  13367. is actually done (i.e. ScrollView::setViewportSize gets called
  13368. further down the method) so we do not get render artifacts.
  13369. Since our WebPage::setViewportSize calls rely on async Virtual
  13370. Keyboard responses, we were getting it called with the render
  13371. tree sometimes in a dirty state, sometimes not. It was flaky!
  13372. Patch ensures a clear render tree state, and sets it as dirty
  13373. afterwards as needed, so layout happens at the proper time.
  13374. * Api/WebPage.cpp:
  13375. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  13376. 2012-05-24 Mike Fenton <mifenton@rim.com>
  13377. [BlackBerry] Padding adjustment for determining the relative distance for a point was backwards.
  13378. https://bugs.webkit.org/show_bug.cgi?id=87404
  13379. Reviewed by Rob Buis.
  13380. Fix padding calculation for handle adjustment.
  13381. Reviewed Internally by Mike Lattanzio.
  13382. * WebKitSupport/SelectionHandler.cpp:
  13383. (BlackBerry::WebKit::directionOfPointRelativeToRect):
  13384. 2012-05-24 Mike Fenton <mifenton@rim.com>
  13385. [BlackBerry] Remove unused API function touchEventCancelAndClearFocusedNode.
  13386. https://bugs.webkit.org/show_bug.cgi?id=87379
  13387. Reviewed by Antonio Gomes.
  13388. Remove unused API, touchEventCancelAndClearFocusedNode.
  13389. Reviewed Internally by Gen Mak.
  13390. * Api/WebPage.cpp:
  13391. * Api/WebPage.h:
  13392. * WebKitSupport/TouchEventHandler.cpp:
  13393. * WebKitSupport/TouchEventHandler.h:
  13394. (TouchEventHandler):
  13395. 2012-05-23 Genevieve Mak <gmak@rim.com>
  13396. Remove minimum and maximum scroll position as they are no
  13397. longer required due to changes in ScrollViewBase.
  13398. https://bugs.webkit.org/show_bug.cgi?id=87298
  13399. Reviewed by Antonio Gomes.
  13400. * WebKitSupport/InRegionScrollableArea.cpp:
  13401. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  13402. * WebKitSupport/InRegionScrollableArea.h:
  13403. (InRegionScrollableArea):
  13404. 2012-05-22 Chris Guan <chris.guan@torchmobile.com.cn>
  13405. [Blackberry]Pages contain video or audio tags should be in pageCache
  13406. https://bugs.webkit.org/show_bug.cgi?id=87116
  13407. Reviewed by George Staikos.
  13408. There is not any reason to disable pageCache for video/audio
  13409. tags probably. By my testing, Back and Forward are working for
  13410. those pages contain video and audio tags.
  13411. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13412. (WebCore::FrameLoaderClientBlackBerry::canCachePage):
  13413. 2012-05-22 Konrad Piascik <kpaiscik@rim.com>
  13414. [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
  13415. https://bugs.webkit.org/show_bug.cgi?id=87125
  13416. Reviewed by Rob Buis.
  13417. Removed unimplemented methods that are no longer part of InspectorClient and added
  13418. a new stub for InspectorStateClient::updateInspectorStateCookie
  13419. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  13420. (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
  13421. (WebCore):
  13422. * WebCoreSupport/InspectorClientBlackBerry.h:
  13423. (InspectorClientBlackBerry):
  13424. 2012-05-18 Mike Fenton <mifenton@rim.com>
  13425. [BlackBerry] Validation of Last Fat Finger result is needed for selection.
  13426. https://bugs.webkit.org/show_bug.cgi?id=86888
  13427. Reviewed by Antonio Gomes.
  13428. PR 128393.
  13429. Cached FatFingersResults must be validatible against
  13430. the desired request to ensure the result is both for
  13431. the same point and of the same type.
  13432. * WebKitSupport/FatFingers.h:
  13433. (WebKit):
  13434. (FatFingersResult):
  13435. (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
  13436. (BlackBerry::WebKit::FatFingersResult::reset):
  13437. (BlackBerry::WebKit::FatFingersResult::resultMatches):
  13438. (BlackBerry::WebKit::FatFingersResult::originPosition):
  13439. (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
  13440. (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
  13441. (BlackBerry::WebKit::FatFingersResult::isTextInput):
  13442. (BlackBerry::WebKit::FatFingersResult::isValid):
  13443. (BlackBerry::WebKit::FatFingersResult::node):
  13444. (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
  13445. * WebKitSupport/SelectionHandler.cpp:
  13446. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  13447. 2012-05-18 MORITA Hajime <morrita@google.com>
  13448. https://bugs.webkit.org/show_bug.cgi?id=85515
  13449. Stale frame in WebCore::SpellChecker::didCheckSucceeded
  13450. Reviewed by Ryosuke Niwa.
  13451. * WebCoreSupport/EditorClientBlackBerry.h:
  13452. (WebCore::EditorClientBlackBerry::frameWillDetachPage):
  13453. 2012-05-17 Jacky Jiang <zhajiang@rim.com>
  13454. [BlackBerry] www.thestar.com/iphone Viewport Weirdness
  13455. https://bugs.webkit.org/show_bug.cgi?id=86756
  13456. Reviewed by George Staikos.
  13457. PR 156710
  13458. On high DPI devices, the virtual viewport size of this page was smaller
  13459. than screen size. During the refreshing of the page, we reset the scale
  13460. when the state was Committed, then layouted and rendered contents based
  13461. on the virtual viewport size and default scale 1, which caused a small
  13462. size thumbnail before we restored the previous view state.
  13463. Fixed it by keeping the previous scale, user scalable and
  13464. m_userViewportArguments during the Committed state of refreshing.
  13465. * Api/WebPage.cpp:
  13466. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  13467. 2012-05-17 Mike Fenton <mifenton@rim.com>
  13468. [BlackBerry] Cleanup headers in SelectionHandler.cpp
  13469. https://bugs.webkit.org/show_bug.cgi?id=86760
  13470. Reviewed by Antonio Gomes.
  13471. Clean up includes in SelectionHandler.cpp.
  13472. * WebKitSupport/SelectionHandler.cpp:
  13473. 2012-05-17 Mike Fenton <mifenton@rim.com>
  13474. [BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
  13475. https://bugs.webkit.org/show_bug.cgi?id=86759
  13476. Reviewed by Antonio Gomes.
  13477. expandSelectionToGranularity unnecesarily converted the
  13478. selection to range and back. Using the selection
  13479. directly is preferred.
  13480. * WebKitSupport/SelectionHandler.cpp:
  13481. (BlackBerry::WebKit::expandSelectionToGranularity):
  13482. 2012-05-17 Hironori Bono <hbono@chromium.org>
  13483. [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
  13484. https://bugs.webkit.org/show_bug.cgi?id=86591
  13485. Reviewed by Ryosuke Niwa.
  13486. This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
  13487. function to remove platform-specific code from Editor::respondToChangedSelection
  13488. function.
  13489. No new tests, no change in behavior.
  13490. * WebCoreSupport/EditorClientBlackBerry.cpp:
  13491. (WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
  13492. (WebCore):
  13493. * WebCoreSupport/EditorClientBlackBerry.h:
  13494. (EditorClientBlackBerry):
  13495. 2012-05-17 Mike Fenton <mifenton@rim.com>
  13496. [BlackBerry] Build fix, SelectionHandler extra debug logs
  13497. https://bugs.webkit.org/show_bug.cgi?id=86743
  13498. Reviewed by Antonio Gomes.
  13499. Add include for BlackBerryPlatformLog to SelectionHandler.cpp
  13500. * WebKitSupport/SelectionHandler.cpp:
  13501. 2012-05-16 Yongxin Dai <yodai@rim.com>
  13502. [BlackBerry] The FCC shows up on an empty input field
  13503. https://bugs.webkit.org/show_bug.cgi?id=86657
  13504. Reviewed by Antonio Gomes.
  13505. Turn off the caret by sending a caret changed notification with empty caret.
  13506. PR #120620
  13507. Reviewed Internally by Mike Fenton.
  13508. * WebKitSupport/SelectionHandler.cpp:
  13509. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  13510. 2012-05-16 Eli Fidler <efidler@rim.com>
  13511. [BlackBerry] Don't reset the default font families in WebSettings
  13512. https://bugs.webkit.org/show_bug.cgi?id=86660
  13513. Reviewed by Rob Buis.
  13514. PR 152467
  13515. The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp
  13516. * Api/WebSettings.cpp:
  13517. (BlackBerry::WebKit::WebSettings::standardSettings):
  13518. 2012-05-16 Genevieve Mak <gmak@rim.com>
  13519. Add missing include that was causing build errors.
  13520. https://bugs.webkit.org/show_bug.cgi?id=86502
  13521. Reviewed by Rob Buis.
  13522. Reviewed Internally by Liam Quinn.
  13523. * WebKitSupport/InputHandler.cpp:
  13524. 2012-05-15 Chris Guan <chris.guan@torchmobile.com.cn>
  13525. [BlackBerry] Enhance an API of BackingStore::drawContents
  13526. https://bugs.webkit.org/show_bug.cgi?id=86447
  13527. Reviewed by George Staikos.
  13528. Enhance the current APIs by adding parameters of id and destination
  13529. contentSize, because chrome browser may want different contents from
  13530. the same webview at different times.
  13531. * Api/BackingStore.cpp:
  13532. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  13533. (BlackBerry::WebKit::BackingStore::drawContents):
  13534. * Api/BackingStore.h:
  13535. * Api/BackingStore_p.h:
  13536. (BackingStorePrivate):
  13537. 2012-05-15 Max Feil <mfeil@rim.com>
  13538. [BlackBerry] Enable the Fullscreen API
  13539. https://bugs.webkit.org/show_bug.cgi?id=86129
  13540. Reviewed by Antonio Gomes.
  13541. This patch enables the new document-based Fullscreen API.
  13542. The ENABLE(FULLSCREEN_API) is already enabled in the
  13543. BlackBerry WebKit build. My patch turns fullscreen on
  13544. in the page settings by default and implements the missing
  13545. ChromeClientBlackBerry::{supports,enter,exit}FullScreenForElement()
  13546. member functions. I am also plumbing through the existing
  13547. "fullScreenVideoCapable" that QNXStageWebView has always been
  13548. sending to allow the presence of a native fullscreen video player
  13549. to be checked.
  13550. * Api/WebPage.cpp:
  13551. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  13552. * Api/WebSettings.cpp:
  13553. (WebKit):
  13554. (BlackBerry::WebKit::WebSettings::standardSettings):
  13555. (BlackBerry::WebKit::WebSettings::fullScreenVideoCapable):
  13556. (BlackBerry::WebKit::WebSettings::setFullScreenVideoCapable):
  13557. * Api/WebSettings.h:
  13558. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  13559. (WebCore):
  13560. (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
  13561. (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
  13562. (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
  13563. * WebCoreSupport/ChromeClientBlackBerry.h:
  13564. (ChromeClientBlackBerry):
  13565. 2012-05-15 Hanna Ma <Hanma@rim.com>
  13566. [BlackBerry] adding a functionality for web inspector to inspect current selected element
  13567. https://bugs.webkit.org/show_bug.cgi?id=86394
  13568. Reviewed by Rob Buis.
  13569. Add a way to trigger the remote web inspector on selected element.
  13570. * Api/WebPage.cpp:
  13571. (BlackBerry::WebKit::WebPage::inspectCurrentContextElement):
  13572. (WebKit):
  13573. * Api/WebPage.h:
  13574. 2012-05-14 Jacky Jiang <zhajiang@rim.com>
  13575. [BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar.com/iphone
  13576. https://bugs.webkit.org/show_bug.cgi?id=86391
  13577. Reviewed by Adam Treat.
  13578. PR 156992
  13579. Request layout first if needed before painting contents.
  13580. * Api/BackingStore.cpp:
  13581. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  13582. 2012-05-10 Mike Fenton <mifenton@rim.com>
  13583. Caret node boundary should be adjusted to account for the visible region.
  13584. https://bugs.webkit.org/show_bug.cgi?id=86116
  13585. Reviewed by Antonio Gomes.
  13586. PR 138988.
  13587. Update the node bounding box to be clipped and adjusted
  13588. for the visible region of the frame.
  13589. Reviewed Internally by Gen Mak.
  13590. * WebKitSupport/SelectionHandler.cpp:
  13591. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  13592. 2012-05-10 Antonio Gomes <agomes@rim.com>
  13593. [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid
  13594. https://bugs.webkit.org/show_bug.cgi?id=86096
  13595. Reviewed by Rob Buis.
  13596. A Frame's FrameView has always to be checked since it is
  13597. a volatile object, and gets created and destroyed all the time.
  13598. We have been facing a particular issue, where during our automated
  13599. interaction tests, the main frame object was being pinch zoomed in
  13600. the middle of it creation, and WebKit thread was blocked by a mutex.
  13601. In practice, it is a case that would not be possible in a real
  13602. world scenario, but shows that the ASSERTs are bogus regardless.
  13603. * WebKitSupport/BackingStoreClient.cpp:
  13604. (BlackBerry::WebKit::BackingStoreClient::scrollPosition):
  13605. (BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
  13606. (BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
  13607. (BlackBerry::WebKit::BackingStoreClient::viewportSize):
  13608. (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
  13609. (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
  13610. (BlackBerry::WebKit::BackingStoreClient::contentsSize):
  13611. 2012-05-09 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  13612. [BlackBerry] Autofill feature implementation for BlackBerry porting
  13613. https://bugs.webkit.org/show_bug.cgi?id=85577
  13614. Reviewed by Rob Buis.
  13615. * Api/WebPage.cpp:
  13616. (BlackBerry::WebKit::WebPage::autofillTextField): Added this interface
  13617. function to auto fill the inputting text field when user selects
  13618. a autofill candidate value from autofill context dialog.
  13619. (WebKit):
  13620. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  13621. (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog): Added
  13622. this interface function to notify WebPageClient to pop up the autofill
  13623. context dialog with the suggested input items.
  13624. (BlackBerry::WebKit::WebPage::clearAutofillData):
  13625. * Api/WebPage.h:
  13626. * Api/WebPageClient.h:
  13627. * Api/WebPage_p.h:
  13628. (WebCore):
  13629. (WebPagePrivate):
  13630. * WebCoreSupport/AutofillManager.cpp:
  13631. (WebCore::AutofillManager::didChangeInTextField):
  13632. * WebCoreSupport/EditorClientBlackBerry.cpp:
  13633. (WebCore::EditorClientBlackBerry::textDidChangeInTextField): Implemented
  13634. this function to listen to the notification of text field change, and
  13635. notify AutofillManager to handle the autofill.
  13636. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13637. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
  13638. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  13639. Save the name and value pair of every autofillable input text field when
  13640. user submitting a form.
  13641. 2012-05-09 Crystal Zhang <haizhang@rim.com>
  13642. [BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
  13643. https://bugs.webkit.org/show_bug.cgi?id=85907
  13644. Reviewed by Rob Buis.
  13645. Internal reviewed by Yong Li.
  13646. Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
  13647. Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
  13648. implementation and add methods in WebKit::WebPage that needed for PagePopupClient.
  13649. * Api/WebPage.cpp:
  13650. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  13651. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  13652. (BlackBerry::WebKit::WebPage::initPopupWebView):
  13653. (WebKit):
  13654. (BlackBerry::WebKit::WebPage::popupOpened):
  13655. (BlackBerry::WebKit::WebPage::popupClosed):
  13656. (BlackBerry::WebKit::WebPage::hasOpenedPopup):
  13657. (BlackBerry::WebKit::WebPage::popup):
  13658. (BlackBerry::WebKit::WebPagePrivate::setParentPopup):
  13659. * Api/WebPage.h:
  13660. (WebCore):
  13661. * Api/WebPage_p.h:
  13662. (WebCore):
  13663. (WebPagePrivate):
  13664. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  13665. (WebCore::ChromeClientBlackBerry::hasOpenedPopup):
  13666. (WebCore::ChromeClientBlackBerry::openPagePopup):
  13667. (WebCore):
  13668. (WebCore::ChromeClientBlackBerry::closePagePopup):
  13669. * WebCoreSupport/ChromeClientBlackBerry.h:
  13670. (WebCore):
  13671. (ChromeClientBlackBerry):
  13672. 2012-05-08 Jason Liu <jason.liu@torchmobile.com.cn>
  13673. [BlackBerry] Auth credentials set in private mode are reused in public mode.
  13674. https://bugs.webkit.org/show_bug.cgi?id=84697
  13675. Reviewed by Rob Buis.
  13676. Add setPrivateMode function for CredentialStorage.
  13677. We have to change Private Browsing to test, so have to write a manual test case.
  13678. Test: ManualTests/blackberry/http-auth-private-mode-changed.html
  13679. * Api/WebPage.cpp:
  13680. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  13681. 2012-05-08 Crystal Zhang <haizhang@rim.com>
  13682. [BlackBerry] Implement a popup client for HTML controls
  13683. https://bugs.webkit.org/show_bug.cgi?id=85670
  13684. Reviewed by Rob Buis.
  13685. Implement a popup client for HTML controls, which would be used to load
  13686. different popups according to popup type.
  13687. * WebCoreSupport/PagePopupBlackBerry.cpp: Added.
  13688. (WebCore):
  13689. (PagePopupChromeClient):
  13690. (WebCore::PagePopupChromeClient::PagePopupChromeClient):
  13691. (WebCore::PagePopupChromeClient::closeWindowSoon):
  13692. (WebCore::PagePopupChromeClient::webPage):
  13693. (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
  13694. (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
  13695. (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
  13696. (WebCore::PagePopupBlackBerry::init):
  13697. (WebCore::setValueAndClosePopupCallback):
  13698. (WebCore::popUpExtensionInitialize):
  13699. (WebCore::popUpExtensionFinalize):
  13700. (WebCore::PagePopupBlackBerry::installDomFunction):
  13701. (WebCore::PagePopupBlackBerry::handleMouseEvent):
  13702. (WebCore::PagePopupBlackBerry::closePopup):
  13703. (WebCore::PagePopupBlackBerry::closeWebPage):
  13704. * WebCoreSupport/PagePopupBlackBerry.h: Added.
  13705. (WebKit):
  13706. (WebCore):
  13707. (PagePopupBlackBerry):
  13708. 2012-05-08 Andrew Lo <anlo@rim.com>
  13709. [BlackBerry] Over-scroll image should be tiled
  13710. https://bugs.webkit.org/show_bug.cgi?id=85860
  13711. Reviewed by Rob Buis.
  13712. Implement tiling for over-scroll image if image dimension don't match
  13713. the surface dimensions.
  13714. * Api/BackingStore.cpp:
  13715. (WebKit):
  13716. (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
  13717. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  13718. * Api/BackingStore_p.h:
  13719. (BackingStorePrivate):
  13720. 2012-05-08 Chris Guan <chris.guan@torchmobile.com.cn>
  13721. [Blackberry] remove m_isRequestedByPlugin in ResourceRequest
  13722. https://bugs.webkit.org/show_bug.cgi?id=84559
  13723. Reviewed by Antonio Gomes.
  13724. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13725. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
  13726. 2012-05-08 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  13727. [BlackBerry] AutofillManager implementation upstream
  13728. https://bugs.webkit.org/show_bug.cgi?id=85576
  13729. Reviewed by Rob Buis.
  13730. RIM PR: 136405
  13731. Implemented class AutofillManager to handle the form autofill
  13732. interactions.
  13733. It listens to text changed notification from text input, searches
  13734. autofill database for the suggested autofill candidate value,
  13735. and notifies WebPageClient to pop up a context dialog for user;
  13736. it also responds to user's choice by autofilling the text input.
  13737. * WebCoreSupport/AutofillManager.cpp: Added.
  13738. (WebCore):
  13739. (WebCore::AutofillManager::create):
  13740. (WebCore::AutofillManager::didChangeInTextField):
  13741. (WebCore::AutofillManager::autofillTextField):
  13742. (WebCore::AutofillManager::saveTextFields):
  13743. (WebCore::AutofillManager::clear):
  13744. * WebCoreSupport/AutofillManager.h: Added.
  13745. (WTF):
  13746. (WebKit):
  13747. (WebCore):
  13748. (AutofillManager):
  13749. (WebCore::AutofillManager::m_element):
  13750. 2012-05-07 Andrew Lo <anlo@rim.com>
  13751. [BlackBerry] Delete previous buffer when new over-scroll image path is set
  13752. https://bugs.webkit.org/show_bug.cgi?id=85812
  13753. Reviewed by Rob Buis.
  13754. When a new over-scroll image path is set, delete old buffer before creating
  13755. a new one.
  13756. * Api/BackingStore.cpp:
  13757. (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
  13758. 2012-05-07 Andrew Lo <anlo@rim.com>
  13759. [BlackBerry] Over-scroll image path property should be relative to local application directory
  13760. https://bugs.webkit.org/show_bug.cgi?id=85814
  13761. Reviewed by Rob Buis.
  13762. Over-scroll image path web setting should be relative to the local directory.
  13763. * Api/BackingStore.cpp:
  13764. (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
  13765. 2012-05-07 Crystal Zhang <haizhang@rim.com>
  13766. [BlackBerry] Add methods need by client side
  13767. https://bugs.webkit.org/show_bug.cgi?id=85661
  13768. Reviewed by Antonio Gomes.
  13769. Add methods needed by client side when create and close HTML popup dialogs.
  13770. PR 154360
  13771. * Api/WebPageClient.h:
  13772. 2012-05-06 Mary Wu <mary.wu@torchmobile.com.cn>
  13773. [BlackBerry] Support html5 download attribute.
  13774. https://bugs.webkit.org/show_bug.cgi?id=85044
  13775. Reviewed by Antonio Gomes.
  13776. If a link has download attribute, we should pass that value and be able to
  13777. save file with the name according to HTML5:
  13778. http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download
  13779. * Api/WebPage.cpp:
  13780. (BlackBerry::WebKit::WebPagePrivate::load):
  13781. (BlackBerry::WebKit::WebPage::download):
  13782. * Api/WebPage_p.h:
  13783. (WebPagePrivate):
  13784. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13785. (WebCore::FrameLoaderClientBlackBerry::startDownload):
  13786. 2012-05-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  13787. [BlackBerry] Autofill backing store implementation upstream
  13788. https://bugs.webkit.org/show_bug.cgi?id=85575
  13789. Reviewed by Rob Buis.
  13790. Replaced calling static function CredentialBackingStore::instance()
  13791. with calling the helper function credentialBackingStore().
  13792. * WebCoreSupport/CredentialManager.cpp:
  13793. (WebCore::CredentialManager::autofillAuthenticationChallenge):
  13794. (WebCore::CredentialManager::autofillPasswordForms):
  13795. (WebCore::CredentialManager::saveCredentialIfConfirmed):
  13796. (WebCore::CredentialManager::clearCredentials):
  13797. (WebCore::CredentialManager::clearNeverRememberSites):
  13798. 2012-05-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  13799. [BlackBerry] Enable credential persistance and auto fill
  13800. https://bugs.webkit.org/show_bug.cgi?id=85572
  13801. Reviewed by Rob Buis.
  13802. Set autofilled status of credential input fields when credential
  13803. information is auto filled by CredentialManager.
  13804. By doing this the input element will get painted with yellow background
  13805. which can notify user this input field is auto filled by the browser.
  13806. No behavior changes, so no new test.
  13807. * WebCoreSupport/CredentialTransformData.cpp:
  13808. (WebCore::CredentialTransformData::setCredential):
  13809. 2012-05-04 Andrew Lo <anlo@rim.com>
  13810. [Blackberry] Implement over-scroll background image
  13811. https://bugs.webkit.org/show_bug.cgi?id=85538
  13812. Reviewed by Rob Buis.
  13813. Use over-scroll image when set instead of the solid colour.
  13814. Internal PR146652
  13815. * Api/BackingStore.cpp:
  13816. (WebKit):
  13817. (BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
  13818. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  13819. * Api/BackingStore_p.h:
  13820. (BackingStorePrivate):
  13821. * Api/WebSettings.cpp:
  13822. (WebKit):
  13823. (BlackBerry::WebKit::WebSettings::standardSettings):
  13824. (BlackBerry::WebKit::WebSettings::overScrollImagePath):
  13825. (BlackBerry::WebKit::WebSettings::setOverScrollImagePath):
  13826. * Api/WebSettings.h:
  13827. 2012-05-04 Rob Buis <rbuis@rim.com>
  13828. [BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
  13829. https://bugs.webkit.org/show_bug.cgi?id=85036
  13830. Reviewed by Antonio Gomes.
  13831. Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.
  13832. * Api/WebSettings.cpp:
  13833. (WebKit):
  13834. (BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
  13835. * Api/WebSettings.h:
  13836. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13837. (WebCore::FrameLoaderClientBlackBerry::createPlugin):
  13838. (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
  13839. (WebCore::FrameLoaderClientBlackBerry::objectContentType):
  13840. 2012-05-04 Nate Chapin <japhet@chromium.org>
  13841. Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
  13842. https://bugs.webkit.org/show_bug.cgi?id=85533
  13843. Reviewed by Alexey Proskuryakov.
  13844. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13845. (WebCore::FrameLoaderClientBlackBerry::finishedLoading):
  13846. 2012-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
  13847. Unreviewed, rolling out r116085, r116091, and r116095.
  13848. http://trac.webkit.org/changeset/116085
  13849. http://trac.webkit.org/changeset/116091
  13850. http://trac.webkit.org/changeset/116095
  13851. https://bugs.webkit.org/show_bug.cgi?id=85628
  13852. We are not ready with dependencies on all platform yet (mac) +
  13853. problems with debug builds. (Requested by Zoltan on #webkit).
  13854. * WebCoreSupport/AboutDataEnableFeatures.in:
  13855. 2012-05-04 Zoltan Horvath <zoltan@webkit.org>
  13856. [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
  13857. https://bugs.webkit.org/show_bug.cgi?id=80400
  13858. Get rid off QT_IMAGE_DECODER flag.
  13859. Reviewed by Simon Hausmann.
  13860. * WebCoreSupport/AboutDataEnableFeatures.in:
  13861. 2012-05-03 Fady Samuel <fsamuel@chromium.org>
  13862. Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
  13863. https://bugs.webkit.org/show_bug.cgi?id=70609
  13864. Reviewed by Kenneth Rohde Christiansen.
  13865. * WebKitSupport/DumpRenderTreeSupport.cpp:
  13866. (DumpRenderTreeSupport::dumpConfigurationForViewport):
  13867. 2012-05-03 Mike Fenton <mifenton@rim.com>
  13868. [BlackBerry] Add special attribute for alternate selection touch handling.
  13869. https://bugs.webkit.org/show_bug.cgi?id=85284
  13870. Reviewed by Rob Buis.
  13871. Rename the custom attribute and make it a data- attribute.
  13872. * WebKitSupport/SelectionHandler.cpp:
  13873. (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
  13874. 2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
  13875. FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
  13876. information about the form being submitted
  13877. https://bugs.webkit.org/show_bug.cgi?id=84297
  13878. Reviewed by Andy Estes.
  13879. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  13880. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  13881. Updated to use the FormState.
  13882. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  13883. (FrameLoaderClientBlackBerry):
  13884. Updated method declaration.
  13885. 2012-05-02 Jacky Jiang <zhajiang@rim.com>
  13886. [BlackBerry] Double tap zooming does nothing on small size table
  13887. https://bugs.webkit.org/show_bug.cgi?id=85383
  13888. Reviewed by George Staikos.
  13889. PR: 153232
  13890. When we search the best node for block zoom, if the initial node's new
  13891. scale exceeds the maximum block zoom scale, we will try to walk through
  13892. it's ancestors and pick the acceptable one. But the reality is that the
  13893. acceptable ancestor's size can be too close to the size of the actual
  13894. contents, we will do nothing for it. As we will still select the
  13895. minimum of the new scale and the maximum block zoom scale as block zoom
  13896. scale, we can ignore such kind of node and use the initial node instead.
  13897. * Api/WebPage.cpp:
  13898. (BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomLimits):
  13899. 2012-05-01 Mike Fenton <mifenton@rim.com>
  13900. Add special attribute for alternate selection touch handling.
  13901. https://bugs.webkit.org/show_bug.cgi?id=85284
  13902. Reviewed by Antonio Gomes.
  13903. PR 152975.
  13904. Add attribute -bb-selection-touchoverride to override
  13905. touch handling on selection overlay.
  13906. Reviewed Internally by Gen Mak.
  13907. * Api/WebPageClient.h:
  13908. * WebKitSupport/SelectionHandler.cpp:
  13909. (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
  13910. (WebKit):
  13911. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  13912. * WebKitSupport/SelectionHandler.h:
  13913. (SelectionHandler):
  13914. 2012-04-30 Benjamin Poulain <benjamin@webkit.org>
  13915. Add String::startsWith() and endsWith() for string literals
  13916. https://bugs.webkit.org/show_bug.cgi?id=85154
  13917. Reviewed by Darin Adler.
  13918. * WebKitSupport/DOMSupport.cpp:
  13919. (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
  13920. 2012-04-27 Jacky Jiang <zhajiang@rim.com>
  13921. [BlackBerry] Double tap zooming does nothing on table element on bustedtees.com
  13922. https://bugs.webkit.org/show_bug.cgi?id=85104
  13923. Reviewed by George Staikos.
  13924. PR: 147006
  13925. This was caused by the incorrect fix master_33/SHA:612caec4.
  13926. Calculations like this "originalArea / pageArea" would always return 0
  13927. so that the incorrect node and blockRect were used by block zoom. This
  13928. patch takes care of it.
  13929. * Api/WebPage.cpp:
  13930. (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
  13931. (BlackBerry::WebKit::WebPage::blockZoom):
  13932. 2012-04-27 Nima Ghanavatian <nghanavatian@rim.com>
  13933. [BlackBerry] Improve log output in InputHandler.cpp
  13934. https://bugs.webkit.org/show_bug.cgi?id=85007
  13935. Reviewed by Antonio Gomes.
  13936. PR 138292
  13937. Improving logging in InputHandler.
  13938. In setText we had an early return which wasn't being captured.
  13939. Also, cleaning up the output to make it more clear and descriptive.
  13940. Internally reviewed by Mike Fenton.
  13941. * WebKitSupport/InputHandler.cpp:
  13942. (BlackBerry::WebKit::InputHandler::learnText):
  13943. (BlackBerry::WebKit::InputHandler::enableInputMode):
  13944. (BlackBerry::WebKit::InputHandler::setText):
  13945. 2012-04-27 Chris Guan <chris.guan@torchmobile.com.cn>
  13946. [Blackberry] remove redundant returns
  13947. https://bugs.webkit.org/show_bug.cgi?id=85033
  13948. Reviewed by Antonio Gomes.
  13949. Remove two redundant returns which were added by accident.
  13950. No new test cases, because no behaviour has changed.
  13951. * Api/WebPage.cpp:
  13952. (BlackBerry::WebKit::WebPage::setSelection):
  13953. (BlackBerry::WebKit::WebPage::setCaretPosition):
  13954. 2012-04-27 Andy Chen <andchen@rim.com>
  13955. [BlackBerry] Find-in-page fails to deactivate the old active match when moving backwards
  13956. https://bugs.webkit.org/show_bug.cgi?id=84892
  13957. Reviewed by Antonio Gomes.
  13958. Find in page fails to deactivate the old active match when moving backwards
  13959. because searchStartingPoint was incorrectly initialized.
  13960. Create a real range object instead of referencing other range object.
  13961. PR 152009
  13962. Internally reviewed by Yongxin Dai.
  13963. * WebKitSupport/InPageSearchManager.cpp:
  13964. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  13965. 2012-04-26 Yong Li <yoli@rim.com>
  13966. [BlackBerry] A quick fix to the previous patch r115245.
  13967. https://bugs.webkit.org/show_bug.cgi?id=84862
  13968. Reviewed by Antonio Gomes.
  13969. Fix an obvious bug in previous patch: DeferredTaskLoadManualScript
  13970. was using a wrong flag.
  13971. * Api/WebPage.cpp:
  13972. * Api/WebPage_p.h:
  13973. (WebPagePrivate):
  13974. 2012-04-25 Chris Guan <chris.guan@torchmobile.com.cn>
  13975. [Blackberry] add a new function in BackingStore
  13976. https://bugs.webkit.org/show_bug.cgi?id=84818
  13977. Reviewed by Antonio Gomes.
  13978. Adding two functions in BackingStorePrivate and
  13979. BackingStore, which could render out webpage contents
  13980. into BlackBerry::Platform::Graphics::Drawable.
  13981. * Api/BackingStore.cpp:
  13982. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  13983. (WebKit):
  13984. (BlackBerry::WebKit::BackingStore::drawContents):
  13985. * Api/BackingStore.h:
  13986. * Api/BackingStore_p.h:
  13987. (BackingStorePrivate):
  13988. 2012-04-25 Charles Wei <charles.wei@torchmobile.com.cn>
  13989. [BlackBerry] Input Range element expects mouse events
  13990. https://bugs.webkit.org/show_bug.cgi?id=84571
  13991. Reviewed by Antonio Gomes.
  13992. This just cleans up the code a bit to make it less code and more readable.
  13993. * WebKitSupport/TouchEventHandler.cpp:
  13994. (BlackBerry::WebKit::shouldConvertTouchToMouse):
  13995. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  13996. (BlackBerry::WebKit::TouchEventHandler::spellCheck):
  13997. 2012-04-25 Yong Li <yoli@rim.com>
  13998. [BlackBerry] Possible JS re-entrancy caused by UI events.
  13999. https://bugs.webkit.org/show_bug.cgi?id=84862
  14000. Reviewed by Antonio Gomes.
  14001. 1. block UI events when running in nested event loop
  14002. 2. defer some tasks we still want to perform when it is safe to do,
  14003. with cached data.
  14004. 3. deferred task can be cancelled by clearing the flag. duplicate tasks
  14005. is not a problem because they share same flag and data.
  14006. 4. move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate
  14007. and make it a deferred task
  14008. * Api/WebPage.cpp:
  14009. (WebKit):
  14010. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  14011. (BlackBerry::WebKit::WebPagePrivate::load):
  14012. (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
  14013. (BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
  14014. (BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
  14015. (BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
  14016. (BlackBerry::WebKit::WebPage::assignFocus):
  14017. (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
  14018. (BlackBerry::WebKit::WebPage::setInputSelection):
  14019. (BlackBerry::WebKit::WebPage::popupListClosed):
  14020. (BlackBerry::WebKit::WebPage::setDateTimeInput):
  14021. (BlackBerry::WebKit::WebPage::setColorInput):
  14022. (BlackBerry::WebKit::WebPage::mouseEvent):
  14023. (BlackBerry::WebKit::WebPage::touchEvent):
  14024. (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
  14025. (BlackBerry::WebKit::WebPage::touchEventCancel):
  14026. (BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
  14027. (BlackBerry::WebKit::WebPage::keyEvent):
  14028. (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
  14029. (BlackBerry::WebKit::WebPage::setComposingText):
  14030. (BlackBerry::WebKit::WebPage::commitText):
  14031. (BlackBerry::WebKit::WebPage::selectionCancelled):
  14032. (BlackBerry::WebKit::WebPage::cutSelectedText):
  14033. (BlackBerry::WebKit::WebPage::insertText):
  14034. (BlackBerry::WebKit::WebPage::clearCurrentInputField):
  14035. (BlackBerry::WebKit::WebPage::cut):
  14036. (BlackBerry::WebKit::WebPage::paste):
  14037. (BlackBerry::WebKit::WebPage::setSelection):
  14038. (BlackBerry::WebKit::WebPage::setCaretPosition):
  14039. (BlackBerry::WebKit::WebPage::selectAtPoint):
  14040. (BlackBerry::WebKit::WebPage::setFocused):
  14041. * Api/WebPage.h:
  14042. * Api/WebPage_p.h:
  14043. (WebCore):
  14044. (WebPagePrivate):
  14045. (DeferredTaskBase):
  14046. (BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
  14047. (BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):
  14048. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14049. (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
  14050. (WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
  14051. (WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
  14052. (WebCore::FrameLoaderClientBlackBerry::didResumeLoading):
  14053. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  14054. (FrameLoaderClientBlackBerry):
  14055. * WebKitSupport/InputHandler.cpp:
  14056. (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
  14057. * WebKitSupport/InputHandler.h:
  14058. (InputHandler):
  14059. 2012-04-24 Nima Ghanavatian <nghanavatian@rim.com>
  14060. [BlackBerry] Perform spellcheck before handling TouchRelease event
  14061. https://bugs.webkit.org/show_bug.cgi?id=84744
  14062. After rebasing to master_35, it appears as though some code had been moved around.
  14063. Here, we were handling the TouchReleased event before calling spellcheck. This
  14064. meant that when we finally got the call to spellcheck, the fatFinger result had been
  14065. reset and the spelling markers had been removed.
  14066. In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
  14067. I am also updating the BlackBerry specific documentMarkerContainingPoint to use
  14068. LayoutPoint instead of IntPoint.
  14069. Internally reviewed by Mike Fenton.
  14070. Reviewed by Antonio Gomes.
  14071. * WebKitSupport/TouchEventHandler.cpp:
  14072. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  14073. (BlackBerry::WebKit::TouchEventHandler::spellCheck):
  14074. * dom/DocumentMarkerController.cpp:
  14075. (WebCore::DocumentMarkerController::markerContainingPoint):
  14076. * dom/DocumentMarkerController.h:
  14077. 2012-04-24 Mike Lattanzio <mlattanzio@rim.com>
  14078. [BlackBerry] setUserViewportArguments not always respected.
  14079. https://bugs.webkit.org/show_bug.cgi?id=84738
  14080. Reviewed by Antonio Gomes.
  14081. Remove the unnecessary logic in
  14082. WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
  14083. Instead it is much simpler to just set the m_viewportArguments to
  14084. m_userViewportArguments on LoadCommitted. If there is a viewport
  14085. tag in the content, m_viewportArguments will be replaced with it
  14086. as usual during normal page load.
  14087. * Api/WebPage.cpp:
  14088. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  14089. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  14090. 2012-04-24 Joe Mason <jmason@rim.com>
  14091. [BlackBerry] Revert broken changes to authentication dialog
  14092. https://bugs.webkit.org/show_bug.cgi?id=80135
  14093. Reviewed by Antonio Gomes.
  14094. The previous patches from this bug caused an infinite loop when using digest auth;
  14095. apparently they were only tested with basic.
  14096. * Api/DumpRenderTreeClient.h:
  14097. * Api/WebPage.cpp:
  14098. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  14099. * Api/WebPageClient.h:
  14100. * Api/WebPage_p.h:
  14101. (WebPagePrivate):
  14102. 2012-04-24 Mike Fenton <mifenton@rim.com>
  14103. [BlackBerry] Add additional details including the bounds of the box for caretPositionChanged.
  14104. https://bugs.webkit.org/show_bug.cgi?id=84728
  14105. Reviewed by Antonio Gomes.
  14106. PR 138988.
  14107. Update caretPositionChanged to include the limit of the input field
  14108. for single line inputs.
  14109. Reviewed Internally by Gen Mak.
  14110. * Api/WebPageClient.h:
  14111. * WebKitSupport/InputHandler.cpp:
  14112. (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
  14113. (WebKit):
  14114. * WebKitSupport/InputHandler.h:
  14115. (InputHandler):
  14116. * WebKitSupport/SelectionHandler.cpp:
  14117. (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
  14118. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  14119. 2012-04-24 Charles Wei <charles.wei@torchmobile.com.cn>
  14120. [BlackBerry] Input Range element expects mouse events
  14121. https://bugs.webkit.org/show_bug.cgi?id=84571
  14122. Reviewed by Antonio Gomes.
  14123. Input element with Range type expects mouse events to
  14124. drag the handle. Note that Input Range could appear
  14125. in both the web page directly, or in some shadow tree,
  14126. like the MediaControlTimeline and MediaControlVolume.
  14127. * WebKitSupport/TouchEventHandler.cpp:
  14128. (BlackBerry::WebKit::isRangeControlElement):
  14129. (WebKit):
  14130. (BlackBerry::WebKit::elementExpectsMouseEvents):
  14131. (BlackBerry::WebKit::shouldConvertTouchToMouse):
  14132. 2012-04-23 Charles Wei <charles.wei@torchmobile.com.cn>
  14133. [BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled
  14134. https://bugs.webkit.org/show_bug.cgi?id=84563
  14135. Reviewed by Antonio Gomes.
  14136. Fat Finger log code uses obsolete IntRect::toString() for logging,
  14137. which was first implemented interally and removed later.
  14138. * WebKitSupport/FatFingers.cpp:
  14139. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  14140. 2012-04-21 Benjamin C Meyer <bmeyer@rim.com>
  14141. Don't hard code the plugins that blackberry supports.
  14142. https://bugs.webkit.org/show_bug.cgi?id=84535
  14143. Use the existing PluginDatabase to query for the plugins we can handle.
  14144. The original implemention of FrameLoaderClientBlackBerry::createPlugin
  14145. was a partial copy from another port. In the Qt port there is some
  14146. workarounds for flash which is why this exists there. Sadly the bits
  14147. that were copied made it so only flash worked, but as flash was the only
  14148. plugin on the system this issue was not noticed until QNX tried to get
  14149. jnext working. Tracing it down to this bit of code rather then
  14150. correcting it they hardcoded the jnext into the same block as flash was.
  14151. The blackberry port isn't specifically suppose to only allow jnext and
  14152. flash, but was an accident due to the way this code was developed.
  14153. Reviewed by Adam Treat.
  14154. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14155. (WebCore::FrameLoaderClientBlackBerry::createPlugin):
  14156. 2012-04-20 Brady Eidson <beidson@apple.com>
  14157. https://bugs.webkit.org/show_bug.cgi?id=84512
  14158. Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
  14159. Reviewed by Eric Carlson.
  14160. PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
  14161. They just use WillDeferLoading by default.
  14162. * Api/WebPageGroupLoadDeferrer.cpp:
  14163. (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
  14164. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  14165. (WebCore::ChromeClientBlackBerry::createWindow):
  14166. (WebCore::ChromeClientBlackBerry::runOpenPanel):
  14167. 2012-04-20 Brady Eidson <beidson@apple.com>
  14168. https://bugs.webkit.org/show_bug.cgi?id=84490
  14169. PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
  14170. Reviewed by Anders Carlsson.
  14171. * Api/WebPageGroupLoadDeferrer.cpp:
  14172. (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
  14173. which used to be the default
  14174. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  14175. (WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
  14176. (WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
  14177. 2012-04-20 Mike Lattanzio <mlattanzio@rim.com>
  14178. [BlackBerry] Expose WebViewportArguments to WebPageClient
  14179. https://bugs.webkit.org/show_bug.cgi?id=84471
  14180. Reviewed by Antonio Gomes.
  14181. Implement the ability for the WebPageClient to specify a fallback
  14182. virtual viewport to be used whenever a meta viewport tag is not
  14183. present in the HTML. This can drastically impact apparent layout.
  14184. This patch is designed to provide a classic "Column View" style of
  14185. layout without breaking the web by simply exposing meta viewport
  14186. arguments to WebPageClients.
  14187. Note: As a side effect of this change. the WebPagePrivate::
  14188. recomputeVirtualViewportFromViewportArguments method no longer
  14189. modifies the targetDensityDpi property of the m_viewportArguments.
  14190. However this does not affect the class because that property itself
  14191. means nothing to us. Only the computeViewportArguments method from
  14192. WebCore uses it, and the currentViewportArguments object we pass
  14193. into that method has the adjusted targetDensityDpi value as before.
  14194. * Api/WebPage.cpp:
  14195. (BlackBerry::WebKit::WebPage::setUserViewportArguments):
  14196. (WebKit):
  14197. (BlackBerry::WebKit::WebPage::resetUserViewportArguments):
  14198. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  14199. * Api/WebPage.h:
  14200. (WebKit):
  14201. * Api/WebPage_p.h:
  14202. (WebPagePrivate):
  14203. * Api/WebViewportArguments.cpp: Added.
  14204. (WebKit):
  14205. (BlackBerry::WebKit:::d):
  14206. (BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
  14207. (BlackBerry::WebKit::WebViewportArguments::initialScale):
  14208. (BlackBerry::WebKit::WebViewportArguments::setInitialScale):
  14209. (BlackBerry::WebKit::WebViewportArguments::minimumScale):
  14210. (BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
  14211. (BlackBerry::WebKit::WebViewportArguments::maximumScale):
  14212. (BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
  14213. (BlackBerry::WebKit::WebViewportArguments::width):
  14214. (BlackBerry::WebKit::WebViewportArguments::setWidth):
  14215. (BlackBerry::WebKit::WebViewportArguments::height):
  14216. (BlackBerry::WebKit::WebViewportArguments::setHeight):
  14217. (BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
  14218. (BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
  14219. (BlackBerry::WebKit::WebViewportArguments::userScalable):
  14220. (BlackBerry::WebKit::WebViewportArguments::setUserScalable):
  14221. (BlackBerry::WebKit::WebViewportArguments::operator==):
  14222. (BlackBerry::WebKit::WebViewportArguments::operator!=):
  14223. * Api/WebViewportArguments.h: Added.
  14224. (WebCore):
  14225. (WebKit):
  14226. 2012-04-19 Arvid Nilsson <anilsson@rim.com>
  14227. [BlackBerry] Always use the AnimationFrameRateController for accelerated animations
  14228. https://bugs.webkit.org/show_bug.cgi?id=84323
  14229. Reviewed by Antonio Gomes.
  14230. PR 150750
  14231. Regardless of whether there's a WebPageCompositorClient, we want the
  14232. AnimationFrameRateController to manage animation frames.
  14233. Reviewed internally by Andrew Lo.
  14234. * Api/BackingStore.cpp:
  14235. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  14236. * Api/WebPageCompositor.cpp:
  14237. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  14238. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  14239. * Api/WebPageCompositor_p.h:
  14240. (WebPageCompositorPrivate):
  14241. 2012-04-18 Max Feil <mfeil@rim.com>
  14242. [BlackBerry] Tab awareness for HTML5 concurrent audio
  14243. https://bugs.webkit.org/show_bug.cgi?id=82930
  14244. Support for concurrent HTML5 audio improvements being made in
  14245. the platform library, which need to be aware of tabs and tab
  14246. visibility. PR96004.
  14247. Reviewed by George Staikos.
  14248. * Api/WebPageClient.h:
  14249. * Api/WebPage_p.h:
  14250. (BlackBerry::WebKit::WebPagePrivate::isVisible):
  14251. 2012-04-17 Jacky Jiang <zhajiang@rim.com>
  14252. [BlackBerry] Viewport metatag doesn't disable double-tap zoom
  14253. https://bugs.webkit.org/show_bug.cgi?id=84199
  14254. Reviewed by George Staikos.
  14255. PR: 148279
  14256. When we set "user-scalable=no" in viewport meta-tag and change any
  14257. other WebSettings, the WebPage can turn to be scalable.
  14258. This is a regression of the change master_32/SHA:fa0f8ee9. In that
  14259. change, we used setUserScalable(webSettings->isUserScalable())
  14260. in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
  14261. case, as webSettings->isUserScalable() would always return true by
  14262. default.
  14263. Create a new API WebPage::setUserScalable which will be used in
  14264. DumpRenderTree.cpp.
  14265. * Api/WebPage.cpp:
  14266. (BlackBerry::WebKit::WebPage::setUserScalable):
  14267. (WebKit):
  14268. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  14269. * Api/WebPage.h:
  14270. 2012-04-17 Mike Fenton <mifenton@rim.com>
  14271. [BlackBerry] Pattern matching should be applied to numbers
  14272. https://bugs.webkit.org/show_bug.cgi?id=84152
  14273. Reviewed by Antonio Gomes.
  14274. PR 148906.
  14275. Add pattern matching for number based on [0-9] to trigger
  14276. input help matching number fields.
  14277. * WebKitSupport/DOMSupport.cpp:
  14278. (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
  14279. (DOMSupport):
  14280. (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
  14281. (BlackBerry::WebKit::DOMSupport::elementPatternMatches):
  14282. * WebKitSupport/DOMSupport.h:
  14283. * WebKitSupport/InputHandler.cpp:
  14284. (BlackBerry::WebKit::convertInputType):
  14285. 2012-04-17 George Staikos <staikos@webkit.org>
  14286. Export the initialization function so it can be called earlier.
  14287. https://bugs.webkit.org/show_bug.cgi?id=84134
  14288. Reviewed by Nikolas Zimmermann.
  14289. * Api/BlackBerryGlobal.h: export globalInitialize()
  14290. (WebKit):
  14291. 2012-04-16 Antonio Gomes <agomes@rim.com>
  14292. Screen shift down when VKB shows by clicking in a input box MKS_3601371
  14293. https://bugs.webkit.org/show_bug.cgi?id=84057
  14294. Reviewed by Rob Buis.
  14295. After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
  14296. we had a less restricted code path allowing/disallowing overscrolling. That caused
  14297. some webpages like google.com to get on overscroll when adjusting the scroll
  14298. position to ensure the focused input field is visible.
  14299. Patch restricts the way we allow overscrolling to the bottom, where the virtual
  14300. keyboard pops up from, clamping it to 0, 0 if it tries to
  14301. overscroll upwards, and to maximum scroll position if it overscrolls
  14302. downwards.
  14303. PR #149846
  14304. Internally reviewed by Mike Fenton.
  14305. * WebKitSupport/InputHandler.cpp:
  14306. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  14307. 2012-04-16 Yongxin Dai <yodai@rim.com>
  14308. [BlackBerry] Increase padding for text element
  14309. https://bugs.webkit.org/show_bug.cgi?id=83903
  14310. Reviewed by Antonio Gomes.
  14311. PR 125888
  14312. Increase the padding value for focused text element to make selection handle
  14313. at least partially visible when the user is dragging at edge of viewport
  14314. in in-region scoll mode.
  14315. Reviewed internally by Mike Fenton.
  14316. * WebKitSupport/InputHandler.cpp:
  14317. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  14318. 2012-04-16 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14319. [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
  14320. https://bugs.webkit.org/show_bug.cgi?id=84031
  14321. Reviewed by Rob Buis.
  14322. Added the interface function didReceivedAuthenticaitonChallenge()
  14323. in interface class DumpRenderTreeClient;
  14324. Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
  14325. WebPagePrivate::authenticationChallenge() when DRT is enabled.
  14326. Test: reuse existing test cases:
  14327. http/tests/loading/basic-credentials-sent-automatically.html
  14328. http/tests/loading/basic-auth-resend-wrong-credentials.html
  14329. * Api/DumpRenderTreeClient.h:
  14330. (WebCore):
  14331. * Api/WebPage.cpp:
  14332. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  14333. 2012-04-16 Arvid Nilsson <anilsson@rim.com>
  14334. [BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
  14335. https://bugs.webkit.org/show_bug.cgi?id=83933
  14336. Reviewed by Adam Treat.
  14337. RIM PR: 149609
  14338. This was because I accidentally dropped an exclamation mark when
  14339. upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
  14340. the exclamation mark.
  14341. * Api/WebPage.cpp:
  14342. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  14343. 2012-04-12 Konrad Piascik <kpiascik@rim.com>
  14344. [BlackBerry] Web Inspector messages incorrectly converted
  14345. https://bugs.webkit.org/show_bug.cgi?id=83796
  14346. Reviewed by Rob Buis.
  14347. The JSON sent over from the remote Web Inspector front-end was being
  14348. mis interpreted as ISO-8859-1. This caused all non ascii characters to
  14349. become garbled when using the String constructor, so we use fromtUTF8 instead.
  14350. * Api/WebPage.cpp:
  14351. (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
  14352. 2012-04-12 Mike Fenton <mifenton@rim.com>
  14353. [BlackBerry] Speed up processing of Selection region generation.
  14354. https://bugs.webkit.org/show_bug.cgi?id=82766
  14355. Reviewed by Rob Buis.
  14356. PR 136593.
  14357. Re-speed up text selection. The previous patch had a merge
  14358. error causing text selection not to function. The fix
  14359. implemented removed the optimization. This fixes the error
  14360. in the original patch and removes the temporary fix.
  14361. Make style updated as suggested by Antonio Gomes.
  14362. Reviewed Internally by Gen Mak.
  14363. * WebKitSupport/SelectionHandler.cpp:
  14364. (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
  14365. (BlackBerry::WebKit::regionRectListContainsPoint):
  14366. 2012-04-12 Mike Fenton <mifenton@rim.com>
  14367. Pattern matching for hexadecimal should include * as an allowable count.
  14368. https://bugs.webkit.org/show_bug.cgi?id=83779
  14369. Reviewed by Rob Buis.
  14370. Update pattern matching check to allow wildcard for number
  14371. of characters allowed.
  14372. PR 148907.
  14373. Reviewed Internally by Gen Mak.
  14374. * WebKitSupport/DOMSupport.cpp:
  14375. (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
  14376. 2012-04-11 Joe Mason <jmason@rim.com>
  14377. [BlackBerry] Update to the thread-safe GuardedPointer API
  14378. https://bugs.webkit.org/show_bug.cgi?id=83603
  14379. Reviewed by Rob Buis.
  14380. RIM PR: 134984
  14381. Make the destructors of all objects inheriting GuardedPointerBase protected or
  14382. private, and delete them using BlackBerry::Platform::deleteGuardedObject.
  14383. Access all GuardedPointers through GuardedPointerLocker.
  14384. No new tests, refactor.
  14385. Reviewed internally by Yong Li and George Staikos.
  14386. * Api/BackingStore.cpp:
  14387. (BlackBerry::WebKit::BackingStore::~BackingStore):
  14388. * Api/BackingStore_p.h:
  14389. (BackingStorePrivate):
  14390. * Api/WebPage.cpp:
  14391. (BlackBerry::WebKit::WebPage::~WebPage):
  14392. (BlackBerry::WebKit::WebPage::destroy):
  14393. * Api/WebPage.h:
  14394. * Api/WebPage_p.h:
  14395. (WebPagePrivate):
  14396. 2012-04-10 Arvid Nilsson <anilsson@rim.com>
  14397. [BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
  14398. https://bugs.webkit.org/show_bug.cgi?id=83567
  14399. Reviewed by Antonio Gomes.
  14400. Fixed by checking if there's a layer renderer before calling into it.
  14401. * Api/WebPageCompositor.cpp:
  14402. (BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
  14403. 2012-04-09 Eli Fidler <efidler@rim.com>
  14404. [BlackBerry] Update about:config page
  14405. https://bugs.webkit.org/show_bug.cgi?id=83515
  14406. Reviewed by Rob Buis.
  14407. * WebCoreSupport/AboutData.cpp:
  14408. (WebCore::configPage):
  14409. * WebCoreSupport/AboutDataEnableFeatures.in:
  14410. * WebCoreSupport/AboutDataHaveFeatures.in:
  14411. * WebCoreSupport/AboutDataUseFeatures.in:
  14412. 2012-04-07 Rob Buis <rbuis@rim.com>
  14413. [BlackBerry] Add Battery Status API support
  14414. https://bugs.webkit.org/show_bug.cgi?id=82615
  14415. Reviewed by George Staikos.
  14416. Add client implementation for Battery API.
  14417. * Api/WebPage.cpp:
  14418. (BlackBerry::WebKit::WebPagePrivate::init): initialize BatteryClient.
  14419. * WebCoreSupport/BatteryClientBlackBerry.cpp: Added.
  14420. (WebCore):
  14421. (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
  14422. (WebCore::BatteryClientBlackBerry::setController):
  14423. (WebCore::BatteryClientBlackBerry::startUpdating):
  14424. (WebCore::BatteryClientBlackBerry::stopUpdating):
  14425. (WebCore::BatteryClientBlackBerry::batteryControllerDestroyed):
  14426. (WebCore::BatteryClientBlackBerry::onLevelChange):
  14427. (WebCore::BatteryClientBlackBerry::onChargingChange):
  14428. (WebCore::BatteryClientBlackBerry::onChargingTimeChange):
  14429. (WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
  14430. * WebCoreSupport/BatteryClientBlackBerry.h: Added.
  14431. (WebCore):
  14432. (BatteryClientBlackBerry):
  14433. (WebCore::BatteryClientBlackBerry::~BatteryClientBlackBerry):
  14434. 2012-04-06 Benjamin Poulain <bpoulain@apple.com>
  14435. Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
  14436. https://bugs.webkit.org/show_bug.cgi?id=83325
  14437. Reviewed by Ryosuke Niwa.
  14438. * WebCoreSupport/AboutDataUseFeatures.in:
  14439. 2012-04-06 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  14440. [BlackBerry] Text selection - Can't select texts
  14441. https://bugs.webkit.org/show_bug.cgi?id=83355
  14442. Fix the problem of not sending out the result of the function
  14443. SelectionHandler::regionForTextQuads(). This regression issue
  14444. is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.
  14445. Reviewed by George Staikos.
  14446. * WebKitSupport/SelectionHandler.cpp:
  14447. (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
  14448. Add code to return the function result.
  14449. 2012-04-05 Jason Liu <jason.liu@torchmobile.com.cn>
  14450. [BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
  14451. https://bugs.webkit.org/show_bug.cgi?id=83252
  14452. Reviewed by George Staikos.
  14453. Test: http/tests/misc/resources/referrer-main-resource.php
  14454. * Api/WebPage.cpp:
  14455. (BlackBerry::WebKit::WebPagePrivate::load):
  14456. 2012-04-05 George Staikos <staikos@webkit.org>
  14457. Add a vibration client for BlackBerry and enable it.
  14458. https://bugs.webkit.org/show_bug.cgi?id=83340
  14459. Reviewed by Rob Buis.
  14460. * Api/WebPage.cpp:
  14461. (BlackBerry::WebKit::WebPagePrivate::init): enable the client
  14462. * WebCoreSupport/VibrationClientBlackBerry.cpp: Added.
  14463. (WebCore):
  14464. (WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
  14465. (WebCore::VibrationClientBlackBerry::vibrate):
  14466. (WebCore::VibrationClientBlackBerry::cancelVibration):
  14467. (WebCore::VibrationClientBlackBerry::vibrationDestroyed):
  14468. * WebCoreSupport/VibrationClientBlackBerry.h: Added.
  14469. (WebCore):
  14470. (VibrationClientBlackBerry):
  14471. (WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):
  14472. 2012-04-05 Arvid Nilsson <anilsson@rim.com>
  14473. [BlackBerry] Force compositing mode when backing store is not active
  14474. https://bugs.webkit.org/show_bug.cgi?id=83131
  14475. Reviewed by George Staikos.
  14476. RIM PR: 136381
  14477. Normally, the BlackBerry WebKit port resorts to direct rendering when
  14478. the backing store is not active. However, direct rendering is broken
  14479. with the OpenGL code path. This prevented multiple web pages from being
  14480. displayed at once with the new WebPageCompositor API.
  14481. Fixed by using accelerated compositing layer to render the root layer
  14482. instead of backing store. This will give us a tiled layer backing the
  14483. root layer, which for some use cases is even better than direct
  14484. rendering.
  14485. Reviewed internally by Filip Spacek.
  14486. * Api/BackingStore.cpp:
  14487. (BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
  14488. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  14489. * Api/WebPage.cpp:
  14490. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  14491. (BlackBerry::WebKit::WebPage::setVisible):
  14492. (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
  14493. (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
  14494. (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
  14495. (WebKit):
  14496. (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
  14497. (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
  14498. (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
  14499. (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
  14500. (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
  14501. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  14502. (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
  14503. (BlackBerry::WebKit::WebPagePrivate::createCompositor):
  14504. (BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
  14505. (BlackBerry::WebKit::WebPagePrivate::setNeedsOneShotDrawingSynchronization):
  14506. * Api/WebPageCompositor.cpp:
  14507. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  14508. (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
  14509. (WebKit):
  14510. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  14511. * Api/WebPageCompositor_p.h:
  14512. (BlackBerry::WebKit::WebPageCompositorPrivate::rootLayer):
  14513. (WebPageCompositorPrivate):
  14514. (BlackBerry::WebKit::WebPageCompositorPrivate::setDrawsRootLayer):
  14515. * Api/WebPage_p.h:
  14516. (WebPagePrivate):
  14517. 2012-04-05 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14518. [BlackBerry] Clear local storage won't take effect until browser exit and relaunch
  14519. https://bugs.webkit.org/show_bug.cgi?id=83253
  14520. Reviewed by Rob Buis.
  14521. RIM PR: #146871
  14522. Cleared the local storage namespace of a WebPage's PageGroup
  14523. when WebPage::clearLocalStorage() get called.
  14524. Also deleted unused global function clearLocalStorage().
  14525. * Api/BlackBerryGlobal.cpp:
  14526. * Api/BlackBerryGlobal.h:
  14527. (WebKit):
  14528. * Api/WebPage.cpp:
  14529. (BlackBerry::WebKit::WebPage::clearLocalStorage):
  14530. 2012-04-04 Rob Buis <rbuis@rim.com>
  14531. [BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
  14532. https://bugs.webkit.org/show_bug.cgi?id=83085
  14533. Reviewed by Antonio Gomes.
  14534. PR 121109
  14535. This way when we add something to the enum and forget to add to the switch we'll get a compile error.
  14536. * Api/WebPage.cpp:
  14537. (BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
  14538. 2012-04-03 Mike Lattanzio <mlattanzio@rim.com>
  14539. [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
  14540. https://bugs.webkit.org/show_bug.cgi?id=82643
  14541. Enhance BlackBerry::WebKit::WebPage::findNextString()
  14542. This patch adds support for toggling case sensitivity,
  14543. search wrapping, and whether or not to highlight all matches
  14544. in addition to the next found match.
  14545. I refactored and renamed the new setActiveMatchAndMarker() method
  14546. to move the active match from one range to another. This was
  14547. required because in the case of a non wrapped search we do not
  14548. want to adjust the m_activeMatch if another match is not found.
  14549. Internal Review by Andy Chen.
  14550. Reviewed by Rob Buis.
  14551. * Api/WebPage.cpp:
  14552. (BlackBerry::WebKit::WebPage::findNextString):
  14553. * Api/WebPage.h:
  14554. * WebKitSupport/InPageSearchManager.cpp:
  14555. (BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
  14556. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  14557. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  14558. (BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
  14559. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  14560. * WebKitSupport/InPageSearchManager.h:
  14561. (InPageSearchManager):
  14562. 2012-04-02 Jacky Jiang <zhajiang@rim.com>
  14563. [BlackBerry] Adapt WebPagePrivate::webContext to the API change of r109570
  14564. https://bugs.webkit.org/show_bug.cgi?id=82945
  14565. Reviewed by Rob Buis.
  14566. RIM PR: 147163
  14567. Adapt WebPagePrivate::webContext to the API change of the security
  14568. cherry-pick of r109570 and r112023.
  14569. * Api/WebPage.cpp:
  14570. (BlackBerry::WebKit::WebPagePrivate::webContext):
  14571. 2012-04-02 Lianghui Chen <liachen@rim.com>
  14572. [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
  14573. https://bugs.webkit.org/show_bug.cgi?id=80519
  14574. Set the right TargetType for main loads if they are not already set in
  14575. dispatchWillSendRequest().
  14576. Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
  14577. and dispatchDecidePolicyForNavigationAction() as they are called before
  14578. dispatchWillSendRequest() is called. Patch to change ResourceRequest
  14579. TargetType earlier has been rejected as in WebKit bug
  14580. https://bugs.webkit.org/show_bug.cgi?id=80713
  14581. Reviewed by Rob Buis.
  14582. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14583. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  14584. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  14585. (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
  14586. 2012-04-01 Arvid Nilsson <anilsson@rim.com>
  14587. [BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
  14588. https://bugs.webkit.org/show_bug.cgi?id=82845
  14589. Reviewed by Rob Buis.
  14590. RIM PR: 136381
  14591. The code accounted for a now obsolete setup where we used one OpenGL
  14592. window for accelerated compositing and one native window for backing
  14593. store output, and let the windowing system composite those two. In that
  14594. setup an optimization to try and only update the window that had
  14595. changed was viable.
  14596. Nowadays, we either use an offscreen surface for accelerated
  14597. compositing output, which we blend onto the window containing the
  14598. backing store output, or render both backing store and accelerated
  14599. compositing output directly to one OpenGL window. We always have to
  14600. blit the backingstore contents and draw the accelerated compositing
  14601. output every frame with these code paths, so don't try to be clever
  14602. about it.
  14603. Even when we use an OpenGL window, the compositing surface can be non-
  14604. null, so don't try to glFinish() and swap the compositing surface when
  14605. the GLES2Context is tied to a window.
  14606. * Api/BackingStore.cpp:
  14607. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  14608. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  14609. (WebKit):
  14610. * Api/BackingStore_p.h:
  14611. (BackingStorePrivate):
  14612. * Api/WebPage.cpp:
  14613. (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
  14614. * WebKitSupport/GLES2Context.cpp:
  14615. (BlackBerry::WebKit::GLES2Context::swapBuffers):
  14616. 2012-03-31 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14617. [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
  14618. https://bugs.webkit.org/show_bug.cgi?id=80135
  14619. Reviewed by Rob Buis.
  14620. RIM PR: 145660
  14621. Fixed a regression introduced by r111810, which used the wrong
  14622. credential object.
  14623. * Api/WebPage.cpp:
  14624. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  14625. 2012-03-30 Mike Fenton <mifenton@rim.com>
  14626. [BlackBerry] Speed up processing of Selection region generation.
  14627. https://bugs.webkit.org/show_bug.cgi?id=82766
  14628. Reviewed by Rob Buis.
  14629. PR 136593.
  14630. Refactor generation of Selection IntRectRegion to avoid
  14631. the need for IntRectRegion's helper functions which were
  14632. not available when using it as a container without
  14633. unioning the rects.
  14634. This greatly speeds up rendering by maintaining the distinct
  14635. rects as the union operation was length with large numbers of
  14636. rects.
  14637. Reviewed Internally by Gen Mak, Mike Lattanzio and Tyler Abbott.
  14638. * WebKitSupport/DOMSupport.cpp:
  14639. (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
  14640. (DOMSupport):
  14641. * WebKitSupport/DOMSupport.h:
  14642. * WebKitSupport/SelectionHandler.cpp:
  14643. (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
  14644. (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
  14645. (BlackBerry::WebKit::SelectionHandler::setSelection):
  14646. (WebKit):
  14647. (BlackBerry::WebKit::regionRectListContainsPoint):
  14648. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  14649. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  14650. * WebKitSupport/SelectionHandler.h:
  14651. (WebCore):
  14652. (SelectionHandler):
  14653. 2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
  14654. GEOLOCATION should be implemented as Page Supplement
  14655. https://bugs.webkit.org/show_bug.cgi?id=82228
  14656. Reviewed by Adam Barth.
  14657. Geolocation is now a Supplement in Page so the interface
  14658. has changed for setting up the page's geolocation client
  14659. initially and accessing the controller later.
  14660. * Api/WebPage.cpp:
  14661. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  14662. (BlackBerry::WebKit::WebPagePrivate::init):
  14663. * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
  14664. (GeolocationControllerClientBlackBerry::onLocationUpdate):
  14665. (GeolocationControllerClientBlackBerry::onLocationError):
  14666. * WebKitSupport/DumpRenderTreeSupport.cpp:
  14667. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  14668. (DumpRenderTreeSupport::resetGeolocationMock):
  14669. (DumpRenderTreeSupport::setMockGeolocationError):
  14670. (DumpRenderTreeSupport::setMockGeolocationPermission):
  14671. (DumpRenderTreeSupport::setMockGeolocationPosition):
  14672. 2012-03-30 Keishi Hattori <keishi@webkit.org>
  14673. Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
  14674. https://bugs.webkit.org/show_bug.cgi?id=80972
  14675. Reviewed by Kent Tamura.
  14676. * WebCoreSupport/AboutDataEnableFeatures.in:
  14677. * WebCoreSupport/ChromeClientBlackBerry.h:
  14678. (ChromeClientBlackBerry):
  14679. * WebKitSupport/DOMSupport.cpp:
  14680. (BlackBerry::WebKit::DOMSupport::isColorInputField):
  14681. * WebKitSupport/InputHandler.cpp:
  14682. (BlackBerry::WebKit::convertInputType):
  14683. 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
  14684. Unreviewed, rolling out r111259.
  14685. http://trac.webkit.org/changeset/111259
  14686. https://bugs.webkit.org/show_bug.cgi?id=82650
  14687. Caused selection regression in calculations due to
  14688. misconstructed IntRectRegion. (Requested by mfenton on
  14689. #webkit).
  14690. * WebKitSupport/SelectionHandler.cpp:
  14691. (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
  14692. 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
  14693. Unreviewed, rolling out r112553.
  14694. http://trac.webkit.org/changeset/112553
  14695. https://bugs.webkit.org/show_bug.cgi?id=82638
  14696. It made all tests crash on Qt WK2 (Requested by Ossy_away on
  14697. #webkit).
  14698. * Api/WebPage.cpp:
  14699. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  14700. (BlackBerry::WebKit::WebPagePrivate::init):
  14701. * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
  14702. (GeolocationControllerClientBlackBerry::onLocationUpdate):
  14703. (GeolocationControllerClientBlackBerry::onLocationError):
  14704. * WebKitSupport/DumpRenderTreeSupport.cpp:
  14705. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  14706. (DumpRenderTreeSupport::resetGeolocationMock):
  14707. (DumpRenderTreeSupport::setMockGeolocationError):
  14708. (DumpRenderTreeSupport::setMockGeolocationPermission):
  14709. (DumpRenderTreeSupport::setMockGeolocationPosition):
  14710. 2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
  14711. GEOLOCATION should be implemented as Page Supplement
  14712. https://bugs.webkit.org/show_bug.cgi?id=82228
  14713. Reviewed by Adam Barth.
  14714. Geolocation is now a Supplement in Page so the interface
  14715. has changed for setting up the page's geolocation client
  14716. initially and accessing the controller later.
  14717. * Api/WebPage.cpp:
  14718. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  14719. (BlackBerry::WebKit::WebPagePrivate::init):
  14720. * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
  14721. (GeolocationControllerClientBlackBerry::onLocationUpdate):
  14722. (GeolocationControllerClientBlackBerry::onLocationError):
  14723. * WebKitSupport/DumpRenderTreeSupport.cpp:
  14724. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  14725. (DumpRenderTreeSupport::resetGeolocationMock):
  14726. (DumpRenderTreeSupport::setMockGeolocationError):
  14727. (DumpRenderTreeSupport::setMockGeolocationPermission):
  14728. (DumpRenderTreeSupport::setMockGeolocationPosition):
  14729. 2012-03-28 Nate Chapin <japhet@chromium.org>
  14730. Remove dispatchDidLoadMainResource callback, since no
  14731. port implements it.
  14732. https://bugs.webkit.org/show_bug.cgi?id=82539
  14733. Reviewed by Alexey Proskuryakov.
  14734. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  14735. (FrameLoaderClientBlackBerry):
  14736. 2012-03-28 Leo Yang <leo.yang@torchmobile.com.cn>
  14737. [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
  14738. https://bugs.webkit.org/show_bug.cgi?id=82420
  14739. Reviewed by Rob Buis.
  14740. In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
  14741. for PlatformMouseEvent, but this method is same as globalPosition() that is available for
  14742. every porting. We should use globalPosition().
  14743. * Api/WebPage.cpp:
  14744. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  14745. 2012-03-27 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
  14746. [BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
  14747. https://bugs.webkit.org/show_bug.cgi?id=82292
  14748. Change to check and avoid text selection across frames.
  14749. Internal reviewed by Mike Fenton
  14750. Reviewed by Rob Buis.
  14751. * WebKitSupport/SelectionHandler.cpp:
  14752. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  14753. support selection across frames, so check if the *framePoint* is in
  14754. the *frame*.
  14755. (BlackBerry::WebKit::SelectionHandler::setSelection):
  14756. function returns a null VisablePosition, it stands for a invalid position
  14757. or a position in the different frames, therefor we don't execute setting
  14758. handle's position.
  14759. 2012-03-27 Andrew Lo <anlo@rim.com>
  14760. [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
  14761. https://bugs.webkit.org/show_bug.cgi?id=82350
  14762. Switch timer in WebPageCompositor to use AnimationFrameRateController.
  14763. Reviewed by Rob Buis.
  14764. * Api/WebPageCompositor.cpp:
  14765. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  14766. (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
  14767. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  14768. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
  14769. * Api/WebPageCompositor_p.h:
  14770. (WebPageCompositorPrivate):
  14771. 2012-03-27 Chris Guan <chris.guan@torchmobile.com.cn>
  14772. A page containing multiparts with "multipart/x-mixed-replace" should not be cached.
  14773. https://bugs.webkit.org/show_bug.cgi?id=82291
  14774. Reviewed by Rob Buis.
  14775. If we have a multiPart reponse with multipart/x-mixed-replace,
  14776. the current page should not be cached. I use isMultipartPayload()
  14777. API which was supposed to be set in NetworkJob to decide to
  14778. cache page or not.
  14779. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14780. (WebCore::FrameLoaderClientBlackBerry::canCachePage):
  14781. 2012-03-25 Arvid Nilsson <anilsson@rim.com>
  14782. [BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor
  14783. https://bugs.webkit.org/show_bug.cgi?id=82104
  14784. RIM PR: 145963
  14785. Reviewed by Rob Buis.
  14786. The root layer may be set before we have a layer renderer, because the
  14787. latter is not created until we get an OpenGL context from the embedder.
  14788. Fixed by setting the root layer on the layer renderer when it's created
  14789. instead of assuming a certain order of events.
  14790. * Api/WebPageCompositor.cpp:
  14791. (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
  14792. (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
  14793. 2012-03-23 Arvid Nilsson <anilsson@rim.com>
  14794. [BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API
  14795. https://bugs.webkit.org/show_bug.cgi?id=81121
  14796. RIM PR: 136687
  14797. Reviewed by Rob Buis.
  14798. The idea is for the API client to use a WebPageCompositor object to
  14799. render the WebPage when there's no screen window available.
  14800. The WebPageCompositorPrivate becomes reference counted in order to be
  14801. kept alive either because it's used for accelerated compositing layers
  14802. or used for the WebPageCompositor API. It can still work standalone.
  14803. Clean up some code - no need to keep track of a separate boolean
  14804. WebPagePrivate::m_isAcceleratedCompositingActive when the state of
  14805. m_compositor can tell you.
  14806. Also remove duplicated code from WebPagePrivate - go directly to the
  14807. compositor object instead, if you need to draw the AC layers.
  14808. Reviewed internally by Robin Cao and the hasBlitJobs/blitOnIdle change
  14809. by Filip Spacek.
  14810. * Api/BackingStore.cpp:
  14811. (BlackBerry::WebKit::BackingStore::hasBlitJobs):
  14812. (BlackBerry::WebKit::BackingStore::blitOnIdle):
  14813. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  14814. (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
  14815. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  14816. (BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
  14817. (BlackBerry::WebKit::BackingStorePrivate::buffer):
  14818. * Api/WebPage.cpp:
  14819. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  14820. (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
  14821. (BlackBerry::WebKit::WebPagePrivate::setCompositor):
  14822. (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
  14823. (BlackBerry::WebKit::WebPagePrivate::createCompositor):
  14824. (BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
  14825. * Api/WebPage.h:
  14826. * Api/WebPageCompositor.cpp:
  14827. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  14828. (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
  14829. (BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
  14830. (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
  14831. (BlackBerry::WebKit::WebPageCompositorPrivate::render):
  14832. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  14833. (BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
  14834. (BlackBerry::WebKit::WebPageCompositorPrivate::compositorDestroyed):
  14835. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  14836. (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
  14837. (BlackBerry::WebKit::WebPageCompositor::client):
  14838. (BlackBerry::WebKit::WebPageCompositor::prepareFrame):
  14839. (BlackBerry::WebKit::WebPageCompositor::render):
  14840. (BlackBerry::WebKit::WebPageCompositor::cleanup):
  14841. (BlackBerry::WebKit::WebPageCompositor::contextLost):
  14842. * Api/WebPageCompositor.h: Added.
  14843. * Api/WebPageCompositorClient.h: Added.
  14844. * Api/WebPageCompositor_p.h:
  14845. (BlackBerry::WebKit::WebPageCompositorPrivate::create):
  14846. (BlackBerry::WebKit::WebPageCompositorPrivate::context):
  14847. (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameTimestamp):
  14848. (BlackBerry::WebKit::WebPageCompositorPrivate::page):
  14849. (BlackBerry::WebKit::WebPageCompositorPrivate::client):
  14850. * Api/WebPage_p.h:
  14851. (BlackBerry::WebKit::WebPagePrivate::client):
  14852. (BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
  14853. (BlackBerry::WebKit::WebPagePrivate::compositor):
  14854. 2012-03-22 Charles Wei <charles.wei@torchmobile.com.cn>
  14855. [BlackBerry] Need to store the meta info of a page in the ViewState of the history
  14856. https://bugs.webkit.org/show_bug.cgi?id=82000
  14857. Reviewed by Rob Buis.
  14858. Internally reviewed by George Staikos.
  14859. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14860. (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
  14861. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  14862. 2012-03-22 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14863. [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
  14864. https://bugs.webkit.org/show_bug.cgi?id=81887
  14865. Reviewed by Rob Buis.
  14866. Added two interface functions clearCredentials() and
  14867. clearNeverRememberSites() into class WebPage, which
  14868. should be used by UI to clear the stored credential
  14869. information and never remember sites.
  14870. Also implemented the corresponding functions in class
  14871. CredentialManager to call CredentialBackingStore
  14872. to perform the actual clear table work.
  14873. * Api/WebPage.cpp:
  14874. (BlackBerry::WebKit::WebPage::clearCredentials):
  14875. (WebKit):
  14876. (BlackBerry::WebKit::WebPage::clearNeverRememberSites):
  14877. * Api/WebPage.h:
  14878. * WebCoreSupport/CredentialManager.cpp:
  14879. (WebCore::CredentialManager::clearCredentials):
  14880. (WebCore):
  14881. (WebCore::CredentialManager::clearNeverRememberSites):
  14882. * WebCoreSupport/CredentialManager.h:
  14883. (CredentialManager):
  14884. 2012-03-22 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14885. [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
  14886. https://bugs.webkit.org/show_bug.cgi?id=80135
  14887. Reviewed by Rob Buis.
  14888. Modified the interface function authenticationChallenge() in
  14889. class WebPagePrivate by returning a bool to indicate if user
  14890. pressed Ok button or not, and moved the Credential from return
  14891. value to the reference parameter.
  14892. Also updated the corresponding interface functions in class
  14893. WebPageClient.
  14894. * Api/WebPage.cpp:
  14895. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  14896. * Api/WebPageClient.h:
  14897. * Api/WebPage_p.h:
  14898. (WebPagePrivate):
  14899. 2012-03-22 Mike Lattanzio <mlattanzio@rim.com>
  14900. [BlackBerry] DeviceDPI Scaling is broken on mobile.
  14901. https://bugs.webkit.org/show_bug.cgi?id=81966
  14902. Fix our viewport argument handling to only override the
  14903. targetDensityDpi on tablet devices. Allow WebCore to use
  14904. dpi scaling for smaller screen mobile devices.
  14905. Reviewed by Rob Buis.
  14906. * Api/WebPage.cpp:
  14907. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  14908. 2012-03-22 Mike Fenton <mifenton@rim.com>
  14909. [BlackBerry] Add pattern matching for hexadecimal type input fields
  14910. https://bugs.webkit.org/show_bug.cgi?id=81944
  14911. Reviewed by Rob Buis.
  14912. PR 98504.
  14913. Add mapping of patterns matching hexadecimal input
  14914. to a specialized type and provide input styling based
  14915. on that format.
  14916. Reviewed Internally by Gen Mak.
  14917. * WebKitSupport/DOMSupport.cpp:
  14918. (BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
  14919. (DOMSupport):
  14920. * WebKitSupport/DOMSupport.h:
  14921. * WebKitSupport/InputHandler.cpp:
  14922. (BlackBerry::WebKit::convertInputType):
  14923. (BlackBerry::WebKit::inputStyle):
  14924. 2012-03-22 Mike Fenton <mifenton@rim.com>
  14925. [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
  14926. https://bugs.webkit.org/show_bug.cgi?id=81929
  14927. Reviewed by Rob Buis.
  14928. Make suggested style clean up and move int offset = 0 directly
  14929. above is actual usage.
  14930. * WebKitSupport/DOMSupport.cpp:
  14931. (BlackBerry::WebKit::DOMSupport::isPositionInNode):
  14932. 2012-03-22 Mike Fenton <mifenton@rim.com>
  14933. [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
  14934. https://bugs.webkit.org/show_bug.cgi?id=81929
  14935. Reviewed by Rob Buis.
  14936. Add early returns in isPositionInNode when either
  14937. node or the position node is null.
  14938. * WebKitSupport/DOMSupport.cpp:
  14939. (BlackBerry::WebKit::DOMSupport::isPositionInNode):
  14940. 2012-03-21 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  14941. [BlackBerry] Credential save and autofill implemetation
  14942. https://bugs.webkit.org/show_bug.cgi?id=80401
  14943. Reviewed by Rob Buis.
  14944. This patch is intended to implement the credential persist
  14945. and autofill feature for BlackBerry porting.
  14946. Moved interface authenticationChallenge() from class
  14947. FrameLoaderClientBlackBerry to WebPagePrivate (derived from
  14948. PageClientBlackBerry as changes made in its parent interface class);
  14949. Implemented notifyShouldSaveCredential() in WebPagePrivate
  14950. and WebPageClient as well.
  14951. Added credentialManager() to retrive CredentialManager instance
  14952. as a global singleton; removed its m_frameLoaderClient which is
  14953. replaced with a passed in PageClientBlackBerry pointer, and modified
  14954. the interface function accordingly.
  14955. For the http authentication, autofill the input dialog in
  14956. function authenticationChallenge() and save the credential
  14957. information in the same function;
  14958. For the in-form authentication, autofill the username and
  14959. password input fields in function dispatchDidFinishLoad(),
  14960. and save the credential information in function
  14961. dispatchWillSubmitForm() or dispatchWillSendSubmitEvent().
  14962. * Api/WebPage.cpp:
  14963. (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
  14964. (WebKit):
  14965. (BlackBerry::WebKit::WebPagePrivate::notifyShouldSaveCredential):
  14966. * Api/WebPageClient.h:
  14967. * Api/WebPage_p.h:
  14968. (WebPagePrivate):
  14969. * WebCoreSupport/CredentialManager.cpp:
  14970. (WebCore::credentialManager):
  14971. (WebCore::CredentialManager::saveCredentialIfConfirmed):
  14972. * WebCoreSupport/CredentialManager.h:
  14973. (CredentialManager):
  14974. (WebCore::CredentialManager::CredentialManager):
  14975. (WebCore):
  14976. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14977. (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
  14978. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
  14979. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
  14980. (WebCore):
  14981. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  14982. (FrameLoaderClientBlackBerry):
  14983. 2012-03-20 Jacky Jiang <zhajiang@rim.com>
  14984. [BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
  14985. https://bugs.webkit.org/show_bug.cgi?id=81686
  14986. Reviewed by Rob Buis.
  14987. When deciding the policy for navigation action, if the url of the
  14988. request is null, ignore it to avoid the ASSERT failure in
  14989. MainResourceLoader::willSendRequest.
  14990. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  14991. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  14992. 2012-03-20 Konrad Piascik <kpiascik@rim.com>
  14993. [BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
  14994. https://bugs.webkit.org/show_bug.cgi?id=81670
  14995. Reviewed by Rob Buis.
  14996. * WebCoreSupport/InspectorClientBlackBerry.h:
  14997. (WebCore::InspectorClientBlackBerry::canClearBrowserCache):
  14998. (WebCore::InspectorClientBlackBerry::canClearBrowserCookies):
  14999. 2012-03-20 Nima Ghanavatian <nghanavatian@rim.com>
  15000. [BlackBerry] Removing doubly defined methods in BackingStore.cpp
  15001. https://bugs.webkit.org/show_bug.cgi?id=81664
  15002. Reviewed by Rob Buis.
  15003. * Api/BackingStore.cpp:
  15004. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  15005. 2012-03-20 Mike Fenton <mifenton@rim.com>
  15006. [BlackBerry] Crash when dragging the FCC caret over an invalid node.
  15007. https://bugs.webkit.org/show_bug.cgi?id=81654
  15008. Reviewed by Rob Buis.
  15009. PR 144505.
  15010. The position did not have a valid container node and was causing
  15011. a crash. Validate the node pointer before using it.
  15012. * WebKitSupport/DOMSupport.cpp:
  15013. (BlackBerry::WebKit::DOMSupport::DOMContainerNodeForPosition):
  15014. 2012-03-20 Jason Liu <jason.liu@torchmobile.com.cn>
  15015. [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.
  15016. https://bugs.webkit.org/show_bug.cgi?id=80800
  15017. Reviewed by George Staikos.
  15018. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15019. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
  15020. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  15021. (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
  15022. 2012-03-19 Adam Barth <abarth@webkit.org>
  15023. Remove support for "magic" iframe
  15024. https://bugs.webkit.org/show_bug.cgi?id=81590
  15025. Reviewed by Eric Seidel.
  15026. Remove FrameLoaderClient methods that no longer exist.
  15027. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15028. (WebCore):
  15029. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  15030. (FrameLoaderClientBlackBerry):
  15031. (WebCore::FrameLoaderClientBlackBerry::didDetectXSS):
  15032. 2012-03-19 Tyler Abbott <tabbott@rim.com>
  15033. [BlackBerry] speed up text selection for large selections
  15034. https://bugs.webkit.org/show_bug.cgi?id=81536
  15035. When selecting large disjoint areas of text the cost
  15036. of calculating the IntRectRegion union becomes very
  15037. expensive. Simply placing all of the text quads into
  15038. the IntRectRegion is faster despite the larger memory
  15039. footprint and the additional calculations at render
  15040. time.
  15041. Reviewed by Rob Buis.
  15042. * WebKitSupport/SelectionHandler.cpp:
  15043. (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
  15044. 2012-03-19 Mike Lattanzio <mlattanzio@rim.com>
  15045. [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
  15046. https://bugs.webkit.org/show_bug.cgi?id=81269
  15047. Generate the UserAgent lazily, using it as the default for the
  15048. WebSettings object. BlackBerry::Platform::DeviceInfo is used
  15049. to ensure the information is accurate to the specific device.
  15050. Remove the !isEmpty() assert when fetching the UA from the
  15051. WebSettings object, as it will now always be properly initialized.
  15052. Add a static initializer block to ensure defaultUserAgent() is
  15053. thread-safe from that moment onward.
  15054. Reviewed by Rob Buis.
  15055. * Api/WebPage.cpp:
  15056. (WebKit):
  15057. (BlackBerry::WebKit::WebPagePrivate::init):
  15058. (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
  15059. * Api/WebPage_p.h:
  15060. (WebPagePrivate):
  15061. * Api/WebSettings.cpp:
  15062. (BlackBerry::WebKit::WebSettings::setUserAgentString):
  15063. * Api/WebSettings.h:
  15064. 2012-03-19 Mike Fenton <mifenton@rim.com>
  15065. [BlackBerry] Input fields with id of e-mail and url should be styled as such.
  15066. https://bugs.webkit.org/show_bug.cgi?id=81364
  15067. Reviewed by Rob Buis.
  15068. Be less aggressive on matching url, and update as suggested by Rob.
  15069. * WebKitSupport/DOMSupport.cpp:
  15070. (BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
  15071. * WebKitSupport/InputHandler.cpp:
  15072. (BlackBerry::WebKit::inputStyle):
  15073. 2012-03-19 Arvid Nilsson <anilsson@rim.com>
  15074. [BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
  15075. https://bugs.webkit.org/show_bug.cgi?id=81115
  15076. Reviewed by Benjamin Poulain.
  15077. The compositor tried to avoid rendering the same stuff twice, using a
  15078. mechanism that didn't work properly and has been redundant since we
  15079. introduced deferred blits. Remove this code.
  15080. Reviewed internally by Robin Cao.
  15081. * Api/WebPageCompositor.cpp:
  15082. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  15083. (BlackBerry::WebKit::WebPageCompositorPrivate::commit):
  15084. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  15085. * Api/WebPageCompositor_p.h:
  15086. 2012-03-17 Charles Wei <charles.wei@torchmobile.com.cn>
  15087. [BlackBerry] Enable Web Timing for performance profiling and improvement.
  15088. https://bugs.webkit.org/show_bug.cgi?id=81085
  15089. Reviewed by Rob Buis.
  15090. * Api/WebPage.cpp:
  15091. (BlackBerry::WebKit::WebPagePrivate::init):
  15092. 2012-03-16 Arvid Nilsson <anilsson@rim.com>
  15093. [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
  15094. https://bugs.webkit.org/show_bug.cgi?id=81108
  15095. RIM PR: 136687
  15096. Reviewed by Rob Buis.
  15097. This is done in anticipation of a new WebPageCompositor class in the
  15098. public API. The existing internal class will serve to d-pointerize the
  15099. new public API. In addition, it is and will be possible to create only
  15100. the private class, for cases where existing code paths require
  15101. OpenGL compositing (i.e. due to accelerated compositing layers being
  15102. added to the page).
  15103. Reviewed internally by Robin Cao.
  15104. * Api/BackingStore.h:
  15105. * Api/WebPage.cpp:
  15106. (BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):
  15107. * Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.
  15108. (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
  15109. (BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
  15110. (BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
  15111. (BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
  15112. (BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
  15113. (BlackBerry::WebKit::WebPageCompositorPrivate::commit):
  15114. (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
  15115. (BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
  15116. (BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
  15117. * Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.
  15118. (BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
  15119. (BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
  15120. (BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
  15121. (BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
  15122. (BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
  15123. (BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):
  15124. * Api/WebPage_p.h:
  15125. * CMakeListsBlackBerry.txt:
  15126. 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
  15127. [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
  15128. https://bugs.webkit.org/show_bug.cgi?id=81118
  15129. Reviewed by Rob Buis.
  15130. This is a consolidation of various changes that are in our local dev branch
  15131. but do not appear in our upstreamed port.
  15132. * WebKitSupport/DumpRenderTreeSupport.cpp:
  15133. (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
  15134. * WebKitSupport/FatFingers.cpp:
  15135. (BlackBerry::WebKit::FatFingers::isElementClickable):
  15136. * WebKitSupport/InputHandler.cpp:
  15137. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  15138. * WebKitSupport/SurfacePool.cpp:
  15139. (BlackBerry::WebKit::SurfacePool::createBuffers):
  15140. (BlackBerry::WebKit::SurfacePool::releaseBuffers):
  15141. * WebKitSupport/TouchEventHandler.cpp:
  15142. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  15143. (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
  15144. * WebKitSupport/WebPageCompositor.cpp:
  15145. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  15146. * WebKitSupport/WebPageCompositor.h:
  15147. (WebPageCompositor):
  15148. 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
  15149. [BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
  15150. https://bugs.webkit.org/show_bug.cgi?id=81120
  15151. Reviewed by Rob Buis.
  15152. This is a consolidation of various changes that are in our local dev branch
  15153. but do not appear in our upstreamed port.
  15154. * WebCoreSupport/AboutDataEnableFeatures.in:
  15155. * WebCoreSupport/AboutDataHaveFeatures.in:
  15156. * WebCoreSupport/AboutDataUseFeatures.in:
  15157. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15158. (WebCore::ChromeClientBlackBerry::hasOpenedPopup):
  15159. (WebCore):
  15160. (WebCore::ChromeClientBlackBerry::screenToRootView):
  15161. (WebCore::ChromeClientBlackBerry::rootViewToScreen):
  15162. (WebCore::ChromeClientBlackBerry::invalidateRootView):
  15163. (WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
  15164. (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
  15165. (WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
  15166. (WebCore::ChromeClientBlackBerry::createColorChooser):
  15167. * WebCoreSupport/ChromeClientBlackBerry.h:
  15168. (ChromeClientBlackBerry):
  15169. (WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):
  15170. * WebCoreSupport/EditorClientBlackBerry.cpp:
  15171. (WebCore::EditorClientBlackBerry::registerUndoStep):
  15172. (WebCore::EditorClientBlackBerry::registerRedoStep):
  15173. (WebCore::EditorClientBlackBerry::undo):
  15174. (WebCore::EditorClientBlackBerry::redo):
  15175. * WebCoreSupport/EditorClientBlackBerry.h:
  15176. (EditorClientBlackBerry):
  15177. * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
  15178. (GeolocationControllerClientBlackBerry::requestPermission):
  15179. (GeolocationControllerClientBlackBerry::cancelPermissionRequest):
  15180. * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
  15181. * WebCoreSupport/InspectorClientBlackBerry.cpp:
  15182. (WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
  15183. (WebCore):
  15184. (WebCore::InspectorClientBlackBerry::bringFrontendToFront):
  15185. * WebCoreSupport/InspectorClientBlackBerry.h:
  15186. (InspectorClientBlackBerry):
  15187. * WebCoreSupport/NotificationPresenterImpl.cpp:
  15188. (WebCore::NotificationPresenterImpl::show):
  15189. 2012-03-16 Mike Fenton <mifenton@rim.com>
  15190. [BlackBerry] Input fields with id of e-mail and url should be styled as such.
  15191. https://bugs.webkit.org/show_bug.cgi?id=81364
  15192. Reviewed by Rob Buis.
  15193. Treat fields that have name/id's that match url or
  15194. email as url or email fields providing the appropriate
  15195. keyboard.
  15196. PR 137259.
  15197. Reviewed Internally by Gen Mak and Nima Ghanavatian.
  15198. * WebKitSupport/DOMSupport.cpp:
  15199. (BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
  15200. (DOMSupport):
  15201. (BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
  15202. (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
  15203. (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
  15204. (BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):
  15205. * WebKitSupport/DOMSupport.h:
  15206. (WebCore):
  15207. * WebKitSupport/InputHandler.cpp:
  15208. (BlackBerry::WebKit::convertInputType):
  15209. (BlackBerry::WebKit::inputStyle):
  15210. 2012-03-16 Nima Ghanavatian <nghanavatian@rim.com>
  15211. [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
  15212. https://bugs.webkit.org/show_bug.cgi?id=81105
  15213. Reviewed by Rob Buis.
  15214. This patches fixes up a previous sync done in this directory and adds some new bits
  15215. as well. This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
  15216. local repo.
  15217. * Api/BackingStore.cpp:
  15218. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  15219. (WebKit):
  15220. (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
  15221. * Api/WebPage.cpp:
  15222. (BlackBerry::WebKit::WebPagePrivate::webContext):
  15223. (BlackBerry::WebKit::WebPage::webContext):
  15224. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  15225. * Api/WebPage.h:
  15226. * Api/WebPage_p.h:
  15227. (WebPagePrivate):
  15228. 2012-03-16 Mike Fenton <mifenton@rim.com>
  15229. [BlackBerry] Input processing mode should be cancelled when processing hot keys
  15230. https://bugs.webkit.org/show_bug.cgi?id=81348
  15231. Reviewed by Rob Buis.
  15232. Don't suppress IMF notifications if we are handling
  15233. the event as a hotkey.
  15234. Reviewed Internally by Nima Ghanavatian.
  15235. * WebCoreSupport/EditorClientBlackBerry.cpp:
  15236. (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
  15237. 2012-03-16 Robin Cao <robin.cao@torchmobile.com.cn>
  15238. [BlackBerry] Can not open certain links from bridge applications
  15239. https://bugs.webkit.org/show_bug.cgi?id=81197
  15240. Reviewed by Rob Buis.
  15241. Currently, the engine asks the client to handle some type of requests externally.
  15242. But WebPageClient::handleStringPattern is not yet implemented and exposed to
  15243. the client. Before that, we still need to give the client a chance to decide
  15244. how to handle requests such as 'mailto:'.
  15245. To address this problem, r108763 introduced a change that ask the client to
  15246. decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
  15247. This is not intuitive and will bring troubles, because this navigation will
  15248. happen in the new page. So the new page client is to decide how to handle
  15249. the navigation, not the old one.
  15250. This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
  15251. since it's not implemented.
  15252. This way the new window action will continue, and the logic in
  15253. dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.
  15254. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15255. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
  15256. (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
  15257. 2012-03-16 Leo Yang <leo.yang@torchmobile.com.cn>
  15258. [BlackBerry] Crash when going back from an xhtml document containing <img>
  15259. https://bugs.webkit.org/show_bug.cgi?id=81297
  15260. Reviewed by Rob Buis.
  15261. This is manually reverting the offending internal commit which checked-in before upstreaming.
  15262. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15263. (WebCore::FrameLoaderClientBlackBerry::canCachePage):
  15264. 2012-03-16 Genevieve Mak <gmak@rim.com>
  15265. [BlackBerry] viewportRect has changed to viewportSize
  15266. https://bugs.webkit.org/show_bug.cgi?id=81262
  15267. Reviewed by Antonio Gomes.
  15268. Set size instead of rect in constructor.
  15269. * WebKitSupport/InRegionScrollableArea.cpp:
  15270. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  15271. 2012-03-16 Andrew Lo <anlo@rim.com>
  15272. [BlackBerry] Enable PAGE_VISIBILITY_API
  15273. https://bugs.webkit.org/show_bug.cgi?id=81257
  15274. Set Page visibility state for BlackBerry port.
  15275. Reviewed by Rob Buis.
  15276. * Api/WebPage.cpp:
  15277. (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
  15278. (WebKit):
  15279. (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
  15280. (BlackBerry::WebKit::WebPagePrivate::setVisible):
  15281. (BlackBerry::WebKit::WebPage::setVisible):
  15282. (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
  15283. (BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
  15284. * Api/WebPage_p.h:
  15285. (WebPagePrivate):
  15286. 2012-03-14 Arvid Nilsson <anilsson@rim.com>
  15287. [BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
  15288. https://bugs.webkit.org/show_bug.cgi?id=81099
  15289. Reviewed by Rob Buis.
  15290. Also rename the "compositing/blitting to main window" variables to
  15291. instead refer to OpenGL compositing. The code paths it triggers are
  15292. related to the BackingStore using OpenGL compositing, and can be useful
  15293. even when there's no window.
  15294. * Api/BackingStore.cpp:
  15295. (BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
  15296. (BlackBerry::WebKit::BackingStorePrivate::render):
  15297. (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
  15298. (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
  15299. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  15300. (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
  15301. (BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
  15302. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  15303. (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
  15304. (BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
  15305. (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
  15306. (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
  15307. (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
  15308. (BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
  15309. (BlackBerry::WebKit::BackingStorePrivate::buffer):
  15310. * Api/BackingStore_p.h:
  15311. * Api/WebPage.cpp:
  15312. (BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
  15313. (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
  15314. (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
  15315. (BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
  15316. (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
  15317. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15318. (WebCore::ChromeClientBlackBerry::windowRect):
  15319. (WebCore::ChromeClientBlackBerry::screenToWindow):
  15320. (WebCore::ChromeClientBlackBerry::windowToScreen):
  15321. * WebKitSupport/GLES2Context.cpp:
  15322. (BlackBerry::WebKit::GLES2Context::GLES2Context):
  15323. * WebKitSupport/TouchEventHandler.h:
  15324. * WebKitSupport/WebPageCompositor.cpp:
  15325. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  15326. (BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
  15327. (BlackBerry::WebKit::WebPageCompositor::drawLayers):
  15328. * WebKitSupport/WebPageCompositor.h:
  15329. 2012-03-13 Jon Lee <jonlee@apple.com>
  15330. Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
  15331. https://bugs.webkit.org/show_bug.cgi?id=80922
  15332. <rdar://problem/11035082>
  15333. Reviewed by Jian Li.
  15334. You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
  15335. LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
  15336. new API. Therefore, APIs that are common between the two will have:
  15337. #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
  15338. This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
  15339. the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
  15340. Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
  15341. * Api/WebPage.cpp:
  15342. (BlackBerry::WebKit::WebPagePrivate::init):
  15343. * WebCoreSupport/NotificationPresenterImpl.cpp:
  15344. * WebCoreSupport/NotificationPresenterImpl.h:
  15345. 2012-03-14 Nima Ghanavatian <nghanavatian@rim.com>
  15346. [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
  15347. https://bugs.webkit.org/show_bug.cgi?id=81105
  15348. Reviewed by Rob Buis.
  15349. * Api/BackingStore.cpp:
  15350. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  15351. (BlackBerry::WebKit::BackingStorePrivate::isActive):
  15352. (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
  15353. (WebKit):
  15354. (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
  15355. * Api/BackingStore.h:
  15356. * Api/WebPage.cpp:
  15357. (BlackBerry::WebKit::toWebCoreMouseEventType):
  15358. (BlackBerry::WebKit::WebPagePrivate::init):
  15359. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  15360. (BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
  15361. (BlackBerry::WebKit::WebPage::activeNodeContext):
  15362. (BlackBerry::WebKit::WebPagePrivate::updateCursor):
  15363. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  15364. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  15365. * Api/WebPage.h:
  15366. * Api/WebPage_p.h:
  15367. (WebPagePrivate):
  15368. 2012-03-14 Andrew Lo <anlo@rim.com>
  15369. [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
  15370. https://bugs.webkit.org/show_bug.cgi?id=81000
  15371. Set the platform display ID, needed for DisplayRefreshMonitor.
  15372. Reviewed by Antonio Gomes.
  15373. * Api/WebPage.cpp:
  15374. (BlackBerry::WebKit::WebPagePrivate::init):
  15375. 2012-03-14 Leo Yang <leo.yang@torchmobile.com.cn>
  15376. [BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
  15377. https://bugs.webkit.org/show_bug.cgi?id=81086
  15378. Reviewed by Rob Buis.
  15379. There was an alias named PlatformCursorHandle for PlatformCursor
  15380. in the internal version of Cursor.h. But it's not necessary so it's
  15381. not included in the upstreaming version of Cursor.h. As a result,
  15382. use PlatformCursor directly.
  15383. * Api/WebPage.cpp:
  15384. (BlackBerry::WebKit::WebPagePrivate::setCursor):
  15385. * Api/WebPage_p.h:
  15386. (WebPagePrivate):
  15387. 2012-03-13 Mike Fenton <mifenton@rim.com>
  15388. [BlackBerry] Input focus state should unfocus the frame selection instead of the field.
  15389. https://bugs.webkit.org/show_bug.cgi?id=81023
  15390. Reviewed by Antonio Gomes.
  15391. PR 137400.
  15392. Prevent cursor drawing by unfocusing the frame selection
  15393. when input mode is not ready.
  15394. Greatly simplify the decision to focus input fields by removing
  15395. all ties to the page load state and base it on input. Input mode
  15396. is disabled when a page load begins and enabled on any user input.
  15397. The field is focused and ready for input immediately, only the
  15398. frame selection (or cursor) is unfocused.
  15399. Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.
  15400. * Api/WebPage.cpp:
  15401. (BlackBerry::WebKit::WebPagePrivate::setLoadState):
  15402. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  15403. * Api/WebPageClient.h:
  15404. * WebCoreSupport/EditorClientBlackBerry.cpp:
  15405. (WebCore::EditorClientBlackBerry::shouldBeginEditing):
  15406. * WebKitSupport/InputHandler.cpp:
  15407. (BlackBerry::WebKit::InputHandler::InputHandler):
  15408. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  15409. (BlackBerry::WebKit::InputHandler::enableInputMode):
  15410. (BlackBerry::WebKit::InputHandler::setElementFocused):
  15411. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  15412. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  15413. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  15414. (BlackBerry::WebKit::InputHandler::setComposingText):
  15415. * WebKitSupport/InputHandler.h:
  15416. (InputHandler):
  15417. * WebKitSupport/TouchEventHandler.cpp:
  15418. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  15419. 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
  15420. Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
  15421. https://bugs.webkit.org/show_bug.cgi?id=78853
  15422. Reviewed by Adam Barth.
  15423. * Api/WebPage.cpp:
  15424. (BlackBerry::WebKit::WebPagePrivate::init):
  15425. * WebCoreSupport/AboutDataEnableFeatures.in:
  15426. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15427. * WebCoreSupport/ChromeClientBlackBerry.h:
  15428. (ChromeClientBlackBerry):
  15429. * WebKitSupport/DumpRenderTreeSupport.cpp:
  15430. (toGeolocationClientMock):
  15431. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  15432. (DumpRenderTreeSupport::resetGeolocationMock):
  15433. (DumpRenderTreeSupport::setMockGeolocationError):
  15434. (DumpRenderTreeSupport::setMockGeolocationPermission):
  15435. (DumpRenderTreeSupport::setMockGeolocationPosition):
  15436. 2012-03-13 Mike Lattanzio <mlattanzio@rim.com>
  15437. Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
  15438. https://bugs.webkit.org/show_bug.cgi?id=80984
  15439. Remove ActiveNodeContext, and switch the implementation to
  15440. provide a BlackBerry::Platform::WebContext. The new object
  15441. adds an explicit IsImage flag, as well as IsAudio and IsVideo
  15442. for the HTML5 elements.
  15443. Note that for many videos both IsVideo and IsAudio will be true,
  15444. as videos typically have audio streams as well.
  15445. Reviewed by George Staikos.
  15446. * Api/ActiveNodeContext.h: Removed.
  15447. * Api/WebPage.cpp:
  15448. (BlackBerry::WebKit::WebPagePrivate::webContext):
  15449. (BlackBerry::WebKit::WebPage::webContext):
  15450. * Api/WebPage.h:
  15451. * Api/WebPage_p.h:
  15452. 2012-03-12 Andy Chen <andchen@rim.com>
  15453. [Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
  15454. https://bugs.webkit.org/show_bug.cgi?id=80831
  15455. Reviewed by Antonio Gomes.
  15456. * WebKitSupport/InPageSearchManager.cpp:
  15457. (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
  15458. (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
  15459. (BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
  15460. (BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
  15461. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  15462. (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
  15463. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  15464. (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
  15465. (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
  15466. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
  15467. (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
  15468. (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
  15469. (BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
  15470. * WebKitSupport/InPageSearchManager.h:
  15471. 2012-03-09 Jon Lee <jonlee@apple.com>
  15472. Rename NotificationPresenter to NotificationClient
  15473. https://bugs.webkit.org/show_bug.cgi?id=80488
  15474. <rdar://problem/10965558>
  15475. Reviewed by Kentaro Hara.
  15476. Refactor to use renamed WebCore::NotificationClient.
  15477. * WebCoreSupport/NotificationPresenterImpl.cpp:
  15478. (WebCore::NotificationPresenterImpl::instance):
  15479. (WebCore::NotificationPresenterImpl::show):
  15480. (WebCore::NotificationPresenterImpl::checkPermission):
  15481. * WebCoreSupport/NotificationPresenterImpl.h:
  15482. (NotificationPresenterImpl):
  15483. 2012-03-09 Charles Wei <charles.wei@torchmobile.com.cn>
  15484. [BlackBerry] Web Notification not working after rebase
  15485. https://bugs.webkit.org/show_bug.cgi?id=80690
  15486. Reviewed by George Staikos.
  15487. 1. NotificationPresenterImpl should be in namespace WebCore
  15488. 2. Need to connect NotificationPresenterImpl to webcore the new way:
  15489. WebCore::provideNotification(Page*, NotificationPresenter*)
  15490. 3. Remove the old way of connecting the Notification:
  15491. ChromeClientBlackBerry::notificationPresenter()
  15492. * Api/WebPage.cpp:
  15493. (BlackBerry::WebKit::WebPagePrivate::init):
  15494. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15495. (WebCore):
  15496. * WebCoreSupport/ChromeClientBlackBerry.h:
  15497. (ChromeClientBlackBerry):
  15498. * WebCoreSupport/NotificationPresenterImpl.cpp:
  15499. * WebCoreSupport/NotificationPresenterImpl.h:
  15500. 2012-03-08 Mike Fenton <mifenton@rim.com>
  15501. [BlackBerry] Always use the current focused node when processing focus changes
  15502. https://bugs.webkit.org/show_bug.cgi?id=80594
  15503. Reviewed by Antonio Gomes.
  15504. Guard against toRange or fromRange being null when called
  15505. as part of a clear event.
  15506. * WebCoreSupport/EditorClientBlackBerry.cpp:
  15507. (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
  15508. 2012-03-08 Yong Li <yoli@rim.com>
  15509. [BlackBerry] Block file-to-file access by default
  15510. https://bugs.webkit.org/show_bug.cgi?id=80605
  15511. Reviewed by Rob Buis.
  15512. Turn off allowFileAccessFromFileURLs() by default.
  15513. * Api/WebPage.cpp:
  15514. (BlackBerry::WebKit::WebPagePrivate::init):
  15515. 2012-03-08 Mike Fenton <mifenton@rim.com>
  15516. [BlackBerry] Always use the current focused node when processing focus changes
  15517. https://bugs.webkit.org/show_bug.cgi?id=80594
  15518. Reviewed by Antonio Gomes.
  15519. Update InputHandler focused node handling to strictly use
  15520. the currently focused node. This prevents a handling loop
  15521. when JS is modifying the focus and we get a late notification
  15522. of a past change from ChromeClientBlackBerry with the previously
  15523. unfocused node.
  15524. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15525. (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
  15526. * WebCoreSupport/EditorClientBlackBerry.cpp:
  15527. (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
  15528. (WebCore::EditorClientBlackBerry::setInputMethodState):
  15529. * WebKitSupport/InputHandler.cpp:
  15530. (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
  15531. * WebKitSupport/InputHandler.h:
  15532. 2012-03-07 Jacky Jiang <zhajiang@rim.com>
  15533. [BlackBerry] WebKit rendering problem when show/hide VKB
  15534. https://bugs.webkit.org/show_bug.cgi?id=80448
  15535. RIM PR: 141727
  15536. Reviewed by Antonio Gomes.
  15537. When setting viewport size, layout happens inside
  15538. WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
  15539. outside of the code path of "needsLayout" so that the contents are
  15540. not rendered into the backing store. This is a regression of r108718,
  15541. switch back to do the layout inside the public API
  15542. WebPage::setDefaultLayoutSize().
  15543. We haven't upstreamed the manual tests directory yet, therefore,
  15544. the new manual test case will be upstreamed later.
  15545. * Api/WebPage.cpp:
  15546. (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
  15547. (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
  15548. 2012-03-06 Lianghui Chen <liachen@rim.com>
  15549. [BlackBerry] Set correct ResourceRequest target type.
  15550. https://bugs.webkit.org/show_bug.cgi?id=80430
  15551. Reviewed by Rob Buis.
  15552. Removed unused code in dispatchWillSendRequest(). These codes are too
  15553. late as the target type has already been referred to when calling
  15554. ResourceRequest::initializePlatformRequest().
  15555. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15556. (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
  15557. 2012-03-06 Lianghui Chen <liachen@rim.com>
  15558. [BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
  15559. https://bugs.webkit.org/show_bug.cgi?id=80438
  15560. Reviewed by Antonio Gomes.
  15561. * Api/WebPageClient.h:
  15562. 2012-03-06 Jakob Petsovits <jpetsovits@rim.com>
  15563. [BlackBerry] Don't suspend accel comp when backgrounding a page.
  15564. https://bugs.webkit.org/show_bug.cgi?id=80369
  15565. RIM PR: 137609
  15566. Reviewed by Adam Treat.
  15567. Just because the page is in the background doesn't mean
  15568. it's invisible, doesn't mean it won't have to be redrawn
  15569. at some point - on rotation, for instance.
  15570. We still suspend accelerated compositing on setVisible(false).
  15571. * Api/WebPage.cpp:
  15572. (BlackBerry::WebKit::WebPage::notifyPageBackground):
  15573. (BlackBerry::WebKit::WebPage::notifyPageForeground):
  15574. 2012-03-06 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  15575. [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
  15576. https://bugs.webkit.org/show_bug.cgi?id=80377
  15577. Reviewed by Rob Buis.
  15578. As some of the function names changed in class MediaPlayerPrivate
  15579. with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we
  15580. should update WebKit/blackberry/Api/WebPage.cpp which uses these
  15581. functions accordingly.
  15582. Renamed functions in class MediaPlayerPrivate:
  15583. windowGet() -> getWindow()
  15584. windowPositionGet() -> getWindowPosition()
  15585. mmrContextNameGet() -> mmrContextName()
  15586. * Api/WebPage.cpp:
  15587. (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
  15588. 2012-03-05 Eli Fidler <efidler@rim.com>
  15589. The minimum font size WebSetting should actually change the LOGICAL font size in WebCore.
  15590. https://bugs.webkit.org/show_bug.cgi?id=80312
  15591. RIM PR: 139874
  15592. Reviewed by George Staikos.
  15593. * Api/WebPage.cpp:
  15594. (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
  15595. 2012-03-05 Jakob Petsovits <jpetsovits@rim.com>
  15596. Make accelerated compositing work again with direct rendering.
  15597. https://bugs.webkit.org/show_bug.cgi?id=80181
  15598. RIM PR: 139110
  15599. Reviewed by Antonio Gomes.
  15600. Internally reviewed by Arvid Nilsson.
  15601. The significant amount of refactoring and optimization work
  15602. that has gone into accelerated compositing missed out on
  15603. some of the code paths that are being used in direct rendering.
  15604. Animations were relying on blitVisibleContents() only (which
  15605. is a no-op in direct rendering mode). There were early returns
  15606. which are suitable to determine whether screen contents need
  15607. to be updated at all; however, when we're already forcing a
  15608. re-render then those checks would cause the composition surface
  15609. not to appear at all, or avoid drawing new animation frames.
  15610. We went through dispatchMessage(), potentially causing
  15611. mismatches between rendered (but not yet posted) back content
  15612. and layers composited on top of it. As we're rendering onto
  15613. the sole target surface (the window) directly and posting
  15614. from the same thread, we have to wait for compositing on the
  15615. UI thread to finish before posting the window.
  15616. In turn, this patch combines both drawSubLayers() and
  15617. blendCompositingSurface() calls into one method, reducing
  15618. the number of messages to the UI thread within
  15619. renderDirectToWindow() to one.
  15620. blendCompositingMessage() in renderDirectToScreen() was called
  15621. with contents coordinates rather than viewport coordinates.
  15622. That caused some of the composited content to be cut off when
  15623. the scroll position wasn't (0, 0).
  15624. We called copyPreviousContentsToBackSurfaceOfWindow() twice for
  15625. one frame, in both renderDirectToWindow() and invalidateWindow().
  15626. Only one of those (the latter one) is necessary.
  15627. * Api/BackingStore.cpp:
  15628. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  15629. (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
  15630. (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
  15631. (WebKit):
  15632. (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
  15633. * Api/BackingStore.h:
  15634. (WebKit):
  15635. * Api/BackingStore_p.h:
  15636. (BackingStorePrivate):
  15637. (BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
  15638. (BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
  15639. * Api/WebPage_p.h:
  15640. (BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
  15641. (WebPagePrivate):
  15642. * WebKitSupport/WebPageCompositor.cpp:
  15643. (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
  15644. (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
  15645. (BlackBerry::WebKit::WebPageCompositor::drawLayers):
  15646. (BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
  15647. * WebKitSupport/WebPageCompositor.h:
  15648. (WebPageCompositor):
  15649. 2012-03-05 George Staikos <gstaikos@rim.com>
  15650. [BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
  15651. https://bugs.webkit.org/show_bug.cgi?id=80274
  15652. Reviewed by Antonio Gomes.
  15653. A null range can be returned so we should not blindly deref it.
  15654. Reviewed Internally by Mike Fenton.
  15655. * WebKitSupport/DOMSupport.cpp:
  15656. (BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):
  15657. 2012-03-04 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  15658. [BlackBerry] upstream CredentialManager and CredentialTransformData implementation
  15659. https://bugs.webkit.org/show_bug.cgi?id=80107
  15660. Reviewed by Antonio Gomes.
  15661. Initial upstream of CredentialManager.[h|cpp] and
  15662. CredentialTransformData.[h|cpp].
  15663. No new test.
  15664. * WebCoreSupport/CredentialManager.cpp: Added.
  15665. (WebCore):
  15666. (WebCore::CredentialManager::CredentialManager):
  15667. (WebCore::CredentialManager::autofillAuthenticationChallenge):
  15668. (WebCore::CredentialManager::autofillPasswordForms):
  15669. (WebCore::CredentialManager::saveCredentialIfConfirmed):
  15670. * WebCoreSupport/CredentialManager.h: Added.
  15671. (WebKit):
  15672. (WebCore):
  15673. (CredentialManager):
  15674. * WebCoreSupport/CredentialTransformData.cpp: Added.
  15675. (WebCore::CredentialTransformData::CredentialTransformData):
  15676. (WebCore):
  15677. (WebCore::CredentialTransformData::url):
  15678. (WebCore::CredentialTransformData::credential):
  15679. (WebCore::CredentialTransformData::setCredential):
  15680. (WebCore::CredentialTransformData::findPasswordFormFields):
  15681. * WebCoreSupport/CredentialTransformData.h: Added.
  15682. (WebCore):
  15683. (CredentialTransformData):
  15684. (WebCore::CredentialTransformData::isValid):
  15685. (WebCore::CredentialTransformData::protectionSpace):
  15686. 2012-03-04 Antonio Gomes <agomes@rim.com>
  15687. [BlackBerry] Fixed positioned element not correctly positioned after orientation change, when viewport metatag is used
  15688. https://bugs.webkit.org/show_bug.cgi?id=80228
  15689. PR #138865
  15690. Reviewed by George Staikos.
  15691. Viewport size changes in two main scenarios:
  15692. - orientation changes;
  15693. - virtual keyboard pop up/hide.
  15694. When we are setting a new viewport size, we need to
  15695. update the FixedReportedSize of the mainframe. This size
  15696. is used to return innerWidth|Heigth as well as to calculate
  15697. the fixed position elements height relative to the RenderView [1].
  15698. [1] RenderBox::containingBlockLogicalHeightForPositioned.
  15699. When we are rotating, we need to delay setting the new FixedReportedSize
  15700. till we layout and are able to figure out the new contents size. At this
  15701. time we call setFixedReportedSize, but we do not reposition the fixed elemts
  15702. afterwards.
  15703. Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
  15704. setting the new size.
  15705. Source/WebKit/blackberry:
  15706. * Api/WebPage.cpp:
  15707. (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
  15708. 2012-03-02 Mike Fenton <mifenton@rim.com>
  15709. [BlackBerry] Expose WebInspector state to client and clean up WebSettings
  15710. https://bugs.webkit.org/show_bug.cgi?id=80177
  15711. Reviewed by Antonio Gomes.
  15712. Expose the Web Inspector state to WebPage client's and
  15713. re-order initialization of WebSettings to be alphabetical
  15714. matching their definitions.
  15715. * Api/WebPage.cpp:
  15716. (BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
  15717. * Api/WebPage.h:
  15718. * Api/WebSettings.cpp:
  15719. (BlackBerry::WebKit::WebSettings::standardSettings):
  15720. 2012-03-02 Arvid Nilsson <anilsson@rim.com>
  15721. Accelerated compositing: Checkerboard never goes away
  15722. https://bugs.webkit.org/show_bug.cgi?id=79020
  15723. RIM PR #134164
  15724. Reviewed by Adam Treat.
  15725. Checkerboard appears in accelerated compositing layers when there's no
  15726. texture for (part of) a layer. The layer renderer queues up some render
  15727. jobs and schedules a commit to make the WebKit thread process those
  15728. jobs. Render jobs performed during commit cause texture upload jobs to
  15729. be scheduled on the UI thread. Texture uploads are performed when next
  15730. drawing the layers.
  15731. Unfortunately, sometimes commit operation happens without a subsequent
  15732. call draw the layers.
  15733. In order to implement one-shot drawing sync, I added a call to
  15734. commitRootLayerIfNeeded() in BackingStore::renderContents(), and
  15735. I was lucky that most of the time, renderContents() is followed by
  15736. blit(Visible)Contents() which in turn draws the layers.
  15737. However, render is not always followed by a blit, for example when
  15738. rendering offscreen tiles in BackingStore::renderOnIdle(), and in
  15739. direct rendering mode.
  15740. Fixed by making sure that every call to commitRootLayerIfNeeded() that
  15741. returns true is followed by a call to drawLayersOnCommit(), unless a
  15742. blit was requested already.
  15743. Also tweak the logic for one-shot drawing sync to make the code in
  15744. drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
  15745. * Api/BackingStore.cpp:
  15746. (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
  15747. (BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
  15748. (BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
  15749. (BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
  15750. (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
  15751. (BlackBerry::WebKit::BackingStorePrivate::render):
  15752. (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
  15753. (BlackBerry::WebKit::BackingStorePrivate::blitContents):
  15754. (BlackBerry::WebKit::BackingStorePrivate::renderContents):
  15755. (WebKit):
  15756. (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
  15757. * Api/BackingStore_p.h:
  15758. (BackingStorePrivate):
  15759. (BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
  15760. 2012-03-02 Adam Treat <atreat@rim.com>
  15761. https://bugs.webkit.org/show_bug.cgi?id=80161
  15762. PR: 141157
  15763. BlackBerryPlatformScreen.h API has been updated. Reflect those
  15764. changes in our usage.
  15765. Reviewed by Antonio Gomes.
  15766. Internally reviewed by Jakob Petsovits.
  15767. * Api/BackingStore.cpp:
  15768. (BlackBerry::WebKit::BackingStorePrivate::tileWidth):
  15769. (BlackBerry::WebKit::BackingStorePrivate::tileHeight):
  15770. * Api/WebPage.cpp:
  15771. (BlackBerry::WebKit::WebPagePrivate::init):
  15772. (BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
  15773. (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
  15774. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  15775. (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
  15776. (BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
  15777. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15778. (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
  15779. * WebKitSupport/SurfacePool.cpp:
  15780. (BlackBerry::WebKit::createCompositingSurface):
  15781. 2012-03-02 Konrad Piascik <kpiascik@rim.com>
  15782. [BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
  15783. https://bugs.webkit.org/show_bug.cgi?id=80160
  15784. Reviewed by Antonio Gomes.
  15785. Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
  15786. Previously when executing window.devicePixelRatio these two pages returned 1 now
  15787. they report the devicePixelRatio returned by computeViewportAttributes.
  15788. * Api/WebPage.cpp:
  15789. (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
  15790. 2012-03-02 Jacky Jiang <zhajiang@rim.com>
  15791. Fix a warning in InputHandler::learnText()
  15792. https://bugs.webkit.org/show_bug.cgi?id=80049
  15793. Reviewed by Antonio Gomes.
  15794. Fix a warning of the comparison "textInField.length() <=
  15795. MaxLearnTextDataSize" in InputHandler::learnText().
  15796. Rubber-stamped internally by Mike Fenton.
  15797. * WebKitSupport/InputHandler.cpp:
  15798. (BlackBerry::WebKit::InputHandler::learnText):
  15799. 2012-03-01 Andy Chen <andchen@rim.com>
  15800. [BlackBerry] Implement features for find-in-page
  15801. https://bugs.webkit.org/show_bug.cgi?id=79820
  15802. Reviewed by Antonio Gomes.
  15803. - Make it be able to search text around the whole page instead of single frame.
  15804. - Make it be able to start new search from active selection and last active match.
  15805. No new tests as this patch doesn't change behavior.
  15806. * Api/WebPage.cpp:
  15807. (BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
  15808. * Api/WebPage_p.h:
  15809. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  15810. (WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
  15811. (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
  15812. * WebKitSupport/DOMSupport.cpp:
  15813. (BlackBerry::WebKit::DOMSupport::incrementFrame):
  15814. * WebKitSupport/DOMSupport.h:
  15815. * WebKitSupport/InPageSearchManager.cpp:
  15816. (BlackBerry::WebKit::InPageSearchManager::findNextString):
  15817. (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
  15818. (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
  15819. (BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
  15820. (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
  15821. * WebKitSupport/InPageSearchManager.h:
  15822. * WebKitSupport/InputHandler.cpp:
  15823. (BlackBerry::WebKit::InputHandler::frameUnloaded):
  15824. * WebKitSupport/InputHandler.h:
  15825. 2012-03-01 Charles Wei <charles.wei@torchmobile.com.cn>
  15826. [BlackBerry] Web Notification crashes the browser.
  15827. https://bugs.webkit.org/show_bug.cgi?id=79897
  15828. Reviewed by Antonio Gomes.
  15829. The reason of the crash is that it still uses the iterator
  15830. after been removed from the container, which invalidates the
  15831. iterator.
  15832. We should stop processing after we have found the element
  15833. and removed from the container through the iterator.
  15834. This patch only fixes the crash issue, but not any notification
  15835. functionality issue, which is tracked seperatly.
  15836. Test case: http://sandbox.gtaero.net/chrome/notifications.php
  15837. * WebCoreSupport/NotificationPresenterImpl.cpp:
  15838. (WebKit::NotificationPresenterImpl::onPermission):
  15839. (WebKit::NotificationPresenterImpl::notificationClicked):
  15840. 2012-03-01 Mike Fenton <mifenton@rim.com>
  15841. Autocomplete attribute should apply to textarea's.
  15842. https://bugs.webkit.org/show_bug.cgi?id=79929
  15843. Reviewed by Antonio Gomes.
  15844. Add local static Qualified name for autocorrect attribute.
  15845. * WebKitSupport/DOMSupport.cpp:
  15846. (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
  15847. 2012-02-29 Mike Fenton <mifenton@rim.com>
  15848. Autocomplete attribute should apply to textarea's.
  15849. https://bugs.webkit.org/show_bug.cgi?id=79929
  15850. Reviewed by Antonio Gomes.
  15851. Allow the autocomplete attribute to bubble back to the form setting.
  15852. Expand support to include checking autocorrect, autocomplete and
  15853. name/id matching to text areas.
  15854. Reviewed internally by Nima Ghanavatian and Gen Mak.
  15855. * WebKitSupport/DOMSupport.cpp:
  15856. (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
  15857. (BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
  15858. (BlackBerry::WebKit::DOMSupport::elementAttributeState):
  15859. * WebKitSupport/DOMSupport.h:
  15860. * WebKitSupport/InputHandler.cpp:
  15861. (BlackBerry::WebKit::inputStyle):
  15862. 2012-02-29 Max Feil <mfeil@rim.com>
  15863. [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
  15864. https://bugs.webkit.org/show_bug.cgi?id=79519
  15865. Reviewed by Antonio Gomes.
  15866. * Api/WebSettings.cpp:
  15867. (BlackBerry::WebKit::mimeTypeAssociationMap):
  15868. 2012-02-28 Konrad Piascik <kpiascik@rim.com>
  15869. [BlackBerry] Change the API to use std::string
  15870. https://bugs.webkit.org/show_bug.cgi?id=79818
  15871. Reviewed by Antonio Gomes.
  15872. * Api/WebPage.cpp:
  15873. (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
  15874. * Api/WebPage.h:
  15875. 2012-02-28 Jacky Jiang <zhajiang@rim.com>
  15876. [BlackBerry] x86 build fix after cleaning up WebPage.cpp
  15877. https://bugs.webkit.org/show_bug.cgi?id=79814
  15878. Reviewed by Antonio Gomes.
  15879. x86 build fix, keep WebPage::destroyWebPageCompositor() method where it
  15880. was which was outside of USE(ACCELERATED_COMPOSITING).
  15881. * Api/WebPage.cpp:
  15882. (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
  15883. (WebKit):
  15884. 2012-02-28 Mike Fenton <mifenton@rim.com>
  15885. [BlackBerry] Remove unused focusedNodeChange notifications from the Chrome client.
  15886. https://bugs.webkit.org/show_bug.cgi?id=79794
  15887. Reviewed by Rob Buis.
  15888. Remove unused notification for focusedNodeChanged.
  15889. Internally reviewed by Gen Mak.
  15890. * Api/WebPageClient.h:
  15891. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  15892. (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
  15893. 2012-02-27 Jacky Jiang <zhajiang@rim.com>
  15894. [BlackBerry] Upstream BlackBerry API web page related files
  15895. https://bugs.webkit.org/show_bug.cgi?id=74380
  15896. Reviewed by Antonio Gomes.
  15897. Clean up WebPage.{h, cpp} and WebPage_p.h.
  15898. - Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in
  15899. the public API, adapt to the change by adding a new method
  15900. WebPagePrivate::core(Const WebPage*) and expose it to
  15901. DumpRenderTreeSupport.
  15902. - Rename WebPage::spellCheckingEnabled to
  15903. WebPage::setSpellCheckingEnabled.
  15904. - Remove unused WebPage::focusNodeRect().
  15905. - Remove extra blank lines.
  15906. - Put WebPage methods and their associated WebPagePrivate methods
  15907. together.
  15908. No new tests as this patch doesn't change behavior.
  15909. * Api/WebPage.cpp:
  15910. (BlackBerry::WebKit::WebPage::WebPage):
  15911. (WebKit):
  15912. (BlackBerry::WebKit::WebPage::~WebPage):
  15913. (BlackBerry::WebKit::WebPagePrivate::core):
  15914. (BlackBerry::WebKit::WebPage::load):
  15915. (BlackBerry::WebKit::WebPage::loadExtended):
  15916. (BlackBerry::WebKit::WebPage::loadFile):
  15917. (BlackBerry::WebKit::WebPage::download):
  15918. (BlackBerry::WebKit::WebPage::loadString):
  15919. (BlackBerry::WebKit::WebPage::executeJavaScript):
  15920. (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
  15921. (BlackBerry::WebKit::WebPage::stopLoading):
  15922. (BlackBerry::WebKit::WebPage::prepareToDestroy):
  15923. (BlackBerry::WebKit::WebPage::setScrollPosition):
  15924. (BlackBerry::WebKit::WebPage::scrollBy):
  15925. (BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
  15926. (BlackBerry::WebKit::WebPage::zoomToFitScale):
  15927. (BlackBerry::WebKit::WebPage::initialScale):
  15928. (BlackBerry::WebKit::WebPage::maximumScale):
  15929. (BlackBerry::WebKit::WebPage::scrollPosition):
  15930. (BlackBerry::WebKit::WebPage::viewportSize):
  15931. (BlackBerry::WebKit::WebPage::activeNodeContext):
  15932. (BlackBerry::WebKit::WebPage::assignFocus):
  15933. (BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
  15934. (BlackBerry::WebKit::WebPage::onInputLocaleChanged):
  15935. (BlackBerry::WebKit::WebPage::setScreenOrientation):
  15936. (BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
  15937. (BlackBerry::WebKit::WebPage::setViewportSize):
  15938. (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
  15939. (BlackBerry::WebKit::WebPage::setScrollOriginPoint):
  15940. (BlackBerry::WebKit::WebPage::textEncoding):
  15941. (BlackBerry::WebKit::WebPage::forcedTextEncoding):
  15942. (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
  15943. (BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
  15944. (BlackBerry::WebKit::parentLayer):
  15945. (BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
  15946. (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
  15947. * Api/WebPage.h:
  15948. (WebCore):
  15949. (WebKit):
  15950. * Api/WebPage_p.h:
  15951. (WebCore):
  15952. (WebKit):
  15953. * WebKitSupport/DumpRenderTreeSupport.cpp:
  15954. (DumpRenderTreeSupport::corePage):
  15955. (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
  15956. (DumpRenderTreeSupport::resetGeolocationMock):
  15957. (DumpRenderTreeSupport::setMockGeolocationError):
  15958. (DumpRenderTreeSupport::setMockGeolocationPermission):
  15959. (DumpRenderTreeSupport::setMockGeolocationPosition):
  15960. (DumpRenderTreeSupport::scalePageBy):
  15961. * WebKitSupport/DumpRenderTreeSupport.h:
  15962. (WebCore):
  15963. (DumpRenderTreeSupport):
  15964. 2012-02-27 Mike Fenton <mifenton@rim.com>
  15965. [BlackBerry] Selection handling should be entirely directional
  15966. https://bugs.webkit.org/show_bug.cgi?id=79692
  15967. Reviewed by Antonio Gomes.
  15968. Make all VisibleSelections directional.
  15969. * WebKitSupport/SelectionHandler.cpp:
  15970. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  15971. (BlackBerry::WebKit::SelectionHandler::setSelection):
  15972. 2012-02-27 Ed Baker <edbaker@rim.com>
  15973. [BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
  15974. https://bugs.webkit.org/show_bug.cgi?id=78608
  15975. Ensure that when selection handles leave the content bounding box that
  15976. the handle not being dragged remains fixed. Do not apply padding to a
  15977. direction that would cause the selection to shrink when performing the
  15978. handle direction detection.
  15979. Reviewed by Antonio Gomes.
  15980. * WebKitSupport/DOMSupport.cpp:
  15981. (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
  15982. * WebKitSupport/DOMSupport.h:
  15983. * WebKitSupport/SelectionHandler.cpp:
  15984. (BlackBerry::WebKit::clamp):
  15985. (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
  15986. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  15987. (BlackBerry::WebKit::SelectionHandler::setSelection):
  15988. (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
  15989. * WebKitSupport/SelectionHandler.h:
  15990. 2012-02-27 Leo Yang <leo.yang@torchmobile.com.cn>
  15991. [BlackBerry] Upstream accelerated compositing helper class
  15992. https://bugs.webkit.org/show_bug.cgi?id=78448
  15993. Reviewed by Antonio Gomes.
  15994. Initial upstream, no new tests.
  15995. * WebKitSupport/FrameLayers.cpp: Added.
  15996. * WebKitSupport/FrameLayers.h: Added.
  15997. 2012-02-26 Hajime Morrita <morrita@chromium.org>
  15998. Move ChromeClient::showContextMenu() to ContextMenuClient
  15999. https://bugs.webkit.org/show_bug.cgi?id=79427
  16000. Reviewed by Adam Barth.
  16001. * WebCoreSupport/ChromeClientBlackBerry.h:
  16002. (ChromeClientBlackBerry):
  16003. 2012-02-24 Mike Fenton <mifenton@rim.com>
  16004. [BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
  16005. https://bugs.webkit.org/show_bug.cgi?id=79393
  16006. Reviewed by Antonio Gomes.
  16007. Cleanup usage of BlackBerry::Platform in InputHandler.
  16008. * WebKitSupport/InputHandler.cpp:
  16009. (BlackBerry::WebKit::convertStringToWchar):
  16010. (BlackBerry::WebKit::convertStringToWcharVector):
  16011. (BlackBerry::WebKit::convertSpannableStringToString):
  16012. (BlackBerry::WebKit::InputHandler::learnText):
  16013. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  16014. (BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
  16015. (BlackBerry::WebKit::InputHandler::setElementFocused):
  16016. (BlackBerry::WebKit::InputHandler::nodeTextChanged):
  16017. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  16018. (BlackBerry::WebKit::InputHandler::frameUnloaded):
  16019. (BlackBerry::WebKit::InputHandler::selectionChanged):
  16020. (BlackBerry::WebKit::InputHandler::setSelection):
  16021. (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
  16022. (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
  16023. (BlackBerry::WebKit::InputHandler::deleteText):
  16024. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  16025. (BlackBerry::WebKit::InputHandler::setComposingRegion):
  16026. (BlackBerry::WebKit::InputHandler::finishComposition):
  16027. (BlackBerry::WebKit::InputHandler::setText):
  16028. (BlackBerry::WebKit::InputHandler::setTextAttributes):
  16029. (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
  16030. (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
  16031. (BlackBerry::WebKit::InputHandler::setComposingText):
  16032. (BlackBerry::WebKit::InputHandler::commitText):
  16033. 2012-02-24 Mike Fenton <mifenton@rim.com>
  16034. [BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
  16035. https://bugs.webkit.org/show_bug.cgi?id=79391
  16036. Reviewed by Antonio Gomes.
  16037. Clean up usage of BlackBerry::Platform in SelectionHandler and
  16038. explicitly define what namespace to use for ambiguous objects like
  16039. IntRect and IntPoint.
  16040. * WebKitSupport/SelectionHandler.cpp:
  16041. (BlackBerry::WebKit::SelectionHandler::cancelSelection):
  16042. (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
  16043. (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
  16044. (BlackBerry::WebKit::directionOfPointRelativeToRect):
  16045. (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
  16046. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  16047. (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
  16048. (BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
  16049. (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
  16050. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  16051. (BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
  16052. (BlackBerry::WebKit::SelectionHandler::setSelection):
  16053. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  16054. (BlackBerry::WebKit::SelectionHandler::selectObject):
  16055. (BlackBerry::WebKit::comparePointsToReferencePoint):
  16056. (BlackBerry::WebKit::minXMinYCorner):
  16057. (BlackBerry::WebKit::maxXMinYCorner):
  16058. (BlackBerry::WebKit::minXMaxYCorner):
  16059. (BlackBerry::WebKit::maxXMaxYCorner):
  16060. (BlackBerry::WebKit::caretLocationForRect):
  16061. (BlackBerry::WebKit::caretComparisonPointForRect):
  16062. (BlackBerry::WebKit::adjustCaretRects):
  16063. (BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
  16064. (BlackBerry::WebKit::referencePoint):
  16065. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  16066. (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
  16067. (BlackBerry::WebKit::SelectionHandler::selectionContains):
  16068. 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
  16069. SpellCheckRequest needs to know the context where the spellcheck happened.
  16070. https://bugs.webkit.org/show_bug.cgi?id=79320
  16071. Reviewed by Hajime Morita.
  16072. * WebCoreSupport/EditorClientBlackBerry.cpp:
  16073. (WebCore::EditorClientBlackBerry::requestCheckingOfString):
  16074. * WebCoreSupport/EditorClientBlackBerry.h:
  16075. (EditorClientBlackBerry):
  16076. 2012-02-24 Charles Wei <charles.wei@torchmobile.com.cn>
  16077. [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
  16078. https://bugs.webkit.org/show_bug.cgi?id=79318
  16079. Need to give the client a chance to decide how to handle the new window request.
  16080. Reviewed by Rob Buis.
  16081. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  16082. (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
  16083. 2012-02-23 Mike Fenton <mifenton@rim.com>
  16084. [BlackBerry] Selection handler has compile failure with logs enabled.
  16085. https://bugs.webkit.org/show_bug.cgi?id=79392
  16086. Reviewed by Antonio Gomes.
  16087. Build Fix. Update log to avoid usage of toString which was removed.
  16088. * WebKitSupport/SelectionHandler.cpp:
  16089. (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
  16090. 2012-02-19 Antonio Gomes <agomes@rim.com>
  16091. Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
  16092. https://bugs.webkit.org/show_bug.cgi?id=79256
  16093. PR #127814 / MKS_2587410
  16094. Reviewed by Rob Buis.
  16095. Patch adds a cleaner way for call sites of FatFingersResult to
  16096. query for the appropriated target node: shadow or non-shadow DOM nodes.
  16097. It also renames FatFingersResults::validNode to ::node, assuming
  16098. that "invalid" nodes are not applicable in any context.
  16099. * Api/WebPage.cpp:
  16100. (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
  16101. (BlackBerry::WebKit::WebPagePrivate::contextNode):
  16102. (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  16103. * WebKitSupport/FatFingers.h:
  16104. (FatFingersResult):
  16105. (BlackBerry::WebKit::FatFingersResult::node):
  16106. (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
  16107. * WebKitSupport/SelectionHandler.cpp:
  16108. (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  16109. * WebKitSupport/TouchEventHandler.cpp:
  16110. (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
  16111. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  16112. 2012-02-23 Jacky Jiang <zhajiang@rim.com>
  16113. [BlackBerry] Upstream BlackBerry API web page related files
  16114. https://bugs.webkit.org/show_bug.cgi?id=74380
  16115. Reviewed by Antonio Gomes.
  16116. Initial upstream, no new tests.
  16117. * Api/WebPage.cpp: Added.
  16118. * Api/WebPage.h: Added.
  16119. * Api/WebPage_p.h: Added.
  16120. 2012-02-23 Leo Yang <leo.yang@torchmobile.com.cn>
  16121. [BlackBerry] Remove unused ChromeClientBlackBerry::platformCompositingWindow(), platformWindow() and WebPageClient::compositingWindow()
  16122. https://bugs.webkit.org/show_bug.cgi?id=78681
  16123. Reviewed by Antonio Gomes.
  16124. * Api/WebPageClient.h:
  16125. * WebCoreSupport/ChromeClientBlackBerry.cpp:
  16126. (WebCore):
  16127. * WebCoreSupport/ChromeClientBlackBerry.h:
  16128. (ChromeClientBlackBerry):
  16129. 2012-02-23 Leo Yang <leo.yang@torchmobile.com.cn>
  16130. [BlackBerry] Upstream GLES2Context.{h, cpp}
  16131. https://bugs.webkit.org/show_bug.cgi?id=79196
  16132. Reviewed by Rob Buis.
  16133. Initial upstream, no new tests.
  16134. * WebKitSupport/GLES2Context.cpp: Added.
  16135. * WebKitSupport/GLES2Context.h: Added.
  16136. 2012-02-23 Mike Fenton <mifenton@rim.com>
  16137. [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
  16138. https://bugs.webkit.org/show_bug.cgi?id=79366
  16139. Reviewed by Rob Buis.
  16140. Cleanup InputHandler navigation based code.
  16141. 1) Remove the concept of NavigationMode and replace it
  16142. with simple showKeyboard calls.
  16143. 2) Remove navigation move events and replace with standard
  16144. key events.
  16145. 3) Standardize function/variable names and remove obsolete
  16146. functions.
  16147. * Api/WebPageClient.h:
  16148. * WebKitSupport/InputHandler.cpp:
  16149. (BlackBerry::WebKit::InputHandler::InputHandler):
  16150. (BlackBerry::WebKit::InputHandler::nodeFocused):
  16151. (BlackBerry::WebKit::InputHandler::setElementUnfocused):
  16152. (BlackBerry::WebKit::InputHandler::setElementFocused):
  16153. (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
  16154. (BlackBerry::WebKit::InputHandler::setDelayKeyboardVisibilityChange):
  16155. (BlackBerry::WebKit::InputHandler::processPendingKeyboardVisibilityChange):
  16156. (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
  16157. * WebKitSupport/InputHandler.h:
  16158. (InputHandler):
  16159. * WebKitSupport/SelectionHandler.cpp:
  16160. (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
  16161. (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
  16162. * WebKitSupport/TouchEventHandler.cpp:
  16163. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  16164. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  16165. 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
  16166. Remove the remaining uses of CSSStyleDeclaration in Editor
  16167. https://bugs.webkit.org/show_bug.cgi?id=78939
  16168. Reviewed by Enrica Casucci.
  16169. * WebCoreSupport/EditorClientBlackBerry.cpp:
  16170. (WebCore::EditorClientBlackBerry::shouldApplyStyle):
  16171. * WebCoreSupport/EditorClientBlackBerry.h:
  16172. (EditorClientBlackBerry):
  16173. 2012-02-22 Mike Fenton <mifenton@rim.com>
  16174. [BlackBerry] InputHandler has signed vs unsigned comparison.
  16175. https://bugs.webkit.org/show_bug.cgi?id=79261
  16176. Fix warning by casting the unsigned int to an int.
  16177. Reviewed by Rob Buis.
  16178. * WebKitSupport/InputHandler.cpp:
  16179. (BlackBerry::WebKit::InputHandler::rectForCaret):
  16180. 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
  16181. Remove the remaining uses of CSSStyleDeclaration in Editor
  16182. https://bugs.webkit.org/show_bug.cgi?id=78939
  16183. Reviewed by Enrica Casucci.
  16184. * WebCoreSupport/EditorClientBlackBerry.cpp:
  16185. (WebCore::EditorClientBlackBerry::shouldApplyStyle):
  16186. * WebCoreSupport/EditorClientBlackBerry.h:
  16187. (EditorClientBlackBerry):
  16188. 2012-02-18 Antonio Gomes <agomes@rim.com>
  16189. Fat fingers - cache the first rect-based hit test so we do not need to do it again
  16190. https://bugs.webkit.org/show_bug.cgi?id=79115
  16191. Reviewed by Adam Treat.
  16192. Our FatFingers implementation runs currently in two phases:
  16193. the first checks for the elements intrinsically clickable;
  16194. the second checks for elements made clickable by the page
  16195. (for example, a div with a onclick event listener attached to it).
  16196. For each phase, we perform a rect hittest, which is not needed since
  16197. the result of each is the same.
  16198. Patch introduces a caching mechanism so we avoid on rect hittest:
  16199. when the first phase runs, it caches each nodeset per document in
  16200. a hashmap. This second phase works with the cached results.
  16201. No behavioral change, but performance is better since we
  16202. avoid one (possibly expensive) rect hittest.
  16203. I measured the performance gain on https://www.kvd.se/, and we
  16204. save up to 0.04 seconds, by caching and re-using the results.
  16205. * WebKitSupport/FatFingers.cpp:
  16206. (BlackBerry::WebKit::dumpHitTestResult):
  16207. (BlackBerry::WebKit::FatFingers::findBestPoint):
  16208. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  16209. (BlackBerry::WebKit::FatFingers::cachingStrategy):
  16210. (WebKit):
  16211. (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  16212. * WebKitSupport/FatFingers.h:
  16213. 2012-02-20 Antonio Gomes <agomes@rim.com>
  16214. All default video/audio control elements should be rect-hit testable (Part II)
  16215. PR #139518 / MKS_3005538
  16216. Reviewed by George Staikos.
  16217. Add HTMLInputElement::isMediaControlElement as a criteria
  16218. to consider a element as clickable.
  16219. Note that is should be only used while in the "ClickableByDefault"
  16220. phase of FatFingers.
  16221. * WebKitSupport/FatFingers.cpp:
  16222. (BlackBerry::WebKit::FatFingers::isElementClickable):
  16223. 2012-02-16 Antonio Gomes <agomes@rim.com>
  16224. [BlackBerry] Implemented a way to defer client navigation change client notifications
  16225. https://bugs.webkit.org/show_bug.cgi?id=78848
  16226. Reviewed by Rob Buis.
  16227. Currently we postpone touch_down till touch_up if user touches
  16228. the screen and an input field has the WebKit focus. This is done
  16229. so we can scroll the page without hidding the vkb needlessly.
  16230. However, it breaks the conversion of touch to mouse events
  16231. if an input field has the focus in the following scenario:
  16232. an <input type=text> is focused and an user grab and-drag
  16233. a <input type=range> knob/slide. It does not work until the
  16234. user unfocuses the currently focused edit field.
  16235. Patch introduces a way to unfocus a currently focused input field,
  16236. without requesting the client to show or hide the virtual keyboard
  16237. right way. Instead it gets a delayed notification of the vkb mode requested
  16238. at either touch_released/mouse_up or touch_cancel time.
  16239. For now, due to content side issues with major web sites,
  16240. only delay navigation mode notification changes if we are not dealing with
  16241. input modes.
  16242. * WebKitSupport/InputHandler.cpp:
  16243. (BlackBerry::WebKit::InputHandler::InputHandler):
  16244. (BlackBerry::WebKit::InputHandler::nodeFocused):
  16245. (BlackBerry::WebKit::InputHandler::setElementFocused):
  16246. (BlackBerry::WebKit::InputHandler::setNavigationMode):
  16247. (WebKit):
  16248. (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange):
  16249. (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification):
  16250. (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange):
  16251. (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
  16252. (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
  16253. (BlackBerry::WebKit::InputHandler::spannableTextInRange):
  16254. (BlackBerry::WebKit::InputHandler::removeComposedText):
  16255. (BlackBerry::WebKit::InputHandler::firstSpanInString):
  16256. (BlackBerry::WebKit::InputHandler::setText):
  16257. (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
  16258. * WebKitSupport/InputHandler.h:
  16259. (InputHandler):
  16260. 2012-02-16 Antonio Gomes <agomes@rim.com>
  16261. Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
  16262. https://bugs.webkit.org/show_bug.cgi?id=78845
  16263. Reviewed by Rob Buis.
  16264. We were trying to operate on a cached Node when its page/frame/document
  16265. were gone to PageCache already. To avoid such problems, lets clean up
  16266. any document data we have cached when the Frame goes into the cache.
  16267. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
  16268. (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
  16269. (WebCore):
  16270. * WebCoreSupport/FrameLoaderClientBlackBerry.h:
  16271. (FrameLoaderClientBlackBerry):
  16272. 2012-02-16 Antonio Gomes <agomes@rim.com>
  16273. [BlackBerry] Upstream touch handling related classes
  16274. https://bugs.webkit.org/show_bug.cgi?id=78509
  16275. Reviewed by Adam Treat and Rob Buis.
  16276. FatFingers is the class responsible to the whole touch
  16277. accuracy of the BlackBerry port. Initial upstream.
  16278. * WebKitSupport/FatFingers.cpp: Added.
  16279. (WebKit):
  16280. (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
  16281. (BlackBerry::WebKit::hasMousePressListener):
  16282. (BlackBerry::WebKit::FatFingers::isElementClickable):
  16283. (BlackBerry::WebKit::isFieldWithText):
  16284. (BlackBerry::WebKit::distanceBetweenPoints):
  16285. (BlackBerry::WebKit::compareDistanceBetweenPoints):
  16286. (BlackBerry::WebKit::isValidFrameOwner):
  16287. (BlackBerry::WebKit::FatFingers::FatFingers):
  16288. (BlackBerry::WebKit::FatFingers::~FatFingers):
  16289. (BlackBerry::WebKit::FatFingers::findBestPoint):
  16290. (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
  16291. (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
  16292. (BlackBerry::WebKit::FatFingers::checkForClickableElement):
  16293. (BlackBerry::WebKit::FatFingers::checkForText):
  16294. (BlackBerry::WebKit::FatFingers::getPaddings):
  16295. (BlackBerry::WebKit::FatFingers::nodesFromRect):
  16296. (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
  16297. (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
  16298. * WebKitSupport/FatFingers.h: Added.
  16299. (WebCore):
  16300. (WebKit):
  16301. (FatFingersResult):
  16302. (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
  16303. (BlackBerry::WebKit::FatFingersResult::reset):
  16304. (BlackBerry::WebKit::FatFingersResult::originPosition):
  16305. (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
  16306. (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
  16307. (BlackBerry::WebKit::FatFingersResult::isTextInput):
  16308. (BlackBerry::WebKit::FatFingersResult::isValid):
  16309. (BlackBerry::WebKit::FatFingersResult::validNode):
  16310. (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
  16311. (FatFingers):
  16312. 2012-02-16 Antonio Gomes <agomes@rim.com>
  16313. [BlackBerry] Upstream touch handling related classes
  16314. https://bugs.webkit.org/show_bug.cgi?id=78509
  16315. Reviewed by Adam Treat.
  16316. Initial upstream of the Blackberry specific single touch event
  16317. handler class.
  16318. * blackberry/WebKitSupport/TouchEventHandler.cpp: Added.
  16319. (WebKit):
  16320. (BlackBerry::WebKit::hasMouseMoveListener):
  16321. (BlackBerry::WebKit::hasTouchListener):
  16322. (BlackBerry::WebKit::elementExpectsMouseEvents):
  16323. (BlackBerry::WebKit::shouldConvertTouchToMouse):
  16324. (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
  16325. (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler):
  16326. (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown):
  16327. [BlackBerry] Upstream touch handling related classes
  16328. https://bugs.webkit.org/show_bug.cgi?id=78509
  16329. Reviewed by Rob Buis.
  16330. InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
  16331. working as a read-only wrapper object for a scrollable areas in the page.
  16332. It is used in our client side to control in-region scrolling (scrollable boxes,
  16333. inner frames, etc).
  16334. Initial upstream.
  16335. * WebKitSupport/InRegionScrollableArea.cpp: Added.
  16336. (WebKit):
  16337. (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
  16338. (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition):
  16339. (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition):
  16340. (BlackBerry::WebKit::InRegionScrollableArea::layer):
  16341. (BlackBerry):
  16342. * WebKitSupport/InRegionScrollableArea.h: Added.
  16343. (WebCore):
  16344. (WebKit):
  16345. (InRegionScrollableArea):
  16346. 2012-02-16 Antonio Gomes <agomes@rim.com>
  16347. (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
  16348. (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
  16349. (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
  16350. (BlackBerry::WebKit::TouchEventHandler::spellCheck):
  16351. (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
  16352. (BlackBerry::WebKit::elementForTapHighlight):
  16353. (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  16354. * blackberry/WebKitSupport/TouchEventHandler.h: Added.
  16355. (WebCore):
  16356. (WebKit):
  16357. (TouchEventHandler):
  16358. (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult):
  16359. (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):