ChangeLog-2011-06-04 3.6 MB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787578857895790579157925793579457955796579757985799580058015802580358045805580658075808580958105811581258135814581558165817581858195820582158225823582458255826582758285829583058315832583358345835583658375838583958405841584258435844584558465847584858495850585158525853585458555856585758585859586058615862586358645865586658675868586958705871587258735874587558765877587858795880588158825883588458855886588758885889589058915892589358945895589658975898589959005901590259035904590559065907590859095910591159125913591459155916591759185919592059215922592359245925592659275928592959305931593259335934593559365937593859395940594159425943594459455946594759485949595059515952595359545955595659575958595959605961596259635964596559665967596859695970597159725973597459755976597759785979598059815982598359845985598659875988598959905991599259935994599559965997599859996000600160026003600460056006600760086009601060116012601360146015601660176018601960206021602260236024602560266027602860296030603160326033603460356036603760386039604060416042604360446045604660476048604960506051605260536054605560566057605860596060606160626063606460656066606760686069607060716072607360746075607660776078607960806081608260836084608560866087608860896090609160926093609460956096609760986099610061016102610361046105610661076108610961106111611261136114611561166117611861196120612161226123612461256126612761286129613061316132613361346135613661376138613961406141614261436144614561466147614861496150615161526153615461556156615761586159616061616162616361646165616661676168616961706171617261736174617561766177617861796180618161826183618461856186618761886189619061916192619361946195619661976198619962006201620262036204620562066207620862096210621162126213621462156216621762186219622062216222622362246225622662276228622962306231623262336234623562366237623862396240624162426243624462456246624762486249625062516252625362546255625662576258625962606261626262636264626562666267626862696270627162726273627462756276627762786279628062816282628362846285628662876288628962906291629262936294629562966297629862996300630163026303630463056306630763086309631063116312631363146315631663176318631963206321632263236324632563266327632863296330633163326333633463356336633763386339634063416342634363446345634663476348634963506351635263536354635563566357635863596360636163626363636463656366636763686369637063716372637363746375637663776378637963806381638263836384638563866387638863896390639163926393639463956396639763986399640064016402640364046405640664076408640964106411641264136414641564166417641864196420642164226423642464256426642764286429643064316432643364346435643664376438643964406441644264436444644564466447644864496450645164526453645464556456645764586459646064616462646364646465646664676468646964706471647264736474647564766477647864796480648164826483648464856486648764886489649064916492649364946495649664976498649965006501650265036504650565066507650865096510651165126513651465156516651765186519652065216522652365246525652665276528652965306531653265336534653565366537653865396540654165426543654465456546654765486549655065516552655365546555655665576558655965606561656265636564656565666567656865696570657165726573657465756576657765786579658065816582658365846585658665876588658965906591659265936594659565966597659865996600660166026603660466056606660766086609661066116612661366146615661666176618661966206621662266236624662566266627662866296630663166326633663466356636663766386639664066416642664366446645664666476648664966506651665266536654665566566657665866596660666166626663666466656666666766686669667066716672667366746675667666776678667966806681668266836684668566866687668866896690669166926693669466956696669766986699670067016702670367046705670667076708670967106711671267136714671567166717671867196720672167226723672467256726672767286729673067316732673367346735673667376738673967406741674267436744674567466747674867496750675167526753675467556756675767586759676067616762676367646765676667676768676967706771677267736774677567766777677867796780678167826783678467856786678767886789679067916792679367946795679667976798679968006801680268036804680568066807680868096810681168126813681468156816681768186819682068216822682368246825682668276828682968306831683268336834683568366837683868396840684168426843684468456846684768486849685068516852685368546855685668576858685968606861686268636864686568666867686868696870687168726873687468756876687768786879688068816882688368846885688668876888688968906891689268936894689568966897689868996900690169026903690469056906690769086909691069116912691369146915691669176918691969206921692269236924692569266927692869296930693169326933693469356936693769386939694069416942694369446945694669476948694969506951695269536954695569566957695869596960696169626963696469656966696769686969697069716972697369746975697669776978697969806981698269836984698569866987698869896990699169926993699469956996699769986999700070017002700370047005700670077008700970107011701270137014701570167017701870197020702170227023702470257026702770287029703070317032703370347035703670377038703970407041704270437044704570467047704870497050705170527053705470557056705770587059706070617062706370647065706670677068706970707071707270737074707570767077707870797080708170827083708470857086708770887089709070917092709370947095709670977098709971007101710271037104710571067107710871097110711171127113711471157116711771187119712071217122712371247125712671277128712971307131713271337134713571367137713871397140714171427143714471457146714771487149715071517152715371547155715671577158715971607161716271637164716571667167716871697170717171727173717471757176717771787179718071817182718371847185718671877188718971907191719271937194719571967197719871997200720172027203720472057206720772087209721072117212721372147215721672177218721972207221722272237224722572267227722872297230723172327233723472357236723772387239724072417242724372447245724672477248724972507251725272537254725572567257725872597260726172627263726472657266726772687269727072717272727372747275727672777278727972807281728272837284728572867287728872897290729172927293729472957296729772987299730073017302730373047305730673077308730973107311731273137314731573167317731873197320732173227323732473257326732773287329733073317332733373347335733673377338733973407341734273437344734573467347734873497350735173527353735473557356735773587359736073617362736373647365736673677368736973707371737273737374737573767377737873797380738173827383738473857386738773887389739073917392739373947395739673977398739974007401740274037404740574067407740874097410741174127413741474157416741774187419742074217422742374247425742674277428742974307431743274337434743574367437743874397440744174427443744474457446744774487449745074517452745374547455745674577458745974607461746274637464746574667467746874697470747174727473747474757476747774787479748074817482748374847485748674877488748974907491749274937494749574967497749874997500750175027503750475057506750775087509751075117512751375147515751675177518751975207521752275237524752575267527752875297530753175327533753475357536753775387539754075417542754375447545754675477548754975507551755275537554755575567557755875597560756175627563756475657566756775687569757075717572757375747575757675777578757975807581758275837584758575867587758875897590759175927593759475957596759775987599760076017602760376047605760676077608760976107611761276137614761576167617761876197620762176227623762476257626762776287629763076317632763376347635763676377638763976407641764276437644764576467647764876497650765176527653765476557656765776587659766076617662766376647665766676677668766976707671767276737674767576767677767876797680768176827683768476857686768776887689769076917692769376947695769676977698769977007701770277037704770577067707770877097710771177127713771477157716771777187719772077217722772377247725772677277728772977307731773277337734773577367737773877397740774177427743774477457746774777487749775077517752775377547755775677577758775977607761776277637764776577667767776877697770777177727773777477757776777777787779778077817782778377847785778677877788778977907791779277937794779577967797779877997800780178027803780478057806780778087809781078117812781378147815781678177818781978207821782278237824782578267827782878297830783178327833783478357836783778387839784078417842784378447845784678477848784978507851785278537854785578567857785878597860786178627863786478657866786778687869787078717872787378747875787678777878787978807881788278837884788578867887788878897890789178927893789478957896789778987899790079017902790379047905790679077908790979107911791279137914791579167917791879197920792179227923792479257926792779287929793079317932793379347935793679377938793979407941794279437944794579467947794879497950795179527953795479557956795779587959796079617962796379647965796679677968796979707971797279737974797579767977797879797980798179827983798479857986798779887989799079917992799379947995799679977998799980008001800280038004800580068007800880098010801180128013801480158016801780188019802080218022802380248025802680278028802980308031803280338034803580368037803880398040804180428043804480458046804780488049805080518052805380548055805680578058805980608061806280638064806580668067806880698070807180728073807480758076807780788079808080818082808380848085808680878088808980908091809280938094809580968097809880998100810181028103810481058106810781088109811081118112811381148115811681178118811981208121812281238124812581268127812881298130813181328133813481358136813781388139814081418142814381448145814681478148814981508151815281538154815581568157815881598160816181628163816481658166816781688169817081718172817381748175817681778178817981808181818281838184818581868187818881898190819181928193819481958196819781988199820082018202820382048205820682078208820982108211821282138214821582168217821882198220822182228223822482258226822782288229823082318232823382348235823682378238823982408241824282438244824582468247824882498250825182528253825482558256825782588259826082618262826382648265826682678268826982708271827282738274827582768277827882798280828182828283828482858286828782888289829082918292829382948295829682978298829983008301830283038304830583068307830883098310831183128313831483158316831783188319832083218322832383248325832683278328832983308331833283338334833583368337833883398340834183428343834483458346834783488349835083518352835383548355835683578358835983608361836283638364836583668367836883698370837183728373837483758376837783788379838083818382838383848385838683878388838983908391839283938394839583968397839883998400840184028403840484058406840784088409841084118412841384148415841684178418841984208421842284238424842584268427842884298430843184328433843484358436843784388439844084418442844384448445844684478448844984508451845284538454845584568457845884598460846184628463846484658466846784688469847084718472847384748475847684778478847984808481848284838484848584868487848884898490849184928493849484958496849784988499850085018502850385048505850685078508850985108511851285138514851585168517851885198520852185228523852485258526852785288529853085318532853385348535853685378538853985408541854285438544854585468547854885498550855185528553855485558556855785588559856085618562856385648565856685678568856985708571857285738574857585768577857885798580858185828583858485858586858785888589859085918592859385948595859685978598859986008601860286038604860586068607860886098610861186128613861486158616861786188619862086218622862386248625862686278628862986308631863286338634863586368637863886398640864186428643864486458646864786488649865086518652865386548655865686578658865986608661866286638664866586668667866886698670867186728673867486758676867786788679868086818682868386848685868686878688868986908691869286938694869586968697869886998700870187028703870487058706870787088709871087118712871387148715871687178718871987208721872287238724872587268727872887298730873187328733873487358736873787388739874087418742874387448745874687478748874987508751875287538754875587568757875887598760876187628763876487658766876787688769877087718772877387748775877687778778877987808781878287838784878587868787878887898790879187928793879487958796879787988799880088018802880388048805880688078808880988108811881288138814881588168817881888198820882188228823882488258826882788288829883088318832883388348835883688378838883988408841884288438844884588468847884888498850885188528853885488558856885788588859886088618862886388648865886688678868886988708871887288738874887588768877887888798880888188828883888488858886888788888889889088918892889388948895889688978898889989008901890289038904890589068907890889098910891189128913891489158916891789188919892089218922892389248925892689278928892989308931893289338934893589368937893889398940894189428943894489458946894789488949895089518952895389548955895689578958895989608961896289638964896589668967896889698970897189728973897489758976897789788979898089818982898389848985898689878988898989908991899289938994899589968997899889999000900190029003900490059006900790089009901090119012901390149015901690179018901990209021902290239024902590269027902890299030903190329033903490359036903790389039904090419042904390449045904690479048904990509051905290539054905590569057905890599060906190629063906490659066906790689069907090719072907390749075907690779078907990809081908290839084908590869087908890899090909190929093909490959096909790989099910091019102910391049105910691079108910991109111911291139114911591169117911891199120912191229123912491259126912791289129913091319132913391349135913691379138913991409141914291439144914591469147914891499150915191529153915491559156915791589159916091619162916391649165916691679168916991709171917291739174917591769177917891799180918191829183918491859186918791889189919091919192919391949195919691979198919992009201920292039204920592069207920892099210921192129213921492159216921792189219922092219222922392249225922692279228922992309231923292339234923592369237923892399240924192429243924492459246924792489249925092519252925392549255925692579258925992609261926292639264926592669267926892699270927192729273927492759276927792789279928092819282928392849285928692879288928992909291929292939294929592969297929892999300930193029303930493059306930793089309931093119312931393149315931693179318931993209321932293239324932593269327932893299330933193329333933493359336933793389339934093419342934393449345934693479348934993509351935293539354935593569357935893599360936193629363936493659366936793689369937093719372937393749375937693779378937993809381938293839384938593869387938893899390939193929393939493959396939793989399940094019402940394049405940694079408940994109411941294139414941594169417941894199420942194229423942494259426942794289429943094319432943394349435943694379438943994409441944294439444944594469447944894499450945194529453945494559456945794589459946094619462946394649465946694679468946994709471947294739474947594769477947894799480948194829483948494859486948794889489949094919492949394949495949694979498949995009501950295039504950595069507950895099510951195129513951495159516951795189519952095219522952395249525952695279528952995309531953295339534953595369537953895399540954195429543954495459546954795489549955095519552955395549555955695579558955995609561956295639564956595669567956895699570957195729573957495759576957795789579958095819582958395849585958695879588958995909591959295939594959595969597959895999600960196029603960496059606960796089609961096119612961396149615961696179618961996209621962296239624962596269627962896299630963196329633963496359636963796389639964096419642964396449645964696479648964996509651965296539654965596569657965896599660966196629663966496659666966796689669967096719672967396749675967696779678967996809681968296839684968596869687968896899690969196929693969496959696969796989699970097019702970397049705970697079708970997109711971297139714971597169717971897199720972197229723972497259726972797289729973097319732973397349735973697379738973997409741974297439744974597469747974897499750975197529753975497559756975797589759976097619762976397649765976697679768976997709771977297739774977597769777977897799780978197829783978497859786978797889789979097919792979397949795979697979798979998009801980298039804980598069807980898099810981198129813981498159816981798189819982098219822982398249825982698279828982998309831983298339834983598369837983898399840984198429843984498459846984798489849985098519852985398549855985698579858985998609861986298639864986598669867986898699870987198729873987498759876987798789879988098819882988398849885988698879888988998909891989298939894989598969897989898999900990199029903990499059906990799089909991099119912991399149915991699179918991999209921992299239924992599269927992899299930993199329933993499359936993799389939994099419942994399449945994699479948994999509951995299539954995599569957995899599960996199629963996499659966996799689969997099719972997399749975997699779978997999809981998299839984998599869987998899899990999199929993999499959996999799989999100001000110002100031000410005100061000710008100091001010011100121001310014100151001610017100181001910020100211002210023100241002510026100271002810029100301003110032100331003410035100361003710038100391004010041100421004310044100451004610047100481004910050100511005210053100541005510056100571005810059100601006110062100631006410065100661006710068100691007010071100721007310074100751007610077100781007910080100811008210083100841008510086100871008810089100901009110092100931009410095100961009710098100991010010101101021010310104101051010610107101081010910110101111011210113101141011510116101171011810119101201012110122101231012410125101261012710128101291013010131101321013310134101351013610137101381013910140101411014210143101441014510146101471014810149101501015110152101531015410155101561015710158101591016010161101621016310164101651016610167101681016910170101711017210173101741017510176101771017810179101801018110182101831018410185101861018710188101891019010191101921019310194101951019610197101981019910200102011020210203102041020510206102071020810209102101021110212102131021410215102161021710218102191022010221102221022310224102251022610227102281022910230102311023210233102341023510236102371023810239102401024110242102431024410245102461024710248102491025010251102521025310254102551025610257102581025910260102611026210263102641026510266102671026810269102701027110272102731027410275102761027710278102791028010281102821028310284102851028610287102881028910290102911029210293102941029510296102971029810299103001030110302103031030410305103061030710308103091031010311103121031310314103151031610317103181031910320103211032210323103241032510326103271032810329103301033110332103331033410335103361033710338103391034010341103421034310344103451034610347103481034910350103511035210353103541035510356103571035810359103601036110362103631036410365103661036710368103691037010371103721037310374103751037610377103781037910380103811038210383103841038510386103871038810389103901039110392103931039410395103961039710398103991040010401104021040310404104051040610407104081040910410104111041210413104141041510416104171041810419104201042110422104231042410425104261042710428104291043010431104321043310434104351043610437104381043910440104411044210443104441044510446104471044810449104501045110452104531045410455104561045710458104591046010461104621046310464104651046610467104681046910470104711047210473104741047510476104771047810479104801048110482104831048410485104861048710488104891049010491104921049310494104951049610497104981049910500105011050210503105041050510506105071050810509105101051110512105131051410515105161051710518105191052010521105221052310524105251052610527105281052910530105311053210533105341053510536105371053810539105401054110542105431054410545105461054710548105491055010551105521055310554105551055610557105581055910560105611056210563105641056510566105671056810569105701057110572105731057410575105761057710578105791058010581105821058310584105851058610587105881058910590105911059210593105941059510596105971059810599106001060110602106031060410605106061060710608106091061010611106121061310614106151061610617106181061910620106211062210623106241062510626106271062810629106301063110632106331063410635106361063710638106391064010641106421064310644106451064610647106481064910650106511065210653106541065510656106571065810659106601066110662106631066410665106661066710668106691067010671106721067310674106751067610677106781067910680106811068210683106841068510686106871068810689106901069110692106931069410695106961069710698106991070010701107021070310704107051070610707107081070910710107111071210713107141071510716107171071810719107201072110722107231072410725107261072710728107291073010731107321073310734107351073610737107381073910740107411074210743107441074510746107471074810749107501075110752107531075410755107561075710758107591076010761107621076310764107651076610767107681076910770107711077210773107741077510776107771077810779107801078110782107831078410785107861078710788107891079010791107921079310794107951079610797107981079910800108011080210803108041080510806108071080810809108101081110812108131081410815108161081710818108191082010821108221082310824108251082610827108281082910830108311083210833108341083510836108371083810839108401084110842108431084410845108461084710848108491085010851108521085310854108551085610857108581085910860108611086210863108641086510866108671086810869108701087110872108731087410875108761087710878108791088010881108821088310884108851088610887108881088910890108911089210893108941089510896108971089810899109001090110902109031090410905109061090710908109091091010911109121091310914109151091610917109181091910920109211092210923109241092510926109271092810929109301093110932109331093410935109361093710938109391094010941109421094310944109451094610947109481094910950109511095210953109541095510956109571095810959109601096110962109631096410965109661096710968109691097010971109721097310974109751097610977109781097910980109811098210983109841098510986109871098810989109901099110992109931099410995109961099710998109991100011001110021100311004110051100611007110081100911010110111101211013110141101511016110171101811019110201102111022110231102411025110261102711028110291103011031110321103311034110351103611037110381103911040110411104211043110441104511046110471104811049110501105111052110531105411055110561105711058110591106011061110621106311064110651106611067110681106911070110711107211073110741107511076110771107811079110801108111082110831108411085110861108711088110891109011091110921109311094110951109611097110981109911100111011110211103111041110511106111071110811109111101111111112111131111411115111161111711118111191112011121111221112311124111251112611127111281112911130111311113211133111341113511136111371113811139111401114111142111431114411145111461114711148111491115011151111521115311154111551115611157111581115911160111611116211163111641116511166111671116811169111701117111172111731117411175111761117711178111791118011181111821118311184111851118611187111881118911190111911119211193111941119511196111971119811199112001120111202112031120411205112061120711208112091121011211112121121311214112151121611217112181121911220112211122211223112241122511226112271122811229112301123111232112331123411235112361123711238112391124011241112421124311244112451124611247112481124911250112511125211253112541125511256112571125811259112601126111262112631126411265112661126711268112691127011271112721127311274112751127611277112781127911280112811128211283112841128511286112871128811289112901129111292112931129411295112961129711298112991130011301113021130311304113051130611307113081130911310113111131211313113141131511316113171131811319113201132111322113231132411325113261132711328113291133011331113321133311334113351133611337113381133911340113411134211343113441134511346113471134811349113501135111352113531135411355113561135711358113591136011361113621136311364113651136611367113681136911370113711137211373113741137511376113771137811379113801138111382113831138411385113861138711388113891139011391113921139311394113951139611397113981139911400114011140211403114041140511406114071140811409114101141111412114131141411415114161141711418114191142011421114221142311424114251142611427114281142911430114311143211433114341143511436114371143811439114401144111442114431144411445114461144711448114491145011451114521145311454114551145611457114581145911460114611146211463114641146511466114671146811469114701147111472114731147411475114761147711478114791148011481114821148311484114851148611487114881148911490114911149211493114941149511496114971149811499115001150111502115031150411505115061150711508115091151011511115121151311514115151151611517115181151911520115211152211523115241152511526115271152811529115301153111532115331153411535115361153711538115391154011541115421154311544115451154611547115481154911550115511155211553115541155511556115571155811559115601156111562115631156411565115661156711568115691157011571115721157311574115751157611577115781157911580115811158211583115841158511586115871158811589115901159111592115931159411595115961159711598115991160011601116021160311604116051160611607116081160911610116111161211613116141161511616116171161811619116201162111622116231162411625116261162711628116291163011631116321163311634116351163611637116381163911640116411164211643116441164511646116471164811649116501165111652116531165411655116561165711658116591166011661116621166311664116651166611667116681166911670116711167211673116741167511676116771167811679116801168111682116831168411685116861168711688116891169011691116921169311694116951169611697116981169911700117011170211703117041170511706117071170811709117101171111712117131171411715117161171711718117191172011721117221172311724117251172611727117281172911730117311173211733117341173511736117371173811739117401174111742117431174411745117461174711748117491175011751117521175311754117551175611757117581175911760117611176211763117641176511766117671176811769117701177111772117731177411775117761177711778117791178011781117821178311784117851178611787117881178911790117911179211793117941179511796117971179811799118001180111802118031180411805118061180711808118091181011811118121181311814118151181611817118181181911820118211182211823118241182511826118271182811829118301183111832118331183411835118361183711838118391184011841118421184311844118451184611847118481184911850118511185211853118541185511856118571185811859118601186111862118631186411865118661186711868118691187011871118721187311874118751187611877118781187911880118811188211883118841188511886118871188811889118901189111892118931189411895118961189711898118991190011901119021190311904119051190611907119081190911910119111191211913119141191511916119171191811919119201192111922119231192411925119261192711928119291193011931119321193311934119351193611937119381193911940119411194211943119441194511946119471194811949119501195111952119531195411955119561195711958119591196011961119621196311964119651196611967119681196911970119711197211973119741197511976119771197811979119801198111982119831198411985119861198711988119891199011991119921199311994119951199611997119981199912000120011200212003120041200512006120071200812009120101201112012120131201412015120161201712018120191202012021120221202312024120251202612027120281202912030120311203212033120341203512036120371203812039120401204112042120431204412045120461204712048120491205012051120521205312054120551205612057120581205912060120611206212063120641206512066120671206812069120701207112072120731207412075120761207712078120791208012081120821208312084120851208612087120881208912090120911209212093120941209512096120971209812099121001210112102121031210412105121061210712108121091211012111121121211312114121151211612117121181211912120121211212212123121241212512126121271212812129121301213112132121331213412135121361213712138121391214012141121421214312144121451214612147121481214912150121511215212153121541215512156121571215812159121601216112162121631216412165121661216712168121691217012171121721217312174121751217612177121781217912180121811218212183121841218512186121871218812189121901219112192121931219412195121961219712198121991220012201122021220312204122051220612207122081220912210122111221212213122141221512216122171221812219122201222112222122231222412225122261222712228122291223012231122321223312234122351223612237122381223912240122411224212243122441224512246122471224812249122501225112252122531225412255122561225712258122591226012261122621226312264122651226612267122681226912270122711227212273122741227512276122771227812279122801228112282122831228412285122861228712288122891229012291122921229312294122951229612297122981229912300123011230212303123041230512306123071230812309123101231112312123131231412315123161231712318123191232012321123221232312324123251232612327123281232912330123311233212333123341233512336123371233812339123401234112342123431234412345123461234712348123491235012351123521235312354123551235612357123581235912360123611236212363123641236512366123671236812369123701237112372123731237412375123761237712378123791238012381123821238312384123851238612387123881238912390123911239212393123941239512396123971239812399124001240112402124031240412405124061240712408124091241012411124121241312414124151241612417124181241912420124211242212423124241242512426124271242812429124301243112432124331243412435124361243712438124391244012441124421244312444124451244612447124481244912450124511245212453124541245512456124571245812459124601246112462124631246412465124661246712468124691247012471124721247312474124751247612477124781247912480124811248212483124841248512486124871248812489124901249112492124931249412495124961249712498124991250012501125021250312504125051250612507125081250912510125111251212513125141251512516125171251812519125201252112522125231252412525125261252712528125291253012531125321253312534125351253612537125381253912540125411254212543125441254512546125471254812549125501255112552125531255412555125561255712558125591256012561125621256312564125651256612567125681256912570125711257212573125741257512576125771257812579125801258112582125831258412585125861258712588125891259012591125921259312594125951259612597125981259912600126011260212603126041260512606126071260812609126101261112612126131261412615126161261712618126191262012621126221262312624126251262612627126281262912630126311263212633126341263512636126371263812639126401264112642126431264412645126461264712648126491265012651126521265312654126551265612657126581265912660126611266212663126641266512666126671266812669126701267112672126731267412675126761267712678126791268012681126821268312684126851268612687126881268912690126911269212693126941269512696126971269812699127001270112702127031270412705127061270712708127091271012711127121271312714127151271612717127181271912720127211272212723127241272512726127271272812729127301273112732127331273412735127361273712738127391274012741127421274312744127451274612747127481274912750127511275212753127541275512756127571275812759127601276112762127631276412765127661276712768127691277012771127721277312774127751277612777127781277912780127811278212783127841278512786127871278812789127901279112792127931279412795127961279712798127991280012801128021280312804128051280612807128081280912810128111281212813128141281512816128171281812819128201282112822128231282412825128261282712828128291283012831128321283312834128351283612837128381283912840128411284212843128441284512846128471284812849128501285112852128531285412855128561285712858128591286012861128621286312864128651286612867128681286912870128711287212873128741287512876128771287812879128801288112882128831288412885128861288712888128891289012891128921289312894128951289612897128981289912900129011290212903129041290512906129071290812909129101291112912129131291412915129161291712918129191292012921129221292312924129251292612927129281292912930129311293212933129341293512936129371293812939129401294112942129431294412945129461294712948129491295012951129521295312954129551295612957129581295912960129611296212963129641296512966129671296812969129701297112972129731297412975129761297712978129791298012981129821298312984129851298612987129881298912990129911299212993129941299512996129971299812999130001300113002130031300413005130061300713008130091301013011130121301313014130151301613017130181301913020130211302213023130241302513026130271302813029130301303113032130331303413035130361303713038130391304013041130421304313044130451304613047130481304913050130511305213053130541305513056130571305813059130601306113062130631306413065130661306713068130691307013071130721307313074130751307613077130781307913080130811308213083130841308513086130871308813089130901309113092130931309413095130961309713098130991310013101131021310313104131051310613107131081310913110131111311213113131141311513116131171311813119131201312113122131231312413125131261312713128131291313013131131321313313134131351313613137131381313913140131411314213143131441314513146131471314813149131501315113152131531315413155131561315713158131591316013161131621316313164131651316613167131681316913170131711317213173131741317513176131771317813179131801318113182131831318413185131861318713188131891319013191131921319313194131951319613197131981319913200132011320213203132041320513206132071320813209132101321113212132131321413215132161321713218132191322013221132221322313224132251322613227132281322913230132311323213233132341323513236132371323813239132401324113242132431324413245132461324713248132491325013251132521325313254132551325613257132581325913260132611326213263132641326513266132671326813269132701327113272132731327413275132761327713278132791328013281132821328313284132851328613287132881328913290132911329213293132941329513296132971329813299133001330113302133031330413305133061330713308133091331013311133121331313314133151331613317133181331913320133211332213323133241332513326133271332813329133301333113332133331333413335133361333713338133391334013341133421334313344133451334613347133481334913350133511335213353133541335513356133571335813359133601336113362133631336413365133661336713368133691337013371133721337313374133751337613377133781337913380133811338213383133841338513386133871338813389133901339113392133931339413395133961339713398133991340013401134021340313404134051340613407134081340913410134111341213413134141341513416134171341813419134201342113422134231342413425134261342713428134291343013431134321343313434134351343613437134381343913440134411344213443134441344513446134471344813449134501345113452134531345413455134561345713458134591346013461134621346313464134651346613467134681346913470134711347213473134741347513476134771347813479134801348113482134831348413485134861348713488134891349013491134921349313494134951349613497134981349913500135011350213503135041350513506135071350813509135101351113512135131351413515135161351713518135191352013521135221352313524135251352613527135281352913530135311353213533135341353513536135371353813539135401354113542135431354413545135461354713548135491355013551135521355313554135551355613557135581355913560135611356213563135641356513566135671356813569135701357113572135731357413575135761357713578135791358013581135821358313584135851358613587135881358913590135911359213593135941359513596135971359813599136001360113602136031360413605136061360713608136091361013611136121361313614136151361613617136181361913620136211362213623136241362513626136271362813629136301363113632136331363413635136361363713638136391364013641136421364313644136451364613647136481364913650136511365213653136541365513656136571365813659136601366113662136631366413665136661366713668136691367013671136721367313674136751367613677136781367913680136811368213683136841368513686136871368813689136901369113692136931369413695136961369713698136991370013701137021370313704137051370613707137081370913710137111371213713137141371513716137171371813719137201372113722137231372413725137261372713728137291373013731137321373313734137351373613737137381373913740137411374213743137441374513746137471374813749137501375113752137531375413755137561375713758137591376013761137621376313764137651376613767137681376913770137711377213773137741377513776137771377813779137801378113782137831378413785137861378713788137891379013791137921379313794137951379613797137981379913800138011380213803138041380513806138071380813809138101381113812138131381413815138161381713818138191382013821138221382313824138251382613827138281382913830138311383213833138341383513836138371383813839138401384113842138431384413845138461384713848138491385013851138521385313854138551385613857138581385913860138611386213863138641386513866138671386813869138701387113872138731387413875138761387713878138791388013881138821388313884138851388613887138881388913890138911389213893138941389513896138971389813899139001390113902139031390413905139061390713908139091391013911139121391313914139151391613917139181391913920139211392213923139241392513926139271392813929139301393113932139331393413935139361393713938139391394013941139421394313944139451394613947139481394913950139511395213953139541395513956139571395813959139601396113962139631396413965139661396713968139691397013971139721397313974139751397613977139781397913980139811398213983139841398513986139871398813989139901399113992139931399413995139961399713998139991400014001140021400314004140051400614007140081400914010140111401214013140141401514016140171401814019140201402114022140231402414025140261402714028140291403014031140321403314034140351403614037140381403914040140411404214043140441404514046140471404814049140501405114052140531405414055140561405714058140591406014061140621406314064140651406614067140681406914070140711407214073140741407514076140771407814079140801408114082140831408414085140861408714088140891409014091140921409314094140951409614097140981409914100141011410214103141041410514106141071410814109141101411114112141131411414115141161411714118141191412014121141221412314124141251412614127141281412914130141311413214133141341413514136141371413814139141401414114142141431414414145141461414714148141491415014151141521415314154141551415614157141581415914160141611416214163141641416514166141671416814169141701417114172141731417414175141761417714178141791418014181141821418314184141851418614187141881418914190141911419214193141941419514196141971419814199142001420114202142031420414205142061420714208142091421014211142121421314214142151421614217142181421914220142211422214223142241422514226142271422814229142301423114232142331423414235142361423714238142391424014241142421424314244142451424614247142481424914250142511425214253142541425514256142571425814259142601426114262142631426414265142661426714268142691427014271142721427314274142751427614277142781427914280142811428214283142841428514286142871428814289142901429114292142931429414295142961429714298142991430014301143021430314304143051430614307143081430914310143111431214313143141431514316143171431814319143201432114322143231432414325143261432714328143291433014331143321433314334143351433614337143381433914340143411434214343143441434514346143471434814349143501435114352143531435414355143561435714358143591436014361143621436314364143651436614367143681436914370143711437214373143741437514376143771437814379143801438114382143831438414385143861438714388143891439014391143921439314394143951439614397143981439914400144011440214403144041440514406144071440814409144101441114412144131441414415144161441714418144191442014421144221442314424144251442614427144281442914430144311443214433144341443514436144371443814439144401444114442144431444414445144461444714448144491445014451144521445314454144551445614457144581445914460144611446214463144641446514466144671446814469144701447114472144731447414475144761447714478144791448014481144821448314484144851448614487144881448914490144911449214493144941449514496144971449814499145001450114502145031450414505145061450714508145091451014511145121451314514145151451614517145181451914520145211452214523145241452514526145271452814529145301453114532145331453414535145361453714538145391454014541145421454314544145451454614547145481454914550145511455214553145541455514556145571455814559145601456114562145631456414565145661456714568145691457014571145721457314574145751457614577145781457914580145811458214583145841458514586145871458814589145901459114592145931459414595145961459714598145991460014601146021460314604146051460614607146081460914610146111461214613146141461514616146171461814619146201462114622146231462414625146261462714628146291463014631146321463314634146351463614637146381463914640146411464214643146441464514646146471464814649146501465114652146531465414655146561465714658146591466014661146621466314664146651466614667146681466914670146711467214673146741467514676146771467814679146801468114682146831468414685146861468714688146891469014691146921469314694146951469614697146981469914700147011470214703147041470514706147071470814709147101471114712147131471414715147161471714718147191472014721147221472314724147251472614727147281472914730147311473214733147341473514736147371473814739147401474114742147431474414745147461474714748147491475014751147521475314754147551475614757147581475914760147611476214763147641476514766147671476814769147701477114772147731477414775147761477714778147791478014781147821478314784147851478614787147881478914790147911479214793147941479514796147971479814799148001480114802148031480414805148061480714808148091481014811148121481314814148151481614817148181481914820148211482214823148241482514826148271482814829148301483114832148331483414835148361483714838148391484014841148421484314844148451484614847148481484914850148511485214853148541485514856148571485814859148601486114862148631486414865148661486714868148691487014871148721487314874148751487614877148781487914880148811488214883148841488514886148871488814889148901489114892148931489414895148961489714898148991490014901149021490314904149051490614907149081490914910149111491214913149141491514916149171491814919149201492114922149231492414925149261492714928149291493014931149321493314934149351493614937149381493914940149411494214943149441494514946149471494814949149501495114952149531495414955149561495714958149591496014961149621496314964149651496614967149681496914970149711497214973149741497514976149771497814979149801498114982149831498414985149861498714988149891499014991149921499314994149951499614997149981499915000150011500215003150041500515006150071500815009150101501115012150131501415015150161501715018150191502015021150221502315024150251502615027150281502915030150311503215033150341503515036150371503815039150401504115042150431504415045150461504715048150491505015051150521505315054150551505615057150581505915060150611506215063150641506515066150671506815069150701507115072150731507415075150761507715078150791508015081150821508315084150851508615087150881508915090150911509215093150941509515096150971509815099151001510115102151031510415105151061510715108151091511015111151121511315114151151511615117151181511915120151211512215123151241512515126151271512815129151301513115132151331513415135151361513715138151391514015141151421514315144151451514615147151481514915150151511515215153151541515515156151571515815159151601516115162151631516415165151661516715168151691517015171151721517315174151751517615177151781517915180151811518215183151841518515186151871518815189151901519115192151931519415195151961519715198151991520015201152021520315204152051520615207152081520915210152111521215213152141521515216152171521815219152201522115222152231522415225152261522715228152291523015231152321523315234152351523615237152381523915240152411524215243152441524515246152471524815249152501525115252152531525415255152561525715258152591526015261152621526315264152651526615267152681526915270152711527215273152741527515276152771527815279152801528115282152831528415285152861528715288152891529015291152921529315294152951529615297152981529915300153011530215303153041530515306153071530815309153101531115312153131531415315153161531715318153191532015321153221532315324153251532615327153281532915330153311533215333153341533515336153371533815339153401534115342153431534415345153461534715348153491535015351153521535315354153551535615357153581535915360153611536215363153641536515366153671536815369153701537115372153731537415375153761537715378153791538015381153821538315384153851538615387153881538915390153911539215393153941539515396153971539815399154001540115402154031540415405154061540715408154091541015411154121541315414154151541615417154181541915420154211542215423154241542515426154271542815429154301543115432154331543415435154361543715438154391544015441154421544315444154451544615447154481544915450154511545215453154541545515456154571545815459154601546115462154631546415465154661546715468154691547015471154721547315474154751547615477154781547915480154811548215483154841548515486154871548815489154901549115492154931549415495154961549715498154991550015501155021550315504155051550615507155081550915510155111551215513155141551515516155171551815519155201552115522155231552415525155261552715528155291553015531155321553315534155351553615537155381553915540155411554215543155441554515546155471554815549155501555115552155531555415555155561555715558155591556015561155621556315564155651556615567155681556915570155711557215573155741557515576155771557815579155801558115582155831558415585155861558715588155891559015591155921559315594155951559615597155981559915600156011560215603156041560515606156071560815609156101561115612156131561415615156161561715618156191562015621156221562315624156251562615627156281562915630156311563215633156341563515636156371563815639156401564115642156431564415645156461564715648156491565015651156521565315654156551565615657156581565915660156611566215663156641566515666156671566815669156701567115672156731567415675156761567715678156791568015681156821568315684156851568615687156881568915690156911569215693156941569515696156971569815699157001570115702157031570415705157061570715708157091571015711157121571315714157151571615717157181571915720157211572215723157241572515726157271572815729157301573115732157331573415735157361573715738157391574015741157421574315744157451574615747157481574915750157511575215753157541575515756157571575815759157601576115762157631576415765157661576715768157691577015771157721577315774157751577615777157781577915780157811578215783157841578515786157871578815789157901579115792157931579415795157961579715798157991580015801158021580315804158051580615807158081580915810158111581215813158141581515816158171581815819158201582115822158231582415825158261582715828158291583015831158321583315834158351583615837158381583915840158411584215843158441584515846158471584815849158501585115852158531585415855158561585715858158591586015861158621586315864158651586615867158681586915870158711587215873158741587515876158771587815879158801588115882158831588415885158861588715888158891589015891158921589315894158951589615897158981589915900159011590215903159041590515906159071590815909159101591115912159131591415915159161591715918159191592015921159221592315924159251592615927159281592915930159311593215933159341593515936159371593815939159401594115942159431594415945159461594715948159491595015951159521595315954159551595615957159581595915960159611596215963159641596515966159671596815969159701597115972159731597415975159761597715978159791598015981159821598315984159851598615987159881598915990159911599215993159941599515996159971599815999160001600116002160031600416005160061600716008160091601016011160121601316014160151601616017160181601916020160211602216023160241602516026160271602816029160301603116032160331603416035160361603716038160391604016041160421604316044160451604616047160481604916050160511605216053160541605516056160571605816059160601606116062160631606416065160661606716068160691607016071160721607316074160751607616077160781607916080160811608216083160841608516086160871608816089160901609116092160931609416095160961609716098160991610016101161021610316104161051610616107161081610916110161111611216113161141611516116161171611816119161201612116122161231612416125161261612716128161291613016131161321613316134161351613616137161381613916140161411614216143161441614516146161471614816149161501615116152161531615416155161561615716158161591616016161161621616316164161651616616167161681616916170161711617216173161741617516176161771617816179161801618116182161831618416185161861618716188161891619016191161921619316194161951619616197161981619916200162011620216203162041620516206162071620816209162101621116212162131621416215162161621716218162191622016221162221622316224162251622616227162281622916230162311623216233162341623516236162371623816239162401624116242162431624416245162461624716248162491625016251162521625316254162551625616257162581625916260162611626216263162641626516266162671626816269162701627116272162731627416275162761627716278162791628016281162821628316284162851628616287162881628916290162911629216293162941629516296162971629816299163001630116302163031630416305163061630716308163091631016311163121631316314163151631616317163181631916320163211632216323163241632516326163271632816329163301633116332163331633416335163361633716338163391634016341163421634316344163451634616347163481634916350163511635216353163541635516356163571635816359163601636116362163631636416365163661636716368163691637016371163721637316374163751637616377163781637916380163811638216383163841638516386163871638816389163901639116392163931639416395163961639716398163991640016401164021640316404164051640616407164081640916410164111641216413164141641516416164171641816419164201642116422164231642416425164261642716428164291643016431164321643316434164351643616437164381643916440164411644216443164441644516446164471644816449164501645116452164531645416455164561645716458164591646016461164621646316464164651646616467164681646916470164711647216473164741647516476164771647816479164801648116482164831648416485164861648716488164891649016491164921649316494164951649616497164981649916500165011650216503165041650516506165071650816509165101651116512165131651416515165161651716518165191652016521165221652316524165251652616527165281652916530165311653216533165341653516536165371653816539165401654116542165431654416545165461654716548165491655016551165521655316554165551655616557165581655916560165611656216563165641656516566165671656816569165701657116572165731657416575165761657716578165791658016581165821658316584165851658616587165881658916590165911659216593165941659516596165971659816599166001660116602166031660416605166061660716608166091661016611166121661316614166151661616617166181661916620166211662216623166241662516626166271662816629166301663116632166331663416635166361663716638166391664016641166421664316644166451664616647166481664916650166511665216653166541665516656166571665816659166601666116662166631666416665166661666716668166691667016671166721667316674166751667616677166781667916680166811668216683166841668516686166871668816689166901669116692166931669416695166961669716698166991670016701167021670316704167051670616707167081670916710167111671216713167141671516716167171671816719167201672116722167231672416725167261672716728167291673016731167321673316734167351673616737167381673916740167411674216743167441674516746167471674816749167501675116752167531675416755167561675716758167591676016761167621676316764167651676616767167681676916770167711677216773167741677516776167771677816779167801678116782167831678416785167861678716788167891679016791167921679316794167951679616797167981679916800168011680216803168041680516806168071680816809168101681116812168131681416815168161681716818168191682016821168221682316824168251682616827168281682916830168311683216833168341683516836168371683816839168401684116842168431684416845168461684716848168491685016851168521685316854168551685616857168581685916860168611686216863168641686516866168671686816869168701687116872168731687416875168761687716878168791688016881168821688316884168851688616887168881688916890168911689216893168941689516896168971689816899169001690116902169031690416905169061690716908169091691016911169121691316914169151691616917169181691916920169211692216923169241692516926169271692816929169301693116932169331693416935169361693716938169391694016941169421694316944169451694616947169481694916950169511695216953169541695516956169571695816959169601696116962169631696416965169661696716968169691697016971169721697316974169751697616977169781697916980169811698216983169841698516986169871698816989169901699116992169931699416995169961699716998169991700017001170021700317004170051700617007170081700917010170111701217013170141701517016170171701817019170201702117022170231702417025170261702717028170291703017031170321703317034170351703617037170381703917040170411704217043170441704517046170471704817049170501705117052170531705417055170561705717058170591706017061170621706317064170651706617067170681706917070170711707217073170741707517076170771707817079170801708117082170831708417085170861708717088170891709017091170921709317094170951709617097170981709917100171011710217103171041710517106171071710817109171101711117112171131711417115171161711717118171191712017121171221712317124171251712617127171281712917130171311713217133171341713517136171371713817139171401714117142171431714417145171461714717148171491715017151171521715317154171551715617157171581715917160171611716217163171641716517166171671716817169171701717117172171731717417175171761717717178171791718017181171821718317184171851718617187171881718917190171911719217193171941719517196171971719817199172001720117202172031720417205172061720717208172091721017211172121721317214172151721617217172181721917220172211722217223172241722517226172271722817229172301723117232172331723417235172361723717238172391724017241172421724317244172451724617247172481724917250172511725217253172541725517256172571725817259172601726117262172631726417265172661726717268172691727017271172721727317274172751727617277172781727917280172811728217283172841728517286172871728817289172901729117292172931729417295172961729717298172991730017301173021730317304173051730617307173081730917310173111731217313173141731517316173171731817319173201732117322173231732417325173261732717328173291733017331173321733317334173351733617337173381733917340173411734217343173441734517346173471734817349173501735117352173531735417355173561735717358173591736017361173621736317364173651736617367173681736917370173711737217373173741737517376173771737817379173801738117382173831738417385173861738717388173891739017391173921739317394173951739617397173981739917400174011740217403174041740517406174071740817409174101741117412174131741417415174161741717418174191742017421174221742317424174251742617427174281742917430174311743217433174341743517436174371743817439174401744117442174431744417445174461744717448174491745017451174521745317454174551745617457174581745917460174611746217463174641746517466174671746817469174701747117472174731747417475174761747717478174791748017481174821748317484174851748617487174881748917490174911749217493174941749517496174971749817499175001750117502175031750417505175061750717508175091751017511175121751317514175151751617517175181751917520175211752217523175241752517526175271752817529175301753117532175331753417535175361753717538175391754017541175421754317544175451754617547175481754917550175511755217553175541755517556175571755817559175601756117562175631756417565175661756717568175691757017571175721757317574175751757617577175781757917580175811758217583175841758517586175871758817589175901759117592175931759417595175961759717598175991760017601176021760317604176051760617607176081760917610176111761217613176141761517616176171761817619176201762117622176231762417625176261762717628176291763017631176321763317634176351763617637176381763917640176411764217643176441764517646176471764817649176501765117652176531765417655176561765717658176591766017661176621766317664176651766617667176681766917670176711767217673176741767517676176771767817679176801768117682176831768417685176861768717688176891769017691176921769317694176951769617697176981769917700177011770217703177041770517706177071770817709177101771117712177131771417715177161771717718177191772017721177221772317724177251772617727177281772917730177311773217733177341773517736177371773817739177401774117742177431774417745177461774717748177491775017751177521775317754177551775617757177581775917760177611776217763177641776517766177671776817769177701777117772177731777417775177761777717778177791778017781177821778317784177851778617787177881778917790177911779217793177941779517796177971779817799178001780117802178031780417805178061780717808178091781017811178121781317814178151781617817178181781917820178211782217823178241782517826178271782817829178301783117832178331783417835178361783717838178391784017841178421784317844178451784617847178481784917850178511785217853178541785517856178571785817859178601786117862178631786417865178661786717868178691787017871178721787317874178751787617877178781787917880178811788217883178841788517886178871788817889178901789117892178931789417895178961789717898178991790017901179021790317904179051790617907179081790917910179111791217913179141791517916179171791817919179201792117922179231792417925179261792717928179291793017931179321793317934179351793617937179381793917940179411794217943179441794517946179471794817949179501795117952179531795417955179561795717958179591796017961179621796317964179651796617967179681796917970179711797217973179741797517976179771797817979179801798117982179831798417985179861798717988179891799017991179921799317994179951799617997179981799918000180011800218003180041800518006180071800818009180101801118012180131801418015180161801718018180191802018021180221802318024180251802618027180281802918030180311803218033180341803518036180371803818039180401804118042180431804418045180461804718048180491805018051180521805318054180551805618057180581805918060180611806218063180641806518066180671806818069180701807118072180731807418075180761807718078180791808018081180821808318084180851808618087180881808918090180911809218093180941809518096180971809818099181001810118102181031810418105181061810718108181091811018111181121811318114181151811618117181181811918120181211812218123181241812518126181271812818129181301813118132181331813418135181361813718138181391814018141181421814318144181451814618147181481814918150181511815218153181541815518156181571815818159181601816118162181631816418165181661816718168181691817018171181721817318174181751817618177181781817918180181811818218183181841818518186181871818818189181901819118192181931819418195181961819718198181991820018201182021820318204182051820618207182081820918210182111821218213182141821518216182171821818219182201822118222182231822418225182261822718228182291823018231182321823318234182351823618237182381823918240182411824218243182441824518246182471824818249182501825118252182531825418255182561825718258182591826018261182621826318264182651826618267182681826918270182711827218273182741827518276182771827818279182801828118282182831828418285182861828718288182891829018291182921829318294182951829618297182981829918300183011830218303183041830518306183071830818309183101831118312183131831418315183161831718318183191832018321183221832318324183251832618327183281832918330183311833218333183341833518336183371833818339183401834118342183431834418345183461834718348183491835018351183521835318354183551835618357183581835918360183611836218363183641836518366183671836818369183701837118372183731837418375183761837718378183791838018381183821838318384183851838618387183881838918390183911839218393183941839518396183971839818399184001840118402184031840418405184061840718408184091841018411184121841318414184151841618417184181841918420184211842218423184241842518426184271842818429184301843118432184331843418435184361843718438184391844018441184421844318444184451844618447184481844918450184511845218453184541845518456184571845818459184601846118462184631846418465184661846718468184691847018471184721847318474184751847618477184781847918480184811848218483184841848518486184871848818489184901849118492184931849418495184961849718498184991850018501185021850318504185051850618507185081850918510185111851218513185141851518516185171851818519185201852118522185231852418525185261852718528185291853018531185321853318534185351853618537185381853918540185411854218543185441854518546185471854818549185501855118552185531855418555185561855718558185591856018561185621856318564185651856618567185681856918570185711857218573185741857518576185771857818579185801858118582185831858418585185861858718588185891859018591185921859318594185951859618597185981859918600186011860218603186041860518606186071860818609186101861118612186131861418615186161861718618186191862018621186221862318624186251862618627186281862918630186311863218633186341863518636186371863818639186401864118642186431864418645186461864718648186491865018651186521865318654186551865618657186581865918660186611866218663186641866518666186671866818669186701867118672186731867418675186761867718678186791868018681186821868318684186851868618687186881868918690186911869218693186941869518696186971869818699187001870118702187031870418705187061870718708187091871018711187121871318714187151871618717187181871918720187211872218723187241872518726187271872818729187301873118732187331873418735187361873718738187391874018741187421874318744187451874618747187481874918750187511875218753187541875518756187571875818759187601876118762187631876418765187661876718768187691877018771187721877318774187751877618777187781877918780187811878218783187841878518786187871878818789187901879118792187931879418795187961879718798187991880018801188021880318804188051880618807188081880918810188111881218813188141881518816188171881818819188201882118822188231882418825188261882718828188291883018831188321883318834188351883618837188381883918840188411884218843188441884518846188471884818849188501885118852188531885418855188561885718858188591886018861188621886318864188651886618867188681886918870188711887218873188741887518876188771887818879188801888118882188831888418885188861888718888188891889018891188921889318894188951889618897188981889918900189011890218903189041890518906189071890818909189101891118912189131891418915189161891718918189191892018921189221892318924189251892618927189281892918930189311893218933189341893518936189371893818939189401894118942189431894418945189461894718948189491895018951189521895318954189551895618957189581895918960189611896218963189641896518966189671896818969189701897118972189731897418975189761897718978189791898018981189821898318984189851898618987189881898918990189911899218993189941899518996189971899818999190001900119002190031900419005190061900719008190091901019011190121901319014190151901619017190181901919020190211902219023190241902519026190271902819029190301903119032190331903419035190361903719038190391904019041190421904319044190451904619047190481904919050190511905219053190541905519056190571905819059190601906119062190631906419065190661906719068190691907019071190721907319074190751907619077190781907919080190811908219083190841908519086190871908819089190901909119092190931909419095190961909719098190991910019101191021910319104191051910619107191081910919110191111911219113191141911519116191171911819119191201912119122191231912419125191261912719128191291913019131191321913319134191351913619137191381913919140191411914219143191441914519146191471914819149191501915119152191531915419155191561915719158191591916019161191621916319164191651916619167191681916919170191711917219173191741917519176191771917819179191801918119182191831918419185191861918719188191891919019191191921919319194191951919619197191981919919200192011920219203192041920519206192071920819209192101921119212192131921419215192161921719218192191922019221192221922319224192251922619227192281922919230192311923219233192341923519236192371923819239192401924119242192431924419245192461924719248192491925019251192521925319254192551925619257192581925919260192611926219263192641926519266192671926819269192701927119272192731927419275192761927719278192791928019281192821928319284192851928619287192881928919290192911929219293192941929519296192971929819299193001930119302193031930419305193061930719308193091931019311193121931319314193151931619317193181931919320193211932219323193241932519326193271932819329193301933119332193331933419335193361933719338193391934019341193421934319344193451934619347193481934919350193511935219353193541935519356193571935819359193601936119362193631936419365193661936719368193691937019371193721937319374193751937619377193781937919380193811938219383193841938519386193871938819389193901939119392193931939419395193961939719398193991940019401194021940319404194051940619407194081940919410194111941219413194141941519416194171941819419194201942119422194231942419425194261942719428194291943019431194321943319434194351943619437194381943919440194411944219443194441944519446194471944819449194501945119452194531945419455194561945719458194591946019461194621946319464194651946619467194681946919470194711947219473194741947519476194771947819479194801948119482194831948419485194861948719488194891949019491194921949319494194951949619497194981949919500195011950219503195041950519506195071950819509195101951119512195131951419515195161951719518195191952019521195221952319524195251952619527195281952919530195311953219533195341953519536195371953819539195401954119542195431954419545195461954719548195491955019551195521955319554195551955619557195581955919560195611956219563195641956519566195671956819569195701957119572195731957419575195761957719578195791958019581195821958319584195851958619587195881958919590195911959219593195941959519596195971959819599196001960119602196031960419605196061960719608196091961019611196121961319614196151961619617196181961919620196211962219623196241962519626196271962819629196301963119632196331963419635196361963719638196391964019641196421964319644196451964619647196481964919650196511965219653196541965519656196571965819659196601966119662196631966419665196661966719668196691967019671196721967319674196751967619677196781967919680196811968219683196841968519686196871968819689196901969119692196931969419695196961969719698196991970019701197021970319704197051970619707197081970919710197111971219713197141971519716197171971819719197201972119722197231972419725197261972719728197291973019731197321973319734197351973619737197381973919740197411974219743197441974519746197471974819749197501975119752197531975419755197561975719758197591976019761197621976319764197651976619767197681976919770197711977219773197741977519776197771977819779197801978119782197831978419785197861978719788197891979019791197921979319794197951979619797197981979919800198011980219803198041980519806198071980819809198101981119812198131981419815198161981719818198191982019821198221982319824198251982619827198281982919830198311983219833198341983519836198371983819839198401984119842198431984419845198461984719848198491985019851198521985319854198551985619857198581985919860198611986219863198641986519866198671986819869198701987119872198731987419875198761987719878198791988019881198821988319884198851988619887198881988919890198911989219893198941989519896198971989819899199001990119902199031990419905199061990719908199091991019911199121991319914199151991619917199181991919920199211992219923199241992519926199271992819929199301993119932199331993419935199361993719938199391994019941199421994319944199451994619947199481994919950199511995219953199541995519956199571995819959199601996119962199631996419965199661996719968199691997019971199721997319974199751997619977199781997919980199811998219983199841998519986199871998819989199901999119992199931999419995199961999719998199992000020001200022000320004200052000620007200082000920010200112001220013200142001520016200172001820019200202002120022200232002420025200262002720028200292003020031200322003320034200352003620037200382003920040200412004220043200442004520046200472004820049200502005120052200532005420055200562005720058200592006020061200622006320064200652006620067200682006920070200712007220073200742007520076200772007820079200802008120082200832008420085200862008720088200892009020091200922009320094200952009620097200982009920100201012010220103201042010520106201072010820109201102011120112201132011420115201162011720118201192012020121201222012320124201252012620127201282012920130201312013220133201342013520136201372013820139201402014120142201432014420145201462014720148201492015020151201522015320154201552015620157201582015920160201612016220163201642016520166201672016820169201702017120172201732017420175201762017720178201792018020181201822018320184201852018620187201882018920190201912019220193201942019520196201972019820199202002020120202202032020420205202062020720208202092021020211202122021320214202152021620217202182021920220202212022220223202242022520226202272022820229202302023120232202332023420235202362023720238202392024020241202422024320244202452024620247202482024920250202512025220253202542025520256202572025820259202602026120262202632026420265202662026720268202692027020271202722027320274202752027620277202782027920280202812028220283202842028520286202872028820289202902029120292202932029420295202962029720298202992030020301203022030320304203052030620307203082030920310203112031220313203142031520316203172031820319203202032120322203232032420325203262032720328203292033020331203322033320334203352033620337203382033920340203412034220343203442034520346203472034820349203502035120352203532035420355203562035720358203592036020361203622036320364203652036620367203682036920370203712037220373203742037520376203772037820379203802038120382203832038420385203862038720388203892039020391203922039320394203952039620397203982039920400204012040220403204042040520406204072040820409204102041120412204132041420415204162041720418204192042020421204222042320424204252042620427204282042920430204312043220433204342043520436204372043820439204402044120442204432044420445204462044720448204492045020451204522045320454204552045620457204582045920460204612046220463204642046520466204672046820469204702047120472204732047420475204762047720478204792048020481204822048320484204852048620487204882048920490204912049220493204942049520496204972049820499205002050120502205032050420505205062050720508205092051020511205122051320514205152051620517205182051920520205212052220523205242052520526205272052820529205302053120532205332053420535205362053720538205392054020541205422054320544205452054620547205482054920550205512055220553205542055520556205572055820559205602056120562205632056420565205662056720568205692057020571205722057320574205752057620577205782057920580205812058220583205842058520586205872058820589205902059120592205932059420595205962059720598205992060020601206022060320604206052060620607206082060920610206112061220613206142061520616206172061820619206202062120622206232062420625206262062720628206292063020631206322063320634206352063620637206382063920640206412064220643206442064520646206472064820649206502065120652206532065420655206562065720658206592066020661206622066320664206652066620667206682066920670206712067220673206742067520676206772067820679206802068120682206832068420685206862068720688206892069020691206922069320694206952069620697206982069920700207012070220703207042070520706207072070820709207102071120712207132071420715207162071720718207192072020721207222072320724207252072620727207282072920730207312073220733207342073520736207372073820739207402074120742207432074420745207462074720748207492075020751207522075320754207552075620757207582075920760207612076220763207642076520766207672076820769207702077120772207732077420775207762077720778207792078020781207822078320784207852078620787207882078920790207912079220793207942079520796207972079820799208002080120802208032080420805208062080720808208092081020811208122081320814208152081620817208182081920820208212082220823208242082520826208272082820829208302083120832208332083420835208362083720838208392084020841208422084320844208452084620847208482084920850208512085220853208542085520856208572085820859208602086120862208632086420865208662086720868208692087020871208722087320874208752087620877208782087920880208812088220883208842088520886208872088820889208902089120892208932089420895208962089720898208992090020901209022090320904209052090620907209082090920910209112091220913209142091520916209172091820919209202092120922209232092420925209262092720928209292093020931209322093320934209352093620937209382093920940209412094220943209442094520946209472094820949209502095120952209532095420955209562095720958209592096020961209622096320964209652096620967209682096920970209712097220973209742097520976209772097820979209802098120982209832098420985209862098720988209892099020991209922099320994209952099620997209982099921000210012100221003210042100521006210072100821009210102101121012210132101421015210162101721018210192102021021210222102321024210252102621027210282102921030210312103221033210342103521036210372103821039210402104121042210432104421045210462104721048210492105021051210522105321054210552105621057210582105921060210612106221063210642106521066210672106821069210702107121072210732107421075210762107721078210792108021081210822108321084210852108621087210882108921090210912109221093210942109521096210972109821099211002110121102211032110421105211062110721108211092111021111211122111321114211152111621117211182111921120211212112221123211242112521126211272112821129211302113121132211332113421135211362113721138211392114021141211422114321144211452114621147211482114921150211512115221153211542115521156211572115821159211602116121162211632116421165211662116721168211692117021171211722117321174211752117621177211782117921180211812118221183211842118521186211872118821189211902119121192211932119421195211962119721198211992120021201212022120321204212052120621207212082120921210212112121221213212142121521216212172121821219212202122121222212232122421225212262122721228212292123021231212322123321234212352123621237212382123921240212412124221243212442124521246212472124821249212502125121252212532125421255212562125721258212592126021261212622126321264212652126621267212682126921270212712127221273212742127521276212772127821279212802128121282212832128421285212862128721288212892129021291212922129321294212952129621297212982129921300213012130221303213042130521306213072130821309213102131121312213132131421315213162131721318213192132021321213222132321324213252132621327213282132921330213312133221333213342133521336213372133821339213402134121342213432134421345213462134721348213492135021351213522135321354213552135621357213582135921360213612136221363213642136521366213672136821369213702137121372213732137421375213762137721378213792138021381213822138321384213852138621387213882138921390213912139221393213942139521396213972139821399214002140121402214032140421405214062140721408214092141021411214122141321414214152141621417214182141921420214212142221423214242142521426214272142821429214302143121432214332143421435214362143721438214392144021441214422144321444214452144621447214482144921450214512145221453214542145521456214572145821459214602146121462214632146421465214662146721468214692147021471214722147321474214752147621477214782147921480214812148221483214842148521486214872148821489214902149121492214932149421495214962149721498214992150021501215022150321504215052150621507215082150921510215112151221513215142151521516215172151821519215202152121522215232152421525215262152721528215292153021531215322153321534215352153621537215382153921540215412154221543215442154521546215472154821549215502155121552215532155421555215562155721558215592156021561215622156321564215652156621567215682156921570215712157221573215742157521576215772157821579215802158121582215832158421585215862158721588215892159021591215922159321594215952159621597215982159921600216012160221603216042160521606216072160821609216102161121612216132161421615216162161721618216192162021621216222162321624216252162621627216282162921630216312163221633216342163521636216372163821639216402164121642216432164421645216462164721648216492165021651216522165321654216552165621657216582165921660216612166221663216642166521666216672166821669216702167121672216732167421675216762167721678216792168021681216822168321684216852168621687216882168921690216912169221693216942169521696216972169821699217002170121702217032170421705217062170721708217092171021711217122171321714217152171621717217182171921720217212172221723217242172521726217272172821729217302173121732217332173421735217362173721738217392174021741217422174321744217452174621747217482174921750217512175221753217542175521756217572175821759217602176121762217632176421765217662176721768217692177021771217722177321774217752177621777217782177921780217812178221783217842178521786217872178821789217902179121792217932179421795217962179721798217992180021801218022180321804218052180621807218082180921810218112181221813218142181521816218172181821819218202182121822218232182421825218262182721828218292183021831218322183321834218352183621837218382183921840218412184221843218442184521846218472184821849218502185121852218532185421855218562185721858218592186021861218622186321864218652186621867218682186921870218712187221873218742187521876218772187821879218802188121882218832188421885218862188721888218892189021891218922189321894218952189621897218982189921900219012190221903219042190521906219072190821909219102191121912219132191421915219162191721918219192192021921219222192321924219252192621927219282192921930219312193221933219342193521936219372193821939219402194121942219432194421945219462194721948219492195021951219522195321954219552195621957219582195921960219612196221963219642196521966219672196821969219702197121972219732197421975219762197721978219792198021981219822198321984219852198621987219882198921990219912199221993219942199521996219972199821999220002200122002220032200422005220062200722008220092201022011220122201322014220152201622017220182201922020220212202222023220242202522026220272202822029220302203122032220332203422035220362203722038220392204022041220422204322044220452204622047220482204922050220512205222053220542205522056220572205822059220602206122062220632206422065220662206722068220692207022071220722207322074220752207622077220782207922080220812208222083220842208522086220872208822089220902209122092220932209422095220962209722098220992210022101221022210322104221052210622107221082210922110221112211222113221142211522116221172211822119221202212122122221232212422125221262212722128221292213022131221322213322134221352213622137221382213922140221412214222143221442214522146221472214822149221502215122152221532215422155221562215722158221592216022161221622216322164221652216622167221682216922170221712217222173221742217522176221772217822179221802218122182221832218422185221862218722188221892219022191221922219322194221952219622197221982219922200222012220222203222042220522206222072220822209222102221122212222132221422215222162221722218222192222022221222222222322224222252222622227222282222922230222312223222233222342223522236222372223822239222402224122242222432224422245222462224722248222492225022251222522225322254222552225622257222582225922260222612226222263222642226522266222672226822269222702227122272222732227422275222762227722278222792228022281222822228322284222852228622287222882228922290222912229222293222942229522296222972229822299223002230122302223032230422305223062230722308223092231022311223122231322314223152231622317223182231922320223212232222323223242232522326223272232822329223302233122332223332233422335223362233722338223392234022341223422234322344223452234622347223482234922350223512235222353223542235522356223572235822359223602236122362223632236422365223662236722368223692237022371223722237322374223752237622377223782237922380223812238222383223842238522386223872238822389223902239122392223932239422395223962239722398223992240022401224022240322404224052240622407224082240922410224112241222413224142241522416224172241822419224202242122422224232242422425224262242722428224292243022431224322243322434224352243622437224382243922440224412244222443224442244522446224472244822449224502245122452224532245422455224562245722458224592246022461224622246322464224652246622467224682246922470224712247222473224742247522476224772247822479224802248122482224832248422485224862248722488224892249022491224922249322494224952249622497224982249922500225012250222503225042250522506225072250822509225102251122512225132251422515225162251722518225192252022521225222252322524225252252622527225282252922530225312253222533225342253522536225372253822539225402254122542225432254422545225462254722548225492255022551225522255322554225552255622557225582255922560225612256222563225642256522566225672256822569225702257122572225732257422575225762257722578225792258022581225822258322584225852258622587225882258922590225912259222593225942259522596225972259822599226002260122602226032260422605226062260722608226092261022611226122261322614226152261622617226182261922620226212262222623226242262522626226272262822629226302263122632226332263422635226362263722638226392264022641226422264322644226452264622647226482264922650226512265222653226542265522656226572265822659226602266122662226632266422665226662266722668226692267022671226722267322674226752267622677226782267922680226812268222683226842268522686226872268822689226902269122692226932269422695226962269722698226992270022701227022270322704227052270622707227082270922710227112271222713227142271522716227172271822719227202272122722227232272422725227262272722728227292273022731227322273322734227352273622737227382273922740227412274222743227442274522746227472274822749227502275122752227532275422755227562275722758227592276022761227622276322764227652276622767227682276922770227712277222773227742277522776227772277822779227802278122782227832278422785227862278722788227892279022791227922279322794227952279622797227982279922800228012280222803228042280522806228072280822809228102281122812228132281422815228162281722818228192282022821228222282322824228252282622827228282282922830228312283222833228342283522836228372283822839228402284122842228432284422845228462284722848228492285022851228522285322854228552285622857228582285922860228612286222863228642286522866228672286822869228702287122872228732287422875228762287722878228792288022881228822288322884228852288622887228882288922890228912289222893228942289522896228972289822899229002290122902229032290422905229062290722908229092291022911229122291322914229152291622917229182291922920229212292222923229242292522926229272292822929229302293122932229332293422935229362293722938229392294022941229422294322944229452294622947229482294922950229512295222953229542295522956229572295822959229602296122962229632296422965229662296722968229692297022971229722297322974229752297622977229782297922980229812298222983229842298522986229872298822989229902299122992229932299422995229962299722998229992300023001230022300323004230052300623007230082300923010230112301223013230142301523016230172301823019230202302123022230232302423025230262302723028230292303023031230322303323034230352303623037230382303923040230412304223043230442304523046230472304823049230502305123052230532305423055230562305723058230592306023061230622306323064230652306623067230682306923070230712307223073230742307523076230772307823079230802308123082230832308423085230862308723088230892309023091230922309323094230952309623097230982309923100231012310223103231042310523106231072310823109231102311123112231132311423115231162311723118231192312023121231222312323124231252312623127231282312923130231312313223133231342313523136231372313823139231402314123142231432314423145231462314723148231492315023151231522315323154231552315623157231582315923160231612316223163231642316523166231672316823169231702317123172231732317423175231762317723178231792318023181231822318323184231852318623187231882318923190231912319223193231942319523196231972319823199232002320123202232032320423205232062320723208232092321023211232122321323214232152321623217232182321923220232212322223223232242322523226232272322823229232302323123232232332323423235232362323723238232392324023241232422324323244232452324623247232482324923250232512325223253232542325523256232572325823259232602326123262232632326423265232662326723268232692327023271232722327323274232752327623277232782327923280232812328223283232842328523286232872328823289232902329123292232932329423295232962329723298232992330023301233022330323304233052330623307233082330923310233112331223313233142331523316233172331823319233202332123322233232332423325233262332723328233292333023331233322333323334233352333623337233382333923340233412334223343233442334523346233472334823349233502335123352233532335423355233562335723358233592336023361233622336323364233652336623367233682336923370233712337223373233742337523376233772337823379233802338123382233832338423385233862338723388233892339023391233922339323394233952339623397233982339923400234012340223403234042340523406234072340823409234102341123412234132341423415234162341723418234192342023421234222342323424234252342623427234282342923430234312343223433234342343523436234372343823439234402344123442234432344423445234462344723448234492345023451234522345323454234552345623457234582345923460234612346223463234642346523466234672346823469234702347123472234732347423475234762347723478234792348023481234822348323484234852348623487234882348923490234912349223493234942349523496234972349823499235002350123502235032350423505235062350723508235092351023511235122351323514235152351623517235182351923520235212352223523235242352523526235272352823529235302353123532235332353423535235362353723538235392354023541235422354323544235452354623547235482354923550235512355223553235542355523556235572355823559235602356123562235632356423565235662356723568235692357023571235722357323574235752357623577235782357923580235812358223583235842358523586235872358823589235902359123592235932359423595235962359723598235992360023601236022360323604236052360623607236082360923610236112361223613236142361523616236172361823619236202362123622236232362423625236262362723628236292363023631236322363323634236352363623637236382363923640236412364223643236442364523646236472364823649236502365123652236532365423655236562365723658236592366023661236622366323664236652366623667236682366923670236712367223673236742367523676236772367823679236802368123682236832368423685236862368723688236892369023691236922369323694236952369623697236982369923700237012370223703237042370523706237072370823709237102371123712237132371423715237162371723718237192372023721237222372323724237252372623727237282372923730237312373223733237342373523736237372373823739237402374123742237432374423745237462374723748237492375023751237522375323754237552375623757237582375923760237612376223763237642376523766237672376823769237702377123772237732377423775237762377723778237792378023781237822378323784237852378623787237882378923790237912379223793237942379523796237972379823799238002380123802238032380423805238062380723808238092381023811238122381323814238152381623817238182381923820238212382223823238242382523826238272382823829238302383123832238332383423835238362383723838238392384023841238422384323844238452384623847238482384923850238512385223853238542385523856238572385823859238602386123862238632386423865238662386723868238692387023871238722387323874238752387623877238782387923880238812388223883238842388523886238872388823889238902389123892238932389423895238962389723898238992390023901239022390323904239052390623907239082390923910239112391223913239142391523916239172391823919239202392123922239232392423925239262392723928239292393023931239322393323934239352393623937239382393923940239412394223943239442394523946239472394823949239502395123952239532395423955239562395723958239592396023961239622396323964239652396623967239682396923970239712397223973239742397523976239772397823979239802398123982239832398423985239862398723988239892399023991239922399323994239952399623997239982399924000240012400224003240042400524006240072400824009240102401124012240132401424015240162401724018240192402024021240222402324024240252402624027240282402924030240312403224033240342403524036240372403824039240402404124042240432404424045240462404724048240492405024051240522405324054240552405624057240582405924060240612406224063240642406524066240672406824069240702407124072240732407424075240762407724078240792408024081240822408324084240852408624087240882408924090240912409224093240942409524096240972409824099241002410124102241032410424105241062410724108241092411024111241122411324114241152411624117241182411924120241212412224123241242412524126241272412824129241302413124132241332413424135241362413724138241392414024141241422414324144241452414624147241482414924150241512415224153241542415524156241572415824159241602416124162241632416424165241662416724168241692417024171241722417324174241752417624177241782417924180241812418224183241842418524186241872418824189241902419124192241932419424195241962419724198241992420024201242022420324204242052420624207242082420924210242112421224213242142421524216242172421824219242202422124222242232422424225242262422724228242292423024231242322423324234242352423624237242382423924240242412424224243242442424524246242472424824249242502425124252242532425424255242562425724258242592426024261242622426324264242652426624267242682426924270242712427224273242742427524276242772427824279242802428124282242832428424285242862428724288242892429024291242922429324294242952429624297242982429924300243012430224303243042430524306243072430824309243102431124312243132431424315243162431724318243192432024321243222432324324243252432624327243282432924330243312433224333243342433524336243372433824339243402434124342243432434424345243462434724348243492435024351243522435324354243552435624357243582435924360243612436224363243642436524366243672436824369243702437124372243732437424375243762437724378243792438024381243822438324384243852438624387243882438924390243912439224393243942439524396243972439824399244002440124402244032440424405244062440724408244092441024411244122441324414244152441624417244182441924420244212442224423244242442524426244272442824429244302443124432244332443424435244362443724438244392444024441244422444324444244452444624447244482444924450244512445224453244542445524456244572445824459244602446124462244632446424465244662446724468244692447024471244722447324474244752447624477244782447924480244812448224483244842448524486244872448824489244902449124492244932449424495244962449724498244992450024501245022450324504245052450624507245082450924510245112451224513245142451524516245172451824519245202452124522245232452424525245262452724528245292453024531245322453324534245352453624537245382453924540245412454224543245442454524546245472454824549245502455124552245532455424555245562455724558245592456024561245622456324564245652456624567245682456924570245712457224573245742457524576245772457824579245802458124582245832458424585245862458724588245892459024591245922459324594245952459624597245982459924600246012460224603246042460524606246072460824609246102461124612246132461424615246162461724618246192462024621246222462324624246252462624627246282462924630246312463224633246342463524636246372463824639246402464124642246432464424645246462464724648246492465024651246522465324654246552465624657246582465924660246612466224663246642466524666246672466824669246702467124672246732467424675246762467724678246792468024681246822468324684246852468624687246882468924690246912469224693246942469524696246972469824699247002470124702247032470424705247062470724708247092471024711247122471324714247152471624717247182471924720247212472224723247242472524726247272472824729247302473124732247332473424735247362473724738247392474024741247422474324744247452474624747247482474924750247512475224753247542475524756247572475824759247602476124762247632476424765247662476724768247692477024771247722477324774247752477624777247782477924780247812478224783247842478524786247872478824789247902479124792247932479424795247962479724798247992480024801248022480324804248052480624807248082480924810248112481224813248142481524816248172481824819248202482124822248232482424825248262482724828248292483024831248322483324834248352483624837248382483924840248412484224843248442484524846248472484824849248502485124852248532485424855248562485724858248592486024861248622486324864248652486624867248682486924870248712487224873248742487524876248772487824879248802488124882248832488424885248862488724888248892489024891248922489324894248952489624897248982489924900249012490224903249042490524906249072490824909249102491124912249132491424915249162491724918249192492024921249222492324924249252492624927249282492924930249312493224933249342493524936249372493824939249402494124942249432494424945249462494724948249492495024951249522495324954249552495624957249582495924960249612496224963249642496524966249672496824969249702497124972249732497424975249762497724978249792498024981249822498324984249852498624987249882498924990249912499224993249942499524996249972499824999250002500125002250032500425005250062500725008250092501025011250122501325014250152501625017250182501925020250212502225023250242502525026250272502825029250302503125032250332503425035250362503725038250392504025041250422504325044250452504625047250482504925050250512505225053250542505525056250572505825059250602506125062250632506425065250662506725068250692507025071250722507325074250752507625077250782507925080250812508225083250842508525086250872508825089250902509125092250932509425095250962509725098250992510025101251022510325104251052510625107251082510925110251112511225113251142511525116251172511825119251202512125122251232512425125251262512725128251292513025131251322513325134251352513625137251382513925140251412514225143251442514525146251472514825149251502515125152251532515425155251562515725158251592516025161251622516325164251652516625167251682516925170251712517225173251742517525176251772517825179251802518125182251832518425185251862518725188251892519025191251922519325194251952519625197251982519925200252012520225203252042520525206252072520825209252102521125212252132521425215252162521725218252192522025221252222522325224252252522625227252282522925230252312523225233252342523525236252372523825239252402524125242252432524425245252462524725248252492525025251252522525325254252552525625257252582525925260252612526225263252642526525266252672526825269252702527125272252732527425275252762527725278252792528025281252822528325284252852528625287252882528925290252912529225293252942529525296252972529825299253002530125302253032530425305253062530725308253092531025311253122531325314253152531625317253182531925320253212532225323253242532525326253272532825329253302533125332253332533425335253362533725338253392534025341253422534325344253452534625347253482534925350253512535225353253542535525356253572535825359253602536125362253632536425365253662536725368253692537025371253722537325374253752537625377253782537925380253812538225383253842538525386253872538825389253902539125392253932539425395253962539725398253992540025401254022540325404254052540625407254082540925410254112541225413254142541525416254172541825419254202542125422254232542425425254262542725428254292543025431254322543325434254352543625437254382543925440254412544225443254442544525446254472544825449254502545125452254532545425455254562545725458254592546025461254622546325464254652546625467254682546925470254712547225473254742547525476254772547825479254802548125482254832548425485254862548725488254892549025491254922549325494254952549625497254982549925500255012550225503255042550525506255072550825509255102551125512255132551425515255162551725518255192552025521255222552325524255252552625527255282552925530255312553225533255342553525536255372553825539255402554125542255432554425545255462554725548255492555025551255522555325554255552555625557255582555925560255612556225563255642556525566255672556825569255702557125572255732557425575255762557725578255792558025581255822558325584255852558625587255882558925590255912559225593255942559525596255972559825599256002560125602256032560425605256062560725608256092561025611256122561325614256152561625617256182561925620256212562225623256242562525626256272562825629256302563125632256332563425635256362563725638256392564025641256422564325644256452564625647256482564925650256512565225653256542565525656256572565825659256602566125662256632566425665256662566725668256692567025671256722567325674256752567625677256782567925680256812568225683256842568525686256872568825689256902569125692256932569425695256962569725698256992570025701257022570325704257052570625707257082570925710257112571225713257142571525716257172571825719257202572125722257232572425725257262572725728257292573025731257322573325734257352573625737257382573925740257412574225743257442574525746257472574825749257502575125752257532575425755257562575725758257592576025761257622576325764257652576625767257682576925770257712577225773257742577525776257772577825779257802578125782257832578425785257862578725788257892579025791257922579325794257952579625797257982579925800258012580225803258042580525806258072580825809258102581125812258132581425815258162581725818258192582025821258222582325824258252582625827258282582925830258312583225833258342583525836258372583825839258402584125842258432584425845258462584725848258492585025851258522585325854258552585625857258582585925860258612586225863258642586525866258672586825869258702587125872258732587425875258762587725878258792588025881258822588325884258852588625887258882588925890258912589225893258942589525896258972589825899259002590125902259032590425905259062590725908259092591025911259122591325914259152591625917259182591925920259212592225923259242592525926259272592825929259302593125932259332593425935259362593725938259392594025941259422594325944259452594625947259482594925950259512595225953259542595525956259572595825959259602596125962259632596425965259662596725968259692597025971259722597325974259752597625977259782597925980259812598225983259842598525986259872598825989259902599125992259932599425995259962599725998259992600026001260022600326004260052600626007260082600926010260112601226013260142601526016260172601826019260202602126022260232602426025260262602726028260292603026031260322603326034260352603626037260382603926040260412604226043260442604526046260472604826049260502605126052260532605426055260562605726058260592606026061260622606326064260652606626067260682606926070260712607226073260742607526076260772607826079260802608126082260832608426085260862608726088260892609026091260922609326094260952609626097260982609926100261012610226103261042610526106261072610826109261102611126112261132611426115261162611726118261192612026121261222612326124261252612626127261282612926130261312613226133261342613526136261372613826139261402614126142261432614426145261462614726148261492615026151261522615326154261552615626157261582615926160261612616226163261642616526166261672616826169261702617126172261732617426175261762617726178261792618026181261822618326184261852618626187261882618926190261912619226193261942619526196261972619826199262002620126202262032620426205262062620726208262092621026211262122621326214262152621626217262182621926220262212622226223262242622526226262272622826229262302623126232262332623426235262362623726238262392624026241262422624326244262452624626247262482624926250262512625226253262542625526256262572625826259262602626126262262632626426265262662626726268262692627026271262722627326274262752627626277262782627926280262812628226283262842628526286262872628826289262902629126292262932629426295262962629726298262992630026301263022630326304263052630626307263082630926310263112631226313263142631526316263172631826319263202632126322263232632426325263262632726328263292633026331263322633326334263352633626337263382633926340263412634226343263442634526346263472634826349263502635126352263532635426355263562635726358263592636026361263622636326364263652636626367263682636926370263712637226373263742637526376263772637826379263802638126382263832638426385263862638726388263892639026391263922639326394263952639626397263982639926400264012640226403264042640526406264072640826409264102641126412264132641426415264162641726418264192642026421264222642326424264252642626427264282642926430264312643226433264342643526436264372643826439264402644126442264432644426445264462644726448264492645026451264522645326454264552645626457264582645926460264612646226463264642646526466264672646826469264702647126472264732647426475264762647726478264792648026481264822648326484264852648626487264882648926490264912649226493264942649526496264972649826499265002650126502265032650426505265062650726508265092651026511265122651326514265152651626517265182651926520265212652226523265242652526526265272652826529265302653126532265332653426535265362653726538265392654026541265422654326544265452654626547265482654926550265512655226553265542655526556265572655826559265602656126562265632656426565265662656726568265692657026571265722657326574265752657626577265782657926580265812658226583265842658526586265872658826589265902659126592265932659426595265962659726598265992660026601266022660326604266052660626607266082660926610266112661226613266142661526616266172661826619266202662126622266232662426625266262662726628266292663026631266322663326634266352663626637266382663926640266412664226643266442664526646266472664826649266502665126652266532665426655266562665726658266592666026661266622666326664266652666626667266682666926670266712667226673266742667526676266772667826679266802668126682266832668426685266862668726688266892669026691266922669326694266952669626697266982669926700267012670226703267042670526706267072670826709267102671126712267132671426715267162671726718267192672026721267222672326724267252672626727267282672926730267312673226733267342673526736267372673826739267402674126742267432674426745267462674726748267492675026751267522675326754267552675626757267582675926760267612676226763267642676526766267672676826769267702677126772267732677426775267762677726778267792678026781267822678326784267852678626787267882678926790267912679226793267942679526796267972679826799268002680126802268032680426805268062680726808268092681026811268122681326814268152681626817268182681926820268212682226823268242682526826268272682826829268302683126832268332683426835268362683726838268392684026841268422684326844268452684626847268482684926850268512685226853268542685526856268572685826859268602686126862268632686426865268662686726868268692687026871268722687326874268752687626877268782687926880268812688226883268842688526886268872688826889268902689126892268932689426895268962689726898268992690026901269022690326904269052690626907269082690926910269112691226913269142691526916269172691826919269202692126922269232692426925269262692726928269292693026931269322693326934269352693626937269382693926940269412694226943269442694526946269472694826949269502695126952269532695426955269562695726958269592696026961269622696326964269652696626967269682696926970269712697226973269742697526976269772697826979269802698126982269832698426985269862698726988269892699026991269922699326994269952699626997269982699927000270012700227003270042700527006270072700827009270102701127012270132701427015270162701727018270192702027021270222702327024270252702627027270282702927030270312703227033270342703527036270372703827039270402704127042270432704427045270462704727048270492705027051270522705327054270552705627057270582705927060270612706227063270642706527066270672706827069270702707127072270732707427075270762707727078270792708027081270822708327084270852708627087270882708927090270912709227093270942709527096270972709827099271002710127102271032710427105271062710727108271092711027111271122711327114271152711627117271182711927120271212712227123271242712527126271272712827129271302713127132271332713427135271362713727138271392714027141271422714327144271452714627147271482714927150271512715227153271542715527156271572715827159271602716127162271632716427165271662716727168271692717027171271722717327174271752717627177271782717927180271812718227183271842718527186271872718827189271902719127192271932719427195271962719727198271992720027201272022720327204272052720627207272082720927210272112721227213272142721527216272172721827219272202722127222272232722427225272262722727228272292723027231272322723327234272352723627237272382723927240272412724227243272442724527246272472724827249272502725127252272532725427255272562725727258272592726027261272622726327264272652726627267272682726927270272712727227273272742727527276272772727827279272802728127282272832728427285272862728727288272892729027291272922729327294272952729627297272982729927300273012730227303273042730527306273072730827309273102731127312273132731427315273162731727318273192732027321273222732327324273252732627327273282732927330273312733227333273342733527336273372733827339273402734127342273432734427345273462734727348273492735027351273522735327354273552735627357273582735927360273612736227363273642736527366273672736827369273702737127372273732737427375273762737727378273792738027381273822738327384273852738627387273882738927390273912739227393273942739527396273972739827399274002740127402274032740427405274062740727408274092741027411274122741327414274152741627417274182741927420274212742227423274242742527426274272742827429274302743127432274332743427435274362743727438274392744027441274422744327444274452744627447274482744927450274512745227453274542745527456274572745827459274602746127462274632746427465274662746727468274692747027471274722747327474274752747627477274782747927480274812748227483274842748527486274872748827489274902749127492274932749427495274962749727498274992750027501275022750327504275052750627507275082750927510275112751227513275142751527516275172751827519275202752127522275232752427525275262752727528275292753027531275322753327534275352753627537275382753927540275412754227543275442754527546275472754827549275502755127552275532755427555275562755727558275592756027561275622756327564275652756627567275682756927570275712757227573275742757527576275772757827579275802758127582275832758427585275862758727588275892759027591275922759327594275952759627597275982759927600276012760227603276042760527606276072760827609276102761127612276132761427615276162761727618276192762027621276222762327624276252762627627276282762927630276312763227633276342763527636276372763827639276402764127642276432764427645276462764727648276492765027651276522765327654276552765627657276582765927660276612766227663276642766527666276672766827669276702767127672276732767427675276762767727678276792768027681276822768327684276852768627687276882768927690276912769227693276942769527696276972769827699277002770127702277032770427705277062770727708277092771027711277122771327714277152771627717277182771927720277212772227723277242772527726277272772827729277302773127732277332773427735277362773727738277392774027741277422774327744277452774627747277482774927750277512775227753277542775527756277572775827759277602776127762277632776427765277662776727768277692777027771277722777327774277752777627777277782777927780277812778227783277842778527786277872778827789277902779127792277932779427795277962779727798277992780027801278022780327804278052780627807278082780927810278112781227813278142781527816278172781827819278202782127822278232782427825278262782727828278292783027831278322783327834278352783627837278382783927840278412784227843278442784527846278472784827849278502785127852278532785427855278562785727858278592786027861278622786327864278652786627867278682786927870278712787227873278742787527876278772787827879278802788127882278832788427885278862788727888278892789027891278922789327894278952789627897278982789927900279012790227903279042790527906279072790827909279102791127912279132791427915279162791727918279192792027921279222792327924279252792627927279282792927930279312793227933279342793527936279372793827939279402794127942279432794427945279462794727948279492795027951279522795327954279552795627957279582795927960279612796227963279642796527966279672796827969279702797127972279732797427975279762797727978279792798027981279822798327984279852798627987279882798927990279912799227993279942799527996279972799827999280002800128002280032800428005280062800728008280092801028011280122801328014280152801628017280182801928020280212802228023280242802528026280272802828029280302803128032280332803428035280362803728038280392804028041280422804328044280452804628047280482804928050280512805228053280542805528056280572805828059280602806128062280632806428065280662806728068280692807028071280722807328074280752807628077280782807928080280812808228083280842808528086280872808828089280902809128092280932809428095280962809728098280992810028101281022810328104281052810628107281082810928110281112811228113281142811528116281172811828119281202812128122281232812428125281262812728128281292813028131281322813328134281352813628137281382813928140281412814228143281442814528146281472814828149281502815128152281532815428155281562815728158281592816028161281622816328164281652816628167281682816928170281712817228173281742817528176281772817828179281802818128182281832818428185281862818728188281892819028191281922819328194281952819628197281982819928200282012820228203282042820528206282072820828209282102821128212282132821428215282162821728218282192822028221282222822328224282252822628227282282822928230282312823228233282342823528236282372823828239282402824128242282432824428245282462824728248282492825028251282522825328254282552825628257282582825928260282612826228263282642826528266282672826828269282702827128272282732827428275282762827728278282792828028281282822828328284282852828628287282882828928290282912829228293282942829528296282972829828299283002830128302283032830428305283062830728308283092831028311283122831328314283152831628317283182831928320283212832228323283242832528326283272832828329283302833128332283332833428335283362833728338283392834028341283422834328344283452834628347283482834928350283512835228353283542835528356283572835828359283602836128362283632836428365283662836728368283692837028371283722837328374283752837628377283782837928380283812838228383283842838528386283872838828389283902839128392283932839428395283962839728398283992840028401284022840328404284052840628407284082840928410284112841228413284142841528416284172841828419284202842128422284232842428425284262842728428284292843028431284322843328434284352843628437284382843928440284412844228443284442844528446284472844828449284502845128452284532845428455284562845728458284592846028461284622846328464284652846628467284682846928470284712847228473284742847528476284772847828479284802848128482284832848428485284862848728488284892849028491284922849328494284952849628497284982849928500285012850228503285042850528506285072850828509285102851128512285132851428515285162851728518285192852028521285222852328524285252852628527285282852928530285312853228533285342853528536285372853828539285402854128542285432854428545285462854728548285492855028551285522855328554285552855628557285582855928560285612856228563285642856528566285672856828569285702857128572285732857428575285762857728578285792858028581285822858328584285852858628587285882858928590285912859228593285942859528596285972859828599286002860128602286032860428605286062860728608286092861028611286122861328614286152861628617286182861928620286212862228623286242862528626286272862828629286302863128632286332863428635286362863728638286392864028641286422864328644286452864628647286482864928650286512865228653286542865528656286572865828659286602866128662286632866428665286662866728668286692867028671286722867328674286752867628677286782867928680286812868228683286842868528686286872868828689286902869128692286932869428695286962869728698286992870028701287022870328704287052870628707287082870928710287112871228713287142871528716287172871828719287202872128722287232872428725287262872728728287292873028731287322873328734287352873628737287382873928740287412874228743287442874528746287472874828749287502875128752287532875428755287562875728758287592876028761287622876328764287652876628767287682876928770287712877228773287742877528776287772877828779287802878128782287832878428785287862878728788287892879028791287922879328794287952879628797287982879928800288012880228803288042880528806288072880828809288102881128812288132881428815288162881728818288192882028821288222882328824288252882628827288282882928830288312883228833288342883528836288372883828839288402884128842288432884428845288462884728848288492885028851288522885328854288552885628857288582885928860288612886228863288642886528866288672886828869288702887128872288732887428875288762887728878288792888028881288822888328884288852888628887288882888928890288912889228893288942889528896288972889828899289002890128902289032890428905289062890728908289092891028911289122891328914289152891628917289182891928920289212892228923289242892528926289272892828929289302893128932289332893428935289362893728938289392894028941289422894328944289452894628947289482894928950289512895228953289542895528956289572895828959289602896128962289632896428965289662896728968289692897028971289722897328974289752897628977289782897928980289812898228983289842898528986289872898828989289902899128992289932899428995289962899728998289992900029001290022900329004290052900629007290082900929010290112901229013290142901529016290172901829019290202902129022290232902429025290262902729028290292903029031290322903329034290352903629037290382903929040290412904229043290442904529046290472904829049290502905129052290532905429055290562905729058290592906029061290622906329064290652906629067290682906929070290712907229073290742907529076290772907829079290802908129082290832908429085290862908729088290892909029091290922909329094290952909629097290982909929100291012910229103291042910529106291072910829109291102911129112291132911429115291162911729118291192912029121291222912329124291252912629127291282912929130291312913229133291342913529136291372913829139291402914129142291432914429145291462914729148291492915029151291522915329154291552915629157291582915929160291612916229163291642916529166291672916829169291702917129172291732917429175291762917729178291792918029181291822918329184291852918629187291882918929190291912919229193291942919529196291972919829199292002920129202292032920429205292062920729208292092921029211292122921329214292152921629217292182921929220292212922229223292242922529226292272922829229292302923129232292332923429235292362923729238292392924029241292422924329244292452924629247292482924929250292512925229253292542925529256292572925829259292602926129262292632926429265292662926729268292692927029271292722927329274292752927629277292782927929280292812928229283292842928529286292872928829289292902929129292292932929429295292962929729298292992930029301293022930329304293052930629307293082930929310293112931229313293142931529316293172931829319293202932129322293232932429325293262932729328293292933029331293322933329334293352933629337293382933929340293412934229343293442934529346293472934829349293502935129352293532935429355293562935729358293592936029361293622936329364293652936629367293682936929370293712937229373293742937529376293772937829379293802938129382293832938429385293862938729388293892939029391293922939329394293952939629397293982939929400294012940229403294042940529406294072940829409294102941129412294132941429415294162941729418294192942029421294222942329424294252942629427294282942929430294312943229433294342943529436294372943829439294402944129442294432944429445294462944729448294492945029451294522945329454294552945629457294582945929460294612946229463294642946529466294672946829469294702947129472294732947429475294762947729478294792948029481294822948329484294852948629487294882948929490294912949229493294942949529496294972949829499295002950129502295032950429505295062950729508295092951029511295122951329514295152951629517295182951929520295212952229523295242952529526295272952829529295302953129532295332953429535295362953729538295392954029541295422954329544295452954629547295482954929550295512955229553295542955529556295572955829559295602956129562295632956429565295662956729568295692957029571295722957329574295752957629577295782957929580295812958229583295842958529586295872958829589295902959129592295932959429595295962959729598295992960029601296022960329604296052960629607296082960929610296112961229613296142961529616296172961829619296202962129622296232962429625296262962729628296292963029631296322963329634296352963629637296382963929640296412964229643296442964529646296472964829649296502965129652296532965429655296562965729658296592966029661296622966329664296652966629667296682966929670296712967229673296742967529676296772967829679296802968129682296832968429685296862968729688296892969029691296922969329694296952969629697296982969929700297012970229703297042970529706297072970829709297102971129712297132971429715297162971729718297192972029721297222972329724297252972629727297282972929730297312973229733297342973529736297372973829739297402974129742297432974429745297462974729748297492975029751297522975329754297552975629757297582975929760297612976229763297642976529766297672976829769297702977129772297732977429775297762977729778297792978029781297822978329784297852978629787297882978929790297912979229793297942979529796297972979829799298002980129802298032980429805298062980729808298092981029811298122981329814298152981629817298182981929820298212982229823298242982529826298272982829829298302983129832298332983429835298362983729838298392984029841298422984329844298452984629847298482984929850298512985229853298542985529856298572985829859298602986129862298632986429865298662986729868298692987029871298722987329874298752987629877298782987929880298812988229883298842988529886298872988829889298902989129892298932989429895298962989729898298992990029901299022990329904299052990629907299082990929910299112991229913299142991529916299172991829919299202992129922299232992429925299262992729928299292993029931299322993329934299352993629937299382993929940299412994229943299442994529946299472994829949299502995129952299532995429955299562995729958299592996029961299622996329964299652996629967299682996929970299712997229973299742997529976299772997829979299802998129982299832998429985299862998729988299892999029991299922999329994299952999629997299982999930000300013000230003300043000530006300073000830009300103001130012300133001430015300163001730018300193002030021300223002330024300253002630027300283002930030300313003230033300343003530036300373003830039300403004130042300433004430045300463004730048300493005030051300523005330054300553005630057300583005930060300613006230063300643006530066300673006830069300703007130072300733007430075300763007730078300793008030081300823008330084300853008630087300883008930090300913009230093300943009530096300973009830099301003010130102301033010430105301063010730108301093011030111301123011330114301153011630117301183011930120301213012230123301243012530126301273012830129301303013130132301333013430135301363013730138301393014030141301423014330144301453014630147301483014930150301513015230153301543015530156301573015830159301603016130162301633016430165301663016730168301693017030171301723017330174301753017630177301783017930180301813018230183301843018530186301873018830189301903019130192301933019430195301963019730198301993020030201302023020330204302053020630207302083020930210302113021230213302143021530216302173021830219302203022130222302233022430225302263022730228302293023030231302323023330234302353023630237302383023930240302413024230243302443024530246302473024830249302503025130252302533025430255302563025730258302593026030261302623026330264302653026630267302683026930270302713027230273302743027530276302773027830279302803028130282302833028430285302863028730288302893029030291302923029330294302953029630297302983029930300303013030230303303043030530306303073030830309303103031130312303133031430315303163031730318303193032030321303223032330324303253032630327303283032930330303313033230333303343033530336303373033830339303403034130342303433034430345303463034730348303493035030351303523035330354303553035630357303583035930360303613036230363303643036530366303673036830369303703037130372303733037430375303763037730378303793038030381303823038330384303853038630387303883038930390303913039230393303943039530396303973039830399304003040130402304033040430405304063040730408304093041030411304123041330414304153041630417304183041930420304213042230423304243042530426304273042830429304303043130432304333043430435304363043730438304393044030441304423044330444304453044630447304483044930450304513045230453304543045530456304573045830459304603046130462304633046430465304663046730468304693047030471304723047330474304753047630477304783047930480304813048230483304843048530486304873048830489304903049130492304933049430495304963049730498304993050030501305023050330504305053050630507305083050930510305113051230513305143051530516305173051830519305203052130522305233052430525305263052730528305293053030531305323053330534305353053630537305383053930540305413054230543305443054530546305473054830549305503055130552305533055430555305563055730558305593056030561305623056330564305653056630567305683056930570305713057230573305743057530576305773057830579305803058130582305833058430585305863058730588305893059030591305923059330594305953059630597305983059930600306013060230603306043060530606306073060830609306103061130612306133061430615306163061730618306193062030621306223062330624306253062630627306283062930630306313063230633306343063530636306373063830639306403064130642306433064430645306463064730648306493065030651306523065330654306553065630657306583065930660306613066230663306643066530666306673066830669306703067130672306733067430675306763067730678306793068030681306823068330684306853068630687306883068930690306913069230693306943069530696306973069830699307003070130702307033070430705307063070730708307093071030711307123071330714307153071630717307183071930720307213072230723307243072530726307273072830729307303073130732307333073430735307363073730738307393074030741307423074330744307453074630747307483074930750307513075230753307543075530756307573075830759307603076130762307633076430765307663076730768307693077030771307723077330774307753077630777307783077930780307813078230783307843078530786307873078830789307903079130792307933079430795307963079730798307993080030801308023080330804308053080630807308083080930810308113081230813308143081530816308173081830819308203082130822308233082430825308263082730828308293083030831308323083330834308353083630837308383083930840308413084230843308443084530846308473084830849308503085130852308533085430855308563085730858308593086030861308623086330864308653086630867308683086930870308713087230873308743087530876308773087830879308803088130882308833088430885308863088730888308893089030891308923089330894308953089630897308983089930900309013090230903309043090530906309073090830909309103091130912309133091430915309163091730918309193092030921309223092330924309253092630927309283092930930309313093230933309343093530936309373093830939309403094130942309433094430945309463094730948309493095030951309523095330954309553095630957309583095930960309613096230963309643096530966309673096830969309703097130972309733097430975309763097730978309793098030981309823098330984309853098630987309883098930990309913099230993309943099530996309973099830999310003100131002310033100431005310063100731008310093101031011310123101331014310153101631017310183101931020310213102231023310243102531026310273102831029310303103131032310333103431035310363103731038310393104031041310423104331044310453104631047310483104931050310513105231053310543105531056310573105831059310603106131062310633106431065310663106731068310693107031071310723107331074310753107631077310783107931080310813108231083310843108531086310873108831089310903109131092310933109431095310963109731098310993110031101311023110331104311053110631107311083110931110311113111231113311143111531116311173111831119311203112131122311233112431125311263112731128311293113031131311323113331134311353113631137311383113931140311413114231143311443114531146311473114831149311503115131152311533115431155311563115731158311593116031161311623116331164311653116631167311683116931170311713117231173311743117531176311773117831179311803118131182311833118431185311863118731188311893119031191311923119331194311953119631197311983119931200312013120231203312043120531206312073120831209312103121131212312133121431215312163121731218312193122031221312223122331224312253122631227312283122931230312313123231233312343123531236312373123831239312403124131242312433124431245312463124731248312493125031251312523125331254312553125631257312583125931260312613126231263312643126531266312673126831269312703127131272312733127431275312763127731278312793128031281312823128331284312853128631287312883128931290312913129231293312943129531296312973129831299313003130131302313033130431305313063130731308313093131031311313123131331314313153131631317313183131931320313213132231323313243132531326313273132831329313303133131332313333133431335313363133731338313393134031341313423134331344313453134631347313483134931350313513135231353313543135531356313573135831359313603136131362313633136431365313663136731368313693137031371313723137331374313753137631377313783137931380313813138231383313843138531386313873138831389313903139131392313933139431395313963139731398313993140031401314023140331404314053140631407314083140931410314113141231413314143141531416314173141831419314203142131422314233142431425314263142731428314293143031431314323143331434314353143631437314383143931440314413144231443314443144531446314473144831449314503145131452314533145431455314563145731458314593146031461314623146331464314653146631467314683146931470314713147231473314743147531476314773147831479314803148131482314833148431485314863148731488314893149031491314923149331494314953149631497314983149931500315013150231503315043150531506315073150831509315103151131512315133151431515315163151731518315193152031521315223152331524315253152631527315283152931530315313153231533315343153531536315373153831539315403154131542315433154431545315463154731548315493155031551315523155331554315553155631557315583155931560315613156231563315643156531566315673156831569315703157131572315733157431575315763157731578315793158031581315823158331584315853158631587315883158931590315913159231593315943159531596315973159831599316003160131602316033160431605316063160731608316093161031611316123161331614316153161631617316183161931620316213162231623316243162531626316273162831629316303163131632316333163431635316363163731638316393164031641316423164331644316453164631647316483164931650316513165231653316543165531656316573165831659316603166131662316633166431665316663166731668316693167031671316723167331674316753167631677316783167931680316813168231683316843168531686316873168831689316903169131692316933169431695316963169731698316993170031701317023170331704317053170631707317083170931710317113171231713317143171531716317173171831719317203172131722317233172431725317263172731728317293173031731317323173331734317353173631737317383173931740317413174231743317443174531746317473174831749317503175131752317533175431755317563175731758317593176031761317623176331764317653176631767317683176931770317713177231773317743177531776317773177831779317803178131782317833178431785317863178731788317893179031791317923179331794317953179631797317983179931800318013180231803318043180531806318073180831809318103181131812318133181431815318163181731818318193182031821318223182331824318253182631827318283182931830318313183231833318343183531836318373183831839318403184131842318433184431845318463184731848318493185031851318523185331854318553185631857318583185931860318613186231863318643186531866318673186831869318703187131872318733187431875318763187731878318793188031881318823188331884318853188631887318883188931890318913189231893318943189531896318973189831899319003190131902319033190431905319063190731908319093191031911319123191331914319153191631917319183191931920319213192231923319243192531926319273192831929319303193131932319333193431935319363193731938319393194031941319423194331944319453194631947319483194931950319513195231953319543195531956319573195831959319603196131962319633196431965319663196731968319693197031971319723197331974319753197631977319783197931980319813198231983319843198531986319873198831989319903199131992319933199431995319963199731998319993200032001320023200332004320053200632007320083200932010320113201232013320143201532016320173201832019320203202132022320233202432025320263202732028320293203032031320323203332034320353203632037320383203932040320413204232043320443204532046320473204832049320503205132052320533205432055320563205732058320593206032061320623206332064320653206632067320683206932070320713207232073320743207532076320773207832079320803208132082320833208432085320863208732088320893209032091320923209332094320953209632097320983209932100321013210232103321043210532106321073210832109321103211132112321133211432115321163211732118321193212032121321223212332124321253212632127321283212932130321313213232133321343213532136321373213832139321403214132142321433214432145321463214732148321493215032151321523215332154321553215632157321583215932160321613216232163321643216532166321673216832169321703217132172321733217432175321763217732178321793218032181321823218332184321853218632187321883218932190321913219232193321943219532196321973219832199322003220132202322033220432205322063220732208322093221032211322123221332214322153221632217322183221932220322213222232223322243222532226322273222832229322303223132232322333223432235322363223732238322393224032241322423224332244322453224632247322483224932250322513225232253322543225532256322573225832259322603226132262322633226432265322663226732268322693227032271322723227332274322753227632277322783227932280322813228232283322843228532286322873228832289322903229132292322933229432295322963229732298322993230032301323023230332304323053230632307323083230932310323113231232313323143231532316323173231832319323203232132322323233232432325323263232732328323293233032331323323233332334323353233632337323383233932340323413234232343323443234532346323473234832349323503235132352323533235432355323563235732358323593236032361323623236332364323653236632367323683236932370323713237232373323743237532376323773237832379323803238132382323833238432385323863238732388323893239032391323923239332394323953239632397323983239932400324013240232403324043240532406324073240832409324103241132412324133241432415324163241732418324193242032421324223242332424324253242632427324283242932430324313243232433324343243532436324373243832439324403244132442324433244432445324463244732448324493245032451324523245332454324553245632457324583245932460324613246232463324643246532466324673246832469324703247132472324733247432475324763247732478324793248032481324823248332484324853248632487324883248932490324913249232493324943249532496324973249832499325003250132502325033250432505325063250732508325093251032511325123251332514325153251632517325183251932520325213252232523325243252532526325273252832529325303253132532325333253432535325363253732538325393254032541325423254332544325453254632547325483254932550325513255232553325543255532556325573255832559325603256132562325633256432565325663256732568325693257032571325723257332574325753257632577325783257932580325813258232583325843258532586325873258832589325903259132592325933259432595325963259732598325993260032601326023260332604326053260632607326083260932610326113261232613326143261532616326173261832619326203262132622326233262432625326263262732628326293263032631326323263332634326353263632637326383263932640326413264232643326443264532646326473264832649326503265132652326533265432655326563265732658326593266032661326623266332664326653266632667326683266932670326713267232673326743267532676326773267832679326803268132682326833268432685326863268732688326893269032691326923269332694326953269632697326983269932700327013270232703327043270532706327073270832709327103271132712327133271432715327163271732718327193272032721327223272332724327253272632727327283272932730327313273232733327343273532736327373273832739327403274132742327433274432745327463274732748327493275032751327523275332754327553275632757327583275932760327613276232763327643276532766327673276832769327703277132772327733277432775327763277732778327793278032781327823278332784327853278632787327883278932790327913279232793327943279532796327973279832799328003280132802328033280432805328063280732808328093281032811328123281332814328153281632817328183281932820328213282232823328243282532826328273282832829328303283132832328333283432835328363283732838328393284032841328423284332844328453284632847328483284932850328513285232853328543285532856328573285832859328603286132862328633286432865328663286732868328693287032871328723287332874328753287632877328783287932880328813288232883328843288532886328873288832889328903289132892328933289432895328963289732898328993290032901329023290332904329053290632907329083290932910329113291232913329143291532916329173291832919329203292132922329233292432925329263292732928329293293032931329323293332934329353293632937329383293932940329413294232943329443294532946329473294832949329503295132952329533295432955329563295732958329593296032961329623296332964329653296632967329683296932970329713297232973329743297532976329773297832979329803298132982329833298432985329863298732988329893299032991329923299332994329953299632997329983299933000330013300233003330043300533006330073300833009330103301133012330133301433015330163301733018330193302033021330223302333024330253302633027330283302933030330313303233033330343303533036330373303833039330403304133042330433304433045330463304733048330493305033051330523305333054330553305633057330583305933060330613306233063330643306533066330673306833069330703307133072330733307433075330763307733078330793308033081330823308333084330853308633087330883308933090330913309233093330943309533096330973309833099331003310133102331033310433105331063310733108331093311033111331123311333114331153311633117331183311933120331213312233123331243312533126331273312833129331303313133132331333313433135331363313733138331393314033141331423314333144331453314633147331483314933150331513315233153331543315533156331573315833159331603316133162331633316433165331663316733168331693317033171331723317333174331753317633177331783317933180331813318233183331843318533186331873318833189331903319133192331933319433195331963319733198331993320033201332023320333204332053320633207332083320933210332113321233213332143321533216332173321833219332203322133222332233322433225332263322733228332293323033231332323323333234332353323633237332383323933240332413324233243332443324533246332473324833249332503325133252332533325433255332563325733258332593326033261332623326333264332653326633267332683326933270332713327233273332743327533276332773327833279332803328133282332833328433285332863328733288332893329033291332923329333294332953329633297332983329933300333013330233303333043330533306333073330833309333103331133312333133331433315333163331733318333193332033321333223332333324333253332633327333283332933330333313333233333333343333533336333373333833339333403334133342333433334433345333463334733348333493335033351333523335333354333553335633357333583335933360333613336233363333643336533366333673336833369333703337133372333733337433375333763337733378333793338033381333823338333384333853338633387333883338933390333913339233393333943339533396333973339833399334003340133402334033340433405334063340733408334093341033411334123341333414334153341633417334183341933420334213342233423334243342533426334273342833429334303343133432334333343433435334363343733438334393344033441334423344333444334453344633447334483344933450334513345233453334543345533456334573345833459334603346133462334633346433465334663346733468334693347033471334723347333474334753347633477334783347933480334813348233483334843348533486334873348833489334903349133492334933349433495334963349733498334993350033501335023350333504335053350633507335083350933510335113351233513335143351533516335173351833519335203352133522335233352433525335263352733528335293353033531335323353333534335353353633537335383353933540335413354233543335443354533546335473354833549335503355133552335533355433555335563355733558335593356033561335623356333564335653356633567335683356933570335713357233573335743357533576335773357833579335803358133582335833358433585335863358733588335893359033591335923359333594335953359633597335983359933600336013360233603336043360533606336073360833609336103361133612336133361433615336163361733618336193362033621336223362333624336253362633627336283362933630336313363233633336343363533636336373363833639336403364133642336433364433645336463364733648336493365033651336523365333654336553365633657336583365933660336613366233663336643366533666336673366833669336703367133672336733367433675336763367733678336793368033681336823368333684336853368633687336883368933690336913369233693336943369533696336973369833699337003370133702337033370433705337063370733708337093371033711337123371333714337153371633717337183371933720337213372233723337243372533726337273372833729337303373133732337333373433735337363373733738337393374033741337423374333744337453374633747337483374933750337513375233753337543375533756337573375833759337603376133762337633376433765337663376733768337693377033771337723377333774337753377633777337783377933780337813378233783337843378533786337873378833789337903379133792337933379433795337963379733798337993380033801338023380333804338053380633807338083380933810338113381233813338143381533816338173381833819338203382133822338233382433825338263382733828338293383033831338323383333834338353383633837338383383933840338413384233843338443384533846338473384833849338503385133852338533385433855338563385733858338593386033861338623386333864338653386633867338683386933870338713387233873338743387533876338773387833879338803388133882338833388433885338863388733888338893389033891338923389333894338953389633897338983389933900339013390233903339043390533906339073390833909339103391133912339133391433915339163391733918339193392033921339223392333924339253392633927339283392933930339313393233933339343393533936339373393833939339403394133942339433394433945339463394733948339493395033951339523395333954339553395633957339583395933960339613396233963339643396533966339673396833969339703397133972339733397433975339763397733978339793398033981339823398333984339853398633987339883398933990339913399233993339943399533996339973399833999340003400134002340033400434005340063400734008340093401034011340123401334014340153401634017340183401934020340213402234023340243402534026340273402834029340303403134032340333403434035340363403734038340393404034041340423404334044340453404634047340483404934050340513405234053340543405534056340573405834059340603406134062340633406434065340663406734068340693407034071340723407334074340753407634077340783407934080340813408234083340843408534086340873408834089340903409134092340933409434095340963409734098340993410034101341023410334104341053410634107341083410934110341113411234113341143411534116341173411834119341203412134122341233412434125341263412734128341293413034131341323413334134341353413634137341383413934140341413414234143341443414534146341473414834149341503415134152341533415434155341563415734158341593416034161341623416334164341653416634167341683416934170341713417234173341743417534176341773417834179341803418134182341833418434185341863418734188341893419034191341923419334194341953419634197341983419934200342013420234203342043420534206342073420834209342103421134212342133421434215342163421734218342193422034221342223422334224342253422634227342283422934230342313423234233342343423534236342373423834239342403424134242342433424434245342463424734248342493425034251342523425334254342553425634257342583425934260342613426234263342643426534266342673426834269342703427134272342733427434275342763427734278342793428034281342823428334284342853428634287342883428934290342913429234293342943429534296342973429834299343003430134302343033430434305343063430734308343093431034311343123431334314343153431634317343183431934320343213432234323343243432534326343273432834329343303433134332343333433434335343363433734338343393434034341343423434334344343453434634347343483434934350343513435234353343543435534356343573435834359343603436134362343633436434365343663436734368343693437034371343723437334374343753437634377343783437934380343813438234383343843438534386343873438834389343903439134392343933439434395343963439734398343993440034401344023440334404344053440634407344083440934410344113441234413344143441534416344173441834419344203442134422344233442434425344263442734428344293443034431344323443334434344353443634437344383443934440344413444234443344443444534446344473444834449344503445134452344533445434455344563445734458344593446034461344623446334464344653446634467344683446934470344713447234473344743447534476344773447834479344803448134482344833448434485344863448734488344893449034491344923449334494344953449634497344983449934500345013450234503345043450534506345073450834509345103451134512345133451434515345163451734518345193452034521345223452334524345253452634527345283452934530345313453234533345343453534536345373453834539345403454134542345433454434545345463454734548345493455034551345523455334554345553455634557345583455934560345613456234563345643456534566345673456834569345703457134572345733457434575345763457734578345793458034581345823458334584345853458634587345883458934590345913459234593345943459534596345973459834599346003460134602346033460434605346063460734608346093461034611346123461334614346153461634617346183461934620346213462234623346243462534626346273462834629346303463134632346333463434635346363463734638346393464034641346423464334644346453464634647346483464934650346513465234653346543465534656346573465834659346603466134662346633466434665346663466734668346693467034671346723467334674346753467634677346783467934680346813468234683346843468534686346873468834689346903469134692346933469434695346963469734698346993470034701347023470334704347053470634707347083470934710347113471234713347143471534716347173471834719347203472134722347233472434725347263472734728347293473034731347323473334734347353473634737347383473934740347413474234743347443474534746347473474834749347503475134752347533475434755347563475734758347593476034761347623476334764347653476634767347683476934770347713477234773347743477534776347773477834779347803478134782347833478434785347863478734788347893479034791347923479334794347953479634797347983479934800348013480234803348043480534806348073480834809348103481134812348133481434815348163481734818348193482034821348223482334824348253482634827348283482934830348313483234833348343483534836348373483834839348403484134842348433484434845348463484734848348493485034851348523485334854348553485634857348583485934860348613486234863348643486534866348673486834869348703487134872348733487434875348763487734878348793488034881348823488334884348853488634887348883488934890348913489234893348943489534896348973489834899349003490134902349033490434905349063490734908349093491034911349123491334914349153491634917349183491934920349213492234923349243492534926349273492834929349303493134932349333493434935349363493734938349393494034941349423494334944349453494634947349483494934950349513495234953349543495534956349573495834959349603496134962349633496434965349663496734968349693497034971349723497334974349753497634977349783497934980349813498234983349843498534986349873498834989349903499134992349933499434995349963499734998349993500035001350023500335004350053500635007350083500935010350113501235013350143501535016350173501835019350203502135022350233502435025350263502735028350293503035031350323503335034350353503635037350383503935040350413504235043350443504535046350473504835049350503505135052350533505435055350563505735058350593506035061350623506335064350653506635067350683506935070350713507235073350743507535076350773507835079350803508135082350833508435085350863508735088350893509035091350923509335094350953509635097350983509935100351013510235103351043510535106351073510835109351103511135112351133511435115351163511735118351193512035121351223512335124351253512635127351283512935130351313513235133351343513535136351373513835139351403514135142351433514435145351463514735148351493515035151351523515335154351553515635157351583515935160351613516235163351643516535166351673516835169351703517135172351733517435175351763517735178351793518035181351823518335184351853518635187351883518935190351913519235193351943519535196351973519835199352003520135202352033520435205352063520735208352093521035211352123521335214352153521635217352183521935220352213522235223352243522535226352273522835229352303523135232352333523435235352363523735238352393524035241352423524335244352453524635247352483524935250352513525235253352543525535256352573525835259352603526135262352633526435265352663526735268352693527035271352723527335274352753527635277352783527935280352813528235283352843528535286352873528835289352903529135292352933529435295352963529735298352993530035301353023530335304353053530635307353083530935310353113531235313353143531535316353173531835319353203532135322353233532435325353263532735328353293533035331353323533335334353353533635337353383533935340353413534235343353443534535346353473534835349353503535135352353533535435355353563535735358353593536035361353623536335364353653536635367353683536935370353713537235373353743537535376353773537835379353803538135382353833538435385353863538735388353893539035391353923539335394353953539635397353983539935400354013540235403354043540535406354073540835409354103541135412354133541435415354163541735418354193542035421354223542335424354253542635427354283542935430354313543235433354343543535436354373543835439354403544135442354433544435445354463544735448354493545035451354523545335454354553545635457354583545935460354613546235463354643546535466354673546835469354703547135472354733547435475354763547735478354793548035481354823548335484354853548635487354883548935490354913549235493354943549535496354973549835499355003550135502355033550435505355063550735508355093551035511355123551335514355153551635517355183551935520355213552235523355243552535526355273552835529355303553135532355333553435535355363553735538355393554035541355423554335544355453554635547355483554935550355513555235553355543555535556355573555835559355603556135562355633556435565355663556735568355693557035571355723557335574355753557635577355783557935580355813558235583355843558535586355873558835589355903559135592355933559435595355963559735598355993560035601356023560335604356053560635607356083560935610356113561235613356143561535616356173561835619356203562135622356233562435625356263562735628356293563035631356323563335634356353563635637356383563935640356413564235643356443564535646356473564835649356503565135652356533565435655356563565735658356593566035661356623566335664356653566635667356683566935670356713567235673356743567535676356773567835679356803568135682356833568435685356863568735688356893569035691356923569335694356953569635697356983569935700357013570235703357043570535706357073570835709357103571135712357133571435715357163571735718357193572035721357223572335724357253572635727357283572935730357313573235733357343573535736357373573835739357403574135742357433574435745357463574735748357493575035751357523575335754357553575635757357583575935760357613576235763357643576535766357673576835769357703577135772357733577435775357763577735778357793578035781357823578335784357853578635787357883578935790357913579235793357943579535796357973579835799358003580135802358033580435805358063580735808358093581035811358123581335814358153581635817358183581935820358213582235823358243582535826358273582835829358303583135832358333583435835358363583735838358393584035841358423584335844358453584635847358483584935850358513585235853358543585535856358573585835859358603586135862358633586435865358663586735868358693587035871358723587335874358753587635877358783587935880358813588235883358843588535886358873588835889358903589135892358933589435895358963589735898358993590035901359023590335904359053590635907359083590935910359113591235913359143591535916359173591835919359203592135922359233592435925359263592735928359293593035931359323593335934359353593635937359383593935940359413594235943359443594535946359473594835949359503595135952359533595435955359563595735958359593596035961359623596335964359653596635967359683596935970359713597235973359743597535976359773597835979359803598135982359833598435985359863598735988359893599035991359923599335994359953599635997359983599936000360013600236003360043600536006360073600836009360103601136012360133601436015360163601736018360193602036021360223602336024360253602636027360283602936030360313603236033360343603536036360373603836039360403604136042360433604436045360463604736048360493605036051360523605336054360553605636057360583605936060360613606236063360643606536066360673606836069360703607136072360733607436075360763607736078360793608036081360823608336084360853608636087360883608936090360913609236093360943609536096360973609836099361003610136102361033610436105361063610736108361093611036111361123611336114361153611636117361183611936120361213612236123361243612536126361273612836129361303613136132361333613436135361363613736138361393614036141361423614336144361453614636147361483614936150361513615236153361543615536156361573615836159361603616136162361633616436165361663616736168361693617036171361723617336174361753617636177361783617936180361813618236183361843618536186361873618836189361903619136192361933619436195361963619736198361993620036201362023620336204362053620636207362083620936210362113621236213362143621536216362173621836219362203622136222362233622436225362263622736228362293623036231362323623336234362353623636237362383623936240362413624236243362443624536246362473624836249362503625136252362533625436255362563625736258362593626036261362623626336264362653626636267362683626936270362713627236273362743627536276362773627836279362803628136282362833628436285362863628736288362893629036291362923629336294362953629636297362983629936300363013630236303363043630536306363073630836309363103631136312363133631436315363163631736318363193632036321363223632336324363253632636327363283632936330363313633236333363343633536336363373633836339363403634136342363433634436345363463634736348363493635036351363523635336354363553635636357363583635936360363613636236363363643636536366363673636836369363703637136372363733637436375363763637736378363793638036381363823638336384363853638636387363883638936390363913639236393363943639536396363973639836399364003640136402364033640436405364063640736408364093641036411364123641336414364153641636417364183641936420364213642236423364243642536426364273642836429364303643136432364333643436435364363643736438364393644036441364423644336444364453644636447364483644936450364513645236453364543645536456364573645836459364603646136462364633646436465364663646736468364693647036471364723647336474364753647636477364783647936480364813648236483364843648536486364873648836489364903649136492364933649436495364963649736498364993650036501365023650336504365053650636507365083650936510365113651236513365143651536516365173651836519365203652136522365233652436525365263652736528365293653036531365323653336534365353653636537365383653936540365413654236543365443654536546365473654836549365503655136552365533655436555365563655736558365593656036561365623656336564365653656636567365683656936570365713657236573365743657536576365773657836579365803658136582365833658436585365863658736588365893659036591365923659336594365953659636597365983659936600366013660236603366043660536606366073660836609366103661136612366133661436615366163661736618366193662036621366223662336624366253662636627366283662936630366313663236633366343663536636366373663836639366403664136642366433664436645366463664736648366493665036651366523665336654366553665636657366583665936660366613666236663366643666536666366673666836669366703667136672366733667436675366763667736678366793668036681366823668336684366853668636687366883668936690366913669236693366943669536696366973669836699367003670136702367033670436705367063670736708367093671036711367123671336714367153671636717367183671936720367213672236723367243672536726367273672836729367303673136732367333673436735367363673736738367393674036741367423674336744367453674636747367483674936750367513675236753367543675536756367573675836759367603676136762367633676436765367663676736768367693677036771367723677336774367753677636777367783677936780367813678236783367843678536786367873678836789367903679136792367933679436795367963679736798367993680036801368023680336804368053680636807368083680936810368113681236813368143681536816368173681836819368203682136822368233682436825368263682736828368293683036831368323683336834368353683636837368383683936840368413684236843368443684536846368473684836849368503685136852368533685436855368563685736858368593686036861368623686336864368653686636867368683686936870368713687236873368743687536876368773687836879368803688136882368833688436885368863688736888368893689036891368923689336894368953689636897368983689936900369013690236903369043690536906369073690836909369103691136912369133691436915369163691736918369193692036921369223692336924369253692636927369283692936930369313693236933369343693536936369373693836939369403694136942369433694436945369463694736948369493695036951369523695336954369553695636957369583695936960369613696236963369643696536966369673696836969369703697136972369733697436975369763697736978369793698036981369823698336984369853698636987369883698936990369913699236993369943699536996369973699836999370003700137002370033700437005370063700737008370093701037011370123701337014370153701637017370183701937020370213702237023370243702537026370273702837029370303703137032370333703437035370363703737038370393704037041370423704337044370453704637047370483704937050370513705237053370543705537056370573705837059370603706137062370633706437065370663706737068370693707037071370723707337074370753707637077370783707937080370813708237083370843708537086370873708837089370903709137092370933709437095370963709737098370993710037101371023710337104371053710637107371083710937110371113711237113371143711537116371173711837119371203712137122371233712437125371263712737128371293713037131371323713337134371353713637137371383713937140371413714237143371443714537146371473714837149371503715137152371533715437155371563715737158371593716037161371623716337164371653716637167371683716937170371713717237173371743717537176371773717837179371803718137182371833718437185371863718737188371893719037191371923719337194371953719637197371983719937200372013720237203372043720537206372073720837209372103721137212372133721437215372163721737218372193722037221372223722337224372253722637227372283722937230372313723237233372343723537236372373723837239372403724137242372433724437245372463724737248372493725037251372523725337254372553725637257372583725937260372613726237263372643726537266372673726837269372703727137272372733727437275372763727737278372793728037281372823728337284372853728637287372883728937290372913729237293372943729537296372973729837299373003730137302373033730437305373063730737308373093731037311373123731337314373153731637317373183731937320373213732237323373243732537326373273732837329373303733137332373333733437335373363733737338373393734037341373423734337344373453734637347373483734937350373513735237353373543735537356373573735837359373603736137362373633736437365373663736737368373693737037371373723737337374373753737637377373783737937380373813738237383373843738537386373873738837389373903739137392373933739437395373963739737398373993740037401374023740337404374053740637407374083740937410374113741237413374143741537416374173741837419374203742137422374233742437425374263742737428374293743037431374323743337434374353743637437374383743937440374413744237443374443744537446374473744837449374503745137452374533745437455374563745737458374593746037461374623746337464374653746637467374683746937470374713747237473374743747537476374773747837479374803748137482374833748437485374863748737488374893749037491374923749337494374953749637497374983749937500375013750237503375043750537506375073750837509375103751137512375133751437515375163751737518375193752037521375223752337524375253752637527375283752937530375313753237533375343753537536375373753837539375403754137542375433754437545375463754737548375493755037551375523755337554375553755637557375583755937560375613756237563375643756537566375673756837569375703757137572375733757437575375763757737578375793758037581375823758337584375853758637587375883758937590375913759237593375943759537596375973759837599376003760137602376033760437605376063760737608376093761037611376123761337614376153761637617376183761937620376213762237623376243762537626376273762837629376303763137632376333763437635376363763737638376393764037641376423764337644376453764637647376483764937650376513765237653376543765537656376573765837659376603766137662376633766437665376663766737668376693767037671376723767337674376753767637677376783767937680376813768237683376843768537686376873768837689376903769137692376933769437695376963769737698376993770037701377023770337704377053770637707377083770937710377113771237713377143771537716377173771837719377203772137722377233772437725377263772737728377293773037731377323773337734377353773637737377383773937740377413774237743377443774537746377473774837749377503775137752377533775437755377563775737758377593776037761377623776337764377653776637767377683776937770377713777237773377743777537776377773777837779377803778137782377833778437785377863778737788377893779037791377923779337794377953779637797377983779937800378013780237803378043780537806378073780837809378103781137812378133781437815378163781737818378193782037821378223782337824378253782637827378283782937830378313783237833378343783537836378373783837839378403784137842378433784437845378463784737848378493785037851378523785337854378553785637857378583785937860378613786237863378643786537866378673786837869378703787137872378733787437875378763787737878378793788037881378823788337884378853788637887378883788937890378913789237893378943789537896378973789837899379003790137902379033790437905379063790737908379093791037911379123791337914379153791637917379183791937920379213792237923379243792537926379273792837929379303793137932379333793437935379363793737938379393794037941379423794337944379453794637947379483794937950379513795237953379543795537956379573795837959379603796137962379633796437965379663796737968379693797037971379723797337974379753797637977379783797937980379813798237983379843798537986379873798837989379903799137992379933799437995379963799737998379993800038001380023800338004380053800638007380083800938010380113801238013380143801538016380173801838019380203802138022380233802438025380263802738028380293803038031380323803338034380353803638037380383803938040380413804238043380443804538046380473804838049380503805138052380533805438055380563805738058380593806038061380623806338064380653806638067380683806938070380713807238073380743807538076380773807838079380803808138082380833808438085380863808738088380893809038091380923809338094380953809638097380983809938100381013810238103381043810538106381073810838109381103811138112381133811438115381163811738118381193812038121381223812338124381253812638127381283812938130381313813238133381343813538136381373813838139381403814138142381433814438145381463814738148381493815038151381523815338154381553815638157381583815938160381613816238163381643816538166381673816838169381703817138172381733817438175381763817738178381793818038181381823818338184381853818638187381883818938190381913819238193381943819538196381973819838199382003820138202382033820438205382063820738208382093821038211382123821338214382153821638217382183821938220382213822238223382243822538226382273822838229382303823138232382333823438235382363823738238382393824038241382423824338244382453824638247382483824938250382513825238253382543825538256382573825838259382603826138262382633826438265382663826738268382693827038271382723827338274382753827638277382783827938280382813828238283382843828538286382873828838289382903829138292382933829438295382963829738298382993830038301383023830338304383053830638307383083830938310383113831238313383143831538316383173831838319383203832138322383233832438325383263832738328383293833038331383323833338334383353833638337383383833938340383413834238343383443834538346383473834838349383503835138352383533835438355383563835738358383593836038361383623836338364383653836638367383683836938370383713837238373383743837538376383773837838379383803838138382383833838438385383863838738388383893839038391383923839338394383953839638397383983839938400384013840238403384043840538406384073840838409384103841138412384133841438415384163841738418384193842038421384223842338424384253842638427384283842938430384313843238433384343843538436384373843838439384403844138442384433844438445384463844738448384493845038451384523845338454384553845638457384583845938460384613846238463384643846538466384673846838469384703847138472384733847438475384763847738478384793848038481384823848338484384853848638487384883848938490384913849238493384943849538496384973849838499385003850138502385033850438505385063850738508385093851038511385123851338514385153851638517385183851938520385213852238523385243852538526385273852838529385303853138532385333853438535385363853738538385393854038541385423854338544385453854638547385483854938550385513855238553385543855538556385573855838559385603856138562385633856438565385663856738568385693857038571385723857338574385753857638577385783857938580385813858238583385843858538586385873858838589385903859138592385933859438595385963859738598385993860038601386023860338604386053860638607386083860938610386113861238613386143861538616386173861838619386203862138622386233862438625386263862738628386293863038631386323863338634386353863638637386383863938640386413864238643386443864538646386473864838649386503865138652386533865438655386563865738658386593866038661386623866338664386653866638667386683866938670386713867238673386743867538676386773867838679386803868138682386833868438685386863868738688386893869038691386923869338694386953869638697386983869938700387013870238703387043870538706387073870838709387103871138712387133871438715387163871738718387193872038721387223872338724387253872638727387283872938730387313873238733387343873538736387373873838739387403874138742387433874438745387463874738748387493875038751387523875338754387553875638757387583875938760387613876238763387643876538766387673876838769387703877138772387733877438775387763877738778387793878038781387823878338784387853878638787387883878938790387913879238793387943879538796387973879838799388003880138802388033880438805388063880738808388093881038811388123881338814388153881638817388183881938820388213882238823388243882538826388273882838829388303883138832388333883438835388363883738838388393884038841388423884338844388453884638847388483884938850388513885238853388543885538856388573885838859388603886138862388633886438865388663886738868388693887038871388723887338874388753887638877388783887938880388813888238883388843888538886388873888838889388903889138892388933889438895388963889738898388993890038901389023890338904389053890638907389083890938910389113891238913389143891538916389173891838919389203892138922389233892438925389263892738928389293893038931389323893338934389353893638937389383893938940389413894238943389443894538946389473894838949389503895138952389533895438955389563895738958389593896038961389623896338964389653896638967389683896938970389713897238973389743897538976389773897838979389803898138982389833898438985389863898738988389893899038991389923899338994389953899638997389983899939000390013900239003390043900539006390073900839009390103901139012390133901439015390163901739018390193902039021390223902339024390253902639027390283902939030390313903239033390343903539036390373903839039390403904139042390433904439045390463904739048390493905039051390523905339054390553905639057390583905939060390613906239063390643906539066390673906839069390703907139072390733907439075390763907739078390793908039081390823908339084390853908639087390883908939090390913909239093390943909539096390973909839099391003910139102391033910439105391063910739108391093911039111391123911339114391153911639117391183911939120391213912239123391243912539126391273912839129391303913139132391333913439135391363913739138391393914039141391423914339144391453914639147391483914939150391513915239153391543915539156391573915839159391603916139162391633916439165391663916739168391693917039171391723917339174391753917639177391783917939180391813918239183391843918539186391873918839189391903919139192391933919439195391963919739198391993920039201392023920339204392053920639207392083920939210392113921239213392143921539216392173921839219392203922139222392233922439225392263922739228392293923039231392323923339234392353923639237392383923939240392413924239243392443924539246392473924839249392503925139252392533925439255392563925739258392593926039261392623926339264392653926639267392683926939270392713927239273392743927539276392773927839279392803928139282392833928439285392863928739288392893929039291392923929339294392953929639297392983929939300393013930239303393043930539306393073930839309393103931139312393133931439315393163931739318393193932039321393223932339324393253932639327393283932939330393313933239333393343933539336393373933839339393403934139342393433934439345393463934739348393493935039351393523935339354393553935639357393583935939360393613936239363393643936539366393673936839369393703937139372393733937439375393763937739378393793938039381393823938339384393853938639387393883938939390393913939239393393943939539396393973939839399394003940139402394033940439405394063940739408394093941039411394123941339414394153941639417394183941939420394213942239423394243942539426394273942839429394303943139432394333943439435394363943739438394393944039441394423944339444394453944639447394483944939450394513945239453394543945539456394573945839459394603946139462394633946439465394663946739468394693947039471394723947339474394753947639477394783947939480394813948239483394843948539486394873948839489394903949139492394933949439495394963949739498394993950039501395023950339504395053950639507395083950939510395113951239513395143951539516395173951839519395203952139522395233952439525395263952739528395293953039531395323953339534395353953639537395383953939540395413954239543395443954539546395473954839549395503955139552395533955439555395563955739558395593956039561395623956339564395653956639567395683956939570395713957239573395743957539576395773957839579395803958139582395833958439585395863958739588395893959039591395923959339594395953959639597395983959939600396013960239603396043960539606396073960839609396103961139612396133961439615396163961739618396193962039621396223962339624396253962639627396283962939630396313963239633396343963539636396373963839639396403964139642396433964439645396463964739648396493965039651396523965339654396553965639657396583965939660396613966239663396643966539666396673966839669396703967139672396733967439675396763967739678396793968039681396823968339684396853968639687396883968939690396913969239693396943969539696396973969839699397003970139702397033970439705397063970739708397093971039711397123971339714397153971639717397183971939720397213972239723397243972539726397273972839729397303973139732397333973439735397363973739738397393974039741397423974339744397453974639747397483974939750397513975239753397543975539756397573975839759397603976139762397633976439765397663976739768397693977039771397723977339774397753977639777397783977939780397813978239783397843978539786397873978839789397903979139792397933979439795397963979739798397993980039801398023980339804398053980639807398083980939810398113981239813398143981539816398173981839819398203982139822398233982439825398263982739828398293983039831398323983339834398353983639837398383983939840398413984239843398443984539846398473984839849398503985139852398533985439855398563985739858398593986039861398623986339864398653986639867398683986939870398713987239873398743987539876398773987839879398803988139882398833988439885398863988739888398893989039891398923989339894398953989639897398983989939900399013990239903399043990539906399073990839909399103991139912399133991439915399163991739918399193992039921399223992339924399253992639927399283992939930399313993239933399343993539936399373993839939399403994139942399433994439945399463994739948399493995039951399523995339954399553995639957399583995939960399613996239963399643996539966399673996839969399703997139972399733997439975399763997739978399793998039981399823998339984399853998639987399883998939990399913999239993399943999539996399973999839999400004000140002400034000440005400064000740008400094001040011400124001340014400154001640017400184001940020400214002240023400244002540026400274002840029400304003140032400334003440035400364003740038400394004040041400424004340044400454004640047400484004940050400514005240053400544005540056400574005840059400604006140062400634006440065400664006740068400694007040071400724007340074400754007640077400784007940080400814008240083400844008540086400874008840089400904009140092400934009440095400964009740098400994010040101401024010340104401054010640107401084010940110401114011240113401144011540116401174011840119401204012140122401234012440125401264012740128401294013040131401324013340134401354013640137401384013940140401414014240143401444014540146401474014840149401504015140152401534015440155401564015740158401594016040161401624016340164401654016640167401684016940170401714017240173401744017540176401774017840179401804018140182401834018440185401864018740188401894019040191401924019340194401954019640197401984019940200402014020240203402044020540206402074020840209402104021140212402134021440215402164021740218402194022040221402224022340224402254022640227402284022940230402314023240233402344023540236402374023840239402404024140242402434024440245402464024740248402494025040251402524025340254402554025640257402584025940260402614026240263402644026540266402674026840269402704027140272402734027440275402764027740278402794028040281402824028340284402854028640287402884028940290402914029240293402944029540296402974029840299403004030140302403034030440305403064030740308403094031040311403124031340314403154031640317403184031940320403214032240323403244032540326403274032840329403304033140332403334033440335403364033740338403394034040341403424034340344403454034640347403484034940350403514035240353403544035540356403574035840359403604036140362403634036440365403664036740368403694037040371403724037340374403754037640377403784037940380403814038240383403844038540386403874038840389403904039140392403934039440395403964039740398403994040040401404024040340404404054040640407404084040940410404114041240413404144041540416404174041840419404204042140422404234042440425404264042740428404294043040431404324043340434404354043640437404384043940440404414044240443404444044540446404474044840449404504045140452404534045440455404564045740458404594046040461404624046340464404654046640467404684046940470404714047240473404744047540476404774047840479404804048140482404834048440485404864048740488404894049040491404924049340494404954049640497404984049940500405014050240503405044050540506405074050840509405104051140512405134051440515405164051740518405194052040521405224052340524405254052640527405284052940530405314053240533405344053540536405374053840539405404054140542405434054440545405464054740548405494055040551405524055340554405554055640557405584055940560405614056240563405644056540566405674056840569405704057140572405734057440575405764057740578405794058040581405824058340584405854058640587405884058940590405914059240593405944059540596405974059840599406004060140602406034060440605406064060740608406094061040611406124061340614406154061640617406184061940620406214062240623406244062540626406274062840629406304063140632406334063440635406364063740638406394064040641406424064340644406454064640647406484064940650406514065240653406544065540656406574065840659406604066140662406634066440665406664066740668406694067040671406724067340674406754067640677406784067940680406814068240683406844068540686406874068840689406904069140692406934069440695406964069740698406994070040701407024070340704407054070640707407084070940710407114071240713407144071540716407174071840719407204072140722407234072440725407264072740728407294073040731407324073340734407354073640737407384073940740407414074240743407444074540746407474074840749407504075140752407534075440755407564075740758407594076040761407624076340764407654076640767407684076940770407714077240773407744077540776407774077840779407804078140782407834078440785407864078740788407894079040791407924079340794407954079640797407984079940800408014080240803408044080540806408074080840809408104081140812408134081440815408164081740818408194082040821408224082340824408254082640827408284082940830408314083240833408344083540836408374083840839408404084140842408434084440845408464084740848408494085040851408524085340854408554085640857408584085940860408614086240863408644086540866408674086840869408704087140872408734087440875408764087740878408794088040881408824088340884408854088640887408884088940890408914089240893408944089540896408974089840899409004090140902409034090440905409064090740908409094091040911409124091340914409154091640917409184091940920409214092240923409244092540926409274092840929409304093140932409334093440935409364093740938409394094040941409424094340944409454094640947409484094940950409514095240953409544095540956409574095840959409604096140962409634096440965409664096740968409694097040971409724097340974409754097640977409784097940980409814098240983409844098540986409874098840989409904099140992409934099440995409964099740998409994100041001410024100341004410054100641007410084100941010410114101241013410144101541016410174101841019410204102141022410234102441025410264102741028410294103041031410324103341034410354103641037410384103941040410414104241043410444104541046410474104841049410504105141052410534105441055410564105741058410594106041061410624106341064410654106641067410684106941070410714107241073410744107541076410774107841079410804108141082410834108441085410864108741088410894109041091410924109341094410954109641097410984109941100411014110241103411044110541106411074110841109411104111141112411134111441115411164111741118411194112041121411224112341124411254112641127411284112941130411314113241133411344113541136411374113841139411404114141142411434114441145411464114741148411494115041151411524115341154411554115641157411584115941160411614116241163411644116541166411674116841169411704117141172411734117441175411764117741178411794118041181411824118341184411854118641187411884118941190411914119241193411944119541196411974119841199412004120141202412034120441205412064120741208412094121041211412124121341214412154121641217412184121941220412214122241223412244122541226412274122841229412304123141232412334123441235412364123741238412394124041241412424124341244412454124641247412484124941250412514125241253412544125541256412574125841259412604126141262412634126441265412664126741268412694127041271412724127341274412754127641277412784127941280412814128241283412844128541286412874128841289412904129141292412934129441295412964129741298412994130041301413024130341304413054130641307413084130941310413114131241313413144131541316413174131841319413204132141322413234132441325413264132741328413294133041331413324133341334413354133641337413384133941340413414134241343413444134541346413474134841349413504135141352413534135441355413564135741358413594136041361413624136341364413654136641367413684136941370413714137241373413744137541376413774137841379413804138141382413834138441385413864138741388413894139041391413924139341394413954139641397413984139941400414014140241403414044140541406414074140841409414104141141412414134141441415414164141741418414194142041421414224142341424414254142641427414284142941430414314143241433414344143541436414374143841439414404144141442414434144441445414464144741448414494145041451414524145341454414554145641457414584145941460414614146241463414644146541466414674146841469414704147141472414734147441475414764147741478414794148041481414824148341484414854148641487414884148941490414914149241493414944149541496414974149841499415004150141502415034150441505415064150741508415094151041511415124151341514415154151641517415184151941520415214152241523415244152541526415274152841529415304153141532415334153441535415364153741538415394154041541415424154341544415454154641547415484154941550415514155241553415544155541556415574155841559415604156141562415634156441565415664156741568415694157041571415724157341574415754157641577415784157941580415814158241583415844158541586415874158841589415904159141592415934159441595415964159741598415994160041601416024160341604416054160641607416084160941610416114161241613416144161541616416174161841619416204162141622416234162441625416264162741628416294163041631416324163341634416354163641637416384163941640416414164241643416444164541646416474164841649416504165141652416534165441655416564165741658416594166041661416624166341664416654166641667416684166941670416714167241673416744167541676416774167841679416804168141682416834168441685416864168741688416894169041691416924169341694416954169641697416984169941700417014170241703417044170541706417074170841709417104171141712417134171441715417164171741718417194172041721417224172341724417254172641727417284172941730417314173241733417344173541736417374173841739417404174141742417434174441745417464174741748417494175041751417524175341754417554175641757417584175941760417614176241763417644176541766417674176841769417704177141772417734177441775417764177741778417794178041781417824178341784417854178641787417884178941790417914179241793417944179541796417974179841799418004180141802418034180441805418064180741808418094181041811418124181341814418154181641817418184181941820418214182241823418244182541826418274182841829418304183141832418334183441835418364183741838418394184041841418424184341844418454184641847418484184941850418514185241853418544185541856418574185841859418604186141862418634186441865418664186741868418694187041871418724187341874418754187641877418784187941880418814188241883418844188541886418874188841889418904189141892418934189441895418964189741898418994190041901419024190341904419054190641907419084190941910419114191241913419144191541916419174191841919419204192141922419234192441925419264192741928419294193041931419324193341934419354193641937419384193941940419414194241943419444194541946419474194841949419504195141952419534195441955419564195741958419594196041961419624196341964419654196641967419684196941970419714197241973419744197541976419774197841979419804198141982419834198441985419864198741988419894199041991419924199341994419954199641997419984199942000420014200242003420044200542006420074200842009420104201142012420134201442015420164201742018420194202042021420224202342024420254202642027420284202942030420314203242033420344203542036420374203842039420404204142042420434204442045420464204742048420494205042051420524205342054420554205642057420584205942060420614206242063420644206542066420674206842069420704207142072420734207442075420764207742078420794208042081420824208342084420854208642087420884208942090420914209242093420944209542096420974209842099421004210142102421034210442105421064210742108421094211042111421124211342114421154211642117421184211942120421214212242123421244212542126421274212842129421304213142132421334213442135421364213742138421394214042141421424214342144421454214642147421484214942150421514215242153421544215542156421574215842159421604216142162421634216442165421664216742168421694217042171421724217342174421754217642177421784217942180421814218242183421844218542186421874218842189421904219142192421934219442195421964219742198421994220042201422024220342204422054220642207422084220942210422114221242213422144221542216422174221842219422204222142222422234222442225422264222742228422294223042231422324223342234422354223642237422384223942240422414224242243422444224542246422474224842249422504225142252422534225442255422564225742258422594226042261422624226342264422654226642267422684226942270422714227242273422744227542276422774227842279422804228142282422834228442285422864228742288422894229042291422924229342294422954229642297422984229942300423014230242303423044230542306423074230842309423104231142312423134231442315423164231742318423194232042321423224232342324423254232642327423284232942330423314233242333423344233542336423374233842339423404234142342423434234442345423464234742348423494235042351423524235342354423554235642357423584235942360423614236242363423644236542366423674236842369423704237142372423734237442375423764237742378423794238042381423824238342384423854238642387423884238942390423914239242393423944239542396423974239842399424004240142402424034240442405424064240742408424094241042411424124241342414424154241642417424184241942420424214242242423424244242542426424274242842429424304243142432424334243442435424364243742438424394244042441424424244342444424454244642447424484244942450424514245242453424544245542456424574245842459424604246142462424634246442465424664246742468424694247042471424724247342474424754247642477424784247942480424814248242483424844248542486424874248842489424904249142492424934249442495424964249742498424994250042501425024250342504425054250642507425084250942510425114251242513425144251542516425174251842519425204252142522425234252442525425264252742528425294253042531425324253342534425354253642537425384253942540425414254242543425444254542546425474254842549425504255142552425534255442555425564255742558425594256042561425624256342564425654256642567425684256942570425714257242573425744257542576425774257842579425804258142582425834258442585425864258742588425894259042591425924259342594425954259642597425984259942600426014260242603426044260542606426074260842609426104261142612426134261442615426164261742618426194262042621426224262342624426254262642627426284262942630426314263242633426344263542636426374263842639426404264142642426434264442645426464264742648426494265042651426524265342654426554265642657426584265942660426614266242663426644266542666426674266842669426704267142672426734267442675426764267742678426794268042681426824268342684426854268642687426884268942690426914269242693426944269542696426974269842699427004270142702427034270442705427064270742708427094271042711427124271342714427154271642717427184271942720427214272242723427244272542726427274272842729427304273142732427334273442735427364273742738427394274042741427424274342744427454274642747427484274942750427514275242753427544275542756427574275842759427604276142762427634276442765427664276742768427694277042771427724277342774427754277642777427784277942780427814278242783427844278542786427874278842789427904279142792427934279442795427964279742798427994280042801428024280342804428054280642807428084280942810428114281242813428144281542816428174281842819428204282142822428234282442825428264282742828428294283042831428324283342834428354283642837428384283942840428414284242843428444284542846428474284842849428504285142852428534285442855428564285742858428594286042861428624286342864428654286642867428684286942870428714287242873428744287542876428774287842879428804288142882428834288442885428864288742888428894289042891428924289342894428954289642897428984289942900429014290242903429044290542906429074290842909429104291142912429134291442915429164291742918429194292042921429224292342924429254292642927429284292942930429314293242933429344293542936429374293842939429404294142942429434294442945429464294742948429494295042951429524295342954429554295642957429584295942960429614296242963429644296542966429674296842969429704297142972429734297442975429764297742978429794298042981429824298342984429854298642987429884298942990429914299242993429944299542996429974299842999430004300143002430034300443005430064300743008430094301043011430124301343014430154301643017430184301943020430214302243023430244302543026430274302843029430304303143032430334303443035430364303743038430394304043041430424304343044430454304643047430484304943050430514305243053430544305543056430574305843059430604306143062430634306443065430664306743068430694307043071430724307343074430754307643077430784307943080430814308243083430844308543086430874308843089430904309143092430934309443095430964309743098430994310043101431024310343104431054310643107431084310943110431114311243113431144311543116431174311843119431204312143122431234312443125431264312743128431294313043131431324313343134431354313643137431384313943140431414314243143431444314543146431474314843149431504315143152431534315443155431564315743158431594316043161431624316343164431654316643167431684316943170431714317243173431744317543176431774317843179431804318143182431834318443185431864318743188431894319043191431924319343194431954319643197431984319943200432014320243203432044320543206432074320843209432104321143212432134321443215432164321743218432194322043221432224322343224432254322643227432284322943230432314323243233432344323543236432374323843239432404324143242432434324443245432464324743248432494325043251432524325343254432554325643257432584325943260432614326243263432644326543266432674326843269432704327143272432734327443275432764327743278432794328043281432824328343284432854328643287432884328943290432914329243293432944329543296432974329843299433004330143302433034330443305433064330743308433094331043311433124331343314433154331643317433184331943320433214332243323433244332543326433274332843329433304333143332433334333443335433364333743338433394334043341433424334343344433454334643347433484334943350433514335243353433544335543356433574335843359433604336143362433634336443365433664336743368433694337043371433724337343374433754337643377433784337943380433814338243383433844338543386433874338843389433904339143392433934339443395433964339743398433994340043401434024340343404434054340643407434084340943410434114341243413434144341543416434174341843419434204342143422434234342443425434264342743428434294343043431434324343343434434354343643437434384343943440434414344243443434444344543446434474344843449434504345143452434534345443455434564345743458434594346043461434624346343464434654346643467434684346943470434714347243473434744347543476434774347843479434804348143482434834348443485434864348743488434894349043491434924349343494434954349643497434984349943500435014350243503435044350543506435074350843509435104351143512435134351443515435164351743518435194352043521435224352343524435254352643527435284352943530435314353243533435344353543536435374353843539435404354143542435434354443545435464354743548435494355043551435524355343554435554355643557435584355943560435614356243563435644356543566435674356843569435704357143572435734357443575435764357743578435794358043581435824358343584435854358643587435884358943590435914359243593435944359543596435974359843599436004360143602436034360443605436064360743608436094361043611436124361343614436154361643617436184361943620436214362243623436244362543626436274362843629436304363143632436334363443635436364363743638436394364043641436424364343644436454364643647436484364943650436514365243653436544365543656436574365843659436604366143662436634366443665436664366743668436694367043671436724367343674436754367643677436784367943680436814368243683436844368543686436874368843689436904369143692436934369443695436964369743698436994370043701437024370343704437054370643707437084370943710437114371243713437144371543716437174371843719437204372143722437234372443725437264372743728437294373043731437324373343734437354373643737437384373943740437414374243743437444374543746437474374843749437504375143752437534375443755437564375743758437594376043761437624376343764437654376643767437684376943770437714377243773437744377543776437774377843779437804378143782437834378443785437864378743788437894379043791437924379343794437954379643797437984379943800438014380243803438044380543806438074380843809438104381143812438134381443815438164381743818438194382043821438224382343824438254382643827438284382943830438314383243833438344383543836438374383843839438404384143842438434384443845438464384743848438494385043851438524385343854438554385643857438584385943860438614386243863438644386543866438674386843869438704387143872438734387443875438764387743878438794388043881438824388343884438854388643887438884388943890438914389243893438944389543896438974389843899439004390143902439034390443905439064390743908439094391043911439124391343914439154391643917439184391943920439214392243923439244392543926439274392843929439304393143932439334393443935439364393743938439394394043941439424394343944439454394643947439484394943950439514395243953439544395543956439574395843959439604396143962439634396443965439664396743968439694397043971439724397343974439754397643977439784397943980439814398243983439844398543986439874398843989439904399143992439934399443995439964399743998439994400044001440024400344004440054400644007440084400944010440114401244013440144401544016440174401844019440204402144022440234402444025440264402744028440294403044031440324403344034440354403644037440384403944040440414404244043440444404544046440474404844049440504405144052440534405444055440564405744058440594406044061440624406344064440654406644067440684406944070440714407244073440744407544076440774407844079440804408144082440834408444085440864408744088440894409044091440924409344094440954409644097440984409944100441014410244103441044410544106441074410844109441104411144112441134411444115441164411744118441194412044121441224412344124441254412644127441284412944130441314413244133441344413544136441374413844139441404414144142441434414444145441464414744148441494415044151441524415344154441554415644157441584415944160441614416244163441644416544166441674416844169441704417144172441734417444175441764417744178441794418044181441824418344184441854418644187441884418944190441914419244193441944419544196441974419844199442004420144202442034420444205442064420744208442094421044211442124421344214442154421644217442184421944220442214422244223442244422544226442274422844229442304423144232442334423444235442364423744238442394424044241442424424344244442454424644247442484424944250442514425244253442544425544256442574425844259442604426144262442634426444265442664426744268442694427044271442724427344274442754427644277442784427944280442814428244283442844428544286442874428844289442904429144292442934429444295442964429744298442994430044301443024430344304443054430644307443084430944310443114431244313443144431544316443174431844319443204432144322443234432444325443264432744328443294433044331443324433344334443354433644337443384433944340443414434244343443444434544346443474434844349443504435144352443534435444355443564435744358443594436044361443624436344364443654436644367443684436944370443714437244373443744437544376443774437844379443804438144382443834438444385443864438744388443894439044391443924439344394443954439644397443984439944400444014440244403444044440544406444074440844409444104441144412444134441444415444164441744418444194442044421444224442344424444254442644427444284442944430444314443244433444344443544436444374443844439444404444144442444434444444445444464444744448444494445044451444524445344454444554445644457444584445944460444614446244463444644446544466444674446844469444704447144472444734447444475444764447744478444794448044481444824448344484444854448644487444884448944490444914449244493444944449544496444974449844499445004450144502445034450444505445064450744508445094451044511445124451344514445154451644517445184451944520445214452244523445244452544526445274452844529445304453144532445334453444535445364453744538445394454044541445424454344544445454454644547445484454944550445514455244553445544455544556445574455844559445604456144562445634456444565445664456744568445694457044571445724457344574445754457644577445784457944580445814458244583445844458544586445874458844589445904459144592445934459444595445964459744598445994460044601446024460344604446054460644607446084460944610446114461244613446144461544616446174461844619446204462144622446234462444625446264462744628446294463044631446324463344634446354463644637446384463944640446414464244643446444464544646446474464844649446504465144652446534465444655446564465744658446594466044661446624466344664446654466644667446684466944670446714467244673446744467544676446774467844679446804468144682446834468444685446864468744688446894469044691446924469344694446954469644697446984469944700447014470244703447044470544706447074470844709447104471144712447134471444715447164471744718447194472044721447224472344724447254472644727447284472944730447314473244733447344473544736447374473844739447404474144742447434474444745447464474744748447494475044751447524475344754447554475644757447584475944760447614476244763447644476544766447674476844769447704477144772447734477444775447764477744778447794478044781447824478344784447854478644787447884478944790447914479244793447944479544796447974479844799448004480144802448034480444805448064480744808448094481044811448124481344814448154481644817448184481944820448214482244823448244482544826448274482844829448304483144832448334483444835448364483744838448394484044841448424484344844448454484644847448484484944850448514485244853448544485544856448574485844859448604486144862448634486444865448664486744868448694487044871448724487344874448754487644877448784487944880448814488244883448844488544886448874488844889448904489144892448934489444895448964489744898448994490044901449024490344904449054490644907449084490944910449114491244913449144491544916449174491844919449204492144922449234492444925449264492744928449294493044931449324493344934449354493644937449384493944940449414494244943449444494544946449474494844949449504495144952449534495444955449564495744958449594496044961449624496344964449654496644967449684496944970449714497244973449744497544976449774497844979449804498144982449834498444985449864498744988449894499044991449924499344994449954499644997449984499945000450014500245003450044500545006450074500845009450104501145012450134501445015450164501745018450194502045021450224502345024450254502645027450284502945030450314503245033450344503545036450374503845039450404504145042450434504445045450464504745048450494505045051450524505345054450554505645057450584505945060450614506245063450644506545066450674506845069450704507145072450734507445075450764507745078450794508045081450824508345084450854508645087450884508945090450914509245093450944509545096450974509845099451004510145102451034510445105451064510745108451094511045111451124511345114451154511645117451184511945120451214512245123451244512545126451274512845129451304513145132451334513445135451364513745138451394514045141451424514345144451454514645147451484514945150451514515245153451544515545156451574515845159451604516145162451634516445165451664516745168451694517045171451724517345174451754517645177451784517945180451814518245183451844518545186451874518845189451904519145192451934519445195451964519745198451994520045201452024520345204452054520645207452084520945210452114521245213452144521545216452174521845219452204522145222452234522445225452264522745228452294523045231452324523345234452354523645237452384523945240452414524245243452444524545246452474524845249452504525145252452534525445255452564525745258452594526045261452624526345264452654526645267452684526945270452714527245273452744527545276452774527845279452804528145282452834528445285452864528745288452894529045291452924529345294452954529645297452984529945300453014530245303453044530545306453074530845309453104531145312453134531445315453164531745318453194532045321453224532345324453254532645327453284532945330453314533245333453344533545336453374533845339453404534145342453434534445345453464534745348453494535045351453524535345354453554535645357453584535945360453614536245363453644536545366453674536845369453704537145372453734537445375453764537745378453794538045381453824538345384453854538645387453884538945390453914539245393453944539545396453974539845399454004540145402454034540445405454064540745408454094541045411454124541345414454154541645417454184541945420454214542245423454244542545426454274542845429454304543145432454334543445435454364543745438454394544045441454424544345444454454544645447454484544945450454514545245453454544545545456454574545845459454604546145462454634546445465454664546745468454694547045471454724547345474454754547645477454784547945480454814548245483454844548545486454874548845489454904549145492454934549445495454964549745498454994550045501455024550345504455054550645507455084550945510455114551245513455144551545516455174551845519455204552145522455234552445525455264552745528455294553045531455324553345534455354553645537455384553945540455414554245543455444554545546455474554845549455504555145552455534555445555455564555745558455594556045561455624556345564455654556645567455684556945570455714557245573455744557545576455774557845579455804558145582455834558445585455864558745588455894559045591455924559345594455954559645597455984559945600456014560245603456044560545606456074560845609456104561145612456134561445615456164561745618456194562045621456224562345624456254562645627456284562945630456314563245633456344563545636456374563845639456404564145642456434564445645456464564745648456494565045651456524565345654456554565645657456584565945660456614566245663456644566545666456674566845669456704567145672456734567445675456764567745678456794568045681456824568345684456854568645687456884568945690456914569245693456944569545696456974569845699457004570145702457034570445705457064570745708457094571045711457124571345714457154571645717457184571945720457214572245723457244572545726457274572845729457304573145732457334573445735457364573745738457394574045741457424574345744457454574645747457484574945750457514575245753457544575545756457574575845759457604576145762457634576445765457664576745768457694577045771457724577345774457754577645777457784577945780457814578245783457844578545786457874578845789457904579145792457934579445795457964579745798457994580045801458024580345804458054580645807458084580945810458114581245813458144581545816458174581845819458204582145822458234582445825458264582745828458294583045831458324583345834458354583645837458384583945840458414584245843458444584545846458474584845849458504585145852458534585445855458564585745858458594586045861458624586345864458654586645867458684586945870458714587245873458744587545876458774587845879458804588145882458834588445885458864588745888458894589045891458924589345894458954589645897458984589945900459014590245903459044590545906459074590845909459104591145912459134591445915459164591745918459194592045921459224592345924459254592645927459284592945930459314593245933459344593545936459374593845939459404594145942459434594445945459464594745948459494595045951459524595345954459554595645957459584595945960459614596245963459644596545966459674596845969459704597145972459734597445975459764597745978459794598045981459824598345984459854598645987459884598945990459914599245993459944599545996459974599845999460004600146002460034600446005460064600746008460094601046011460124601346014460154601646017460184601946020460214602246023460244602546026460274602846029460304603146032460334603446035460364603746038460394604046041460424604346044460454604646047460484604946050460514605246053460544605546056460574605846059460604606146062460634606446065460664606746068460694607046071460724607346074460754607646077460784607946080460814608246083460844608546086460874608846089460904609146092460934609446095460964609746098460994610046101461024610346104461054610646107461084610946110461114611246113461144611546116461174611846119461204612146122461234612446125461264612746128461294613046131461324613346134461354613646137461384613946140461414614246143461444614546146461474614846149461504615146152461534615446155461564615746158461594616046161461624616346164461654616646167461684616946170461714617246173461744617546176461774617846179461804618146182461834618446185461864618746188461894619046191461924619346194461954619646197461984619946200462014620246203462044620546206462074620846209462104621146212462134621446215462164621746218462194622046221462224622346224462254622646227462284622946230462314623246233462344623546236462374623846239462404624146242462434624446245462464624746248462494625046251462524625346254462554625646257462584625946260462614626246263462644626546266462674626846269462704627146272462734627446275462764627746278462794628046281462824628346284462854628646287462884628946290462914629246293462944629546296462974629846299463004630146302463034630446305463064630746308463094631046311463124631346314463154631646317463184631946320463214632246323463244632546326463274632846329463304633146332463334633446335463364633746338463394634046341463424634346344463454634646347463484634946350463514635246353463544635546356463574635846359463604636146362463634636446365463664636746368463694637046371463724637346374463754637646377463784637946380463814638246383463844638546386463874638846389463904639146392463934639446395463964639746398463994640046401464024640346404464054640646407464084640946410464114641246413464144641546416464174641846419464204642146422464234642446425464264642746428464294643046431464324643346434464354643646437464384643946440464414644246443464444644546446464474644846449464504645146452464534645446455464564645746458464594646046461464624646346464464654646646467464684646946470464714647246473464744647546476464774647846479464804648146482464834648446485464864648746488464894649046491464924649346494464954649646497464984649946500465014650246503465044650546506465074650846509465104651146512465134651446515465164651746518465194652046521465224652346524465254652646527465284652946530465314653246533465344653546536465374653846539465404654146542465434654446545465464654746548465494655046551465524655346554465554655646557465584655946560465614656246563465644656546566465674656846569465704657146572465734657446575465764657746578465794658046581465824658346584465854658646587465884658946590465914659246593465944659546596465974659846599466004660146602466034660446605466064660746608466094661046611466124661346614466154661646617466184661946620466214662246623466244662546626466274662846629466304663146632466334663446635466364663746638466394664046641466424664346644466454664646647466484664946650466514665246653466544665546656466574665846659466604666146662466634666446665466664666746668466694667046671466724667346674466754667646677466784667946680466814668246683466844668546686466874668846689466904669146692466934669446695466964669746698466994670046701467024670346704467054670646707467084670946710467114671246713467144671546716467174671846719467204672146722467234672446725467264672746728467294673046731467324673346734467354673646737467384673946740467414674246743467444674546746467474674846749467504675146752467534675446755467564675746758467594676046761467624676346764467654676646767467684676946770467714677246773467744677546776467774677846779467804678146782467834678446785467864678746788467894679046791467924679346794467954679646797467984679946800468014680246803468044680546806468074680846809468104681146812468134681446815468164681746818468194682046821468224682346824468254682646827468284682946830468314683246833468344683546836468374683846839468404684146842468434684446845468464684746848468494685046851468524685346854468554685646857468584685946860468614686246863468644686546866468674686846869468704687146872468734687446875468764687746878468794688046881468824688346884468854688646887468884688946890468914689246893468944689546896468974689846899469004690146902469034690446905469064690746908469094691046911469124691346914469154691646917469184691946920469214692246923469244692546926469274692846929469304693146932469334693446935469364693746938469394694046941469424694346944469454694646947469484694946950469514695246953469544695546956469574695846959469604696146962469634696446965469664696746968469694697046971469724697346974469754697646977469784697946980469814698246983469844698546986469874698846989469904699146992469934699446995469964699746998469994700047001470024700347004470054700647007470084700947010470114701247013470144701547016470174701847019470204702147022470234702447025470264702747028470294703047031470324703347034470354703647037470384703947040470414704247043470444704547046470474704847049470504705147052470534705447055470564705747058470594706047061470624706347064470654706647067470684706947070470714707247073470744707547076470774707847079470804708147082470834708447085470864708747088470894709047091470924709347094470954709647097470984709947100471014710247103471044710547106471074710847109471104711147112471134711447115471164711747118471194712047121471224712347124471254712647127471284712947130471314713247133471344713547136471374713847139471404714147142471434714447145471464714747148471494715047151471524715347154471554715647157471584715947160471614716247163471644716547166471674716847169471704717147172471734717447175471764717747178471794718047181471824718347184471854718647187471884718947190471914719247193471944719547196471974719847199472004720147202472034720447205472064720747208472094721047211472124721347214472154721647217472184721947220472214722247223472244722547226472274722847229472304723147232472334723447235472364723747238472394724047241472424724347244472454724647247472484724947250472514725247253472544725547256472574725847259472604726147262472634726447265472664726747268472694727047271472724727347274472754727647277472784727947280472814728247283472844728547286472874728847289472904729147292472934729447295472964729747298472994730047301473024730347304473054730647307473084730947310473114731247313473144731547316473174731847319473204732147322473234732447325473264732747328473294733047331473324733347334473354733647337473384733947340473414734247343473444734547346473474734847349473504735147352473534735447355473564735747358473594736047361473624736347364473654736647367473684736947370473714737247373473744737547376473774737847379473804738147382473834738447385473864738747388473894739047391473924739347394473954739647397473984739947400474014740247403474044740547406474074740847409474104741147412474134741447415474164741747418474194742047421474224742347424474254742647427474284742947430474314743247433474344743547436474374743847439474404744147442474434744447445474464744747448474494745047451474524745347454474554745647457474584745947460474614746247463474644746547466474674746847469474704747147472474734747447475474764747747478474794748047481474824748347484474854748647487474884748947490474914749247493474944749547496474974749847499475004750147502475034750447505475064750747508475094751047511475124751347514475154751647517475184751947520475214752247523475244752547526475274752847529475304753147532475334753447535475364753747538475394754047541475424754347544475454754647547475484754947550475514755247553475544755547556475574755847559475604756147562475634756447565475664756747568475694757047571475724757347574475754757647577475784757947580475814758247583475844758547586475874758847589475904759147592475934759447595475964759747598475994760047601476024760347604476054760647607476084760947610476114761247613476144761547616476174761847619476204762147622476234762447625476264762747628476294763047631476324763347634476354763647637476384763947640476414764247643476444764547646476474764847649476504765147652476534765447655476564765747658476594766047661476624766347664476654766647667476684766947670476714767247673476744767547676476774767847679476804768147682476834768447685476864768747688476894769047691476924769347694476954769647697476984769947700477014770247703477044770547706477074770847709477104771147712477134771447715477164771747718477194772047721477224772347724477254772647727477284772947730477314773247733477344773547736477374773847739477404774147742477434774447745477464774747748477494775047751477524775347754477554775647757477584775947760477614776247763477644776547766477674776847769477704777147772477734777447775477764777747778477794778047781477824778347784477854778647787477884778947790477914779247793477944779547796477974779847799478004780147802478034780447805478064780747808478094781047811478124781347814478154781647817478184781947820478214782247823478244782547826478274782847829478304783147832478334783447835478364783747838478394784047841478424784347844478454784647847478484784947850478514785247853478544785547856478574785847859478604786147862478634786447865478664786747868478694787047871478724787347874478754787647877478784787947880478814788247883478844788547886478874788847889478904789147892478934789447895478964789747898478994790047901479024790347904479054790647907479084790947910479114791247913479144791547916479174791847919479204792147922479234792447925479264792747928479294793047931479324793347934479354793647937479384793947940479414794247943479444794547946479474794847949479504795147952479534795447955479564795747958479594796047961479624796347964479654796647967479684796947970479714797247973479744797547976479774797847979479804798147982479834798447985479864798747988479894799047991479924799347994479954799647997479984799948000480014800248003480044800548006480074800848009480104801148012480134801448015480164801748018480194802048021480224802348024480254802648027480284802948030480314803248033480344803548036480374803848039480404804148042480434804448045480464804748048480494805048051480524805348054480554805648057480584805948060480614806248063480644806548066480674806848069480704807148072480734807448075480764807748078480794808048081480824808348084480854808648087480884808948090480914809248093480944809548096480974809848099481004810148102481034810448105481064810748108481094811048111481124811348114481154811648117481184811948120481214812248123481244812548126481274812848129481304813148132481334813448135481364813748138481394814048141481424814348144481454814648147481484814948150481514815248153481544815548156481574815848159481604816148162481634816448165481664816748168481694817048171481724817348174481754817648177481784817948180481814818248183481844818548186481874818848189481904819148192481934819448195481964819748198481994820048201482024820348204482054820648207482084820948210482114821248213482144821548216482174821848219482204822148222482234822448225482264822748228482294823048231482324823348234482354823648237482384823948240482414824248243482444824548246482474824848249482504825148252482534825448255482564825748258482594826048261482624826348264482654826648267482684826948270482714827248273482744827548276482774827848279482804828148282482834828448285482864828748288482894829048291482924829348294482954829648297482984829948300483014830248303483044830548306483074830848309483104831148312483134831448315483164831748318483194832048321483224832348324483254832648327483284832948330483314833248333483344833548336483374833848339483404834148342483434834448345483464834748348483494835048351483524835348354483554835648357483584835948360483614836248363483644836548366483674836848369483704837148372483734837448375483764837748378483794838048381483824838348384483854838648387483884838948390483914839248393483944839548396483974839848399484004840148402484034840448405484064840748408484094841048411484124841348414484154841648417484184841948420484214842248423484244842548426484274842848429484304843148432484334843448435484364843748438484394844048441484424844348444484454844648447484484844948450484514845248453484544845548456484574845848459484604846148462484634846448465484664846748468484694847048471484724847348474484754847648477484784847948480484814848248483484844848548486484874848848489484904849148492484934849448495484964849748498484994850048501485024850348504485054850648507485084850948510485114851248513485144851548516485174851848519485204852148522485234852448525485264852748528485294853048531485324853348534485354853648537485384853948540485414854248543485444854548546485474854848549485504855148552485534855448555485564855748558485594856048561485624856348564485654856648567485684856948570485714857248573485744857548576485774857848579485804858148582485834858448585485864858748588485894859048591485924859348594485954859648597485984859948600486014860248603486044860548606486074860848609486104861148612486134861448615486164861748618486194862048621486224862348624486254862648627486284862948630486314863248633486344863548636486374863848639486404864148642486434864448645486464864748648486494865048651486524865348654486554865648657486584865948660486614866248663486644866548666486674866848669486704867148672486734867448675486764867748678486794868048681486824868348684486854868648687486884868948690486914869248693486944869548696486974869848699487004870148702487034870448705487064870748708487094871048711487124871348714487154871648717487184871948720487214872248723487244872548726487274872848729487304873148732487334873448735487364873748738487394874048741487424874348744487454874648747487484874948750487514875248753487544875548756487574875848759487604876148762487634876448765487664876748768487694877048771487724877348774487754877648777487784877948780487814878248783487844878548786487874878848789487904879148792487934879448795487964879748798487994880048801488024880348804488054880648807488084880948810488114881248813488144881548816488174881848819488204882148822488234882448825488264882748828488294883048831488324883348834488354883648837488384883948840488414884248843488444884548846488474884848849488504885148852488534885448855488564885748858488594886048861488624886348864488654886648867488684886948870488714887248873488744887548876488774887848879488804888148882488834888448885488864888748888488894889048891488924889348894488954889648897488984889948900489014890248903489044890548906489074890848909489104891148912489134891448915489164891748918489194892048921489224892348924489254892648927489284892948930489314893248933489344893548936489374893848939489404894148942489434894448945489464894748948489494895048951489524895348954489554895648957489584895948960489614896248963489644896548966489674896848969489704897148972489734897448975489764897748978489794898048981489824898348984489854898648987489884898948990489914899248993489944899548996489974899848999490004900149002490034900449005490064900749008490094901049011490124901349014490154901649017490184901949020490214902249023490244902549026490274902849029490304903149032490334903449035490364903749038490394904049041490424904349044490454904649047490484904949050490514905249053490544905549056490574905849059490604906149062490634906449065490664906749068490694907049071490724907349074490754907649077490784907949080490814908249083490844908549086490874908849089490904909149092490934909449095490964909749098490994910049101491024910349104491054910649107491084910949110491114911249113491144911549116491174911849119491204912149122491234912449125491264912749128491294913049131491324913349134491354913649137491384913949140491414914249143491444914549146491474914849149491504915149152491534915449155491564915749158491594916049161491624916349164491654916649167491684916949170491714917249173491744917549176491774917849179491804918149182491834918449185491864918749188491894919049191491924919349194491954919649197491984919949200492014920249203492044920549206492074920849209492104921149212492134921449215492164921749218492194922049221492224922349224492254922649227492284922949230492314923249233492344923549236492374923849239492404924149242492434924449245492464924749248492494925049251492524925349254492554925649257492584925949260492614926249263492644926549266492674926849269492704927149272492734927449275492764927749278492794928049281492824928349284492854928649287492884928949290492914929249293492944929549296492974929849299493004930149302493034930449305493064930749308493094931049311493124931349314493154931649317493184931949320493214932249323493244932549326493274932849329493304933149332493334933449335493364933749338493394934049341493424934349344493454934649347493484934949350493514935249353493544935549356493574935849359493604936149362493634936449365493664936749368493694937049371493724937349374493754937649377493784937949380493814938249383493844938549386493874938849389493904939149392493934939449395493964939749398493994940049401494024940349404494054940649407494084940949410494114941249413494144941549416494174941849419494204942149422494234942449425494264942749428494294943049431494324943349434494354943649437494384943949440494414944249443494444944549446494474944849449494504945149452494534945449455494564945749458494594946049461494624946349464494654946649467494684946949470494714947249473494744947549476494774947849479494804948149482494834948449485494864948749488494894949049491494924949349494494954949649497494984949949500495014950249503495044950549506495074950849509495104951149512495134951449515495164951749518495194952049521495224952349524495254952649527495284952949530495314953249533495344953549536495374953849539495404954149542495434954449545495464954749548495494955049551495524955349554495554955649557495584955949560495614956249563495644956549566495674956849569495704957149572495734957449575495764957749578495794958049581495824958349584495854958649587495884958949590495914959249593495944959549596495974959849599496004960149602496034960449605496064960749608496094961049611496124961349614496154961649617496184961949620496214962249623496244962549626496274962849629496304963149632496334963449635496364963749638496394964049641496424964349644496454964649647496484964949650496514965249653496544965549656496574965849659496604966149662496634966449665496664966749668496694967049671496724967349674496754967649677496784967949680496814968249683496844968549686496874968849689496904969149692496934969449695496964969749698496994970049701497024970349704497054970649707497084970949710497114971249713497144971549716497174971849719497204972149722497234972449725497264972749728497294973049731497324973349734497354973649737497384973949740497414974249743497444974549746497474974849749497504975149752497534975449755497564975749758497594976049761497624976349764497654976649767497684976949770497714977249773497744977549776497774977849779497804978149782497834978449785497864978749788497894979049791497924979349794497954979649797497984979949800498014980249803498044980549806498074980849809498104981149812498134981449815498164981749818498194982049821498224982349824498254982649827498284982949830498314983249833498344983549836498374983849839498404984149842498434984449845498464984749848498494985049851498524985349854498554985649857498584985949860498614986249863498644986549866498674986849869498704987149872498734987449875498764987749878498794988049881498824988349884498854988649887498884988949890498914989249893498944989549896498974989849899499004990149902499034990449905499064990749908499094991049911499124991349914499154991649917499184991949920499214992249923499244992549926499274992849929499304993149932499334993449935499364993749938499394994049941499424994349944499454994649947499484994949950499514995249953499544995549956499574995849959499604996149962499634996449965499664996749968499694997049971499724997349974499754997649977499784997949980499814998249983499844998549986499874998849989499904999149992499934999449995499964999749998499995000050001500025000350004500055000650007500085000950010500115001250013500145001550016500175001850019500205002150022500235002450025500265002750028500295003050031500325003350034500355003650037500385003950040500415004250043500445004550046500475004850049500505005150052500535005450055500565005750058500595006050061500625006350064500655006650067500685006950070500715007250073500745007550076500775007850079500805008150082500835008450085500865008750088500895009050091500925009350094500955009650097500985009950100501015010250103501045010550106501075010850109501105011150112501135011450115501165011750118501195012050121501225012350124501255012650127501285012950130501315013250133501345013550136501375013850139501405014150142501435014450145501465014750148501495015050151501525015350154501555015650157501585015950160501615016250163501645016550166501675016850169501705017150172501735017450175501765017750178501795018050181501825018350184501855018650187501885018950190501915019250193501945019550196501975019850199502005020150202502035020450205502065020750208502095021050211502125021350214502155021650217502185021950220502215022250223502245022550226502275022850229502305023150232502335023450235502365023750238502395024050241502425024350244502455024650247502485024950250502515025250253502545025550256502575025850259502605026150262502635026450265502665026750268502695027050271502725027350274502755027650277502785027950280502815028250283502845028550286502875028850289502905029150292502935029450295502965029750298502995030050301503025030350304503055030650307503085030950310503115031250313503145031550316503175031850319503205032150322503235032450325503265032750328503295033050331503325033350334503355033650337503385033950340503415034250343503445034550346503475034850349503505035150352503535035450355503565035750358503595036050361503625036350364503655036650367503685036950370503715037250373503745037550376503775037850379503805038150382503835038450385503865038750388503895039050391503925039350394503955039650397503985039950400504015040250403504045040550406504075040850409504105041150412504135041450415504165041750418504195042050421504225042350424504255042650427504285042950430504315043250433504345043550436504375043850439504405044150442504435044450445504465044750448504495045050451504525045350454504555045650457504585045950460504615046250463504645046550466504675046850469504705047150472504735047450475504765047750478504795048050481504825048350484504855048650487504885048950490504915049250493504945049550496504975049850499505005050150502505035050450505505065050750508505095051050511505125051350514505155051650517505185051950520505215052250523505245052550526505275052850529505305053150532505335053450535505365053750538505395054050541505425054350544505455054650547505485054950550505515055250553505545055550556505575055850559505605056150562505635056450565505665056750568505695057050571505725057350574505755057650577505785057950580505815058250583505845058550586505875058850589505905059150592505935059450595505965059750598505995060050601506025060350604506055060650607506085060950610506115061250613506145061550616506175061850619506205062150622506235062450625506265062750628506295063050631506325063350634506355063650637506385063950640506415064250643506445064550646506475064850649506505065150652506535065450655506565065750658506595066050661506625066350664506655066650667506685066950670506715067250673506745067550676506775067850679506805068150682506835068450685506865068750688506895069050691506925069350694506955069650697506985069950700507015070250703507045070550706507075070850709507105071150712507135071450715507165071750718507195072050721507225072350724507255072650727507285072950730507315073250733507345073550736507375073850739507405074150742507435074450745507465074750748507495075050751507525075350754507555075650757507585075950760507615076250763507645076550766507675076850769507705077150772507735077450775507765077750778507795078050781507825078350784507855078650787507885078950790507915079250793507945079550796507975079850799508005080150802508035080450805508065080750808508095081050811508125081350814508155081650817508185081950820508215082250823508245082550826508275082850829508305083150832508335083450835508365083750838508395084050841508425084350844508455084650847508485084950850508515085250853508545085550856508575085850859508605086150862508635086450865508665086750868508695087050871508725087350874508755087650877508785087950880508815088250883508845088550886508875088850889508905089150892508935089450895508965089750898508995090050901509025090350904509055090650907509085090950910509115091250913509145091550916509175091850919509205092150922509235092450925509265092750928509295093050931509325093350934509355093650937509385093950940509415094250943509445094550946509475094850949509505095150952509535095450955509565095750958509595096050961509625096350964509655096650967509685096950970509715097250973509745097550976509775097850979509805098150982509835098450985509865098750988509895099050991509925099350994509955099650997509985099951000510015100251003510045100551006510075100851009510105101151012510135101451015510165101751018510195102051021510225102351024510255102651027510285102951030510315103251033510345103551036510375103851039510405104151042510435104451045510465104751048510495105051051510525105351054510555105651057510585105951060510615106251063510645106551066510675106851069510705107151072510735107451075510765107751078510795108051081510825108351084510855108651087510885108951090510915109251093510945109551096510975109851099511005110151102511035110451105511065110751108511095111051111511125111351114511155111651117511185111951120511215112251123511245112551126511275112851129511305113151132511335113451135511365113751138511395114051141511425114351144511455114651147511485114951150511515115251153511545115551156511575115851159511605116151162511635116451165511665116751168511695117051171511725117351174511755117651177511785117951180511815118251183511845118551186511875118851189511905119151192511935119451195511965119751198511995120051201512025120351204512055120651207512085120951210512115121251213512145121551216512175121851219512205122151222512235122451225512265122751228512295123051231512325123351234512355123651237512385123951240512415124251243512445124551246512475124851249512505125151252512535125451255512565125751258512595126051261512625126351264512655126651267512685126951270512715127251273512745127551276512775127851279512805128151282512835128451285512865128751288512895129051291512925129351294512955129651297512985129951300513015130251303513045130551306513075130851309513105131151312513135131451315513165131751318513195132051321513225132351324513255132651327513285132951330513315133251333513345133551336513375133851339513405134151342513435134451345513465134751348513495135051351513525135351354513555135651357513585135951360513615136251363513645136551366513675136851369513705137151372513735137451375513765137751378513795138051381513825138351384513855138651387513885138951390513915139251393513945139551396513975139851399514005140151402514035140451405514065140751408514095141051411514125141351414514155141651417514185141951420514215142251423514245142551426514275142851429514305143151432514335143451435514365143751438514395144051441514425144351444514455144651447514485144951450514515145251453514545145551456514575145851459514605146151462514635146451465514665146751468514695147051471514725147351474514755147651477514785147951480514815148251483514845148551486514875148851489514905149151492514935149451495514965149751498514995150051501515025150351504515055150651507515085150951510515115151251513515145151551516515175151851519515205152151522515235152451525515265152751528515295153051531515325153351534515355153651537515385153951540515415154251543515445154551546515475154851549515505155151552515535155451555515565155751558515595156051561515625156351564515655156651567515685156951570515715157251573515745157551576515775157851579515805158151582515835158451585515865158751588515895159051591515925159351594515955159651597515985159951600516015160251603516045160551606516075160851609516105161151612516135161451615516165161751618516195162051621516225162351624516255162651627516285162951630516315163251633516345163551636516375163851639516405164151642516435164451645516465164751648516495165051651516525165351654516555165651657516585165951660516615166251663516645166551666516675166851669516705167151672516735167451675516765167751678516795168051681516825168351684516855168651687516885168951690516915169251693516945169551696516975169851699517005170151702517035170451705517065170751708517095171051711517125171351714517155171651717517185171951720517215172251723517245172551726517275172851729517305173151732517335173451735517365173751738517395174051741517425174351744517455174651747517485174951750517515175251753517545175551756517575175851759517605176151762517635176451765517665176751768517695177051771517725177351774517755177651777517785177951780517815178251783517845178551786517875178851789517905179151792517935179451795517965179751798517995180051801518025180351804518055180651807518085180951810518115181251813518145181551816518175181851819518205182151822518235182451825518265182751828518295183051831518325183351834518355183651837518385183951840518415184251843518445184551846518475184851849518505185151852518535185451855518565185751858518595186051861518625186351864518655186651867518685186951870518715187251873518745187551876518775187851879518805188151882518835188451885518865188751888518895189051891518925189351894518955189651897518985189951900519015190251903519045190551906519075190851909519105191151912519135191451915519165191751918519195192051921519225192351924519255192651927519285192951930519315193251933519345193551936519375193851939519405194151942519435194451945519465194751948519495195051951519525195351954519555195651957519585195951960519615196251963519645196551966519675196851969519705197151972519735197451975519765197751978519795198051981519825198351984519855198651987519885198951990519915199251993519945199551996519975199851999520005200152002520035200452005520065200752008520095201052011520125201352014520155201652017520185201952020520215202252023520245202552026520275202852029520305203152032520335203452035520365203752038520395204052041520425204352044520455204652047520485204952050520515205252053520545205552056520575205852059520605206152062520635206452065520665206752068520695207052071520725207352074520755207652077520785207952080520815208252083520845208552086520875208852089520905209152092520935209452095520965209752098520995210052101521025210352104521055210652107521085210952110521115211252113521145211552116521175211852119521205212152122521235212452125521265212752128521295213052131521325213352134521355213652137521385213952140521415214252143521445214552146521475214852149521505215152152521535215452155521565215752158521595216052161521625216352164521655216652167521685216952170521715217252173521745217552176521775217852179521805218152182521835218452185521865218752188521895219052191521925219352194521955219652197521985219952200522015220252203522045220552206522075220852209522105221152212522135221452215522165221752218522195222052221522225222352224522255222652227522285222952230522315223252233522345223552236522375223852239522405224152242522435224452245522465224752248522495225052251522525225352254522555225652257522585225952260522615226252263522645226552266522675226852269522705227152272522735227452275522765227752278522795228052281522825228352284522855228652287522885228952290522915229252293522945229552296522975229852299523005230152302523035230452305523065230752308523095231052311523125231352314523155231652317523185231952320523215232252323523245232552326523275232852329523305233152332523335233452335523365233752338523395234052341523425234352344523455234652347523485234952350523515235252353523545235552356523575235852359523605236152362523635236452365523665236752368523695237052371523725237352374523755237652377523785237952380523815238252383523845238552386523875238852389523905239152392523935239452395523965239752398523995240052401524025240352404524055240652407524085240952410524115241252413524145241552416524175241852419524205242152422524235242452425524265242752428524295243052431524325243352434524355243652437524385243952440524415244252443524445244552446524475244852449524505245152452524535245452455524565245752458524595246052461524625246352464524655246652467524685246952470524715247252473524745247552476524775247852479524805248152482524835248452485524865248752488524895249052491524925249352494524955249652497524985249952500525015250252503525045250552506525075250852509525105251152512525135251452515525165251752518525195252052521525225252352524525255252652527525285252952530525315253252533525345253552536525375253852539525405254152542525435254452545525465254752548525495255052551525525255352554525555255652557525585255952560525615256252563525645256552566525675256852569525705257152572525735257452575525765257752578525795258052581525825258352584525855258652587525885258952590525915259252593525945259552596525975259852599526005260152602526035260452605526065260752608526095261052611526125261352614526155261652617526185261952620526215262252623526245262552626526275262852629526305263152632526335263452635526365263752638526395264052641526425264352644526455264652647526485264952650526515265252653526545265552656526575265852659526605266152662526635266452665526665266752668526695267052671526725267352674526755267652677526785267952680526815268252683526845268552686526875268852689526905269152692526935269452695526965269752698526995270052701527025270352704527055270652707527085270952710527115271252713527145271552716527175271852719527205272152722527235272452725527265272752728527295273052731527325273352734527355273652737527385273952740527415274252743527445274552746527475274852749527505275152752527535275452755527565275752758527595276052761527625276352764527655276652767527685276952770527715277252773527745277552776527775277852779527805278152782527835278452785527865278752788527895279052791527925279352794527955279652797527985279952800528015280252803528045280552806528075280852809528105281152812528135281452815528165281752818528195282052821528225282352824528255282652827528285282952830528315283252833528345283552836528375283852839528405284152842528435284452845528465284752848528495285052851528525285352854528555285652857528585285952860528615286252863528645286552866528675286852869528705287152872528735287452875528765287752878528795288052881528825288352884528855288652887528885288952890528915289252893528945289552896528975289852899529005290152902529035290452905529065290752908529095291052911529125291352914529155291652917529185291952920529215292252923529245292552926529275292852929529305293152932529335293452935529365293752938529395294052941529425294352944529455294652947529485294952950529515295252953529545295552956529575295852959529605296152962529635296452965529665296752968529695297052971529725297352974529755297652977529785297952980529815298252983529845298552986529875298852989529905299152992529935299452995529965299752998529995300053001530025300353004530055300653007530085300953010530115301253013530145301553016530175301853019530205302153022530235302453025530265302753028530295303053031530325303353034530355303653037530385303953040530415304253043530445304553046530475304853049530505305153052530535305453055530565305753058530595306053061530625306353064530655306653067530685306953070530715307253073530745307553076530775307853079530805308153082530835308453085530865308753088530895309053091530925309353094530955309653097530985309953100531015310253103531045310553106531075310853109531105311153112531135311453115531165311753118531195312053121531225312353124531255312653127531285312953130531315313253133531345313553136531375313853139531405314153142531435314453145531465314753148531495315053151531525315353154531555315653157531585315953160531615316253163531645316553166531675316853169531705317153172531735317453175531765317753178531795318053181531825318353184531855318653187531885318953190531915319253193531945319553196531975319853199532005320153202532035320453205532065320753208532095321053211532125321353214532155321653217532185321953220532215322253223532245322553226532275322853229532305323153232532335323453235532365323753238532395324053241532425324353244532455324653247532485324953250532515325253253532545325553256532575325853259532605326153262532635326453265532665326753268532695327053271532725327353274532755327653277532785327953280532815328253283532845328553286532875328853289532905329153292532935329453295532965329753298532995330053301533025330353304533055330653307533085330953310533115331253313533145331553316533175331853319533205332153322533235332453325533265332753328533295333053331533325333353334533355333653337533385333953340533415334253343533445334553346533475334853349533505335153352533535335453355533565335753358533595336053361533625336353364533655336653367533685336953370533715337253373533745337553376533775337853379533805338153382533835338453385533865338753388533895339053391533925339353394533955339653397533985339953400534015340253403534045340553406534075340853409534105341153412534135341453415534165341753418534195342053421534225342353424534255342653427534285342953430534315343253433534345343553436534375343853439534405344153442534435344453445534465344753448534495345053451534525345353454534555345653457534585345953460534615346253463534645346553466534675346853469534705347153472534735347453475534765347753478534795348053481534825348353484534855348653487534885348953490534915349253493534945349553496534975349853499535005350153502535035350453505535065350753508535095351053511535125351353514535155351653517535185351953520535215352253523535245352553526535275352853529535305353153532535335353453535535365353753538535395354053541535425354353544535455354653547535485354953550535515355253553535545355553556535575355853559535605356153562535635356453565535665356753568535695357053571535725357353574535755357653577535785357953580535815358253583535845358553586535875358853589535905359153592535935359453595535965359753598535995360053601536025360353604536055360653607536085360953610536115361253613536145361553616536175361853619536205362153622536235362453625536265362753628536295363053631536325363353634536355363653637536385363953640536415364253643536445364553646536475364853649536505365153652536535365453655536565365753658536595366053661536625366353664536655366653667536685366953670536715367253673536745367553676536775367853679536805368153682536835368453685536865368753688536895369053691536925369353694536955369653697536985369953700537015370253703537045370553706537075370853709537105371153712537135371453715537165371753718537195372053721537225372353724537255372653727537285372953730537315373253733537345373553736537375373853739537405374153742537435374453745537465374753748537495375053751537525375353754537555375653757537585375953760537615376253763537645376553766537675376853769537705377153772537735377453775537765377753778537795378053781537825378353784537855378653787537885378953790537915379253793537945379553796537975379853799538005380153802538035380453805538065380753808538095381053811538125381353814538155381653817538185381953820538215382253823538245382553826538275382853829538305383153832538335383453835538365383753838538395384053841538425384353844538455384653847538485384953850538515385253853538545385553856538575385853859538605386153862538635386453865538665386753868538695387053871538725387353874538755387653877538785387953880538815388253883538845388553886538875388853889538905389153892538935389453895538965389753898538995390053901539025390353904539055390653907539085390953910539115391253913539145391553916539175391853919539205392153922539235392453925539265392753928539295393053931539325393353934539355393653937539385393953940539415394253943539445394553946539475394853949539505395153952539535395453955539565395753958539595396053961539625396353964539655396653967539685396953970539715397253973539745397553976539775397853979539805398153982539835398453985539865398753988539895399053991539925399353994539955399653997539985399954000540015400254003540045400554006540075400854009540105401154012540135401454015540165401754018540195402054021540225402354024540255402654027540285402954030540315403254033540345403554036540375403854039540405404154042540435404454045540465404754048540495405054051540525405354054540555405654057540585405954060540615406254063540645406554066540675406854069540705407154072540735407454075540765407754078540795408054081540825408354084540855408654087540885408954090540915409254093540945409554096540975409854099541005410154102541035410454105541065410754108541095411054111541125411354114541155411654117541185411954120541215412254123541245412554126541275412854129541305413154132541335413454135541365413754138541395414054141541425414354144541455414654147541485414954150541515415254153541545415554156541575415854159541605416154162541635416454165541665416754168541695417054171541725417354174541755417654177541785417954180541815418254183541845418554186541875418854189541905419154192541935419454195541965419754198541995420054201542025420354204542055420654207542085420954210542115421254213542145421554216542175421854219542205422154222542235422454225542265422754228542295423054231542325423354234542355423654237542385423954240542415424254243542445424554246542475424854249542505425154252542535425454255542565425754258542595426054261542625426354264542655426654267542685426954270542715427254273542745427554276542775427854279542805428154282542835428454285542865428754288542895429054291542925429354294542955429654297542985429954300543015430254303543045430554306543075430854309543105431154312543135431454315543165431754318543195432054321543225432354324543255432654327543285432954330543315433254333543345433554336543375433854339543405434154342543435434454345543465434754348543495435054351543525435354354543555435654357543585435954360543615436254363543645436554366543675436854369543705437154372543735437454375543765437754378543795438054381543825438354384543855438654387543885438954390543915439254393543945439554396543975439854399544005440154402544035440454405544065440754408544095441054411544125441354414544155441654417544185441954420544215442254423544245442554426544275442854429544305443154432544335443454435544365443754438544395444054441544425444354444544455444654447544485444954450544515445254453544545445554456544575445854459544605446154462544635446454465544665446754468544695447054471544725447354474544755447654477544785447954480544815448254483544845448554486544875448854489544905449154492544935449454495544965449754498544995450054501545025450354504545055450654507545085450954510545115451254513545145451554516545175451854519545205452154522545235452454525545265452754528545295453054531545325453354534545355453654537545385453954540545415454254543545445454554546545475454854549545505455154552545535455454555545565455754558545595456054561545625456354564545655456654567545685456954570545715457254573545745457554576545775457854579545805458154582545835458454585545865458754588545895459054591545925459354594545955459654597545985459954600546015460254603546045460554606546075460854609546105461154612546135461454615546165461754618546195462054621546225462354624546255462654627546285462954630546315463254633546345463554636546375463854639546405464154642546435464454645546465464754648546495465054651546525465354654546555465654657546585465954660546615466254663546645466554666546675466854669546705467154672546735467454675546765467754678546795468054681546825468354684546855468654687546885468954690546915469254693546945469554696546975469854699547005470154702547035470454705547065470754708547095471054711547125471354714547155471654717547185471954720547215472254723547245472554726547275472854729547305473154732547335473454735547365473754738547395474054741547425474354744547455474654747547485474954750547515475254753547545475554756547575475854759547605476154762547635476454765547665476754768547695477054771547725477354774547755477654777547785477954780547815478254783547845478554786547875478854789547905479154792547935479454795547965479754798547995480054801548025480354804548055480654807548085480954810548115481254813548145481554816548175481854819548205482154822548235482454825548265482754828548295483054831548325483354834548355483654837548385483954840548415484254843548445484554846548475484854849548505485154852548535485454855548565485754858548595486054861548625486354864548655486654867548685486954870548715487254873548745487554876548775487854879548805488154882548835488454885548865488754888548895489054891548925489354894548955489654897548985489954900549015490254903549045490554906549075490854909549105491154912549135491454915549165491754918549195492054921549225492354924549255492654927549285492954930549315493254933549345493554936549375493854939549405494154942549435494454945549465494754948549495495054951549525495354954549555495654957549585495954960549615496254963549645496554966549675496854969549705497154972549735497454975549765497754978549795498054981549825498354984549855498654987549885498954990549915499254993549945499554996549975499854999550005500155002550035500455005550065500755008550095501055011550125501355014550155501655017550185501955020550215502255023550245502555026550275502855029550305503155032550335503455035550365503755038550395504055041550425504355044550455504655047550485504955050550515505255053550545505555056550575505855059550605506155062550635506455065550665506755068550695507055071550725507355074550755507655077550785507955080550815508255083550845508555086550875508855089550905509155092550935509455095550965509755098550995510055101551025510355104551055510655107551085510955110551115511255113551145511555116551175511855119551205512155122551235512455125551265512755128551295513055131551325513355134551355513655137551385513955140551415514255143551445514555146551475514855149551505515155152551535515455155551565515755158551595516055161551625516355164551655516655167551685516955170551715517255173551745517555176551775517855179551805518155182551835518455185551865518755188551895519055191551925519355194551955519655197551985519955200552015520255203552045520555206552075520855209552105521155212552135521455215552165521755218552195522055221552225522355224552255522655227552285522955230552315523255233552345523555236552375523855239552405524155242552435524455245552465524755248552495525055251552525525355254552555525655257552585525955260552615526255263552645526555266552675526855269552705527155272552735527455275552765527755278552795528055281552825528355284552855528655287552885528955290552915529255293552945529555296552975529855299553005530155302553035530455305553065530755308553095531055311553125531355314553155531655317553185531955320553215532255323553245532555326553275532855329553305533155332553335533455335553365533755338553395534055341553425534355344553455534655347553485534955350553515535255353553545535555356553575535855359553605536155362553635536455365553665536755368553695537055371553725537355374553755537655377553785537955380553815538255383553845538555386553875538855389553905539155392553935539455395553965539755398553995540055401554025540355404554055540655407554085540955410554115541255413554145541555416554175541855419554205542155422554235542455425554265542755428554295543055431554325543355434554355543655437554385543955440554415544255443554445544555446554475544855449554505545155452554535545455455554565545755458554595546055461554625546355464554655546655467554685546955470554715547255473554745547555476554775547855479554805548155482554835548455485554865548755488554895549055491554925549355494554955549655497554985549955500555015550255503555045550555506555075550855509555105551155512555135551455515555165551755518555195552055521555225552355524555255552655527555285552955530555315553255533555345553555536555375553855539555405554155542555435554455545555465554755548555495555055551555525555355554555555555655557555585555955560555615556255563555645556555566555675556855569555705557155572555735557455575555765557755578555795558055581555825558355584555855558655587555885558955590555915559255593555945559555596555975559855599556005560155602556035560455605556065560755608556095561055611556125561355614556155561655617556185561955620556215562255623556245562555626556275562855629556305563155632556335563455635556365563755638556395564055641556425564355644556455564655647556485564955650556515565255653556545565555656556575565855659556605566155662556635566455665556665566755668556695567055671556725567355674556755567655677556785567955680556815568255683556845568555686556875568855689556905569155692556935569455695556965569755698556995570055701557025570355704557055570655707557085570955710557115571255713557145571555716557175571855719557205572155722557235572455725557265572755728557295573055731557325573355734557355573655737557385573955740557415574255743557445574555746557475574855749557505575155752557535575455755557565575755758557595576055761557625576355764557655576655767557685576955770557715577255773557745577555776557775577855779557805578155782557835578455785557865578755788557895579055791557925579355794557955579655797557985579955800558015580255803558045580555806558075580855809558105581155812558135581455815558165581755818558195582055821558225582355824558255582655827558285582955830558315583255833558345583555836558375583855839558405584155842558435584455845558465584755848558495585055851558525585355854558555585655857558585585955860558615586255863558645586555866558675586855869558705587155872558735587455875558765587755878558795588055881558825588355884558855588655887558885588955890558915589255893558945589555896558975589855899559005590155902559035590455905559065590755908559095591055911559125591355914559155591655917559185591955920559215592255923559245592555926559275592855929559305593155932559335593455935559365593755938559395594055941559425594355944559455594655947559485594955950559515595255953559545595555956559575595855959559605596155962559635596455965559665596755968559695597055971559725597355974559755597655977559785597955980559815598255983559845598555986559875598855989559905599155992559935599455995559965599755998559995600056001560025600356004560055600656007560085600956010560115601256013560145601556016560175601856019560205602156022560235602456025560265602756028560295603056031560325603356034560355603656037560385603956040560415604256043560445604556046560475604856049560505605156052560535605456055560565605756058560595606056061560625606356064560655606656067560685606956070560715607256073560745607556076560775607856079560805608156082560835608456085560865608756088560895609056091560925609356094560955609656097560985609956100561015610256103561045610556106561075610856109561105611156112561135611456115561165611756118561195612056121561225612356124561255612656127561285612956130561315613256133561345613556136561375613856139561405614156142561435614456145561465614756148561495615056151561525615356154561555615656157561585615956160561615616256163561645616556166561675616856169561705617156172561735617456175561765617756178561795618056181561825618356184561855618656187561885618956190561915619256193561945619556196561975619856199562005620156202562035620456205562065620756208562095621056211562125621356214562155621656217562185621956220562215622256223562245622556226562275622856229562305623156232562335623456235562365623756238562395624056241562425624356244562455624656247562485624956250562515625256253562545625556256562575625856259562605626156262562635626456265562665626756268562695627056271562725627356274562755627656277562785627956280562815628256283562845628556286562875628856289562905629156292562935629456295562965629756298562995630056301563025630356304563055630656307563085630956310563115631256313563145631556316563175631856319563205632156322563235632456325563265632756328563295633056331563325633356334563355633656337563385633956340563415634256343563445634556346563475634856349563505635156352563535635456355563565635756358563595636056361563625636356364563655636656367563685636956370563715637256373563745637556376563775637856379563805638156382563835638456385563865638756388563895639056391563925639356394563955639656397563985639956400564015640256403564045640556406564075640856409564105641156412564135641456415564165641756418564195642056421564225642356424564255642656427564285642956430564315643256433564345643556436564375643856439564405644156442564435644456445564465644756448564495645056451564525645356454564555645656457564585645956460564615646256463564645646556466564675646856469564705647156472564735647456475564765647756478564795648056481564825648356484564855648656487564885648956490564915649256493564945649556496564975649856499565005650156502565035650456505565065650756508565095651056511565125651356514565155651656517565185651956520565215652256523565245652556526565275652856529565305653156532565335653456535565365653756538565395654056541565425654356544565455654656547565485654956550565515655256553565545655556556565575655856559565605656156562565635656456565565665656756568565695657056571565725657356574565755657656577565785657956580565815658256583565845658556586565875658856589565905659156592565935659456595565965659756598565995660056601566025660356604566055660656607566085660956610566115661256613566145661556616566175661856619566205662156622566235662456625566265662756628566295663056631566325663356634566355663656637566385663956640566415664256643566445664556646566475664856649566505665156652566535665456655566565665756658566595666056661566625666356664566655666656667566685666956670566715667256673566745667556676566775667856679566805668156682566835668456685566865668756688566895669056691566925669356694566955669656697566985669956700567015670256703567045670556706567075670856709567105671156712567135671456715567165671756718567195672056721567225672356724567255672656727567285672956730567315673256733567345673556736567375673856739567405674156742567435674456745567465674756748567495675056751567525675356754567555675656757567585675956760567615676256763567645676556766567675676856769567705677156772567735677456775567765677756778567795678056781567825678356784567855678656787567885678956790567915679256793567945679556796567975679856799568005680156802568035680456805568065680756808568095681056811568125681356814568155681656817568185681956820568215682256823568245682556826568275682856829568305683156832568335683456835568365683756838568395684056841568425684356844568455684656847568485684956850568515685256853568545685556856568575685856859568605686156862568635686456865568665686756868568695687056871568725687356874568755687656877568785687956880568815688256883568845688556886568875688856889568905689156892568935689456895568965689756898568995690056901569025690356904569055690656907569085690956910569115691256913569145691556916569175691856919569205692156922569235692456925569265692756928569295693056931569325693356934569355693656937569385693956940569415694256943569445694556946569475694856949569505695156952569535695456955569565695756958569595696056961569625696356964569655696656967569685696956970569715697256973569745697556976569775697856979569805698156982569835698456985569865698756988569895699056991569925699356994569955699656997569985699957000570015700257003570045700557006570075700857009570105701157012570135701457015570165701757018570195702057021570225702357024570255702657027570285702957030570315703257033570345703557036570375703857039570405704157042570435704457045570465704757048570495705057051570525705357054570555705657057570585705957060570615706257063570645706557066570675706857069570705707157072570735707457075570765707757078570795708057081570825708357084570855708657087570885708957090570915709257093570945709557096570975709857099571005710157102571035710457105571065710757108571095711057111571125711357114571155711657117571185711957120571215712257123571245712557126571275712857129571305713157132571335713457135571365713757138571395714057141571425714357144571455714657147571485714957150571515715257153571545715557156571575715857159571605716157162571635716457165571665716757168571695717057171571725717357174571755717657177571785717957180571815718257183571845718557186571875718857189571905719157192571935719457195571965719757198571995720057201572025720357204572055720657207572085720957210572115721257213572145721557216572175721857219572205722157222572235722457225572265722757228572295723057231572325723357234572355723657237572385723957240572415724257243572445724557246572475724857249572505725157252572535725457255572565725757258572595726057261572625726357264572655726657267572685726957270572715727257273572745727557276572775727857279572805728157282572835728457285572865728757288572895729057291572925729357294572955729657297572985729957300573015730257303573045730557306573075730857309573105731157312573135731457315573165731757318573195732057321573225732357324573255732657327573285732957330573315733257333573345733557336573375733857339573405734157342573435734457345573465734757348573495735057351573525735357354573555735657357573585735957360573615736257363573645736557366573675736857369573705737157372573735737457375573765737757378573795738057381573825738357384573855738657387573885738957390573915739257393573945739557396573975739857399574005740157402574035740457405574065740757408574095741057411574125741357414574155741657417574185741957420574215742257423574245742557426574275742857429574305743157432574335743457435574365743757438574395744057441574425744357444574455744657447574485744957450574515745257453574545745557456574575745857459574605746157462574635746457465574665746757468574695747057471574725747357474574755747657477574785747957480574815748257483574845748557486574875748857489574905749157492574935749457495574965749757498574995750057501575025750357504575055750657507575085750957510575115751257513575145751557516575175751857519575205752157522575235752457525575265752757528575295753057531575325753357534575355753657537575385753957540575415754257543575445754557546575475754857549575505755157552575535755457555575565755757558575595756057561575625756357564575655756657567575685756957570575715757257573575745757557576575775757857579575805758157582575835758457585575865758757588575895759057591575925759357594575955759657597575985759957600576015760257603576045760557606576075760857609576105761157612576135761457615576165761757618576195762057621576225762357624576255762657627576285762957630576315763257633576345763557636576375763857639576405764157642576435764457645576465764757648576495765057651576525765357654576555765657657576585765957660576615766257663576645766557666576675766857669576705767157672576735767457675576765767757678576795768057681576825768357684576855768657687576885768957690576915769257693576945769557696576975769857699577005770157702577035770457705577065770757708577095771057711577125771357714577155771657717577185771957720577215772257723577245772557726577275772857729577305773157732577335773457735577365773757738577395774057741577425774357744577455774657747577485774957750577515775257753577545775557756577575775857759577605776157762577635776457765577665776757768577695777057771577725777357774577755777657777577785777957780577815778257783577845778557786577875778857789577905779157792577935779457795577965779757798577995780057801578025780357804578055780657807578085780957810578115781257813578145781557816578175781857819578205782157822578235782457825578265782757828578295783057831578325783357834578355783657837578385783957840578415784257843578445784557846578475784857849578505785157852578535785457855578565785757858578595786057861578625786357864578655786657867578685786957870578715787257873578745787557876578775787857879578805788157882578835788457885578865788757888578895789057891578925789357894578955789657897578985789957900579015790257903579045790557906579075790857909579105791157912579135791457915579165791757918579195792057921579225792357924579255792657927579285792957930579315793257933579345793557936579375793857939579405794157942579435794457945579465794757948579495795057951579525795357954579555795657957579585795957960579615796257963579645796557966579675796857969579705797157972579735797457975579765797757978579795798057981579825798357984579855798657987579885798957990579915799257993579945799557996579975799857999580005800158002580035800458005580065800758008580095801058011580125801358014580155801658017580185801958020580215802258023580245802558026580275802858029580305803158032580335803458035580365803758038580395804058041580425804358044580455804658047580485804958050580515805258053580545805558056580575805858059580605806158062580635806458065580665806758068580695807058071580725807358074580755807658077580785807958080580815808258083580845808558086580875808858089580905809158092580935809458095580965809758098580995810058101581025810358104581055810658107581085810958110581115811258113581145811558116581175811858119581205812158122581235812458125581265812758128581295813058131581325813358134581355813658137581385813958140581415814258143581445814558146581475814858149581505815158152581535815458155581565815758158581595816058161581625816358164581655816658167581685816958170581715817258173581745817558176581775817858179581805818158182581835818458185581865818758188581895819058191581925819358194581955819658197581985819958200582015820258203582045820558206582075820858209582105821158212582135821458215582165821758218582195822058221582225822358224582255822658227582285822958230582315823258233582345823558236582375823858239582405824158242582435824458245582465824758248582495825058251582525825358254582555825658257582585825958260582615826258263582645826558266582675826858269582705827158272582735827458275582765827758278582795828058281582825828358284582855828658287582885828958290582915829258293582945829558296582975829858299583005830158302583035830458305583065830758308583095831058311583125831358314583155831658317583185831958320583215832258323583245832558326583275832858329583305833158332583335833458335583365833758338583395834058341583425834358344583455834658347583485834958350583515835258353583545835558356583575835858359583605836158362583635836458365583665836758368583695837058371583725837358374583755837658377583785837958380583815838258383583845838558386583875838858389583905839158392583935839458395583965839758398583995840058401584025840358404584055840658407584085840958410584115841258413584145841558416584175841858419584205842158422584235842458425584265842758428584295843058431584325843358434584355843658437584385843958440584415844258443584445844558446584475844858449584505845158452584535845458455584565845758458584595846058461584625846358464584655846658467584685846958470584715847258473584745847558476584775847858479584805848158482584835848458485584865848758488584895849058491584925849358494584955849658497584985849958500585015850258503585045850558506585075850858509585105851158512585135851458515585165851758518585195852058521585225852358524585255852658527585285852958530585315853258533585345853558536585375853858539585405854158542585435854458545585465854758548585495855058551585525855358554585555855658557585585855958560585615856258563585645856558566585675856858569585705857158572585735857458575585765857758578585795858058581585825858358584585855858658587585885858958590585915859258593585945859558596585975859858599586005860158602586035860458605586065860758608586095861058611586125861358614586155861658617586185861958620586215862258623586245862558626586275862858629586305863158632586335863458635586365863758638586395864058641586425864358644586455864658647586485864958650586515865258653586545865558656586575865858659586605866158662586635866458665586665866758668586695867058671586725867358674586755867658677586785867958680586815868258683586845868558686586875868858689586905869158692586935869458695586965869758698586995870058701587025870358704587055870658707587085870958710587115871258713587145871558716587175871858719587205872158722587235872458725587265872758728587295873058731587325873358734587355873658737587385873958740587415874258743587445874558746587475874858749587505875158752587535875458755587565875758758587595876058761587625876358764587655876658767587685876958770587715877258773587745877558776587775877858779587805878158782587835878458785587865878758788587895879058791587925879358794587955879658797587985879958800588015880258803588045880558806588075880858809588105881158812588135881458815588165881758818588195882058821588225882358824588255882658827588285882958830588315883258833588345883558836588375883858839588405884158842588435884458845588465884758848588495885058851588525885358854588555885658857588585885958860588615886258863588645886558866588675886858869588705887158872588735887458875588765887758878588795888058881588825888358884588855888658887588885888958890588915889258893588945889558896588975889858899589005890158902589035890458905589065890758908589095891058911589125891358914589155891658917589185891958920589215892258923589245892558926589275892858929589305893158932589335893458935589365893758938589395894058941589425894358944589455894658947589485894958950589515895258953589545895558956589575895858959589605896158962589635896458965589665896758968589695897058971589725897358974589755897658977589785897958980589815898258983589845898558986589875898858989589905899158992589935899458995589965899758998589995900059001590025900359004590055900659007590085900959010590115901259013590145901559016590175901859019590205902159022590235902459025590265902759028590295903059031590325903359034590355903659037590385903959040590415904259043590445904559046590475904859049590505905159052590535905459055590565905759058590595906059061590625906359064590655906659067590685906959070590715907259073590745907559076590775907859079590805908159082590835908459085590865908759088590895909059091590925909359094590955909659097590985909959100591015910259103591045910559106591075910859109591105911159112591135911459115591165911759118591195912059121591225912359124591255912659127591285912959130591315913259133591345913559136591375913859139591405914159142591435914459145591465914759148591495915059151591525915359154591555915659157591585915959160591615916259163591645916559166591675916859169591705917159172591735917459175591765917759178591795918059181591825918359184591855918659187591885918959190591915919259193591945919559196591975919859199592005920159202592035920459205592065920759208592095921059211592125921359214592155921659217592185921959220592215922259223592245922559226592275922859229592305923159232592335923459235592365923759238592395924059241592425924359244592455924659247592485924959250592515925259253592545925559256592575925859259592605926159262592635926459265592665926759268592695927059271592725927359274592755927659277592785927959280592815928259283592845928559286592875928859289592905929159292592935929459295592965929759298592995930059301593025930359304593055930659307593085930959310593115931259313593145931559316593175931859319593205932159322593235932459325593265932759328593295933059331593325933359334593355933659337593385933959340593415934259343593445934559346593475934859349593505935159352593535935459355593565935759358593595936059361593625936359364593655936659367593685936959370593715937259373593745937559376593775937859379593805938159382593835938459385593865938759388593895939059391593925939359394593955939659397593985939959400594015940259403594045940559406594075940859409594105941159412594135941459415594165941759418594195942059421594225942359424594255942659427594285942959430594315943259433594345943559436594375943859439594405944159442594435944459445594465944759448594495945059451594525945359454594555945659457594585945959460594615946259463594645946559466594675946859469594705947159472594735947459475594765947759478594795948059481594825948359484594855948659487594885948959490594915949259493594945949559496594975949859499595005950159502595035950459505595065950759508595095951059511595125951359514595155951659517595185951959520595215952259523595245952559526595275952859529595305953159532595335953459535595365953759538595395954059541595425954359544595455954659547595485954959550595515955259553595545955559556595575955859559595605956159562595635956459565595665956759568595695957059571595725957359574595755957659577595785957959580595815958259583595845958559586595875958859589595905959159592595935959459595595965959759598595995960059601596025960359604596055960659607596085960959610596115961259613596145961559616596175961859619596205962159622596235962459625596265962759628596295963059631596325963359634596355963659637596385963959640596415964259643596445964559646596475964859649596505965159652596535965459655596565965759658596595966059661596625966359664596655966659667596685966959670596715967259673596745967559676596775967859679596805968159682596835968459685596865968759688596895969059691596925969359694596955969659697596985969959700597015970259703597045970559706597075970859709597105971159712597135971459715597165971759718597195972059721597225972359724597255972659727597285972959730597315973259733597345973559736597375973859739597405974159742597435974459745597465974759748597495975059751597525975359754597555975659757597585975959760597615976259763597645976559766597675976859769597705977159772597735977459775597765977759778597795978059781597825978359784597855978659787597885978959790597915979259793597945979559796597975979859799598005980159802598035980459805598065980759808598095981059811598125981359814598155981659817598185981959820598215982259823598245982559826598275982859829598305983159832598335983459835598365983759838598395984059841598425984359844598455984659847598485984959850598515985259853598545985559856598575985859859598605986159862598635986459865598665986759868598695987059871598725987359874598755987659877598785987959880598815988259883598845988559886598875988859889598905989159892598935989459895598965989759898598995990059901599025990359904599055990659907599085990959910599115991259913599145991559916599175991859919599205992159922599235992459925599265992759928599295993059931599325993359934599355993659937599385993959940599415994259943599445994559946599475994859949599505995159952599535995459955599565995759958599595996059961599625996359964599655996659967599685996959970599715997259973599745997559976599775997859979599805998159982599835998459985599865998759988599895999059991599925999359994599955999659997599985999960000600016000260003600046000560006600076000860009600106001160012600136001460015600166001760018600196002060021600226002360024600256002660027600286002960030600316003260033600346003560036600376003860039600406004160042600436004460045600466004760048600496005060051600526005360054600556005660057600586005960060600616006260063600646006560066600676006860069600706007160072600736007460075600766007760078600796008060081600826008360084600856008660087600886008960090600916009260093600946009560096600976009860099601006010160102601036010460105601066010760108601096011060111601126011360114601156011660117601186011960120601216012260123601246012560126601276012860129601306013160132601336013460135601366013760138601396014060141601426014360144601456014660147601486014960150601516015260153601546015560156601576015860159601606016160162601636016460165601666016760168601696017060171601726017360174601756017660177601786017960180601816018260183601846018560186601876018860189601906019160192601936019460195601966019760198601996020060201602026020360204602056020660207602086020960210602116021260213602146021560216602176021860219602206022160222602236022460225602266022760228602296023060231602326023360234602356023660237602386023960240602416024260243602446024560246602476024860249602506025160252602536025460255602566025760258602596026060261602626026360264602656026660267602686026960270602716027260273602746027560276602776027860279602806028160282602836028460285602866028760288602896029060291602926029360294602956029660297602986029960300603016030260303603046030560306603076030860309603106031160312603136031460315603166031760318603196032060321603226032360324603256032660327603286032960330603316033260333603346033560336603376033860339603406034160342603436034460345603466034760348603496035060351603526035360354603556035660357603586035960360603616036260363603646036560366603676036860369603706037160372603736037460375603766037760378603796038060381603826038360384603856038660387603886038960390603916039260393603946039560396603976039860399604006040160402604036040460405604066040760408604096041060411604126041360414604156041660417604186041960420604216042260423604246042560426604276042860429604306043160432604336043460435604366043760438604396044060441604426044360444604456044660447604486044960450604516045260453604546045560456604576045860459604606046160462604636046460465604666046760468604696047060471604726047360474604756047660477604786047960480604816048260483604846048560486604876048860489604906049160492604936049460495604966049760498604996050060501605026050360504605056050660507605086050960510605116051260513605146051560516605176051860519605206052160522605236052460525605266052760528605296053060531605326053360534605356053660537605386053960540605416054260543605446054560546605476054860549605506055160552605536055460555605566055760558605596056060561605626056360564605656056660567605686056960570605716057260573605746057560576605776057860579605806058160582605836058460585605866058760588605896059060591605926059360594605956059660597605986059960600606016060260603606046060560606606076060860609606106061160612606136061460615606166061760618606196062060621606226062360624606256062660627606286062960630606316063260633606346063560636606376063860639606406064160642606436064460645606466064760648606496065060651606526065360654606556065660657606586065960660606616066260663606646066560666606676066860669606706067160672606736067460675606766067760678606796068060681606826068360684606856068660687606886068960690606916069260693606946069560696606976069860699607006070160702607036070460705607066070760708607096071060711607126071360714607156071660717607186071960720607216072260723607246072560726607276072860729607306073160732607336073460735607366073760738607396074060741607426074360744607456074660747607486074960750607516075260753607546075560756607576075860759607606076160762607636076460765607666076760768607696077060771607726077360774607756077660777607786077960780607816078260783607846078560786607876078860789607906079160792607936079460795607966079760798607996080060801608026080360804608056080660807608086080960810608116081260813608146081560816608176081860819608206082160822608236082460825608266082760828608296083060831608326083360834608356083660837608386083960840608416084260843608446084560846608476084860849608506085160852608536085460855608566085760858608596086060861608626086360864608656086660867608686086960870608716087260873608746087560876608776087860879608806088160882608836088460885608866088760888608896089060891608926089360894608956089660897608986089960900609016090260903609046090560906609076090860909609106091160912609136091460915609166091760918609196092060921609226092360924609256092660927609286092960930609316093260933609346093560936609376093860939609406094160942609436094460945609466094760948609496095060951609526095360954609556095660957609586095960960609616096260963609646096560966609676096860969609706097160972609736097460975609766097760978609796098060981609826098360984609856098660987609886098960990609916099260993609946099560996609976099860999610006100161002610036100461005610066100761008610096101061011610126101361014610156101661017610186101961020610216102261023610246102561026610276102861029610306103161032610336103461035610366103761038610396104061041610426104361044610456104661047610486104961050610516105261053610546105561056610576105861059610606106161062610636106461065610666106761068610696107061071610726107361074610756107661077610786107961080610816108261083610846108561086610876108861089610906109161092610936109461095610966109761098610996110061101611026110361104611056110661107611086110961110611116111261113611146111561116611176111861119611206112161122611236112461125611266112761128611296113061131611326113361134611356113661137611386113961140611416114261143611446114561146611476114861149611506115161152611536115461155611566115761158611596116061161611626116361164611656116661167611686116961170611716117261173611746117561176611776117861179611806118161182611836118461185611866118761188611896119061191611926119361194611956119661197611986119961200612016120261203612046120561206612076120861209612106121161212612136121461215612166121761218612196122061221612226122361224612256122661227612286122961230612316123261233612346123561236612376123861239612406124161242612436124461245612466124761248612496125061251612526125361254612556125661257612586125961260612616126261263612646126561266612676126861269612706127161272612736127461275612766127761278612796128061281612826128361284612856128661287612886128961290612916129261293612946129561296612976129861299613006130161302613036130461305613066130761308613096131061311613126131361314613156131661317613186131961320613216132261323613246132561326613276132861329613306133161332613336133461335613366133761338613396134061341613426134361344613456134661347613486134961350613516135261353613546135561356613576135861359613606136161362613636136461365613666136761368613696137061371613726137361374613756137661377613786137961380613816138261383613846138561386613876138861389613906139161392613936139461395613966139761398613996140061401614026140361404614056140661407614086140961410614116141261413614146141561416614176141861419614206142161422614236142461425614266142761428614296143061431614326143361434614356143661437614386143961440614416144261443614446144561446614476144861449614506145161452614536145461455614566145761458614596146061461614626146361464614656146661467614686146961470614716147261473614746147561476614776147861479614806148161482614836148461485614866148761488614896149061491614926149361494614956149661497614986149961500615016150261503615046150561506615076150861509615106151161512615136151461515615166151761518615196152061521615226152361524615256152661527615286152961530615316153261533615346153561536615376153861539615406154161542615436154461545615466154761548615496155061551615526155361554615556155661557615586155961560615616156261563615646156561566615676156861569615706157161572615736157461575615766157761578615796158061581615826158361584615856158661587615886158961590615916159261593615946159561596615976159861599616006160161602616036160461605616066160761608616096161061611616126161361614616156161661617616186161961620616216162261623616246162561626616276162861629616306163161632616336163461635616366163761638616396164061641616426164361644616456164661647616486164961650616516165261653616546165561656616576165861659616606166161662616636166461665616666166761668616696167061671616726167361674616756167661677616786167961680616816168261683616846168561686616876168861689616906169161692616936169461695616966169761698616996170061701617026170361704617056170661707617086170961710617116171261713617146171561716617176171861719617206172161722617236172461725617266172761728617296173061731617326173361734617356173661737617386173961740617416174261743617446174561746617476174861749617506175161752617536175461755617566175761758617596176061761617626176361764617656176661767617686176961770617716177261773617746177561776617776177861779617806178161782617836178461785617866178761788617896179061791617926179361794617956179661797617986179961800618016180261803618046180561806618076180861809618106181161812618136181461815618166181761818618196182061821618226182361824618256182661827618286182961830618316183261833618346183561836618376183861839618406184161842618436184461845618466184761848618496185061851618526185361854618556185661857618586185961860618616186261863618646186561866618676186861869618706187161872618736187461875618766187761878618796188061881618826188361884618856188661887618886188961890618916189261893618946189561896618976189861899619006190161902619036190461905619066190761908619096191061911619126191361914619156191661917619186191961920619216192261923619246192561926619276192861929619306193161932619336193461935619366193761938619396194061941619426194361944619456194661947619486194961950619516195261953619546195561956619576195861959619606196161962619636196461965619666196761968619696197061971619726197361974619756197661977619786197961980619816198261983619846198561986619876198861989619906199161992619936199461995619966199761998619996200062001620026200362004620056200662007620086200962010620116201262013620146201562016620176201862019620206202162022620236202462025620266202762028620296203062031620326203362034620356203662037620386203962040620416204262043620446204562046620476204862049620506205162052620536205462055620566205762058620596206062061620626206362064620656206662067620686206962070620716207262073620746207562076620776207862079620806208162082620836208462085620866208762088620896209062091620926209362094620956209662097620986209962100621016210262103621046210562106621076210862109621106211162112621136211462115621166211762118621196212062121621226212362124621256212662127621286212962130621316213262133621346213562136621376213862139621406214162142621436214462145621466214762148621496215062151621526215362154621556215662157621586215962160621616216262163621646216562166621676216862169621706217162172621736217462175621766217762178621796218062181621826218362184621856218662187621886218962190621916219262193621946219562196621976219862199622006220162202622036220462205622066220762208622096221062211622126221362214622156221662217622186221962220622216222262223622246222562226622276222862229622306223162232622336223462235622366223762238622396224062241622426224362244622456224662247622486224962250622516225262253622546225562256622576225862259622606226162262622636226462265622666226762268622696227062271622726227362274622756227662277622786227962280622816228262283622846228562286622876228862289622906229162292622936229462295622966229762298622996230062301623026230362304623056230662307623086230962310623116231262313623146231562316623176231862319623206232162322623236232462325623266232762328623296233062331623326233362334623356233662337623386233962340623416234262343623446234562346623476234862349623506235162352623536235462355623566235762358623596236062361623626236362364623656236662367623686236962370623716237262373623746237562376623776237862379623806238162382623836238462385623866238762388623896239062391623926239362394623956239662397623986239962400624016240262403624046240562406624076240862409624106241162412624136241462415624166241762418624196242062421624226242362424624256242662427624286242962430624316243262433624346243562436624376243862439624406244162442624436244462445624466244762448624496245062451624526245362454624556245662457624586245962460624616246262463624646246562466624676246862469624706247162472624736247462475624766247762478624796248062481624826248362484624856248662487624886248962490624916249262493624946249562496624976249862499625006250162502625036250462505625066250762508625096251062511625126251362514625156251662517625186251962520625216252262523625246252562526625276252862529625306253162532625336253462535625366253762538625396254062541625426254362544625456254662547625486254962550625516255262553625546255562556625576255862559625606256162562625636256462565625666256762568625696257062571625726257362574625756257662577625786257962580625816258262583625846258562586625876258862589625906259162592625936259462595625966259762598625996260062601626026260362604626056260662607626086260962610626116261262613626146261562616626176261862619626206262162622626236262462625626266262762628626296263062631626326263362634626356263662637626386263962640626416264262643626446264562646626476264862649626506265162652626536265462655626566265762658626596266062661626626266362664626656266662667626686266962670626716267262673626746267562676626776267862679626806268162682626836268462685626866268762688626896269062691626926269362694626956269662697626986269962700627016270262703627046270562706627076270862709627106271162712627136271462715627166271762718627196272062721627226272362724627256272662727627286272962730627316273262733627346273562736627376273862739627406274162742627436274462745627466274762748627496275062751627526275362754627556275662757627586275962760627616276262763627646276562766627676276862769627706277162772627736277462775627766277762778627796278062781627826278362784627856278662787627886278962790627916279262793627946279562796627976279862799628006280162802628036280462805628066280762808628096281062811628126281362814628156281662817628186281962820628216282262823628246282562826628276282862829628306283162832628336283462835628366283762838628396284062841628426284362844628456284662847628486284962850628516285262853628546285562856628576285862859628606286162862628636286462865628666286762868628696287062871628726287362874628756287662877628786287962880628816288262883628846288562886628876288862889628906289162892628936289462895628966289762898628996290062901629026290362904629056290662907629086290962910629116291262913629146291562916629176291862919629206292162922629236292462925629266292762928629296293062931629326293362934629356293662937629386293962940629416294262943629446294562946629476294862949629506295162952629536295462955629566295762958629596296062961629626296362964629656296662967629686296962970629716297262973629746297562976629776297862979629806298162982629836298462985629866298762988629896299062991629926299362994629956299662997629986299963000630016300263003630046300563006630076300863009630106301163012630136301463015630166301763018630196302063021630226302363024630256302663027630286302963030630316303263033630346303563036630376303863039630406304163042630436304463045630466304763048630496305063051630526305363054630556305663057630586305963060630616306263063630646306563066630676306863069630706307163072630736307463075630766307763078630796308063081630826308363084630856308663087630886308963090630916309263093630946309563096630976309863099631006310163102631036310463105631066310763108631096311063111631126311363114631156311663117631186311963120631216312263123631246312563126631276312863129631306313163132631336313463135631366313763138631396314063141631426314363144631456314663147631486314963150631516315263153631546315563156631576315863159631606316163162631636316463165631666316763168631696317063171631726317363174631756317663177631786317963180631816318263183631846318563186631876318863189631906319163192631936319463195631966319763198631996320063201632026320363204632056320663207632086320963210632116321263213632146321563216632176321863219632206322163222632236322463225632266322763228632296323063231632326323363234632356323663237632386323963240632416324263243632446324563246632476324863249632506325163252632536325463255632566325763258632596326063261632626326363264632656326663267632686326963270632716327263273632746327563276632776327863279632806328163282632836328463285632866328763288632896329063291632926329363294632956329663297632986329963300633016330263303633046330563306633076330863309633106331163312633136331463315633166331763318633196332063321633226332363324633256332663327633286332963330633316333263333633346333563336633376333863339633406334163342633436334463345633466334763348633496335063351633526335363354633556335663357633586335963360633616336263363633646336563366633676336863369633706337163372633736337463375633766337763378633796338063381633826338363384633856338663387633886338963390633916339263393633946339563396633976339863399634006340163402634036340463405634066340763408634096341063411634126341363414634156341663417634186341963420634216342263423634246342563426634276342863429634306343163432634336343463435634366343763438634396344063441634426344363444634456344663447634486344963450634516345263453634546345563456634576345863459634606346163462634636346463465634666346763468634696347063471634726347363474634756347663477634786347963480634816348263483634846348563486634876348863489634906349163492634936349463495634966349763498634996350063501635026350363504635056350663507635086350963510635116351263513635146351563516635176351863519635206352163522635236352463525635266352763528635296353063531635326353363534635356353663537635386353963540635416354263543635446354563546635476354863549635506355163552635536355463555635566355763558635596356063561635626356363564635656356663567635686356963570635716357263573635746357563576635776357863579635806358163582635836358463585635866358763588635896359063591635926359363594635956359663597635986359963600636016360263603636046360563606636076360863609636106361163612636136361463615636166361763618636196362063621636226362363624636256362663627636286362963630636316363263633636346363563636636376363863639636406364163642636436364463645636466364763648636496365063651636526365363654636556365663657636586365963660636616366263663636646366563666636676366863669636706367163672636736367463675636766367763678636796368063681636826368363684636856368663687636886368963690636916369263693636946369563696636976369863699637006370163702637036370463705637066370763708637096371063711637126371363714637156371663717637186371963720637216372263723637246372563726637276372863729637306373163732637336373463735637366373763738637396374063741637426374363744637456374663747637486374963750637516375263753637546375563756637576375863759637606376163762637636376463765637666376763768637696377063771637726377363774637756377663777637786377963780637816378263783637846378563786637876378863789637906379163792637936379463795637966379763798637996380063801638026380363804638056380663807638086380963810638116381263813638146381563816638176381863819638206382163822638236382463825638266382763828638296383063831638326383363834638356383663837638386383963840638416384263843638446384563846638476384863849638506385163852638536385463855638566385763858638596386063861638626386363864638656386663867638686386963870638716387263873638746387563876638776387863879638806388163882638836388463885638866388763888638896389063891638926389363894638956389663897638986389963900639016390263903639046390563906639076390863909639106391163912639136391463915639166391763918639196392063921639226392363924639256392663927639286392963930639316393263933639346393563936639376393863939639406394163942639436394463945639466394763948639496395063951639526395363954639556395663957639586395963960639616396263963639646396563966639676396863969639706397163972639736397463975639766397763978639796398063981639826398363984639856398663987639886398963990639916399263993639946399563996639976399863999640006400164002640036400464005640066400764008640096401064011640126401364014640156401664017640186401964020640216402264023640246402564026640276402864029640306403164032640336403464035640366403764038640396404064041640426404364044640456404664047640486404964050640516405264053640546405564056640576405864059640606406164062640636406464065640666406764068640696407064071640726407364074640756407664077640786407964080640816408264083640846408564086640876408864089640906409164092640936409464095640966409764098640996410064101641026410364104641056410664107641086410964110641116411264113641146411564116641176411864119641206412164122641236412464125641266412764128641296413064131641326413364134641356413664137641386413964140641416414264143641446414564146641476414864149641506415164152641536415464155641566415764158641596416064161641626416364164641656416664167641686416964170641716417264173641746417564176641776417864179641806418164182641836418464185641866418764188641896419064191641926419364194641956419664197641986419964200642016420264203642046420564206642076420864209642106421164212642136421464215642166421764218642196422064221642226422364224642256422664227642286422964230642316423264233642346423564236642376423864239642406424164242642436424464245642466424764248642496425064251642526425364254642556425664257642586425964260642616426264263642646426564266642676426864269642706427164272642736427464275642766427764278642796428064281642826428364284642856428664287642886428964290642916429264293642946429564296642976429864299643006430164302643036430464305643066430764308643096431064311643126431364314643156431664317643186431964320643216432264323643246432564326643276432864329643306433164332643336433464335643366433764338643396434064341643426434364344643456434664347643486434964350643516435264353643546435564356643576435864359643606436164362643636436464365643666436764368643696437064371643726437364374643756437664377643786437964380643816438264383643846438564386643876438864389643906439164392643936439464395643966439764398643996440064401644026440364404644056440664407644086440964410644116441264413644146441564416644176441864419644206442164422644236442464425644266442764428644296443064431644326443364434644356443664437644386443964440644416444264443644446444564446644476444864449644506445164452644536445464455644566445764458644596446064461644626446364464644656446664467644686446964470644716447264473644746447564476644776447864479644806448164482644836448464485644866448764488644896449064491644926449364494644956449664497644986449964500645016450264503645046450564506645076450864509645106451164512645136451464515645166451764518645196452064521645226452364524645256452664527645286452964530645316453264533645346453564536645376453864539645406454164542645436454464545645466454764548645496455064551645526455364554645556455664557645586455964560645616456264563645646456564566645676456864569645706457164572645736457464575645766457764578645796458064581645826458364584645856458664587645886458964590645916459264593645946459564596645976459864599646006460164602646036460464605646066460764608646096461064611646126461364614646156461664617646186461964620646216462264623646246462564626646276462864629646306463164632646336463464635646366463764638646396464064641646426464364644646456464664647646486464964650646516465264653646546465564656646576465864659646606466164662646636466464665646666466764668646696467064671646726467364674646756467664677646786467964680646816468264683646846468564686646876468864689646906469164692646936469464695646966469764698646996470064701647026470364704647056470664707647086470964710647116471264713647146471564716647176471864719647206472164722647236472464725647266472764728647296473064731647326473364734647356473664737647386473964740647416474264743647446474564746647476474864749647506475164752647536475464755647566475764758647596476064761647626476364764647656476664767647686476964770647716477264773647746477564776647776477864779647806478164782647836478464785647866478764788647896479064791647926479364794647956479664797647986479964800648016480264803648046480564806648076480864809648106481164812648136481464815648166481764818648196482064821648226482364824648256482664827648286482964830648316483264833648346483564836648376483864839648406484164842648436484464845648466484764848648496485064851648526485364854648556485664857648586485964860648616486264863648646486564866648676486864869648706487164872648736487464875648766487764878648796488064881648826488364884648856488664887648886488964890648916489264893648946489564896648976489864899649006490164902649036490464905649066490764908649096491064911649126491364914649156491664917649186491964920649216492264923649246492564926649276492864929649306493164932649336493464935649366493764938649396494064941649426494364944649456494664947649486494964950649516495264953649546495564956649576495864959649606496164962649636496464965649666496764968649696497064971649726497364974649756497664977649786497964980649816498264983649846498564986649876498864989649906499164992649936499464995649966499764998649996500065001650026500365004650056500665007650086500965010650116501265013650146501565016650176501865019650206502165022650236502465025650266502765028650296503065031650326503365034650356503665037650386503965040650416504265043650446504565046650476504865049650506505165052650536505465055650566505765058650596506065061650626506365064650656506665067650686506965070650716507265073650746507565076650776507865079650806508165082650836508465085650866508765088650896509065091650926509365094650956509665097650986509965100651016510265103651046510565106651076510865109651106511165112651136511465115651166511765118651196512065121651226512365124651256512665127651286512965130651316513265133651346513565136651376513865139651406514165142651436514465145651466514765148651496515065151651526515365154651556515665157651586515965160651616516265163651646516565166651676516865169651706517165172651736517465175651766517765178651796518065181651826518365184651856518665187651886518965190651916519265193651946519565196651976519865199652006520165202652036520465205652066520765208652096521065211652126521365214652156521665217652186521965220652216522265223652246522565226652276522865229652306523165232652336523465235652366523765238652396524065241652426524365244652456524665247652486524965250652516525265253652546525565256652576525865259652606526165262652636526465265652666526765268652696527065271652726527365274652756527665277652786527965280652816528265283652846528565286652876528865289652906529165292652936529465295652966529765298652996530065301653026530365304653056530665307653086530965310653116531265313653146531565316653176531865319653206532165322653236532465325653266532765328653296533065331653326533365334653356533665337653386533965340653416534265343653446534565346653476534865349653506535165352653536535465355653566535765358653596536065361653626536365364653656536665367653686536965370653716537265373653746537565376653776537865379653806538165382653836538465385653866538765388653896539065391653926539365394653956539665397653986539965400654016540265403654046540565406654076540865409654106541165412654136541465415654166541765418654196542065421654226542365424654256542665427654286542965430654316543265433654346543565436654376543865439654406544165442654436544465445654466544765448654496545065451654526545365454654556545665457654586545965460654616546265463654646546565466654676546865469654706547165472654736547465475654766547765478654796548065481654826548365484654856548665487654886548965490654916549265493654946549565496654976549865499655006550165502655036550465505655066550765508655096551065511655126551365514655156551665517655186551965520655216552265523655246552565526655276552865529655306553165532655336553465535655366553765538655396554065541655426554365544655456554665547655486554965550655516555265553655546555565556655576555865559655606556165562655636556465565655666556765568655696557065571655726557365574655756557665577655786557965580655816558265583655846558565586655876558865589655906559165592655936559465595655966559765598655996560065601656026560365604656056560665607656086560965610656116561265613656146561565616656176561865619656206562165622656236562465625656266562765628656296563065631656326563365634656356563665637656386563965640656416564265643656446564565646656476564865649656506565165652656536565465655656566565765658656596566065661656626566365664656656566665667656686566965670656716567265673656746567565676656776567865679656806568165682656836568465685656866568765688656896569065691656926569365694656956569665697656986569965700657016570265703657046570565706657076570865709657106571165712657136571465715657166571765718657196572065721657226572365724657256572665727657286572965730657316573265733657346573565736657376573865739657406574165742657436574465745657466574765748657496575065751657526575365754657556575665757657586575965760657616576265763657646576565766657676576865769657706577165772657736577465775657766577765778657796578065781657826578365784657856578665787657886578965790657916579265793657946579565796657976579865799658006580165802658036580465805658066580765808658096581065811658126581365814658156581665817658186581965820658216582265823658246582565826658276582865829658306583165832658336583465835658366583765838658396584065841658426584365844658456584665847658486584965850658516585265853658546585565856658576585865859658606586165862658636586465865658666586765868658696587065871658726587365874658756587665877658786587965880658816588265883658846588565886658876588865889658906589165892658936589465895658966589765898658996590065901659026590365904659056590665907659086590965910659116591265913659146591565916659176591865919659206592165922659236592465925659266592765928659296593065931659326593365934659356593665937659386593965940659416594265943659446594565946659476594865949659506595165952659536595465955659566595765958659596596065961659626596365964659656596665967659686596965970659716597265973659746597565976659776597865979659806598165982659836598465985659866598765988659896599065991659926599365994659956599665997659986599966000660016600266003660046600566006660076600866009660106601166012660136601466015660166601766018660196602066021660226602366024660256602666027660286602966030660316603266033660346603566036660376603866039660406604166042660436604466045660466604766048660496605066051660526605366054660556605666057660586605966060660616606266063660646606566066660676606866069660706607166072660736607466075660766607766078660796608066081660826608366084660856608666087660886608966090660916609266093660946609566096660976609866099661006610166102661036610466105661066610766108661096611066111661126611366114661156611666117661186611966120661216612266123661246612566126661276612866129661306613166132661336613466135661366613766138661396614066141661426614366144661456614666147661486614966150661516615266153661546615566156661576615866159661606616166162661636616466165661666616766168661696617066171661726617366174661756617666177661786617966180661816618266183661846618566186661876618866189661906619166192661936619466195661966619766198661996620066201662026620366204662056620666207662086620966210662116621266213662146621566216662176621866219662206622166222662236622466225662266622766228662296623066231662326623366234662356623666237662386623966240662416624266243662446624566246662476624866249662506625166252662536625466255662566625766258662596626066261662626626366264662656626666267662686626966270662716627266273662746627566276662776627866279662806628166282662836628466285662866628766288662896629066291662926629366294662956629666297662986629966300663016630266303663046630566306663076630866309663106631166312663136631466315663166631766318663196632066321663226632366324663256632666327663286632966330663316633266333663346633566336663376633866339663406634166342663436634466345663466634766348663496635066351663526635366354663556635666357663586635966360663616636266363663646636566366663676636866369663706637166372663736637466375663766637766378663796638066381663826638366384663856638666387663886638966390663916639266393663946639566396663976639866399664006640166402664036640466405664066640766408664096641066411664126641366414664156641666417664186641966420664216642266423664246642566426664276642866429664306643166432664336643466435664366643766438664396644066441664426644366444664456644666447664486644966450664516645266453664546645566456664576645866459664606646166462664636646466465664666646766468664696647066471664726647366474664756647666477664786647966480664816648266483664846648566486664876648866489664906649166492664936649466495664966649766498664996650066501665026650366504665056650666507665086650966510665116651266513665146651566516665176651866519665206652166522665236652466525665266652766528665296653066531665326653366534665356653666537665386653966540665416654266543665446654566546665476654866549665506655166552665536655466555665566655766558665596656066561665626656366564665656656666567665686656966570665716657266573665746657566576665776657866579665806658166582665836658466585665866658766588665896659066591665926659366594665956659666597665986659966600666016660266603666046660566606666076660866609666106661166612666136661466615666166661766618666196662066621666226662366624666256662666627666286662966630666316663266633666346663566636666376663866639666406664166642666436664466645666466664766648666496665066651666526665366654666556665666657666586665966660666616666266663666646666566666666676666866669666706667166672666736667466675666766667766678666796668066681666826668366684666856668666687666886668966690666916669266693666946669566696666976669866699667006670166702667036670466705667066670766708667096671066711667126671366714667156671666717667186671966720667216672266723667246672566726667276672866729667306673166732667336673466735667366673766738667396674066741667426674366744667456674666747667486674966750667516675266753667546675566756667576675866759667606676166762667636676466765667666676766768667696677066771667726677366774667756677666777667786677966780667816678266783667846678566786667876678866789667906679166792667936679466795667966679766798667996680066801668026680366804668056680666807668086680966810668116681266813668146681566816668176681866819668206682166822668236682466825668266682766828668296683066831668326683366834668356683666837668386683966840668416684266843668446684566846668476684866849668506685166852668536685466855668566685766858668596686066861668626686366864668656686666867668686686966870668716687266873668746687566876668776687866879668806688166882668836688466885668866688766888668896689066891668926689366894668956689666897668986689966900669016690266903669046690566906669076690866909669106691166912669136691466915669166691766918669196692066921669226692366924669256692666927669286692966930669316693266933669346693566936669376693866939669406694166942669436694466945669466694766948669496695066951669526695366954669556695666957669586695966960669616696266963669646696566966669676696866969669706697166972669736697466975669766697766978669796698066981669826698366984669856698666987669886698966990669916699266993669946699566996669976699866999670006700167002670036700467005670066700767008670096701067011670126701367014670156701667017670186701967020670216702267023670246702567026670276702867029670306703167032670336703467035670366703767038670396704067041670426704367044670456704667047670486704967050670516705267053670546705567056670576705867059670606706167062670636706467065670666706767068670696707067071670726707367074670756707667077670786707967080670816708267083670846708567086670876708867089670906709167092670936709467095670966709767098670996710067101671026710367104671056710667107671086710967110671116711267113671146711567116671176711867119671206712167122671236712467125671266712767128671296713067131671326713367134671356713667137671386713967140671416714267143671446714567146671476714867149671506715167152671536715467155671566715767158671596716067161671626716367164671656716667167671686716967170671716717267173671746717567176671776717867179671806718167182671836718467185671866718767188671896719067191671926719367194671956719667197671986719967200672016720267203672046720567206672076720867209672106721167212672136721467215672166721767218672196722067221672226722367224672256722667227672286722967230672316723267233672346723567236672376723867239672406724167242672436724467245672466724767248672496725067251672526725367254672556725667257672586725967260672616726267263672646726567266672676726867269672706727167272672736727467275672766727767278672796728067281672826728367284672856728667287672886728967290672916729267293672946729567296672976729867299673006730167302673036730467305673066730767308673096731067311673126731367314673156731667317673186731967320673216732267323673246732567326673276732867329673306733167332673336733467335673366733767338673396734067341673426734367344673456734667347673486734967350673516735267353673546735567356673576735867359673606736167362673636736467365673666736767368673696737067371673726737367374673756737667377673786737967380673816738267383673846738567386673876738867389673906739167392673936739467395673966739767398673996740067401674026740367404674056740667407674086740967410674116741267413674146741567416674176741867419674206742167422674236742467425674266742767428674296743067431674326743367434674356743667437674386743967440674416744267443674446744567446674476744867449674506745167452674536745467455674566745767458674596746067461674626746367464674656746667467674686746967470674716747267473674746747567476674776747867479674806748167482674836748467485674866748767488674896749067491674926749367494674956749667497674986749967500675016750267503675046750567506675076750867509675106751167512675136751467515675166751767518675196752067521675226752367524675256752667527675286752967530675316753267533675346753567536675376753867539675406754167542675436754467545675466754767548675496755067551675526755367554675556755667557675586755967560675616756267563675646756567566675676756867569675706757167572675736757467575675766757767578675796758067581675826758367584675856758667587675886758967590675916759267593675946759567596675976759867599676006760167602676036760467605676066760767608676096761067611676126761367614676156761667617676186761967620676216762267623676246762567626676276762867629676306763167632676336763467635676366763767638676396764067641676426764367644676456764667647676486764967650676516765267653676546765567656676576765867659676606766167662676636766467665676666766767668676696767067671676726767367674676756767667677676786767967680676816768267683676846768567686676876768867689676906769167692676936769467695676966769767698676996770067701677026770367704677056770667707677086770967710677116771267713677146771567716677176771867719677206772167722677236772467725677266772767728677296773067731677326773367734677356773667737677386773967740677416774267743677446774567746677476774867749677506775167752677536775467755677566775767758677596776067761677626776367764677656776667767677686776967770677716777267773677746777567776677776777867779677806778167782677836778467785677866778767788677896779067791677926779367794677956779667797677986779967800678016780267803678046780567806678076780867809678106781167812678136781467815678166781767818678196782067821678226782367824678256782667827678286782967830678316783267833678346783567836678376783867839678406784167842678436784467845678466784767848678496785067851678526785367854678556785667857678586785967860678616786267863678646786567866678676786867869678706787167872678736787467875678766787767878678796788067881678826788367884678856788667887678886788967890678916789267893678946789567896678976789867899679006790167902679036790467905679066790767908679096791067911679126791367914679156791667917679186791967920679216792267923679246792567926679276792867929679306793167932679336793467935679366793767938679396794067941679426794367944679456794667947679486794967950679516795267953679546795567956679576795867959679606796167962679636796467965679666796767968679696797067971679726797367974679756797667977679786797967980679816798267983679846798567986679876798867989679906799167992679936799467995679966799767998679996800068001680026800368004680056800668007680086800968010680116801268013680146801568016680176801868019680206802168022680236802468025680266802768028680296803068031680326803368034680356803668037680386803968040680416804268043680446804568046680476804868049680506805168052680536805468055680566805768058680596806068061680626806368064680656806668067680686806968070680716807268073680746807568076680776807868079680806808168082680836808468085680866808768088680896809068091680926809368094680956809668097680986809968100681016810268103681046810568106681076810868109681106811168112681136811468115681166811768118681196812068121681226812368124681256812668127681286812968130681316813268133681346813568136681376813868139681406814168142681436814468145681466814768148681496815068151681526815368154681556815668157681586815968160681616816268163681646816568166681676816868169681706817168172681736817468175681766817768178681796818068181681826818368184681856818668187681886818968190681916819268193681946819568196681976819868199682006820168202682036820468205682066820768208682096821068211682126821368214682156821668217682186821968220682216822268223682246822568226682276822868229682306823168232682336823468235682366823768238682396824068241682426824368244682456824668247682486824968250682516825268253682546825568256682576825868259682606826168262682636826468265682666826768268682696827068271682726827368274682756827668277682786827968280682816828268283682846828568286682876828868289682906829168292682936829468295682966829768298682996830068301683026830368304683056830668307683086830968310683116831268313683146831568316683176831868319683206832168322683236832468325683266832768328683296833068331683326833368334683356833668337683386833968340683416834268343683446834568346683476834868349683506835168352683536835468355683566835768358683596836068361683626836368364683656836668367683686836968370683716837268373683746837568376683776837868379683806838168382683836838468385683866838768388683896839068391683926839368394683956839668397683986839968400684016840268403684046840568406684076840868409684106841168412684136841468415684166841768418684196842068421684226842368424684256842668427684286842968430684316843268433684346843568436684376843868439684406844168442684436844468445684466844768448684496845068451684526845368454684556845668457684586845968460684616846268463684646846568466684676846868469684706847168472684736847468475684766847768478684796848068481684826848368484684856848668487684886848968490684916849268493684946849568496684976849868499685006850168502685036850468505685066850768508685096851068511685126851368514685156851668517685186851968520685216852268523685246852568526685276852868529685306853168532685336853468535685366853768538685396854068541685426854368544685456854668547685486854968550685516855268553685546855568556685576855868559685606856168562685636856468565685666856768568685696857068571685726857368574685756857668577685786857968580685816858268583685846858568586685876858868589685906859168592685936859468595685966859768598685996860068601686026860368604686056860668607686086860968610686116861268613686146861568616686176861868619686206862168622686236862468625686266862768628686296863068631686326863368634686356863668637686386863968640686416864268643686446864568646686476864868649686506865168652686536865468655686566865768658686596866068661686626866368664686656866668667686686866968670686716867268673686746867568676686776867868679686806868168682686836868468685686866868768688686896869068691686926869368694686956869668697686986869968700687016870268703687046870568706687076870868709687106871168712687136871468715687166871768718687196872068721687226872368724687256872668727687286872968730687316873268733687346873568736687376873868739687406874168742687436874468745687466874768748687496875068751687526875368754687556875668757687586875968760687616876268763687646876568766687676876868769687706877168772687736877468775687766877768778687796878068781687826878368784687856878668787687886878968790687916879268793687946879568796687976879868799688006880168802688036880468805688066880768808688096881068811688126881368814688156881668817688186881968820688216882268823688246882568826688276882868829688306883168832688336883468835688366883768838688396884068841688426884368844688456884668847688486884968850688516885268853688546885568856688576885868859688606886168862688636886468865688666886768868688696887068871688726887368874688756887668877688786887968880688816888268883688846888568886688876888868889688906889168892688936889468895688966889768898688996890068901689026890368904689056890668907689086890968910689116891268913689146891568916689176891868919689206892168922689236892468925689266892768928689296893068931689326893368934689356893668937689386893968940689416894268943689446894568946689476894868949689506895168952689536895468955689566895768958689596896068961689626896368964689656896668967689686896968970689716897268973689746897568976689776897868979689806898168982689836898468985689866898768988689896899068991689926899368994689956899668997689986899969000690016900269003690046900569006690076900869009690106901169012690136901469015690166901769018690196902069021690226902369024690256902669027690286902969030690316903269033690346903569036690376903869039690406904169042690436904469045690466904769048690496905069051690526905369054690556905669057690586905969060690616906269063690646906569066690676906869069690706907169072690736907469075690766907769078690796908069081690826908369084690856908669087690886908969090690916909269093690946909569096690976909869099691006910169102691036910469105691066910769108691096911069111691126911369114691156911669117691186911969120691216912269123691246912569126691276912869129691306913169132691336913469135691366913769138691396914069141691426914369144691456914669147691486914969150691516915269153691546915569156691576915869159691606916169162691636916469165691666916769168691696917069171691726917369174691756917669177691786917969180691816918269183691846918569186691876918869189691906919169192691936919469195691966919769198691996920069201692026920369204692056920669207692086920969210692116921269213692146921569216692176921869219692206922169222692236922469225692266922769228692296923069231692326923369234692356923669237692386923969240692416924269243692446924569246692476924869249692506925169252692536925469255692566925769258692596926069261692626926369264692656926669267692686926969270692716927269273692746927569276692776927869279692806928169282692836928469285692866928769288692896929069291692926929369294692956929669297692986929969300693016930269303693046930569306693076930869309693106931169312693136931469315693166931769318693196932069321693226932369324693256932669327693286932969330693316933269333693346933569336693376933869339693406934169342693436934469345693466934769348693496935069351693526935369354693556935669357693586935969360693616936269363693646936569366693676936869369693706937169372693736937469375693766937769378693796938069381693826938369384693856938669387693886938969390693916939269393693946939569396693976939869399694006940169402694036940469405694066940769408694096941069411694126941369414694156941669417694186941969420694216942269423694246942569426694276942869429694306943169432694336943469435694366943769438694396944069441694426944369444694456944669447694486944969450694516945269453694546945569456694576945869459694606946169462694636946469465694666946769468694696947069471694726947369474694756947669477694786947969480694816948269483694846948569486694876948869489694906949169492694936949469495694966949769498694996950069501695026950369504695056950669507695086950969510695116951269513695146951569516695176951869519695206952169522695236952469525695266952769528695296953069531695326953369534695356953669537695386953969540695416954269543695446954569546695476954869549695506955169552695536955469555695566955769558695596956069561695626956369564695656956669567695686956969570695716957269573695746957569576695776957869579695806958169582695836958469585695866958769588695896959069591695926959369594695956959669597695986959969600696016960269603696046960569606696076960869609696106961169612696136961469615696166961769618696196962069621696226962369624696256962669627696286962969630696316963269633696346963569636696376963869639696406964169642696436964469645696466964769648696496965069651696526965369654696556965669657696586965969660696616966269663696646966569666696676966869669696706967169672696736967469675696766967769678696796968069681696826968369684696856968669687696886968969690696916969269693696946969569696696976969869699697006970169702697036970469705697066970769708697096971069711697126971369714697156971669717697186971969720697216972269723697246972569726697276972869729697306973169732697336973469735697366973769738697396974069741697426974369744697456974669747697486974969750697516975269753697546975569756697576975869759697606976169762697636976469765697666976769768697696977069771697726977369774697756977669777697786977969780697816978269783697846978569786697876978869789697906979169792697936979469795697966979769798697996980069801698026980369804698056980669807698086980969810698116981269813698146981569816698176981869819698206982169822698236982469825698266982769828698296983069831698326983369834698356983669837698386983969840698416984269843698446984569846698476984869849698506985169852698536985469855698566985769858698596986069861698626986369864698656986669867698686986969870698716987269873698746987569876698776987869879698806988169882698836988469885698866988769888698896989069891698926989369894698956989669897698986989969900699016990269903699046990569906699076990869909699106991169912699136991469915699166991769918699196992069921699226992369924699256992669927699286992969930699316993269933699346993569936699376993869939699406994169942699436994469945699466994769948699496995069951699526995369954699556995669957699586995969960699616996269963699646996569966699676996869969699706997169972699736997469975699766997769978699796998069981699826998369984699856998669987699886998969990699916999269993699946999569996699976999869999700007000170002700037000470005700067000770008700097001070011700127001370014700157001670017700187001970020700217002270023700247002570026700277002870029700307003170032700337003470035700367003770038700397004070041700427004370044700457004670047700487004970050700517005270053700547005570056700577005870059700607006170062700637006470065700667006770068700697007070071700727007370074700757007670077700787007970080700817008270083700847008570086700877008870089700907009170092700937009470095700967009770098700997010070101701027010370104701057010670107701087010970110701117011270113701147011570116701177011870119701207012170122701237012470125701267012770128701297013070131701327013370134701357013670137701387013970140701417014270143701447014570146701477014870149701507015170152701537015470155701567015770158701597016070161701627016370164701657016670167701687016970170701717017270173701747017570176701777017870179701807018170182701837018470185701867018770188701897019070191701927019370194701957019670197701987019970200702017020270203702047020570206702077020870209702107021170212702137021470215702167021770218702197022070221702227022370224702257022670227702287022970230702317023270233702347023570236702377023870239702407024170242702437024470245702467024770248702497025070251702527025370254702557025670257702587025970260702617026270263702647026570266702677026870269702707027170272702737027470275702767027770278702797028070281702827028370284702857028670287702887028970290702917029270293702947029570296702977029870299703007030170302703037030470305703067030770308703097031070311703127031370314703157031670317703187031970320703217032270323703247032570326703277032870329703307033170332703337033470335703367033770338703397034070341703427034370344703457034670347703487034970350703517035270353703547035570356703577035870359703607036170362703637036470365703667036770368703697037070371703727037370374703757037670377703787037970380703817038270383703847038570386703877038870389703907039170392703937039470395703967039770398703997040070401704027040370404704057040670407704087040970410704117041270413704147041570416704177041870419704207042170422704237042470425704267042770428704297043070431704327043370434704357043670437704387043970440704417044270443704447044570446704477044870449704507045170452704537045470455704567045770458704597046070461704627046370464704657046670467704687046970470704717047270473704747047570476704777047870479704807048170482704837048470485704867048770488704897049070491704927049370494704957049670497704987049970500705017050270503705047050570506705077050870509705107051170512705137051470515705167051770518705197052070521705227052370524705257052670527705287052970530705317053270533705347053570536705377053870539705407054170542705437054470545705467054770548705497055070551705527055370554705557055670557705587055970560705617056270563705647056570566705677056870569705707057170572705737057470575705767057770578705797058070581705827058370584705857058670587705887058970590705917059270593705947059570596705977059870599706007060170602706037060470605706067060770608706097061070611706127061370614706157061670617706187061970620706217062270623706247062570626706277062870629706307063170632706337063470635706367063770638706397064070641706427064370644706457064670647706487064970650706517065270653706547065570656706577065870659706607066170662706637066470665706667066770668706697067070671706727067370674706757067670677706787067970680706817068270683706847068570686706877068870689706907069170692706937069470695706967069770698706997070070701707027070370704707057070670707707087070970710707117071270713707147071570716707177071870719707207072170722707237072470725707267072770728707297073070731707327073370734707357073670737707387073970740707417074270743707447074570746707477074870749707507075170752707537075470755707567075770758707597076070761707627076370764707657076670767707687076970770707717077270773707747077570776707777077870779707807078170782707837078470785707867078770788707897079070791707927079370794707957079670797707987079970800708017080270803708047080570806708077080870809708107081170812708137081470815708167081770818708197082070821708227082370824708257082670827708287082970830708317083270833708347083570836708377083870839708407084170842708437084470845708467084770848708497085070851708527085370854708557085670857708587085970860708617086270863708647086570866708677086870869708707087170872708737087470875708767087770878708797088070881708827088370884708857088670887708887088970890708917089270893708947089570896708977089870899709007090170902709037090470905709067090770908709097091070911709127091370914709157091670917709187091970920709217092270923709247092570926709277092870929709307093170932709337093470935709367093770938709397094070941709427094370944709457094670947709487094970950709517095270953709547095570956709577095870959709607096170962709637096470965709667096770968709697097070971709727097370974709757097670977709787097970980709817098270983709847098570986709877098870989709907099170992709937099470995709967099770998709997100071001710027100371004710057100671007710087100971010710117101271013710147101571016710177101871019710207102171022710237102471025710267102771028710297103071031710327103371034710357103671037710387103971040710417104271043710447104571046710477104871049710507105171052710537105471055710567105771058710597106071061710627106371064710657106671067710687106971070710717107271073710747107571076710777107871079710807108171082710837108471085710867108771088710897109071091710927109371094710957109671097710987109971100711017110271103711047110571106711077110871109711107111171112711137111471115711167111771118711197112071121711227112371124711257112671127711287112971130711317113271133711347113571136711377113871139711407114171142711437114471145711467114771148711497115071151711527115371154711557115671157711587115971160711617116271163711647116571166711677116871169711707117171172711737117471175711767117771178711797118071181711827118371184711857118671187711887118971190711917119271193711947119571196711977119871199712007120171202712037120471205712067120771208712097121071211712127121371214712157121671217712187121971220712217122271223712247122571226712277122871229712307123171232712337123471235712367123771238712397124071241712427124371244712457124671247712487124971250712517125271253712547125571256712577125871259712607126171262712637126471265712667126771268712697127071271712727127371274712757127671277712787127971280712817128271283712847128571286712877128871289712907129171292712937129471295712967129771298712997130071301713027130371304713057130671307713087130971310713117131271313713147131571316713177131871319713207132171322713237132471325713267132771328713297133071331713327133371334713357133671337713387133971340713417134271343713447134571346713477134871349713507135171352713537135471355713567135771358713597136071361713627136371364713657136671367713687136971370713717137271373713747137571376713777137871379713807138171382713837138471385713867138771388713897139071391713927139371394713957139671397713987139971400714017140271403714047140571406714077140871409714107141171412714137141471415714167141771418714197142071421714227142371424714257142671427714287142971430714317143271433714347143571436714377143871439714407144171442714437144471445714467144771448714497145071451714527145371454714557145671457714587145971460714617146271463714647146571466714677146871469714707147171472714737147471475714767147771478714797148071481714827148371484714857148671487714887148971490714917149271493714947149571496714977149871499715007150171502715037150471505715067150771508715097151071511715127151371514715157151671517715187151971520715217152271523715247152571526715277152871529715307153171532715337153471535715367153771538715397154071541715427154371544715457154671547715487154971550715517155271553715547155571556715577155871559715607156171562715637156471565715667156771568715697157071571715727157371574715757157671577715787157971580715817158271583715847158571586715877158871589715907159171592715937159471595715967159771598715997160071601716027160371604716057160671607716087160971610716117161271613716147161571616716177161871619716207162171622716237162471625716267162771628716297163071631716327163371634716357163671637716387163971640716417164271643716447164571646716477164871649716507165171652716537165471655716567165771658716597166071661716627166371664716657166671667716687166971670716717167271673716747167571676716777167871679716807168171682716837168471685716867168771688716897169071691716927169371694716957169671697716987169971700717017170271703717047170571706717077170871709717107171171712717137171471715717167171771718717197172071721717227172371724717257172671727717287172971730717317173271733717347173571736717377173871739717407174171742717437174471745717467174771748717497175071751717527175371754717557175671757717587175971760717617176271763717647176571766717677176871769717707177171772717737177471775717767177771778717797178071781717827178371784717857178671787717887178971790717917179271793717947179571796717977179871799718007180171802718037180471805718067180771808718097181071811718127181371814718157181671817718187181971820718217182271823718247182571826718277182871829718307183171832718337183471835718367183771838718397184071841718427184371844718457184671847718487184971850718517185271853718547185571856718577185871859718607186171862718637186471865718667186771868718697187071871718727187371874718757187671877718787187971880718817188271883718847188571886718877188871889718907189171892718937189471895718967189771898718997190071901719027190371904719057190671907719087190971910719117191271913719147191571916719177191871919719207192171922719237192471925719267192771928719297193071931719327193371934719357193671937719387193971940719417194271943719447194571946719477194871949719507195171952719537195471955719567195771958719597196071961719627196371964719657196671967719687196971970719717197271973719747197571976719777197871979719807198171982719837198471985719867198771988719897199071991719927199371994719957199671997719987199972000720017200272003720047200572006720077200872009720107201172012720137201472015720167201772018720197202072021720227202372024720257202672027720287202972030720317203272033720347203572036720377203872039720407204172042720437204472045720467204772048720497205072051720527205372054720557205672057720587205972060720617206272063720647206572066720677206872069720707207172072720737207472075720767207772078720797208072081720827208372084720857208672087720887208972090720917209272093720947209572096720977209872099721007210172102721037210472105721067210772108721097211072111721127211372114721157211672117721187211972120721217212272123721247212572126721277212872129721307213172132721337213472135721367213772138721397214072141721427214372144721457214672147721487214972150721517215272153721547215572156721577215872159721607216172162721637216472165721667216772168721697217072171721727217372174721757217672177721787217972180721817218272183721847218572186721877218872189721907219172192721937219472195721967219772198721997220072201722027220372204722057220672207722087220972210722117221272213722147221572216722177221872219722207222172222722237222472225722267222772228722297223072231722327223372234722357223672237722387223972240722417224272243722447224572246722477224872249722507225172252722537225472255722567225772258722597226072261722627226372264722657226672267722687226972270722717227272273722747227572276722777227872279722807228172282722837228472285722867228772288722897229072291722927229372294722957229672297722987229972300723017230272303723047230572306723077230872309723107231172312723137231472315723167231772318723197232072321723227232372324723257232672327723287232972330723317233272333723347233572336723377233872339723407234172342723437234472345723467234772348723497235072351723527235372354723557235672357723587235972360723617236272363723647236572366723677236872369723707237172372723737237472375723767237772378723797238072381723827238372384723857238672387723887238972390723917239272393723947239572396723977239872399724007240172402724037240472405724067240772408724097241072411724127241372414724157241672417724187241972420724217242272423724247242572426724277242872429724307243172432724337243472435724367243772438724397244072441724427244372444724457244672447724487244972450724517245272453724547245572456724577245872459724607246172462724637246472465724667246772468724697247072471724727247372474724757247672477724787247972480724817248272483724847248572486724877248872489724907249172492724937249472495724967249772498724997250072501725027250372504725057250672507725087250972510725117251272513725147251572516725177251872519725207252172522725237252472525725267252772528725297253072531725327253372534725357253672537725387253972540725417254272543725447254572546725477254872549725507255172552725537255472555725567255772558725597256072561725627256372564725657256672567725687256972570725717257272573725747257572576725777257872579725807258172582725837258472585725867258772588725897259072591725927259372594725957259672597725987259972600726017260272603726047260572606726077260872609726107261172612726137261472615726167261772618726197262072621726227262372624726257262672627726287262972630726317263272633726347263572636726377263872639726407264172642726437264472645726467264772648726497265072651726527265372654726557265672657726587265972660726617266272663726647266572666726677266872669726707267172672726737267472675726767267772678726797268072681726827268372684726857268672687726887268972690726917269272693726947269572696726977269872699727007270172702727037270472705727067270772708727097271072711727127271372714727157271672717727187271972720727217272272723727247272572726727277272872729727307273172732727337273472735727367273772738727397274072741727427274372744727457274672747727487274972750727517275272753727547275572756727577275872759727607276172762727637276472765727667276772768727697277072771727727277372774727757277672777727787277972780727817278272783727847278572786727877278872789727907279172792727937279472795727967279772798727997280072801728027280372804728057280672807728087280972810728117281272813728147281572816728177281872819728207282172822728237282472825728267282772828728297283072831728327283372834728357283672837728387283972840728417284272843728447284572846728477284872849728507285172852728537285472855728567285772858728597286072861728627286372864728657286672867728687286972870728717287272873728747287572876728777287872879728807288172882728837288472885728867288772888728897289072891728927289372894728957289672897728987289972900729017290272903729047290572906729077290872909729107291172912729137291472915729167291772918729197292072921729227292372924729257292672927729287292972930729317293272933729347293572936729377293872939729407294172942729437294472945729467294772948729497295072951729527295372954729557295672957729587295972960729617296272963729647296572966729677296872969729707297172972729737297472975729767297772978729797298072981729827298372984729857298672987729887298972990729917299272993729947299572996729977299872999730007300173002730037300473005730067300773008730097301073011730127301373014730157301673017730187301973020730217302273023730247302573026730277302873029730307303173032730337303473035730367303773038730397304073041730427304373044730457304673047730487304973050730517305273053730547305573056730577305873059730607306173062730637306473065730667306773068730697307073071730727307373074730757307673077730787307973080730817308273083730847308573086730877308873089730907309173092730937309473095730967309773098730997310073101731027310373104731057310673107731087310973110731117311273113731147311573116731177311873119731207312173122731237312473125731267312773128731297313073131731327313373134731357313673137731387313973140731417314273143731447314573146731477314873149731507315173152731537315473155731567315773158731597316073161731627316373164731657316673167731687316973170731717317273173731747317573176731777317873179731807318173182731837318473185731867318773188731897319073191731927319373194731957319673197731987319973200732017320273203732047320573206732077320873209732107321173212732137321473215732167321773218732197322073221732227322373224732257322673227732287322973230732317323273233732347323573236732377323873239732407324173242732437324473245732467324773248732497325073251732527325373254732557325673257732587325973260732617326273263732647326573266732677326873269732707327173272732737327473275732767327773278732797328073281732827328373284732857328673287732887328973290732917329273293732947329573296732977329873299733007330173302733037330473305733067330773308733097331073311733127331373314733157331673317733187331973320733217332273323733247332573326733277332873329733307333173332733337333473335733367333773338733397334073341733427334373344733457334673347733487334973350733517335273353733547335573356733577335873359733607336173362733637336473365733667336773368733697337073371733727337373374733757337673377733787337973380733817338273383733847338573386733877338873389733907339173392733937339473395733967339773398733997340073401734027340373404734057340673407734087340973410734117341273413734147341573416734177341873419734207342173422734237342473425734267342773428734297343073431734327343373434734357343673437734387343973440734417344273443734447344573446734477344873449734507345173452734537345473455734567345773458734597346073461734627346373464734657346673467734687346973470734717347273473734747347573476734777347873479734807348173482734837348473485734867348773488734897349073491734927349373494734957349673497734987349973500735017350273503735047350573506735077350873509735107351173512735137351473515735167351773518735197352073521735227352373524735257352673527735287352973530735317353273533735347353573536735377353873539735407354173542735437354473545735467354773548735497355073551735527355373554735557355673557735587355973560735617356273563735647356573566735677356873569735707357173572735737357473575735767357773578735797358073581735827358373584735857358673587735887358973590735917359273593735947359573596735977359873599736007360173602736037360473605736067360773608736097361073611736127361373614736157361673617736187361973620736217362273623736247362573626736277362873629736307363173632736337363473635736367363773638736397364073641736427364373644736457364673647736487364973650736517365273653736547365573656736577365873659736607366173662736637366473665736667366773668736697367073671736727367373674736757367673677736787367973680736817368273683736847368573686736877368873689736907369173692736937369473695736967369773698736997370073701737027370373704737057370673707737087370973710737117371273713737147371573716737177371873719737207372173722737237372473725737267372773728737297373073731737327373373734737357373673737737387373973740737417374273743737447374573746737477374873749737507375173752737537375473755737567375773758737597376073761737627376373764737657376673767737687376973770737717377273773737747377573776737777377873779737807378173782737837378473785737867378773788737897379073791737927379373794737957379673797737987379973800738017380273803738047380573806738077380873809738107381173812738137381473815738167381773818738197382073821738227382373824738257382673827738287382973830738317383273833738347383573836738377383873839738407384173842738437384473845738467384773848738497385073851738527385373854738557385673857738587385973860738617386273863738647386573866738677386873869738707387173872738737387473875738767387773878738797388073881738827388373884738857388673887738887388973890738917389273893738947389573896738977389873899739007390173902739037390473905739067390773908739097391073911739127391373914739157391673917739187391973920739217392273923739247392573926739277392873929739307393173932739337393473935739367393773938739397394073941739427394373944739457394673947739487394973950739517395273953739547395573956739577395873959739607396173962739637396473965739667396773968739697397073971739727397373974739757397673977739787397973980739817398273983739847398573986739877398873989739907399173992739937399473995739967399773998739997400074001740027400374004740057400674007740087400974010740117401274013740147401574016740177401874019740207402174022740237402474025740267402774028740297403074031740327403374034740357403674037740387403974040740417404274043740447404574046740477404874049740507405174052740537405474055740567405774058740597406074061740627406374064740657406674067740687406974070740717407274073740747407574076740777407874079740807408174082740837408474085740867408774088740897409074091740927409374094740957409674097740987409974100741017410274103741047410574106741077410874109741107411174112741137411474115741167411774118741197412074121741227412374124741257412674127741287412974130741317413274133741347413574136741377413874139741407414174142741437414474145741467414774148741497415074151741527415374154741557415674157741587415974160741617416274163741647416574166741677416874169741707417174172741737417474175741767417774178741797418074181741827418374184741857418674187741887418974190741917419274193741947419574196741977419874199742007420174202742037420474205742067420774208742097421074211742127421374214742157421674217742187421974220742217422274223742247422574226742277422874229742307423174232742337423474235742367423774238742397424074241742427424374244742457424674247742487424974250742517425274253742547425574256742577425874259742607426174262742637426474265742667426774268742697427074271742727427374274742757427674277742787427974280742817428274283742847428574286742877428874289742907429174292742937429474295742967429774298742997430074301743027430374304743057430674307743087430974310743117431274313743147431574316743177431874319743207432174322743237432474325743267432774328743297433074331743327433374334743357433674337743387433974340743417434274343743447434574346743477434874349743507435174352743537435474355743567435774358743597436074361743627436374364743657436674367743687436974370743717437274373743747437574376743777437874379743807438174382743837438474385743867438774388743897439074391743927439374394743957439674397743987439974400744017440274403744047440574406744077440874409744107441174412744137441474415744167441774418744197442074421744227442374424744257442674427744287442974430744317443274433744347443574436744377443874439744407444174442744437444474445744467444774448744497445074451744527445374454744557445674457744587445974460744617446274463744647446574466744677446874469744707447174472744737447474475744767447774478744797448074481744827448374484744857448674487744887448974490744917449274493744947449574496744977449874499745007450174502745037450474505745067450774508745097451074511745127451374514745157451674517745187451974520745217452274523745247452574526745277452874529745307453174532745337453474535745367453774538745397454074541745427454374544745457454674547745487454974550745517455274553745547455574556745577455874559745607456174562745637456474565745667456774568745697457074571745727457374574745757457674577745787457974580745817458274583745847458574586745877458874589745907459174592745937459474595745967459774598745997460074601746027460374604746057460674607746087460974610746117461274613746147461574616746177461874619746207462174622746237462474625746267462774628746297463074631746327463374634746357463674637746387463974640746417464274643746447464574646746477464874649746507465174652746537465474655746567465774658746597466074661746627466374664746657466674667746687466974670746717467274673746747467574676746777467874679746807468174682746837468474685746867468774688746897469074691746927469374694746957469674697746987469974700747017470274703747047470574706747077470874709747107471174712747137471474715747167471774718747197472074721747227472374724747257472674727747287472974730747317473274733747347473574736747377473874739747407474174742747437474474745747467474774748747497475074751747527475374754747557475674757747587475974760747617476274763747647476574766747677476874769747707477174772747737477474775747767477774778747797478074781747827478374784747857478674787747887478974790747917479274793747947479574796747977479874799748007480174802748037480474805748067480774808748097481074811748127481374814748157481674817748187481974820748217482274823748247482574826748277482874829748307483174832748337483474835748367483774838748397484074841748427484374844748457484674847748487484974850748517485274853748547485574856748577485874859748607486174862748637486474865748667486774868748697487074871748727487374874748757487674877748787487974880748817488274883748847488574886748877488874889748907489174892748937489474895748967489774898748997490074901749027490374904749057490674907749087490974910749117491274913749147491574916749177491874919749207492174922749237492474925749267492774928749297493074931749327493374934749357493674937749387493974940749417494274943749447494574946749477494874949749507495174952749537495474955749567495774958749597496074961749627496374964749657496674967749687496974970749717497274973749747497574976749777497874979749807498174982749837498474985749867498774988749897499074991749927499374994749957499674997749987499975000750017500275003750047500575006750077500875009750107501175012750137501475015750167501775018750197502075021750227502375024750257502675027750287502975030750317503275033750347503575036750377503875039750407504175042750437504475045750467504775048750497505075051750527505375054750557505675057750587505975060750617506275063750647506575066750677506875069750707507175072750737507475075750767507775078750797508075081750827508375084750857508675087750887508975090750917509275093750947509575096750977509875099751007510175102751037510475105751067510775108751097511075111751127511375114751157511675117751187511975120751217512275123751247512575126751277512875129751307513175132751337513475135751367513775138751397514075141751427514375144751457514675147751487514975150751517515275153751547515575156751577515875159751607516175162751637516475165751667516775168751697517075171751727517375174751757517675177751787517975180751817518275183751847518575186751877518875189751907519175192751937519475195751967519775198751997520075201752027520375204752057520675207752087520975210752117521275213752147521575216752177521875219752207522175222752237522475225752267522775228752297523075231752327523375234752357523675237752387523975240752417524275243752447524575246752477524875249752507525175252752537525475255752567525775258752597526075261752627526375264752657526675267752687526975270752717527275273752747527575276752777527875279752807528175282752837528475285752867528775288752897529075291752927529375294752957529675297752987529975300753017530275303753047530575306753077530875309753107531175312753137531475315753167531775318753197532075321753227532375324753257532675327753287532975330753317533275333753347533575336753377533875339753407534175342753437534475345753467534775348753497535075351753527535375354753557535675357753587535975360753617536275363753647536575366753677536875369753707537175372753737537475375753767537775378753797538075381753827538375384753857538675387753887538975390753917539275393753947539575396753977539875399754007540175402754037540475405754067540775408754097541075411754127541375414754157541675417754187541975420754217542275423754247542575426754277542875429754307543175432754337543475435754367543775438754397544075441754427544375444754457544675447754487544975450754517545275453754547545575456754577545875459754607546175462754637546475465754667546775468754697547075471754727547375474754757547675477754787547975480754817548275483754847548575486754877548875489754907549175492754937549475495754967549775498754997550075501755027550375504755057550675507755087550975510755117551275513755147551575516755177551875519755207552175522755237552475525755267552775528755297553075531755327553375534755357553675537755387553975540755417554275543755447554575546755477554875549755507555175552755537555475555755567555775558755597556075561755627556375564755657556675567755687556975570755717557275573755747557575576755777557875579755807558175582755837558475585755867558775588755897559075591755927559375594755957559675597755987559975600756017560275603756047560575606756077560875609756107561175612756137561475615756167561775618756197562075621756227562375624756257562675627756287562975630756317563275633756347563575636756377563875639756407564175642756437564475645756467564775648756497565075651756527565375654756557565675657756587565975660756617566275663756647566575666756677566875669756707567175672756737567475675756767567775678756797568075681756827568375684756857568675687756887568975690756917569275693756947569575696756977569875699757007570175702757037570475705757067570775708757097571075711757127571375714757157571675717757187571975720757217572275723757247572575726757277572875729757307573175732757337573475735757367573775738757397574075741757427574375744757457574675747757487574975750757517575275753757547575575756757577575875759757607576175762757637576475765757667576775768757697577075771757727577375774757757577675777757787577975780757817578275783757847578575786757877578875789757907579175792757937579475795757967579775798757997580075801758027580375804758057580675807758087580975810758117581275813758147581575816758177581875819758207582175822758237582475825758267582775828758297583075831758327583375834758357583675837758387583975840758417584275843758447584575846758477584875849758507585175852758537585475855758567585775858758597586075861758627586375864758657586675867758687586975870758717587275873758747587575876758777587875879758807588175882758837588475885758867588775888758897589075891758927589375894758957589675897758987589975900759017590275903759047590575906759077590875909759107591175912759137591475915759167591775918759197592075921759227592375924759257592675927759287592975930759317593275933759347593575936759377593875939759407594175942759437594475945759467594775948759497595075951759527595375954759557595675957759587595975960759617596275963759647596575966759677596875969759707597175972759737597475975759767597775978759797598075981759827598375984759857598675987759887598975990759917599275993759947599575996759977599875999760007600176002760037600476005760067600776008760097601076011760127601376014760157601676017760187601976020760217602276023760247602576026760277602876029760307603176032760337603476035760367603776038760397604076041760427604376044760457604676047760487604976050760517605276053760547605576056760577605876059760607606176062760637606476065760667606776068760697607076071760727607376074760757607676077760787607976080760817608276083760847608576086760877608876089760907609176092760937609476095760967609776098760997610076101761027610376104761057610676107761087610976110761117611276113761147611576116761177611876119761207612176122761237612476125761267612776128761297613076131761327613376134761357613676137761387613976140761417614276143761447614576146761477614876149761507615176152761537615476155761567615776158761597616076161761627616376164761657616676167761687616976170761717617276173761747617576176761777617876179761807618176182761837618476185761867618776188761897619076191761927619376194761957619676197761987619976200762017620276203762047620576206762077620876209762107621176212762137621476215762167621776218762197622076221762227622376224762257622676227762287622976230762317623276233762347623576236762377623876239762407624176242762437624476245762467624776248762497625076251762527625376254762557625676257762587625976260762617626276263762647626576266762677626876269762707627176272762737627476275762767627776278762797628076281762827628376284762857628676287762887628976290762917629276293762947629576296762977629876299763007630176302763037630476305763067630776308763097631076311763127631376314763157631676317763187631976320763217632276323763247632576326763277632876329763307633176332763337633476335763367633776338763397634076341763427634376344763457634676347763487634976350763517635276353763547635576356763577635876359763607636176362763637636476365763667636776368763697637076371763727637376374763757637676377763787637976380763817638276383763847638576386763877638876389763907639176392763937639476395763967639776398763997640076401764027640376404764057640676407764087640976410764117641276413764147641576416764177641876419764207642176422764237642476425764267642776428764297643076431764327643376434764357643676437764387643976440764417644276443764447644576446764477644876449764507645176452764537645476455764567645776458764597646076461764627646376464764657646676467764687646976470764717647276473764747647576476764777647876479764807648176482764837648476485764867648776488764897649076491764927649376494764957649676497764987649976500765017650276503765047650576506765077650876509765107651176512765137651476515765167651776518765197652076521765227652376524765257652676527765287652976530765317653276533765347653576536765377653876539765407654176542765437654476545765467654776548765497655076551765527655376554765557655676557765587655976560765617656276563765647656576566765677656876569765707657176572765737657476575765767657776578765797658076581765827658376584765857658676587765887658976590765917659276593765947659576596765977659876599766007660176602766037660476605766067660776608766097661076611766127661376614766157661676617766187661976620766217662276623766247662576626766277662876629766307663176632766337663476635766367663776638766397664076641766427664376644766457664676647766487664976650766517665276653766547665576656766577665876659766607666176662766637666476665766667666776668766697667076671766727667376674766757667676677766787667976680766817668276683766847668576686766877668876689766907669176692766937669476695766967669776698766997670076701767027670376704767057670676707767087670976710767117671276713767147671576716767177671876719767207672176722767237672476725767267672776728767297673076731767327673376734767357673676737767387673976740767417674276743767447674576746767477674876749767507675176752767537675476755767567675776758767597676076761767627676376764767657676676767767687676976770767717677276773767747677576776767777677876779767807678176782767837678476785767867678776788767897679076791767927679376794767957679676797767987679976800768017680276803768047680576806768077680876809768107681176812768137681476815768167681776818768197682076821768227682376824768257682676827768287682976830768317683276833768347683576836768377683876839768407684176842768437684476845768467684776848768497685076851768527685376854768557685676857768587685976860768617686276863768647686576866768677686876869768707687176872768737687476875768767687776878768797688076881768827688376884768857688676887768887688976890768917689276893768947689576896768977689876899769007690176902769037690476905769067690776908769097691076911769127691376914769157691676917769187691976920769217692276923769247692576926769277692876929769307693176932769337693476935769367693776938769397694076941769427694376944769457694676947769487694976950769517695276953769547695576956769577695876959769607696176962769637696476965769667696776968769697697076971769727697376974769757697676977769787697976980769817698276983769847698576986769877698876989769907699176992769937699476995769967699776998769997700077001770027700377004770057700677007770087700977010770117701277013770147701577016770177701877019770207702177022770237702477025770267702777028770297703077031770327703377034770357703677037770387703977040770417704277043770447704577046770477704877049770507705177052770537705477055770567705777058770597706077061770627706377064770657706677067770687706977070770717707277073770747707577076770777707877079770807708177082770837708477085770867708777088770897709077091770927709377094770957709677097770987709977100771017710277103771047710577106771077710877109771107711177112771137711477115771167711777118771197712077121771227712377124771257712677127771287712977130771317713277133771347713577136771377713877139771407714177142771437714477145771467714777148771497715077151771527715377154771557715677157771587715977160771617716277163771647716577166771677716877169771707717177172771737717477175771767717777178771797718077181771827718377184771857718677187771887718977190771917719277193771947719577196771977719877199772007720177202772037720477205772067720777208772097721077211772127721377214772157721677217772187721977220772217722277223772247722577226772277722877229772307723177232772337723477235772367723777238772397724077241772427724377244772457724677247772487724977250772517725277253772547725577256772577725877259772607726177262772637726477265772667726777268772697727077271772727727377274772757727677277772787727977280772817728277283772847728577286772877728877289772907729177292772937729477295772967729777298772997730077301773027730377304773057730677307773087730977310773117731277313773147731577316773177731877319773207732177322773237732477325773267732777328773297733077331773327733377334773357733677337773387733977340773417734277343773447734577346773477734877349773507735177352773537735477355773567735777358773597736077361773627736377364773657736677367773687736977370773717737277373773747737577376773777737877379773807738177382773837738477385773867738777388773897739077391773927739377394773957739677397773987739977400774017740277403774047740577406774077740877409774107741177412774137741477415774167741777418774197742077421774227742377424774257742677427774287742977430774317743277433774347743577436774377743877439774407744177442774437744477445774467744777448774497745077451774527745377454774557745677457774587745977460774617746277463774647746577466774677746877469774707747177472774737747477475774767747777478774797748077481774827748377484774857748677487774887748977490774917749277493774947749577496774977749877499775007750177502775037750477505775067750777508775097751077511775127751377514775157751677517775187751977520775217752277523775247752577526775277752877529775307753177532775337753477535775367753777538775397754077541775427754377544775457754677547775487754977550775517755277553775547755577556775577755877559775607756177562775637756477565775667756777568775697757077571775727757377574775757757677577775787757977580775817758277583775847758577586775877758877589775907759177592775937759477595775967759777598775997760077601776027760377604776057760677607776087760977610776117761277613776147761577616776177761877619776207762177622776237762477625776267762777628776297763077631776327763377634776357763677637776387763977640776417764277643776447764577646776477764877649776507765177652776537765477655776567765777658776597766077661776627766377664776657766677667776687766977670776717767277673776747767577676776777767877679776807768177682776837768477685776867768777688776897769077691776927769377694776957769677697776987769977700777017770277703777047770577706777077770877709777107771177712777137771477715777167771777718777197772077721777227772377724777257772677727777287772977730777317773277733777347773577736777377773877739777407774177742777437774477745777467774777748777497775077751777527775377754777557775677757777587775977760777617776277763777647776577766777677776877769777707777177772777737777477775777767777777778777797778077781777827778377784777857778677787777887778977790777917779277793777947779577796777977779877799778007780177802778037780477805778067780777808778097781077811778127781377814778157781677817778187781977820778217782277823778247782577826778277782877829778307783177832778337783477835778367783777838778397784077841778427784377844778457784677847778487784977850778517785277853778547785577856778577785877859778607786177862778637786477865778667786777868778697787077871778727787377874778757787677877778787787977880778817788277883778847788577886778877788877889778907789177892778937789477895778967789777898778997790077901779027790377904779057790677907779087790977910779117791277913779147791577916779177791877919779207792177922779237792477925779267792777928779297793077931779327793377934779357793677937779387793977940779417794277943779447794577946779477794877949779507795177952779537795477955779567795777958779597796077961779627796377964779657796677967779687796977970779717797277973779747797577976779777797877979779807798177982779837798477985779867798777988779897799077991779927799377994779957799677997779987799978000780017800278003780047800578006780077800878009780107801178012780137801478015780167801778018780197802078021780227802378024780257802678027780287802978030780317803278033780347803578036780377803878039780407804178042780437804478045780467804778048780497805078051780527805378054780557805678057780587805978060780617806278063780647806578066780677806878069780707807178072780737807478075780767807778078780797808078081780827808378084780857808678087780887808978090780917809278093780947809578096780977809878099781007810178102781037810478105781067810778108781097811078111781127811378114781157811678117781187811978120781217812278123781247812578126781277812878129781307813178132781337813478135781367813778138781397814078141781427814378144781457814678147781487814978150781517815278153781547815578156781577815878159781607816178162781637816478165781667816778168781697817078171781727817378174781757817678177781787817978180781817818278183781847818578186781877818878189781907819178192781937819478195781967819778198781997820078201782027820378204782057820678207782087820978210782117821278213782147821578216782177821878219782207822178222782237822478225782267822778228782297823078231782327823378234782357823678237782387823978240782417824278243782447824578246782477824878249782507825178252782537825478255782567825778258782597826078261782627826378264782657826678267782687826978270782717827278273782747827578276782777827878279782807828178282782837828478285782867828778288782897829078291782927829378294782957829678297782987829978300783017830278303783047830578306783077830878309783107831178312783137831478315783167831778318783197832078321783227832378324783257832678327783287832978330783317833278333783347833578336783377833878339783407834178342783437834478345783467834778348783497835078351783527835378354783557835678357783587835978360783617836278363783647836578366783677836878369783707837178372783737837478375783767837778378783797838078381783827838378384783857838678387783887838978390783917839278393783947839578396783977839878399784007840178402784037840478405784067840778408784097841078411784127841378414784157841678417784187841978420784217842278423784247842578426784277842878429784307843178432784337843478435784367843778438784397844078441784427844378444784457844678447784487844978450784517845278453784547845578456784577845878459784607846178462784637846478465784667846778468784697847078471784727847378474784757847678477784787847978480784817848278483784847848578486784877848878489784907849178492784937849478495784967849778498784997850078501785027850378504785057850678507785087850978510785117851278513785147851578516785177851878519785207852178522785237852478525785267852778528785297853078531785327853378534785357853678537785387853978540785417854278543785447854578546785477854878549785507855178552785537855478555785567855778558785597856078561785627856378564785657856678567785687856978570785717857278573785747857578576785777857878579785807858178582785837858478585785867858778588785897859078591785927859378594785957859678597785987859978600786017860278603786047860578606786077860878609786107861178612786137861478615786167861778618786197862078621786227862378624786257862678627786287862978630786317863278633786347863578636786377863878639786407864178642786437864478645786467864778648786497865078651786527865378654786557865678657786587865978660786617866278663786647866578666786677866878669786707867178672786737867478675786767867778678786797868078681786827868378684786857868678687786887868978690786917869278693786947869578696786977869878699787007870178702787037870478705787067870778708787097871078711787127871378714787157871678717787187871978720787217872278723787247872578726787277872878729787307873178732787337873478735787367873778738787397874078741787427874378744787457874678747787487874978750787517875278753787547875578756787577875878759787607876178762787637876478765787667876778768787697877078771787727877378774787757877678777787787877978780787817878278783787847878578786787877878878789787907879178792787937879478795787967879778798787997880078801788027880378804788057880678807788087880978810788117881278813788147881578816788177881878819788207882178822788237882478825788267882778828788297883078831788327883378834788357883678837788387883978840788417884278843788447884578846788477884878849788507885178852788537885478855788567885778858788597886078861788627886378864788657886678867788687886978870788717887278873788747887578876788777887878879788807888178882788837888478885788867888778888788897889078891788927889378894788957889678897788987889978900789017890278903789047890578906789077890878909789107891178912789137891478915789167891778918789197892078921789227892378924789257892678927789287892978930789317893278933789347893578936789377893878939789407894178942789437894478945789467894778948789497895078951789527895378954789557895678957789587895978960789617896278963789647896578966789677896878969789707897178972789737897478975789767897778978789797898078981789827898378984789857898678987789887898978990789917899278993789947899578996789977899878999790007900179002790037900479005790067900779008790097901079011790127901379014790157901679017790187901979020790217902279023790247902579026790277902879029790307903179032790337903479035790367903779038790397904079041790427904379044790457904679047790487904979050790517905279053790547905579056790577905879059790607906179062790637906479065790667906779068790697907079071790727907379074790757907679077790787907979080790817908279083790847908579086790877908879089790907909179092790937909479095790967909779098790997910079101791027910379104791057910679107791087910979110791117911279113791147911579116791177911879119791207912179122791237912479125791267912779128791297913079131791327913379134791357913679137791387913979140791417914279143791447914579146791477914879149791507915179152791537915479155791567915779158791597916079161791627916379164791657916679167791687916979170791717917279173791747917579176791777917879179791807918179182791837918479185791867918779188791897919079191791927919379194791957919679197791987919979200792017920279203792047920579206792077920879209792107921179212792137921479215792167921779218792197922079221792227922379224792257922679227792287922979230792317923279233792347923579236792377923879239792407924179242792437924479245792467924779248792497925079251792527925379254792557925679257792587925979260792617926279263792647926579266792677926879269792707927179272792737927479275792767927779278792797928079281792827928379284792857928679287792887928979290792917929279293792947929579296792977929879299793007930179302793037930479305793067930779308793097931079311793127931379314793157931679317793187931979320793217932279323793247932579326793277932879329793307933179332793337933479335793367933779338793397934079341793427934379344793457934679347793487934979350793517935279353793547935579356793577935879359793607936179362793637936479365793667936779368793697937079371793727937379374793757937679377793787937979380793817938279383793847938579386793877938879389793907939179392793937939479395793967939779398793997940079401794027940379404794057940679407794087940979410794117941279413794147941579416794177941879419794207942179422794237942479425794267942779428794297943079431794327943379434794357943679437794387943979440794417944279443794447944579446794477944879449794507945179452794537945479455794567945779458794597946079461794627946379464794657946679467794687946979470794717947279473794747947579476794777947879479794807948179482794837948479485794867948779488794897949079491794927949379494794957949679497794987949979500795017950279503795047950579506795077950879509795107951179512795137951479515795167951779518795197952079521795227952379524795257952679527795287952979530795317953279533795347953579536795377953879539795407954179542795437954479545795467954779548795497955079551795527955379554795557955679557795587955979560795617956279563795647956579566795677956879569795707957179572795737957479575795767957779578795797958079581795827958379584795857958679587795887958979590795917959279593795947959579596795977959879599796007960179602796037960479605796067960779608796097961079611796127961379614796157961679617796187961979620796217962279623796247962579626796277962879629796307963179632796337963479635796367963779638796397964079641796427964379644796457964679647796487964979650796517965279653796547965579656796577965879659796607966179662796637966479665796667966779668796697967079671796727967379674796757967679677796787967979680796817968279683796847968579686796877968879689796907969179692796937969479695796967969779698796997970079701797027970379704797057970679707797087970979710797117971279713797147971579716797177971879719797207972179722797237972479725797267972779728797297973079731797327973379734797357973679737797387973979740797417974279743797447974579746797477974879749797507975179752797537975479755797567975779758797597976079761797627976379764797657976679767797687976979770797717977279773797747977579776797777977879779797807978179782797837978479785797867978779788797897979079791797927979379794797957979679797797987979979800798017980279803798047980579806798077980879809798107981179812798137981479815798167981779818798197982079821798227982379824798257982679827798287982979830798317983279833798347983579836798377983879839798407984179842798437984479845798467984779848798497985079851798527985379854798557985679857798587985979860798617986279863798647986579866798677986879869798707987179872798737987479875798767987779878798797988079881798827988379884798857988679887798887988979890798917989279893798947989579896798977989879899799007990179902799037990479905799067990779908799097991079911799127991379914799157991679917799187991979920799217992279923799247992579926799277992879929799307993179932799337993479935799367993779938799397994079941799427994379944799457994679947799487994979950799517995279953799547995579956799577995879959799607996179962799637996479965799667996779968799697997079971799727997379974799757997679977799787997979980799817998279983799847998579986799877998879989799907999179992799937999479995799967999779998799998000080001800028000380004800058000680007800088000980010800118001280013800148001580016800178001880019800208002180022800238002480025800268002780028800298003080031800328003380034800358003680037800388003980040800418004280043800448004580046800478004880049800508005180052800538005480055800568005780058800598006080061800628006380064800658006680067800688006980070800718007280073800748007580076800778007880079800808008180082800838008480085800868008780088800898009080091800928009380094800958009680097800988009980100801018010280103801048010580106801078010880109801108011180112801138011480115801168011780118801198012080121801228012380124801258012680127801288012980130801318013280133801348013580136801378013880139801408014180142801438014480145801468014780148801498015080151801528015380154801558015680157801588015980160801618016280163801648016580166801678016880169801708017180172801738017480175801768017780178801798018080181801828018380184801858018680187801888018980190801918019280193801948019580196801978019880199802008020180202802038020480205802068020780208802098021080211802128021380214802158021680217802188021980220802218022280223802248022580226802278022880229802308023180232802338023480235802368023780238802398024080241802428024380244802458024680247802488024980250802518025280253802548025580256802578025880259802608026180262802638026480265802668026780268802698027080271802728027380274802758027680277802788027980280802818028280283802848028580286802878028880289802908029180292802938029480295802968029780298802998030080301803028030380304803058030680307803088030980310803118031280313803148031580316803178031880319803208032180322803238032480325803268032780328803298033080331803328033380334803358033680337803388033980340803418034280343803448034580346803478034880349803508035180352803538035480355803568035780358803598036080361803628036380364803658036680367803688036980370803718037280373803748037580376803778037880379803808038180382803838038480385803868038780388803898039080391803928039380394803958039680397803988039980400804018040280403804048040580406804078040880409804108041180412804138041480415804168041780418804198042080421804228042380424804258042680427804288042980430804318043280433804348043580436804378043880439804408044180442804438044480445804468044780448804498045080451804528045380454804558045680457804588045980460804618046280463804648046580466804678046880469804708047180472804738047480475804768047780478804798048080481804828048380484804858048680487804888048980490804918049280493804948049580496804978049880499805008050180502805038050480505805068050780508805098051080511805128051380514805158051680517805188051980520805218052280523805248052580526805278052880529805308053180532805338053480535805368053780538805398054080541805428054380544805458054680547805488054980550805518055280553805548055580556805578055880559805608056180562805638056480565805668056780568805698057080571805728057380574805758057680577805788057980580805818058280583805848058580586805878058880589805908059180592805938059480595805968059780598805998060080601806028060380604806058060680607806088060980610806118061280613806148061580616806178061880619806208062180622806238062480625806268062780628806298063080631806328063380634806358063680637806388063980640806418064280643806448064580646806478064880649806508065180652806538065480655806568065780658806598066080661806628066380664806658066680667806688066980670806718067280673806748067580676806778067880679806808068180682806838068480685806868068780688806898069080691806928069380694806958069680697806988069980700807018070280703807048070580706807078070880709807108071180712807138071480715807168071780718807198072080721807228072380724807258072680727807288072980730807318073280733807348073580736807378073880739807408074180742807438074480745807468074780748807498075080751807528075380754807558075680757807588075980760807618076280763807648076580766807678076880769807708077180772807738077480775807768077780778807798078080781807828078380784807858078680787807888078980790807918079280793807948079580796807978079880799808008080180802808038080480805808068080780808808098081080811808128081380814808158081680817808188081980820808218082280823808248082580826808278082880829808308083180832808338083480835808368083780838808398084080841808428084380844808458084680847808488084980850808518085280853808548085580856808578085880859808608086180862808638086480865808668086780868808698087080871808728087380874808758087680877808788087980880808818088280883808848088580886808878088880889808908089180892808938089480895808968089780898808998090080901809028090380904809058090680907809088090980910809118091280913809148091580916809178091880919809208092180922809238092480925809268092780928809298093080931809328093380934809358093680937809388093980940809418094280943809448094580946809478094880949809508095180952809538095480955809568095780958809598096080961809628096380964809658096680967809688096980970809718097280973809748097580976809778097880979809808098180982809838098480985809868098780988809898099080991809928099380994809958099680997809988099981000810018100281003810048100581006810078100881009810108101181012810138101481015810168101781018810198102081021810228102381024810258102681027810288102981030810318103281033810348103581036810378103881039810408104181042810438104481045810468104781048810498105081051810528105381054810558105681057810588105981060810618106281063810648106581066810678106881069810708107181072810738107481075810768107781078810798108081081810828108381084810858108681087810888108981090810918109281093810948109581096810978109881099811008110181102811038110481105811068110781108811098111081111811128111381114811158111681117811188111981120811218112281123811248112581126811278112881129811308113181132811338113481135811368113781138811398114081141811428114381144811458114681147811488114981150811518115281153811548115581156811578115881159811608116181162811638116481165811668116781168811698117081171811728117381174811758117681177811788117981180811818118281183811848118581186811878118881189811908119181192811938119481195811968119781198811998120081201812028120381204812058120681207812088120981210812118121281213812148121581216812178121881219812208122181222812238122481225812268122781228812298123081231812328123381234812358123681237812388123981240812418124281243812448124581246812478124881249812508125181252812538125481255812568125781258812598126081261812628126381264812658126681267812688126981270812718127281273812748127581276812778127881279812808128181282812838128481285812868128781288812898129081291812928129381294812958129681297812988129981300813018130281303813048130581306813078130881309813108131181312813138131481315813168131781318813198132081321813228132381324813258132681327813288132981330813318133281333813348133581336813378133881339813408134181342813438134481345813468134781348813498135081351813528135381354813558135681357813588135981360813618136281363813648136581366813678136881369813708137181372813738137481375813768137781378813798138081381813828138381384813858138681387813888138981390813918139281393813948139581396813978139881399814008140181402814038140481405814068140781408814098141081411814128141381414814158141681417814188141981420814218142281423814248142581426814278142881429814308143181432814338143481435814368143781438814398144081441814428144381444814458144681447814488144981450814518145281453814548145581456814578145881459814608146181462814638146481465814668146781468814698147081471814728147381474814758147681477814788147981480814818148281483814848148581486814878148881489814908149181492814938149481495814968149781498814998150081501815028150381504815058150681507815088150981510815118151281513815148151581516815178151881519815208152181522815238152481525815268152781528815298153081531815328153381534815358153681537815388153981540815418154281543815448154581546815478154881549815508155181552815538155481555815568155781558815598156081561815628156381564815658156681567815688156981570815718157281573815748157581576815778157881579815808158181582815838158481585815868158781588815898159081591815928159381594815958159681597815988159981600816018160281603816048160581606816078160881609816108161181612816138161481615816168161781618816198162081621816228162381624816258162681627816288162981630816318163281633816348163581636816378163881639816408164181642816438164481645816468164781648816498165081651816528165381654816558165681657816588165981660816618166281663816648166581666816678166881669816708167181672816738167481675816768167781678816798168081681816828168381684816858168681687816888168981690816918169281693816948169581696816978169881699817008170181702817038170481705817068170781708817098171081711817128171381714817158171681717817188171981720817218172281723817248172581726817278172881729817308173181732817338173481735817368173781738817398174081741817428174381744817458174681747817488174981750817518175281753817548175581756817578175881759817608176181762817638176481765817668176781768817698177081771817728177381774817758177681777817788177981780817818178281783817848178581786817878178881789817908179181792817938179481795817968179781798817998180081801818028180381804818058180681807818088180981810818118181281813818148181581816818178181881819818208182181822818238182481825818268182781828818298183081831818328183381834818358183681837818388183981840818418184281843818448184581846818478184881849818508185181852818538185481855818568185781858818598186081861818628186381864818658186681867818688186981870818718187281873818748187581876818778187881879818808188181882818838188481885818868188781888818898189081891818928189381894818958189681897818988189981900819018190281903819048190581906819078190881909819108191181912819138191481915819168191781918819198192081921819228192381924819258192681927819288192981930819318193281933819348193581936819378193881939819408194181942819438194481945819468194781948819498195081951819528195381954819558195681957819588195981960819618196281963819648196581966819678196881969819708197181972819738197481975819768197781978819798198081981819828198381984819858198681987819888198981990819918199281993819948199581996819978199881999820008200182002820038200482005820068200782008820098201082011820128201382014820158201682017820188201982020820218202282023820248202582026820278202882029820308203182032820338203482035820368203782038820398204082041820428204382044820458204682047820488204982050820518205282053820548205582056820578205882059820608206182062820638206482065820668206782068820698207082071820728207382074820758207682077820788207982080820818208282083820848208582086820878208882089820908209182092820938209482095820968209782098820998210082101821028210382104821058210682107821088210982110821118211282113821148211582116821178211882119821208212182122821238212482125821268212782128821298213082131821328213382134821358213682137821388213982140821418214282143821448214582146821478214882149821508215182152821538215482155821568215782158821598216082161821628216382164821658216682167821688216982170821718217282173821748217582176821778217882179821808218182182821838218482185821868218782188821898219082191821928219382194821958219682197821988219982200822018220282203822048220582206822078220882209822108221182212822138221482215822168221782218822198222082221822228222382224822258222682227822288222982230822318223282233822348223582236822378223882239822408224182242822438224482245822468224782248822498225082251822528225382254822558225682257822588225982260822618226282263822648226582266822678226882269822708227182272822738227482275822768227782278822798228082281822828228382284822858228682287822888228982290822918229282293822948229582296822978229882299823008230182302823038230482305823068230782308823098231082311823128231382314823158231682317823188231982320823218232282323823248232582326823278232882329823308233182332823338233482335823368233782338823398234082341823428234382344823458234682347823488234982350823518235282353823548235582356823578235882359823608236182362823638236482365823668236782368823698237082371823728237382374823758237682377823788237982380823818238282383823848238582386823878238882389823908239182392823938239482395823968239782398823998240082401824028240382404824058240682407824088240982410824118241282413824148241582416824178241882419824208242182422824238242482425824268242782428824298243082431824328243382434824358243682437824388243982440824418244282443824448244582446824478244882449824508245182452824538245482455824568245782458824598246082461824628246382464824658246682467824688246982470824718247282473824748247582476824778247882479824808248182482824838248482485824868248782488824898249082491824928249382494824958249682497824988249982500825018250282503825048250582506825078250882509825108251182512825138251482515825168251782518825198252082521825228252382524825258252682527825288252982530825318253282533825348253582536825378253882539825408254182542825438254482545825468254782548825498255082551825528255382554825558255682557825588255982560825618256282563825648256582566825678256882569825708257182572825738257482575825768257782578825798258082581825828258382584825858258682587825888258982590825918259282593825948259582596825978259882599826008260182602826038260482605826068260782608826098261082611826128261382614826158261682617826188261982620826218262282623826248262582626826278262882629826308263182632826338263482635826368263782638826398264082641826428264382644826458264682647826488264982650826518265282653826548265582656826578265882659826608266182662826638266482665826668266782668826698267082671826728267382674826758267682677826788267982680826818268282683826848268582686826878268882689826908269182692826938269482695826968269782698826998270082701827028270382704827058270682707827088270982710827118271282713827148271582716827178271882719827208272182722827238272482725827268272782728827298273082731827328273382734827358273682737827388273982740827418274282743827448274582746827478274882749827508275182752827538275482755827568275782758827598276082761827628276382764827658276682767827688276982770827718277282773827748277582776827778277882779827808278182782827838278482785827868278782788827898279082791827928279382794827958279682797827988279982800828018280282803828048280582806828078280882809828108281182812828138281482815828168281782818828198282082821828228282382824828258282682827828288282982830828318283282833828348283582836828378283882839828408284182842828438284482845828468284782848828498285082851828528285382854828558285682857828588285982860828618286282863828648286582866828678286882869828708287182872828738287482875828768287782878828798288082881828828288382884828858288682887828888288982890828918289282893828948289582896828978289882899829008290182902829038290482905829068290782908829098291082911829128291382914829158291682917829188291982920829218292282923829248292582926829278292882929829308293182932829338293482935829368293782938829398294082941829428294382944829458294682947829488294982950829518295282953829548295582956829578295882959829608296182962829638296482965829668296782968829698297082971829728297382974829758297682977829788297982980829818298282983829848298582986829878298882989829908299182992829938299482995829968299782998829998300083001830028300383004830058300683007830088300983010830118301283013830148301583016830178301883019830208302183022830238302483025830268302783028830298303083031830328303383034830358303683037830388303983040830418304283043830448304583046830478304883049830508305183052830538305483055830568305783058830598306083061830628306383064830658306683067830688306983070830718307283073830748307583076830778307883079830808308183082830838308483085830868308783088830898309083091830928309383094830958309683097830988309983100831018310283103831048310583106831078310883109831108311183112831138311483115831168311783118831198312083121831228312383124831258312683127831288312983130831318313283133831348313583136831378313883139831408314183142831438314483145831468314783148831498315083151831528315383154831558315683157831588315983160831618316283163831648316583166831678316883169831708317183172831738317483175831768317783178831798318083181831828318383184831858318683187831888318983190831918319283193831948319583196831978319883199832008320183202832038320483205832068320783208832098321083211832128321383214832158321683217832188321983220832218322283223832248322583226832278322883229832308323183232832338323483235832368323783238832398324083241832428324383244832458324683247832488324983250832518325283253832548325583256832578325883259832608326183262832638326483265832668326783268832698327083271832728327383274832758327683277832788327983280832818328283283832848328583286832878328883289832908329183292832938329483295832968329783298832998330083301833028330383304833058330683307833088330983310833118331283313833148331583316833178331883319833208332183322833238332483325833268332783328833298333083331833328333383334833358333683337833388333983340833418334283343833448334583346833478334883349833508335183352833538335483355833568335783358833598336083361833628336383364833658336683367833688336983370833718337283373833748337583376833778337883379833808338183382833838338483385833868338783388833898339083391833928339383394833958339683397833988339983400834018340283403834048340583406834078340883409834108341183412834138341483415834168341783418834198342083421834228342383424834258342683427834288342983430834318343283433834348343583436834378343883439834408344183442834438344483445834468344783448834498345083451834528345383454834558345683457834588345983460834618346283463834648346583466834678346883469834708347183472834738347483475834768347783478834798348083481834828348383484834858348683487834888348983490834918349283493834948349583496834978349883499835008350183502835038350483505835068350783508835098351083511835128351383514835158351683517835188351983520835218352283523835248352583526835278352883529835308353183532835338353483535835368353783538835398354083541835428354383544835458354683547835488354983550835518355283553835548355583556835578355883559835608356183562835638356483565835668356783568835698357083571835728357383574835758357683577835788357983580835818358283583835848358583586835878358883589835908359183592835938359483595835968359783598835998360083601836028360383604836058360683607836088360983610836118361283613836148361583616836178361883619836208362183622836238362483625836268362783628836298363083631836328363383634836358363683637836388363983640836418364283643836448364583646836478364883649836508365183652836538365483655836568365783658836598366083661836628366383664836658366683667836688366983670836718367283673836748367583676836778367883679836808368183682836838368483685836868368783688836898369083691836928369383694836958369683697836988369983700837018370283703837048370583706837078370883709837108371183712837138371483715837168371783718837198372083721837228372383724837258372683727837288372983730837318373283733837348373583736837378373883739837408374183742837438374483745837468374783748837498375083751837528375383754837558375683757837588375983760837618376283763837648376583766837678376883769837708377183772837738377483775837768377783778837798378083781837828378383784837858378683787837888378983790837918379283793837948379583796837978379883799838008380183802838038380483805838068380783808838098381083811838128381383814838158381683817838188381983820838218382283823838248382583826838278382883829838308383183832838338383483835838368383783838838398384083841838428384383844838458384683847838488384983850838518385283853838548385583856838578385883859838608386183862838638386483865838668386783868838698387083871838728387383874838758387683877838788387983880838818388283883838848388583886838878388883889838908389183892838938389483895838968389783898838998390083901839028390383904839058390683907839088390983910839118391283913839148391583916839178391883919839208392183922839238392483925839268392783928839298393083931839328393383934839358393683937839388393983940
  1. 2011-06-04 Darin Adler <darin@apple.com>
  2. Reviewed by Anders Carlsson.
  3. [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
  4. https://bugs.webkit.org/show_bug.cgi?id=62094
  5. rdar://problem/9539204
  6. * WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
  7. * platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
  8. * platform/network/cf/ResourceHandleCFNet.cpp:
  9. (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
  10. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
  11. * platform/network/mac/ResourceHandleMac.mm:
  12. (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
  13. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
  14. 2011-06-04 Eric Seidel <eric@webkit.org>
  15. Reviewed by Adam Barth.
  16. Add InlineWalker class to hold state for repeated calls to bidiNext
  17. https://bugs.webkit.org/show_bug.cgi?id=60724
  18. This is one more little step towards removing (naked) bidiNext usage.
  19. More refactoring is required before all callers of bidiNext can move
  20. onto using an InlineWalker instead of bidiNext directly.
  21. No change in behavior, thus no tests.
  22. * rendering/InlineIterator.h:
  23. (WebCore::InlineWalker::InlineWalker):
  24. (WebCore::InlineWalker::root):
  25. (WebCore::InlineWalker::current):
  26. (WebCore::InlineWalker::atEndOfInline):
  27. (WebCore::InlineWalker::atEnd):
  28. (WebCore::InlineWalker::advance):
  29. * rendering/RenderBlock.cpp:
  30. (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  31. * rendering/RenderBlockLineLayout.cpp:
  32. (WebCore::RenderBlock::layoutInlineChildren):
  33. 2011-06-04 Sam Weinig <sam@webkit.org>
  34. Reviewed by Anders Carlsson.
  35. WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
  36. https://bugs.webkit.org/show_bug.cgi?id=62093
  37. Add additional ChromeClient functions to indicate the beginning and end of
  38. the various ScrollAnimator animations. Change existing notification that a
  39. rubber-band has completed for the main frame to be triggered for all frames.
  40. * page/ChromeClient.h:
  41. (WebCore::ChromeClient::didStartRubberBandForFrame):
  42. (WebCore::ChromeClient::didCompleteRubberBandForFrame):
  43. (WebCore::ChromeClient::didStartAnimatedScroll):
  44. (WebCore::ChromeClient::didCompleteAnimatedScroll):
  45. * page/FrameView.cpp:
  46. (WebCore::FrameView::didStartRubberBand):
  47. (WebCore::FrameView::didCompleteRubberBand):
  48. (WebCore::FrameView::didStartAnimatedScroll):
  49. (WebCore::FrameView::didCompleteAnimatedScroll):
  50. * page/FrameView.h:
  51. * platform/ScrollableArea.h:
  52. (WebCore::ScrollableArea::didStartRubberBand):
  53. (WebCore::ScrollableArea::didStartAnimatedScroll):
  54. (WebCore::ScrollableArea::didCompleteAnimatedScroll):
  55. * platform/mac/ScrollAnimatorMac.h:
  56. * platform/mac/ScrollAnimatorMac.mm:
  57. (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
  58. (WebCore::ScrollAnimatorMac::scroll):
  59. (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation):
  60. (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
  61. 2011-06-04 Martin Robinson <mrobinson@igalia.com>
  62. Touch a file to try to fix the GTK+ build on the 32-bit bot.
  63. * testing/Internals.idl: Touch this IDL file in an effort to fix the build.
  64. 2011-06-04 Martin Robinson <mrobinson@igalia.com>
  65. Fix the GTK+ build.
  66. * bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.
  67. 2011-06-03 Dimitri Glazkov <dglazkov@chromium.org>
  68. Reviewed by Darin Adler.
  69. Convert file <input> to use the new shadow DOM model
  70. https://bugs.webkit.org/show_bug.cgi?id=59005
  71. Refactoring, covered by existing tests.
  72. * css/CSSSelector.cpp:
  73. (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it.
  74. (WebCore::nameToPseudoTypeMap): Ditto.
  75. (WebCore::CSSSelector::extractPseudoType): Ditto.
  76. * css/CSSSelector.h: Ditto.
  77. * css/html.css:
  78. (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule.
  79. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
  80. * html/FileInputType.cpp:
  81. (WebCore::UploadButtonElement::create): Added.
  82. (WebCore::UploadButtonElement::UploadButtonElement): Added.
  83. (WebCore::UploadButtonElement::shadowPseudoId): Added.
  84. (WebCore::FileInputType::createShadowSubtree): Added.
  85. * html/FileInputType.h: Added createShadowSubtree decl.
  86. * page/DragController.cpp:
  87. (WebCore::asFileInput): Changed the logic to use new shadow DOM.
  88. * rendering/RenderFileUploadControl.cpp: Removed UploadButton class.
  89. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button.
  90. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary.
  91. (WebCore::nodeWidth): Added a helper.
  92. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth.
  93. (WebCore::RenderFileUploadControl::paintObject): Ditto.
  94. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button.
  95. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
  96. * rendering/RenderFileUploadControl.h: Changed decls.
  97. * rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
  98. 2011-06-04 Alexey Proskuryakov <ap@apple.com>
  99. Reviewed by Darin Adler.
  100. Input value sanitization for text fields is incorrect
  101. https://bugs.webkit.org/show_bug.cgi?id=62061
  102. <rdar://problem/9553273>
  103. Newline characters should be removed according to HTML5, not replaced with spaces.
  104. This also matches Safari 5 behavior.
  105. * html/TextFieldInputType.cpp:
  106. (WebCore::isASCIILineBreak): A functor for removeCharacters().
  107. (WebCore::limitLength): Do one thing at once.
  108. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines.
  109. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising)
  110. code that replaces newlines with spaces here.
  111. 2011-06-04 Jeffrey Pfau <jpfau@apple.com>
  112. Reviewed by Beth Dakin.
  113. Crash in WebCore::RenderMathMLSubSup::baselinePosition()
  114. https://bugs.webkit.org/show_bug.cgi?id=57897
  115. Simple patch adding NULL checks in each function.
  116. Test: mathml/msubsup-remove-children.xhtml
  117. * rendering/mathml/RenderMathMLSubSup.cpp:
  118. (WebCore::RenderMathMLSubSup::stretchToHeight):
  119. (WebCore::RenderMathMLSubSup::baselinePosition):
  120. 2011-06-04 Nico Weber <thakis@chromium.org>
  121. Reviewed by James Robinson.
  122. Give IDBBackingStore::Transaction a virtual destructor
  123. https://bugs.webkit.org/show_bug.cgi?id=62063
  124. IDBLevelDBBackingStore::createTransaction() hands out a
  125. PassRefPtr<IDBBackingStore::Transaction>, which means the missing
  126. virtual destructor is a real bug.
  127. * storage/IDBBackingStore.h:
  128. (WebCore::IDBBackingStore::Transaction::~Transaction):
  129. 2011-06-04 Emil A Eklund <eae@chromium.org>
  130. Reviewed by Eric Seidel.
  131. Convert RenderBox::overflowClipRect to IntPoint
  132. https://bugs.webkit.org/show_bug.cgi?id=62032
  133. Covered by existing tests.
  134. * editing/Editor.cpp:
  135. (WebCore::Editor::insideVisibleArea):
  136. * platform/graphics/IntRect.h:
  137. (WebCore::IntRect::contract):
  138. * rendering/RenderBlock.cpp:
  139. (WebCore::RenderBlock::nodeAtPoint):
  140. * rendering/RenderBox.cpp:
  141. (WebCore::RenderBox::pushContentsClip):
  142. (WebCore::RenderBox::overflowClipRect):
  143. * rendering/RenderBox.h:
  144. * rendering/RenderBoxModelObject.cpp:
  145. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  146. * rendering/RenderLayer.cpp:
  147. (WebCore::RenderLayer::calculateClipRects):
  148. (WebCore::RenderLayer::calculateRects):
  149. (WebCore::RenderLayer::repaintBlockSelectionGaps):
  150. * rendering/RenderLayerBacking.cpp:
  151. (WebCore::clipBox):
  152. * rendering/RenderTable.cpp:
  153. (WebCore::RenderTable::overflowClipRect):
  154. (WebCore::RenderTable::nodeAtPoint):
  155. * rendering/RenderTable.h:
  156. * rendering/RenderTableSection.cpp:
  157. (WebCore::RenderTableSection::nodeAtPoint):
  158. * rendering/svg/RenderSVGRoot.cpp:
  159. (WebCore::RenderSVGRoot::paint):
  160. 2011-06-04 Adam Barth <abarth@webkit.org>
  161. Reviewed by Eric Seidel.
  162. V8Proxy::disconnectFrame doesn't do anything
  163. https://bugs.webkit.org/show_bug.cgi?id=62051
  164. Dead code should die.
  165. * bindings/v8/ScriptController.cpp:
  166. (WebCore::ScriptController::~ScriptController):
  167. * bindings/v8/V8Proxy.cpp:
  168. * bindings/v8/V8Proxy.h:
  169. 2011-06-04 Nico Weber <thakis@chromium.org>
  170. Reviewed by James Robinson.
  171. Make the destructors of DataTransferItem and DataTransferItems virtual
  172. https://bugs.webkit.org/show_bug.cgi?id=62052
  173. Clang has grown a new warning that warns on |delete ptr| if ptr's
  174. class is non-final, has virtual methods, but no virtual destructor.
  175. This warning finds real bugs, so we want to keep it enabled. However,
  176. it also warns about DataTransferItem[s]. Since these are subclassed,
  177. they can't be made final, so make their destructors virtual. (Maybe
  178. clang's warning even points out an actual bug here.)
  179. * dom/DataTransferItem.h:
  180. (WebCore::DataTransferItem::~DataTransferItem):
  181. * dom/DataTransferItems.h:
  182. (WebCore::DataTransferItems::~DataTransferItems):
  183. 2011-06-04 Nico Weber <thakis@chromium.org>
  184. Reviewed by James Robinson.
  185. [chromium] Make LayerPainterChromium destructor virtual
  186. https://bugs.webkit.org/show_bug.cgi?id=62056
  187. LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
  188. means that without this patch, the destructor of classes implementing
  189. LayerPainterChromium wasn't called correctly in that case.
  190. * platform/graphics/chromium/LayerPainterChromium.h:
  191. (WebCore::LayerPainterChromium::~LayerPainterChromium):
  192. 2011-06-04 Emil A Eklund <eae@chromium.org>
  193. Reviewed by Andreas Kling.
  194. Fix IntRect::expand(const IntSize& size)
  195. https://bugs.webkit.org/show_bug.cgi?id=62042
  196. No new tests.
  197. * platform/graphics/IntRect.h:
  198. (WebCore::IntRect::expand):
  199. Fix IntRect::expand to expand the size rather than move the location.
  200. Currently unused.
  201. 2011-06-03 Alexey Proskuryakov <ap@apple.com>
  202. Reviewed by Darin Adler.
  203. ResourceHandleMac should always respond to an authentication challenge
  204. https://bugs.webkit.org/show_bug.cgi?id=61667
  205. I don't know if this can actually happen in practice, so no new tests.
  206. * platform/network/mac/ResourceHandleMac.mm:
  207. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
  208. Cancel authentication challenge if we don't have a client. We must always respond to the
  209. challenge to release the connection, and there is nothing else to do in this state anyway.
  210. 2011-06-03 Dan Bernstein <mitz@apple.com>
  211. Try to fix the Apple LLVM Compiler build after r88087.
  212. * rendering/RenderTableCell.cpp:
  213. (WebCore::RenderTableCell::paintMask):
  214. * rendering/RenderTableCell.h:
  215. 2011-06-03 Chris Rogers <crogers@google.com>
  216. Unreviewed build fix.
  217. Fix clang build - take 2
  218. https://bugs.webkit.org/show_bug.cgi?id=62081
  219. * webaudio/AudioParamTimeline.cpp:
  220. (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
  221. 2011-06-03 Chris Rogers <crogers@google.com>
  222. Unreviewed clang build fix.
  223. Fix clang build
  224. https://bugs.webkit.org/show_bug.cgi?id=62080
  225. * webaudio/AudioParamTimeline.cpp:
  226. (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
  227. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  228. Reviewed by Eric Seidel.
  229. Switch paintMask and paintObject to use IntPoint
  230. https://bugs.webkit.org/show_bug.cgi?id=62077
  231. Switching paintMask and paintObject to use IntPoint for their paint offset instead of
  232. a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
  233. passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.
  234. No new tests since this is simple refactoring.
  235. * rendering/RenderBlock.cpp:
  236. (WebCore::RenderBlock::paint):
  237. (WebCore::RenderBlock::paintObject):
  238. * rendering/RenderBlock.h:
  239. * rendering/RenderBox.cpp:
  240. (WebCore::RenderBox::paintMask):
  241. (WebCore::RenderBox::pushContentsClip):
  242. (WebCore::RenderBox::popContentsClip):
  243. * rendering/RenderBox.h:
  244. (WebCore::RenderBox::paintObject):
  245. * rendering/RenderFieldset.cpp:
  246. (WebCore::RenderFieldset::paintMask):
  247. * rendering/RenderFieldset.h:
  248. * rendering/RenderFileUploadControl.cpp:
  249. (WebCore::RenderFileUploadControl::paintObject):
  250. * rendering/RenderFileUploadControl.h:
  251. * rendering/RenderListBox.cpp:
  252. (WebCore::RenderListBox::paintObject):
  253. * rendering/RenderListBox.h:
  254. * rendering/RenderReplaced.cpp:
  255. (WebCore::RenderReplaced::paint):
  256. * rendering/RenderReplica.cpp:
  257. (WebCore::RenderReplica::paint):
  258. * rendering/RenderTable.cpp:
  259. (WebCore::RenderTable::paint):
  260. (WebCore::RenderTable::paintObject):
  261. (WebCore::RenderTable::paintMask):
  262. * rendering/RenderTable.h:
  263. * rendering/RenderTableSection.cpp:
  264. (WebCore::RenderTableSection::paint):
  265. (WebCore::RenderTableSection::paintObject):
  266. * rendering/RenderTableSection.h:
  267. * rendering/RenderTextControl.cpp:
  268. (WebCore::RenderTextControl::paintPlaceholder):
  269. (WebCore::RenderTextControl::paintObject):
  270. * rendering/RenderTextControl.h:
  271. * rendering/RenderView.cpp:
  272. (WebCore::RenderView::paint):
  273. * rendering/RenderWidget.cpp:
  274. (WebCore::RenderWidget::paint):
  275. 2011-06-03 Cary Clark <caryclark@google.com>
  276. Reviewed by Eric Seidel.
  277. Support FontCustomPlatformData on Skia-Mac-Chrome variant
  278. https://bugs.webkit.org/show_bug.cgi?id=62040
  279. Canvas text is only recognized by Skia if it is registered
  280. by creating a new SkTypeface. Skia uses CGFont to measure
  281. and render the glyphs, then takes care of managing the glyph
  282. cache.
  283. Skia on Mac Chrome is not yet enabled, so this change
  284. does not affect existing code, and requires no new tests.
  285. * platform/graphics/mac/FontCustomPlatformData.cpp:
  286. (WebCore::RemoteFontStream::RemoteFontStream):
  287. (WebCore::RemoteFontStream::~RemoteFontStream):
  288. (WebCore::RemoteFontStream::rewind):
  289. (WebCore::RemoteFontStream::read):
  290. Turn the buffer into a stream. This is identical to
  291. the implementation in skia/FontCustomPlatformData.cpp.
  292. While that file could be modified instead of this one,
  293. it was simpler to add SkTypeface streaming to this instead
  294. of adding all CGFont support to the skia platform file.
  295. (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
  296. Release the SkTypeface reference.
  297. (WebCore::createFontCustomPlatformData):
  298. Associate the buffer stream with a SkTypeface so Skia
  299. can find the custom font data.
  300. * platform/graphics/mac/FontCustomPlatformData.h:
  301. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  302. Add a slot to hold the SkTypeface.
  303. 2011-06-03 Steve Falkenburg <sfalken@apple.com>
  304. Reviewed by Brian Weinstein.
  305. HistoryItem children persist across page loads
  306. https://bugs.webkit.org/show_bug.cgi?id=62071
  307. <rdar://problem/9552129>
  308. Not testable since there's no way to check for the presence/absence
  309. of children for a HistoryItem.
  310. * history/HistoryItem.cpp:
  311. (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.
  312. 2011-06-03 Chris Rogers <crogers@google.com>
  313. Reviewed by Kenneth Russell.
  314. Allow existing AudioParams to use scheduled parameter changes
  315. https://bugs.webkit.org/show_bug.cgi?id=62046
  316. No new tests since audio API is not yet implemented.
  317. * platform/audio/AudioBus.cpp:
  318. (WebCore::AudioBus::processWithGainFrom):
  319. (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
  320. * platform/audio/AudioBus.h:
  321. * webaudio/AudioBufferSourceNode.cpp:
  322. (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
  323. * webaudio/AudioGainNode.cpp:
  324. (WebCore::AudioGainNode::AudioGainNode):
  325. (WebCore::AudioGainNode::process):
  326. * webaudio/AudioGainNode.h:
  327. * webaudio/HighPass2FilterNode.cpp:
  328. (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  329. * webaudio/LowPass2FilterNode.cpp:
  330. (WebCore::LowPass2FilterNode::LowPass2FilterNode):
  331. 2011-06-03 Chris Rogers <crogers@google.com>
  332. Reviewed by Kenneth Russell.
  333. Biquad filter coefficient naming is incorrect
  334. https://bugs.webkit.org/show_bug.cgi?id=62053
  335. No new tests since audio API is not yet implemented.
  336. * platform/audio/Biquad.cpp:
  337. (WebCore::Biquad::Biquad):
  338. (WebCore::Biquad::process):
  339. (WebCore::Biquad::processFast):
  340. (WebCore::Biquad::setLowpassParams):
  341. (WebCore::Biquad::setHighpassParams):
  342. (WebCore::Biquad::setLowShelfParams):
  343. (WebCore::Biquad::setZeroPolePairs):
  344. * platform/audio/Biquad.h:
  345. 2011-06-03 Adam Barth <abarth@webkit.org>
  346. Reviewed by Eric Seidel.
  347. DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
  348. https://bugs.webkit.org/show_bug.cgi?id=62057
  349. This code gets confused when dealing with inactive DOMWindows. We
  350. should just block inactive DOMWindows because there's no compatibility
  351. reason to support them in this code path.
  352. Test: http/tests/security/xss-DENIED-contentWindow-eval.html
  353. * page/DOMWindow.cpp:
  354. (WebCore::DOMWindow::isInsecureScriptAccess):
  355. 2011-05-31 Martin Robinson <mrobinson@igalia.com>
  356. Reviewed by Ryosuke Niwa.
  357. [GTK] Support smart replace for the pasteboard
  358. https://bugs.webkit.org/show_bug.cgi?id=61734
  359. Add smart replace support to WebCore and add hooks for it in WebKit
  360. via DumpRenderTreeSupportGtk. When a platform supports smart replace,
  361. WebCore will remove extra spaces that appear when pasting text. Eventually
  362. WebKitGTK+ may want to expose this in the public API.
  363. * platform/gtk/PasteboardGtk.cpp:
  364. (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace
  365. when calling writeSelection.
  366. (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard
  367. for whether or not it supports smart paste.
  368. * platform/gtk/PasteboardHelper.cpp:
  369. (WebCore::initGdkAtoms): Added initialization for smart replace atom.
  370. (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom.
  371. (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter.
  372. (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter.
  373. (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
  374. * platform/gtk/PasteboardHelper.h: Add new method definition.
  375. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  376. Reviewed by Eric Seidel.
  377. Switch paintCell to use IntPoint
  378. https://bugs.webkit.org/show_bug.cgi?id=62033
  379. Switching paintCell to take an IntPoint representing the paint offset
  380. instead of a pair of ints.
  381. No new tests since this is simple refactoring.
  382. * rendering/RenderTableSection.cpp:
  383. (WebCore::RenderTableSection::paintCell):
  384. (WebCore::RenderTableSection::paintObject):
  385. * rendering/RenderTableSection.h:
  386. 2011-06-03 Martin Robinson <mrobinson@igalia.com>
  387. Reviewed by Dimitri Glazkov.
  388. Teach Gtk build about window.internals
  389. https://bugs.webkit.org/show_bug.cgi?id=61071
  390. * GNUmakefile.am: Add new internals directories to the VPATH
  391. (for idl processing) and the include list.
  392. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  393. Reviewed by Eric Seidel.
  394. Switch paintBackgroundsBehindCell to use IntPoint
  395. https://bugs.webkit.org/show_bug.cgi?id=62031
  396. Switching paintBackgroundsBehindCell to take an IntPoint representing
  397. the paint offset instead of a pair of ints.
  398. No new tests as this is simple refactoring.
  399. * rendering/RenderTableCell.cpp:
  400. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  401. (WebCore::RenderTableCell::paintBoxDecorations):
  402. * rendering/RenderTableCell.h:
  403. * rendering/RenderTableRow.cpp:
  404. (WebCore::RenderTableRow::paint):
  405. * rendering/RenderTableSection.cpp:
  406. (WebCore::RenderTableSection::paintCell):
  407. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  408. Reviewed by Eric Seidel.
  409. Switch paintCaret and paintDragCaret to use IntPoint
  410. https://bugs.webkit.org/show_bug.cgi?id=62037
  411. Switching paintCaret and paintDragCaret to use an IntPoint representing
  412. the paint offset instead of a pair of ints.
  413. No new tests since this is simple refactoring.
  414. * editing/FrameSelection.cpp:
  415. (WebCore::FrameSelection::paintCaret):
  416. (WebCore::CaretBase::paintCaret):
  417. (WebCore::DragCaretController::paintDragCaret):
  418. * editing/FrameSelection.h:
  419. * rendering/RenderBlock.cpp:
  420. (WebCore::RenderBlock::paintCaret):
  421. (WebCore::RenderBlock::paintObject):
  422. (WebCore::RenderBlock::positionForPoint):
  423. (WebCore::RenderBlock::offsetForContents):
  424. * rendering/RenderBlock.h:
  425. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  426. Reviewed by Eric Seidel.
  427. Switch paintItemForeground and paintItemForeground to use IntPoint
  428. https://bugs.webkit.org/show_bug.cgi?id=62035
  429. Switching paintItemFore/Background to use IntPoint instead of a pair of ints.
  430. No new tests since this is simple refactoring.
  431. * rendering/RenderListBox.cpp:
  432. (WebCore::RenderListBox::paintObject):
  433. (WebCore::RenderListBox::paintItemForeground):
  434. (WebCore::RenderListBox::paintItemBackground):
  435. * rendering/RenderListBox.h:
  436. 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
  437. Reviewed by Andreas Kling.
  438. To support building namespaced Qt, we require that forward-declarations
  439. of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
  440. * platform/network/qt/QtMIMETypeSniffer.h:
  441. 2011-06-03 Rob Buis <rbuis@rim.com>
  442. Reviewed by Nikolas Zimmermann.
  443. Cleanup member variable usage in svg/animation classes
  444. https://bugs.webkit.org/show_bug.cgi?id=62029
  445. Cleanup member variables.
  446. * svg/animation/SMILTimeContainer.cpp:
  447. (WebCore::SMILTimeContainer::SMILTimeContainer):
  448. (WebCore::SMILTimeContainer::sampleAnimationAtTime):
  449. (WebCore::SMILTimeContainer::updateAnimations):
  450. * svg/animation/SMILTimeContainer.h:
  451. * svg/animation/SVGSMILElement.cpp:
  452. (WebCore::SVGSMILElement::SVGSMILElement):
  453. * svg/animation/SVGSMILElement.h:
  454. 2011-06-03 Chris Rogers <crogers@google.com>
  455. Reviewed by Kenneth Russell.
  456. Add AudioParam parameter scheduling implementation
  457. https://bugs.webkit.org/show_bug.cgi?id=61830
  458. No new tests since audio API is not yet implemented.
  459. * WebCore.gypi:
  460. * WebCore.xcodeproj/project.pbxproj:
  461. * webaudio/AudioParam.cpp:
  462. (WebCore::AudioParam::value):
  463. (WebCore::AudioParam::smoothedValue):
  464. (WebCore::AudioParam::smooth):
  465. (WebCore::AudioParam::calculateSampleAccurateValues):
  466. * webaudio/AudioParam.h:
  467. (WebCore::AudioParam::setContext):
  468. (WebCore::AudioParam::context):
  469. (WebCore::AudioParam::setValueAtTime):
  470. (WebCore::AudioParam::linearRampToValueAtTime):
  471. (WebCore::AudioParam::exponentialRampToValueAtTime):
  472. (WebCore::AudioParam::setTargetValueAtTime):
  473. (WebCore::AudioParam::setValueCurveAtTime):
  474. (WebCore::AudioParam::cancelScheduledValues):
  475. (WebCore::AudioParam::hasTimelineValues):
  476. * webaudio/AudioParam.idl:
  477. * webaudio/AudioParamTimeline.cpp: Added.
  478. (WebCore::AudioParamTimeline::setValueAtTime):
  479. (WebCore::AudioParamTimeline::linearRampToValueAtTime):
  480. (WebCore::AudioParamTimeline::exponentialRampToValueAtTime):
  481. (WebCore::AudioParamTimeline::setTargetValueAtTime):
  482. (WebCore::AudioParamTimeline::setValueCurveAtTime):
  483. (WebCore::isValidNumber):
  484. (WebCore::AudioParamTimeline::insertEvent):
  485. (WebCore::AudioParamTimeline::cancelScheduledValues):
  486. (WebCore::AudioParamTimeline::valueForContextTime):
  487. (WebCore::AudioParamTimeline::valuesForTimeRange):
  488. (WebCore::timeToSampleFrame):
  489. (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
  490. * webaudio/AudioParamTimeline.h: Added.
  491. (WebCore::AudioParamTimeline::AudioParamTimeline):
  492. (WebCore::AudioParamTimeline::hasValues):
  493. (WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
  494. (WebCore::AudioParamTimeline::ParamEvent::type):
  495. (WebCore::AudioParamTimeline::ParamEvent::value):
  496. (WebCore::AudioParamTimeline::ParamEvent::time):
  497. (WebCore::AudioParamTimeline::ParamEvent::timeConstant):
  498. (WebCore::AudioParamTimeline::ParamEvent::duration):
  499. (WebCore::AudioParamTimeline::ParamEvent::curve):
  500. 2011-06-01 Jer Noble <jer.noble@apple.com>
  501. Reviewed by Simon Fraser.
  502. Flash of broken page when exiting full screen at jerryseinfeld.com
  503. https://bugs.webkit.org/show_bug.cgi?id=61897
  504. <rdar://problem/9522985>
  505. Test: fullscreen/full-screen-placeholder.html
  506. Entering full-screen mode is causing the page layout to change because the full-screen
  507. element is taken out of the normal flow. To counteract this effect, insert a placeholder
  508. block as a parent of the full-screen renderer with the same size and style as the full-screen
  509. element pre-full-screen.
  510. Only create a placeholder for block-level elements; the technique required for inline elements
  511. would be vastly more complicated.
  512. * dom/Document.cpp:
  513. (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder
  514. based on the size and style of the full-screen element.
  515. (WebCore::Document::setFullScreenRenderer): Persist the placeholder size and
  516. style across new renderers.
  517. * rendering/RenderFullScreen.cpp:
  518. (RenderFullScreen::RenderFullScreen): Added ivar.
  519. (RenderFullScreen::destroy): Make sure to safely destroy our placeholder.
  520. (RenderFullScreen::createPlaceholder): Added.
  521. * rendering/RenderFullScreen.h:
  522. (WebCore::RenderFullScreen::placeholder): Ivar accessor.
  523. 2011-06-03 Levi Weintraub <leviw@chromium.org>
  524. Reviewed by Eric Seidel.
  525. Switch paintBoxDecorations to IntPoint
  526. https://bugs.webkit.org/show_bug.cgi?id=61968
  527. Switching paintBoxDecorations to take an IntPoint representing
  528. the paint offset instead of a pair of ints. Also cleaning up
  529. some duplicated code in InlineFlowBox related to constraining
  530. the paint rect to the linetop and linebottom.
  531. No new tests since this is just refactoring.
  532. * rendering/InlineFlowBox.cpp:
  533. (WebCore::InlineFlowBox::paint):
  534. (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added
  535. to remove duplicate code in paintBoxDecorations and paintMask.
  536. (WebCore::InlineFlowBox::paintBoxDecorations):
  537. (WebCore::InlineFlowBox::paintMask):
  538. * rendering/InlineFlowBox.h:
  539. * rendering/RenderBlock.cpp:
  540. (WebCore::RenderBlock::paintObject):
  541. * rendering/RenderBox.cpp:
  542. (WebCore::RenderBox::paintBoxDecorations):
  543. * rendering/RenderBox.h:
  544. * rendering/RenderFieldset.cpp:
  545. (WebCore::RenderFieldset::paintBoxDecorations):
  546. * rendering/RenderFieldset.h:
  547. * rendering/RenderReplaced.cpp:
  548. (WebCore::RenderReplaced::paint):
  549. * rendering/RenderTable.cpp:
  550. (WebCore::RenderTable::paintObject):
  551. (WebCore::RenderTable::paintBoxDecorations):
  552. * rendering/RenderTable.h:
  553. * rendering/RenderTableCell.cpp:
  554. (WebCore::RenderTableCell::paintBoxDecorations):
  555. * rendering/RenderTableCell.h:
  556. * rendering/RenderView.cpp:
  557. (WebCore::RenderView::paintBoxDecorations):
  558. * rendering/RenderView.h:
  559. * rendering/RenderWidget.cpp:
  560. (WebCore::RenderWidget::paint):
  561. * rendering/svg/RenderSVGRoot.cpp:
  562. (WebCore::RenderSVGRoot::paint):
  563. 2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>
  564. Reviewed by Benjamin Poulain.
  565. [Qt]The minimum size of the select menu list is incorrect for qtwebkit
  566. https://bugs.webkit.org/show_bug.cgi?id=56752
  567. The minimum width of the select-box is calculated to be as small as possible
  568. instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
  569. This will avoid overapping the select lists in popular websites.
  570. Test: fast/forms/selectlist-minsize.html
  571. * platform/qt/RenderThemeQt.cpp:
  572. (WebCore::RenderThemeQt::minimumMenuListSize):
  573. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  574. Reviewed by Darin Adler.
  575. Prevent event dispatch for events with related target when host is the target.
  576. https://bugs.webkit.org/show_bug.cgi?id=61979
  577. Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
  578. So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.
  579. * dom/EventDispatcher.cpp:
  580. (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing.
  581. (WebCore::EventDispatcher::EventDispatcher): Added initializer.
  582. (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
  583. * dom/EventDispatcher.h: Added a def.
  584. 2011-06-03 Dan Bernstein <mitz@apple.com>
  585. Mac build fix.
  586. * WebCore.xcodeproj/project.pbxproj:
  587. 2011-06-03 Naoki Takano <takano.naoki@gmail.com>
  588. Reviewed by Eric Seidel.
  589. [Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
  590. https://bugs.webkit.org/show_bug.cgi?id=61260
  591. http://code.google.com/p/chromium/issues/detail?id=12721
  592. Manual test: select-popup-tooltip-test.html
  593. * manual-tests/select-popup-tooltip-test.html: Added.
  594. * platform/chromium/PopupMenuChromium.cpp:
  595. (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
  596. * platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.
  597. 2011-06-03 Rob Buis <rbuis@rim.com>
  598. Reviewed by Nikolas Zimmermann.
  599. Creating <animateMotion> elements via javascript do not execute
  600. https://bugs.webkit.org/show_bug.cgi?id=34301
  601. Enable constructors for SVGMPathElement and SVGAnimateMotionElement.
  602. * DerivedSources.cpp:
  603. * DerivedSources.make:
  604. * GNUmakefile.list.am:
  605. * WebCore.gypi:
  606. * WebCore.vcproj/WebCore.vcproj:
  607. * WebCore.xcodeproj/project.pbxproj:
  608. * page/DOMWindow.idl:
  609. 2011-06-03 Hans Wennborg <hans@chromium.org>
  610. Reviewed by Steve Block.
  611. IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
  612. https://bugs.webkit.org/show_bug.cgi?id=62009
  613. This constant should only be needed inside IDBLevelDBCoding.cpp.
  614. No new functionality, no new tests.
  615. * storage/IDBLevelDBBackingStore.cpp:
  616. (WebCore::getNewDatabaseId):
  617. (WebCore::IDBLevelDBBackingStore::getObjectStores):
  618. (WebCore::getNewObjectStoreId):
  619. (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
  620. (WebCore::getNewIndexId):
  621. * storage/IDBLevelDBCoding.cpp:
  622. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey):
  623. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
  624. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
  625. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey):
  626. (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
  627. * storage/IDBLevelDBCoding.h:
  628. 2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>
  629. Reviewed by Benjamin Poulain.
  630. [Qt] Build flag for experimental ICU library support
  631. https://bugs.webkit.org/show_bug.cgi?id=60786
  632. Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
  633. ICU powered Unicode support.
  634. No new tests as no new features added.
  635. * WebCore.pri: Removed text_breaking_with_icu CONFIG flag.
  636. * WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
  637. * editing/qt/SmartReplaceQt.cpp:
  638. * features.pri: Support for use_system_icu CONFIG flag.
  639. * platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE).
  640. * platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added.
  641. (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER):
  642. (WebCore::currentSearchLocaleID):
  643. (WebCore::currentTextBreakLocaleID):
  644. * platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID().
  645. (WebCore::isTextBreak):
  646. * platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE).
  647. (WebCore::TextCodecQt::registerEncodingNames):
  648. (WebCore::TextCodecQt::registerCodecs):
  649. 2011-06-03 Yael Aharon <yael.aharon@nokia.com>
  650. Reviewed by Kenneth Rohde Christiansen.
  651. Frame flattening is broken with nested frames
  652. https://bugs.webkit.org/show_bug.cgi?id=61491
  653. Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
  654. Test: fast/frames/flattening/iframe-flattening-out-of-view.html
  655. fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
  656. fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
  657. * rendering/RenderIFrame.cpp:
  658. (WebCore::RenderIFrame::flattenFrame):
  659. 2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
  660. Reviewed by Andreas Kling.
  661. Incorrect embedded document replaced size calculation for box-sizing: border-box
  662. https://bugs.webkit.org/show_bug.cgi?id=62007
  663. When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
  664. which has an intrinsic width/height, the embedded document intrinsic size is incorrect.
  665. RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.
  666. Tests: svg/as-image/img-preserveAspectRatio-support-2.html
  667. svg/as-object/object-box-sizing-no-width-height.html
  668. * rendering/RenderPart.cpp:
  669. (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
  670. (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
  671. 2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
  672. Unreviewed, rolling out r88004.
  673. http://trac.webkit.org/changeset/88004
  674. https://bugs.webkit.org/show_bug.cgi?id=62008
  675. This patch broke 4 tests in the GTK bots (Requested by
  676. msanchez on #webkit).
  677. * accessibility/gtk/AXObjectCacheAtk.cpp:
  678. (WebCore::AXObjectCache::handleScrolledToAnchor):
  679. 2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
  680. Reviewed by Andreas Kling.
  681. Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
  682. https://bugs.webkit.org/show_bug.cgi?id=62005
  683. Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
  684. Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
  685. zoom in the RenderStyle instead of asking SVGSVGElement.
  686. The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
  687. They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.
  688. Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html
  689. * rendering/svg/RenderSVGRoot.cpp:
  690. (WebCore::RenderSVGRoot::computeIntrinsicWidth):
  691. (WebCore::RenderSVGRoot::computeIntrinsicHeight):
  692. (WebCore::RenderSVGRoot::localToBorderBoxTransform):
  693. * svg/SVGSVGElement.cpp:
  694. (WebCore::SVGSVGElement::SVGSVGElement):
  695. (WebCore::SVGSVGElement::currentScale):
  696. (WebCore::SVGSVGElement::setCurrentScale):
  697. * svg/SVGSVGElement.h:
  698. 2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
  699. Reviewed by Martin Robinson.
  700. Focus and caret position should be updated when same-page links are followed
  701. https://bugs.webkit.org/show_bug.cgi?id=59737
  702. Update the caret position to the anchor's position after scrolling.
  703. This behavior is specific to the Gtk port and requested because of
  704. accessibility needs, that's why it's implemented in AXObjectCache.
  705. Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html
  706. * accessibility/gtk/AXObjectCacheAtk.cpp:
  707. (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the
  708. caret is updated to be in the anchor's position after scrolling.
  709. 2011-06-03 Dominic Cooney <dominicc@chromium.org>
  710. Reviewed by Kent Tamura.
  711. Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
  712. https://bugs.webkit.org/show_bug.cgi?id=61984
  713. When cloneNode's tag name-based cloning algorithm clones the
  714. KeygenSelectElements of a keygen shadow as select elements. These
  715. lack the -webkit-keygen-select pseudoclass.
  716. Test: fast/html/clone-keygen.html
  717. * html/HTMLKeygenElement.cpp:
  718. (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
  719. 2011-06-02 MORITA Hajime <morrita@google.com>
  720. Unreviewed ChangeLog fix.
  721. 2011-06-03 Peter Varga <pvarga@webkit.org>
  722. Rubber-stamped by Csaba Osztrogonác.
  723. [Qt][V8] Buildfix after r87988.
  724. No new tests needed.
  725. * bindings/v8/ScheduledAction.cpp: Add missing guards.
  726. (WebCore::ScheduledAction::execute):
  727. * bindings/v8/V8EventListener.cpp: Ditto.
  728. (WebCore::V8EventListener::callListenerFunction):
  729. 2011-06-03 Dominic Cooney <dominicc@chromium.org>
  730. Reviewed by Kent Tamura.
  731. Cloned range input sliders should be SliderThumbElements, not divs.
  732. https://bugs.webkit.org/show_bug.cgi?id=61982
  733. Test: fast/html/clone-range.html
  734. * html/shadow/SliderThumbElement.h:
  735. (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
  736. 2011-06-02 Yury Semikhatsky <yurys@chromium.org>
  737. Reviewed by Pavel Feldman.
  738. Web Inspector: add an option for automatically attaching to new workers
  739. https://bugs.webkit.org/show_bug.cgi?id=61930
  740. Worker list is extended with a checkbox that makes inspector attach to each
  741. new worker. Whenever a new worker context starts a new inspector window will
  742. be opened for it.
  743. Also worker agent and worker list will be updated when worker context is terminated.
  744. * inspector/Inspector.json:
  745. * inspector/InspectorController.cpp:
  746. (WebCore::InspectorController::InspectorController):
  747. * inspector/InspectorInstrumentation.cpp:
  748. (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
  749. * inspector/InspectorInstrumentation.h:
  750. (WebCore::InspectorInstrumentation::workerContextTerminated):
  751. * inspector/InspectorWorkerAgent.cpp:
  752. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
  753. (WebCore::InspectorWorkerAgent::create):
  754. (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
  755. (WebCore::InspectorWorkerAgent::clearFrontend):
  756. (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
  757. (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  758. (WebCore::InspectorWorkerAgent::workerContextTerminated):
  759. * inspector/InspectorWorkerAgent.h:
  760. * inspector/front-end/WorkerManager.js:
  761. (WebInspector.WorkerManager.prototype._workerCreated):
  762. (WebInspector.WorkerManager.prototype._workerTerminated):
  763. (WebInspector.WorkerManager.prototype.openWorkerInspector):
  764. (WebInspector.WorkerManager.prototype._openInspectorWindow):
  765. (WebInspector.WorkerManager.prototype.reset):
  766. (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
  767. (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
  768. * inspector/front-end/WorkersSidebarPane.js:
  769. (WebInspector.WorkerListSidebarPane):
  770. (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
  771. (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
  772. (WebInspector.WorkerListSidebarPane.prototype._workersCleared):
  773. (WebInspector.WorkerListSidebarPane.prototype._addWorker):
  774. (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
  775. (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
  776. * inspector/front-end/inspector.js:
  777. (WebInspector.reset):
  778. 2011-06-02 Hayato Ito <hayato@chromium.org>
  779. Reviewed by Ryosuke Niwa.
  780. Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
  781. https://bugs.webkit.org/show_bug.cgi?id=61992
  782. It's better to show a shadow root node itself for debugging.
  783. Skipping it didn't add any values.
  784. No new tests since the function is only available in debug builds.
  785. * dom/Node.cpp:
  786. (WebCore::traverseNextNodeAcrossFrame):
  787. 2011-06-02 James Robinson <jamesr@chromium.org>
  788. Unreviewed, rolling out r87901.
  789. http://trac.webkit.org/changeset/87901
  790. https://bugs.webkit.org/show_bug.cgi?id=61894
  791. Might be responsible for performance regression on Chromium page cyclers, reverting to see...
  792. * loader/DocumentLoader.h:
  793. (WebCore::DocumentLoader::didTellClientAboutLoad):
  794. (WebCore::DocumentLoader::haveToldClientAboutLoad):
  795. * loader/FrameLoader.cpp:
  796. (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  797. * loader/ResourceLoadNotifier.cpp:
  798. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
  799. 2011-06-02 Levi Weintraub <leviw@chromium.org>
  800. Reviewed by Eric Seidel.
  801. Switch paintReplaced to use IntPoint
  802. https://bugs.webkit.org/show_bug.cgi?id=61891
  803. Switching paintReplaced to use IntPoint to represent the paint offset instead
  804. of a pair of ints.
  805. Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
  806. fact that the IntPoint is added as an offset as opposed to being relocated
  807. to that point.
  808. No tests because this is just a refactoring.
  809. * page/FrameView.cpp:
  810. (WebCore::FrameView::invalidateScrollbarRect):
  811. (WebCore::FrameView::convertFromRenderer):
  812. (WebCore::FrameView::convertToRenderer):
  813. * platform/ScrollView.cpp:
  814. (WebCore::ScrollView::wheelEvent):
  815. * platform/ScrollbarThemeComposite.cpp:
  816. (WebCore::ScrollbarThemeComposite::invalidatePart):
  817. * platform/graphics/gpu/Texture.cpp
  818. (WebCore::Texture::updateSubRect)
  819. * platform/graphics/IntRect.h:
  820. (WebCore::IntRect::moveBy):
  821. * platform/mac/WidgetMac.mm:
  822. (WebCore::Widget::paint):
  823. * rendering/InlineFlowBox.cpp:
  824. (WebCore::InlineFlowBox::paint):
  825. * rendering/RenderBlock.cpp:
  826. (WebCore::RenderBlock::logicalRectToPhysicalRect):
  827. (WebCore::RenderBlock::selectionGaps):
  828. * rendering/RenderBox.cpp:
  829. (WebCore::RenderBox::offsetFromContainer):
  830. (WebCore::RenderBox::computeRectForRepaint):
  831. (WebCore::RenderBox::localCaretRect):
  832. * rendering/RenderDetailsMarker.cpp:
  833. (WebCore::RenderDetailsMarker::paint):
  834. * rendering/RenderEmbeddedObject.cpp:
  835. (WebCore::RenderEmbeddedObject::paintReplaced):
  836. * rendering/RenderEmbeddedObject.h:
  837. * rendering/RenderHTMLCanvas.cpp:
  838. (WebCore::RenderHTMLCanvas::paintReplaced):
  839. * rendering/RenderHTMLCanvas.h:
  840. * rendering/RenderImage.cpp:
  841. (WebCore::RenderImage::paintReplaced):
  842. * rendering/RenderImage.h:
  843. * rendering/RenderInline.cpp:
  844. (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
  845. * rendering/RenderLayer.cpp:
  846. (WebCore::expandClipRectForDescendantsAndReflection):
  847. (WebCore::RenderLayer::paintScrollCorner):
  848. (WebCore::RenderLayer::paintResizer):
  849. (WebCore::RenderLayer::paintChildLayerIntoColumns):
  850. (WebCore::RenderLayer::hitTestChildLayerColumns):
  851. (WebCore::RenderLayer::boundingBox):
  852. (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  853. * rendering/RenderLayerBacking.cpp:
  854. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  855. (WebCore::paintScrollbar):
  856. (WebCore::RenderLayerBacking::paintContents):
  857. * rendering/RenderLayerCompositor.cpp:
  858. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  859. (WebCore::RenderLayerCompositor::layerWillBeRemoved):
  860. (WebCore::paintScrollbar):
  861. (WebCore::RenderLayerCompositor::paintContents):
  862. * rendering/RenderListBox.cpp:
  863. (WebCore::RenderListBox::controlClipRect):
  864. * rendering/RenderListItem.cpp:
  865. (WebCore::RenderListItem::positionListMarker):
  866. * rendering/RenderListMarker.cpp:
  867. (WebCore::RenderListMarker::paint):
  868. * rendering/RenderReplaced.cpp:
  869. (WebCore::RenderReplaced::paint):
  870. * rendering/RenderReplaced.h:
  871. (WebCore::RenderReplaced::paintReplaced):
  872. * rendering/RenderTableCell.cpp:
  873. (WebCore::RenderTableCell::computeRectForRepaint):
  874. * rendering/RenderTextControlSingleLine.cpp:
  875. (WebCore::RenderTextControlSingleLine::controlClipRect):
  876. * rendering/RenderVideo.cpp:
  877. (WebCore::RenderVideo::paintReplaced):
  878. * rendering/RenderVideo.h:
  879. * rendering/RenderView.cpp:
  880. (WebCore::RenderView::repaintViewRectangle):
  881. 2011-06-02 James Robinson <jamesr@chromium.org>
  882. Reviewed by Dimitri Glazkov.
  883. [chromium][V8] Add trace events for timer fires and event listener dispatches
  884. https://bugs.webkit.org/show_bug.cgi?id=61977
  885. Adds TRACE_EVENT macro around timer and event listener dispatches. When tracing (a chromium feature) is
  886. enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
  887. is traced. When tracing is disabled, this macro does nothing useful. Trace points are very cheap when tracing
  888. is disabled so this should have no performance impact for non-developers.
  889. * bindings/v8/ScheduledAction.cpp:
  890. (WebCore::ScheduledAction::execute):
  891. * bindings/v8/V8EventListener.cpp:
  892. (WebCore::V8EventListener::callListenerFunction):
  893. 2011-06-02 John Bates <jbates@google.com>
  894. Reviewed by James Robinson.
  895. DrawingBufferChromium cleanup:
  896. - Correct FIXME comment about synchronization.
  897. - Remove unnecessary DrawingBufferInternal indirection struct
  898. and its unused offscreenColorTexture member.
  899. https://bugs.webkit.org/show_bug.cgi?id=61953
  900. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  901. (WebCore::DrawingBuffer::DrawingBuffer):
  902. (WebCore::DrawingBuffer::~DrawingBuffer):
  903. (WebCore::DrawingBuffer::publishToPlatformLayer):
  904. (WebCore::DrawingBuffer::didReset):
  905. (WebCore::DrawingBuffer::platformLayer):
  906. * platform/graphics/gpu/DrawingBuffer.h:
  907. 2011-06-02 Andrey Kosyakov <caseq@chromium.org>
  908. Reviewed by Pavel Feldman.
  909. Web Inspector: ResourceCookiesView.resize() is missing
  910. https://bugs.webkit.org/show_bug.cgi?id=61868
  911. * inspector/front-end/ResourceCookiesView.js:
  912. (WebInspector.ResourceCookiesView.prototype.resize):
  913. 2011-06-02 Kent Tamura <tkent@chromium.org>
  914. Reviewed by Dimitri Glazkov.
  915. REGRESSION(r87014): Cloned text <input> doesn't work well.
  916. https://bugs.webkit.org/show_bug.cgi?id=61909
  917. The default implementation of Element::cloneNode() creates a clone
  918. node by Document::createElement(). So, if a customized class is used for
  919. shadow nodes, cloneNode() doesn't create a node of the correct class.
  920. Such custom classes need to override Element::
  921. cloneElementWithoutAttributesAndChildren().
  922. TextFieldInputType and SearchInputType had references to shadow nodes
  923. initialized in createShadowSubtree(). However createShadowSubtree() is
  924. not called if the host node is cloned. The accessors for shadow nodes
  925. should search a shadow tree.
  926. Test: fast/forms/textfield-clone.html
  927. * html/SearchInputType.cpp:
  928. Remove data members for shadow nodes, and the accessors search the
  929. shadow tree for the requested node by TreeScope::getElementById().
  930. (WebCore::SearchInputType::SearchInputType):
  931. (WebCore::innerBlockId):
  932. (WebCore::resultButtonId):
  933. (WebCore::cancelButtonId):
  934. (WebCore::SearchInputType::createShadowSubtree):
  935. (WebCore::SearchInputType::innerBlockElement):
  936. (WebCore::SearchInputType::resultsButtonElement):
  937. (WebCore::SearchInputType::cancelButtonElement):
  938. * html/SearchInputType.h:
  939. * html/TextFieldInputType.cpp: ditto.
  940. (WebCore::TextFieldInputType::TextFieldInputType):
  941. (WebCore::TextFieldInputType::innerTextId):
  942. (WebCore::spinButtonId):
  943. (WebCore::TextFieldInputType::speechButtonId):
  944. (WebCore::TextFieldInputType::appendChildAndSetId):
  945. (WebCore::TextFieldInputType::createShadowSubtree):
  946. (WebCore::TextFieldInputType::getShadowElementById):
  947. (WebCore::TextFieldInputType::innerTextElement):
  948. (WebCore::TextFieldInputType::innerSpinButtonElement):
  949. (WebCore::TextFieldInputType::speechButtonElement):
  950. * html/TextFieldInputType.h:
  951. * html/shadow/TextControlInnerElements.cpp:
  952. Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode()
  953. produces an instance of the correct class.
  954. (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren):
  955. (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren):
  956. (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren):
  957. (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren):
  958. (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren):
  959. (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
  960. * html/shadow/TextControlInnerElements.h:
  961. 2011-05-28 Martin Robinson <mrobinson@igalia.com>
  962. Reviewed by Gustavo Noronha Silva.
  963. [GTK] Remove PasteboardHelperGtk
  964. https://bugs.webkit.org/show_bug.cgi?id=61690
  965. Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
  966. can be removed. Since the GtkClipboard IDs are verified to be the same between
  967. WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
  968. get them.
  969. No new tests. This is just a code refactor.
  970. * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
  971. * platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the
  972. PasteboardHelper singleton directly.
  973. * platform/gtk/ClipboardGtk.h: Ditto.
  974. * platform/gtk/PasteboardGtk.cpp: Ditto.
  975. * platform/gtk/PasteboardHelper.cpp:
  976. (WebCore::removeMarkupPrefix): Remove an extra line.
  977. (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter
  978. for the singleton.
  979. (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here.
  980. (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine
  981. whether or not to use the primary selection clipboard, just use our new member.
  982. (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID.
  983. (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
  984. (WebCore::PasteboardHelper::dropAtomsForContext): Ditto.
  985. (WebCore::getClipboardContentsCallback): Ditto.
  986. * platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or
  987. not to use the primary selection clipboard internally.
  988. (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added.
  989. (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.
  990. 2011-06-02 Levi Weintraub <leviw@chromium.org>
  991. Reviewed by Eric Seidel.
  992. Teach InlineBox about FloatPoint
  993. https://bugs.webkit.org/show_bug.cgi?id=44412
  994. Original patch by Eric Seidel. Updated by me.
  995. This is another step towards more point/size
  996. usage throughout the rendering tree.
  997. Added left(), right(), top(), and bottom() methods
  998. to InlineBox. Removed m_x, and m_y and replaced them
  999. with a single m_topLeft member.
  1000. No new tests since this is just a refactoring.
  1001. * rendering/EllipsisBox.cpp:
  1002. (WebCore::EllipsisBox::paint):
  1003. (WebCore::EllipsisBox::selectionRect):
  1004. (WebCore::EllipsisBox::paintSelection):
  1005. (WebCore::EllipsisBox::nodeAtPoint):
  1006. * rendering/EllipsisBox.h:
  1007. (WebCore::EllipsisBox::EllipsisBox):
  1008. * rendering/InlineBox.cpp:
  1009. (WebCore::InlineBox::adjustPosition):
  1010. (WebCore::InlineBox::canAccommodateEllipsis):
  1011. * rendering/InlineBox.h:
  1012. (WebCore::InlineBox::InlineBox):
  1013. (WebCore::InlineBox::setX):
  1014. (WebCore::InlineBox::x):
  1015. (WebCore::InlineBox::left):
  1016. (WebCore::InlineBox::setY):
  1017. (WebCore::InlineBox::y):
  1018. (WebCore::InlineBox::top):
  1019. (WebCore::InlineBox::topLeft):
  1020. (WebCore::InlineBox::right):
  1021. (WebCore::InlineBox::bottom):
  1022. (WebCore::InlineBox::logicalLeft):
  1023. (WebCore::InlineBox::setLogicalLeft):
  1024. (WebCore::InlineBox::logicalTop):
  1025. (WebCore::InlineBox::setLogicalTop):
  1026. (WebCore::InlineBox::logicalFrameRect):
  1027. * rendering/InlineFlowBox.h:
  1028. (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
  1029. * rendering/InlineTextBox.cpp:
  1030. (WebCore::InlineTextBox::placeEllipsisBox):
  1031. (WebCore::InlineTextBox::paintTextMatchMarker):
  1032. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  1033. * rendering/RenderText.cpp:
  1034. (WebCore::RenderText::firstRunX):
  1035. (WebCore::RenderText::firstRunY):
  1036. * rendering/RenderTreeAsText.cpp:
  1037. (WebCore::writeTextRun):
  1038. * rendering/RootInlineBox.cpp:
  1039. (WebCore::RootInlineBox::placeEllipsis):
  1040. * rendering/svg/RenderSVGText.cpp:
  1041. (WebCore::RenderSVGText::positionForPoint):
  1042. * rendering/svg/SVGInlineTextBox.h:
  1043. (WebCore::SVGInlineTextBox::selectionTop):
  1044. * rendering/svg/SVGRootInlineBox.cpp:
  1045. (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
  1046. 2011-06-02 Jian Li <jianli@chromium.org>
  1047. Reviewed by David Levin.
  1048. Update the behavior of multiple reads for FileReader
  1049. https://bugs.webkit.org/show_bug.cgi?id=61793
  1050. Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
  1051. status code on any of the read methods that occur when readyState = LOADING.
  1052. Otherwise, calling any of the read methods should work.
  1053. Test: fast/files/read-file-async.html
  1054. * CodeGenerators.pri:
  1055. * DerivedSources.cpp:
  1056. * DerivedSources.make:
  1057. * GNUmakefile.list.am:
  1058. * WebCore.gypi:
  1059. * WebCore.pro:
  1060. * WebCore.vcproj/WebCore.vcproj:
  1061. * WebCore.xcodeproj/project.pbxproj:
  1062. * bindings/js/JSDOMBinding.cpp:
  1063. (WebCore::setDOMException):
  1064. * bindings/v8/V8Proxy.cpp:
  1065. (WebCore::V8Proxy::setDOMException):
  1066. * dom/ExceptionCode.cpp:
  1067. (WebCore::getExceptionCodeDescription):
  1068. * dom/ExceptionCode.h:
  1069. * fileapi/FileReader.cpp:
  1070. (WebCore::FileReader::FileReader):
  1071. (WebCore::FileReader::hasPendingActivity):
  1072. (WebCore::FileReader::readAsArrayBuffer):
  1073. (WebCore::FileReader::readAsBinaryString):
  1074. (WebCore::FileReader::readAsText):
  1075. (WebCore::FileReader::readAsDataURL):
  1076. (WebCore::FileReader::readInternal):
  1077. (WebCore::FileReader::abort):
  1078. (WebCore::FileReader::doAbort):
  1079. (WebCore::FileReader::terminate):
  1080. (WebCore::FileReader::start):
  1081. (WebCore::FileReader::didStartLoading):
  1082. (WebCore::FileReader::didFinishLoading):
  1083. (WebCore::FileReader::didFail):
  1084. * fileapi/FileReader.h:
  1085. (WebCore::FileReader::readyState):
  1086. * fileapi/FileReader.idl:
  1087. * fileapi/OperationNotAllowedException.h: Added.
  1088. (WebCore::OperationNotAllowedException::create):
  1089. (WebCore::OperationNotAllowedException::OperationNotAllowedException):
  1090. * fileapi/OperationNotAllowedException.idl: Added.
  1091. 2011-06-02 Adrienne Walker <enne@google.com>
  1092. Reviewed by James Robinson.
  1093. [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
  1094. https://bugs.webkit.org/show_bug.cgi?id=61954
  1095. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  1096. (WebCore::CCHeadsUpDisplay::draw):
  1097. 2011-06-02 Brady Eidson <beidson@apple.com>
  1098. Reviewed by Oliver Hunt.
  1099. <rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
  1100. Repro crash loading certain webarchives after r87566.
  1101. Test: webarchive/loading/javascript-url-iframe-crash.html
  1102. * bindings/ScriptControllerBase.cpp:
  1103. (WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
  1104. cause the DocumentLoader to be destroyed, so protect it with a Ref here.
  1105. 2011-06-02 Jay Civelli <jcivelli@chromium.org>
  1106. Reviewed by Adam Barth.
  1107. Adding MHTML generation support to MHTMLArchive.
  1108. https://bugs.webkit.org/show_bug.cgi?id=7169
  1109. * loader/archive/mhtml/MHTMLArchive.cpp:
  1110. (WebCore::generateRandomBoundary):
  1111. (WebCore::replaceNonPrintableCharacters):
  1112. (WebCore::MHTMLArchive::generateMHTMLData):
  1113. * loader/archive/mhtml/MHTMLArchive.h:
  1114. * page/PageSerializer.cpp:
  1115. (WebCore::PageSerializer::serializeFrame):
  1116. (WebCore::PageSerializer::serializeCSSStyleSheet):
  1117. * platform/SharedBuffer.cpp:
  1118. (WebCore::SharedBuffer::append):
  1119. * platform/SharedBuffer.h:
  1120. 2011-06-02 Simon Fraser <simon.fraser@apple.com>
  1121. Reviewed by Andreas Kling.
  1122. Share Path code that uses beziers to construct a rounded rect
  1123. https://bugs.webkit.org/show_bug.cgi?id=61960
  1124. Have two methods in Path that construct beziers for rounded
  1125. rects to share the same code.
  1126. Make gCircleControlPoint a little more precise, and add
  1127. a comment describing its derivation.
  1128. Make use of FloatRect::maxX() and maxY().
  1129. * platform/graphics/Path.cpp:
  1130. (WebCore::Path::addRoundedRect):
  1131. (WebCore::Path::addBeziersForRoundedRect):
  1132. * platform/graphics/Path.h:
  1133. 2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
  1134. Reviewed by Enrica Casucci.
  1135. ApplyStyleCommand shouldn't call collapseTextDecorationProperties
  1136. https://bugs.webkit.org/show_bug.cgi?id=61887
  1137. Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.
  1138. No new tests because this is a code refactoring.
  1139. * editing/ApplyStyleCommand.cpp:
  1140. (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties.
  1141. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
  1142. * editing/EditingStyle.cpp:
  1143. (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration
  1144. and -webkit-text-decorations-in-effect.
  1145. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment.
  1146. (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration
  1147. and -webkit-text-decorations-in-effect.
  1148. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration
  1149. is present in -webkit-text-decorations-in-effect or text-decoration preferring the former.
  1150. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties
  1151. is false and true. Added a support for -webkit-text-decorations-in-effect.
  1152. 2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
  1153. Reviewed by Eric Seidel.
  1154. Make more functions static local in EventHandlers.cpp
  1155. https://bugs.webkit.org/show_bug.cgi?id=58503
  1156. Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.
  1157. * page/EventHandler.cpp:
  1158. (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget.
  1159. (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget.
  1160. (WebCore::EventHandler::cancelDragAndDrop): Ditto.
  1161. (WebCore::EventHandler::performDragAndDrop): Ditto.
  1162. (WebCore::focusDirectionForKey): No longer a member function of EventHandler class.
  1163. (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls
  1164. focusDirectionForKey instead of manually comparing.
  1165. * page/EventHandler.h:
  1166. 2011-06-02 Alok Priyadarshi <alokp@chromium.org>
  1167. Reviewed by James Robinson.
  1168. [chromium] Things jump around when selecting anything on the page
  1169. https://bugs.webkit.org/show_bug.cgi?id=61639
  1170. WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
  1171. It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
  1172. Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
  1173. An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
  1174. with the viewport set by skia.
  1175. No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
  1176. Here is a non-exhaustive list of existing tests covering this case.
  1177. Test: editing/selection/14971.html (existing)
  1178. editing/selection/3690703-2.html (existing)
  1179. editing/selection/4402375.html (existing)
  1180. editing/selection/4818145.html (existing)
  1181. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
  1182. (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
  1183. (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  1184. * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  1185. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  1186. Reviewed by Darin Adler.
  1187. Add build logistics and plumbing for window.internals object.
  1188. https://bugs.webkit.org/show_bug.cgi?id=60313
  1189. Test: fast/harness/internals-object.html
  1190. * Configurations/WebCoreTestSupport.xcconfig: Added.
  1191. * DerivedSources.make: Added support for generating from Internals.idl.
  1192. * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  1193. * WebCore.gypi: Ditto.
  1194. * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  1195. * testing/Internals.cpp: Added.
  1196. * testing/Internals.h: Added.
  1197. * testing/Internals.idl: Added.
  1198. * testing/js/WebCoreTestSupport.cpp: Added.
  1199. * testing/js/WebCoreTestSupport.h: Added.
  1200. * testing/v8/WebCoreTestSupport.cpp: Added.
  1201. * testing/v8/WebCoreTestSupport.h: Added.
  1202. 2011-06-01 Adrienne Walker <enne@google.com>
  1203. Reviewed by Eric Seidel.
  1204. [chromium] LayerChromium should use a RefPtr for replica layer
  1205. https://bugs.webkit.org/show_bug.cgi?id=61898
  1206. Having this member variable be a raw pointer is brittle and assumes
  1207. that the GraphicsLayer tree keeps this in sync. There aren't any
  1208. known bugs caused by this, but it seems like good sense to do this.
  1209. * platform/graphics/chromium/LayerChromium.h:
  1210. (WebCore::LayerChromium::replicaLayer):
  1211. 2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
  1212. Reviewed by Eric Seidel.
  1213. REGRESSION: inline style is lost when deleting line break between paragraphs with same style
  1214. https://bugs.webkit.org/show_bug.cgi?id=61899
  1215. The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
  1216. before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
  1217. Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
  1218. Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
  1219. * editing/ReplaceSelectionCommand.cpp:
  1220. (WebCore::ReplaceSelectionCommand::doApply):
  1221. 2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
  1222. Reviewed by Simon Fraser.
  1223. REGRESSION: Text selection broken for text with line-height applied
  1224. https://bugs.webkit.org/show_bug.cgi?id=54929
  1225. The bug was caused by RenderText::positionForPoint's not considering the case where a point is
  1226. above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
  1227. any point between selectionTop and lineTop to be inside a root inline box. This condition is
  1228. consistent with the condition we use to determine the bottom of a line.
  1229. Test: editing/selection/hit-test-on-text-with-line-height.html
  1230. * rendering/RenderBlock.cpp:
  1231. (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
  1232. or not a point is above the first root line box. We need to check both selectionTop and logicalTop
  1233. for the same reason explained above.
  1234. * rendering/RenderText.cpp:
  1235. (WebCore::RenderText::positionForPoint): See above.
  1236. 2011-06-02 Andreas Kling <kling@webkit.org>
  1237. Reviewed by James Robinson.
  1238. Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
  1239. https://bugs.webkit.org/show_bug.cgi?id=61944
  1240. Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
  1241. for string styles. This ensures that system color resolution is performed,
  1242. and matches what the JSC bindings do.
  1243. Test: canvas/philip/tests/2d.fillStyle.parse.system.html
  1244. * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  1245. (WebCore::toCanvasStyle):
  1246. (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
  1247. (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
  1248. 2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
  1249. Unreviewed, rolling out r87920.
  1250. http://trac.webkit.org/changeset/87920
  1251. https://bugs.webkit.org/show_bug.cgi?id=61943
  1252. This patch does not build in Win Builder (dbg)(shared)
  1253. downstream (Requested by abarth|gardener on #webkit).
  1254. * platform/chromium/PopupMenuChromium.cpp:
  1255. (WebCore::PopupContainer::showPopup):
  1256. (WebCore::PopupListBox::handleMouseReleaseEvent):
  1257. (WebCore::PopupListBox::acceptIndex):
  1258. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  1259. Unreviewed, rolling out r87926.
  1260. http://trac.webkit.org/changeset/87926
  1261. https://bugs.webkit.org/show_bug.cgi?id=60313
  1262. Fails to find WebCoreTestSupport.dylib on bots.
  1263. * Configurations/WebCore.xcconfig:
  1264. * Configurations/WebCoreTestSupport.xcconfig: Removed.
  1265. * DerivedSources.make:
  1266. * WebCore.exp.in:
  1267. * WebCore.gyp/WebCore.gyp:
  1268. * WebCore.gypi:
  1269. * WebCore.xcodeproj/project.pbxproj:
  1270. * bindings/js/JSDOMWrapper.cpp:
  1271. (WebCore::JSDOMWrapper::~JSDOMWrapper):
  1272. * bindings/js/JSDOMWrapper.h:
  1273. * testing/Internals.cpp: Removed.
  1274. * testing/Internals.h: Removed.
  1275. * testing/Internals.idl: Removed.
  1276. * testing/js/WebCoreTestSupport.cpp: Removed.
  1277. * testing/js/WebCoreTestSupport.h: Removed.
  1278. * testing/v8/WebCoreTestSupport.cpp: Removed.
  1279. * testing/v8/WebCoreTestSupport.h: Removed.
  1280. 2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>
  1281. Reviewed by Martin Robinson.
  1282. [GTK] Implement popup menus in Webkit2
  1283. https://bugs.webkit.org/show_bug.cgi?id=61854
  1284. Move common code into a new class to be used by both WebKit1 and
  1285. WebKit2.
  1286. * GNUmakefile.list.am: Add new files to compilation.
  1287. * platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp.
  1288. (WebCore::GtkPopupMenu::GtkPopupMenu):
  1289. (WebCore::GtkPopupMenu::~GtkPopupMenu):
  1290. (WebCore::GtkPopupMenu::clear): Remove all menu items.
  1291. (WebCore::GtkPopupMenu::appendSeparator): Add a new separator
  1292. item to the menu.
  1293. (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for
  1294. the given action.
  1295. (WebCore::GtkPopupMenu::popUp): Show the menu.
  1296. (WebCore::GtkPopupMenu::popDown): Hide the menu.
  1297. (WebCore::GtkPopupMenu::menuRemoveItem):
  1298. (WebCore::GtkPopupMenu::menuPositionFunction):
  1299. (WebCore::GtkPopupMenu::resetTypeAheadFindState):
  1300. (WebCore::GtkPopupMenu::typeAheadFind):
  1301. (WebCore::GtkPopupMenu::selectItemCallback):
  1302. (WebCore::GtkPopupMenu::keyPressEventCallback):
  1303. * platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h.
  1304. (WebCore::GtkPopupMenu::create):
  1305. (WebCore::GtkPopupMenu::platformMenu):
  1306. * platform/gtk/PopupMenuGtk.cpp:
  1307. (WebCore::PopupMenuGtk::PopupMenuGtk):
  1308. (WebCore::PopupMenuGtk::~PopupMenuGtk):
  1309. (WebCore::PopupMenuGtk::show): Use GtkPopupMenu.
  1310. (WebCore::PopupMenuGtk::hide): Ditto.
  1311. (WebCore::PopupMenuGtk::menuItemActivated):
  1312. (WebCore::PopupMenuGtk::menuUnmapped):
  1313. * platform/gtk/PopupMenuGtk.h:
  1314. 2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
  1315. Reviewed by Darin Adler.
  1316. Add build logistics and plumbing for window.internals object.
  1317. https://bugs.webkit.org/show_bug.cgi?id=60313
  1318. Test: fast/harness/internals-object.html
  1319. * Configurations/WebCoreTestSupport.xcconfig: Added.
  1320. * DerivedSources.make: Added support for generating from Internals.idl.
  1321. * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  1322. * WebCore.gypi: Ditto.
  1323. * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  1324. * testing/Internals.cpp: Added.
  1325. * testing/Internals.h: Added.
  1326. * testing/Internals.idl: Added.
  1327. * testing/js/WebCoreTestSupport.cpp: Added.
  1328. * testing/js/WebCoreTestSupport.h: Added.
  1329. * testing/v8/WebCoreTestSupport.cpp: Added.
  1330. * testing/v8/WebCoreTestSupport.h: Added.
  1331. 2011-06-02 Naoki Takano <takano.naoki@gmail.com>
  1332. Reviewed by Dimitri Glazkov.
  1333. [Chromium] Click event is not fired for a menulist <select>
  1334. https://bugs.webkit.org/show_bug.cgi?id=60563
  1335. Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
  1336. * platform/chromium/PopupMenuChromium.cpp:
  1337. (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
  1338. (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
  1339. (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
  1340. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  1341. Reviewed by Darin Adler.
  1342. Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
  1343. https://bugs.webkit.org/show_bug.cgi?id=61892
  1344. In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
  1345. a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.
  1346. * dom/EventDispatcher.cpp:
  1347. (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
  1348. 2011-06-02 Hans Wennborg <hans@chromium.org>
  1349. Reviewed by Tony Gentilcore.
  1350. Fix LevelDBTransaction::clearTree()
  1351. https://bugs.webkit.org/show_bug.cgi?id=61917
  1352. This was broken in the code I copied it from; we can't delete and walk
  1353. the tree at the same time.
  1354. No new functionality, no new tests.
  1355. * platform/leveldb/LevelDBTransaction.cpp:
  1356. (WebCore::LevelDBTransaction::clearTree):
  1357. 2011-06-02 Andreas Kling <kling@webkit.org>
  1358. Rubber-stamped by Simon Hausmann.
  1359. Remove Qt's precompiled header hack as it was broken, and was not even
  1360. used unless building WebKit inside a Qt tree.
  1361. * WebCore.pri:
  1362. 2011-06-02 James Robinson <jamesr@chromium.org>
  1363. Reviewed by Brady Eidson.
  1364. DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
  1365. https://bugs.webkit.org/show_bug.cgi?id=61894
  1366. DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
  1367. FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
  1368. whether to inform the FrameLoader's m_client about this load. Unfortunately, this set holds a reference to the
  1369. URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
  1370. lots of memory.
  1371. This set only has an effect on the Mac port, as the only two ports that implement
  1372. FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
  1373. can correctly handle receiving multiple callbacks. This patch limits the set to only PLATFORM(MAC) so other
  1374. ports do not have to pay this memory cost. It's possible that a better fix exists specifically for the Mac port
  1375. implementation, but that would have to determined by someone who works on that port specifically.
  1376. * loader/DocumentLoader.h:
  1377. (WebCore::DocumentLoader::didTellClientAboutLoad):
  1378. (WebCore::DocumentLoader::haveToldClientAboutLoad):
  1379. 2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>
  1380. Reviewed by Andreas Kling.
  1381. [Qt] Multiple drop events when doing DnD of images.
  1382. https://bugs.webkit.org/show_bug.cgi?id=61504
  1383. Duplicate entries of the url were getting added into drag data
  1384. which is removed. The duplicate entries were causing the same image
  1385. url to be copied twice. The code changes now match other webkit ports.
  1386. * platform/qt/ClipboardQt.cpp:
  1387. (WebCore::ClipboardQt::declareAndWriteDragImage):
  1388. 2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>
  1389. Reviewed by Kent Tamura.
  1390. Fixing invalid value being returned for default checkbox and radio state
  1391. https://bugs.webkit.org/show_bug.cgi?id=61674
  1392. As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
  1393. http://www.w3.org/TR/html5/number-state.html#radio-button-state:
  1394. The value IDL attribute is in mode default/on:
  1395. If the element has a value attribute, it must return that attribute's
  1396. value; otherwise, it must return the string "on".
  1397. Currently default value is empty string;Default value of Radio button
  1398. and checkbox should be "on".Changed fallbackValue function to return the same
  1399. This works as per spec in IE9,Firefox and Opera
  1400. Tests: fast/forms/checkbox-default-value.html
  1401. fast/forms/radio-default-value.html
  1402. * html/BaseCheckableInputType.cpp:
  1403. (WebCore::BaseCheckableInputType::fallbackValue):
  1404. 2011-06-02 Kent Tamura <tkent@chromium.org>
  1405. [Chromium/Mac] Fix a wrong merge for r87881
  1406. https://bugs.webkit.org/show_bug.cgi?id=61845
  1407. * platform/chromium/ThemeChromiumMac.mm:
  1408. (WebCore::paintStepper):
  1409. 2011-06-02 Ian Henderson <ianh@apple.com>
  1410. Reviewed by Simon Fraser.
  1411. [CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
  1412. https://bugs.webkit.org/show_bug.cgi?id=61882
  1413. If we have a gradient or pattern fill set, take the slow path, which
  1414. handles these cases properly.
  1415. No new tests, since we never try to fill a rounded rect with a
  1416. gradient or pattern.
  1417. * platform/graphics/cg/GraphicsContextCG.cpp:
  1418. (WebCore::GraphicsContext::fillRoundedRect):
  1419. 2011-06-02 MORITA Hajime <morrita@google.com>
  1420. Reviewed by Kent Tamura.
  1421. [Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
  1422. https://bugs.webkit.org/show_bug.cgi?id=61912
  1423. Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
  1424. removed original definitions.
  1425. No test, no behavioral change.
  1426. * dom/Node.cpp:
  1427. * dom/Node.h:
  1428. * dom/NodeRenderingContext.cpp:
  1429. (WebCore::NodeRenderingContext::nextRenderer):
  1430. (WebCore::NodeRenderingContext::previousRenderer):
  1431. 2011-06-02 Piroska András <Piroska.Andras@stud.u-szeged.hu>
  1432. Rubber-stamped by Gabor Loki.
  1433. Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.
  1434. * platform/graphics/filters/FEConvolveMatrix.cpp:
  1435. (WebCore::FEConvolveMatrix::apply): Rename variable i to job
  1436. 2011-06-02 Yuta Kitamura <yutak@chromium.org>
  1437. Reviewed by Kent Tamura.
  1438. WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
  1439. https://bugs.webkit.org/show_bug.cgi?id=61841
  1440. There is no change in behavior except that capitalization of a few error messages
  1441. has been changed. No new tests are added.
  1442. * websockets/WebSocketChannel.cpp:
  1443. (WebCore::WebSocketChannel::processBuffer):
  1444. Pass m_handshake.failureReason() to fail() if the handshake has failed.
  1445. * websockets/WebSocketHandshake.cpp:
  1446. Replace occurrences of m_handle->addMessage() with assignments to m_failureReason.
  1447. Change capitalization of a few messages so that all messages start with a capital letter.
  1448. (WebCore::WebSocketHandshake::readServerHandshake):
  1449. (WebCore::WebSocketHandshake::failureReason):
  1450. (WebCore::WebSocketHandshake::readStatusLine):
  1451. (WebCore::WebSocketHandshake::readHTTPHeaders):
  1452. (WebCore::WebSocketHandshake::checkResponseHeaders):
  1453. * websockets/WebSocketHandshake.h:
  1454. Add failureReason(), which returns a string that describes why WebSocket handshake
  1455. has failed.
  1456. 2011-06-01 Dan Bernstein <mitz@apple.com>
  1457. Reviewed by Anders Carlsson.
  1458. Incorrect UA style when printing a simple document
  1459. https://bugs.webkit.org/show_bug.cgi?id=61900
  1460. This is not testable in run-webkit-tests because unless the test is the first to run in an instance
  1461. of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.
  1462. * css/CSSStyleSelector.cpp:
  1463. (WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
  1464. simple default style, with a new RuleSet before adding the style rules from the full default sheet.
  1465. (WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
  1466. equal in the simple case.
  1467. 2011-06-01 Kent Tamura <tkent@chromium.org>
  1468. Reviewed by Dimitri Glazkov.
  1469. Remove outer-spin-button
  1470. https://bugs.webkit.org/show_bug.cgi?id=61845
  1471. Remove outer-spin-button, and render steppers as inner-spin-button.
  1472. Outer-spin-button have never worked well with padding and border of
  1473. <input>, and the layout code is very tricky and very hard to maintain it.
  1474. * css/CSSPrimitiveValueMappings.h:
  1475. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  1476. * css/CSSValueKeywords.in:
  1477. * css/html.css:
  1478. * html/HTMLInputElement.cpp:
  1479. (WebCore::HTMLInputElement::innerSpinButtonElement):
  1480. * html/HTMLInputElement.h:
  1481. * html/InputType.h:
  1482. * html/TextFieldInputType.cpp:
  1483. (WebCore::TextFieldInputType::TextFieldInputType):
  1484. (WebCore::TextFieldInputType::createShadowSubtree):
  1485. (WebCore::TextFieldInputType::destroyShadowSubtree):
  1486. * html/TextFieldInputType.h:
  1487. * html/shadow/TextControlInnerElements.cpp:
  1488. (WebCore::SpinButtonElement::SpinButtonElement):
  1489. (WebCore::SpinButtonElement::create):
  1490. (WebCore::SpinButtonElement::shadowPseudoId):
  1491. * html/shadow/TextControlInnerElements.h:
  1492. * platform/ThemeTypes.h:
  1493. * platform/chromium/ThemeChromiumMac.mm:
  1494. (WebCore::paintStepper):
  1495. Center the stepper drawing area because the specified area can be
  1496. larger than the NSStepper sizes.
  1497. (WebCore::ThemeChromiumMac::controlSize):
  1498. (WebCore::ThemeChromiumMac::minimumControlSize):
  1499. (WebCore::ThemeChromiumMac::inflateControlPaintRect):
  1500. (WebCore::ThemeChromiumMac::paint):
  1501. * platform/mac/ThemeMac.mm:
  1502. (WebCore::paintStepper):
  1503. Center the stepper drawing area because the specified area can be
  1504. larger than the NSStepper sizes.
  1505. (WebCore::ThemeMac::controlSize):
  1506. (WebCore::ThemeMac::minimumControlSize):
  1507. (WebCore::ThemeMac::inflateControlPaintRect):
  1508. (WebCore::ThemeMac::paint):
  1509. * rendering/RenderBox.cpp:
  1510. (WebCore::RenderBox::paintBoxDecorations):
  1511. * rendering/RenderBox.h:
  1512. * rendering/RenderTextControlSingleLine.cpp:
  1513. (WebCore::RenderTextControlSingleLine::layout):
  1514. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  1515. (WebCore::RenderTextControlSingleLine::textBlockWidth):
  1516. * rendering/RenderTextControlSingleLine.h:
  1517. * rendering/RenderTheme.cpp:
  1518. (WebCore::RenderTheme::adjustStyle):
  1519. (WebCore::RenderTheme::paint):
  1520. (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
  1521. * rendering/RenderTheme.h:
  1522. * rendering/RenderThemeMac.mm:
  1523. (WebCore::RenderThemeMac::adjustRepaintRect):
  1524. 2011-06-01 Emil A Eklund <eae@chromium.org>
  1525. Reviewed by Eric Seidel.
  1526. Switch RenderLayer::convertToLayerCoords to use IntPoint
  1527. https://bugs.webkit.org/show_bug.cgi?id=61818
  1528. Covered by existing tests.
  1529. * platform/graphics/FloatPoint.h:
  1530. (WebCore::flooredIntSize):
  1531. * rendering/RenderLayer.cpp:
  1532. (WebCore::RenderLayer::updateLayerPositions):
  1533. (WebCore::expandClipRectForDescendantsAndReflection):
  1534. (WebCore::transparencyClipBox):
  1535. (WebCore::RenderLayer::convertToLayerCoords):
  1536. (WebCore::RenderLayer::paintLayer):
  1537. (WebCore::RenderLayer::paintChildLayerIntoColumns):
  1538. (WebCore::RenderLayer::createLocalTransformState):
  1539. (WebCore::RenderLayer::hitTestChildLayerColumns):
  1540. (WebCore::RenderLayer::calculateClipRects):
  1541. (WebCore::RenderLayer::calculateRects):
  1542. (WebCore::RenderLayer::boundingBox):
  1543. (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  1544. * rendering/RenderLayer.h:
  1545. * rendering/RenderLayerBacking.cpp:
  1546. (WebCore::RenderLayerBacking::updateCompositedBounds):
  1547. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  1548. * rendering/RenderLayerCompositor.cpp:
  1549. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  1550. (WebCore::RenderLayerCompositor::layerWillBeRemoved):
  1551. (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
  1552. 2011-06-01 Roland Steiner <rolandsteiner@chromium.org>
  1553. Reviewed by Kent Tamura.
  1554. Remove superfluous renderer() test
  1555. https://bugs.webkit.org/show_bug.cgi?id=61907
  1556. No new tests. (trivial)
  1557. * dom/Document.cpp:
  1558. (WebCore::Document::recalcStyle):
  1559. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1560. Reviewed by Hajime Morita.
  1561. Add IntPoint + IntPoint operator
  1562. https://bugs.webkit.org/show_bug.cgi?id=61876
  1563. Adding an operator+ convenience method to IntPoint that sums two points
  1564. and returns the result as an IntPoint. Changing doImageDrag to use it
  1565. as a proof of concept.
  1566. No new tests since there is no change in behavior.
  1567. * page/DragController.cpp:
  1568. (WebCore::DragController::doImageDrag):
  1569. * platform/graphics/IntPoint.h:
  1570. (WebCore::operator+):
  1571. 2011-06-01 Jaehun Lim <ljaehun.lim@samsung.com>
  1572. Reviewed by Eric Seidel.
  1573. [EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
  1574. https://bugs.webkit.org/show_bug.cgi?id=61836
  1575. Add functions for rendering drop-down list when style attributes are applied.
  1576. * platform/efl/RenderThemeEfl.cpp:
  1577. (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
  1578. (WebCore::RenderThemeEfl::paintMenuListButton):
  1579. * platform/efl/RenderThemeEfl.h:
  1580. 2011-06-01 Yuta Kitamura <yutak@chromium.org>
  1581. Reviewed by Kent Tamura.
  1582. WebSocket: WebSocketChannel::fail() should close the connection immediately
  1583. https://bugs.webkit.org/show_bug.cgi?id=61851
  1584. The effect of this change is almost unobservable. The difference between m_handle->close() and
  1585. m_handle->disconnect() is that the former does not close the connection if the handle has
  1586. unsent data while the latter immediately closes the connection regardless of unsent data.
  1587. Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
  1588. for user scripts to observe the difference between close() and disconnect() (it should take some time
  1589. for onclose() to be called if there are any unsent data, but there ought to be no other difference
  1590. in user scripts' perspective).
  1591. No new tests are added, because writing a test for this issue is not feasible due to the above reason.
  1592. * websockets/WebSocketChannel.cpp:
  1593. (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
  1594. 2011-06-01 Abhishek Arya <inferno@chromium.org>
  1595. Unreviewed.
  1596. Coding style nit. Move ec=0 initialization, change
  1597. recommended by Alexey in bug.
  1598. https://bugs.webkit.org/show_bug.cgi?id=60831
  1599. * dom/Document.cpp:
  1600. (WebCore::Document::setBody):
  1601. 2011-06-01 Hayato Ito <hayato@chromium.org>
  1602. Reviewed by Kent Tamura.
  1603. Move {Next,Previous}FocusableNode functions from Document to FocusController.
  1604. https://bugs.webkit.org/show_bug.cgi?id=61839
  1605. There are some member functions in Document which use 'this'
  1606. pointer, but we should use TreeScope instead of Document in some
  1607. places to handle focus issues nicely. We have to move these
  1608. functions out of Document class so that we can give the TreeScope
  1609. as a parameter.
  1610. No new tests since no functionality was changed.
  1611. * dom/Document.cpp:
  1612. * dom/Document.h:
  1613. * page/FocusController.cpp:
  1614. (WebCore::FocusController::deepFocusableNode):
  1615. (WebCore::FocusController::advanceFocusInDocumentOrder):
  1616. (WebCore::nextNodeWithExactTabIndex):
  1617. (WebCore::previousNodeWithExactTabIndex):
  1618. (WebCore::nextNodeWithGreaterTabIndex):
  1619. (WebCore::previousNodeWithLowerTabIndex):
  1620. (WebCore::FocusController::nextFocusableNode):
  1621. (WebCore::FocusController::previousFocusableNode):
  1622. * page/FocusController.h:
  1623. 2011-06-01 Adrienne Walker <enne@google.com>
  1624. Reviewed by James Robinson.
  1625. [chromium] Fix syncing of removed mask and replica layers
  1626. https://bugs.webkit.org/show_bug.cgi?id=61895
  1627. * platform/graphics/chromium/TreeSynchronizer.cpp:
  1628. (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
  1629. 2011-06-01 Julien Chaffraix <jchaffraix@codeaurora.org>
  1630. Reviewed by Simon Fraser.
  1631. CSSStyleSheet#insertRule doesn't work well with imported stylesheets
  1632. https://bugs.webkit.org/show_bug.cgi?id=56981
  1633. Test: fast/css/import-and-insert-rule-no-update.html
  1634. The bug arises from the fact that <link> element did not know about a programmatically
  1635. loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
  1636. This is needed to make sure our style selector contains an up-to-date list of stylesheets.
  1637. The gist of the patch adds a way for style sheet owner element to know if we are
  1638. programmatically loading a style sheet. This is needed as <link> keeps the information
  1639. about that last loaded stylesheet.
  1640. * css/CSSImportRule.cpp:
  1641. (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet
  1642. on our parent style sheet instead of directly adding a pending style sheet.
  1643. * css/CSSStyleSheet.cpp:
  1644. (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet
  1645. on our owner element if we have one.
  1646. * css/CSSStyleSheet.h:
  1647. * dom/Node.h:
  1648. (WebCore::Node::startLoadingDynamicSheet): Added common implementation of
  1649. startLoadingDynamicSheet, which should never be called.
  1650. * dom/StyleElement.cpp:
  1651. (WebCore::StyleElement::startLoadingDynamicSheet):
  1652. * dom/StyleElement.h:
  1653. Common implementation of startLoadingDynamicSheet for style elements.
  1654. * html/HTMLLinkElement.cpp:
  1655. (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
  1656. * html/HTMLLinkElement.h:
  1657. Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
  1658. * html/HTMLStyleElement.h:
  1659. (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
  1660. * svg/SVGStyleElement.h:
  1661. (WebCore::SVGStyleElement::startLoadingDynamicSheet):
  1662. Forward the call to StyleElement.
  1663. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1664. Reviewed by Eric Seidel.
  1665. Switch paintCustomHighlight to use IntPoint
  1666. https://bugs.webkit.org/show_bug.cgi?id=61562
  1667. Switching paintCustomHighlight to use an IntPoint for
  1668. its paint offset instead of a pair of ints.
  1669. No new tests since this is refactoring.
  1670. * rendering/InlineTextBox.cpp:
  1671. (WebCore::InlineTextBox::paint):
  1672. (WebCore::InlineTextBox::paintCustomHighlight):
  1673. * rendering/InlineTextBox.h:
  1674. * rendering/RenderBox.cpp:
  1675. (WebCore::RenderBox::paintCustomHighlight):
  1676. * rendering/RenderBox.h:
  1677. * rendering/RenderImage.cpp:
  1678. (WebCore::RenderImage::paintReplaced):
  1679. * rendering/RenderListMarker.cpp:
  1680. (WebCore::RenderListMarker::paint):
  1681. * rendering/RenderWidget.cpp:
  1682. (WebCore::RenderWidget::paint):
  1683. * rendering/RootInlineBox.cpp:
  1684. (WebCore::RootInlineBox::paintCustomHighlight):
  1685. (WebCore::RootInlineBox::paint):
  1686. * rendering/RootInlineBox.h:
  1687. 2011-06-01 Emil A Eklund <eae@chromium.org>
  1688. Reviewed by Eric Seidel.
  1689. Switch MouseRelatedEvent to use IntPoint
  1690. https://bugs.webkit.org/show_bug.cgi?id=61574
  1691. Covered by existing tests.
  1692. * dom/MouseEvent.cpp:
  1693. (WebCore::MouseEvent::MouseEvent):
  1694. (WebCore::MouseEvent::initMouseEvent):
  1695. (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
  1696. * dom/MouseRelatedEvent.cpp:
  1697. (WebCore::MouseRelatedEvent::MouseRelatedEvent):
  1698. (WebCore::contentsScrollOffset):
  1699. (WebCore::MouseRelatedEvent::initCoordinates):
  1700. (WebCore::MouseRelatedEvent::computeRelativePosition):
  1701. (WebCore::MouseRelatedEvent::layerX):
  1702. (WebCore::MouseRelatedEvent::layerY):
  1703. (WebCore::MouseRelatedEvent::offsetX):
  1704. (WebCore::MouseRelatedEvent::offsetY):
  1705. (WebCore::MouseRelatedEvent::pageX):
  1706. (WebCore::MouseRelatedEvent::pageY):
  1707. (WebCore::MouseRelatedEvent::pageLocation):
  1708. (WebCore::MouseRelatedEvent::x):
  1709. (WebCore::MouseRelatedEvent::y):
  1710. * dom/MouseRelatedEvent.h:
  1711. (WebCore::MouseRelatedEvent::screenX):
  1712. (WebCore::MouseRelatedEvent::screenY):
  1713. (WebCore::MouseRelatedEvent::screenLocation):
  1714. (WebCore::MouseRelatedEvent::clientX):
  1715. (WebCore::MouseRelatedEvent::clientY):
  1716. (WebCore::MouseRelatedEvent::clientLocation):
  1717. (WebCore::MouseRelatedEvent::absoluteLocation):
  1718. * dom/TouchEvent.cpp:
  1719. (WebCore::TouchEvent::TouchEvent):
  1720. (WebCore::TouchEvent::initTouchEvent):
  1721. * dom/WheelEvent.cpp:
  1722. (WebCore::WheelEvent::WheelEvent):
  1723. (WebCore::WheelEvent::initWheelEvent):
  1724. (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
  1725. * dom/WheelEvent.h:
  1726. (WebCore::WheelEvent::create):
  1727. (WebCore::WheelEvent::wheelDelta):
  1728. (WebCore::WheelEvent::wheelDeltaX):
  1729. (WebCore::WheelEvent::wheelDeltaY):
  1730. (WebCore::WheelEvent::rawDeltaX):
  1731. (WebCore::WheelEvent::rawDeltaY):
  1732. (WebCore::WheelEvent::isHorizontal):
  1733. * platform/graphics/IntPoint.h:
  1734. (WebCore::IntPoint::scale):
  1735. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1736. Reviewed by Eric Seidel.
  1737. Switch paintOverflowControls to use IntPoint
  1738. https://bugs.webkit.org/show_bug.cgi?id=61884
  1739. Switching paintOverflowControls to use an IntPoint instead of a pair of ints.
  1740. No new tests since this is simple refactoring.
  1741. * rendering/RenderBlock.cpp:
  1742. (WebCore::RenderBlock::paint):
  1743. * rendering/RenderLayer.cpp:
  1744. (WebCore::RenderLayer::paintOverflowControls):
  1745. (WebCore::RenderLayer::paintLayer):
  1746. * rendering/RenderLayer.h:
  1747. * rendering/RenderLayerBacking.cpp:
  1748. (WebCore::RenderLayerBacking::paintIntoLayer):
  1749. 2011-06-01 Abhishek Arya <inferno@chromium.org>
  1750. Reviewed by Alexey Proskuryakov.
  1751. Fix setting of document.body
  1752. https://bugs.webkit.org/show_bug.cgi?id=60831
  1753. 1. Only allowing setting to an element if it has a body tag.
  1754. 2. If element is from another document, import it.
  1755. Test: fast/dom/document-set-body.html
  1756. * dom/Document.cpp:
  1757. (WebCore::Document::setBody):
  1758. 2011-06-01 Chris Fleizach <cfleizach@apple.com>
  1759. Reviewed by Darin Adler.
  1760. Safari always crashes on http://bbc.co.uk when VoiceOver enabled
  1761. https://bugs.webkit.org/show_bug.cgi?id=61886
  1762. This crash can happen on webpages that remove an element from the DOM when the element receives focus.
  1763. When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
  1764. However by posting that notification, a render tree update is performed. This causes the element to disappear, but
  1765. AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.
  1766. To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method
  1767. will not be called in time.
  1768. No test could be created because to cause it depends on an internal AppKit mechanism
  1769. that is only triggered remotely through the accessibility runtime.
  1770. * accessibility/AccessibilityObject.cpp:
  1771. (WebCore::AccessibilityObject::updateBackingStore):
  1772. * accessibility/AccessibilityObject.h:
  1773. * accessibility/AccessibilityRenderObject.cpp:
  1774. * accessibility/AccessibilityRenderObject.h:
  1775. 2011-06-01 David Carson <dacarson@apple.com>
  1776. Reviewed by Antti Koivisto.
  1777. https://bugs.webkit.org/show_bug.cgi?id=61831
  1778. If width and height of an iframe is fixed and should not be visible, then
  1779. it shouldn't be flattened.
  1780. Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html
  1781. * rendering/RenderIFrame.cpp:
  1782. (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
  1783. 2011-06-01 Daniel Cheng <dcheng@chromium.org>
  1784. Reviewed by Tony Chang.
  1785. [chromium] Use correct file name for dragging out images.
  1786. https://bugs.webkit.org/show_bug.cgi?id=24887
  1787. We try to guess an appropriate filename when dragging out images. In order, we try to use:
  1788. - The filename suggested in the HTTP header.
  1789. - The last path component of the source URL.
  1790. - The alt text.
  1791. This matches the behavior of the other WebKit ports.
  1792. Test: fast/events/drag-image-filename.html
  1793. * platform/chromium/ClipboardChromium.cpp:
  1794. (WebCore::writeImageToDataObject):
  1795. * platform/chromium/ClipboardChromiumMac.cpp:
  1796. (WebCore::isInvalidFileCharacter):
  1797. (WebCore::ClipboardChromium::validateFileName):
  1798. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1799. Reviewed by Eric Seidel.
  1800. Text is scaled in a stair-step pattern
  1801. https://bugs.webkit.org/show_bug.cgi?id=60317
  1802. Stop scaling the specified font to the actual on-screen value when font-rendering:
  1803. geometricPrecision is specified, but instead scale the graphics context. This allows
  1804. us to scale text up and down smoothly.
  1805. Test: svg/text/scaling-font-with-geometric-precision.html
  1806. * rendering/svg/RenderSVGInlineText.cpp:
  1807. (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
  1808. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1809. Reviewed by Eric Seidel.
  1810. Switch paintResizer to use IntPoint
  1811. https://bugs.webkit.org/show_bug.cgi?id=61883
  1812. Switch paintResizer to take an IntPoint instead of a pair of ints.
  1813. No new tests as this is simple refactoring.
  1814. * rendering/RenderLayer.cpp:
  1815. (WebCore::RenderLayer::paintOverflowControls):
  1816. (WebCore::RenderLayer::paintResizer):
  1817. * rendering/RenderLayer.h:
  1818. * rendering/RenderLayerBacking.cpp:
  1819. (WebCore::RenderLayerBacking::paintContents):
  1820. 2011-06-01 Jer Noble <jer.noble@apple.com>
  1821. Reviewed by Darin Adler.
  1822. Page layout messed up after exiting full screen at Apple trailers page
  1823. https://bugs.webkit.org/show_bug.cgi?id=61755
  1824. <rdar://problem/9525277>
  1825. Test: fullscreen/full-screen-zIndex-after.html
  1826. Fix the incomplete implementation of r87660. Make parameters to
  1827. setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
  1828. in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
  1829. inconsistent..
  1830. * dom/Document.cpp:
  1831. (WebCore::Document::webkitWillExitFullScreenForElement):
  1832. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1833. Reviewed by Eric Seidel.
  1834. Switch paintScrollCorner to use IntPoint
  1835. https://bugs.webkit.org/show_bug.cgi?id=61874
  1836. Changing paintScrollCorner to take an IntPoint representing the paint
  1837. offset instead of a pair of ints.
  1838. No new tests as this is simple refactoring.
  1839. * rendering/RenderLayer.cpp:
  1840. (WebCore::RenderLayer::paintOverflowControls):
  1841. (WebCore::RenderLayer::paintScrollCorner):
  1842. * rendering/RenderLayer.h:
  1843. * rendering/RenderLayerBacking.cpp:
  1844. (WebCore::RenderLayerBacking::paintContents):
  1845. 2011-06-01 Kenneth Russell <kbr@google.com>
  1846. Reviewed by Nate Chapin.
  1847. [V8] Optimize fetches of indexed properties in custom bindings
  1848. https://bugs.webkit.org/show_bug.cgi?id=61821
  1849. Avoid allocating garbage in affected custom bindings. This speeds
  1850. up one test case by at least a factor of two. No new tests;
  1851. covered by existing layout tests (typed array and otherwise).
  1852. * bindings/v8/custom/V8ArrayBufferViewCustom.h:
  1853. (WebCore::constructWebGLArray):
  1854. (WebCore::setWebGLArrayHelper):
  1855. * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  1856. (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  1857. * bindings/v8/custom/V8MessagePortCustom.cpp:
  1858. (WebCore::getMessagePortArray):
  1859. * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  1860. (WebCore::jsArrayToFloatArray):
  1861. (WebCore::jsArrayToIntArray):
  1862. 2011-06-01 Andras Becsi <abecsi@webkit.org>
  1863. Reviewed by Csaba Osztrogonác.
  1864. [Qt] Fix the Phonon build when logging is disabled
  1865. https://bugs.webkit.org/show_bug.cgi?id=61869
  1866. No new tests needed.
  1867. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
  1868. (WebCore::MediaPlayerPrivatePhonon::networkState):
  1869. (WebCore::MediaPlayerPrivatePhonon::readyState):
  1870. (WebCore::MediaPlayerPrivatePhonon::updateStates):
  1871. (WebCore::MediaPlayerPrivatePhonon::stateChanged):
  1872. 2011-06-01 Abhishek Arya <inferno@chromium.org>
  1873. Reviewed by Antti Koivisto.
  1874. Do not use the pushed style selector if it is not equal to the
  1875. parent document's style selector. It usually means that it is
  1876. in a bad state, e.g. already cleared.
  1877. https://bugs.webkit.org/show_bug.cgi?id=61737
  1878. * dom/Element.cpp:
  1879. (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
  1880. 2011-06-01 Levi Weintraub <leviw@chromium.org>
  1881. Reviewed by Eric Seidel.
  1882. Switch RenderLineBoxList intersection functions to use IntPoint
  1883. https://bugs.webkit.org/show_bug.cgi?id=61794
  1884. Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
  1885. to take IntPoint instead of a tx/ty to represent the offset to be applied match
  1886. the rect and lines' coordinates.
  1887. No new tests since this is merely refactoring.
  1888. * rendering/RenderLineBoxList.cpp:
  1889. (WebCore::RenderLineBoxList::rangeIntersectsRect):
  1890. (WebCore::RenderLineBoxList::anyLineIntersectsRect):
  1891. (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
  1892. (WebCore::RenderLineBoxList::paint):
  1893. (WebCore::RenderLineBoxList::hitTest):
  1894. * rendering/RenderLineBoxList.h:
  1895. 2011-05-19 Adrienne Walker <enne@google.com>
  1896. Reviewed by James Robinson.
  1897. [chromium] Don't split long, narrow layers into multiple tiles.
  1898. https://bugs.webkit.org/show_bug.cgi?id=60821
  1899. This changes the heuristic for when we tile layers to be less bad
  1900. about wasting texture space. Long, narrow layers that are tiled with
  1901. a large tile size waste texture space. Now layers are only tiled if
  1902. they are above 512px in one dimension and extend into a second tile in
  1903. the other. If they are not tiled, their layer texture will exactly
  1904. fit their layer bounds. In particular, this will help scrollbars.
  1905. * platform/graphics/chromium/ContentLayerChromium.cpp:
  1906. (WebCore::ContentLayerChromium::updateLayerSize):
  1907. * platform/graphics/chromium/LayerRendererChromium.h:
  1908. (WebCore::LayerRendererChromium::maxTextureSize):
  1909. 2011-06-01 Cary Clark <caryclark@google.com>
  1910. Reviewed by Eric Seidel.
  1911. Ready Chromium port for Skia on Mac
  1912. https://bugs.webkit.org/show_bug.cgi?id=61800
  1913. Skia on Mac is not enabled. The executing
  1914. code is unchanged, so there are no new tests.
  1915. * platform/chromium/DragImageRef.h:
  1916. Use Skia for DragImageRef instead of CG.
  1917. * platform/chromium/ScrollbarThemeChromiumMac.mm:
  1918. (WebCore::ScrollbarThemeChromiumMac::paint):
  1919. Get the total matrix from Skia for the scrollbar.
  1920. Convert the SkCanvas into a CGContext to draw.
  1921. * platform/chromium/ThemeChromiumMac.mm:
  1922. (WebCore::paintStepper):
  1923. Ditto.
  1924. 2011-06-01 Yury Semikhatsky <yurys@chromium.org>
  1925. Reviewed by Pavel Feldman.
  1926. Web Inspector: allow opening inspector for existing workers
  1927. https://bugs.webkit.org/show_bug.cgi?id=61853
  1928. Added sidebar pane with a list of all workers. Each worker has a check box
  1929. that allows opening inspector for the worker.
  1930. * inspector/Inspector.json:
  1931. * inspector/InspectorInstrumentation.cpp:
  1932. (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
  1933. * inspector/InspectorInstrumentation.h:
  1934. (WebCore::InspectorInstrumentation::didStartWorkerContext):
  1935. * inspector/InspectorWorkerAgent.cpp:
  1936. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
  1937. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
  1938. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
  1939. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
  1940. (WebCore::InspectorWorkerAgent::clearFrontend):
  1941. (WebCore::InspectorWorkerAgent::connectToWorker):
  1942. (WebCore::InspectorWorkerAgent::disconnectFromWorker):
  1943. (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  1944. * inspector/InspectorWorkerAgent.h:
  1945. * inspector/front-end/ScriptsPanel.js:
  1946. (WebInspector.ScriptsPanel):
  1947. * inspector/front-end/Settings.js:
  1948. * inspector/front-end/WorkerManager.js:
  1949. (WebInspector.WorkerManager):
  1950. (WebInspector.WorkerManager.prototype._workerCreated):
  1951. (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
  1952. (WebInspector.WorkerManager.prototype.openWorkerInspector):
  1953. (WebInspector.WorkerManager.prototype.closeWorkerInspector):
  1954. (WebInspector.WorkerManager.prototype._workerInspectorClosing):
  1955. (WebInspector.WorkerMessageForwarder):
  1956. (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
  1957. (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
  1958. * inspector/front-end/WorkersSidebarPane.js:
  1959. (WebInspector.WorkersSidebarPane):
  1960. (WebInspector.WorkersSidebarPane.prototype.addWorker):
  1961. (WebInspector.WorkerListSidebarPane):
  1962. (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
  1963. (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
  1964. (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
  1965. (WebInspector.WorkerListSidebarPane.prototype._addWorker):
  1966. (WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
  1967. (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
  1968. * workers/Worker.cpp:
  1969. (WebCore::Worker::notifyFinished):
  1970. 2011-06-01 Shishir Agrawal <shishir@chromium.org>
  1971. Reviewed by Tony Gentilcore.
  1972. Renaming the Page Visibility attributes as per the modified spec draft.
  1973. https://bugs.webkit.org/show_bug.cgi?id=61825
  1974. Spec draft:
  1975. http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
  1976. - Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  1977. - The attribute webkitIsVisible needs to change to webkitHidden
  1978. * dom/Document.cpp:
  1979. (WebCore::Document::webkitHidden):
  1980. (WebCore::Document::dispatchVisibilityStateChangeEvent):
  1981. * dom/Document.h:
  1982. * dom/Document.idl:
  1983. * dom/EventNames.h:
  1984. 2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
  1985. Reviewed by Rob Buis.
  1986. Remove duplicated code in various computeReplacedLogical*() functions
  1987. https://bugs.webkit.org/show_bug.cgi?id=61860
  1988. Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
  1989. int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());
  1990. int maxLogicalWidth = !includeMaxWidth || style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());
  1991. return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));
  1992. Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
  1993. int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
  1994. int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
  1995. return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));
  1996. Use the new helper methods where possible, deduplicating lots of code.
  1997. * rendering/RenderBox.cpp:
  1998. (WebCore::RenderBox::computeReplacedLogicalWidth):
  1999. (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
  2000. (WebCore::RenderBox::computeReplacedLogicalHeight):
  2001. (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
  2002. * rendering/RenderBox.h:
  2003. * rendering/RenderImage.cpp:
  2004. (WebCore::RenderImage::computeReplacedLogicalWidth):
  2005. (WebCore::RenderImage::computeReplacedLogicalHeight):
  2006. * rendering/RenderPart.cpp:
  2007. (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
  2008. (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
  2009. (WebCore::RenderPart::computeReplacedLogicalWidth):
  2010. (WebCore::RenderPart::computeReplacedLogicalHeight):
  2011. * rendering/RenderPart.h:
  2012. * rendering/RenderReplaced.cpp:
  2013. (WebCore::RenderReplaced::computeReplacedLogicalWidth):
  2014. (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  2015. * rendering/svg/RenderSVGRoot.cpp:
  2016. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
  2017. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
  2018. 2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
  2019. Unreviewed, rolling out r87788.
  2020. http://trac.webkit.org/changeset/87788
  2021. https://bugs.webkit.org/show_bug.cgi?id=61856
  2022. breaks windows chromium canary (Requested by jknotten on
  2023. #webkit).
  2024. * loader/archive/mhtml/MHTMLArchive.cpp:
  2025. * loader/archive/mhtml/MHTMLArchive.h:
  2026. * page/PageSerializer.cpp:
  2027. (WebCore::PageSerializer::serializeFrame):
  2028. (WebCore::PageSerializer::serializeCSSStyleSheet):
  2029. * platform/SharedBuffer.cpp:
  2030. * platform/SharedBuffer.h:
  2031. 2011-06-01 Joseph Pecoraro <joepeck@webkit.org>
  2032. Reviewed by Pavel Feldman.
  2033. Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
  2034. https://bugs.webkit.org/show_bug.cgi?id=61835
  2035. Add a JSLock call before possible allocations in jsFunction and toString.
  2036. * bindings/js/ScriptEventListener.cpp:
  2037. (WebCore::eventListenerHandlerBody):
  2038. 2011-06-01 Jay Civelli <jcivelli@chromium.org>
  2039. Reviewed by Adam Barth.
  2040. Adding MHTML generation support to MHTMLArchive.
  2041. https://bugs.webkit.org/show_bug.cgi?id=7169
  2042. * loader/archive/mhtml/MHTMLArchive.cpp:
  2043. (WebCore::generateRandomBoundary):
  2044. (WebCore::replaceNonPrintableCharacters):
  2045. (WebCore::MHTMLArchive::generateMHTMLData):
  2046. * loader/archive/mhtml/MHTMLArchive.h:
  2047. * page/PageSerializer.cpp:
  2048. (WebCore::PageSerializer::serializeFrame):
  2049. (WebCore::PageSerializer::serializeCSSStyleSheet):
  2050. * platform/SharedBuffer.cpp:
  2051. (WebCore::SharedBuffer::append):
  2052. * platform/SharedBuffer.h:
  2053. 2011-06-01 Dimitri Glazkov <dglazkov@chromium.org>
  2054. Reviewed by Kent Tamura.
  2055. Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
  2056. https://bugs.webkit.org/show_bug.cgi?id=61816
  2057. This is a near-mechanical move-and-rename of ShadowElement, which is now only
  2058. used by input[type=file]. Next step -- switch it over to new shadow DOM.
  2059. Refactoring, no change in behavior.
  2060. * CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
  2061. * GNUmakefile.list.am: Ditto.
  2062. * WebCore.gypi: Ditto.
  2063. * WebCore.pro: Ditto.
  2064. * WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
  2065. * WebCore.xcodeproj/project.pbxproj: Ditto.
  2066. * WebCore/rendering/RenderingAllInOne.cpp: Ditto.
  2067. * rendering/RenderFileUploadControl.cpp:
  2068. (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton.
  2069. (WebCore::UploadButton::detach): Ditto.
  2070. (WebCore::UploadButton::UploadButton): Ditto.
  2071. (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
  2072. * rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
  2073. * rendering/RenderProgress.cpp: Ditto.
  2074. * rendering/ShadowElement.cpp: Removed.
  2075. * rendering/ShadowElement.h: Removed.
  2076. 2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
  2077. Reviewed by Rob Buis.
  2078. SVG fails all 3 of Hixie's CSS intrinsic sizing tests
  2079. https://bugs.webkit.org/show_bug.cgi?id=15473
  2080. Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
  2081. and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
  2082. SVGs width/height attributes into account when determining the intrinsic size of the <object>.
  2083. Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
  2084. The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
  2085. interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.
  2086. Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml
  2087. svg/custom/object-sizing-height-50p-on-target-svg.xhtml
  2088. svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
  2089. svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
  2090. svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
  2091. svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
  2092. svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
  2093. svg/custom/object-sizing-width-50p-on-target-svg.xhtml
  2094. svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
  2095. svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
  2096. svg/hixie/intrinsic/001.html
  2097. svg/hixie/intrinsic/002.html
  2098. svg/hixie/intrinsic/003.html
  2099. * rendering/RenderPart.cpp:
  2100. (WebCore::RenderPart::computeReplacedLogicalWidth):
  2101. (WebCore::RenderPart::computeReplacedLogicalHeight):
  2102. * rendering/svg/RenderSVGRoot.cpp:
  2103. (WebCore::RenderSVGRoot::computeIntrinsicRatio):
  2104. * rendering/svg/RenderSVGRoot.h:
  2105. 2011-05-31 Tonis Tiigi <tonistiigi@gmail.com>
  2106. Reviewed by Pavel Feldman.
  2107. Web Inspector: Timeline panel improvements for managing current selection
  2108. https://bugs.webkit.org/show_bug.cgi?id=61468
  2109. Enables X-axis dragging of the selected area.
  2110. Double click zoom-out.
  2111. Fixes slightly wrong selection area position.
  2112. * inspector/front-end/TimelineOverviewPane.js:
  2113. (WebInspector.TimelineOverviewPane):
  2114. (WebInspector.TimelineOverviewPane.prototype._dragWindow):
  2115. (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
  2116. (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
  2117. (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum):
  2118. (WebInspector.TimelineOverviewPane.prototype.scrollWindow):
  2119. (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
  2120. * inspector/front-end/TimelinePanel.js:
  2121. (WebInspector.TimelinePanel):
  2122. 2011-05-31 Keishi Hattori <keishi@webkit.org>
  2123. Reviewed by Kent Tamura.
  2124. Fix to enable page scroll of select element
  2125. https://bugs.webkit.org/show_bug.cgi?id=53628
  2126. Manual test: select-page-scroll.html
  2127. * manual-tests/select-page-scroll.html: Added.
  2128. * rendering/RenderListBox.cpp:
  2129. (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
  2130. 2011-05-31 Yong Li <yoli@rim.com>
  2131. Reviewed by Eric Seidel.
  2132. https://bugs.webkit.org/show_bug.cgi?id=54807
  2133. We have been assuming plain bitfields (like "int a : 31") are always signed integers.
  2134. However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
  2135. bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
  2136. http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
  2137. Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
  2138. always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
  2139. rule we should have in order to make our code independent from compilers and compiler flags.
  2140. No new test added because this change is not known to fix any issue.
  2141. * css/CSSPrimitiveValue.h:
  2142. * css/CSSProperty.h:
  2143. * rendering/InlineBox.h:
  2144. * rendering/RenderBlock.h:
  2145. 2011-05-31 Hironori Bono <hbono@chromium.org>
  2146. Reviewed by Eric Seidel.
  2147. Send an input event when we change the text direction.
  2148. https://bugs.webkit.org/show_bug.cgi?id=50952
  2149. Both Safari and Chrome call Editor::setBaseWritingDirection() to change
  2150. the text direction of an editable element with their UIs. This change
  2151. calls dispatchInputEvent() to send an input event when the function
  2152. actually changes the "dir" attribute so we can send an input event as
  2153. written in the HTML5 spec.
  2154. Test: fast/html/set-text-direction.html
  2155. * editing/Editor.cpp:
  2156. (WebCore::Editor::setBaseWritingDirection):
  2157. 2011-05-31 Jer Noble <jer.noble@apple.com>
  2158. Reviewed by Darin Adler.
  2159. Flash of black at the end of full screen transition at apple.com product videos
  2160. https://bugs.webkit.org/show_bug.cgi?id=61756
  2161. Added two new entries to the WebCore exports list.
  2162. * WebCore.exp.in:
  2163. 2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
  2164. Reviewed by Andreas Kling.
  2165. [Qt] tst_QWebFrame::render() failing
  2166. https://bugs.webkit.org/show_bug.cgi?id=60893
  2167. Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
  2168. this test was calculating the final geometry incorrectly. As the order between
  2169. a translate and a draw operation could be relevant for it, but not for the
  2170. final rendered result, they were changed on ScrollbarThemeQt::paint.
  2171. * platform/qt/ScrollbarThemeQt.cpp:
  2172. (WebCore::ScrollbarThemeQt::paint):
  2173. 2011-05-27 Adrienne Walker <enne@google.com>
  2174. Reviewed by James Robinson.
  2175. [chromium] Fix crash from empty reflections with masks
  2176. https://bugs.webkit.org/show_bug.cgi?id=61654
  2177. Change the iteration for updateCompositorResources to match that being
  2178. done in the paint and draw steps. This mismatch of iteration style
  2179. was causing layers with replica masks to correctly get skipped while
  2180. painting but not get skipped during texture upload.
  2181. Test: compositing/reflections/empty-reflection-with-mask.html
  2182. * platform/graphics/chromium/LayerRendererChromium.cpp:
  2183. (WebCore::LayerRendererChromium::updateLayers):
  2184. (WebCore::LayerRendererChromium::updateCompositorResources):
  2185. * platform/graphics/chromium/LayerRendererChromium.h:
  2186. 2011-05-31 B.J. Wever <skylined@chromium.org>
  2187. Reviewed by Adam Barth.
  2188. requestFileSystem and resolveLocalFileSystemURI are not checking if
  2189. errorCallback is NULL before scheduling a callback on error.
  2190. https://bugs.webkit.org/show_bug.cgi?id=49539
  2191. Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
  2192. * fileapi/DOMFileSystem.cpp:
  2193. (WebCore::DOMFileSystem::scheduleCallback): Only call callback if
  2194. one is supplied.
  2195. 2011-05-31 Brady Eidson <beidson@apple.com>
  2196. Reviewed by Darin Adler.
  2197. Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
  2198. Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
  2199. No new tests. No change in behavior.
  2200. Instead of storing the DocumentLoader at construction and never changing it,
  2201. always calculate it based on the FrameLoader's current DocumentLoader:
  2202. * dom/Document.cpp:
  2203. (WebCore::Document::Document):
  2204. (WebCore::Document::suggestedMIMEType):
  2205. (WebCore::Document::lastModified):
  2206. (WebCore::Document::initSecurityContext):
  2207. (WebCore::Document::updateURLForPushOrReplaceState):
  2208. (WebCore::Document::loader):
  2209. * dom/Document.h:
  2210. Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
  2211. * bindings/ScriptControllerBase.cpp:
  2212. (WebCore::ScriptController::executeIfJavaScriptURL):
  2213. * html/MediaDocument.cpp:
  2214. (WebCore::MediaDocument::replaceMediaElementTimerFired):
  2215. * html/PluginDocument.cpp:
  2216. (WebCore::PluginDocumentParser::createDocumentStructure):
  2217. * platform/mac/HTMLConverter.mm:
  2218. (fileWrapperForElement):
  2219. * WebCore.exp.in:
  2220. 2011-05-31 Levi Weintraub <leviw@chromium.org>
  2221. Reviewed by Simon Fraser.
  2222. Change InlineBox::paint and its overloaded variants to use IntPoint
  2223. https://bugs.webkit.org/show_bug.cgi?id=61804
  2224. Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
  2225. to use IntPoint for their paint offset instead of a pair of ints.
  2226. No new tests since this is just a refactoring.
  2227. * rendering/EllipsisBox.cpp:
  2228. (WebCore::EllipsisBox::paint):
  2229. * rendering/EllipsisBox.h:
  2230. * rendering/InlineBox.cpp:
  2231. (WebCore::InlineBox::paint):
  2232. * rendering/InlineBox.h:
  2233. * rendering/InlineFlowBox.cpp:
  2234. (WebCore::InlineFlowBox::paint):
  2235. * rendering/InlineFlowBox.h:
  2236. * rendering/InlineTextBox.cpp:
  2237. (WebCore::InlineTextBox::paint):
  2238. * rendering/InlineTextBox.h:
  2239. * rendering/RenderBlock.cpp:
  2240. (WebCore::RenderBlock::paintEllipsisBoxes):
  2241. * rendering/RenderBoxModelObject.cpp:
  2242. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  2243. * rendering/RenderLineBoxList.cpp:
  2244. (WebCore::RenderLineBoxList::paint):
  2245. * rendering/RootInlineBox.cpp:
  2246. (WebCore::RootInlineBox::paintEllipsisBox):
  2247. (WebCore::RootInlineBox::paint):
  2248. * rendering/RootInlineBox.h:
  2249. * rendering/svg/SVGInlineFlowBox.cpp:
  2250. (WebCore::SVGInlineFlowBox::paint):
  2251. * rendering/svg/SVGInlineFlowBox.h:
  2252. * rendering/svg/SVGInlineTextBox.cpp:
  2253. (WebCore::SVGInlineTextBox::paint):
  2254. * rendering/svg/SVGInlineTextBox.h:
  2255. * rendering/svg/SVGRootInlineBox.cpp:
  2256. (WebCore::SVGRootInlineBox::paint):
  2257. * rendering/svg/SVGRootInlineBox.h:
  2258. 2011-05-31 James Robinson <jamesr@chromium.org>
  2259. Reviewed by Kenneth Russell.
  2260. [chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
  2261. https://bugs.webkit.org/show_bug.cgi?id=61593
  2262. Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
  2263. This is extremely defensive and not strictly necessary, but not harmful either.
  2264. * platform/graphics/chromium/LayerChromium.h:
  2265. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  2266. (WebCore::CCLayerImpl::~CCLayerImpl):
  2267. 2011-05-31 Stephen White <senorblanco@chromium.org>
  2268. Unreviewed; build fix.
  2269. Silence some warnings on the Safari/Mac release build.
  2270. * platform/graphics/gpu/TilingData.h:
  2271. (WebCore::TilingData::assertTile):
  2272. 2011-05-31 Justin Novosad <junov@chromium.org>
  2273. Reviewed by Stephen White.
  2274. [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
  2275. https://bugs.webkit.org/show_bug.cgi?id=61790
  2276. Changing the build guards in these two files that are required
  2277. by the accelerated compositing feature.
  2278. * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  2279. * platform/graphics/gpu/TilingData.cpp:
  2280. 2011-05-31 Justin Novosad <junov@chromium.org>
  2281. Reviewed by Stephen White.
  2282. [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
  2283. https://bugs.webkit.org/show_bug.cgi?id=61790
  2284. Changing the build guards in these two files that are required
  2285. by the accelerated compositing feature.
  2286. * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  2287. * platform/graphics/gpu/TilingData.cpp:
  2288. 2011-05-31 Rob Buis <rbuis@rim.com>
  2289. Reviewed by Dirk Schulze.
  2290. https://bugs.webkit.org/show_bug.cgi?id=34301
  2291. Creating <animateMotion> elements via javascript do not execute
  2292. https://bugs.webkit.org/show_bug.cgi?id=17043
  2293. SVG missing some .idl files
  2294. Add missing idl files.
  2295. Test: svg/animations/animate-mpath-insert.html
  2296. * CMakeLists.txt:
  2297. * CodeGenerators.pri:
  2298. * WebCore.gypi:
  2299. * WebCore.xcodeproj/project.pbxproj:
  2300. * svg/SVGAnimateMotionElement.idl: Added.
  2301. * svg/SVGMPathElement.idl: Added.
  2302. 2011-05-31 Robin Dunn <robin@alldunn.com>
  2303. Reviewed by Kevin Ollivier.
  2304. [wx] Implement printing support for wxWidgets 2.9.x and above.
  2305. https://bugs.webkit.org/show_bug.cgi?id=61796
  2306. * platform/graphics/GraphicsContext.h:
  2307. * platform/graphics/wx/FontWx.cpp:
  2308. (WebCore::Font::drawGlyphs):
  2309. * platform/graphics/wx/GraphicsContextWx.cpp:
  2310. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  2311. (WebCore::GraphicsContext::drawRect):
  2312. (WebCore::GraphicsContext::drawLine):
  2313. (WebCore::GraphicsContext::drawEllipse):
  2314. (WebCore::GraphicsContext::strokeArc):
  2315. (WebCore::GraphicsContext::drawConvexPolygon):
  2316. (WebCore::GraphicsContext::fillRect):
  2317. (WebCore::GraphicsContext::drawLineForText):
  2318. (WebCore::GraphicsContext::scale):
  2319. (WebCore::GraphicsContext::currentScale):
  2320. * platform/wx/wxcode/win/non-kerned-drawing.cpp:
  2321. (WebCore::drawTextWithSpacing):
  2322. 2011-05-31 Joseph Pecoraro <joepeck@webkit.org>
  2323. Reviewed by Pavel Feldman.
  2324. Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
  2325. https://bugs.webkit.org/show_bug.cgi?id=61751
  2326. Add missing stub function causing an error on load.
  2327. * inspector/front-end/InspectorFrontendHostStub.js:
  2328. (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
  2329. 2011-05-31 Abhishek Arya <inferno@chromium.org>
  2330. Reviewed by Dimitri Glazkov.
  2331. Improve hasMediaControls logic to check that node has
  2332. media controls. This can be false when cloning nodes.
  2333. https://bugs.webkit.org/show_bug.cgi?id=61765
  2334. Test: media/media-controls-clone-crash.html
  2335. * dom/Node.h:
  2336. (WebCore::Node::isMediaControls):
  2337. * html/HTMLMediaElement.cpp:
  2338. (WebCore::HTMLMediaElement::mediaControls):
  2339. (WebCore::HTMLMediaElement::hasMediaControls):
  2340. * html/shadow/MediaControls.h:
  2341. (WebCore::MediaControls::isMediaControls):
  2342. (WebCore::toMediaControls):
  2343. 2011-05-31 Xan Lopez <xlopez@igalia.com>
  2344. Reviewed by Martin Robinson.
  2345. [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
  2346. https://bugs.webkit.org/show_bug.cgi?id=61791
  2347. * bindings/gobject/GNUmakefile.am: add new files.
  2348. * bindings/gobject/WebKitDOMCustom.cpp: Added.
  2349. (webkit_dom_html_text_area_element_is_edited):
  2350. (webkit_dom_html_input_element_is_edited):
  2351. * bindings/gobject/WebKitDOMCustom.h: Added.
  2352. 2011-05-31 Noam Rosenthal <noam.rosenthal@nokia.com>
  2353. Unreviewed build fix for Symbian.
  2354. Opt-out Symbian for TextureMapper.
  2355. No new tests: build fix.
  2356. * WebCore.pri:
  2357. 2011-05-31 Levi Weintraub <leviw@chromium.org>
  2358. Reviewed by Eric Seidel.
  2359. Switch paintFocusRing to IntPoint
  2360. https://bugs.webkit.org/show_bug.cgi?id=61580
  2361. Switching paintFocusRing to take an IntPoint representing the paint offset
  2362. instead of a pair of ints.
  2363. No new tests as this is just refactoring.
  2364. * rendering/RenderInline.cpp:
  2365. (WebCore::RenderInline::paintOutline):
  2366. * rendering/RenderObject.cpp:
  2367. (WebCore::RenderObject::paintFocusRing):
  2368. (WebCore::RenderObject::paintOutline):
  2369. * rendering/RenderObject.h:
  2370. 2011-05-31 Abhishek Arya <inferno@chromium.org>
  2371. Reviewed by Dimitri Glazkov.
  2372. Convert raw ptr to RefPtr for documentElement.
  2373. https://bugs.webkit.org/show_bug.cgi?id=61688
  2374. Test: fast/dom/xml-parser-error-message-crash.svg
  2375. * dom/XMLDocumentParser.cpp:
  2376. (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  2377. 2011-05-31 Andreas Kling <kling@webkit.org>
  2378. Reviewed by Antti Koivisto.
  2379. Canvas/JSC: Auto-generate overloads for setShadow()
  2380. https://bugs.webkit.org/show_bug.cgi?id=61786
  2381. Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.
  2382. There is a subtle difference to the previous behavior: invalid numbers of
  2383. arguments now raise TypeError instead of SyntaxError. This is in accordance
  2384. with Web IDL, and matches the existing V8 bindings.
  2385. Test: fast/canvas/canvas-overloads-setShadow.html
  2386. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2387. * html/canvas/CanvasRenderingContext2D.idl:
  2388. 2011-05-31 Andreas Kling <kling@webkit.org>
  2389. Reviewed by Antti Koivisto.
  2390. Canvas/JSC: Auto-generate overloads for drawImageFromRect()
  2391. https://bugs.webkit.org/show_bug.cgi?id=61709
  2392. Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
  2393. Make it [RequiresAllArguments=Raise] to match the old behavior.
  2394. Side effect: calling drawImageFromRect() with zero arguments will now raise
  2395. SyntaxError instead of TypeError.
  2396. Test: fast/canvas/canvas-overloads-drawImageFromRect.html
  2397. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2398. * html/canvas/CanvasRenderingContext2D.h:
  2399. * html/canvas/CanvasRenderingContext2D.idl:
  2400. 2011-05-31 Andreas Kling <kling@webkit.org>
  2401. Reviewed by Antti Koivisto.
  2402. Canvas/JSC: Auto-generate overloads for drawImage()
  2403. https://bugs.webkit.org/show_bug.cgi?id=61703
  2404. Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.
  2405. There is a subtle difference to the previous behavior: invalid numbers of
  2406. arguments now raise TypeError instead of SyntaxError. This is in accordance
  2407. with Web IDL, and matches the existing V8 bindings.
  2408. Test: fast/canvas/canvas-overloads-drawImage.html
  2409. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2410. * html/canvas/CanvasRenderingContext2D.idl:
  2411. 2011-05-31 Andreas Kling <kling@webkit.org>
  2412. Reviewed by Antti Koivisto.
  2413. Canvas/JSC: Auto-generate overloads for strokeRect()
  2414. https://bugs.webkit.org/show_bug.cgi?id=61641
  2415. Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
  2416. No behavioral change.
  2417. Test: fast/canvas/canvas-overloads-strokeRect.html
  2418. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2419. * html/canvas/CanvasRenderingContext2D.idl:
  2420. 2011-05-31 Andreas Kling <kling@webkit.org>
  2421. Reviewed by Antti Koivisto.
  2422. Canvas/JSC: Auto-generate overloads for setFillColor()
  2423. https://bugs.webkit.org/show_bug.cgi?id=61635
  2424. Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
  2425. There is a subtle difference to the previous behavior: invalid numbers of
  2426. arguments now raise TypeError instead of SyntaxError. This is in accordance
  2427. with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
  2428. Test: fast/canvas/canvas-overloads-setFillColor.html
  2429. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2430. * html/canvas/CanvasRenderingContext2D.idl:
  2431. 2011-05-31 Andreas Kling <kling@webkit.org>
  2432. Reviewed by Antti Koivisto.
  2433. Canvas/JSC: Auto-generate overloads for setStrokeColor()
  2434. https://bugs.webkit.org/show_bug.cgi?id=61629
  2435. Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
  2436. There is a subtle difference to the previous behavior: invalid numbers of
  2437. arguments now raise TypeError instead of SyntaxError. This is in accordance
  2438. with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
  2439. Test: fast/canvas/canvas-overloads-setStrokeColor.html
  2440. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2441. * html/canvas/CanvasRenderingContext2D.idl:
  2442. 2011-05-31 Andreas Kling <kling@webkit.org>
  2443. Reviewed by Antti Koivisto.
  2444. Canvas/JSC: Auto-generate overloads for strokeText()
  2445. https://bugs.webkit.org/show_bug.cgi?id=61626
  2446. Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
  2447. Make it [RequiresAllArguments=Raise] to match the old behavior.
  2448. This has the side-effect of aligning the behaviors of JSC and V8.
  2449. Test: fast/canvas/canvas-overloads-strokeText.html
  2450. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2451. * html/canvas/CanvasRenderingContext2D.idl:
  2452. 2011-05-31 Andreas Kling <kling@webkit.org>
  2453. Reviewed by Antti Koivisto.
  2454. Canvas/JSC: Auto-generate overloads for fillText()
  2455. https://bugs.webkit.org/show_bug.cgi?id=61623
  2456. Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
  2457. Make it [RequiresAllArguments=Raise] to match the old behavior.
  2458. This has the side-effect of aligning the behaviors of JSC and V8.
  2459. Test: fast/canvas/canvas-overloads-fillText.html
  2460. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  2461. * html/canvas/CanvasRenderingContext2D.idl:
  2462. 2011-05-31 Yael Aharon <yael.aharon@nokia.com>
  2463. Reviewed by Kenneth Rohde Christiansen.
  2464. Frame flattening is broken with nested frames
  2465. https://bugs.webkit.org/show_bug.cgi?id=61491
  2466. After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
  2467. This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
  2468. Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.
  2469. Test: fast/frames/flattening/iframe-flattening-nested.html
  2470. * page/FrameView.cpp:
  2471. (WebCore::FrameView::layout):
  2472. 2011-05-31 Tommy Widenflycht <tommyw@google.com>
  2473. Reviewed by Tony Gentilcore.
  2474. Fix getUserMedia callback bindings for JSC.
  2475. https://bugs.webkit.org/show_bug.cgi?id=60174
  2476. This patch initializes the exception code variable to 0.
  2477. Test: fast/dom/MediaStream/argument-types.html
  2478. * bindings/js/JSNavigatorCustom.cpp:
  2479. (WebCore::JSNavigator::webkitGetUserMedia):
  2480. 2011-05-31 Oleg Romashin <oleg.romashin@nokia.com>
  2481. Reviewed by Benjamin Poulain.
  2482. Fix compilation with debug enabled, m_lightSource.type is not valid anymore
  2483. https://bugs.webkit.org/show_bug.cgi?id=61719
  2484. * platform/graphics/filters/arm/FELightingNEON.h:
  2485. (WebCore::FELighting::platformApplyNeon):
  2486. 2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
  2487. Reviewed by Nikolas Zimmermann.
  2488. Invalid color handling is broken for SVG
  2489. https://bugs.webkit.org/show_bug.cgi?id=58531
  2490. Fix invalid color fallback handling. If the fill/stroke attributes computed
  2491. value leads to a an invalid color, inherit the desired color from the parent
  2492. style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).
  2493. Tests: svg/custom/invalid-stroke-hex.svg
  2494. svg/custom/invalid-uri-stroke.svg
  2495. * rendering/svg/RenderSVGResource.cpp:
  2496. (WebCore::inheritColorFromParentStyleIfNeeded):
  2497. (WebCore::requestPaintingResource):
  2498. 2011-05-31 Vangelis Kokkevis <vangelis@chromium.org>
  2499. Reviewed by Kent Tamura.
  2500. [chromium] Avoid double deletion of DrawingBuffer's color buffer
  2501. texture.
  2502. https://bugs.webkit.org/show_bug.cgi?id=61761
  2503. Test: Verified that the DCHECK in GraphicsContext3D implementation
  2504. doesn't trigger.
  2505. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  2506. (WebCore::DrawingBuffer::~DrawingBuffer):
  2507. 2011-05-30 Hayato Ito <hayato@chromium.org>
  2508. Reviewed by Ryosuke Niwa.
  2509. Add a utility function for dumping a tree for the Node, including a document of a frame.
  2510. https://bugs.webkit.org/show_bug.cgi?id=61727
  2511. No new tests since added functions are only available in debug builds.
  2512. * dom/Node.cpp:
  2513. (WebCore::parentOrHostOrFrameOwner):
  2514. (WebCore::traverseNextNodeAcrossFrame):
  2515. (WebCore::Node::showTreeForThisAcrossFrame):
  2516. * dom/Node.h:
  2517. 2011-05-30 James Kozianski <koz@chromium.org>
  2518. Reviewed by Kent Tamura.
  2519. [Chromium] Make isValidProtocol() accept protocols with '+'.
  2520. https://bugs.webkit.org/show_bug.cgi?id=61759
  2521. Also, detect syntax errors before security errors; some syntax errors
  2522. will also trigger a security error, but it's more helpful to the
  2523. programmer to know if they have a syntax error, which are well-defined
  2524. in the spec, rather than a security error, which aren't.
  2525. * page/Navigator.cpp:
  2526. (WebCore::Navigator::registerProtocolHandler):
  2527. Detect syntax errors before security errors.
  2528. * platform/KURLGoogle.cpp:
  2529. (WebCore::isSchemeChar):
  2530. Include '+' in the list of valid characters.
  2531. 2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>
  2532. Reviewed by Hajime Morita.
  2533. Using jQuery to show/hide IMG elements crashes WebKit
  2534. https://bugs.webkit.org/show_bug.cgi?id=31721
  2535. For platform code, do not assert nodes always have renderer at
  2536. the time context menu action is invoked.
  2537. Renderer can actually be empty for a given node if it was hidden
  2538. or removed from domtree by some non-user generated event (e.g timeout)
  2539. after the popup menu had been created.
  2540. Changing Chromium, Gtk, Mac, Qt, Win and WinCE.
  2541. Test: editing/pasteboard/copy-standalone-image-crash.html
  2542. * platform/chromium/PasteboardChromium.cpp:
  2543. (WebCore::Pasteboard::writeImage):
  2544. * platform/gtk/PasteboardGtk.cpp:
  2545. (WebCore::Pasteboard::writeImage):
  2546. * platform/mac/PasteboardMac.mm:
  2547. (WebCore::Pasteboard::writeImage):
  2548. * platform/qt/PasteboardQt.cpp:
  2549. (WebCore::Pasteboard::writeImage):
  2550. * platform/win/PasteboardWin.cpp:
  2551. (WebCore::Pasteboard::writeImage):
  2552. * platform/wince/PasteboardWinCE.cpp:
  2553. (WebCore::Pasteboard::writeImage):
  2554. 2011-05-30 Daniel Bates <dbates@webkit.org>
  2555. Reviewed by Adam Barth.
  2556. Rename XSSFilter to XSSAuditor
  2557. https://bugs.webkit.org/show_bug.cgi?id=61718
  2558. Currently we use the names XSSFilter and XSSAuditor throughout the project.
  2559. Instead, we should choose one name for consistency.
  2560. No functionality was changed. So, no new tests.
  2561. * CMakeLists.txt:
  2562. * GNUmakefile.list.am:
  2563. * WebCore.gypi:
  2564. * WebCore.pro:
  2565. * WebCore.vcproj/WebCore.vcproj:
  2566. * WebCore.xcodeproj/project.pbxproj:
  2567. * html/parser/HTMLDocumentParser.cpp:
  2568. (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  2569. (WebCore::HTMLDocumentParser::pumpTokenizer):
  2570. * html/parser/HTMLDocumentParser.h:
  2571. * html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp.
  2572. (WebCore::XSSAuditor::XSSAuditor):
  2573. (WebCore::XSSAuditor::init):
  2574. (WebCore::XSSAuditor::filterToken):
  2575. (WebCore::XSSAuditor::filterTokenInitial):
  2576. (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
  2577. (WebCore::XSSAuditor::filterScriptToken):
  2578. (WebCore::XSSAuditor::filterObjectToken):
  2579. (WebCore::XSSAuditor::filterParamToken):
  2580. (WebCore::XSSAuditor::filterEmbedToken):
  2581. (WebCore::XSSAuditor::filterAppletToken):
  2582. (WebCore::XSSAuditor::filterIframeToken):
  2583. (WebCore::XSSAuditor::filterMetaToken):
  2584. (WebCore::XSSAuditor::filterBaseToken):
  2585. (WebCore::XSSAuditor::filterFormToken):
  2586. (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
  2587. (WebCore::XSSAuditor::eraseAttributeIfInjected):
  2588. (WebCore::XSSAuditor::snippetForRange):
  2589. (WebCore::XSSAuditor::snippetForAttribute):
  2590. (WebCore::XSSAuditor::isContainedInRequest):
  2591. (WebCore::XSSAuditor::isSameOriginResource):
  2592. * html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
  2593. * html/parser/XSSFilter.cpp: Removed.
  2594. * html/parser/XSSFilter.h: Removed.
  2595. 2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
  2596. Reviewed by Simon Hausmann.
  2597. WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
  2598. https://bugs.webkit.org/show_bug.cgi?id=61694
  2599. Expose a public clearAll() function to reset WebCore::Animation.
  2600. No new functionality, so no new tests.
  2601. * platform/animation/Animation.h:
  2602. (WebCore::Animation::clearAll):
  2603. 2011-05-30 Eric Carlson <eric.carlson@apple.com>
  2604. Reviewed by Alexey Proskuryakov.
  2605. Audio and video files saved to the Application Cache should preserve the original file extension
  2606. https://bugs.webkit.org/show_bug.cgi?id=61750
  2607. <rdar://9524922>
  2608. No new tests, it isn't possible to check the name of the file in the cache from within
  2609. DRT. Changes verified manually.
  2610. * loader/appcache/ApplicationCacheStorage.cpp:
  2611. (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache
  2612. file name.
  2613. (WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.
  2614. * loader/appcache/ApplicationCacheStorage.h:
  2615. 2011-05-30 Jer Noble <jer.noble@apple.com>
  2616. Reviewed by Dan Bernstein.
  2617. Play/Pause button in wrong state when entering full screen on Vimeo
  2618. https://bugs.webkit.org/show_bug.cgi?id=61754
  2619. Update the play/pause button inside reset(). This ensures the button is in
  2620. the correct state when the controls are created after playback has already
  2621. started.
  2622. * html/shadow/MediaControlRootElement.cpp:
  2623. (WebCore::MediaControlRootElement::reset):
  2624. 2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
  2625. Reviewed by Simon Hausmann.
  2626. WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
  2627. https://bugs.webkit.org/show_bug.cgi?id=61694
  2628. Added a public TimingFunction::type() method.
  2629. No new functionality, so no new tests.
  2630. * platform/animation/TimingFunction.h:
  2631. (WebCore::TimingFunction::type):
  2632. 2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
  2633. BUILD FIX for r87697 on Windows/Symbian
  2634. For now enabling TextureMapper for Mac/Linux only.
  2635. * WebCore.pri:
  2636. 2011-05-30 David Kilzer <ddkilzer@apple.com>
  2637. BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)
  2638. * dom/EventDispatcher.cpp:
  2639. (WebCore::EventDispatcher::determineDispatchBehavior): Mark
  2640. shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).
  2641. 2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
  2642. Reviewed by Andreas Kling.
  2643. [Texmap][Qt] Enable TextureMapper by default
  2644. https://bugs.webkit.org/show_bug.cgi?id=61740
  2645. Make CONFIG+=texmap an opt-out instead of an opt-in.
  2646. No new functionality so no new tests.
  2647. * WebCore.pri:
  2648. 2011-05-30 Martin Robinson <mrobinson@igalia.com>
  2649. Reviewed by Xan Lopez.
  2650. [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
  2651. https://bugs.webkit.org/show_bug.cgi?id=61693
  2652. Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
  2653. null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
  2654. may now be null.
  2655. No new tests. This change should cause fast/css/font-face-zero-hash-key.html
  2656. to stop crashing.
  2657. * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  2658. (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing
  2659. m_scaledFont.
  2660. 2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
  2661. Reviewed by Kenneth Rohde Christiansen.
  2662. [Texmap][Qt] Disable accelerated plugins/media until they're working.
  2663. https://bugs.webkit.org/show_bug.cgi?id=61687
  2664. Until this works properly, we should indicate that our media implementation
  2665. in texture mapper doesn't support accelerated compositing.
  2666. This makes LayoutTests/compositing/video/* work again.
  2667. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  2668. (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
  2669. (WebCore::MediaPlayerPrivateQt::platformLayer):
  2670. 2011-05-30 Mikhail Naganov <mnaganov@chromium.org>
  2671. Reviewed by Adam Barth.
  2672. [Chromium] Fix regression after r87628.
  2673. https://bugs.webkit.org/show_bug.cgi?id=61733
  2674. Having r87628 in place, Chrome reliability bot crashes in
  2675. WebCore::HTMLLinkElement::onloadTimerFired.
  2676. This is because the change makes WebCore::CachedResource::setRequest to
  2677. call checkNotify on request reset. HTMLLinkElement registers itself as
  2678. CachedResource client via m_cachedSheet, which can happen even if
  2679. m_cachedLinkResource wasn't set. As a result,
  2680. WebCore::HTMLLinkElement::notifyFinished is got called with unset
  2681. m_cachedLinkResource, which causes a crash in
  2682. HTMLLinkElement::onloadTimerFired
  2683. * html/HTMLLinkElement.cpp:
  2684. (WebCore::HTMLLinkElement::notifyFinished):
  2685. 2011-05-30 Jer Noble <jer.noble@apple.com>
  2686. Reviewed by Darin Adler and Simon Fraser.
  2687. REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
  2688. https://bugs.webkit.org/show_bug.cgi?id=61717
  2689. rdar://problem/9522272
  2690. May be some good way to test this later. No immediate idea about the best way.
  2691. When a media element is taken into full-screen mode, stop events from propagating
  2692. outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
  2693. has been changed to take a shadow root node. In our full screen media element check,
  2694. we check to see if the passed shadow root is the shadow root of the full screen media
  2695. element, and if so, specify events should StayInsideShadowDOM. The end result is that
  2696. inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
  2697. way from the SliderThumb to the video element's shadow root, but no further.
  2698. * dom/EventDispatcher.cpp:
  2699. (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the
  2700. shadow DOM when showing a full screen video.
  2701. * html/HTMLMediaElement.cpp:
  2702. (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls.
  2703. The events telling us about activity in the shadow DOM no longer bubble out so we need to
  2704. handle this inside the shadow DOM on the root element.
  2705. (WebCore::HTMLMediaElement::play): Ditto.
  2706. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
  2707. (WebCore::HTMLMediaElement::defaultEventHandler): Ditto.
  2708. (WebCore::HTMLMediaElement::enterFullscreen): Ditto.
  2709. (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
  2710. * html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
  2711. * html/shadow/MediaControlElements.cpp:
  2712. (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out
  2713. changes that tried to make special rules for events using preDispatchEventHandler and such.
  2714. This rolls out both r87622 and r87655.
  2715. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto.
  2716. (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto.
  2717. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto.
  2718. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
  2719. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
  2720. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
  2721. (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto.
  2722. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
  2723. (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.
  2724. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto.
  2725. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
  2726. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
  2727. * html/shadow/MediaControlElements.h: Ditto.
  2728. * html/shadow/MediaControlRootElement.cpp:
  2729. (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members.
  2730. (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider
  2731. hiding the controls later.
  2732. (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse
  2733. is no longer over the controls.
  2734. (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide
  2735. automatically if we're playing.
  2736. (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer.
  2737. (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care
  2738. if we are full screen.
  2739. (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function.
  2740. (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions
  2741. as the mouse is moved in and out.
  2742. (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if
  2743. needed.
  2744. (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions
  2745. are met.
  2746. (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
  2747. * html/shadow/MediaControlRootElement.h: Added new functions and data members.
  2748. 2011-05-30 Gavin Peters <gavinp@chromium.org>
  2749. Reviewed by Adam Barth.
  2750. prevent HTMLLinkElement from watching multiple CachedResources
  2751. https://bugs.webkit.org/show_bug.cgi?id=61686
  2752. If we modify an existing link element, stop listening to the previous
  2753. cached resource, to prevent double notifications (which crash).
  2754. Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
  2755. * html/HTMLLinkElement.cpp:
  2756. (WebCore::HTMLLinkElement::process):
  2757. 2011-05-30 Peter Varga <pvarga@webkit.org>
  2758. Unreviewed build fix.
  2759. [Qt][V8] Fix debug build.
  2760. No new tests needed.
  2761. * css/CSSStyleDeclaration.cpp: Add missing header.
  2762. * dom/Text.cpp: Ditto.
  2763. * rendering/InlineTextBox.cpp: Ditto.
  2764. 2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
  2765. Unreviewed, rolling out r87683.
  2766. http://trac.webkit.org/changeset/87683
  2767. https://bugs.webkit.org/show_bug.cgi?id=61729
  2768. Breaks inspector tests on Chromium (Requested by apavlov on
  2769. #webkit).
  2770. * inspector/front-end/StylesSidebarPane.js:
  2771. (WebInspector.StylesSidebarPane.prototype.update):
  2772. 2011-05-25 Alexander Pavlov <apavlov@chromium.org>
  2773. Reviewed by Yury Semikhatsky.
  2774. Web Inspector: node selection is slow in the Elements panel.
  2775. https://bugs.webkit.org/show_bug.cgi?id=60813
  2776. Schedule full style updates rather than request all node styles from the backend up front.
  2777. * inspector/front-end/StylesSidebarPane.js:
  2778. (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
  2779. (WebInspector.StylesSidebarPane.prototype.update):
  2780. 2011-05-30 Andrey Kosyakov <caseq@chromium.org>
  2781. Reviewed by Pavel Feldman.
  2782. Web Inspector: do not issue frontendReused for reload or navigation.
  2783. https://bugs.webkit.org/show_bug.cgi?id=61192
  2784. - only issue frontendReused when inspector is attached after main resource committed load
  2785. - upon committing loading main resource, reset agents before sending FrameNavigated to page agent
  2786. - Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
  2787. - do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
  2788. * inspector/InspectorAgent.cpp:
  2789. (WebCore::InspectorAgent::InspectorAgent):
  2790. (WebCore::InspectorAgent::restore):
  2791. (WebCore::InspectorAgent::clearFrontend):
  2792. (WebCore::InspectorAgent::didCommitLoad):
  2793. * inspector/InspectorAgent.h:
  2794. * inspector/InspectorInstrumentation.cpp:
  2795. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  2796. * inspector/front-end/NetworkManager.js:
  2797. * inspector/front-end/ResourceTreeModel.js:
  2798. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  2799. (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  2800. (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
  2801. (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  2802. * inspector/front-end/ResourcesPanel.js:
  2803. (WebInspector.ResourcesPanel.prototype.reset):
  2804. (WebInspector.ResourcesPanel.prototype._resetResourcesTree):
  2805. (WebInspector.DatabaseTreeElement.prototype.onpopulate):
  2806. (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  2807. * inspector/front-end/inspector.js:
  2808. (WebInspector.reset):
  2809. (WebInspector.frontendReused):
  2810. 2011-05-30 Ryan Sleevi <rsleevi@chromium.org>
  2811. Reviewed by Darin Adler.
  2812. FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
  2813. https://bugs.webkit.org/show_bug.cgi?id=61603
  2814. Test: svg/filters/feConvolveFilter-y-bounds.svg
  2815. * platform/graphics/filters/FEConvolveMatrix.cpp:
  2816. (WebCore::FEConvolveMatrix::getPixelValue):
  2817. 2011-05-30 Nate Chapin <japhet@chromium.org>
  2818. Reviewed by Antti Koivisto.
  2819. Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
  2820. flow so it's a little less circular.
  2821. https://bugs.webkit.org/show_bug.cgi?id=61666
  2822. * loader/cache/CachedFont.cpp:
  2823. (WebCore::CachedFont::beginLoadIfNeeded):
  2824. * loader/cache/CachedResource.cpp:
  2825. (WebCore::CachedResource::load):
  2826. * loader/cache/CachedResourceLoader.cpp:
  2827. (WebCore::CachedResourceLoader::requestImage):
  2828. (WebCore::CachedResourceLoader::setAutoLoadImages):
  2829. (WebCore::CachedResourceLoader::loadStarted):
  2830. * loader/cache/CachedResourceLoader.h:
  2831. * loader/cache/CachedResourceRequest.cpp:
  2832. (WebCore::CachedResourceRequest::load):
  2833. 2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
  2834. Unreviewed, rolling out r87618.
  2835. http://trac.webkit.org/changeset/87618
  2836. https://bugs.webkit.org/show_bug.cgi?id=61720
  2837. Causes BrowserFocusTest.FocusOnReload to fail (Requested by
  2838. abarth|gardener on #webkit).
  2839. * html/HTMLLinkElement.cpp:
  2840. (WebCore::HTMLLinkElement::process):
  2841. 2011-05-29 Yuta Kitamura <yutak@chromium.org>
  2842. Reviewed by Kent Tamura.
  2843. WebSocket closing handshake
  2844. https://bugs.webkit.org/show_bug.cgi?id=35721
  2845. Implement WebSocket closing handshake based on Ian Hickson's
  2846. WebSocket protocol draft 76.
  2847. Tests: http/tests/websocket/tests/client-close.html
  2848. http/tests/websocket/tests/server-close.html
  2849. * platform/network/SocketStreamHandleBase.cpp:
  2850. (WebCore::SocketStreamHandleBase::send):
  2851. Do not send a message if we are in Closing state.
  2852. (WebCore::SocketStreamHandleBase::close):
  2853. Do not disconnect if we have pending data which have not been sent yet.
  2854. In this case, the actual disconnection will happen in sendPendingData().
  2855. (WebCore::SocketStreamHandleBase::disconnect):
  2856. Renamed from close(). Disconnect the connection immediately.
  2857. (WebCore::SocketStreamHandleBase::sendPendingData):
  2858. * platform/network/SocketStreamHandleBase.h:
  2859. * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
  2860. Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
  2861. to didClose().
  2862. (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
  2863. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  2864. (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
  2865. (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  2866. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  2867. * websockets/WebSocket.cpp:
  2868. (WebCore::WebSocket::send):
  2869. (WebCore::WebSocket::close):
  2870. Fail if close() is attempted before the connection is established.
  2871. Otherwise, set the state to CLOSING and start the closing handshake.
  2872. (WebCore::WebSocket::bufferedAmount):
  2873. If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
  2874. (WebCore::WebSocket::didConnect):
  2875. (WebCore::WebSocket::didReceiveMessage):
  2876. We need to invoke message event in CLOSING state as well as OPEN state.
  2877. (WebCore::WebSocket::didReceiveMessageError):
  2878. (WebCore::WebSocket::didStartClosingHandshake):
  2879. (WebCore::WebSocket::didClose):
  2880. * websockets/WebSocket.h:
  2881. * websockets/WebSocketChannel.cpp:
  2882. (WebCore::WebSocketChannel::WebSocketChannel):
  2883. (WebCore::WebSocketChannel::close):
  2884. Start the closing handshake.
  2885. (WebCore::WebSocketChannel::disconnect):
  2886. Disconnect the socket stream, instead of close.
  2887. (WebCore::WebSocketChannel::didClose):
  2888. (WebCore::WebSocketChannel::didReceiveData): Ditto.
  2889. (WebCore::WebSocketChannel::didFail): Ditto.
  2890. (WebCore::WebSocketChannel::processBuffer):
  2891. Ditto.
  2892. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
  2893. (WebCore::WebSocketChannel::startClosingHandshake):
  2894. Send 0xFF 0x00 byte sequence.
  2895. (WebCore::WebSocketChannel::closingTimerFired):
  2896. Disconnect the socket stream if the closing handshake has timed out.
  2897. * websockets/WebSocketChannel.h:
  2898. m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
  2899. specification).
  2900. * websockets/WebSocketChannelClient.h:
  2901. (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
  2902. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  2903. * websockets/WorkerThreadableWebSocketChannel.cpp:
  2904. Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
  2905. (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
  2906. (WebCore::workerContextDidStartClosingHandshake):
  2907. (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
  2908. (WebCore::workerContextDidClose):
  2909. (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  2910. * websockets/WorkerThreadableWebSocketChannel.h:
  2911. 2011-05-29 Adam Barth <abarth@webkit.org>
  2912. Attempt to fix build by implementing pure virtual function.
  2913. * html/shadow/MediaControlRootElementChromium.cpp:
  2914. (WebCore::MediaControlRootElementChromium::shouldHideControls):
  2915. * html/shadow/MediaControlRootElementChromium.h:
  2916. 2011-05-29 Brian Weinstein <bweinstein@apple.com>
  2917. Reviewed by Darin Adler.
  2918. Controls never hide in full screen after user stops moving mouse
  2919. https://bugs.webkit.org/show_bug.cgi?id=61715
  2920. <rdar://problem/9522182>
  2921. When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
  2922. show the media controls, and then start a timer.
  2923. The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
  2924. move), and hides the controls.
  2925. * html/HTMLMediaElement.cpp:
  2926. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer.
  2927. (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen
  2928. controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
  2929. to play.
  2930. (WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future
  2931. if we are in full screen.
  2932. (WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and
  2933. we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.
  2934. (WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
  2935. (WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the
  2936. controls and start a timer to hide them.
  2937. (WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't
  2938. have the move the mouse once they enter full screen to hide the controls.
  2939. (WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.
  2940. * html/HTMLMediaElement.h:
  2941. * html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
  2942. * html/shadow/MediaControlRootElement.cpp:
  2943. (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls.
  2944. (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that
  2945. the caller should hide the controls if the panel is not hovered.
  2946. * html/shadow/MediaControlRootElement.h:
  2947. 2011-05-29 Jer Noble <jer.noble@apple.com>
  2948. Reviewed by Simon Fraser.
  2949. Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
  2950. https://bugs.webkit.org/show_bug.cgi?id=61712
  2951. Tests: fullscreen/full-screen-iframe-zIndex.html
  2952. Walk up the ancestor chain for the full-screen element, marking them as full-screen
  2953. ancestors. Then, we apply a pseudo-class to those elements, which disable all their
  2954. stacking-context-creating styles. Set the z-index of all full-screen elements (and
  2955. the iframes which contain them) to a large value, ensuring they appear above other
  2956. sibling elements.
  2957. This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
  2958. and pesudo-class, so remove it and replace it with the new pseudo-class.
  2959. * css/CSSSelector.cpp:
  2960. (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove
  2961. -webkit-full-screen-media-document.
  2962. (WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove
  2963. PseudoFullScreenMediaDocument
  2964. (WebCore::CSSSelector::extractPseudoType): Ditto.
  2965. * css/CSSSelector.h: Ditto.
  2966. * css/CSSStyleSelector.cpp:
  2967. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the
  2968. PseudoFullScreenMediaDocument implementation and replace it with
  2969. PseudoFullScreenAncestor.
  2970. * css/fullscreen.css:
  2971. (:-webkit-full-screen): Add a z-index property.
  2972. (:-webkit-full-screen-ancestor:not(iframe)): Added. Reset the z-index to
  2973. auto, and reset other stacking-context creating properties.
  2974. * dom/Document.cpp:
  2975. (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element
  2976. instead of just the iframe elements.
  2977. (WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.
  2978. * dom/Element.cpp:
  2979. (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property.
  2980. (WebCore::Element::insertedIntoTree): Ditto.
  2981. (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase.
  2982. (WebCore::Element::setContainsFullScreenElement): Ditto.
  2983. * dom/Element.h:
  2984. * dom/ElementRareData.h:
  2985. (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for
  2986. m_containsFullScreenElement.
  2987. * html/HTMLFrameElementBase.cpp:
  2988. (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer.
  2989. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
  2990. * html/HTMLFrameElementBase.h:
  2991. * rendering/style/RenderStyleConstants.h:
  2992. 2011-05-29 Dan Bernstein <mitz@apple.com>
  2993. Reviewed by Darin Adler.
  2994. <rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
  2995. https://bugs.webkit.org/show_bug.cgi?id=61714
  2996. * dom/Document.cpp:
  2997. (WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
  2998. new full screen element.
  2999. (WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
  3000. the full screen element.
  3001. * dom/Element.h:
  3002. (WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
  3003. (WebCore::Element::willStopBeingFullscreenElement): Ditto.
  3004. * html/HTMLMediaElement.cpp:
  3005. (WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
  3006. MediaControls::enteredFullscreen().
  3007. (WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
  3008. MediaControls::exitedFullscreen().
  3009. * html/HTMLMediaElement.h:
  3010. * html/shadow/MediaControlElements.cpp:
  3011. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
  3012. enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
  3013. changes to the fullscreen-ness of the element.
  3014. 2011-05-29 Darin Adler <darin@apple.com>
  3015. Reviewed by Kevin Decker.
  3016. REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
  3017. https://bugs.webkit.org/show_bug.cgi?id=61713
  3018. We need to come up with a way to regression-test these changes. Nothing at the moment.
  3019. The bug is that we removed calls to preventDefault, but we still do need to prevent
  3020. default handling of this event.
  3021. * html/shadow/MediaControlElements.cpp:
  3022. (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault
  3023. that was in here before r87622 as well as the stopPropagation that was added in r87622.
  3024. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
  3025. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
  3026. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
  3027. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
  3028. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
  3029. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
  3030. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
  3031. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
  3032. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
  3033. 2011-05-29 Andreas Kling <kling@webkit.org>
  3034. Reviewed by Kenneth Rohde Christiansen.
  3035. Element: Micro-cleanup of scroll methods.
  3036. https://bugs.webkit.org/show_bug.cgi?id=61705
  3037. Do an early return without calculating element boundaries when asked
  3038. to scroll an element without a renderer().
  3039. * dom/Element.cpp:
  3040. (WebCore::Element::scrollIntoView):
  3041. (WebCore::Element::scrollIntoViewIfNeeded):
  3042. (WebCore::Element::scrollByUnits):
  3043. 2011-05-29 Darin Adler <darin@apple.com>
  3044. Reviewed by Dan Bernstein.
  3045. Fix assertion seen when entering full screen mode for standalone video
  3046. https://bugs.webkit.org/show_bug.cgi?id=61708
  3047. We don't currently have a way to make a regression test for this.
  3048. * dom/Document.cpp:
  3049. (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc,
  3050. because scheduleStyleRecalc is intended to only be called when the style
  3051. system itself detects recalc is needed.
  3052. 2011-05-27 Andreas Kling <kling@webkit.org>
  3053. Reviewed by James Robinson.
  3054. [Qt] Add area check to ImageBufferData::getImageData()
  3055. https://bugs.webkit.org/show_bug.cgi?id=61375
  3056. No change in behavior, just a sanity check.
  3057. * platform/graphics/qt/ImageBufferQt.cpp:
  3058. (WebCore::getImageData):
  3059. 2011-05-29 Beth Dakin <bdakin@apple.com>
  3060. Reviewed by Darin Adler.
  3061. https://bugs.webkit.org/show_bug.cgi?id=61700
  3062. Need WebKit2 API to get the size of the render tree
  3063. -and corresponding-
  3064. <rdar://problem/9512733>
  3065. New member variable on RenderArena keeps track of the current amount of memory
  3066. allocated in the arena. The new client function sends this piece of data to
  3067. WebKit.
  3068. * page/ChromeClient.h:
  3069. (WebCore::ChromeClient::setRenderTreeSize):
  3070. * page/FrameView.cpp:
  3071. (WebCore::FrameView::performPostLayoutTasks):
  3072. * rendering/RenderArena.cpp:
  3073. (WebCore::RenderArena::RenderArena):
  3074. (WebCore::RenderArena::allocate):
  3075. (WebCore::RenderArena::free):
  3076. * rendering/RenderArena.h:
  3077. (WebCore::RenderArena::totalRenderArenaSize):
  3078. 2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com>
  3079. Unreviewed, rolling out r87566.
  3080. http://trac.webkit.org/changeset/87566
  3081. https://bugs.webkit.org/show_bug.cgi?id=61702
  3082. It made all tests assert on Qt in debug mode (Requested by
  3083. Ossy_weekend on #webkit).
  3084. * WebCore.exp.in:
  3085. * bindings/ScriptControllerBase.cpp:
  3086. (WebCore::ScriptController::executeIfJavaScriptURL):
  3087. * dom/Document.cpp:
  3088. (WebCore::Document::Document):
  3089. (WebCore::Document::suggestedMIMEType):
  3090. (WebCore::Document::lastModified):
  3091. (WebCore::Document::initSecurityContext):
  3092. (WebCore::Document::updateURLForPushOrReplaceState):
  3093. * dom/Document.h:
  3094. (WebCore::Document::setDocumentLoader):
  3095. (WebCore::Document::loader):
  3096. * html/MediaDocument.cpp:
  3097. (WebCore::MediaDocument::replaceMediaElementTimerFired):
  3098. * html/PluginDocument.cpp:
  3099. (WebCore::PluginDocumentParser::createDocumentStructure):
  3100. * platform/mac/HTMLConverter.mm:
  3101. (fileWrapperForElement):
  3102. 2011-05-28 Steve Falkenburg <sfalken@apple.com>
  3103. Reviewed by Dan Bernstein.
  3104. Don't add sub-frames to global history when navigating via back/forward
  3105. https://bugs.webkit.org/show_bug.cgi?id=61701
  3106. <rdar://problem/9521222>
  3107. Instead of just checking whether the load is the first in the frame, we also need to
  3108. check to make sure we're loading in the main frame.
  3109. Not testable due to lack of global history infrastructure in DRT.
  3110. * loader/FrameLoader.cpp:
  3111. (WebCore::FrameLoader::transitionToCommitted):
  3112. 2011-05-28 Alexey Proskuryakov <ap@apple.com>
  3113. Suggested by Simon Fraser.
  3114. REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
  3115. https://bugs.webkit.org/show_bug.cgi?id=61692
  3116. <rdar://problem/9488628>
  3117. * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use
  3118. ASSERT_UNUSED here.
  3119. 2011-05-28 Alexey Proskuryakov <ap@apple.com>
  3120. Reviewed by Geoff Garen.
  3121. REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
  3122. https://bugs.webkit.org/show_bug.cgi?id=61692
  3123. <rdar://problem/9488628>
  3124. Test: fast/dom/gc-image-element-2.html
  3125. Manually verified that tests from bug 59604 and from bug 40926 still pass.
  3126. The problem here was that HTMLImageElement::hasPendingActivity() could return false when
  3127. a load (or error) event was still expected to fire.
  3128. * loader/cache/CachedResource.cpp:
  3129. (WebCore::CachedResource::setRequest):
  3130. * loader/cache/CachedResource.h:
  3131. (WebCore::CachedResource::wasCanceled):
  3132. (WebCore::CachedResource::errorOccurred):
  3133. Track whether the load was canceled. We want to always notify clients of load outcome,
  3134. as that's the only way they could make intelligent decisions.
  3135. * dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now
  3136. get a notifyFinished call on cancellation. Handle this case, where we don't need the
  3137. execute the script, but also don't need to fire an error event.
  3138. * html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single
  3139. function call now.
  3140. * html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large
  3141. window between when CachedResource::isLoading() becomes false and events are queued.
  3142. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting
  3143. an event to fire.
  3144. * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do
  3145. anything on cancellation.
  3146. * loader/ImageLoader.cpp:
  3147. (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to
  3148. give an accurate result while looping over the list of events to dispatch.
  3149. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to
  3150. switch to a broken image icon, or to dispatch events.
  3151. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching
  3152. list, as the event is no longer pending when it's being dispatched.
  3153. * loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one
  3154. is already pending, we only care if one is expected at some time in the future, and
  3155. !haveFiredLoadEvent() is our best idea of that.
  3156. * dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to
  3157. handle cancellation.
  3158. 2011-05-28 Adam Barth <abarth@webkit.org>
  3159. Reviewed by Alexey Proskuryakov.
  3160. Audit all uses of KURL::prettyURL
  3161. https://bugs.webkit.org/show_bug.cgi?id=61201
  3162. As far as I can tell, all the callers of this API are confused. There
  3163. seems to be a cargo cult of using the "pretty" version of a URL, but in
  3164. reality folks just want the URL itself. The only case I'm unsure about
  3165. is location.href, which could have some compatibility constraints.
  3166. I've renamed prettyURL to deprecatedString to discourage folks from
  3167. further cargo-culting.
  3168. * WebCore.exp.in:
  3169. * page/Location.cpp:
  3170. (WebCore::Location::href):
  3171. (WebCore::Location::toString):
  3172. * platform/KURL.cpp:
  3173. (WebCore::KURL::deprecatedString):
  3174. * platform/KURL.h:
  3175. * platform/KURLGoogle.cpp:
  3176. (WebCore::KURL::deprecatedString):
  3177. * platform/network/soup/ResourceHandleSoup.cpp:
  3178. (WebCore::ResourceHandle::prepareForURL):
  3179. * workers/WorkerLocation.cpp:
  3180. (WebCore::WorkerLocation::href):
  3181. (WebCore::WorkerLocation::toString):
  3182. 2011-05-28 Jer Noble <jer.noble@apple.com>
  3183. Reviewed by Maciej Stachowiak.
  3184. Mouse clicks propagate outside full-screen media controls.
  3185. https://bugs.webkit.org/show_bug.cgi?id=61689
  3186. Mouse click events are propagating out of the media controls, so mouse click
  3187. listeners registered on the video element are getting fired when the user
  3188. clicks on media controller buttons. By default, block propagation of click
  3189. events from MediaControlElements by overriding preDispatchEventHandler, and
  3190. convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
  3191. all calls of event->setDefaultHandled() to event->stopPropagation().
  3192. * html/shadow/MediaControlElements.cpp:
  3193. (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block
  3194. propagation of all mouse click events.
  3195. (WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):
  3196. Renamed from setDefaultHandled.
  3197. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
  3198. (WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
  3199. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
  3200. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
  3201. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
  3202. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
  3203. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
  3204. (WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
  3205. (WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
  3206. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
  3207. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
  3208. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
  3209. * html/shadow/MediaControlElements.h:
  3210. 2011-05-28 Gavin Peters <gavinp@chromium.org>
  3211. Reviewed by Adam Barth.
  3212. prevent HTMLLinkElement from watching multiple CachedResources
  3213. https://bugs.webkit.org/show_bug.cgi?id=61686
  3214. If we modify an existing link element, stop listening to the previous
  3215. cached resource, to prevent double notifications (which crash).
  3216. Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
  3217. * html/HTMLLinkElement.cpp:
  3218. (WebCore::HTMLLinkElement::process):
  3219. 2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>
  3220. Reviewed by Pavel Feldman.
  3221. Web Inspector: there is a problem with computed style properties with wrong values
  3222. https://bugs.webkit.org/show_bug.cgi?id=60535
  3223. * inspector/front-end/StylesSidebarPane.js:
  3224. (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
  3225. (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
  3226. 2011-05-26 Antonio Gomes <agomes@rim.com>
  3227. Reviewed by Andreas Kling.
  3228. Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartiallyAligned
  3229. https://bugs.webkit.org/show_bug.cgi?id=61606
  3230. Removed duplicated statement within if condition.
  3231. No new tests. Obvious clean up patch.
  3232. * page/SpatialNavigation.cpp:
  3233. (WebCore::areRectsPartiallyAligned):
  3234. 2011-05-27 Simon Fraser <simon.fraser@apple.com>
  3235. Reviewed by Dan Bernstein.
  3236. CG BitmapImage needs to check for valid CGImage in a couple of places
  3237. https://bugs.webkit.org/show_bug.cgi?id=61684
  3238. <rdar://problem/9519348>
  3239. BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
  3240. returns null, which it may do if the image is corrupted or still
  3241. loading. Protect against that here and in getFirstCGImageRefOfSize().
  3242. * platform/graphics/cg/ImageCG.cpp:
  3243. (WebCore::BitmapImage::getFirstCGImageRefOfSize):
  3244. (WebCore::BitmapImage::getCGImageArray):
  3245. 2011-05-27 Jochen Eisinger <jochen@chromium.org>
  3246. Reviewed by Adam Barth.
  3247. Add Frame parameter to all StorageArea methods. The chromium
  3248. embedder uses the Frame as context to decide whether or not
  3249. to allow usage of the storage API.
  3250. https://bugs.webkit.org/show_bug.cgi?id=61581
  3251. Test: platform/chromium/permissionclient/storage-permission.html
  3252. * storage/Storage.cpp:
  3253. (WebCore::Storage::length):
  3254. (WebCore::Storage::key):
  3255. (WebCore::Storage::getItem):
  3256. (WebCore::Storage::contains):
  3257. * storage/StorageArea.h:
  3258. * storage/StorageAreaImpl.cpp:
  3259. (WebCore::StorageAreaImpl::length):
  3260. (WebCore::StorageAreaImpl::key):
  3261. (WebCore::StorageAreaImpl::getItem):
  3262. (WebCore::StorageAreaImpl::contains):
  3263. * storage/StorageAreaImpl.h:
  3264. 2011-05-27 Nate Chapin <japhet@chromium.org>
  3265. Reviewed by Jian Li.
  3266. Keep a reference to BlobResourceHandle before calling doNotifyFinish()
  3267. asynchronously to ensure it's still safe in the main thread.
  3268. https://bugs.webkit.org/show_bug.cgi?id=61669
  3269. I triggered this crash in fast/files/file-reader-abort.html during a
  3270. refactor that changed timings slightly.
  3271. * platform/network/BlobResourceHandle.cpp:
  3272. (WebCore::doNotifyFinish):
  3273. (WebCore::BlobResourceHandle::notifyFinish):
  3274. * platform/network/BlobResourceHandle.h:
  3275. (WebCore::BlobResourceHandle::aborted):
  3276. 2011-05-27 Stephanie Lewis <slewis@apple.com>
  3277. Unreviewed.
  3278. Fix a typo in the order_file flag.
  3279. * Configurations/Base.xcconfig:
  3280. 2011-05-27 Anders Carlsson <andersca@apple.com>
  3281. Reviewed by Sam Weinig.
  3282. Always use the default localization strategy
  3283. https://bugs.webkit.org/show_bug.cgi?id=61670
  3284. <rdar://problem/9516130>
  3285. Always use the default localization strategy when there's no platform strategy.
  3286. * platform/DefaultLocalizationStrategy.cpp:
  3287. (WebCore::DefaultLocalizationStrategy::shared):
  3288. * platform/DefaultLocalizationStrategy.h:
  3289. * platform/LocalizedStrings.cpp:
  3290. (WebCore::inputElementAltText):
  3291. (WebCore::resetButtonDefaultLabel):
  3292. (WebCore::searchableIndexIntroduction):
  3293. (WebCore::submitButtonDefaultLabel):
  3294. (WebCore::fileButtonChooseFileLabel):
  3295. (WebCore::fileButtonNoFileSelectedLabel):
  3296. (WebCore::defaultDetailsSummaryText):
  3297. (WebCore::copyImageUnknownFileLabel):
  3298. (WebCore::contextMenuItemTagOpenLinkInNewWindow):
  3299. (WebCore::contextMenuItemTagDownloadLinkToDisk):
  3300. (WebCore::contextMenuItemTagCopyLinkToClipboard):
  3301. (WebCore::contextMenuItemTagOpenImageInNewWindow):
  3302. (WebCore::contextMenuItemTagDownloadImageToDisk):
  3303. (WebCore::contextMenuItemTagCopyImageToClipboard):
  3304. (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
  3305. (WebCore::contextMenuItemTagOpenFrameInNewWindow):
  3306. (WebCore::contextMenuItemTagCopy):
  3307. (WebCore::contextMenuItemTagGoBack):
  3308. (WebCore::contextMenuItemTagGoForward):
  3309. (WebCore::contextMenuItemTagStop):
  3310. (WebCore::contextMenuItemTagReload):
  3311. (WebCore::contextMenuItemTagCut):
  3312. (WebCore::contextMenuItemTagPaste):
  3313. (WebCore::contextMenuItemTagSelectAll):
  3314. (WebCore::contextMenuItemTagNoGuessesFound):
  3315. (WebCore::contextMenuItemTagIgnoreSpelling):
  3316. (WebCore::contextMenuItemTagLearnSpelling):
  3317. (WebCore::contextMenuItemTagSearchInSpotlight):
  3318. (WebCore::contextMenuItemTagSearchWeb):
  3319. (WebCore::contextMenuItemTagLookUpInDictionary):
  3320. (WebCore::contextMenuItemTagOpenLink):
  3321. (WebCore::contextMenuItemTagIgnoreGrammar):
  3322. (WebCore::contextMenuItemTagSpellingMenu):
  3323. (WebCore::contextMenuItemTagShowSpellingPanel):
  3324. (WebCore::contextMenuItemTagCheckSpelling):
  3325. (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
  3326. (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
  3327. (WebCore::contextMenuItemTagFontMenu):
  3328. (WebCore::contextMenuItemTagShowFonts):
  3329. (WebCore::contextMenuItemTagBold):
  3330. (WebCore::contextMenuItemTagItalic):
  3331. (WebCore::contextMenuItemTagUnderline):
  3332. (WebCore::contextMenuItemTagOutline):
  3333. (WebCore::contextMenuItemTagStyles):
  3334. (WebCore::contextMenuItemTagShowColors):
  3335. (WebCore::contextMenuItemTagSpeechMenu):
  3336. (WebCore::contextMenuItemTagStartSpeaking):
  3337. (WebCore::contextMenuItemTagStopSpeaking):
  3338. (WebCore::contextMenuItemTagWritingDirectionMenu):
  3339. (WebCore::contextMenuItemTagTextDirectionMenu):
  3340. (WebCore::contextMenuItemTagDefaultDirection):
  3341. (WebCore::contextMenuItemTagLeftToRight):
  3342. (WebCore::contextMenuItemTagRightToLeft):
  3343. (WebCore::contextMenuItemTagCorrectSpellingAutomatically):
  3344. (WebCore::contextMenuItemTagSubstitutionsMenu):
  3345. (WebCore::contextMenuItemTagShowSubstitutions):
  3346. (WebCore::contextMenuItemTagSmartCopyPaste):
  3347. (WebCore::contextMenuItemTagSmartQuotes):
  3348. (WebCore::contextMenuItemTagSmartDashes):
  3349. (WebCore::contextMenuItemTagSmartLinks):
  3350. (WebCore::contextMenuItemTagTextReplacement):
  3351. (WebCore::contextMenuItemTagTransformationsMenu):
  3352. (WebCore::contextMenuItemTagMakeUpperCase):
  3353. (WebCore::contextMenuItemTagMakeLowerCase):
  3354. (WebCore::contextMenuItemTagCapitalize):
  3355. (WebCore::contextMenuItemTagChangeBack):
  3356. (WebCore::contextMenuItemTagOpenVideoInNewWindow):
  3357. (WebCore::contextMenuItemTagOpenAudioInNewWindow):
  3358. (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
  3359. (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
  3360. (WebCore::contextMenuItemTagToggleMediaControls):
  3361. (WebCore::contextMenuItemTagToggleMediaLoop):
  3362. (WebCore::contextMenuItemTagEnterVideoFullscreen):
  3363. (WebCore::contextMenuItemTagMediaPlay):
  3364. (WebCore::contextMenuItemTagMediaPause):
  3365. (WebCore::contextMenuItemTagMediaMute):
  3366. (WebCore::contextMenuItemTagInspectElement):
  3367. (WebCore::searchMenuNoRecentSearchesText):
  3368. (WebCore::searchMenuRecentSearchesText):
  3369. (WebCore::searchMenuClearRecentSearchesText):
  3370. (WebCore::AXWebAreaText):
  3371. (WebCore::AXLinkText):
  3372. (WebCore::AXListMarkerText):
  3373. (WebCore::AXImageMapText):
  3374. (WebCore::AXHeadingText):
  3375. (WebCore::AXDefinitionListTermText):
  3376. (WebCore::AXDefinitionListDefinitionText):
  3377. (WebCore::AXARIAContentGroupText):
  3378. (WebCore::AXButtonActionVerb):
  3379. (WebCore::AXRadioButtonActionVerb):
  3380. (WebCore::AXTextFieldActionVerb):
  3381. (WebCore::AXCheckedCheckBoxActionVerb):
  3382. (WebCore::AXUncheckedCheckBoxActionVerb):
  3383. (WebCore::AXLinkActionVerb):
  3384. (WebCore::AXMenuListPopupActionVerb):
  3385. (WebCore::AXMenuListActionVerb):
  3386. (WebCore::missingPluginText):
  3387. (WebCore::crashedPluginText):
  3388. (WebCore::multipleFileUploadText):
  3389. (WebCore::unknownFileSizeText):
  3390. (WebCore::uploadFileText):
  3391. (WebCore::allFilesText):
  3392. (WebCore::keygenMenuItem512):
  3393. (WebCore::keygenMenuItem1024):
  3394. (WebCore::keygenMenuItem2048):
  3395. (WebCore::keygenKeychainItemName):
  3396. (WebCore::imageTitle):
  3397. (WebCore::mediaElementLoadingStateText):
  3398. (WebCore::mediaElementLiveBroadcastStateText):
  3399. (WebCore::localizedMediaControlElementString):
  3400. (WebCore::localizedMediaControlElementHelpText):
  3401. (WebCore::localizedMediaTimeDescription):
  3402. (WebCore::validationMessageValueMissingText):
  3403. (WebCore::validationMessageValueMissingForCheckboxText):
  3404. (WebCore::validationMessageValueMissingForFileText):
  3405. (WebCore::validationMessageValueMissingForMultipleFileText):
  3406. (WebCore::validationMessageValueMissingForRadioText):
  3407. (WebCore::validationMessageValueMissingForSelectText):
  3408. (WebCore::validationMessageTypeMismatchText):
  3409. (WebCore::validationMessageTypeMismatchForEmailText):
  3410. (WebCore::validationMessageTypeMismatchForMultipleEmailText):
  3411. (WebCore::validationMessageTypeMismatchForURLText):
  3412. (WebCore::validationMessagePatternMismatchText):
  3413. (WebCore::validationMessageTooLongText):
  3414. (WebCore::validationMessageRangeUnderflowText):
  3415. (WebCore::validationMessageRangeOverflowText):
  3416. (WebCore::validationMessageStepMismatchText):
  3417. 2011-05-27 Brady Eidson <beidson@apple.com>
  3418. Reviewed by Darin Adler.
  3419. First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
  3420. Make the Document be intelligent about returning its DocumentLoader, including the possibility that
  3421. the DocumentLoader will be null.
  3422. No new tests. No change in behavior.
  3423. Instead of storing the DocumentLoader at construction and never changing it,
  3424. always calculate it based on the FrameLoader's current DocumentLoader:
  3425. * dom/Document.cpp:
  3426. (WebCore::Document::Document):
  3427. (WebCore::Document::suggestedMIMEType):
  3428. (WebCore::Document::lastModified):
  3429. (WebCore::Document::initSecurityContext):
  3430. (WebCore::Document::updateURLForPushOrReplaceState):
  3431. (WebCore::Document::loader):
  3432. * dom/Document.h:
  3433. Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
  3434. * bindings/ScriptControllerBase.cpp:
  3435. (WebCore::ScriptController::executeIfJavaScriptURL):
  3436. * html/MediaDocument.cpp:
  3437. (WebCore::MediaDocument::replaceMediaElementTimerFired):
  3438. * html/PluginDocument.cpp:
  3439. (WebCore::PluginDocumentParser::createDocumentStructure):
  3440. * platform/mac/HTMLConverter.mm:
  3441. (fileWrapperForElement):
  3442. * WebCore.exp.in:
  3443. 2011-05-27 Jer Noble <jer.noble@apple.com>
  3444. Reviewed by Maciej Stachowiak.
  3445. 30 second rewind button obscured in fullscreen controller
  3446. https://bugs.webkit.org/show_bug.cgi?id=61663
  3447. If reset() is called while in full-screen mode, make sure to show and hide
  3448. the correct controls for that mode.
  3449. * html/shadow/MediaControlRootElement.cpp:
  3450. (WebCore::MediaControlRootElement::reset):
  3451. 2011-05-27 James Robinson <jamesr@chromium.org>
  3452. Reviewed by Simon Fraser.
  3453. GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
  3454. https://bugs.webkit.org/show_bug.cgi?id=61590
  3455. Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
  3456. backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
  3457. in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
  3458. graphics layer tree consistent.
  3459. Test: compositing/iframes/resizer.html
  3460. * rendering/RenderLayerCompositor.cpp:
  3461. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  3462. 2011-05-27 Adam Barth <abarth@webkit.org>
  3463. Reviewed by Eric Seidel.
  3464. HTMLVideoElement::currentSrc() should return a KURL
  3465. https://bugs.webkit.org/show_bug.cgi?id=61578
  3466. I suspect we got into this mess because the author of this code didn't
  3467. know about the URL attribute in WebKit IDL, which is super useful!
  3468. Bad news: The line of code in question seems to have another bug, which
  3469. I've documented in a FIXME. Let the yak shaving continue!
  3470. * html/HTMLMediaElement.cpp:
  3471. (WebCore::urlForLogging):
  3472. (WebCore::HTMLMediaElement::loadResource):
  3473. (WebCore::HTMLMediaElement::isSafeToLoadURL):
  3474. (WebCore::HTMLMediaElement::selectNextSourceChild):
  3475. (WebCore::HTMLMediaElement::getPluginProxyParams):
  3476. * html/HTMLMediaElement.h:
  3477. (WebCore::HTMLMediaElement::currentSrc):
  3478. (WebCore::HTMLMediaElement::currentURL):
  3479. * html/canvas/CanvasRenderingContext.cpp:
  3480. (WebCore::CanvasRenderingContext::checkOrigin):
  3481. * rendering/HitTestResult.cpp:
  3482. (WebCore::HitTestResult::absoluteMediaURL):
  3483. - This complete URL call was unnecessary because currentSrc is
  3484. already absolute.
  3485. 2011-05-27 Mikhail Naganov <mnaganov@chromium.org>
  3486. Reviewed by Pavel Feldman.
  3487. Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
  3488. https://bugs.webkit.org/show_bug.cgi?id=61177
  3489. * inspector/front-end/HeapSnapshot.js:
  3490. (WebInspector.HeapSnapshotNode.prototype.get className):
  3491. 2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
  3492. Rubber-stamped by Rob Buis.
  3493. embedded SVG object doesn't scale right
  3494. https://bugs.webkit.org/show_bug.cgi?id=10526
  3495. Fixes crash in svg/custom/immutable-properties.html, seen on the bots.
  3496. * svg/SVGLength.cpp:
  3497. (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
  3498. 2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
  3499. Reviewed by Rob Buis.
  3500. embedded SVG object doesn't scale right
  3501. https://bugs.webkit.org/show_bug.cgi?id=10526
  3502. <object> tags should treat width/height on a referenced SVG as intrinsic width/height
  3503. https://bugs.webkit.org/show_bug.cgi?id=11976
  3504. Incorrect handling of percentage values for width/height on embedded elements
  3505. https://bugs.webkit.org/show_bug.cgi?id=14793
  3506. WebKit fails some WICD 1.0 core test cases
  3507. https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)
  3508. CSS 2.1: Support replaced elements with relative intrinsic sizes
  3509. https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)
  3510. SVG embedded as <object> doesn't respect width/height attributes
  3511. https://bugs.webkit.org/show_bug.cgi?id=34972
  3512. Explicit size of object tag ignored
  3513. https://bugs.webkit.org/show_bug.cgi?id=37086
  3514. Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
  3515. been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
  3516. The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).
  3517. SVG 1.1 says:
  3518. The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
  3519. ...
  3520. and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
  3521. or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
  3522. the positioning properties establish the viewport's width.
  3523. If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
  3524. width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
  3525. on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
  3526. This requires a negotiation between the host document and the embedded document.
  3527. (There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)
  3528. Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".
  3529. Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml
  3530. svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
  3531. svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
  3532. svg/custom/object-sizing-explicit-width-height.xhtml
  3533. svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
  3534. svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
  3535. svg/custom/object-sizing-no-width-height.xhtml
  3536. svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
  3537. svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
  3538. svg/wicd/test-rightsizing-a.xhtml (ditto)
  3539. svg/wicd/test-rightsizing-b.xhtml (ditto)
  3540. svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
  3541. svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
  3542. svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
  3543. svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
  3544. svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
  3545. svg/zoom/page/zoom-svg-through-object-with-text.xhtml
  3546. * platform/Length.h:
  3547. (WebCore::Length::isSpecified):
  3548. * rendering/RenderPart.cpp:
  3549. (WebCore::RenderPart::embeddedSVGContentRenderer):
  3550. (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
  3551. (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
  3552. (WebCore::RenderPart::computeReplacedLogicalWidth):
  3553. (WebCore::RenderPart::computeReplacedLogicalHeight):
  3554. (WebCore::RenderPart::layout):
  3555. * rendering/RenderPart.h:
  3556. * rendering/RenderReplaced.cpp:
  3557. (WebCore::RenderReplaced::computeReplacedLogicalWidth):
  3558. (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  3559. * rendering/svg/RenderSVGRoot.cpp:
  3560. (WebCore::RenderSVGRoot::RenderSVGRoot):
  3561. (WebCore::RenderSVGRoot::computeIntrinsicRatio):
  3562. (WebCore::RenderSVGRoot::computeIntrinsicWidth):
  3563. (WebCore::RenderSVGRoot::computeIntrinsicHeight):
  3564. (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded):
  3565. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
  3566. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
  3567. (WebCore::RenderSVGRoot::layout):
  3568. * rendering/svg/RenderSVGRoot.h:
  3569. * svg/SVGLength.cpp:
  3570. (WebCore::SVGLength::determineViewport):
  3571. * svg/SVGSVGElement.cpp:
  3572. (WebCore::SVGSVGElement::currentScale):
  3573. (WebCore::SVGSVGElement::setCurrentScale):
  3574. (WebCore::SVGSVGElement::currentViewBoxRect):
  3575. (WebCore::SVGSVGElement::viewBoxToViewTransform):
  3576. * svg/SVGSVGElement.h:
  3577. 2011-05-27 Michael Saboff <msaboff@apple.com>
  3578. Reviewed by David Hyatt.
  3579. https://bugs.webkit.org/show_bug.cgi?id=61646
  3580. Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font
  3581. Change the platformIsEqual to just compare the m_font members if
  3582. either is not null.
  3583. No tests added - functionality unchanged, fixing memory abandonment.
  3584. * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  3585. (WebCore::FontPlatformData::platformIsEqual):
  3586. 2011-05-25 Martin Robinson <mrobinson@igalia.com>
  3587. Reviewed by Dirk Schulze.
  3588. [GTK][Cairo] Twitter rendering breaks
  3589. https://bugs.webkit.org/show_bug.cgi?id=60917
  3590. When instantiating a cairo_scaled_font_t font would put the font in an error state,
  3591. leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
  3592. in the error state can later lead to corrupted rendering.
  3593. Due to this change, we must always null check cairo_scaled_font_t and the platform
  3594. data now carries the cairo_font_face_t object with it, so that it can be accessed later
  3595. if there is no cairo_scaled_font_t.
  3596. Test: platform/gtk/fonts/zero-pixel-sized-fonts.html
  3597. * platform/graphics/cairo/FontCairo.cpp:
  3598. (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
  3599. * platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
  3600. * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  3601. (WebCore::FontPlatformData::FontPlatformData): Initialize the new member.
  3602. (WebCore::FontPlatformData::operator=): Carry over the new member.
  3603. (WebCore::FontPlatformData::operator==): Check equality with the new member.
  3604. (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont
  3605. put the font into an error state, then just free it and return.
  3606. (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap
  3607. when the scaled font is null, because rendering is always a no-op and the font data never
  3608. needs to be read.
  3609. * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
  3610. (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
  3611. * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  3612. (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font.
  3613. (WebCore::SimpleFontData::scaledFontData): Use the new m_font member.
  3614. (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font.
  3615. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
  3616. 2011-05-27 David Levin <levin@chromium.org>
  3617. Reviewed by Darin Fisher.
  3618. Need a callback for when the preferred rendered size may have changed.
  3619. https://bugs.webkit.org/show_bug.cgi?id=61309
  3620. No new tests needed since no new functionality is exposed.
  3621. * page/Chrome.cpp:
  3622. (WebCore::Chrome::layoutUpdated): Plumbed through the call.
  3623. * page/Chrome.h: Added the new method.
  3624. * page/ChromeClient.h:
  3625. (WebCore::ChromeClient::layoutUpdated): Ditto.
  3626. * page/FrameView.cpp:
  3627. (WebCore::FrameView::layout): Added a callback for whem a layout has finished.
  3628. 2011-05-27 Stephanie Lewis <slewis@apple.com>
  3629. Rubber Stamped by Adam Roben.
  3630. Update Order Files. Use -order_file flag since it can order more of the binary.
  3631. * Configurations/Base.xcconfig:
  3632. * WebCore.order:
  3633. 2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
  3634. Unreviewed, rolling out r87464.
  3635. http://trac.webkit.org/changeset/87464
  3636. https://bugs.webkit.org/show_bug.cgi?id=61643
  3637. client-close/server-close tests are flaky on Chromium Mac and
  3638. Windows (Requested by aklein on #webkit).
  3639. * platform/network/SocketStreamHandleBase.cpp:
  3640. (WebCore::SocketStreamHandleBase::send):
  3641. (WebCore::SocketStreamHandleBase::close):
  3642. (WebCore::SocketStreamHandleBase::sendPendingData):
  3643. * platform/network/SocketStreamHandleBase.h:
  3644. * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
  3645. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  3646. (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  3647. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  3648. * websockets/WebSocket.cpp:
  3649. (WebCore::WebSocket::send):
  3650. (WebCore::WebSocket::close):
  3651. (WebCore::WebSocket::bufferedAmount):
  3652. (WebCore::WebSocket::didConnect):
  3653. (WebCore::WebSocket::didReceiveMessage):
  3654. (WebCore::WebSocket::didReceiveMessageError):
  3655. (WebCore::WebSocket::didClose):
  3656. * websockets/WebSocket.h:
  3657. * websockets/WebSocketChannel.cpp:
  3658. (WebCore::WebSocketChannel::WebSocketChannel):
  3659. (WebCore::WebSocketChannel::close):
  3660. (WebCore::WebSocketChannel::disconnect):
  3661. (WebCore::WebSocketChannel::didClose):
  3662. (WebCore::WebSocketChannel::didReceiveData):
  3663. (WebCore::WebSocketChannel::didFail):
  3664. (WebCore::WebSocketChannel::processBuffer):
  3665. * websockets/WebSocketChannel.h:
  3666. * websockets/WebSocketChannelClient.h:
  3667. (WebCore::WebSocketChannelClient::didClose):
  3668. * websockets/WorkerThreadableWebSocketChannel.cpp:
  3669. (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
  3670. (WebCore::workerContextDidClose):
  3671. (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  3672. * websockets/WorkerThreadableWebSocketChannel.h:
  3673. 2011-05-27 Rob Buis <rbuis@rim.com>
  3674. Reviewed by Nikolas Zimmermann.
  3675. https://bugs.webkit.org/show_bug.cgi?id=19995
  3676. hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.
  3677. Only allow links to animation elements within the document.
  3678. Test: svg/hixie/links/003.xml
  3679. * svg/SVGAElement.cpp:
  3680. (WebCore::SVGAElement::defaultEventHandler):
  3681. 2011-05-27 Andreas Kling <kling@webkit.org>
  3682. Reviewed by Benjamin Poulain.
  3683. Update RGBA color serialization to match HTML5.
  3684. https://bugs.webkit.org/show_bug.cgi?id=61449
  3685. HTML5 now specifies that fully transparent colors should have their alpha value
  3686. serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)
  3687. The number of decimals for alpha values between 0 and 1 is not specified,
  3688. so match Gecko and Presto by returning the lowest number of decimals needed
  3689. to represent the number. (No more trailing zeroes.)
  3690. * platform/graphics/Color.cpp:
  3691. (WebCore::Color::serialized):
  3692. 2011-05-27 Hans Wennborg <hans@chromium.org>
  3693. Reviewed by Tony Gentilcore.
  3694. IndexedDB: Support mutating cursors on top of LevelDB
  3695. https://bugs.webkit.org/show_bug.cgi?id=61615
  3696. We need to support the case where a new node is added to the tree in a
  3697. transaction after the TreeIterator has covered the whole tree.
  3698. Since this is done lazily, i.e. we set a flag that the tree might have
  3699. changed, and act upon it later, some members need to be mutable,
  3700. because we might need to re-seek the tree iterator in a const function.
  3701. Test: storage/indexeddb/mutating-cursor.html
  3702. storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)
  3703. * platform/leveldb/LevelDBTransaction.cpp:
  3704. (WebCore::LevelDBTransaction::set):
  3705. (WebCore::LevelDBTransaction::TreeIterator::reset):
  3706. (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator):
  3707. (WebCore::LevelDBTransaction::TreeIterator::TreeIterator):
  3708. (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):
  3709. (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
  3710. (WebCore::LevelDBTransaction::TransactionIterator::next):
  3711. (WebCore::LevelDBTransaction::TransactionIterator::prev):
  3712. (WebCore::LevelDBTransaction::TransactionIterator::key):
  3713. (WebCore::LevelDBTransaction::TransactionIterator::value):
  3714. (WebCore::LevelDBTransaction::TransactionIterator::treeChanged):
  3715. (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
  3716. (WebCore::LevelDBTransaction::registerIterator):
  3717. (WebCore::LevelDBTransaction::unregisterIterator):
  3718. (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
  3719. * platform/leveldb/LevelDBTransaction.h:
  3720. * storage/IDBFactoryBackendImpl.cpp:
  3721. (WebCore::IDBFactoryBackendImpl::open):
  3722. * storage/IDBLevelDBBackingStore.cpp:
  3723. (WebCore::IDBLevelDBBackingStore::open):
  3724. 2011-05-27 Sujin Park <sujjin.park@gmail.com>
  3725. Unreviewed, buildfix if --no-javascript-debugger.
  3726. Regression(R84125): Broke GTK build
  3727. https://bugs.webkit.org/show_bug.cgi?id=60698
  3728. No new tests since this doesn't change any behavior.
  3729. * inspector/WorkerInspectorController.h:
  3730. 2011-05-26 Yael Aharon <yael.aharon@nokia.com>
  3731. Reviewed by Tony Chang.
  3732. webkit should implement the dropzone attribute
  3733. https://bugs.webkit.org/show_bug.cgi?id=58210
  3734. Add support for dropzone attribute.
  3735. http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
  3736. If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
  3737. If there is such an element, and it matches the drag data store, set the action defined by that
  3738. element and continue processing the drag and drop operation.
  3739. Tests: fast/events/dropzone-001.html
  3740. fast/events/dropzone-002.html
  3741. fast/events/dropzone-003.html
  3742. fast/events/dropzone-004.html
  3743. * dom/Clipboard.cpp:
  3744. (WebCore::Clipboard::hasFileOfType):
  3745. (WebCore::Clipboard::hasStringOfType):
  3746. (WebCore::convertDropZoneOperationToDragOperation):
  3747. (WebCore::convertDragOperationToDropZoneOperation):
  3748. (WebCore::Clipboard::processDropZoneKeyword):
  3749. * dom/Clipboard.h:
  3750. * html/HTMLAttributeNames.in:
  3751. * html/HTMLElement.idl:
  3752. * page/EventHandler.cpp:
  3753. (WebCore::EventHandler::findDropZone):
  3754. (WebCore::EventHandler::updateDragAndDrop):
  3755. * page/EventHandler.h:
  3756. 2011-05-27 Patrick Gansterer <paroga@webkit.org>
  3757. Unreviewed WinCE build fix for r87467.
  3758. * page/wince/FrameWinCE.cpp:
  3759. 2011-05-26 Hans Wennborg <hans@chromium.org>
  3760. Reviewed by Tony Gentilcore.
  3761. IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
  3762. https://bugs.webkit.org/show_bug.cgi?id=61517
  3763. Support cursors where the direction is set to NEXT_NO_DUPLICATE,
  3764. or PREV_NO_DUPLICATE, as specified here:
  3765. http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE
  3766. This is tested by storage/indexeddb/mozilla/indexes.html
  3767. * storage/IDBLevelDBBackingStore.cpp:
  3768. (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
  3769. (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
  3770. (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  3771. 2011-05-26 Hans Wennborg <hans@chromium.org>
  3772. Reviewed by Tony Gentilcore.
  3773. LevelDB: turn on paranoid checks and verify checksums, log errors
  3774. https://bugs.webkit.org/show_bug.cgi?id=61516
  3775. This allows for detection of corrupted databases.
  3776. Even if we can't recover from a corrupted database, discovering the
  3777. problem is a step in the right direction.
  3778. No new functionality, no new tests.
  3779. * platform/leveldb/LevelDBDatabase.cpp:
  3780. (WebCore::LevelDBDatabase::open):
  3781. (WebCore::LevelDBDatabase::put):
  3782. (WebCore::LevelDBDatabase::remove):
  3783. (WebCore::LevelDBDatabase::get):
  3784. (WebCore::LevelDBDatabase::write):
  3785. (WebCore::IteratorImpl::checkStatus):
  3786. (WebCore::IteratorImpl::seekToLast):
  3787. (WebCore::IteratorImpl::seek):
  3788. (WebCore::IteratorImpl::next):
  3789. (WebCore::IteratorImpl::prev):
  3790. (WebCore::LevelDBDatabase::createIterator):
  3791. 2011-05-27 James Robinson <jamesr@chromium.org>
  3792. Reviewed by Adam Barth.
  3793. CachedResourceLoader stores data: urls in validated URL set
  3794. https://bugs.webkit.org/show_bug.cgi?id=61604
  3795. CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
  3796. multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
  3797. memory.
  3798. * loader/cache/CachedResourceLoader.cpp:
  3799. (WebCore::CachedResourceLoader::revalidateResource):
  3800. (WebCore::CachedResourceLoader::loadResource):
  3801. 2011-05-23 MORITA Hajime <morrita@google.com>
  3802. Reviewed by Tony Chang.
  3803. [Refactoring] DocumentMarker should be carried around as a pointer, not value.
  3804. https://bugs.webkit.org/show_bug.cgi?id=61262
  3805. - Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
  3806. - Introduced markersFor() that returns Vector<DocumentMarker*>
  3807. - Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by
  3808. RenderedDocumentMarker::setRenderedRect().
  3809. - This change didn't remove markersForNode() beucase there is patches on review which depends
  3810. markersForNode(). I'll remove its call after these patches are landed.
  3811. No new tests. No behavior change.
  3812. * WebCore.exp.in:
  3813. * dom/DocumentMarkerController.cpp:
  3814. (WebCore::DocumentMarkerController::addTextMatchMarker):
  3815. (WebCore::DocumentMarkerController::markersFor):
  3816. (WebCore::DocumentMarkerController::markersInRange):
  3817. (WebCore::DocumentMarkerController::hasMarkers):
  3818. * dom/DocumentMarkerController.h:
  3819. * dom/RenderedDocumentMarker.h:
  3820. (WebCore::toRenderedDocumentMarker):
  3821. * editing/CompositeEditCommand.cpp:
  3822. (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  3823. * editing/DeleteSelectionCommand.cpp:
  3824. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  3825. * editing/Editor.cpp:
  3826. (WebCore::Editor::selectionStartHasMarkerFor):
  3827. * editing/SpellingCorrectionController.cpp:
  3828. (WebCore::markersHaveIdenticalDescription):
  3829. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  3830. (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  3831. (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  3832. * editing/SpellingCorrectionController.h:
  3833. (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  3834. * rendering/InlineTextBox.cpp:
  3835. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  3836. (WebCore::InlineTextBox::paintTextMatchMarker):
  3837. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  3838. (WebCore::InlineTextBox::paintDocumentMarkers):
  3839. * rendering/InlineTextBox.h:
  3840. * rendering/svg/SVGInlineFlowBox.cpp:
  3841. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  3842. 2011-05-26 MORITA Hajime <morrita@google.com>
  3843. Reviewed by Kent Tamura.
  3844. WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
  3845. https://bugs.webkit.org/show_bug.cgi?id=61511
  3846. Removed Unnecessary wrong cast to Elmement, which can be non-Element.
  3847. Test: fast/html/details-summary-document-child.html
  3848. * html/HTMLSummaryElement.cpp:
  3849. (WebCore::HTMLSummaryElement::detailsElement):
  3850. 2011-05-26 Adam Barth <abarth@webkit.org>
  3851. Reviewed by Ryosuke Niwa.
  3852. FrameLoader cannot be null
  3853. https://bugs.webkit.org/show_bug.cgi?id=61609
  3854. This code has a bunch of cargo-cult null checking.
  3855. * html/HTMLMediaElement.cpp:
  3856. (WebCore::HTMLMediaElement::createRenderer):
  3857. (WebCore::HTMLMediaElement::attach):
  3858. (WebCore::HTMLMediaElement::loadResource):
  3859. (WebCore::HTMLMediaElement::getPluginProxyParams):
  3860. (WebCore::HTMLMediaElement::createMediaPlayerProxy):
  3861. (WebCore::HTMLMediaElement::updateWidget):
  3862. 2011-05-26 Shane Stephens <shanestephens@google.com>
  3863. Reviewed by James Robinson.
  3864. REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
  3865. https://bugs.webkit.org/show_bug.cgi?id=60689
  3866. When a transform is modified in a style, we were upgrading our understanding
  3867. of the difference from PositionedMovementOnly to SimplifiedLayout. However,
  3868. if the position of the style is independently changed at the same time, both
  3869. PositionedMovement and SimplifiedLayout passes are required.
  3870. Test: transforms/2d/set-transform-and-top.html
  3871. * rendering/RenderObject.cpp:
  3872. Added checks for SimplifiedLayoutAndPositionedMovement - when encountered,
  3873. set both PositionedMovement and SimplifiedLayout update flasgs.
  3874. * rendering/style/RenderStyleConstants.h:
  3875. Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for
  3876. cases when both PositionedMovement and SimplifiedLayout are required.
  3877. 2011-05-26 Luke Macpherson <macpherson@chromium.org>
  3878. Reviewed by Eric Seidel.
  3879. Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
  3880. https://bugs.webkit.org/show_bug.cgi?id=61589
  3881. No new tests as no new functionality added.
  3882. * css/CSSStyleApplyProperty.cpp:
  3883. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  3884. Add handlers for:
  3885. CSSPropertyWebkitMarginBeforeCollapse
  3886. CSSPropertyWebkitMarginAfterCollapse
  3887. CSSPropertyWebkitMarginTopCollapse
  3888. CSSPropertyWebkitMarginBottomCollapse
  3889. CSSPropertyWebkitMarginCollapse
  3890. * css/CSSStyleSelector.cpp:
  3891. (WebCore::CSSStyleSelector::applyProperty):
  3892. Remove cases that are no longer required.
  3893. 2011-05-26 Adam Barth <abarth@webkit.org>
  3894. Reviewed by Eric Seidel.
  3895. Support cross-origin property for images
  3896. https://bugs.webkit.org/show_bug.cgi?id=61015
  3897. This patch add support for the crossorigin attribute of images and
  3898. teaches 2D canvas to respect that flag and not taint a canvas if the
  3899. image drawn on the canvas is allowed by CORS.
  3900. While I was editing this code, I couldn't resist a couple touch-up
  3901. changes.
  3902. Tests: http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html
  3903. http/tests/security/canvas-remote-read-remote-image-allowed.html
  3904. http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html
  3905. * html/HTMLAttributeNames.in:
  3906. * html/HTMLCanvasElement.cpp:
  3907. (WebCore::HTMLCanvasElement::securityOrigin):
  3908. * html/HTMLCanvasElement.h:
  3909. * html/HTMLImageElement.idl:
  3910. * html/canvas/CanvasRenderingContext.cpp:
  3911. (WebCore::CanvasRenderingContext::checkOrigin):
  3912. * html/canvas/CanvasRenderingContext2D.cpp:
  3913. (WebCore::CanvasRenderingContext2D::createPattern):
  3914. * loader/ImageLoader.cpp:
  3915. (WebCore::ImageLoader::updateFromElement):
  3916. * loader/cache/CachedResource.cpp:
  3917. (WebCore::CachedResource::passesAccessControlCheck):
  3918. * loader/cache/CachedResource.h:
  3919. 2011-05-26 Mihai Parparita <mihaip@chromium.org>
  3920. Reviewed by Adam Barth.
  3921. Fix worldID and destinationDomain argument names
  3922. https://bugs.webkit.org/show_bug.cgi?id=61571
  3923. As part of working on r87423, I noticed a couple of inconsistencies in
  3924. argument names:
  3925. - We would use worldId in .h files but worldID in .cpp files.
  3926. Standardize on the latter
  3927. - SecurityOrigin::addOriginAccessWhitelistEntry would take a
  3928. destinationDomains argument, even though the actual parameter was for
  3929. a single domain (renamed to be singular).
  3930. * bindings/v8/ScriptController.h:
  3931. * bindings/v8/V8Proxy.h:
  3932. * page/SecurityOrigin.cpp:
  3933. (WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
  3934. (WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
  3935. * page/SecurityOrigin.h:
  3936. 2011-05-26 Emil A Eklund <eae@chromium.org>
  3937. Reviewed by Eric Seidel.
  3938. Replace RenderLayer::x/y/width/height with location/size
  3939. https://bugs.webkit.org/show_bug.cgi?id=61414
  3940. Covered by existing tests.
  3941. * dom/MouseRelatedEvent.cpp:
  3942. (WebCore::MouseRelatedEvent::computeRelativePosition):
  3943. * rendering/RenderBox.cpp:
  3944. (WebCore::RenderBox::computeRectForRepaint):
  3945. * rendering/RenderBox.h:
  3946. (WebCore::RenderBox::maxLayoutOverflow):
  3947. * rendering/RenderInline.cpp:
  3948. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  3949. (WebCore::RenderInline::computeRectForRepaint):
  3950. * rendering/RenderLayer.cpp:
  3951. (WebCore::RenderLayer::updateLayerPosition):
  3952. (WebCore::RenderLayer::convertToLayerCoords):
  3953. (WebCore::RenderLayer::offsetFromResizeCorner):
  3954. (WebCore::RenderLayer::calculateRects):
  3955. * rendering/RenderLayer.h:
  3956. (WebCore::RenderLayer::location):
  3957. (WebCore::RenderLayer::setSize):
  3958. * rendering/RenderObject.cpp:
  3959. (WebCore::RenderObject::computeRectForRepaint):
  3960. * rendering/RenderTreeAsText.cpp:
  3961. (WebCore::write):
  3962. (WebCore::writeLayers):
  3963. (WebCore::externalRepresentation):
  3964. * rendering/RenderView.cpp:
  3965. (WebCore::RenderView::absoluteRects):
  3966. (WebCore::RenderView::absoluteQuads):
  3967. 2011-05-26 Annie Sullivan <sullivan@chromium.org>
  3968. Reviewed by Ryosuke Niwa.
  3969. Delete table in contentEditable/designMode produces odd contents
  3970. https://bugs.webkit.org/show_bug.cgi?id=57148
  3971. Removes border-collapse, -webkit-border-horizontal-spacing, and
  3972. -webkit-border-vertical-spacing from the list of properties which
  3973. should be preserved during edit operations. Also renames this
  3974. list to editingInheritableProperties to be more clear about what
  3975. the list is for.
  3976. Test: editing/deleting/delete-last-char-in-table.html
  3977. * editing/EditingStyle.cpp: Removes border vertical/horizontal
  3978. spacing from editingStyleProperties.
  3979. * editing/EditingStyle.h: Renames OnlyInheritableProperties to
  3980. OnlyEditingInheritableProperties.
  3981. * editing/markup.cpp: Renames InheritablePropertiesAndBackgroundColorInEffect.
  3982. 2011-05-26 Yuta Kitamura <yutak@chromium.org>
  3983. Reviewed by Kent Tamura.
  3984. WebSocket closing handshake
  3985. https://bugs.webkit.org/show_bug.cgi?id=35721
  3986. Implement WebSocket closing handshake based on Ian Hickson's
  3987. WebSocket protocol draft 76.
  3988. Tests: http/tests/websocket/tests/client-close.html
  3989. http/tests/websocket/tests/server-close.html
  3990. * platform/network/SocketStreamHandleBase.cpp:
  3991. (WebCore::SocketStreamHandleBase::send):
  3992. Do not send a message if we are in Closing state.
  3993. (WebCore::SocketStreamHandleBase::close):
  3994. Do not disconnect if we have pending data which have not been sent yet.
  3995. In this case, the actual disconnection will happen in sendPendingData().
  3996. (WebCore::SocketStreamHandleBase::disconnect):
  3997. Renamed from close(). Disconnect the connection immediately.
  3998. (WebCore::SocketStreamHandleBase::sendPendingData):
  3999. * platform/network/SocketStreamHandleBase.h:
  4000. * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
  4001. Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
  4002. to didClose().
  4003. (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
  4004. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  4005. (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
  4006. (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  4007. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  4008. * websockets/WebSocket.cpp:
  4009. (WebCore::WebSocket::send):
  4010. (WebCore::WebSocket::close):
  4011. Fail if close() is attempted before the connection is established.
  4012. Otherwise, set the state to CLOSING and start the closing handshake.
  4013. (WebCore::WebSocket::bufferedAmount):
  4014. If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
  4015. (WebCore::WebSocket::didConnect):
  4016. (WebCore::WebSocket::didReceiveMessage):
  4017. We need to invoke message event in CLOSING state as well as OPEN state.
  4018. (WebCore::WebSocket::didReceiveMessageError):
  4019. (WebCore::WebSocket::didStartClosingHandshake):
  4020. (WebCore::WebSocket::didClose):
  4021. * websockets/WebSocket.h:
  4022. * websockets/WebSocketChannel.cpp:
  4023. (WebCore::WebSocketChannel::WebSocketChannel):
  4024. (WebCore::WebSocketChannel::close):
  4025. Start the closing handshake.
  4026. (WebCore::WebSocketChannel::disconnect):
  4027. Disconnect the socket stream, instead of close.
  4028. (WebCore::WebSocketChannel::didClose):
  4029. (WebCore::WebSocketChannel::didReceiveData): Ditto.
  4030. (WebCore::WebSocketChannel::didFail): Ditto.
  4031. (WebCore::WebSocketChannel::processBuffer):
  4032. Ditto.
  4033. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
  4034. (WebCore::WebSocketChannel::startClosingHandshake):
  4035. Send 0xFF 0x00 byte sequence.
  4036. (WebCore::WebSocketChannel::closingTimerFired):
  4037. Disconnect the socket stream if the closing handshake has timed out.
  4038. * websockets/WebSocketChannel.h:
  4039. m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
  4040. specification).
  4041. * websockets/WebSocketChannelClient.h:
  4042. (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
  4043. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  4044. * websockets/WorkerThreadableWebSocketChannel.cpp:
  4045. Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
  4046. (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
  4047. (WebCore::workerContextDidStartClosingHandshake):
  4048. (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
  4049. (WebCore::workerContextDidClose):
  4050. (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  4051. * websockets/WorkerThreadableWebSocketChannel.h:
  4052. 2011-05-26 David Levin <levin@chromium.org>
  4053. Reviewed by Dmitry Titov.
  4054. WebKit's font notification has problems when the WebKit main thread != UI thread.
  4055. https://bugs.webkit.org/show_bug.cgi?id=61391
  4056. This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
  4057. some time to write correctly. In the meantime, this issues happens to be causing
  4058. some crashes in Chrome so here's the fix alone for the time being.
  4059. * platform/graphics/mac/FontCacheMac.mm:
  4060. (WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread.
  4061. (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation.
  4062. Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically,
  4063. there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code.
  4064. (WebCore::fontCacheATSNotificationCallback): Ditto.
  4065. 2011-05-26 Stephanie Lewis <slewis@apple.com>
  4066. Reviewed by Geoff Garen.
  4067. https://bugs.webkit.org/show_bug.cgi?id=61345
  4068. part of <rdar://problem/8675177>
  4069. Roll back in now that the Crashes are fixed. ResourceResponseBase and ResourceResponse had two different definitions
  4070. for m_isNull. ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse.
  4071. ResourceResponseBase treats m_isNull as meaning no fields have been initialized. Consolidate calls into ResourceResponseBase meaning.
  4072. Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
  4073. Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
  4074. Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
  4075. Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
  4076. No new functionality so no new tests.
  4077. * platform/network/ResourceResponseBase.cpp:
  4078. (WebCore::ResourceResponseBase::adopt):
  4079. (WebCore::ResourceResponseBase::suggestedFilename):
  4080. (WebCore::ResourceResponseBase::setSuggestedFilename):
  4081. (WebCore::ResourceResponseBase::httpStatusText):
  4082. (WebCore::ResourceResponseBase::setHTTPStatusText):
  4083. (WebCore::ResourceResponseBase::httpHeaderField):
  4084. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  4085. (WebCore::ResourceResponseBase::httpHeaderFields):
  4086. (WebCore::ResourceResponseBase::isAttachment):
  4087. (WebCore::ResourceResponseBase::setLastModifiedDate):
  4088. (WebCore::ResourceResponseBase::lastModifiedDate):
  4089. (WebCore::ResourceResponseBase::wasCached):
  4090. (WebCore::ResourceResponseBase::connectionReused):
  4091. (WebCore::ResourceResponseBase::setConnectionReused):
  4092. (WebCore::ResourceResponseBase::connectionID):
  4093. (WebCore::ResourceResponseBase::setConnectionID):
  4094. (WebCore::ResourceResponseBase::resourceLoadTiming):
  4095. (WebCore::ResourceResponseBase::setResourceLoadTiming):
  4096. (WebCore::ResourceResponseBase::resourceLoadInfo):
  4097. (WebCore::ResourceResponseBase::setResourceLoadInfo):
  4098. * platform/network/ResourceResponseBase.h:
  4099. * platform/network/cf/ResourceResponse.h:
  4100. (WebCore::ResourceResponse::ResourceResponse):
  4101. * platform/network/cf/ResourceResponseCFNet.cpp:
  4102. (WebCore::ResourceResponse::platformLazyInit):
  4103. * platform/network/mac/ResourceResponseMac.mm:
  4104. 2011-05-26 James Kozianski <koz@chromium.org>
  4105. Reviewed by Eric Seidel.
  4106. Implement a whitelist for registerProtocolHandler
  4107. https://bugs.webkit.org/show_bug.cgi?id=60322
  4108. * page/Navigator.cpp:
  4109. (WebCore::initProtocolHandlerWhitelist):
  4110. (WebCore::isProtocolWhitelisted):
  4111. (WebCore::verifyProtocolHandlerScheme):
  4112. 2011-05-26 Annie Sullivan <sullivan@chromium.org>
  4113. Reviewed by Ryosuke Niwa.
  4114. [debug feature] CSSStyleDeclaration should have a way to print cssText
  4115. https://bugs.webkit.org/show_bug.cgi?id=61570
  4116. Adds a method to print the cssText to stderr for debugging.
  4117. * css/CSSStyleDeclaration.cpp:
  4118. (WebCore::CSSStyleDeclaration::showStyle): New method to print cssText to stderr
  4119. * css/CSSStyleDeclaration.h: New method declaration
  4120. 2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>
  4121. Reviewed by Andreas Kling.
  4122. [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
  4123. https://bugs.webkit.org/show_bug.cgi?id=60377
  4124. LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
  4125. For an array of active uniform, we should be careful while truncating the name of the uniform.
  4126. Currently we are truncating the last three characters of an array with out checking for [0].
  4127. As a result we are truncating the the actual name of the active uniforms i.e. color to co.
  4128. * html/canvas/WebGLRenderingContext.cpp:
  4129. (WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
  4130. 2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
  4131. Unreviewed, rolling out r87444.
  4132. http://trac.webkit.org/changeset/87444
  4133. https://bugs.webkit.org/show_bug.cgi?id=61582
  4134. Layout test regressions in Chromium/WebKit: fast/css/first-
  4135. letter-text-fragment-crash.html, fast/css/first-letter-
  4136. visibility.html (Requested by aklein on #webkit).
  4137. * page/Chrome.cpp:
  4138. * page/Chrome.h:
  4139. * page/ChromeClient.h:
  4140. * page/FrameView.cpp:
  4141. (WebCore::FrameView::setContentsSize):
  4142. * page/FrameView.h:
  4143. 2011-05-26 David Levin <levin@chromium.org>
  4144. Reviewed by Darin Fisher.
  4145. Need a callback for when the preferred rendered size changed.
  4146. https://bugs.webkit.org/show_bug.cgi?id=61309
  4147. No new tests needed since no new functionality is exposed.
  4148. * page/Chrome.cpp:
  4149. (WebCore::Chrome::contentsPreferredSizeChanged): Plumbed through the call.
  4150. * page/Chrome.h: Added the new method.
  4151. * page/ChromeClient.h: Ditto.
  4152. * page/FrameView.cpp:
  4153. (WebCore::FrameView::setContentsSize): Added calculations for the preferred size
  4154. and the call to contentsPreferredSizeChanged.
  4155. 2011-05-25 Levi Weintraub <leviw@chromium.org>
  4156. Reviewed by Eric Seidel.
  4157. Switch controlClipRect to use IntPoint
  4158. https://bugs.webkit.org/show_bug.cgi?id=60806
  4159. Switching controlClipRect to take an IntPoint representing the
  4160. offset to be added instead of a pair of ints.
  4161. No new tests as this is just refactoring.
  4162. * WebCore.xcodeproj/project.pbxproj:
  4163. * rendering/RenderBlock.cpp:
  4164. (WebCore::RenderBlock::nodeAtPoint):
  4165. * rendering/RenderBox.cpp:
  4166. (WebCore::RenderBox::pushContentsClip):
  4167. * rendering/RenderBox.h:
  4168. (WebCore::RenderBox::controlClipRect):
  4169. * rendering/RenderButton.cpp:
  4170. (WebCore::RenderButton::controlClipRect):
  4171. * rendering/RenderButton.h:
  4172. * rendering/RenderListBox.cpp:
  4173. (WebCore::RenderListBox::paintItemBackground):
  4174. (WebCore::RenderListBox::controlClipRect):
  4175. * rendering/RenderListBox.h:
  4176. * rendering/RenderMenuList.cpp:
  4177. (WebCore::RenderMenuList::controlClipRect):
  4178. * rendering/RenderMenuList.h:
  4179. * rendering/RenderTextControlSingleLine.cpp:
  4180. (WebCore::RenderTextControlSingleLine::controlClipRect):
  4181. * rendering/RenderTextControlSingleLine.h:
  4182. 2011-05-25 Levi Weintraub <leviw@chromium.org>
  4183. Reviewed by Eric Seidel.
  4184. Switch controlClipRect to use IntPoint
  4185. https://bugs.webkit.org/show_bug.cgi?id=60806
  4186. Switching controlClipRect to take an IntPoint representing the
  4187. offset to be added instead of a pair of ints.
  4188. No new tests as this is just refactoring.
  4189. * WebCore.xcodeproj/project.pbxproj:
  4190. * rendering/RenderBlock.cpp:
  4191. (WebCore::RenderBlock::nodeAtPoint):
  4192. * rendering/RenderBox.cpp:
  4193. (WebCore::RenderBox::pushContentsClip):
  4194. * rendering/RenderBox.h:
  4195. (WebCore::RenderBox::controlClipRect):
  4196. * rendering/RenderButton.cpp:
  4197. (WebCore::RenderButton::controlClipRect):
  4198. * rendering/RenderButton.h:
  4199. * rendering/RenderListBox.cpp:
  4200. (WebCore::RenderListBox::paintItemBackground):
  4201. (WebCore::RenderListBox::controlClipRect):
  4202. * rendering/RenderListBox.h:
  4203. * rendering/RenderMenuList.cpp:
  4204. (WebCore::RenderMenuList::controlClipRect):
  4205. * rendering/RenderMenuList.h:
  4206. * rendering/RenderTextControlSingleLine.cpp:
  4207. (WebCore::RenderTextControlSingleLine::controlClipRect):
  4208. * rendering/RenderTextControlSingleLine.h:
  4209. 2011-05-26 Jeff Miller <jeffm@apple.com>
  4210. Reviewed by Steve Falkenburg.
  4211. Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
  4212. https://bugs.webkit.org/show_bug.cgi?id=61569
  4213. <rdar://problem/9454315>
  4214. Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
  4215. Workaround this issue by setting the real fullscreen window to be a topmost window.
  4216. * platform/graphics/win/FullScreenController.cpp:
  4217. (FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
  4218. (FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.
  4219. 2011-05-26 James Robinson <jamesr@chromium.org>
  4220. Reviewed by Darin Fisher.
  4221. [skia] Add area check to ImageBufferData::getImageData
  4222. https://bugs.webkit.org/show_bug.cgi?id=61375
  4223. No change in behavior, just a sanity check.
  4224. * platform/graphics/skia/ImageBufferSkia.cpp:
  4225. (WebCore::getImageData):
  4226. 2011-05-26 Levi Weintraub <leviw@chromium.org>
  4227. Reviewed by Eric Seidel.
  4228. Switch positionOverflowControls to IntSize
  4229. https://bugs.webkit.org/show_bug.cgi?id=61493
  4230. Switching positionOverflowControls to take a layerOffset IntSize
  4231. as opposed to a pair of ints.
  4232. No new tests since this is just refactoring.
  4233. * rendering/RenderLayer.cpp:
  4234. (WebCore::RenderLayer::updateLayerPositions):
  4235. (WebCore::RenderLayer::positionOverflowControls):
  4236. (WebCore::RenderLayer::paintOverflowControls):
  4237. * rendering/RenderLayer.h:
  4238. 2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
  4239. Unreviewed, rolling out r87368.
  4240. http://trac.webkit.org/changeset/87368
  4241. https://bugs.webkit.org/show_bug.cgi?id=61564
  4242. Wrong approach, will do the wrong thing if the element needs
  4243. simplified normal flow layout but is not positioned (Requested
  4244. by jamesr on #webkit).
  4245. * rendering/RenderObject.h:
  4246. (WebCore::RenderObject::needsPositionedMovementLayout):
  4247. 2011-05-02 Robert Hogan <robert@webkit.org>
  4248. Reviewed by Adam Roben.
  4249. [Qt] Allow popup windows from plugins when initiated by a user gesture
  4250. https://bugs.webkit.org/show_bug.cgi?id=41292
  4251. If the event is from a user gesture and the plugin doesn't support
  4252. NPN_PushPopupsEnabledState() and NPN_PopPopupsEnabledState(), allow popups.
  4253. * plugins/qt/PluginViewQt.cpp:
  4254. (WebCore::PluginView::dispatchNPEvent):
  4255. 2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>
  4256. Reviewed by Dmitry Titov.
  4257. [V8] Add missing compile guards for WebWorkers in WebCore.
  4258. https://bugs.webkit.org/show_bug.cgi?id=61535
  4259. No new tests - refactoring only.
  4260. * bindings/v8/V8AbstractEventListener.cpp:
  4261. (WebCore::V8AbstractEventListener::invokeEventHandler):
  4262. * bindings/v8/V8DOMWrapper.cpp:
  4263. (WebCore::V8DOMWrapper::instantiateV8Object):
  4264. 2011-05-26 Mihai Parparita <mihaip@chromium.org>
  4265. Reviewed by Adam Barth.
  4266. Support cross-origin XMLHttpRequest in isolated worlds
  4267. https://bugs.webkit.org/show_bug.cgi?id=59843
  4268. Allows isolated worlds to be associated with a different SecurityOrigin
  4269. (exposed as a setIsolatedWorldSecurityOrigin function in
  4270. ScriptController).
  4271. The XMLHttpRequest constructor can then check that it's being
  4272. instantiated in an isolated world and use its security origin.
  4273. XMLHttpRequest, ThreadableLoader and DocumentThreadableLoader had to be
  4274. changed to use the copied SecurityOrigin instead of always grabbing the
  4275. Document's.
  4276. Test: http/tests/security/isolatedWorld/cross-origin-xhr.html
  4277. * bindings/v8/ScriptController.cpp:
  4278. (WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
  4279. * bindings/v8/ScriptController.h:
  4280. * bindings/v8/V8IsolatedContext.cpp:
  4281. (WebCore::V8IsolatedContext::setSecurityOrigin):
  4282. * bindings/v8/V8IsolatedContext.h:
  4283. (WebCore::V8IsolatedContext::securityOrigin):
  4284. * bindings/v8/V8Proxy.cpp:
  4285. (WebCore::V8Proxy::evaluateInIsolatedWorld):
  4286. (WebCore::V8Proxy::setIsolatedWorldSecurityOrigin):
  4287. (WebCore::V8Proxy::resetIsolatedWorlds):
  4288. * bindings/v8/V8Proxy.h:
  4289. * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  4290. (WebCore::V8XMLHttpRequest::constructorCallback):
  4291. * loader/DocumentThreadableLoader.cpp:
  4292. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
  4293. (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
  4294. (WebCore::DocumentThreadableLoader::didReceiveResponse):
  4295. (WebCore::DocumentThreadableLoader::preflightSuccess):
  4296. (WebCore::DocumentThreadableLoader::isAllowedRedirect):
  4297. (WebCore::DocumentThreadableLoader::securityOrigin):
  4298. * loader/DocumentThreadableLoader.h:
  4299. * loader/ThreadableLoader.h:
  4300. * xml/XMLHttpRequest.cpp:
  4301. (WebCore::XMLHttpRequest::create):
  4302. (WebCore::XMLHttpRequest::XMLHttpRequest):
  4303. (WebCore::XMLHttpRequest::securityOrigin):
  4304. (WebCore::XMLHttpRequest::responseXML):
  4305. (WebCore::XMLHttpRequest::createRequest):
  4306. (WebCore::XMLHttpRequest::setRequestHeader):
  4307. (WebCore::XMLHttpRequest::getAllResponseHeaders):
  4308. (WebCore::XMLHttpRequest::getResponseHeader):
  4309. * xml/XMLHttpRequest.h:
  4310. 2011-05-26 Michael Nordman <michaeln@google.com>
  4311. Reviewed by Darin Fisher.
  4312. [Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
  4313. SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
  4314. collection of open databases. Otherwise we can fail to lookup databases when
  4315. trying to forceably close them via WebDatabase::closeDatabaseImmediately.
  4316. https://bugs.webkit.org/show_bug.cgi?id=61417
  4317. New new functionality, no tests.
  4318. * storage/DatabaseTracker.h:
  4319. * storage/chromium/DatabaseTrackerChromium.cpp:
  4320. (WebCore::DatabaseTracker::addOpenDatabase):
  4321. (WebCore::DatabaseTracker::removeOpenDatabase):
  4322. (WebCore::DatabaseTracker::getOpenDatabases):
  4323. (WebCore::DatabaseTracker::interruptAllDatabasesForContext):
  4324. 2011-05-25 Jer Noble <jer.noble@apple.com>
  4325. Reviewed by Maciej Stachowiak.
  4326. Safari Web Content crashes while entering/exiting the full screen mode of the video content
  4327. https://bugs.webkit.org/show_bug.cgi?id=61498
  4328. No new tests, as DRT does not currently animate the full screen transition.
  4329. To guard against m_fullScreenRenderer being called after it has been deleted, add
  4330. code in RenderFullScreen which notifies the document when its full-screen renderer
  4331. will be destroyed.
  4332. Also, add some sanity checks when accessing the full-screen renderer's layer backing.
  4333. * dom/Document.cpp:
  4334. (WebCore::Document::webkitWillEnterFullScreenForElement): Guard against a missing
  4335. full-screen renderer layer.
  4336. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
  4337. (WebCore::Document::setFullScreenRenderer): Added ASSERT.
  4338. (WebCore::Document::fullScreenRendererDestroyed): Added.
  4339. (WebCore::Document::setAnimatingFullScreen): Guard against the full-screen
  4340. element having been removed from the document.
  4341. * dom/Document.h:
  4342. * rendering/RenderFullScreen.cpp:
  4343. (RenderFullScreen::destroy): Added. Tell the Document that it's full-screen
  4344. renderer is about to be destroyed.
  4345. * rendering/RenderFullScreen.h:
  4346. 2011-05-26 Andreas Kling <kling@webkit.org>
  4347. Reviewed by Geoffrey Garen.
  4348. Overload resolution in generated JSC bindings could be more efficient.
  4349. https://bugs.webkit.org/show_bug.cgi?id=61544
  4350. Only fetch the arguments once, and not until they are needed (less work
  4351. in the case of an early return.)
  4352. * bindings/scripts/CodeGeneratorJS.pm:
  4353. * bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
  4354. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  4355. 2011-05-26 Adrienne Walker <enne@google.com>
  4356. Reviewed by James Robinson.
  4357. [chromium] Be robust to empty viewports in the compositor
  4358. https://bugs.webkit.org/show_bug.cgi?id=61545
  4359. It's possible for a frame to be requested to be drawn before it is
  4360. non-empty. The compositor should be robust to that possibility. The
  4361. changes in LayerTilerChromium are the only required changes to handle
  4362. this, but having an early out in LayerRendererChromium seemed like a
  4363. good sanity check.
  4364. * platform/graphics/chromium/LayerRendererChromium.cpp:
  4365. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  4366. (WebCore::LayerRendererChromium::drawLayers):
  4367. * platform/graphics/chromium/LayerTilerChromium.cpp:
  4368. (WebCore::LayerTilerChromium::prepareToUpdate):
  4369. (WebCore::LayerTilerChromium::updateRect):
  4370. (WebCore::LayerTilerChromium::draw):
  4371. 2011-05-26 Emil A Eklund <eae@chromium.org>
  4372. Reviewed by Eric Seidel.
  4373. Change RenderObject to use FloatPoint::scale and FloatQuad::scale
  4374. https://bugs.webkit.org/show_bug.cgi?id=61497
  4375. Covered by existing test.
  4376. * platform/graphics/FloatQuad.h:
  4377. (WebCore::FloatQuad::scale):
  4378. * rendering/RenderObject.h:
  4379. (WebCore::adjustFloatQuadForAbsoluteZoom):
  4380. (WebCore::adjustFloatRectForAbsoluteZoom):
  4381. (WebCore::adjustFloatQuadForPageScale):
  4382. (WebCore::adjustFloatRectForPageScale):
  4383. 2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
  4384. Unreviewed build fix for Qt and QuickTime backend.
  4385. r87328 added a new system interface, we need to add it too.
  4386. * platform/qt/WebCoreSystemInterface.h:
  4387. * platform/qt/WebCoreSystemInterface.mm:
  4388. 2011-05-26 Andrey Kosyakov <caseq@chromium.org>
  4389. Unreviewed follow-up to r87395, added checks to avoid accessing undefined member for certain timeline events.
  4390. * inspector/front-end/TimelinePanel.js:
  4391. (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
  4392. (WebInspector.TimelinePanel.FormattedRecord):
  4393. 2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
  4394. Reviewed by Enrica Casucci.
  4395. WebKit duplicates styles from css rules on copy and paste
  4396. https://bugs.webkit.org/show_bug.cgi?id=61466
  4397. Fixed the bug by removing duplicate properties from inline style declarations in ReplaceSelectionCommand.
  4398. Also moved the code to obtain style from rules from markup.cpp to EditingStyle.cpp to share code.
  4399. Test: editing/pasteboard/style-from-rules.html
  4400. * editing/EditingStyle.cpp:
  4401. (WebCore::EditingStyle::EditingStyle): Added a null check.
  4402. (WebCore::EditingStyle::extractFontSizeDelta): Ditto.
  4403. (WebCore::styleFromMatchedRulesForElement): Moved from markup.cpp.
  4404. (WebCore::EditingStyle::mergeStyleFromRules): Extracted from StyledMarkupAccumulator::appendElement.
  4405. (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Ditto.
  4406. (WebCore::EditingStyle::removeStyleFromRules): Added.
  4407. * editing/EditingStyle.h:
  4408. * editing/ReplaceSelectionCommand.cpp:
  4409. (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Renamed from
  4410. negateStyleRulesThatAffectAppearance; Calls removeStyleFromRules.
  4411. * editing/markup.cpp:
  4412. (WebCore::StyledMarkupAccumulator::appendElement): Calls mergeStyleFromRulesForSerialization.
  4413. (WebCore::styleFromMatchedRulesAndInlineDecl): Calls mergeStyleFromRules; changed the return type
  4414. from CSSMutableStyleDeclaration to EditingStyle.
  4415. (WebCore::isElementPresentational): Calls styleFromMatchedRulesAndInlineDecl.
  4416. (WebCore::shouldIncludeWrapperForFullySelectedRoot): Ditto.
  4417. (WebCore::highestAncestorToWrapMarkup): Calls shouldIncludeWrapperForFullySelectedRoot.
  4418. (WebCore::createMarkup): Calls styleFromMatchedRulesAndInlineDecl.
  4419. 2011-05-26 Michael Schneider <michschn@google.com>
  4420. Reviewed by Pavel Feldman.
  4421. WebInspector: Added API to access the timeline data in a inspector extension.
  4422. https://bugs.webkit.org/show_bug.cgi?id=61098
  4423. * WebCore.gypi:
  4424. * WebCore.vcproj/WebCore.vcproj:
  4425. * inspector/front-end/ExtensionAPI.js:
  4426. (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
  4427. (WebInspector.injectedExtensionAPI):
  4428. * inspector/front-end/ExtensionServer.js:
  4429. (WebInspector.ExtensionServer):
  4430. (WebInspector.ExtensionServer.prototype._addRecordToTimeline):
  4431. (WebInspector.ExtensionServer.prototype._onSubscribe):
  4432. (WebInspector.ExtensionServer.prototype._onUnsubscribe):
  4433. (WebInspector.ExtensionServer.prototype._registerHandler):
  4434. (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
  4435. * inspector/front-end/TimelineManager.js: Added.
  4436. (WebInspector.TimelineManager):
  4437. (WebInspector.TimelineManager.prototype.start):
  4438. (WebInspector.TimelineManager.prototype.stop):
  4439. (WebInspector.TimelineDispatcher):
  4440. (WebInspector.TimelineDispatcher.prototype.started):
  4441. (WebInspector.TimelineDispatcher.prototype.stopped):
  4442. (WebInspector.TimelineDispatcher.prototype.eventRecorded):
  4443. * inspector/front-end/TimelinePanel.js:
  4444. (WebInspector.TimelinePanel):
  4445. (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  4446. (WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
  4447. * inspector/front-end/WebKit.qrc:
  4448. * inspector/front-end/inspector.html:
  4449. 2011-05-26 Andrey Kosyakov <caseq@chromium.org>
  4450. Reviewed by Yury Semikhatsky.
  4451. Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
  4452. https://bugs.webkit.org/show_bug.cgi?id=61529
  4453. Do not modify input timeline data when processing timeline event.
  4454. * inspector/front-end/TimelinePanel.js:
  4455. (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
  4456. (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
  4457. (WebInspector.TimelinePanel.FormattedRecord):
  4458. (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
  4459. (WebInspector.TimelinePanel.FormattedRecord.prototype._refreshDetails):
  4460. (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  4461. 2011-05-26 Rob Buis <rbuis@rim.com>
  4462. Reviewed by Dirk Schulze.
  4463. Dynamically created <animate> elements do not animate upon document insertion as they should
  4464. https://bugs.webkit.org/show_bug.cgi?id=20028
  4465. Tests: svg/animations/animate-insert-begin.html
  4466. svg/animations/animate-insert-no-begin.html
  4467. Move animation initializing and rescheduling to insertedIntoDocument. This way animate elements
  4468. dynamicaly inserted into the document using js start as well.
  4469. * svg/animation/SVGSMILElement.cpp:
  4470. (WebCore::SVGSMILElement::insertedIntoDocument):
  4471. * svg/animation/SVGSMILElement.h:
  4472. 2011-05-26 Andreas Kling <kling@webkit.org>
  4473. Reviewed by Benjamin Poulain.
  4474. JSC DOM bindings: ExecState::argumentCount() is size_t, not int.
  4475. https://bugs.webkit.org/show_bug.cgi?id=61530
  4476. * bindings/scripts/CodeGeneratorJS.pm:
  4477. * bindings/scripts/test/JS/JSTestObj.cpp:
  4478. (WebCore::jsTestObjPrototypeFunctionOptionsObject):
  4479. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
  4480. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  4481. (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
  4482. (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
  4483. (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
  4484. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
  4485. (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
  4486. 2011-05-26 Simon Fraser <simon.fraser@apple.com>
  4487. Reviewed by Adam Roben.
  4488. Some repeating linear gradients look wrong
  4489. https://bugs.webkit.org/show_bug.cgi?id=61371
  4490. Test: fast/gradients/css3-repeating-linear-gradients2.html
  4491. Fix incorrect stop duplication code when filling forwards a repeating
  4492. gradient. The "if (srcStopOrdinal < originalNumStops - 1)" test was wrong
  4493. because srcStopOrdinal had been adjusted for stops added by start-filling,
  4494. but originalNumStops had not. Fix by considering srcStopOrdinal as an index
  4495. into the original stops, so comparing it with originalNumStops remains valid.
  4496. * css/CSSGradientValue.cpp:
  4497. (WebCore::CSSGradientValue::addStops):
  4498. 2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>
  4499. Reviewed by Yury Semikhatsky.
  4500. Web Inspector: In network panel, show transfer size in a first line of resource row.
  4501. https://bugs.webkit.org/show_bug.cgi?id=61354
  4502. * English.lproj/localizedStrings.js:
  4503. * inspector/front-end/NetworkPanel.js:
  4504. (WebInspector.NetworkPanel.prototype._createTable):
  4505. (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
  4506. 2011-05-25 Simon Fraser <simon.fraser@apple.com>
  4507. Reviewed by Dan Bernstein.
  4508. Always antialias borders, outlines and rules when scaling
  4509. https://bugs.webkit.org/show_bug.cgi?id=61502
  4510. r84273 changed the behavior of drawLineForBoxSide() to never antialias by default.
  4511. This actually disabled antialiasing in some circumstances where it used to be enabled,
  4512. for example collapsed table border drawing.
  4513. Fix by allowing antialiasing for collapsed table borders, column rules and span
  4514. outlines when the context is scaled.
  4515. Test: fast/borders/border-antialiasing.html
  4516. * rendering/RenderBlock.cpp:
  4517. (WebCore::RenderBlock::paintColumnRules):
  4518. * rendering/RenderInline.cpp:
  4519. (WebCore::RenderInline::paintOutline):
  4520. (WebCore::RenderInline::paintOutlineForLine):
  4521. * rendering/RenderTableCell.cpp:
  4522. (WebCore::RenderTableCell::paintCollapsedBorder):
  4523. 2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>
  4524. Reviewed by Yury Semikhatsky.
  4525. Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
  4526. https://bugs.webkit.org/show_bug.cgi?id=59193
  4527. * inspector/front-end/NetworkItemView.js:
  4528. (WebInspector.NetworkItemView):
  4529. (WebInspector.NetworkItemView._contentViewForResource):
  4530. * inspector/front-end/NetworkPanel.js:
  4531. (WebInspector.NetworkPanel.prototype._refreshResource):
  4532. * inspector/front-end/Resource.js:
  4533. (WebInspector.Resource.prototype.get messages):
  4534. (WebInspector.Resource.prototype.addMessage):
  4535. (WebInspector.Resource.prototype.set errors):
  4536. (WebInspector.Resource.prototype.set warnings):
  4537. (WebInspector.Resource.prototype.clearErrorsAndWarnings):
  4538. * inspector/front-end/ResourceTreeModel.js:
  4539. (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  4540. * inspector/front-end/ResourceView.js:
  4541. (WebInspector.ResourceView.hasTextContent):
  4542. (WebInspector.ResourceView.nonSourceViewForResource):
  4543. (WebInspector.ResourceSourceFrame):
  4544. (WebInspector.ResourceSourceFrame.mimeTypeForResource):
  4545. (WebInspector.ResourceSourceFrame.prototype.requestContent):
  4546. (WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
  4547. (WebInspector.EditableResourceSourceFrame):
  4548. (WebInspector.EditableResourceSourceFrame.prototype.doubleClick):
  4549. (WebInspector.EditableResourceSourceFrame.prototype.editContent):
  4550. (WebInspector.EditableResourceSourceFrame.prototype.cancelEditing):
  4551. (WebInspector.EditableResourceSourceFrame.prototype.afterTextChanged):
  4552. (WebInspector.EditableResourceSourceFrame.prototype._clearIncrementalUpdateTimer):
  4553. (WebInspector.ResourceRevisionSourceFrame):
  4554. (WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
  4555. * inspector/front-end/ResourcesPanel.js:
  4556. (WebInspector.ResourcesPanel.prototype.showResource):
  4557. (WebInspector.ResourcesPanel.prototype._showResourceView):
  4558. (WebInspector.ResourcesPanel.prototype._resourceViewForResource):
  4559. (WebInspector.ResourcesPanel.prototype._showRevisionView):
  4560. (WebInspector.ResourcesPanel.prototype._sourceViewForRevision):
  4561. (WebInspector.ResourcesPanel.prototype.searchCanceled):
  4562. (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision):
  4563. (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision.getParent):
  4564. (WebInspector.FrameResourceTreeElement):
  4565. (WebInspector.FrameResourceTreeElement.prototype.onattach):
  4566. (WebInspector.FrameResourceTreeElement.prototype._updateErrorsAndWarningsBubbles):
  4567. (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsCleared):
  4568. (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsMessageAdded):
  4569. (WebInspector.FrameResourceTreeElement.prototype._appendRevision):
  4570. (WebInspector.FrameResourceTreeElement.prototype.sourceView):
  4571. (WebInspector.FrameResourceTreeElement.prototype._createSourceView):
  4572. (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
  4573. (WebInspector.ResourceRevisionTreeElement):
  4574. (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  4575. (WebInspector.ResourceRevisionTreeElement.prototype.sourceView):
  4576. 2011-05-26 Andreas Kling <kling@webkit.org>
  4577. Reviewed by Darin Adler.
  4578. JSC DOM bindings: Use isUndefinedOrNull() instead of (isNull() || isUndefined()).
  4579. https://bugs.webkit.org/show_bug.cgi?id=61472
  4580. * bindings/scripts/CodeGeneratorJS.pm:
  4581. * bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
  4582. (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
  4583. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  4584. 2011-05-26 Keishi Hattori <keishi@webkit.org>
  4585. Reviewed by Kent Tamura.
  4586. Add <input type=color> appearance.
  4587. https://bugs.webkit.org/show_bug.cgi?id=61275
  4588. Test: fast/forms/color/input-appearance-color.html
  4589. * css/html.css:
  4590. (input[type="color"]): Adds square-button appearance.
  4591. (input[type="color"]::-webkit-color-swatch-wrapper):
  4592. (input[type="color"]::-webkit-color-swatch):
  4593. (input[type="color"][list]): Adds menulist appearance.
  4594. (input[type="color"][list]::-webkit-color-swatch-wrapper):
  4595. (input[type="color"][list]::-webkit-color-swatch):
  4596. * html/ColorInputType.cpp:
  4597. (WebCore::ColorInputType::createShadowSubtree): Creates -webkit-color-swatch inside -webkit-color-swatch-wrapper.
  4598. (WebCore::ColorInputType::updateColorSwatch): Updates background color of shadowColorSwatch.
  4599. (WebCore::ColorInputType::valueChanged): Calls updateColorSwatch.
  4600. (WebCore::ColorInputType::shadowColorSwatch): Gets shadowColorSwatch element.
  4601. * html/ColorInputType.h:
  4602. (WebCore::ColorInputType::ColorInputType): Changed to inherit InputType.
  4603. 2011-05-26 Kent Tamura <tkent@chromium.org>
  4604. Reviewed by Dimitri Glazkov.
  4605. Fix a bug that <input type="number"> dispatches two blurs when tabbing
  4606. from an invalid number
  4607. https://bugs.webkit.org/show_bug.cgi?id=59071
  4608. NumberInputType::handleBlurEvent() dispatched an extra focus event
  4609. and an extra blur event because
  4610. SelectionController::textWillBeReplaced() called by
  4611. RenderTextControlSingleLine::updateFromElement() focuses a node
  4612. with the selection.
  4613. In order to avoid this problem,
  4614. - Introduce Node::willBlur()
  4615. It is called before any state changes by a blur event.
  4616. - Call RenderTextControlSingleLine::updateFromElement() in willBlur()
  4617. It avoids extra focus/blur events because Document::m_focusedNode is
  4618. still the number input during willBlur().
  4619. Test: fast/forms/input-number-blur-twice.html
  4620. * dom/Document.cpp:
  4621. (WebCore::Document::setFocusedNode): Calls Node::beforeBlueEvent().
  4622. * dom/Node.cpp:
  4623. (WebCore::Node::willBlur):
  4624. Default empty implementation of willBlur().
  4625. * dom/Node.h: Declare willBlur().
  4626. * html/HTMLInputElement.cpp:
  4627. (WebCore::HTMLInputElement::willBlur):
  4628. Added. It just calls InputType::willBlur().
  4629. (WebCore::HTMLInputElement::handleBlurEvent):
  4630. Removed InputType::handleBlurEvent() call.
  4631. * html/HTMLInputElement.h: Declare willBlur().
  4632. * html/InputType.cpp:
  4633. (WebCore::InputType::willBlur): Default empty implementation.
  4634. (WebCore::InputType::handleBlurEvent): Removed.
  4635. * html/InputType.h: Declare willBlur(), remove handleBlurEvent().
  4636. * html/NumberInputType.cpp:
  4637. (WebCore::NumberInputType::willBlur):
  4638. Move the code in handleBlurEvent() here.
  4639. * html/NumberInputType.h: Declare willBlur().
  4640. 2011-05-25 Hans Wennborg <hans@chromium.org>
  4641. Reviewed by Steve Block.
  4642. IndexedDB: Support LevelDB transactions.
  4643. https://bugs.webkit.org/show_bug.cgi?id=61270
  4644. Introduce LevelDBTransaction, which implements in-memory transaction
  4645. support on top of LevelDB, and hook this up for IndexedDB to use.
  4646. This is all covered by existing tests.
  4647. * CMakeLists.txt:
  4648. * GNUmakefile.list.am:
  4649. * WebCore.gypi:
  4650. * WebCore.pro:
  4651. * WebCore.xcodeproj/project.pbxproj:
  4652. * platform/leveldb/LevelDBDatabase.cpp:
  4653. (WebCore::LevelDBDatabase::open):
  4654. (WebCore::LevelDBDatabase::put):
  4655. (WebCore::LevelDBDatabase::remove):
  4656. (WebCore::LevelDBDatabase::write):
  4657. (WebCore::IteratorImpl::IteratorImpl):
  4658. (WebCore::IteratorImpl::isValid):
  4659. (WebCore::IteratorImpl::seekToLast):
  4660. (WebCore::IteratorImpl::seek):
  4661. (WebCore::IteratorImpl::next):
  4662. (WebCore::IteratorImpl::prev):
  4663. (WebCore::IteratorImpl::key):
  4664. (WebCore::IteratorImpl::value):
  4665. (WebCore::LevelDBDatabase::createIterator):
  4666. (WebCore::LevelDBDatabase::comparator):
  4667. * platform/leveldb/LevelDBDatabase.h:
  4668. * platform/leveldb/LevelDBIterator.h:
  4669. (WebCore::LevelDBIterator::~LevelDBIterator):
  4670. * platform/leveldb/LevelDBTransaction.cpp: Added.
  4671. (WebCore::LevelDBTransaction::create):
  4672. (WebCore::LevelDBTransaction::LevelDBTransaction):
  4673. (WebCore::LevelDBTransaction::clearTree):
  4674. (WebCore::LevelDBTransaction::~LevelDBTransaction):
  4675. (WebCore::makeVector):
  4676. (WebCore::LevelDBTransaction::set):
  4677. (WebCore::LevelDBTransaction::put):
  4678. (WebCore::LevelDBTransaction::remove):
  4679. (WebCore::LevelDBTransaction::get):
  4680. (WebCore::LevelDBTransaction::commit):
  4681. (WebCore::LevelDBTransaction::rollback):
  4682. (WebCore::LevelDBTransaction::createIterator):
  4683. (WebCore::LevelDBTransaction::TreeIterator::create):
  4684. (WebCore::LevelDBTransaction::TreeIterator::isValid):
  4685. (WebCore::LevelDBTransaction::TreeIterator::seekToLast):
  4686. (WebCore::LevelDBTransaction::TreeIterator::seek):
  4687. (WebCore::LevelDBTransaction::TreeIterator::next):
  4688. (WebCore::LevelDBTransaction::TreeIterator::prev):
  4689. (WebCore::LevelDBTransaction::TreeIterator::key):
  4690. (WebCore::LevelDBTransaction::TreeIterator::value):
  4691. (WebCore::LevelDBTransaction::TreeIterator::isDeleted):
  4692. (WebCore::LevelDBTransaction::TreeIterator::reset):
  4693. (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator):
  4694. (WebCore::LevelDBTransaction::TreeIterator::TreeIterator):
  4695. (WebCore::LevelDBTransaction::TransactionIterator::create):
  4696. (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):
  4697. (WebCore::LevelDBTransaction::TransactionIterator::isValid):
  4698. (WebCore::LevelDBTransaction::TransactionIterator::seekToLast):
  4699. (WebCore::LevelDBTransaction::TransactionIterator::seek):
  4700. (WebCore::LevelDBTransaction::TransactionIterator::next):
  4701. (WebCore::LevelDBTransaction::TransactionIterator::prev):
  4702. (WebCore::LevelDBTransaction::TransactionIterator::key):
  4703. (WebCore::LevelDBTransaction::TransactionIterator::value):
  4704. (WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
  4705. (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToSmallestKey):
  4706. (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToLargestKey):
  4707. (WebCore::LevelDBTransaction::registerIterator):
  4708. (WebCore::LevelDBTransaction::unregisterIterator):
  4709. (WebCore::LevelDBTransaction::resetIterators):
  4710. * platform/leveldb/LevelDBTransaction.h: Added.
  4711. (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_less):
  4712. (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_less):
  4713. (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_greater):
  4714. (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_greater):
  4715. (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_balance_factor):
  4716. (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_balance_factor):
  4717. (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_key):
  4718. (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_node):
  4719. (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_node_node):
  4720. (WebCore::LevelDBTransaction::AVLTreeAbstractor::null):
  4721. (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
  4722. * platform/leveldb/LevelDBWriteBatch.cpp:
  4723. (WebCore::LevelDBWriteBatch::create):
  4724. (WebCore::LevelDBWriteBatch::LevelDBWriteBatch):
  4725. (WebCore::LevelDBWriteBatch::~LevelDBWriteBatch):
  4726. (WebCore::makeSlice):
  4727. (WebCore::LevelDBWriteBatch::put):
  4728. (WebCore::LevelDBWriteBatch::remove):
  4729. (WebCore::LevelDBWriteBatch::clear):
  4730. * storage/IDBLevelDBBackingStore.cpp:
  4731. (WebCore::getInt):
  4732. (WebCore::putInt):
  4733. (WebCore::getString):
  4734. (WebCore::putString):
  4735. (WebCore::getNewObjectStoreId):
  4736. (WebCore::IDBLevelDBBackingStore::createObjectStore):
  4737. (WebCore::deleteRange):
  4738. (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
  4739. (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
  4740. (WebCore::getNewVersionNumber):
  4741. (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
  4742. (WebCore::IDBLevelDBBackingStore::clearObjectStore):
  4743. (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
  4744. (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
  4745. (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
  4746. (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
  4747. (WebCore::getNewIndexId):
  4748. (WebCore::IDBLevelDBBackingStore::createIndex):
  4749. (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
  4750. (WebCore::findGreatestKeyLessThan):
  4751. (WebCore::versionExists):
  4752. (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
  4753. (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
  4754. (WebCore::findLastIndexKeyEqualTo):
  4755. (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
  4756. (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
  4757. (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  4758. (WebCore::IDBLevelDBBackingStore::createTransaction):
  4759. (WebCore::IDBLevelDBBackingStore::Transaction::create):
  4760. (WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
  4761. (WebCore::IDBLevelDBBackingStore::Transaction::begin):
  4762. (WebCore::IDBLevelDBBackingStore::Transaction::commit):
  4763. (WebCore::IDBLevelDBBackingStore::Transaction::rollback):
  4764. * storage/IDBLevelDBBackingStore.h:
  4765. * storage/IDBTransactionBackendImpl.cpp:
  4766. (WebCore::IDBTransactionBackendImpl::abort):
  4767. 2011-05-26 Shane Stephens <shanestephens@google.com>
  4768. Reviewed by James Robinson.
  4769. REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
  4770. https://bugs.webkit.org/show_bug.cgi?id=60689
  4771. Test: transforms/2d/set-transform-and-top.html
  4772. * rendering/RenderBlock.cpp:
  4773. (WebCore::RenderBlock::simplifiedLayout):
  4774. 2011-05-26 Igor Oliveira <igor.oliveira@openbossa.org>
  4775. Reviewed by Andreas Kling.
  4776. drag-not-loaded-image.html test crashes when WebKit is built with debug option
  4777. https://bugs.webkit.org/show_bug.cgi?id=61480
  4778. Checks if image has content before starting to drag.
  4779. * page/DragController.cpp:
  4780. (WebCore::DragController::startDrag):
  4781. 2011-05-26 Alok Priyadarshi <alokp@chromium.org>
  4782. Reviewed by James Robinson.
  4783. [chromium] Cannot create stencil render-buffer for accelerated drawing on desktop GL
  4784. https://bugs.webkit.org/show_bug.cgi?id=61444
  4785. Used DEPTH24_STENCIL8 format for stencil buffer instead of STENCIL_INDEX8.
  4786. Packed depth-stencil buffer is the most common format supported by graphics cards.
  4787. It is not very robust to rely on just one format being supported,
  4788. so long term the task of creating FBO should be delegated to SKIA,
  4789. which has necessary code to iterate through all possible formats.
  4790. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
  4791. (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer):
  4792. (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  4793. 2011-05-25 Jer Noble <jer.noble@apple.com>
  4794. Reviewed by Dan Bernstein.
  4795. 30 second rewind button dysfunctional viewing trailers fullscreen.
  4796. https://bugs.webkit.org/show_bug.cgi?id=61505
  4797. Add support for painting MediaReturnToRealtimeButton, as well as hide and show
  4798. the correct default video control buttons when entering full-screen mode.
  4799. * css/fullscreenQuickTime.css:
  4800. (video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
  4801. * html/shadow/MediaControlRootElement.cpp:
  4802. (WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
  4803. "Return to Realtime" buttons for Live Streams in full-screen mode.
  4804. (WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of
  4805. all the buttons affected by enteredFullscreen().
  4806. * rendering/RenderMediaControls.cpp:
  4807. (WebCore::RenderMediaControls::paintMediaControlsPart): Add support for
  4808. MediaReturnToRealtimeButton.
  4809. 2011-05-25 Luke Macpherson <macpherson@chromium.org>
  4810. Reviewed by Dimitri Glazkov.
  4811. Implement various CSS font properties in CSSStyleApplyProperty.
  4812. https://bugs.webkit.org/show_bug.cgi?id=60603
  4813. No new tests - refactoring only.
  4814. * css/CSSStyleApplyProperty.cpp:
  4815. (WebCore::ApplyPropertyFont):
  4816. Added templated class to handle font properties
  4817. (WebCore::ApplyPropertyFontWeight):
  4818. Added class to handle font weight calculation
  4819. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  4820. Instantiate ApplyPropertyFont/ApplyPropertyFontWeight for appropriate properties.
  4821. * css/CSSStyleSelector.cpp:
  4822. (WebCore::CSSStyleSelector::applyProperty):
  4823. Remove properties that are now implemented in CSSStyleApplyProperty
  4824. * css/CSSStyleSelector.h:
  4825. (WebCore::CSSStyleSelector::fontDescription):
  4826. Added getter for m_style->fontDescription()
  4827. (WebCore::CSSStyleSelector::parentFontDescription):
  4828. Added getter for m_parentStyle->fontDescription()
  4829. (WebCore::CSSStyleSelector::setFontDescription):
  4830. Added setter for m_style->setFontDescription() that automatically sets m_fontDirty
  4831. 2011-05-25 James Simonsen <simonjam@chromium.org>
  4832. Reviewed by Adam Barth.
  4833. Add site-specific hack for zipcar.com with old versions of requirejs.
  4834. https://bugs.webkit.org/show_bug.cgi?id=61321
  4835. Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
  4836. order. This used to work in webkit by setting a bogus script type (script/cache), then
  4837. changing the type to a valid one when they wanted to execute it. This hack translates the
  4838. behavior into the new API (by disabling forceAsync).
  4839. * html/HTMLScriptElement.cpp:
  4840. (WebCore::needsOldRequirejsQuirk): Added.
  4841. (WebCore::HTMLScriptElement::insertedIntoDocument):
  4842. If hack is needed, set a proper script type so script loads.
  4843. If script isn't async, disable forceAsync so script executes in order.
  4844. 2011-05-25 Andreas Kling <kling@webkit.org>
  4845. Reviewed by David Levin.
  4846. Rebaseline run-bindings-tests.
  4847. https://bugs.webkit.org/show_bug.cgi?id=61469
  4848. * bindings/scripts/test/JS/:
  4849. * bindings/scripts/test/V8/:
  4850. 2011-05-25 Levi Weintraub <leviw@chromium.org>
  4851. Reviewed by Eric Seidel.
  4852. Switch itemBoundingBoxRect to use IntPoint
  4853. https://bugs.webkit.org/show_bug.cgi?id=60789
  4854. Changing itemBoundingBoxRect to use an IntPoint representing the offset
  4855. to be added tot he box rect instead of a pair of ints.
  4856. No new tests since this is just refactoring.
  4857. * accessibility/AccessibilityListBox.cpp:
  4858. (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
  4859. * accessibility/AccessibilityListBoxOption.cpp:
  4860. (WebCore::AccessibilityListBoxOption::elementRect):
  4861. * rendering/RenderListBox.cpp:
  4862. (WebCore::RenderListBox::itemBoundingBoxRect):
  4863. (WebCore::RenderListBox::addFocusRingRects):
  4864. (WebCore::RenderListBox::paintItemForeground):
  4865. (WebCore::RenderListBox::paintItemBackground):
  4866. (WebCore::RenderListBox::nodeAtPoint):
  4867. * rendering/RenderListBox.h:
  4868. 2011-05-24 MORITA Hajime <morrita@google.com>
  4869. Reviewed by Dimitri Glazkov.
  4870. RenderText with empty text is not created inside ShadowContentElement
  4871. https://bugs.webkit.org/show_bug.cgi?id=61111
  4872. - Changed Text::rendererIsNeeded() to be shadow-aware.
  4873. - previousRenderer(), nextRenderer() and parentRenderer() on NodeRenderingContext is now
  4874. safe even if it's used with an attached node, which was originally used only during attach().
  4875. We need this change because these APIs are called inside CharacterData::updateRenderer() callstack.
  4876. Tests: fast/html/details-replace-summary-child.html
  4877. fast/html/details-replace-text.html
  4878. * dom/NodeRenderingContext.cpp:
  4879. (WebCore::NodeRenderingContext::NodeRenderingContext):
  4880. (WebCore::NodeRenderingContext::nextRenderer):
  4881. (WebCore::NodeRenderingContext::previousRenderer):
  4882. (WebCore::NodeRenderingContext::parentRenderer):
  4883. (WebCore::NodeRenderingContext::shouldCreateRenderer):
  4884. * dom/NodeRenderingContext.h:
  4885. (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
  4886. * dom/Text.cpp:
  4887. (WebCore::Text::rendererIsNeeded):
  4888. 2011-05-25 Sailesh Agrawal <sail@chromium.org>
  4889. Reviewed by Tony Chang.
  4890. Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
  4891. https://bugs.webkit.org/show_bug.cgi?id=61401
  4892. ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.
  4893. * WebCore.gypi:
  4894. * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
  4895. * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
  4896. * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
  4897. * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.
  4898. 2011-05-25 James Robinson <jamesr@chromium.org>
  4899. Reviewed by Geoffrey Garen
  4900. CachedResource overhead size calculation ignores the actual size of the URL
  4901. https://bugs.webkit.org/show_bug.cgi?id=61481
  4902. CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
  4903. it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
  4904. can be significant.
  4905. This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
  4906. other types of strings instead of a fixed number.
  4907. * loader/cache/CachedResource.cpp:
  4908. (WebCore::CachedResource::overheadSize):
  4909. 2011-05-25 Oliver Hunt <oliver@apple.com>
  4910. Reviewed by Geoffrey Garen.
  4911. Make RegExp GC allocated
  4912. https://bugs.webkit.org/show_bug.cgi?id=61490
  4913. RegExp is GC'd so we don't need the RefPtr shenanigans anymore.
  4914. * bindings/js/SerializedScriptValue.cpp:
  4915. (WebCore::CloneDeserializer::readTerminal):
  4916. 2011-05-25 Martin Robinson <mrobinson@igalia.com>
  4917. Reviewed by Dirk Schulze.
  4918. [Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
  4919. https://bugs.webkit.org/show_bug.cgi?id=60185
  4920. Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
  4921. state into PlatformContextCairo. Since Cairo is the only platform that needs
  4922. to store this, this is the proper place for it. Change the image mask stack into
  4923. a more generic state stack that can keep track of the multiple bits of platform
  4924. specific state and properly handle save/restore pairs.
  4925. No new tests. This is just a code refactor.
  4926. * platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs.
  4927. (WebCore::GraphicsContextState::GraphicsContextState): Ditto.
  4928. * platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now.
  4929. (WebCore::ContextShadow::drawRectShadow):
  4930. * platform/graphics/cairo/FontCairo.cpp: Ditto.
  4931. (WebCore::Font::drawGlyphs):
  4932. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  4933. (WebCore::setPlatformFill): Ditto.
  4934. (WebCore::setPlatformStroke): Ditto.
  4935. (WebCore::GraphicsContext::setAlpha): Ditto.
  4936. * platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the
  4937. header file, since it can be private now. Abstract the image mask state and the global alpha
  4938. in a generic State class.
  4939. (WebCore::ImageMaskInformation::update):
  4940. (WebCore::ImageMaskInformation::isValid):
  4941. (WebCore::ImageMaskInformation::maskSurface):
  4942. (WebCore::ImageMaskInformation::maskRect):
  4943. (WebCore::PlatformContextCairo::State::State): Added.
  4944. (WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state
  4945. class when this class is constructed.
  4946. (WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack.
  4947. (WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward
  4948. declare the State class in the header.
  4949. (WebCore::PlatformContextCairo::save): Push a new state onto the stack.
  4950. (WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now.
  4951. (WebCore::PlatformContextCairo::globalAlpha): Added.
  4952. (WebCore::PlatformContextCairo::setGlobalAlpha): Added.
  4953. (WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha().
  4954. * platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack
  4955. into a more generic state stack, much like PlatformContextChromium.
  4956. 2011-05-25 Mark Rowe <mrowe@apple.com>
  4957. Reviewed by Sam Weinig.
  4958. <rdar://problem/9504058> Need some way to query user gesture state from injected bundle
  4959. * WebCore.exp.in: Add an export that WebKit2 needs.
  4960. 2011-05-25 Jer Noble <jer.noble@apple.com>
  4961. Ureviewed; Build fix for Leopard and Snow Leopard.
  4962. Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.
  4963. * WebCore.exp.in:
  4964. 2011-05-25 Michael Saboff <msaboff@apple.com>
  4965. Reviewed by Sam Weinig.
  4966. Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
  4967. https://bugs.webkit.org/show_bug.cgi?id=61478
  4968. Cleanup of further comments after patch was landed. Changes include
  4969. using /2 instead of >>1, adding a blank line after class include,
  4970. making method names start with lower case and adding clarifying
  4971. comments.
  4972. No new tests as the changes are stylistic and not functional.
  4973. * loader/cache/MemoryCache.cpp:
  4974. (WebCore::MemoryCache::pruneLiveResourcesToPercentage):
  4975. (WebCore::MemoryCache::pruneDeadResourcesToPercentage):
  4976. * loader/cache/MemoryCache.h:
  4977. (WebCore::MemoryCache::pruneToPercentage):
  4978. * platform/mac/MemoryPressureHandlerMac.mm:
  4979. (WebCore::MemoryPressureHandler::respondToMemoryPressure):
  4980. 2011-05-25 Stephanie Lewis <slewis@apple.com>
  4981. Reviewed by Brady Eidson.
  4982. https://bugs.webkit.org/show_bug.cgi?id=61407
  4983. part of <rdar://problem/8675177>
  4984. Move Quicklook quirk down into WebCore so it can be caculated when the user
  4985. starts a reload. Restructure the conditions so it only called when absolutely
  4986. necessary.
  4987. No change in functionality so no new tests.
  4988. * loader/FrameLoader.cpp:
  4989. (WebCore::FrameLoader::subresourceCachePolicy):
  4990. * page/Settings.cpp:
  4991. (WebCore::Settings::Settings):
  4992. * page/Settings.h:
  4993. * platform/network/cf/ResourceRequest.h:
  4994. * platform/network/mac/ResourceRequestMac.mm:
  4995. (WebCore::initQuickLookResourceCachingQuirks):
  4996. (WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
  4997. 2011-05-24 Jer Noble <jer.noble@apple.com>
  4998. Reviewed by Darin Adler.
  4999. Video fails to play on Vimeo
  5000. https://bugs.webkit.org/show_bug.cgi?id=61403
  5001. No new tests; Covered by media/video-canvas-source.html.
  5002. Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
  5003. by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
  5004. creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
  5005. remote->local and make our answer to hasSingleSecurityOrigin dynamic.
  5006. When checking whether a given request has a single security origin, use a
  5007. SecurityOrigin to check the host, port, and scheme.
  5008. * WebCore.exp.in:
  5009. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  5010. (WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
  5011. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  5012. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  5013. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference
  5014. for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote
  5015. (WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the
  5016. requested and resolved URLs have the same host and port.
  5017. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  5018. (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for
  5019. NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.
  5020. (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the
  5021. requested and resolved URLs have the same host and port.
  5022. * platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
  5023. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  5024. 2011-05-25 Andrew Scherkus <scherkus@chromium.org>
  5025. Reviewed by Eric Carlson.
  5026. Fix media element regression where ended event stopped firing after changing the src attribute.
  5027. https://bugs.webkit.org/show_bug.cgi?id=61336
  5028. Test: media/media-ended.html
  5029. * html/HTMLMediaElement.cpp:
  5030. (WebCore::HTMLMediaElement::prepareForLoad):
  5031. 2011-05-25 Jer Noble <jer.noble@apple.com>
  5032. Reviewed by Darin Adler.
  5033. REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
  5034. https://bugs.webkit.org/show_bug.cgi?id=61461
  5035. Tests: fullscreen/full-screen-iframe-legacy.html
  5036. Allow calls from the legacy full-screen API to bypass the iframe
  5037. "webkitallowfullscreen" requirement by adding a parameter to
  5038. Document::webkitRequestFullScreenForElement specifying the strictness
  5039. of that check. Specify this new parameter everywhere that function is
  5040. called, including in the default controls' full-screen button handler.
  5041. * dom/Document.cpp:
  5042. (WebCore::Document::webkitRequestFullScreenForElement):
  5043. * dom/Document.h:
  5044. * dom/Element.cpp:
  5045. (WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
  5046. * html/HTMLMediaElement.cpp:
  5047. (WebCore::HTMLMediaElement::enterFullscreen):
  5048. * html/shadow/MediaControlElements.cpp:
  5049. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
  5050. 2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
  5051. Reviewed by David Hyatt.
  5052. Selector matching doesn't update when DOM changes ("[data-a=x] #x")
  5053. https://bugs.webkit.org/show_bug.cgi?id=60752
  5054. Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
  5055. which are used in CSS attribute selectors to determine the need for style
  5056. recalculation whenever element attributes are manipulated in DOM.
  5057. In certain conditions (element with no style, element is styled and attribute
  5058. is not a mapped attribute, attribute is of type 'type' or read-only)
  5059. even when attribute selector matches for an element, the attribute is not
  5060. added to m_selectorAttrs. This results in missing style recalculations
  5061. when a DOM element attribute is changed and is not found in m_selectorAttrs.
  5062. Removing the above said conditions in
  5063. CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
  5064. attributes in m_selectorAttrs will solve this issue. But this particular
  5065. function is called numerous times which triggers adding duplicate attributes
  5066. again and again.
  5067. This patch follows the approach taken for collecting ids in selectors, where
  5068. all the attributes in selectors are added to a HashSet at the time of adding
  5069. style rules to CSSStyleSelector from StyleSheets and when
  5070. CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
  5071. simply looked up in this pre-populated hash set.
  5072. Test: fast/css/attribute-selector-dynamic-no-elementstyle.html
  5073. * css/CSSStyleSelector.cpp:
  5074. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  5075. (WebCore::CSSStyleSelector::checkSelector):
  5076. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  5077. (WebCore::collectFeaturesFromSelector):
  5078. (WebCore::CSSStyleSelector::applyProperty):
  5079. (WebCore::CSSStyleSelector::hasSelectorForAttribute):
  5080. * css/CSSStyleSelector.h:
  5081. 2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
  5082. Reviewed by James Robinson.
  5083. CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
  5084. https://bugs.webkit.org/show_bug.cgi?id=61454
  5085. Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
  5086. by one enum, and provided a way to obtain rules from UA/user stylesheets.
  5087. * css/CSSRule.h: Removed CSSRuleFilter.
  5088. * css/CSSStyleSelector.cpp:
  5089. (WebCore::CSSStyleSelector::styleRulesForElement): See above.
  5090. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
  5091. * css/CSSStyleSelector.h: Moved CSSRuleFilter here.
  5092. * editing/markup.cpp:
  5093. (WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
  5094. * inspector/InspectorCSSAgent.cpp:
  5095. (WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
  5096. * page/DOMWindow.cpp:
  5097. (WebCore::DOMWindow::getMatchedCSSRules): Ditto.
  5098. 2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  5099. Reviewed by Andreas Kling.
  5100. [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
  5101. https://bugs.webkit.org/show_bug.cgi?id=61343
  5102. Create a stack to keep track of the sender objects. This is simpler than
  5103. the similar mechanism in QObject (C++ API), that keeps a stack per-object.
  5104. Since we do not support multiple threads, one static stack will be enough for
  5105. handling the behavior.
  5106. This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
  5107. * bridge/qt/qt_instance.cpp:
  5108. (JSC::Bindings::QtInstance::qtSenderStack):
  5109. We have one static stack of QObject*. The top of the stack contains the
  5110. last object that emitted signal that called a JavaScript function.
  5111. * bridge/qt/qt_instance.h:
  5112. (JSC::Bindings::QtInstance::QtSenderStack::top):
  5113. (JSC::Bindings::QtInstance::QtSenderStack::push):
  5114. (JSC::Bindings::QtInstance::QtSenderStack::pop):
  5115. Minimal functionality to manipulate the sender stack.
  5116. * bridge/qt/qt_runtime.cpp:
  5117. (JSC::Bindings::QtConnectionObject::execute):
  5118. Remove the previous code that modified the scope chain. Push the sender object
  5119. to the stack before calling the JavaScript function (the "slot" in Qt-speak) and
  5120. pop it afterwards.
  5121. 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
  5122. Unreviewed, rolling out r87257.
  5123. http://trac.webkit.org/changeset/87257
  5124. https://bugs.webkit.org/show_bug.cgi?id=61457
  5125. This broke layout tests, see bug 61431. (Requested by
  5126. hwennborg on #webkit).
  5127. * storage/IDBBackingStore.h:
  5128. * storage/IDBFactoryBackendImpl.cpp:
  5129. (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
  5130. (WebCore::IDBFactoryBackendImpl::open):
  5131. * storage/IDBFactoryBackendImpl.h:
  5132. * storage/IDBFactoryBackendInterface.h:
  5133. * storage/IDBLevelDBBackingStore.cpp:
  5134. * storage/IDBLevelDBBackingStore.h:
  5135. * storage/IDBSQLiteBackingStore.cpp:
  5136. * storage/IDBSQLiteBackingStore.h:
  5137. 2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
  5138. Reviewed by Eric Carlson.
  5139. [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
  5140. https://bugs.webkit.org/show_bug.cgi?id=61279
  5141. Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
  5142. to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
  5143. when calling build-webkit.
  5144. * WebCore.pri:
  5145. * WebCore.pro:
  5146. * features.pri:
  5147. * platform/KURL.h:
  5148. * platform/SharedBuffer.h:
  5149. * platform/cf/KURLCFNet.cpp:
  5150. * platform/cf/SharedBufferCF.cpp:
  5151. * platform/graphics/FloatSize.h:
  5152. * platform/graphics/IntRect.h:
  5153. * platform/graphics/IntSize.h:
  5154. * platform/graphics/MediaPlayer.cpp:
  5155. * platform/graphics/cg/FloatSizeCG.cpp:
  5156. * platform/graphics/cg/IntRectCG.cpp:
  5157. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  5158. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  5159. (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
  5160. (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
  5161. (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
  5162. (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
  5163. (WebCore::MediaPlayerPrivateQTKit::paint):
  5164. (-[WebCoreMovieObserver layerHostChanged:]):
  5165. * platform/mac/KURLMac.mm:
  5166. * platform/mac/SharedBufferMac.mm:
  5167. (+[WebCoreSharedBufferData initialize]):
  5168. * platform/mac/WebCoreObjCExtras.mm:
  5169. * platform/qt/WebCoreSystemInterface.h: Added.
  5170. * platform/qt/WebCoreSystemInterface.mm: Added.
  5171. 2011-05-25 Rob Buis <rbuis@rim.com>
  5172. Reviewed by Eric Seidel.
  5173. New test rubber-stamped by Dirk Schulze.
  5174. WebKit does not handle missing filter elements correctly
  5175. https://bugs.webkit.org/show_bug.cgi?id=12569
  5176. Do not render elements that reference non-existant filters.
  5177. Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg
  5178. * rendering/svg/SVGRenderSupport.cpp:
  5179. (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
  5180. 2011-05-25 Nate Chapin <japhet@chromium.org>
  5181. Reviewed by Adam Barth.
  5182. Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
  5183. XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
  5184. https://bugs.webkit.org/show_bug.cgi?id=59113
  5185. * bindings/ScriptControllerBase.cpp:
  5186. (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
  5187. * css/CSSStyleSelector.cpp:
  5188. (WebCore::CSSStyleSelector::matchUARules):
  5189. * dom/Document.cpp:
  5190. (WebCore::Document::Document):
  5191. (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
  5192. * dom/Document.h:
  5193. (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
  5194. * html/HTMLViewSourceDocument.cpp:
  5195. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  5196. * loader/FrameLoader.cpp:
  5197. (WebCore::FrameLoader::receivedFirstData):
  5198. * xml/XMLTreeViewer.cpp:
  5199. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  5200. 2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>
  5201. Reviewed by James Robinson.
  5202. http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
  5203. https://bugs.webkit.org/show_bug.cgi?id=39027
  5204. And:
  5205. - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
  5206. https://bugs.webkit.org/show_bug.cgi?id=48295
  5207. - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
  5208. https://bugs.webkit.org/show_bug.cgi?id=48304
  5209. - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
  5210. https://bugs.webkit.org/show_bug.cgi?id=48305
  5211. Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
  5212. them together as the fix is common.
  5213. Based on an older work by Ariya Hidayat.
  5214. * html/canvas/CanvasRenderingContext2D.cpp:
  5215. (WebCore::CanvasRenderingContext2D::fill):
  5216. (WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2
  5217. cases if we have to.
  5218. (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
  5219. the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
  5220. (WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
  5221. (which matches other browsers' behavior) and "display transparency elsewhere".
  5222. * html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.
  5223. 2011-05-25 Levi Weintraub <leviw@chromium.org>
  5224. Reviewed by Eric Seidel.
  5225. Add IntPoint versions of IntRect::move and IntPoint::move
  5226. https://bugs.webkit.org/show_bug.cgi?id=61390
  5227. Adding move methods to IntRect and IntPoint that take an IntPoint
  5228. that's acting as an offset. Since we also apply negative offsets,
  5229. also adding a single parameter operator- for IntPoint.
  5230. No new tests since this is refactoring.
  5231. * page/FrameView.cpp:
  5232. (WebCore::FrameView::invalidateScrollbarRect):
  5233. (WebCore::FrameView::convertFromRenderer):
  5234. (WebCore::FrameView::convertToRenderer):
  5235. * platform/ScrollView.cpp:
  5236. (WebCore::ScrollView::wheelEvent):
  5237. * platform/ScrollView.h:
  5238. (WebCore::ScrollView::convertChildToSelf):
  5239. (WebCore::ScrollView::convertSelfToChild):
  5240. * platform/ScrollbarThemeComposite.cpp:
  5241. (WebCore::ScrollbarThemeComposite::invalidatePart):
  5242. * platform/graphics/IntPoint.h:
  5243. (WebCore::IntPoint::move):
  5244. (WebCore::operator-):
  5245. * platform/graphics/IntRect.h:
  5246. (WebCore::IntRect::move):
  5247. * platform/graphics/filters/FilterEffect.cpp:
  5248. (WebCore::FilterEffect::requestedRegionOfInputImageData):
  5249. * platform/graphics/gpu/Texture.cpp:
  5250. (WebCore::Texture::updateSubRect):
  5251. * platform/mac/WidgetMac.mm:
  5252. (WebCore::Widget::paint):
  5253. * rendering/RenderBlock.cpp:
  5254. (WebCore::RenderBlock::logicalRectToPhysicalRect):
  5255. (WebCore::RenderBlock::selectionGaps):
  5256. * rendering/RenderBox.cpp:
  5257. (WebCore::RenderBox::offsetFromContainer):
  5258. (WebCore::RenderBox::computeRectForRepaint):
  5259. (WebCore::RenderBox::localCaretRect):
  5260. * rendering/RenderDetailsMarker.cpp:
  5261. (WebCore::RenderDetailsMarker::paint):
  5262. * rendering/RenderInline.cpp:
  5263. (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
  5264. * rendering/RenderInputSpeech.cpp:
  5265. (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  5266. * rendering/RenderLayerBacking.cpp:
  5267. (WebCore::paintScrollbar):
  5268. (WebCore::RenderLayerBacking::paintContents):
  5269. * rendering/RenderLayerCompositor.cpp:
  5270. (WebCore::paintScrollbar):
  5271. (WebCore::RenderLayerCompositor::paintContents):
  5272. * rendering/RenderListItem.cpp:
  5273. (WebCore::RenderListItem::positionListMarker):
  5274. * rendering/RenderListMarker.cpp:
  5275. (WebCore::RenderListMarker::paint):
  5276. * rendering/RenderTableCell.cpp:
  5277. (WebCore::RenderTableCell::computeRectForRepaint):
  5278. * rendering/RenderTextControlSingleLine.cpp:
  5279. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  5280. * rendering/RenderView.cpp:
  5281. (WebCore::RenderView::repaintViewRectangle):
  5282. 2011-05-25 Levi Weintraub <leviw@chromium.org>
  5283. Reviewed by Eric Seidel.
  5284. Switch addFocusRingRects to use IntPoint
  5285. https://bugs.webkit.org/show_bug.cgi?id=60783
  5286. Switching addFocusRingRects to use an IntPoint representing the offset being
  5287. applied instead of a pair of ints.
  5288. No new tests as this is only refactoring.
  5289. * platform/graphics/FloatSize.h:
  5290. (WebCore::flooredIntPoint):
  5291. * rendering/RenderBlock.cpp:
  5292. (WebCore::RenderBlock::addFocusRingRects):
  5293. * rendering/RenderBlock.h:
  5294. * rendering/RenderBox.cpp:
  5295. (WebCore::RenderBox::addFocusRingRects):
  5296. * rendering/RenderBox.h:
  5297. * rendering/RenderInline.cpp:
  5298. (WebCore::RenderInline::addFocusRingRects):
  5299. * rendering/RenderInline.h:
  5300. * rendering/RenderListBox.cpp:
  5301. (WebCore::RenderListBox::addFocusRingRects):
  5302. * rendering/RenderListBox.h:
  5303. * rendering/RenderObject.cpp:
  5304. (WebCore::RenderObject::paintFocusRing):
  5305. (WebCore::RenderObject::absoluteFocusRingQuads):
  5306. * rendering/RenderObject.h:
  5307. (WebCore::RenderObject::addFocusRingRects):
  5308. * rendering/RenderTextControl.cpp:
  5309. (WebCore::RenderTextControl::addFocusRingRects):
  5310. * rendering/RenderTextControl.h:
  5311. * rendering/RenderTextControlSingleLine.cpp:
  5312. (WebCore::RenderTextControlSingleLine::addFocusRingRects):
  5313. * rendering/RenderTextControlSingleLine.h:
  5314. * rendering/svg/RenderSVGContainer.cpp:
  5315. (WebCore::RenderSVGContainer::addFocusRingRects):
  5316. * rendering/svg/RenderSVGContainer.h:
  5317. * rendering/svg/RenderSVGImage.cpp:
  5318. (WebCore::RenderSVGImage::addFocusRingRects):
  5319. * rendering/svg/RenderSVGImage.h:
  5320. * rendering/svg/RenderSVGPath.cpp:
  5321. (WebCore::RenderSVGPath::addFocusRingRects):
  5322. * rendering/svg/RenderSVGPath.h:
  5323. 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
  5324. Unreviewed, rolling out r87229.
  5325. http://trac.webkit.org/changeset/87229
  5326. https://bugs.webkit.org/show_bug.cgi?id=61445
  5327. Lots of tests crashing in
  5328. CFNetwork!URLResponse::createFilenameFromResponseHeaders on
  5329. Windows XP (Requested by aroben on #webkit).
  5330. * platform/network/ResourceResponseBase.cpp:
  5331. (WebCore::ResourceResponseBase::adopt):
  5332. (WebCore::ResourceResponseBase::suggestedFilename):
  5333. (WebCore::ResourceResponseBase::setSuggestedFilename):
  5334. (WebCore::ResourceResponseBase::httpStatusText):
  5335. (WebCore::ResourceResponseBase::setHTTPStatusText):
  5336. (WebCore::ResourceResponseBase::httpHeaderField):
  5337. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  5338. (WebCore::ResourceResponseBase::httpHeaderFields):
  5339. (WebCore::ResourceResponseBase::isAttachment):
  5340. (WebCore::ResourceResponseBase::setLastModifiedDate):
  5341. (WebCore::ResourceResponseBase::lastModifiedDate):
  5342. (WebCore::ResourceResponseBase::wasCached):
  5343. (WebCore::ResourceResponseBase::connectionReused):
  5344. (WebCore::ResourceResponseBase::setConnectionReused):
  5345. (WebCore::ResourceResponseBase::connectionID):
  5346. (WebCore::ResourceResponseBase::setConnectionID):
  5347. (WebCore::ResourceResponseBase::resourceLoadTiming):
  5348. (WebCore::ResourceResponseBase::setResourceLoadTiming):
  5349. (WebCore::ResourceResponseBase::resourceLoadInfo):
  5350. (WebCore::ResourceResponseBase::setResourceLoadInfo):
  5351. * platform/network/ResourceResponseBase.h:
  5352. * platform/network/cf/ResourceResponse.h:
  5353. (WebCore::ResourceResponse::ResourceResponse):
  5354. * platform/network/cf/ResourceResponseCFNet.cpp:
  5355. (WebCore::ResourceResponse::platformLazyInit):
  5356. * platform/network/mac/ResourceResponseMac.mm:
  5357. (WebCore::ResourceResponse::platformLazyInit):
  5358. 2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
  5359. Reviewed by Antonio Gomes.
  5360. [Qt] QtWebKit crashes when dragging not loaded images
  5361. https://bugs.webkit.org/show_bug.cgi?id=61314
  5362. Checks if nativeImageForCurrentFrame is a valid pointer.
  5363. Test: http/tests/misc/drag-not-loaded-image.html
  5364. * platform/qt/DragImageQt.cpp:
  5365. (WebCore::createDragImageFromImage):
  5366. 2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>
  5367. Reviewed by Xan Lopez.
  5368. [GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
  5369. https://bugs.webkit.org/show_bug.cgi?id=61436
  5370. Fix arguments of gdk_drawable_get_size.
  5371. No new tests, no behavior change.
  5372. * platform/gtk/GtkVersioning.c:
  5373. (getGdkDrawableSize):
  5374. 2011-05-23 Alexander Pavlov <apavlov@chromium.org>
  5375. Reviewed by Yury Semikhatsky.
  5376. Web Inspector: extreme lagging when searching for "img[src*="
  5377. https://bugs.webkit.org/show_bug.cgi?id=61282
  5378. No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
  5379. when built and search-highlighted, rather than through innerHTML.
  5380. * inspector/front-end/DOMSyntaxHighlighter.js:
  5381. (WebInspector.DOMSyntaxHighlighter):
  5382. (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
  5383. * inspector/front-end/ElementsPanel.js:
  5384. (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
  5385. * inspector/front-end/ElementsTreeOutline.js:
  5386. (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
  5387. (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
  5388. (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
  5389. (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
  5390. (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
  5391. (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
  5392. (WebInspector.ElementsTreeElement.prototype.updateTitle):
  5393. (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
  5394. ():
  5395. * inspector/front-end/utilities.js:
  5396. ():
  5397. 2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>
  5398. Reviewed by Tony Gentilcore.
  5399. Introduce HTML5 track list objects.
  5400. https://bugs.webkit.org/show_bug.cgi?id=60184
  5401. Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
  5402. for their use in the MediaStream API and the HTML Media Element.
  5403. Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist
  5404. The Media Stream API will test this feature in the bug 56587.
  5405. More tests related to the HTML Media Element may be added later.
  5406. * CMakeLists.txt:
  5407. * CodeGenerators.pri:
  5408. * DerivedSources.cpp:
  5409. * DerivedSources.make:
  5410. * GNUmakefile.list.am:
  5411. * WebCore.gypi:
  5412. * WebCore.pro:
  5413. * WebCore.vcproj/WebCore.vcproj:
  5414. * WebCore.xcodeproj/project.pbxproj:
  5415. * bindings/js/JSEventTarget.cpp:
  5416. (WebCore::toJS):
  5417. * bindings/v8/V8DOMWrapper.cpp:
  5418. (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  5419. * dom/DOMAllInOne.cpp:
  5420. * dom/EventTarget.cpp:
  5421. (WebCore::EventTarget::toTrackList):
  5422. (WebCore::EventTarget::toMultipleTrackList):
  5423. (WebCore::EventTarget::toExclusiveTrackList):
  5424. * dom/EventTarget.h:
  5425. * dom/ExclusiveTrackList.cpp: Added.
  5426. (WebCore::ExclusiveTrackList::create):
  5427. (WebCore::ExclusiveTrackList::ExclusiveTrackList):
  5428. (WebCore::ExclusiveTrackList::~ExclusiveTrackList):
  5429. (WebCore::ExclusiveTrackList::clear):
  5430. (WebCore::ExclusiveTrackList::select):
  5431. (WebCore::ExclusiveTrackList::toExclusiveTrackList):
  5432. * dom/ExclusiveTrackList.h: Added.
  5433. (WebCore::ExclusiveTrackList::selectedIndex):
  5434. * dom/ExclusiveTrackList.idl: Added.
  5435. * dom/MultipleTrackList.cpp: Added.
  5436. (WebCore::MultipleTrackList::create):
  5437. (WebCore::MultipleTrackList::MultipleTrackList):
  5438. (WebCore::MultipleTrackList::~MultipleTrackList):
  5439. (WebCore::MultipleTrackList::clear):
  5440. (WebCore::MultipleTrackList::isEnabled):
  5441. (WebCore::MultipleTrackList::enable):
  5442. (WebCore::MultipleTrackList::disable):
  5443. (WebCore::MultipleTrackList::toMultipleTrackList):
  5444. * dom/MultipleTrackList.h: Added.
  5445. * dom/MultipleTrackList.idl: Added.
  5446. * dom/TrackList.cpp: Added.
  5447. (WebCore::Track::create):
  5448. (WebCore::Track::Track):
  5449. (WebCore::TrackList::create):
  5450. (WebCore::TrackList::TrackList):
  5451. (WebCore::TrackList::~TrackList):
  5452. (WebCore::TrackList::length):
  5453. (WebCore::TrackList::checkIndex):
  5454. (WebCore::TrackList::getID):
  5455. (WebCore::TrackList::getKind):
  5456. (WebCore::TrackList::getLabel):
  5457. (WebCore::TrackList::getLanguage):
  5458. (WebCore::TrackList::clear):
  5459. (WebCore::TrackList::postChangeEvent):
  5460. (WebCore::TrackList::dispatchChangeEvent):
  5461. (WebCore::TrackList::toTrackList):
  5462. (WebCore::TrackList::scriptExecutionContext):
  5463. (WebCore::TrackList::eventTargetData):
  5464. (WebCore::TrackList::ensureEventTargetData):
  5465. * dom/TrackList.h: Added.
  5466. (WebCore::Track::id):
  5467. (WebCore::Track::kind):
  5468. (WebCore::Track::label):
  5469. (WebCore::Track::language):
  5470. (WebCore::TrackList::DispatchTask::create):
  5471. (WebCore::TrackList::DispatchTask::performTask):
  5472. (WebCore::TrackList::DispatchTask::DispatchTask):
  5473. (WebCore::TrackList::refEventTarget):
  5474. (WebCore::TrackList::derefEventTarget):
  5475. * dom/TrackList.idl: Added.
  5476. 2011-05-25 Keishi Hattori <keishi@webkit.org>
  5477. Reviewed by Kent Tamura.
  5478. Move ElementWithPseudoId to separate file
  5479. https://bugs.webkit.org/show_bug.cgi?id=61430
  5480. No new tests because no behavior changes.
  5481. * CMakeLists.txt: Added ElementWithPseudoId.cpp
  5482. * GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
  5483. * WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
  5484. * WebCore.pro: Added ElementWithPseudoId.{h,cpp}
  5485. * WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
  5486. * WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
  5487. * html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
  5488. * html/shadow/ElementWithPseudoId.cpp: Added.
  5489. (WebCore::ElementWithPseudoId::shadowPseudoId):
  5490. * html/shadow/ElementWithPseudoId.h: Added.
  5491. (WebCore::ElementWithPseudoId::create):
  5492. (WebCore::ElementWithPseudoId::ElementWithPseudoId):
  5493. 2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
  5494. Reviewed by Antonio Gomes.
  5495. [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
  5496. https://bugs.webkit.org/show_bug.cgi?id=34635
  5497. Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
  5498. two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
  5499. application with -style plastique for example, therefore the code used for other styles should also be
  5500. used whenever the current style is not the Mac style.
  5501. * platform/qt/ScrollbarThemeQt.cpp:
  5502. (WebCore::ScrollbarThemeQt::paint):
  5503. 2011-05-25 Yuta Kitamura <yutak@chromium.org>
  5504. Reviewed by Kent Tamura.
  5505. WebSocket: Use fail() when WebSocketChannel has failed
  5506. https://bugs.webkit.org/show_bug.cgi?id=61353
  5507. An existing error message has been modified, but it is impossible
  5508. to test this message in LayoutTests because it is only shown when
  5509. memory allocation has failed, which is hard to reproduce reliably.
  5510. One new message has been added. It is covered by an existing test
  5511. http/tests/websocket/tests/frame-length-overflow.html.
  5512. There is no other change in behavior. No new tests are added.
  5513. * websockets/WebSocketChannel.cpp:
  5514. (WebCore::WebSocketChannel::fail):
  5515. Do not close if we know the socket stream is already closed. This does not
  5516. change the behavior, because SocketStreamBase does nothing if it is already
  5517. closed.
  5518. (WebCore::WebSocketChannel::didOpen):
  5519. (WebCore::WebSocketChannel::didReceiveData):
  5520. We need to set m_shouldDiscardReceivedData to true before calling fail(),
  5521. so I moved the error message from appendToBuffer() to here.
  5522. The error message was rephrased in order to improve readability.
  5523. (WebCore::WebSocketChannel::appendToBuffer):
  5524. Unnested the code.
  5525. (WebCore::WebSocketChannel::processBuffer):
  5526. 2011-05-16 Alexander Pavlov <apavlov@chromium.org>
  5527. Reviewed by David Levin.
  5528. CSSParser: m_implicitShorthand should probably be RAII
  5529. https://bugs.webkit.org/show_bug.cgi?id=51586
  5530. It was impossible to entirely eliminate the m_implicitShorthand manual changes
  5531. due to the parseFill*() method stateful call chains.
  5532. No new tests, as this is a refactoring.
  5533. * css/CSSParser.cpp:
  5534. (ImplicitScope::ImplicitScope):
  5535. (ImplicitScope::~ImplicitScope):
  5536. (WebCore::CSSParser::parseShorthand):
  5537. (WebCore::CSSParser::parse4Values):
  5538. (WebCore::CSSParser::parseBorderRadius):
  5539. 2011-05-24 Pavel Podivilov <podivilov@chromium.org>
  5540. Reviewed by Yury Semikhatsky.
  5541. Web Inspector: inspected page crashes when call stack is empty after live edit.
  5542. https://bugs.webkit.org/show_bug.cgi?id=61364
  5543. * bindings/v8/ScriptDebugServer.cpp:
  5544. (WebCore::ScriptDebugServer::currentCallFrame):
  5545. 2011-05-23 Yury Semikhatsky <yurys@chromium.org>
  5546. Reviewed by Adam Barth.
  5547. Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
  5548. https://bugs.webkit.org/show_bug.cgi?id=61194
  5549. Test: inspector/console/console-eval-syntax-error.html
  5550. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  5551. (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
  5552. 2011-05-25 Yuzo Fujishima <yuzo@google.com>
  5553. Reviewed by Kent Tamura.
  5554. Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
  5555. https://bugs.webkit.org/show_bug.cgi?id=61352
  5556. No new tests because no behavior changes.
  5557. * html/shadow/MediaControlElements.cpp:
  5558. (WebCore::RenderMediaVolumeSliderContainer::layout):
  5559. * page/FrameView.cpp:
  5560. (WebCore::FrameView::layout):
  5561. * rendering/RenderBlock.cpp:
  5562. (WebCore::RenderBlock::repaintOverhangingFloats):
  5563. (WebCore::RenderBlock::updateFirstLetter):
  5564. * rendering/RenderLayer.cpp:
  5565. (WebCore::RenderLayer::updateLayerPositions):
  5566. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  5567. * rendering/RenderListBox.cpp:
  5568. (WebCore::RenderListBox::layout):
  5569. * rendering/RenderListItem.cpp:
  5570. (WebCore::RenderListItem::updateMarkerLocation):
  5571. * rendering/RenderMedia.cpp:
  5572. (WebCore::RenderMedia::layout):
  5573. * rendering/RenderView.h:
  5574. (WebCore::RenderView::disableLayoutState):
  5575. (WebCore::RenderView::enableLayoutState):
  5576. (WebCore::LayoutStateDisabler::LayoutStateDisabler):
  5577. (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
  5578. * rendering/svg/RenderSVGRoot.cpp:
  5579. (WebCore::RenderSVGRoot::layout):
  5580. 2011-05-24 Csaba Osztrogonác <ossy@webkit.org>
  5581. [Qt] Unreviewed typo fix after r87228.
  5582. * WebCore.pro:
  5583. 2011-05-24 Keishi Hattori <keishi@webkit.org>
  5584. Reviewed by Kent Tamura.
  5585. Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
  5586. https://bugs.webkit.org/show_bug.cgi?id=61273
  5587. Test: fast/forms/color/input-value-sanitization-color.html
  5588. * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
  5589. * GNUmakefile.am: Added COLOR_INPUT feature flag.
  5590. * features.pri: Added COLOR_INPUT feature flag.
  5591. * html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag.
  5592. (WebCore::ColorInputType::isColorControl): Added.
  5593. (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec.
  5594. (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
  5595. * html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag.
  5596. (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
  5597. * html/InputType.cpp:
  5598. (WebCore::InputType::isColorControl): Added.
  5599. * html/InputType.h:
  5600. 2011-05-24 Steve Lacey <sjl@chromium.org>
  5601. Reviewed by Eric Carlson.
  5602. Move chromium media controls timeline back to flexible rather than absolute
  5603. layout.
  5604. https://bugs.webkit.org/show_bug.cgi?id=61379
  5605. * css/mediaControlsChromium.css:
  5606. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  5607. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  5608. 2011-05-24 Fumitoshi Ukai <ukai@chromium.org>
  5609. Unreviewed. Fix clang error.
  5610. error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
  5611. NULL from a constant boolean expression [-Werror,-Wbool-conversio
  5612. * loader/archive/mhtml/MHTMLArchive.cpp:
  5613. (WebCore::MHTMLArchive::create):
  5614. 2011-05-24 Adam Barth <abarth@webkit.org>
  5615. Reviewed by Eric Seidel.
  5616. Add FIXME comments about removing FrameLoader::isProcessingUserGesture
  5617. https://bugs.webkit.org/show_bug.cgi?id=61395
  5618. All the callers of the API are wrong. They should call the more modern
  5619. static member function of ScriptController instead. I'll remove the
  5620. FrameLoader function in a future patch.
  5621. * html/HTMLMediaElement.cpp:
  5622. (WebCore::HTMLMediaElement::processingUserGesture):
  5623. * rendering/RenderFileUploadControl.cpp:
  5624. (WebCore::RenderFileUploadControl::click):
  5625. 2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  5626. Unreviewed. Fix style error.
  5627. * platform/efl/WidgetEfl.cpp:
  5628. (WebCore::WidgetPrivate::WidgetPrivate):
  5629. 2011-05-24 Greg Simon <gregsimon@chromium.org>
  5630. Reviewed by Dimitri Glazkov.
  5631. Control Indexeddb backends from LayoutTestController
  5632. https://bugs.webkit.org/show_bug.cgi?id=61000
  5633. Test: storage/indexeddb/migrate-basics.html
  5634. * storage/IDBBackingStore.h:
  5635. * storage/IDBFactoryBackendImpl.cpp:
  5636. (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
  5637. (WebCore::IDBFactoryBackendImpl::open):
  5638. (WebCore::IDBFactoryBackendImpl::setEnableMigration):
  5639. (WebCore::IDBFactoryBackendImpl::migrate):
  5640. * storage/IDBFactoryBackendImpl.h:
  5641. * storage/IDBFactoryBackendInterface.h:
  5642. * storage/IDBLevelDBBackingStore.cpp:
  5643. (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  5644. * storage/IDBLevelDBBackingStore.h:
  5645. (WebCore::IDBLevelDBBackingStore::backingStoreType):
  5646. * storage/IDBSQLiteBackingStore.cpp:
  5647. (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  5648. * storage/IDBSQLiteBackingStore.h:
  5649. (WebCore::IDBSQLiteBackingStore::backingStoreType):
  5650. 2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
  5651. Reviewed by Ryosuke Niwa.
  5652. [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
  5653. https://bugs.webkit.org/show_bug.cgi?id=60692
  5654. Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
  5655. before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.
  5656. Test: editing/pasteboard/drag-drop-input-in-svg.svg
  5657. * editing/ReplaceSelectionCommand.cpp:
  5658. (WebCore::ReplacementFragment::ReplacementFragment):
  5659. 2011-05-24 Andy Estes <aestes@apple.com>
  5660. Reviewed by Geoffrey Garen.
  5661. REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
  5662. https://bugs.webkit.org/show_bug.cgi?id=61229
  5663. This site-specific hack maintains compatibility with Mac OS X Wiki Server,
  5664. which embeds QuickTime movies using an object tag containing QuickTime's
  5665. ActiveX classid. Treat this classid as valid only if OS X Server's unique
  5666. 'generator' meta tag is present. Only apply this quirk if there is no
  5667. fallback content, which ensures the quirk will disable itself if Wiki
  5668. Server is updated to generate an alternate embed tag as fallback content.
  5669. * html/HTMLObjectElement.cpp:
  5670. (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return
  5671. true if site-specific quirks are enabled, the object element has no
  5672. fallback content, the classid attribute matches QuickTime's classid and
  5673. the document has a 'generator' meta tag matching Mac OS X Web Services
  5674. Server's unique generator string.
  5675. (WebCore::HTMLObjectElement::hasValidClassId): Call
  5676. shouldAllowQuickTimeClassIdQuirk()
  5677. * html/HTMLObjectElement.h:
  5678. 2011-05-24 Nate Chapin <japhet@chromium.org>
  5679. Reviewed by Adam Barth.
  5680. Change CachedResources to take a ResourceRequest instead of
  5681. a url in their constructors and provide a very minimal set of
  5682. cases for avoiding reusing a CachedResource. The ResourceRequest
  5683. part of this change requires pushing responsibility
  5684. for calling Document::completeURL() to the caller, instead of
  5685. CachedResourceLoader, since ResourceRequest ASSERTs if it
  5686. is constructed with an invalid url.
  5687. https://bugs.webkit.org/show_bug.cgi?id=61318
  5688. Refactor, no new tests.
  5689. * css/CSSFontSelector.cpp:
  5690. (WebCore::CSSFontSelector::addFontFaceRule):
  5691. * css/CSSImageValue.cpp:
  5692. (WebCore::CSSImageValue::cachedImage):
  5693. * css/CSSImportRule.cpp:
  5694. (WebCore::CSSImportRule::insertedIntoParent):
  5695. * dom/ProcessingInstruction.cpp:
  5696. (WebCore::ProcessingInstruction::checkStyleSheet):
  5697. * dom/ScriptElement.cpp:
  5698. (WebCore::ScriptElement::requestScript):
  5699. * html/HTMLLinkElement.cpp:
  5700. (WebCore::HTMLLinkElement::process):
  5701. * loader/ImageLoader.cpp:
  5702. (WebCore::ImageLoader::updateFromElement):
  5703. * loader/cache/CachedCSSStyleSheet.cpp:
  5704. (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  5705. (WebCore::CachedCSSStyleSheet::didAddClient):
  5706. (WebCore::CachedCSSStyleSheet::checkNotify):
  5707. * loader/cache/CachedCSSStyleSheet.h:
  5708. * loader/cache/CachedFont.cpp:
  5709. (WebCore::CachedFont::CachedFont):
  5710. * loader/cache/CachedFont.h:
  5711. * loader/cache/CachedImage.cpp:
  5712. (WebCore::CachedImage::CachedImage):
  5713. (WebCore::CachedImage::checkShouldPaintBrokenImage):
  5714. * loader/cache/CachedImage.h:
  5715. * loader/cache/CachedResource.cpp:
  5716. (WebCore::CachedResource::CachedResource):
  5717. (WebCore::reuseRequest):
  5718. (WebCore::CachedResource::allowReuseOfRequest):
  5719. (WebCore::CachedResource::removeClient):
  5720. (WebCore::CachedResource::canUseCacheValidator):
  5721. * loader/cache/CachedResource.h:
  5722. (WebCore::CachedResource::resourceRequest):
  5723. (WebCore::CachedResource::url):
  5724. * loader/cache/CachedResourceLoader.cpp:
  5725. * loader/cache/CachedResourceLoader.h:
  5726. * loader/cache/CachedResourceRequest.cpp:
  5727. (WebCore::CachedResourceRequest::load):
  5728. * loader/cache/CachedScript.cpp:
  5729. (WebCore::CachedScript::CachedScript):
  5730. * loader/cache/CachedScript.h:
  5731. * loader/cache/CachedXSLStyleSheet.cpp:
  5732. (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  5733. (WebCore::CachedXSLStyleSheet::didAddClient):
  5734. (WebCore::CachedXSLStyleSheet::checkNotify):
  5735. * loader/cache/CachedXSLStyleSheet.h:
  5736. * svg/SVGFEImageElement.cpp:
  5737. (WebCore::SVGFEImageElement::requestImageResource):
  5738. * svg/SVGFontFaceUriElement.cpp:
  5739. (WebCore::SVGFontFaceUriElement::loadFont):
  5740. * xml/XSLImportRule.cpp:
  5741. (WebCore::XSLImportRule::loadSheet):
  5742. 2011-05-24 Kent Tamura <tkent@chromium.org>
  5743. Reviewed by Dimitri Glazkov.
  5744. Use Element::shadowPseudoId() for text field decoration elements
  5745. https://bugs.webkit.org/show_bug.cgi?id=61351
  5746. No new tests. Covered by existing tests.
  5747. * css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
  5748. - -webkit-inner-spin-button
  5749. - -webkit-input-speech-button
  5750. - -webkit-outer-spin-button
  5751. - -webkit-search-cancel-button
  5752. - -webkit-search-decoration
  5753. - -webkit-search-results-button
  5754. - -webkit-search-results-decoration
  5755. (WebCore::CSSSelector::pseudoId):
  5756. (WebCore::nameToPseudoTypeMap):
  5757. (WebCore::CSSSelector::extractPseudoType):
  5758. * css/CSSSelector.h: ditto.
  5759. * css/CSSStyleSelector.cpp:
  5760. (WebCore::CSSStyleSelector::matchRules):
  5761. Store shadowPseudoId() result in a local variable because
  5762. SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
  5763. * html/shadow/TextControlInnerElements.cpp:
  5764. Override Element::shadowPseudoId() instead of Element::styleForRenderer().
  5765. (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
  5766. (WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
  5767. (WebCore::SpinButtonElement::shadowPseudoId):
  5768. (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
  5769. * html/shadow/TextControlInnerElements.h: Update declarations.
  5770. * rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
  5771. * rendering/RenderTextControlSingleLine.h: ditto.
  5772. * rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.
  5773. 2011-05-24 Dimitri Glazkov <dglazkov@chromium.org>
  5774. Sorted WebCore.xcodeproj again.
  5775. * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
  5776. 2011-05-24 Stephanie Lewis <slewis@apple.com>
  5777. Reviewed by Geoff Garen.
  5778. https://bugs.webkit.org/show_bug.cgi?id=61345
  5779. part of <rdar://problem/8675177>
  5780. Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
  5781. Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
  5782. Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
  5783. Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
  5784. No new tests because functionality has not changed.
  5785. * platform/network/ResourceResponseBase.cpp:
  5786. (WebCore::ResourceResponseBase::adopt):
  5787. (WebCore::ResourceResponseBase::suggestedFilename):
  5788. (WebCore::ResourceResponseBase::setSuggestedFilename):
  5789. (WebCore::ResourceResponseBase::httpStatusText):
  5790. (WebCore::ResourceResponseBase::setHTTPStatusText):
  5791. (WebCore::ResourceResponseBase::httpHeaderField):
  5792. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  5793. (WebCore::ResourceResponseBase::httpHeaderFields):
  5794. (WebCore::ResourceResponseBase::isAttachment):
  5795. (WebCore::ResourceResponseBase::setLastModifiedDate):
  5796. (WebCore::ResourceResponseBase::lastModifiedDate):
  5797. (WebCore::ResourceResponseBase::wasCached):
  5798. (WebCore::ResourceResponseBase::connectionReused):
  5799. (WebCore::ResourceResponseBase::setConnectionReused):
  5800. (WebCore::ResourceResponseBase::connectionID):
  5801. (WebCore::ResourceResponseBase::setConnectionID):
  5802. (WebCore::ResourceResponseBase::resourceLoadTiming):
  5803. (WebCore::ResourceResponseBase::setResourceLoadTiming):
  5804. (WebCore::ResourceResponseBase::resourceLoadInfo):
  5805. (WebCore::ResourceResponseBase::setResourceLoadInfo):
  5806. * platform/network/ResourceResponseBase.h:
  5807. * platform/network/cf/ResourceResponse.h:
  5808. (WebCore::ResourceResponse::ResourceResponse):
  5809. * platform/network/cf/ResourceResponseCFNet.cpp:
  5810. (WebCore::ResourceResponse::platformLazyInit):
  5811. * platform/network/mac/ResourceResponseMac.mm:
  5812. (WebCore::ResourceResponse::platformLazyInit):
  5813. 2011-05-24 Michael Saboff <msaboff@apple.com>
  5814. Reviewed by Geoffrey Garen.
  5815. Improve handling in WebCore of low memory situations
  5816. https://bugs.webkit.org/show_bug.cgi?id=61222
  5817. Added new class, MemoryPressureHandler, to platform to respond to low
  5818. system memory events. Added Mac specific implementation that reduces the
  5819. page cache, NSURL cache, WebCore cache by half their current usage
  5820. and then garbage collects. This can allow Safari to continue operating
  5821. in a low memory situation with minimal paging.
  5822. Split up prune operations in MemoryCache to allow for pruning to a
  5823. specific actual size to support this change.
  5824. No tests added as the functionality of WebKit wasn't changed.
  5825. * GNUmakefile.list.am:
  5826. * WebCore.exp.in:
  5827. * WebCore.gypi:
  5828. * WebCore.pro:
  5829. * WebCore.vcproj/WebCore.vcproj:
  5830. * WebCore.xcodeproj/project.pbxproj:
  5831. * loader/cache/MemoryCache.cpp:
  5832. (WebCore::MemoryCache::pruneLiveResources):
  5833. (WebCore::MemoryCache::forcePruneLiveResources):
  5834. (WebCore::MemoryCache::pruneLiveResourcesToTarget):
  5835. (WebCore::MemoryCache::pruneDeadResources):
  5836. (WebCore::MemoryCache::forcePruneDeadResources):
  5837. (WebCore::MemoryCache::pruneDeadResourcesToTarget):
  5838. * loader/cache/MemoryCache.h:
  5839. (WebCore::MemoryCache::forcePrune):
  5840. * platform/MemoryPressureHandler.cpp: Added.
  5841. (WebCore::memoryPressureHandler):
  5842. (WebCore::MemoryPressureHandler::MemoryPressureHandler):
  5843. (WebCore::MemoryPressureHandler::install):
  5844. (WebCore::MemoryPressureHandler::respondToMemoryPressure):
  5845. * platform/MemoryPressureHandler.h: Added.
  5846. * platform/mac/MemoryPressureHandler.mm: Added.
  5847. (WebCore::MemoryPressureHandler::install):
  5848. (WebCore::MemoryPressureHandler::respondToMemoryPressure):
  5849. 2011-05-24 Kent Tamura <tkent@chromium.org>
  5850. Reviewed by Dimitri Glazkov.
  5851. Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
  5852. https://bugs.webkit.org/show_bug.cgi?id=61398
  5853. shadowAncestorNode() and shadowTreeRootNode() should be const
  5854. though they can return 'this' pointer.
  5855. No new tests. This doesn't change any visible behavior.
  5856. * dom/Node.cpp:
  5857. (WebCore::Node::shadowAncestorNode): Make this const.
  5858. (WebCore::Node::shadowTreeRootNode): ditto.
  5859. * dom/Node.h: Update declarations.
  5860. * html/shadow/TextControlInnerElements.h:
  5861. (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>.
  5862. (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.
  5863. 2011-05-24 James Simonsen <simonjam@chromium.org>
  5864. Reviewed by Eric Seidel.
  5865. ASSERT_NOT_REACHED reached with broken ideograph and system fallback
  5866. https://bugs.webkit.org/show_bug.cgi?id=53528
  5867. Test: fast/text/justify-ideograph-vertical.html (on chromium linux)
  5868. * platform/graphics/FontFastPath.cpp:
  5869. (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
  5870. * platform/graphics/SimpleFontData.h:
  5871. (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.
  5872. 2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>
  5873. Reviewed by Andreas Kling.
  5874. [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
  5875. https://bugs.webkit.org/show_bug.cgi?id=60377
  5876. LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
  5877. We do not need assert for the useProgram as program can be null.
  5878. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  5879. (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.
  5880. 2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
  5881. Reviewed by Darin Adler.
  5882. Undo gets broken in contenteditable area when a text field's value is set by script
  5883. https://bugs.webkit.org/show_bug.cgi?id=61340
  5884. The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
  5885. calling clearUndoRedoOperations whenever script sets new value to input or textarea.
  5886. Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
  5887. was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
  5888. and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.
  5889. Test: editing/undo/undo-after-setting-value.html
  5890. * rendering/RenderTextControl.cpp:
  5891. (WebCore::RenderTextControl::setInnerTextValue):
  5892. 2011-05-24 Dan Bernstein <mitz@apple.com>
  5893. Reviewed by Dave Hyatt.
  5894. Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
  5895. https://bugs.webkit.org/show_bug.cgi?id=61392
  5896. * platform/graphics/mac/SimpleFontDataMac.mm:
  5897. (WebCore::fontHasVerticalGlyphs): Moved code here...
  5898. (WebCore::SimpleFontData::platformInit): ...from here.
  5899. 2011-05-24 Kenneth Russell <kbr@google.com>
  5900. Reviewed by James Robinson.
  5901. Implement Float64Array
  5902. https://bugs.webkit.org/show_bug.cgi?id=39144
  5903. Implemented Float64Array based on the existing Float32Array sources.
  5904. Built and tested in Chromium on Linux and Mac OS X and Safari on Mac OS X.
  5905. * CMakeLists.txt:
  5906. * CodeGenerators.pri:
  5907. * DerivedSources.cpp:
  5908. * DerivedSources.make:
  5909. * GNUmakefile.list.am:
  5910. * UseJSC.cmake:
  5911. * WebCore.gypi:
  5912. * WebCore.pro:
  5913. * WebCore.vcproj/WebCore.vcproj:
  5914. * WebCore.xcodeproj/project.pbxproj:
  5915. * bindings/js/JSBindingsAllInOne.cpp:
  5916. * bindings/js/JSDOMWindowCustom.cpp:
  5917. (WebCore::JSDOMWindow::float64Array):
  5918. * bindings/js/JSFloat64ArrayCustom.cpp: Added.
  5919. (WebCore::JSFloat64Array::indexSetter):
  5920. (WebCore::toJS):
  5921. (WebCore::JSFloat64Array::set):
  5922. (WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
  5923. * bindings/v8/custom/V8Float64ArrayCustom.cpp: Added.
  5924. (WebCore::V8Float64Array::constructorCallback):
  5925. (WebCore::V8Float64Array::setCallback):
  5926. (WebCore::toV8):
  5927. * html/canvas/ArrayBufferView.h:
  5928. (WebCore::ArrayBufferView::isDoubleArray):
  5929. * html/canvas/Float64Array.cpp: Added.
  5930. (WebCore::Float64Array::create):
  5931. (WebCore::Float64Array::Float64Array):
  5932. (WebCore::Float64Array::subarray):
  5933. * html/canvas/Float64Array.h: Added.
  5934. (WebCore::Float64Array::set):
  5935. (WebCore::Float64Array::item):
  5936. (WebCore::Float64Array::isDoubleArray):
  5937. * html/canvas/Float64Array.idl: Added.
  5938. * page/DOMWindow.idl:
  5939. * workers/WorkerContext.idl:
  5940. 2011-05-24 Simon Fraser <simon.fraser@apple.com>
  5941. Reviewed by Chris Marrin.
  5942. Add ability to set compositing layer bounds origin
  5943. https://bugs.webkit.org/show_bug.cgi?id=61381
  5944. On Core Animation layers, the origin of the bounds
  5945. rectangle affects where layer content is rendered, as well
  5946. as the offset of sublayers. Currently we always set the
  5947. bounds offset to a zero point, but may need to make use
  5948. of the bounds offset in future, so expose it via GraphicsLayer.
  5949. * platform/graphics/GraphicsLayer.h:
  5950. (WebCore::GraphicsLayer::boundsOrigin):
  5951. (WebCore::GraphicsLayer::setBoundsOrigin):
  5952. * platform/graphics/ca/GraphicsLayerCA.cpp:
  5953. (WebCore::GraphicsLayerCA::setSize):
  5954. (WebCore::GraphicsLayerCA::setBoundsOrigin):
  5955. (WebCore::GraphicsLayerCA::setAllowTiledLayer):
  5956. (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
  5957. (WebCore::GraphicsLayerCA::updateBounds):
  5958. (WebCore::GraphicsLayerCA::ensureStructuralLayer):
  5959. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  5960. * platform/graphics/ca/GraphicsLayerCA.h:
  5961. 2011-05-24 Leandro Pereira <leandro@profusion.mobi>
  5962. [EFL] Build fix.
  5963. * CMakeLists.txt: Also build platform/network/ContentTypeParser.cpp,
  5964. added by r86289.
  5965. 2011-05-24 Leandro Pereira <leandro@profusion.mobi>
  5966. [EFL] Build fix.
  5967. * bridge/runtime_root.cpp: Include <heap/Weak.h> instead of
  5968. <JavaScriptCore/Weak.h>.
  5969. 2011-05-24 Jay Civelli <jcivelli@chromium.org>
  5970. Reviewed by Adam Barth.
  5971. Adding MHTML reading support. That required some basic MIME header parsing.
  5972. Modified DocumentLoader to keep a reference to the currently Archive loaded,
  5973. so we can have different policies for loading subresources depending on the
  5974. archive type.
  5975. https://bugs.webkit.org/show_bug.cgi?id=7168
  5976. * CMakeLists.txt:
  5977. * Configurations/FeatureDefines.xcconfig:
  5978. * GNUmakefile.am:
  5979. * GNUmakefile.list.am:
  5980. * WebCore.gyp/WebCore.gyp:
  5981. * WebCore.gypi:
  5982. * WebCore.pro:
  5983. * WebCore.vcproj/WebCore.vcproj:
  5984. * WebCore.xcodeproj/project.pbxproj:
  5985. * features.pri:
  5986. * loader/DocumentLoader.cpp:
  5987. (WebCore::DocumentLoader::commitLoad):
  5988. (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  5989. (WebCore::DocumentLoader::popArchiveForSubframe):
  5990. (WebCore::DocumentLoader::scheduleArchiveLoad):
  5991. * loader/DocumentLoader.h:
  5992. * loader/FrameLoader.cpp:
  5993. (WebCore::FrameLoader::loadURLIntoChildFrame):
  5994. (WebCore::FrameLoader::loadArchive):
  5995. (WebCore::FrameLoader::stopAllLoaders):
  5996. (WebCore::FrameLoader::finishedLoadingDocument):
  5997. * loader/FrameLoader.h:
  5998. (WebCore::FrameLoader::archive):
  5999. * loader/MainResourceLoader.cpp:
  6000. (WebCore::MainResourceLoader::continueAfterContentPolicy):
  6001. * loader/ResourceLoader.cpp:
  6002. (WebCore::ResourceLoader::start):
  6003. * loader/archive/Archive.cpp: Added.
  6004. * loader/archive/Archive.h:
  6005. (WebCore::Archive::mainResource):
  6006. * loader/archive/ArchiveFactory.cpp:
  6007. (WebCore::archiveFactoryCreate):
  6008. (WebCore::archiveMIMETypes):
  6009. (WebCore::ArchiveFactory::create):
  6010. (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
  6011. * loader/archive/ArchiveFactory.h:
  6012. * loader/archive/ArchiveResourceCollection.cpp:
  6013. (WebCore::ArchiveResourceCollection::addAllResources):
  6014. (WebCore::ArchiveResourceCollection::popSubframeArchive):
  6015. * loader/archive/ArchiveResourceCollection.h:
  6016. * loader/archive/cf/LegacyWebArchive.cpp:
  6017. (WebCore::LegacyWebArchive::create):
  6018. (WebCore::LegacyWebArchive::type):
  6019. * loader/archive/cf/LegacyWebArchive.h:
  6020. * loader/archive/mhtml/MHTMLArchive.cpp: Added.
  6021. * loader/archive/mhtml/MHTMLArchive.h: Added.
  6022. * loader/archive/mhtml/MHTMLParser.cpp: Added.
  6023. * loader/archive/mhtml/MHTMLParser.h: Added.
  6024. * platform/MIMETypeRegistry.cpp:
  6025. (WebCore::initializeSupportedNonImageMimeTypes):
  6026. * platform/mac/PasteboardMac.mm:
  6027. (WebCore::Pasteboard::documentFragment):
  6028. * platform/network/MIMEHeader.cpp: Added.
  6029. * platform/network/MIMEHeader.h: Added.
  6030. 2011-05-24 Geoffrey Garen <ggaren@apple.com>
  6031. Try to fix some builds: #include Weak.h for Weak<T>.
  6032. * bridge/runtime_root.h:
  6033. 2011-05-24 Sam Weinig <sam@webkit.org>
  6034. Reviewed by Beth Dakin.
  6035. Can't scroll scaled page that has overflow:hidden on its root
  6036. <rdar://problem/9029189>
  6037. https://bugs.webkit.org/show_bug.cgi?id=61339
  6038. Test: fast/events/scroll-in-scaled-page-with-overflow-hidden.html
  6039. * page/FrameView.cpp:
  6040. (WebCore::FrameView::applyOverflowToViewport):
  6041. Scrollbars should be enabled for the viewport when scaled, even if overflow:hidden
  6042. is specified.
  6043. 2011-05-24 Adam Roben <aroben@apple.com>
  6044. Leopard build fix
  6045. * bridge/runtime_root.cpp: Added a missing #include.
  6046. 2011-05-24 Jian Li <jianli@chromium.org>
  6047. Reviewed by Kenneth Russell.
  6048. Make start parameter of Blob.slice optional.
  6049. https://bugs.webkit.org/show_bug.cgi?id=59628
  6050. The start parameter should be optional per the latest FILE API
  6051. spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob.
  6052. * fileapi/Blob.h:
  6053. * fileapi/Blob.idl: Make start parameter optional.
  6054. 2011-05-24 Adam Roben <aroben@apple.com>
  6055. Invalidate RuntimeObjects when they are finalized
  6056. This will cause the underlying NPObject to be released at finalization time, rather than at
  6057. destruction time (which is unpredictable and could occur after the plugin has been
  6058. unloaded).
  6059. Test: plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html
  6060. Fixes <http://webkit.org/b/61317> <rdar://problem/9489829> Crash in _NPN_DeallocateObject
  6061. when reloading yahoo.com webarchive in WebKit1
  6062. Reviewed by Oliver Hunt.
  6063. * bridge/runtime_object.cpp:
  6064. (JSC::Bindings::RuntimeObject::~RuntimeObject): Assert that we've already been invalidated.
  6065. * bridge/runtime_root.cpp:
  6066. (JSC::Bindings::RootObject::invalidate):
  6067. (JSC::Bindings::RootObject::addRuntimeObject):
  6068. Updated for m_runtimeObjects type change.
  6069. (JSC::Bindings::RootObject::finalize): Added. Invalidates the RuntimeObject and removes it
  6070. from the map.
  6071. * bridge/runtime_root.h: Now inherits from WeakHandleOwner.
  6072. Changed m_runtimeObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will
  6073. be notified when the RuntimeObjects are finalized.
  6074. 2011-05-24 Mike Reed <reed@google.com>
  6075. Reviewed by Kenneth Russell.
  6076. skia: fix stroking of zero-height rectangles
  6077. https://bugs.webkit.org/show_bug.cgi?id=61284
  6078. Tests: canvas/philip/tests/2d.line.miter.lineedge.html
  6079. canvas/philip/tests/2d.strokeRect.zero.4.html
  6080. * platform/graphics/skia/GraphicsContextSkia.cpp:
  6081. (WebCore::GraphicsContext::strokeRect):
  6082. 2011-05-24 Zan Dobersek <zandobersek@gmail.com> and Philippe Normand <pnormand@igalia.com>
  6083. Reviewed by Kenneth Russell.
  6084. Enable FloatArray usage outside WebGL guards
  6085. https://bugs.webkit.org/show_bug.cgi?id=61356
  6086. * webaudio/AudioBuffer.cpp:
  6087. * webaudio/AudioBuffer.idl:
  6088. * webaudio/RealtimeAnalyser.cpp:
  6089. * webaudio/RealtimeAnalyser.h:
  6090. * webaudio/RealtimeAnalyserNode.h:
  6091. * webaudio/RealtimeAnalyserNode.idl:
  6092. 2011-05-24 Adam Klein <adamk@chromium.org>
  6093. Unreviewed, rolling out r87145.
  6094. http://trac.webkit.org/changeset/87145
  6095. https://bugs.webkit.org/show_bug.cgi?id=61194
  6096. Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
  6097. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  6098. (WebCore::V8InjectedScriptHost::evaluateCallback):
  6099. 2011-05-24 Matthew Delaney <mdelaney@apple.com>
  6100. Reviewed by Simon Fraser.
  6101. Clamp coordinates to integers for canvas create/getImageData routines
  6102. https://bugs.webkit.org/show_bug.cgi?id=61135
  6103. Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html
  6104. * html/HTMLCanvasElement.cpp:
  6105. (WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
  6106. * html/canvas/CanvasRenderingContext2D.cpp:
  6107. (WebCore::CanvasRenderingContext2D::createImageData):
  6108. (WebCore::CanvasRenderingContext2D::getImageData):
  6109. * platform/graphics/cg/ImageBufferDataCG.cpp:
  6110. (WebCore::ImageBufferData::getData):
  6111. 2011-05-24 Robin Dunn <robin@alldunn.com>
  6112. Reviewed by Kevin Ollivier.
  6113. [wx] Make sure x and y adjustments are applied to all operations, and fix the calculations
  6114. for the height and width checks to take into account x and y offsets.
  6115. https://bugs.webkit.org/show_bug.cgi?id=61367
  6116. * platform/graphics/wx/ImageWx.cpp:
  6117. (WebCore::Image::drawPattern):
  6118. 2011-05-24 Tony Chang <tony@chromium.org>
  6119. Reviewed by James Robinson.
  6120. fix render overflow computation for input type=range
  6121. https://bugs.webkit.org/show_bug.cgi?id=61132
  6122. Test: fast/forms/slider-hit-testing.html
  6123. We need to clear m_overflow otherwise we use the first
  6124. size of the slider for hit testing (i.e., changes to the size
  6125. cause problems). This only shows up if the thumb isn't contained
  6126. in the bounds of the slider. Making the range have a smaller height
  6127. than the thumb shows the bug.
  6128. * rendering/RenderSlider.cpp:
  6129. (WebCore::RenderSlider::layout): Clear the overflow during layout
  6130. so we re-compute the overflow based on the current size of the
  6131. slider.
  6132. 2011-05-24 Alok Priyadarshi <alokp@chromium.org>
  6133. Reviewed by James Robinson.
  6134. Enable skia gpu rendering for content layers
  6135. https://bugs.webkit.org/show_bug.cgi?id=56749
  6136. This patch adds gpu accelerated rendering for content and root layers.
  6137. Layer textures are updated in two stages:
  6138. 1. Paint: The non-accelerated path paints the layer contents into a bitmap.
  6139. The accelerated path paints into an SkPicture, which is essentially a display list.
  6140. 2. Upload: The non-accelerated path uploads the pixels obtained in the first stage to a texture.
  6141. The accelerated path renders the picture directly into the texture.
  6142. The accelerated path can be enabled by --enable-accelerated-drawing command-line flag in chromium.
  6143. Note that this patch does not accelerate the CG path on mac. We have two options here - use skia or accelrate CG path.
  6144. Any bugs should be caught by layout tests.
  6145. * platform/graphics/chromium/ContentLayerChromium.cpp:
  6146. (WebCore::ContentLayerChromium::createTextureUpdater):
  6147. * platform/graphics/chromium/LayerRendererChromium.cpp:
  6148. (WebCore::LayerRendererChromium::create):
  6149. (WebCore::LayerRendererChromium::LayerRendererChromium):
  6150. (WebCore::LayerRendererChromium::skiaContext):
  6151. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  6152. (WebCore::LayerRendererChromium::createRootLayerTextureUpdater):
  6153. * platform/graphics/chromium/LayerRendererChromium.h:
  6154. (WebCore::LayerRendererChromium::acceleratedDrawing):
  6155. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
  6156. (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
  6157. (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
  6158. (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
  6159. (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
  6160. (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer):
  6161. (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  6162. (WebCore::LayerTextureUpdaterSkPicture::clearFrameBuffer):
  6163. * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  6164. (WebCore::LayerTextureUpdaterSkPicture::orientation):
  6165. * platform/graphics/chromium/LayerTilerChromium.cpp:
  6166. (WebCore::LayerTilerChromium::updateRect):
  6167. (WebCore::LayerTilerChromium::draw):
  6168. 2011-05-24 Pavel Podivilov <podivilov@chromium.org>
  6169. Reviewed by Yury Semikhatsky.
  6170. Web Inspector: display keyboard shortcuts in scripts panel sidebar buttons tooltip text.
  6171. https://bugs.webkit.org/show_bug.cgi?id=61358
  6172. * English.lproj/localizedStrings.js:
  6173. * inspector/front-end/CallStackSidebarPane.js:
  6174. (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex):
  6175. (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  6176. * inspector/front-end/Panel.js:
  6177. (WebInspector.Panel.prototype.registerShortcut):
  6178. * inspector/front-end/ScriptsPanel.js:
  6179. (WebInspector.ScriptsPanel):
  6180. (WebInspector.ScriptsPanel.prototype._createSidebarButtons):
  6181. (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
  6182. 2011-05-24 Philippe Normand <pnormand@igalia.com>
  6183. Reviewed by Andres Kling.
  6184. JSAudioContextCustom doesn't encode errors
  6185. https://bugs.webkit.org/show_bug.cgi?id=61357
  6186. Fix AudioContext return values
  6187. * bindings/js/JSAudioContextCustom.cpp:
  6188. (WebCore::JSAudioContextConstructor::constructJSAudioContext):
  6189. 2011-05-24 Rob Buis <rbuis@rim.com>
  6190. Rubber-stamped by Dirk Schulze.
  6191. Remove requiresLayer inlines, already provided by RenderSVGModelObject.
  6192. * rendering/svg/RenderSVGHiddenContainer.h:
  6193. (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
  6194. * rendering/svg/RenderSVGImage.h:
  6195. 2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
  6196. Not reviewed, build fix.
  6197. Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
  6198. https://bugs.webkit.org/show_bug.cgi?id=60254
  6199. Forgot to rename the destructor.
  6200. * platform/graphics/SimpleFontData.h:
  6201. (WebCore::SimpleFontData::AdditionalFontData::~AdditionalFontData):
  6202. 2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
  6203. Not reviewed, build fix.
  6204. Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
  6205. https://bugs.webkit.org/show_bug.cgi?id=60254
  6206. Rename SimpleFontData::FontData subclass to AdditionalFontData, to avoid clashes with the WebCore::FontData class, which breaks the win build.
  6207. * platform/graphics/SimpleFontData.cpp:
  6208. (WebCore::SimpleFontData::SimpleFontData):
  6209. * platform/graphics/SimpleFontData.h:
  6210. (WebCore::SimpleFontData::fontData):
  6211. * svg/SVGFontData.h:
  6212. 2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
  6213. Reviewed by Antti Koivisto.
  6214. Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
  6215. https://bugs.webkit.org/show_bug.cgi?id=60254
  6216. First part:
  6217. Remove a long-standing layering violation in TextRun: it stores RenderObject/RenderSVGResource pointers for SVG Fonts support.
  6218. Replace the two Render* pointers with a single RefPtr<AbstractRenderingContext>. AbstractRenderingContext is a helper class,
  6219. that can be derived from in order to associate additional data with a TextRun. This effectively reduces the memory consumption of TextRun.
  6220. Introduce rendering/TextRunRenderingContext.h, which inherits from TextRun::AbstractRenderingContext and holds additional data.
  6221. If the primary font in use is a SVG Font then allocate a TextRunRenderingContext object and store it in the RefPtr<AbstractRenderingContext>
  6222. in TextRun. If the primary font is not a SVG Font, don't even allocate the TextRunRenderingContext structure, as we won't need the context data.
  6223. SVG Fonts glyph matching only works within a context, so we need access to the RenderObject that's drawing the text.
  6224. This is the main preparation patch for the SVG Fonts rewrite, that will allow us to share the simple text code path for SVG Fonts as well,
  6225. making all CSS text properties work for HTML text using SVG Fonts, and allows proper integration within the GlyphPage concept. Soon
  6226. we can intermix WOFF/SVG & native fonts, within segment font declarations.
  6227. Second part:
  6228. Remove a long-standing layering violation in SimpleFontData: it stores SVGFontData objects, that are living in svg/.
  6229. Use the same concept as above, introduce SimpleFontData::AbstractFontData, and let SVGFontData inherit from AbstractFontData and extent it.
  6230. If SVG Fonts are used, CSSFontFaceSource will create a SVGFontData object and pass it as PassOwnPtr<AbstractFontData> to SimpleFontData.
  6231. All layering violations are gone now, SVG Fonts are cleanly integrated now.
  6232. Doesn't affect any tests yet, refactoring only.
  6233. * CMakeLists.txt:
  6234. * GNUmakefile.list.am:
  6235. * WebCore.gypi:
  6236. * WebCore.pro:
  6237. * WebCore.vcproj/WebCore.vcproj:
  6238. * WebCore.xcodeproj/project.pbxproj:
  6239. * css/CSSFontFaceSource.cpp:
  6240. (WebCore::CSSFontFaceSource::getFontData):
  6241. * platform/graphics/Font.cpp:
  6242. (WebCore::Font::drawText):
  6243. (WebCore::Font::width):
  6244. (WebCore::Font::selectionRectForText):
  6245. (WebCore::Font::offsetForPosition):
  6246. * platform/graphics/Font.h:
  6247. * platform/graphics/SimpleFontData.cpp:
  6248. (WebCore::SimpleFontData::SimpleFontData):
  6249. (WebCore::SimpleFontData::~SimpleFontData):
  6250. * platform/graphics/SimpleFontData.h:
  6251. (WebCore::SimpleFontData::FontData::~FontData):
  6252. (WebCore::SimpleFontData::fontMetrics):
  6253. (WebCore::SimpleFontData::setMaxCharWidth):
  6254. (WebCore::SimpleFontData::setAvgCharWidth):
  6255. (WebCore::SimpleFontData::setSpaceWidth):
  6256. (WebCore::SimpleFontData::setSpaceGlyph):
  6257. (WebCore::SimpleFontData::setZeroWidthSpaceGlyph):
  6258. (WebCore::SimpleFontData::fontData):
  6259. (WebCore::SimpleFontData::isSVGFont):
  6260. (WebCore::SimpleFontData::setMissingGlyphData):
  6261. * platform/graphics/TextRun.h:
  6262. (WebCore::TextRun::TextRun):
  6263. (WebCore::TextRun::setAllowTabs):
  6264. (WebCore::TextRun::setXPos):
  6265. (WebCore::TextRun::RenderingContext::~RenderingContext):
  6266. (WebCore::TextRun::renderingContext):
  6267. (WebCore::TextRun::setRenderingContext):
  6268. * rendering/EllipsisBox.cpp:
  6269. (WebCore::EllipsisBox::paint):
  6270. (WebCore::EllipsisBox::selectionRect):
  6271. (WebCore::EllipsisBox::paintSelection):
  6272. * rendering/InlineTextBox.cpp:
  6273. (WebCore::InlineTextBox::selectionRect):
  6274. (WebCore::InlineTextBox::paint):
  6275. (WebCore::InlineTextBox::paintSelection):
  6276. (WebCore::InlineTextBox::paintCompositionBackground):
  6277. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  6278. (WebCore::InlineTextBox::paintTextMatchMarker):
  6279. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  6280. (WebCore::InlineTextBox::offsetForPosition):
  6281. (WebCore::InlineTextBox::positionForOffset):
  6282. (WebCore::InlineTextBox::constructTextRun):
  6283. * rendering/InlineTextBox.h:
  6284. * rendering/RenderBlock.cpp:
  6285. (WebCore::stripTrailingSpace):
  6286. (WebCore::RenderBlock::constructTextRun):
  6287. * rendering/RenderBlock.h:
  6288. * rendering/RenderBlockLineLayout.cpp:
  6289. (WebCore::setLogicalWidthForTextRun):
  6290. (WebCore::textWidth):
  6291. (WebCore::tryHyphenating):
  6292. (WebCore::RenderBlock::LineBreaker::nextLineBreak):
  6293. (WebCore::RenderBlock::checkLinesForTextOverflow):
  6294. * rendering/RenderCombineText.cpp:
  6295. (WebCore::RenderCombineText::combineText):
  6296. * rendering/RenderFileUploadControl.cpp:
  6297. (WebCore::RenderFileUploadControl::paintObject):
  6298. (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  6299. * rendering/RenderFlexibleBox.cpp:
  6300. (WebCore::RenderFlexibleBox::applyLineClamp):
  6301. * rendering/RenderImage.cpp:
  6302. (WebCore::RenderImage::setImageSizeForAltText):
  6303. (WebCore::RenderImage::paintReplaced):
  6304. * rendering/RenderListBox.cpp:
  6305. (WebCore::RenderListBox::updateFromElement):
  6306. * rendering/RenderListMarker.cpp:
  6307. (WebCore::RenderListMarker::paint):
  6308. (WebCore::RenderListMarker::computePreferredLogicalWidths):
  6309. (WebCore::RenderListMarker::getRelativeMarkerRect):
  6310. * rendering/RenderText.cpp:
  6311. (WebCore::RenderText::widthFromCache):
  6312. (WebCore::RenderText::trimmedPrefWidths):
  6313. (WebCore::RenderText::computePreferredLogicalWidths):
  6314. (WebCore::RenderText::width):
  6315. * rendering/RenderTextControl.cpp:
  6316. (WebCore::RenderTextControl::getAvgCharWidth):
  6317. * rendering/svg/RenderSVGAllInOne.cpp:
  6318. * rendering/svg/SVGInlineTextBox.cpp:
  6319. (WebCore::SVGInlineTextBox::offsetForPositionInFragment):
  6320. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting):
  6321. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):
  6322. (WebCore::SVGInlineTextBox::constructTextRun):
  6323. (WebCore::SVGInlineTextBox::paintText):
  6324. * rendering/svg/SVGTextLayoutEngineSpacing.cpp:
  6325. (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  6326. * rendering/svg/SVGTextMetrics.cpp:
  6327. (WebCore::constructTextRun):
  6328. (WebCore::SVGTextMetrics::measureCharacterRange):
  6329. * rendering/svg/SVGTextRunRenderingContext.cpp: Copied from svg/SVGFont.cpp.
  6330. (WebCore::svgFontAndFontFaceElementForFontData):
  6331. (WebCore::firstParentRendererForNonTextNode):
  6332. (WebCore::referencingRenderObjectFromRun):
  6333. (WebCore::activePaintingResourceFromRun):
  6334. (WebCore::SVGTextRunWalker::walk):
  6335. (WebCore::floatWidthMissingGlyphCallback):
  6336. (WebCore::floatWidthOfSubStringUsingSVGFont):
  6337. (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont):
  6338. (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
  6339. (WebCore::SVGTextRunRenderingContext::selectionRectForTextUsingSVGFont):
  6340. (WebCore::SVGTextRunRenderingContext::offsetForPositionForTextUsingSVGFont):
  6341. * rendering/svg/SVGTextRunRenderingContext.h: Added.
  6342. (WebCore::SVGTextRunRenderingContext::create):
  6343. (WebCore::SVGTextRunRenderingContext::context):
  6344. (WebCore::SVGTextRunRenderingContext::activePaintingResource):
  6345. (WebCore::SVGTextRunRenderingContext::setActivePaintingResource):
  6346. (WebCore::SVGTextRunRenderingContext::SVGTextRunRenderingContext):
  6347. (WebCore::textRunNeedsRenderingContext):
  6348. * svg/SVGAllInOne.cpp:
  6349. * svg/SVGFont.cpp: Removed.
  6350. * svg/SVGFontData.cpp:
  6351. (WebCore::SVGFontData::initializeFontData):
  6352. * svg/SVGFontData.h:
  6353. (WebCore::SVGFontData::create):
  6354. (WebCore::SVGFontData::isSVGFontData):
  6355. * svg/SVGGlyphElement.cpp:
  6356. (WebCore::SVGGlyphElement::SVGGlyphElement):
  6357. (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier):
  6358. (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  6359. * svg/SVGHKernElement.cpp:
  6360. (WebCore::SVGHKernElement::SVGHKernElement):
  6361. (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  6362. * svg/SVGVKernElement.cpp:
  6363. (WebCore::SVGVKernElement::SVGVKernElement):
  6364. (WebCore::SVGVKernElement::buildVerticalKerningPair):
  6365. * svg/SVGVKernElement.h:
  6366. 2011-05-24 Ryuan Choi <ryuan.choi@samsung.com>
  6367. Reviewed by Andreas Kling.
  6368. [GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
  6369. https://bugs.webkit.org/show_bug.cgi?id=60827
  6370. Implement getter/setter of imageInterpolationQuality and logic to change
  6371. interpolation algorithm when drawing image.
  6372. Mac and Qt already implemented it.
  6373. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  6374. (WebCore::GraphicsContext::setImageInterpolationQuality):
  6375. (WebCore::GraphicsContext::imageInterpolationQuality):
  6376. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  6377. * platform/graphics/cairo/PlatformContextCairo.cpp:
  6378. (WebCore::PlatformContextCairo::drawSurfaceToContext):
  6379. * platform/graphics/cairo/PlatformContextCairo.h:
  6380. (WebCore::PlatformContextCairo::setImageInterpolationQuality): Added.
  6381. (WebCore::PlatformContextCairo::imageInterpolationQuality): Added.
  6382. 2011-05-24 Leandro Gracia Gil <leandrogracia@chromium.org>
  6383. Reviewed by Tony Gentilcore.
  6384. Media Stream API: adding Stream and GeneratedStream classes.
  6385. https://bugs.webkit.org/show_bug.cgi?id=56666
  6386. Add the code for the Stream and GeneratedStream classes and integrate it
  6387. with the existing stream generation requests.
  6388. Tests for the Media Stream API will be provided by the bug 56587.
  6389. * CMakeLists.txt:
  6390. * CodeGenerators.pri:
  6391. * DerivedSources.cpp:
  6392. * DerivedSources.make:
  6393. * GNUmakefile.list.am:
  6394. * WebCore.gypi:
  6395. * WebCore.pro:
  6396. * WebCore.vcproj/WebCore.vcproj:
  6397. * WebCore.xcodeproj/project.pbxproj:
  6398. * bindings/js/JSEventTarget.cpp:
  6399. (WebCore::toJS):
  6400. * bindings/v8/V8DOMWrapper.cpp:
  6401. (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  6402. * dom/DOMAllInOne.cpp:
  6403. * dom/EventTarget.cpp:
  6404. (WebCore::EventTarget::toStream):
  6405. (WebCore::EventTarget::toGeneratedStream):
  6406. * dom/EventTarget.h:
  6407. * dom/GeneratedStream.cpp: Added.
  6408. (WebCore::GeneratedStream::DispatchUpdateTask::create):
  6409. (WebCore::GeneratedStream::DispatchUpdateTask::performTask):
  6410. (WebCore::GeneratedStream::DispatchUpdateTask::DispatchUpdateTask):
  6411. (WebCore::GeneratedStream::create):
  6412. (WebCore::GeneratedStream::GeneratedStream):
  6413. (WebCore::GeneratedStream::~GeneratedStream):
  6414. (WebCore::GeneratedStream::toGeneratedStream):
  6415. (WebCore::GeneratedStream::detachEmbedder):
  6416. (WebCore::GeneratedStream::stop):
  6417. (WebCore::GeneratedStream::onStop):
  6418. * dom/GeneratedStream.h: Added.
  6419. * dom/GeneratedStream.idl: Added.
  6420. * dom/Stream.cpp: Added.
  6421. (WebCore::Stream::create):
  6422. (WebCore::Stream::Stream):
  6423. (WebCore::Stream::~Stream):
  6424. (WebCore::Stream::toStream):
  6425. (WebCore::Stream::streamEnded):
  6426. (WebCore::Stream::scriptExecutionContext):
  6427. (WebCore::Stream::eventTargetData):
  6428. (WebCore::Stream::ensureEventTargetData):
  6429. * dom/Stream.h: Added.
  6430. (WebCore::Stream::readyState):
  6431. (WebCore::Stream::label):
  6432. (WebCore::Stream::refEventTarget):
  6433. (WebCore::Stream::derefEventTarget):
  6434. * dom/Stream.idl: Added.
  6435. * page/CallbackTask.h:
  6436. (WebCore::CallbackTask1::Scheduler::~Scheduler):
  6437. * page/MediaStreamClient.h:
  6438. * page/MediaStreamController.cpp:
  6439. (WebCore::MediaStreamController::stopGeneratedStream):
  6440. (WebCore::MediaStreamController::streamFailed):
  6441. * page/MediaStreamController.h:
  6442. * page/MediaStreamFrameController.cpp:
  6443. (WebCore::MediaStreamFrameController::Request::Request):
  6444. (WebCore::MediaStreamFrameController::GenerateStreamRequest::create):
  6445. (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
  6446. (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
  6447. (WebCore::MediaStreamFrameController::unregister):
  6448. (WebCore::MediaStreamFrameController::getStreamFromLabel):
  6449. (WebCore::MediaStreamFrameController::generateStream):
  6450. (WebCore::MediaStreamFrameController::stopGeneratedStream):
  6451. (WebCore::MediaStreamFrameController::streamGenerated):
  6452. (WebCore::MediaStreamFrameController::streamGenerationFailed):
  6453. (WebCore::MediaStreamFrameController::streamFailed):
  6454. * page/MediaStreamFrameController.h:
  6455. (WebCore::MediaStreamFrameController::StreamClient::StreamClient):
  6456. (WebCore::MediaStreamFrameController::StreamClient::isGeneratedStream):
  6457. * page/NavigatorUserMediaError.h:
  6458. (WebCore::NavigatorUserMediaError::create):
  6459. (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
  6460. * page/NavigatorUserMediaSuccessCallback.h:
  6461. * page/NavigatorUserMediaSuccessCallback.idl:
  6462. 2011-05-23 Antti Koivisto <antti@apple.com>
  6463. Reviewed by Oliver Hunt.
  6464. REGRESSION (r45620): Node list caches never deleted
  6465. https://bugs.webkit.org/show_bug.cgi?id=61268
  6466. <rdar://problem/9467379>
  6467. NodeListsNodeData::isEmpty() tests if RefCounted objects have refcount of zero which is impossible.
  6468. As a results NodeList caches are never deleted, causing bad performance in DOM mutating operations as
  6469. they repeatedly invalidate caches.
  6470. * dom/Node.cpp:
  6471. (WebCore::Node::childNodes):
  6472. Construct m_childNodeListCaches lazily.
  6473. (WebCore::Node::unregisterDynamicNodeList):
  6474. (WebCore::Node::notifyLocalNodeListsAttributeChanged):
  6475. (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  6476. (WebCore::Node::removeNodeListCacheIfPossible):
  6477. Add a helper.
  6478. (WebCore::NodeListsNodeData::invalidateCaches):
  6479. Invalidate m_childNodeListCaches by clearing it if there are no additional clients
  6480. (WebCore::NodeListsNodeData::isEmpty):
  6481. Test emptiness of various NodeListCaches simply by testing hash emptiness instead of testing for non-zero ref count of items.
  6482. m_childNodeListCaches is empty if it is null.
  6483. * dom/Node.h:
  6484. * dom/NodeRareData.h:
  6485. (WebCore::NodeListsNodeData::NodeListsNodeData):
  6486. Construct m_childNodeListCaches lazily.
  6487. 2011-05-24 Mikhail Naganov <mnaganov@chromium.org>
  6488. Reviewed by Yury Semikhatsky.
  6489. Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
  6490. https://bugs.webkit.org/show_bug.cgi?id=61300
  6491. * inspector/CodeGeneratorInspector.pm:
  6492. 2011-05-23 Yury Semikhatsky <yurys@chromium.org>
  6493. Reviewed by Adam Barth.
  6494. Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
  6495. https://bugs.webkit.org/show_bug.cgi?id=61194
  6496. Test: inspector/console/console-eval-syntax-error.html
  6497. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  6498. (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
  6499. 2011-04-13 Steve Block <steveblock@google.com>
  6500. Reviewed by Eric Seidel.
  6501. Geolocation callbacks should make use of new callback generation mechanism
  6502. https://bugs.webkit.org/show_bug.cgi?id=40065
  6503. No new tests, refactoring only.
  6504. * Android.derived.jscbindings.mk:
  6505. * Android.derived.v8bindings.mk:
  6506. * Android.jscbindings.mk:
  6507. * Android.v8bindings.mk:
  6508. * CMakeLists.txt:
  6509. * CodeGenerators.pri:
  6510. * DerivedSources.cpp:
  6511. * DerivedSources.make:
  6512. * GNUmakefile.list.am:
  6513. * UseJSC.cmake:
  6514. * WebCore.gypi:
  6515. * WebCore.order:
  6516. * WebCore.pro:
  6517. * WebCore.vcproj/WebCore.vcproj:
  6518. * WebCore.xcodeproj/project.pbxproj:
  6519. * bindings/js/JSBindingsAllInOne.cpp:
  6520. * bindings/js/JSCustomPositionCallback.cpp: Removed.
  6521. * bindings/js/JSCustomPositionCallback.h: Removed.
  6522. * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
  6523. * bindings/js/JSCustomPositionErrorCallback.h: Removed.
  6524. * bindings/js/JSGeolocationCustom.cpp:
  6525. (WebCore::JSGeolocation::getCurrentPosition):
  6526. (WebCore::JSGeolocation::watchPosition):
  6527. * bindings/v8/custom/V8CustomPositionCallback.cpp: Removed.
  6528. * bindings/v8/custom/V8CustomPositionCallback.h: Removed.
  6529. * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Removed.
  6530. * bindings/v8/custom/V8CustomPositionErrorCallback.h: Removed.
  6531. * bindings/v8/custom/V8GeolocationCustom.cpp:
  6532. (WebCore::V8Geolocation::getCurrentPositionCallback):
  6533. (WebCore::V8Geolocation::watchPositionCallback):
  6534. * page/PositionCallback.h:
  6535. * page/PositionCallback.idl: Added.
  6536. * page/PositionErrorCallback.h:
  6537. * page/PositionErrorCallback.idl: Added.
  6538. 2011-05-23 Pavel Podivilov <podivilov@chromium.org>
  6539. Reviewed by Yury Semikhatsky.
  6540. Web Inspector: watched expressions buttons do not match inspector styles.
  6541. https://bugs.webkit.org/show_bug.cgi?id=30554
  6542. * WebCore.gypi:
  6543. * inspector/front-end/BreakpointsSidebarPane.js:
  6544. (WebInspector.XHRBreakpointsSidebarPane):
  6545. * inspector/front-end/Images/deleteIcon.png: Added.
  6546. * inspector/front-end/Images/paneRefreshButtons.png: Added.
  6547. * inspector/front-end/WatchExpressionsSidebarPane.js:
  6548. (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
  6549. (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
  6550. (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
  6551. (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):
  6552. (WebInspector.WatchExpressionsSection):
  6553. (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
  6554. (WebInspector.WatchExpressionsSection.prototype.update):
  6555. (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
  6556. (WebInspector.WatchExpressionsSection.prototype._mouseMove):
  6557. (WebInspector.WatchExpressionsSection.prototype._mouseOut):
  6558. (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
  6559. (WebInspector.WatchExpressionsSection.CompareProperties):
  6560. (WebInspector.WatchExpressionTreeElement.prototype.update):
  6561. (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
  6562. * inspector/front-end/WebKit.qrc:
  6563. * inspector/front-end/inspector.css:
  6564. (.properties-tree.watch-expressions):
  6565. (.properties-tree.watch-expressions li):
  6566. (.section .properties .delete-button):
  6567. (.section .properties li.hovered .delete-button):
  6568. (.pane > .title > .pane-title-button):
  6569. (.pane > .title > .pane-title-button:hover):
  6570. (.pane > .title > .pane-title-button:active):
  6571. (.pane > .title > .pane-title-button.add):
  6572. (.pane > .title > .pane-title-button.refresh):
  6573. 2011-05-24 Yuta Kitamura <yutak@chromium.org>
  6574. Reviewed by Kent Tamura.
  6575. WebSocket: Add fail() to WebSocketChannel and its family
  6576. https://bugs.webkit.org/show_bug.cgi?id=61277
  6577. This is the first part of refactoring effort described in bug 61115.
  6578. Existing error reports will be modified to use fail() in a later patch.
  6579. No change in behavior, thus no new tests.
  6580. * websockets/ThreadableWebSocketChannel.h:
  6581. * websockets/WebSocketChannel.cpp:
  6582. (WebCore::WebSocketChannel::fail):
  6583. * websockets/WebSocketChannel.h:
  6584. * websockets/WorkerThreadableWebSocketChannel.cpp:
  6585. (WebCore::WorkerThreadableWebSocketChannel::fail):
  6586. (WebCore::WorkerThreadableWebSocketChannel::Peer::fail):
  6587. (WebCore::WorkerThreadableWebSocketChannel::mainThreadFail):
  6588. (WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
  6589. * websockets/WorkerThreadableWebSocketChannel.h:
  6590. 2011-05-24 Andras Becsi <abecsi@webkit.org>
  6591. Reviewed by Csaba Osztrogonác.
  6592. [Qt][V8] REGRESSION (r87063): Fix the build.
  6593. https://bugs.webkit.org/show_bug.cgi?id=61290
  6594. No new tests needed.
  6595. * bindings/scripts/CodeGeneratorV8.pm: disable the unsupported call
  6596. tracked in: https://bugs.webkit.org/show_bug.cgi?id=61291
  6597. 2011-05-24 Naoki Takano <takano.naoki@gmail.com>
  6598. Reviewed by Kent Tamura.
  6599. [Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.
  6600. https://bugs.webkit.org/show_bug.cgi?id=61252
  6601. http://code.google.com/p/chromium/issues/detail?id=83539
  6602. Manual test: manual-tests/autofill-popup-location.html.
  6603. * manual-tests/autofill-popup-location.html: With long long text, test the shown location is correct.
  6604. * platform/chromium/PopupMenuChromium.cpp:
  6605. (WebCore::PopupListBox::setBaseWidth): Clip width with m_maxWindowWidth.
  6606. (WebCore::PopupListBox::PopupListBox): Add m_maxWindowWidth initialization.
  6607. (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Call setMaxWidthAndLayout() when the width is clipped with screen size.
  6608. (WebCore::PopupListBox::setMaxWidthAndLayout): Set m_maxWindowWidth and call layout().
  6609. (WebCore::PopupListBox::layout): Compare renewed windowWidth and m_maxWindowWidth, and clip the it.
  6610. 2011-05-24 James Robinson <jamesr@chromium.org>
  6611. Reviewed by Kenneth Russell.
  6612. [chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
  6613. https://bugs.webkit.org/show_bug.cgi?id=60077
  6614. Return NULL from DrawingBuffer::create() if the initial dimensions are larger than we can support in hardware so
  6615. that we properly use the software canvas path and not enable the compositor for the canvas.
  6616. compositing/tiling/huge-layer-img.html triggers this case by trying to create a 20000 pixel high canvas. The
  6617. failure was previously masked by other bugs fixed by r85661.
  6618. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  6619. (WebCore::DrawingBuffer::DrawingBuffer):
  6620. Return NULL from DrawingBuffer::create() if resize() fails.
  6621. 2011-05-24 Fumitoshi Ukai <ukai@chromium.org>
  6622. Reviewed by Adam Barth.
  6623. close before open WebSocket doesn't fire close event.
  6624. https://bugs.webkit.org/show_bug.cgi?id=57301
  6625. In platformClose(), m_readStream may be 0 until proxy is resolved.
  6626. It should callback didClose() in such case.
  6627. Test: http/tests/websocket/tests/close-before-open.html
  6628. * platform/network/cf/SocketStreamHandleCFNet.cpp:
  6629. (WebCore::SocketStreamHandle::platformClose):
  6630. 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
  6631. Unreviewed, rolling out r87118.
  6632. http://trac.webkit.org/changeset/87118
  6633. https://bugs.webkit.org/show_bug.cgi?id=61347
  6634. patch breaks layout tests
  6635. (https://bugs.webkit.org/show_bug.cgi?id=61342), and chromium
  6636. tests (browser_test MacTestCmdUp and ui_test Scrollbar)
  6637. (Requested by ukai_ on #webkit).
  6638. * WebCore.gyp/WebCore.gyp:
  6639. * WebCore.gypi:
  6640. * platform/ScrollAnimator.cpp:
  6641. * platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  6642. * platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  6643. * platform/graphics/IntPoint.h:
  6644. 2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
  6645. Reviewed by Adam Barth.
  6646. Remove Node::deprecatedParserAddChild
  6647. https://bugs.webkit.org/show_bug.cgi?id=60818
  6648. No new tests as this is just a removal.
  6649. * dom/ContainerNode.cpp:
  6650. * dom/ContainerNode.h:
  6651. * dom/Node.cpp:
  6652. * dom/Node.h:
  6653. Removed the method now that the last instance got removed as part of the <input>
  6654. shadow DOM refactoring.
  6655. 2011-05-23 Dirk Schulze <krit@webkit.org>
  6656. Reviewed by Darin Adler.
  6657. SVGTextPositioning attributes are marked as NumberList instead of LengthList
  6658. https://bugs.webkit.org/show_bug.cgi?id=61301
  6659. SVGTextPositioningElement attributes x, y, dx and dy were marked as AnimatedNumberList
  6660. instead of AnimatedLengthList.
  6661. See specification http://www.w3.org/TR/SVG/text.html#InterfaceSVGTextPositioningElement
  6662. This does not affect the behavior, since we do not respect SVG units in SMIL animation yet.
  6663. No new tests added.
  6664. * svg/SVGTextPositioningElement.cpp:
  6665. (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
  6666. 2011-05-19 MORITA Hajime <morrita@google.com>
  6667. Reviewed by Dimitri Glazkov.
  6668. [Refactoring] Pass NodeRenderingContext to Node::rendererIsNeeded()
  6669. https://bugs.webkit.org/show_bug.cgi?id=61114
  6670. - Extracted NodeRenderingContext from NodeRendererFactory, giving separate files to it.
  6671. - Changed signature rendererIsNeeded(RenderStyle*)
  6672. to rendererIsNeeded(const NodeRenderingContext&).
  6673. The style object is retrieved from NodeRendererFactory::style()
  6674. This will allow rendererIsNeeded() to access contextual
  6675. information like attaching phase and rendering-parent.
  6676. No new tests. No behaviour change.
  6677. * CMakeLists.txt:
  6678. * GNUmakefile.list.am:
  6679. * WebCore.gypi:
  6680. * WebCore.pro:
  6681. * WebCore.vcproj/WebCore.vcproj:
  6682. * WebCore.xcodeproj/project.pbxproj:
  6683. * dom/CharacterData.cpp:
  6684. (WebCore::CharacterData::updateRenderer): Pass unresolved NodeRenderingContext& to rendererIsNeeded()
  6685. (WebCore::CharacterData::rendererIsNeeded):
  6686. * dom/CharacterData.h:
  6687. * dom/DOMAllInOne.cpp:
  6688. * dom/EditingText.cpp:
  6689. (WebCore::EditingText::rendererIsNeeded):
  6690. * dom/EditingText.h:
  6691. * dom/Node.cpp:
  6692. (WebCore::Node::parentNodeForRenderingAndStyle):
  6693. (WebCore::Node::rendererIsNeeded):
  6694. * dom/Node.h:
  6695. * dom/NodeRenderingContext.cpp: Added.
  6696. (WebCore::NodeRenderingContext::NodeRenderingContext):
  6697. (WebCore::NodeRenderingContext::~NodeRenderingContext):
  6698. (WebCore::NodeRenderingContext::setStyle):
  6699. (WebCore::NodeRenderingContext::releaseStyle):
  6700. (WebCore::NodeRenderingContext::nextRenderer):
  6701. (WebCore::NodeRenderingContext::parentRenderer):
  6702. (WebCore::NodeRenderingContext::hostChildrenChanged):
  6703. (WebCore::NodeRenderingContext::shouldCreateRenderer):
  6704. (WebCore::NodeRendererFactory::NodeRendererFactory):
  6705. (WebCore::NodeRendererFactory::createRendererAndStyle):
  6706. (WebCore::wrapWithRenderFullScreen):
  6707. (WebCore::NodeRendererFactory::createRendererIfNeeded):
  6708. * dom/NodeRenderingContext.h: Added.
  6709. (WebCore::NodeRenderingContext::node):
  6710. (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
  6711. (WebCore::NodeRenderingContext::style):
  6712. (WebCore::NodeRendererFactory::context):
  6713. * dom/ShadowContentElement.h:
  6714. * dom/Text.cpp:
  6715. * dom/Text.h:
  6716. * html/HTMLAppletElement.cpp:
  6717. * html/HTMLAppletElement.h:
  6718. * html/HTMLElement.cpp:
  6719. * html/HTMLElement.h:
  6720. * html/HTMLEmbedElement.cpp:
  6721. * html/HTMLEmbedElement.h:
  6722. * html/HTMLFormElement.cpp:
  6723. * html/HTMLFormElement.h:
  6724. * html/HTMLFrameElement.cpp:
  6725. * html/HTMLFrameElement.h:
  6726. * html/HTMLFrameSetElement.cpp:
  6727. * html/HTMLFrameSetElement.h:
  6728. * html/HTMLIFrameElement.cpp:
  6729. * html/HTMLIFrameElement.h:
  6730. * html/HTMLInputElement.cpp:
  6731. * html/HTMLInputElement.h:
  6732. * html/HTMLMediaElement.cpp:
  6733. * html/HTMLMediaElement.h:
  6734. * html/HTMLNoScriptElement.h:
  6735. * html/HTMLObjectElement.cpp:
  6736. * html/HTMLObjectElement.h:
  6737. * html/HTMLOptGroupElement.h:
  6738. * html/HTMLOptionElement.h:
  6739. * html/HTMLVideoElement.cpp:
  6740. * html/HTMLVideoElement.h:
  6741. * html/shadow/DetailsMarkerControl.cpp:
  6742. * html/shadow/DetailsMarkerControl.h:
  6743. * html/shadow/MeterShadowElement.cpp:
  6744. * html/shadow/MeterShadowElement.h:
  6745. * html/shadow/ProgressShadowElement.cpp:
  6746. * html/shadow/ProgressShadowElement.h:
  6747. * svg/SVGDescElement.h:
  6748. * svg/SVGElement.h:
  6749. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  6750. * svg/SVGFilterPrimitiveStandardAttributes.h:
  6751. * svg/SVGFontElement.h:
  6752. * svg/SVGGElement.cpp:
  6753. * svg/SVGGElement.h:
  6754. * svg/SVGGlyphElement.h:
  6755. * svg/SVGHKernElement.h:
  6756. * svg/SVGMarkerElement.h:
  6757. * svg/SVGMissingGlyphElement.h:
  6758. * svg/SVGSVGElement.h:
  6759. * svg/SVGStyledElement.cpp:
  6760. * svg/SVGStyledElement.h:
  6761. * svg/SVGSymbolElement.h:
  6762. * svg/SVGTRefElement.cpp:
  6763. * svg/SVGTRefElement.h:
  6764. * svg/SVGTSpanElement.cpp:
  6765. * svg/SVGTSpanElement.h:
  6766. * svg/SVGTextPathElement.cpp:
  6767. * svg/SVGTextPathElement.h:
  6768. * svg/SVGTitleElement.h:
  6769. * svg/SVGVKernElement.h:
  6770. * svg/SVGViewElement.h:
  6771. 2011-05-20 MORITA Hajime <morrita@google.com>
  6772. Reviewed by Dimitri Glazkov.
  6773. [Refactoring] attach() following detach() should be replaced with Node::reattach()
  6774. https://bugs.webkit.org/show_bug.cgi?id=61011
  6775. - Renamed forceReattach() to reattach()
  6776. - Introduced reattachIfAttached() as a variant.
  6777. No new tests. No behavior change.
  6778. * dom/CharacterData.cpp:
  6779. (WebCore::CharacterData::updateRenderer):
  6780. * dom/Element.cpp:
  6781. (WebCore::Element::recalcStyle):
  6782. * dom/Node.h:
  6783. (WebCore::Node::reattach):
  6784. (WebCore::Node::reattachIfAttached):
  6785. * dom/Text.cpp:
  6786. (WebCore::Text::recalcStyle):
  6787. * html/HTMLDetailsElement.cpp:
  6788. (WebCore::HTMLDetailsElement::refreshMainSummary):
  6789. (WebCore::HTMLDetailsElement::parseMappedAttribute):
  6790. * html/HTMLInputElement.cpp:
  6791. (WebCore::HTMLInputElement::parseMappedAttribute):
  6792. * html/HTMLObjectElement.cpp:
  6793. (WebCore::HTMLObjectElement::renderFallbackContent):
  6794. * html/HTMLPlugInImageElement.cpp:
  6795. (WebCore::HTMLPlugInImageElement::recalcStyle):
  6796. * html/HTMLSelectElement.cpp:
  6797. (WebCore::HTMLSelectElement::parseMappedAttribute):
  6798. 2011-05-23 Mark Rowe <mrowe@apple.com>
  6799. Build fix after r87117.
  6800. When moving #defines out in to separate files I find that code is more likely to compile
  6801. when the new header file is actually #included.
  6802. * editing/SpellingCorrectionController.h:
  6803. 2011-05-23 Mike Lawther <mikelawther@chromium.org>
  6804. Reviewed by James Robinson.
  6805. implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
  6806. https://bugs.webkit.org/show_bug.cgi?id=56627
  6807. Tests: css3/images/optimize-contrast-canvas.html
  6808. css3/images/optimize-contrast-image.html
  6809. * WebCore.xcodeproj/project.pbxproj:
  6810. * css/CSSComputedStyleDeclaration.cpp:
  6811. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  6812. * css/CSSParser.cpp:
  6813. (WebCore::CSSParser::parseValue):
  6814. * css/CSSPrimitiveValueMappings.h:
  6815. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  6816. (WebCore::CSSPrimitiveValue::operator EImageRendering):
  6817. * css/CSSPropertyNames.in:
  6818. * css/CSSStyleSelector.cpp:
  6819. (WebCore::CSSStyleSelector::applyProperty):
  6820. * css/CSSValueKeywords.in:
  6821. * css/SVGCSSComputedStyleDeclaration.cpp:
  6822. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  6823. * css/SVGCSSPropertyNames.in:
  6824. * css/SVGCSSStyleSelector.cpp:
  6825. (WebCore::CSSStyleSelector::applySVGProperty):
  6826. * css/SVGCSSValueKeywords.in:
  6827. * html/HTMLCanvasElement.cpp:
  6828. (WebCore::HTMLCanvasElement::paint):
  6829. * html/HTMLCanvasElement.h:
  6830. * platform/graphics/ImageRenderingMode.h: Added.
  6831. * rendering/RenderBoxModelObject.cpp:
  6832. (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  6833. * rendering/RenderHTMLCanvas.cpp:
  6834. (WebCore::RenderHTMLCanvas::paintReplaced):
  6835. * rendering/style/RenderStyle.cpp:
  6836. (WebCore::RenderStyle::diff):
  6837. * rendering/style/RenderStyle.h:
  6838. (WebCore::InheritedFlags::imageRendering):
  6839. (WebCore::InheritedFlags::setImageRendering):
  6840. (WebCore::InheritedFlags::initialImageRendering):
  6841. * rendering/style/RenderStyleConstants.h:
  6842. * rendering/style/SVGRenderStyle.cpp:
  6843. (WebCore::SVGRenderStyle::diff):
  6844. * rendering/style/SVGRenderStyle.h:
  6845. (WebCore::SVGRenderStyle::InheritedFlags::operator==):
  6846. (WebCore::SVGRenderStyle::setBitDefaults):
  6847. * rendering/style/SVGRenderStyleDefs.h:
  6848. * rendering/svg/SVGRenderTreeAsText.cpp:
  6849. (WebCore::writeStyle):
  6850. 2011-05-23 Sailesh Agrawal <sail@chromium.org>
  6851. Reviewed by James Robinson.
  6852. Chromium Mac: Use ScrollAnimatorMac.mm for overlay scrollbar support
  6853. https://bugs.webkit.org/show_bug.cgi?id=59753
  6854. No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
  6855. * WebCore.gyp/WebCore.gyp:
  6856. * WebCore.gypi:
  6857. * platform/ScrollAnimator.cpp:
  6858. * platform/chromium/ScrollAnimatorChromiumMac.h: Added.
  6859. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
  6860. (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
  6861. (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  6862. * platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file.
  6863. (abs):
  6864. (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
  6865. (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
  6866. (-[ScrollAnimationHelperDelegate bounds]):
  6867. (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
  6868. (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
  6869. (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
  6870. (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
  6871. (-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
  6872. (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
  6873. (-[ScrollAnimationHelperDelegate superview]):
  6874. (-[ScrollAnimationHelperDelegate documentView]):
  6875. (-[ScrollAnimationHelperDelegate window]):
  6876. (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
  6877. (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
  6878. (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
  6879. (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
  6880. (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
  6881. (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
  6882. (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
  6883. (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
  6884. (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
  6885. (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
  6886. (-[ScrollbarPartAnimation setCurrentProgress:]):
  6887. (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
  6888. (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
  6889. (-[ScrollbarPainterDelegate cancelAnimations]):
  6890. (-[ScrollbarPainterDelegate convertRectToBacking:]):
  6891. (-[ScrollbarPainterDelegate convertRectFromBacking:]):
  6892. (-[ScrollbarPainterDelegate layer]):
  6893. (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
  6894. (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
  6895. (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
  6896. (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
  6897. (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
  6898. (WebCore::ScrollAnimator::create):
  6899. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
  6900. (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
  6901. (WebCore::ScrollAnimatorChromiumMac::scroll):
  6902. (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
  6903. (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
  6904. (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
  6905. (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
  6906. (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
  6907. (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
  6908. (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
  6909. (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
  6910. (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
  6911. (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
  6912. (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
  6913. (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
  6914. (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
  6915. (WebCore::ScrollAnimatorChromiumMac::contentsResized):
  6916. (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
  6917. (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
  6918. (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
  6919. (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
  6920. (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
  6921. (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
  6922. (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
  6923. (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
  6924. (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
  6925. (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
  6926. (WebCore::elasticDeltaForTimeDelta):
  6927. (WebCore::reboundDeltaForElasticDelta):
  6928. (WebCore::elasticDeltaForReboundDelta):
  6929. (WebCore::scrollWheelMultiplier):
  6930. (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
  6931. (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
  6932. (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
  6933. (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
  6934. (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
  6935. (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
  6936. (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
  6937. (WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
  6938. (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
  6939. (WebCore::roundTowardZero):
  6940. (WebCore::roundToDevicePixelTowardZero):
  6941. (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
  6942. (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
  6943. (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
  6944. (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
  6945. (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
  6946. (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  6947. * platform/graphics/IntPoint.h:
  6948. 2011-05-22 MORITA Hajime <morrita@google.com>
  6949. Reviewed by Ryosuke Niwa.
  6950. SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
  6951. https://bugs.webkit.org/show_bug.cgi?id=61181
  6952. - Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
  6953. - Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h
  6954. No new tests. Just renaming a compilation conditional.
  6955. * editing/Editor.cpp:
  6956. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  6957. * editing/SpellingCorrectionCommand.cpp:
  6958. (WebCore::SpellingCorrectionCommand::doApply):
  6959. * editing/SpellingCorrectionController.cpp:
  6960. * editing/SpellingCorrectionController.h:
  6961. (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  6962. * loader/EmptyClients.h:
  6963. * page/EditorClient.h:
  6964. * platform/text/TextChecking.h:
  6965. 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
  6966. Unreviewed, rolling out r87007.
  6967. http://trac.webkit.org/changeset/87007
  6968. https://bugs.webkit.org/show_bug.cgi?id=61329
  6969. patch unnecessarily breaks HTML5 compatibility (Requested by
  6970. estes on #webkit).
  6971. * html/HTMLObjectElement.cpp:
  6972. (WebCore::HTMLObjectElement::hasValidClassId):
  6973. 2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
  6974. Reviewed by Darin Adler.
  6975. Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
  6976. https://bugs.webkit.org/show_bug.cgi?id=57140
  6977. Test: fast/storage/storage-detached-iframe.html
  6978. Access of localStorage on a detached iframe was causing a crash because a detached
  6979. iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.
  6980. * storage/StorageAreaImpl.cpp:
  6981. (WebCore::privateBrowsingEnabled): check that child->page() is non-null before
  6982. accessing it.
  6983. 2011-05-23 Chris Fleizach <cfleizach@apple.com>
  6984. Reviewed by David Kilzer.
  6985. VO doesn't work with HTML5 range (slider) input @step attribute
  6986. https://bugs.webkit.org/show_bug.cgi?id=61298
  6987. Test: platform/mac/accessibility/range-alter-by-step.html
  6988. * accessibility/AccessibilityObject.h:
  6989. (WebCore::AccessibilityObject::stepValueForRange):
  6990. * accessibility/AccessibilityRenderObject.cpp:
  6991. (WebCore::AccessibilityRenderObject::alterSliderValue):
  6992. (WebCore::AccessibilityRenderObject::increment):
  6993. (WebCore::AccessibilityRenderObject::decrement):
  6994. (WebCore::AccessibilityRenderObject::stepValueForRange):
  6995. (WebCore::AccessibilityRenderObject::changeValueByStep):
  6996. * accessibility/AccessibilityRenderObject.h:
  6997. 2011-05-23 Gavin Peters <gavinp@chromium.org>
  6998. Reviewed by Adam Barth.
  6999. fix rel=prerender target types
  7000. https://bugs.webkit.org/show_bug.cgi?id=61297
  7001. The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
  7002. didn't properly map the target type, and didn't carry the target
  7003. types through to chromium properly. Fixed.
  7004. No new tests; it's very hard to catch these with a layout test, however
  7005. all of the chromium Prerender browser tests will test this functionality
  7006. when I land an upcoming chromium CL.
  7007. * loader/cache/CachedResourceRequest.cpp:
  7008. (WebCore::cachedResourceTypeToTargetType):
  7009. 2011-05-23 Matthew Delaney <mdelaney@apple.com>
  7010. Reviewed by Simon Fraser.
  7011. Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
  7012. https://bugs.webkit.org/show_bug.cgi?id=58216
  7013. No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.
  7014. * platform/graphics/FloatRect.cpp:
  7015. (WebCore::enclosingIntRect):
  7016. 2011-05-20 Jeremy Noble <jer.noble@apple.com>
  7017. Reviewed by Darin Adler.
  7018. Video looks squished when animating to full screen.
  7019. https://bugs.webkit.org/show_bug.cgi?id=61220
  7020. No new tests, because DumpRenderTree does not currently "animate" the full-screen transition.
  7021. There are three issues animating video content to full screen which this patch is meant to
  7022. address:
  7023. 1) The animation scales between the client sizes of the element before and after full-screen.
  7024. Because these sizes have different aspect ratios, the video appears "squished" for part of
  7025. the animation. Instead, we will animate between the content box sizes before and after full
  7026. screen which, in the case of video now and object-fit content in the future, will have the
  7027. same aspect ratio before and after full screen.
  7028. 2) Now that we are animating the full-screen video element's content box, the black letterbox
  7029. bars appear above and below the video (depending on the video's aspect ratio) as soon as the
  7030. animation begins. This is extremely jarring, so set the background color to clear. The
  7031. full-screen renderer's background color will serve the same purpose (providing the letterbox
  7032. background) once the animation completes.
  7033. 3) Now that the letterbox color is gone, the full screen controls can appear to float in thin
  7034. air beneath the video (again, depending on aspect ratio) during the animation, so to avoid
  7035. that effect and to make the animation consistent with the old webkitenterfullscreen()
  7036. animation, we will hide the controls during the animation by adding a new CSS pseudo class
  7037. -webkit-animating-full-screen-transition.
  7038. Added a new css pseudo-class: -webkit-animating-full-screen. During the transition animation, this
  7039. pseudo-class will be applied to the current full-screen element. Styles have been added to
  7040. fullscreenQuickTime.css to hide the video element's built-in controller during the full-screen
  7041. animation.
  7042. To accomplish this, the ivar tracking whether the full-screen animation is taking place has been moved
  7043. from the RenderFullScreen renderer, to the current full-screen Document. Because changing
  7044. isAnimatingFullScreen causes style changes, make sure to call recalcStyle on the full-screen element
  7045. after changing.
  7046. This extra transition caused assertions in HTMLFormControlElement::updateFromElementCallback. A
  7047. full-screen media control's renderer is disabled during the style recalculation when exiting full
  7048. screen. This assertion was exposed by the extra recalcStyle() issued during the exit transition, and
  7049. has been removed.
  7050. * WebCore.exp.in:
  7051. * css/CSSSelector.cpp:
  7052. (WebCore::CSSSelector::pseudoId): Add support for new pseudo class -webkit-animate-full-screen-transition.
  7053. (WebCore::nameToPseudoTypeMap): Ditto.
  7054. (WebCore::CSSSelector::extractPseudoType): Ditto.
  7055. * css/CSSSelector.h:
  7056. * css/CSSStyleSelector.cpp:
  7057. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  7058. * css/fullscreen.css:
  7059. (video:-webkit-full-screen): Set full screen video background color to clear.
  7060. * css/fullscreenQuickTime.css:
  7061. (video:-webkit-full-screen::-webkit-media-controls-panel): Set a default opacity transition.
  7062. (video:-webkit-animating-full-screen::-webkit-media-controls-panel): Set the opacity to 0 and
  7063. disable the transition.
  7064. * dom/Document.cpp:
  7065. (WebCore::Document::Document):
  7066. (WebCore::Document::webkitWillEnterFullScreenForElement): Call our new setAnimatingFullScreen function.
  7067. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
  7068. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
  7069. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
  7070. (WebCore::Document::isAnimatingFullScreen): Moved here from RenderFullScreen.
  7071. (WebCore::Document::setAnimatingFullScreen): Ditto.
  7072. * dom/Document.h:
  7073. * html/HTMLFormControlElement.cpp:
  7074. (WebCore::updateFromElementCallback): Use the Document's isAnimatingFullScreen function.
  7075. * page/FrameView.cpp:
  7076. (WebCore::isDocumentRunningFullScreenAnimation): Ditto.
  7077. * rendering/RenderFullScreen.cpp:
  7078. * rendering/RenderFullScreen.h:
  7079. * rendering/RenderLayerCompositor.cpp:
  7080. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto.
  7081. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
  7082. * rendering/style/RenderStyleConstants.h:
  7083. 2011-05-23 Emil A Eklund <eae@chromium.org>
  7084. Reviewed by Eric Seidel.
  7085. Change RenderBlock hit testing to use IntPoint instead x,y pair
  7086. https://bugs.webkit.org/show_bug.cgi?id=61146
  7087. Covered by existing tests.
  7088. * platform/graphics/IntPoint.h:
  7089. (WebCore::toSize):
  7090. Add toSize function for converting from point to size.
  7091. * rendering/RenderBlock.cpp:
  7092. (WebCore::RenderBlock::isPointInOverflowControl):
  7093. (WebCore::RenderBlock::nodeAtPoint):
  7094. (WebCore::RenderBlock::hitTestFloats):
  7095. (WebCore::RenderBlock::hitTestColumns):
  7096. (WebCore::RenderBlock::hitTestContents):
  7097. * rendering/RenderBlock.h:
  7098. Change hit testing code in RenderBlock to use IntPoint.
  7099. * rendering/RenderListBox.cpp:
  7100. (WebCore::RenderListBox::isPointInOverflowControl):
  7101. * rendering/RenderListBox.h:
  7102. Change overridden method to use IntPoint.
  7103. 2011-05-23 Mike Reed <reed@google.com>
  7104. Reviewed by James Robinson.
  7105. Skia: Need to implement GraphicsContext::clipConvexPolygon()
  7106. https://bugs.webkit.org/show_bug.cgi?id=41311
  7107. No new tests.
  7108. * platform/graphics/skia/GraphicsContextSkia.cpp:
  7109. (WebCore::setPathFromConvexPoints):
  7110. (WebCore::GraphicsContext::drawConvexPolygon):
  7111. (WebCore::GraphicsContext::clipConvexPolygon):
  7112. 2011-05-23 James Simonsen <simonjam@chromium.org>
  7113. Reviewed by Adam Barth.
  7114. Convert raw pointer to RefPtr.
  7115. https://bugs.webkit.org/show_bug.cgi?id=61196
  7116. * dom/XMLDocumentParserLibxml2.cpp:
  7117. (WebCore::XMLDocumentParser::endElementNs):
  7118. * dom/XMLDocumentParserQt.cpp:
  7119. (WebCore::XMLDocumentParser::parseEndElement):
  7120. 2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
  7121. Reviewed by Alexey Proskuryakov.
  7122. selectstart is fired for every mouse move
  7123. https://bugs.webkit.org/show_bug.cgi?id=19489
  7124. Fixed the bug by dispatching selectstart event immediately before modifying selection in
  7125. handleMousePressEventSingleClick and updateSelectionForMouseDrag.
  7126. Also replaced a boolean EventHandler::m_beganSelectingText by an enum-valued m_selectionInitiationState
  7127. to retain 3 states:
  7128. 1. HaveNotStartedSelection - Selection has not been set by a mouse drag or a mouse click
  7129. 2. PlacedCaret - A caret was placed by a mouse click, double click, or triple click, and is about
  7130. to replace selection if a mouse drag never occurs.
  7131. 3. ExtendedSelection - A range selection was set by a mouse click, a double click, a triple click,
  7132. or a mouse drag; otherwise a caret selection was set by a mouse drag.
  7133. State 1 corresponds to m_beganSelectingText being false and state 3 corresponds to m_beganSelectingText
  7134. being true. State 2 is used in updateSelectionForMouseDrag to avoid dispatching selectstart twice.
  7135. States 1 and 2 are set by updateSelectionForMouseDownDispatchingSelectStart and state 3 is set by
  7136. updateSelectionForMouseDrag.
  7137. Test: fast/events/selectstart-by-double-triple-clicks.html
  7138. fast/events/selectstart-by-drag.html
  7139. fast/events/selectstart-by-single-click-with-shift.html
  7140. * page/EventHandler.cpp: Removed canMouseDragExtendSelect.
  7141. (WebCore::EventHandler::EventHandler): Initializes m_selectionInitiationState.
  7142. (WebCore::dispatchSelectStart): Returns true only if selectstart was successfully fired
  7143. and default action was not prevented.
  7144. (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Updates m_selectionInitiationState
  7145. and modifies the selection if dispatchSelectStart returns true.
  7146. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls updateSelectionForMouseDownDispatchingSelectStart.
  7147. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
  7148. (WebCore::EventHandler::handleMousePressEventDoubleClick):
  7149. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
  7150. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
  7151. (WebCore::canMouseDownStartSelect): No longer dispatches startselect; also renamed from
  7152. EventHandler::canMouseDownStartSelect.
  7153. (WebCore::EventHandler::handleMousePressEvent): No longer calls canMouseDragExtendSelect.
  7154. (WebCore::EventHandler::handleMouseDraggedEvent):
  7155. (WebCore::EventHandler::updateSelectionForMouseDrag): Exit early if m_selectionInitiationState is
  7156. HaveNotStartedSelection and dispatchSelectStart returns false. Since setSelectionIfPossible dispatches
  7157. selectstart event before assigning PlacedCaret or ExtendedSelection to m_selectionInitiationState,
  7158. there is no need to dispatch event for those two cases.
  7159. (WebCore::EventHandler::handleMouseReleaseEvent):
  7160. * page/EventHandler.h: Removed canMouseDownStartSelect and canMouseDragExtendSelect from EventHandler
  7161. and added setSelectionIfPossible.
  7162. 2011-05-23 Adam Klein <adamk@chromium.org>
  7163. Reviewed by Jian Li.
  7164. [fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
  7165. https://bugs.webkit.org/show_bug.cgi?id=61155
  7166. Covered by existing tests: fast/filesystem/file-from-file-entry.html
  7167. fast/filesystem/workers/file-from-file-entry.html
  7168. fast/filesystem/workers/file-from-file-entry-sync.html
  7169. * fileapi/DOMFileSystem.cpp:
  7170. (WebCore::DOMFileSystem::createFile): Updated to call createWithName().
  7171. * fileapi/DOMFileSystemSync.cpp:
  7172. (WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
  7173. * fileapi/File.cpp:
  7174. (WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup.
  7175. (WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method.
  7176. (WebCore::File::File):
  7177. * fileapi/File.h:
  7178. (WebCore::File::createWithName):
  7179. * html/FileInputType.cpp:
  7180. (WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
  7181. 2011-05-23 Adrienne Walker <enne@google.com>
  7182. Reviewed by James Robinson.
  7183. [chromium] Fix division by zero in TilingData for boundary case texture sizes
  7184. https://bugs.webkit.org/show_bug.cgi?id=61164
  7185. * platform/graphics/gpu/TilingData.cpp:
  7186. (WebCore::TilingData::tileXIndexFromSrcCoord):
  7187. (WebCore::TilingData::tileYIndexFromSrcCoord):
  7188. 2011-05-23 Adam Barth <abarth@webkit.org>
  7189. Reviewed by Eric Seidel.
  7190. Update ImageDecoder::create to match sniffing spec
  7191. https://bugs.webkit.org/show_bug.cgi?id=47683
  7192. This change is difficult to test. We're making this change to comply
  7193. with standards even if the change is difficult to observe. (This patch
  7194. also causes us to match Firefox.)
  7195. Test: fast/images/busted-oval-does-not-render.html
  7196. * platform/image-decoders/ImageDecoder.cpp:
  7197. 2011-05-23 Ruben <chromium@hybridsource.org>
  7198. Reviewed by Tony Chang.
  7199. Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
  7200. https://bugs.webkit.org/show_bug.cgi?id=61219
  7201. No new tests, just changing gyp defines.
  7202. * WebCore.gyp/WebCore.gyp:
  7203. 2011-05-23 Abhishek Arya <inferno@chromium.org>
  7204. Reviewed by Simon Fraser.
  7205. Terminate css color parsing on integers which are not followed
  7206. by a terminator.
  7207. https://bugs.webkit.org/show_bug.cgi?id=61293
  7208. Test: fast/css/parse-color-int-or-percent-crash.html
  7209. * css/CSSParser.cpp:
  7210. (WebCore::parseColorIntOrPercentage):
  7211. 2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
  7212. Reviewed by Enrica Casucci.
  7213. REGRESSION(r84311): WebKit copies too much styles when copying
  7214. https://bugs.webkit.org/show_bug.cgi?id=60914
  7215. The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
  7216. Fixed the bug by not cloning background color and adding the effective background color to the wrapping
  7217. style span.
  7218. Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html
  7219. editing/pasteboard/do-no-clone-unnecessary-styles.html
  7220. * editing/EditingStyle.cpp:
  7221. (WebCore::cssValueToRGBA): Extracted from getRGBAFontColor.
  7222. (WebCore::getRGBAFontColor): Moved.
  7223. (WebCore::rgbaBackgroundColorInEffect): Added.
  7224. (WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect.
  7225. (WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position.
  7226. Also remove the background color property when the effective background color is equal to the background
  7227. color property (in terms of RGBA value) of the editing style.
  7228. (WebCore::hasTransparentBackgroundColor): Moved from Editor class.
  7229. (WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
  7230. * editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
  7231. * editing/Editor.cpp:
  7232. (WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
  7233. * editing/Editor.h: Removed hasTransparentBackgroundColor.
  7234. * editing/markup.cpp:
  7235. (WebCore::isElementPresentational): Reverted r85090 and r84311.
  7236. (WebCore::createMarkup): Include the background color in effect when computing the editing style.
  7237. 2011-05-23 Roland Steiner <rolandsteiner@chromium.org>
  7238. Reviewed by Dimitri Glazkov.
  7239. Update node list cache count on the containing TreeScope rather than the Document
  7240. https://bugs.webkit.org/show_bug.cgi?id=59983
  7241. Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
  7242. Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
  7243. Make setDocument() and setDocumentRecursively() private.
  7244. No new tests. (refactoring)
  7245. * dom/ContainerNode.cpp:
  7246. (WebCore::ContainerNode::childrenChanged):
  7247. * dom/Node.cpp:
  7248. (WebCore::Node::~Node):
  7249. (WebCore::Node::setDocument):
  7250. (WebCore::Node::setTreeScopeRecursively):
  7251. (WebCore::Node::childNodes):
  7252. (WebCore::Node::registerDynamicNodeList):
  7253. (WebCore::Node::unregisterDynamicNodeList):
  7254. (WebCore::Node::notifyLocalNodeListsAttributeChanged):
  7255. (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  7256. (WebCore::Node::getElementsByTagName):
  7257. (WebCore::Node::getElementsByTagNameNS):
  7258. (WebCore::Node::getElementsByName):
  7259. (WebCore::Node::getElementsByClassName):
  7260. * dom/Node.h:
  7261. * html/HTMLFormControlElement.cpp:
  7262. (WebCore::HTMLFormControlElement::labels):
  7263. 2011-05-23 Yury Semikhatsky <yurys@chromium.org>
  7264. Reviewed by Pavel Feldman.
  7265. [Chromium] Web Inspector: provide initial implementation of worker inspector transport
  7266. https://bugs.webkit.org/show_bug.cgi?id=60267
  7267. All methods of WorkerContextInspectorProxy are inlined in WorkerContextProxy and
  7268. the class itself is removed. Messages from worker inspector to page inspector
  7269. are sent by means of WorkerReportingProxy.
  7270. * GNUmakefile.list.am:
  7271. * WebCore.gypi:
  7272. * WebCore.vcproj/WebCore.vcproj:
  7273. * WebCore.xcodeproj/project.pbxproj:
  7274. * inspector/InspectorWorkerAgent.cpp:
  7275. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
  7276. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy):
  7277. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker):
  7278. (WebCore::InspectorWorkerAgent::sendMessageToWorker):
  7279. (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  7280. * inspector/InspectorWorkerAgent.h:
  7281. * inspector/WorkerInspectorController.cpp:
  7282. (WebCore::WorkerInspectorController::connectFrontend):
  7283. (WebCore::WorkerInspectorController::disconnectFrontend):
  7284. * inspector/WorkerInspectorController.h:
  7285. * workers/DefaultSharedWorkerRepository.cpp:
  7286. (WebCore::SharedWorkerProxy::postMessageToPageInspector):
  7287. * workers/WorkerContextInspectorProxy.h: Removed.
  7288. * workers/WorkerContextProxy.h:
  7289. (WebCore::WorkerContextProxy::PageInspector::~PageInspector):
  7290. (WebCore::WorkerContextProxy::connectToInspector):
  7291. (WebCore::WorkerContextProxy::disconnectFromInspector):
  7292. (WebCore::WorkerContextProxy::sendMessageToInspector):
  7293. * workers/WorkerMessagingProxy.cpp:
  7294. (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
  7295. * workers/WorkerMessagingProxy.h:
  7296. * workers/WorkerReportingProxy.h:
  7297. 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
  7298. Unreviewed, rolling out r87070.
  7299. http://trac.webkit.org/changeset/87070
  7300. https://bugs.webkit.org/show_bug.cgi?id=61285
  7301. broke resource-parameters.html on win, weird failures on wk2
  7302. (Requested by caseq on #webkit).
  7303. * inspector/front-end/HAREntry.js:
  7304. (WebInspector.HAREntry.prototype.build):
  7305. (WebInspector.HAREntry.prototype._buildRequest):
  7306. (WebInspector.HAREntry.prototype._buildResponse):
  7307. (WebInspector.HAREntry.prototype._buildContent):
  7308. (WebInspector.HAREntry.prototype._buildCookie):
  7309. (WebInspector.HAREntry.prototype._interval):
  7310. (WebInspector.HARLog.prototype.build):
  7311. * inspector/front-end/Resource.js:
  7312. (WebInspector.Resource.prototype.set requestHeaders):
  7313. (WebInspector.Resource.prototype.get requestHeadersText):
  7314. (WebInspector.Resource.prototype.set requestHeadersText):
  7315. (WebInspector.Resource.prototype.get requestHeadersSize):
  7316. (WebInspector.Resource.prototype.set responseHeaders):
  7317. (WebInspector.Resource.prototype.get responseHeadersText):
  7318. (WebInspector.Resource.prototype.set responseHeadersText):
  7319. (WebInspector.Resource.prototype.get responseHeadersSize):
  7320. (WebInspector.Resource.prototype._headersSize):
  7321. 2011-05-18 Pavel Podivilov <podivilov@chromium.org>
  7322. Reviewed by Yury Semikhatsky.
  7323. Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
  7324. https://bugs.webkit.org/show_bug.cgi?id=61037
  7325. * inspector/front-end/JavaScriptFormatter.js:
  7326. (FormattedContentBuilder.prototype.addToken):
  7327. (FormattedContentBuilder.prototype._addComment):
  7328. (FormattedContentBuilder.prototype._addText):
  7329. (FormattedContentBuilder.prototype._addMappingIfNeeded):
  7330. 2011-05-23 Mike West <mkwst@chromium.org>
  7331. Reviewed by Yury Semikhatsky.
  7332. Web Inspector: Missing fields in HAR
  7333. https://bugs.webkit.org/show_bug.cgi?id=58127
  7334. Specifically, this patch adds:
  7335. - entry.request.httpVersion
  7336. - entry.request.headersSize
  7337. - entry.request.bodySize
  7338. - entry.response.httpVersion
  7339. - entry.response.headersSize
  7340. - entry.response.bodySize
  7341. - entry.response.content.compression
  7342. Tests: http/tests/inspector/resource-har-conversion.html
  7343. http/tests/inspector/resource-har-headers.html
  7344. http/tests/inspector/resource-parameters.html
  7345. http/tests/inspector/network/network-size.html
  7346. * inspector/front-end/HAREntry.js:
  7347. (WebInspector.HAREntry.prototype.build):
  7348. (WebInspector.HAREntry.prototype._buildRequest):
  7349. (WebInspector.HAREntry.prototype._buildResponse):
  7350. (WebInspector.HAREntry.prototype._buildContent):
  7351. (WebInspector.HAREntry.prototype._buildCookie):
  7352. (WebInspector.HAREntry.prototype._interval):
  7353. (WebInspector.HAREntry.prototype.get requestBodySize):
  7354. (WebInspector.HAREntry.prototype.get responseBodySize):
  7355. (WebInspector.HAREntry.prototype.get responseCompression):
  7356. (WebInspector.HARLog.prototype.build):
  7357. * inspector/front-end/Resource.js:
  7358. (WebInspector.Resource.prototype.set requestHeaders):
  7359. (WebInspector.Resource.prototype.get requestHeadersText):
  7360. (WebInspector.Resource.prototype.set requestHeadersText):
  7361. (WebInspector.Resource.prototype.get requestHeadersSize):
  7362. (WebInspector.Resource.prototype.get requestHttpVersion):
  7363. (WebInspector.Resource.prototype.set responseHeaders):
  7364. (WebInspector.Resource.prototype.get responseHeadersText):
  7365. (WebInspector.Resource.prototype.set responseHeadersText):
  7366. (WebInspector.Resource.prototype.get responseHeadersSize):
  7367. (WebInspector.Resource.prototype.get responseHttpVersion):
  7368. 2011-05-23 Andrey Kosyakov <caseq@chromium.org>
  7369. Reviewed by Yury Semikhatsky.
  7370. Web Inspector: keyboard shortcut panel is 1px too short
  7371. https://bugs.webkit.org/show_bug.cgi?id=61242
  7372. Fixed bottom margin of attached helpscreen so it's glued to status bar.
  7373. * inspector/front-end/helpScreen.css:
  7374. (body.attached .help-window-outer):
  7375. 2011-05-23 Kent Tamura <tkent@chromium.org>
  7376. Reviewed by Dimitri Glazkov.
  7377. Change text-based <input> types to the new shadow DOM model
  7378. https://bugs.webkit.org/show_bug.cgi?id=54179
  7379. By this change, text field inputs and textareas have one extra
  7380. shadow node at the root of shadow trees.
  7381. e.g. Before the change:
  7382. <textarea> --(shadow-connection)-- <div> -- ...
  7383. After the change:
  7384. <textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...
  7385. The goals of this change are
  7386. - Change to the new shadow DOM model, and
  7387. - Minimize the patch size.
  7388. We should use shadowPseudoId() in the new shadow DOM model, but the
  7389. shadow elements in this patch don't use it in order to reduce the patch
  7390. size.
  7391. Note: This is a re-landing for r87014 with a small fix of
  7392. Element::removeShadowRoot().
  7393. * css/html.css:
  7394. (input::-webkit-inner-spin-button):
  7395. Add vertical-align in order to avoid the button affect the baseline.
  7396. (input::-webkit-outer-spin-button): ditto.
  7397. (input::-webkit-input-speech-button): ditto.
  7398. * dom/Element.cpp:
  7399. (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a
  7400. subclass of Element can override it.
  7401. (WebCore::Element::remvoeShadowRoot):
  7402. Fix a wrong parameter for willRemoveDOMNode().
  7403. (WebCore::Element::isSpellCheckingEnabled):
  7404. Handle ShadowRoot, which is not an Element.
  7405. * dom/Node.cpp:
  7406. Add utility functions for editing code.
  7407. (WebCore::Node::nonBoundaryShadowTreeRootNode):
  7408. (WebCore::Node::nonShadowBoundaryParentNode):
  7409. * dom/Node.h: Declare them.
  7410. * dom/Position.cpp:
  7411. - Add some assertions about ShadowRoot
  7412. - Replace parentNode() with nonShadowBoundaryParentNode()
  7413. Because input/textarea shadow structures are changed.
  7414. (WebCore::Position::Position):
  7415. (WebCore::Position::containerNode):
  7416. (WebCore::Position::parentAnchoredEquivalent):
  7417. (WebCore::Position::previous):
  7418. (WebCore::Position::next):
  7419. (WebCore::Position::parentEditingBoundary):
  7420. (WebCore::Position::atStartOfTree):
  7421. (WebCore::Position::atEndOfTree):
  7422. * dom/Position.h: ditto.
  7423. (WebCore::positionInParentBeforeNode):
  7424. (WebCore::positionInParentAfterNode):
  7425. * editing/CompositeEditCommand.cpp: ditto.
  7426. (WebCore::CompositeEditCommand::insertNodeAfter):
  7427. (WebCore::CompositeEditCommand::removeNode):
  7428. * editing/Editor.cpp:
  7429. (WebCore::Editor::findString): ditto.
  7430. * editing/FrameSelection.cpp:
  7431. (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
  7432. * editing/FrameSelection.h:
  7433. Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  7434. * editing/InsertParagraphSeparatorCommand.cpp:
  7435. (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
  7436. * editing/ReplaceSelectionCommand.cpp:
  7437. (WebCore::ReplacementFragment::removeNode): ditto.
  7438. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
  7439. * editing/VisibleSelection.cpp:
  7440. Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns
  7441. a child node of ShadowRoot.
  7442. (WebCore::VisibleSelection::isAll):
  7443. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
  7444. (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
  7445. * editing/VisibleSelection.h: ditto.
  7446. * editing/htmlediting.cpp: Add assertions.
  7447. (WebCore::visiblePositionBeforeNode):
  7448. (WebCore::visiblePositionAfterNode):
  7449. * html/HTMLInputElement.cpp:
  7450. (WebCore::HTMLInputElement::create): Calls createShadowSubtree().
  7451. (WebCore::HTMLInputElement::createShadowSubtree):
  7452. Calls InputType::createShadowSubTree().
  7453. (WebCore::HTMLInputElement::innerTextElement):
  7454. Accessor of a shadow node. This is used by RenderTextControlSingleLine.
  7455. (WebCore::HTMLInputElement::innerBlockElement): ditto.
  7456. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
  7457. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
  7458. (WebCore::HTMLInputElement::resultsButtonElement): ditto.
  7459. (WebCore::HTMLInputElement::cancelButtonElement): ditto.
  7460. (WebCore::HTMLInputElement::speechButtonElement): ditto.
  7461. (WebCore::HTMLInputElement::parseMappedAttribute):
  7462. Rebuild shadow trees because x-webkit-speech attribute affects it.
  7463. * html/HTMLInputElement.h: Add declarations.
  7464. * html/HTMLIsIndexElement.cpp:
  7465. (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
  7466. * html/HTMLTextAreaElement.cpp:
  7467. (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
  7468. (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
  7469. * html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  7470. * html/InputType.h: Add default implementations of accessors.
  7471. (WebCore::InputType::innerBlockElement):
  7472. (WebCore::InputType::innerTextElement):
  7473. (WebCore::InputType::innerSpinButtonElement):
  7474. (WebCore::InputType::outerSpinButtonElement):
  7475. (WebCore::InputType::resultsButtonElement):
  7476. (WebCore::InputType::cancelButtonElement):
  7477. (WebCore::InputType::speechButtonElement):
  7478. * html/SearchInputType.cpp:
  7479. (WebCore::SearchInputType::SearchInputType): Initializes new data members.
  7480. (WebCore::SearchInputType::createShadowSubtree):
  7481. Moved from RenderTextControlSingleLine.
  7482. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
  7483. * html/SearchInputType.h: Add declarations.
  7484. (WebCore::SearchInputType::innerBlockElement):
  7485. (WebCore::SearchInputType::resultsButtonElement):
  7486. (WebCore::SearchInputType::cancelButtonElement):
  7487. * html/TextFieldInputType.cpp:
  7488. (WebCore::TextFieldInputType::TextFieldInputType):
  7489. Initializes new data members.
  7490. (WebCore::TextFieldInputType::createShadowSubtree):
  7491. Moved from RenderTextControlSingleLine.
  7492. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
  7493. * html/TextFieldInputType.h: Add declarations.
  7494. (WebCore::TextFieldInputType::innerTextElement):
  7495. (WebCore::TextFieldInputType::innerSpinButtonElement):
  7496. (WebCore::TextFieldInputType::outerSpinButtonElement):
  7497. (WebCore::TextFieldInputType::speechButtonElement):
  7498. (WebCore::TextFieldInputType::setInnerTextElement):
  7499. (WebCore::TextFieldInputType::setSpeechButtonElement):
  7500. * html/shadow/TextControlInnerElements.cpp:
  7501. (WebCore::TextControlInnerElement::TextControlInnerElement):
  7502. Remove shadowParent parameter. It is unnecessary because we switch to
  7503. new shadow model.
  7504. (WebCore::TextControlInnerElement::create):
  7505. Change the parameter type to Document.
  7506. (WebCore::TextControlInnerElement::styleForRenderer):
  7507. Override this in order to set style by
  7508. RenderTextControlSingleLine::createInnerBlockStyle().
  7509. (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
  7510. Remove shadowParent parameter.
  7511. Inherit HTMLDivElement, not TextControlInnerElement.
  7512. (WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
  7513. (WebCore::TextControlInnerTextElement::styleForRenderer):
  7514. Override this in order to set style by
  7515. RenderTextControlSingleLine::createInnerTextStyle().
  7516. (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
  7517. Inherit HTMLDivElement, not TextControlInnerElement.
  7518. (WebCore::SearchFieldResultsButtonElement::styleForRenderer):
  7519. Override this in order to set style by
  7520. RenderTextControlSingleLine::createResultButtonStyle().
  7521. (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
  7522. Inherit HTMLDivElement, not TextControlInnerElement.
  7523. (WebCore::SearchFieldCancelButtonElement::styleForRenderer):
  7524. Override this in order to set style by
  7525. RenderTextControlSingleLine::createCancelButtonStyle().
  7526. (WebCore::SearchFieldCancelButtonElement::detach):
  7527. Update for the parent class change.
  7528. (WebCore::SpinButtonElement::SpinButtonElement):
  7529. - Change the parameter type: shadowParent -> Document
  7530. - Add the inner flag
  7531. - Inherit HTMLDivElement, not TextControlInnerElement.
  7532. (WebCore::SpinButtonElement::createInner): Introduce a new factory
  7533. method to hide a bool parameter of the constructor.
  7534. (WebCore::SpinButtonElement::createOuter): ditto.
  7535. (WebCore::SpinButtonElement::styleForRenderer):
  7536. Override this in order to set style by
  7537. RenderTextControlSingleLine::createInnerSpinButtonStyle() or
  7538. createOuterSpinButtonStyle().
  7539. (WebCore::SpinButtonElement::detach): Update for the parent class change.
  7540. (WebCore::SpinButtonElement::setHovered): ditto.
  7541. (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
  7542. - Change the parameter type: shadowParent -> Document
  7543. - Inherit HTMLDivElement, not TextControlInnerElement.
  7544. - Do not register this as a speech input listener here.
  7545. (WebCore::InputFieldSpeechButtonElement::create):
  7546. Update for the parameter change.
  7547. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  7548. Do not handle click event if listener registration is not done.
  7549. (WebCore::InputFieldSpeechButtonElement::attach):
  7550. Register this as a speech input listener.
  7551. (WebCore::InputFieldSpeechButtonElement::detach):
  7552. Update for the parent class change.
  7553. (WebCore::InputFieldSpeechButtonElement::styleForRenderer):
  7554. Override this in order to set style by
  7555. RenderTextControlSingleLine::createSpeechButtonStyle().
  7556. * html/shadow/TextControlInnerElements.h:
  7557. (WebCore::TextControlInnerTextElement::isMouseFocusable):
  7558. Add this because the class is not a subclass of TextControllInnerElement.
  7559. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
  7560. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
  7561. (WebCore::SpinButtonElement::isMouseFocusable): ditto.
  7562. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
  7563. * rendering/RenderTextControl.cpp:
  7564. (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
  7565. (WebCore::RenderTextControl::styleDidChange):
  7566. innerTextElement can have no renderer.
  7567. Explicitly call setNeedsStyleRecals() for innerTextElement. It is
  7568. needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.
  7569. (WebCore::RenderTextControl::textBlockWidth): Member data -> function
  7570. (WebCore::RenderTextControl::updateFromElement): ditto.
  7571. (WebCore::RenderTextControl::setInnerTextValue): ditto.
  7572. (WebCore::RenderTextControl::hasVisibleTextArea): ditto.
  7573. (WebCore::RenderTextControl::isSelectableElement): ditto.
  7574. (WebCore::RenderTextControl::selection): ditto.
  7575. (WebCore::RenderTextControl::visiblePositionForIndex): ditto.
  7576. (WebCore::RenderTextControl::indexForVisiblePosition): ditto.
  7577. (WebCore::RenderTextControl::text): ditto.
  7578. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
  7579. (WebCore::RenderTextControl::computeLogicalHeight): ditto.
  7580. (WebCore::RenderTextControl::hitInnerTextElement): ditto.
  7581. (WebCore::RenderTextControl::forwardEvent): ditto.
  7582. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
  7583. * rendering/RenderTextControl.h:
  7584. - Make m_innerText virtual function.
  7585. - Make createInnerTextStyle() public in order that
  7586. TextControlInnerElements can call it.
  7587. * rendering/RenderTextControlMultiLine.cpp:
  7588. (WebCore::RenderTextControlMultiLine::innerTextElement): Added.
  7589. (WebCore::RenderTextControlMultiLine::updateFromElement):
  7590. Remove unnecessary createSubtreeIfNeeded() call.
  7591. * rendering/RenderTextControlMultiLine.h: Add a declaration.
  7592. * rendering/RenderTextControlSingleLine.cpp:
  7593. (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
  7594. Remove unnecessary code.
  7595. (WebCore::RenderTextControlSingleLine::innerTextElement): Added.
  7596. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
  7597. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
  7598. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
  7599. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
  7600. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
  7601. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
  7602. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
  7603. (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
  7604. (WebCore::RenderTextControlSingleLine::layout): ditto.
  7605. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
  7606. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
  7607. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
  7608. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
  7609. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
  7610. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
  7611. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
  7612. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
  7613. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
  7614. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
  7615. (WebCore::RenderTextControlSingleLine::updateFromElement):
  7616. ditto, and remove unnecessary createSubtreeIfNeeded() call.
  7617. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  7618. Data member -> function
  7619. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
  7620. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
  7621. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
  7622. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
  7623. * rendering/RenderTextControlSingleLine.h:
  7624. Add declarations, and remove unnecessary data members.
  7625. 2011-05-19 Vitaly Repeshko <vitalyr@chromium.org>
  7626. Reviewed by Adam Barth.
  7627. [V8] Explicitly mark objects with complex GC rules.
  7628. https://bugs.webkit.org/show_bug.cgi?id=61131
  7629. From the GC point view there are two kinds of objects: the ones
  7630. that may participate in object grouping (i.e. their lifetime
  7631. depends on other objects) and the ones that never participate in
  7632. grouping (independent). V8 added support for marking persistent
  7633. handles as independent so that the GC can process the objects they
  7634. hold faster. The motivating use case here is typed arrays.
  7635. This patch adds V8-specific inherited IDL attribute
  7636. V8DependentLifetime to types used in V8GCController, which is
  7637. exactly the set of types with object lifetimes depending on other
  7638. objects. The handles for the types that are not marked with the
  7639. new attribute can be marked as independent and GC-ed faster.
  7640. * bindings/scripts/CodeGeneratorV8.pm: Added proccessing of the new attribute.
  7641. Updated test output:
  7642. * bindings/scripts/test/V8/V8TestInterface.cpp:
  7643. (WebCore::V8TestInterface::wrapSlow):
  7644. * bindings/scripts/test/V8/V8TestInterface.h:
  7645. * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  7646. (WebCore::V8TestMediaQueryListListener::wrapSlow):
  7647. * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
  7648. * bindings/scripts/test/V8/V8TestObj.cpp:
  7649. (WebCore::V8TestObj::wrapSlow):
  7650. * bindings/scripts/test/V8/V8TestObj.h:
  7651. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
  7652. (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
  7653. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
  7654. Added the new attribute:
  7655. * css/CSSRule.idl:
  7656. * css/CSSRuleList.idl:
  7657. * css/CSSStyleDeclaration.idl:
  7658. * css/CSSValue.idl:
  7659. * css/StyleSheet.idl:
  7660. * css/StyleSheetList.idl:
  7661. * dom/DOMImplementation.idl:
  7662. * dom/Node.idl:
  7663. 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
  7664. Unreviewed, rolling out r87014, r87016, and r87017.
  7665. http://trac.webkit.org/changeset/87014
  7666. http://trac.webkit.org/changeset/87016
  7667. http://trac.webkit.org/changeset/87017
  7668. https://bugs.webkit.org/show_bug.cgi?id=61266
  7669. It made more tests assert (Requested by Ossy on #webkit).
  7670. * css/html.css:
  7671. (input::-webkit-inner-spin-button):
  7672. (input::-webkit-outer-spin-button):
  7673. (input::-webkit-input-speech-button):
  7674. * dom/Element.cpp:
  7675. (WebCore::Element::recalcStyle):
  7676. (WebCore::Element::isSpellCheckingEnabled):
  7677. * dom/Node.cpp:
  7678. * dom/Node.h:
  7679. * dom/Position.cpp:
  7680. (WebCore::Position::Position):
  7681. (WebCore::Position::containerNode):
  7682. (WebCore::Position::parentAnchoredEquivalent):
  7683. (WebCore::Position::previous):
  7684. (WebCore::Position::next):
  7685. (WebCore::Position::parentEditingBoundary):
  7686. (WebCore::Position::atStartOfTree):
  7687. (WebCore::Position::atEndOfTree):
  7688. * dom/Position.h:
  7689. (WebCore::positionInParentBeforeNode):
  7690. (WebCore::positionInParentAfterNode):
  7691. * editing/CompositeEditCommand.cpp:
  7692. (WebCore::CompositeEditCommand::insertNodeAfter):
  7693. (WebCore::CompositeEditCommand::removeNode):
  7694. * editing/Editor.cpp:
  7695. (WebCore::Editor::findString):
  7696. * editing/FrameSelection.cpp:
  7697. (WebCore::FrameSelection::selectAll):
  7698. * editing/FrameSelection.h:
  7699. (WebCore::FrameSelection::shadowTreeRootNode):
  7700. * editing/InsertParagraphSeparatorCommand.cpp:
  7701. (WebCore::InsertParagraphSeparatorCommand::doApply):
  7702. * editing/ReplaceSelectionCommand.cpp:
  7703. (WebCore::ReplacementFragment::removeNode):
  7704. (WebCore::ReplacementFragment::insertNodeBefore):
  7705. * editing/VisibleSelection.cpp:
  7706. (WebCore::VisibleSelection::isAll):
  7707. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
  7708. (WebCore::VisibleSelection::shadowTreeRootNode):
  7709. * editing/VisibleSelection.h:
  7710. * editing/htmlediting.cpp:
  7711. (WebCore::visiblePositionBeforeNode):
  7712. (WebCore::visiblePositionAfterNode):
  7713. * html/HTMLInputElement.cpp:
  7714. (WebCore::HTMLInputElement::create):
  7715. (WebCore::HTMLInputElement::parseMappedAttribute):
  7716. * html/HTMLInputElement.h:
  7717. * html/HTMLIsIndexElement.cpp:
  7718. (WebCore::HTMLIsIndexElement::create):
  7719. * html/HTMLTextAreaElement.cpp:
  7720. (WebCore::HTMLTextAreaElement::create):
  7721. * html/HTMLTextAreaElement.h:
  7722. * html/InputType.h:
  7723. * html/SearchInputType.cpp:
  7724. * html/SearchInputType.h:
  7725. (WebCore::SearchInputType::SearchInputType):
  7726. * html/TextFieldInputType.cpp:
  7727. * html/TextFieldInputType.h:
  7728. (WebCore::TextFieldInputType::TextFieldInputType):
  7729. * html/shadow/TextControlInnerElements.cpp:
  7730. (WebCore::TextControlInnerElement::TextControlInnerElement):
  7731. (WebCore::TextControlInnerElement::create):
  7732. (WebCore::TextControlInnerElement::attachInnerElement):
  7733. (WebCore::TextControlInnerElement::detach):
  7734. (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
  7735. (WebCore::TextControlInnerTextElement::create):
  7736. (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
  7737. (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
  7738. (WebCore::SearchFieldCancelButtonElement::detach):
  7739. (WebCore::SpinButtonElement::SpinButtonElement):
  7740. (WebCore::SpinButtonElement::create):
  7741. (WebCore::SpinButtonElement::detach):
  7742. (WebCore::SpinButtonElement::setHovered):
  7743. (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
  7744. (WebCore::InputFieldSpeechButtonElement::create):
  7745. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  7746. (WebCore::InputFieldSpeechButtonElement::detach):
  7747. * html/shadow/TextControlInnerElements.h:
  7748. * rendering/RenderTextControl.cpp:
  7749. (WebCore::RenderTextControl::~RenderTextControl):
  7750. (WebCore::RenderTextControl::styleDidChange):
  7751. (WebCore::RenderTextControl::setInnerTextStyle):
  7752. (WebCore::RenderTextControl::createSubtreeIfNeeded):
  7753. (WebCore::RenderTextControl::textBlockWidth):
  7754. (WebCore::RenderTextControl::updateFromElement):
  7755. (WebCore::RenderTextControl::setInnerTextValue):
  7756. (WebCore::RenderTextControl::hasVisibleTextArea):
  7757. (WebCore::RenderTextControl::isSelectableElement):
  7758. (WebCore::RenderTextControl::selection):
  7759. (WebCore::RenderTextControl::visiblePositionForIndex):
  7760. (WebCore::RenderTextControl::indexForVisiblePosition):
  7761. (WebCore::RenderTextControl::text):
  7762. (WebCore::RenderTextControl::textWithHardLineBreaks):
  7763. (WebCore::RenderTextControl::computeLogicalHeight):
  7764. (WebCore::RenderTextControl::hitInnerTextElement):
  7765. (WebCore::RenderTextControl::forwardEvent):
  7766. (WebCore::RenderTextControl::computePreferredLogicalWidths):
  7767. (WebCore::RenderTextControl::innerTextElement):
  7768. * rendering/RenderTextControl.h:
  7769. * rendering/RenderTextControlMultiLine.cpp:
  7770. (WebCore::RenderTextControlMultiLine::updateFromElement):
  7771. * rendering/RenderTextControlMultiLine.h:
  7772. * rendering/RenderTextControlSingleLine.cpp:
  7773. (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
  7774. (WebCore::RenderTextControlSingleLine::textBaseStyle):
  7775. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  7776. (WebCore::RenderTextControlSingleLine::layout):
  7777. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  7778. (WebCore::RenderTextControlSingleLine::forwardEvent):
  7779. (WebCore::RenderTextControlSingleLine::styleDidChange):
  7780. (WebCore::RenderTextControlSingleLine::hasControlClip):
  7781. (WebCore::RenderTextControlSingleLine::controlClipRect):
  7782. (WebCore::RenderTextControlSingleLine::textBlockWidth):
  7783. (WebCore::RenderTextControlSingleLine::decorationWidthRight):
  7784. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  7785. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
  7786. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  7787. (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
  7788. (WebCore::RenderTextControlSingleLine::updateFromElement):
  7789. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  7790. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
  7791. (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
  7792. (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  7793. (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
  7794. * rendering/RenderTextControlSingleLine.h:
  7795. 2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>
  7796. Reviewed by Andreas Kling.
  7797. GraphicsContext3DInternal object should be called for getAttachedShaders.
  7798. [Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
  7799. https://bugs.webkit.org/show_bug.cgi?id=61202
  7800. LayoutTests/fast/canvas/webgl/gl-object-get-calls.html
  7801. getAttachedShaders should be called on GraphicsContext3DInternal instance.
  7802. It was left out by mistake.
  7803. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  7804. (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
  7805. 2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
  7806. Unreviewed. Strict PassOwnPtr build fix.
  7807. * platform/text/gtk/TextCodecGtk.cpp:
  7808. (WebCore::newTextCodecGtk):
  7809. 2011-05-23 Mikhail Naganov <mnaganov@chromium.org>
  7810. Reviewed by Yury Semikhatsky.
  7811. Web Inspector: [Chromium] Show "Please wait" message during initial
  7812. heap snapshot processing.
  7813. https://bugs.webkit.org/show_bug.cgi?id=61040
  7814. * inspector/front-end/DetailedHeapshotView.js:
  7815. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort):
  7816. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
  7817. (WebInspector.DetailedHeapshotView.profileCallback):
  7818. (WebInspector.DetailedHeapshotView.setDataSource):
  7819. (WebInspector.DetailedHeapshotView):
  7820. (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
  7821. (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource):
  7822. (WebInspector.DetailedHeapshotView.prototype._changeBase):
  7823. (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource):
  7824. (WebInspector.DetailedHeapshotView.prototype._changeView):
  7825. * inspector/front-end/PleaseWaitMessage.js:
  7826. (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
  7827. 2011-05-23 Adam Barth <abarth@webkit.org>
  7828. Strict PassOwnPtr build fixes.
  7829. * platform/gtk/GeolocationServiceGtk.cpp:
  7830. (WebCore::GeolocationServiceGtk::create):
  7831. * platform/gtk/RenderThemeGtk.cpp:
  7832. (WebCore::RenderThemeGtk::adjustSliderTrackStyle):
  7833. (WebCore::RenderThemeGtk::adjustSliderThumbStyle):
  7834. (WebCore::RenderThemeGtk::adjustProgressBarStyle):
  7835. 2011-05-22 Adam Barth <abarth@webkit.org>
  7836. Strict PassOwnPtr build fix.
  7837. * platform/efl/RenderThemeEfl.cpp:
  7838. (WebCore::RenderThemeEfl::adjustProgressBarStyle):
  7839. 2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
  7840. Reviewed by Benjamin Poulain.
  7841. [Qt] Implement toImageData() in QtWebKit Bridge
  7842. https://bugs.webkit.org/show_bug.cgi?id=60897
  7843. Tests are in WebKit/qt/tests/hybridPixmap
  7844. * bridge/qt/qt_pixmapruntime.cpp:
  7845. (JSC::Bindings::QtPixmapToImageDataMethod::name):
  7846. (JSC::Bindings::QtPixmapToImageDataMethod::invoke):
  7847. (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels):
  7848. (JSC::Bindings::QtPixmapClass::methodsNamed):
  7849. (JSC::Bindings::QtPixmapInstance::getPropertyNames):
  7850. Add toImageData() to Qt Bridge, alternative to
  7851. assignToHTMLImageElement().
  7852. 2011-05-22 Dominic Cooney <dominicc@chromium.org>
  7853. Reviewed by Dimitri Glazkov.
  7854. When removing a shadow root, also remove it from the render tree.
  7855. https://bugs.webkit.org/show_bug.cgi?id=61245
  7856. Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
  7857. * dom/Element.cpp:
  7858. (WebCore::Element::removeShadowRoot): Call detach if attached.
  7859. 2011-05-22 Dirk Schulze <krit@webkit.org>
  7860. Reviewed by Nikolas Zimmermann.
  7861. Don't do manually style resolution for SVGElements with renderer
  7862. https://bugs.webkit.org/show_bug.cgi?id=59176
  7863. General clean-up.
  7864. Don't resolve style manually, instead ask the RenderObject for its style.
  7865. Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.
  7866. No new tests needed. No change of behavior.
  7867. * svg/SVGFEDiffuseLightingElement.cpp:
  7868. (WebCore::SVGFEDiffuseLightingElement::build):
  7869. * svg/SVGFEDropShadowElement.cpp:
  7870. (WebCore::SVGFEDropShadowElement::build):
  7871. * svg/SVGFEFloodElement.cpp:
  7872. (WebCore::SVGFEFloodElement::build):
  7873. * svg/SVGFESpecularLightingElement.cpp:
  7874. (WebCore::SVGFESpecularLightingElement::build):
  7875. * svg/svgattrs.in:
  7876. 2011-05-21 Dirk Schulze <krit@webkit.org>
  7877. Reviewed by Darin Adler.
  7878. REGRESSION(r66731): pointer-events are broken in some cases
  7879. https://bugs.webkit.org/show_bug.cgi?id=45467
  7880. The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
  7881. to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
  7882. if none of its childs caught the event. This is the case for all pointer-events other than 'none'.
  7883. Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml
  7884. svg/custom/pointer-events-on-svg-without-pointer.xhtml
  7885. * rendering/svg/RenderSVGRoot.cpp:
  7886. (WebCore::RenderSVGRoot::nodeAtPoint):
  7887. 2011-05-21 Dan Bernstein <mitz@apple.com>
  7888. Reviewed by Darin Adler.
  7889. <rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
  7890. https://bugs.webkit.org/show_bug.cgi?id=61241
  7891. Test: fast/block/positioning/start-ignoring-before.html
  7892. * rendering/RenderBlockLineLayout.cpp:
  7893. (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
  7894. whether to merge the first trailing space with the line break.
  7895. (WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
  7896. character, account for trailing positioned objects that occurred after the midpoint by calling
  7897. updateMidpointsForTrailingBoxes(), which adds midpoints for them.
  7898. 2011-05-21 Jeremy Noble <jer.noble@apple.com>
  7899. Reviewed by Eric Carlson.
  7900. WebKit2: fix failing fullscreen/full-screen-remove* tests.
  7901. https://bugs.webkit.org/show_bug.cgi?id=61027
  7902. * dom/Document.cpp:
  7903. (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be
  7904. synchronous, so make sure to check whether the current element is
  7905. in the DOM before dispatching.
  7906. 2011-05-21 Gavin Peters <gavinp@chromium.org>
  7907. Reviewed by Adam Barth.
  7908. Add rel type prerender to distinguish prerender from prefetch
  7909. https://bugs.webkit.org/show_bug.cgi?id=61079
  7910. Chrome right now uses <link rel=prefetch ...> for one of two things,
  7911. to warm the cache in the same way as firefox, or to launch a speculative
  7912. rendering of a web page, for faster "loading" when the user navigates to it.
  7913. This new rel type will let us distinguish the two cases; the rel type prerender
  7914. isn't used on the web today, but the Google Web Search example prerendering application
  7915. is ready to experiment with it.
  7916. Test: fast/dom/HTMLLinkElement/prerender.html
  7917. * html/HTMLLinkElement.cpp:
  7918. (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  7919. (WebCore::HTMLLinkElement::process):
  7920. * html/HTMLLinkElement.h:
  7921. (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  7922. * loader/cache/CachedResource.cpp:
  7923. (WebCore::defaultPriorityForResourceType):
  7924. * loader/cache/CachedResource.h:
  7925. (WebCore::CachedResource::isLinkResource):
  7926. * loader/cache/CachedResourceLoader.cpp:
  7927. (WebCore::createResource):
  7928. (WebCore::CachedResourceLoader::requestLinkResource):
  7929. (WebCore::CachedResourceLoader::canRequest):
  7930. * loader/cache/CachedResourceLoader.h:
  7931. * loader/cache/CachedResourceRequest.cpp:
  7932. (WebCore::cachedResourceTypeToTargetType):
  7933. (WebCore::CachedResourceRequest::load):
  7934. * platform/network/ResourceRequestBase.h:
  7935. 2011-05-21 Emil A Eklund <eae@chromium.org>
  7936. Reviewed by Eric Seidel.
  7937. Change RenderLineBoxList::hitTest to use IntPoint
  7938. https://bugs.webkit.org/show_bug.cgi?id=61156
  7939. Change the RenderLineBoxList hit testing to use IntPoint and clean up the rect calculation.
  7940. Covered by existing tests.
  7941. * rendering/RenderBlock.cpp:
  7942. (WebCore::RenderBlock::hitTestContents):
  7943. * rendering/RenderInline.cpp:
  7944. (WebCore::RenderInline::nodeAtPoint):
  7945. * rendering/RenderLineBoxList.cpp:
  7946. (WebCore::RenderLineBoxList::hitTest):
  7947. * rendering/RenderLineBoxList.h:
  7948. 2011-05-21 Emil A Eklund <eae@chromium.org>
  7949. Reviewed by Eric Seidel.
  7950. Change HitTestResult to use IntPoint
  7951. https://bugs.webkit.org/show_bug.cgi?id=61230
  7952. Covered by existing tests.
  7953. * rendering/EllipsisBox.cpp:
  7954. (WebCore::EllipsisBox::nodeAtPoint):
  7955. * rendering/HitTestResult.cpp:
  7956. (WebCore::HitTestResult::addNodeToRectBasedTestResult):
  7957. * rendering/HitTestResult.h:
  7958. (WebCore::HitTestResult::isRectBasedTest):
  7959. * rendering/InlineFlowBox.cpp:
  7960. (WebCore::InlineFlowBox::nodeAtPoint):
  7961. * rendering/InlineTextBox.cpp:
  7962. (WebCore::InlineTextBox::nodeAtPoint):
  7963. * rendering/RenderBlock.cpp:
  7964. (WebCore::RenderBlock::nodeAtPoint):
  7965. (WebCore::RenderBlock::hitTestColumns):
  7966. * rendering/RenderBox.cpp:
  7967. (WebCore::RenderBox::nodeAtPoint):
  7968. * rendering/RenderTable.cpp:
  7969. (WebCore::RenderTable::nodeAtPoint):
  7970. * rendering/svg/RenderSVGRoot.cpp:
  7971. (WebCore::RenderSVGRoot::nodeAtPoint):
  7972. 2011-05-21 Jochen Eisinger <jochen@chromium.org>
  7973. Reviewed by Darin Fisher.
  7974. [chromium] add extraData field to resource requests
  7975. https://bugs.webkit.org/show_bug.cgi?id=61033
  7976. * platform/network/chromium/ResourceRequest.h:
  7977. (WebCore::ResourceRequest::ExtraData::~ExtraData):
  7978. (WebCore::ResourceRequest::extraData):
  7979. (WebCore::ResourceRequest::setExtraData):
  7980. 2011-05-21 Kent Tamura <tkent@chromium.org>
  7981. Reviewed by Dimitri Glazkov.
  7982. Change text-based <input> types to the new shadow DOM model
  7983. https://bugs.webkit.org/show_bug.cgi?id=54179
  7984. By this change, text field inputs and textareas have one extra
  7985. shadow node at the root of shadow trees.
  7986. e.g. Before the change:
  7987. <textarea> --(shadow-connection)-- <div> -- ...
  7988. After the change:
  7989. <textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...
  7990. The goals of this change are
  7991. - Change to the new shadow DOM model, and
  7992. - Minimize the patch size.
  7993. We should use shadowPseudoId() in the new shadow DOM model, but the
  7994. shadow elements in this patch don't use it in order to reduce the patch
  7995. size.
  7996. * css/html.css:
  7997. (input::-webkit-inner-spin-button):
  7998. Add vertical-align in order to avoid the button affect the baseline.
  7999. (input::-webkit-outer-spin-button): ditto.
  8000. (input::-webkit-input-speech-button): ditto.
  8001. * dom/Element.cpp:
  8002. (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a
  8003. subclass of Element can override it.
  8004. (WebCore::Element::isSpellCheckingEnabled):
  8005. Handle ShadowRoot, which is not an Element.
  8006. * dom/Node.cpp:
  8007. Add utility functions for editing code.
  8008. (WebCore::Node::nonBoundaryShadowTreeRootNode):
  8009. (WebCore::Node::nonShadowBoundaryParentNode):
  8010. * dom/Node.h: Declare them.
  8011. * dom/Position.cpp:
  8012. - Add some assertions about ShadowRoot
  8013. - Replace parentNode() with nonShadowBoundaryParentNode()
  8014. Because input/textarea shadow structures are changed.
  8015. (WebCore::Position::Position):
  8016. (WebCore::Position::containerNode):
  8017. (WebCore::Position::parentAnchoredEquivalent):
  8018. (WebCore::Position::previous):
  8019. (WebCore::Position::next):
  8020. (WebCore::Position::parentEditingBoundary):
  8021. (WebCore::Position::atStartOfTree):
  8022. (WebCore::Position::atEndOfTree):
  8023. * dom/Position.h: ditto.
  8024. (WebCore::positionInParentBeforeNode):
  8025. (WebCore::positionInParentAfterNode):
  8026. * editing/CompositeEditCommand.cpp: ditto.
  8027. (WebCore::CompositeEditCommand::insertNodeAfter):
  8028. (WebCore::CompositeEditCommand::removeNode):
  8029. * editing/Editor.cpp:
  8030. (WebCore::Editor::findString): ditto.
  8031. * editing/FrameSelection.cpp:
  8032. (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
  8033. * editing/FrameSelection.h:
  8034. Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  8035. * editing/InsertParagraphSeparatorCommand.cpp:
  8036. (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
  8037. * editing/ReplaceSelectionCommand.cpp:
  8038. (WebCore::ReplacementFragment::removeNode): ditto.
  8039. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
  8040. * editing/VisibleSelection.cpp:
  8041. Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns
  8042. a child node of ShadowRoot.
  8043. (WebCore::VisibleSelection::isAll):
  8044. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
  8045. (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
  8046. * editing/VisibleSelection.h: ditto.
  8047. * editing/htmlediting.cpp: Add assertions.
  8048. (WebCore::visiblePositionBeforeNode):
  8049. (WebCore::visiblePositionAfterNode):
  8050. * html/HTMLInputElement.cpp:
  8051. (WebCore::HTMLInputElement::create): Calls createShadowSubtree().
  8052. (WebCore::HTMLInputElement::createShadowSubtree):
  8053. Calls InputType::createShadowSubTree().
  8054. (WebCore::HTMLInputElement::innerTextElement):
  8055. Accessor of a shadow node. This is used by RenderTextControlSingleLine.
  8056. (WebCore::HTMLInputElement::innerBlockElement): ditto.
  8057. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
  8058. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
  8059. (WebCore::HTMLInputElement::resultsButtonElement): ditto.
  8060. (WebCore::HTMLInputElement::cancelButtonElement): ditto.
  8061. (WebCore::HTMLInputElement::speechButtonElement): ditto.
  8062. (WebCore::HTMLInputElement::parseMappedAttribute):
  8063. Rebuild shadow trees because x-webkit-speech attribute affects it.
  8064. * html/HTMLInputElement.h: Add declarations.
  8065. * html/HTMLIsIndexElement.cpp:
  8066. (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
  8067. * html/HTMLTextAreaElement.cpp:
  8068. (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
  8069. (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
  8070. * html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  8071. * html/InputType.h: Add default implementations of accessors.
  8072. (WebCore::InputType::innerBlockElement):
  8073. (WebCore::InputType::innerTextElement):
  8074. (WebCore::InputType::innerSpinButtonElement):
  8075. (WebCore::InputType::outerSpinButtonElement):
  8076. (WebCore::InputType::resultsButtonElement):
  8077. (WebCore::InputType::cancelButtonElement):
  8078. (WebCore::InputType::speechButtonElement):
  8079. * html/SearchInputType.cpp:
  8080. (WebCore::SearchInputType::SearchInputType): Initializes new data members.
  8081. (WebCore::SearchInputType::createShadowSubtree):
  8082. Moved from RenderTextControlSingleLine.
  8083. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
  8084. * html/SearchInputType.h: Add declarations.
  8085. (WebCore::SearchInputType::innerBlockElement):
  8086. (WebCore::SearchInputType::resultsButtonElement):
  8087. (WebCore::SearchInputType::cancelButtonElement):
  8088. * html/TextFieldInputType.cpp:
  8089. (WebCore::TextFieldInputType::TextFieldInputType):
  8090. Initializes new data members.
  8091. (WebCore::TextFieldInputType::createShadowSubtree):
  8092. Moved from RenderTextControlSingleLine.
  8093. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
  8094. * html/TextFieldInputType.h: Add declarations.
  8095. (WebCore::TextFieldInputType::innerTextElement):
  8096. (WebCore::TextFieldInputType::innerSpinButtonElement):
  8097. (WebCore::TextFieldInputType::outerSpinButtonElement):
  8098. (WebCore::TextFieldInputType::speechButtonElement):
  8099. (WebCore::TextFieldInputType::setInnerTextElement):
  8100. (WebCore::TextFieldInputType::setSpeechButtonElement):
  8101. * html/shadow/TextControlInnerElements.cpp:
  8102. (WebCore::TextControlInnerElement::TextControlInnerElement):
  8103. Remove shadowParent parameter. It is unnecessary because we switch to
  8104. new shadow model.
  8105. (WebCore::TextControlInnerElement::create):
  8106. Change the parameter type to Document.
  8107. (WebCore::TextControlInnerElement::styleForRenderer):
  8108. Override this in order to set style by
  8109. RenderTextControlSingleLine::createInnerBlockStyle().
  8110. (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
  8111. Remove shadowParent parameter.
  8112. Inherit HTMLDivElement, not TextControlInnerElement.
  8113. (WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
  8114. (WebCore::TextControlInnerTextElement::styleForRenderer):
  8115. Override this in order to set style by
  8116. RenderTextControlSingleLine::createInnerTextStyle().
  8117. (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
  8118. Inherit HTMLDivElement, not TextControlInnerElement.
  8119. (WebCore::SearchFieldResultsButtonElement::styleForRenderer):
  8120. Override this in order to set style by
  8121. RenderTextControlSingleLine::createResultButtonStyle().
  8122. (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
  8123. Inherit HTMLDivElement, not TextControlInnerElement.
  8124. (WebCore::SearchFieldCancelButtonElement::styleForRenderer):
  8125. Override this in order to set style by
  8126. RenderTextControlSingleLine::createCancelButtonStyle().
  8127. (WebCore::SearchFieldCancelButtonElement::detach):
  8128. Update for the parent class change.
  8129. (WebCore::SpinButtonElement::SpinButtonElement):
  8130. - Change the parameter type: shadowParent -> Document
  8131. - Add the inner flag
  8132. - Inherit HTMLDivElement, not TextControlInnerElement.
  8133. (WebCore::SpinButtonElement::createInner): Introduce a new factory
  8134. method to hide a bool parameter of the constructor.
  8135. (WebCore::SpinButtonElement::createOuter): ditto.
  8136. (WebCore::SpinButtonElement::styleForRenderer):
  8137. Override this in order to set style by
  8138. RenderTextControlSingleLine::createInnerSpinButtonStyle() or
  8139. createOuterSpinButtonStyle().
  8140. (WebCore::SpinButtonElement::detach): Update for the parent class change.
  8141. (WebCore::SpinButtonElement::setHovered): ditto.
  8142. (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
  8143. - Change the parameter type: shadowParent -> Document
  8144. - Inherit HTMLDivElement, not TextControlInnerElement.
  8145. - Do not register this as a speech input listener here.
  8146. (WebCore::InputFieldSpeechButtonElement::create):
  8147. Update for the parameter change.
  8148. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  8149. Do not handle click event if listener registration is not done.
  8150. (WebCore::InputFieldSpeechButtonElement::attach):
  8151. Register this as a speech input listener.
  8152. (WebCore::InputFieldSpeechButtonElement::detach):
  8153. Update for the parent class change.
  8154. (WebCore::InputFieldSpeechButtonElement::styleForRenderer):
  8155. Override this in order to set style by
  8156. RenderTextControlSingleLine::createSpeechButtonStyle().
  8157. * html/shadow/TextControlInnerElements.h:
  8158. (WebCore::TextControlInnerTextElement::isMouseFocusable):
  8159. Add this because the class is not a subclass of TextControllInnerElement.
  8160. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
  8161. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
  8162. (WebCore::SpinButtonElement::isMouseFocusable): ditto.
  8163. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
  8164. * rendering/RenderTextControl.cpp:
  8165. (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
  8166. (WebCore::RenderTextControl::styleDidChange):
  8167. innerTextElement can have no renderer.
  8168. Explicitly call setNeedsStyleRecals() for innerTextElement. It is
  8169. needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.
  8170. (WebCore::RenderTextControl::textBlockWidth): Member data -> function
  8171. (WebCore::RenderTextControl::updateFromElement): ditto.
  8172. (WebCore::RenderTextControl::setInnerTextValue): ditto.
  8173. (WebCore::RenderTextControl::hasVisibleTextArea): ditto.
  8174. (WebCore::RenderTextControl::isSelectableElement): ditto.
  8175. (WebCore::RenderTextControl::selection): ditto.
  8176. (WebCore::RenderTextControl::visiblePositionForIndex): ditto.
  8177. (WebCore::RenderTextControl::indexForVisiblePosition): ditto.
  8178. (WebCore::RenderTextControl::text): ditto.
  8179. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
  8180. (WebCore::RenderTextControl::computeLogicalHeight): ditto.
  8181. (WebCore::RenderTextControl::hitInnerTextElement): ditto.
  8182. (WebCore::RenderTextControl::forwardEvent): ditto.
  8183. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
  8184. * rendering/RenderTextControl.h:
  8185. - Make m_innerText virtual function.
  8186. - Make createInnerTextStyle() public in order that
  8187. TextControlInnerElements can call it.
  8188. * rendering/RenderTextControlMultiLine.cpp:
  8189. (WebCore::RenderTextControlMultiLine::innerTextElement): Added.
  8190. (WebCore::RenderTextControlMultiLine::updateFromElement):
  8191. Remove unnecessary createSubtreeIfNeeded() call.
  8192. * rendering/RenderTextControlMultiLine.h: Add a declaration.
  8193. * rendering/RenderTextControlSingleLine.cpp:
  8194. (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
  8195. Remove unnecessary code.
  8196. (WebCore::RenderTextControlSingleLine::innerTextElement): Added.
  8197. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
  8198. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
  8199. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
  8200. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
  8201. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
  8202. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
  8203. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
  8204. (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
  8205. (WebCore::RenderTextControlSingleLine::layout): ditto.
  8206. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
  8207. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
  8208. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
  8209. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
  8210. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
  8211. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
  8212. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
  8213. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
  8214. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
  8215. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
  8216. (WebCore::RenderTextControlSingleLine::updateFromElement):
  8217. ditto, and remove unnecessary createSubtreeIfNeeded() call.
  8218. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  8219. Data member -> function
  8220. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
  8221. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
  8222. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
  8223. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
  8224. * rendering/RenderTextControlSingleLine.h:
  8225. Add declarations, and remove unnecessary data members.
  8226. 2011-05-21 Chris Rogers <crogers@google.com>
  8227. Reviewed by Kenneth Russell.
  8228. AudioBufferSourceNode noteOff() method must respect scheduling time
  8229. https://bugs.webkit.org/show_bug.cgi?id=61226
  8230. No new tests since audio API is not yet implemented.
  8231. * webaudio/AudioBufferSourceNode.cpp:
  8232. (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
  8233. (WebCore::AudioBufferSourceNode::process):
  8234. (WebCore::AudioBufferSourceNode::provideInput):
  8235. (WebCore::AudioBufferSourceNode::finish):
  8236. (WebCore::AudioBufferSourceNode::noteGrainOn):
  8237. (WebCore::AudioBufferSourceNode::noteOff):
  8238. * webaudio/AudioBufferSourceNode.h:
  8239. 2011-05-20 Dirk Schulze <krit@webkit.org>
  8240. Reviewed by Nikolas Zimmermann.
  8241. Share more code in PathTraversalState
  8242. https://bugs.webkit.org/show_bug.cgi?id=61238
  8243. Share more code between SVGPathTraversalStateBuilder and Path in PathTraversalState.
  8244. No change in functionality, so no new tests.
  8245. * platform/graphics/Path.cpp:
  8246. (WebCore::pathLengthApplierFunction):
  8247. * platform/graphics/PathTraversalState.cpp:
  8248. (WebCore::PathTraversalState::processSegment):
  8249. * platform/graphics/PathTraversalState.h:
  8250. * svg/SVGPathTraversalStateBuilder.cpp:
  8251. (WebCore::SVGPathTraversalStateBuilder::continueConsuming):
  8252. 2011-05-21 Nikolas Zimmermann <nzimmermann@rim.com>
  8253. Reviewed by Rob Buis.
  8254. SVG svgAttributeChanged/synchronizeProperty/parseMappedAttribute should be optimized
  8255. https://bugs.webkit.org/show_bug.cgi?id=61183
  8256. Example: rect.x.baseVal.value = 100;
  8257. What happens: SVGRectElement::svgAttributeChanged(const QualifiedName& attrName) is invoked with "SVGNames::rectAttr" as parameter.
  8258. void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
  8259. {
  8260. SVGStyledTransformableElement::svgAttributeChanged(attrName);
  8261. // Handle my own attribute changes...
  8262. }
  8263. Currently we always traverse the base class hierarchy, when invoking svgAttributeChanged. Every svgAttributeChanged call from a class
  8264. like SVGRectElement has to reach the base class SVGStyledElement::svgAttributeChanged, as it handles invalidation of the instances of
  8265. an element. Say that a <rect> is referenced by a <use> and we change the 'x' attribute of the <rect>, then SVGStyledElement::svgAttributeChanged,
  8266. calls SVGElementInstance::invalidateAllInstancesOfElement(this), so that the <use> can rebuild its shadow tree...
  8267. That's the only reason all svgAttributeChanged implementations call the base class immediately, so SVGStyledElement is always reached.
  8268. Switch to a more efficient pattern, by providing a "bool isSupportedAttribute(const QualifiedName&);" function for all SVG*Elements.
  8269. It contains all attributes the particular SVG*Element class handles (but not its parent classes attributes). For example SVGRectElement
  8270. contains x/y/width/height/rx/ry attributes, and the ones from SVGTests/SVGLangSpace/SVGExternalResourcesRequired (xml:space/lang, etc.),
  8271. but not eg. transform as that's handled by the parent class SVGStyledTransformableElement.
  8272. void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
  8273. {
  8274. if (!isSupportedAttribute.contains(attrName)) {
  8275. SVGStyledTransformableElement::svgAttributeChanged(attrName);
  8276. return;
  8277. }
  8278. // When we get here, we know for sure it's one of our attributes that has changed.
  8279. // Note for eg. SVGNames::transformAttr, the call from SVGRectElement::svgAttributeChanged, would be immediately forwarded to the base class, which handles transformAttr changes)
  8280. if (attrName == SVGNames::xAttr) { do_work(); return; }
  8281. if (attrName == SVGNames::yAttr) { do_work(); return; }
  8282. ...
  8283. // Assure that we handled all properties we claim support for in "isSupportedAttribute()".
  8284. ASSERT_NOT_REACHED();
  8285. }
  8286. Exactly the same pattern can be applied to synchronizeProperty and parseMappedAttribute to speed them up as well.
  8287. Add "SVGElementInstance::InvalidationGuard guard(this)" statements in all svgAttributeChanged implementations, that calls invalidateAllInstancesOfElement(this)
  8288. upon destruction, after we've reacted to the svg attribute change. This assures we never forget to call the invalidation method anywhere, and don't
  8289. need to rely on the base class svgAttributeChanged() call to do it.
  8290. It's a slight overal performance progression.
  8291. * svg/SVGAElement.cpp:
  8292. (WebCore::SVGAElement::isSupportedAttribute):
  8293. (WebCore::SVGAElement::parseMappedAttribute):
  8294. (WebCore::SVGAElement::svgAttributeChanged):
  8295. (WebCore::SVGAElement::synchronizeProperty):
  8296. * svg/SVGAElement.h:
  8297. * svg/SVGAnimateMotionElement.cpp:
  8298. (WebCore::SVGAnimateMotionElement::isSupportedAttribute):
  8299. (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  8300. * svg/SVGAnimateMotionElement.h:
  8301. * svg/SVGAnimateTransformElement.cpp:
  8302. (WebCore::SVGAnimateTransformElement::isSupportedAttribute):
  8303. (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
  8304. * svg/SVGAnimateTransformElement.h:
  8305. * svg/SVGAnimationElement.cpp:
  8306. (WebCore::SVGAnimationElement::isSupportedAttribute):
  8307. (WebCore::SVGAnimationElement::parseMappedAttribute):
  8308. * svg/SVGAnimationElement.h:
  8309. * svg/SVGCircleElement.cpp:
  8310. (WebCore::SVGCircleElement::isSupportedAttribute):
  8311. (WebCore::SVGCircleElement::parseMappedAttribute):
  8312. (WebCore::SVGCircleElement::svgAttributeChanged):
  8313. (WebCore::SVGCircleElement::synchronizeProperty):
  8314. * svg/SVGCircleElement.h:
  8315. * svg/SVGClipPathElement.cpp:
  8316. (WebCore::SVGClipPathElement::isSupportedAttribute):
  8317. (WebCore::SVGClipPathElement::parseMappedAttribute):
  8318. (WebCore::SVGClipPathElement::svgAttributeChanged):
  8319. (WebCore::SVGClipPathElement::synchronizeProperty):
  8320. * svg/SVGClipPathElement.h:
  8321. * svg/SVGComponentTransferFunctionElement.cpp:
  8322. (WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
  8323. (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
  8324. (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
  8325. * svg/SVGComponentTransferFunctionElement.h:
  8326. * svg/SVGCursorElement.cpp:
  8327. (WebCore::SVGCursorElement::isSupportedAttribute):
  8328. (WebCore::SVGCursorElement::parseMappedAttribute):
  8329. (WebCore::SVGCursorElement::svgAttributeChanged):
  8330. (WebCore::SVGCursorElement::synchronizeProperty):
  8331. * svg/SVGCursorElement.h:
  8332. * svg/SVGElementInstance.h:
  8333. (WebCore::SVGElementInstance::InvalidationGuard::InvalidationGuard):
  8334. (WebCore::SVGElementInstance::InvalidationGuard::~InvalidationGuard):
  8335. * svg/SVGEllipseElement.cpp:
  8336. (WebCore::SVGEllipseElement::isSupportedAttribute):
  8337. (WebCore::SVGEllipseElement::parseMappedAttribute):
  8338. (WebCore::SVGEllipseElement::svgAttributeChanged):
  8339. (WebCore::SVGEllipseElement::synchronizeProperty):
  8340. * svg/SVGEllipseElement.h:
  8341. * svg/SVGExternalResourcesRequired.cpp:
  8342. (WebCore::SVGExternalResourcesRequired::addSupportedAttributes):
  8343. * svg/SVGExternalResourcesRequired.h:
  8344. * svg/SVGFEBlendElement.cpp:
  8345. (WebCore::SVGFEBlendElement::isSupportedAttribute):
  8346. (WebCore::SVGFEBlendElement::parseMappedAttribute):
  8347. (WebCore::SVGFEBlendElement::svgAttributeChanged):
  8348. (WebCore::SVGFEBlendElement::synchronizeProperty):
  8349. * svg/SVGFEBlendElement.h:
  8350. * svg/SVGFEColorMatrixElement.cpp:
  8351. (WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
  8352. (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
  8353. (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
  8354. (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
  8355. * svg/SVGFEColorMatrixElement.h:
  8356. * svg/SVGFEComponentTransferElement.cpp:
  8357. (WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
  8358. (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
  8359. (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
  8360. * svg/SVGFEComponentTransferElement.h:
  8361. * svg/SVGFECompositeElement.cpp:
  8362. (WebCore::SVGFECompositeElement::isSupportedAttribute):
  8363. (WebCore::SVGFECompositeElement::parseMappedAttribute):
  8364. (WebCore::SVGFECompositeElement::svgAttributeChanged):
  8365. (WebCore::SVGFECompositeElement::synchronizeProperty):
  8366. * svg/SVGFECompositeElement.h:
  8367. * svg/SVGFEConvolveMatrixElement.cpp:
  8368. (WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
  8369. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute):
  8370. (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  8371. (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty):
  8372. * svg/SVGFEConvolveMatrixElement.h:
  8373. * svg/SVGFEDiffuseLightingElement.cpp:
  8374. (WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
  8375. (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
  8376. (WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
  8377. (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
  8378. * svg/SVGFEDiffuseLightingElement.h:
  8379. * svg/SVGFEDisplacementMapElement.cpp:
  8380. (WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
  8381. (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute):
  8382. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
  8383. (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
  8384. * svg/SVGFEDisplacementMapElement.h:
  8385. * svg/SVGFEDropShadowElement.cpp:
  8386. (WebCore::SVGFEDropShadowElement::isSupportedAttribute):
  8387. (WebCore::SVGFEDropShadowElement::parseMappedAttribute):
  8388. (WebCore::SVGFEDropShadowElement::svgAttributeChanged):
  8389. (WebCore::SVGFEDropShadowElement::synchronizeProperty):
  8390. * svg/SVGFEDropShadowElement.h:
  8391. * svg/SVGFEGaussianBlurElement.cpp:
  8392. (WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
  8393. (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
  8394. (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
  8395. (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
  8396. * svg/SVGFEGaussianBlurElement.h:
  8397. * svg/SVGFEImageElement.cpp:
  8398. (WebCore::SVGFEImageElement::isSupportedAttribute):
  8399. (WebCore::SVGFEImageElement::parseMappedAttribute):
  8400. (WebCore::SVGFEImageElement::svgAttributeChanged):
  8401. (WebCore::SVGFEImageElement::synchronizeProperty):
  8402. * svg/SVGFEImageElement.h:
  8403. * svg/SVGFELightElement.cpp:
  8404. (WebCore::SVGFELightElement::isSupportedAttribute):
  8405. (WebCore::SVGFELightElement::parseMappedAttribute):
  8406. (WebCore::SVGFELightElement::svgAttributeChanged):
  8407. (WebCore::SVGFELightElement::synchronizeProperty):
  8408. * svg/SVGFELightElement.h:
  8409. * svg/SVGFEMergeNodeElement.cpp:
  8410. (WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
  8411. (WebCore::SVGFEMergeNodeElement::parseMappedAttribute):
  8412. (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
  8413. (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
  8414. * svg/SVGFEMergeNodeElement.h:
  8415. * svg/SVGFEMorphologyElement.cpp:
  8416. (WebCore::SVGFEMorphologyElement::isSupportedAttribute):
  8417. (WebCore::SVGFEMorphologyElement::parseMappedAttribute):
  8418. (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  8419. (WebCore::SVGFEMorphologyElement::synchronizeProperty):
  8420. * svg/SVGFEMorphologyElement.h:
  8421. * svg/SVGFEOffsetElement.cpp:
  8422. (WebCore::SVGFEOffsetElement::isSupportedAttribute):
  8423. (WebCore::SVGFEOffsetElement::parseMappedAttribute):
  8424. (WebCore::SVGFEOffsetElement::svgAttributeChanged):
  8425. (WebCore::SVGFEOffsetElement::synchronizeProperty):
  8426. * svg/SVGFEOffsetElement.h:
  8427. * svg/SVGFESpecularLightingElement.cpp:
  8428. (WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
  8429. (WebCore::SVGFESpecularLightingElement::parseMappedAttribute):
  8430. (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
  8431. (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
  8432. * svg/SVGFESpecularLightingElement.h:
  8433. * svg/SVGFETileElement.cpp:
  8434. (WebCore::SVGFETileElement::isSupportedAttribute):
  8435. (WebCore::SVGFETileElement::parseMappedAttribute):
  8436. (WebCore::SVGFETileElement::svgAttributeChanged):
  8437. (WebCore::SVGFETileElement::synchronizeProperty):
  8438. * svg/SVGFETileElement.h:
  8439. * svg/SVGFETurbulenceElement.cpp:
  8440. (WebCore::SVGFETurbulenceElement::isSupportedAttribute):
  8441. (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
  8442. (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
  8443. (WebCore::SVGFETurbulenceElement::synchronizeProperty):
  8444. * svg/SVGFETurbulenceElement.h:
  8445. * svg/SVGFilterElement.cpp:
  8446. (WebCore::SVGFilterElement::isSupportedAttribute):
  8447. (WebCore::SVGFilterElement::parseMappedAttribute):
  8448. (WebCore::SVGFilterElement::svgAttributeChanged):
  8449. (WebCore::SVGFilterElement::synchronizeProperty):
  8450. * svg/SVGFilterElement.h:
  8451. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  8452. (WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
  8453. (WebCore::SVGFilterPrimitiveStandardAttributes::parseMappedAttribute):
  8454. (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
  8455. (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
  8456. * svg/SVGFilterPrimitiveStandardAttributes.h:
  8457. * svg/SVGFitToViewBox.cpp:
  8458. (WebCore::SVGFitToViewBox::parseMappedAttribute):
  8459. (WebCore::SVGFitToViewBox::synchronizeProperties):
  8460. (WebCore::SVGFitToViewBox::addSupportedAttributes):
  8461. * svg/SVGFitToViewBox.h:
  8462. * svg/SVGForeignObjectElement.cpp:
  8463. (WebCore::SVGForeignObjectElement::isSupportedAttribute):
  8464. (WebCore::SVGForeignObjectElement::parseMappedAttribute):
  8465. (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  8466. (WebCore::SVGForeignObjectElement::synchronizeProperty):
  8467. * svg/SVGForeignObjectElement.h:
  8468. * svg/SVGGElement.cpp:
  8469. (WebCore::SVGGElement::isSupportedAttribute):
  8470. (WebCore::SVGGElement::parseMappedAttribute):
  8471. (WebCore::SVGGElement::svgAttributeChanged):
  8472. (WebCore::SVGGElement::synchronizeProperty):
  8473. * svg/SVGGElement.h:
  8474. * svg/SVGGradientElement.cpp:
  8475. (WebCore::SVGGradientElement::isSupportedAttribute):
  8476. (WebCore::SVGGradientElement::parseMappedAttribute):
  8477. (WebCore::SVGGradientElement::svgAttributeChanged):
  8478. (WebCore::SVGGradientElement::synchronizeProperty):
  8479. * svg/SVGGradientElement.h:
  8480. * svg/SVGImageElement.cpp:
  8481. (WebCore::SVGImageElement::isSupportedAttribute):
  8482. (WebCore::SVGImageElement::parseMappedAttribute):
  8483. (WebCore::SVGImageElement::svgAttributeChanged):
  8484. (WebCore::SVGImageElement::synchronizeProperty):
  8485. * svg/SVGImageElement.h:
  8486. * svg/SVGLangSpace.cpp:
  8487. (WebCore::SVGLangSpace::addSupportedAttributes):
  8488. * svg/SVGLangSpace.h:
  8489. * svg/SVGLineElement.cpp:
  8490. (WebCore::SVGLineElement::isSupportedAttribute):
  8491. (WebCore::SVGLineElement::parseMappedAttribute):
  8492. (WebCore::SVGLineElement::svgAttributeChanged):
  8493. (WebCore::SVGLineElement::synchronizeProperty):
  8494. * svg/SVGLineElement.h:
  8495. * svg/SVGLinearGradientElement.cpp:
  8496. (WebCore::SVGLinearGradientElement::isSupportedAttribute):
  8497. (WebCore::SVGLinearGradientElement::parseMappedAttribute):
  8498. (WebCore::SVGLinearGradientElement::svgAttributeChanged):
  8499. (WebCore::SVGLinearGradientElement::synchronizeProperty):
  8500. * svg/SVGLinearGradientElement.h:
  8501. * svg/SVGMPathElement.cpp:
  8502. (WebCore::SVGMPathElement::isSupportedAttribute):
  8503. (WebCore::SVGMPathElement::parseMappedAttribute):
  8504. (WebCore::SVGMPathElement::synchronizeProperty):
  8505. * svg/SVGMPathElement.h:
  8506. * svg/SVGMarkerElement.cpp:
  8507. (WebCore::SVGMarkerElement::isSupportedAttribute):
  8508. (WebCore::SVGMarkerElement::parseMappedAttribute):
  8509. (WebCore::SVGMarkerElement::svgAttributeChanged):
  8510. (WebCore::SVGMarkerElement::synchronizeProperty):
  8511. * svg/SVGMarkerElement.h:
  8512. * svg/SVGMaskElement.cpp:
  8513. (WebCore::SVGMaskElement::isSupportedAttribute):
  8514. (WebCore::SVGMaskElement::parseMappedAttribute):
  8515. (WebCore::SVGMaskElement::svgAttributeChanged):
  8516. (WebCore::SVGMaskElement::synchronizeProperty):
  8517. * svg/SVGMaskElement.h:
  8518. * svg/SVGPathElement.cpp:
  8519. (WebCore::SVGPathElement::isSupportedAttribute):
  8520. (WebCore::SVGPathElement::parseMappedAttribute):
  8521. (WebCore::SVGPathElement::svgAttributeChanged):
  8522. (WebCore::SVGPathElement::synchronizeProperty):
  8523. * svg/SVGPathElement.h:
  8524. * svg/SVGPatternElement.cpp:
  8525. (WebCore::SVGPatternElement::isSupportedAttribute):
  8526. (WebCore::SVGPatternElement::parseMappedAttribute):
  8527. (WebCore::SVGPatternElement::svgAttributeChanged):
  8528. (WebCore::SVGPatternElement::synchronizeProperty):
  8529. * svg/SVGPatternElement.h:
  8530. * svg/SVGPolyElement.cpp:
  8531. (WebCore::SVGPolyElement::isSupportedAttribute):
  8532. (WebCore::SVGPolyElement::parseMappedAttribute):
  8533. (WebCore::SVGPolyElement::svgAttributeChanged):
  8534. * svg/SVGPolyElement.h:
  8535. * svg/SVGRadialGradientElement.cpp:
  8536. (WebCore::SVGRadialGradientElement::isSupportedAttribute):
  8537. (WebCore::SVGRadialGradientElement::parseMappedAttribute):
  8538. (WebCore::SVGRadialGradientElement::svgAttributeChanged):
  8539. (WebCore::SVGRadialGradientElement::synchronizeProperty):
  8540. * svg/SVGRadialGradientElement.h:
  8541. * svg/SVGRectElement.cpp:
  8542. (WebCore::SVGRectElement::isSupportedAttribute):
  8543. (WebCore::SVGRectElement::parseMappedAttribute):
  8544. (WebCore::SVGRectElement::svgAttributeChanged):
  8545. (WebCore::SVGRectElement::synchronizeProperty):
  8546. * svg/SVGRectElement.h:
  8547. * svg/SVGSVGElement.cpp:
  8548. (WebCore::SVGSVGElement::svgAttributeChanged):
  8549. (WebCore::SVGSVGElement::synchronizeProperty):
  8550. * svg/SVGScriptElement.cpp:
  8551. (WebCore::SVGScriptElement::isSupportedAttribute):
  8552. (WebCore::SVGScriptElement::parseMappedAttribute):
  8553. (WebCore::SVGScriptElement::svgAttributeChanged):
  8554. (WebCore::SVGScriptElement::synchronizeProperty):
  8555. * svg/SVGScriptElement.h:
  8556. * svg/SVGStopElement.cpp:
  8557. (WebCore::SVGStopElement::isSupportedAttribute):
  8558. (WebCore::SVGStopElement::parseMappedAttribute):
  8559. (WebCore::SVGStopElement::svgAttributeChanged):
  8560. (WebCore::SVGStopElement::synchronizeProperty):
  8561. * svg/SVGStopElement.h:
  8562. * svg/SVGStyleElement.cpp:
  8563. (WebCore::SVGStyleElement::isSupportedAttribute):
  8564. (WebCore::SVGStyleElement::parseMappedAttribute):
  8565. * svg/SVGStyleElement.h:
  8566. * svg/SVGStyledElement.cpp:
  8567. (WebCore::SVGStyledElement::parseMappedAttribute):
  8568. (WebCore::SVGStyledElement::svgAttributeChanged):
  8569. (WebCore::SVGStyledElement::synchronizeProperty):
  8570. * svg/SVGStyledTransformableElement.cpp:
  8571. (WebCore::SVGStyledTransformableElement::isSupportedAttribute):
  8572. (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
  8573. (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
  8574. (WebCore::SVGStyledTransformableElement::synchronizeProperty):
  8575. * svg/SVGStyledTransformableElement.h:
  8576. * svg/SVGSymbolElement.cpp:
  8577. (WebCore::SVGSymbolElement::isSupportedAttribute):
  8578. (WebCore::SVGSymbolElement::parseMappedAttribute):
  8579. (WebCore::SVGSymbolElement::svgAttributeChanged):
  8580. (WebCore::SVGSymbolElement::synchronizeProperty):
  8581. * svg/SVGSymbolElement.h:
  8582. * svg/SVGTRefElement.cpp:
  8583. (WebCore::SVGTRefElement::isSupportedAttribute):
  8584. (WebCore::SVGTRefElement::parseMappedAttribute):
  8585. (WebCore::SVGTRefElement::svgAttributeChanged):
  8586. (WebCore::SVGTRefElement::synchronizeProperty):
  8587. * svg/SVGTRefElement.h:
  8588. * svg/SVGTests.cpp:
  8589. (WebCore::SVGTests::addSupportedAttributes):
  8590. * svg/SVGTests.h:
  8591. * svg/SVGTextContentElement.cpp:
  8592. (WebCore::SVGTextContentElement::isSupportedAttribute):
  8593. (WebCore::SVGTextContentElement::parseMappedAttribute):
  8594. (WebCore::SVGTextContentElement::synchronizeProperty):
  8595. (WebCore::SVGTextContentElement::svgAttributeChanged):
  8596. * svg/SVGTextContentElement.h:
  8597. * svg/SVGTextElement.cpp:
  8598. (WebCore::SVGTextElement::isSupportedAttribute):
  8599. (WebCore::SVGTextElement::parseMappedAttribute):
  8600. (WebCore::SVGTextElement::svgAttributeChanged):
  8601. (WebCore::SVGTextElement::synchronizeProperty):
  8602. * svg/SVGTextElement.h:
  8603. * svg/SVGTextPathElement.cpp:
  8604. (WebCore::SVGTextPathElement::isSupportedAttribute):
  8605. (WebCore::SVGTextPathElement::parseMappedAttribute):
  8606. (WebCore::SVGTextPathElement::svgAttributeChanged):
  8607. (WebCore::SVGTextPathElement::synchronizeProperty):
  8608. * svg/SVGTextPathElement.h:
  8609. * svg/SVGTextPositioningElement.cpp:
  8610. (WebCore::SVGTextPositioningElement::isSupportedAttribute):
  8611. (WebCore::SVGTextPositioningElement::parseMappedAttribute):
  8612. (WebCore::SVGTextPositioningElement::svgAttributeChanged):
  8613. (WebCore::SVGTextPositioningElement::synchronizeProperty):
  8614. * svg/SVGTextPositioningElement.h:
  8615. * svg/SVGTransformable.cpp:
  8616. * svg/SVGTransformable.h:
  8617. * svg/SVGURIReference.cpp:
  8618. (WebCore::SVGURIReference::addSupportedAttributes):
  8619. * svg/SVGURIReference.h:
  8620. * svg/SVGUseElement.cpp:
  8621. (WebCore::SVGUseElement::isSupportedAttribute):
  8622. (WebCore::SVGUseElement::parseMappedAttribute):
  8623. (WebCore::SVGUseElement::svgAttributeChanged):
  8624. (WebCore::SVGUseElement::synchronizeProperty):
  8625. * svg/SVGUseElement.h:
  8626. * svg/SVGViewElement.cpp:
  8627. (WebCore::SVGViewElement::isSupportedAttribute):
  8628. (WebCore::SVGViewElement::parseMappedAttribute):
  8629. (WebCore::SVGViewElement::synchronizeProperty):
  8630. * svg/SVGViewElement.h:
  8631. * svg/SVGZoomAndPan.cpp:
  8632. (WebCore::SVGZoomAndPan::addSupportedAttributes):
  8633. * svg/SVGZoomAndPan.h:
  8634. 2011-05-20 Simon Fraser <simon.fraser@apple.com>
  8635. Reviewed by Dan Bernstein.
  8636. Allow ShadowBlur to do tiling when the context is scaled
  8637. https://bugs.webkit.org/show_bug.cgi?id=61232
  8638. If the GraphicsContext is scaled or rotated by a multiple of 90deg, have ShadowBlur
  8639. use the tiling code path, to avoid blurring large areas on pages like cracked.com
  8640. when the context is scaled.
  8641. * platform/graphics/ShadowBlur.cpp:
  8642. (WebCore::ShadowBlur::drawRectShadow): Call preservesAxisAlignment()
  8643. to decide when to not use tiling.
  8644. (WebCore::ShadowBlur::drawInsetShadow): Ditto.
  8645. (WebCore::ShadowBlur::drawLayerPieces): Round to device pixels when drawing tiles
  8646. to avoid pixel cracks in scaled contexts.
  8647. * platform/graphics/transforms/AffineTransform.h:
  8648. (WebCore::AffineTransform::preservesAxisAlignment): Return true if there is the matrix
  8649. contains a transform that results in axis alignment (no rotation or skew, or rotations
  8650. which are multiples of 90deg).
  8651. 2011-05-20 Alexey Proskuryakov <ap@apple.com>
  8652. Reviewed by Kent Tamura.
  8653. Special characters can be inserted in text field having reached maxlength
  8654. https://bugs.webkit.org/show_bug.cgi?id=19479
  8655. <rdar://problem/7828739>
  8656. Test: platform/mac/editing/input/maxlength.html
  8657. * editing/CompositeEditCommand.cpp:
  8658. (WebCore::CompositeEditCommand::insertTextIntoNode):
  8659. (WebCore::CompositeEditCommand::replaceTextInNode):
  8660. Avoid hitting an assertion below, now that we can get here with empty text.
  8661. * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): There is still work to do
  8662. even if beforetextinput removed all text from the event. At the very least, we should delete
  8663. the current selection.
  8664. 2011-05-20 Andy Estes <aestes@apple.com>
  8665. Reviewed by Darin Adler.
  8666. REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
  8667. https://bugs.webkit.org/show_bug.cgi?id=61229
  8668. Podcast Producer uses an object tag with a classid attribute to embed
  8669. QuickTime Player into a page. In r70748, we changed our behavior to
  8670. render the object's fallback content when a non-empty classid is
  8671. encountered, per HTML5. Since Podcast Producer videos have no fallback
  8672. content, this change in behavior causes the video to fail to load.
  8673. Since the object tag has a valid type attribute, we would be able to
  8674. load it if weren't for the non-empty classid. This patch changes our
  8675. policy to allow objects with non-empty classids if there is no fallback
  8676. content. We still continue to prefer fallback content if it exists,
  8677. however.
  8678. * html/HTMLObjectElement.cpp:
  8679. (WebCore::HTMLObjectElement::hasValidClassId): Treat a non-empty
  8680. classid as valid if the object has no fallback content.
  8681. 2011-05-20 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
  8682. Reviewed by Simon Fraser.
  8683. If both border-radius and box-shadow applied, shadow is not fully visible
  8684. https://bugs.webkit.org/show_bug.cgi?id=59577
  8685. The current implementation of RoundedIntRect::inflateWithRadii() inflates
  8686. its rect size and corner radii out of sync. This leads to validation failure in
  8687. Path::addRoundedRect() and results in ignoring radii in the path.
  8688. When this invalid path is used to clip out the rounded corner box before painting
  8689. the box shadow, the entire rectangle is clipped out without the corner radii.
  8690. This patch implements RoundedIntRect::inflateWithRadii() properly to inflate
  8691. rounded rect radii based on inflate ratios of rect size.
  8692. Test: fast/css/box-shadow-and-border-radius.html
  8693. * platform/graphics/RoundedIntRect.cpp:
  8694. (WebCore::RoundedIntRect::inflateWithRadii):
  8695. * platform/graphics/RoundedIntRect.h:
  8696. 2011-05-20 Michael Nordman <michaeln@google.com>
  8697. Reviewed by Darin Fisher.
  8698. [Chromium] Support the new webkit apis so the WebDatabase system participates
  8699. in the unified quota management system.
  8700. https://bugs.webkit.org/show_bug.cgi?id=60985
  8701. No change in functionality, no new tests.
  8702. * platform/chromium/PlatformBridge.h:
  8703. * storage/chromium/QuotaTracker.cpp:
  8704. (WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
  8705. (WebCore::QuotaTracker::updateDatabaseSize):
  8706. (WebCore::QuotaTracker::updateSpaceAvailableToOrigin):
  8707. (WebCore::QuotaTracker::resetSpaceAvailableToOrigin):
  8708. * storage/chromium/QuotaTracker.h:
  8709. 2011-05-20 Andy Estes <aestes@apple.com>
  8710. Reviewed by Darin Adler.
  8711. WebView loses firstResponder status when entering full-screen mode.
  8712. https://bugs.webkit.org/show_bug.cgi?id=61153
  8713. No test possible via DRT. Add a manual test instead.
  8714. * manual-tests/full-screen-keypress.html: Added.
  8715. 2011-05-20 Jeremy Noble <jer.noble@apple.com>
  8716. Reviewed by Maciej Stachowiak.
  8717. WebKit2: Exit full screen mode if the WebProcess crashes.
  8718. https://bugs.webkit.org/show_bug.cgi?id=61151
  8719. * platform/graphics/win/FullScreenController.h:
  8720. * platform/graphics/win/FullScreenController.cpp:
  8721. (FullScreenController::close): Added. Close the full-screen window without animation
  8722. if called.
  8723. 2011-05-20 Enrica Casucci <enrica@apple.com>
  8724. Reviewed by David Kilzer.
  8725. Add delegate methods about focus and blur to all elements.
  8726. https://bugs.webkit.org/show_bug.cgi?id=61218
  8727. We want to have delegates for these events for all the elements, not only the form elements.
  8728. The patch moves the call to the delegate in the Node class and changes the name
  8729. of the methods not to be form element specific.
  8730. * dom/Node.cpp:
  8731. (WebCore::Node::dispatchFocusEvent): Added call to delegate with the new name.
  8732. (WebCore::Node::dispatchBlurEvent): Added call to delegate with the new name.
  8733. * html/HTMLFormControlElement.cpp:
  8734. (WebCore::HTMLFormControlElement::dispatchBlurEvent): Removed code that calls the delegate since
  8735. it has been moved into Node.
  8736. * html/HTMLFormControlElement.h: Removed dispatchFocusEvent, since we are using the default inplementation in Node.
  8737. * loader/EmptyClients.h:
  8738. (WebCore::EmptyChromeClient::elementDidFocus): Name changed.
  8739. (WebCore::EmptyChromeClient::elementDidBlur): Name changed.
  8740. * page/ChromeClient.h:
  8741. (WebCore::ChromeClient::elementDidFocus): Name changed.
  8742. (WebCore::ChromeClient::elementDidBlur): Name changed.
  8743. 2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
  8744. Reviewed by Enrica Casucci.
  8745. Wrap copied contents by one style span instead of two
  8746. https://bugs.webkit.org/show_bug.cgi?id=60988
  8747. Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by one wrapping style span. Instead
  8748. of wrapping the copied contents by user-applied style and document default style in serialization,
  8749. take the difference with the document default's style in paste code.
  8750. This will dramatically simplify our copy and paste code and pave a way to fix the bug 60914.
  8751. No new tests because copy & paste is tested by existing layout tests.
  8752. * editing/EditingStyle.cpp:
  8753. (WebCore::EditingStyle::prepareToApplyAt): Remove the color property if RGBA values of color
  8754. matches that of the computed style at the specified position.
  8755. * editing/ReplaceSelectionCommand.cpp:
  8756. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Replaced sourceDocumentStyleSpan and
  8757. copiedRangeStyleSpan by wrappingStyleSpan. When pasting as a quotation, compare style against
  8758. the document's default style to avoid keeping the document default style (tested by
  8759. editing/pasteboard/4930986-3.html).
  8760. * editing/ReplaceSelectionCommand.h:
  8761. * editing/markup.cpp:
  8762. (WebCore::createMarkup): Only use one style span to wrap the serialized contents.
  8763. 2011-05-20 Simon Fraser <simon.fraser@apple.com>
  8764. Reviewed by Sam Weinig.
  8765. numberOfActiveAnimations() can include animations from documents in the page cache
  8766. https://bugs.webkit.org/show_bug.cgi?id=53641
  8767. Some transition tests using layoutTestController.numberOfActiveAnimations() failed
  8768. in WebKit2 because numberOfActiveAnimations() could include those from other documents
  8769. in the page cache.
  8770. Fix by passing in the document for which we wish to count animations.
  8771. * WebCore.exp.in:
  8772. * page/animation/AnimationController.cpp:
  8773. (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
  8774. (WebCore::AnimationController::numberOfActiveAnimations):
  8775. * page/animation/AnimationController.h:
  8776. * page/animation/AnimationControllerPrivate.h:
  8777. 2011-05-20 Adam Barth <abarth@webkit.org>
  8778. Reviewed by Alexey Proskuryakov.
  8779. Factor CORS request preparation out of DocumentThreadableLoader
  8780. https://bugs.webkit.org/show_bug.cgi?id=61209
  8781. DocumentThreadableLoader has two jobs:
  8782. 1) Proxy loads between threads.
  8783. 2) Run the CORS state machine.
  8784. This patch begins the work of separating those concerns, allowing CORS
  8785. to be used elsewhere in the loading pipeline. In particular, this
  8786. patch moves knowledge of how to prepare CORS requests out of
  8787. DocumentThreadableLoder.
  8788. * loader/CrossOriginAccessControl.cpp:
  8789. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
  8790. (WebCore::updateRequestForAccessControl):
  8791. (WebCore::createAccessControlPreflightRequest):
  8792. * loader/CrossOriginAccessControl.h:
  8793. * loader/DocumentThreadableLoader.cpp:
  8794. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
  8795. (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
  8796. (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
  8797. 2011-05-20 Rob Buis <rbuis@rim.com>
  8798. Reviewed by Dirk Schulze.
  8799. Use test from ietestcenter fails
  8800. https://bugs.webkit.org/show_bug.cgi?id=60844
  8801. When an id changes on an in-document element, we need to check whether the id
  8802. is part of the pending elements. Since this is the same thing as happens in
  8803. insertedIntoDocument, split out the common code into buildPendingResourcesIfNeeded.
  8804. Test: svg/W3C-SVG-1.1-SE/struct-use-14-f.svg
  8805. * svg/SVGStyledElement.cpp:
  8806. (WebCore::SVGStyledElement::svgAttributeChanged):
  8807. (WebCore::SVGStyledElement::insertedIntoDocument):
  8808. (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
  8809. * svg/SVGStyledElement.h:
  8810. 2011-05-20 Abhishek Arya <inferno@chromium.org>
  8811. Reviewed by Kent Tamura.
  8812. Make auto-focus a post attach callback in
  8813. HTMLFormControlElement::attach().
  8814. https://bugs.webkit.org/show_bug.cgi?id=32882
  8815. Original patch by Darin Adler. This one uses a part of it.
  8816. Test: fast/forms/input-element-attach-crash.html
  8817. * dom/Document.cpp:
  8818. (WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
  8819. already false by the time post-attach callbacks are done so that
  8820. layout triggered inside those callbacks can work properly.
  8821. * html/HTMLFormControlElement.cpp:
  8822. (WebCore::shouldAutofocus): Helper function that expresses
  8823. the rule for which form control elements should auto-focus.
  8824. (WebCore::focusPostAttach): Called post-attach to focus an
  8825. element if we discover it should be focused during attach.
  8826. (WebCore::HTMLFormControlElement::attach): Refactored code for
  8827. which elements need auto-focus into a separate function. Instead
  8828. of focusing right away, use the focusPostAttach function to focus
  8829. after attach is done. Also added calls to suspendPostAttachCallbacks
  8830. and resumePostAttachCallbacks so post-attach callbacks happen late
  8831. enough. Before, they could run inside the base attach function.
  8832. * html/HTMLInputElement.cpp:
  8833. (WebCore::HTMLInputElement::attach): Added calls to
  8834. suspendPostAttachCallbacks and resumePostAttachCallbacks so
  8835. post-attach callbacks happen late enough
  8836. 2011-05-20 Alok Priyadarshi <alokp@chromium.org>
  8837. Reviewed by James Robinson.
  8838. [chromium] Remove LayerRendererChromium::useShader
  8839. https://bugs.webkit.org/show_bug.cgi?id=61143
  8840. GPU compositor tests should be sufficient.
  8841. * platform/graphics/chromium/LayerRendererChromium.cpp:
  8842. (WebCore::LayerRendererChromium::LayerRendererChromium):
  8843. * platform/graphics/chromium/LayerRendererChromium.h:
  8844. * platform/graphics/chromium/LayerTilerChromium.cpp:
  8845. (WebCore::LayerTilerChromium::draw):
  8846. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  8847. (WebCore::RenderSurfaceChromium::drawSurface):
  8848. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  8849. (WebCore::CCCanvasLayerImpl::draw):
  8850. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  8851. (WebCore::CCHeadsUpDisplay::draw):
  8852. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  8853. (WebCore::CCLayerImpl::drawDebugBorder):
  8854. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
  8855. (WebCore::CCPluginLayerImpl::draw):
  8856. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
  8857. (WebCore::CCVideoLayerImpl::drawYUV):
  8858. (WebCore::CCVideoLayerImpl::drawRGBA):
  8859. 2011-05-20 Dirk Schulze <krit@webkit.org>
  8860. Reviewed by Darin Adler.
  8861. SVGPathSegList needs better getTotalLength, getSegmentAtLength path traversal code
  8862. https://bugs.webkit.org/show_bug.cgi?id=12047
  8863. Right now SVGPathElement::getTotalLength and SVGPathElement::getPointAtLength use toPathData()
  8864. to transform a SVGPathByteStream to a Path. This Path gets traversed to find the searched value.
  8865. With this patch both functions use the SVGPathByteStream directly together with the existing
  8866. traversing code in SVG. This avoids the intermediate transforming to a platform path and gives
  8867. platform independent results.
  8868. The traversal code in SVG needed to be extended to support all PathTraversalActions.
  8869. No new tests added. The existing tests cover the changes.
  8870. * svg/SVGPathElement.cpp:
  8871. (WebCore::SVGPathElement::getTotalLength):
  8872. (WebCore::SVGPathElement::getPointAtLength):
  8873. * svg/SVGPathParserFactory.cpp:
  8874. (WebCore::SVGPathParserFactory::getTotalLengthOfSVGPathByteStream):
  8875. (WebCore::SVGPathParserFactory::getPointAtLengthOfSVGPathByteStream):
  8876. * svg/SVGPathParserFactory.h:
  8877. * svg/SVGPathTraversalStateBuilder.cpp:
  8878. (WebCore::SVGPathTraversalStateBuilder::continueConsuming):
  8879. (WebCore::SVGPathTraversalStateBuilder::totalLength):
  8880. (WebCore::SVGPathTraversalStateBuilder::currentPoint):
  8881. * svg/SVGPathTraversalStateBuilder.h:
  8882. 2011-05-20 Mark Pilgrim <pilgrim@chromium.org>
  8883. Reviewed by Tony Chang.
  8884. IndexedDB createObjectStore should throw if name is null
  8885. https://bugs.webkit.org/show_bug.cgi?id=58465
  8886. Test: storage/indexeddb/mozilla/create-objectstore-null-name.html
  8887. * storage/IDBDatabase.idl:
  8888. * storage/IDBDatabaseBackendImpl.cpp:
  8889. (WebCore::IDBDatabaseBackendImpl::createObjectStore):
  8890. 2011-05-20 Xiaomei Ji <xji@chromium.org>
  8891. Reviewed by Ryosuke Niwa.
  8892. ctrl-arrow does not work on words separated by multiple spaces.
  8893. https://bugs.webkit.org/show_bug.cgi?id=57543.
  8894. Add the leftmost boundary of a box in RTL block or the rightmost boundary of a box in LTR
  8895. block as word break if its inlineBox is the current box and it is a word break.
  8896. * editing/visible_units.cpp:
  8897. (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Add the rightmost
  8898. boundary of a box in LTR block or leftmost boundary of a box in RTL block as visually
  8899. first word break.
  8900. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
  8901. (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
  8902. (WebCore::leftWordBoundary): Fix bug change "box" to "adjacentBox".
  8903. (WebCore::rightWordBoundary): Fix bug change "box" to "adjacentBox".
  8904. 2011-05-19 Evan Martin <evan@chromium.org>
  8905. Reviewed by Tony Chang.
  8906. [chromium] remove <(library) variable
  8907. https://bugs.webkit.org/show_bug.cgi?id=61158
  8908. This was for a build experiment; we can just use the correct value now.
  8909. * WebCore.gyp/WebCore.gyp:
  8910. 2011-05-20 Pavel Podivilov <podivilov@chromium.org>
  8911. Reviewed by Pavel Feldman.
  8912. Web Inspector: breakpoints disappear from ui after navigation.
  8913. https://bugs.webkit.org/show_bug.cgi?id=61133
  8914. * inspector/front-end/DebuggerPresentationModel.js:
  8915. (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
  8916. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  8917. 2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>
  8918. Unreviewed, rolling out r86958.
  8919. http://trac.webkit.org/changeset/86958
  8920. https://bugs.webkit.org/show_bug.cgi?id=61195
  8921. broke breakpoints persisting (Requested by podivilov on
  8922. #webkit).
  8923. * inspector/front-end/DebuggerPresentationModel.js:
  8924. (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
  8925. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  8926. 2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>
  8927. Reviewed by Yury Semikhatsky.
  8928. Web Inspector: Background network events collection - add GUI to Inspector.
  8929. https://bugs.webkit.org/show_bug.cgi?id=58652
  8930. Now in WebInspector Network panel avalaible new checkbox item in context menu:
  8931. "Background events collection". It allows to save all network events when inspector
  8932. frontend closed. Events that occur before collection enabling are not preserved after
  8933. frontend reopening. Property unique for each page. Disabled by default.
  8934. Tests: http/tests/inspector/network/network-clear-after-disabled.html
  8935. http/tests/inspector/network/network-close-load-open.html
  8936. http/tests/inspector/network/network-open-load-reopen.html
  8937. * inspector/EventsCollector.cpp:
  8938. (WebCore::EventsCollector::clear):
  8939. * inspector/EventsCollector.h:
  8940. * inspector/Inspector.json:
  8941. * inspector/InspectorFrontendProxy.cpp:
  8942. (WebCore::InspectorFrontendProxy::inspectorFrontendChannel):
  8943. * inspector/InspectorFrontendProxy.h:
  8944. * inspector/InspectorResourceAgent.cpp:
  8945. (WebCore::InspectorResourceAgent::setFrontend):
  8946. (WebCore::InspectorResourceAgent::clearFrontend):
  8947. (WebCore::InspectorResourceAgent::isBackgroundEventsCollectionEnabled):
  8948. (WebCore::InspectorResourceAgent::setBackgroundEventsCollectionEnabled):
  8949. (WebCore::InspectorResourceAgent::initializeBackgroundCollection):
  8950. (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  8951. * inspector/InspectorResourceAgent.h:
  8952. * inspector/front-end/NetworkPanel.js:
  8953. (WebInspector.NetworkPanel):
  8954. (WebInspector.NetworkPanel.prototype._contextMenu):
  8955. (WebInspector.NetworkPanel.prototype._toggleBackgroundEventsCollection):
  8956. 2011-05-20 Pavel Podivilov <podivilov@chromium.org>
  8957. Reviewed by Pavel Feldman.
  8958. Web Inspector: breakpoints disappear from ui after navigation.
  8959. https://bugs.webkit.org/show_bug.cgi?id=61133
  8960. * inspector/front-end/DebuggerPresentationModel.js:
  8961. (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
  8962. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  8963. 2011-05-20 Jer Noble <jer.noble@apple.com>
  8964. Reviewed by Maciej Stachowiak.
  8965. Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
  8966. https://bugs.webkit.org/show_bug.cgi?id=61108
  8967. Instead of repainting the full- and non-full-screen windows in WebCore, delegate that
  8968. responsibility to the FullScreenControllerClient. Because the repaint operation may
  8969. be asynchronous, add a new method for clients to use to indicate repainting has completed.
  8970. * platform/graphics/win/FullScreenController.cpp:
  8971. (FullScreenController::Private::Private): Added new ivars.
  8972. (FullScreenController::enterFullScreen): Split into two functions (pre-and post repaint)
  8973. (FullScreenController::enterFullScreenRepaintCompleted): Ditto.
  8974. (FullScreenController::exitFullScreen): Ditto.
  8975. (FullScreenController::exitFullScreenRepaintCompleted): Ditto.
  8976. (FullScreenController::repaintCompleted): Call the appropriated repaint completed function.
  8977. * platform/graphics/win/FullScreenController.h:
  8978. * platform/graphics/win/FullScreenControllerClient.h:
  8979. 2011-05-20 Yury Semikhatsky <yurys@chromium.org>
  8980. Reviewed by Pavel Feldman.
  8981. Web Inspector: use RefPtr instead of OwnPtr to store InspectorBackendDispatcher
  8982. https://bugs.webkit.org/show_bug.cgi?id=61188
  8983. * inspector/WorkerInspectorController.cpp:
  8984. (WebCore::WorkerInspectorController::connectFrontend):
  8985. (WebCore::WorkerInspectorController::disconnectFrontend):
  8986. * inspector/WorkerInspectorController.h:
  8987. 2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>
  8988. Reviewed by Pavel Feldman.
  8989. Web Inspector: Network panel should only show pointer cursor over valid resources
  8990. https://bugs.webkit.org/show_bug.cgi?id=55240
  8991. Cursor style removed from filler area.
  8992. * inspector/front-end/networkPanel.css:
  8993. (.network-sidebar .data-grid tr:not(.filler) td.name-column):
  8994. 2011-05-20 Peter Varga <pvarga@webkit.org>
  8995. Reviewed by Simon Hausmann.
  8996. [Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
  8997. https://bugs.webkit.org/show_bug.cgi?id=56649
  8998. Use the provided V8 and functionality of
  8999. http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
  9000. Based on the original patch of Andras Becsi <abecsi@webkit.org>.
  9001. No new tests needed.
  9002. * CodeGenerators.pri: Add generating of DebuggerScriptSource.h
  9003. * WebCore.pri: Fix the options for V8 build.
  9004. * WebCore.pro: Ditto.
  9005. * bindings/v8/NPV8Object.cpp:
  9006. (WebCore::npObjectTypeInfo): Add missing initializer.
  9007. * bindings/v8/ScriptController.cpp:
  9008. (WebCore::ScriptController::disableEval): Temporarily disable
  9009. unsupported feature on Qt.
  9010. * bindings/v8/ScriptControllerQt.cpp:
  9011. (WebCore::ScriptController::qtScriptEngine): use the QtScriptEngine
  9012. constructor of qtscript-staging.
  9013. * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Add missing
  9014. initializer.
  9015. * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.
  9016. * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.
  9017. * loader/appcache/ApplicationCacheGroup.cpp: Add missing header.
  9018. * loader/cache/CachedResourceRequest.cpp: Ditto.
  9019. * page/PageSerializer.cpp: Ditto.
  9020. * page/qt/FrameQt.cpp: Ditto.
  9021. * storage/StorageEventDispatcher.cpp: Ditto.
  9022. 2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>
  9023. Reviewed by Pavel Feldman.
  9024. Web Inspector: console.log(XMLDocument) should be case preserving
  9025. https://bugs.webkit.org/show_bug.cgi?id=60765
  9026. Changes the XML document checking from base documents MIME type
  9027. to xmlVersion parameter.
  9028. * inspector/InspectorDOMAgent.cpp:
  9029. (WebCore::InspectorDOMAgent::buildObjectForNode):
  9030. * inspector/front-end/DOMAgent.js:
  9031. (WebInspector.DOMNode):
  9032. * inspector/front-end/ElementsTreeOutline.js:
  9033. (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
  9034. 2011-05-20 Mikhail Naganov <mnaganov@chromium.org>
  9035. Reviewed by Yury Semikhatsky.
  9036. Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM,
  9037. instead of building it on Inspector's side.
  9038. https://bugs.webkit.org/show_bug.cgi?id=61185
  9039. * bindings/js/ScriptProfile.cpp:
  9040. (WebCore::ScriptProfile::bottomUpHead):
  9041. (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  9042. * bindings/js/ScriptProfile.h:
  9043. * bindings/v8/ScriptProfile.cpp:
  9044. (WebCore::ScriptProfile::bottomUpHead):
  9045. (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  9046. * bindings/v8/ScriptProfile.h:
  9047. * inspector/InspectorProfilerAgent.cpp:
  9048. (WebCore::InspectorProfilerAgent::getProfile):
  9049. * inspector/front-end/ProfileView.js:
  9050. (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
  9051. 2011-05-20 Adam Roben <aroben@apple.com>
  9052. Mac build fix after r86936
  9053. * WebCore.xcodeproj/project.pbxproj: Added preprocessor.pm like the
  9054. other .pm files.
  9055. 2011-05-20 Kent Tamura <tkent@chromium.org>
  9056. Try to fix Windows CE build.
  9057. Touch html.css to kick UA style sheet generation.
  9058. * css/html.css:
  9059. 2011-05-20 Kent Tamura <tkent@chromium.org>
  9060. Try to fix Windows CE build.
  9061. * CMakeLists.txt: Add --preprocessor flag.
  9062. 2011-05-20 Kent Tamura <tkent@chromium.org>
  9063. Reviewed by Hajime Morita.
  9064. Apply feature flags to user-agent style sheets
  9065. https://bugs.webkit.org/show_bug.cgi?id=52612
  9066. A user-agent style sheet should not have style definitions for disabled
  9067. features because such definitions makes feature detection harder and
  9068. causes incorrect behavior (See Bug 52214).
  9069. We have handled such feature-dependent style definitions by providing
  9070. separated CSS files and selecting them in build files. Adding such style
  9071. definition was hard because we need to update each of build files. This
  9072. change simplifies the process to add such style definitions by applying
  9073. preprocessor to the CSS files.
  9074. Implementation:
  9075. make-css-file-arrays.pl invokes a preprocessor if it has --defines
  9076. option. Otherwise, it just remove lines beginning with #.
  9077. In this change, we pass --defines on Mac, Windows, Chromium, GTK, and
  9078. CMake platforms. Qt and Android have no behavior change.
  9079. * CMakeLists.txt:
  9080. - IDL handling depends on preprocessor.pm.
  9081. - Pass --defines option to make-css-file-arrays.pl
  9082. - Add WebCore/bindings/scripts to @INC for make-css-file-arrays.pl
  9083. * CodeGenerators.pri: IDL handling depends on preprocessor.pm.
  9084. * DerivedSources.make: ditto.
  9085. * GNUmakefile.am: ditto.
  9086. * WebCore.gyp/WebCore.gyp: ditto.
  9087. * WebCore.gyp/scripts/action_useragentstylesheets.py:
  9088. Change parameter order to support perl modules and options.
  9089. Many code is taken from rule_bindings.py.
  9090. * WebCore.vcproj/MigrateScripts: Handles preprocessor.pm.
  9091. * bindings/scripts/IDLParser.pm:
  9092. Move the preprocessor code to preprocessor.pm.
  9093. * bindings/scripts/preprocessor.pm:
  9094. Added. The code was moved from IDLParser.pm
  9095. * css/html.css: Enclose some style definitions with #if-#endif.
  9096. * css/make-css-file-arrays.pl:
  9097. - Add --defines and --preprocessor options.
  9098. - Invoke a preprocessor if --defines is specified.
  9099. 2011-05-20 Dirk Schulze <krit@webkit.org>
  9100. Rubber-stamped by Nikolas Zimmermann.
  9101. Remove unnecessary class Path inlcude from PathTraversalState.
  9102. * platform/graphics/PathTraversalState.h:
  9103. 2011-05-19 Pavel Podivilov <podivilov@chromium.org>
  9104. Reviewed by Pavel Feldman.
  9105. Web Inspector: ctrl+s should not switch source frame to read only mode.
  9106. https://bugs.webkit.org/show_bug.cgi?id=61125
  9107. * inspector/front-end/SourceFrame.js:
  9108. (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
  9109. (WebInspector.SourceFrame.prototype.commitEditing):
  9110. * inspector/front-end/inspector.js:
  9111. (WebInspector.documentKeyDown):
  9112. 2011-05-20 Piroska András <Piroska.Andras@stud.u-szeged.hu>
  9113. Reviewed by Nikolas Zimmermann.
  9114. Apply the ParallelJobs support to FEConvolveMatrix
  9115. https://bugs.webkit.org/show_bug.cgi?id=61171
  9116. The FEConvolveMatrix filter of SVG can consume lots of resources if it is
  9117. applied to a large area. The computation can be distributed to multiple
  9118. cores if the architecture supports.
  9119. The average performance progression is 20-30% on dual-core machines.
  9120. Developed in cooperation with Gabor Loki.
  9121. * platform/graphics/filters/FEConvolveMatrix.cpp:
  9122. (WebCore::FEConvolveMatrix::fastSetInteriorPixels):
  9123. (WebCore::FEConvolveMatrix::setInteriorPixels):
  9124. (WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
  9125. (WebCore::FEConvolveMatrix::apply):
  9126. * platform/graphics/filters/FEConvolveMatrix.h:
  9127. 2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>
  9128. Unreviewed, rolling out r86920.
  9129. http://trac.webkit.org/changeset/86920
  9130. https://bugs.webkit.org/show_bug.cgi?id=61173
  9131. It cause compile error on some buildbot in chromium. e.g.
  9132. http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
  9133. (Requested by ukai_ on #webkit).
  9134. * WebCore.xcodeproj/project.pbxproj:
  9135. * css/CSSComputedStyleDeclaration.cpp:
  9136. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  9137. * css/CSSParser.cpp:
  9138. (WebCore::CSSParser::parseValue):
  9139. * css/CSSPrimitiveValueMappings.h:
  9140. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  9141. (WebCore::CSSPrimitiveValue::operator EImageRendering):
  9142. * css/CSSPropertyNames.in:
  9143. * css/CSSStyleSelector.cpp:
  9144. (WebCore::CSSStyleSelector::applyProperty):
  9145. * css/CSSValueKeywords.in:
  9146. * css/SVGCSSComputedStyleDeclaration.cpp:
  9147. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  9148. * css/SVGCSSPropertyNames.in:
  9149. * css/SVGCSSStyleSelector.cpp:
  9150. (WebCore::CSSStyleSelector::applySVGProperty):
  9151. * css/SVGCSSValueKeywords.in:
  9152. * html/HTMLCanvasElement.cpp:
  9153. (WebCore::HTMLCanvasElement::paint):
  9154. * html/HTMLCanvasElement.h:
  9155. * platform/graphics/ImageRenderingMode.h: Removed.
  9156. * rendering/RenderBoxModelObject.cpp:
  9157. (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  9158. * rendering/RenderHTMLCanvas.cpp:
  9159. (WebCore::RenderHTMLCanvas::paintReplaced):
  9160. * rendering/style/RenderStyle.cpp:
  9161. (WebCore::RenderStyle::diff):
  9162. * rendering/style/RenderStyle.h:
  9163. * rendering/style/RenderStyleConstants.h:
  9164. * rendering/style/SVGRenderStyle.cpp:
  9165. (WebCore::SVGRenderStyle::diff):
  9166. * rendering/style/SVGRenderStyle.h:
  9167. (WebCore::SVGRenderStyle::initialImageRendering):
  9168. (WebCore::SVGRenderStyle::setImageRendering):
  9169. (WebCore::SVGRenderStyle::imageRendering):
  9170. (WebCore::SVGRenderStyle::InheritedFlags::operator==):
  9171. (WebCore::SVGRenderStyle::setBitDefaults):
  9172. * rendering/style/SVGRenderStyleDefs.h:
  9173. * rendering/style/StyleRareInheritedData.cpp:
  9174. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  9175. (WebCore::StyleRareInheritedData::operator==):
  9176. * rendering/style/StyleRareInheritedData.h:
  9177. * rendering/svg/SVGRenderTreeAsText.cpp:
  9178. (WebCore::writeStyle):
  9179. 2011-05-20 Dirk Schulze <krit@webkit.org>
  9180. Reviewed by Eric Seidel.
  9181. SVG Large curve path segment OOM crash
  9182. https://bugs.webkit.org/show_bug.cgi?id=42079
  9183. Limit the depth of repeatedly splitting a segment on length calculation to 20. The limitation
  9184. is necessary for very big segments that would be splitter into millions of parts otherwise.
  9185. The limitation just cause a less accurate approximation.
  9186. At the moment the limit is fixed to 20. This is comparable with splitting the segment into
  9187. ~1 million parts as a worst case. We might want to be more flexible later.
  9188. Test: svg/custom/path-getTotalLength-on-big-segment-crash.svg
  9189. * platform/graphics/PathTraversalState.cpp:
  9190. (WebCore::midPoint):
  9191. (WebCore::curveLength):
  9192. (WebCore::PathTraversalState::PathTraversalState):
  9193. (WebCore::PathTraversalState::moveTo):
  9194. (WebCore::PathTraversalState::quadraticBezierTo):
  9195. (WebCore::PathTraversalState::cubicBezierTo):
  9196. * platform/graphics/PathTraversalState.h:
  9197. 2011-05-20 Leo Yang <leo.yang@torchmobile.com.cn>
  9198. Reviewed by Nikolas Zimmermann.
  9199. SVGRootInlineBox triggers calculateBoundaries twice in layout
  9200. https://bugs.webkit.org/show_bug.cgi?id=60979
  9201. SVGRootInlineBox was calculating boundaries for children twice
  9202. in computePerCharacterLayoutInformation(). The first time of
  9203. calculation was in layoutChildBoxes() which is called by
  9204. computePerCharacterLayoutInformation(), and the second time of
  9205. calculation was in layoutRootBox() following layoutChildBoxes().
  9206. This patch calculates rectangle of children in layoutChildBoxes()
  9207. and then uses the rectange in layoutRootBox() to reduce a pass
  9208. of calculating child boundaries.
  9209. No functionality change, no new tests.
  9210. * rendering/svg/SVGRootInlineBox.cpp:
  9211. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
  9212. (WebCore::SVGRootInlineBox::layoutChildBoxes):
  9213. (WebCore::SVGRootInlineBox::layoutRootBox):
  9214. * rendering/svg/SVGRootInlineBox.h:
  9215. 2011-05-19 Naoki Takano <takano.naoki@gmail.com>
  9216. Reviewed by Kent Tamura.
  9217. Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
  9218. https://bugs.webkit.org/show_bug.cgi?id=61163
  9219. Manual test input-number-localization.html.
  9220. Because we can't assume any number formats in various WebKit ports.
  9221. * html/HTMLInputElement.cpp:
  9222. (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
  9223. * manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.
  9224. 2011-05-19 Jer Noble <jer.noble@apple.com>
  9225. Reviewed by Maciej Stachowiak.
  9226. WebKit2: Flashing when entering and exiting full screen mode
  9227. https://bugs.webkit.org/show_bug.cgi?id=56957
  9228. Guard against the parameter of setAnimating() matching the ivar value it's
  9229. setting, thus avoiding tearing down the renderer's layer backing.
  9230. * rendering/RenderFullScreen.cpp:
  9231. (RenderFullScreen::setAnimating):
  9232. 2011-05-19 Julien Chaffraix <jchaffraix@codeaurora.org>
  9233. Reviewed by Adam Barth.
  9234. Remove Node::deprecatedParserAddChild
  9235. https://bugs.webkit.org/show_bug.cgi?id=60818
  9236. Refactoring only so no new tests.
  9237. This patch fails short of one instance of deprecatedParserAddChild which will
  9238. require a refactoring of <input> shadow DOM to be removed.
  9239. * dom/XMLDocumentParser.cpp:
  9240. (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode.
  9241. (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear
  9242. up m_leafTextNode too.
  9243. (WebCore::XMLDocumentParser::enterText):
  9244. (WebCore::XMLDocumentParser::exitText):
  9245. Those methods were updated to use m_leafTextNode instead of m_currentNode.
  9246. * dom/XMLDocumentParser.h:
  9247. Changed the currentNode logic to use ContainerNode. Also fixed the style of the
  9248. forward declarations.
  9249. * dom/XMLDocumentParserLibxml2.cpp:
  9250. (WebCore::XMLDocumentParser::startElementNs):
  9251. (WebCore::XMLDocumentParser::endElementNs):
  9252. (WebCore::XMLDocumentParser::characters):
  9253. (WebCore::XMLDocumentParser::processingInstruction):
  9254. (WebCore::XMLDocumentParser::cdataBlock):
  9255. (WebCore::XMLDocumentParser::comment):
  9256. * dom/XMLDocumentParserQt.cpp:
  9257. (WebCore::XMLDocumentParser::parse):
  9258. (WebCore::XMLDocumentParser::parseStartElement):
  9259. (WebCore::XMLDocumentParser::parseEndElement):
  9260. (WebCore::XMLDocumentParser::parseCharacters):
  9261. (WebCore::XMLDocumentParser::parseProcessingInstruction):
  9262. (WebCore::XMLDocumentParser::parseCdata):
  9263. (WebCore::XMLDocumentParser::parseComment):
  9264. Removed the calls to deprecatedParserAddChild, changed the code to use
  9265. m_leafTextNode when it made sense and used ContainerNode instead of
  9266. Node for m_currentNode.
  9267. 2011-05-19 Mike Lawther <mikelawther@chromium.org>
  9268. Reviewed by Simon Fraser.
  9269. implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
  9270. https://bugs.webkit.org/show_bug.cgi?id=56627
  9271. Tests: css3/images/optimize-contrast-canvas.html
  9272. css3/images/optimize-contrast-image.html
  9273. * WebCore.xcodeproj/project.pbxproj:
  9274. * css/CSSComputedStyleDeclaration.cpp:
  9275. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  9276. * css/CSSParser.cpp:
  9277. (WebCore::CSSParser::parseValue):
  9278. * css/CSSPrimitiveValueMappings.h:
  9279. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  9280. (WebCore::CSSPrimitiveValue::operator EImageRendering):
  9281. * css/CSSPropertyNames.in:
  9282. * css/CSSStyleSelector.cpp:
  9283. (WebCore::CSSStyleSelector::applyProperty):
  9284. * css/CSSValueKeywords.in:
  9285. * css/SVGCSSComputedStyleDeclaration.cpp:
  9286. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  9287. * css/SVGCSSPropertyNames.in:
  9288. * css/SVGCSSStyleSelector.cpp:
  9289. (WebCore::CSSStyleSelector::applySVGProperty):
  9290. * css/SVGCSSValueKeywords.in:
  9291. * html/HTMLCanvasElement.cpp:
  9292. (WebCore::HTMLCanvasElement::paint):
  9293. * html/HTMLCanvasElement.h:
  9294. * platform/graphics/ImageRenderingMode.h: Added.
  9295. * rendering/RenderBoxModelObject.cpp:
  9296. (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  9297. * rendering/RenderHTMLCanvas.cpp:
  9298. (WebCore::RenderHTMLCanvas::paintReplaced):
  9299. * rendering/style/RenderStyle.cpp:
  9300. (WebCore::RenderStyle::diff):
  9301. * rendering/style/RenderStyle.h:
  9302. (WebCore::InheritedFlags::imageRendering):
  9303. (WebCore::InheritedFlags::setImageRendering):
  9304. (WebCore::InheritedFlags::initialImageRendering):
  9305. * rendering/style/RenderStyleConstants.h:
  9306. * rendering/style/SVGRenderStyle.cpp:
  9307. (WebCore::SVGRenderStyle::diff):
  9308. * rendering/style/SVGRenderStyle.h:
  9309. (WebCore::SVGRenderStyle::InheritedFlags::operator==):
  9310. (WebCore::SVGRenderStyle::setBitDefaults):
  9311. * rendering/style/SVGRenderStyleDefs.h:
  9312. * rendering/svg/SVGRenderTreeAsText.cpp:
  9313. (WebCore::writeStyle):
  9314. 2011-05-18 Kenneth Russell <kbr@google.com>
  9315. Reviewed by James Robinson.
  9316. [chromium] Disable blending in compositor for WebGL layers with alpha=false
  9317. https://bugs.webkit.org/show_bug.cgi?id=61091
  9318. Test: compositing/webgl/webgl-no-alpha.html
  9319. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  9320. (WebCore::CanvasLayerChromium::CanvasLayerChromium):
  9321. (WebCore::CanvasLayerChromium::pushPropertiesTo):
  9322. * platform/graphics/chromium/CanvasLayerChromium.h:
  9323. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  9324. (WebCore::WebGLLayerChromium::setContext):
  9325. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  9326. (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  9327. (WebCore::CCCanvasLayerImpl::draw):
  9328. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  9329. (WebCore::CCCanvasLayerImpl::setHasAlpha):
  9330. 2011-05-18 Jeremy Noble <jer.noble@apple.com>
  9331. Reviewed by Darin Adler.
  9332. Poster is not shown in Safari for video element with no playable source elements.
  9333. https://bugs.webkit.org/show_bug.cgi?id=61109
  9334. Test: media/video-src-invalid-poster.html
  9335. In the case where no video sources are playable, update the display state and
  9336. renderer, allowing the poster image to display.
  9337. * html/HTMLMediaElement.cpp:
  9338. (WebCore::HTMLMediaElement::waitForSourceChange):
  9339. 2011-05-19 Andrew Wilson <atwilson@chromium.org>
  9340. Reviewed by Darin Adler.
  9341. MessagePortArray cloning code needs to verify source before copying.
  9342. https://bugs.webkit.org/show_bug.cgi?id=61130
  9343. * bindings/js/JSMessagePortCustom.cpp:
  9344. (WebCore::fillMessagePortArray):
  9345. Changed code to not pre-allocate the destination array.
  9346. * bindings/v8/custom/V8MessagePortCustom.cpp:
  9347. (WebCore::getMessagePortArray):
  9348. Changed code to not pre-allocate the destination array.
  9349. 2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
  9350. Unreviewed, rolling out r86869, r86873, r86875, and r86877.
  9351. http://trac.webkit.org/changeset/86869
  9352. http://trac.webkit.org/changeset/86873
  9353. http://trac.webkit.org/changeset/86875
  9354. http://trac.webkit.org/changeset/86877
  9355. https://bugs.webkit.org/show_bug.cgi?id=61139
  9356. broke builds and debug DRT (Requested by rniwa on #webkit).
  9357. * DerivedSources.make:
  9358. * WebCore.exp.in:
  9359. * WebCore.gyp/WebCore.gyp:
  9360. * WebCore.gypi:
  9361. * WebCore.xcodeproj/project.pbxproj:
  9362. * testing/Internals.cpp: Removed.
  9363. * testing/Internals.h: Removed.
  9364. * testing/Internals.idl: Removed.
  9365. * testing/js/WebCoreTestSupport.cpp: Removed.
  9366. * testing/js/WebCoreTestSupport.h: Removed.
  9367. * testing/v8/WebCoreTestSupport.cpp: Removed.
  9368. * testing/v8/WebCoreTestSupport.h: Removed.
  9369. 2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
  9370. One more fix after r86869.
  9371. * WebCore.exp.in: Made __ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.
  9372. 2011-05-19 Anders Carlsson <andersca@apple.com>
  9373. Add two more symbols needed by the window.internals library.
  9374. * WebCore.exp.in:
  9375. 2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
  9376. Fix Leopard build after r86869.
  9377. * WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.
  9378. 2011-05-19 Robert Hogan <robert@webkit.org>
  9379. Reviewed by Andreas Kling.
  9380. [Qt] Fix plugins/windowless_plugin_paint_test.html
  9381. https://bugs.webkit.org/show_bug.cgi?id=60992
  9382. Call gdk_init_check before gdk_display_get_default().
  9383. If we don't do this, gdk_display_get_default() will hang
  9384. the next time it's called.
  9385. * plugins/qt/PluginViewQt.cpp:
  9386. (WebCore::getPluginDisplay):
  9387. 2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
  9388. Reviewed by Darin Adler.
  9389. Add build logistics and plumbing for window.internals object.
  9390. https://bugs.webkit.org/show_bug.cgi?id=60313
  9391. Test: fast/harness/internals-object.html
  9392. * DerivedSources.make: Added support for generating from Internals.idl.
  9393. * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  9394. * WebCore.gypi: Ditto.
  9395. * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  9396. * testing/Internals.cpp: Added.
  9397. * testing/Internals.h: Added.
  9398. * testing/Internals.idl: Added.
  9399. * testing/js/WebCoreTestSupport.cpp: Added.
  9400. * testing/js/WebCoreTestSupport.h: Added.
  9401. * testing/v8/WebCoreTestSupport.cpp: Added.
  9402. * testing/v8/WebCoreTestSupport.h: Added.
  9403. 2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
  9404. Accept XCode's decisions to keep modifying WebCore.xcodeproj.
  9405. * WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.
  9406. 2011-05-19 Andrew Wason <rectalogic@rectalogic.com>
  9407. Reviewed by Darin Adler.
  9408. Fix GraphicsContext3DQt.cpp compile error
  9409. https://bugs.webkit.org/show_bug.cgi?id=61128
  9410. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  9411. (WebCore::GraphicsContext3D::GraphicsContext3D):
  9412. clear() m_internal OwnPtr.
  9413. 2011-05-19 Tonis Tiigi <tonistiigi@gmail.com>
  9414. Reviewed by Pavel Feldman.
  9415. Web Inspector: Resizing columns in the network panel is weird
  9416. https://bugs.webkit.org/show_bug.cgi?id=55238
  9417. Makes network panel column resizing more usable by adding "first only" and "last only"
  9418. resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
  9419. remains default. Network panels datagrid is set to use method "last".
  9420. * inspector/front-end/DataGrid.js:
  9421. (WebInspector.DataGrid.prototype.get resizeMethod):
  9422. (WebInspector.DataGrid.prototype.set resizeMethod):
  9423. (WebInspector.DataGrid.prototype._resizerDragging):
  9424. * inspector/front-end/NetworkPanel.js:
  9425. (WebInspector.NetworkPanel.prototype._createTable):
  9426. 2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
  9427. Reviewed by Darin Adler.
  9428. JoinTextNodesCommand is never used
  9429. https://bugs.webkit.org/show_bug.cgi?id=61089
  9430. Deleted JoinTextNodesCommand because it's never used.
  9431. * CMakeLists.txt:
  9432. * GNUmakefile.list.am:
  9433. * WebCore.gypi:
  9434. * WebCore.pro:
  9435. * WebCore.vcproj/WebCore.vcproj:
  9436. * WebCore.xcodeproj/project.pbxproj:
  9437. * editing/CompositeEditCommand.cpp:
  9438. * editing/CompositeEditCommand.h:
  9439. * editing/EditingAllInOne.cpp:
  9440. * editing/JoinTextNodesCommand.cpp: Removed.
  9441. * editing/JoinTextNodesCommand.h: Removed.
  9442. 2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
  9443. Reviewed by Darin Adler.
  9444. REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
  9445. https://bugs.webkit.org/show_bug.cgi?id=61012
  9446. The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
  9447. being moved when the insertion position's container node is the node to split to. Fixed the crash
  9448. by not changing the insertion position in such a case.
  9449. Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
  9450. it's much better than crashing.
  9451. Test: editing/pasteboard/paste-after-inline-style-element.html
  9452. * editing/ReplaceSelectionCommand.cpp:
  9453. (WebCore::ReplaceSelectionCommand::doApply):
  9454. 2011-05-19 Brady Eidson <beidson@apple.com>
  9455. Try to fix SUPPORT_AUTOCORRECTION_PANEL build.
  9456. * editing/SpellingCorrectionController.cpp:
  9457. (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  9458. (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  9459. 2011-05-19 Darin Adler <darin@apple.com>
  9460. Try to fix SUPPORT_AUTOCORRECTION_PANEL build.
  9461. * editing/SpellingCorrectionController.cpp:
  9462. (WebCore::markersHaveIdenticalDescription): Call description() function.
  9463. 2011-05-19 Andrey Adaikin <aandrey@google.com>
  9464. Reviewed by Pavel Feldman.
  9465. Web Inspector: switch to Scripts panel is too slow
  9466. https://bugs.webkit.org/show_bug.cgi?id=61030
  9467. - It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal
  9468. DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
  9469. - Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.
  9470. * inspector/front-end/SourceFrame.js:
  9471. (WebInspector.SourceFrame.prototype.show):
  9472. * inspector/front-end/TextViewer.js:
  9473. (WebInspector.TextEditorMainPanel):
  9474. (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
  9475. (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
  9476. (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener):
  9477. (WebInspector.TextEditorMainChunk):
  9478. (WebInspector.TextEditorMainChunk.prototype.set expanded):
  9479. (WebInspector.TextEditorMainChunk.prototype._createRow):
  9480. 2011-05-19 Pavel Feldman <pfeldman@google.com>
  9481. Not reviewed: inspector protocol tests fixed.
  9482. * inspector/InjectedScriptSource.js:
  9483. 2011-05-19 David Grogan <dgrogan@chromium.org>
  9484. Reviewed by David Levin.
  9485. Make EventQueue post a Task to the task queue for each asynchronous event
  9486. https://bugs.webkit.org/show_bug.cgi?id=60790
  9487. Currently EventQueue queues up events to be fired asynchronously and
  9488. fires each of them when a single DOMTimer goes off. In the words of
  9489. dimich, "Having 2 queues will sooner or later cause problems with
  9490. ordering of tasks, termination, suspension and other things that all
  9491. require some control on how queues operate."
  9492. No new tests; this is just a refactoring to avoid potential future
  9493. problems.
  9494. * dom/EventQueue.cpp:
  9495. (WebCore::EventQueue::EventQueue):
  9496. (WebCore::EventQueue::EventDispatcherTask::create):
  9497. (WebCore::EventQueue::EventDispatcherTask::dispatchEvent):
  9498. (WebCore::EventQueue::EventDispatcherTask::performTask):
  9499. (WebCore::EventQueue::EventDispatcherTask::cancel):
  9500. (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask):
  9501. (WebCore::EventQueue::removeEvent):
  9502. (WebCore::EventQueue::enqueueEvent):
  9503. (WebCore::EventQueue::enqueueOrDispatchScrollEvent):
  9504. (WebCore::EventQueue::cancelEvent):
  9505. (WebCore::EventQueue::cancelQueuedEvents):
  9506. * dom/EventQueue.h:
  9507. 2011-05-18 Yury Semikhatsky <yurys@chromium.org>
  9508. Reviewed by Pavel Feldman.
  9509. InjectedScriptSource.js - "Don't be eval()."
  9510. https://bugs.webkit.org/show_bug.cgi?id=60800
  9511. Thanks to Adam Barth for providing JSC implementation!
  9512. InjectedScriptHost.evaluate is used to perform script evaluations for
  9513. inspector needs. This method is not affected by CSP and should fix inspector
  9514. on pages with CSP restrictions.
  9515. Test: inspector/console/console-eval-blocked.html
  9516. * bindings/js/JSInjectedScriptHostCustom.cpp:
  9517. (WebCore::JSInjectedScriptHost::evaluate):
  9518. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  9519. (WebCore::V8InjectedScriptHost::evaluateCallback):
  9520. (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  9521. * inspector/InjectedScriptHost.idl:
  9522. * inspector/InjectedScriptSource.js:
  9523. (.):
  9524. 2011-05-19 Pavel Feldman <pfeldman@google.com>
  9525. Reviewed by Yury Semikhatsky.
  9526. Web Inspector: expose object class name as a part of RemoteObject mirror.
  9527. https://bugs.webkit.org/show_bug.cgi?id=61067
  9528. * inspector/InjectedScriptSource.js:
  9529. * inspector/Inspector.json:
  9530. 2011-05-19 Pavel Feldman <pfeldman@google.com>
  9531. Reviewed by Yury Semikhatsky.
  9532. Web Inspector: make "this" a part of callFrame, not scope in the protocol.
  9533. https://bugs.webkit.org/show_bug.cgi?id=61057
  9534. * inspector/InjectedScriptSource.js:
  9535. * inspector/Inspector.json:
  9536. * inspector/front-end/ScopeChainSidebarPane.js:
  9537. (WebInspector.ScopeChainSidebarPane.prototype.update):
  9538. 2011-05-19 Kent Tamura <tkent@chromium.org>
  9539. Reviewed by Hajime Morita.
  9540. tooLong validity should not be true for a value set by a script
  9541. https://bugs.webkit.org/show_bug.cgi?id=60948
  9542. The specification has been updated so that tooLong should be true only
  9543. for user-edit values.
  9544. Introduce m_wasModifiedByUser flag to HTMLInputElement and
  9545. HTMLTextAreaElemnt. It is set to true when a renderer updates the
  9546. value, and is cleared when the value is updated by others.
  9547. * html/HTMLInputElement.cpp:
  9548. (WebCore::HTMLInputElement::HTMLInputElement):
  9549. Initialize m_wasModifiedByUser.
  9550. (WebCore::HTMLInputElement::tooLong):
  9551. Skip the check if m_wasModifiedByUser is false.
  9552. (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser.
  9553. (WebCore::HTMLInputElement::copyNonAttributeProperties):
  9554. (WebCore::HTMLInputElement::setValue): If sendChange is true,
  9555. m_wasModifiedByUser should be true because sendChange is set in a case
  9556. of form auto-fill. We assume a value set by form auto-fill is a kind
  9557. of user-edit.
  9558. (WebCore::HTMLInputElement::setValueFromRenderer):
  9559. m_wasModifiedByUser should be true for the update by a renderer.
  9560. * html/HTMLInputElement.h: Declare m_wasModifiedByUser.
  9561. * html/HTMLTextAreaElement.cpp:
  9562. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  9563. Initialize m_wasModifiedByUser.
  9564. (WebCore::HTMLTextAreaElement::updateValue):
  9565. m_wasModifiedByUser should be true for the update by a renderer.
  9566. (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser.
  9567. (WebCore::HTMLTextAreaElement::tooLong):
  9568. Skip the check if m_wasModifiedByUser is false.
  9569. * html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.
  9570. 2011-05-19 David Barr <davidbarr@chromium.org>
  9571. Reviewed by Simon Fraser.
  9572. CSS3: We fail 'border radius sum of radii' test
  9573. https://bugs.webkit.org/show_bug.cgi?id=38788
  9574. Ignore border-radius properties with negative values.
  9575. Test: fast/css/border-radius-non-negative.html
  9576. * WebCore.xcodeproj/project.pbxproj:
  9577. * css/CSSParser.cpp:
  9578. (WebCore::CSSParser::parseValue):
  9579. (WebCore::CSSParser::parseBorderRadius):
  9580. 2011-05-19 Yuta Kitamura <yutak@chromium.org>
  9581. Reviewed by Kent Tamura.
  9582. WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
  9583. https://bugs.webkit.org/show_bug.cgi?id=61034
  9584. Refactoring only. No new tests.
  9585. * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
  9586. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
  9587. (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
  9588. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
  9589. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  9590. (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
  9591. (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
  9592. (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
  9593. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
  9594. (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  9595. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  9596. Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task
  9597. to hold these pending events.
  9598. 2011-05-19 Emil A Eklund <eae@chromium.org>
  9599. Reviewed by Alexey Proskuryakov.
  9600. REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
  9601. https://bugs.webkit.org/show_bug.cgi?id=60986
  9602. * html/HTMLSelectElement.cpp:
  9603. (WebCore::HTMLSelectElement::setMultiple):
  9604. Don't restore selection if the multiple attribute hasn't changed.
  9605. 2011-05-18 Fumitoshi Ukai <ukai@chromium.org>
  9606. Reviewed by Alexey Proskuryakov.
  9607. http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests)
  9608. https://bugs.webkit.org/show_bug.cgi?id=57048
  9609. * platform/network/cf/SocketStreamHandleCFNet.cpp:
  9610. (WebCore::SocketStreamHandle::platformClose): use loaderRunLoop to schedule streams on platform WIN
  9611. 2011-05-18 MORITA Hajime <morrita@google.com>
  9612. Unreviewed attempt to fix clang build.
  9613. * rendering/InlineTextBox.h:
  9614. 2011-05-18 Nat Duca <nduca@chromium.org>
  9615. Reviewed by James Robinson.
  9616. [chromium] Add histograms for paint times
  9617. https://bugs.webkit.org/show_bug.cgi?id=61010
  9618. * platform/graphics/chromium/ContentLayerChromium.cpp:
  9619. (WebCore::ContentLayerPainter::paint):
  9620. 2011-05-18 Adrienne Walker <enne@google.com>
  9621. Reviewed by James Robinson.
  9622. [chromium] Fix incorrect size when clipping image layer upload rects
  9623. https://bugs.webkit.org/show_bug.cgi?id=61105
  9624. The clipped destination and source rects should have the same size.
  9625. * platform/graphics/chromium/ImageLayerChromium.cpp:
  9626. (WebCore::ImageLayerTextureUpdater::updateTextureRect):
  9627. 2011-05-17 MORITA Hajime <morrita@google.com>
  9628. Reviewed by Tony Chang.
  9629. [Refactoring] Member variables of DocumentMarker should be encapsulated.
  9630. https://bugs.webkit.org/show_bug.cgi?id=56814
  9631. - Moved DocumentMarker's member variables to private and added getters for them.
  9632. - Added DocumentMarker setters and constructors, which contain assertions against m_type values
  9633. because description and activeMatch are used with specific type of MarkerType.
  9634. - Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController::addTextMatchMarker()
  9635. because it accesses DocumentMarker internals.
  9636. - Moved a version of DMC::addMarker() to private and add alternatives that hide
  9637. internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  9638. * dom/DocumentMarker.h:
  9639. (WebCore::DocumentMarker::type):
  9640. (WebCore::DocumentMarker::startOffset):
  9641. (WebCore::DocumentMarker::endOffset):
  9642. (WebCore::DocumentMarker::description):
  9643. (WebCore::DocumentMarker::hasDescription):
  9644. (WebCore::DocumentMarker::activeMatch):
  9645. (WebCore::DocumentMarker::clearDescription):
  9646. (WebCore::DocumentMarker::setStartOffset):
  9647. (WebCore::DocumentMarker::setEndOffset):
  9648. (WebCore::DocumentMarker::operator==):
  9649. (WebCore::DocumentMarker::DocumentMarker):
  9650. (WebCore::DocumentMarker::shiftOffsets):
  9651. (WebCore::DocumentMarker::setActiveMatch):
  9652. * dom/DocumentMarkerController.cpp:
  9653. (WebCore::DocumentMarkerController::addMarker):
  9654. (WebCore::DocumentMarkerController::addTextMatchMarker):
  9655. (WebCore::DocumentMarkerController::copyMarkers):
  9656. (WebCore::DocumentMarkerController::removeMarkers):
  9657. (WebCore::DocumentMarkerController::markerContainingPoint):
  9658. (WebCore::DocumentMarkerController::markersInRange):
  9659. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  9660. (WebCore::DocumentMarkerController::removeMarkersFromList):
  9661. (WebCore::DocumentMarkerController::repaintMarkers):
  9662. (WebCore::DocumentMarkerController::shiftMarkers):
  9663. (WebCore::DocumentMarkerController::setMarkersActive):
  9664. (WebCore::DocumentMarkerController::hasMarkers):
  9665. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  9666. (WebCore::DocumentMarkerController::showMarkers):
  9667. * dom/DocumentMarkerController.h:
  9668. * editing/CompositeEditCommand.cpp:
  9669. (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  9670. * editing/DeleteSelectionCommand.cpp:
  9671. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  9672. * editing/Editor.cpp:
  9673. (WebCore::Editor::selectionStartHasMarkerFor):
  9674. * editing/SpellingCorrectionController.cpp:
  9675. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  9676. * editing/SpellingCorrectionController.h:
  9677. (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  9678. * rendering/HitTestResult.cpp:
  9679. (WebCore::HitTestResult::spellingToolTip):
  9680. (WebCore::HitTestResult::replacedString):
  9681. * rendering/InlineTextBox.cpp:
  9682. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  9683. (WebCore::InlineTextBox::paintTextMatchMarker):
  9684. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  9685. (WebCore::InlineTextBox::paintDocumentMarkers):
  9686. * rendering/svg/SVGInlineFlowBox.cpp:
  9687. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  9688. 2011-05-18 Oliver Hunt <oliver@apple.com>
  9689. Reviewed by Geoffrey Garen.
  9690. +[WebScriptObject throwException:] doesn't work when invoked from obj-c field access
  9691. https://bugs.webkit.org/show_bug.cgi?id=61100
  9692. The objc bindings were written to assume exceptions would
  9693. come from obj-c style exceptions, rather than throwException:
  9694. This code simply calls the global ObjcInstance mechanism for
  9695. transferring the reported exception.
  9696. * bridge/objc/objc_instance.h:
  9697. * bridge/objc/objc_runtime.mm:
  9698. (JSC::Bindings::ObjcField::valueFromInstance):
  9699. (JSC::Bindings::ObjcField::setValueToInstance):
  9700. 2011-05-16 Adrienne Walker <enne@google.com>
  9701. Reviewed by James Robinson.
  9702. [chromium] Robustly handle mapTexSubImage2D returning NULL
  9703. https://bugs.webkit.org/show_bug.cgi?id=60934
  9704. Also, lazily create the temp buffer so that both the map and non-map
  9705. cases can use it.
  9706. * platform/graphics/chromium/LayerTextureSubImage.cpp:
  9707. (WebCore::LayerTextureSubImage::setSubImageSize):
  9708. (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
  9709. (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  9710. 2011-05-18 Emil A Eklund <eae@chromium.org>
  9711. Reviewed by Darin Adler.
  9712. Change RenderTextControl::hitInnerTextElement to use IntPoint
  9713. https://bugs.webkit.org/show_bug.cgi?id=61003
  9714. Covered by existing tests.
  9715. * rendering/RenderTextControl.cpp:
  9716. (WebCore::RenderTextControl::hitInnerTextElement):
  9717. * rendering/RenderTextControl.h:
  9718. * rendering/RenderTextControlMultiLine.cpp:
  9719. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  9720. * rendering/RenderTextControlSingleLine.cpp:
  9721. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  9722. 2011-05-18 Chris Fleizach <cfleizach@apple.com>
  9723. Reviewed by Maciej Stachowiak.
  9724. WK2: VoiceOver cannot move focus into a web area programmatically
  9725. https://bugs.webkit.org/show_bug.cgi?id=60661
  9726. Accessibility code relies on the ability to bring focus to the containing widget view.
  9727. In WK2, that message needs to be propagated to the UI process.
  9728. * page/ChromeClient.h:
  9729. (WebCore::ChromeClient::makeFirstResponder):
  9730. * page/mac/ChromeMac.mm:
  9731. (WebCore::Chrome::focusNSView):
  9732. * platform/mac/WidgetMac.mm:
  9733. (WebCore::Widget::setFocus):
  9734. 2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google.com>
  9735. Reviewed by James Robinson.
  9736. [chromium] Split canvas from LayerTilerChromium
  9737. https://bugs.webkit.org/show_bug.cgi?id=60719
  9738. LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
  9739. Also abstracted LayerTextureSubImage to upload texture pixels.
  9740. * WebCore.gypi:
  9741. * platform/chromium/TraceEvent.h:
  9742. * platform/graphics/chromium/ContentLayerChromium.cpp:
  9743. (WebCore::ContentLayerChromium::create):
  9744. (WebCore::ContentLayerChromium::ContentLayerChromium):
  9745. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  9746. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  9747. (WebCore::ContentLayerChromium::cleanupResources):
  9748. (WebCore::ContentLayerChromium::setLayerRenderer):
  9749. (WebCore::ContentLayerChromium::createTextureUpdater):
  9750. (WebCore::ContentLayerChromium::drawsContent):
  9751. (WebCore::ContentLayerChromium::createTilerIfNeeded):
  9752. (WebCore::ContentLayerChromium::updateCompositorResources):
  9753. * platform/graphics/chromium/ContentLayerChromium.h:
  9754. * platform/graphics/chromium/ImageLayerChromium.cpp:
  9755. (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
  9756. (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater):
  9757. (WebCore::ImageLayerTextureUpdater::orientation):
  9758. (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
  9759. (WebCore::ImageLayerTextureUpdater::updateTextureRect):
  9760. (WebCore::ImageLayerTextureUpdater::imageRect):
  9761. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  9762. (WebCore::ImageLayerChromium::updateCompositorResources):
  9763. (WebCore::ImageLayerChromium::createTextureUpdater):
  9764. * platform/graphics/chromium/ImageLayerChromium.h:
  9765. * platform/graphics/chromium/LayerPainterChromium.h: Added.
  9766. * platform/graphics/chromium/LayerRendererChromium.cpp:
  9767. (WebCore::LayerRendererChromium::create):
  9768. (WebCore::LayerRendererChromium::LayerRendererChromium):
  9769. (WebCore::LayerRendererChromium::updateRootLayerContents):
  9770. (WebCore::LayerRendererChromium::drawRootLayer):
  9771. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  9772. (WebCore::LayerRendererChromium::updateLayers):
  9773. * platform/graphics/chromium/LayerRendererChromium.h:
  9774. * platform/graphics/chromium/LayerTextureSubImage.cpp: Added.
  9775. (WebCore::LayerTextureSubImage::LayerTextureSubImage):
  9776. (WebCore::LayerTextureSubImage::~LayerTextureSubImage):
  9777. (WebCore::LayerTextureSubImage::setSubImageSize):
  9778. (WebCore::LayerTextureSubImage::upload):
  9779. (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
  9780. (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  9781. * platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
  9782. * platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
  9783. (WebCore::LayerTextureUpdater::LayerTextureUpdater):
  9784. (WebCore::LayerTextureUpdater::~LayerTextureUpdater):
  9785. (WebCore::LayerTextureUpdater::context):
  9786. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added.
  9787. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
  9788. (WebCore::LayerTextureUpdaterCanvas::paintContents):
  9789. (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
  9790. (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
  9791. (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  9792. * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
  9793. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas):
  9794. (WebCore::LayerTextureUpdaterCanvas::contentRect):
  9795. (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap):
  9796. (WebCore::LayerTextureUpdaterBitmap::orientation):
  9797. * platform/graphics/chromium/LayerTilerChromium.cpp:
  9798. (WebCore::LayerTilerChromium::create):
  9799. (WebCore::LayerTilerChromium::LayerTilerChromium):
  9800. (WebCore::LayerTilerChromium::setTileSize):
  9801. (WebCore::LayerTilerChromium::prepareToUpdate):
  9802. (WebCore::LayerTilerChromium::updateRect):
  9803. (WebCore::LayerTilerChromium::draw):
  9804. * platform/graphics/chromium/LayerTilerChromium.h:
  9805. (WebCore::LayerTilerChromium::Tile::Tile):
  9806. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  9807. (WebCore::CCHeadsUpDisplay::draw):
  9808. 2011-05-18 Mark Pilgrim <pilgrim@chromium.org>
  9809. Reviewed by Tony Chang.
  9810. IndexedDB put() should fail adding to object store that uses
  9811. out-of-line keys and has no key generator and the key parameter
  9812. was not provided
  9813. https://bugs.webkit.org/show_bug.cgi?id=58609
  9814. Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
  9815. no key generator means that objectStore->autoIncrement() is false, and
  9816. key parameter was not provided means that prpKey will be a null pointer.
  9817. The combination of these 3 should throw a DATA_ERR.
  9818. Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html
  9819. * storage/IDBObjectStoreBackendImpl.cpp:
  9820. (WebCore::IDBObjectStoreBackendImpl::put):
  9821. 2011-05-18 Chris Rogers <crogers@google.com>
  9822. Reviewed by James Robinson.
  9823. EqualPowerPanner is not using the correct azimuth range for stereo panning
  9824. https://bugs.webkit.org/show_bug.cgi?id=61085
  9825. No new tests since audio API is not yet implemented.
  9826. * platform/audio/EqualPowerPanner.cpp:
  9827. (WebCore::EqualPowerPanner::pan):
  9828. 2011-05-18 Yi Shen <yi.4.shen@nokia.com>
  9829. Reviewed by Andreas Kling.
  9830. [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
  9831. https://bugs.webkit.org/show_bug.cgi?id=33179
  9832. Fill the missing key text for the EnterKey event.
  9833. Tests: fast/events/onsearch-enter.html
  9834. * platform/qt/PlatformKeyboardEventQt.cpp:
  9835. (WebCore::keyTextForKeyEvent):
  9836. 2011-05-17 Timothy Hatcher <timothy@apple.com>
  9837. Update the the context menu to reflect the system search provider on Mac.
  9838. <rdar://problem/9198419>
  9839. Reviewed by Sam Weinig.
  9840. * English.lproj/Localizable.strings: Updated.
  9841. * Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
  9842. * platform/DefaultLocalizationStrategy.cpp:
  9843. (WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
  9844. create the string.
  9845. * platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
  9846. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  9847. 2011-05-18 Rob Buis <rbuis@rim.com>
  9848. Reviewed by Nikolas Zimmermann.
  9849. Marker test from ietestcenter fails
  9850. https://bugs.webkit.org/show_bug.cgi?id=60721
  9851. Change <marker> renderer creation behaviour to always create the renderer. This fixes
  9852. the problem that no marker is rendered when display=none is set on the <marker>. The
  9853. specification states that display=none should have no influence on <marker> usage:
  9854. "The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
  9855. elements are available for referencing even when the ‘display’ property on the ‘marker’
  9856. element or any of its ancestors is set to none."
  9857. Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
  9858. svg/custom/painting-marker-07-f-inherit.svg
  9859. * svg/SVGMarkerElement.h:
  9860. (WebCore::SVGMarkerElement::rendererIsNeeded):
  9861. 2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon.hausmann@nokia.com>
  9862. Reviewed by Eric Carlson.
  9863. MediaElements fails to load the data in some cases.
  9864. https://bugs.webkit.org/show_bug.cgi?id=60760
  9865. WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
  9866. that uses the ResourceHandle API to request data and pass it down. For
  9867. our builds it is absolutely essential that we have a NetworkingContext
  9868. available there, in order to get access to the QNetworkAccessManager.
  9869. No access means we basically cannot load the video. The WebSource gains
  9870. access to the NetworkingContext through a WebCore::Frame pointer it has.
  9871. MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
  9872. the WebCore::Frame to the WebKitWebSource in
  9873. mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
  9874. frameView() accessor to access the frame. However the frameView() member
  9875. is only set through the render tree's RenderVideo, which is rather unreliable
  9876. given that some sites create "fake" video tags initially that only become
  9877. visible later (or never).
  9878. A more reliable way is to simply use the document of the MediaPlayerClient,
  9879. which is provided at constructor time.
  9880. Test: http/tests/media/media-can-load-when-hidden.html
  9881. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  9882. (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
  9883. 2011-05-18 Adrienne Walker <enne@google.com>
  9884. Reviewed by James Robinson.
  9885. [chromium] Check HUD texture reserve status before using texture
  9886. https://bugs.webkit.org/show_bug.cgi?id=61082
  9887. This only changes behavior behind a flag, so shouldn't impact any tests.
  9888. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  9889. (WebCore::CCHeadsUpDisplay::draw):
  9890. 2011-05-18 Oliver Hunt <oliver@apple.com>
  9891. Reviewed by Sam Weinig.
  9892. JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
  9893. https://bugs.webkit.org/show_bug.cgi?id=61090
  9894. Rather than having Constructor objects create their structure
  9895. as part of initialisation, we now pass their expected structure
  9896. in as an argument. This required fixing the few custom Constructors
  9897. and the code generator.
  9898. * bindings/js/JSAudioConstructor.cpp:
  9899. (WebCore::JSAudioConstructor::JSAudioConstructor):
  9900. * bindings/js/JSAudioConstructor.h:
  9901. * bindings/js/JSDOMGlobalObject.h:
  9902. (WebCore::getDOMConstructor):
  9903. Pass the Constructor objects structure in as an argument
  9904. * bindings/js/JSImageConstructor.cpp:
  9905. (WebCore::JSImageConstructor::JSImageConstructor):
  9906. * bindings/js/JSImageConstructor.h:
  9907. * bindings/js/JSOptionConstructor.cpp:
  9908. (WebCore::JSOptionConstructor::JSOptionConstructor):
  9909. * bindings/js/JSOptionConstructor.h:
  9910. * bindings/scripts/CodeGeneratorJS.pm:
  9911. 2011-05-18 Abhishek Arya <inferno@chromium.org>
  9912. Reviewed by Beth Dakin.
  9913. Remove removeChild on table caption since destroy call
  9914. already does that.
  9915. https://bugs.webkit.org/show_bug.cgi?id=61083
  9916. Test: fast/table/table-captions-child-visible-crash.html
  9917. * rendering/RenderTable.cpp:
  9918. (WebCore::RenderTable::recalcCaption):
  9919. 2011-05-18 Evan Martin <evan@chromium.org>
  9920. Reviewed by Tony Chang.
  9921. [chromium] make action_derivedsourcesallinone.py quiet
  9922. https://bugs.webkit.org/show_bug.cgi?id=61081
  9923. In gyp, it's the responsibility of the build system to print what actions are doing;
  9924. for example, the compile command is generally silent, while the build system prints
  9925. "compiling".
  9926. Make this program behave like a compiler: silent on success.
  9927. * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
  9928. delete a print statement.
  9929. 2011-05-18 David Kilzer <ddkilzer@apple.com>
  9930. <http://webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()
  9931. Reviewed by Joseph Pecoraro.
  9932. * platform/network/cf/ResourceRequestCFNet.cpp:
  9933. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Use
  9934. toHTTPPipeliningPriority() to convert arguments passed to
  9935. wkSetHTTPPipeliningMaximumPriority() and
  9936. wkSetHTTPPipeliningMinimumFastLanePriority().
  9937. 2011-05-18 Erik Arvidsson <arv@chromium.org>
  9938. Reviewed by Ojan Vafai.
  9939. event.clientX/clientY is 0/0 in a click generated through a label
  9940. https://bugs.webkit.org/show_bug.cgi?id=56606
  9941. This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
  9942. is a mouse event.
  9943. This makes us match Firefox and IE.
  9944. Test: fast/events/simulated-click-coords.html
  9945. * dom/MouseEvent.cpp:
  9946. (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
  9947. 2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
  9948. Not reviewed. Sorted XCode project file.
  9949. * WebCore.xcodeproj/project.pbxproj:
  9950. 2011-05-18 Alexander Pavlov <apavlov@chromium.org>
  9951. Reviewed by Pavel Feldman.
  9952. Web Inspector: Non-color CSS property values can get a color-picker
  9953. https://bugs.webkit.org/show_bug.cgi?id=61056
  9954. * inspector/front-end/CSSKeywordCompletions.js:
  9955. (WebInspector.CSSKeywordCompletions.forProperty):
  9956. (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
  9957. * inspector/front-end/StylesSidebarPane.js:
  9958. (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
  9959. 2011-05-18 Pratik Solanki <psolanki@apple.com>
  9960. Reviewed by Dan Bernstein.
  9961. Don't use DEFINE_STATIC_LOCAL with an unsigned
  9962. https://bugs.webkit.org/show_bug.cgi?id=61026
  9963. * storage/StorageTracker.cpp:
  9964. (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): DEFINE_STATIC_LOCAL is meant
  9965. for objects, not unsigned ints. We can just use static here.
  9966. 2011-05-18 Rob Buis <rbuis@rim.com>
  9967. Reviewed by Nikolas Zimmermann.
  9968. NULL deref when SVG elements have table styles
  9969. https://bugs.webkit.org/show_bug.cgi?id=45561
  9970. Restrict computed CSS values for SVG display property to block, inline or none.
  9971. Tests: svg/custom/display-table-caption-foreignObject.svg
  9972. svg/custom/display-table-caption-inherit-foreignObject.xhtml
  9973. svg/custom/display-table-caption-inherit-text.xhtml
  9974. svg/custom/display-table-caption-text.svg
  9975. * css/CSSStyleSelector.cpp:
  9976. (WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard):
  9977. (WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard):
  9978. (WebCore::isAcceptableForSVGElement):
  9979. (WebCore::CSSStyleSelector::applyProperty):
  9980. 2011-05-18 Pavel Feldman <pfeldman@google.com>
  9981. Reviewed by Yury Semikhatsky.
  9982. Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
  9983. https://bugs.webkit.org/show_bug.cgi?id=60811
  9984. Test: inspector/debugger/debugger-completions-on-call-frame.html
  9985. * inspector/InjectedScriptSource.js:
  9986. * inspector/front-end/ConsoleView.js:
  9987. (WebInspector.ConsoleView.prototype.completions.else.evaluated):
  9988. * inspector/front-end/DebuggerPresentationModel.js:
  9989. (WebInspector.PresenationCallFrame.prototype.get variables):
  9990. * inspector/front-end/ScriptsPanel.js:
  9991. (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):
  9992. 2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
  9993. Reviewed by Rob Buis.
  9994. All animated SVG enum properties are now ints
  9995. https://bugs.webkit.org/show_bug.cgi?id=10749
  9996. DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
  9997. Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
  9998. types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
  9999. (Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)
  10000. Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
  10001. A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
  10002. Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
  10003. Use the new SVGPropertyTraits everywhere in svg/.
  10004. This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
  10005. Example: <clipPath clipPathUnits="objectBoundingBox">
  10006. myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
  10007. alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
  10008. We're now properly converting the enum values to strings.
  10009. Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:
  10010. - SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
  10011. - SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.
  10012. Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html
  10013. svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
  10014. svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
  10015. svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
  10016. svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
  10017. svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
  10018. svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
  10019. svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
  10020. svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
  10021. svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
  10022. svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
  10023. svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
  10024. svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
  10025. svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
  10026. svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
  10027. svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html
  10028. Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.
  10029. * GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
  10030. * WebCore.gypi: Ditto.
  10031. * WebCore.pro: Ditto.
  10032. * WebCore.vcproj/WebCore.vcproj: Ditto.
  10033. * WebCore.xcodeproj/project.pbxproj: Ditto.
  10034. * bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
  10035. * platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
  10036. * platform/graphics/filters/FEBlend.cpp:
  10037. (WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
  10038. * platform/graphics/filters/FEDisplacementMap.cpp:
  10039. (WebCore::FEDisplacementMap::apply): Ditto.
  10040. * rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now.
  10041. (WebCore::RenderSVGResourceClipper::clipPathUnits):
  10042. * rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now.
  10043. (WebCore::RenderSVGResourceFilter::filterUnits):
  10044. (WebCore::RenderSVGResourceFilter::primitiveUnits):
  10045. * rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform).
  10046. (WebCore::RenderSVGResourceGradient::applyResource):
  10047. * rendering/svg/RenderSVGResourceGradient.h: Ditto.
  10048. * rendering/svg/RenderSVGResourceLinearGradient.cpp:
  10049. (WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  10050. * rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now.
  10051. (WebCore::RenderSVGResourceMarker::markerUnits):
  10052. * rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now.
  10053. (WebCore::RenderSVGResourceMasker::maskUnits):
  10054. (WebCore::RenderSVGResourceMasker::maskContentUnits):
  10055. * rendering/svg/RenderSVGResourceRadialGradient.cpp:
  10056. (WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  10057. * rendering/svg/SVGRenderTreeAsText.cpp:
  10058. (WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication.
  10059. (WebCore::writeCommonGradientProperties):
  10060. * rendering/svg/SVGTextChunkBuilder.cpp:
  10061. (WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10062. * rendering/svg/SVGTextLayoutEngine.cpp:
  10063. (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto.
  10064. (WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
  10065. * svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType.
  10066. (WebCore::GradientAttributes::GradientAttributes):
  10067. (WebCore::GradientAttributes::spreadMethod):
  10068. (WebCore::GradientAttributes::setSpreadMethod):
  10069. * svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
  10070. * svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
  10071. * svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.
  10072. Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.
  10073. * svg/SVGAnimatedInteger.idl: Ditto.
  10074. * svg/SVGAnimatedNumber.idl: Ditto.
  10075. * svg/SVGAnimatedString.idl: Ditto.
  10076. * svg/SVGClipPathElement.cpp:
  10077. (WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  10078. * svg/SVGClipPathElement.h:
  10079. * svg/SVGComponentTransferFunctionElement.cpp:
  10080. (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec.
  10081. (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  10082. (WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10083. * svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.
  10084. It's not possible anymore for these values to go out of range.
  10085. * svg/SVGFEBlendElement.cpp:
  10086. (WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()).
  10087. (WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10088. (WebCore::SVGFEBlendElement::build): Ditto.
  10089. * svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
  10090. * svg/SVGFEColorMatrixElement.cpp:
  10091. (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()).
  10092. (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now..
  10093. (WebCore::SVGFEColorMatrixElement::build): Ditto.
  10094. * svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
  10095. * svg/SVGFECompositeElement.cpp:
  10096. (WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()).
  10097. (WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10098. (WebCore::SVGFECompositeElement::build): Ditto.
  10099. * svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
  10100. * svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr.
  10101. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()).
  10102. (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10103. (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync.
  10104. (WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10105. * svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
  10106. * svg/SVGFEDisplacementMapElement.cpp:
  10107. (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()).
  10108. (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10109. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now.
  10110. (WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10111. * svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
  10112. * svg/SVGFEMorphologyElement.cpp:
  10113. (WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()).
  10114. (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10115. (WebCore::SVGFEMorphologyElement::build): Ditto.
  10116. * svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
  10117. * svg/SVGFETurbulenceElement.cpp:
  10118. (WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()).
  10119. (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10120. (WebCore::SVGFETurbulenceElement::build): Ditto.
  10121. * svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
  10122. * svg/SVGFilterElement.cpp:
  10123. (WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
  10124. * svg/SVGFilterElement.h:
  10125. * svg/SVGGradientElement.cpp:
  10126. (WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec.
  10127. (WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
  10128. * svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
  10129. * svg/SVGLinearGradientElement.cpp:
  10130. (WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10131. * svg/SVGMarkerElement.cpp:
  10132. (WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  10133. (WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special
  10134. as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.
  10135. (WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.
  10136. * svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations.
  10137. (WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'.
  10138. (WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto.
  10139. (WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
  10140. * svg/SVGMaskElement.cpp:
  10141. (WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  10142. * svg/SVGMaskElement.h:
  10143. * svg/SVGPatternElement.cpp:
  10144. (WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  10145. * svg/SVGPatternElement.h:
  10146. * svg/SVGRadialGradientElement.cpp:
  10147. (WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  10148. * svg/SVGTextContentElement.cpp:
  10149. (WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
  10150. * svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
  10151. * svg/SVGTextPathElement.cpp:
  10152. (WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
  10153. * svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
  10154. * svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
  10155. * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.
  10156. SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
  10157. class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
  10158. is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
  10159. the enums go out of range anymore (which lead to security bugs in the past).
  10160. (WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
  10161. (WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
  10162. (WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):
  10163. * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
  10164. (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param.
  10165. (WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):
  10166. 2011-05-18 Kinuko Yasuda <kinuko@chromium.org>
  10167. Reviewed by David Levin.
  10168. Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
  10169. https://bugs.webkit.org/show_bug.cgi?id=59681
  10170. Test: storage/storageinfo-request-quota.html
  10171. * CMakeLists.txt:
  10172. * CodeGenerators.pri:
  10173. * DerivedSources.cpp:
  10174. * DerivedSources.make:
  10175. * GNUmakefile.am:
  10176. * GNUmakefile.list.am:
  10177. * WebCore.gypi:
  10178. * WebCore.vcproj/WebCore.vcproj:
  10179. * WebCore.xcodeproj/project.pbxproj:
  10180. * storage/StorageInfo.idl: Added requestQuota().
  10181. * storage/StorageInfoQuotaCallback.idl: Added.
  10182. 2011-05-18 Renata Hodovan <reni@webkit.org>
  10183. Reviewed by Nikolas Zimmermann.
  10184. Apply the ParallelJobs support to FEGaussianBlur
  10185. https://bugs.webkit.org/show_bug.cgi?id=61049
  10186. The Gaussian blur filter of SVG can consume lots of resources if it is
  10187. applied to a large area. The computation can be distributed to multiple
  10188. cores if the architecture supports.
  10189. The average performance progression is about 15% on dual-core machines.
  10190. Developed in cooperation with Gabor Loki and Zoltan Herczeg.
  10191. * platform/graphics/filters/FEGaussianBlur.cpp:
  10192. (WebCore::FEGaussianBlur::platformApplyWorker):
  10193. (WebCore::FEGaussianBlur::platformApply):
  10194. * platform/graphics/filters/FEGaussianBlur.h:
  10195. 2011-05-18 Pavel Feldman <pfeldman@google.com>
  10196. Reviewed by Yury Semikhatsky.
  10197. Web Inspector: make parentId for frame optional.
  10198. https://bugs.webkit.org/show_bug.cgi?id=61032
  10199. * inspector/Inspector.json:
  10200. * inspector/InspectorPageAgent.cpp:
  10201. (WebCore::InspectorPageAgent::buildObjectForFrame):
  10202. * inspector/front-end/ResourceTreeModel.js:
  10203. (WebInspector.ResourceTreeModel.prototype._addFrame):
  10204. 2011-05-18 Gabor Loki <loki@webkit.org>
  10205. Reviewed by Nikolas Zimmermann.
  10206. Apply the ParallelJobs support to FELighting
  10207. https://bugs.webkit.org/show_bug.cgi?id=61048
  10208. The lighting filter of SVG can consume lots of resources if it is
  10209. applied to a large area. The computation can be distributed to multiple
  10210. cores if the architecture supports.
  10211. The average performance progression is 10-20% on dual-core machines.
  10212. Developed in cooperation with Zoltan Herczeg.
  10213. * platform/graphics/filters/FELighting.cpp:
  10214. (WebCore::FELighting::platformApplyGenericPaint):
  10215. (WebCore::FELighting::platformApplyGenericWorker):
  10216. (WebCore::FELighting::platformApplyGeneric):
  10217. * platform/graphics/filters/FELighting.h:
  10218. * platform/graphics/filters/arm/FELightingNEON.cpp:
  10219. (WebCore::FELighting::platformApplyNeonWorker):
  10220. * platform/graphics/filters/arm/FELightingNEON.h:
  10221. (WebCore::FELighting::platformApplyNeon):
  10222. 2011-05-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  10223. Reviewed by Andreas Kling.
  10224. [Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
  10225. https://bugs.webkit.org/show_bug.cgi?id=60984
  10226. The code for converting objects to QVariantMap was causing exception,
  10227. that was "leaking" to the next evaluation. One situation was reading
  10228. the property 'localStorage' when we do not have a proper security
  10229. origin, which throws a SECURITY_ERR.
  10230. Now, we will simply not include on the QVariantMap those properties,
  10231. and make sure that we clean the exception if necessary.
  10232. * bridge/qt/qt_runtime.cpp:
  10233. (JSC::Bindings::convertValueToQVariantMap):
  10234. Extracted function that performs conversion from JSObject to a QVariantMap. This
  10235. functions makes sure that exception is clean after its execution.
  10236. (JSC::Bindings::convertValueToQVariant):
  10237. Use the previous function. Add a comment explaining the choice of distance value.
  10238. 2011-05-18 Ilya Tikhonovsky <loislo@chromium.org>
  10239. Reviewed by Yury Semikhatsky.
  10240. Web Inspector: scripts panel file selector element doesn't track keyboard events
  10241. https://bugs.webkit.org/show_bug.cgi?id=61047
  10242. * inspector/front-end/ScriptsPanel.js:
  10243. (WebInspector.ScriptsPanel):
  10244. 2011-05-16 Pavel Podivilov <podivilov@chromium.org>
  10245. Reviewed by Yury Semikhatsky.
  10246. Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
  10247. https://bugs.webkit.org/show_bug.cgi?id=60900
  10248. * bindings/js/ScriptDebugServer.cpp:
  10249. (WebCore::ScriptDebugServer::dispatchDidParseSource):
  10250. * bindings/v8/ScriptDebugServer.cpp:
  10251. (WebCore::ScriptDebugServer::dispatchDidParseSource):
  10252. * inspector/InspectorDebuggerAgent.cpp:
  10253. (WebCore::InspectorDebuggerAgent::getScriptSource):
  10254. (WebCore::InspectorDebuggerAgent::didParseSource):
  10255. * inspector/InspectorDebuggerAgent.h:
  10256. * inspector/ScriptDebugListener.h:
  10257. (WebCore::ScriptDebugListener::Script::Script):
  10258. 2011-05-18 Alexander Pavlov <apavlov@chromium.org>
  10259. Reviewed by Pavel Feldman.
  10260. Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
  10261. https://bugs.webkit.org/show_bug.cgi?id=60966
  10262. Imported stylesheets didn't use to be returned by InspectorCSSAgent.
  10263. * inspector/InspectorCSSAgent.cpp:
  10264. (WebCore::InspectorCSSAgent::getAllStyleSheets):
  10265. (WebCore::InspectorCSSAgent::collectStyleSheets):
  10266. * inspector/InspectorCSSAgent.h:
  10267. 2011-05-18 Pavel Feldman <pfeldman@google.com>
  10268. Reviewed by Yury Semikhatsky.
  10269. Web Inspector: make "Id" suffixes use consistent case.
  10270. https://bugs.webkit.org/show_bug.cgi?id=61028
  10271. * inspector/InjectedScriptSource.js:
  10272. * inspector/Inspector.json:
  10273. * inspector/InspectorConsoleAgent.cpp:
  10274. (WebCore::InspectorConsoleAgent::addMessageToConsole):
  10275. * inspector/InspectorConsoleAgent.h:
  10276. * inspector/InspectorConsoleInstrumentation.h:
  10277. (WebCore::InspectorInstrumentation::addMessageToConsole):
  10278. * inspector/InspectorDebuggerAgent.cpp:
  10279. (WebCore::parseLocation):
  10280. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  10281. (WebCore::InspectorDebuggerAgent::editScriptSource):
  10282. (WebCore::InspectorDebuggerAgent::getScriptSource):
  10283. (WebCore::InspectorDebuggerAgent::didParseSource):
  10284. * inspector/InspectorDebuggerAgent.h:
  10285. * inspector/InspectorInstrumentation.cpp:
  10286. (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  10287. * inspector/InspectorInstrumentation.h:
  10288. * inspector/InspectorResourceAgent.cpp:
  10289. (WebCore::buildObjectForResourceResponse):
  10290. * inspector/ScriptDebugListener.h:
  10291. * inspector/front-end/DebuggerModel.js:
  10292. (WebInspector.DebuggerModel.prototype.scriptForSourceID):
  10293. (WebInspector.DebuggerModel.prototype.queryScripts):
  10294. (WebInspector.DebuggerModel.prototype.editScriptSource):
  10295. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  10296. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  10297. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  10298. (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  10299. * inspector/front-end/DebuggerPresentationModel.js:
  10300. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
  10301. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  10302. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
  10303. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
  10304. (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
  10305. (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
  10306. (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
  10307. (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
  10308. (WebInspector.PresenationCallFrame):
  10309. * inspector/front-end/NetworkManager.js:
  10310. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  10311. * inspector/front-end/Script.js:
  10312. (WebInspector.Script):
  10313. (WebInspector.Script.prototype.requestSource):
  10314. (WebInspector.Script.prototype.editSource):
  10315. * inspector/front-end/SourceFile.js:
  10316. (WebInspector.SourceFile.prototype.forceLoadContent):
  10317. (WebInspector.SourceFile.prototype._concatenateScriptsContent):
  10318. (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
  10319. (WebInspector):
  10320. 2011-05-18 Sheriff Bot <webkit.review.bot@gmail.com>
  10321. Unreviewed, rolling out r86747.
  10322. http://trac.webkit.org/changeset/86747
  10323. https://bugs.webkit.org/show_bug.cgi?id=61039
  10324. Breaks JSC debugger tests. (Requested by pfeldman on #webkit).
  10325. * inspector/InjectedScriptSource.js:
  10326. ():
  10327. * inspector/Inspector.json:
  10328. * inspector/InspectorConsoleAgent.cpp:
  10329. (WebCore::InspectorConsoleAgent::addMessageToConsole):
  10330. * inspector/InspectorConsoleAgent.h:
  10331. * inspector/InspectorConsoleInstrumentation.h:
  10332. (WebCore::InspectorInstrumentation::addMessageToConsole):
  10333. * inspector/InspectorDebuggerAgent.cpp:
  10334. (WebCore::parseLocation):
  10335. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  10336. (WebCore::InspectorDebuggerAgent::editScriptSource):
  10337. (WebCore::InspectorDebuggerAgent::getScriptSource):
  10338. (WebCore::InspectorDebuggerAgent::didParseSource):
  10339. * inspector/InspectorDebuggerAgent.h:
  10340. * inspector/InspectorInstrumentation.cpp:
  10341. (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  10342. * inspector/InspectorInstrumentation.h:
  10343. * inspector/InspectorResourceAgent.cpp:
  10344. (WebCore::buildObjectForResourceResponse):
  10345. * inspector/ScriptDebugListener.h:
  10346. * inspector/front-end/DebuggerModel.js:
  10347. (WebInspector.DebuggerModel.prototype.scriptForSourceID):
  10348. (WebInspector.DebuggerModel.prototype.queryScripts):
  10349. (WebInspector.DebuggerModel.prototype.editScriptSource):
  10350. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  10351. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  10352. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  10353. (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  10354. * inspector/front-end/DebuggerPresentationModel.js:
  10355. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
  10356. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  10357. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
  10358. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
  10359. (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
  10360. (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
  10361. (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
  10362. (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
  10363. (WebInspector.PresenationCallFrame):
  10364. * inspector/front-end/NetworkManager.js:
  10365. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  10366. * inspector/front-end/Script.js:
  10367. (WebInspector.Script):
  10368. (WebInspector.Script.prototype.requestSource):
  10369. (WebInspector.Script.prototype.editSource):
  10370. * inspector/front-end/SourceFile.js:
  10371. (WebInspector.SourceFile.prototype.forceLoadContent):
  10372. (WebInspector.SourceFile.prototype._concatenateScriptsContent):
  10373. (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
  10374. (WebInspector):
  10375. 2011-05-18 Abhishek Arya <inferno@chromium.org>
  10376. Reviewed by Dirk Schulze.
  10377. When SMIL element is getting removed, make sure to remove it
  10378. from target's animation elements list.
  10379. https://bugs.webkit.org/show_bug.cgi?id=60980
  10380. Test: svg/animations/smil-element-not-removed-crash.html
  10381. * svg/animation/SVGSMILElement.cpp:
  10382. (WebCore::SVGSMILElement::~SVGSMILElement):
  10383. 2011-05-18 Pavel Feldman <pfeldman@google.com>
  10384. Reviewed by Yury Semikhatsky.
  10385. Web Inspector: make "Id" suffixes use consistent case.
  10386. https://bugs.webkit.org/show_bug.cgi?id=61028
  10387. * inspector/InjectedScriptSource.js:
  10388. * inspector/Inspector.json:
  10389. * inspector/InspectorConsoleAgent.cpp:
  10390. (WebCore::InspectorConsoleAgent::addMessageToConsole):
  10391. * inspector/InspectorConsoleAgent.h:
  10392. * inspector/InspectorConsoleInstrumentation.h:
  10393. (WebCore::InspectorInstrumentation::addMessageToConsole):
  10394. * inspector/InspectorDebuggerAgent.cpp:
  10395. (WebCore::parseLocation):
  10396. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  10397. (WebCore::InspectorDebuggerAgent::editScriptSource):
  10398. (WebCore::InspectorDebuggerAgent::getScriptSource):
  10399. (WebCore::InspectorDebuggerAgent::didParseSource):
  10400. * inspector/InspectorDebuggerAgent.h:
  10401. * inspector/InspectorInstrumentation.cpp:
  10402. (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  10403. * inspector/InspectorInstrumentation.h:
  10404. * inspector/InspectorResourceAgent.cpp:
  10405. (WebCore::buildObjectForResourceResponse):
  10406. * inspector/ScriptDebugListener.h:
  10407. * inspector/front-end/DebuggerModel.js:
  10408. (WebInspector.DebuggerModel.prototype.scriptForSourceID):
  10409. (WebInspector.DebuggerModel.prototype.queryScripts):
  10410. (WebInspector.DebuggerModel.prototype.editScriptSource):
  10411. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  10412. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  10413. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  10414. (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  10415. * inspector/front-end/DebuggerPresentationModel.js:
  10416. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
  10417. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  10418. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
  10419. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
  10420. (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
  10421. (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
  10422. (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
  10423. (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
  10424. (WebInspector.PresenationCallFrame):
  10425. * inspector/front-end/NetworkManager.js:
  10426. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  10427. * inspector/front-end/Script.js:
  10428. (WebInspector.Script):
  10429. (WebInspector.Script.prototype.requestSource):
  10430. (WebInspector.Script.prototype.editSource):
  10431. * inspector/front-end/SourceFile.js:
  10432. (WebInspector.SourceFile.prototype.forceLoadContent):
  10433. (WebInspector.SourceFile.prototype._concatenateScriptsContent):
  10434. (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
  10435. (WebInspector):
  10436. 2011-05-18 Pavel Feldman <pfeldman@google.com>
  10437. Reviewed by Yury Semikhatsky.
  10438. Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
  10439. https://bugs.webkit.org/show_bug.cgi?id=60971
  10440. * inspector/front-end/ResourcesPanel.js:
  10441. (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
  10442. * inspector/front-end/ScriptsPanel.js:
  10443. (WebInspector.ScriptsPanel.prototype.showAnchorLocation.):
  10444. (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  10445. * inspector/front-end/inspector.js:
  10446. (WebInspector._showAnchorLocation):
  10447. 2011-05-18 Kent Tamura <tkent@chromium.org>
  10448. Reviewed by Hajime Morita.
  10449. valueMissing validity for <select> is lame when selecting a value by a key operation
  10450. https://bugs.webkit.org/show_bug.cgi?id=61021
  10451. We missed updating validity in case that SelectElement::defaultEventHandler
  10452. update selections. So, SelectElement::setSelectedIndex() updates validity.
  10453. * dom/SelectElement.cpp:
  10454. (WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
  10455. * html/HTMLSelectElement.cpp:
  10456. (WebCore::HTMLSelectElement::setSelectedIndex):
  10457. Remove unnecessary setNeedsValidityCheck() call.
  10458. SelectElement::setSlectedIndex() calls it.
  10459. (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
  10460. 2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
  10461. Reviewed by Pavel Feldman.
  10462. Web Inspector: [Chromium] Enable detailed heap snapshots by default.
  10463. https://bugs.webkit.org/show_bug.cgi?id=60286
  10464. * inspector/front-end/ProfilesPanel.js:
  10465. 2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
  10466. Reviewed by Pavel Feldman.
  10467. Web Inspector: [Chromium] Make retaining paths list of the Detailed
  10468. heap snapshots view resizable.
  10469. https://bugs.webkit.org/show_bug.cgi?id=60960
  10470. * inspector/front-end/DetailedHeapshotView.js:
  10471. (WebInspector.DetailedHeapshotView.prototype.resize):
  10472. (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
  10473. (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):
  10474. (WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging):
  10475. (WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
  10476. * inspector/front-end/heapProfiler.css:
  10477. 2011-05-16 Jeremy Noble <jer.noble@apple.com>
  10478. Reviewed by Darin Adler.
  10479. Disable keyboard input (with exceptions) in full-screen mode.
  10480. https://bugs.webkit.org/show_bug.cgi?id=60943
  10481. Tests: fullscreen/full-screen-keyboard-disabled.html
  10482. fullscreen/full-screen-keyboard-enabled.html
  10483. * page/EventHandler.cpp:
  10484. (WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added. Implements the
  10485. list of allowed keyboard events in the proposed API.
  10486. (WebCore::EventHandler::keyEvent): Discard events which are not allowed in
  10487. full-screen mode.
  10488. * page/EventHandler.h:
  10489. 2011-05-17 Nikolas Zimmermann <nzimmermann@rim.com>
  10490. Reviewed by Dirk Schulze.
  10491. Refactor TextRun creation
  10492. https://bugs.webkit.org/show_bug.cgi?id=60255
  10493. Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
  10494. The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
  10495. replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
  10496. the catch-it-all constructor, these helper functions are introduced, which hide the details of
  10497. creating a TextRun.
  10498. Furthermore it will be used to remove the platform layering violation, that TextRun stores
  10499. RenderObject pointers for the sake of SVG Fonts support, see bug 60254.
  10500. No change in functionaliy, no new tests.
  10501. * rendering/EllipsisBox.cpp:
  10502. (WebCore::EllipsisBox::paint):
  10503. (WebCore::EllipsisBox::selectionRect):
  10504. (WebCore::EllipsisBox::paintSelection):
  10505. * rendering/InlineTextBox.cpp:
  10506. (WebCore::InlineTextBox::selectionRect):
  10507. (WebCore::InlineTextBox::paint):
  10508. (WebCore::InlineTextBox::paintSelection):
  10509. (WebCore::InlineTextBox::paintCompositionBackground):
  10510. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  10511. (WebCore::InlineTextBox::paintTextMatchMarker):
  10512. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  10513. (WebCore::InlineTextBox::offsetForPosition):
  10514. (WebCore::InlineTextBox::positionForOffset):
  10515. (WebCore::InlineTextBox::constructTextRun):
  10516. * rendering/InlineTextBox.h:
  10517. * rendering/RenderBlock.cpp:
  10518. (WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
  10519. * rendering/RenderBlock.h:
  10520. * rendering/RenderEmbeddedObject.cpp:
  10521. (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  10522. * rendering/RenderFileUploadControl.cpp:
  10523. (WebCore::RenderFileUploadControl::paintObject):
  10524. (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  10525. * rendering/RenderImage.cpp:
  10526. (WebCore::RenderImage::setImageSizeForAltText):
  10527. (WebCore::RenderImage::paintReplaced):
  10528. * rendering/RenderListBox.cpp:
  10529. (WebCore::RenderListBox::updateFromElement):
  10530. * rendering/RenderTextControl.cpp:
  10531. (WebCore::RenderTextControl::getAvgCharWidth):
  10532. 2011-05-17 Jeremy Noble <jer.noble@apple.com>
  10533. Reviewed by Darin Adler.
  10534. Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
  10535. https://bugs.webkit.org/show_bug.cgi?id=60997
  10536. Tests: fullscreen/full-screen-remove-ancestor.html
  10537. fullscreen/full-screen-remove-children.html
  10538. fullscreen/full-screen-remove.html
  10539. * dom/Document.cpp:
  10540. (WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document
  10541. make sure to message the documentElement() as well.
  10542. (WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.
  10543. 2011-05-17 Yuta Kitamura <yutak@chromium.org>
  10544. Reviewed by Kent Tamura.
  10545. WebSocket: Add CLOSING state
  10546. https://bugs.webkit.org/show_bug.cgi?id=60878
  10547. No new tests are added because there is no change in functionality.
  10548. * platform/network/SocketStreamHandleBase.h:
  10549. * websockets/WebSocket.h:
  10550. * websockets/WebSocket.idl:
  10551. 2011-05-16 MORITA Hajime <morrita@google.com>
  10552. Reviewed by Dimitri Glazkov.
  10553. [Refactoring] ShadowContentElement should be part of dom/
  10554. https://bugs.webkit.org/show_bug.cgi?id=59117
  10555. - Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
  10556. - Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
  10557. - Added ShadowContentElement.cpp
  10558. - Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}
  10559. No new tests, no behavior change.
  10560. * CMakeLists.txt:
  10561. * GNUmakefile.list.am:
  10562. * WebCore.gypi:
  10563. * WebCore.pro:
  10564. * WebCore.vcproj/WebCore.vcproj:
  10565. * WebCore.xcodeproj/project.pbxproj:
  10566. * dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
  10567. * dom/Node.h:
  10568. (WebCore::Node::forceReattach): Moved from static local function to share between classes.
  10569. * dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
  10570. (WebCore::ShadowContentElement::attach):
  10571. * dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
  10572. (WebCore::ShadowContentElement::ShadowContentElement):
  10573. (WebCore::ShadowContentElement::isShadowBoundary):
  10574. (WebCore::ShadowContentElement::rendererIsNeeded):
  10575. (WebCore::ShadowContentElement::createRenderer):
  10576. * dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
  10577. (WebCore::ShadowContentSelector::ShadowContentSelector):
  10578. (WebCore::ShadowContentSelector::~ShadowContentSelector):
  10579. (WebCore::ShadowContentSelector::attachChildrenFor):
  10580. * dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h.
  10581. (WebCore::ShadowContentSelector::shadowRoot):
  10582. (WebCore::ShadowContentSelector::activeElement):
  10583. (WebCore::ShadowContentSelector::currentInstance):
  10584. * dom/ShadowRoot.cpp:
  10585. (WebCore::ShadowRoot::recalcStyle):
  10586. * html/HTMLDetailsElement.cpp:
  10587. (WebCore::DetailsContentElement::DetailsContentElement):
  10588. (WebCore::DetailsSummaryElement::DetailsSummaryElement):
  10589. * html/HTMLSummaryElement.cpp:
  10590. (WebCore::SummaryContentElement::SummaryContentElement):
  10591. 2011-05-17 Cris Neckar <cdn@chromium.org>
  10592. Reviewed by Adam Barth.
  10593. Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
  10594. https://bugs.webkit.org/show_bug.cgi?id=61005
  10595. Test: http/tests/loading/nested_bad_objects.php
  10596. * html/HTMLObjectElement.cpp:
  10597. (WebCore::HTMLObjectElement::renderFallbackContent):
  10598. 2011-05-17 Chris Rogers <crogers@google.com>
  10599. Reviewed by Kenneth Russell.
  10600. Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
  10601. https://bugs.webkit.org/show_bug.cgi?id=60995
  10602. No new tests since audio API is not yet implemented.
  10603. * webaudio/AudioNode.cpp:
  10604. (WebCore::AudioNode::ref):
  10605. 2011-05-17 Brady Eidson <beidson@apple.com>
  10606. Reviewed by Darin Adler.
  10607. <rdar://problem/9366728> and https://webkit.org/b/60796
  10608. Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]
  10609. Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
  10610. This change has the following benefits:
  10611. - Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect
  10612. themselves, check these variables as often, or ASSERT them.
  10613. - ResourceLoader subclasses no longer have to call the base class ::didCancel
  10614. - ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the
  10615. cancellation is completed inside the last call.
  10616. No new tests - No change in behavior for previous tests, and new test would require API usage outside
  10617. the scope of DumpRenderTree.
  10618. * loader/ResourceLoader.cpp:
  10619. (WebCore::ResourceLoader::ResourceLoader):
  10620. (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work
  10621. except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
  10622. * loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().
  10623. Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:
  10624. * loader/MainResourceLoader.cpp:
  10625. (WebCore::MainResourceLoader::willCancel):
  10626. (WebCore::MainResourceLoader::didCancel):
  10627. * loader/MainResourceLoader.h:
  10628. Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
  10629. * loader/NetscapePlugInStreamLoader.cpp:
  10630. (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel()
  10631. (WebCore::NetscapePlugInStreamLoader::willCancel):
  10632. (WebCore::NetscapePlugInStreamLoader::didCancel):
  10633. * loader/NetscapePlugInStreamLoader.h:
  10634. Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
  10635. * loader/SubresourceLoader.cpp:
  10636. (WebCore::SubresourceLoader::willCancel):
  10637. (WebCore::SubresourceLoader::didCancel):
  10638. * loader/SubresourceLoader.h:
  10639. 2011-05-17 Nat Duca <nduca@chromium.org>
  10640. Reviewed by James Robinson.
  10641. [chromium] Always set layerRenderer, even on non-drawn-layers
  10642. https://bugs.webkit.org/show_bug.cgi?id=60977
  10643. This is a defensive fixe for crbug.com/82799, in which
  10644. a RenderLayer could not prepare itself because its owning layerImpl
  10645. had no associated layerRenderer. The underlying issue is that we
  10646. sometimes put renderSurfaces onto the list that won't actually render.
  10647. For now, the priority is to reduce fragility so that invisible layers
  10648. dont lead to crashers. We do this by being more agressive about
  10649. binding CCLayerImpls to the LayerRenderer, doing it all the time rather
  10650. than only when we think it will get rendered.
  10651. * platform/graphics/chromium/LayerRendererChromium.cpp:
  10652. (WebCore::LayerRendererChromium::paintLayerContents):
  10653. 2011-05-17 Anders Carlsson <andersca@apple.com>
  10654. Fix the clang build.
  10655. * rendering/RenderText.h:
  10656. (WebCore::RenderText::nodeAtPoint):
  10657. nodeAtPoint should take a const IntPoint reference.
  10658. 2011-05-17 Erik Arvidsson <arv@chromium.org>
  10659. Reviewed by Ryosuke Niwa.
  10660. document.activeElement doesn't point to the focused frame
  10661. https://bugs.webkit.org/show_bug.cgi?id=49509
  10662. This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.
  10663. Test: fast/dom/HTMLDocument/active-element-frames.html
  10664. * html/HTMLDocument.cpp:
  10665. (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.
  10666. 2011-05-17 Emil A Eklund <eae@chromium.org>
  10667. Reviewed by Eric Seidel.
  10668. Change nodeAtPoint to take IntPoint instead of int x, int y
  10669. https://bugs.webkit.org/show_bug.cgi?id=60663
  10670. Change nodeAtPoint to take a single const IntPoint& instead of a pair of
  10671. ints for the location.
  10672. Covered by existing tests.
  10673. * platform/graphics/FloatPoint.h:
  10674. (WebCore::flooredIntPoint):
  10675. * rendering/EllipsisBox.cpp:
  10676. (WebCore::EllipsisBox::nodeAtPoint):
  10677. * rendering/EllipsisBox.h:
  10678. * rendering/InlineBox.cpp:
  10679. (WebCore::InlineBox::nodeAtPoint):
  10680. * rendering/InlineBox.h:
  10681. * rendering/InlineFlowBox.cpp:
  10682. (WebCore::InlineFlowBox::nodeAtPoint):
  10683. * rendering/InlineFlowBox.h:
  10684. * rendering/InlineTextBox.cpp:
  10685. (WebCore::InlineTextBox::nodeAtPoint):
  10686. * rendering/InlineTextBox.h:
  10687. * rendering/RenderBlock.cpp:
  10688. (WebCore::RenderBlock::nodeAtPoint):
  10689. (WebCore::RenderBlock::hitTestContents):
  10690. * rendering/RenderBlock.h:
  10691. * rendering/RenderBox.cpp:
  10692. (WebCore::RenderBox::nodeAtPoint):
  10693. * rendering/RenderBox.h:
  10694. * rendering/RenderFrameSet.cpp:
  10695. (WebCore::RenderFrameSet::nodeAtPoint):
  10696. * rendering/RenderFrameSet.h:
  10697. * rendering/RenderImage.cpp:
  10698. (WebCore::RenderImage::nodeAtPoint):
  10699. * rendering/RenderImage.h:
  10700. * rendering/RenderInline.cpp:
  10701. (WebCore::RenderInline::nodeAtPoint):
  10702. * rendering/RenderInline.h:
  10703. * rendering/RenderLineBoxList.cpp:
  10704. (WebCore::RenderLineBoxList::hitTest):
  10705. * rendering/RenderListBox.cpp:
  10706. (WebCore::RenderListBox::nodeAtPoint):
  10707. * rendering/RenderListBox.h:
  10708. * rendering/RenderObject.cpp:
  10709. (WebCore::RenderObject::hitTest):
  10710. (WebCore::RenderObject::nodeAtPoint):
  10711. * rendering/RenderObject.h:
  10712. * rendering/RenderTable.cpp:
  10713. (WebCore::RenderTable::nodeAtPoint):
  10714. * rendering/RenderTable.h:
  10715. * rendering/RenderTableRow.cpp:
  10716. (WebCore::RenderTableRow::nodeAtPoint):
  10717. * rendering/RenderTableRow.h:
  10718. * rendering/RenderTableSection.cpp:
  10719. (WebCore::RenderTableSection::nodeAtPoint):
  10720. * rendering/RenderTableSection.h:
  10721. * rendering/RenderText.h:
  10722. (WebCore::RenderText::nodeAtPoint):
  10723. * rendering/RenderTextControlMultiLine.cpp:
  10724. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  10725. * rendering/RenderTextControlMultiLine.h:
  10726. * rendering/RenderTextControlSingleLine.cpp:
  10727. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  10728. * rendering/RenderTextControlSingleLine.h:
  10729. * rendering/RenderWidget.cpp:
  10730. (WebCore::RenderWidget::nodeAtPoint):
  10731. * rendering/RenderWidget.h:
  10732. * rendering/RootInlineBox.cpp:
  10733. (WebCore::RootInlineBox::nodeAtPoint):
  10734. * rendering/RootInlineBox.h:
  10735. * rendering/svg/RenderSVGForeignObject.cpp:
  10736. (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
  10737. (WebCore::RenderSVGForeignObject::nodeAtPoint):
  10738. * rendering/svg/RenderSVGForeignObject.h:
  10739. * rendering/svg/RenderSVGModelObject.cpp:
  10740. (WebCore::RenderSVGModelObject::nodeAtPoint):
  10741. * rendering/svg/RenderSVGModelObject.h:
  10742. * rendering/svg/RenderSVGRoot.cpp:
  10743. (WebCore::RenderSVGRoot::nodeAtPoint):
  10744. * rendering/svg/RenderSVGRoot.h:
  10745. * rendering/svg/RenderSVGText.cpp:
  10746. (WebCore::RenderSVGText::nodeAtFloatPoint):
  10747. (WebCore::RenderSVGText::nodeAtPoint):
  10748. * rendering/svg/RenderSVGText.h:
  10749. 2011-05-17 Andrew Wilson <atwilson@chromium.org>
  10750. Unreviewed, rolling out r86647.
  10751. http://trac.webkit.org/changeset/86647
  10752. https://bugs.webkit.org/show_bug.cgi?id=56814
  10753. Broke tests downstream in Chromium
  10754. * dom/DocumentMarker.h:
  10755. (WebCore::DocumentMarker::operator==):
  10756. (WebCore::DocumentMarker::operator!=):
  10757. * dom/DocumentMarkerController.cpp:
  10758. (WebCore::DocumentMarkerController::addMarker):
  10759. (WebCore::DocumentMarkerController::copyMarkers):
  10760. (WebCore::DocumentMarkerController::removeMarkers):
  10761. (WebCore::DocumentMarkerController::markerContainingPoint):
  10762. (WebCore::DocumentMarkerController::markersInRange):
  10763. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  10764. (WebCore::DocumentMarkerController::removeMarkersFromList):
  10765. (WebCore::DocumentMarkerController::repaintMarkers):
  10766. (WebCore::DocumentMarkerController::shiftMarkers):
  10767. (WebCore::DocumentMarkerController::setMarkersActive):
  10768. (WebCore::DocumentMarkerController::hasMarkers):
  10769. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  10770. (WebCore::DocumentMarkerController::showMarkers):
  10771. * dom/DocumentMarkerController.h:
  10772. * editing/CompositeEditCommand.cpp:
  10773. (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  10774. * editing/DeleteSelectionCommand.cpp:
  10775. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  10776. * editing/Editor.cpp:
  10777. (WebCore::Editor::selectionStartHasMarkerFor):
  10778. * editing/SpellingCorrectionController.cpp:
  10779. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  10780. * editing/SpellingCorrectionController.h:
  10781. (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  10782. * rendering/HitTestResult.cpp:
  10783. (WebCore::HitTestResult::spellingToolTip):
  10784. (WebCore::HitTestResult::replacedString):
  10785. * rendering/InlineTextBox.cpp:
  10786. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  10787. (WebCore::InlineTextBox::paintTextMatchMarker):
  10788. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  10789. (WebCore::InlineTextBox::paintDocumentMarkers):
  10790. * rendering/svg/SVGInlineFlowBox.cpp:
  10791. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  10792. 2011-05-17 Andrew Wilson <atwilson@chromium.org>
  10793. Unreviewed, rolling out r86656.
  10794. http://trac.webkit.org/changeset/86656
  10795. Broke tests downstream in Chromium
  10796. * editing/SpellingCorrectionController.cpp:
  10797. (WebCore::markersHaveIdenticalDescription):
  10798. (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  10799. (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  10800. 2011-05-17 Yufeng Shen <miletus@chromium.org>
  10801. Reviewed by Darin Fisher.
  10802. Make WebKit expose extra touch information
  10803. https://bugs.webkit.org/show_bug.cgi?id=59030
  10804. * dom/Document.cpp:
  10805. (WebCore::Document::createTouch):
  10806. * dom/Document.h:
  10807. * dom/Document.idl:
  10808. * dom/Touch.cpp:
  10809. (WebCore::Touch::Touch):
  10810. * dom/Touch.h:
  10811. (WebCore::Touch::create):
  10812. (WebCore::Touch::webkitRadiusX):
  10813. (WebCore::Touch::webkitRadiusY):
  10814. (WebCore::Touch::webkitRotationAngle):
  10815. * dom/Touch.idl:
  10816. * page/EventHandler.cpp:
  10817. (WebCore::EventHandler::handleTouchEvent):
  10818. * platform/PlatformTouchPoint.h:
  10819. (WebCore::PlatformTouchPoint::radiusX):
  10820. (WebCore::PlatformTouchPoint::radiusY):
  10821. (WebCore::PlatformTouchPoint::rotationAngle):
  10822. 2011-05-17 Eric Seidel <eric@webkit.org>
  10823. Reviewed by Ryosuke Niwa.
  10824. Add a LineLayoutState object to hold global state during line layout
  10825. https://bugs.webkit.org/show_bug.cgi?id=60113
  10826. Like LayoutState for layout(), LineLayoutState keeps track of global information
  10827. during an entire linebox tree layout pass (aka layoutInlineChildren).
  10828. For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
  10829. It's possible we should hold the useRepaintBounds bool as well as
  10830. the startLine and endLine RootInlineBox pointers.
  10831. No change in behavior, thus no tests.
  10832. * rendering/RenderBlock.cpp:
  10833. (WebCore::RenderBlock::layoutBlock):
  10834. * rendering/RenderBlock.h:
  10835. * rendering/RenderBlockLineLayout.cpp:
  10836. (WebCore::LineLayoutState::LineLayoutState):
  10837. (WebCore::LineLayoutState::markForFullLayout):
  10838. (WebCore::LineLayoutState::isFullLayout):
  10839. (WebCore::LineLayoutState::setRepaintRange):
  10840. (WebCore::LineLayoutState::updateRepaintRangeFromBox):
  10841. (WebCore::LineLayoutState::startLine):
  10842. (WebCore::LineLayoutState::endLine):
  10843. (WebCore::deleteLineRange):
  10844. (WebCore::RenderBlock::layoutRunsAndFloats):
  10845. (WebCore::RenderBlock::layoutInlineChildren):
  10846. (WebCore::RenderBlock::checkFloatsInCleanLine):
  10847. (WebCore::RenderBlock::determineStartPosition):
  10848. (WebCore::RenderBlock::determineEndPosition):
  10849. (WebCore::RenderBlock::matchedEndLine):
  10850. 2011-05-17 Andreas Kling <kling@webkit.org>
  10851. Reviewed by Kenneth Rohde Christiansen.
  10852. Area element doesn't update region when dynamically altered.
  10853. https://bugs.webkit.org/show_bug.cgi?id=54636
  10854. Recompute the clickable region after the "shape" or "coords" attribute
  10855. of an area element is changed.
  10856. Test: fast/images/imagemap-dynamic-area-updates.html
  10857. * html/HTMLAreaElement.cpp:
  10858. (WebCore::HTMLAreaElement::parseMappedAttribute):
  10859. (WebCore::HTMLAreaElement::invalidateCachedRegion):
  10860. * html/HTMLAreaElement.h:
  10861. 2011-05-09 Luiz Agostini <luiz.agostini@openbossa.org>
  10862. Reviewed by Kenneth Rohde Christiansen.
  10863. [Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
  10864. https://bugs.webkit.org/show_bug.cgi?id=60440
  10865. Makes sure that the HTTP headers Content-type and Content-length are not included in
  10866. the requests that do not have any content.
  10867. Tests: http/tests/navigation/post-301-response.html
  10868. http/tests/navigation/post-302-response.html
  10869. http/tests/navigation/post-303-response.html
  10870. http/tests/navigation/post-307-response.html
  10871. * platform/network/qt/QNetworkReplyHandler.cpp:
  10872. (WebCore::QNetworkReplyHandler::sendNetworkRequest):
  10873. 2011-05-17 Andreas Kling <kling@webkit.org>
  10874. Reviewed by Benjamin Poulain.
  10875. [Qt] GraphicsLayerQtImpl: Remove an unused variable.
  10876. * platform/graphics/qt/GraphicsLayerQt.cpp:
  10877. (WebCore::GraphicsLayerQtImpl::paint):
  10878. 2011-05-17 Pavel Feldman <pfeldman@google.com>
  10879. Reviewed by Yury Semikhatsky.
  10880. Web Inspector: navigating from elements panel does not show source view.
  10881. https://bugs.webkit.org/show_bug.cgi?id=60970
  10882. * inspector/front-end/TextViewer.js:
  10883. (WebInspector.TextViewer.prototype.highlightLine):
  10884. (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
  10885. 2011-05-17 Sam Magnuson <smagnuson@netflix.com>
  10886. Reviewed by Kenneth Rohde Christiansen.
  10887. [Qt] Node that have both an opacity and a transform animation on them seem not to fire.
  10888. https://bugs.webkit.org/show_bug.cgi?id=40841
  10889. Test: compositing/animation/busy-indicator.html
  10890. * platform/graphics/qt/GraphicsLayerQt.cpp:
  10891. (WebCore::GraphicsLayerQtImpl::recache):
  10892. (WebCore::GraphicsLayerQtImpl::flushChanges):
  10893. (WebCore::GraphicsLayerQt::setContentsToImage):
  10894. (WebCore::TransformAnimationQt::getAnimatedProperty):
  10895. (WebCore::OpacityAnimationQt::getAnimatedProperty):
  10896. (WebCore::GraphicsLayerQt::addAnimation):
  10897. 2011-05-17 Grace Kloba <klobag@chromium.org>
  10898. Reviewed by Kenneth Russell.
  10899. GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
  10900. https://bugs.webkit.org/show_bug.cgi?id=60965
  10901. * platform/graphics/skia/GraphicsContext3DSkia.cpp:
  10902. (WebCore::GraphicsContext3D::getImageData):
  10903. 2011-05-17 Alexander Pavlov <apavlov@chromium.org>
  10904. Reviewed by Yury Semikhatsky.
  10905. Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
  10906. https://bugs.webkit.org/show_bug.cgi?id=60962
  10907. * inspector/front-end/ElementsPanel.js:
  10908. (WebInspector.ElementsPanel.prototype.updateStyles):
  10909. 2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
  10910. Unreviewed, rolling out r86660.
  10911. http://trac.webkit.org/changeset/86660
  10912. https://bugs.webkit.org/show_bug.cgi?id=60958
  10913. broke search in console panel (Requested by podivilov on
  10914. #webkit).
  10915. * inspector/front-end/ConsoleView.js:
  10916. (WebInspector.ConsoleView.prototype.show):
  10917. (WebInspector.ConsoleView.prototype.afterShow):
  10918. (WebInspector.ConsoleView.prototype.hide):
  10919. (WebInspector.ConsoleView.prototype.addMessage):
  10920. (WebInspector.ConsoleView.prototype.clearMessages):
  10921. * inspector/front-end/DebuggerPresentationModel.js:
  10922. (WebInspector.DebuggerPresentationModel):
  10923. * inspector/front-end/Drawer.js:
  10924. (WebInspector.Drawer.prototype.set visibleView):
  10925. (WebInspector.Drawer.prototype.show.animationFinished):
  10926. (WebInspector.Drawer.prototype.show):
  10927. * inspector/front-end/Panel.js:
  10928. (WebInspector.Panel):
  10929. * inspector/front-end/ResourceTreeModel.js:
  10930. (WebInspector.ResourceTreeModel):
  10931. * inspector/front-end/inspector.html:
  10932. * inspector/front-end/inspector.js:
  10933. (WebInspector._createPanels):
  10934. 2011-05-17 Alexis Menard <alexis.menard@openbossa.org>
  10935. Unreviewed warning fix introduced by r86377.
  10936. * rendering/RenderFieldset.cpp:
  10937. (WebCore::RenderFieldset::paintMask):
  10938. 2011-05-17 Yuta Kitamura <yutak@chromium.org>
  10939. Reviewed by Kent Tamura.
  10940. WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
  10941. https://bugs.webkit.org/show_bug.cgi?id=60945
  10942. Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
  10943. move these definitions into .cpp in order to allow further modifications in this class.
  10944. No new tests, as this is just refactoring.
  10945. * CMakeLists.txt:
  10946. * GNUmakefile.list.am:
  10947. * WebCore.gypi:
  10948. * WebCore.pro:
  10949. * WebCore.vcproj/WebCore.vcproj:
  10950. * WebCore.xcodeproj/project.pbxproj:
  10951. * websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added.
  10952. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
  10953. (WebCore::ThreadableWebSocketChannelClientWrapper::create):
  10954. (WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone):
  10955. (WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone):
  10956. (WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone):
  10957. (WebCore::ThreadableWebSocketChannelClientWrapper::sent):
  10958. (WebCore::ThreadableWebSocketChannelClientWrapper::setSent):
  10959. (WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount):
  10960. (WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount):
  10961. (WebCore::ThreadableWebSocketChannelClientWrapper::clearClient):
  10962. (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
  10963. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
  10964. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  10965. (WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
  10966. (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
  10967. (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
  10968. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  10969. 2011-05-17 Andreas Kling <andreas.kling@nokia.com>
  10970. Reviewed by Kenneth Rohde Christiansen.
  10971. [Qt] Support shadowed text in fast font path.
  10972. https://bugs.webkit.org/show_bug.cgi?id=60462
  10973. * platform/graphics/Font.cpp:
  10974. (WebCore::Font::drawText): Remove complex path shortcut for shadowed text.
  10975. * platform/graphics/qt/FontQt.cpp:
  10976. (WebCore::Font::drawGlyphs): Paint shadows for simple text.
  10977. 2011-05-17 Andreas Kling <kling@webkit.org>
  10978. Reviewed by Kenneth Rohde Christiansen.
  10979. [Qt] Construct GraphicsLayerQtImpl::State with correct values.
  10980. https://bugs.webkit.org/show_bug.cgi?id=60902
  10981. The GraphicsLayerQtImpl initial state should match the initial values
  10982. of the corresponding GraphicsLayer flags.
  10983. * platform/graphics/qt/GraphicsLayerQt.cpp:
  10984. (WebCore::GraphicsLayerQtImpl::State::State):
  10985. 2011-05-12 Hans Wennborg <hans@chromium.org>
  10986. Reviewed by Steve Block.
  10987. IndexedDB: Index population should ignore records without key for index
  10988. https://bugs.webkit.org/show_bug.cgi?id=60697
  10989. When populating a new index, records which do not have a key on the
  10990. index's key path should be ignored.
  10991. * storage/IDBObjectStoreBackendImpl.cpp:
  10992. 2011-05-17 Young Han Lee <joybro@company100.net>
  10993. Reviewed by Csaba Osztrogonác.
  10994. [Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
  10995. https://bugs.webkit.org/show_bug.cgi?id=60947
  10996. No new tests. Build fix.
  10997. * platform/graphics/qt/TextureMapperQt.cpp:
  10998. (WebCore::TextureMapper::create):
  10999. * platform/graphics/qt/TextureMapperQt.h:
  11000. (WebCore::TextureMapperQt::create):
  11001. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  11002. (WebCore::GraphicsLayer::create):
  11003. 2011-05-17 Alexander Pavlov <apavlov@chromium.org>
  11004. Reviewed by Yury Semikhatsky.
  11005. Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
  11006. https://bugs.webkit.org/show_bug.cgi?id=60890
  11007. * inspector/front-end/MetricsSidebarPane.js:
  11008. (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
  11009. * inspector/front-end/StylesSidebarPane.js:
  11010. (WebInspector.StylesSidebarPane.alteredFloatNumber):
  11011. (WebInspector.StylePropertyTreeElement.prototype):
  11012. 2011-05-17 Pavel Podivilov <podivilov@chromium.org>
  11013. Reviewed by Yury Semikhatsky.
  11014. Web Inspector: merge ConsoleView into ConsolePanel.
  11015. https://bugs.webkit.org/show_bug.cgi?id=54670
  11016. Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
  11017. will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.
  11018. * inspector/front-end/ConsoleView.js:
  11019. (WebInspector.ConsolePanel.prototype.get toolbarItemLabel):
  11020. (WebInspector.ConsolePanel.prototype.show):
  11021. (WebInspector.ConsolePanel.prototype.hide):
  11022. (WebInspector.ConsolePanel.prototype.showInDrawer):
  11023. (WebInspector.ConsolePanel.prototype.afterShowInDrawer):
  11024. (WebInspector.ConsolePanel.prototype.hideInDrawer):
  11025. (WebInspector.ConsolePanel.prototype.addMessage):
  11026. (WebInspector.ConsolePanel.prototype.clearMessages):
  11027. * inspector/front-end/DebuggerPresentationModel.js:
  11028. (WebInspector.DebuggerPresentationModel):
  11029. * inspector/front-end/Drawer.js:
  11030. (WebInspector.Drawer.prototype.set visibleView):
  11031. (WebInspector.Drawer.prototype.show.animationFinished):
  11032. (WebInspector.Drawer.prototype.show):
  11033. * inspector/front-end/Panel.js:
  11034. (WebInspector.Panel):
  11035. * inspector/front-end/ResourceTreeModel.js:
  11036. (WebInspector.ResourceTreeModel):
  11037. * inspector/front-end/inspector.html:
  11038. * inspector/front-end/inspector.js:
  11039. (WebInspector._createPanels):
  11040. 2011-05-16 Yuta Kitamura <yutak@chromium.org>
  11041. Reviewed by Kent Tamura.
  11042. WebSocket: WebSocketHandshake prints a carriage return to console
  11043. https://bugs.webkit.org/show_bug.cgi?id=60880
  11044. * websockets/WebSocketHandshake.cpp:
  11045. (WebCore::WebSocketHandshake::readStatusLine):
  11046. WebSocketHandshake should not print a carriage return to console. To fix this,
  11047. we first check whether the status line ends with CRLF. After that,
  11048. we can print the first (lineLength - 2) characters of the status line
  11049. which do not contain a carriage return.
  11050. 2011-05-16 MORITA Hajime <morrita@google.com>
  11051. Unreviewed build fix for r86647, which broke SUPPORT_AUTOCORRECTION_PANEL.
  11052. * editing/SpellingCorrectionController.cpp:
  11053. (WebCore::markersHaveIdenticalDescription):
  11054. (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  11055. (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  11056. 2011-05-16 Kent Tamura <tkent@chromium.org>
  11057. Fix Leopard build.
  11058. * html/HTMLInputElement.cpp:
  11059. (WebCore::HTMLInputElement::stepUpFromRenderer): Use double instead of int.
  11060. 2011-05-16 James Robinson <jamesr@chromium.org>
  11061. Reviewed by Kenneth Russell.
  11062. [chromium] Decouple LayerChromium/CCLayerImpl trees
  11063. https://bugs.webkit.org/show_bug.cgi?id=58830
  11064. Makes the CCLayerImpl tree self-hosting and provides an explicit step
  11065. to synchronize the LayerChromium tree to the CCLayerImpl tree.
  11066. Tested by compositing/ layout tests and by unit tests in WebKit/chromium.
  11067. * WebCore.gypi:
  11068. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  11069. (WebCore::CanvasLayerChromium::createCCLayerImpl):
  11070. * platform/graphics/chromium/LayerChromium.cpp:
  11071. (WebCore::LayerChromium::LayerChromium):
  11072. (WebCore::LayerChromium::~LayerChromium):
  11073. (WebCore::LayerChromium::cleanupResources):
  11074. (WebCore::LayerChromium::dumpLayer):
  11075. (WebCore::LayerChromium::dumpLayerProperties):
  11076. (WebCore::LayerChromium::createCCLayerImpl):
  11077. (WebCore::LayerChromium::ccLayerImpl):
  11078. * platform/graphics/chromium/LayerChromium.h:
  11079. (WebCore::LayerChromium::id):
  11080. (WebCore::LayerChromium::setCCLayerImpl):
  11081. * platform/graphics/chromium/LayerRendererChromium.cpp:
  11082. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  11083. (WebCore::LayerRendererChromium::updateLayers):
  11084. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  11085. (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  11086. * platform/graphics/chromium/LayerRendererChromium.h:
  11087. * platform/graphics/chromium/PluginLayerChromium.cpp:
  11088. (WebCore::PluginLayerChromium::createCCLayerImpl):
  11089. * platform/graphics/chromium/TreeSynchronizer.cpp: Added.
  11090. (WebCore::TreeSynchronizer::addCCLayerImplsToMapRecursive):
  11091. (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
  11092. (WebCore::TreeSynchronizer::synchronizeTrees):
  11093. * platform/graphics/chromium/TreeSynchronizer.h:
  11094. * platform/graphics/chromium/VideoLayerChromium.cpp:
  11095. (WebCore::VideoLayerChromium::createCCLayerImpl):
  11096. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  11097. (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  11098. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  11099. (WebCore::CCCanvasLayerImpl::create):
  11100. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  11101. (WebCore::CCLayerImpl::CCLayerImpl):
  11102. (WebCore::CCLayerImpl::addChild):
  11103. (WebCore::CCLayerImpl::removeFromParent):
  11104. (WebCore::CCLayerImpl::removeAllChildren):
  11105. (WebCore::CCLayerImpl::clearChildList):
  11106. (WebCore::CCLayerImpl::descendantsDrawsContent):
  11107. (WebCore::CCLayerImpl::drawsContent):
  11108. (WebCore::CCLayerImpl::updateCompositorResources):
  11109. * platform/graphics/chromium/cc/CCLayerImpl.h:
  11110. (WebCore::CCLayerImpl::create):
  11111. (WebCore::CCLayerImpl::parent):
  11112. (WebCore::CCLayerImpl::children):
  11113. (WebCore::CCLayerImpl::setMaskLayer):
  11114. (WebCore::CCLayerImpl::maskLayer):
  11115. (WebCore::CCLayerImpl::setReplicaLayer):
  11116. (WebCore::CCLayerImpl::replicaLayer):
  11117. (WebCore::CCLayerImpl::id):
  11118. (WebCore::CCLayerImpl::owner):
  11119. (WebCore::CCLayerImpl::setParent):
  11120. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
  11121. (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
  11122. * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  11123. (WebCore::CCPluginLayerImpl::create):
  11124. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
  11125. (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
  11126. * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
  11127. (WebCore::CCVideoLayerImpl::create):
  11128. 2011-05-16 Naoki Takano <takano.naoki@gmail.com>
  11129. Reviewed by Kent Tamura.
  11130. HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
  11131. https://bugs.webkit.org/show_bug.cgi?id=60871
  11132. Test: fast/forms/input-stepup-stepdown-from-renderer.html
  11133. In number input type, if the value is not a number, including empty, the currect valued is assumed 0.
  11134. But we have to handle it separately from the case when the value is actuall "0".
  11135. * html/HTMLInputElement.cpp:
  11136. (WebCore::HTMLInputElement::stepUpFromRenderer): Added cliping for default value.
  11137. 2011-05-16 Adam Barth <abarth@webkit.org>
  11138. Reviewed by Eric Seidel.
  11139. Remove bogus ASSERT in Document::setCompatibilityMode
  11140. https://bugs.webkit.org/show_bug.cgi?id=60935
  11141. The ASSERT is invalid when the parser is in the initial state and the
  11142. document is non-empty, which is strange but not impossible.
  11143. Test: fast/parser/append-child-followed-by-document-write.html
  11144. * dom/Document.cpp:
  11145. (WebCore::Document::setCompatibilityMode):
  11146. 2011-05-16 MORITA Hajime <morrita@google.com>
  11147. Reviewed by Tony Chang.
  11148. [Refactoring] Member variables of DocumentMarker should be encapsulated.
  11149. https://bugs.webkit.org/show_bug.cgi?id=56814
  11150. - Moved DocumentMarker's member variables to private and added getters for them.
  11151. - Added DocumentMarker setters and constructors, which contain assertions against m_type values
  11152. because description and activeMatch are used with specific type of MarkerType.
  11153. - Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController because
  11154. it accesses DocumentMarker internals.
  11155. - Moved a version of DMC::addMarker() to private and add alternatives that hide
  11156. internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  11157. * dom/DocumentMarker.h:
  11158. (WebCore::DocumentMarker::type):
  11159. (WebCore::DocumentMarker::startOffset):
  11160. (WebCore::DocumentMarker::endOffset):
  11161. (WebCore::DocumentMarker::description):
  11162. (WebCore::DocumentMarker::hasDescription):
  11163. (WebCore::DocumentMarker::activeMatch):
  11164. (WebCore::DocumentMarker::clearDescription):
  11165. (WebCore::DocumentMarker::setStartOffset):
  11166. (WebCore::DocumentMarker::setEndOffset):
  11167. (WebCore::DocumentMarker::operator==):
  11168. (WebCore::DocumentMarker::DocumentMarker):
  11169. (WebCore::DocumentMarker::shiftOffsets):
  11170. (WebCore::DocumentMarker::setActiveMatch):
  11171. * dom/DocumentMarkerController.cpp:
  11172. (WebCore::DocumentMarkerController::addMarker):
  11173. (WebCore::DocumentMarkerController::addTextMatchMarker):
  11174. (WebCore::DocumentMarkerController::copyMarkers):
  11175. (WebCore::DocumentMarkerController::removeMarkers):
  11176. (WebCore::DocumentMarkerController::markerContainingPoint):
  11177. (WebCore::DocumentMarkerController::markersInRange):
  11178. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  11179. (WebCore::DocumentMarkerController::removeMarkersFromList):
  11180. (WebCore::DocumentMarkerController::repaintMarkers):
  11181. (WebCore::DocumentMarkerController::shiftMarkers):
  11182. (WebCore::DocumentMarkerController::setMarkersActive):
  11183. (WebCore::DocumentMarkerController::hasMarkers):
  11184. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  11185. (WebCore::DocumentMarkerController::showMarkers):
  11186. * dom/DocumentMarkerController.h:
  11187. * editing/CompositeEditCommand.cpp:
  11188. (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  11189. * editing/DeleteSelectionCommand.cpp:
  11190. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  11191. * editing/Editor.cpp:
  11192. (WebCore::Editor::selectionStartHasMarkerFor):
  11193. * editing/SpellingCorrectionController.cpp:
  11194. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  11195. * editing/SpellingCorrectionController.h:
  11196. (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  11197. * rendering/HitTestResult.cpp:
  11198. (WebCore::HitTestResult::spellingToolTip):
  11199. (WebCore::HitTestResult::replacedString):
  11200. * rendering/InlineTextBox.cpp:
  11201. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  11202. (WebCore::InlineTextBox::paintTextMatchMarker):
  11203. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  11204. (WebCore::InlineTextBox::paintDocumentMarkers):
  11205. * rendering/svg/SVGInlineFlowBox.cpp:
  11206. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  11207. 2011-05-16 Martin Robinson <mrobinson@igalia.com>
  11208. Fix the Cairo build for older versions of GTK+.
  11209. * platform/gtk/GtkWidgetBackingStoreX11.cpp: Include GtkVersioning.h to
  11210. satisfy older versions of GTK+ 2.x.
  11211. 2011-05-16 Ian Henderson <ianh@apple.com>
  11212. Reviewed by Joseph Pecoraro.
  11213. Page::goToItem doesn't work while loading is deferred
  11214. https://bugs.webkit.org/show_bug.cgi?id=60412
  11215. If goToItem is called while loading is deferred, save the arguments
  11216. and try again later instead of doing nothing.
  11217. Test: loader/navigation-while-deferring-loads.html
  11218. * loader/FrameLoader.cpp:
  11219. (WebCore::FrameLoader::setDefersLoading):
  11220. Pipe the "defersLoading" state into HistoryController.
  11221. * loader/HistoryController.cpp:
  11222. (WebCore::HistoryController::HistoryController):
  11223. (WebCore::HistoryController::goToItem):
  11224. Save the HistoryItem and FrameLoadType if loading is deferred.
  11225. (WebCore::HistoryController::setDefersLoading):
  11226. If we have a saved HistoryItem after resuming, try going to it.
  11227. * loader/HistoryController.h:
  11228. * page/Page.cpp:
  11229. (WebCore::Page::goToItem):
  11230. No longer bail early if loading is deferred, since HistoryController
  11231. now handles this case.
  11232. 2011-05-16 Andrew Wilson <atwilson@chromium.org>
  11233. Unreviewed, rolling out r86625.
  11234. http://trac.webkit.org/changeset/86625
  11235. https://bugs.webkit.org/show_bug.cgi?id=60719
  11236. Caused failed assertion on Chromium gpu canary bots
  11237. * WebCore.gypi:
  11238. * platform/chromium/TraceEvent.h:
  11239. * platform/graphics/chromium/ContentLayerChromium.cpp:
  11240. (WebCore::ContentLayerChromium::create):
  11241. (WebCore::ContentLayerChromium::ContentLayerChromium):
  11242. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  11243. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  11244. (WebCore::ContentLayerChromium::setLayerRenderer):
  11245. (WebCore::ContentLayerChromium::createTilerIfNeeded):
  11246. (WebCore::ContentLayerChromium::updateCompositorResources):
  11247. * platform/graphics/chromium/ContentLayerChromium.h:
  11248. (WebCore::ContentLayerChromium::drawsContent):
  11249. * platform/graphics/chromium/ImageLayerChromium.cpp:
  11250. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  11251. (WebCore::ImageLayerChromium::updateCompositorResources):
  11252. * platform/graphics/chromium/ImageLayerChromium.h:
  11253. * platform/graphics/chromium/LayerPainterChromium.h: Removed.
  11254. * platform/graphics/chromium/LayerRendererChromium.cpp:
  11255. (WebCore::LayerRendererChromium::create):
  11256. (WebCore::LayerRendererChromium::LayerRendererChromium):
  11257. (WebCore::LayerRendererChromium::updateRootLayerContents):
  11258. (WebCore::LayerRendererChromium::drawRootLayer):
  11259. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  11260. (WebCore::LayerRendererChromium::updateLayers):
  11261. * platform/graphics/chromium/LayerRendererChromium.h:
  11262. * platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
  11263. * platform/graphics/chromium/LayerTextureSubImage.h: Removed.
  11264. * platform/graphics/chromium/LayerTextureUpdater.h: Removed.
  11265. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
  11266. * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  11267. * platform/graphics/chromium/LayerTilerChromium.cpp:
  11268. (WebCore::LayerTilerChromium::create):
  11269. (WebCore::LayerTilerChromium::LayerTilerChromium):
  11270. (WebCore::LayerTilerChromium::setLayerRenderer):
  11271. (WebCore::LayerTilerChromium::setTileSize):
  11272. (WebCore::LayerTilerChromium::update):
  11273. (WebCore::LayerTilerChromium::uploadCanvas):
  11274. (WebCore::LayerTilerChromium::updateFromPixels):
  11275. (WebCore::LayerTilerChromium::draw):
  11276. * platform/graphics/chromium/LayerTilerChromium.h:
  11277. (WebCore::LayerTilerChromium::Tile::Tile):
  11278. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  11279. (WebCore::CCHeadsUpDisplay::draw):
  11280. 2011-05-16 Antti Koivisto <antti@apple.com>
  11281. Reviewed by Dave Kilzer.
  11282. https://bugs.webkit.org/show_bug.cgi?id=60927
  11283. fastCheckSelector() does not inline correctly in all cases
  11284. Use anonymous namespace instead of static qualifier to get internal linkage.
  11285. Use functions as template arguments instead of classes.
  11286. * css/CSSStyleSelector.cpp:
  11287. (WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
  11288. 2011-05-16 Chris Rogers <crogers@google.com>
  11289. Unreviewed build fix.
  11290. Just return "nullptr" to fix compile errors
  11291. https://bugs.webkit.org/show_bug.cgi?id=60932
  11292. * platform/audio/mac/AudioBusMac.mm:
  11293. (WebCore::AudioBus::loadPlatformResource):
  11294. * platform/audio/mac/AudioFileReaderMac.cpp:
  11295. (WebCore::AudioFileReader::createBus):
  11296. 2011-05-16 Emil A Eklund <eae@chromium.org>
  11297. Reviewed by Eric Seidel.
  11298. Replace docTop/Right/Bottom/Left/Width/Height with documentRect
  11299. https://bugs.webkit.org/show_bug.cgi?id=60743
  11300. Change RenderView::documentRect to compute rect once rather than four times.
  11301. Replace all uses of docTop/Right/Bottom/Left/Width/Height with documentRect to
  11302. simplify the code and reduce complexity.
  11303. Covered by existing tests.
  11304. * WebCore.exp.in:
  11305. * page/FrameView.cpp:
  11306. (WebCore::FrameView::adjustViewSize):
  11307. (WebCore::FrameView::forceLayoutForPagination):
  11308. * page/PrintContext.cpp:
  11309. (WebCore::PrintContext::computePageRects):
  11310. * rendering/RenderBox.cpp:
  11311. (WebCore::RenderBox::paintRootBoxFillLayers):
  11312. * rendering/RenderLayerCompositor.cpp:
  11313. (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  11314. * rendering/RenderView.cpp:
  11315. (WebCore::RenderView::documentRect):
  11316. * rendering/RenderView.h:
  11317. 2011-05-16 Tony Chang <tony@chromium.org>
  11318. Reviewed by Adam Barth.
  11319. [chromium] shard V8DerivedSources into 19 files
  11320. https://bugs.webkit.org/show_bug.cgi?id=60926
  11321. This reduces the clobber build time by 4s on my machine. It helps
  11322. by making the slowest to compile V8DerivedSources faster (and thus
  11323. more parallelizable). With 8 files, the 3 slowest are 23s, 18s and
  11324. 10s. With 19 files, the 3 slowest are 16s, 10s, and 10s.
  11325. * WebCore.gyp/WebCore.gyp:
  11326. * storage/IDBObjectStore.h: Fix a missing include that was working
  11327. because a different .cpp file before it was including the header.
  11328. 2011-05-16 Chris Rogers <crogers@google.com>
  11329. Unreviewed build fix.
  11330. Fix web audio enabled mac port compile errors
  11331. https://bugs.webkit.org/show_bug.cgi?id=60930
  11332. * platform/audio/mac/AudioBusMac.mm:
  11333. (WebCore::AudioBus::loadPlatformResource):
  11334. * platform/audio/mac/AudioFileReaderMac.cpp:
  11335. (WebCore::AudioFileReader::createBus):
  11336. 2011-05-16 Eric Seidel <eric@webkit.org>
  11337. Reviewed by Adam Barth.
  11338. Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
  11339. https://bugs.webkit.org/show_bug.cgi?id=60925
  11340. I suspect this difference is really just papering over other bugs
  11341. but now that I finally understand the difference, I should at least
  11342. document it for others.
  11343. * rendering/RenderBlockLineLayout.cpp:
  11344. (WebCore::deleteLineRange):
  11345. (WebCore::RenderBlock::determineStartPosition):
  11346. 2011-05-16 Alok Priyadarshi <alokp@chromium.org>
  11347. Reviewed by James Robinson.
  11348. [chromium] Split canvas from LayerTilerChromium
  11349. https://bugs.webkit.org/show_bug.cgi?id=60719
  11350. LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
  11351. Also abstracted LayerTextureSubImage to upload texture pixels.
  11352. * WebCore.gypi:
  11353. * platform/chromium/TraceEvent.h:
  11354. * platform/graphics/chromium/ContentLayerChromium.cpp:
  11355. (WebCore::ContentLayerChromium::create):
  11356. (WebCore::ContentLayerChromium::ContentLayerChromium):
  11357. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  11358. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  11359. (WebCore::ContentLayerChromium::cleanupResources):
  11360. (WebCore::ContentLayerChromium::setLayerRenderer):
  11361. (WebCore::ContentLayerChromium::createTextureUpdater):
  11362. (WebCore::ContentLayerChromium::drawsContent):
  11363. (WebCore::ContentLayerChromium::createTilerIfNeeded):
  11364. (WebCore::ContentLayerChromium::updateCompositorResources):
  11365. * platform/graphics/chromium/ContentLayerChromium.h:
  11366. * platform/graphics/chromium/ImageLayerChromium.cpp:
  11367. (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
  11368. (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater):
  11369. (WebCore::ImageLayerTextureUpdater::orientation):
  11370. (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
  11371. (WebCore::ImageLayerTextureUpdater::updateTextureRect):
  11372. (WebCore::ImageLayerTextureUpdater::imageRect):
  11373. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  11374. (WebCore::ImageLayerChromium::updateCompositorResources):
  11375. (WebCore::ImageLayerChromium::createTextureUpdater):
  11376. * platform/graphics/chromium/ImageLayerChromium.h:
  11377. * platform/graphics/chromium/LayerPainterChromium.h: Added.
  11378. * platform/graphics/chromium/LayerRendererChromium.cpp:
  11379. (WebCore::LayerRendererChromium::create):
  11380. (WebCore::LayerRendererChromium::LayerRendererChromium):
  11381. (WebCore::LayerRendererChromium::updateRootLayerContents):
  11382. (WebCore::LayerRendererChromium::drawRootLayer):
  11383. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  11384. (WebCore::LayerRendererChromium::updateLayers):
  11385. * platform/graphics/chromium/LayerRendererChromium.h:
  11386. * platform/graphics/chromium/LayerTextureSubImage.cpp: Added.
  11387. (WebCore::LayerTextureSubImage::LayerTextureSubImage):
  11388. (WebCore::LayerTextureSubImage::~LayerTextureSubImage):
  11389. (WebCore::LayerTextureSubImage::setSubImageSize):
  11390. (WebCore::LayerTextureSubImage::upload):
  11391. (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
  11392. (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  11393. * platform/graphics/chromium/LayerTextureSubImage.h: Added.
  11394. * platform/graphics/chromium/LayerTextureUpdater.h: Added.
  11395. (WebCore::LayerTextureUpdater::LayerTextureUpdater):
  11396. (WebCore::LayerTextureUpdater::~LayerTextureUpdater):
  11397. (WebCore::LayerTextureUpdater::context):
  11398. * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added.
  11399. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
  11400. (WebCore::LayerTextureUpdaterCanvas::paintContents):
  11401. (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
  11402. (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
  11403. (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  11404. * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
  11405. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas):
  11406. (WebCore::LayerTextureUpdaterCanvas::contentRect):
  11407. (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap):
  11408. (WebCore::LayerTextureUpdaterBitmap::orientation):
  11409. * platform/graphics/chromium/LayerTilerChromium.cpp:
  11410. (WebCore::LayerTilerChromium::create):
  11411. (WebCore::LayerTilerChromium::LayerTilerChromium):
  11412. (WebCore::LayerTilerChromium::setTileSize):
  11413. (WebCore::LayerTilerChromium::prepareToUpdate):
  11414. (WebCore::LayerTilerChromium::updateRect):
  11415. (WebCore::LayerTilerChromium::draw):
  11416. * platform/graphics/chromium/LayerTilerChromium.h:
  11417. (WebCore::LayerTilerChromium::Tile::Tile):
  11418. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  11419. (WebCore::CCHeadsUpDisplay::draw):
  11420. 2011-05-16 Andrew Wilson <atwilson@chromium.org>
  11421. Unreviewed prospective build fix/workaround for chromium ARM compiler error.
  11422. * platform/graphics/GraphicsLayer.cpp:
  11423. (WebCore::GraphicsLayer::animationNameForTransition):
  11424. 2011-05-16 Martin Robinson <mrobinson@igalia.com>
  11425. Reviewed by Anders Carlsson.
  11426. [GTK] [WebKit2] Provide a fast version of the backing store for X11
  11427. https://bugs.webkit.org/show_bug.cgi?id=60912
  11428. No new tests. This will be covered by WebKit2 pixel tests.
  11429. * GNUmakefile.list.am: Added new GtkWidgetBackingStore source and header files.
  11430. * platform/gtk/GtkWidgetBackingStore.h: Added.
  11431. * platform/gtk/GtkWidgetBackingStoreCairo.cpp: Added this implementation of the backing
  11432. store that uses Cairo and has the same performance characteristics as the WebKit2 implementaiton.
  11433. * platform/gtk/GtkWidgetBackingStoreX11.cpp: Added this implementation of the backing
  11434. store that uses X11 directly and has better performance than the Cairo version.
  11435. 2011-05-16 Chris Rogers <crogers@google.com>
  11436. Reviewed by senorblanco@chromium.org.
  11437. Add DynamicsCompressorNode implementation
  11438. https://bugs.webkit.org/show_bug.cgi?id=60682
  11439. No new tests since audio API is not yet implemented.
  11440. * DerivedSources.make:
  11441. * WebCore.gypi:
  11442. * WebCore.xcodeproj/project.pbxproj:
  11443. * platform/audio/DynamicsCompressor.cpp: Added.
  11444. (WebCore::DynamicsCompressor::DynamicsCompressor):
  11445. (WebCore::DynamicsCompressor::initializeParameters):
  11446. (WebCore::DynamicsCompressor::parameterValue):
  11447. (WebCore::DynamicsCompressor::setEmphasisStageParameters):
  11448. (WebCore::DynamicsCompressor::setEmphasisParameters):
  11449. (WebCore::DynamicsCompressor::process):
  11450. (WebCore::DynamicsCompressor::reset):
  11451. * platform/audio/DynamicsCompressor.h: Added.
  11452. (WebCore::DynamicsCompressor::isStereo):
  11453. (WebCore::DynamicsCompressor::sampleRate):
  11454. (WebCore::DynamicsCompressor::nyquist):
  11455. * platform/audio/DynamicsCompressorKernel.cpp: Added.
  11456. (WebCore::saturate):
  11457. (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
  11458. (WebCore::DynamicsCompressorKernel::setPreDelayTime):
  11459. (WebCore::DynamicsCompressorKernel::process):
  11460. (WebCore::DynamicsCompressorKernel::reset):
  11461. * platform/audio/DynamicsCompressorKernel.h: Added.
  11462. (WebCore::DynamicsCompressorKernel::latencyFrames):
  11463. (WebCore::DynamicsCompressorKernel::sampleRate):
  11464. * platform/audio/ZeroPole.cpp: Added.
  11465. (WebCore::ZeroPole::process):
  11466. * platform/audio/ZeroPole.h: Added.
  11467. (WebCore::ZeroPole::ZeroPole):
  11468. (WebCore::ZeroPole::reset):
  11469. (WebCore::ZeroPole::setZero):
  11470. (WebCore::ZeroPole::setPole):
  11471. (WebCore::ZeroPole::zero):
  11472. (WebCore::ZeroPole::pole):
  11473. * webaudio/AudioContext.cpp:
  11474. (WebCore::AudioContext::createDynamicsCompressor):
  11475. * webaudio/AudioContext.h:
  11476. * webaudio/AudioContext.idl:
  11477. * webaudio/AudioNode.h:
  11478. * webaudio/DynamicsCompressorNode.cpp: Added.
  11479. (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
  11480. (WebCore::DynamicsCompressorNode::~DynamicsCompressorNode):
  11481. (WebCore::DynamicsCompressorNode::process):
  11482. (WebCore::DynamicsCompressorNode::reset):
  11483. (WebCore::DynamicsCompressorNode::initialize):
  11484. (WebCore::DynamicsCompressorNode::uninitialize):
  11485. * webaudio/DynamicsCompressorNode.h: Added.
  11486. (WebCore::DynamicsCompressorNode::create):
  11487. * webaudio/DynamicsCompressorNode.idl: Added.
  11488. 2011-05-16 Yuzo Fujishima <yuzo@google.com>
  11489. Reviewed by Antti Koivisto.
  11490. Fix for Bug 43704 - Web font is printed as blank if it is not cached
  11491. https://bugs.webkit.org/show_bug.cgi?id=43704
  11492. In setting printing, we should not validate resources already cached
  11493. for the document. If we do, web fonts used for screen are revalidated
  11494. and possiby reloaded. Then the fonts can be shown as blank on print.
  11495. This patch won't save the case where screen and print use different web
  11496. fonts. Nonetheless, this is an improvement.
  11497. No new tests because there seems to be no good way to test print images.
  11498. * editing/Editor.cpp:
  11499. (WebCore::Editor::paste): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  11500. * loader/cache/CachedResourceLoader.h:
  11501. (WebCore::ResourceCacheValidationSuppressor::ResourceCacheValidationSuppressor): RAII class for allowing/disallowing stale resources.
  11502. (WebCore::ResourceCacheValidationSuppressor::~ResourceCacheValidationSuppressor):
  11503. * page/DragController.cpp:
  11504. (WebCore::DragController::concludeEditDrag): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  11505. * page/Frame.cpp:
  11506. (WebCore::Frame::setPrinting): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
  11507. 2011-05-16 Dan Bernstein <mitz@apple.com>
  11508. Reviewed by Darin Adler.
  11509. <rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe mid-word
  11510. https://bugs.webkit.org/show_bug.cgi?id=60915
  11511. CFStringTokenizer’s kCFStringTokenizerUnitWord considers “Here’s” as two separate tokens.
  11512. Switching to CFStringTokenizer in r84750 was an attempt to address an issue with Japanese word
  11513. boundaries for searches with WebFindOptionsAtWordStarts, but it turned out to be insufficient,
  11514. and in r86387 the Japanese word issue was addressed independently of text boundaries, so just
  11515. revert r84750.
  11516. * platform/text/mac/TextBoundaries.mm:
  11517. (WebCore::findNextWordFromIndex):
  11518. 2011-05-16 David Kilzer <ddkilzer@apple.com>
  11519. <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
  11520. <rdar://problem/9446430>
  11521. Reviewed by Mark Rowe.
  11522. * Configurations/Base.xcconfig: Fixed typo.
  11523. 2011-05-16 Jon Lee <jonlee@apple.com>
  11524. Fix for broken regression tests. Adding null pointer check
  11525. * page/FrameView.cpp:
  11526. (WebCore::FrameView::didAddHorizontalScrollbar):
  11527. (WebCore::FrameView::willRemoveHorizontalScrollbar):
  11528. 2011-05-16 Adrienne Walker <enne@google.com>
  11529. Reviewed by James Robinson.
  11530. [chromium] Remove unused member variables from LayerRendererChromium
  11531. https://bugs.webkit.org/show_bug.cgi?id=60899
  11532. These should have been removed when tiling was enabled for root
  11533. layers.
  11534. * platform/graphics/chromium/LayerRendererChromium.h:
  11535. 2011-05-16 Andrew Wilson <atwilson@chromium.org>
  11536. Unreviewed, rolling out r86589.
  11537. http://trac.webkit.org/changeset/86589
  11538. https://bugs.webkit.org/show_bug.cgi?id=54670
  11539. Broke chromium inspector tests.
  11540. * inspector/front-end/ConsoleView.js:
  11541. (WebInspector.ConsoleView.prototype.show):
  11542. (WebInspector.ConsoleView.prototype.afterShow):
  11543. (WebInspector.ConsoleView.prototype.hide):
  11544. (WebInspector.ConsoleView.prototype.addMessage):
  11545. (WebInspector.ConsoleView.prototype.clearMessages):
  11546. * inspector/front-end/DebuggerPresentationModel.js:
  11547. (WebInspector.DebuggerPresentationModel):
  11548. * inspector/front-end/Drawer.js:
  11549. (WebInspector.Drawer.prototype.set visibleView):
  11550. (WebInspector.Drawer.prototype.show.animationFinished):
  11551. (WebInspector.Drawer.prototype.show):
  11552. * inspector/front-end/Panel.js:
  11553. (WebInspector.Panel):
  11554. * inspector/front-end/ResourceTreeModel.js:
  11555. (WebInspector.ResourceTreeModel):
  11556. * inspector/front-end/inspector.html:
  11557. * inspector/front-end/inspector.js:
  11558. (WebInspector._createPanels):
  11559. 2011-05-16 Brian Weinstein <bweinstein@apple.com>
  11560. Reviewed by Enrica Casucci.
  11561. REGRESSION (r86542): Dropping URL onto Desktop creates broken Internet Shortcut file.
  11562. r86477 fixed this bug by using latin1 as the CString's encoding instead of ascii, but r86542
  11563. undid this change.
  11564. Change it back to latin1 to fix the bug.
  11565. * platform/win/ClipboardWin.cpp:
  11566. (WebCore::ClipboardWin::writeURL):
  11567. 2011-05-16 Jeremy Noble <jer.noble@apple.com>
  11568. Unreviewed; build fix for non-SnowLeopard builds.
  11569. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition
  11570. of layerIsDescendentOf in a #if check.
  11571. 2011-05-16 Pavel Podivilov <podivilov@chromium.org>
  11572. Reviewed by Yury Semikhatsky.
  11573. Web Inspector: merge ConsoleView into ConsolePanel.
  11574. https://bugs.webkit.org/show_bug.cgi?id=54670
  11575. Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
  11576. will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.
  11577. * inspector/front-end/ConsoleView.js:
  11578. (WebInspector.ConsolePanel.prototype.get toolbarItemLabel):
  11579. (WebInspector.ConsolePanel.prototype.show):
  11580. (WebInspector.ConsolePanel.prototype.hide):
  11581. (WebInspector.ConsolePanel.prototype.showInDrawer):
  11582. (WebInspector.ConsolePanel.prototype.afterShowInDrawer):
  11583. (WebInspector.ConsolePanel.prototype.hideInDrawer):
  11584. (WebInspector.ConsolePanel.prototype.addMessage):
  11585. (WebInspector.ConsolePanel.prototype.clearMessages):
  11586. * inspector/front-end/DebuggerPresentationModel.js:
  11587. (WebInspector.DebuggerPresentationModel):
  11588. * inspector/front-end/Drawer.js:
  11589. (WebInspector.Drawer.prototype.set visibleView):
  11590. (WebInspector.Drawer.prototype.show.animationFinished):
  11591. (WebInspector.Drawer.prototype.show):
  11592. * inspector/front-end/Panel.js:
  11593. (WebInspector.Panel):
  11594. * inspector/front-end/ResourceTreeModel.js:
  11595. (WebInspector.ResourceTreeModel):
  11596. * inspector/front-end/inspector.html:
  11597. * inspector/front-end/inspector.js:
  11598. (WebInspector._createPanels):
  11599. 2011-05-13 Jer Noble <jer.noble@apple.com>
  11600. Reviewed by Simon Fraser.
  11601. Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
  11602. https://bugs.webkit.org/show_bug.cgi?id=60826
  11603. Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
  11604. ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
  11605. next time setVisible(true) is called.
  11606. * dom/Document.cpp:
  11607. (WebCore::Document::webkitDidEnterFullScreenForElement): Call setFullScreenRootLayer(0)
  11608. before disabling animation on the full screen renderer.
  11609. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  11610. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  11611. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new
  11612. WebKitLayerHostChanged notification.
  11613. (WebCore::layerIsDescendentOf): Added.
  11614. (WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added. If the changed
  11615. layer is an ancestor of the movie layer, tear down rendering and re-
  11616. create the next time setVisible(true) is called.
  11617. (-[WebCoreMovieObserver layerHostChanged:]): Added ObjC listener wrapper.
  11618. 2011-05-16 Adam Barth <abarth@webkit.org>
  11619. Reviewed by Darin Adler.
  11620. Remove disable-javascript-urls CSP directive
  11621. https://bugs.webkit.org/show_bug.cgi?id=60874
  11622. After talking this out with various folks in the CSP working group, we
  11623. decided that this syntax isn't the right way to approach this issue.
  11624. If we want to address the use case of enabling JavaScript URLs
  11625. separately from inline script, we'll probably just make
  11626. script-src javascript:
  11627. work that way.
  11628. * page/ContentSecurityPolicy.cpp:
  11629. (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
  11630. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  11631. (WebCore::ContentSecurityPolicy::addDirective):
  11632. * page/ContentSecurityPolicy.h:
  11633. 2011-05-16 Jon Lee <jonlee@apple.com>
  11634. Reviewed by Simon Fraser.
  11635. Can't horizontally scroll iframes and overflow because wheel events are always accepted
  11636. https://bugs.webkit.org/show_bug.cgi?id=60779
  11637. * dom/Document.cpp:
  11638. (WebCore::Document::Document): Initialize wheel event handler count
  11639. (WebCore::Document::didAddWheelEventHandler): Increment count, and tell the main frame
  11640. to recalculate the total number of wheel event handlers in all of its frames' documents
  11641. (WebCore::Document::didRemoveWheelEventHandler): Reverse of previous method
  11642. * dom/Document.h:
  11643. (WebCore::Document::wheelEventHandlerCount): Access the count
  11644. * dom/Node.cpp:
  11645. (WebCore::tryAddEventListener): If the event listener is a mouse wheel event, then
  11646. tell the document to increment its count
  11647. (WebCore::tryRemoveEventListener): Reverse of previous method
  11648. * page/ChromeClient.h: Two new methods:
  11649. numWheelEventHandlersChanged: WebProcess tells UIProcess to update its cached
  11650. count of total wheel event handlers, which in this case only include horizontal
  11651. scrollbars and mouse wheel JS handlers
  11652. shouldRubberBandInDirection: allow the UIProcess to provide some control over
  11653. whether rubber banding is allowed when scrolling in a particular direction
  11654. * loader/EmptyClients.h:
  11655. (WebCore::EmptyChromeClient::numWheelEventHandlersChanged): Default empty impl
  11656. (WebCore::EmptyChromeClient::shouldRubberBandInDirection): Default empty impl
  11657. * page/EventHandler.cpp:
  11658. (WebCore::EventHandler::handleWheelEvent): Remove a redundant pointer check
  11659. * page/Frame.cpp:
  11660. (WebCore::Frame::setDocument): When the frame's document changes, calculate that
  11661. document's total wheel event handlers, and notify the UIProcess
  11662. (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged): Performs a crawl
  11663. of the frame tree to aggregate the count
  11664. * page/Frame.h:
  11665. * platform/ScrollableArea.h: Virtualize didAddHorizontalScrollbar and
  11666. willRemoveHorizontalScrollbar for overriding in RenderLayer and FrameView
  11667. (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition): Returns true if there is
  11668. no scrollbar or the scroller position is in the minimum scroll position.
  11669. (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition): Converse of the above.
  11670. (WebCore::ScrollableArea::shouldRubberBandInDirection): Default impl
  11671. * page/FrameView.cpp:
  11672. (WebCore::FrameView::didAddHorizontalScrollbar): Updates the frame's document's count
  11673. (WebCore::FrameView::willRemoveHorizontalScrollbar): Updates the frame's document's
  11674. count
  11675. (WebCore::FrameView::shouldRubberBandInDirection): Connective glue
  11676. * page/FrameView.h: Adding overriding methods from ScrollableArea
  11677. * rendering/RenderLayer.cpp: Similar functionality to FrameView
  11678. (WebCore::RenderLayer::didAddHorizontalScrollbar):
  11679. (WebCore::RenderLayer::willRemoveHorizontalScrollbar):
  11680. * rendering/RenderLayer.h:
  11681. * platform/mac/ScrollAnimatorMac.h: Fix typo of "momentum"
  11682. * platform/mac/ScrollAnimatorMac.mm:
  11683. (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Fix typo of "momentum"
  11684. (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): Fix typo of "coalesced"
  11685. (WebCore::ScrollAnimatorMac::beginScrollGesture): Fix typo of "coalesced"
  11686. (WebCore::ScrollAnimatorMac::snapRubberBand): Fix typo of "momentum"
  11687. (WebCore::ScrollAnimatorMac::handleWheelEvent): New logic for determining whether
  11688. to allow rubber-banding based on the area's scroll position and the wheel event.
  11689. Could prevent accepting the wheel event. Also, fix typo of "momentum"
  11690. (WebCore::isScrollingLeftAndShouldNotRubberBand): Inline helper function for logic
  11691. (WebCore::isScrollingRightAndShouldNotRubberBand): Inline helper function for logic
  11692. 2011-05-16 Leandro Gracia Gil <leandrogracia@chromium.org>
  11693. Reviewed by Tony Gentilcore.
  11694. Media Stream API: add local stream requests.
  11695. https://bugs.webkit.org/show_bug.cgi?id=60177
  11696. Add the code and messages for requesting the generation of local streams and getting the reply back.
  11697. Tests for the Media Stream API will be provided by the bug 56587.
  11698. One test is re-enabled with this patch.
  11699. Test: fast/dom/MediaStream/argument-types.html
  11700. * GNUmakefile.list.am:
  11701. * WebCore.gypi:
  11702. * WebCore.pro:
  11703. * WebCore.vcproj/WebCore.vcproj:
  11704. * WebCore.xcodeproj/project.pbxproj:
  11705. * page/CallbackTask.h: Added.
  11706. (WebCore::CallbackTask1::create):
  11707. (WebCore::CallbackTask1::performTask):
  11708. (WebCore::CallbackTask1::Scheduler::scheduleCallback):
  11709. (WebCore::CallbackTask1::CallbackTask1):
  11710. * page/MediaStreamClient.h:
  11711. * page/MediaStreamController.cpp:
  11712. (WebCore::MediaStreamController::isClientAvailable):
  11713. (WebCore::MediaStreamController::unregisterFrameController):
  11714. (WebCore::MediaStreamController::registerRequest):
  11715. (WebCore::MediaStreamController::registerStream):
  11716. (WebCore::MediaStreamController::generateStream):
  11717. (WebCore::MediaStreamController::streamGenerated):
  11718. (WebCore::MediaStreamController::streamGenerationFailed):
  11719. * page/MediaStreamController.h:
  11720. * page/MediaStreamFrameController.cpp:
  11721. (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
  11722. (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest):
  11723. (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest):
  11724. (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
  11725. (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback):
  11726. (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback):
  11727. (WebCore::::unregisterAll):
  11728. (WebCore::::detachEmbedder):
  11729. (WebCore::MediaStreamFrameController::MediaStreamFrameController):
  11730. (WebCore::MediaStreamFrameController::pageController):
  11731. (WebCore::MediaStreamFrameController::unregister):
  11732. (WebCore::MediaStreamFrameController::enterDetachedState):
  11733. (WebCore::MediaStreamFrameController::isClientAvailable):
  11734. (WebCore::MediaStreamFrameController::disconnectFrame):
  11735. (WebCore::MediaStreamFrameController::parseGenerateStreamOptions):
  11736. (WebCore::MediaStreamFrameController::generateStream):
  11737. (WebCore::MediaStreamFrameController::streamGenerated):
  11738. (WebCore::MediaStreamFrameController::streamGenerationFailed):
  11739. * page/MediaStreamFrameController.h:
  11740. (WebCore::MediaStreamFrameController::ClientBase::ClientBase):
  11741. (WebCore::MediaStreamFrameController::ClientBase::~ClientBase):
  11742. (WebCore::MediaStreamFrameController::ClientBase::mediaStreamFrameController):
  11743. (WebCore::MediaStreamFrameController::ClientBase::clientId):
  11744. (WebCore::MediaStreamFrameController::ClientBase::isStream):
  11745. (WebCore::MediaStreamFrameController::ClientBase::isGeneratedStream):
  11746. (WebCore::MediaStreamFrameController::ClientBase::detachEmbedder):
  11747. (WebCore::MediaStreamFrameController::ClientBase::associateFrameController):
  11748. (WebCore::MediaStreamFrameController::ClientBase::unregisterClient):
  11749. (WebCore::MediaStreamFrameController::StreamClient::StreamClient):
  11750. (WebCore::MediaStreamFrameController::StreamClient::~StreamClient):
  11751. (WebCore::MediaStreamFrameController::StreamClient::isStream):
  11752. (WebCore::MediaStreamFrameController::StreamClient::unregister):
  11753. (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator):
  11754. (WebCore::MediaStreamFrameController::IdGenerator::getNextId):
  11755. (WebCore::MediaStreamFrameController::ClientMapBase::ClientMapBase):
  11756. * page/Navigator.cpp:
  11757. (WebCore::Navigator::webkitGetUserMedia):
  11758. * page/NavigatorUserMediaErrorCallback.h:
  11759. 2011-05-16 Pavel Podivilov <podivilov@chromium.org>
  11760. Reviewed by Yury Semikhatsky.
  11761. Web Inspector: debuggerWasEnabled notification should not be send to front-end on navigation.
  11762. https://bugs.webkit.org/show_bug.cgi?id=60888
  11763. * inspector/InspectorController.cpp:
  11764. (WebCore::InspectorController::disableDebugger):
  11765. * inspector/InspectorDebuggerAgent.cpp:
  11766. (WebCore::InspectorDebuggerAgent::enable):
  11767. (WebCore::InspectorDebuggerAgent::disable):
  11768. (WebCore::InspectorDebuggerAgent::restore):
  11769. (WebCore::InspectorDebuggerAgent::clearFrontend):
  11770. * inspector/InspectorDebuggerAgent.h:
  11771. 2011-05-16 Yury Semikhatsky <yurys@chromium.org>
  11772. Unreviewed. Windows build fix.
  11773. * inspector/InspectorConsoleInstrumentation.h:
  11774. (WebCore::InspectorInstrumentation::consoleMarkTimeline):
  11775. 2011-05-16 Yury Semikhatsky <yurys@chromium.org>
  11776. Unreviewed. Build fix.
  11777. * inspector/InspectorInstrumentation.h:
  11778. (WebCore::InspectorInstrumentation::willStartWorkerContext):
  11779. 2011-05-11 Yury Semikhatsky <yurys@chromium.org>
  11780. Reviewed by Pavel Feldman.
  11781. Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
  11782. https://bugs.webkit.org/show_bug.cgi?id=60624
  11783. InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
  11784. instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
  11785. about changes in WebCore.
  11786. * inspector/InspectorAgent.cpp:
  11787. (WebCore::InspectorAgent::InspectorAgent):
  11788. (WebCore::InspectorAgent::inspectedPageDestroyed):
  11789. * inspector/InspectorAgent.h:
  11790. * inspector/InspectorConsoleInstrumentation.h:
  11791. (WebCore::InspectorInstrumentation::addMessageToConsole):
  11792. (WebCore::InspectorInstrumentation::consoleCount):
  11793. (WebCore::InspectorInstrumentation::startConsoleTiming):
  11794. (WebCore::InspectorInstrumentation::stopConsoleTiming):
  11795. (WebCore::InspectorInstrumentation::consoleMarkTimeline):
  11796. (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
  11797. (WebCore::InspectorInstrumentation::addProfile):
  11798. (WebCore::InspectorInstrumentation::profilerEnabled):
  11799. (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  11800. * inspector/InspectorController.cpp:
  11801. (WebCore::InspectorController::InspectorController):
  11802. (WebCore::InspectorController::inspectedPageDestroyed):
  11803. (WebCore::InspectorController::didClearWindowObjectInWorld):
  11804. (WebCore::InspectorController::inspectedPage):
  11805. * inspector/InspectorController.h:
  11806. * inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros
  11807. is used for early return in common case when inspector is not opened. In this
  11808. case inspector instrumentation costs one additional check of a static field.
  11809. (WebCore::InspectorInstrumentation::didOpenDatabase):
  11810. * inspector/InspectorInstrumentation.cpp:
  11811. (WebCore::InspectorInstrumentation::instrumentingAgents):
  11812. (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
  11813. (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
  11814. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
  11815. (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
  11816. (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
  11817. (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
  11818. (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
  11819. (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
  11820. (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
  11821. (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
  11822. (WebCore::InspectorInstrumentation::handleMousePressImpl):
  11823. (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
  11824. (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
  11825. (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
  11826. (WebCore::InspectorInstrumentation::didInstallTimerImpl):
  11827. (WebCore::InspectorInstrumentation::didRemoveTimerImpl):
  11828. (WebCore::InspectorInstrumentation::willCallFunctionImpl):
  11829. (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
  11830. (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  11831. (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
  11832. (WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
  11833. (WebCore::InspectorInstrumentation::willFireTimerImpl):
  11834. (WebCore::InspectorInstrumentation::willLayoutImpl):
  11835. (WebCore::InspectorInstrumentation::willLoadXHRImpl):
  11836. (WebCore::InspectorInstrumentation::willPaintImpl):
  11837. (WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
  11838. (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
  11839. (WebCore::InspectorInstrumentation::willSendRequestImpl):
  11840. (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
  11841. (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
  11842. (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
  11843. (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
  11844. (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
  11845. (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  11846. (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  11847. (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
  11848. (WebCore::InspectorInstrumentation::didFailLoadingImpl):
  11849. (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
  11850. (WebCore::InspectorInstrumentation::scriptImportedImpl):
  11851. (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
  11852. (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  11853. (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
  11854. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  11855. (WebCore::InspectorInstrumentation::willWriteHTMLImpl):
  11856. (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  11857. (WebCore::InspectorInstrumentation::consoleCountImpl):
  11858. (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
  11859. (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
  11860. (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
  11861. (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
  11862. (WebCore::InspectorInstrumentation::addProfileImpl):
  11863. (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  11864. (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  11865. (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
  11866. (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
  11867. (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
  11868. (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
  11869. (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
  11870. (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
  11871. (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
  11872. (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
  11873. (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
  11874. (WebCore::InspectorInstrumentation::networkStateChangedImpl):
  11875. (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  11876. (WebCore::InspectorInstrumentation::hasFrontend):
  11877. (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  11878. (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  11879. (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  11880. * inspector/InspectorInstrumentation.h:
  11881. (WebCore::InspectorInstrumentation::bindInstrumentingAgents):
  11882. (WebCore::InspectorInstrumentation::unbindInstrumentingAgents):
  11883. (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
  11884. (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
  11885. (WebCore::InspectorInstrumentation::willInsertDOMNode):
  11886. (WebCore::InspectorInstrumentation::didInsertDOMNode):
  11887. (WebCore::InspectorInstrumentation::willRemoveDOMNode):
  11888. (WebCore::InspectorInstrumentation::willModifyDOMAttr):
  11889. (WebCore::InspectorInstrumentation::didModifyDOMAttr):
  11890. (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
  11891. (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
  11892. (WebCore::InspectorInstrumentation::handleMousePress):
  11893. (WebCore::InspectorInstrumentation::characterDataModified):
  11894. (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
  11895. (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
  11896. (WebCore::InspectorInstrumentation::didInstallTimer):
  11897. (WebCore::InspectorInstrumentation::didRemoveTimer):
  11898. (WebCore::InspectorInstrumentation::willCallFunction):
  11899. (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
  11900. (WebCore::InspectorInstrumentation::willDispatchEvent):
  11901. (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
  11902. (WebCore::InspectorInstrumentation::willEvaluateScript):
  11903. (WebCore::InspectorInstrumentation::willFireTimer):
  11904. (WebCore::InspectorInstrumentation::willLayout):
  11905. (WebCore::InspectorInstrumentation::willLoadXHR):
  11906. (WebCore::InspectorInstrumentation::willPaint):
  11907. (WebCore::InspectorInstrumentation::willRecalculateStyle):
  11908. (WebCore::InspectorInstrumentation::applyUserAgentOverride):
  11909. (WebCore::InspectorInstrumentation::willSendRequest):
  11910. (WebCore::InspectorInstrumentation::continueAfterPingLoader):
  11911. (WebCore::InspectorInstrumentation::markResourceAsCached):
  11912. (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
  11913. (WebCore::InspectorInstrumentation::willReceiveResourceData):
  11914. (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
  11915. (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
  11916. (WebCore::InspectorInstrumentation::continueWithPolicyDownload):
  11917. (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
  11918. (WebCore::InspectorInstrumentation::didReceiveContentLength):
  11919. (WebCore::InspectorInstrumentation::didFinishLoading):
  11920. (WebCore::InspectorInstrumentation::didFailLoading):
  11921. (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
  11922. (WebCore::InspectorInstrumentation::scriptImported):
  11923. (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
  11924. (WebCore::InspectorInstrumentation::loadEventFired):
  11925. (WebCore::InspectorInstrumentation::frameDetachedFromParent):
  11926. (WebCore::InspectorInstrumentation::didCommitLoad):
  11927. (WebCore::InspectorInstrumentation::willWriteHTML):
  11928. (WebCore::InspectorInstrumentation::didUseDOMStorage):
  11929. (WebCore::InspectorInstrumentation::willStartWorkerContext):
  11930. (WebCore::InspectorInstrumentation::didStartWorkerContext):
  11931. (WebCore::InspectorInstrumentation::didCreateWorker):
  11932. (WebCore::InspectorInstrumentation::didDestroyWorker):
  11933. (WebCore::InspectorInstrumentation::didCreateWebSocket):
  11934. (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
  11935. (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
  11936. (WebCore::InspectorInstrumentation::didCloseWebSocket):
  11937. (WebCore::InspectorInstrumentation::networkStateChanged):
  11938. (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
  11939. (WebCore::InspectorInstrumentation::hasFrontend):
  11940. (WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
  11941. (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
  11942. (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame):
  11943. (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame):
  11944. (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage):
  11945. (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext):
  11946. (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):
  11947. 2011-05-16 Vsevolod Vlasov <vsevik@chromium.org>
  11948. Reviewed by Pavel Feldman.
  11949. Web Inspector: Move Resources Panel search to backend
  11950. https://bugs.webkit.org/show_bug.cgi?id=59596
  11951. * inspector/Inspector.json:
  11952. * inspector/InspectorPageAgent.cpp:
  11953. (WebCore::decodeMainResource):
  11954. (WebCore::InspectorPageAgent::resourceContent):
  11955. (WebCore::cachedResourcesForFrame):
  11956. (WebCore::InspectorPageAgent::getCookies):
  11957. (WebCore::InspectorPageAgent::deleteCookie):
  11958. (WebCore::createSearchRegexSource):
  11959. (WebCore::countRegularExpressionMatches):
  11960. (WebCore::buildObjectForSearchMatch):
  11961. (WebCore::InspectorPageAgent::searchInResources):
  11962. (WebCore::InspectorPageAgent::domContentEventFired):
  11963. (WebCore::InspectorPageAgent::loadEventFired):
  11964. (WebCore::InspectorPageAgent::frameNavigated):
  11965. (WebCore::InspectorPageAgent::frameDetached):
  11966. (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  11967. * inspector/InspectorPageAgent.h:
  11968. * inspector/front-end/ResourcesPanel.js:
  11969. (WebInspector.ResourcesPanel.prototype._showResourceView):
  11970. (WebInspector.ResourcesPanel.prototype.performSearch.searchInEditedResource):
  11971. (WebInspector.ResourcesPanel.prototype.performSearch.callback):
  11972. (WebInspector.ResourcesPanel.prototype.performSearch):
  11973. (WebInspector.ResourcesPanel.prototype._ensureViewSearchPerformed):
  11974. (WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
  11975. (WebInspector.ResourcesPanel.prototype._showSearchResult):
  11976. (WebInspector.ResourcesPanel.prototype._resetSearchResults):
  11977. (WebInspector.ResourcesPanel.prototype.searchCanceled):
  11978. (WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
  11979. (WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
  11980. (WebInspector.FrameTreeElement.prototype.resourceByURL):
  11981. (WebInspector.FrameResourceTreeElement.prototype._resetSearchResults):
  11982. (WebInspector.FrameResourceTreeElement.prototype.get searchMatchesCount):
  11983. (WebInspector.FrameResourceTreeElement.prototype.searchMatchesFound):
  11984. (WebInspector.ResourcesSearchController):
  11985. (WebInspector.ResourcesSearchController.prototype.nextSearchResult):
  11986. (WebInspector.ResourcesSearchController.prototype.previousSearchResult):
  11987. (WebInspector.ResourcesSearchController.prototype._searchResult):
  11988. (WebInspector.SearchResultsTreeElementsTraverser):
  11989. (WebInspector.SearchResultsTreeElementsTraverser.prototype.first):
  11990. (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
  11991. (WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
  11992. (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
  11993. (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
  11994. (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementHasSearchResults):
  11995. (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
  11996. (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  11997. * inspector/front-end/SourceFrame.js:
  11998. (WebInspector.SourceFrame.createSearchRegex):
  11999. (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
  12000. (WebInspector.SourceFrame.prototype.performSearch):
  12001. (WebInspector.SourceFrame.prototype.hasSearchResults):
  12002. (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
  12003. (WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
  12004. (WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
  12005. (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
  12006. (WebInspector.SourceFrame.prototype.jumpToSearchResult):
  12007. (WebInspector.SourceFrame.prototype._collectRegexMatches):
  12008. * inspector/front-end/utilities.js:
  12009. ():
  12010. 2011-05-16 Andreas Kling <kling@webkit.org>
  12011. Reviewed by Darin Adler.
  12012. CSS: Fast path for 'px' lengths should be case-insensitive.
  12013. https://bugs.webkit.org/show_bug.cgi?id=60703
  12014. No new tests, this is an optimization that avoids creating
  12015. a full CSSParser to parse the value.
  12016. * css/CSSParser.cpp:
  12017. (WebCore::parseSimpleLengthValue):
  12018. 2011-05-16 Naiem Shaik <naiem.shaik@gmail.com>
  12019. Reviewed by Adam Barth.
  12020. This is for fixing build break in webgl due to https://bugs.webkit.org/show_bug.cgi?id=59861
  12021. The bug raised for fixing this is https://bugs.webkit.org/show_bug.cgi?id=60867
  12022. No new tests. This does not change any functionality.
  12023. * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
  12024. (WebCore::GraphicsContext3D::create):
  12025. * platform/graphics/gtk/GraphicsContext3DInternal.cpp:
  12026. (WebCore::GraphicsContext3DInternal::create):
  12027. * platform/graphics/gtk/GraphicsContext3DInternal.h:
  12028. 2011-05-16 Pavel Feldman <pfeldman@chromium.org>
  12029. Reviewed by Yury Semikhatsky.
  12030. Web Inspector: parse edited attributes by means of InspectorDOMAgent.
  12031. https://bugs.webkit.org/show_bug.cgi?id=60807
  12032. This change moves attribute parsing from the front-end to the backend.
  12033. * inspector/InspectorDOMAgent.cpp:
  12034. (WebCore::InspectorDOMAgent::setAttribute):
  12035. * inspector/front-end/DOMAgent.js:
  12036. (WebInspector.DOMNode.prototype.setAttribute):
  12037. * inspector/front-end/ElementsTreeOutline.js:
  12038. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
  12039. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  12040. 2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
  12041. Not reviewed.
  12042. Switch from Vector<UChar> to StringBuilder in dom/
  12043. https://bugs.webkit.org/show_bug.cgi?id=57843
  12044. Incorporate comment from Darin/Andreas.
  12045. * dom/DatasetDOMStringMap.cpp:
  12046. (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i].
  12047. (WebCore::convertPropertyNameToAttributeName): Ditto.
  12048. 2011-05-16 Alexander Pavlov <apavlov@chromium.org>
  12049. Reviewed by Pavel Feldman.
  12050. Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
  12051. https://bugs.webkit.org/show_bug.cgi?id=60773
  12052. * inspector/front-end/SourceJavaScriptTokenizer.js:
  12053. (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  12054. * inspector/front-end/SourceJavaScriptTokenizer.re2js:
  12055. 2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
  12056. Reviewed by Darin Adler.
  12057. Switch from Vector<UChar> to StringBuilder in dom/
  12058. https://bugs.webkit.org/show_bug.cgi?id=57843
  12059. * dom/DatasetDOMStringMap.cpp:
  12060. (WebCore::convertAttributeNameToPropertyName):
  12061. (WebCore::convertPropertyNameToAttributeName):
  12062. * dom/Range.cpp:
  12063. (WebCore::Range::toString):
  12064. * dom/ScriptElement.cpp:
  12065. (WebCore::ScriptElement::scriptContent):
  12066. 2011-05-05 Pavel Podivilov <podivilov@chromium.org>
  12067. Reviewed by Pavel Feldman.
  12068. Web Inspector: move double click handling from TextEditor to SourceFrame.
  12069. https://bugs.webkit.org/show_bug.cgi?id=60271
  12070. It is SourceFrame's responsibility to check if content is editable and
  12071. to configure TextEditor component (e.g. set editable range) when user
  12072. tries to initiate editing.
  12073. * inspector/front-end/ResourceView.js:
  12074. (WebInspector.ResourceSourceFrame.prototype.doubleClick):
  12075. (WebInspector.RevisionSourceFrame.prototype.doubleClick):
  12076. * inspector/front-end/SourceFrame.js:
  12077. (WebInspector.SourceFrame.prototype.beforeTextChanged):
  12078. (WebInspector.SourceFrame.prototype.afterTextChanged):
  12079. (WebInspector.SourceFrame.prototype.doubleClick):
  12080. (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
  12081. (WebInspector.SourceFrame.prototype.commitEditing):
  12082. (WebInspector.SourceFrame.prototype.cancelEditing):
  12083. (WebInspector.SourceFrame.prototype._setReadOnly):
  12084. * inspector/front-end/TextViewer.js:
  12085. (WebInspector.TextViewer.prototype.set readOnly):
  12086. (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
  12087. (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
  12088. (WebInspector.TextViewer.prototype._doubleClick):
  12089. (WebInspector.TextViewer.prototype._commitEditing):
  12090. (WebInspector.TextViewer.prototype._cancelEditing):
  12091. (WebInspector.TextViewerDelegate.prototype.doubleClick):
  12092. (WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
  12093. (WebInspector.TextViewerDelegate.prototype.afterTextChanged):
  12094. 2011-05-15 Robert Hogan <robert@webkit.org>
  12095. Reviewed by Yury Semikhatsky.
  12096. [Qt] Fix crash in inspector/console/console-long-eval-crash.html
  12097. https://bugs.webkit.org/show_bug.cgi?id=60858
  12098. The client may be gone when sendMessageToBackend() is called.
  12099. * inspector/InspectorFrontendHost.cpp:
  12100. (WebCore::InspectorFrontendHost::sendMessageToBackend):
  12101. 2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
  12102. Reviewed by Dirk Schulze.
  12103. Replace direct StringConcatenate usage, by using operator+ (again)
  12104. https://bugs.webkit.org/show_bug.cgi?id=60700
  12105. Remove makeString() usage everywhere, instead directly use operator+.
  12106. * accessibility/AccessibilityObject.cpp:
  12107. (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
  12108. * bindings/js/JSDOMWindowBase.cpp:
  12109. * bindings/js/ScriptDebugServer.cpp:
  12110. (WebCore::ScriptDebugServer::setBreakpoint):
  12111. * bindings/v8/V8Proxy.cpp:
  12112. (WebCore::V8Proxy::reportUnsafeAccessTo):
  12113. * css/CSSMutableStyleDeclaration.cpp:
  12114. (WebCore::CSSMutableStyleDeclaration::borderSpacingValue):
  12115. * dom/ExceptionBase.cpp:
  12116. (WebCore::ExceptionBase::ExceptionBase):
  12117. * dom/XMLDocumentParser.cpp:
  12118. (WebCore::XMLDocumentParser::handleError):
  12119. * html/FTPDirectoryDocument.cpp:
  12120. (WebCore::processFileDateString):
  12121. * inspector/CodeGeneratorInspector.pm:
  12122. * inspector/InspectorConsoleAgent.cpp:
  12123. (WebCore::InspectorConsoleAgent::count):
  12124. (WebCore::InspectorConsoleAgent::didReceiveResponse):
  12125. * inspector/InspectorDOMAgent.cpp:
  12126. * inspector/InspectorDOMDebuggerAgent.cpp:
  12127. (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
  12128. * inspector/InspectorDebuggerAgent.cpp:
  12129. (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
  12130. (WebCore::InspectorDebuggerAgent::setBreakpoint):
  12131. * loader/FrameLoader.cpp:
  12132. (WebCore::FrameLoader::checkIfDisplayInsecureContent):
  12133. (WebCore::FrameLoader::checkIfRunInsecureContent):
  12134. (WebCore::FrameLoader::shouldAllowNavigation):
  12135. * loader/archive/cf/LegacyWebArchive.cpp:
  12136. (WebCore::LegacyWebArchive::createFromSelection):
  12137. * loader/cache/CachedResourceLoader.cpp:
  12138. (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  12139. * page/ContentSecurityPolicy.cpp:
  12140. (WebCore::CSPDirective::CSPDirective):
  12141. (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  12142. * page/DOMWindow.cpp:
  12143. (WebCore::DOMWindow::postMessageTimerFired):
  12144. (WebCore::DOMWindow::crossDomainAccessErrorMessage):
  12145. * page/PageSerializer.cpp:
  12146. (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
  12147. (WebCore::SerializerMarkupAccumulator::appendElement):
  12148. (WebCore::PageSerializer::urlForBlankFrame):
  12149. * page/PrintContext.cpp:
  12150. (WebCore::PrintContext::pageProperty):
  12151. (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  12152. * platform/efl/PlatformKeyboardEventEfl.cpp:
  12153. (WebCore::createKeyMap):
  12154. (WebCore::createWindowsKeyMap):
  12155. * platform/efl/RenderThemeEfl.cpp:
  12156. (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
  12157. * platform/graphics/GraphicsLayer.cpp:
  12158. (WebCore::GraphicsLayer::animationNameForTransition):
  12159. * platform/graphics/brew/ImageBrew.cpp:
  12160. (WebCore::Image::loadPlatformResource):
  12161. * platform/graphics/ca/GraphicsLayerCA.cpp:
  12162. (WebCore::animationIdentifier):
  12163. * platform/graphics/cg/ImageBufferCG.cpp:
  12164. (WebCore::CGImageToDataURL):
  12165. * platform/graphics/gtk/ImageBufferGtk.cpp:
  12166. (WebCore::ImageBuffer::toDataURL):
  12167. * platform/graphics/haiku/ImageBufferHaiku.cpp:
  12168. (WebCore::ImageBuffer::toDataURL):
  12169. * platform/graphics/qt/ImageBufferQt.cpp:
  12170. (WebCore::ImageBuffer::toDataURL):
  12171. * platform/graphics/skia/ImageBufferSkia.cpp:
  12172. (WebCore::ImageToDataURL):
  12173. * platform/network/CredentialStorage.cpp:
  12174. (WebCore::originStringFromURL):
  12175. * platform/network/cf/SocketStreamHandleCFNet.cpp:
  12176. (WebCore::SocketStreamHandle::reportErrorToClient):
  12177. * platform/sql/SQLiteDatabase.cpp:
  12178. (WebCore::SQLiteDatabase::setSynchronous):
  12179. * platform/text/wince/TextCodecWinCE.cpp:
  12180. (WebCore::LanguageManager::LanguageManager):
  12181. * platform/win/ClipboardUtilitiesWin.cpp:
  12182. * platform/win/ClipboardWin.cpp:
  12183. (WebCore::ClipboardWin::writeURL):
  12184. * platform/win/FileSystemWin.cpp:
  12185. (WebCore::listDirectory):
  12186. * platform/win/LanguageWin.cpp:
  12187. (WebCore::platformDefaultLanguage):
  12188. * platform/win/PathWalker.cpp:
  12189. (WebCore::PathWalker::PathWalker):
  12190. * platform/win/SystemInfo.cpp:
  12191. (WebCore::osVersionForUAString):
  12192. (WebCore::windowsVersionForUAString):
  12193. * plugins/PluginStream.cpp:
  12194. (WebCore::PluginStream::startStream):
  12195. * svg/SVGAngle.cpp:
  12196. (WebCore::SVGAngle::valueAsString):
  12197. * svg/SVGLength.cpp:
  12198. (WebCore::SVGLength::valueAsString):
  12199. * svg/SVGPaint.cpp:
  12200. (WebCore::SVGPaint::cssText):
  12201. * svg/SVGPointList.cpp:
  12202. (WebCore::SVGPointList::valueAsString):
  12203. * svg/SVGPreserveAspectRatio.cpp:
  12204. (WebCore::SVGPreserveAspectRatio::valueAsString):
  12205. * svg/SVGTransform.cpp:
  12206. (WebCore::SVGTransform::valueAsString):
  12207. * svg/SVGTransformList.cpp:
  12208. * svg/SVGUseElement.cpp:
  12209. (WebCore::dumpInstanceTree):
  12210. * websockets/WebSocket.cpp:
  12211. (WebCore::WebSocket::connect):
  12212. * websockets/WebSocketChannel.cpp:
  12213. (WebCore::WebSocketChannel::didFail):
  12214. (WebCore::WebSocketChannel::appendToBuffer):
  12215. * websockets/WebSocketHandshake.cpp:
  12216. (WebCore::WebSocketHandshake::readServerHandshake):
  12217. 2011-05-12 Yury Semikhatsky <yurys@chromium.org>
  12218. Reviewed by Pavel Feldman.
  12219. Web Inspector: inspector console should be searchable
  12220. https://bugs.webkit.org/show_bug.cgi?id=60711
  12221. Search now works for Console panel. It shows number of matching console entries
  12222. and allows to jump to the next matching console entry. Also the matches count
  12223. is dynamically updated when new messages are added to the console.
  12224. ResourceTreeModel and DebuggerPresentationModel now listen to console events instead
  12225. of being called directly from ConsoleView.
  12226. * inspector/front-end/ConsolePanel.js:
  12227. (WebInspector.ConsolePanel):
  12228. (WebInspector.ConsolePanel.prototype.show):
  12229. (WebInspector.ConsolePanel.prototype.hide):
  12230. (WebInspector.ConsolePanel.prototype.searchCanceled):
  12231. (WebInspector.ConsolePanel.prototype.performSearch):
  12232. (WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
  12233. (WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
  12234. (WebInspector.ConsolePanel.prototype._clearCurrentSearchResultHighlight):
  12235. (WebInspector.ConsolePanel.prototype._jumpToSearchResult):
  12236. (WebInspector.ConsolePanel.prototype._consoleMessageAdded):
  12237. (WebInspector.ConsolePanel.prototype._consoleCleared):
  12238. * inspector/front-end/ConsoleView.js:
  12239. (WebInspector.ConsoleView.prototype.addMessage):
  12240. (WebInspector.ConsoleView.prototype.clearMessages):
  12241. (WebInspector.ConsoleMessage.prototype.clearHighlight):
  12242. (WebInspector.ConsoleMessage.prototype.highlightSearchResults):
  12243. (WebInspector.ConsoleMessage.prototype.matchesRegex):
  12244. (WebInspector.ConsoleMessage.prototype.toMessageElement):
  12245. (WebInspector.ConsoleCommand.prototype.clearHighlight):
  12246. (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
  12247. (WebInspector.ConsoleCommand.prototype.matchesRegex):
  12248. (WebInspector.ConsoleCommand.prototype.toMessageElement):
  12249. (WebInspector.ConsoleCommand.prototype._formatCommand):
  12250. * inspector/front-end/DebuggerPresentationModel.js:
  12251. (WebInspector.DebuggerPresentationModel):
  12252. (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
  12253. (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
  12254. (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
  12255. * inspector/front-end/ResourceTreeModel.js:
  12256. (WebInspector.ResourceTreeModel):
  12257. (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  12258. * inspector/front-end/ScriptsPanel.js:
  12259. (WebInspector.ScriptsPanel):
  12260. (WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
  12261. * inspector/front-end/utilities.js:
  12262. ():
  12263. 2011-05-16 Adam Barth <abarth@webkit.org>
  12264. [Qt] QtPlatformPlugin create methods should use PassOwnPtr
  12265. https://bugs.webkit.org/show_bug.cgi?id=60873
  12266. * plugins/qt/PluginViewQt.cpp:
  12267. (WebCore::PluginView::platformStart):
  12268. 2011-05-15 Adam Barth <abarth@webkit.org>
  12269. Attempt to fix Qt build. (Strict PassOwnPtr fix.)
  12270. * platform/graphics/qt/GraphicsLayerQt.cpp:
  12271. (WebCore::GraphicsLayerQt::GraphicsLayerQt):
  12272. (WebCore::GraphicsLayer::create):
  12273. 2011-05-15 Adam Barth <abarth@webkit.org>
  12274. Attempt to fix Qt build. (Strict PassOwnPtr fix.)
  12275. * platform/text/qt/TextCodecQt.cpp:
  12276. (WebCore::newTextCodecQt):
  12277. 2011-05-15 Adam Barth <abarth@webkit.org>
  12278. Attempt to fix Qt build. (Strict PassOwnPtr fix.)
  12279. * platform/network/qt/QNetworkReplyHandler.cpp:
  12280. (WebCore::QNetworkReplyWrapper::release):
  12281. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  12282. (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
  12283. (WebCore::QNetworkReplyHandler::release):
  12284. (WebCore::QNetworkReplyHandler::finish):
  12285. (WebCore::QNetworkReplyHandler::redirect):
  12286. (WebCore::QNetworkReplyHandler::start):
  12287. 2011-05-15 Adam Barth <abarth@webkit.org>
  12288. Attempt to fix Qt build. (Strict PassOwnPtr fix.)
  12289. * dom/XMLDocumentParserQt.cpp:
  12290. (WebCore::XMLDocumentParser::doEnd):
  12291. 2011-05-15 Kenichi Ishibashi <bashi@chromium.org>
  12292. Reviewed by Kent Tamura.
  12293. <output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
  12294. https://bugs.webkit.org/show_bug.cgi?id=60602
  12295. HTMLFormControlElement::isFocusable() returns true when the element is
  12296. visible as a block element. However, for output, meter, and progress
  12297. elements, the function should not return true unless they have
  12298. tabindex attributes. Override supportsFocus() of these elements to
  12299. apply the result of Node::supportsFocus() because it takes care of
  12300. whether the element has tabindex or not.
  12301. Test: fast/forms/focus-with-display-block.html
  12302. * html/HTMLFormControlElement.h: Made supportsFocus() protected.
  12303. * html/HTMLMeterElement.cpp:
  12304. (WebCore::HTMLMeterElement::supportsFocus): Added.
  12305. * html/HTMLMeterElement.h:
  12306. * html/HTMLOutputElement.cpp:
  12307. (WebCore::HTMLOutputElement::supportsFocus): Added.
  12308. * html/HTMLOutputElement.h:
  12309. * html/HTMLProgressElement.cpp:
  12310. (WebCore::HTMLProgressElement::supportsFocus): Added.
  12311. * html/HTMLProgressElement.h:
  12312. 2011-05-15 Jon Lee <jonlee@apple.com>
  12313. Reviewed by Dan Bernstein.
  12314. Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
  12315. https://bugs.webkit.org/show_bug.cgi?id=60870
  12316. * editing/SpellingCorrectionController.cpp:
  12317. (WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType
  12318. 2011-05-15 Geoffrey Garen <ggaren@apple.com>
  12319. Reviewed by Gavin Barraclough.
  12320. https://bugs.webkit.org/show_bug.cgi?id=59699
  12321. Global object is recreated on teardown, for no good reason
  12322. (Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
  12323. ~7% slower in browser than on command line (was 17%))
  12324. I'm basically rolling out http://trac.webkit.org/changeset/49786 because
  12325. (a) it created this performance problem
  12326. and
  12327. (b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
  12328. was committed in http://trac.webkit.org/changeset/53439.
  12329. Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.
  12330. * page/Frame.cpp:
  12331. (WebCore::Frame::~Frame): Don't create a new window every time we destroy
  12332. a frame.
  12333. 2011-05-12 MORITA Hajime <morrita@google.com>
  12334. ShadowContentElement should affect the order of renderer children
  12335. https://bugs.webkit.org/show_bug.cgi?id=59157
  12336. Introduced ShadowContentSelector to collect and forward content
  12337. children for each ShadowContentElement. ShadowRoot collects child
  12338. nodes of its host (we call these children "content children"), and
  12339. the descendant ShadowContentElement pulls that these content
  12340. children and put it under its child during
  12341. ShadowContentElement::attach().
  12342. Content children no longer create its renderer during its normal
  12343. attach() phase (called "light" phase). And they create it during
  12344. attach() as a content children instead (called "forwarded phase").
  12345. These phases are detected by NodeRendererFactory and represented
  12346. as NodeRendererFactory::AttachPhase value AttachContentLight and
  12347. AttachContentForwarded.
  12348. Tests: fast/html/details-add-details-child-1.html
  12349. fast/html/details-add-details-child-2.html
  12350. fast/html/details-nested-1.html
  12351. fast/html/details-nested-2.html
  12352. * dom/Element.cpp:
  12353. (WebCore::Element::attach):
  12354. (WebCore::Element::childrenChanged):
  12355. * dom/Node.cpp:
  12356. (WebCore::NodeRendererFactory::NodeRendererFactory):
  12357. (WebCore::NodeRendererFactory::shouldCreateRenderer):
  12358. (WebCore::NodeRendererFactory::nextRenderer):
  12359. (WebCore::NodeRendererFactory::createRendererIfNeeded):
  12360. * dom/ShadowRoot.cpp:
  12361. (WebCore::forceReattach):
  12362. (WebCore::ShadowContentSelector::shadowRoot):
  12363. (WebCore::ShadowContentSelector::activeElement):
  12364. (WebCore::ShadowContentSelector::currentInstance):
  12365. (WebCore::ShadowContentSelector::ShadowContentSelector):
  12366. (WebCore::ShadowContentSelector::~ShadowContentSelector):
  12367. (WebCore::ShadowContentSelector::attachChildrenFor):
  12368. (WebCore::ShadowContentElement::attach):
  12369. (WebCore::ShadowRoot::recalcStyle):
  12370. (WebCore::ShadowRoot::activeContentContainer):
  12371. (WebCore::ShadowRoot::hostChildrenChanged):
  12372. (WebCore::ShadowRoot::attach):
  12373. * dom/ShadowRoot.h:
  12374. * html/shadow/ShadowContentElement.h:
  12375. (WebCore::ShadowContentElement::rendererIsNeeded):
  12376. * rendering/RenderDetails.cpp:
  12377. * rendering/RenderDetails.h:
  12378. 2011-05-13 MORITA Hajime <morrita@google.com>
  12379. Reviewed by Ryosuke Niwa.
  12380. Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
  12381. https://bugs.webkit.org/show_bug.cgi?id=57088
  12382. Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
  12383. No new tests, no behavior change.
  12384. * editing/Editor.cpp:
  12385. (WebCore::Editor::replaceSelectionWithFragment):
  12386. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  12387. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  12388. (WebCore::Editor::markMisspellingsAndBadGrammar):
  12389. (WebCore::Editor::resolveTextCheckingTypeMask):
  12390. * editing/Editor.h:
  12391. * platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel
  12392. 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>
  12393. Reviewed by Yury Semikhatsky.
  12394. Web Inspector: chromium renderer crash at eval in console.
  12395. https://bugs.webkit.org/show_bug.cgi?id=60616
  12396. Renderer of inspected page is crashing when modal dialog
  12397. has been opened via console eval and page is reloaded.
  12398. Test: inspector/console/console-long-eval-crash.html
  12399. * inspector/CodeGeneratorInspector.pm:
  12400. * inspector/InspectorController.cpp:
  12401. (WebCore::InspectorController::connectFrontend):
  12402. (WebCore::InspectorController::dispatchMessageFromFrontend):
  12403. * inspector/InspectorController.h:
  12404. 2011-05-15 Eric Carlson <eric.carlson@apple.com>
  12405. Reviewed by Maciej Stachowiak.
  12406. Use new AVAssetReferenceRestrictions to prevent cross site media references
  12407. https://bugs.webkit.org/show_bug.cgi?id=60791
  12408. <rdar://problem/9374202>
  12409. Test: http/tests/media/video-cross-site.html
  12410. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  12411. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction
  12412. to prevent cross-domain references from being followed.
  12413. 2011-05-15 Arno Renevier <arno@renevier.net>
  12414. Reviewed by Darin Adler.
  12415. remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
  12416. https://bugs.webkit.org/show_bug.cgi?id=60775
  12417. No new tests. This change only impacts compilation.
  12418. * html/HTMLFrameElementBase.cpp:
  12419. 2011-05-14 Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
  12420. Reviewed by Kevin Ollivier.
  12421. [wx] Fix strokeArc and fillRoundedRect drawing, and add clipPath support.
  12422. https://bugs.webkit.org/show_bug.cgi?id=60847
  12423. * platform/graphics/wx/GraphicsContextWx.cpp:
  12424. (WebCore::GraphicsContext::strokeArc):
  12425. (WebCore::GraphicsContext::clipConvexPolygon):
  12426. (WebCore::GraphicsContext::fillRoundedRect):
  12427. (WebCore::GraphicsContext::drawFocusRing):
  12428. (WebCore::GraphicsContext::clipOut):
  12429. (WebCore::GraphicsContext::clipPath):
  12430. (WebCore::GraphicsContext::clip):
  12431. (WebCore::GraphicsContext::addInnerRoundedRectClip):
  12432. 2011-05-14 Eric Carlson <eric.carlson@apple.com>
  12433. Reviewed by Dan Bernstein.
  12434. HTTP video-on-demand streams frequently have live stream UI
  12435. https://bugs.webkit.org/show_bug.cgi?id=60849
  12436. <rdar://problem/9440502>
  12437. No new tests, we don't currently have tests for http live streams. Changes verified manually.
  12438. * html/HTMLMediaElement.cpp:
  12439. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Reset the media controls so
  12440. a duration change which identifies a format will be picked up.
  12441. (WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): New, reset media controls
  12442. so they can be reconfigured for the media file characteristics.
  12443. * html/HTMLMediaElement.h:
  12444. * platform/graphics/MediaPlayer.cpp:
  12445. (WebCore::MediaPlayer::characteristicChanged): New, pass through to the element.
  12446. * platform/graphics/MediaPlayer.h:
  12447. (WebCore::MediaPlayerClient::mediaPlayerCharacteristicChanged):
  12448. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  12449. (WebCore::MediaPlayerPrivateAVFoundation::setHasVideo): Call characteristicChanged when
  12450. setting changes.
  12451. (WebCore::MediaPlayerPrivateAVFoundation::setHasAudio): Ditto.
  12452. (WebCore::MediaPlayerPrivateAVFoundation::setHasClosedCaptions): Ditto.
  12453. (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Move the duration
  12454. change notification logic to invalidateCachedDuration.
  12455. (WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration): New, invalidate
  12456. the cached duration and notify the element when it changes.
  12457. (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call invalidateCachedDuration
  12458. for the DurationChanged notification.
  12459. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Define DurationChanged.
  12460. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  12461. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't check asset or
  12462. item duration until they have been loaded.
  12463. (WebCore::itemKVOProperties): Listen for duration change.
  12464. (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with
  12465. duration change notification.
  12466. 2011-05-14 Abhishek Arya <inferno@chromium.org>
  12467. Reviewed by Dan Bernstein.
  12468. As per spec, only allow one font family name in a font face rule.
  12469. Other things like initial value, inherited value or multiple names
  12470. are discarded.
  12471. https://bugs.webkit.org/show_bug.cgi?id=60837
  12472. Test: fast/css/invalid-font-family-in-font-face-crash.html
  12473. * css/CSSParser.cpp:
  12474. (WebCore::CSSParser::createFontFaceRule):
  12475. 2011-05-13 Oliver Hunt <oliver@apple.com>
  12476. Reviewed by Geoffrey Garen.
  12477. Make GC validation more aggressive
  12478. https://bugs.webkit.org/show_bug.cgi?id=60802
  12479. This makes GC_VALIDATION much more aggressive in webcore,
  12480. adding logic to every visitChildren method to ensure that
  12481. the structure still has correct flags.
  12482. Additionally every function generated for the dom bindings
  12483. makes use of the new GC_VALIDATION object assertions to further
  12484. ensure that the object appears to be sensible.
  12485. * bindings/js/JSAttrCustom.cpp:
  12486. (WebCore::JSAttr::visitChildren):
  12487. * bindings/js/JSAudioContextCustom.cpp:
  12488. (WebCore::JSAudioContext::visitChildren):
  12489. * bindings/js/JSCSSRuleCustom.cpp:
  12490. (WebCore::JSCSSRule::visitChildren):
  12491. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  12492. (WebCore::JSCSSStyleDeclaration::visitChildren):
  12493. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  12494. (WebCore::JSCanvasRenderingContext::visitChildren):
  12495. * bindings/js/JSDOMGlobalObject.cpp:
  12496. (WebCore::JSDOMGlobalObject::visitChildren):
  12497. (WebCore::JSDOMGlobalObject::setInjectedScript):
  12498. * bindings/js/JSDOMWindowCustom.cpp:
  12499. (WebCore::JSDOMWindow::visitChildren):
  12500. * bindings/js/JSDOMWindowShell.cpp:
  12501. (WebCore::JSDOMWindowShell::visitChildren):
  12502. * bindings/js/JSEventListener.cpp:
  12503. (WebCore::JSEventListener::JSEventListener):
  12504. * bindings/js/JSEventListener.h:
  12505. (WebCore::JSEventListener::jsFunction):
  12506. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  12507. (WebCore::JSJavaScriptAudioNode::visitChildren):
  12508. * bindings/js/JSMessageChannelCustom.cpp:
  12509. (WebCore::JSMessageChannel::visitChildren):
  12510. * bindings/js/JSMessagePortCustom.cpp:
  12511. (WebCore::JSMessagePort::visitChildren):
  12512. * bindings/js/JSNamedNodeMapCustom.cpp:
  12513. (WebCore::JSNamedNodeMap::visitChildren):
  12514. * bindings/js/JSNodeCustom.cpp:
  12515. (WebCore::JSNode::visitChildren):
  12516. * bindings/js/JSNodeFilterCustom.cpp:
  12517. (WebCore::JSNodeFilter::visitChildren):
  12518. * bindings/js/JSNodeIteratorCustom.cpp:
  12519. (WebCore::JSNodeIterator::visitChildren):
  12520. * bindings/js/JSSVGElementInstanceCustom.cpp:
  12521. (WebCore::JSSVGElementInstance::visitChildren):
  12522. * bindings/js/JSSharedWorkerCustom.cpp:
  12523. (WebCore::JSSharedWorker::visitChildren):
  12524. * bindings/js/JSStyleSheetCustom.cpp:
  12525. (WebCore::JSStyleSheet::visitChildren):
  12526. * bindings/js/JSTreeWalkerCustom.cpp:
  12527. (WebCore::JSTreeWalker::visitChildren):
  12528. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  12529. (WebCore::JSWebGLRenderingContext::visitChildren):
  12530. * bindings/js/JSWorkerContextCustom.cpp:
  12531. (WebCore::JSWorkerContext::visitChildren):
  12532. * bindings/js/JSXMLHttpRequestCustom.cpp:
  12533. (WebCore::JSXMLHttpRequest::visitChildren):
  12534. * bindings/js/JSXPathResultCustom.cpp:
  12535. (WebCore::JSXPathResult::visitChildren):
  12536. * bindings/scripts/CodeGeneratorJS.pm:
  12537. 2011-05-13 Oliver Hunt <oliver@apple.com>
  12538. Reviewed by Geoffrey Garen.
  12539. Make GC validation more aggressive
  12540. https://bugs.webkit.org/show_bug.cgi?id=60802
  12541. This makes GC_VALIDATION much more aggressive in webcore,
  12542. adding logic to every visitChildren method to ensure that
  12543. the structure still has correct flags.
  12544. Additionally every function generated for the dom bindings
  12545. makes use of the new GC_VALIDATION object assertions to further
  12546. ensure that the object appears to be sensible.
  12547. * bindings/js/JSAttrCustom.cpp:
  12548. (WebCore::JSAttr::visitChildren):
  12549. * bindings/js/JSAudioContextCustom.cpp:
  12550. (WebCore::JSAudioContext::visitChildren):
  12551. * bindings/js/JSCSSRuleCustom.cpp:
  12552. (WebCore::JSCSSRule::visitChildren):
  12553. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  12554. (WebCore::JSCSSStyleDeclaration::visitChildren):
  12555. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  12556. (WebCore::JSCanvasRenderingContext::visitChildren):
  12557. * bindings/js/JSDOMGlobalObject.cpp:
  12558. (WebCore::JSDOMGlobalObject::visitChildren):
  12559. (WebCore::JSDOMGlobalObject::setInjectedScript):
  12560. * bindings/js/JSDOMWindowCustom.cpp:
  12561. (WebCore::JSDOMWindow::visitChildren):
  12562. * bindings/js/JSDOMWindowShell.cpp:
  12563. (WebCore::JSDOMWindowShell::visitChildren):
  12564. * bindings/js/JSEventListener.cpp:
  12565. (WebCore::JSEventListener::JSEventListener):
  12566. * bindings/js/JSEventListener.h:
  12567. (WebCore::JSEventListener::jsFunction):
  12568. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  12569. (WebCore::JSJavaScriptAudioNode::visitChildren):
  12570. * bindings/js/JSMessageChannelCustom.cpp:
  12571. (WebCore::JSMessageChannel::visitChildren):
  12572. * bindings/js/JSMessagePortCustom.cpp:
  12573. (WebCore::JSMessagePort::visitChildren):
  12574. * bindings/js/JSNamedNodeMapCustom.cpp:
  12575. (WebCore::JSNamedNodeMap::visitChildren):
  12576. * bindings/js/JSNodeCustom.cpp:
  12577. (WebCore::JSNode::visitChildren):
  12578. * bindings/js/JSNodeFilterCustom.cpp:
  12579. (WebCore::JSNodeFilter::visitChildren):
  12580. * bindings/js/JSNodeIteratorCustom.cpp:
  12581. (WebCore::JSNodeIterator::visitChildren):
  12582. * bindings/js/JSSVGElementInstanceCustom.cpp:
  12583. (WebCore::JSSVGElementInstance::visitChildren):
  12584. * bindings/js/JSSharedWorkerCustom.cpp:
  12585. (WebCore::JSSharedWorker::visitChildren):
  12586. * bindings/js/JSStyleSheetCustom.cpp:
  12587. (WebCore::JSStyleSheet::visitChildren):
  12588. * bindings/js/JSTreeWalkerCustom.cpp:
  12589. (WebCore::JSTreeWalker::visitChildren):
  12590. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  12591. (WebCore::JSWebGLRenderingContext::visitChildren):
  12592. * bindings/js/JSWorkerContextCustom.cpp:
  12593. (WebCore::JSWorkerContext::visitChildren):
  12594. * bindings/js/JSXMLHttpRequestCustom.cpp:
  12595. (WebCore::JSXMLHttpRequest::visitChildren):
  12596. * bindings/js/JSXPathResultCustom.cpp:
  12597. (WebCore::JSXPathResult::visitChildren):
  12598. * bindings/scripts/CodeGeneratorJS.pm:
  12599. 2011-05-14 Oliver Hunt <oliver@apple.com>
  12600. Reviewed by Anders Carlsson.
  12601. Make Qt bindings GC safe
  12602. https://bugs.webkit.org/show_bug.cgi?id=60841
  12603. Trying to do cache management by using "this" as a key from a GC
  12604. object's destructor leads to a violation of GC semantics. Make
  12605. the qt bindings use a Weak<> handle for finalization.
  12606. * bridge/qt/qt_runtime.cpp:
  12607. (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  12608. (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
  12609. * bridge/qt/qt_runtime.h:
  12610. (JSC::Bindings::QtRuntimeMethodData::finalize):
  12611. 2011-05-14 Ryosuke Niwa <rniwa@webkit.org>
  12612. Reviewed by Eric Seidel.
  12613. Make canHaveChildrenForEditing more efficient
  12614. https://bugs.webkit.org/show_bug.cgi?id=53564
  12615. Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
  12616. canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
  12617. node for a position.
  12618. As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
  12619. and any elements except:
  12620. HTML: applet, br, embed, frame, frameset, hr (unless has children), img, input, keygen,
  12621. meter, object (unless uses fallback content), output, progress, select, and textarea.
  12622. No new tests are added since this change cannot be tested directly.
  12623. * dom/Document.h:
  12624. (WebCore::Document::canContainRangeEndPoint): Added; returns false.
  12625. * dom/DocumentFragment.h:
  12626. (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
  12627. * dom/Element.h:
  12628. (WebCore::Element::canContainRangeEndPoint): Ditto.
  12629. * dom/Node.h:
  12630. (WebCore::Node::canContainRangeEndPoint): Added; returns false.
  12631. * dom/Text.h:
  12632. (WebCore::Text::canContainRangeEndPoint): Added; returns true.
  12633. * editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
  12634. * editing/htmlediting.h:
  12635. (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline.
  12636. (WebCore::canHaveChildrenForEditing): Ditto.
  12637. * html/HTMLBRElement.h:
  12638. (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
  12639. * html/HTMLButtonElement.h:
  12640. (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
  12641. * html/HTMLFormControlElement.h:
  12642. (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
  12643. * html/HTMLFrameElementBase.h:
  12644. (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
  12645. * html/HTMLImageElement.h:
  12646. (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
  12647. * html/HTMLMeterElement.h:
  12648. (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
  12649. * html/HTMLOutputElement.h:
  12650. (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
  12651. * html/HTMLPlugInElement.h:
  12652. (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
  12653. * html/HTMLProgressElement.h:
  12654. (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
  12655. * html/HTMLHRElement.h:
  12656. (WebCore::HTMLHRElement::canContainRangeEndPoint): Added; returns true iff it has children.
  12657. * html/HTMLObjectElement.h:
  12658. (WebCore::HTMLObjectElement::canContainRangeEndPoint): Added; returns true iff it uses fallback
  12659. content.
  12660. 2011-05-14 Jeremy Noble <jer.noble@apple.com>
  12661. Reviewed by Darin Adler.
  12662. Exiting full screen causes <video> element inline controls to become visible
  12663. https://bugs.webkit.org/show_bug.cgi?id=60142
  12664. Create a queue of elements who must be targeted with webkitfullscreenchange events. Instead of dispatching
  12665. a single event with whatever the current value of m_fullScreenElement is (which may have been cleared, or
  12666. changed since the timer was asked to fire), dispatch one event for each entry in the queue.
  12667. Test: fullscreen/video-controls-override.html
  12668. * dom/Document.cpp:
  12669. (WebCore::Document::webkitDidEnterFullScreenForElement): Push current full screen element onto the
  12670. webkitfullscreenchange event delay queue.
  12671. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
  12672. (WebCore::Document::fullScreenElementRemoved): Ditto.
  12673. (WebCore::Document::fullScreenChangeDelayTimerFired): Empty the queue, dispatching a
  12674. webkitfullscreenchange event for each entry.
  12675. * dom/Document.h:
  12676. 2011-05-14 Patrick Gansterer <paroga@webkit.org>
  12677. Reviewed by Andreas Kling.
  12678. Buildfix for SharedTimerWx.cpp
  12679. https://bugs.webkit.org/show_bug.cgi?id=60829
  12680. * platform/wx/SharedTimerWx.cpp:
  12681. (WebCore::WebKitTimer::WebKitTimer):
  12682. We can't call the constructor of a base class in the body of the constructor.
  12683. 2011-05-14 Patrick Gansterer <paroga@webkit.org>
  12684. Unreviewed WinCE build fix for r86477.
  12685. Remove the global namespace prefix from GlobalLock/GlobalUnlock.
  12686. * platform/win/ClipboardUtilitiesWin.cpp:
  12687. 2011-05-14 Csaba Osztrogonác <ossy@webkit.org>
  12688. Unreviewed, rolling out r86469 and r86471, because they made hundreds tests crash on Qt.
  12689. Make GC validation more aggressive
  12690. https://bugs.webkit.org/show_bug.cgi?id=60802
  12691. * bindings/js/JSAttrCustom.cpp:
  12692. (WebCore::JSAttr::visitChildren):
  12693. * bindings/js/JSAudioContextCustom.cpp:
  12694. (WebCore::JSAudioContext::visitChildren):
  12695. * bindings/js/JSCSSRuleCustom.cpp:
  12696. (WebCore::JSCSSRule::visitChildren):
  12697. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  12698. (WebCore::JSCSSStyleDeclaration::visitChildren):
  12699. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  12700. (WebCore::JSCanvasRenderingContext::visitChildren):
  12701. * bindings/js/JSDOMGlobalObject.cpp:
  12702. (WebCore::JSDOMGlobalObject::visitChildren):
  12703. (WebCore::JSDOMGlobalObject::setInjectedScript):
  12704. * bindings/js/JSDOMWindowCustom.cpp:
  12705. (WebCore::JSDOMWindow::visitChildren):
  12706. * bindings/js/JSDOMWindowShell.cpp:
  12707. (WebCore::JSDOMWindowShell::visitChildren):
  12708. * bindings/js/JSEventListener.cpp:
  12709. (WebCore::JSEventListener::JSEventListener):
  12710. * bindings/js/JSEventListener.h:
  12711. (WebCore::JSEventListener::jsFunction):
  12712. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  12713. (WebCore::JSJavaScriptAudioNode::visitChildren):
  12714. * bindings/js/JSMessageChannelCustom.cpp:
  12715. (WebCore::JSMessageChannel::visitChildren):
  12716. * bindings/js/JSMessagePortCustom.cpp:
  12717. (WebCore::JSMessagePort::visitChildren):
  12718. * bindings/js/JSNamedNodeMapCustom.cpp:
  12719. (WebCore::JSNamedNodeMap::visitChildren):
  12720. * bindings/js/JSNodeCustom.cpp:
  12721. (WebCore::JSNode::visitChildren):
  12722. * bindings/js/JSNodeFilterCustom.cpp:
  12723. (WebCore::JSNodeFilter::visitChildren):
  12724. * bindings/js/JSNodeIteratorCustom.cpp:
  12725. (WebCore::JSNodeIterator::visitChildren):
  12726. * bindings/js/JSSVGElementInstanceCustom.cpp:
  12727. (WebCore::JSSVGElementInstance::visitChildren):
  12728. * bindings/js/JSSharedWorkerCustom.cpp:
  12729. (WebCore::JSSharedWorker::visitChildren):
  12730. * bindings/js/JSStyleSheetCustom.cpp:
  12731. (WebCore::JSStyleSheet::visitChildren):
  12732. * bindings/js/JSTreeWalkerCustom.cpp:
  12733. (WebCore::JSTreeWalker::visitChildren):
  12734. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  12735. (WebCore::JSWebGLRenderingContext::visitChildren):
  12736. * bindings/js/JSWorkerContextCustom.cpp:
  12737. (WebCore::JSWorkerContext::visitChildren):
  12738. * bindings/js/JSXMLHttpRequestCustom.cpp:
  12739. (WebCore::JSXMLHttpRequest::visitChildren):
  12740. * bindings/js/JSXPathResultCustom.cpp:
  12741. (WebCore::JSXPathResult::visitChildren):
  12742. * bindings/scripts/CodeGeneratorJS.pm:
  12743. 2011-05-13 Alexey Proskuryakov <ap@apple.com>
  12744. Reviewed by Darin Adler.
  12745. HTML5 Application Cache Update Failures on Page Refresh
  12746. https://bugs.webkit.org/show_bug.cgi?id=60598
  12747. <rdar://problem/9418639>
  12748. Test: http/tests/appcache/interrupted-update.html
  12749. The reason was two-fold:
  12750. 1) Cache group state wasn't fully reset after a failed cache update (or an initial load).
  12751. 2) The cache group is not deleted until after after the navigation (from autorelease pool),
  12752. so the failed and sorry old version was picked up by cache selection algorithm.
  12753. The latter is more of a surprising behavior than a problem in itself. Keeping an appcache in
  12754. memory for reload is generally a good thing for performance.
  12755. * loader/appcache/ApplicationCacheGroup.cpp:
  12756. (WebCore::ApplicationCacheGroup::stopLoading): Added a FIXME about half-baked state resetting
  12757. code that sent me looking for a wrong fix originally.
  12758. (WebCore::ApplicationCacheGroup::stopLoadingInFrame): Stopped load is an update failure like
  12759. any other, so we should call cacheUpdateFailed(), which knows how to reset state.
  12760. 2011-05-13 Enrica Casucci <enrica@apple.com>
  12761. Reviewed by Darin Adler and Brian Weinstein.
  12762. REGRESSION (WK2): Can't drag and drop a link or image from Safari to Desktop
  12763. https://bugs.webkit.org/show_bug.cgi?id=60819
  12764. <rdar://problem/9370689>
  12765. To support drag-and-drop to the desktop and other windows applications,
  12766. we need to support the fileDescriptor and fileContentZero clipboard formats.
  12767. This patch adds the support for serializing these types across the process boundary.
  12768. It also fixes a regression introduced by r70914, that was causing the content of the
  12769. shortcut files to be corrupted. Using ascii() to convert from String to CString was
  12770. causing '\n' and '\r' to be replaced with '?'.
  12771. * platform/DragData.h:
  12772. * platform/win/ClipboardUtilitiesWin.cpp:
  12773. (WebCore::fileDescriptorFormat): Moved from ClipboardWin.cpp.
  12774. (WebCore::fileContentFormatZero): Moved from ClipboardWin.cpp.
  12775. (WebCore::getFileDescriptorData): Serialize FileDescriptor type.
  12776. (WebCore::getFileContentData): Serialize FileContent type.
  12777. (WebCore::setFileDescriptorData): Deserialize FileDescriptor type.
  12778. (WebCore::setFileContentData): Deserialize FileContent type.
  12779. (WebCore::setCFData): Added missing initialization of the tymed field
  12780. that was causing the cfHDrop format not to be deserialized correctly.
  12781. * platform/win/ClipboardUtilitiesWin.h:
  12782. * platform/win/ClipboardWin.cpp:
  12783. (WebCore::createGlobalHDropContent): Changed ascii() to latin1().
  12784. (WebCore::ClipboardWin::writeURL):
  12785. * platform/win/DragDataWin.cpp:
  12786. (WebCore::DragData::getDragFileDescriptorData):
  12787. (WebCore::DragData::getDragFileContentData):
  12788. 2011-05-13 Daniel Cheng <dcheng@chromium.org>
  12789. Fix the build.
  12790. Add includes that the builders are suddenly complaining about...
  12791. * page/DragState.h:
  12792. 2011-05-13 Daniel Cheng <dcheng@chromium.org>
  12793. Reviewed by Tony Chang.
  12794. Improve drag start logic
  12795. https://bugs.webkit.org/show_bug.cgi?id=59409
  12796. Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
  12797. defined in the spec. Among other things:
  12798. - draggableNode() no longer returns text nodes when dragging anchors.
  12799. - When starting a drag over an image in a selection, prefer to drag the selection.
  12800. - Several redundant hit tests have been removed.
  12801. - Minor refactoring to make the logic easier to follow.
  12802. Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html
  12803. * WebCore.xcodeproj/project.pbxproj:
  12804. * page/DragController.cpp:
  12805. (WebCore::DragController::draggableNode):
  12806. (WebCore::DragController::startDrag):
  12807. * page/DragController.h:
  12808. * page/DragState.h:
  12809. (WebCore::DragState::shouldDispatchEvents):
  12810. * page/EventHandler.cpp:
  12811. (WebCore::EventHandler::EventHandler):
  12812. (WebCore::EventHandler::eventMayStartDrag):
  12813. (WebCore::EventHandler::updateDragSourceActionsAllowed):
  12814. (WebCore::EventHandler::updateDragAndDrop):
  12815. (WebCore::EventHandler::cancelDragAndDrop):
  12816. (WebCore::EventHandler::dragHysteresisExceeded):
  12817. (WebCore::EventHandler::dragSourceEndedAt):
  12818. (WebCore::ExactlyOneBitSet):
  12819. (WebCore::EventHandler::handleDrag):
  12820. * page/EventHandler.h:
  12821. 2011-05-13 Oliver Hunt <oliver@apple.com>
  12822. Reviewed by Geoffrey Garen.
  12823. Make GC validation more aggressive
  12824. https://bugs.webkit.org/show_bug.cgi?id=60802
  12825. This makes GC_VALIDATION much more aggressive in webcore,
  12826. adding logic to every visitChildren method to ensure that
  12827. the structure still has correct flags.
  12828. Additionally every function generated for the dom bindings
  12829. makes use of the new GC_VALIDATION object assertions to further
  12830. ensure that the object appears to be sensible.
  12831. * bindings/js/JSAttrCustom.cpp:
  12832. (WebCore::JSAttr::visitChildren):
  12833. * bindings/js/JSAudioContextCustom.cpp:
  12834. (WebCore::JSAudioContext::visitChildren):
  12835. * bindings/js/JSCSSRuleCustom.cpp:
  12836. (WebCore::JSCSSRule::visitChildren):
  12837. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  12838. (WebCore::JSCSSStyleDeclaration::visitChildren):
  12839. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  12840. (WebCore::JSCanvasRenderingContext::visitChildren):
  12841. * bindings/js/JSDOMGlobalObject.cpp:
  12842. (WebCore::JSDOMGlobalObject::visitChildren):
  12843. (WebCore::JSDOMGlobalObject::setInjectedScript):
  12844. * bindings/js/JSDOMWindowCustom.cpp:
  12845. (WebCore::JSDOMWindow::visitChildren):
  12846. * bindings/js/JSDOMWindowShell.cpp:
  12847. (WebCore::JSDOMWindowShell::visitChildren):
  12848. * bindings/js/JSEventListener.cpp:
  12849. (WebCore::JSEventListener::JSEventListener):
  12850. * bindings/js/JSEventListener.h:
  12851. (WebCore::JSEventListener::jsFunction):
  12852. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  12853. (WebCore::JSJavaScriptAudioNode::visitChildren):
  12854. * bindings/js/JSMessageChannelCustom.cpp:
  12855. (WebCore::JSMessageChannel::visitChildren):
  12856. * bindings/js/JSMessagePortCustom.cpp:
  12857. (WebCore::JSMessagePort::visitChildren):
  12858. * bindings/js/JSNamedNodeMapCustom.cpp:
  12859. (WebCore::JSNamedNodeMap::visitChildren):
  12860. * bindings/js/JSNodeCustom.cpp:
  12861. (WebCore::JSNode::visitChildren):
  12862. * bindings/js/JSNodeFilterCustom.cpp:
  12863. (WebCore::JSNodeFilter::visitChildren):
  12864. * bindings/js/JSNodeIteratorCustom.cpp:
  12865. (WebCore::JSNodeIterator::visitChildren):
  12866. * bindings/js/JSSVGElementInstanceCustom.cpp:
  12867. (WebCore::JSSVGElementInstance::visitChildren):
  12868. * bindings/js/JSSharedWorkerCustom.cpp:
  12869. (WebCore::JSSharedWorker::visitChildren):
  12870. * bindings/js/JSStyleSheetCustom.cpp:
  12871. (WebCore::JSStyleSheet::visitChildren):
  12872. * bindings/js/JSTreeWalkerCustom.cpp:
  12873. (WebCore::JSTreeWalker::visitChildren):
  12874. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  12875. (WebCore::JSWebGLRenderingContext::visitChildren):
  12876. * bindings/js/JSWorkerContextCustom.cpp:
  12877. (WebCore::JSWorkerContext::visitChildren):
  12878. * bindings/js/JSXMLHttpRequestCustom.cpp:
  12879. (WebCore::JSXMLHttpRequest::visitChildren):
  12880. * bindings/js/JSXPathResultCustom.cpp:
  12881. (WebCore::JSXPathResult::visitChildren):
  12882. * bindings/scripts/CodeGeneratorJS.pm:
  12883. 2011-05-13 Mikhail Naganov <mnaganov@chromium.org>
  12884. Web Inspector: Unreviewed image glyph position fix in CSS after r85588.
  12885. * inspector/front-end/heapProfiler.css:
  12886. (.heapshot-help-status-bar-item .glyph):
  12887. 2011-05-13 Adam Barth <abarth@webkit.org>
  12888. Reviewed by Eric Seidel.
  12889. iframe sandbox doesn't properly block popups
  12890. https://bugs.webkit.org/show_bug.cgi?id=60784
  12891. Previously, we weren't implementing this requirement from the spec:
  12892. "This flag also prevents content from creating new auxiliary browsing
  12893. contexts, e.g. using the target attribute or the window.open() method."
  12894. Tests: http/tests/security/no-popup-from-sandbox-top.html
  12895. http/tests/security/no-popup-from-sandbox.html
  12896. * loader/PolicyChecker.cpp:
  12897. (WebCore::PolicyChecker::checkNewWindowPolicy):
  12898. 2011-05-13 Ryosuke Niwa <rniwa@webkit.org>
  12899. Reviewed by Darin Adler.
  12900. click event shouldn't fire when the target is ever removed in mouseup
  12901. https://bugs.webkit.org/show_bug.cgi?id=60600
  12902. Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
  12903. from the document. New behavior matches Internet Explorer and Firefox.
  12904. Tests: fast/events/remove-target-in-mouseup-deep.html
  12905. fast/events/remove-target-in-mouseup-insertback.html
  12906. fast/events/remove-target-in-mouseup-twice.html
  12907. fast/events/remove-target-in-mouseup.html
  12908. * dom/Document.cpp:
  12909. (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
  12910. (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
  12911. * page/EventHandler.cpp:
  12912. (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode
  12913. or one of its ancestor is removed from the document.
  12914. * page/EventHandler.h:
  12915. 2011-05-13 Alexey Proskuryakov <ap@apple.com>
  12916. Reviewed by Joseph Pecoraro.
  12917. Hide appcache status bar items
  12918. https://bugs.webkit.org/show_bug.cgi?id=60799
  12919. We have a number of non-trivial bugs that make these more misleading than helpful to developers.
  12920. * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
  12921. Just hide the items for now. Removing all support code would be complicated, and not helpful.
  12922. 2011-05-13 Adam Barth <abarth@webkit.org>
  12923. Reviewed by Eric Seidel.
  12924. indexedDB is visible inside iframe sandbox
  12925. https://bugs.webkit.org/show_bug.cgi?id=60785
  12926. We're supposed to return a null indexedDB factory when inside an iframe
  12927. sandbox.
  12928. Test: http/tests/security/no-indexeddb-from-sandbox.html
  12929. * page/DOMWindow.cpp:
  12930. (WebCore::DOMWindow::webkitIndexedDB):
  12931. 2011-05-13 Adam Roben <aroben@apple.com>
  12932. Fix manual tests that got broken by the move of WebCore into Source
  12933. * manual-tests/plugins/object-clipping.html:
  12934. * manual-tests/pointer-events.html:
  12935. * manual-tests/video-waiting-seeking.html:
  12936. Updated some paths.
  12937. 2011-05-13 Nat Duca <nduca@chromium.org>
  12938. Reviewed by James Robinson.
  12939. [chromium] compositing tests are failing
  12940. https://bugs.webkit.org/show_bug.cgi?id=60738
  12941. Bind texture before setting its filtering state.
  12942. * platform/graphics/chromium/LayerTilerChromium.cpp:
  12943. (WebCore::LayerTilerChromium::updateFromPixels):
  12944. 2011-05-13 Alexey Proskuryakov <ap@apple.com>
  12945. Reviewed by Dan Bernstein.
  12946. https://bugs.webkit.org/show_bug.cgi?id=60787
  12947. Add some assertions to ApplicationCacheGroup
  12948. * loader/appcache/ApplicationCacheGroup.cpp:
  12949. (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow.
  12950. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
  12951. (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before
  12952. resetting it.
  12953. (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or
  12954. resource hanging around.
  12955. (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
  12956. 2011-05-13 Sam Weinig <sam@webkit.org>
  12957. Reviewed by Anders Carlsson.
  12958. Prune #includes from FrameView.h (Part 2)
  12959. https://bugs.webkit.org/show_bug.cgi?id=60748
  12960. - Replace #includes in FrameView.h of Frame.h and Page.h
  12961. with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
  12962. - Update files that were depending on FrameView.h #including Frame.h or
  12963. Page.h.
  12964. * GNUmakefile.list.am:
  12965. * WebCore.exp.in:
  12966. * WebCore.pro:
  12967. * WebCore.vcproj/WebCore.vcproj:
  12968. * WebCore.xcodeproj/project.pbxproj:
  12969. * accessibility/AccessibilityRenderObject.cpp:
  12970. * accessibility/AccessibilityScrollView.cpp:
  12971. * accessibility/chromium/AXObjectCacheChromium.cpp:
  12972. * accessibility/mac/AccessibilityObjectWrapper.mm:
  12973. * css/MediaQueryMatcher.cpp:
  12974. * dom/Range.cpp:
  12975. * editing/SpellingCorrectionController.cpp:
  12976. * history/CachedFrame.cpp:
  12977. * html/HTMLBodyElement.cpp:
  12978. * html/canvas/WebGLRenderingContext.cpp:
  12979. * html/parser/HTMLParserScheduler.cpp:
  12980. * page/AdjustViewSizeOrNot.h: Added.
  12981. * page/EditorClient.h:
  12982. * page/Frame.h:
  12983. * page/FrameView.cpp:
  12984. (WebCore::FrameView::forceLayoutForPagination):
  12985. * page/FrameView.h:
  12986. * page/PrintContext.cpp:
  12987. (WebCore::PrintContext::begin):
  12988. (WebCore::PrintContext::end):
  12989. * page/chromium/FrameChromium.cpp:
  12990. * page/win/FrameCGWin.cpp:
  12991. * page/win/FrameWin.cpp:
  12992. * platform/efl/PopupMenuEfl.cpp:
  12993. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  12994. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12995. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  12996. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  12997. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  12998. * platform/gtk/WidgetGtk.cpp:
  12999. * plugins/IFrameShimSupport.cpp:
  13000. * rendering/RenderBlock.cpp:
  13001. * rendering/RenderBoxModelObject.cpp:
  13002. * rendering/RenderFrameBase.cpp:
  13003. * rendering/RenderIFrame.cpp:
  13004. * rendering/RenderMenuList.cpp:
  13005. * rendering/RenderTextControlSingleLine.cpp:
  13006. * rendering/RenderWidget.cpp:
  13007. * svg/SVGSVGElement.cpp:
  13008. 2011-05-13 Levi Weintraub <leviw@chromium.org>
  13009. Reviewed by Eric Seidel.
  13010. Switch paintCollapsedBorder to use IntRect
  13011. https://bugs.webkit.org/show_bug.cgi?id=60739
  13012. Updating the last offending paint function that takes four ints
  13013. instead of an IntRect.
  13014. No new tests as this is simple refactoring.
  13015. * rendering/RenderTableCell.cpp:
  13016. (WebCore::RenderTableCell::paint):
  13017. (WebCore::RenderTableCell::paintCollapsedBorder):
  13018. * rendering/RenderTableCell.h:
  13019. 2011-05-13 Abhishek Arya <inferno@chromium.org>
  13020. Reviewed by Dave Hyatt.
  13021. Regression(r75823): Revert initialization back to the first RenderBlock
  13022. in the parent chain.
  13023. https://bugs.webkit.org/show_bug.cgi?id=60780
  13024. Test: fast/block/float/float-not-removed-crash.html
  13025. * rendering/RenderBox.cpp:
  13026. (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
  13027. In r75823, I forgot to initialize parentBlock, when the original code
  13028. did and Hyatt did mention in c#5. Now, initializing parentBlock to the
  13029. first RenderBlock in the parent chain.
  13030. 2011-05-05 Pavel Podivilov <podivilov@chromium.org>
  13031. Reviewed by Yury Semikhatsky.
  13032. Web Inspector: TextEditor should support editing a range.
  13033. https://bugs.webkit.org/show_bug.cgi?id=59688
  13034. * inspector/front-end/TextViewer.js:
  13035. (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
  13036. (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
  13037. (WebInspector.TextEditorMainPanel.prototype.setEditableRange):
  13038. (WebInspector.TextEditorMainPanel.prototype.clearEditableRange):
  13039. (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
  13040. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  13041. (WebInspector.TextEditorMainChunk):
  13042. (WebInspector.TextEditorMainChunk.prototype.set expanded):
  13043. (WebInspector.TextEditorMainChunk.prototype.set readOnly):
  13044. (WebInspector.TextEditorMainChunk.prototype.get readOnly):
  13045. (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
  13046. * inspector/front-end/textViewer.css:
  13047. (.text-editor-read-only):
  13048. 2011-05-05 Pavel Podivilov <podivilov@chromium.org>
  13049. Reviewed by Yury Semikhatsky.
  13050. Web Inspector: fix source mapping for formatted scripts.
  13051. https://bugs.webkit.org/show_bug.cgi?id=60263
  13052. Source mapping is broken for script chunks that are already formatted at the beginning
  13053. and at the end of the script (see script-formatter.html).
  13054. * inspector/front-end/ScriptFormatter.js:
  13055. (WebInspector.ScriptFormatter.prototype._didFormatContent):
  13056. (WebInspector.FormattedSourceMapping):
  13057. (WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
  13058. (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):
  13059. (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  13060. * inspector/front-end/ScriptFormatterWorker.js:
  13061. (onmessage):
  13062. (HTMLScriptFormatter.prototype.format):
  13063. * inspector/front-end/SourceFile.js:
  13064. (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  13065. (WebInspector.SourceMappingForFormattedSourceFile):
  13066. (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine):
  13067. (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
  13068. 2011-05-13 Adam Roben <aroben@apple.com>
  13069. Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect
  13070. changes
  13071. r79167 moved some code from setFrameRect to setBoundsSize, including a call to
  13072. frameRectsChanged. This was done because positionScrollbarLayers, which is called by
  13073. frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
  13074. changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
  13075. frame rect changes.
  13076. This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
  13077. to be called at different times from frameRectsChanged. Then it restores the
  13078. frameRectsChanged call to setFrameRect, which fixes the bug.
  13079. Test: platform/win/plugins/iframe-inside-overflow.html
  13080. Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
  13081. plugins in Google Reader don't move when the article list is scrolled
  13082. Reviewed by Dan Bernstein.
  13083. * platform/ScrollView.cpp:
  13084. (WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
  13085. frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
  13086. call frameRectsChanged here when our frame rect hasn't changed.
  13087. (WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
  13088. in r79167.
  13089. (WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
  13090. positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
  13091. positionScrollbarLayers to be called.
  13092. (WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
  13093. callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.
  13094. 2011-05-13 Martin Robinson <mrobinson@igalia.com>
  13095. Reviewed by Eric Seidel.
  13096. [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
  13097. https://bugs.webkit.org/show_bug.cgi?id=59765
  13098. Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
  13099. almost directly moved from the WebKit layer.
  13100. No new tests. This is covered by the editing tests.
  13101. * GNUmakefile.list.am:
  13102. * platform/gtk/KeyBindingTranslator.cpp: Added.
  13103. (WebCore::backspaceCallback):Added.
  13104. (WebCore::selectAllCallback):Added.
  13105. (WebCore::cutClipboardCallback):Added.
  13106. (WebCore::copyClipboardCallback):Added.
  13107. (WebCore::pasteClipboardCallback):Added.
  13108. (WebCore::toggleOverwriteCallback):Added.
  13109. (WebCore::popupMenuCallback):Added.
  13110. (WebCore::showHelpCallback):Added.
  13111. (WebCore::deleteFromCursorCallback):Added.
  13112. (WebCore::moveCursorCallback):Added.
  13113. (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added.
  13114. (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
  13115. * platform/gtk/KeyBindingTranslator.h: Added.
  13116. (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.
  13117. 2011-05-01 Holger Hans Peter Freyther <holger@moiji-mobile.com>
  13118. Reviewed by Adam Barth.
  13119. [android] Forward declare types for PlatformWidget and DragImage
  13120. https://bugs.webkit.org/show_bug.cgi?id=59890
  13121. This is a simple build fix.
  13122. * platform/DragImage.h:
  13123. * platform/Widget.h:
  13124. 2011-05-06 Pavel Podivilov <podivilov@chromium.org>
  13125. Reviewed by Yury Semikhatsky.
  13126. Web Inspector: fix incremental html highlight.
  13127. https://bugs.webkit.org/show_bug.cgi?id=60163
  13128. SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
  13129. various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
  13130. initialCondition object via condition link). This all worked because of another bug in tokenizers registry
  13131. that always returned new tokenizer object.
  13132. For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
  13133. state from string. That's why we need tokenizers to be truly stateless.
  13134. * inspector/front-end/DOMSyntaxHighlighter.js:
  13135. (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  13136. * inspector/front-end/SourceCSSTokenizer.js:
  13137. (WebInspector.SourceCSSTokenizer):
  13138. (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
  13139. * inspector/front-end/SourceCSSTokenizer.re2js:
  13140. * inspector/front-end/SourceHTMLTokenizer.js:
  13141. (WebInspector.SourceHTMLTokenizer):
  13142. (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition):
  13143. (WebInspector.SourceHTMLTokenizer.prototype.set line):
  13144. (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer):
  13145. (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer):
  13146. (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
  13147. (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
  13148. (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  13149. * inspector/front-end/SourceHTMLTokenizer.re2js:
  13150. * inspector/front-end/SourceJavaScriptTokenizer.js:
  13151. (WebInspector.SourceJavaScriptTokenizer):
  13152. (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
  13153. * inspector/front-end/SourceJavaScriptTokenizer.re2js:
  13154. * inspector/front-end/SourceTokenizer.js:
  13155. (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  13156. * inspector/front-end/TextEditorHighlighter.js:
  13157. (WebInspector.TextEditorHighlighter.prototype._highlightLines):
  13158. 2011-05-13 Adam Roben <aroben@apple.com>
  13159. Build fix after r86418
  13160. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  13161. Made the destructor public so that this class can be used with
  13162. [Pass]OwnPtr.
  13163. 2011-05-11 Hans Wennborg <hans@chromium.org>
  13164. Reviewed by Tony Gentilcore.
  13165. IndexedDB: Fix integer comparison bug in LevelDB coding routines
  13166. https://bugs.webkit.org/show_bug.cgi?id=60623
  13167. Fix the code for comparing two int64_t variables.
  13168. Also remove faulty line in ObjectStoreNamesKey::encode which was
  13169. uncovered by the unit test in this patch.
  13170. Very hard to cover with layout tests; covered by unit test.
  13171. * storage/IDBLevelDBCoding.cpp:
  13172. (WebCore::IDBLevelDBCoding::compareInts):
  13173. (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
  13174. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
  13175. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
  13176. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
  13177. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
  13178. (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
  13179. (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
  13180. (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
  13181. (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
  13182. 2011-05-13 Andrew Wason <rectalogic@rectalogic.com>
  13183. Reviewed by Darin Adler.
  13184. GraphicsContext3DQt.cpp fails to compile
  13185. https://bugs.webkit.org/show_bug.cgi?id=60740
  13186. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  13187. (WebCore::GraphicsContext3D::GraphicsContext3D):
  13188. Change order of initializers.
  13189. 2011-05-05 Hans Wennborg <hans@chromium.org>
  13190. Reviewed by Steve Block.
  13191. IndexedDB: Transaction rollback prevented by open SQLite statement
  13192. https://bugs.webkit.org/show_bug.cgi?id=60032
  13193. Let the IDBTransactionbackendImpl keep track of all open cursors, and
  13194. "close" them (i.e. finalizing the underlying SQLiteStatement) before
  13195. committing or rolling back the transaction. This fixes the problem
  13196. with opened cursors preventing transaction rollback.
  13197. Test: storage/indexeddb/transaction-rollback.html
  13198. * storage/IDBBackingStore.h:
  13199. * storage/IDBCursorBackendImpl.cpp:
  13200. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
  13201. (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl):
  13202. (WebCore::IDBCursorBackendImpl::close):
  13203. * storage/IDBCursorBackendImpl.h:
  13204. * storage/IDBLevelDBBackingStore.cpp:
  13205. * storage/IDBSQLiteBackingStore.cpp:
  13206. * storage/IDBTransactionBackendImpl.cpp:
  13207. (WebCore::IDBTransactionBackendImpl::abort):
  13208. (WebCore::IDBTransactionBackendImpl::registerOpenCursor):
  13209. (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor):
  13210. (WebCore::IDBTransactionBackendImpl::commit):
  13211. (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
  13212. * storage/IDBTransactionBackendImpl.h:
  13213. * storage/IDBTransactionBackendInterface.h:
  13214. (WebCore::IDBTransactionBackendInterface::registerOpenCursor):
  13215. (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):
  13216. 2011-05-13 Patrick Gansterer <paroga@webkit.org>
  13217. Reviewed by Adam Barth.
  13218. Enable OwnPtr strict mode in MediaPlayer
  13219. https://bugs.webkit.org/show_bug.cgi?id=59466
  13220. Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
  13221. Also fix the templete argument of OwnPtr for the m_private member variable.
  13222. * platform/graphics/MediaPlayer.cpp:
  13223. (WebCore::MediaPlayer::MediaPlayer):
  13224. (WebCore::MediaPlayer::loadWithNextMediaEngine):
  13225. * platform/graphics/MediaPlayer.h:
  13226. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  13227. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  13228. (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
  13229. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  13230. (WebCore::MediaPlayerPrivateGStreamer::create):
  13231. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  13232. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  13233. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  13234. (WebCore::MediaPlayerPrivateQTKit::create):
  13235. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  13236. (WebCore::MediaPlayerPrivatePhonon::create):
  13237. * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  13238. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  13239. (WebCore::MediaPlayerPrivateQt::create):
  13240. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  13241. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  13242. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
  13243. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  13244. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  13245. (WebCore::MediaPlayerPrivate::create):
  13246. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  13247. * platform/graphics/wince/MediaPlayerPrivateWinCE.h:
  13248. 2011-05-13 Alexey Proskuryakov <ap@apple.com>
  13249. Reviewed by Pavel Feldman.
  13250. Web Inspector: Show Error Messages for Application Cache Errors
  13251. https://bugs.webkit.org/show_bug.cgi?id=41642
  13252. * loader/appcache/ApplicationCacheGroup.cpp:
  13253. (WebCore::ApplicationCacheGroup::didReceiveResponse):
  13254. (WebCore::ApplicationCacheGroup::didFail):
  13255. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
  13256. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  13257. (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
  13258. Added console error logging.
  13259. 2011-05-12 Pratik Solanki <psolanki@apple.com>
  13260. Reviewed by Antti Koivisto.
  13261. Part of WebCore should use CFNetwork-based loader on Mac
  13262. https://bugs.webkit.org/show_bug.cgi?id=51836
  13263. Fixes for warnings and other minor cleanups when we enable USE_CFNETWORK on Mac.
  13264. * platform/network/cf/ResourceErrorCF.cpp:
  13265. (WebCore::ResourceError::cfStreamError):
  13266. * platform/network/cf/ResourceHandleCFNet.cpp:
  13267. (WebCore::allowsAnyHTTPSCertificateHosts):
  13268. (WebCore::clientCerts):
  13269. (WebCore::willSendRequest):
  13270. (WebCore::didReceiveResponse):
  13271. (WebCore::didReceiveData):
  13272. (WebCore::didSendBodyData):
  13273. (WebCore::shouldUseCredentialStorageCallback):
  13274. (WebCore::didFinishLoading):
  13275. (WebCore::didFail):
  13276. (WebCore::didReceiveChallenge):
  13277. (WebCore::makeFinalRequest):
  13278. (WebCore::ResourceHandle::willLoadFromCache):
  13279. 2011-05-12 Pratik Solanki <psolanki@apple.com>
  13280. Reviewed by Antti Koivisto.
  13281. Part of WebCore should use CFNetwork-based loader on Mac
  13282. https://bugs.webkit.org/show_bug.cgi?id=51836
  13283. Implement ResourceHandle::schedule()/unschedule() based on CF for Mac.
  13284. * WebCore.exp.in:
  13285. * platform/cf/SchedulePair.h:
  13286. * platform/mac/SchedulePairMac.mm:
  13287. * platform/network/cf/ResourceHandleCFNet.cpp:
  13288. (WebCore::ResourceHandle::schedule):
  13289. (WebCore::ResourceHandle::unschedule):
  13290. 2011-05-12 Pratik Solanki <psolanki@apple.com>
  13291. Reviewed by Antti Koivisto.
  13292. Part of WebCore should use CFNetwork-based loader on Mac
  13293. https://bugs.webkit.org/show_bug.cgi?id=51836
  13294. Implement mac specific Authentication functions when using CFNetwork.
  13295. * WebCore.exp.in:
  13296. * WebCore.xcodeproj/project.pbxproj:
  13297. * platform/network/ResourceHandle.h:
  13298. * platform/network/cf/AuthenticationCF.cpp:
  13299. (WebCore::AuthenticationChallenge::authenticationClient):
  13300. (WebCore::createCF):
  13301. (WebCore::core):
  13302. * platform/network/cf/AuthenticationCF.h:
  13303. * platform/network/cf/AuthenticationChallenge.h:
  13304. * platform/network/mac/AuthenticationMac.mm:
  13305. (WebCore::core):
  13306. (WebCore::mac):
  13307. * platform/network/mac/CredentialStorageMac.mm:
  13308. 2011-05-12 Ben Wells <benwells@chromium.org>
  13309. Reviewed by Simon Fraser.
  13310. RGBA colors in outlines show overpainting at the corners
  13311. https://bugs.webkit.org/show_bug.cgi?id=58999
  13312. Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.
  13313. * rendering/RenderInline.cpp:
  13314. (WebCore::RenderInline::paintOutline):
  13315. * rendering/RenderObject.cpp:
  13316. (WebCore::RenderObject::paintOutline):
  13317. 2011-05-12 Adele Peterson <adele@apple.com>
  13318. Reviewed by Darin Adler and Adam Barth.
  13319. Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
  13320. https://bugs.webkit.org/show_bug.cgi?id=60685
  13321. Detect the Solar Walk application so we can add targeted parser quirks.
  13322. * WebCore.exp.in:
  13323. * platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsSolarWalk):
  13324. * platform/RuntimeApplicationChecks.h:
  13325. 2011-05-12 Jia Pu <jpu@apple.com>
  13326. Reviewed by Darin Adler.
  13327. Regression caused by changeset 86281
  13328. https://bugs.webkit.org/show_bug.cgi?id=60712
  13329. Changed wording in some tests to reflect AppKit UI change.
  13330. * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
  13331. * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:
  13332. 2011-05-12 Daniel Bates <dbates@rim.com>
  13333. Attempt to fix the build after changeset 86391 <http://trac.webkit.org/changeset/86391>
  13334. (https://bugs.webkit.org/show_bug.cgi?id=60681).
  13335. * page/PluginHalter.cpp:
  13336. (WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr
  13337. so it becomes 0 when assigned to another variable.
  13338. 2011-05-12 Patrick Gansterer <paroga@webkit.org>
  13339. Reviewed by Darin Adler.
  13340. Rename SimpleFontData::scaledFontData to createScaledFontData
  13341. https://bugs.webkit.org/show_bug.cgi?id=60723
  13342. * platform/graphics/SimpleFontData.h:
  13343. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  13344. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  13345. * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  13346. * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
  13347. * platform/graphics/mac/SimpleFontDataMac.mm:
  13348. * platform/graphics/pango/SimpleFontDataPango.cpp:
  13349. * platform/graphics/qt/SimpleFontDataQt.cpp:
  13350. * platform/graphics/win/SimpleFontDataWin.cpp:
  13351. * platform/graphics/wince/SimpleFontDataWinCE.cpp:
  13352. * platform/graphics/wx/SimpleFontDataWx.cpp:
  13353. 2011-05-12 Levi Weintraub <leviw@chromium.org>
  13354. Reviewed by Simon Fraser.
  13355. Switch paintOutline to use IntRect
  13356. https://bugs.webkit.org/show_bug.cgi?id=60718
  13357. Switching paintOutline to use an IntRect instead of 4 ints.
  13358. No new tests as this is just refactoring.
  13359. * rendering/RenderBlock.cpp:
  13360. (WebCore::RenderBlock::paintObject):
  13361. * rendering/RenderObject.cpp:
  13362. (WebCore::RenderObject::paintOutline):
  13363. * rendering/RenderObject.h:
  13364. * rendering/RenderReplaced.cpp:
  13365. (WebCore::RenderReplaced::paint):
  13366. * rendering/RenderTable.cpp:
  13367. (WebCore::RenderTable::paintObject):
  13368. * rendering/svg/RenderSVGContainer.cpp:
  13369. (WebCore::RenderSVGContainer::paint):
  13370. * rendering/svg/RenderSVGImage.cpp:
  13371. (WebCore::RenderSVGImage::paint):
  13372. * rendering/svg/RenderSVGPath.cpp:
  13373. (WebCore::RenderSVGPath::paint):
  13374. * rendering/svg/RenderSVGRoot.cpp:
  13375. (WebCore::RenderSVGRoot::paint):
  13376. 2011-05-12 Anders Carlsson <andersca@apple.com>
  13377. Address review comment by Dan Bernstein.
  13378. * loader/DocumentLoader.cpp:
  13379. (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  13380. 2011-05-12 Anders Carlsson <andersca@apple.com>
  13381. Reviewed by Dan Bernstein.
  13382. Crash when a plug-in tries to load a resource from the application cache
  13383. https://bugs.webkit.org/show_bug.cgi?id=60735
  13384. <rdar://problem/8216142>
  13385. When loading application cache resources from disk, we would never restore the
  13386. HTTP status code, which means that resources would always have a 0 status code.
  13387. This led to the plug-in stream loader canceling the load, something which the application
  13388. cache loading machinery couldn't deal and thus would crash.
  13389. Fix the reading of the HTTP status code, and make the loader more robust against
  13390. application cache loads being canceled.
  13391. Unfortunately, I couldn't come up with a test for this because I couldn't find a reliable way
  13392. to force the application cache to be read from disk, so all resources would have valid values.
  13393. * loader/DocumentLoader.cpp:
  13394. (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  13395. * loader/appcache/ApplicationCacheStorage.cpp:
  13396. (WebCore::ApplicationCacheStorage::loadCache):
  13397. 2011-05-12 Emil A Eklund <eae@chromium.org>
  13398. Reviewed by Darin Adler.
  13399. Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize
  13400. https://bugs.webkit.org/show_bug.cgi?id=60585
  13401. Refactoring, covered by existing tests.
  13402. * rendering/RenderBox.cpp:
  13403. (WebCore::RenderBox::positionLineBox):
  13404. * rendering/RenderBox.h:
  13405. (WebCore::RenderBox::setLogicalLocation):
  13406. (WebCore::RenderBox::setLogicalSize):
  13407. (WebCore::RenderBox::setLocation):
  13408. * rendering/RenderFrameSet.cpp:
  13409. (WebCore::RenderFrameSet::positionFrames):
  13410. (WebCore::RenderFrameSet::positionFramesWithFlattening):
  13411. * rendering/RenderMedia.cpp:
  13412. (WebCore::RenderMedia::layout):
  13413. * rendering/RenderScrollbarPart.cpp:
  13414. (WebCore::RenderScrollbarPart::paintIntoRect):
  13415. * rendering/RenderTable.cpp:
  13416. (WebCore::RenderTable::adjustLogicalHeightForCaption):
  13417. (WebCore::RenderTable::layout):
  13418. * rendering/RenderTableSection.cpp:
  13419. (WebCore::RenderTableSection::layoutRows):
  13420. * rendering/RenderTextControlSingleLine.cpp:
  13421. (WebCore::RenderTextControlSingleLine::layout):
  13422. * rendering/svg/SVGRootInlineBox.cpp:
  13423. (WebCore::SVGRootInlineBox::layoutRootBox):
  13424. 2011-05-12 Adrienne Walker <enne@google.com>
  13425. Reviewed by James Robinson.
  13426. [chromium] show-composited-layer-tree crashes on null ptr deref
  13427. https://bugs.webkit.org/show_bug.cgi?id=60734
  13428. The tiler is created lazily, so it won't not be around for the first
  13429. dumpLayerProperties call.
  13430. * platform/graphics/chromium/ContentLayerChromium.cpp:
  13431. (WebCore::ContentLayerChromium::dumpLayerProperties):
  13432. 2011-05-12 Patrick Gansterer <paroga@webkit.org>
  13433. Reviewed by Adam Barth.
  13434. Enable OwnPtr strict mode in PluginHalter
  13435. https://bugs.webkit.org/show_bug.cgi?id=60681
  13436. Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.
  13437. * WebCore.exp.in:
  13438. * page/Page.cpp:
  13439. (WebCore::Page::Page):
  13440. (WebCore::Page::PageClients::PageClients):
  13441. * page/Page.h:
  13442. * page/PluginHalter.cpp:
  13443. (WebCore::PluginHalter::PluginHalter):
  13444. * page/PluginHalter.h:
  13445. 2011-05-12 Daniel Bates <dbates@rim.com>
  13446. Reviewed by Adele Peterson.
  13447. Frame's noResize attribute can not be set by JavaScript
  13448. https://bugs.webkit.org/show_bug.cgi?id=14845
  13449. Tests: fast/frames/frame-inherit-noresize-from-frameset.html
  13450. fast/frames/frame-programmatic-noresize.html
  13451. fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
  13452. fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
  13453. Implements support to programmatically allow and disallow frame resizing.
  13454. Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
  13455. m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
  13456. point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
  13457. frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
  13458. attribute.
  13459. * html/HTMLFrameElement.cpp:
  13460. (WebCore::HTMLFrameElement::HTMLFrameElement):
  13461. (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
  13462. code path isn't performance critical.
  13463. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
  13464. parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
  13465. (WebCore::HTMLFrameElement::parseMappedAttribute):
  13466. * html/HTMLFrameElement.h:
  13467. * rendering/RenderFrame.cpp:
  13468. (WebCore::RenderFrame::updateFromElement): Added.
  13469. * rendering/RenderFrame.h:
  13470. * rendering/RenderFrameSet.cpp:
  13471. (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  13472. * rendering/RenderFrameSet.h:
  13473. 2011-05-12 Emil A Eklund <eae@chromium.org>
  13474. Reviewed by Darin Adler.
  13475. Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
  13476. https://bugs.webkit.org/show_bug.cgi?id=60640
  13477. Pass by const reference instead of by value for consistency reasons.
  13478. Refactoring, covered by existing tests.
  13479. * rendering/RenderFlexibleBox.cpp:
  13480. (WebCore::RenderFlexibleBox::placeChild):
  13481. * rendering/RenderFlexibleBox.h:
  13482. Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead
  13483. 2011-05-12 Dan Bernstein <mitz@apple.com>
  13484. Reviewed by Sam Weinig.
  13485. <rdar://problem/9427336> WebFindOptionsAtWordStarts still fails with some Japanese words
  13486. https://bugs.webkit.org/show_bug.cgi?id=60730
  13487. * editing/TextIterator.cpp:
  13488. (WebCore::SearchBuffer::isWordStartMatch): Consider all positions before a CJK ideograph as
  13489. word starts.
  13490. 2011-05-12 Levi Weintraub <leviw@chromium.org>
  13491. Reviewed by Eric Seidel.
  13492. Switch paintBoxDecorationWithSize to IntRect
  13493. https://bugs.webkit.org/show_bug.cgi?id=60679
  13494. Switching paintBoxDecorationWithSize to take an IntRect instead of 4 ints.
  13495. No new tests as this is simple refactoring.
  13496. * rendering/RenderBox.cpp:
  13497. (WebCore::RenderBox::paintBoxDecorations): Cleaning up amazingly confusing logic.
  13498. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  13499. * rendering/RenderBox.h:
  13500. * rendering/RenderTextControlSingleLine.cpp:
  13501. (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
  13502. 2011-05-12 Levi Weintraub <leviw@chromium.org>
  13503. Reviewed by Eric Seidel.
  13504. Switch paintBoxShadow to use IntRect
  13505. https://bugs.webkit.org/show_bug.cgi?id=60713
  13506. Switching paintBoxShadow from taking four ints to taking an IntRect.
  13507. No new tests since this is refactoring.
  13508. * rendering/InlineFlowBox.cpp:
  13509. (WebCore::InlineFlowBox::paintBoxShadow):
  13510. (WebCore::InlineFlowBox::paintBoxDecorations):
  13511. * rendering/InlineFlowBox.h:
  13512. * rendering/RenderBox.cpp:
  13513. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  13514. * rendering/RenderBoxModelObject.cpp:
  13515. (WebCore::RenderBoxModelObject::paintBoxShadow):
  13516. * rendering/RenderBoxModelObject.h:
  13517. * rendering/RenderFieldset.cpp:
  13518. (WebCore::RenderFieldset::paintBoxDecorations):
  13519. * rendering/RenderTable.cpp:
  13520. (WebCore::RenderTable::paintBoxDecorations):
  13521. * rendering/RenderTableCell.cpp:
  13522. (WebCore::RenderTableCell::paintBoxDecorations):
  13523. 2011-05-12 Maciej Stachowiak <mjs@apple.com>
  13524. Reviewed by Darin Adler.
  13525. XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
  13526. https://bugs.webkit.org/show_bug.cgi?id=59394
  13527. Properly fix this (formerly rolled out for breaking the build). I think the original
  13528. failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.
  13529. * dom/XMLDocumentParserLibxml2.cpp:
  13530. (WebCore::PendingCallbacks::~PendingCallbacks):
  13531. (WebCore::PendingCallbacks::create):
  13532. (WebCore::PendingCallbacks::appendStartElementNSCallback):
  13533. (WebCore::PendingCallbacks::appendEndElementNSCallback):
  13534. (WebCore::PendingCallbacks::appendCharactersCallback):
  13535. (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
  13536. (WebCore::PendingCallbacks::appendCDATABlockCallback):
  13537. (WebCore::PendingCallbacks::appendCommentCallback):
  13538. (WebCore::PendingCallbacks::appendInternalSubsetCallback):
  13539. (WebCore::PendingCallbacks::appendErrorCallback):
  13540. (WebCore::PendingCallbacks::PendingCallbacks):
  13541. (WebCore::XMLDocumentParser::XMLDocumentParser):
  13542. 2011-05-12 Daniel Bates <dbates@rim.com>
  13543. Reviewed by Kenneth Rohde Christiansen.
  13544. [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
  13545. https://bugs.webkit.org/show_bug.cgi?id=58863
  13546. Fixes an issue where a platform mouse event corresponding to mouse button A
  13547. may be associated with the wrong WebCore mouse button when the event occurs
  13548. while pressing and holding a mouse button B, where A != B.
  13549. For example, a person clicks the middle mouse button while pressing and holding
  13550. the left mouse button. Then we dispatch the following DOM events: mouse down for
  13551. left button, mouse down for left button, mouse up for left button. But, we should
  13552. have dispatched: mouse down for left button, mouse down for middle button, mouse up
  13553. for middle button.
  13554. * platform/qt/PlatformMouseEventQt.cpp:
  13555. (WebCore::mouseEventTypeAndMouseButtonFromQEvent): Added.
  13556. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventTypeAndMouseButtonFromQEvent()
  13557. to determine the WebCore mouse event type and button from the platform-specific event.
  13558. 2011-05-12 Levi Weintraub <leviw@chromium.org>
  13559. Reviewed by Eric Seidel.
  13560. Switch paintMask and paintMaskImages off of ints
  13561. https://bugs.webkit.org/show_bug.cgi?id=60578
  13562. Primarily switching paintMask and paintMaskImages to use IntSize and IntRect respectively.
  13563. In the process of that:
  13564. - added an "expand" function to IntRect that allows you to add an IntSize or pair of
  13565. integers to the size portion of an IntRect.
  13566. - changed borderFitAdjust to take an IntRect. It modifies only the x and width attributes.
  13567. No new tests since this refactoring.
  13568. * platform/graphics/IntRect.h:
  13569. (WebCore::IntRect::expand): Added for convenience.
  13570. * rendering/RenderBlock.cpp:
  13571. (WebCore::RenderBlock::paintObject):
  13572. (WebCore::RenderBlock::borderFitAdjust):
  13573. * rendering/RenderBlock.h:
  13574. * rendering/RenderBox.cpp:
  13575. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  13576. (WebCore::RenderBox::paintMask):
  13577. (WebCore::RenderBox::paintMaskImages):
  13578. * rendering/RenderBox.h:
  13579. (WebCore::RenderBox::borderFitAdjust):
  13580. * rendering/RenderFieldset.cpp:
  13581. (WebCore::RenderFieldset::paintMask):
  13582. * rendering/RenderFieldset.h:
  13583. * rendering/RenderReplaced.cpp:
  13584. (WebCore::RenderReplaced::paint):
  13585. * rendering/RenderReplica.cpp:
  13586. (WebCore::RenderReplica::paint):
  13587. * rendering/RenderTable.cpp:
  13588. (WebCore::RenderTable::paintObject):
  13589. (WebCore::RenderTable::paintMask):
  13590. * rendering/RenderTable.h:
  13591. * rendering/RenderTableCell.cpp:
  13592. (WebCore::RenderTableCell::paintMask):
  13593. * rendering/RenderTableCell.h:
  13594. * rendering/RenderWidget.cpp:
  13595. (WebCore::RenderWidget::paint):
  13596. 2011-05-12 Patrick Gansterer <paroga@webkit.org>
  13597. Reviewed by Eric Seidel.
  13598. SimpleFontData::scaledFontData should return a PassOwnPtr
  13599. https://bugs.webkit.org/show_bug.cgi?id=60657
  13600. Let scaledFontData return a PassOwnPtr instead of a raw pointer
  13601. to make SimpleFontData build without LOOSE_PASS_OWN_PTR.
  13602. * platform/graphics/SimpleFontData.h:
  13603. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  13604. (WebCore::SimpleFontData::scaledFontData):
  13605. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  13606. (WebCore::SimpleFontData::scaledFontData):
  13607. * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  13608. (WebCore::SimpleFontData::scaledFontData):
  13609. * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
  13610. (WebCore::SimpleFontData::scaledFontData):
  13611. * platform/graphics/mac/SimpleFontDataMac.mm:
  13612. (WebCore::SimpleFontData::scaledFontData):
  13613. * platform/graphics/pango/SimpleFontDataPango.cpp:
  13614. (WebCore::SimpleFontData::scaledFontData):
  13615. * platform/graphics/qt/SimpleFontDataQt.cpp:
  13616. (WebCore::SimpleFontData::scaledFontData):
  13617. * platform/graphics/win/SimpleFontDataWin.cpp:
  13618. (WebCore::SimpleFontData::scaledFontData):
  13619. * platform/graphics/wince/SimpleFontDataWinCE.cpp:
  13620. (WebCore::SimpleFontData::scaledFontData):
  13621. * platform/graphics/wx/SimpleFontDataWx.cpp:
  13622. (WebCore::SimpleFontData::scaledFontData):
  13623. 2011-05-12 Jessie Berlin <jberlin@apple.com>
  13624. Reviewed by Darin Adler.
  13625. Assertion failure when requesting that storage be deleted for an origin without storage.
  13626. https://bugs.webkit.org/show_bug.cgi?id=60709
  13627. * storage/StorageTracker.cpp:
  13628. (WebCore::StorageTracker::syncDeleteOrigin):
  13629. If the path to the storage location for the givin origin is empty, return early instead of
  13630. asserting.
  13631. 2011-05-12 Jessie Berlin <jberlin@apple.com>
  13632. Reviewed by Darin Adler.
  13633. [Windows WebKit2] Use cookies set in WebKit1
  13634. https://bugs.webkit.org/show_bug.cgi?id=60274
  13635. Make sure any Private Browsing session is based off the default session.
  13636. * platform/network/cf/ResourceHandleCFNet.cpp:
  13637. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
  13638. 2011-05-12 Rob Buis <rbuis@rim.com>
  13639. Reviewed by Eric Seidel.
  13640. SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
  13641. https://bugs.webkit.org/show_bug.cgi?id=15479
  13642. Finally remove resolveStyle, it is not used anymore.
  13643. * svg/SVGStyledElement.cpp:
  13644. (WebCore::SVGStyledElement::childrenChanged):
  13645. * svg/SVGStyledElement.h:
  13646. 2011-05-12 Adam Barth <abarth@webkit.org>
  13647. Reviewed by Darin Adler.
  13648. REGRESSION (r65868): createContextualFragment does not work with <style>
  13649. https://bugs.webkit.org/show_bug.cgi?id=60155
  13650. createContextualFragment doesn't have a spec, so it's hard to tell what
  13651. we're supposed to do exactly. This patch appears to make our behavior
  13652. more like Firefox and should fix the compat issue with this site.
  13653. Tests: fast/parser/style-in-create-contextual-fragment-head.html
  13654. fast/parser/style-in-create-contextual-fragment.html
  13655. * dom/Element.cpp:
  13656. (WebCore::Element::deprecatedCreateContextualFragment):
  13657. 2011-05-12 Ryosuke Niwa <rniwa@webkit.org>
  13658. Reviewed by Darin Adler.
  13659. WebKit inserts base, link, meta, style, and title elements into an editable region
  13660. when pasting table cells from Excel
  13661. https://bugs.webkit.org/show_bug.cgi?id=60644
  13662. Strip base, link, meta, style, and tile elements from the fragment to be pasted prior
  13663. to the merge. We don't have to strip these elements in performTrivialReplace because
  13664. the function only handles a fragment that consists of exactly one text node.
  13665. Test: editing/pasteboard/paste-head-contents.html
  13666. * editing/ReplaceSelectionCommand.cpp:
  13667. (WebCore::removeHeadContents): Added.
  13668. (WebCore::ReplaceSelectionCommand::doApply): Calls removeHeadContents before handing
  13669. style spans.
  13670. 2011-05-12 Levi Weintraub <leviw@chromium.org>
  13671. Reviewed by Simon Fraser.
  13672. Switch calculateBackgroundImageGeometry to use IntRect
  13673. https://bugs.webkit.org/show_bug.cgi?id=60671
  13674. Replacing the four ints passed into calculateBackgroundImageGeometry with an IntRect.
  13675. No new tests since this is just refactoring.
  13676. * rendering/RenderBox.cpp:
  13677. (WebCore::RenderBox::maskClipRect):
  13678. (WebCore::RenderBox::repaintLayerRectsForImage):
  13679. * rendering/RenderBoxModelObject.cpp:
  13680. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  13681. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  13682. * rendering/RenderBoxModelObject.h:
  13683. 2011-05-12 Carol Szabo <carol@webkit.org>
  13684. Reviewed by David Hyatt.
  13685. Fix reparenting and destruction of counter nodes.
  13686. https://bugs.webkit.org/show_bug.cgi?id=57929
  13687. Fixed several issues related to not met assertions.
  13688. See below in the per file description.
  13689. Test: fast/css/counters/element-removal-crash.xhtml
  13690. * dom/ContainerNode.cpp:
  13691. (WebCore::ContainerNode::removeChildren):
  13692. Fixed the fact that Node::detach() used to be called
  13693. while the DOM tree was in an inconsistent state.
  13694. * rendering/RenderCounter.cpp:
  13695. (WebCore::RenderCounter::rendererRemovedFromTree):
  13696. Introduced this function to remove counters from
  13697. descendents of renderers removed from the renderer
  13698. tree not only from the removed renderers themselves.
  13699. * rendering/RenderCounter.h:
  13700. * rendering/RenderObjectChildList.cpp:
  13701. (WebCore::RenderObjectChildList::removeChildNode):
  13702. Changed to call RenderCounter::rendererRemovedFromTree
  13703. instead of RenderCounter::destroyCounters.
  13704. 2011-05-12 Luke Macpherson <macpherson@chromium.org>
  13705. Reviewed by Dimitri Glazkov.
  13706. Merge ApplyPropertyExpanding and ApplyPropertyExpandingSuppressValue classes using template.
  13707. https://bugs.webkit.org/show_bug.cgi?id=60691
  13708. No new tests - refactoring only.
  13709. * css/CSSStyleApplyProperty.cpp:
  13710. (WebCore::ApplyPropertyExpanding::applyValue):
  13711. Use new template parameter to early exit if needed.
  13712. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  13713. Specify template parameters for ApplyPropertyExpanding.
  13714. 2011-05-12 Simon Fraser <simon.fraser@apple.com>
  13715. Followup to r86351; give the vectors some inline capacity
  13716. to avoid heap allocations in most cases.
  13717. * page/animation/AnimationBase.cpp:
  13718. (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
  13719. 2011-05-12 Simon Fraser <simon.fraser@apple.com>
  13720. Reviewed by Dan Bernstein.
  13721. Mismatched multiple box-shadows do not transition as expected
  13722. https://bugs.webkit.org/show_bug.cgi?id=60137
  13723. When animating between two sets of shadows of different lengths, we need
  13724. to walk the ShadowData list backwards, since it stores the shadows in
  13725. reverse order relative to the CSS (so that painting is back-to-front).
  13726. This progresses the behavior of the transitions/multiple-shadow-transitions.html
  13727. test, which is given new expected results.
  13728. Test: transitions/mismatched-shadow-transitions.html
  13729. * page/animation/AnimationBase.cpp:
  13730. (WebCore::shadowListLength): Utility to walk the list of ShadowData and count the number
  13731. of shadows.
  13732. (WebCore::shadowForBlending): Return a ShadowData* that is useful as a blending target,
  13733. based on the shadow type, and whether it's a -webkit-box-shadow.
  13734. (WebCore::PropertyWrapperShadow::blend): Call one of the specialized blend methods.
  13735. (WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists): Fast path
  13736. for shadow blending, when the list lengths match, or both are single or null shadows.
  13737. (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists): Slower path that builds
  13738. vectors for each list to reverse them.
  13739. 2011-05-12 Adam Roben <aroben@apple.com>
  13740. Attempted WinCairo build fix after r86169, part II
  13741. * platform/network/curl/CredentialStorageCurl.cpp: Added a missing #include.
  13742. 2011-05-12 Adam Roben <aroben@apple.com>
  13743. Fix linker warnings in Production builds
  13744. * WebCore.vcproj/WebCore.vcproj: Exclude JSSVGFEDropShadowElement.cpp from the build in the
  13745. Production configuration, just like in the other configurations. Let VS resort some files
  13746. (again).
  13747. 2011-05-12 Philippe Normand <pnormand@igalia.com>
  13748. Reviewed by Adam Roben.
  13749. Autocorrection persists after deleting and retyping the same word at same location.
  13750. https://bugs.webkit.org/show_bug.cgi?id=60555
  13751. Follow-up fix for the 3 editing/deleting tests crashing on GTK,
  13752. Leopard and Windows XP. Don't create the Range if the start of the
  13753. selection has no next position.
  13754. * editing/DeleteSelectionCommand.cpp:
  13755. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  13756. 2011-05-12 Adam Roben <aroben@apple.com>
  13757. Attempted WinCairo build fix after r86169
  13758. * WebCore.vcproj/WebCore.vcproj: Added CredentialStorageCurl.cpp. Also let VS do what it
  13759. wants.
  13760. * platform/network/curl/CredentialStorageCurl.cpp: Added.
  13761. (WebCore::CredentialStorage::getFromPersistentStorage): Stubbed out.
  13762. 2011-05-12 Adam Roben <aroben@apple.com>
  13763. Build fixes after r86325
  13764. * editing/SpellingCorrectionController.cpp:
  13765. * editing/SpellingCorrectionController.h:
  13766. Added missing declarations/#includes.
  13767. 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
  13768. Not reviewed.
  13769. String operator+ reallocates unnecessary when concatting > 2 strings
  13770. https://bugs.webkit.org/show_bug.cgi?id=58420
  13771. Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier.
  13772. * platform/wince/FileSystemWinCE.cpp:
  13773. (WebCore::listDirectory):
  13774. 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
  13775. Not reviewed.
  13776. String operator+ reallocates unnecessary when concatting > 2 strings
  13777. https://bugs.webkit.org/show_bug.cgi?id=58420
  13778. Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/
  13779. * html/ImageInputType.cpp:
  13780. (WebCore::ImageInputType::appendFormData):
  13781. 2011-05-12 Rob Buis <rwlbuis@gmail.com>
  13782. Reviewed by Eric Seidel.
  13783. REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
  13784. https://bugs.webkit.org/show_bug.cgi?id=59941
  13785. Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.
  13786. Test: svg/custom/fill-opacity-update.svg
  13787. * rendering/style/SVGRenderStyle.cpp:
  13788. (WebCore::SVGRenderStyle::diff):
  13789. 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
  13790. Reviewed by Darin Adler.
  13791. String operator+ reallocates unnecessary when concatting > 2 strings
  13792. https://bugs.webkit.org/show_bug.cgi?id=58420
  13793. Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
  13794. * dom/XMLDocumentParserLibxml2.cpp:
  13795. (WebCore::handleElementAttributes):
  13796. * editing/MarkupAccumulator.cpp:
  13797. (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
  13798. * html/HTMLAnchorElement.cpp:
  13799. (WebCore::HTMLAnchorElement::hash):
  13800. (WebCore::HTMLAnchorElement::search):
  13801. * html/ImageInputType.cpp:
  13802. (WebCore::ImageInputType::appendFormData):
  13803. * html/parser/HTMLTreeBuilder.cpp:
  13804. * loader/CrossOriginAccessControl.cpp:
  13805. (WebCore::passesAccessControlCheck):
  13806. * page/Location.cpp:
  13807. (WebCore::Location::search):
  13808. (WebCore::Location::hash):
  13809. * page/NavigatorBase.cpp:
  13810. (WebCore::NavigatorBase::platform):
  13811. * platform/chromium/ClipboardChromium.cpp:
  13812. (WebCore::writeImageToDataObject):
  13813. * platform/gtk/PasteboardHelper.cpp:
  13814. (WebCore::PasteboardHelper::fillSelectionData):
  13815. * platform/network/cf/ResourceHandleCFNet.cpp:
  13816. (WebCore::encodeBasicAuthorization):
  13817. * platform/network/cf/SocketStreamHandleCFNet.cpp:
  13818. (WebCore::SocketStreamHandle::copyCFStreamDescription):
  13819. * platform/network/mac/ResourceHandleMac.mm:
  13820. (WebCore::encodeBasicAuthorization):
  13821. * workers/WorkerLocation.cpp:
  13822. (WebCore::WorkerLocation::search):
  13823. (WebCore::WorkerLocation::hash):
  13824. 2011-05-06 Yury Semikhatsky <yurys@chromium.org>
  13825. Reviewed by Pavel Feldman.
  13826. Web Inspector: move agents from InspectorAgent to InspectorController
  13827. https://bugs.webkit.org/show_bug.cgi?id=60359
  13828. All inspector agents are now created and owned by InspectorController which
  13829. in turned is owned by the inspected Page. InspectorInstrumentation gets access
  13830. to the instrumenting agents by means of InspectorAgent::instrumentingAgents().
  13831. In addition to managing inspector agents lifetime InspectorController sets
  13832. InspectorFronted on the agents when the front-end is connected.
  13833. * inspector/InspectorAgent.cpp:
  13834. (WebCore::InspectorAgent::InspectorAgent):
  13835. (WebCore::InspectorAgent::~InspectorAgent):
  13836. (WebCore::InspectorAgent::inspectedPageDestroyed):
  13837. (WebCore::InspectorAgent::restore):
  13838. (WebCore::InspectorAgent::setFrontend):
  13839. (WebCore::InspectorAgent::clearFrontend):
  13840. * inspector/InspectorAgent.h: all accessors to other agents were removed along with
  13841. the agents themselves from InspectorAgent. Every agent that depends on some other agents
  13842. receives pointers to them explicitely in its constructor. All access to the agents
  13843. from WebCore should go through InspectorInstrumentation which retrieves corresponding
  13844. agents using InstrumentingAgents structure which represents the set of active agents.
  13845. (WebCore::InspectorAgent::instrumentingAgents):
  13846. * inspector/InspectorController.cpp:
  13847. (WebCore::InspectorController::InspectorController):
  13848. (WebCore::InspectorController::~InspectorController):
  13849. (WebCore::InspectorController::inspectedPageDestroyed):
  13850. (WebCore::InspectorController::startTimelineProfiler):
  13851. (WebCore::InspectorController::stopTimelineProfiler):
  13852. (WebCore::InspectorController::connectFrontend):
  13853. (WebCore::InspectorController::disconnectFrontend):
  13854. (WebCore::InspectorController::restoreInspectorStateFromCookie):
  13855. (WebCore::InspectorController::drawNodeHighlight):
  13856. (WebCore::InspectorController::inspect):
  13857. (WebCore::InspectorController::timelineProfilerEnabled):
  13858. (WebCore::InspectorController::hideHighlight):
  13859. (WebCore::InspectorController::highlightedNode):
  13860. (WebCore::InspectorController::enableProfiler):
  13861. (WebCore::InspectorController::disableProfiler):
  13862. (WebCore::InspectorController::profilerEnabled):
  13863. (WebCore::InspectorController::debuggerEnabled):
  13864. (WebCore::InspectorController::disableDebugger):
  13865. (WebCore::InspectorController::startUserInitiatedProfiling):
  13866. (WebCore::InspectorController::stopUserInitiatedProfiling):
  13867. (WebCore::InspectorController::isRecordingUserInitiatedProfile):
  13868. (WebCore::InspectorController::resume):
  13869. * inspector/InspectorController.h:
  13870. * inspector/InspectorInstrumentation.cpp:
  13871. (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
  13872. (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
  13873. (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
  13874. (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
  13875. (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
  13876. (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  13877. (WebCore::InspectorInstrumentation::didFailLoadingImpl):
  13878. (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
  13879. (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  13880. (WebCore::InspectorInstrumentation::consoleCountImpl):
  13881. (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
  13882. (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
  13883. (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
  13884. (WebCore::InspectorInstrumentation::addProfileImpl):
  13885. (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  13886. (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  13887. (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  13888. * page/Page.cpp:
  13889. (WebCore::Page::~Page): we send two notifications when inspected Page is being
  13890. destroyed: one to the inspector instrumentation and another one to the InspectorController
  13891. which is owned by the Page.
  13892. 2011-05-12 Tony Gentilcore <tonyg@chromium.org>
  13893. Build fix: include ExceptionCode.h
  13894. https://bugs.webkit.org/show_bug.cgi?id=60694
  13895. * dom/Range.cpp:
  13896. 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
  13897. Reviewed by Darin Adler.
  13898. Perform some forward declarations suggested by include-what-you-use
  13899. https://bugs.webkit.org/show_bug.cgi?id=60545
  13900. * accessibility/AccessibilityObject.cpp:
  13901. * accessibility/AccessibilityRenderObject.cpp:
  13902. * accessibility/mac/AccessibilityObjectWrapper.mm:
  13903. * dom/DocumentMarkerController.cpp:
  13904. * dom/Position.cpp:
  13905. * dom/PositionIterator.cpp:
  13906. * dom/Range.cpp:
  13907. * editing/ApplyBlockElementCommand.cpp:
  13908. * editing/ApplyStyleCommand.cpp:
  13909. * editing/Editor.cpp:
  13910. * editing/EditorCommand.cpp:
  13911. * editing/FrameSelection.cpp:
  13912. * editing/HTMLInterchange.cpp:
  13913. * editing/IndentOutdentCommand.cpp:
  13914. * editing/ReplaceSelectionCommand.cpp:
  13915. * editing/SpellChecker.h:
  13916. * editing/SpellingCorrectionCommand.cpp:
  13917. * editing/SpellingCorrectionController.h:
  13918. * editing/TextCheckingHelper.cpp:
  13919. * editing/TextIterator.h:
  13920. * editing/htmlediting.h:
  13921. * editing/markup.cpp:
  13922. * editing/visible_units.cpp:
  13923. * editing/visible_units.h:
  13924. * fileapi/DOMFileSystem.cpp:
  13925. * fileapi/DirectoryReaderSync.cpp:
  13926. * fileapi/DirectoryReaderSync.h:
  13927. * fileapi/FileEntry.h:
  13928. * fileapi/FileWriter.h:
  13929. * fileapi/FileWriterBase.h:
  13930. * fileapi/FileWriterSync.h:
  13931. * history/CachedFrame.cpp:
  13932. * history/CachedPage.cpp:
  13933. * history/HistoryItem.cpp:
  13934. * history/HistoryItem.h:
  13935. * history/PageCache.h:
  13936. * loader/HistoryController.h:
  13937. * loader/PingLoader.h:
  13938. * loader/ResourceLoader.h:
  13939. * loader/appcache/DOMApplicationCache.h:
  13940. * loader/cache/CachedCSSStyleSheet.h:
  13941. * loader/cache/CachedFont.cpp:
  13942. * loader/cache/CachedFont.h:
  13943. * loader/cache/CachedResourceRequest.cpp:
  13944. * loader/cache/CachedResourceRequest.h:
  13945. * loader/cache/MemoryCache.h:
  13946. * notifications/Notification.cpp:
  13947. * notifications/Notification.h:
  13948. * notifications/NotificationCenter.cpp:
  13949. * notifications/NotificationCenter.h:
  13950. * page/Chrome.cpp:
  13951. * page/Chrome.h:
  13952. * page/DOMSelection.cpp:
  13953. * page/DOMTimer.h:
  13954. * page/DOMWindow.cpp:
  13955. * page/EventHandler.cpp:
  13956. * page/FocusController.h:
  13957. * page/Geolocation.cpp:
  13958. * page/Geolocation.h:
  13959. * page/History.cpp:
  13960. * rendering/RenderListBox.cpp:
  13961. * workers/WorkerContext.cpp:
  13962. 2011-05-12 Yuta Kitamura <yutak@chromium.org>
  13963. Unreviewed, another attempt of build fix.
  13964. * websockets/CloseEvent.h:
  13965. * websockets/CloseEvent.idl:
  13966. 2011-05-12 Yuta Kitamura <yutak@chromium.org>
  13967. Unreviewed, trying to fix Qt minimal compile.
  13968. * websockets/CloseEvent.idl:
  13969. 2011-05-12 ojab <ojab@ojab.ru>
  13970. Reviewed by Eric Seidel.
  13971. Fix build with --disable-video --enable-fullscreen-api
  13972. https://bugs.webkit.org/show_bug.cgi?id=60542
  13973. * css/CSSStyleSelector.cpp:
  13974. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  13975. 2011-05-12 Yuta Kitamura <yutak@chromium.org>
  13976. Reviewed by Kent Tamura.
  13977. WebSocket add new event: CloseEvent
  13978. https://bugs.webkit.org/show_bug.cgi?id=35573
  13979. Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
  13980. I added CloseEvent constructor to DOMWindow, so it can be referred
  13981. in the new test (close-event.html).
  13982. Test: http/tests/websocket/tests/close-event.html
  13983. * CMakeLists.txt:
  13984. * CodeGenerators.pri:
  13985. * DerivedSources.cpp:
  13986. * DerivedSources.make:
  13987. * GNUmakefile.list.am:
  13988. * WebCore.gypi:
  13989. * WebCore.pro:
  13990. * WebCore.vcproj/WebCore.vcproj:
  13991. * WebCore.xcodeproj/project.pbxproj:
  13992. * bindings/js/JSEventCustom.cpp:
  13993. (WebCore::toJS):
  13994. * bindings/v8/custom/V8EventCustom.cpp:
  13995. (WebCore::toV8):
  13996. * dom/Event.cpp:
  13997. (WebCore::Event::isCloseEvent):
  13998. * dom/Event.h:
  13999. * page/DOMWindow.idl: Add CloseEvent constructor.
  14000. * websockets/CloseEvent.h: Added.
  14001. (WebCore::CloseEvent::isCloseEvent):
  14002. (WebCore::CloseEvent::create):
  14003. (WebCore::CloseEvent::initCloseEvent):
  14004. (WebCore::CloseEvent::wasClean):
  14005. (WebCore::CloseEvent::CloseEvent):
  14006. * websockets/CloseEvent.idl: Added.
  14007. * websockets/WebSocket.cpp:
  14008. (WebCore::WebSocket::didClose):
  14009. 2011-05-12 Ben Wells <benwells@chromium.org>
  14010. Reviewed by Simon Fraser.
  14011. RGBA colors in outlines show overpainting at the corners
  14012. https://bugs.webkit.org/show_bug.cgi?id=58999
  14013. Tests: fast/borders/outline-alpha-block.html
  14014. fast/borders/outline-alpha-inline.html
  14015. Updated baseline images for tests with rgba outlines:
  14016. fast/box-shadow/box-shadow-radius.html
  14017. fast/layers/self-painting-outline.html
  14018. * rendering/RenderInline.cpp:
  14019. (WebCore::RenderInline::paintOutline):
  14020. (WebCore::RenderInline::paintOutlineForLine):
  14021. * rendering/RenderInline.h:
  14022. * rendering/RenderObject.cpp:
  14023. (WebCore::RenderObject::paintOutline):
  14024. 2011-05-11 Levi Weintraub <leviw@chromium.org>
  14025. Reviewed by Eric Seidel.
  14026. Rename Widget::pos()
  14027. https://bugs.webkit.org/show_bug.cgi?id=60575
  14028. Renaming Widget::pos() to the more-descriptive location().
  14029. No new tests as this is a simple rename
  14030. * page/FrameView.cpp:
  14031. (WebCore::FrameView::create):
  14032. * platform/Widget.h:
  14033. (WebCore::Widget::location):
  14034. (WebCore::Widget::resize):
  14035. 2011-05-10 MORITA Hajime <morrita@google.com>
  14036. Reviewed by Kent Tamura.
  14037. Crashes if the document inside iframe is removed during pasting some text into it.
  14038. https://bugs.webkit.org/show_bug.cgi?id=60534
  14039. Added missing null check.
  14040. Test: editing/pasteboard/paste-removing-iframe.html
  14041. * editing/Editor.cpp:
  14042. (WebCore::Editor::shouldChangeSelection):
  14043. 2011-05-11 Brian Salomon <bsalomon@google.com>
  14044. Reviewed by Eric Seidel.
  14045. Handle case when GrContext creation fails
  14046. https://bugs.webkit.org/show_bug.cgi?id=60410
  14047. Exercised by all canvas tests when DRT is run with skia-gpu
  14048. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  14049. (WebCore::SharedGraphicsContext3D::grContext):
  14050. 2011-05-11 Pratik Solanki <psolanki@apple.com>
  14051. Reviewed by Andreas Kling.
  14052. Remove empty class CallbackGuard
  14053. https://bugs.webkit.org/show_bug.cgi?id=60610
  14054. CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it.
  14055. * platform/network/mac/ResourceHandleMac.mm:
  14056. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
  14057. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
  14058. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
  14059. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
  14060. (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):
  14061. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  14062. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  14063. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  14064. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
  14065. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
  14066. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
  14067. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
  14068. 2011-05-11 Luke Macpherson <macpherson@chromium.org>
  14069. Reviewed by Eric Seidel.
  14070. Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty.
  14071. https://bugs.webkit.org/show_bug.cgi?id=60609
  14072. No new tests - refactoring only.
  14073. * css/CSSStyleApplyProperty.cpp:
  14074. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  14075. Initialise CSSPropertyMargin and CSSPropertyPadding handlers.
  14076. * css/CSSStyleSelector.cpp:
  14077. (WebCore::CSSStyleSelector::applyProperty):
  14078. Remove unused implementations.
  14079. 2011-05-11 Robin Dunn <robin@alldunn.com>
  14080. Reviewed by Kevin Ollivier.
  14081. [wx] Implement more clipping functions for wxWebKit.
  14082. https://bugs.webkit.org/show_bug.cgi?id=60662
  14083. * platform/graphics/wx/GraphicsContextWx.cpp:
  14084. (WebCore::GraphicsContext::clip):
  14085. (WebCore::GraphicsContext::clipOut):
  14086. 2011-05-11 Damian Kaleta <dkaleta@apple.com>
  14087. Reviewed by Brady Eidson.
  14088. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
  14089. https://bugs.webkit.org/show_bug.cgi?id=60674
  14090. * WebCore.exp.in: Export restoreScrollPositionAndViewState()
  14091. 2011-05-11 Levi Weintraub <leviw@chromium.org>
  14092. Reviewed by Eric Seidel.
  14093. Switch paintFillLayer and its progeny to use IntRect instead of four ints
  14094. https://bugs.webkit.org/show_bug.cgi?id=60596
  14095. Changing integers passed into paintFillLayer and other derivatives to IntRects
  14096. and IntSizes that reflect their function.
  14097. No new tests since this is just refactoring.
  14098. * rendering/InlineFlowBox.cpp:
  14099. (WebCore::InlineFlowBox::paintFillLayers):
  14100. (WebCore::InlineFlowBox::paintFillLayer):
  14101. (WebCore::InlineFlowBox::paintBoxDecorations):
  14102. (WebCore::InlineFlowBox::paintMask):
  14103. * rendering/InlineFlowBox.h:
  14104. * rendering/RenderBox.cpp:
  14105. (WebCore::RenderBox::paintRootBoxFillLayers):
  14106. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  14107. (WebCore::RenderBox::paintMaskImages):
  14108. (WebCore::RenderBox::paintFillLayers):
  14109. (WebCore::RenderBox::paintFillLayer):
  14110. * rendering/RenderBox.h:
  14111. * rendering/RenderBoxModelObject.cpp:
  14112. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  14113. * rendering/RenderBoxModelObject.h:
  14114. * rendering/RenderFieldset.cpp:
  14115. (WebCore::RenderFieldset::paintBoxDecorations):
  14116. * rendering/RenderTable.cpp:
  14117. (WebCore::RenderTable::paintBoxDecorations):
  14118. * rendering/RenderTableCell.cpp:
  14119. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  14120. 2011-05-11 Nat Duca <nduca@chromium.org>
  14121. Reviewed by James Robinson.
  14122. [chromium] Use mapTexSubImage2D for tile uploads if available
  14123. https://bugs.webkit.org/show_bug.cgi?id=60008
  14124. * platform/graphics/chromium/LayerTilerChromium.cpp:
  14125. (WebCore::LayerTilerChromium::LayerTilerChromium):
  14126. (WebCore::LayerTilerChromium::update):
  14127. (WebCore::LayerTilerChromium::updateFromPixels):
  14128. * platform/graphics/chromium/LayerTilerChromium.h:
  14129. 2011-05-11 Alexis Menard <alexis.menard@openbossa.org>
  14130. Reviewed by Kenneth Rohde Christiansen.
  14131. [Qt] Implements a disable appearance for Media Elements of Qt port.
  14132. https://bugs.webkit.org/show_bug.cgi?id=60561
  14133. Implements a disable appearance for the media controls of the Qt port
  14134. when the media is not yet available.
  14135. * platform/qt/RenderThemeQt.cpp:
  14136. (WebCore::mediaElementCanPlay):
  14137. (WebCore::RenderThemeQt::getMediaControlForegroundColor):
  14138. (WebCore::RenderThemeQt::paintMediaSliderThumb):
  14139. 2011-05-11 Kent Tamura <tkent@chromium.org>
  14140. Reviewed by Dimitri Glazkov.
  14141. input type=email is too strict
  14142. https://bugs.webkit.org/show_bug.cgi?id=55988
  14143. Follow the updated specification.
  14144. * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
  14145. 2011-05-11 Jia Pu <jpu@apple.com>
  14146. Reviewed by Darin Adler.
  14147. Autocorrection persists after deleting and retyping the same word at same location.
  14148. https://bugs.webkit.org/show_bug.cgi?id=60555
  14149. <rdar://problem/9373915>
  14150. This patch intends to alleviate the issue of repetitively applying the same autocorrection
  14151. when user delete and retype the same word at the same location. This scenario is especially
  14152. common when autocorrection modifies the first letter of the word.
  14153. This patch consists following major changes:
  14154. 1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that
  14155. precedes a deleted autocorrection. If the user later types the same original word at after
  14156. this whitespace, the autocorrection will not be applied again.
  14157. 2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the
  14158. autocorrection that has just been deleted.
  14159. 3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress
  14160. autocorrection when necessary.
  14161. 4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers.
  14162. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text
  14163. after the whitespace.
  14164. Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html
  14165. * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection.
  14166. (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  14167. * dom/DocumentMarkerController.cpp:
  14168. (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
  14169. * dom/DocumentMarkerController.h:
  14170. * editing/CompositeEditCommand.cpp:
  14171. (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers):
  14172. (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
  14173. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  14174. * editing/CompositeEditCommand.h:
  14175. * editing/DeleteSelectionCommand.cpp:
  14176. (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  14177. (WebCore::DeleteSelectionCommand::fixupWhitespace):
  14178. (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting
  14179. the original string if we are deleting an autocorrection.
  14180. (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.
  14181. * editing/DeleteSelectionCommand.h:
  14182. * editing/Editor.cpp:
  14183. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining
  14184. when to suppress an autocorrection into SpellingCorrectionController.
  14185. (WebCore::Editor::deletedAutocorrectionAtPosition):
  14186. * editing/Editor.h:
  14187. * editing/InsertParagraphSeparatorCommand.cpp:
  14188. (WebCore::InsertParagraphSeparatorCommand::doApply):
  14189. * editing/SpellingCorrectionController.cpp:
  14190. (WebCore::SpellingCorrectionController::respondToAppliedEditing):
  14191. (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition):
  14192. (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
  14193. (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  14194. * editing/SpellingCorrectionController.h:
  14195. (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  14196. * editing/visible_units.cpp:
  14197. (WebCore::isStartOfWord):
  14198. * editing/visible_units.h:
  14199. * manual-tests/autocorrection/spell-checking-after-reversion.html:
  14200. 2011-05-11 Dan Bernstein <mitz@apple.com>
  14201. Reviewed by Darin Adler.
  14202. <rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com
  14203. https://bugs.webkit.org/show_bug.cgi?id=60677
  14204. * platform/ScrollView.cpp:
  14205. (WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
  14206. animation, if the new scroll offset computed here is different from the current scroll offset.
  14207. 2011-05-11 Kent Tamura <tkent@chromium.org>
  14208. Reviewed by Dimitri Glazkov.
  14209. <input pattern="1|10" value="10"> doesn't work correctly.
  14210. https://bugs.webkit.org/show_bug.cgi?id=60619
  14211. Fixes a bug that patternMismatch returns a wrong result if
  14212. - a whole value matches to a pattern,
  14213. - a sub-string of the value also matches to the pattern, and
  14214. - the sub-string matching has priority.
  14215. * html/BaseTextInputType.cpp:
  14216. (WebCore::BaseTextInputType::patternMismatch):
  14217. Enclose the specified pattern with ^( and )$.
  14218. 2011-05-11 Zelidrag Hornung <zelidrag@chromium.org>
  14219. Reviewed by David Levin.
  14220. Prevented DOMFileSystemBase from imposing file naming restrictions on
  14221. external file systems.
  14222. https://bugs.webkit.org/show_bug.cgi?id=60583
  14223. There are no new tests for this change since it requires the presence
  14224. of external file system provider which is specific to the platform host
  14225. process. Chromium implementation will test this within its extension API
  14226. test suite.
  14227. * fileapi/DOMFileSystemBase.cpp:
  14228. (WebCore::pathToAbsolutePath):
  14229. (WebCore::DOMFileSystemBase::getFile):
  14230. (WebCore::DOMFileSystemBase::getDirectory):
  14231. 2011-05-11 Antoine Labour <piman@chromium.org>
  14232. Reviewed by David Levin.
  14233. Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
  14234. loaded resource.
  14235. https://bugs.webkit.org/show_bug.cgi?id=60656
  14236. * loader/DocumentThreadableLoader.cpp:
  14237. (WebCore::DocumentThreadableLoader::loadRequest):
  14238. Pass the shouldBufferData to the resource load scheduler, forcing it to true for the
  14239. preflight request.
  14240. * loader/ResourceLoadScheduler.cpp:
  14241. (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
  14242. Pass through shouldBufferData to SubresourceLoader::create
  14243. * loader/ResourceLoadScheduler.h:
  14244. * loader/SubresourceLoader.cpp:
  14245. (WebCore::SubresourceLoader::create):
  14246. Set shouldBufferData on the newly created loader
  14247. * loader/SubresourceLoader.h:
  14248. * loader/ThreadableLoader.h:
  14249. (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
  14250. Add shouldBufferData to the options, defaulting to true.
  14251. 2011-05-11 Jay Civelli <jcivelli@chromium.org>
  14252. Reviewed by Adam Barth.
  14253. Adding a Content-Type parser. This is needed for MHTML support.
  14254. https://bugs.webkit.org/show_bug.cgi?id=60637
  14255. (WebCore::ScriptController::disableEval):
  14256. * platform/network/ContentTypeParser.cpp: Added.
  14257. * platform/network/ContentTypeParser.h: Added.
  14258. 2011-05-11 Jessie Berlin <jberlin@apple.com>
  14259. Reviewed by Steve Falkenburg.
  14260. [Windows WebKit2] Use cookies set in WebKit1
  14261. https://bugs.webkit.org/show_bug.cgi?id=60274
  14262. Share the default storage session between the UI and Web Processes.
  14263. * platform/network/cf/CookieStorageCFNet.cpp:
  14264. (WebCore::defaultSessionCookieStorage):
  14265. Keep track of the default storage session cookie storage.
  14266. (WebCore::currentCookieStorage):
  14267. Call defaultCookieStorage to get the default cookie storage.
  14268. (WebCore::defaultCookieStorage):
  14269. If there is a default storage session cookie storage, prefer that over getting the default
  14270. cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
  14271. without specifying a storage session will not get the cookie storage being shared by the UI
  14272. and Web Processes.
  14273. * platform/network/ResourceHandle.h:
  14274. * platform/network/cf/ResourceHandleCFNet.cpp:
  14275. (WebCore::willSendRequest):
  14276. Make sure to set the current storage session on any requests used by the Web
  14277. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  14278. doing anything with the Web Process's default storage session (which is not the one shared
  14279. with the UI Process).
  14280. (WebCore::makeFinalRequest):
  14281. Ditto.
  14282. (WebCore::ResourceHandle::willSendRequest):
  14283. Ditto.
  14284. (WebCore::ResourceHandle::currentStorageSession):
  14285. If there is a Private Browsing storage session, return that.
  14286. If not, on Windows return the default storage session that is being shared with the UI
  14287. Process and on Mac return 0.
  14288. (WebCore::defaultCFURLStorageSession):
  14289. (WebCore::ResourceHandle::setDefaultStorageSession):
  14290. (WebCore::ResourceHandle::defaultStorageSession):
  14291. * platform/network/cf/ResourceRequestCFNet.cpp:
  14292. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  14293. Make sure to set the current storage session on any requests used by the Web
  14294. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  14295. doing anything with the Web Process's default storage session (which is not the one shared
  14296. with the UI Process).
  14297. 2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>
  14298. Reviewed by David Kilzer.
  14299. Remove wml directory from include lists
  14300. https://bugs.webkit.org/show_bug.cgi?id=60646
  14301. Remove wml dir from CMake, Autotools and qmake build systems since WML
  14302. was removed in r85256.
  14303. No new tests since no change in functionality.
  14304. * CMakeLists.txt:
  14305. * GNUmakefile.am:
  14306. * WebCore.pri:
  14307. 2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>
  14308. Reviewed by Antonio Gomes.
  14309. [CMAKE] Move EFL-specific file to CMakeListsEfl.txt
  14310. https://bugs.webkit.org/show_bug.cgi?id=60642
  14311. Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
  14312. having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
  14313. calls, since they depend on lists that now may change inside a port
  14314. like WebCore_USER_AGENT_STYLE_SHEETS.
  14315. No new tests since no change in functionality.
  14316. * CMakeLists.txt: remove css file specific to EFL port.
  14317. * CMakeListsEfl.txt: move file here.
  14318. 2011-05-11 Tao Bai <michaelbai@chromium.org>
  14319. Reviewed by David Kilzer.
  14320. Return empty Favicon URL instead of default one when the frame isn't top level one
  14321. https://bugs.webkit.org/show_bug.cgi?id=60527
  14322. This issue was discovered by chromium browser test.
  14323. * dom/Document.cpp:
  14324. (WebCore::Document::setIconURL):
  14325. Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785.
  14326. * loader/FrameLoader.cpp:
  14327. (WebCore::FrameLoader::iconURLs):
  14328. (WebCore::FrameLoader::fillIconURL):
  14329. Restored original logic, the empty URL should be returned instead of default one. The client (at
  14330. least chromium) may rely on the returned value to decided whether the favicon should be changed.
  14331. 2011-05-11 Nat Duca <nduca@chromium.org>
  14332. Reviewed by Kenneth Russell.
  14333. [chromium] Make throttling of WebGL based on webgl frames, not compositor frames
  14334. https://bugs.webkit.org/show_bug.cgi?id=60508
  14335. When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need
  14336. to prevent WebGL from running too far ahead of the GPU process. The current
  14337. throttling mechanism relies on prepareTexture being called for every WebGL frame.
  14338. However, in a non-requestAnimFrame application, multiple frames might get created
  14339. before the compositor runs and calls prepareTexture on the surface.
  14340. To address this, we post a task that calls a special rate limiting GL extension on
  14341. the WebGL context after every WebGL "frame." When the compositor runs, it calls
  14342. prepareTexture as usual.
  14343. * platform/graphics/chromium/Extensions3DChromium.h:
  14344. * platform/graphics/chromium/LayerRendererChromium.cpp:
  14345. (WebCore::LayerRendererChromium::LayerRendererChromium):
  14346. * platform/graphics/chromium/LayerRendererChromium.h:
  14347. (WebCore::LayerRendererChromium::setIsAnimating):
  14348. (WebCore::LayerRendererChromium::isAnimating):
  14349. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  14350. (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask):
  14351. (WebCore::WebGLLayerChromiumRateLimitTask::run):
  14352. (WebCore::WebGLLayerChromiumRateLimitTask::cancel):
  14353. (WebCore::WebGLLayerChromium::WebGLLayerChromium):
  14354. (WebCore::WebGLLayerChromium::~WebGLLayerChromium):
  14355. (WebCore::WebGLLayerChromium::setTextureUpdated):
  14356. (WebCore::WebGLLayerChromium::setContext):
  14357. * platform/graphics/chromium/WebGLLayerChromium.h:
  14358. (WebCore::WebGLLayerChromium::context):
  14359. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14360. Reviewed by Kenneth Rohde Christiansen.
  14361. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14362. https://bugs.webkit.org/show_bug.cgi?id=60439
  14363. Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation
  14364. mechanism happens inside TextureMapper, and we interpolate right before we paint.
  14365. No new tests. Tests in LayoutTests/compositing cover this.
  14366. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  14367. (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
  14368. (WebCore::GraphicsLayerTextureMapper::syncCompositingState):
  14369. (WebCore::GraphicsLayerTextureMapper::addAnimation):
  14370. (WebCore::GraphicsLayerTextureMapper::pauseAnimation):
  14371. (WebCore::GraphicsLayerTextureMapper::removeAnimation):
  14372. (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired):
  14373. * platform/graphics/texmap/TextureMapperNode.cpp:
  14374. (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
  14375. (WebCore::normalizedAnimationValue):
  14376. (WebCore::TextureMapperNode::applyOpacityAnimation):
  14377. (WebCore::solveEpsilon):
  14378. (WebCore::solveCubicBezierFunction):
  14379. (WebCore::solveStepsFunction):
  14380. (WebCore::applyTimingFunction):
  14381. (WebCore::TextureMapperNode::applyTransformAnimation):
  14382. (WebCore::TextureMapperNode::applyAnimationFrame):
  14383. (WebCore::TextureMapperNode::applyAnimation):
  14384. (WebCore::TextureMapperNode::hasRunningOpacityAnimation):
  14385. (WebCore::TextureMapperNode::hasRunningTransformAnimation):
  14386. (WebCore::TextureMapperNode::syncAnimations):
  14387. (WebCore::copyTimingFunction):
  14388. (WebCore::copyAnimationValue):
  14389. (WebCore::TextureMapperAnimation::TextureMapperAnimation):
  14390. * platform/graphics/texmap/TextureMapperNode.h:
  14391. (WebCore::TextureMapperAnimation::create):
  14392. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14393. Reviewed by Kenneth Rohde Christiansen.
  14394. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14395. https://bugs.webkit.org/show_bug.cgi?id=60439
  14396. Patch 11/12: Patch PluginView to build with TextureMapper on Linux.
  14397. No new tests. This is a build fix.
  14398. * platform/qt/QWebPageClient.h:
  14399. (QWebPageClient::setRootGraphicsLayer):
  14400. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14401. Reviewed by Kenneth Rohde Christiansen.
  14402. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14403. https://bugs.webkit.org/show_bug.cgi?id=60439
  14404. Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).
  14405. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
  14406. No new tests. Tests in LayoutTests/compositing cover this.
  14407. * platform/qt/QWebPageClient.h:
  14408. (QWebPageClient::setRootGraphicsLayer):
  14409. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14410. Reviewed by Kenneth Rohde Christiansen.
  14411. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14412. https://bugs.webkit.org/show_bug.cgi?id=60439
  14413. Patch 9/12: Refactor TextureMapperNode for performance, readability and accuracy.
  14414. Changes include:
  14415. 1. Support the new TextureMapperPlatformLayer for media & WebGL.
  14416. 2. Use a pool for intermediate surfaces, to avoid constant allocating/freeing of textures.
  14417. 3. Divide computation operations to different smaller functions.
  14418. 4. Get rid of scissor/clip layers, use transformed clip instead.
  14419. 5. Allow tiling for big layers.
  14420. No new tests. Tests in LayoutTests/compositing cover this.
  14421. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  14422. (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
  14423. (WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
  14424. (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
  14425. (WebCore::GraphicsLayerTextureMapper::platformLayer):
  14426. * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  14427. (WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
  14428. (WebCore::GraphicsLayerTextureMapper::setContentsToCanvas):
  14429. (WebCore::GraphicsLayerTextureMapper::node):
  14430. * platform/graphics/texmap/TextureMapperNode.cpp:
  14431. (WebCore::TextureMapperSurfaceManager::getIntermediateSurface):
  14432. (WebCore::TextureMapperSurfaceManager::releaseIntermediateSurface):
  14433. (WebCore::toTextureMapperNode):
  14434. (WebCore::TextureMapperNode::rootLayer):
  14435. (WebCore::TextureMapperNode::setTransform):
  14436. (WebCore::TextureMapperNode::computePerspectiveTransformIfNeeded):
  14437. (WebCore::TextureMapperNode::countDescendantsWithContent):
  14438. (WebCore::TextureMapperNode::computeOverlapsIfNeeded):
  14439. (WebCore::TextureMapperNode::computeReplicaTransformIfNeeded):
  14440. (WebCore::TextureMapperNode::computeLocalTransformIfNeeded):
  14441. (WebCore::TextureMapperNode::needsToComputeBoundingRect):
  14442. (WebCore::TextureMapperNode::computeAllTransforms):
  14443. (WebCore::TextureMapperNode::computeBoundingRectFromRootIfNeeded):
  14444. (WebCore::TextureMapperNode::computeTiles):
  14445. (WebCore::TextureMapperNode::computeVisibleRectIfNeeded):
  14446. (WebCore::TextureMapperNode::renderContent):
  14447. (WebCore::TextureMapperNode::paint):
  14448. (WebCore::TextureMapperNode::targetRectForTileRect):
  14449. (WebCore::TextureMapperNode::paintSelf):
  14450. (WebCore::TextureMapperNode::compareGraphicsLayersZValue):
  14451. (WebCore::TextureMapperNode::sortByZOrder):
  14452. (WebCore::TextureMapperNode::paintSelfAndChildren):
  14453. (WebCore::TextureMapperNode::paintReflection):
  14454. (WebCore::TextureMapperNode::paintRecursive):
  14455. (WebCore::TextureMapperNode::~TextureMapperNode):
  14456. (WebCore::TextureMapperNode::resetDescendants):
  14457. (WebCore::TextureMapperNode::setContentScale):
  14458. (WebCore::TextureMapperNode::setVisibleRect):
  14459. (WebCore::TextureMapperNode::syncCompositingState):
  14460. (WebCore::TextureMapperNode::invalidateOverlaps):
  14461. (WebCore::TextureMapperNode::syncCompositingStateSelf):
  14462. (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
  14463. * platform/graphics/texmap/TextureMapperNode.h:
  14464. (WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
  14465. (WebCore::TextureMapperAnimation::create):
  14466. (WebCore::TextureMapperNode::TextureMapperNode):
  14467. (WebCore::TextureMapperNode::size):
  14468. (WebCore::TextureMapperNode::setOpacity):
  14469. (WebCore::TextureMapperNode::setTextureMapper):
  14470. (WebCore::TextureMapperNode::media):
  14471. (WebCore::TextureMapperNode::texture):
  14472. (WebCore::TextureMapperNode::targetRect):
  14473. (WebCore::TextureMapperNode::entireRect):
  14474. (WebCore::TextureMapperNode::contentSize):
  14475. (WebCore::TextureMapperNode::State::State):
  14476. (WebCore::deleteOwnedPtr):
  14477. 2011-05-07 Noam Rosenthal <noam.rosenthal@nokia.com>
  14478. Reviewed by Kenneth Rohde Christiansen.
  14479. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14480. https://bugs.webkit.org/show_bug.cgi?id=60439
  14481. Patch 8/12: Changes to the GL backend of TextureMapper. The code for these changes is intertwined so it was hard to separate
  14482. them to different patches. This is the summary of what the changes do:
  14483. 1. Use stencil for clipping instead of scissors, refactor beginClip/endClip functions to accomodate that.
  14484. 2. Get rid of the "Target" program which forced an intermediate framebuffer for any content. Instead,
  14485. we upload the texture with BGRA from the start. Ports other than Qt can optimize this for their needs.
  14486. 3. Use glGetAttribLocation instead of glBindAttribLocation; On some platforms we might be polluting the
  14487. GL context otherwise.
  14488. 4. Use image UIDs (cache-key in Qt) instead of image pointers. This is important for images that change their
  14489. internal content.
  14490. 5. Allow packing and unpacking. This is currently a stub, for future memory optimizations.
  14491. 6. Put some of the initialization code here (beginPainting/endPainting).
  14492. 7. Allow painting a texture via an ID instead of a BitmapTexture data type.
  14493. 8. Get rid of makeContextCurrent / obtainCurrentContext. We only use texture-mapper when the context is current.
  14494. No new tests. Tests in LayoutTests/compositing test this.
  14495. * platform/graphics/opengl/TextureMapperGL.cpp:
  14496. (WebCore::debugGLCommand):
  14497. (WebCore::TextureMapperGLData::GlobalGLData::createShaderProgram):
  14498. (WebCore::TextureMapperGLData::GlobalGLData::GlobalGLData):
  14499. (WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::findOrCreate):
  14500. (WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::deref):
  14501. (WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::~DirectlyCompositedImageRepository):
  14502. (WebCore::TextureMapperGLData::TextureMapperGLData):
  14503. (WebCore::BitmapTextureGL::id):
  14504. (WebCore::BitmapTextureGL::isOpaque):
  14505. (WebCore::BitmapTextureGL::relativeSize):
  14506. (WebCore::BitmapTextureGL::setTextureMapper):
  14507. (WebCore::BitmapTextureGL::pack):
  14508. (WebCore::BitmapTextureGL::unpack):
  14509. (WebCore::BitmapTextureGL::isPacked):
  14510. (WebCore::BitmapTextureGL::BitmapTextureGL):
  14511. (WebCore::TextureMapperGL::TextureMapperGL):
  14512. (WebCore::TextureMapperGL::initializeShaders):
  14513. (WebCore::TextureMapperGL::beginPainting):
  14514. (WebCore::TextureMapperGL::endPainting):
  14515. (WebCore::TextureMapperGL::drawTexture):
  14516. (WebCore::BitmapTextureGL::reset):
  14517. (WebCore::BitmapTextureGL::endPaint):
  14518. (WebCore::BitmapTextureGL::setContentsToImage):
  14519. (WebCore::createProjectionMatrix):
  14520. (WebCore::BitmapTextureGL::bind):
  14521. (WebCore::BitmapTextureGL::destroy):
  14522. (WebCore::TextureMapperGL::~TextureMapperGL):
  14523. (WebCore::TextureMapperGL::bindSurface):
  14524. (WebCore::TextureMapperGL::beginClip):
  14525. (WebCore::TextureMapperGL::endClip):
  14526. (WebCore::TextureMapperGL::createTexture):
  14527. * platform/graphics/opengl/TextureMapperGL.h:
  14528. (WebCore::TextureMapperGL::allowSurfaceForRoot):
  14529. (WebCore::TextureMapperGL::create):
  14530. (WebCore::TextureMapperGL::setGraphicsContext):
  14531. (WebCore::TextureMapperGL::graphicsContext):
  14532. (WebCore::TextureMapperGL::isOpenGLBacked):
  14533. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  14534. (WebCore::GraphicsContext3DInternal::paintToTextureMapper):
  14535. (WebCore::GraphicsContext3DInternal::boundingRect):
  14536. (WebCore::GraphicsContext3DInternal::paint):
  14537. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  14538. (WebCore::MediaPlayerPrivateQt::repaint):
  14539. (WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
  14540. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  14541. (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
  14542. (WebCore::MediaPlayerPrivateQt::platformLayer):
  14543. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14544. Reviewed by Kenneth Rohde Christiansen.
  14545. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14546. https://bugs.webkit.org/show_bug.cgi?id=60439
  14547. Patch 7/12: Allow a 3D-context (WebGL) to paint itself into a TextureMapper.
  14548. This allows using a WebGL canvas with CSS.
  14549. No new tests. Tests in LayoutTests/compositing/webgl cover this.
  14550. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  14551. (WebCore::GraphicsContext3DInternal::paintToTextureMapper):
  14552. (WebCore::GraphicsContext3DInternal::boundingRect):
  14553. (WebCore::GraphicsContext3DInternal::paint):
  14554. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  14555. (WebCore::MediaPlayerPrivateQt::repaint):
  14556. (WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
  14557. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  14558. (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
  14559. (WebCore::MediaPlayerPrivateQt::platformLayer):
  14560. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14561. Reviewed by Kenneth Rohde Christiansen.
  14562. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14563. https://bugs.webkit.org/show_bug.cgi?id=60439
  14564. Patch 6/12: Allow the Qt media player implementation to paint into a TextureMapper,
  14565. to allow videos to be composited.
  14566. No new tests. Tests in LayoutTests/compositing cover this.
  14567. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  14568. (WebCore::MediaPlayerPrivateQt::repaint):
  14569. (WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
  14570. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  14571. (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
  14572. (WebCore::MediaPlayerPrivateQt::platformLayer):
  14573. 2011-05-11 John Bauman <jbauman@chromium.org>
  14574. Reviewed by Kenneth Russell.
  14575. Don't send zeros in TexImage if GL implementation handles that
  14576. https://bugs.webkit.org/show_bug.cgi?id=60581
  14577. Chromium already handles zeroing textures upon creation, so don't
  14578. bother zeroing them in WebKit, as that causes some unnecessary memcpys
  14579. of zeros.
  14580. No new tests as functionality is the same.
  14581. * html/canvas/WebGLRenderingContext.cpp:
  14582. (WebCore::WebGLRenderingContext::texImage2DBase):
  14583. * platform/graphics/GraphicsContext3D.cpp:
  14584. (WebCore::GraphicsContext3D::texImage2DResourceSafe):
  14585. * platform/graphics/GraphicsContext3D.h:
  14586. * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
  14587. (WebCore::GraphicsContext3D::GraphicsContext3D):
  14588. * platform/graphics/mac/GraphicsContext3DMac.mm:
  14589. (WebCore::GraphicsContext3D::GraphicsContext3D):
  14590. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  14591. (WebCore::GraphicsContext3D::GraphicsContext3D):
  14592. 2011-05-11 Simon Fraser <simon.fraser@apple.com>
  14593. Attempt to fix Chromium Mac build.
  14594. * rendering/RenderThemeMac.mm:
  14595. (WebCore::RenderThemeMac::paintSliderThumb):
  14596. 2011-05-11 Daniel Bates <dbates@rim.com>
  14597. Reviewed by Antonio Gomes.
  14598. [Qt] Extract code to set mouse event modifiers into common function
  14599. https://bugs.webkit.org/show_bug.cgi?id=60649
  14600. Consolidate code to set the keyboard modifiers for a mouse event into a common
  14601. function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount)
  14602. and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code.
  14603. No functionality was changed. So, no new tests.
  14604. * platform/qt/PlatformMouseEventQt.cpp:
  14605. (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added.
  14606. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers().
  14607. 2011-05-11 Levi Weintraub <leviw@chromium.org>
  14608. Reviewed by Eric Seidel.
  14609. Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
  14610. https://bugs.webkit.org/show_bug.cgi?id=60591
  14611. Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect.
  14612. No new tests since there is no functionality change.
  14613. * rendering/InlineFlowBox.cpp:
  14614. (WebCore::InlineFlowBox::paintBoxDecorations):
  14615. * rendering/RenderBox.cpp:
  14616. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  14617. * rendering/RenderBoxModelObject.cpp:
  14618. (WebCore::RenderBoxModelObject::paintBorder):
  14619. * rendering/RenderBoxModelObject.h:
  14620. * rendering/RenderFieldset.cpp:
  14621. (WebCore::RenderFieldset::paintBoxDecorations):
  14622. * rendering/RenderTable.cpp:
  14623. (WebCore::RenderTable::paintBoxDecorations):
  14624. * rendering/RenderTableCell.cpp:
  14625. (WebCore::RenderTableCell::paintBoxDecorations):
  14626. 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
  14627. Unreviewed, rolling out r86255.
  14628. http://trac.webkit.org/changeset/86255
  14629. https://bugs.webkit.org/show_bug.cgi?id=60660
  14630. REGRESSION (r86255): Lots of tests crashing in
  14631. CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
  14632. (WebKit2 Tests) (Requested by aroben on #webkit).
  14633. * platform/network/ResourceHandle.h:
  14634. * platform/network/cf/CookieStorageCFNet.cpp:
  14635. (WebCore::currentCookieStorage):
  14636. (WebCore::defaultCookieStorage):
  14637. * platform/network/cf/ResourceHandleCFNet.cpp:
  14638. (WebCore::willSendRequest):
  14639. (WebCore::makeFinalRequest):
  14640. (WebCore::ResourceHandle::willSendRequest):
  14641. * platform/network/cf/ResourceRequestCFNet.cpp:
  14642. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  14643. 2011-05-11 Sam Weinig <sam@webkit.org>
  14644. Reviewed by Eric Seidel.
  14645. Frequent crashes beneath WebCore::ScriptElement::prepareScript
  14646. https://bugs.webkit.org/show_bug.cgi?id=60559
  14647. * html/parser/HTMLScriptRunner.cpp:
  14648. (WebCore::HTMLScriptRunner::runScript):
  14649. Add null check and explanation that we are keeping the ASSERT to help
  14650. track down the cause and produce a test.
  14651. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14652. Reviewed by Kenneth Rohde Christiansen.
  14653. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14654. https://bugs.webkit.org/show_bug.cgi?id=60439
  14655. Patch 5/12: Implement the new TextureMapper functions for the Qt backend.
  14656. This allow non-rectangular clipping, some stub functions, and getting a unique
  14657. id for an image.
  14658. No new tests. Tests in LayoutTests/compositing cover this.
  14659. * platform/graphics/qt/TextureMapperQt.cpp:
  14660. (WebCore::TextureMapperQt::beginClip):
  14661. (WebCore::TextureMapperQt::endClip):
  14662. (WebCore::TextureMapperQt::viewportSize):
  14663. (WebCore::TextureMapperQt::setGraphicsContext):
  14664. (WebCore::TextureMapperQt::graphicsContext):
  14665. (WebCore::TextureMapperQt::drawTexture):
  14666. (WebCore::TextureMapperQt::beginPainting):
  14667. (WebCore::TextureMapperQt::endPainting):
  14668. (WebCore::RGBA32PremultimpliedBufferQt::beginPaint):
  14669. (WebCore::uidForImage):
  14670. * platform/graphics/qt/TextureMapperQt.h:
  14671. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14672. Reviewed by Kenneth Rohde Christiansen.
  14673. [Texmap] Upstream texture-mapper changes from Qt's WebKit2 branch
  14674. https://bugs.webkit.org/show_bug.cgi?id=60439
  14675. Patch 3/12: TextureMapper shouldn't depend on OpenGL, but rather only allow the GL backend when
  14676. OpenGL is present.
  14677. No new tests. This is a build fix.
  14678. * WebCore.pri:
  14679. * WebCore.pro:
  14680. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14681. Reviewed by Kenneth Rohde Christiansen.
  14682. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14683. https://bugs.webkit.org/show_bug.cgi?id=60439
  14684. Patch 2/12: Add a few functions to the TextureMapper API, allowing:
  14685. 1. an entry/exit point for painting (beginPaint/endPaint)
  14686. 2. Clipping with a matrix, since we use stencil instead of scissors
  14687. 3. Draw a texture directly with an ID
  14688. 4. Remove offset, since we're using real tiling
  14689. 5. numberOfBytes calculation for textures, for memory management
  14690. No new tests. Tests in LayoutTests/compositing test this.
  14691. * platform/graphics/texmap/TextureMapper.h:
  14692. (WebCore::BitmapTexture::destroy):
  14693. (WebCore::BitmapTexture::allowOfflineTextureUpload):
  14694. (WebCore::BitmapTexture::bpp):
  14695. (WebCore::BitmapTexture::numberOfBytes):
  14696. (WebCore::TextureMapper::viewportSize):
  14697. (WebCore::TextureMapper::setViewportSize):
  14698. (WebCore::TextureMapper::allowPartialUpdates):
  14699. (WebCore::TextureMapper::isOpenGLBacked):
  14700. (WebCore::TextureMapper::setTransform):
  14701. (WebCore::TextureMapper::transform):
  14702. (WebCore::TextureMapper::beginPainting):
  14703. (WebCore::TextureMapper::endPainting):
  14704. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  14705. Reviewed by Kenneth Rohde Christiansen.
  14706. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  14707. https://bugs.webkit.org/show_bug.cgi?id=60439
  14708. Patch 1/12: Change the TextureMapperPlatformLayer API to allow a 3D-context or a
  14709. media player to decide how to paint into the TextureMapper, rather than mandate specific
  14710. types of platform layers.
  14711. No new tests. Tests in LayoutTests/compositing test this.
  14712. * platform/graphics/GraphicsLayer.h:
  14713. * platform/graphics/texmap/TextureMapperPlatformLayer.h:
  14714. 2011-05-11 Simon Fraser <simon.fraser@apple.com>
  14715. Reviewed by Darin Adler.
  14716. Flesh out RenderLayer's ScrollableArea implementation a little more
  14717. https://bugs.webkit.org/show_bug.cgi?id=60593
  14718. Override a few more ScrollableArea methods on RenderLayer
  14719. as a baby-step towards animating overflow div scrolling.
  14720. * platform/ScrollableArea.h:
  14721. (WebCore::ScrollableArea::visibleContentRect):
  14722. * rendering/RenderLayer.cpp:
  14723. (WebCore::RenderLayer::scrollPosition):
  14724. (WebCore::RenderLayer::minimumScrollPosition):
  14725. (WebCore::RenderLayer::maximumScrollPosition):
  14726. (WebCore::RenderLayer::visibleContentRect):
  14727. (WebCore::RenderLayer::overhangAmount):
  14728. (WebCore::RenderLayer::didCompleteRubberBand):
  14729. * rendering/RenderLayer.h:
  14730. (WebCore::RenderLayer::shouldSuspendScrollAnimations):
  14731. 2011-05-11 Simon Fraser <simon.fraser@apple.com>
  14732. Reviewed by Dave Hyatt.
  14733. <rdar://problem/9421781> Slider thumb draws upside-down in WebKit2
  14734. <rdar://problem/9418025> Slider thumb has odd appearance
  14735. Fix two issues drawing the slider thumb.
  14736. To fix <rdar://problem/9421781>, if we detect that we're in WebKit2
  14737. by virtual of the FrameView not having a documentView, then flip
  14738. the graphics context.
  14739. To fix <rdar://problem/9418025>, we call -drawInteriorWithFrame:inView:
  14740. rather than -drawWithFrame:inView: so that AppKit doesn't draw a section
  14741. of track behind the thumb.
  14742. * rendering/RenderThemeMac.mm:
  14743. (WebCore::RenderThemeMac::paintSliderThumb):
  14744. 2011-05-11 Jessie Berlin <jberlin@apple.com>
  14745. Reviewed by Steve Falkenburg.
  14746. [Windows WebKit2] Use cookies set in WebKit1
  14747. https://bugs.webkit.org/show_bug.cgi?id=60274
  14748. Share the default storage session between the UI and Web Processes.
  14749. * platform/network/cf/CookieStorageCFNet.cpp:
  14750. (WebCore::defaultSessionCookieStorage):
  14751. Keep track of the default storage session cookie storage.
  14752. (WebCore::currentCookieStorage):
  14753. Call defaultCookieStorage to get the default cookie storage.
  14754. (WebCore::defaultCookieStorage):
  14755. If there is a default storage session cookie storage, prefer that over getting the default
  14756. cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
  14757. without specifying a storage session will not get the cookie storage being shared by the UI
  14758. and Web Processes.
  14759. * platform/network/ResourceHandle.h:
  14760. * platform/network/cf/ResourceHandleCFNet.cpp:
  14761. (WebCore::willSendRequest):
  14762. Make sure to set the current storage session on any requests used by the Web
  14763. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  14764. doing anything with the Web Process's default storage session (which is not the one shared
  14765. with the UI Process).
  14766. (WebCore::makeFinalRequest):
  14767. Ditto.
  14768. (WebCore::ResourceHandle::willSendRequest):
  14769. Ditto.
  14770. (WebCore::ResourceHandle::currentStorageSession):
  14771. If there is a Private Browsing storage session, return that.
  14772. If not, on Windows return the default storage session that is being shared with the UI
  14773. Process and on Mac return 0.
  14774. (WebCore::defaultCFURLStorageSession):
  14775. (WebCore::ResourceHandle::setDefaultStorageSession):
  14776. (WebCore::ResourceHandle::defaultStorageSession):
  14777. * platform/network/cf/ResourceRequestCFNet.cpp:
  14778. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  14779. Make sure to set the current storage session on any requests used by the Web
  14780. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  14781. doing anything with the Web Process's default storage session (which is not the one shared
  14782. with the UI Process).
  14783. 2011-05-11 Martin Robinson <mrobinson@igalia.com>
  14784. Try once more to fix the WinCairo build.
  14785. * platform/graphics/cairo/CairoUtilities.h: Include GraphicsTypes.h with a relative
  14786. include rather than a system include.
  14787. 2011-05-11 Sam Weinig <sam@webkit.org>
  14788. Reviewed by Eric Seidel.
  14789. Stop including Console.h just to get Console enum types
  14790. https://bugs.webkit.org/show_bug.cgi?id=60607
  14791. Move MessageSource, MessageType and MessageLevel into its own
  14792. header and cleanup surrounding classes.
  14793. * GNUmakefile.list.am:
  14794. * WebCore.gypi:
  14795. * WebCore.pro:
  14796. * WebCore.vcproj/WebCore.vcproj:
  14797. * WebCore.xcodeproj/project.pbxproj:
  14798. * bindings/js/JSCustomXPathNSResolver.cpp:
  14799. * bindings/scripts/CodeGeneratorJS.pm:
  14800. * bindings/v8/V8Proxy.cpp:
  14801. * dom/ScriptExecutionContext.h:
  14802. * html/HTMLFormElement.cpp:
  14803. * html/parser/XSSFilter.cpp:
  14804. * inspector/ConsoleMessage.h:
  14805. * inspector/InjectedScriptHost.h:
  14806. * inspector/InspectorAgent.h:
  14807. * inspector/InspectorConsoleAgent.h:
  14808. * inspector/InspectorFrontendHost.h:
  14809. * inspector/InspectorInstrumentation.cpp:
  14810. * inspector/InspectorInstrumentation.h:
  14811. * loader/EmptyClients.h:
  14812. * loader/FrameLoader.cpp:
  14813. * loader/MainResourceLoader.cpp:
  14814. * loader/appcache/ApplicationCacheGroup.cpp:
  14815. * page/ChromeClient.h:
  14816. * page/Console.cpp:
  14817. (WebCore::Console::~Console):
  14818. * page/Console.h:
  14819. * page/ConsoleTypes.h: Added.
  14820. * page/ContentSecurityPolicy.cpp:
  14821. * page/Geolocation.h:
  14822. * workers/WorkerReportingProxy.h:
  14823. * xml/XMLHttpRequest.cpp:
  14824. 2011-05-11 Dimitri Glazkov <dglazkov@chromium.org>
  14825. Unreviewed, rolling out r85650.
  14826. http://trac.webkit.org/changeset/85650
  14827. https://bugs.webkit.org/show_bug.cgi?id=59983
  14828. Triggers m_numNodeListCaches > 0 assert in gc-heavy sites.
  14829. * dom/ContainerNode.cpp:
  14830. (WebCore::ContainerNode::childrenChanged):
  14831. * dom/Node.cpp:
  14832. (WebCore::Node::~Node):
  14833. (WebCore::Node::setDocument):
  14834. (WebCore::Node::setTreeScopeRecursively):
  14835. (WebCore::Node::childNodes):
  14836. (WebCore::Node::registerDynamicNodeList):
  14837. (WebCore::Node::unregisterDynamicNodeList):
  14838. (WebCore::Node::notifyLocalNodeListsAttributeChanged):
  14839. (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  14840. (WebCore::Node::getElementsByTagName):
  14841. (WebCore::Node::getElementsByTagNameNS):
  14842. (WebCore::Node::getElementsByName):
  14843. (WebCore::Node::getElementsByClassName):
  14844. * dom/Node.h:
  14845. * html/HTMLFormControlElement.cpp:
  14846. (WebCore::HTMLFormControlElement::labels):
  14847. 2011-05-11 Eric Carlson <eric.carlson@apple.com>
  14848. Reviewed by Darin Adler.
  14849. Video track sometimes fails to draw.
  14850. https://bugs.webkit.org/show_bug.cgi?id=60635
  14851. <rdar://problem/9281951>
  14852. No new tests, covered by existing pixel tests.
  14853. * html/HTMLMediaElement.cpp:
  14854. (WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a
  14855. recalculation, and media engine notification, the next time the state machine runs.
  14856. 2011-05-11 Adam Roben <aroben@apple.com>
  14857. WinCE build fixes for strict PassOwnPtr
  14858. * platform/graphics/wince/SharedBitmap.cpp:
  14859. (WebCore::SharedBitmap::createHandle):
  14860. (WebCore::SharedBitmap::clipBitmap):
  14861. Use nullptr instead of 0.
  14862. * platform/graphics/wince/SimpleFontDataWinCE.cpp: Keep LOOSE_PASS_OWN_PTR turned on for
  14863. this file until SimpleFontData::scaledFontData is dealt with on all platforms.
  14864. * platform/text/wince/TextCodecWinCE.cpp:
  14865. (WebCore::newTextCodecWinCE): Use adoptPtr.
  14866. 2011-05-11 Chang Shu <cshu@webkit.org>
  14867. Reviewed by Antonio Gomes.
  14868. [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
  14869. https://bugs.webkit.org/show_bug.cgi?id=60477
  14870. PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
  14871. The value is checked at EventHandler.cpp:2527 (r86166).
  14872. Function keyTextForKeyEvent is partially implemented and can be enhanced in
  14873. a need-base.
  14874. * platform/qt/PlatformKeyboardEventQt.cpp:
  14875. (WebCore::keyTextForKeyEvent):
  14876. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  14877. 2011-05-11 Adam Roben <aroben@apple.com>
  14878. Use case-insensitive comparisons when checking plugin filenames on Windows
  14879. Windows paths are nearly always case-insensitive.
  14880. I couldn't think of a good way to test this.
  14881. Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
  14882. should not
  14883. Reviewed by Steve Falkenburg.
  14884. * plugins/win/PluginPackageWin.cpp:
  14885. (WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
  14886. checking plugin filenames.
  14887. 2011-05-11 Adam Roben <aroben@apple.com>
  14888. Turn on strict PassOwnPtr on Windows
  14889. Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled
  14890. Reviewed by Adam Barth.
  14891. * platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this
  14892. file until SimpleFontData::scaledFontData is dealt with on all platforms.
  14893. 2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>
  14894. Reviewed by Geoffrey Garen.
  14895. XPathResult should keep its node set's JS wrappers alive
  14896. https://bugs.webkit.org/show_bug.cgi?id=34231
  14897. The change added a custom mark function for JSC. V8 was already properly
  14898. marking the nodes so no change were done on the V8 side.
  14899. Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html
  14900. fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
  14901. fast/xpath/xpath-result-eventlistener-crash.html
  14902. fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html
  14903. * Android.jscbindings.mk:
  14904. * GNUmakefile.list.am:
  14905. * UseJSC.cmake:
  14906. * WebCore.gypi:
  14907. * WebCore.pro:
  14908. * WebCore.vcproj/WebCore.vcproj:
  14909. * WebCore.xcodeproj/project.pbxproj:
  14910. * bindings/js/JSBindingsAllInOne.cpp:
  14911. Added the new file to our build systems.
  14912. * bindings/js/JSXPathResultCustom.cpp: Added.
  14913. (WebCore::JSXPathResult::markChildren): Added code to mark the
  14914. XPathResult snapshot's nodes.
  14915. * xml/XPathResult.h:
  14916. (WebCore::XPathResult::value): Exposed this getter so that we can
  14917. mark our XPathValue.
  14918. * xml/XPathResult.idl: Told the IDL parser that we now need
  14919. a custom mark function.
  14920. 2011-05-04 Philippe Normand <pnormand@igalia.com>
  14921. Reviewed by Martin Robinson.
  14922. [Gtk+] deadlock in gstreamer video player when exiting fullscreen
  14923. https://bugs.webkit.org/show_bug.cgi?id=58548
  14924. Block data flow towards the pipeline branch to remove to avoid
  14925. potential deadlocks during the PAUSED->READY transitions of the
  14926. elements to remove.
  14927. * platform/graphics/gstreamer/GStreamerGWorld.cpp:
  14928. (WebCore::GStreamerGWorld::exitFullscreen):
  14929. 2011-05-11 Kent Tamura <tkent@chromium.org>
  14930. Reviewed by Hajime Morita.
  14931. The position of validation message bubble is wrong for non text fields.
  14932. https://bugs.webkit.org/show_bug.cgi?id=60341
  14933. Tests: fast/forms/validation-message-on-checkbox.html
  14934. fast/forms/validation-message-on-listbox.html
  14935. fast/forms/validation-message-on-menulist.html
  14936. fast/forms/validation-message-on-radio.html
  14937. fast/forms/validation-message-on-textarea.html
  14938. * css/html.css:
  14939. (::-webkit-validation-bubble-message):
  14940. Add white-space:normal in order not to inherit white-space:pre for <select>.
  14941. * html/ValidationMessage.cpp:
  14942. (WebCore::adjustBubblePosition):
  14943. Adjust the bubble position.
  14944. - The top of the bubble should be same as the bottom of the target control.
  14945. - The left of the bubble should be same as the left of the target control.
  14946. But If the left+32 is larger than the center of the target control,
  14947. left+32 should be at the center of the target control.
  14948. But the left position should not be less than 0.
  14949. (WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition().
  14950. 2011-05-11 Emil A Eklund <eae@chromium.org>
  14951. Reviewed by Eric Seidel.
  14952. Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
  14953. https://bugs.webkit.org/show_bug.cgi?id=60592
  14954. Refactoring, covered by existing tests.
  14955. * rendering/RenderFlexibleBox.cpp:
  14956. (WebCore::RenderFlexibleBox::layoutBlock):
  14957. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  14958. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  14959. (WebCore::RenderFlexibleBox::placeChild):
  14960. * rendering/RenderFlexibleBox.h:
  14961. 2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>
  14962. Unreviewed buildfix for strict OwnPtr.
  14963. * platform/audio/AudioBus.cpp:
  14964. (WebCore::AudioBus::createBufferFromRange):
  14965. (WebCore::AudioBus::createBySampleRateConverting):
  14966. (WebCore::AudioBus::createByMixingToMono):
  14967. * platform/audio/HRTFElevation.cpp:
  14968. (WebCore::HRTFElevation::createForSubject):
  14969. (WebCore::HRTFElevation::createByInterpolatingSlices):
  14970. * platform/audio/Panner.cpp:
  14971. (WebCore::Panner::create):
  14972. * platform/audio/Reverb.cpp:
  14973. (WebCore::Reverb::initialize):
  14974. * platform/audio/chromium/AudioBusChromium.cpp:
  14975. (WebCore::AudioBus::loadPlatformResource):
  14976. (WebCore::createBusFromInMemoryAudioFile):
  14977. 2011-05-10 Adam Barth <abarth@webkit.org>
  14978. Build fix for font data madness. I've had to whitelist this on several
  14979. ports. They need to all be fixed at once.
  14980. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  14981. 2011-05-10 David Kilzer <ddkilzer@apple.com>
  14982. BUILD FIX for !ENABLE(TEXT_CARET) after r86039
  14983. * editing/FrameSelection.cpp:
  14984. (WebCore::DragCaretController::paintDragCaret): Added
  14985. UNUSED_PARAM(frame) for !ENABLE(TEXT_CARET).
  14986. 2011-05-10 James Robinson <jamesr@chromium.org>
  14987. Reviewed by Kenneth Russell.
  14988. [chromium] Clean up setLayerRenderer() calls in LayerRendererChromium
  14989. https://bugs.webkit.org/show_bug.cgi?id=60524
  14990. This refactors the way LayerRendererChromium calls setLayerRenderer on its layers in a few ways to clean things
  14991. up:
  14992. *) Move the pre-paint call to setLayerRenderer from updatePropertiesAndRenderSurfaces() to paintLayerContents().
  14993. updatePropertiesAndRenderSurfaces() does too much and the layer renderer pointer only has to be up to date to do
  14994. the actual paint. Longer term we won't need to call this at all in order to call paint and this call will just
  14995. go away.
  14996. *) Tweaks updateCompositorResourcesRecursive() to be slightly shorter and less error-prone.
  14997. *) Explicitly set the LayerRendererChromium for each layer in the tree when transfering the root layer (used
  14998. during lost context). LayerChromium::setLayerRenderer checks if the new LayerRendererChromium is different
  14999. by comparing the pointer value to the old one. This check will be incorrect if there are multiple lost
  15000. contexts between a setLayerRenderer() call and a new LayerRendererChromium happens to be allocated at the
  15001. same address as the old one. An explicit call to setLayerRenderer() for every layer in the tree fixes this
  15002. since when this function is called the new and old LayerRendererChromium are still live and so they cannot
  15003. live at the same address.
  15004. The first two changes are purely refactors and do not change behavior. The third issue can't be tested via a
  15005. layout test directly as we don't have a way to induce a lost context on the compositor in a layout test.
  15006. * platform/graphics/chromium/LayerRendererChromium.cpp:
  15007. (WebCore::LayerRendererChromium::paintLayerContents):
  15008. (WebCore::LayerRendererChromium::clearLayerRendererRecursive):
  15009. (WebCore::LayerRendererChromium::transferRootLayer):
  15010. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  15011. (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  15012. * platform/graphics/chromium/LayerRendererChromium.h:
  15013. 2011-05-10 Anton D'Auria <adauria@apple.com>
  15014. Reviewed by David Levin.
  15015. StorageTracker should report actual local storage usage on disk
  15016. https://bugs.webkit.org/show_bug.cgi?id=60558
  15017. Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html
  15018. storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html
  15019. Use SQLiteFileSystem::getDatabaseFileSize to get actual usage by
  15020. an origin's local storage db. Factored out code that retrieves
  15021. path of local storage db.
  15022. * WebCore.exp.in: Sorted alphabetically StorageTracker's mangled
  15023. function names.
  15024. * storage/StorageTracker.cpp:
  15025. (WebCore::StorageTracker::syncDeleteOrigin): Uses helper function
  15026. to get path of origin's db
  15027. (WebCore::StorageTracker::databasePathForOrigin): New helper function.
  15028. that gets the path of an origin's local storage db from StorageTracker.
  15029. (WebCore::StorageTracker::diskUsageForOrigin): New API.
  15030. * storage/StorageTracker.h:
  15031. 2011-05-10 Anton D'Auria <adauria@apple.com>
  15032. Reviewed by Alexey Proskuryakov.
  15033. Add ApplicationCache API to get disk usage per origin
  15034. https://bugs.webkit.org/show_bug.cgi?id=57127
  15035. ApplicationCacheStorage already provides an API to get per-origin
  15036. disk usage. This should be exposed through WebCore::ApplicationCache
  15037. to not be dependent on storage implementation.
  15038. Test: http/tests/appcache/origin-usage.html
  15039. * WebCore.exp.in:
  15040. * loader/appcache/ApplicationCache.cpp:
  15041. (WebCore::ApplicationCache::diskUsageForOrigin):
  15042. * loader/appcache/ApplicationCache.h:
  15043. 2011-05-10 Pratik Solanki <psolanki@apple.com>
  15044. Reviewed by Alexey Proskuryakov.
  15045. Protect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
  15046. https://bugs.webkit.org/show_bug.cgi?id=60594
  15047. <rdar://problem/9203259>
  15048. No tests since we don't have any bots testing CFNETWORK_DATA_ARRAY_CALLBACK.
  15049. * platform/network/mac/ResourceHandleMac.mm:
  15050. (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): The didReceiveData()
  15051. callback on client can result in the load being cancelled. This results in the delegate
  15052. (self) being freed. Protect self during the loop so we can check for m_handle and safely
  15053. return without crashing.
  15054. 2011-05-10 Chris Guillory <chris.guillory@google.com>
  15055. Reviewed by James Robinson.
  15056. [ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint.
  15057. https://bugs.webkit.org/show_bug.cgi?id=59848
  15058. To test this I plan to make the non-printing device (BitmapPlatformDevice) fail
  15059. when EndPlatformPaint doesn't matchup with BeginPlatformPaint.
  15060. http://codereview.chromium.org/6949012/
  15061. * platform/graphics/chromium/FontChromiumWin.cpp:
  15062. (WebCore::Font::drawComplexText):
  15063. 2011-05-10 Sheriff Bot <webkit.review.bot@gmail.com>
  15064. Unreviewed, rolling out r86195.
  15065. http://trac.webkit.org/changeset/86195
  15066. https://bugs.webkit.org/show_bug.cgi?id=60597
  15067. LayerOffset is a really bad name (Requested by smfr on
  15068. #webkit).
  15069. * GNUmakefile.list.am:
  15070. * WebCore.gypi:
  15071. * WebCore.pro:
  15072. * WebCore.vcproj/WebCore.vcproj:
  15073. * WebCore.xcodeproj/project.pbxproj:
  15074. * page/FrameView.cpp:
  15075. (WebCore::FrameView::paintScrollCorner):
  15076. * platform/graphics/LayerOffset.h: Removed.
  15077. * rendering/InlineTextBox.cpp:
  15078. (WebCore::InlineTextBox::paint):
  15079. (WebCore::InlineTextBox::paintCustomHighlight):
  15080. * rendering/InlineTextBox.h:
  15081. * rendering/RenderBox.cpp:
  15082. (WebCore::RenderBox::paintCustomHighlight):
  15083. * rendering/RenderBox.h:
  15084. * rendering/RenderImage.cpp:
  15085. (WebCore::RenderImage::paintReplaced):
  15086. * rendering/RenderLayer.cpp:
  15087. (WebCore::RenderLayer::paintScrollCorner):
  15088. (WebCore::RenderLayer::paintResizer):
  15089. * rendering/RenderListMarker.cpp:
  15090. (WebCore::RenderListMarker::paint):
  15091. * rendering/RenderObject.h:
  15092. * rendering/RenderScrollbar.cpp:
  15093. (WebCore::RenderScrollbar::paintPart):
  15094. * rendering/RenderScrollbarPart.cpp:
  15095. (WebCore::RenderScrollbarPart::paintIntoRect):
  15096. * rendering/RenderScrollbarPart.h:
  15097. * rendering/RenderTable.cpp:
  15098. (WebCore::RenderTable::paintObject):
  15099. (WebCore::RenderTable::paintMask):
  15100. * rendering/RenderTable.h:
  15101. * rendering/RenderWidget.cpp:
  15102. (WebCore::RenderWidget::paint):
  15103. * rendering/RootInlineBox.cpp:
  15104. (WebCore::RootInlineBox::paintCustomHighlight):
  15105. (WebCore::RootInlineBox::paint):
  15106. * rendering/RootInlineBox.h:
  15107. 2011-05-10 Emil A Eklund <eae@chromium.org>
  15108. Reviewed by Eric Seidel.
  15109. Convert x,y and width,height pairs to IntPoint and IntSize for RenderLayer
  15110. https://bugs.webkit.org/show_bug.cgi?id=60409
  15111. Convert RenderLayer to use IntPoint for x,y pairs and IntSize for offsets and sizes.
  15112. Refactoring, covered by existing tests.
  15113. * rendering/RenderLayer.cpp:
  15114. (WebCore::RenderLayer::RenderLayer):
  15115. (WebCore::RenderLayer::updateLayerPositions):
  15116. (WebCore::RenderLayer::updateLayerPosition):
  15117. (WebCore::RenderLayer::scrollTo):
  15118. (WebCore::RenderLayer::visibleHeight):
  15119. (WebCore::RenderLayer::visibleWidth):
  15120. (WebCore::RenderLayer::scrollWidth):
  15121. (WebCore::RenderLayer::scrollHeight):
  15122. (WebCore::RenderLayer::computeScrollDimensions):
  15123. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  15124. * rendering/RenderLayer.h:
  15125. (WebCore::RenderLayer::x):
  15126. (WebCore::RenderLayer::y):
  15127. (WebCore::RenderLayer::setLocation):
  15128. (WebCore::RenderLayer::width):
  15129. (WebCore::RenderLayer::height):
  15130. (WebCore::RenderLayer::size):
  15131. (WebCore::RenderLayer::setWidth):
  15132. (WebCore::RenderLayer::setHeight):
  15133. (WebCore::RenderLayer::scrolledContentOffset):
  15134. (WebCore::RenderLayer::scrollXOffset):
  15135. (WebCore::RenderLayer::scrollYOffset):
  15136. (WebCore::RenderLayer::scrollOffset):
  15137. (WebCore::RenderLayer::scrollToXOffset):
  15138. (WebCore::RenderLayer::scrollToYOffset):
  15139. (WebCore::RenderLayer::relativePositionOffset):
  15140. 2011-05-10 Levi Weintraub <leviw@chromium.org>
  15141. Reviewed by Eric Seidel.
  15142. Create LayerOffset class
  15143. https://bugs.webkit.org/show_bug.cgi?id=60490
  15144. Adding a LayerOffset class that will replace existing usage of tx/ty.
  15145. LayerOffset is necessary since these values are commonly used as both
  15146. a size and a point. Updating paintIntoRect to use this new class.
  15147. No new tests since this doesn't change any behavior.
  15148. * GNUmakefile.list.am:
  15149. * WebCore.gypi:
  15150. * WebCore.pro:
  15151. * WebCore.vcproj/WebCore.vcproj:
  15152. * WebCore.xcodeproj/project.pbxproj:
  15153. * page/FrameView.cpp:
  15154. (WebCore::FrameView::paintScrollCorner):
  15155. * platform/graphics/LayerOffset.h: Added.
  15156. (WebCore::LayerOffset::LayerOffset):
  15157. (WebCore::LayerOffset::x):
  15158. (WebCore::LayerOffset::y):
  15159. (WebCore::LayerOffset::setX):
  15160. (WebCore::LayerOffset::setY):
  15161. (WebCore::LayerOffset::toSize):
  15162. (WebCore::LayerOffset::toPoint):
  15163. (WebCore::operator+=):
  15164. (WebCore::operator-=):
  15165. (WebCore::operator+):
  15166. (WebCore::operator-):
  15167. (WebCore::operator==):
  15168. (WebCore::operator!=):
  15169. * rendering/RenderLayer.cpp:
  15170. (WebCore::RenderLayer::paintScrollCorner):
  15171. (WebCore::RenderLayer::paintResizer):
  15172. * rendering/RenderScrollbar.cpp:
  15173. (WebCore::RenderScrollbar::paintPart):
  15174. * rendering/RenderScrollbarPart.cpp:
  15175. (WebCore::RenderScrollbarPart::paintIntoRect):
  15176. * rendering/RenderScrollbarPart.h:
  15177. 2011-05-10 Ryosuke Niwa <rniwa@webkit.org>
  15178. Reviewed by Darin Adler.
  15179. Make member variables of CaretBase private
  15180. https://bugs.webkit.org/show_bug.cgi?id=60454
  15181. Moved m_absCaretBounds, m_absoluteCaretRepaintBounds, m_absCaretBoundsDirty, and m_caretPaint back
  15182. from CaretBase to FrameSelection because they are only used in FrameSelection, and made the rest
  15183. of member variables in CaretBase private.
  15184. * editing/FrameSelection.cpp:
  15185. (WebCore::CaretBase::CaretBase): Takes CaretVisibility as an argument.
  15186. (WebCore::DragCaretController::DragCaretController):
  15187. (WebCore::FrameSelection::FrameSelection): Initializes m_absCaretBoundsDirty and m_caretPaint
  15188. now that they are part of FrameSelection again.
  15189. (WebCore::DragCaretController::setCaretPosition):
  15190. (WebCore::FrameSelection::setSelection):
  15191. (WebCore::CaretBase::clearCaretRect): Extracted from updateCaretRect.
  15192. (WebCore::CaretBase::updateCaretRect): No longer clears caret; all call sites (namely setCaretPosition
  15193. and localCaretRect) that used to call updateCaretRect now need to call clearCaretRect or updateCaretRect
  15194. based on some conditions.
  15195. (WebCore::FrameSelection::localCaretRect):
  15196. (WebCore::CaretBase::caretRepaintRect):
  15197. (WebCore::FrameSelection::recomputeCaretRect):
  15198. (WebCore::FrameSelection::paintCaret): Only calls CaretBase::paintCaret if m_caretPaint is true.
  15199. (WebCore::CaretBase::paintCaret): Removed an early exit for when m_caretPaint is false since m_caretPaint
  15200. has been moved from CaretBase to FrameSelection.
  15201. (WebCore::FrameSelection::focusedOrActiveStateChanged):
  15202. (WebCore::FrameSelection::updateAppearance):
  15203. (WebCore::FrameSelection::setCaretVisibility): Takes CaretVisibility instead of bool.
  15204. (WebCore::FrameSelection::caretBlinkTimerFired):
  15205. * editing/FrameSelection.h:
  15206. (WebCore::CaretBase::fastLocalCaretRect): Added; replaces localCaretRectForPainting.
  15207. (WebCore::CaretBase::shouldUpdateCaretRect): Added.
  15208. (WebCore::CaretBase::setCaretRectNeedsUpdate): Added.
  15209. (WebCore::CaretBase::setCaretVisibility): Added.
  15210. (WebCore::CaretBase::caretIsVisible): Added.
  15211. (WebCore::FrameSelection::setCaretRectNeedsUpdate): Added.
  15212. 2011-05-10 James Robinson <jamesr@chromium.org>
  15213. Reviewed by Nate Chapin.
  15214. [chromium] Use parent/child terms for compositor tree structures consistently instead of superlayer/sublayer
  15215. https://bugs.webkit.org/show_bug.cgi?id=60588
  15216. GraphicsLayer uses parent/child terminology for tree structure, as does CCLayerImpl. LayerChromium was using
  15217. superlayer/sublayer terms, inherited from this code's branching from the platform/graphics/win/CACF code. The
  15218. mixed terminology is confusing and parent/child is more common, so this unifies everything to use parent/child.
  15219. No new tests, refactor only.
  15220. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  15221. (WebCore::GraphicsLayerChromium::setChildren):
  15222. (WebCore::GraphicsLayerChromium::addChild):
  15223. (WebCore::GraphicsLayerChromium::addChildAtIndex):
  15224. (WebCore::GraphicsLayerChromium::addChildBelow):
  15225. (WebCore::GraphicsLayerChromium::addChildAbove):
  15226. (WebCore::GraphicsLayerChromium::replaceChild):
  15227. (WebCore::GraphicsLayerChromium::removeFromParent):
  15228. (WebCore::GraphicsLayerChromium::setContentsToImage):
  15229. (WebCore::GraphicsLayerChromium::setContentsToCanvas):
  15230. (WebCore::GraphicsLayerChromium::setContentsToMedia):
  15231. (WebCore::GraphicsLayerChromium::hostLayerForChildren):
  15232. (WebCore::GraphicsLayerChromium::layerForParent):
  15233. (WebCore::GraphicsLayerChromium::updateChildList):
  15234. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  15235. (WebCore::GraphicsLayerChromium::setupContentsLayer):
  15236. * platform/graphics/chromium/GraphicsLayerChromium.h:
  15237. * platform/graphics/chromium/LayerChromium.cpp:
  15238. (WebCore::LayerChromium::LayerChromium):
  15239. (WebCore::LayerChromium::~LayerChromium):
  15240. (WebCore::LayerChromium::addChild):
  15241. (WebCore::LayerChromium::insertChild):
  15242. (WebCore::LayerChromium::removeFromParent):
  15243. (WebCore::LayerChromium::removeChild):
  15244. (WebCore::LayerChromium::replaceChild):
  15245. (WebCore::LayerChromium::indexOfChild):
  15246. (WebCore::LayerChromium::rootLayer):
  15247. (WebCore::LayerChromium::removeAllChildren):
  15248. (WebCore::LayerChromium::setChildren):
  15249. (WebCore::LayerChromium::parent):
  15250. (WebCore::LayerChromium::dumpLayer):
  15251. * platform/graphics/chromium/LayerChromium.h:
  15252. (WebCore::LayerChromium::children):
  15253. (WebCore::LayerChromium::setParent):
  15254. (WebCore::LayerChromium::numChildren):
  15255. * platform/graphics/chromium/LayerRendererChromium.cpp:
  15256. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  15257. (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  15258. (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  15259. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  15260. (WebCore::CCLayerImpl::parent):
  15261. (WebCore::CCLayerImpl::descendantsDrawsContent):
  15262. * platform/graphics/chromium/cc/CCLayerImpl.h:
  15263. 2011-05-10 Levi Weintraub <leviw@chromium.org>
  15264. Reviewed by Darin Adler.
  15265. Switch RenderBoxModelObject::paintNinePieceImage to use IntRect instead of four ints
  15266. https://bugs.webkit.org/show_bug.cgi?id=60586
  15267. Switch paintNinePieceImage to take an IntRect instead of four ints representing an IntRect!
  15268. No new tests as this is simply refactoring.
  15269. * rendering/InlineFlowBox.cpp:
  15270. (WebCore::InlineFlowBox::paintMask):
  15271. * rendering/RenderBox.cpp:
  15272. (WebCore::RenderBox::paintMaskImages):
  15273. * rendering/RenderBoxModelObject.cpp:
  15274. (WebCore::RenderBoxModelObject::paintNinePieceImage):
  15275. (WebCore::RenderBoxModelObject::paintBorder):
  15276. * rendering/RenderBoxModelObject.h:
  15277. 2011-05-05 Jer Noble <jer.noble@apple.com>
  15278. Reviewed by Maciej Stachowiak.
  15279. Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
  15280. https://bugs.webkit.org/show_bug.cgi?id=60278
  15281. Handle the removal of a full screen element from within Node::willRemove() instead
  15282. of Document::nodeWillBeRemoved(). The new function Document::fullScreenElementWillBeRemoved() will
  15283. be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().
  15284. Test: fullscreen/full-screen-remove-children.html
  15285. * dom/Document.cpp:
  15286. (WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element.
  15287. (WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
  15288. * dom/Document.h:
  15289. * dom/Node.cpp:
  15290. (WebCore::Node::willRemove): Check to see if this is the current full screen element.
  15291. 2011-05-10 Beth Dakin <bdakin@apple.com>
  15292. Reviewed by Darin Adler.
  15293. https://bugs.webkit.org/show_bug.cgi?id=60582
  15294. Crash switching overlay/non-overlay scrollbar preference still possible
  15295. -and corresponding-
  15296. <rdar://problem/9323983>
  15297. This patch prevents any work from being done on pages that are in the page cache
  15298. when the preference is switched.
  15299. When the Document is going into or coming out of the page cache, have the
  15300. FrameView inactivate or activate the Page's ScrollAnimators as appropriate.
  15301. * dom/Document.cpp:
  15302. (WebCore::Document::setInPageCache):
  15303. Iterate through the Page's ScrollableAreas setting the active state of the
  15304. ScrollAnimators.
  15305. * page/FrameView.cpp:
  15306. (WebCore::FrameView::setAnimatorsAreActive):
  15307. * page/FrameView.h:
  15308. ScrollAnimator has a new bit -- m_isActive. Right now m_isActive is always true
  15309. unless the ScrollAnimator belongs to a ScrollableArea that is in the page cache.
  15310. * platform/ScrollAnimator.cpp:
  15311. (WebCore::ScrollAnimator::ScrollAnimator):
  15312. * platform/ScrollAnimator.h:
  15313. (WebCore::ScrollAnimator::setIsActive):
  15314. (WebCore::ScrollAnimator::isActive):
  15315. ScrollAnimatorMac has a new bit -- m_needsScrollerStyleUpdate. This is set to true
  15316. when a ScrollAnimator is inactive and has received the
  15317. updateScrollerStyleForNewRecommendedScrollerStyle delegate notification. It
  15318. prevents any work from being done for this delegate until the ScrollAnimator
  15319. becomes active again.
  15320. * platform/mac/ScrollAnimatorMac.h:
  15321. (WebCore::ScrollAnimatorMac::setNeedsScrollerStyleUpdate):
  15322. (WebCore::ScrollAnimatorMac::needsScrollerStyleUpdate):
  15323. This delegate method has been re-factored into ScrollAnimatorMac::
  15324. updateScrollerStyle(). This way the meat of the function can be called by both the
  15325. delegate and ScrollAnimatorMac::setIsActive()
  15326. * platform/mac/ScrollAnimatorMac.mm:
  15327. (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
  15328. (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
  15329. This override of ScrollAnimator::setIsActive() calls the base class, and then calls updateScrollerStyle() if needsScrollerStyleUpdate() is set to true.
  15330. (WebCore::ScrollAnimatorMac::setIsActive):
  15331. This is mostly the same as the old delegate method. Key differences are that if
  15332. the ScrollAnimator is inactive, we now setNeedsScrollerStyleUpdate(true) and
  15333. return early. We also only call scrollableArea()->scrollbarStyleChanged() if
  15334. needsScrollerStyleUpdate() is false since in the true case when we are restoring
  15335. from the page cache, this would be duplicated work.
  15336. (WebCore::ScrollAnimatorMac::updateScrollerStyle):
  15337. New WKSystemInterface function is needed to retrieve the scrollbar style.
  15338. * WebCore.exp.in:
  15339. * platform/mac/WebCoreSystemInterface.h:
  15340. * platform/mac/WebCoreSystemInterface.mm:
  15341. 2011-05-10 Adam Barth <abarth@webkit.org>
  15342. Reviewed by David Levin.
  15343. Enable strict PassOwnPtr on Chromium
  15344. https://bugs.webkit.org/show_bug.cgi?id=60502
  15345. Technically there are a few bits in here that weren't reviewed by Dave,
  15346. but close enough for government work. This patch all fixes the
  15347. remaining strict PassOwnPtr violations on Chromium Linux.
  15348. * platform/graphics/chromium/PlatformCanvas.cpp:
  15349. (WebCore::PlatformCanvas::resize):
  15350. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  15351. * platform/graphics/skia/ImageBufferSkia.cpp:
  15352. (WebCore::ImageBuffer::ImageBuffer):
  15353. * platform/graphics/skia/PlatformContextSkia.cpp:
  15354. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  15355. 2011-05-10 Brady Eidson <beidson@apple.com>
  15356. Reviewed by Alice Liu.
  15357. <rdar://problem/9343191> and https://bugs.webkit.org/show_bug.cgi?id=60572
  15358. REGRESSION - Canon On-screen Manual.app crashes after a search
  15359. No new tests - There's no way to reproduce the truly bizarre things Canon does in their app
  15360. that would reasonably fit in to our testing infrastructure.
  15361. In r66577 a new behavior was added where changing the "setLoadsImagesAutomatically" setting to "true" would immediately
  15362. start loading those images that had been disabled.
  15363. If this happens while a WebView is being dealloc'ed, and we don't know the WebView is being dealloc'ed, these new loads
  15364. can cause crashes downstream when the WebView memory has actually been free'd.
  15365. One example where this can happen is in Mac apps that subclass WebView then do work in their overridden dealloc methods.
  15366. And the Canon Onscreen Manual is one such app.
  15367. Starting these loads synchronously is not important. By putting it on a 0-delay, properly closing the Page cancels them
  15368. before they have a chance to really start.
  15369. See http://webkit.org/b/60572 for more discussion.
  15370. Add a timer to Settings and instead of calling setLoadsImagesAutomaticallyInAllFrames right
  15371. away when this pref changes, call it on a 0-delay:
  15372. * page/Settings.cpp:
  15373. (WebCore::Settings::Settings):
  15374. (WebCore::Settings::setLoadsImagesAutomatically):
  15375. (WebCore::Settings::loadsImagesAutomaticallyTimerFired):
  15376. * page/Settings.h:
  15377. 2011-05-10 Martin Robinson <mrobinson@igalia.com>
  15378. Reviewed by Xan Lopez.
  15379. [GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
  15380. https://bugs.webkit.org/show_bug.cgi?id=59990
  15381. No new tests. This is covered by existing pixel tests.
  15382. * platform/gtk/GtkVersioning.c:
  15383. (getGdkDrawableSize): Added this helper method.
  15384. * platform/gtk/GtkVersioning.h: Added helper method declaration.
  15385. * platform/gtk/WidgetRenderingContext.cpp:
  15386. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Call into the helper if
  15387. there is actually a GdkDrawable. If not, disable the sanity check.
  15388. 2011-05-10 Martin Robinson <mrobinson@igalia.com>
  15389. Fix the GTK+ WebKit2 build. Add a CredentialsStorage stub for libsoup.
  15390. * GNUmakefile.list.am: Add stub to source list.
  15391. * platform/network/soup/CredentialStorageSoup.cpp: Added.
  15392. (WebCore::CredentialStorage::getFromPersistentStorage): Added stub.
  15393. (WebCore::CredentialStorage::get):
  15394. 2011-05-09 David Hyatt <hyatt@apple.com>
  15395. Reviewed by Dan Bernstein.
  15396. <rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 seconds to load and makes mail unresponsive
  15397. Second attempts at a fix for this bug. Instead of removing the dirtying (which turned out to be needed in a few cases),
  15398. make dirtyLinesFromChangedChild mark a child as needing layout when it has to recur to the parent. Because the method already
  15399. aborts the recursion if selfNeedsLayout() is set on the parent, this has the effect of stopping the O(n^2) pathological
  15400. behavior, since you can use the selfNeedsLayout() bit to understand that you've dirtied the lines already.
  15401. * rendering/RenderLineBoxList.cpp:
  15402. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  15403. 2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson@igalia.com>
  15404. Reviewed by Anders Carlsson.
  15405. [Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
  15406. https://bugs.webkit.org/show_bug.cgi?id=60293
  15407. No new tests. This is covered by current pixel tests.
  15408. * platform/graphics/cairo/CairoUtilities.cpp:
  15409. (WebCore::copyCairoImageSurface): Abstract the code from WebCore::ImageBuffer::copyImage
  15410. into this helper which creates a deep copy of a Cairo image surface.
  15411. * platform/graphics/cairo/CairoUtilities.h: Added declaration.
  15412. * platform/graphics/cairo/ImageBufferCairo.cpp:
  15413. (WebCore::ImageBuffer::copyImage): Use the new helper.
  15414. * platform/graphics/cairo/ImageCairo.cpp: Abstract some of this logic
  15415. into the new drawSurfaceToContext method on PlatformContextCairo.
  15416. (WebCore::BitmapImage::draw):
  15417. * platform/graphics/cairo/PlatformContextCairo.cpp:
  15418. (WebCore::drawPatternToCairoContext): Added.
  15419. (WebCore::PlatformContextCairo::drawSurfaceToContext): Added.
  15420. * platform/graphics/cairo/PlatformContextCairo.h: Added declarations.
  15421. 2011-05-10 Anders Carlsson <andersca@apple.com>
  15422. Attempt to fix Qt build.
  15423. * platform/network/qt/CredentialStorageQt.cpp:
  15424. (WebCore::CredentialStorage::get):
  15425. Add stub.
  15426. 2011-05-10 Kenichi Ishibashi <bashi@chromium.org>
  15427. Reviewed by Tony Chang.
  15428. REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
  15429. https://bugs.webkit.org/show_bug.cgi?id=60079
  15430. Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
  15431. value pair.
  15432. * platform/graphics/chromium/HarfbuzzSkia.cpp:
  15433. (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
  15434. 2011-05-10 Anders Carlsson <andersca@apple.com>
  15435. Reviewed by Sam Weinig.
  15436. Extra sign in required to view video on MobileMe Gallery album
  15437. https://bugs.webkit.org/show_bug.cgi?id=60560
  15438. <rdar://problem/9338693>
  15439. Add symbols required by WebKit2.
  15440. * WebCore.exp.in:
  15441. 2011-05-10 Alexander Pavlov <apavlov@chromium.org>
  15442. Reviewed by Pavel Feldman.
  15443. Web Inspector: Styles sidebar is not updated upon changes in the Resources panel.
  15444. https://bugs.webkit.org/show_bug.cgi?id=60320
  15445. * inspector/front-end/ElementsPanel.js:
  15446. (WebInspector.ElementsPanel):
  15447. 2011-05-06 Brett Wilson <brettw@chromium.org>
  15448. Reviewed by Adam Barth.
  15449. Use a File object to store the downloaded file reference rather than
  15450. just the path. This keeps the file and permissions in scope (using the
  15451. already-existing blob system) so the browser won't delete the file
  15452. when the load is complete. Instead, the file will be cleaned up when
  15453. the request objects are deleted.
  15454. https://bugs.webkit.org/show_bug.cgi?id=60281
  15455. * platform/network/chromium/ResourceResponse.cpp:
  15456. (WebCore::ResourceResponse::doPlatformCopyData):
  15457. (WebCore::ResourceResponse::doPlatformAdopt):
  15458. * platform/network/chromium/ResourceResponse.h:
  15459. (WebCore::ResourceResponse::downloadedFile):
  15460. (WebCore::ResourceResponse::setDownloadedFile):
  15461. 2011-05-10 Eric Carlson <eric.carlson@apple.com>
  15462. Reviewed by Darin Adler.
  15463. Files that load quickly sometimes won't play.
  15464. https://bugs.webkit.org/show_bug.cgi?id=60556
  15465. <rdar://problem/9330567>
  15466. No new tests, this failure is very difficult to reproduce on some machines. The fix was
  15467. verified manually.
  15468. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  15469. (WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates
  15470. to dispatchNotification so it is more obvious which state changes call it.
  15471. (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
  15472. (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to
  15473. dispatchNotification.
  15474. (WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
  15475. (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
  15476. (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after
  15477. processing "size changed" notification so we detect all state changes. Consolidate
  15478. calls to updateStates here.
  15479. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  15480. (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in
  15481. a debug build.
  15482. 2011-05-10 Abhishek Arya <inferno@chromium.org>
  15483. Reviewed by Simon Fraser.
  15484. Add containsFloats call to hasOverhangingFloats.
  15485. https://bugs.webkit.org/show_bug.cgi?id=60537
  15486. Test: fast/block/float/no-overhanging-float-crash.html
  15487. * rendering/RenderBlock.cpp:
  15488. (WebCore::RenderBlock::repaintOverhangingFloats):
  15489. * rendering/RenderBlock.h:
  15490. (WebCore::RenderBlock::hasOverhangingFloats):
  15491. 2011-05-10 Alexis Menard <alexis.menard@openbossa.org>
  15492. Reviewed by Antonio Gomes.
  15493. Warning fix on PluginPackage.cpp.
  15494. https://bugs.webkit.org/show_bug.cgi?id=60371
  15495. Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
  15496. Let's use a struct rather than an array so we can pass everything to StringHasher.
  15497. * plugins/PluginPackage.cpp:
  15498. (WebCore::PluginPackage::hash):
  15499. 2011-05-10 Andreas Kling <andreas.kling@nokia.com>
  15500. Rubber-stamped by Csaba Osztrogonác.
  15501. [Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
  15502. https://bugs.webkit.org/show_bug.cgi?id=60551
  15503. * WebCore.pro: Disable the line that enables HAVE_QRAWFONT
  15504. if the feature is found. Added a comment about why.
  15505. 2011-05-10 Andrey Kosyakov <caseq@chromium.org>
  15506. Reviewed by Sam Weinig.
  15507. Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
  15508. https://bugs.webkit.org/show_bug.cgi?id=60266
  15509. * bindings/objc/DOM.mm:
  15510. (kitClass): return DOMNode class for shadow root node
  15511. 2011-05-10 Ben Murdoch <benm@google.com>
  15512. Reviewed by Steve Block.
  15513. Fix build in WebCore/xml/XSLTProcessorLibxslt.cpp
  15514. https://bugs.webkit.org/show_bug.cgi?id=60478
  15515. No new tests), build fix only.
  15516. * xml/XSLTProcessorLibxslt.cpp: Add CString.h include.
  15517. 2011-05-10 Keith Kyzivat <keith.kyzivat@nokia.com>
  15518. Reviewed by Kenneth Rohde Christiansen.
  15519. [Qt] QtRawFont support should check based on feature, not version
  15520. https://bugs.webkit.org/show_bug.cgi?id=60513
  15521. Build fix - no tests added.
  15522. * WebCore.pro:
  15523. 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
  15524. Build fix: include ExceptionCode
  15525. https://bugs.webkit.org/show_bug.cgi?id=60538
  15526. * bindings/js/JSDOMBinding.cpp:
  15527. 2011-05-06 Tony Gentilcore <tonyg@chromium.org>
  15528. Reviewed by Darin Adler.
  15529. Fix some unnecessary includes in headers
  15530. https://bugs.webkit.org/show_bug.cgi?id=60388
  15531. These were all found using the include-what-you-use clang plugin.
  15532. * css/CSSFontFaceSrcValue.h:
  15533. * css/CSSImageGeneratorValue.h:
  15534. * css/CSSParser.h:
  15535. * css/CSSPrimitiveValueCache.cpp:
  15536. * css/CSSPrimitiveValueCache.h:
  15537. * css/CSSStyleSelector.cpp:
  15538. * css/CSSStyleSelector.h:
  15539. * css/RGBColor.cpp:
  15540. * css/RGBColor.h:
  15541. * dom/EventTarget.h:
  15542. * dom/ExceptionBase.cpp:
  15543. * dom/ExceptionBase.h:
  15544. * dom/MessagePort.cpp:
  15545. * dom/Range.cpp:
  15546. * dom/Range.h:
  15547. * dom/SelectElement.cpp:
  15548. * dom/SelectElement.h:
  15549. * dom/TextEvent.cpp:
  15550. * dom/TextEvent.h:
  15551. * dom/Touch.cpp:
  15552. * dom/Touch.h:
  15553. * dom/TouchEvent.cpp:
  15554. * dom/TouchEvent.h:
  15555. * dom/XMLDocumentParser.h:
  15556. * dom/XMLDocumentParserScope.h:
  15557. * editing/AppendNodeCommand.cpp:
  15558. * editing/ApplyBlockElementCommand.h:
  15559. * editing/DeleteFromTextNodeCommand.cpp:
  15560. * editing/EditCommand.h:
  15561. * editing/Editor.h:
  15562. * editing/FormatBlockCommand.h:
  15563. * editing/IndentOutdentCommand.h:
  15564. * editing/InsertIntoTextNodeCommand.cpp:
  15565. * editing/InsertNodeBeforeCommand.cpp:
  15566. * editing/ReplaceSelectionCommand.h:
  15567. * editing/SetNodeAttributeCommand.h:
  15568. * html/HTMLSelectElement.h:
  15569. * html/canvas/CanvasRenderingContext2D.cpp:
  15570. * loader/appcache/DOMApplicationCache.cpp:
  15571. * page/EventSource.cpp:
  15572. * rendering/RenderListBox.cpp:
  15573. * rendering/RenderMenuList.cpp:
  15574. * rendering/RenderTextControlSingleLine.cpp:
  15575. * rendering/svg/RenderSVGInlineText.cpp:
  15576. * svg/SVGMatrix.h:
  15577. * websockets/WebSocket.cpp:
  15578. * workers/AbstractWorker.cpp:
  15579. * xml/XMLHttpRequest.cpp:
  15580. * xml/XPathExpression.cpp:
  15581. 2011-05-10 MORITA Hajime <morrita@google.com>
  15582. Reviewed by Ryosuke Niwa.
  15583. REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
  15584. https://bugs.webkit.org/show_bug.cgi?id=60090
  15585. SpellChecker uses TextCheckerClient, which belongs Page object,
  15586. which is possibly destroyed during SpellChecker's lifetime.
  15587. This change added to a guard before using TextCheckerClient to
  15588. ensure it being live.
  15589. No new tests, this is a speculative fix for a real crash.
  15590. * editing/Editor.cpp:
  15591. (WebCore::Editor::Editor):
  15592. * editing/SpellChecker.cpp:
  15593. (WebCore::SpellChecker::SpellChecker):
  15594. (WebCore::SpellChecker::client):
  15595. (WebCore::SpellChecker::canCheckAsynchronously):
  15596. (WebCore::SpellChecker::requestCheckingFor):
  15597. * editing/SpellChecker.h:
  15598. 2011-05-09 Dan Bernstein <mitz@apple.com>
  15599. Try to fix the LLVM Compiler build.
  15600. * page/EventHandler.h:
  15601. 2011-05-09 Daniel Cheng <dcheng@chromium.org>
  15602. Fix the build.
  15603. Really add the file this time.
  15604. * page/DragState.h: Added.
  15605. (WebCore::DragState::DragState):
  15606. 2011-05-09 Daniel Cheng <dcheng@chromium.org>
  15607. Reviewed by Tony Chang.
  15608. Refactor RenderObject::draggableNode.
  15609. https://bugs.webkit.org/show_bug.cgi?id=60503
  15610. This patch lays the ground for refactoring the drag start logic. It moves draggableNode to
  15611. DragController to avoid the awkward plumbing of calling DragController from RenderObject and
  15612. also moves EventHandlerDragState out from EventHandler so it can be shared between
  15613. EventHandler and DragController where appropriate.
  15614. No new tests since there should be no behavior change.
  15615. * GNUmakefile.list.am:
  15616. * WebCore.gypi:
  15617. * WebCore.pro:
  15618. * WebCore.vcproj/WebCore.vcproj:
  15619. * WebCore.xcodeproj/project.pbxproj:
  15620. * page/DragController.cpp:
  15621. (WebCore::DragController::draggableNode):
  15622. (WebCore::DragController::mayStartDragAtEventLocation):
  15623. * page/DragController.h:
  15624. * page/DragState.h: Added.
  15625. (WebCore::DragState::DragState):
  15626. * page/EventHandler.cpp:
  15627. (WebCore::EventHandler::dragState):
  15628. (WebCore::EventHandler::eventMayStartDrag):
  15629. (WebCore::EventHandler::handleDrag):
  15630. * page/EventHandler.h:
  15631. * rendering/RenderObject.cpp:
  15632. * rendering/RenderObject.h:
  15633. 2011-05-09 Luke Macpherson <macpherson@chromium.org>
  15634. Reviewed by Darin Adler.
  15635. Enable casting between CSSPrimitiveValue and FontWeight enum
  15636. https://bugs.webkit.org/show_bug.cgi?id=60516
  15637. No new tests added as no functionality changed.
  15638. * css/CSSPrimitiveValueMappings.h:
  15639. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  15640. Implement cast from FontWeight to CSSPrimitiveValue.
  15641. (WebCore::CSSPrimitiveValue::operator FontWeight):
  15642. Implement cast from CSSPrimitiveValue to FontWeight
  15643. * css/CSSStyleSelector.cpp:
  15644. (WebCore::CSSStyleSelector::applyProperty):
  15645. Use new cast to reduce code size.
  15646. Flatten switch inside if.
  15647. 2011-05-09 Simon Fraser <simon.fraser@apple.com>
  15648. Move IconURL.* into the dom grouping.
  15649. * WebCore.xcodeproj/project.pbxproj:
  15650. 2011-05-08 Jeremy Noble <jer.noble@apple.com>
  15651. Reviewed by Dan Bernstein.
  15652. Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
  15653. https://bugs.webkit.org/show_bug.cgi?id=60449
  15654. Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
  15655. coalesce anonymous children.
  15656. Test: fullscreen/full-screen-remove-sibling.html
  15657. * rendering/RenderObject.h:
  15658. (WebCore::RenderObject::isAnonymousBlock):
  15659. 2011-05-09 Jeremy Noble <jer.noble@apple.com>
  15660. Reviewed by Simon Fraser.
  15661. REGRESSION (r84706): Crazy rendering of vimeo.com after exiting fullscreen video
  15662. https://bugs.webkit.org/show_bug.cgi?id=60512
  15663. Initialize m_containsFullScreenElement.
  15664. * html/HTMLFrameElementBase.cpp:
  15665. (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
  15666. 2011-05-09 Ryosuke Niwa <rniwa@webkit.org>
  15667. Reviewed by Darin Adler.
  15668. REGRESSION(r86039): DragCaretController doesn't draw caret
  15669. https://bugs.webkit.org/show_bug.cgi?id=60505
  15670. Removed an early exit in setCaretPosition introduced by r86039.
  15671. Also replaced calls to containerNode by deprecatedNode since rendering code doesn't
  15672. support container node for rendering caret.
  15673. * editing/FrameSelection.cpp:
  15674. (WebCore::DragCaretController::setCaretPosition):
  15675. 2011-04-29 Martin Robinson <mrobinson@igalia.com>
  15676. Reviewed by Gustavo Noronha Silva.
  15677. [GTK] Untangle GtkAdjustments from WebCore
  15678. https://bugs.webkit.org/show_bug.cgi?id=59821
  15679. Completely remove the ability for WebKit to set GtkAdjustments on ScrollViews
  15680. and, consequently, Scrollbars. Handling adjustment updates can now be managed
  15681. in WebKit.
  15682. No new tests. This is covered by existing Scrollbar tests.
  15683. * platform/ScrollView.cpp: platformInit and platformDestroy can now be shared
  15684. between ScrollView.cpp and ScrollViewGtk.cpp.
  15685. * platform/ScrollView.h: Remove unused methods.
  15686. * platform/gtk/MainFrameScrollbarGtk.cpp:
  15687. (MainFrameScrollbarGtk::create): No longer need to pass in the adjustment.
  15688. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): Update the comments here.
  15689. * platform/gtk/MainFrameScrollbarGtk.h: Lots of code removal.
  15690. * platform/gtk/ScrollViewGtk.cpp: Ditto.
  15691. (WebCore::ScrollView::createScrollbar): Ditto.
  15692. (WebCore::ScrollView::setScrollbarModes): Ditto.
  15693. * plugins/gtk/PluginViewGtk.cpp: This file needs the GRefPtrGtk.h include now
  15694. that it doesn't receive it transitively.
  15695. 2011-05-09 Adam Barth <abarth@webkit.org>
  15696. Reviewed by Eric Seidel.
  15697. CSP should block Function constructor
  15698. https://bugs.webkit.org/show_bug.cgi?id=60240
  15699. Tests: http/tests/security/contentSecurityPolicy/function-constructor-allowed.html
  15700. http/tests/security/contentSecurityPolicy/function-constructor-blocked.html
  15701. * bindings/js/JSLazyEventListener.cpp:
  15702. (WebCore::JSLazyEventListener::initializeJSFunction):
  15703. - Update call site to the new entrypoint.
  15704. * bindings/v8/V8LazyEventListener.cpp:
  15705. (WebCore::V8LazyEventListener::prepareListenerObject):
  15706. - Add some comments about the rediculousness of this implementation.
  15707. 2011-05-09 Chris Rogers <crogers@google.com>
  15708. Reviewed by Kenneth Russell.
  15709. Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
  15710. https://bugs.webkit.org/show_bug.cgi?id=60396
  15711. No new tests since audio API is not yet implemented.
  15712. * WebCore.gypi:
  15713. * WebCore.xcodeproj/project.pbxproj:
  15714. * platform/audio/DenormalDisabler.h: Added.
  15715. (WebCore::DenormalDisabler::DenormalDisabler):
  15716. (WebCore::DenormalDisabler::~DenormalDisabler):
  15717. (WebCore::DenormalDisabler::getCSR):
  15718. (WebCore::DenormalDisabler::setCSR):
  15719. * webaudio/AudioDestinationNode.cpp:
  15720. (WebCore::AudioDestinationNode::provideInput):
  15721. 2011-05-09 Tony Chang <tony@chromium.org>
  15722. Reviewed by Eric Seidel.
  15723. Style cleanups in RenderFlexibleBox.cpp
  15724. https://bugs.webkit.org/show_bug.cgi?id=60504
  15725. No new tests, just refactoring.
  15726. * rendering/RenderFlexibleBox.cpp:
  15727. (WebCore::FlexBoxIterator::FlexBoxIterator): Use m_ for member variables, and
  15728. use class initializer list.
  15729. (WebCore::FlexBoxIterator::reset):
  15730. (WebCore::FlexBoxIterator::next):
  15731. (WebCore::RenderFlexibleBox::RenderFlexibleBox):
  15732. (WebCore::marginWidthForChild): Pull out common code used in calc*PrefWidths
  15733. (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
  15734. (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
  15735. (WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
  15736. (WebCore::RenderFlexibleBox::layoutBlock):
  15737. (WebCore::gatherFlexChildrenInfo): Rewrite uses of FlexBoxIterator into for statements
  15738. rather than while loops.
  15739. (WebCore::RenderFlexibleBox::layoutHorizontalBox): ditto
  15740. (WebCore::RenderFlexibleBox::layoutVerticalBox): ditto
  15741. (WebCore::RenderFlexibleBox::applyLineClamp):
  15742. (WebCore::RenderFlexibleBox::allowedChildFlex): Rename variables w/h to width/height.
  15743. 2011-05-09 Eric Seidel <eric@webkit.org>
  15744. Reviewed by Ryosuke Niwa.
  15745. Abstract line deletion code into a function
  15746. https://bugs.webkit.org/show_bug.cgi?id=60501
  15747. No change in behavior, thus no testing.
  15748. * rendering/RenderBlockLineLayout.cpp:
  15749. (WebCore::deleteLineRange):
  15750. (WebCore::RenderBlock::layoutRunsAndFloats):
  15751. (WebCore::RenderBlock::determineStartPosition):
  15752. (WebCore::RenderBlock::matchedEndLine):
  15753. 2011-05-09 Darin Adler <darin@apple.com>
  15754. Cleared some stray executable bits on source files.
  15755. * bindings/js/WorkerScriptDebugServer.cpp: Removed property svn:executable.
  15756. * bindings/js/WorkerScriptDebugServer.h: Removed property svn:executable.
  15757. 2011-05-09 Erik Arvidsson <arv@chromium.org>
  15758. Reviewed by Darin Adler.
  15759. radiogroup: onchange not detected when triggered by keyboard
  15760. https://bugs.webkit.org/show_bug.cgi?id=32013
  15761. Test: fast/forms/radio-group-keyboard-change-event.html
  15762. * html/RadioInputType.cpp:
  15763. (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click
  15764. event. The simulated click event will check it for us but more importantly it will fire the "change" event as
  15765. expected.
  15766. 2011-05-09 Adam Barth <abarth@webkit.org>
  15767. Reviewed by Daniel Bates.
  15768. XSSAuditor should be more selective about the <meta http-equivs> that it blocks
  15769. https://bugs.webkit.org/show_bug.cgi?id=60489
  15770. We don't need to filter most http-equiv attributes. This patch
  15771. introduces a blacklist for two that we probably do want to filter.
  15772. It's possible a whitelist would be more appropriate, but I'm inclined
  15773. to start with a blacklist and see how it works.
  15774. This patch will hopefully fix a false positive that is causing errors
  15775. with copy-and-pasted text in Gmail in some configurations (due to using
  15776. the <meta> tag to request UTF-8 encoding both in the pasted text and in
  15777. the page itself).
  15778. * html/parser/XSSFilter.cpp:
  15779. (WebCore::isNonCanonicalCharacter):
  15780. (WebCore::canonicalize):
  15781. (WebCore::isRequiredForInjection):
  15782. (WebCore::hasName):
  15783. (WebCore::findAttributeWithName):
  15784. (WebCore::isNameOfInlineEventHandler):
  15785. (WebCore::isDangerousHTTPEquiv):
  15786. - This function is new in the patch and includes a blacklist of
  15787. dangerous http-equivs. Many of the other functions listed here
  15788. are just being moved from an anonymous namespace to use static
  15789. for internal linkage.
  15790. (WebCore::containsJavaScriptURL):
  15791. (WebCore::decodeURL):
  15792. (WebCore::XSSFilter::eraseAttributeIfInjected):
  15793. 2011-05-05 Matthew Delaney <mdelaney@apple.com>
  15794. Reviewed by Simon Fraser.
  15795. Remove canvas usage of roundToDevicePixels
  15796. https://bugs.webkit.org/show_bug.cgi?id=60331
  15797. No new tests. This could only affect canvases at non-integral scale factors. Our tests only run in 1.0x.
  15798. * html/canvas/CanvasRenderingContext2D.cpp:
  15799. (WebCore::CanvasRenderingContext2D::drawImage):
  15800. 2011-05-09 Alexis Menard <alexis.menard@openbossa.org>
  15801. Reviewed by Andreas Kling.
  15802. [Qt] Fix the build on Embedded Linux.
  15803. https://bugs.webkit.org/show_bug.cgi?id=60347
  15804. qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
  15805. still be used in order to build properly.
  15806. * WebCore.pri:
  15807. 2011-05-09 Andreas Kling <kling@webkit.org>
  15808. Reviewed by Kenneth Rohde Christiansen.
  15809. [Qt] Simple small-caps text is displayed in uniform size.
  15810. https://bugs.webkit.org/show_bug.cgi?id=60492
  15811. Covered by existing tests.
  15812. * platform/graphics/qt/FontPlatformDataQt.cpp:
  15813. (WebCore::FontPlatformData::FontPlatformData): In the FontPlatformData constructor
  15814. used by SimpleFontData::scaledFontData(), pass the pixel size to both QFont and QRawFont
  15815. to make small caps and emphasis marks have the correct size when rendered through
  15816. the fast font path.
  15817. 2011-05-09 Andreas Kling <kling@webkit.org>
  15818. Reviewed by Tor Arne Vestbø.
  15819. [Qt] Remove unused FontPlatformData functions.
  15820. https://bugs.webkit.org/show_bug.cgi?id=60485
  15821. * platform/graphics/qt/FontPlatformData.h:
  15822. (WebCore::FontPlatformData::bold): Removed.
  15823. (WebCore::FontPlatformData::family): Removed.
  15824. (WebCore::FontPlatformData::italic): Removed.
  15825. (WebCore::FontPlatformData::smallCaps): Removed.
  15826. 2011-05-09 Robin Dunn <robin@alldunn.com>
  15827. Reviewed by Kevin Ollivier.
  15828. [wx] Add invalid file handle check.
  15829. https://bugs.webkit.org/show_bug.cgi?id=60483
  15830. * platform/wx/FileSystemWx.cpp:
  15831. (WebCore::closeFile):
  15832. 2011-05-09 Robin Dunn <robin@alldunn.com>
  15833. Reviewed by Kevin Ollivier.
  15834. [wx] Update the popup menu code to grab the native control and initialize the
  15835. event handler properly.
  15836. https://bugs.webkit.org/show_bug.cgi?id=60482
  15837. * platform/wx/PopupMenuWx.cpp:
  15838. (WebCore::PopupMenuWx::PopupMenuWx):
  15839. (WebCore::PopupMenuWx::~PopupMenuWx):
  15840. (WebCore::PopupMenuWx::show):
  15841. 2011-05-09 Robin Dunn <robin@alldunn.com>
  15842. Reviewed by Kevin Ollivier.
  15843. [wx] Make sure other controls adjust the rect to handle transforms, and turn off the
  15844. adjustment in 2.9.2+ where it is handled internally by wx.
  15845. Also add a couple drawing and focus handling fixes for text fields and menulist controls.
  15846. https://bugs.webkit.org/show_bug.cgi?id=60481
  15847. * platform/wx/RenderThemeWx.cpp:
  15848. (WebCore::getAdjustedRect):
  15849. (WebCore::RenderThemeWx::supportsFocus):
  15850. (WebCore::RenderThemeWx::paintButton):
  15851. (WebCore::RenderThemeWx::adjustTextFieldStyle):
  15852. (WebCore::RenderThemeWx::paintTextField):
  15853. (WebCore::RenderThemeWx::adjustMenuListStyle):
  15854. (WebCore::RenderThemeWx::paintMenuList):
  15855. (WebCore::RenderThemeWx::paintMenuListButton):
  15856. 2011-05-09 Tony Gentilcore <tonyg@chromium.org>
  15857. Reviewed by Darin Adler.
  15858. Style fix: Function names must begin with lowercase letter and should not use "get".
  15859. https://bugs.webkit.org/show_bug.cgi?id=60475
  15860. * dom/Document.cpp:
  15861. (WebCore::Document::webkitVisibilityState):
  15862. * page/PageVisibilityState.cpp:
  15863. (WebCore::pageVisibilityStateString): Renamed.
  15864. * page/PageVisibilityState.h:
  15865. 2011-05-09 Adam Barth <abarth@webkit.org>
  15866. Reviewed by Tony Gentilcore.
  15867. Make Chromium build with strict PassOwnPtr
  15868. https://bugs.webkit.org/show_bug.cgi?id=60461
  15869. Fix many, many PassOwnPtr nits.
  15870. * bindings/v8/V8Proxy.cpp:
  15871. (WebCore::V8Proxy::precompileScript):
  15872. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  15873. (WebCore::WindowSetTimeoutImpl):
  15874. * bindings/v8/custom/V8MessageEventCustom.cpp:
  15875. (WebCore::V8MessageEvent::initMessageEventCallback):
  15876. * bindings/v8/custom/V8WorkerContextCustom.cpp:
  15877. (WebCore::SetTimeoutOrInterval):
  15878. * dom/Document.cpp:
  15879. (WebCore::Document::removedLastRef):
  15880. (WebCore::Document::detach):
  15881. * fileapi/DOMFileSystem.h:
  15882. (WebCore::DOMFileSystem::scheduleCallback):
  15883. * fileapi/FileSystemCallbacks.cpp:
  15884. (WebCore::FileSystemCallbacks::didOpenFileSystem):
  15885. (WebCore::ResolveURICallbacks::didOpenFileSystem):
  15886. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  15887. (WebCore::GraphicsLayer::create):
  15888. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  15889. (WebCore::CCLayerImpl::createRenderSurface):
  15890. * platform/graphics/gpu/BicubicShader.cpp:
  15891. (WebCore::BicubicShader::create):
  15892. * platform/graphics/gpu/ConvolutionShader.cpp:
  15893. (WebCore::ConvolutionShader::create):
  15894. * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
  15895. (WebCore::LoopBlinnSolidFillShader::create):
  15896. * platform/graphics/gpu/SolidFillShader.cpp:
  15897. (WebCore::SolidFillShader::create):
  15898. * platform/graphics/gpu/TexShader.cpp:
  15899. (WebCore::TexShader::create):
  15900. * platform/graphics/gpu/Texture.cpp:
  15901. (WebCore::Texture::create):
  15902. * storage/chromium/DatabaseTrackerChromium.cpp:
  15903. (WebCore::TrackerRemoveOpenDatabaseTask::create):
  15904. * storage/chromium/SQLTransactionClientChromium.cpp:
  15905. (WebCore::NotifyDatabaseChangedTask::create):
  15906. 2011-05-07 Martin Robinson <mrobinson@igalia.com>
  15907. Reviewed by Daniel Bates.
  15908. [Soup] Clean up error handling in ResourceHandleSoup
  15909. https://bugs.webkit.org/show_bug.cgi?id=60436
  15910. Instead of repeating the ResourceError creation twice, abstract
  15911. it into a helper method.
  15912. No new tests. This is a code cleanup.
  15913. * platform/network/soup/ResourceHandleSoup.cpp:
  15914. (WebCore::soupErrorShouldCauseLoadFailure): Added.
  15915. (WebCore::convertSoupErrorToResourceError): Added.
  15916. (WebCore::sendRequestCallback): Use the new helpers.
  15917. (WebCore::readCallback): Ditto.
  15918. 2011-05-09 Abhishek Arya <inferno@chromium.org>
  15919. Reviewed by Dave Hyatt.
  15920. Regression(r85869): Restore dirty line logic in RenderInline::destroy.
  15921. https://bugs.webkit.org/show_bug.cgi?id=60448
  15922. Test: fast/inline/inline-destroy-dirty-lines-crash.html
  15923. * rendering/RenderInline.cpp:
  15924. (WebCore::RenderInline::destroy):
  15925. 2011-05-09 Alejandro G. Castro <alex@igalia.com>
  15926. Reviewed by Martin Robinson.
  15927. [GTK] WidgetGtk setFocus can not access directly the widget in WK2
  15928. https://bugs.webkit.org/show_bug.cgi?id=60016
  15929. Added code to check the situation where we do not have direct
  15930. access to the widget. We use the page to grab the focus which
  15931. would send a request to the UIProcess in WK2.
  15932. * platform/gtk/WidgetGtk.cpp:
  15933. (WebCore::Widget::setFocus):
  15934. 2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>
  15935. Reviewed by Tony Gentilcore.
  15936. Media Stream API: add exception raising to the getUserMedia method.
  15937. https://bugs.webkit.org/show_bug.cgi?id=60387
  15938. Perform the required changes to support rising exceptions in the
  15939. navigator.getUserMedia method. This is required by the latest changes in the spec:
  15940. http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia
  15941. Test: fast/dom/MediaStream/argument-types.html
  15942. * bindings/js/JSNavigatorCustom.cpp:
  15943. (WebCore::JSNavigator::webkitGetUserMedia):
  15944. * bindings/v8/custom/V8NavigatorCustom.cpp:
  15945. (WebCore::V8Navigator::webkitGetUserMediaCallback):
  15946. * page/Navigator.cpp:
  15947. (WebCore::Navigator::webkitGetUserMedia):
  15948. * page/Navigator.h:
  15949. * page/Navigator.idl:
  15950. 2011-05-09 Csaba Osztrogonác <ossy@webkit.org>
  15951. Unreviewed Qt 4.8 fix.
  15952. * WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
  15953. 2011-05-09 Adam Roben <aroben@apple.com>
  15954. Windows project file fix after r86047
  15955. * WebCore.vcproj/WebCore.vcproj: Added missing closing tags.
  15956. 2011-05-06 Chris Marrin <cmarrin@apple.com>
  15957. Reviewed by Darin Adler.
  15958. Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
  15959. https://bugs.webkit.org/show_bug.cgi?id=60417
  15960. Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
  15961. the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
  15962. but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
  15963. instead of the PlatformCALayer everywhere.
  15964. * platform/graphics/ca/GraphicsLayerCA.cpp:
  15965. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  15966. 2011-05-09 Rob Buis <rbuis@rim.com>
  15967. Reviewed by Dirk Schulze.
  15968. Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
  15969. https://bugs.webkit.org/show_bug.cgi?id=22576
  15970. Add tag name ASSERTs in SVG Element constructors.
  15971. No new tests, since no change in behaviour.
  15972. * svg/SVGAElement.cpp:
  15973. (WebCore::SVGAElement::SVGAElement):
  15974. * svg/SVGAltGlyphElement.cpp:
  15975. (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
  15976. * svg/SVGAnimateColorElement.cpp:
  15977. (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
  15978. * svg/SVGAnimateElement.cpp:
  15979. (WebCore::SVGAnimateElement::SVGAnimateElement):
  15980. * svg/SVGAnimateMotionElement.cpp:
  15981. (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
  15982. * svg/SVGAnimateTransformElement.cpp:
  15983. (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
  15984. * svg/SVGCircleElement.cpp:
  15985. (WebCore::SVGCircleElement::SVGCircleElement):
  15986. * svg/SVGClipPathElement.cpp:
  15987. (WebCore::SVGClipPathElement::SVGClipPathElement):
  15988. * svg/SVGCursorElement.cpp:
  15989. (WebCore::SVGCursorElement::SVGCursorElement):
  15990. * svg/SVGDefsElement.cpp:
  15991. (WebCore::SVGDefsElement::SVGDefsElement):
  15992. * svg/SVGDescElement.cpp:
  15993. (WebCore::SVGDescElement::SVGDescElement):
  15994. * svg/SVGEllipseElement.cpp:
  15995. (WebCore::SVGEllipseElement::SVGEllipseElement):
  15996. * svg/SVGFEBlendElement.cpp:
  15997. (WebCore::SVGFEBlendElement::SVGFEBlendElement):
  15998. * svg/SVGFEColorMatrixElement.cpp:
  15999. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
  16000. * svg/SVGFEComponentTransferElement.cpp:
  16001. (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
  16002. * svg/SVGFECompositeElement.cpp:
  16003. (WebCore::SVGFECompositeElement::SVGFECompositeElement):
  16004. * svg/SVGFEConvolveMatrixElement.cpp:
  16005. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
  16006. * svg/SVGFEDiffuseLightingElement.cpp:
  16007. (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
  16008. * svg/SVGFEDisplacementMapElement.cpp:
  16009. (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
  16010. * svg/SVGFEDistantLightElement.cpp:
  16011. (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
  16012. * svg/SVGFEDropShadowElement.cpp:
  16013. (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
  16014. * svg/SVGFEFloodElement.cpp:
  16015. (WebCore::SVGFEFloodElement::SVGFEFloodElement):
  16016. * svg/SVGFEFuncAElement.cpp:
  16017. (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
  16018. * svg/SVGFEFuncBElement.cpp:
  16019. (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
  16020. * svg/SVGFEFuncGElement.cpp:
  16021. (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
  16022. * svg/SVGFEFuncRElement.cpp:
  16023. (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
  16024. * svg/SVGFEGaussianBlurElement.cpp:
  16025. (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
  16026. * svg/SVGFEImageElement.cpp:
  16027. (WebCore::SVGFEImageElement::SVGFEImageElement):
  16028. * svg/SVGFEMergeElement.cpp:
  16029. (WebCore::SVGFEMergeElement::SVGFEMergeElement):
  16030. * svg/SVGFEMergeNodeElement.cpp:
  16031. (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
  16032. * svg/SVGFEMorphologyElement.cpp:
  16033. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
  16034. * svg/SVGFEOffsetElement.cpp:
  16035. (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
  16036. * svg/SVGFEPointLightElement.cpp:
  16037. (WebCore::SVGFEPointLightElement::SVGFEPointLightElement):
  16038. * svg/SVGFESpecularLightingElement.cpp:
  16039. (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
  16040. * svg/SVGFESpotLightElement.cpp:
  16041. (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
  16042. * svg/SVGFETileElement.cpp:
  16043. (WebCore::SVGFETileElement::SVGFETileElement):
  16044. * svg/SVGFETurbulenceElement.cpp:
  16045. (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
  16046. * svg/SVGFilterElement.cpp:
  16047. (WebCore::SVGFilterElement::SVGFilterElement):
  16048. * svg/SVGFontElement.cpp:
  16049. (WebCore::SVGFontElement::SVGFontElement):
  16050. * svg/SVGFontFaceElement.cpp:
  16051. (WebCore::SVGFontFaceElement::SVGFontFaceElement):
  16052. * svg/SVGFontFaceFormatElement.cpp:
  16053. (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
  16054. * svg/SVGFontFaceNameElement.cpp:
  16055. (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
  16056. * svg/SVGFontFaceSrcElement.cpp:
  16057. (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
  16058. * svg/SVGFontFaceUriElement.cpp:
  16059. (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
  16060. * svg/SVGForeignObjectElement.cpp:
  16061. (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
  16062. * svg/SVGGElement.cpp:
  16063. (WebCore::SVGGElement::SVGGElement):
  16064. * svg/SVGGlyphElement.cpp:
  16065. (WebCore::SVGGlyphElement::SVGGlyphElement):
  16066. * svg/SVGHKernElement.cpp:
  16067. (WebCore::SVGHKernElement::SVGHKernElement):
  16068. * svg/SVGImageElement.cpp:
  16069. (WebCore::SVGImageElement::SVGImageElement):
  16070. * svg/SVGLineElement.cpp:
  16071. (WebCore::SVGLineElement::SVGLineElement):
  16072. * svg/SVGLinearGradientElement.cpp:
  16073. (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
  16074. * svg/SVGMPathElement.cpp:
  16075. (WebCore::SVGMPathElement::SVGMPathElement):
  16076. * svg/SVGMarkerElement.cpp:
  16077. (WebCore::SVGMarkerElement::SVGMarkerElement):
  16078. * svg/SVGMaskElement.cpp:
  16079. (WebCore::SVGMaskElement::SVGMaskElement):
  16080. * svg/SVGMetadataElement.cpp:
  16081. (WebCore::SVGMetadataElement::SVGMetadataElement):
  16082. * svg/SVGMissingGlyphElement.cpp:
  16083. (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
  16084. * svg/SVGPathElement.cpp:
  16085. (WebCore::SVGPathElement::SVGPathElement):
  16086. * svg/SVGPatternElement.cpp:
  16087. (WebCore::SVGPatternElement::SVGPatternElement):
  16088. * svg/SVGPolygonElement.cpp:
  16089. (WebCore::SVGPolygonElement::SVGPolygonElement):
  16090. * svg/SVGPolylineElement.cpp:
  16091. (WebCore::SVGPolylineElement::SVGPolylineElement):
  16092. * svg/SVGRadialGradientElement.cpp:
  16093. (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
  16094. * svg/SVGRectElement.cpp:
  16095. (WebCore::SVGRectElement::SVGRectElement):
  16096. * svg/SVGSVGElement.cpp:
  16097. (WebCore::SVGSVGElement::SVGSVGElement):
  16098. * svg/SVGScriptElement.cpp:
  16099. (WebCore::SVGScriptElement::SVGScriptElement):
  16100. * svg/SVGSetElement.cpp:
  16101. (WebCore::SVGSetElement::SVGSetElement):
  16102. * svg/SVGStopElement.cpp:
  16103. (WebCore::SVGStopElement::SVGStopElement):
  16104. * svg/SVGStyleElement.cpp:
  16105. (WebCore::SVGStyleElement::SVGStyleElement):
  16106. * svg/SVGSwitchElement.cpp:
  16107. (WebCore::SVGSwitchElement::SVGSwitchElement):
  16108. * svg/SVGSymbolElement.cpp:
  16109. (WebCore::SVGSymbolElement::SVGSymbolElement):
  16110. * svg/SVGTRefElement.cpp:
  16111. (WebCore::SVGTRefElement::SVGTRefElement):
  16112. * svg/SVGTSpanElement.cpp:
  16113. (WebCore::SVGTSpanElement::SVGTSpanElement):
  16114. * svg/SVGTextElement.cpp:
  16115. (WebCore::SVGTextElement::SVGTextElement):
  16116. * svg/SVGTextPathElement.cpp:
  16117. (WebCore::SVGTextPathElement::SVGTextPathElement):
  16118. * svg/SVGTitleElement.cpp:
  16119. (WebCore::SVGTitleElement::SVGTitleElement):
  16120. * svg/SVGUseElement.cpp:
  16121. (WebCore::SVGUseElement::SVGUseElement):
  16122. * svg/SVGVKernElement.cpp:
  16123. (WebCore::SVGVKernElement::SVGVKernElement):
  16124. * svg/SVGViewElement.cpp:
  16125. (WebCore::SVGViewElement::SVGViewElement):
  16126. 2011-05-09 Shishir Agrawal <shishir@chromium.org>
  16127. Reviewed by Tony Gentilcore.
  16128. Implement Page Visibility API.
  16129. https://bugs.webkit.org/show_bug.cgi?id=54181
  16130. Tests: fast/events/page-visibility-iframe-delete-test.html
  16131. fast/events/page-visibility-iframe-move-test.html
  16132. fast/events/page-visibility-iframe-propagation-test.html
  16133. fast/events/page-visibility-transition-test.html
  16134. * CMakeLists.txt:
  16135. * GNUmakefile.list.am:
  16136. * WebCore.gypi:
  16137. * WebCore.pro:
  16138. * WebCore.vcproj/WebCore.vcproj:
  16139. * WebCore.xcodeproj/project.pbxproj:
  16140. * dom/Document.cpp:
  16141. (WebCore::Document::visibilityState):
  16142. (WebCore::Document::webkitVisibilityState):
  16143. (WebCore::Document::webkitIsVisible):
  16144. (WebCore::Document::dispatchVisibilityStateChangeEvent):
  16145. * dom/Document.h:
  16146. * dom/Document.idl:
  16147. * dom/EventNames.h:
  16148. * page/Frame.cpp:
  16149. (WebCore::Frame::dispatchVisibilityStateChangeEvent):
  16150. * page/Frame.h:
  16151. * page/Page.cpp:
  16152. (WebCore::Page::Page):
  16153. (WebCore::Page::setVisibilityState):
  16154. (WebCore::Page::visibilityState):
  16155. * page/Page.h:
  16156. * page/PageVisibilityState.cpp: Added.
  16157. (WebCore::GetPageVisibilityStateString):
  16158. * page/PageVisibilityState.h: Added.
  16159. 2011-05-09 Luke Macpherson <macpherson@chromium.org>
  16160. Reviewed by Eric Seidel.
  16161. Implement expanding CSS border properties in CSSStyleApplyProperty.
  16162. https://bugs.webkit.org/show_bug.cgi?id=60456
  16163. No new tests added as no functionality changed.
  16164. * css/CSSStyleApplyProperty.cpp:
  16165. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  16166. Create CSS border expanding property handlers.
  16167. * css/CSSStyleSelector.cpp:
  16168. (WebCore::CSSStyleSelector::applyProperty):
  16169. Remove property handlers that are no longer needed.
  16170. 2011-05-08 Ryosuke Niwa <rniwa@webkit.org>
  16171. Reviewed by Kent Tamura.
  16172. selectstart event does not fire when selection is made via select all
  16173. https://bugs.webkit.org/show_bug.cgi?id=60376
  16174. Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
  16175. document, editable region, or text control.
  16176. Tests: editing/selection/selectstart-on-selectall.html
  16177. editing/selection/selectstart-prevent-selectall.html
  16178. * dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
  16179. * editing/FrameSelection.cpp:
  16180. (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is
  16181. input element or textarea element when the current selection is inside a shadow DOM, and the root
  16182. editable element if it's inside a non-shadow editable region, and the body element otherwise.
  16183. * html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer
  16184. declared in Node.
  16185. 2011-05-08 Luke Macpherson <macpherson@chromium.org>
  16186. Reviewed by Eric Seidel.
  16187. Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
  16188. https://bugs.webkit.org/show_bug.cgi?id=60249
  16189. No new tests added as no functionality changed.
  16190. * css/CSSStyleSelector.cpp:
  16191. (WebCore::CSSStyleSelector::applyProperty):
  16192. Remove special-case code and use appropriate macro.
  16193. * rendering/style/RenderStyle.h:
  16194. (WebCore::InheritedFlags::setColumnBreakInside):
  16195. Assert that supported values are used.
  16196. 2011-05-08 Ryosuke Niwa <rniwa@webkit.org>
  16197. Reviewed by Darin Adler.
  16198. Extract a DragCaretController from FrameSelection
  16199. https://bugs.webkit.org/show_bug.cgi?id=60273
  16200. Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
  16201. DragCaretController and FrameSelection and provides functions to paint caret.
  16202. Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.
  16203. * WebCore.exp.in:
  16204. * editing/FrameSelection.cpp:
  16205. (WebCore::CaretBase::CaretBase): Added.
  16206. (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true.
  16207. (WebCore::DragCaretController::isContentRichlyEditable): Added.
  16208. (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase.
  16209. (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection.
  16210. (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController.
  16211. (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification.
  16212. (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved
  16213. and respondToNodeModification. Note that the position DragCaretController holds is equivalent to
  16214. FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position,
  16215. we used to execute the first if clause and cleared render tree selection and DOM tree selection.
  16216. This is exactly what new DragCaretController::nodeWillBeRemoved does.
  16217. (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions.
  16218. (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection.
  16219. (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned.
  16220. Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if
  16221. FrameSelection's start was not null.
  16222. (WebCore::caretRendersInsideNode): Moved; Made static local.
  16223. (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer.
  16224. (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer.
  16225. (WebCore::DragCaretController::caretRenderer): Ditto.
  16226. (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments.
  16227. (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*.
  16228. (WebCore::CaretBase::caretRepaintRect): Ditto.
  16229. (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect,
  16230. and shouldRepaintCaret with extra arguments.
  16231. (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable.
  16232. (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect.
  16233. (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect.
  16234. (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret.
  16235. (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret.
  16236. (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for
  16237. DragCaretController.
  16238. (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
  16239. * editing/FrameSelection.h:
  16240. (WebCore::CaretBase::localCaretRectForPainting): Added.
  16241. (WebCore::DragCaretController::isContentEditable): Added.
  16242. (WebCore::DragCaretController::hasCaret): Added.
  16243. (WebCore::DragCaretController::caretPosition): Added.
  16244. (WebCore::DragCaretController::clear): Added.
  16245. * page/DragController.cpp:
  16246. (WebCore::DragController::tryDocumentDrag): Uses DragCaretController.
  16247. (WebCore::DragController::dispatchTextInputEventFor): Ditto.
  16248. (WebCore::DragController::concludeEditDrag): Ditto.
  16249. (WebCore::DragController::placeDragCaret): Ditto.
  16250. * page/Page.cpp:
  16251. (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
  16252. * page/Page.h:
  16253. (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
  16254. * rendering/RenderBlock.cpp:
  16255. (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
  16256. 2011-05-08 Dan Bernstein <mitz@apple.com>
  16257. Reviewed by Darin Adler.
  16258. <rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
  16259. https://bugs.webkit.org/show_bug.cgi?id=60432
  16260. * rendering/InlineTextBox.h:
  16261. (WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
  16262. variable is a (truncated) int anyway.
  16263. * rendering/RenderBlockLineLayout.cpp:
  16264. (WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
  16265. so that the right amount is added to the total width. Also changed to use an early return.
  16266. 2011-05-08 Pavel Feldman <pfeldman@chromium.org>
  16267. Not reviewed: ignore 0 responses in the inspector network instrumentation.
  16268. * inspector/front-end/NetworkManager.js:
  16269. 2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  16270. Reviewed by Kenneth Rohde Christiansen.
  16271. [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
  16272. https://bugs.webkit.org/show_bug.cgi?id=58556
  16273. Tests: fast/canvas/webgl/gl-teximage.html
  16274. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  16275. (WebCore::GraphicsContext3D::getImageData):
  16276. 2011-05-07 Dan Bernstein <mitz@apple.com>
  16277. Reviewed by Maciej Stachowiak.
  16278. <rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
  16279. https://bugs.webkit.org/show_bug.cgi?id=60443
  16280. Test: fast/replaced/table-percent-height-positioned.html
  16281. * rendering/RenderBox.cpp:
  16282. (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
  16283. replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
  16284. doesn’t affect the table cell’s height).
  16285. 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
  16286. Unreviewed, rolling out r86016.
  16287. http://trac.webkit.org/changeset/86016
  16288. https://bugs.webkit.org/show_bug.cgi?id=60445
  16289. caused crashes on the WK2 Windows bots (Requested by
  16290. jessieberlin on #webkit).
  16291. * platform/network/ResourceHandle.h:
  16292. * platform/network/cf/CookieStorageCFNet.cpp:
  16293. (WebCore::currentCookieStorage):
  16294. (WebCore::defaultCookieStorage):
  16295. * platform/network/cf/ResourceHandleCFNet.cpp:
  16296. (WebCore::willSendRequest):
  16297. (WebCore::makeFinalRequest):
  16298. (WebCore::ResourceHandle::willSendRequest):
  16299. * platform/network/cf/ResourceRequestCFNet.cpp:
  16300. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  16301. 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
  16302. Unreviewed, rolling out r85974.
  16303. http://trac.webkit.org/changeset/85974
  16304. https://bugs.webkit.org/show_bug.cgi?id=60444
  16305. broke browser tests (Requested by inferno-sec on #webkit).
  16306. * platform/network/chromium/ResourceResponse.cpp:
  16307. (WebCore::ResourceResponse::doPlatformCopyData):
  16308. (WebCore::ResourceResponse::doPlatformAdopt):
  16309. * platform/network/chromium/ResourceResponse.h:
  16310. (WebCore::ResourceResponse::downloadFilePath):
  16311. (WebCore::ResourceResponse::setDownloadFilePath):
  16312. 2011-05-07 Jessie Berlin <jberlin@apple.com>
  16313. Reviewed by Steve Falkenburg.
  16314. [Windows WebKit2] Use cookies set in WebKit1
  16315. https://bugs.webkit.org/show_bug.cgi?id=60274
  16316. Share the default storage session between the UI and Web Processes.
  16317. * platform/network/cf/CookieStorageCFNet.cpp:
  16318. (WebCore::defaultSessionCookieStorage):
  16319. Keep track of the default storage session cookie storage.
  16320. (WebCore::currentCookieStorage):
  16321. Call defaultCookieStorage to get the default cookie storage.
  16322. (WebCore::defaultCookieStorage):
  16323. If there is a default storage session cookie storage, prefer that over getting the default
  16324. cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
  16325. without specifying a storage session will not get the cookie storage being shared by the UI
  16326. and Web Processes.
  16327. * platform/network/ResourceHandle.h:
  16328. * platform/network/cf/ResourceHandleCFNet.cpp:
  16329. (WebCore::willSendRequest):
  16330. Make sure to set the current storage session on any requests used by the Web
  16331. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  16332. doing anything with the Web Process's default storage session (which is not the one shared
  16333. with the UI Process).
  16334. (WebCore::makeFinalRequest):
  16335. Ditto.
  16336. (WebCore::ResourceHandle::willSendRequest):
  16337. Ditto.
  16338. (WebCore::ResourceHandle::currentStorageSession):
  16339. If there is a Private Browsing storage session, return that.
  16340. If not, on Windows return the default storage session that is being shared with the UI
  16341. Process and on Mac return 0.
  16342. (WebCore::defaultCFURLStorageSession):
  16343. (WebCore::ResourceHandle::setDefaultStorageSession):
  16344. (WebCore::ResourceHandle::defaultStorageSession):
  16345. * platform/network/cf/ResourceRequestCFNet.cpp:
  16346. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  16347. Make sure to set the current storage session on any requests used by the Web
  16348. Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
  16349. doing anything with the Web Process's default storage session (which is not the one shared
  16350. with the UI Process).
  16351. 2011-05-07 Joe Mason <jmason@rim.com>
  16352. Reviewed by Daniel Bates.
  16353. FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
  16354. https://bugs.webkit.org/show_bug.cgi?id=52211
  16355. Create a UserGestureIndicator when calling the clientRedirected callback.
  16356. * loader/NavigationScheduler.cpp:
  16357. (WebCore::ScheduledURLNavigation::didStartTimer):
  16358. (WebCore::ScheduledURLNavigation::didStopTimer):
  16359. (WebCore::ScheduledFormSubmission::didStartTimer):
  16360. (WebCore::ScheduledFormSubmission::didStopTimer):
  16361. 2011-05-06 Jon Lee <jonlee@apple.com>
  16362. Reviewed by Alice Liu.
  16363. Crash when sending a wheel event to a node with no shadow ancestor node
  16364. https://bugs.webkit.org/show_bug.cgi?id=60429
  16365. <rdar://problem/9389619>
  16366. * page/EventHandler.cpp:
  16367. (WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.
  16368. 2011-05-06 Kent Tamura <tkent@chromium.org>
  16369. Reviewed by Ryosuke Niwa.
  16370. Eliminate WebCore/dom/InputElement.{cpp,h}
  16371. https://bugs.webkit.org/show_bug.cgi?id=60262
  16372. - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
  16373. and TextFieldInputType.
  16374. - Change the return type of Node::toInputElement():
  16375. InputElement* -> HTMLInputElement*
  16376. No new tests. This change should not change the existing behaviour.
  16377. * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
  16378. * GNUmakefile.list.am: ditto.
  16379. * WebCore.exp.in: Add symbols of functions exposed to WebKit.
  16380. * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
  16381. * WebCore.pro: ditto.
  16382. * WebCore.vcproj/WebCore.vcproj: ditto.
  16383. * WebCore.xcodeproj/project.pbxproj: ditto.
  16384. * accessibility/AXObjectCache.cpp:
  16385. (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
  16386. Follow the return type change of Node::toInputElement().
  16387. * accessibility/AccessibilityRenderObject.cpp:
  16388. (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
  16389. (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
  16390. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
  16391. (WebCore::AccessibilityRenderObject::isChecked): ditto.
  16392. * css/CSSStyleSelector.cpp:
  16393. (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
  16394. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  16395. * dom/CheckedRadioButtons.cpp:
  16396. (WebCore::CheckedRadioButtons::removeButton): ditto.
  16397. * dom/DOMAllInOne.cpp: Remove InputElement.h.
  16398. * dom/InputElement.cpp: Removed.
  16399. * dom/InputElement.h: Removed.
  16400. * dom/Node.cpp:
  16401. (WebCore::Node::toInputElement):
  16402. Change the return type from InputElement* to HTMLInputElement*.
  16403. * dom/Node.h: ditto.
  16404. * html/HTMLInputElement.cpp:
  16405. (WebCore::HTMLInputElement::HTMLInputElement):
  16406. (WebCore::HTMLInputElement::formControlName):
  16407. (WebCore::HTMLInputElement::tooLong):
  16408. (WebCore::HTMLInputElement::updateFocusAppearance):
  16409. (WebCore::HTMLInputElement::aboutToUnload):
  16410. (WebCore::HTMLInputElement::handleFocusEvent):
  16411. (WebCore::HTMLInputElement::handleBlurEvent):
  16412. (WebCore::HTMLInputElement::updateType):
  16413. (WebCore::HTMLInputElement::parseMappedAttribute):
  16414. (WebCore::HTMLInputElement::size):
  16415. (WebCore::HTMLInputElement::copyNonAttributeProperties):
  16416. (WebCore::HTMLInputElement::value):
  16417. (WebCore::HTMLInputElement::suggestedValue):
  16418. (WebCore::HTMLInputElement::setSuggestedValue):
  16419. (WebCore::HTMLInputElement::setValue):
  16420. (WebCore::HTMLInputElement::setValueFromRenderer):
  16421. (WebCore::HTMLInputElement::setFileListFromRenderer):
  16422. (WebCore::HTMLInputElement::setDefaultName):
  16423. (WebCore::HTMLInputElement::maxLength):
  16424. (WebCore::HTMLInputElement::cacheSelection):
  16425. (WebCore::formatCodes): Moved from InputElement.
  16426. (WebCore::cursorPositionToMaskIndex): ditto.
  16427. (WebCore::HTMLInputElement::isConformToInputMask): ditto.
  16428. (WebCore::HTMLInputElement::validateInputMask): ditto.
  16429. (WebCore::HTMLInputElement::setWapInputFormat): ditto.
  16430. (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
  16431. (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
  16432. (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
  16433. * html/HTMLInputElement.h:
  16434. - Add data members which were defined in InputElementData.
  16435. - Make some functions public because the public interface InputElement is removed.
  16436. - Make some functions non-virtual because they don't override
  16437. corresponding virtual functions of InputElement anymore.
  16438. (WebCore::HTMLInputElement::toInputElement):
  16439. Follow the return type change of Node::toInputElement().
  16440. (WebCore::HTMLInputElement::isIndeterminate):
  16441. (WebCore::HTMLInputElement::isAutofilled):
  16442. (WebCore::HTMLInputElement::supportsMaxLength):
  16443. (WebCore::HTMLInputElement::cachedSelectionStart):
  16444. (WebCore::HTMLInputElement::cachedSelectionEnd):
  16445. * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
  16446. * html/InputType.cpp:
  16447. (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
  16448. * html/InputType.h: Update for the above.
  16449. * html/TextFieldInputType.cpp:
  16450. (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
  16451. (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
  16452. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
  16453. Move the code from InputElement::handleBeforeTextInsertedEvent().
  16454. * html/TextFieldInputType.h: Update declarations.
  16455. * rendering/RenderTextControlSingleLine.cpp:
  16456. - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
  16457. - Follow the return type change of inputElement().
  16458. (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
  16459. Make sure node() is an HTMLInputElement instance.
  16460. (WebCore::RenderTextControlSingleLine::addSearchResult):
  16461. (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
  16462. (WebCore::RenderTextControlSingleLine::showPopup):
  16463. (WebCore::RenderTextControlSingleLine::hidePopup):
  16464. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  16465. (WebCore::RenderTextControlSingleLine::updateFromElement):
  16466. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  16467. (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
  16468. (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
  16469. (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
  16470. (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
  16471. (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
  16472. (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
  16473. (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
  16474. (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
  16475. (WebCore::RenderTextControlSingleLine::valueChanged):
  16476. (WebCore::RenderTextControlSingleLine::setTextFromItem):
  16477. (WebCore::RenderTextControlSingleLine::inputElement):
  16478. * rendering/RenderTextControlSingleLine.h:
  16479. Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
  16480. * rendering/RenderTheme.cpp:
  16481. (WebCore::RenderTheme::isChecked):
  16482. Follow the return type change of Node::toInputElement().
  16483. (WebCore::RenderTheme::isIndeterminate): ditto.
  16484. (WebCore::RenderTheme::shouldHaveSpinButton):
  16485. Change the parameter type: InputElement* -> HTMLInputElement*.
  16486. * rendering/RenderTheme.h: ditto.
  16487. 2011-05-06 Adam Barth <abarth@webkit.org>
  16488. Reviewed by Eric Seidel.
  16489. Implement "Report-Only" mode for CSP
  16490. https://bugs.webkit.org/show_bug.cgi?id=60402
  16491. This mode lets web sites try out CSP by getting violation reports (and
  16492. console spam) without actually changing the behavior of their web sites.
  16493. Test: http/tests/security/contentSecurityPolicy/report-only.html
  16494. * dom/Document.cpp:
  16495. (WebCore::Document::processHttpEquiv):
  16496. * loader/FrameLoader.cpp:
  16497. (WebCore::FrameLoader::didBeginDocument):
  16498. * page/ContentSecurityPolicy.cpp:
  16499. (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
  16500. (WebCore::ContentSecurityPolicy::didReceiveHeader):
  16501. (WebCore::ContentSecurityPolicy::reportViolation):
  16502. (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
  16503. (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
  16504. (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  16505. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  16506. * page/ContentSecurityPolicy.h:
  16507. 2011-05-06 Beth Dakin <bdakin@apple.com>
  16508. Reviewed by Darin Adler.
  16509. https://bugs.webkit.org/show_bug.cgi?id=60421
  16510. Custom scrollbars nested inside an overlay scrollbar overflow region end up
  16511. painting twice
  16512. -and corresponding-
  16513. <rdar://problem/9389072>
  16514. Be sure not to paint custom css scrollbars during the special overlay-scrollbar
  16515. painting pass.
  16516. * rendering/RenderLayer.cpp:
  16517. (WebCore::RenderLayer::paintOverflowControls):
  16518. 2011-05-06 Cary Clark <caryclark@google.com>
  16519. Reviewed by Eric Seidel.
  16520. Add utility for converting SkCanvas to CGContext
  16521. https://bugs.webkit.org/show_bug.cgi?id=59808
  16522. Skia on Mac uses Skia to render WebKit, and CG
  16523. to render UI elements. The CG elements need a
  16524. transcribed graphics context that preserves the
  16525. canvas matrix, and the canvas clip.
  16526. The BitLockerSkia utility class sets up a CGContext
  16527. from the SkCanvas, locks the bitmap's bits, and
  16528. releases the lock when the class goes out of scope.
  16529. Each time the CGContext is retrieved, it is rebuilt.
  16530. This permits the caller to modify the same canvas
  16531. between calls.
  16532. This change adds utilities but does not modify any
  16533. existing code. For now, there are no callers to these
  16534. utilities, so there is no functional change.
  16535. No new tests.
  16536. * platform/graphics/skia/BitLockerSkia.cpp: Added.
  16537. (WebCore::SkMatrixToCGAffineTransform): Conversion utility.
  16538. (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas.
  16539. (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up.
  16540. (WebCore::BitLockerSkia::release): Internal private helper.
  16541. (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
  16542. * platform/graphics/skia/BitLockerSkia.h: Added.
  16543. 2011-05-06 Martin Robinson <mrobinson@igalia.com>
  16544. Reviewed by Xan Lopez.
  16545. [GTK] [WebKit2] WebView::windowToScreen needs an implementation
  16546. https://bugs.webkit.org/show_bug.cgi?id=55960
  16547. Abstract coordinate system translation code from WebKit into WebCore.
  16548. This will allow the code to be shared between WebKit and WebKit2. The code
  16549. now lives in a new GtkUtilities.cpp helper file.
  16550. * GNUmakefile.list.am: Added GtkUtilities to the source list.
  16551. * platform/gtk/GtkUtilities.cpp: Added.
  16552. (WebCore::convertWidgetRectToScreenRect):
  16553. * platform/gtk/GtkUtilities.h: Added.
  16554. 2011-05-06 Martin Robinson <mrobinson@igalia.com>
  16555. Reviewed by Xan Lopez.
  16556. Remove some unnecessary static methods in ResourceHandleSoup.
  16557. No new tests. This is only a small cleanup.
  16558. * platform/network/soup/ResourceHandleSoup.cpp:
  16559. (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly.
  16560. (WebCore::gotHeadersCallback):Ditto.
  16561. (WebCore::contentSniffedCallback):Ditto.
  16562. (WebCore::sendRequestCallback):Ditto.
  16563. (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
  16564. 2011-05-06 Martin Robinson <mrobinson@igalia.com>
  16565. Reviewed by Xan Lopez.
  16566. [Soup] ResourceHandles are leaked on 304 responses
  16567. https://bugs.webkit.org/show_bug.cgi?id=60413
  16568. Always call cleanupSoupRequestOperation, even when the request was not
  16569. canceled. Before the code would call didFinishLoading and then never clean up
  16570. the request.
  16571. No new tests. This simply fixes a memory leak.
  16572. * platform/network/soup/ResourceHandleSoup.cpp:
  16573. (WebCore::sendRequestCallback):
  16574. 2011-05-06 Adam Barth <abarth@webkit.org>
  16575. Reviewed by Eric Seidel.
  16576. Add disable-javascript-urls CSP directive
  16577. https://bugs.webkit.org/show_bug.cgi?id=60301
  16578. This CSP directive is not in the CSP spec. This patch is somewhat of
  16579. an experiment to see whether this feature is useful. Based on our
  16580. implementation experience, we will coordinate with folks via the W3C to
  16581. see if this makes sense to add to the spec.
  16582. Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html
  16583. * page/ContentSecurityPolicy.cpp:
  16584. (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
  16585. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  16586. (WebCore::ContentSecurityPolicy::addDirective):
  16587. * page/ContentSecurityPolicy.h:
  16588. 2011-05-06 Brett Wilson <brettw@chromium.org>
  16589. Reviewed by Adam Barth.
  16590. Use a File object to store the downloaded file reference rather than
  16591. just the path. This keeps the file and permissions in scope (using the
  16592. already-existing blob system) so the browser won't delete the file
  16593. when the load is complete. Instead, the file will be cleaned up when
  16594. the request objects are deleted.
  16595. https://bugs.webkit.org/show_bug.cgi?id=60281
  16596. * platform/network/chromium/ResourceResponse.cpp:
  16597. (WebCore::ResourceResponse::doPlatformCopyData):
  16598. (WebCore::ResourceResponse::doPlatformAdopt):
  16599. * platform/network/chromium/ResourceResponse.h:
  16600. (WebCore::ResourceResponse::downloadedFile):
  16601. (WebCore::ResourceResponse::setDownloadedFile):
  16602. 2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
  16603. Reviewed by Darin Adler.
  16604. Fix two warnings of unused variables.
  16605. https://bugs.webkit.org/show_bug.cgi?id=60370
  16606. Remove two unused local variable from the code.
  16607. No new tests, the existing ones should cover.
  16608. * rendering/RenderFlexibleBox.cpp:
  16609. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  16610. * svg/animation/SVGSMILElement.cpp:
  16611. (WebCore::SVGSMILElement::calculateNextProgressTime):
  16612. 2011-05-06 Adam Barth <abarth@webkit.org>
  16613. Reviewed by Eric Seidel.
  16614. Wire up CSP's eval blocking to V8's new API
  16615. https://bugs.webkit.org/show_bug.cgi?id=60384
  16616. * bindings/v8/ScriptController.cpp:
  16617. (WebCore::ScriptController::disableEval):
  16618. 2011-05-06 David Hyatt <hyatt@apple.com>
  16619. Reviewed by Dan Bernstein.
  16620. https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
  16621. REGRESSION (r81684?): cox.com sign in button is missing
  16622. Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
  16623. This restores the original behavior before the refactoring messed it up.
  16624. Added fast/inline/nested-top-alignment.html
  16625. * rendering/InlineFlowBox.cpp:
  16626. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  16627. 2011-05-06 David Hyatt <hyatt@apple.com>
  16628. Reviewed by Dan Bernstein.
  16629. https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
  16630. REGRESSION (r81992): portions of ticketmaster site render blank
  16631. Make simplified layout skip from a positioned object out to its containing block. There is no
  16632. need to dirty the intermediate inlines, and in this case it's actively harmful, since the
  16633. block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
  16634. Added fast/block/positioning/hiding-inside-relpositioned-inline.html
  16635. * rendering/RenderObject.h:
  16636. (WebCore::RenderObject::markContainingBlocksForLayout):
  16637. 2011-05-06 Pavel Feldman <pfeldman@chromium.org>
  16638. Not reviewed: move selection test into the text area branch.
  16639. * inspector/front-end/TextViewer.js:
  16640. (WebInspector.TextViewer.prototype._contextMenu):
  16641. 2011-05-04 Adrienne Walker <enne@google.com>
  16642. Reviewed by James Robinson.
  16643. [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
  16644. https://bugs.webkit.org/show_bug.cgi?id=59020
  16645. Allow for empty scissor rects, which implies scissoring to the render
  16646. surface. The previous code and previous patch on this bug both didn't
  16647. take into account that the scissor rect should be the render surface
  16648. and not the projection of the layer itself, because child layers
  16649. aren't necessarily contained within the bounds of their superlayer.
  16650. Test: compositing/flat-with-transformed-child.html
  16651. * platform/graphics/chromium/LayerRendererChromium.cpp:
  16652. (WebCore::LayerRendererChromium::paintLayerContents):
  16653. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  16654. (WebCore::LayerRendererChromium::drawLayer):
  16655. (WebCore::LayerRendererChromium::setScissorToRect):
  16656. 2011-05-06 Simon Fraser <simon.fraser@apple.com>
  16657. Reviewed by Sam Weinig.
  16658. Lazily allocate ScrollAnimator in ScrollableArea
  16659. https://bugs.webkit.org/show_bug.cgi?id=60327
  16660. Avoid allocating the ScrollAnimator up-front, because we
  16661. create lots of ScrollableAreas via RenderLayer, and we should
  16662. only need the animator when scrolling.
  16663. * platform/ScrollableArea.cpp:
  16664. (WebCore::ScrollableArea::ScrollableArea):
  16665. (WebCore::ScrollableArea::scrollAnimator):
  16666. (WebCore::ScrollableArea::scroll):
  16667. (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
  16668. (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
  16669. (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
  16670. (WebCore::ScrollableArea::handleWheelEvent):
  16671. (WebCore::ScrollableArea::handleGestureEvent):
  16672. * platform/ScrollableArea.h:
  16673. 2011-05-06 Eric Carlson <eric.carlson@apple.com>
  16674. Reviewed by Darin Adler.
  16675. REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
  16676. https://bugs.webkit.org/show_bug.cgi?id=60304
  16677. <rdar://problem/9392609>
  16678. Don't assume that the only time the media controls UI may need to change is on a
  16679. network state change, readyState changes can be significant as well.
  16680. Tested manually because we don't have any live streams to test in DRT.
  16681. * html/HTMLMediaElement.cpp:
  16682. (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
  16683. (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
  16684. * html/shadow/MediaControlRootElement.cpp:
  16685. (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
  16686. (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
  16687. * html/shadow/MediaControlRootElement.h:
  16688. * html/shadow/MediaControlRootElementChromium.cpp:
  16689. (WebCore::MediaControlRootElementChromium::reset): Ditto.
  16690. (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
  16691. * html/shadow/MediaControlRootElementChromium.h:
  16692. * html/shadow/MediaControls.h:
  16693. 2011-05-06 Andreas Kling <andreas.kling@nokia.com>
  16694. Unreviewed Qt 4.8 build fix.
  16695. * WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
  16696. enable it after the 4.8 bots are updated with the full QRawFont APIs.
  16697. 2011-05-06 Alexander Pavlov <apavlov@chromium.org>
  16698. Reviewed by Yury Semikhatsky.
  16699. Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
  16700. https://bugs.webkit.org/show_bug.cgi?id=60319
  16701. * inspector/front-end/ResourceView.js:
  16702. (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
  16703. 2011-05-06 Joe Mason <jmason@rim.com>
  16704. Reviewed by Adam Barth.
  16705. WebSocket urls should always be encoded as UTF-8.
  16706. https://bugs.webkit.org/show_bug.cgi?id=57138
  16707. Change WebSocket::connect to take the raw URL string and parse it
  16708. internally using the simple KURL constructor, which expects an absolute
  16709. UTF-8 encoded URL. This ensures that all code that creates a WebSocket
  16710. goes through this method instead of completeURL.
  16711. Test: http/tests/websocket/tests/url-with-nonascii-query.html
  16712. * bindings/js/JSWebSocketCustom.cpp:
  16713. (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
  16714. * websockets/WebSocket.cpp:
  16715. (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
  16716. * websockets/WebSocket.h:
  16717. 2011-05-06 Luke Macpherson <macpherson@chromium.org>
  16718. Reviewed by Eric Seidel.
  16719. Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
  16720. https://bugs.webkit.org/show_bug.cgi?id=60339
  16721. No tests added as no functionality changed.
  16722. * css/CSSStyleSelector.cpp:
  16723. (WebCore::CSSStyleSelector::applyProperty):
  16724. Use correct macro for CSSPropertySpeak.
  16725. * rendering/style/RenderStyle.h:
  16726. (WebCore::InheritedFlags::initialColorSpace):
  16727. Add initialColorSpace() static method.
  16728. 2011-05-06 Luke Macpherson <macpherson@chromium.org>
  16729. Reviewed by Eric Seidel.
  16730. Make RenderStyle::setPageBreakInside() reject unsupported enum values.
  16731. https://bugs.webkit.org/show_bug.cgi?id=60235
  16732. No tests added as no functionality changed.
  16733. * css/CSSStyleSelector.cpp:
  16734. (WebCore::CSSStyleSelector::applyProperty):
  16735. Remove special-case code and use appropriate macro.
  16736. * rendering/style/RenderStyle.h:
  16737. (WebCore::InheritedFlags::setPageBreakInside):
  16738. Assert that only supported values are used.
  16739. 2011-05-06 Luke Macpherson <macpherson@chromium.org>
  16740. Reviewed by Eric Seidel.
  16741. Move burden of checking for BJustify box alignment into RenderStyle
  16742. https://bugs.webkit.org/show_bug.cgi?id=60246
  16743. No new tests added as no functionality changed.
  16744. * css/CSSStyleSelector.cpp:
  16745. (WebCore::CSSStyleSelector::applyProperty):
  16746. Remove special-case logic checking for BJUSTIFY and use existing macro.
  16747. * rendering/style/RenderStyle.h:
  16748. (WebCore::InheritedFlags::setBoxAlign):
  16749. Assert valid values are used.
  16750. 2011-05-06 Luke Macpherson <macpherson@chromium.org>
  16751. Reviewed by Eric Seidel.
  16752. Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
  16753. https://bugs.webkit.org/show_bug.cgi?id=60338
  16754. No tests added as no functionality changed.
  16755. * css/CSSStyleSelector.cpp:
  16756. (WebCore::CSSStyleSelector::applyProperty):
  16757. Use correct macro for CSSPropertySpeak.
  16758. 2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
  16759. Reviewed by Alexey Proskuryakov.
  16760. Build fix with gcc 4.6 and c++0x support.
  16761. https://bugs.webkit.org/show_bug.cgi?id=60284
  16762. When enabling support of c++0x the compilation fails because of an
  16763. ambiguous overload error. In this code when constructing the pair
  16764. we use the new c++0x rvalue reference feature (&&). It means we are
  16765. calling String(const WTF::AtomicString&) which becomes ambiguous because
  16766. it has an overload WTF::String::String(const WTF::String&) and usually one
  16767. with the native port string type (e.g. QString). In this code we want the
  16768. String version because the pair store Strings.
  16769. No new tests, build fix.
  16770. * loader/FormSubmission.cpp:
  16771. (WebCore::FormSubmission::create):
  16772. 2011-05-06 Cris Neckar <cdn@chromium.org>
  16773. Reviewed by Dirk Schulze.
  16774. Tests for crash when a transform is applied to certain filters.
  16775. https://bugs.webkit.org/show_bug.cgi?id=59551
  16776. Test: svg/filters/filter-after-transform-crash.svg
  16777. * platform/graphics/filters/FEComposite.cpp:
  16778. (WebCore::FEComposite::determineAbsolutePaintRect):
  16779. * platform/graphics/filters/FEConvolveMatrix.h:
  16780. (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  16781. * platform/graphics/filters/FEDisplacementMap.h:
  16782. (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  16783. * platform/graphics/filters/FEFlood.h:
  16784. (WebCore::FEFlood::determineAbsolutePaintRect):
  16785. * platform/graphics/filters/FELighting.h:
  16786. (WebCore::FELighting::determineAbsolutePaintRect):
  16787. * platform/graphics/filters/FETile.h:
  16788. (WebCore::FETile::determineAbsolutePaintRect):
  16789. * platform/graphics/filters/FETurbulence.h:
  16790. (WebCore::FETurbulence::determineAbsolutePaintRect):
  16791. * platform/graphics/filters/FilterEffect.cpp:
  16792. (WebCore::isFilterSizeValid):
  16793. (WebCore::FilterEffect::determineAbsolutePaintRect):
  16794. (WebCore::FilterEffect::asUnmultipliedImage):
  16795. (WebCore::FilterEffect::asPremultipliedImage):
  16796. (WebCore::FilterEffect::copyUnmultipliedImage):
  16797. (WebCore::FilterEffect::copyPremultipliedImage):
  16798. (WebCore::FilterEffect::createUnmultipliedImageResult):
  16799. (WebCore::FilterEffect::createPremultipliedImageResult):
  16800. * platform/graphics/filters/FilterEffect.h:
  16801. (WebCore::FilterEffect::maxEffectRect):
  16802. (WebCore::FilterEffect::setMaxEffectRect):
  16803. * rendering/svg/RenderSVGResourceFilter.cpp:
  16804. * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  16805. (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
  16806. 2011-05-06 Luke Macpherson <macpherson@chromium.org>
  16807. Reviewed by Eric Seidel.
  16808. Use cast to convert primitive value to FontSmoothingMode.
  16809. https://bugs.webkit.org/show_bug.cgi?id=60242
  16810. No tests added as no functionality changed.
  16811. * css/CSSStyleSelector.cpp:
  16812. (WebCore::CSSStyleSelector::applyProperty):
  16813. Use cast to convert primitive value to FontSmoothingMode.
  16814. 2011-05-05 Luke Macpherson <macpherson@chromium.org>
  16815. Reviewed by Eric Seidel.
  16816. Make CSSPropertySpeak use the correct macro.
  16817. https://bugs.webkit.org/show_bug.cgi?id=60335
  16818. No tests added as no functionality changed.
  16819. * css/CSSStyleSelector.cpp:
  16820. (WebCore::CSSStyleSelector::applyProperty):
  16821. Use correct macro for CSSPropertySpeak.
  16822. 2011-05-05 Eric Carlson <eric.carlson@apple.com>
  16823. Reviewed by Maciej Stachowiak.
  16824. <rdar://problem/9390864>
  16825. https://bugs.webkit.org/show_bug.cgi?id=60343
  16826. Crash on Recovery System when trying to load page that includes media element
  16827. Automated test not possible, tested manually.
  16828. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  16829. (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if
  16830. AVFoundation and CoreMedia are installed.
  16831. * platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to
  16832. SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.
  16833. 2011-05-05 Eric Carlson <eric.carlson@apple.com>
  16834. Reviewed by Darin Adler.
  16835. Live streams sometimes won't play with AVFoundation backend
  16836. https://bugs.webkit.org/show_bug.cgi?id=58961
  16837. rdar://problem/9284748
  16838. Tested manually because we don't have any live streams to test in DRT.
  16839. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  16840. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume
  16841. AVFoundation will notify us when internal states change.
  16842. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver
  16843. a RetainPtr
  16844. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  16845. (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
  16846. (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
  16847. 2011-05-05 Jay Civelli <jcivelli@chromium.org>
  16848. Reviewed by Adam Barth.
  16849. Adding quoted-printable encoding/decoding capabilities.
  16850. This is needed for MHTML support.
  16851. https://bugs.webkit.org/show_bug.cgi?id=59834
  16852. * CMakeLists.txt:
  16853. * GNUmakefile.list.am:
  16854. * WebCore.gypi:
  16855. * WebCore.pro:
  16856. * WebCore.vcproj/WebCore.vcproj:
  16857. * WebCore.xcodeproj/project.pbxproj:
  16858. * platform/text/QuotedPrintable.cpp: Added.
  16859. * platform/text/QuotedPrintable.h: Added.
  16860. 2011-05-05 Andy Estes <aestes@apple.com>
  16861. Reviewed by Eric Seidel.
  16862. Implement document.innerHTML
  16863. https://bugs.webkit.org/show_bug.cgi?id=60316
  16864. ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
  16865. for fragment parsing. This assertion will become invalid when
  16866. document.innerHTML is implemented, which is the only case where HTML5
  16867. specifies that a fragment will not have a context element.
  16868. * html/parser/HTMLTreeBuilder.cpp:
  16869. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  16870. 2011-05-05 Kevin Ollivier <kevino@theolliviers.com>
  16871. [wx] Unreviewed build fix. Include ApplicationServices for wx port.
  16872. * platform/graphics/GlyphBuffer.h:
  16873. * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  16874. 2011-05-05 Dan Bernstein <mitz@apple.com>
  16875. Reviewed by Simon Fraser.
  16876. WebCore part of <rdar://problem/9155590> Broken animation in iAd producer
  16877. * WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  16878. * platform/graphics/ca/GraphicsLayerCA.cpp:
  16879. (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
  16880. check in Core Animation.
  16881. * platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  16882. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  16883. 2011-05-05 Sam Weinig <sam@webkit.org>
  16884. Reviewed by Anders Carlsson.
  16885. WebKit2 (Mac): Background tabs/windows can force themselves to the front
  16886. <rdar://problem/9386346>
  16887. https://bugs.webkit.org/show_bug.cgi?id=60315
  16888. * platform/mac/WidgetMac.mm:
  16889. (WebCore::Widget::setFocus):
  16890. It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
  16891. to the front. Calling focusNSView() was only necessary because in WebKit we must inform
  16892. the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
  16893. 2011-05-05 Justin Novosad <junov@chromium.org>
  16894. Reviewed by Kenneth Russell.
  16895. [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
  16896. https://bugs.webkit.org/show_bug.cgi?id=60173
  16897. * page/Page.cpp:
  16898. (WebCore::Page::sharedGraphicsContext3D):
  16899. Flipping the switch to make Skia the default for the accelerated 2d canvas
  16900. 2011-05-05 Tony Gentilcore <tonyg@chromium.org>
  16901. Reviewed by Adam Barth.
  16902. ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
  16903. https://bugs.webkit.org/show_bug.cgi?id=60101
  16904. Test: fast/parser/close-while-stopping.html
  16905. * dom/Document.cpp:
  16906. (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
  16907. the close() steps should be aborted if there is no script-created parser
  16908. associated with the document. Our parser lives throughout
  16909. http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
  16910. the spec doesn't consider the parser active any more. So to properly
  16911. respect this, we need to check that the parser is still parsing.
  16912. 2011-04-28 Evan Martin <evan@chromium.org>
  16913. Reviewed by Ojan Vafai.
  16914. REGRESSION: backspace should not go back on Linux
  16915. https://bugs.webkit.org/show_bug.cgi?id=59731
  16916. Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
  16917. Linux, and test for it in the default backspace handler.
  16918. * editing/EditingBehavior.h:
  16919. (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
  16920. * page/EventHandler.cpp:
  16921. (WebCore::EventHandler::defaultBackspaceEventHandler):
  16922. 2011-05-05 Igor Oliveira <igor.oliveira@openbossa.org>
  16923. Reviewed by Kenneth Russell.
  16924. Framebuffer object is being created twice
  16925. https://bugs.webkit.org/show_bug.cgi?id=60207
  16926. Does not create more than one opengl framebuffer
  16927. * platform/graphics/gpu/mac/DrawingBufferMac.mm:
  16928. (WebCore::DrawingBuffer::DrawingBuffer):
  16929. * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
  16930. (WebCore::DrawingBuffer::DrawingBuffer):
  16931. * platform/graphics/gtk/DrawingBufferGtk.cpp:
  16932. (WebCore::DrawingBuffer::DrawingBuffer):
  16933. 2011-05-05 Simon Fraser <simon.fraser@apple.com>
  16934. Reviewed by Beth Dakin.
  16935. Every RenderLayer registers itself as a ScrollableArea
  16936. https://bugs.webkit.org/show_bug.cgi?id=59650
  16937. Rather than registering every RenderLayer as a ScrollableArea
  16938. on layer creation, only register RenderLayers which are overflow-
  16939. scrollable. Use the m_scrollableAreaPage pointer to keep track
  16940. of whether we've registered to avoid excess work.
  16941. * rendering/RenderLayer.cpp:
  16942. (WebCore::RenderLayer::RenderLayer):
  16943. (WebCore::RenderLayer::scrollsOverflow):
  16944. (WebCore::RenderLayer::styleChanged):
  16945. * rendering/RenderLayer.h:
  16946. 2011-05-05 Jer Noble <jer.noble@apple.com>
  16947. Reviewed by Steve Falkenburg.
  16948. Workaround iTunes' incorrect registry entry for .m4a extensions.
  16949. https://bugs.webkit.org/show_bug.cgi?id=60229
  16950. No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
  16951. The test failed to catch this regression because the build bots haven't installed iTunes.
  16952. Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
  16953. * platform/win/MIMETypeRegistryWin.cpp:
  16954. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  16955. 2011-05-05 Abhishek Arya <inferno@chromium.org>
  16956. Reviewed by Dave Hyatt.
  16957. When style changes for a RenderBlock and we lose our ability to intrude into
  16958. floats in the next siblings block (e.g a position change), make sure to mark
  16959. our childs with floats for layout and iterate through our next sibling block
  16960. chain to see which ones contain the float that also exists in our floating
  16961. objects list and clear those using markAllDescendantsWithFloatsForLayout.
  16962. https://bugs.webkit.org/show_bug.cgi?id=56299
  16963. Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
  16964. fast/block/float/float-not-removed-from-next-sibling.html
  16965. fast/block/float/float-not-removed-from-next-sibling2.html
  16966. fast/block/float/float-not-removed-from-next-sibling3.html
  16967. fast/block/float/float-not-removed-from-next-sibling4.html
  16968. * rendering/RenderBlock.cpp:
  16969. (WebCore::RenderBlock::styleWillChange):
  16970. (WebCore::RenderBlock::styleDidChange):
  16971. (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
  16972. * rendering/RenderBlock.h:
  16973. 2011-05-05 Brian Weinstein <bweinstein@apple.com>
  16974. Reviewed by Timothy Hatcher.
  16975. WebKit2: Docking Web Inspector doesn't respect maximum inspector size
  16976. https://bugs.webkit.org/show_bug.cgi?id=60294
  16977. <rdar://problem/9388518>
  16978. Make a needed function public and export it.
  16979. * WebCore.exp.in: Export constrainedAttaechedWindowHeight.
  16980. * inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.
  16981. 2011-05-05 Tony Gentilcore <tonyg@chromium.org>
  16982. Reviewed by Nate Chapin.
  16983. [Navigation Timing] navigationStart should always be available
  16984. https://bugs.webkit.org/show_bug.cgi?id=59448
  16985. * page/PerformanceTiming.cpp:
  16986. (WebCore::PerformanceTiming::navigationStart):
  16987. 2011-05-05 Eric Carlson <eric.carlson@apple.com>
  16988. Reviewed by Adam Roben.
  16989. Block callbacks delivered during destruction
  16990. https://bugs.webkit.org/show_bug.cgi?id=60291
  16991. <rdar://problem/9382942>
  16992. No new tests, tested by existing tests.
  16993. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  16994. (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call
  16995. setIgnoreLoadStateChanges(true) to cancel all callbacks.
  16996. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if
  16997. m_ignoreLoadStateChanges is true.
  16998. (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
  16999. Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
  17000. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  17001. 2011-05-05 David Hyatt <hyatt@apple.com>
  17002. Reviewed by Darin Adler.
  17003. <rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
  17004. Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
  17005. Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
  17006. (it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
  17007. (the object being removed has no effect on any lines).
  17008. Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
  17009. is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.
  17010. * rendering/RenderBlock.cpp:
  17011. (WebCore::RenderBlock::destroy):
  17012. * rendering/RenderInline.cpp:
  17013. (WebCore::RenderInline::destroy):
  17014. (WebCore::RenderInline::culledInlineFirstLineBox):
  17015. (WebCore::RenderInline::culledInlineLastLineBox):
  17016. 2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>
  17017. Reviewed by Holger Freyther.
  17018. Fix build-webkit --minimal.
  17019. https://bugs.webkit.org/show_bug.cgi?id=60257
  17020. No new tests. This is just a build fix.
  17021. * bindings/js/JSDOMBinding.cpp:
  17022. 2011-05-05 Eric Carlson <eric.carlson@apple.com>
  17023. Reviewed by Adam Roben.
  17024. The preload attribute of the video tag is not completely implemented
  17025. https://bugs.webkit.org/show_bug.cgi?id=43673
  17026. <rdar://problem/9369746>
  17027. This change implements "preload=metadata" for the AVFoundation backend.
  17028. Tested manually with manual-tests/media-elements/video-preload.html.
  17029. * html/HTMLMediaElement.cpp:
  17030. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
  17031. (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
  17032. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
  17033. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
  17034. because we need to have media data loaded to seek.
  17035. (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
  17036. * html/HTMLMediaElement.h:
  17037. * manual-tests/media-elements/video-preload.html: Make changing urls work.
  17038. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  17039. (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove
  17040. m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
  17041. (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
  17042. (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
  17043. Move all preload logic to setPreload, call it from here.
  17044. (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
  17045. setPreload, call it.
  17046. (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
  17047. unlikely to be correct and isn't worth caching. Use invalidTime() function.
  17048. (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
  17049. (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
  17050. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
  17051. to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
  17052. without one. Set networkState to 'idle' when the playback buffer is full because that is
  17053. a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
  17054. when the first frame is available.
  17055. (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
  17056. width, height, hasVideo, etc.
  17057. (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
  17058. (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
  17059. (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
  17060. (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
  17061. in derived classes.
  17062. (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
  17063. AVAsset and AVPlayerItem here.
  17064. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  17065. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  17066. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  17067. (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
  17068. m_videoFrameHasDrawn.
  17069. (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
  17070. videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
  17071. if we have painted a frame to the context.
  17072. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
  17073. if necessary.
  17074. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
  17075. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
  17076. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
  17077. (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
  17078. (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
  17079. the buffer is full.
  17080. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
  17081. AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
  17082. when we only have metadata.
  17083. (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
  17084. (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
  17085. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
  17086. when when we haven't allocated the AVPlayerItem yet so that we can report attributes
  17087. when we only have metadata.
  17088. (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
  17089. we have allocated the AVPlayerItem.
  17090. 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
  17091. Reviewed by Eric Seidel.
  17092. Rename SelectionController to FrameSelection
  17093. https://bugs.webkit.org/show_bug.cgi?id=60234
  17094. * CMakeLists.txt:
  17095. * GNUmakefile.list.am:
  17096. * WebCore.exp.in:
  17097. * WebCore.gypi:
  17098. * WebCore.pro:
  17099. * WebCore.vcproj/WebCore.vcproj:
  17100. * WebCore.xcodeproj/project.pbxproj:
  17101. * accessibility/AccessibilityObject.cpp:
  17102. * accessibility/AccessibilityRenderObject.cpp:
  17103. (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  17104. * accessibility/mac/AccessibilityObjectWrapper.mm:
  17105. * bindings/objc/ExceptionHandlers.h:
  17106. * css/CSSStyleSelector.cpp:
  17107. * dom/ContainerNode.cpp:
  17108. (WebCore::ContainerNode::cloneChildNodes):
  17109. * dom/Document.cpp:
  17110. * dom/InputElement.cpp:
  17111. * editing/DeleteButtonController.cpp:
  17112. * editing/EditCommand.cpp:
  17113. * editing/EditingAllInOne.cpp:
  17114. * editing/EditingStyle.cpp:
  17115. * editing/Editor.cpp:
  17116. (WebCore::Editor::canCopy):
  17117. (WebCore::Editor::canDelete):
  17118. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  17119. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  17120. (WebCore::Editor::changeSelectionAfterCommand):
  17121. (WebCore::Editor::respondToChangedSelection):
  17122. * editing/Editor.h:
  17123. * editing/EditorCommand.cpp:
  17124. (WebCore::executeDeleteToMark):
  17125. (WebCore::executeMoveBackward):
  17126. (WebCore::executeMoveBackwardAndModifySelection):
  17127. (WebCore::executeMoveDown):
  17128. (WebCore::executeMoveDownAndModifySelection):
  17129. (WebCore::executeMoveForward):
  17130. (WebCore::executeMoveForwardAndModifySelection):
  17131. (WebCore::executeMoveLeft):
  17132. (WebCore::executeMoveLeftAndModifySelection):
  17133. (WebCore::executeMovePageDown):
  17134. (WebCore::executeMovePageDownAndModifySelection):
  17135. (WebCore::executeMovePageUp):
  17136. (WebCore::executeMovePageUpAndModifySelection):
  17137. (WebCore::executeMoveRight):
  17138. (WebCore::executeMoveRightAndModifySelection):
  17139. (WebCore::executeMoveToBeginningOfDocument):
  17140. (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
  17141. (WebCore::executeMoveToBeginningOfLine):
  17142. (WebCore::executeMoveToBeginningOfLineAndModifySelection):
  17143. (WebCore::executeMoveToBeginningOfParagraph):
  17144. (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
  17145. (WebCore::executeMoveToBeginningOfSentence):
  17146. (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
  17147. (WebCore::executeMoveToEndOfDocument):
  17148. (WebCore::executeMoveToEndOfDocumentAndModifySelection):
  17149. (WebCore::executeMoveToEndOfSentence):
  17150. (WebCore::executeMoveToEndOfSentenceAndModifySelection):
  17151. (WebCore::executeMoveToEndOfLine):
  17152. (WebCore::executeMoveToEndOfLineAndModifySelection):
  17153. (WebCore::executeMoveToEndOfParagraph):
  17154. (WebCore::executeMoveToEndOfParagraphAndModifySelection):
  17155. (WebCore::executeMoveParagraphBackwardAndModifySelection):
  17156. (WebCore::executeMoveParagraphForwardAndModifySelection):
  17157. (WebCore::executeMoveUp):
  17158. (WebCore::executeMoveUpAndModifySelection):
  17159. (WebCore::executeMoveWordBackward):
  17160. (WebCore::executeMoveWordBackwardAndModifySelection):
  17161. (WebCore::executeMoveWordForward):
  17162. (WebCore::executeMoveWordForwardAndModifySelection):
  17163. (WebCore::executeMoveWordLeft):
  17164. (WebCore::executeMoveWordLeftAndModifySelection):
  17165. (WebCore::executeMoveWordRight):
  17166. (WebCore::executeMoveWordRightAndModifySelection):
  17167. (WebCore::executeMoveToLeftEndOfLine):
  17168. (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
  17169. (WebCore::executeMoveToRightEndOfLine):
  17170. (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  17171. * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
  17172. (WebCore::FrameSelection::FrameSelection):
  17173. (WebCore::FrameSelection::moveTo):
  17174. (WebCore::FrameSelection::setSelection):
  17175. (WebCore::FrameSelection::nodeWillBeRemoved):
  17176. (WebCore::FrameSelection::respondToNodeModification):
  17177. (WebCore::FrameSelection::textWillBeReplaced):
  17178. (WebCore::FrameSelection::setIsDirectional):
  17179. (WebCore::FrameSelection::directionOfEnclosingBlock):
  17180. (WebCore::FrameSelection::willBeModified):
  17181. (WebCore::FrameSelection::positionForPlatform):
  17182. (WebCore::FrameSelection::startForPlatform):
  17183. (WebCore::FrameSelection::endForPlatform):
  17184. (WebCore::FrameSelection::modifyExtendingRight):
  17185. (WebCore::FrameSelection::modifyExtendingForward):
  17186. (WebCore::FrameSelection::modifyMovingRight):
  17187. (WebCore::FrameSelection::modifyMovingForward):
  17188. (WebCore::FrameSelection::modifyExtendingLeft):
  17189. (WebCore::FrameSelection::modifyExtendingBackward):
  17190. (WebCore::FrameSelection::modifyMovingLeft):
  17191. (WebCore::FrameSelection::modifyMovingBackward):
  17192. (WebCore::FrameSelection::modify):
  17193. (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
  17194. (WebCore::FrameSelection::clear):
  17195. (WebCore::FrameSelection::setStart):
  17196. (WebCore::FrameSelection::setEnd):
  17197. (WebCore::FrameSelection::setBase):
  17198. (WebCore::FrameSelection::setExtent):
  17199. (WebCore::FrameSelection::setCaretRectNeedsUpdate):
  17200. (WebCore::FrameSelection::updateCaretRect):
  17201. (WebCore::FrameSelection::caretRenderer):
  17202. (WebCore::FrameSelection::localCaretRect):
  17203. (WebCore::FrameSelection::absoluteBoundsForLocalRect):
  17204. (WebCore::FrameSelection::absoluteCaretBounds):
  17205. (WebCore::FrameSelection::caretRepaintRect):
  17206. (WebCore::FrameSelection::recomputeCaretRect):
  17207. (WebCore::FrameSelection::shouldRepaintCaret):
  17208. (WebCore::FrameSelection::invalidateCaretRect):
  17209. (WebCore::FrameSelection::paintCaret):
  17210. (WebCore::FrameSelection::debugRenderer):
  17211. (WebCore::FrameSelection::contains):
  17212. (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
  17213. (WebCore::FrameSelection::selectAll):
  17214. (WebCore::FrameSelection::setSelectedRange):
  17215. (WebCore::FrameSelection::isInPasswordField):
  17216. (WebCore::FrameSelection::caretRendersInsideNode):
  17217. (WebCore::FrameSelection::focusedOrActiveStateChanged):
  17218. (WebCore::FrameSelection::pageActivationChanged):
  17219. (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
  17220. (WebCore::FrameSelection::setUseSecureKeyboardEntry):
  17221. (WebCore::FrameSelection::setFocused):
  17222. (WebCore::FrameSelection::isFocusedAndActive):
  17223. (WebCore::FrameSelection::updateAppearance):
  17224. (WebCore::FrameSelection::setCaretVisible):
  17225. (WebCore::FrameSelection::clearCaretRectIfNeeded):
  17226. (WebCore::FrameSelection::caretBlinkTimerFired):
  17227. (WebCore::FrameSelection::notifyRendererOfSelectionChange):
  17228. (WebCore::FrameSelection::setFocusedNodeIfNeeded):
  17229. (WebCore::FrameSelection::paintDragCaret):
  17230. (WebCore::FrameSelection::copyTypingStyle):
  17231. (WebCore::FrameSelection::shouldDeleteSelection):
  17232. (WebCore::FrameSelection::bounds):
  17233. (WebCore::FrameSelection::getClippedVisibleTextRectangles):
  17234. (WebCore::FrameSelection::currentForm):
  17235. (WebCore::FrameSelection::revealSelection):
  17236. (WebCore::FrameSelection::setSelectionFromNone):
  17237. (WebCore::FrameSelection::shouldChangeSelection):
  17238. (WebCore::FrameSelection::formatForDebugger):
  17239. (WebCore::FrameSelection::showTreeForThis):
  17240. (showTree):
  17241. * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
  17242. (WebCore::FrameSelection::typingStyle):
  17243. (WebCore::FrameSelection::clearTypingStyle):
  17244. (WebCore::FrameSelection::setTypingStyle):
  17245. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  17246. * editing/ModifySelectionListLevel.cpp:
  17247. * editing/RemoveFormatCommand.cpp:
  17248. * editing/ReplaceSelectionCommand.cpp:
  17249. * editing/SelectionController.cpp: Removed.
  17250. * editing/SelectionController.h: Removed.
  17251. * editing/SetSelectionCommand.cpp:
  17252. (WebCore::SetSelectionCommand::SetSelectionCommand):
  17253. (WebCore::SetSelectionCommand::doApply):
  17254. (WebCore::SetSelectionCommand::doUnapply):
  17255. * editing/SetSelectionCommand.h:
  17256. (WebCore::SetSelectionCommand::create):
  17257. * editing/SpellingCorrectionCommand.cpp:
  17258. (WebCore::SpellingCorrectionCommand::doApply):
  17259. * editing/SpellingCorrectionController.cpp:
  17260. (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
  17261. * editing/TypingCommand.cpp:
  17262. (WebCore::TypingCommand::deleteKeyPressed):
  17263. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  17264. * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
  17265. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  17266. * editing/chromium/SelectionControllerChromium.cpp: Removed.
  17267. * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
  17268. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  17269. * editing/gtk/SelectionControllerGtk.cpp: Removed.
  17270. * editing/mac/EditorMac.mm:
  17271. (WebCore::Editor::canCopyExcludingStandaloneImages):
  17272. * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
  17273. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  17274. * editing/mac/SelectionControllerMac.mm: Removed.
  17275. * editing/qt/EditorQt.cpp:
  17276. * loader/archive/cf/LegacyWebArchive.cpp:
  17277. * page/ContextMenuController.cpp:
  17278. (WebCore::ContextMenuController::populate):
  17279. * page/DOMSelection.cpp:
  17280. (WebCore::DOMSelection::type):
  17281. (WebCore::DOMSelection::modify):
  17282. (WebCore::DOMSelection::addRange):
  17283. (WebCore::DOMSelection::deleteFromDocument):
  17284. (WebCore::DOMSelection::containsNode):
  17285. * page/DragController.cpp:
  17286. (WebCore::DragController::dragIsMove):
  17287. * page/DragController.h:
  17288. * page/EventHandler.cpp:
  17289. (WebCore::setSelectionIfNeeded):
  17290. (WebCore::setNonDirectionalSelectionIfNeeded):
  17291. (WebCore::EventHandler::sendContextMenuEventForKey):
  17292. (WebCore::EventHandler::handleKeyboardSelectionMovement):
  17293. * page/EventHandler.h:
  17294. * page/FocusController.cpp:
  17295. (WebCore::clearSelectionIfNeeded):
  17296. * page/Frame.cpp:
  17297. (WebCore::Frame::Frame):
  17298. * page/Frame.h:
  17299. (WebCore::Frame::selection):
  17300. * page/Page.cpp:
  17301. (WebCore::Page::Page):
  17302. * page/Page.h:
  17303. (WebCore::Page::dragCaretController):
  17304. * page/chromium/DragControllerChromium.cpp:
  17305. * page/chromium/EventHandlerChromium.cpp:
  17306. * page/win/DragControllerWin.cpp:
  17307. * page/win/EventHandlerWin.cpp:
  17308. * rendering/HitTestResult.cpp:
  17309. * rendering/RenderBlock.cpp:
  17310. (WebCore::RenderBlock::destroy):
  17311. (WebCore::RenderBlock::paintCaret):
  17312. * rendering/RenderImage.cpp:
  17313. * rendering/RenderInline.cpp:
  17314. (WebCore::RenderInline::destroy):
  17315. * rendering/RenderLayer.cpp:
  17316. * rendering/RenderListBox.cpp:
  17317. * rendering/RenderObjectChildList.cpp:
  17318. (WebCore::RenderObjectChildList::removeChildNode):
  17319. * rendering/RenderTextControl.cpp:
  17320. * rendering/RenderTextControlSingleLine.cpp:
  17321. * rendering/RenderTheme.cpp:
  17322. * rendering/RenderTreeAsText.cpp:
  17323. * svg/SVGSVGElement.cpp:
  17324. * svg/SVGTextContentElement.cpp:
  17325. (WebCore::SVGTextContentElement::selectSubString):
  17326. 2011-05-05 Brent Fulgham <bfulgham@webkit.org>
  17327. [WinCairo] unreviewed build correction.
  17328. * platform/network/curl/ResourceRequest.h:
  17329. Stub out the new pipelined http logic for cURL.
  17330. 2011-05-05 Pavel Feldman <pfeldman@chromium.org>
  17331. Reviewed by Yury Semikhatsky.
  17332. Web Inspector: searching for node does not result in bringToFront call.
  17333. https://bugs.webkit.org/show_bug.cgi?id=60222
  17334. * inspector/front-end/ElementsPanel.js:
  17335. (WebInspector.ElementsPanel.prototype.updateFocusedNode):
  17336. 2011-05-05 Andreas Kling <andreas.kling@nokia.com>
  17337. Reviewed by Simon Hausmann.
  17338. [Qt] Implement the fast font path for Qt.
  17339. https://bugs.webkit.org/show_bug.cgi?id=51106
  17340. Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
  17341. rendering and measurement of simple text.
  17342. Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
  17343. classes are fully integrated into the Qt 4.8 release branch.
  17344. * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
  17345. * platform/graphics/Font.cpp:
  17346. (WebCore::Font::drawText): Disable fast font path for stroked text, and when
  17347. painting text with a shadow. (Qt-only)
  17348. (WebCore::Font::codePath): Try to use fast font path in more cases.
  17349. * platform/graphics/qt/FontCacheQt.cpp:
  17350. (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
  17351. to use for rendering a given string. Goes through QTextLayout to find the best
  17352. font based on the original QFont query.
  17353. (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
  17354. * platform/graphics/qt/FontPlatformData.h:
  17355. (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
  17356. (WebCore::FontPlatformData::FontPlatformData):
  17357. (WebCore::FontPlatformData::rawFont):
  17358. * platform/graphics/qt/FontPlatformDataQt.cpp:
  17359. (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
  17360. * platform/graphics/qt/FontQt.cpp:
  17361. (WebCore::fillPenForContext):
  17362. (WebCore::strokePenForContext):
  17363. (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
  17364. to share code between complex and simple font rendering paths.
  17365. (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
  17366. * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
  17367. (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
  17368. * platform/graphics/qt/SimpleFontDataQt.cpp:
  17369. (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
  17370. have no way of knowing the pitch.
  17371. (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
  17372. (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
  17373. (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
  17374. (WebCore::SimpleFontData::smallCapsFontData): Ditto.
  17375. (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
  17376. (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
  17377. (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
  17378. (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
  17379. 2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
  17380. Reviewed by Andreas Kling.
  17381. [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
  17382. https://bugs.webkit.org/show_bug.cgi?id=60224
  17383. We should use nullptr rather than 0. nullptr will be added in the new C++ standard
  17384. but WebKit already has a nullptr class if there is no c++0x support.
  17385. * platform/qt/RenderThemeQt.cpp:
  17386. (WebCore::RenderThemeQt::adjustProgressBarStyle):
  17387. (WebCore::RenderThemeQt::adjustSliderTrackStyle):
  17388. (WebCore::RenderThemeQt::adjustSliderThumbStyle):
  17389. 2011-05-05 Ilya Tikhonovsky <loislo@chromium.org>
  17390. Reviewed by Yury Semikhatsky.
  17391. Web Inspector: rename BrowserDebugger to DOMDebugger.
  17392. https://bugs.webkit.org/show_bug.cgi?id=60256
  17393. InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
  17394. browserDebugger => domDebugger
  17395. * CMakeLists.txt:
  17396. * GNUmakefile.list.am:
  17397. * WebCore.gypi:
  17398. * WebCore.pro:
  17399. * WebCore.vcproj/WebCore.vcproj:
  17400. * WebCore.xcodeproj/project.pbxproj:
  17401. * inspector/CodeGeneratorInspector.pm:
  17402. * inspector/InspectorAgent.cpp:
  17403. (WebCore::InspectorAgent::InspectorAgent):
  17404. (WebCore::InspectorAgent::inspectedPageDestroyed):
  17405. (WebCore::InspectorAgent::disconnectFrontend):
  17406. * inspector/InspectorAgent.h:
  17407. (WebCore::InspectorAgent::DOMDebuggerAgent):
  17408. * inspector/InspectorController.cpp:
  17409. (WebCore::InspectorController::connectFrontend):
  17410. * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
  17411. (WebCore::InspectorDOMDebuggerAgent::create):
  17412. (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
  17413. (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
  17414. (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
  17415. (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
  17416. (WebCore::InspectorDOMDebuggerAgent::disable):
  17417. (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
  17418. (WebCore::InspectorDOMDebuggerAgent::discardBindings):
  17419. (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
  17420. (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
  17421. (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
  17422. (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
  17423. (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
  17424. (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
  17425. (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
  17426. (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
  17427. (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
  17428. (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
  17429. (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
  17430. (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
  17431. (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
  17432. (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
  17433. (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
  17434. (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
  17435. (WebCore::InspectorDOMDebuggerAgent::clear):
  17436. * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
  17437. * inspector/InspectorInstrumentation.cpp:
  17438. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
  17439. (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
  17440. (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
  17441. (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
  17442. (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
  17443. (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
  17444. (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  17445. * inspector/InstrumentingAgents.h:
  17446. (WebCore::InstrumentingAgents::InstrumentingAgents):
  17447. (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
  17448. (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
  17449. * inspector/WorkerInspectorController.cpp:
  17450. (WebCore::WorkerInspectorController::connectFrontend):
  17451. 2011-05-04 Yury Semikhatsky <yurys@chromium.org>
  17452. Reviewed by Pavel Feldman.
  17453. Web Inspector: show only Console and Scripts panels in worker inspector front-end
  17454. https://bugs.webkit.org/show_bug.cgi?id=60159
  17455. * inspector/front-end/WorkerManager.js:
  17456. (WebInspector.WorkerManager.isWorkerFrontend):
  17457. * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
  17458. 2011-05-03 Hans Wennborg <hans@chromium.org>
  17459. Reviewed by Steve Block.
  17460. IndexedDB: Unit tests for LevelDB key coding functions
  17461. https://bugs.webkit.org/show_bug.cgi?id=59692
  17462. Fix some embarrassing bugs uncovered by unit tests.
  17463. No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
  17464. * storage/IDBLevelDBCoding.cpp:
  17465. (WebCore::IDBLevelDBCoding::decodeInt):
  17466. (WebCore::IDBLevelDBCoding::decodeVarInt):
  17467. 2011-05-05 Young Han Lee <joybro@company100.net>
  17468. Reviewed by Csaba Osztrogonác.
  17469. [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
  17470. https://bugs.webkit.org/show_bug.cgi?id=60251
  17471. No new tests. Build fix.
  17472. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  17473. (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
  17474. 2011-05-04 Jay Civelli <jcivelli@chromium.org>
  17475. Reviewed by Adam Barth.
  17476. Adding a utility class to read a SharedBuffer line by line.
  17477. https://bugs.webkit.org/show_bug.cgi?id=59946
  17478. * CMakeLists.txt:
  17479. * GNUmakefile.list.am:
  17480. * WebCore.gypi:
  17481. * WebCore.pro:
  17482. * WebCore.vcproj/WebCore.vcproj:
  17483. * WebCore.xcodeproj/project.pbxproj:
  17484. * platform/SharedBufferCRLFLineReader.cpp: Added.
  17485. * platform/SharedBufferCRLFLineReader.h: Added.
  17486. 2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
  17487. Unreviewed, rolling out r85788.
  17488. http://trac.webkit.org/changeset/85788
  17489. https://bugs.webkit.org/show_bug.cgi?id=60250
  17490. svg/text/text-block-child-crash.xhtml asserts (Requested by
  17491. Ossy on #webkit).
  17492. * css/CSSStyleSelector.cpp:
  17493. (WebCore::CSSStyleSelector::applyProperty):
  17494. 2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
  17495. Reviewed by Eric Seidel.
  17496. Make more member functions in EventHandler private
  17497. https://bugs.webkit.org/show_bug.cgi?id=60200
  17498. Reduced the number of public member functions in EventHandler.
  17499. * WebCore.exp.in:
  17500. * page/EventHandler.cpp:
  17501. (WebCore::EventHandler::handleAutoscroll):
  17502. (WebCore::EventHandler::autoscrollTimerFired):
  17503. (WebCore::EventHandler::stopAutoscrollTimer):
  17504. (WebCore::EventHandler::handleMousePressEvent):
  17505. (WebCore::EventHandler::handleMouseMoveEvent):
  17506. (WebCore::EventHandler::keyEvent):
  17507. (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
  17508. * page/EventHandler.h:
  17509. (WebCore::EventHandler::mouseDownMayStartSelect):
  17510. 2011-05-04 James Robinson <jamesr@chromium.org>
  17511. Reviewed by Kenneth Russell.
  17512. [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
  17513. https://bugs.webkit.org/show_bug.cgi?id=60202
  17514. In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
  17515. the order back and adds a regression test.
  17516. Test: compositing/repaint/transform-style-change.html
  17517. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  17518. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  17519. 2011-05-04 Cris Neckar <cdn@chromium.org>
  17520. Reviewed by Adam Barth.
  17521. Expose WebView directly through ChromeClient.
  17522. https://bugs.webkit.org/show_bug.cgi?id=49902
  17523. Test: fast/media/media-svg-crash.html
  17524. * loader/EmptyClients.h:
  17525. (WebCore::EmptyChromeClient::webView):
  17526. * page/ChromeClient.h:
  17527. * page/brew/ChromeClientBrew.h:
  17528. (WebCore::ChromeClientBrew::webView):
  17529. 2011-05-04 Joseph Pecoraro <joepeck@webkit.org>
  17530. Reviewed by Darin Adler.
  17531. Unable to Paste After Deleting Text from Input due to -webkit-user-select
  17532. https://bugs.webkit.org/show_bug.cgi?id=60219
  17533. When deleting all the text inside the input a placeholder <br>
  17534. element was inserted for the selection point. However, when
  17535. pasting, the test run computes the -webkit-user-select for the
  17536. <br> element, instead of what would be the text inside the
  17537. <input> and incorrectly disallows selection and prevented
  17538. the paste.
  17539. Test: editing/pasteboard/paste-placeholder-input.html
  17540. * editing/ReplaceSelectionCommand.cpp:
  17541. (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
  17542. <br> elements above us as those are likely placeholder elements.
  17543. 2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
  17544. Reviewed by Martin Robinson.
  17545. Windows build of WebKit GTK needs to be able to find SystemInfo.h
  17546. https://bugs.webkit.org/show_bug.cgi?id=60221
  17547. * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
  17548. for headers, since Source/WebCore/platform/win/SystemInfo.h
  17549. header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
  17550. on Windows.
  17551. 2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>
  17552. Reviewed by Kenneth Russell.
  17553. [chromium] Improve sorting of layers in hierarchies that preserve-3d
  17554. by testing for overlapping regions between layer pairs and doing a
  17555. topological sort to determine the right order.
  17556. https://bugs.webkit.org/show_bug.cgi?id=59255
  17557. Test: platform/chromium/compositing/perpendicular-layer-sorting.html
  17558. * WebCore.gypi:
  17559. * platform/graphics/chromium/LayerRendererChromium.cpp:
  17560. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  17561. * platform/graphics/chromium/LayerRendererChromium.h:
  17562. * platform/graphics/chromium/cc/CCLayerImpl.h:
  17563. (WebCore::CCLayerImpl::clearRenderSurface):
  17564. * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
  17565. (WebCore::perpProduct):
  17566. (WebCore::innerProduct):
  17567. (WebCore::pointInColinearEdge):
  17568. (WebCore::edgeEdgeTest):
  17569. (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
  17570. (WebCore::CCLayerSorter::LayerIntersector::go):
  17571. (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
  17572. (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
  17573. (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
  17574. (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
  17575. (WebCore::CCLayerSorter::CCLayerSorter):
  17576. (WebCore::CCLayerSorter::checkOverlap):
  17577. (WebCore::CCLayerSorter::createGraphNodes):
  17578. (WebCore::CCLayerSorter::createGraphEdges):
  17579. (WebCore::CCLayerSorter::removeEdgeFromList):
  17580. (WebCore::CCLayerSorter::sort):
  17581. * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
  17582. (WebCore::CCLayerSorter::GraphNode::GraphNode):
  17583. (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
  17584. 2011-05-03 Jer Noble <jer.noble@apple.com>
  17585. Reviewed by Antti Koivisto.
  17586. Safari: Video at apple.com cannot play at full screen mode with layout distortion
  17587. https://bugs.webkit.org/show_bug.cgi?id=60140
  17588. Because a fullscreen element may be in a stacking context with a lower z-index than
  17589. a sibling stacking context, those higher contexts would sometimes "pop" through the
  17590. full screen renderer. To facilitate eliminating all the stacking contexts aside from
  17591. the full screen renderer, added a new pseudo-class specific to video or audio full
  17592. screen elements. Then, added a new UA rule which resets the z-index and opacities of
  17593. all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
  17594. identity checking of HTMLMediaElements, added isMediaElement() virtual function to
  17595. Element and HTMLMediaElement.
  17596. Test: fullscreen/full-screen-stacking-context.html
  17597. * css/CSSSelector.cpp:
  17598. (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
  17599. (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
  17600. (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
  17601. * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
  17602. * css/CSSStyleSelector.cpp:
  17603. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
  17604. * css/fullscreen.css:
  17605. (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,
  17606. which were missing the -webkit prefix.
  17607. (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
  17608. * dom/Element.h:
  17609. (WebCore::Element::isMediaElement): Added, returns false.
  17610. * html/HTMLMediaElement.h:
  17611. (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
  17612. * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
  17613. 2011-05-04 Levi Weintraub <leviw@chromium.org>
  17614. Reviewed by Eric Seidel.
  17615. Split findNextLineBreak into a LineBreaker class
  17616. https://bugs.webkit.org/show_bug.cgi?id=60209
  17617. Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
  17618. nearly no state, but subsequent patches will move some of the local variables used throughout
  17619. the nextLineBreak function into member variables to simplify breaking off helper functions from
  17620. the bloated function.
  17621. No new tests since this is just moving code around.
  17622. * WebCore.xcodeproj/project.pbxproj:
  17623. * rendering/RenderBlock.h:
  17624. (WebCore::RenderBlock::LineBreaker::LineBreaker):
  17625. (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
  17626. (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
  17627. (WebCore::RenderBlock::LineBreaker::clear): Ditto.
  17628. * rendering/RenderBlockLineLayout.cpp:
  17629. (WebCore::RenderBlock::layoutRunsAndFloats):
  17630. (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
  17631. (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
  17632. (WebCore::RenderBlock::LineBreaker::reset):
  17633. (WebCore::RenderBlock::LineBreaker::nextLineBreak):
  17634. 2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
  17635. Reviewed by Adam Barth.
  17636. Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
  17637. The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
  17638. https://bugs.webkit.org/show_bug.cgi?id=58579
  17639. * dom/XMLDocumentParserLibxml2.cpp:
  17640. (WebCore::XMLDocumentParser::error):
  17641. 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
  17642. Unreviewed warning fix.
  17643. The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
  17644. a warning in Release build.
  17645. * dom/Node.cpp:
  17646. (WebCore::Node::removeEventListener):
  17647. * platform/DateComponents.cpp:
  17648. (WebCore::DateComponents::parseTime):
  17649. * rendering/RenderLayer.cpp:
  17650. (WebCore::RenderLayer::convertToLayerCoords):
  17651. * storage/StorageMap.cpp:
  17652. (WebCore::StorageMap::importItem):
  17653. * svg/SVGUseElement.cpp:
  17654. (WebCore::SVGUseElement::buildShadowTree):
  17655. (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  17656. 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
  17657. Unreviewed warning fix.
  17658. The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
  17659. a warning in Release build.
  17660. * accessibility/AccessibilityRenderObject.cpp:
  17661. (WebCore::lastChildConsideringContinuation):
  17662. 2011-05-04 Dimitri Glazkov <dglazkov@chromium.org>
  17663. Sort xcodeproj files.
  17664. The WebCore.xcodeproj got out of sorts again.
  17665. * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
  17666. 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
  17667. Reviewed by Adam Barth.
  17668. Warning fix.
  17669. * bindings/js/DOMObjectHashTableMap.h:
  17670. (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
  17671. 2011-05-04 Rob Buis <rbuis@rim.com>
  17672. Reviewed by Darin Adler.
  17673. NULL deref when SVG elements have table styles
  17674. https://bugs.webkit.org/show_bug.cgi?id=45561
  17675. Restrict computed CSS values for SVG display property to block, inline or none.
  17676. Tests: svg/custom/display-table-caption-foreignObject.svg
  17677. svg/custom/display-table-caption-inherit-foreignObject.xhtml
  17678. svg/custom/display-table-caption-inherit-text.xhtml
  17679. svg/custom/display-table-caption-text.svg
  17680. * css/CSSStyleSelector.cpp:
  17681. (WebCore::CSSStyleSelector::applyProperty):
  17682. 2011-05-04 Tao Bai <michaelbai@chromium.org>
  17683. Reviewed by David Kilzer.
  17684. Populate touch-icon url to FrameLoaderClient
  17685. https://bugs.webkit.org/show_bug.cgi?id=59143
  17686. Parsed and populated apple-touch-icon url to FrameLoaderClient.
  17687. Changed favicon to be a type of icon.
  17688. * CMakeLists.txt:
  17689. * Configurations/FeatureDefines.xcconfig:
  17690. * GNUmakefile.am:
  17691. * GNUmakefile.list.am:
  17692. * WebCore.gypi:
  17693. * WebCore.vcproj/WebCore.vcproj:
  17694. * WebCore.xcodeproj/project.pbxproj:
  17695. * dom/Document.cpp:
  17696. (WebCore::Document::iconURL):
  17697. (WebCore::Document::setIconURL):
  17698. * dom/Document.h:
  17699. * dom/IconURL.cpp: Added.
  17700. (WebCore::toIconIndex):
  17701. * dom/IconURL.h: Added.
  17702. (WebCore::IconURL::IconURL):
  17703. * features.pri:
  17704. * html/HTMLLinkElement.cpp:
  17705. (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  17706. (WebCore::HTMLLinkElement::process):
  17707. (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  17708. * html/HTMLLinkElement.h:
  17709. (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  17710. (WebCore::HTMLLinkElement::isEnabledViaScript):
  17711. * html/parser/HTMLPreloadScanner.cpp:
  17712. (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
  17713. * loader/DocumentLoader.cpp:
  17714. (WebCore::DocumentLoader::iconURL):
  17715. (WebCore::DocumentLoader::setIconURL):
  17716. * loader/DocumentLoader.h:
  17717. * loader/EmptyClients.h:
  17718. (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
  17719. * loader/FrameLoader.cpp:
  17720. (WebCore::FrameLoader::iconURL):
  17721. (WebCore::FrameLoader::iconURLs):
  17722. (WebCore::FrameLoader::fillIconURL):
  17723. (WebCore::FrameLoader::getDefaultIconURL):
  17724. (WebCore::FrameLoader::setIconURL):
  17725. (WebCore::FrameLoader::didChangeIcons):
  17726. * loader/FrameLoader.h:
  17727. * loader/FrameLoaderClient.h:
  17728. 2011-05-04 Chris Marrin <cmarrin@apple.com>
  17729. Reviewed by Simon Fraser.
  17730. Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
  17731. https://bugs.webkit.org/show_bug.cgi?id=60191
  17732. Skip replaceSublayer when there is no superlayer rather than asserting.
  17733. This is probably not a problem and happens when restructuring the layer
  17734. tree. Avoiding this crash will allow us to get more testing.
  17735. * platform/graphics/ca/GraphicsLayerCA.cpp:
  17736. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  17737. 2011-05-04 Martin Robinson <mrobinson@igalia.com>
  17738. Reviewed by Gustavo Noronha Silva.
  17739. Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
  17740. method, just use extern declarations to avoid having to declare it in the header.
  17741. This will prevent having to include glib.h in RenderThemeGtk.h, which is included
  17742. in many C++ files.
  17743. No new tests. This is just a build fix.
  17744. * platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
  17745. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
  17746. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
  17747. (WebCore::RenderThemeGtk::paintCapsLockIndicator):
  17748. (WebCore::RenderThemeGtk::paintMediaButton):
  17749. * platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
  17750. gtkEntry() public because they are now accessed externally from getStockIcon().
  17751. * platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
  17752. (WebCore::getStockIconForWidgetType):
  17753. * platform/gtk/RenderThemeGtk3.cpp: Ditto.
  17754. (WebCore::getStockIconForWidgetType):
  17755. 2011-05-04 Mark Pilgrim <pilgrim@chromium.org>
  17756. Reviewed by Tony Chang.
  17757. IndexedDB open (database) should fail if name is null
  17758. https://bugs.webkit.org/show_bug.cgi?id=60022
  17759. Test: storage/indexeddb/mozilla/open-database-null-name.html
  17760. Combination problem: Bug in IDL didn't pass null values to .cpp layer,
  17761. then .cpp layer didn't check for null value anyway.
  17762. * storage/IDBFactory.cpp:
  17763. (WebCore::IDBFactory::open): check for null name
  17764. * storage/IDBFactory.idl: pass null name as null
  17765. 2011-05-04 Jer Noble <jer.noble@apple.com>
  17766. Reviewed by Darin Adler.
  17767. Entering full screen fails >= second time on Vimeo.com.
  17768. https://bugs.webkit.org/show_bug.cgi?id=60143
  17769. Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
  17770. Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
  17771. at the end of an animation, if it determined that the RenderFullScreen would still require
  17772. a layer even when not animating.
  17773. * rendering/RenderFullScreen.cpp:
  17774. (RenderFullScreen::setAnimating): Clear the renderer's layer.
  17775. 2011-05-04 Simon Fraser <simon.fraser@apple.com>
  17776. Reviewed by Darin Adler.
  17777. Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
  17778. https://bugs.webkit.org/show_bug.cgi?id=59849
  17779. When attempting to unwind the graphics state stack in the
  17780. CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
  17781. to create a new ImageBuffer.
  17782. * html/HTMLCanvasElement.cpp:
  17783. (WebCore::HTMLCanvasElement::existingDrawingContext):
  17784. * html/HTMLCanvasElement.h:
  17785. * html/canvas/CanvasRenderingContext2D.cpp:
  17786. (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
  17787. 2011-05-04 Andrey Kosyakov <caseq@chromium.org>
  17788. Reviewed by Yury Semikhatsky.
  17789. Web Inspector: expose shadow DOM in the Elements panel
  17790. https://bugs.webkit.org/show_bug.cgi?id=60160
  17791. Test: inspector/elements/shadow-dom.html
  17792. * dom/Element.cpp:
  17793. (WebCore::Element::ensureShadowRoot):
  17794. (WebCore::Element::removeShadowRoot):
  17795. * inspector/Inspector.json:
  17796. * inspector/InspectorDOMAgent.cpp:
  17797. (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
  17798. (WebCore::InspectorDOMAgent::buildObjectForNode):
  17799. (WebCore::InspectorDOMAgent::didInsertDOMNode):
  17800. (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  17801. (WebCore::InspectorDOMAgent::isContainerNode):
  17802. * inspector/InspectorDOMAgent.h:
  17803. * inspector/front-end/DOMAgent.js:
  17804. (WebInspector.DOMNode):
  17805. (WebInspector.DOMNode.prototype.inShadowTree):
  17806. (WebInspector.DOMNode.prototype._setShadowRootPayload):
  17807. (WebInspector.DOMNode.prototype._renumber):
  17808. (WebInspector.DOMAgent.prototype._bindNodes):
  17809. (WebInspector.DOMAgent.prototype.querySelectorAll):
  17810. (WebInspector.DOMAgent.prototype._shadowRootUpdated):
  17811. (WebInspector.DOMDispatcher.prototype.searchResults):
  17812. (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
  17813. * inspector/front-end/ElementsPanel.js:
  17814. (WebInspector.ElementsPanel):
  17815. (WebInspector.ElementsPanel.prototype._nodeUpdated):
  17816. (WebInspector.ElementsPanel.prototype._attributesUpdated):
  17817. (WebInspector.ElementsPanel.prototype._nodeRemoved):
  17818. (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  17819. (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  17820. * inspector/front-end/ElementsTreeOutline.js:
  17821. (WebInspector.ElementsTreeElement):
  17822. (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
  17823. (WebInspector.ElementsTreeElement.prototype._updateChildren):
  17824. ():
  17825. * inspector/front-end/inspector.css:
  17826. (#elements-content .dom-shadow-root):
  17827. (.outline-disclosure li .webkit-html-tag.shadow):
  17828. * inspector/front-end/utilities.js:
  17829. 2011-05-03 Adam Roben <aroben@apple.com>
  17830. Remove an unnecessary OwnPtr equality check in XSLT code
  17831. Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
  17832. Reviewed by Anders Carlsson and Antti Koivisto.
  17833. * dom/Document.cpp:
  17834. (WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
  17835. equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
  17836. we're safe.)
  17837. 2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>
  17838. Reviewed by Tony Gentilcore.
  17839. Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
  17840. https://bugs.webkit.org/show_bug.cgi?id=56922
  17841. Add the basic outlines of the page controller, the per-frame controller and the embedder
  17842. client interface for the Media Stream API. Provide methods to handle the situations
  17843. where a frame is detached from the page or transferred between pages.
  17844. Tests for the Media Stream API will be provided by the bug 56587.
  17845. * CMakeLists.txt:
  17846. * GNUmakefile.list.am:
  17847. * WebCore.gypi:
  17848. * WebCore.pro:
  17849. * WebCore.vcproj/WebCore.vcproj:
  17850. * WebCore.xcodeproj/project.pbxproj:
  17851. * page/Frame.cpp:
  17852. (WebCore::Frame::Frame):
  17853. (WebCore::Frame::~Frame):
  17854. (WebCore::Frame::pageDestroyed):
  17855. (WebCore::Frame::transferChildFrameToNewDocument):
  17856. * page/Frame.h:
  17857. (WebCore::Frame::mediaStreamFrameController):
  17858. * page/MediaStreamClient.h: Added.
  17859. (WebCore::MediaStreamClient::~MediaStreamClient):
  17860. * page/MediaStreamController.cpp: Added.
  17861. (WebCore::MediaStreamController::Request::Request):
  17862. (WebCore::MediaStreamController::Request::localId):
  17863. (WebCore::MediaStreamController::Request::frameController):
  17864. (WebCore::MediaStreamController::MediaStreamController):
  17865. (WebCore::MediaStreamController::~MediaStreamController):
  17866. (WebCore::MediaStreamController::unregisterFrameController):
  17867. (WebCore::MediaStreamController::registerRequest):
  17868. * page/MediaStreamController.h: Added.
  17869. * page/MediaStreamFrameController.cpp: Added.
  17870. (WebCore::MediaStreamFrameController::Request::Request):
  17871. (WebCore::MediaStreamFrameController::Request::~Request):
  17872. (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
  17873. (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
  17874. (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
  17875. (WebCore::MediaStreamFrameController::RequestMap::abort):
  17876. (WebCore::MediaStreamFrameController::RequestMap::abortAll):
  17877. (WebCore::MediaStreamFrameController::MediaStreamFrameController):
  17878. (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
  17879. (WebCore::MediaStreamFrameController::securityOrigin):
  17880. (WebCore::MediaStreamFrameController::scriptExecutionContext):
  17881. (WebCore::MediaStreamFrameController::pageController):
  17882. (WebCore::MediaStreamFrameController::enterDetachedState):
  17883. (WebCore::MediaStreamFrameController::disconnectPage):
  17884. (WebCore::MediaStreamFrameController::disconnectFrame):
  17885. (WebCore::MediaStreamFrameController::transferToNewPage):
  17886. * page/MediaStreamFrameController.h: Added.
  17887. * page/Page.cpp:
  17888. (WebCore::Page::Page):
  17889. (WebCore::Page::PageClients::PageClients):
  17890. * page/Page.h:
  17891. (WebCore::Page::mediaStreamController):
  17892. 2011-05-04 Alexander Pavlov <apavlov@chromium.org>
  17893. Reviewed by Yury Semikhatsky.
  17894. Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
  17895. https://bugs.webkit.org/show_bug.cgi?id=60150
  17896. * inspector/front-end/StylesSidebarPane.js:
  17897. (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
  17898. 2011-05-04 Dominic Battre <battre@chromium.org>
  17899. Reviewed by Tony Gentilcore.
  17900. Fix missing header in case SVG is disabled
  17901. https://bugs.webkit.org/show_bug.cgi?id=60153
  17902. * dom/EventDispatcher.cpp:
  17903. 2011-05-04 Luke Macpherson <macpherson@chromium.org>
  17904. Reviewed by Eric Seidel.
  17905. Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
  17906. https://bugs.webkit.org/show_bug.cgi?id=60006
  17907. No new tests as no functionality added. Simple rename only.
  17908. * css/CSSStyleApplyProperty.cpp:
  17909. Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
  17910. * css/CSSStyleApplyProperty.h:
  17911. Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
  17912. 2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
  17913. Reviewed by Eric Seidel.
  17914. Cleanup conditionals in findNextLineBreak
  17915. https://bugs.webkit.org/show_bug.cgi?id=60117
  17916. Simplified conditional statements in findNextLineBreak.
  17917. * rendering/RenderBlockLineLayout.cpp:
  17918. (WebCore::RenderBlock::findNextLineBreak):
  17919. 2011-05-04 Luke Macpherson <macpherson@chromium.org>
  17920. Reviewed by Eric Seidel.
  17921. Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
  17922. https://bugs.webkit.org/show_bug.cgi?id=60114
  17923. No new tests as no functionality changes.
  17924. * css/CSSStyleSelector.cpp:
  17925. (WebCore::CSSStyleSelector::applyProperty):
  17926. Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
  17927. 2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  17928. Reviewed by Andreas Kling.
  17929. [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
  17930. https://bugs.webkit.org/show_bug.cgi?id=59070
  17931. Applications using our API and our autotests subclass QNetworkReply as part of providing a
  17932. custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
  17933. QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
  17934. 4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
  17935. The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
  17936. watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
  17937. indicating that it is finished. When there's no finished signal (synchronous) we set the
  17938. dynamic property once we get the reply.
  17939. This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
  17940. emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
  17941. * platform/network/qt/QNetworkReplyHandler.cpp:
  17942. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  17943. Connect the finished signal to the new setFinished() slot.
  17944. (WebCore::QNetworkReplyWrapper::synchronousLoad):
  17945. Since we don't get the finished signal for synchronous loads, set the dynamic property
  17946. before processing it.
  17947. (WebCore::QNetworkReplyWrapper::resetConnections):
  17948. Do not reset the connection to setFinished().
  17949. (WebCore::QNetworkReplyWrapper::setFinished):
  17950. Set the dynamic property in the reply.
  17951. (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
  17952. (WebCore::QNetworkReplyHandler::start):
  17953. Change to use wrapper's isFinished() instead of asking the reply directly.
  17954. * platform/network/qt/QNetworkReplyHandler.h:
  17955. (WebCore::QNetworkReplyWrapper::isFinished):
  17956. Checks the dynamic property of the reply.
  17957. * platform/network/qt/QtMIMETypeSniffer.cpp:
  17958. (QtMIMETypeSniffer::sniff):
  17959. Use the dynamic property to check if the reply is finished.
  17960. 2011-05-04 Eric Seidel <eric@webkit.org>
  17961. Reviewed by Ryosuke Niwa.
  17962. Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
  17963. https://bugs.webkit.org/show_bug.cgi?id=60080
  17964. No functional change, just moving code.
  17965. * rendering/RenderBlock.h:
  17966. * rendering/RenderBlockLineLayout.cpp:
  17967. (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
  17968. (WebCore::RenderBlock::layoutRunsAndFloats):
  17969. 2011-05-04 Andreas Kling <andreas.kling@nokia.com>
  17970. Reviewed by Kenneth Rohde Christiansen.
  17971. [Qt] Remove unused function FontPlatformData::pixelSize()
  17972. https://bugs.webkit.org/show_bug.cgi?id=60156
  17973. * platform/graphics/qt/FontPlatformData.h:
  17974. (WebCore::FontPlatformData::pixelSize): Removed.
  17975. 2011-05-04 Luke Macpherson <macpherson@chromium.org>
  17976. Reviewed by Darin Adler.
  17977. Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
  17978. https://bugs.webkit.org/show_bug.cgi?id=60011
  17979. No new tests added as no functionality changed.
  17980. * css/CSSStyleSelector.cpp:
  17981. (WebCore::CSSStyleSelector::applyProperty):
  17982. Remove reundant check for auto table layout.
  17983. 2011-05-04 Mihai Parparita <mihaip@chromium.org>
  17984. Reviewed by Darin Adler.
  17985. Remove double-free checks for bug 56124
  17986. https://bugs.webkit.org/show_bug.cgi?id=60037
  17987. Antti's speculative fix for bug 56124 (r84151) appears to have worked,
  17988. these CRASH() calls are not triggering anymore.
  17989. * css/CSSSelector.h:
  17990. (WebCore::CSSSelector::CSSSelector):
  17991. (WebCore::CSSSelector::~CSSSelector):
  17992. * css/CSSSelectorList.cpp:
  17993. (WebCore::CSSSelectorList::deleteSelectors):
  17994. 2011-05-04 Satish Sampath <satish@chromium.org>
  17995. Reviewed by Tony Gentilcore.
  17996. Layout the speech input button to the left of outer spin button properly.
  17997. https://bugs.webkit.org/show_bug.cgi?id=59742
  17998. * rendering/RenderTextControlSingleLine.cpp:
  17999. (WebCore::RenderTextControlSingleLine::layout):
  18000. 2011-05-04 Yury Semikhatsky <yurys@chromium.org>
  18001. Unreviewed. Build fix.
  18002. * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
  18003. 2011-05-03 Yury Semikhatsky <yurys@chromium.org>
  18004. Reviewed by Pavel Feldman.
  18005. Web Inspector: can't inspect element in an iframe when element originates from non-frame document
  18006. https://bugs.webkit.org/show_bug.cgi?id=60031
  18007. Inspected object type evaluation has moved into native bindings. This way it doesn't
  18008. depend on the current JS context.
  18009. Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
  18010. * bindings/js/JSInjectedScriptHostCustom.cpp:
  18011. (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
  18012. real undefined values from HTMLAllCollection
  18013. (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
  18014. value
  18015. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  18016. (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
  18017. (WebCore::V8InjectedScriptHost::typeCallback):
  18018. * inspector/InjectedScriptHost.idl:
  18019. * inspector/InjectedScriptSource.js:
  18020. (.):
  18021. 2011-05-03 Pratik Solanki <psolanki@apple.com>
  18022. Reviewed by Antti Koivisto.
  18023. Part of WebCore should use CFNetwork-based loader on Mac
  18024. https://bugs.webkit.org/show_bug.cgi?id=51836
  18025. Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
  18026. up some warnings and #if USE(CFNETWORK) around code.
  18027. * platform/mac/CookieJar.mm:
  18028. * platform/network/CookieStorage.h:
  18029. * platform/network/cf/CookieStorageCFNet.cpp:
  18030. (WebCore::privateBrowsingCookieStorage):
  18031. (WebCore::currentCookieStorage):
  18032. (WebCore::setCurrentCookieStorage):
  18033. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  18034. (WebCore::notifyCookiesChangedOnMainThread):
  18035. (WebCore::notifyCookiesChanged):
  18036. * platform/network/cf/CookieStorageCFNet.h:
  18037. * platform/network/mac/CookieStorageMac.mm:
  18038. 2011-05-03 Justin Novosad <junov@chromium.org>
  18039. Reviewed by Kenneth Russell.
  18040. [Chromium] Make accelerated 2d canvas enabled by default with skia
  18041. https://bugs.webkit.org/show_bug.cgi?id=59929
  18042. No new tests. Covered by existing layout tests
  18043. * html/canvas/CanvasRenderingContext2D.cpp:
  18044. (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
  18045. Initialized for accelerated canvas if either the accelerated2dCanvas
  18046. or the legacyAccelerated2dCanvas flags are enabled
  18047. * page/Page.cpp:
  18048. (WebCore::Page::sharedGraphicsContext3D):
  18049. This is where the code goes to implement the functionality for the
  18050. legacy vs current acceleration paths for the 2D canvas. Currently,
  18051. this is a no-op, and always select the legacy path. This is temporary
  18052. until we are ready to sort the GPU layout tests (rebasline vs. bug)
  18053. * page/Settings.cpp: Added new flage for legacyAccelerated2dCanvas
  18054. (WebCore::Settings::Settings):
  18055. (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
  18056. * page/Settings.h:
  18057. (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
  18058. 2011-04-29 Jer Noble <jer.noble@apple.com>
  18059. Reviewed by Eric Seidel.
  18060. Implement FULLSCREEN_API on Windows, Part 4: Enable it
  18061. https://bugs.webkit.org/show_bug.cgi?id=59798
  18062. * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
  18063. files to the project.
  18064. 2011-05-03 Alpha Lam <hclam@chromium.org>
  18065. Not reviewed. Build fix.
  18066. More places from 0 to nullptr.
  18067. * bindings/v8/V8Proxy.cpp:
  18068. (WebCore::V8Proxy::precompileScript):
  18069. * platform/graphics/chromium/LayerTilerChromium.cpp:
  18070. (WebCore::LayerTilerChromium::create):
  18071. * platform/graphics/gpu/BicubicShader.cpp:
  18072. (WebCore::BicubicShader::create):
  18073. * platform/graphics/gpu/ConvolutionShader.cpp:
  18074. (WebCore::ConvolutionShader::create):
  18075. * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
  18076. (WebCore::LoopBlinnSolidFillShader::create):
  18077. * platform/graphics/gpu/SolidFillShader.cpp:
  18078. (WebCore::SolidFillShader::create):
  18079. * platform/graphics/gpu/TexShader.cpp:
  18080. (WebCore::TexShader::create):
  18081. * platform/graphics/skia/PlatformContextSkia.cpp:
  18082. (WebCore::PlatformContextSkia::~PlatformContextSkia):
  18083. * platform/leveldb/LevelDBDatabase.cpp:
  18084. (WebCore::LevelDBDatabase::createIterator):
  18085. * platform/text/LocalizedNumberICU.cpp:
  18086. (WebCore::createFormatterForCurrentLocale):
  18087. 2011-05-03 Alpha Lam <hclam@chromium.org>
  18088. Not reviewed. Build fix.
  18089. Using nullptr instead of 0. This makes visual studio happy.
  18090. * storage/IDBTransactionBackendInterface.h:
  18091. 2011-05-03 Luke Macpherson <macpherson@chromium.org>
  18092. Reviewed by Dimitri Glazkov.
  18093. Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
  18094. https://bugs.webkit.org/show_bug.cgi?id=59774
  18095. No new tests required as on new functionality.
  18096. * css/CSSStyleApplyProperty.cpp:
  18097. (WebCore::ApplyPropertyColor::applyValue):
  18098. Added template parameter "inheritColorFromParent = false".
  18099. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  18100. Use template parameter where appropriate.
  18101. 2011-05-03 Dan Bernstein <mitz@apple.com>
  18102. Reviewed by Darin Adler.
  18103. <rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
  18104. Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
  18105. dirty the line when the float is removed, instead of relying on the float always intersecting
  18106. its originating line.
  18107. * rendering/RenderBlock.cpp:
  18108. (WebCore::RenderBlock::removeFloatingObject):
  18109. (WebCore::RenderBlock::removeFloatingObjectsBelow):
  18110. (WebCore::RenderBlock::clearFloats):
  18111. * rendering/RenderBlock.h:
  18112. (WebCore::RenderBlock::FloatingObject::FloatingObject):
  18113. * rendering/RenderBlockLineLayout.cpp:
  18114. (WebCore::RenderBlock::appendFloatingObjectToLastLine):
  18115. (WebCore::RenderBlock::layoutRunsAndFloats):
  18116. (WebCore::RenderBlock::determineStartPosition):
  18117. 2011-05-02 Jer Noble <jer.noble@apple.com>
  18118. Reviewed by Adam Roben.
  18119. Implement FULLSCREEN_API on Windows, Part 3: WebKit2
  18120. https://bugs.webkit.org/show_bug.cgi?id=59845
  18121. Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
  18122. and WebKit2. WebFullScreenController now uses a Client class to request work on its
  18123. behalf by WebKit and WebKit2. MediaPlayerPrivateFullscreenWindow now only creates a
  18124. CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
  18125. problems, and because a CALayerHost is overkill if the window is only drawing black to
  18126. its client area.
  18127. * WebCore.vcproj/WebCore.vcproj:
  18128. * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  18129. (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create
  18130. m_layerHost in the constructor.
  18131. (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
  18132. (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
  18133. (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
  18134. not present, fill the window with black in WM_PAINT.
  18135. * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  18136. * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
  18137. * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
  18138. * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
  18139. (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
  18140. 2011-05-03 Brady Eidson <beidson@apple.com>
  18141. Reviewed by Sam Weinig.
  18142. https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
  18143. WK2 Icon Database should provide access to all image representations in the icon.
  18144. Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
  18145. * platform/graphics/BitmapImage.h:
  18146. * platform/graphics/Image.h:
  18147. (WebCore::Image::getCGImageArray):
  18148. * platform/graphics/cg/ImageCG.cpp:
  18149. (WebCore::BitmapImage::getCGImageArray):
  18150. 2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
  18151. Reviewed by Eric Seidel.
  18152. findNextLineBreak splits InlineIterator into 3 pieces
  18153. https://bugs.webkit.org/show_bug.cgi?id=60082
  18154. Avoid splitting InlineIterator into 3 variables with inter-dependencies.
  18155. * rendering/InlineIterator.h:
  18156. (WebCore::InlineIterator::fastIncrementInTextNode): Added.
  18157. (WebCore::InlineIterator::previousInSameNode): Added.
  18158. * rendering/RenderBlockLineLayout.cpp:
  18159. (WebCore::RenderBlock::findNextLineBreak):
  18160. 2011-05-03 Dean Jackson <dino@apple.com>
  18161. Reviewed by Simon Fraser.
  18162. Interrupted transitions are not correctly removed
  18163. https://bugs.webkit.org/show_bug.cgi?id=60062
  18164. CompositeAnimation was replacing any existing
  18165. transition as a new one was created. However, it wasn't
  18166. clearing the lists in AnimationControllerPrivate that
  18167. signal when a hardware animation starts. Rather than
  18168. simple removing the existing transition, we now tell
  18169. AnimationControllerPrivate that is has gone.
  18170. Test: transitions/3d/interrupted-transition.html
  18171. * page/animation/CompositeAnimation.cpp:
  18172. (WebCore::CompositeAnimation::updateTransitions):
  18173. 2011-05-03 Enrica Casucci <enrica@apple.com>
  18174. Reviewed by Ryosuke Niwa.
  18175. Crash in SpellingCorrectionController::respondToChangedSelection.
  18176. https://bugs.webkit.org/show_bug.cgi?id=60071
  18177. <rdar://problem/9358190>
  18178. Creating a Visible position could trigger a layout and there is no
  18179. guarantee that the selection is still valid after that.
  18180. Tests: editing/selection/undo-crash.html
  18181. * editing/SpellingCorrectionController.cpp:
  18182. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  18183. 2011-05-03 Levi Weintraub <leviw@chromium.org>
  18184. Reviewed by Eric Seidel.
  18185. Refactor computeInlineDirectionPositionsForLine into smaller functions
  18186. https://bugs.webkit.org/show_bug.cgi?id=60072
  18187. Split three functions off from computeInlineDirectionPositionsForLine
  18188. to improve its readability.
  18189. No new tests since this is just moving code around.
  18190. * rendering/RenderBlock.h:
  18191. * rendering/RenderBlockLineLayout.cpp:
  18192. (WebCore::RenderBlock::setMarginsForRubyRun):
  18193. (WebCore::setLogicalWidthForTextRun):
  18194. (WebCore::computeExpansionForJustifiedText):
  18195. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  18196. 2011-05-03 David Kilzer <ddkilzer@apple.com>
  18197. <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
  18198. Reviewed by Antti Koivisto.
  18199. * platform/network/cf/ResourceRequestCFNet.cpp:
  18200. (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
  18201. priority on the request if HTTP pipelining is enabled.
  18202. (WebCore::ResourceRequest::doUpdateResourceRequest): Read the
  18203. priority from the request if HTTP pipelining is enabled.
  18204. (readBooleanPreference): Enable code when compiling with
  18205. USE(CFNETWORK).
  18206. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
  18207. Comment out setting the minimum fast lane priority on Windows
  18208. since it's not currently available.
  18209. 2011-05-03 Simon Fraser <simon.fraser@apple.com>
  18210. Reviewed by Dan Bernstein.
  18211. <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
  18212. Conditionalize compositing tiled layer size-constraining logic to older
  18213. OSes.
  18214. * platform/graphics/ca/GraphicsLayerCA.cpp:
  18215. (WebCore::GraphicsLayerCA::constrainedSize):
  18216. 2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
  18217. Reviewed by Dimitri Glazkov.
  18218. Allow access keys to be used in shadow DOM
  18219. https://bugs.webkit.org/show_bug.cgi?id=59979
  18220. Move access key methods and members back to Document from TreeScope.
  18221. Also traverse into shadow trees when building the access key map.
  18222. No new tests. (refactoring)
  18223. * dom/Document.cpp:
  18224. (WebCore::Document::Document):
  18225. (WebCore::Document::getElementByAccessKey):
  18226. (WebCore::Document::buildAccessKeyMap):
  18227. (WebCore::Document::invalidateAccessKeyMap):
  18228. * dom/Document.h:
  18229. * dom/TreeScope.cpp:
  18230. (WebCore::TreeScope::TreeScope):
  18231. (WebCore::TreeScope::destroyTreeScopeData):
  18232. * dom/TreeScope.h:
  18233. 2011-05-03 Dan Bernstein <mitz@apple.com>
  18234. Reviewed by Darin Adler.
  18235. <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
  18236. https://bugs.webkit.org/show_bug.cgi?id=60067
  18237. No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
  18238. * rendering/RenderText.cpp:
  18239. (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
  18240. and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
  18241. results for flipped writing modes.
  18242. 2011-05-03 Anton Muhin <antonm@chromium.org>
  18243. Reviewed by Yury Semikhatsky.
  18244. [v8] remove an ASSERT from grouping logic
  18245. https://bugs.webkit.org/show_bug.cgi?id=60024
  18246. This ASSERT was exploratory. Alas, right now I am aware of no easy way to
  18247. repro it. Removing for now for greener bots.
  18248. No new tests, only an ASSERT removal.
  18249. * bindings/v8/V8GCController.cpp:
  18250. (WebCore::calculateGroupId):
  18251. 2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
  18252. Reviewed by Darin Adler.
  18253. WebKit allows selection that crosses the shadow boundary of a readonly input element
  18254. https://bugs.webkit.org/show_bug.cgi?id=60000
  18255. The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
  18256. Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
  18257. in its validation process.
  18258. Tests: editing/selection/select-across-readonly-input-1.html
  18259. editing/selection/select-across-readonly-input-2.html
  18260. editing/selection/select-across-readonly-input-3.html
  18261. editing/selection/select-across-readonly-input-4.html
  18262. editing/selection/select-across-readonly-input-5.html
  18263. * editing/VisibleSelection.cpp:
  18264. (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
  18265. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
  18266. * editing/VisibleSelection.h:
  18267. 2011-05-03 Eric Seidel <eric@webkit.org>
  18268. Reviewed by Ryosuke Niwa.
  18269. Split out layoutRunsAndFloats from layoutInlineChildren
  18270. https://bugs.webkit.org/show_bug.cgi?id=60052
  18271. No new tests, just moving code here. There should be
  18272. no change in behavior.
  18273. * rendering/RenderBlock.h:
  18274. * rendering/RenderBlockLineLayout.cpp:
  18275. (WebCore::RenderBlock::layoutRunsAndFloats):
  18276. (WebCore::RenderBlock::layoutInlineChildren):
  18277. 2011-05-03 James Robinson <jamesr@chromium.org>
  18278. Reviewed by Kenneth Russell.
  18279. [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
  18280. https://bugs.webkit.org/show_bug.cgi?id=59965
  18281. Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
  18282. Test: fast/canvas/canvas-resize-after-paint.html
  18283. * html/canvas/CanvasRenderingContext2D.cpp:
  18284. (WebCore::CanvasRenderingContext2D::reset):
  18285. Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
  18286. DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
  18287. * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
  18288. (WebCore::Canvas2DLayerChromium::setLayerRenderer):
  18289. Add a null check for m_drawingBuffer
  18290. * platform/graphics/gpu/DrawingBuffer.cpp:
  18291. (WebCore::DrawingBuffer::clear):
  18292. Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
  18293. this is unnecessary.
  18294. 2011-05-03 Adam Roben <aroben@apple.com>
  18295. Fix most strict PassOwnPtr violations on Windows
  18296. Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
  18297. enabled
  18298. Reviewed by Anders Carlsson.
  18299. * loader/EmptyClients.h:
  18300. * platform/GeolocationService.cpp:
  18301. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  18302. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  18303. * platform/mock/GeolocationServiceMock.cpp:
  18304. * rendering/RenderTheme.cpp:
  18305. * rendering/RenderThemeSafari.cpp:
  18306. 2011-05-03 Levi Weintraub <leviw@chromium.org>
  18307. Reviewed by Eric Seidel.
  18308. Extract LineInfo class
  18309. https://bugs.webkit.org/show_bug.cgi?id=60044
  18310. Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
  18311. layout information about a line. This simplifies function signatures and clears up initialization.
  18312. No new tests as this is refactoring.
  18313. * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
  18314. * rendering/RenderBlockLineLayout.cpp:
  18315. (WebCore::LineInfo::LineInfo):
  18316. (WebCore::LineInfo::isFirstLine):
  18317. (WebCore::LineInfo::isLastLine):
  18318. (WebCore::LineInfo::isEmpty):
  18319. (WebCore::LineInfo::previousLineBrokeCleanly):
  18320. (WebCore::LineInfo::setFirstLine):
  18321. (WebCore::LineInfo::setLastLine):
  18322. (WebCore::LineInfo::setEmpty):
  18323. (WebCore::LineInfo::setPreviousLineBrokeCleanly):
  18324. (WebCore::RenderBlock::createLineBoxes):
  18325. (WebCore::RenderBlock::constructLine):
  18326. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  18327. (WebCore::RenderBlock::layoutInlineChildren):
  18328. (WebCore::RenderBlock::determineStartPosition):
  18329. (WebCore::skipNonBreakingSpace):
  18330. (WebCore::shouldCollapseWhiteSpace):
  18331. (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
  18332. (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
  18333. (WebCore::RenderBlock::skipTrailingWhitespace):
  18334. (WebCore::RenderBlock::skipLeadingWhitespace):
  18335. (WebCore::RenderBlock::findNextLineBreak):
  18336. 2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
  18337. Reviewed by Dimitri Glazkov.
  18338. Update node list cache count on the containing TreeScope rather than the Document
  18339. https://bugs.webkit.org/show_bug.cgi?id=59983
  18340. Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
  18341. Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
  18342. Make setDocument() and setDocumentRecursively() private.
  18343. No new tests. (refactoring)
  18344. * dom/ContainerNode.cpp:
  18345. (WebCore::ContainerNode::childrenChanged):
  18346. * dom/Node.cpp:
  18347. (WebCore::Node::~Node):
  18348. (WebCore::Node::setDocument):
  18349. (WebCore::Node::setTreeScopeRecursively):
  18350. (WebCore::Node::childNodes):
  18351. (WebCore::Node::registerDynamicNodeList):
  18352. (WebCore::Node::unregisterDynamicNodeList):
  18353. (WebCore::Node::notifyLocalNodeListsAttributeChanged):
  18354. (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  18355. (WebCore::Node::getElementsByTagName):
  18356. (WebCore::Node::getElementsByTagNameNS):
  18357. (WebCore::Node::getElementsByName):
  18358. (WebCore::Node::getElementsByClassName):
  18359. * dom/Node.h:
  18360. * html/HTMLFormControlElement.cpp:
  18361. (WebCore::HTMLFormControlElement::labels):
  18362. 2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
  18363. Reviewed by Eric Seidel.
  18364. Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
  18365. https://bugs.webkit.org/show_bug.cgi?id=60046
  18366. Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
  18367. * rendering/RenderBlockLineLayout.cpp:
  18368. (WebCore::TrailingObjects::TrailingObjects):
  18369. (WebCore::TrailingObjects::setTrailingWhitespace):
  18370. (WebCore::TrailingObjects::clear):
  18371. (WebCore::TrailingObjects::appendBoxIfNeeded):
  18372. (WebCore::TrailingObjects::addMidpoints):
  18373. (WebCore::RenderBlock::findNextLineBreak):
  18374. 2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>
  18375. Reviewed by Eric Seidel.
  18376. [Qt] Implement initial support to DataTransferItems
  18377. https://bugs.webkit.org/show_bug.cgi?id=58448
  18378. Implement initial support to DataTransferItems. DataTransferItems are used to
  18379. hold data for drag and drop operations. DataTransferItems hold a list of
  18380. DataTransferItem objects each of which holds an item being dragged.
  18381. * WebCore.pro:
  18382. * dom/DataTransferItems.idl:
  18383. * editing/qt/EditorQt.cpp:
  18384. (WebCore::Editor::newGeneralClipboard):
  18385. * page/qt/EventHandlerQt.cpp:
  18386. (WebCore::EventHandler::createDraggingClipboard):
  18387. * platform/chromium/DataTransferItemsChromium.h:
  18388. * platform/qt/ClipboardQt.cpp:
  18389. (WebCore::Clipboard::create):
  18390. (WebCore::ClipboardQt::ClipboardQt):
  18391. (WebCore::ClipboardQt::items):
  18392. * platform/qt/ClipboardQt.h:
  18393. (WebCore::ClipboardQt::create):
  18394. * platform/qt/DataTransferItemQt.cpp: Added.
  18395. (WebCore::DataTransferItem::create):
  18396. (WebCore::DataTransferItemQt::createFromPasteboard):
  18397. (WebCore::DataTransferItemQt::create):
  18398. (WebCore::DataTransferItemQt::DataTransferItemQt):
  18399. (WebCore::DataTransferItemQt::getAsString):
  18400. (WebCore::DataTransferItemQt::getAsFile):
  18401. * platform/qt/DataTransferItemQt.h: Added.
  18402. * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
  18403. (WebCore::DataTransferItemsQt::create):
  18404. (WebCore::DataTransferItemsQt::DataTransferItemsQt):
  18405. (WebCore::DataTransferItemsQt::addPasteboardItem):
  18406. * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
  18407. 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
  18408. Reviewed by Dimitri Glazkov.
  18409. Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
  18410. https://bugs.webkit.org/show_bug.cgi?id=58703
  18411. No new tests, refactoring only.
  18412. * dom/Element.cpp:
  18413. (WebCore::Element::copyNonAttributeProperties):
  18414. (WebCore::Element::insertedIntoDocument):
  18415. (WebCore::Element::removedFromDocument):
  18416. (WebCore::Element::insertedIntoTree):
  18417. (WebCore::Element::removedFromTree):
  18418. (WebCore::Element::attach):
  18419. (WebCore::Element::detach):
  18420. (WebCore::Element::recalcStyle):
  18421. (WebCore::Element::shadowRoot):
  18422. (WebCore::Element::ensureShadowRoot):
  18423. (WebCore::Element::childrenChanged):
  18424. * dom/Node.cpp:
  18425. (WebCore::Node::setTreeScopeRecursively):
  18426. (WebCore::shadowRoot):
  18427. (WebCore::Node::setDocumentRecursively):
  18428. (WebCore::NodeRendererFactory::findVisualParent):
  18429. Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
  18430. previous classes.
  18431. * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
  18432. * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
  18433. * html/HTMLDetailsElement.cpp:
  18434. * html/HTMLSummaryElement.cpp:
  18435. Added #include for ShadowRoot.h.
  18436. 2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  18437. Reviewed by Kenneth Rohde Christiansen.
  18438. [EFL] Implement mediaSliderTrack
  18439. https://bugs.webkit.org/show_bug.cgi?id=59998
  18440. Implement paintMediaSliderTrack.
  18441. * platform/efl/RenderThemeEfl.cpp:
  18442. (WebCore::RenderThemeEfl::RenderThemeEfl):
  18443. (WebCore::RenderThemeEfl::paintMediaSliderTrack):
  18444. * platform/efl/RenderThemeEfl.h:
  18445. 2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
  18446. Reviewed by Pavel Feldman.
  18447. WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
  18448. https://bugs.webkit.org/show_bug.cgi?id=60023
  18449. * inspector/front-end/DetailedHeapshotGridNodes.js:
  18450. (WebInspector.HeapSnapshotConstructorNode):
  18451. (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  18452. * inspector/front-end/HeapSnapshot.js:
  18453. (WebInspector.HeapSnapshot.prototype.dispose):
  18454. (WebInspector.HeapSnapshot.prototype.aggregates):
  18455. (WebInspector.HeapSnapshot.prototype._buildAggregates):
  18456. (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
  18457. (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
  18458. (WebInspector.HeapSnapshotFilteredOrderedIterator):
  18459. (WebInspector.HeapSnapshotNodesProvider):
  18460. * inspector/front-end/HeapSnapshotProxy.js:
  18461. (WebInspector.HeapSnapshotProxy.prototype.aggregates):
  18462. (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
  18463. 2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
  18464. Reviewed by Pavel Feldman.
  18465. WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
  18466. https://bugs.webkit.org/show_bug.cgi?id=60029
  18467. * English.lproj/localizedStrings.js:
  18468. * inspector/front-end/DetailedHeapshotView.js:
  18469. (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
  18470. (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
  18471. 2011-05-03 Beth Dakin <bdakin@apple.com>
  18472. Reviewed by Dan Bernstein.
  18473. https://bugs.webkit.org/show_bug.cgi?id=60045
  18474. Scrollbar thumb sometimes leaves artifacts in the track after scrolling
  18475. -and corresponding-
  18476. <rdar://problem/9015376>
  18477. When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
  18478. always be ignored.
  18479. * platform/mac/ScrollbarThemeMac.mm:
  18480. (WebCore::updateArrowPlacement):
  18481. 2011-05-03 David Hyatt <hyatt@apple.com>
  18482. Reviewed by Dan Bernstein.
  18483. https://bugs.webkit.org/show_bug.cgi?id=60040
  18484. <rdar://problem/9261591>
  18485. Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
  18486. a translation of a 0,0 point to absolute coordinates so that the top left position is
  18487. accurate.
  18488. Added fast/inline/skipped-whitespace-client-rect.html
  18489. * rendering/RenderInline.cpp:
  18490. (WebCore::RenderInline::culledInlineAbsoluteQuads):
  18491. 2011-05-03 Sam Weinig <sam@webkit.org>
  18492. Fix chromium build.
  18493. * page/Settings.cpp:
  18494. 2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
  18495. Reviewed by Dimitri Glazkov.
  18496. Bug 59974 - Update image map on the containing TreeScope rather than the Document
  18497. https://bugs.webkit.org/show_bug.cgi?id=59974
  18498. No new tests. (reefactoring)
  18499. * html/HTMLMapElement.cpp:
  18500. (WebCore::HTMLMapElement::parseMappedAttribute):
  18501. (WebCore::HTMLMapElement::insertedIntoDocument):
  18502. (WebCore::HTMLMapElement::removedFromDocument):
  18503. * rendering/RenderImage.cpp:
  18504. (WebCore::RenderImage::imageMap):
  18505. 2011-05-03 Sam Weinig <sam@webkit.org>
  18506. Fix chromium build.
  18507. * loader/HistoryController.cpp:
  18508. 2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
  18509. Reviewed by Dimitri Glazkov.
  18510. Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
  18511. https://bugs.webkit.org/show_bug.cgi?id=59966
  18512. No new tests. (refactoring)
  18513. * accessibility/AccessibilityRenderObject.cpp:
  18514. (WebCore::AccessibilityRenderObject::elementsFromAttribute):
  18515. (WebCore::AccessibilityRenderObject::activeDescendant):
  18516. * accessibility/AccessibilityRenderObject.h:
  18517. (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  18518. * css/CSSCursorImageValue.cpp:
  18519. (WebCore::resourceReferencedByCursorElement):
  18520. (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  18521. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  18522. (WebCore::CSSCursorImageValue::cachedImage):
  18523. * dom/DynamicNodeList.cpp:
  18524. (WebCore::DynamicNodeList::itemWithName):
  18525. * dom/Element.h:
  18526. (WebCore::Element::updateId):
  18527. * dom/Node.cpp:
  18528. (WebCore::Node::querySelector):
  18529. * html/FormAssociatedElement.cpp:
  18530. (WebCore::FormAssociatedElement::insertedIntoTree):
  18531. (WebCore::FormAssociatedElement::resetFormOwner):
  18532. * html/HTMLInputElement.cpp:
  18533. (WebCore::HTMLInputElement::dataList):
  18534. * html/HTMLLabelElement.cpp:
  18535. (WebCore::HTMLLabelElement::control):
  18536. * rendering/svg/RenderSVGTextPath.cpp:
  18537. (WebCore::RenderSVGTextPath::layoutPath):
  18538. * svg/SVGAElement.cpp:
  18539. (WebCore::SVGAElement::defaultEventHandler):
  18540. * svg/SVGAltGlyphElement.cpp:
  18541. (WebCore::SVGAltGlyphElement::glyphElement):
  18542. * svg/SVGFEImageElement.cpp:
  18543. (WebCore::SVGFEImageElement::requestImageResource):
  18544. (WebCore::SVGFEImageElement::build):
  18545. * svg/SVGLinearGradientElement.cpp:
  18546. (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  18547. * svg/SVGMPathElement.cpp:
  18548. (WebCore::SVGMPathElement::pathElement):
  18549. * svg/SVGPatternElement.cpp:
  18550. (WebCore::SVGPatternElement::collectPatternAttributes):
  18551. * svg/SVGRadialGradientElement.cpp:
  18552. (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  18553. * svg/SVGSVGElement.cpp:
  18554. (WebCore::SVGSVGElement::getElementById):
  18555. * svg/SVGTRefElement.cpp:
  18556. (WebCore::SVGTRefElement::updateReferencedText):
  18557. * svg/SVGTextPathElement.cpp:
  18558. (WebCore::SVGTextPathElement::insertedIntoDocument):
  18559. * svg/SVGUseElement.cpp:
  18560. (WebCore::SVGUseElement::buildPendingResource):
  18561. (WebCore::SVGUseElement::hasCycleUseReferencing):
  18562. (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  18563. * svg/SVGViewSpec.cpp:
  18564. (WebCore::SVGViewSpec::viewTarget):
  18565. * svg/animation/SVGSMILElement.cpp:
  18566. (WebCore::SVGSMILElement::eventBaseFor):
  18567. (WebCore::SVGSMILElement::connectConditions):
  18568. (WebCore::SVGSMILElement::targetElement):
  18569. * xml/XPathFunctions.cpp:
  18570. (WebCore::XPath::FunId::evaluate):
  18571. 2011-05-03 Sam Weinig <sam@webkit.org>
  18572. Fix chromium build.
  18573. * css/StyleMedia.cpp:
  18574. 2011-05-03 Sam Weinig <sam@webkit.org>
  18575. Reviewed by Anders Carlsson.
  18576. Prune #includes from FrameView.h (Part 1)
  18577. https://bugs.webkit.org/show_bug.cgi?id=59957
  18578. * page/FrameView.h:
  18579. Prune #includes.
  18580. * accessibility/chromium/AXObjectCacheChromium.cpp:
  18581. * page/win/FrameCGWin.cpp:
  18582. * platform/Scrollbar.cpp:
  18583. Add not necessary #includes.
  18584. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  18585. Add now necessary forward declaration.
  18586. 2011-05-03 Andrey Kosyakov <caseq@chromium.org>
  18587. Reviewed by Dimitri Glazkov.
  18588. [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
  18589. https://bugs.webkit.org/show_bug.cgi?id=60026
  18590. Return a wrapper for Node in toV8(Node*) when called with a node of type
  18591. SHADOW_ROOT_NODE instead of entering infinite recursion.
  18592. * bindings/v8/custom/V8NodeCustom.cpp:
  18593. (WebCore::toV8Slow):
  18594. 2011-05-02 Adam Roben <aroben@apple.com>
  18595. Take advantage of implicit conversion from nullptr_t to PassOwnPtr
  18596. Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
  18597. doesn't work, but should
  18598. Reviewed by Adam Barth.
  18599. * bindings/js/ScheduledAction.cpp:
  18600. * css/CSSStyleSelector.cpp:
  18601. * css/MediaList.cpp:
  18602. * css/MediaQueryMatcher.cpp:
  18603. * css/SVGCSSStyleSelector.cpp:
  18604. * dom/MessagePort.cpp:
  18605. * html/InputType.cpp:
  18606. * html/canvas/WebGLRenderingContext.cpp:
  18607. * inspector/InspectorStyleSheet.cpp:
  18608. * page/ContextMenuController.cpp:
  18609. * page/Page.cpp:
  18610. * platform/PlatformGestureRecognizer.cpp:
  18611. * platform/PurgeableBuffer.h:
  18612. * platform/graphics/ImageBuffer.h:
  18613. * platform/leveldb/LevelDBDatabase.cpp:
  18614. * platform/mac/PurgeableBufferMac.cpp:
  18615. * platform/text/RegularExpression.cpp:
  18616. * rendering/RenderTheme.cpp:
  18617. * rendering/RenderThemeMac.mm:
  18618. * rendering/style/RenderStyle.h:
  18619. * rendering/style/SVGRenderStyleDefs.cpp:
  18620. * rendering/style/ShadowData.cpp:
  18621. * rendering/style/StyleRareInheritedData.cpp:
  18622. * rendering/style/StyleRareNonInheritedData.cpp:
  18623. * rendering/svg/RenderSVGResourcePattern.cpp:
  18624. 2011-05-03 Pavel Feldman <pfeldman@google.com>
  18625. Not reviewed: fix inspector status bar image glyph reference in network panel.
  18626. * inspector/front-end/networkPanel.css:
  18627. (.network-larger-resources-status-bar-item .glyph):
  18628. 2011-05-03 Pavel Feldman <pfeldman@google.com>
  18629. Reviewed by Yury Semikhatsky.
  18630. Web Inspector: rename BrowserDebugger agent to DOMDebugger.
  18631. https://bugs.webkit.org/show_bug.cgi?id=60019
  18632. * inspector/CodeGeneratorInspector.pm:
  18633. * inspector/Inspector.json:
  18634. * inspector/InspectorController.cpp:
  18635. (WebCore::InspectorController::connectFrontend):
  18636. * inspector/front-end/BreakpointsSidebarPane.js:
  18637. (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
  18638. (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
  18639. (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
  18640. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
  18641. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  18642. * inspector/generate-inspector-idl:
  18643. 2011-05-03 Yury Semikhatsky <yurys@chromium.org>
  18644. Reviewed by Pavel Feldman.
  18645. Web Inspector: remove special logic for type of document.__proto__
  18646. https://bugs.webkit.org/show_bug.cgi?id=60014
  18647. Test: inspector/console/console-log-document-proto.html
  18648. * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
  18649. 2011-05-03 Pavel Feldman <pfeldman@google.com>
  18650. Not reviewed: fixed typo in inspector style.
  18651. * inspector/front-end/inspector.css:
  18652. (.status-bar-item > .glyph):
  18653. 2011-05-03 Pavel Feldman <pfeldman@chromium.org>
  18654. Reviewed by Yury Semikhatsky.
  18655. Web Inspector: revision history storage is too slow.
  18656. https://bugs.webkit.org/show_bug.cgi?id=59939
  18657. It turns out that iterating localStorage keys is very
  18658. expensive (results in slow inspector start), refactor revision
  18659. history in order not to rely upon that operation.
  18660. * inspector/front-end/Resource.js:
  18661. (WebInspector.Resource):
  18662. (WebInspector.Resource._resourceRevisionRegistry):
  18663. (WebInspector.Resource.restoreRevisions.persist):
  18664. (WebInspector.Resource.restoreRevisions):
  18665. (WebInspector.Resource.persistRevision):
  18666. (WebInspector.Resource.prototype._persistRevision):
  18667. * inspector/front-end/ResourceTreeModel.js:
  18668. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  18669. (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  18670. 2011-05-03 Pavel Feldman <pfeldman@chromium.org>
  18671. Reviewed by Yury Semikhatsky.
  18672. Web Inspector: combine toolbar icon images.
  18673. https://bugs.webkit.org/show_bug.cgi?id=59931
  18674. * WebCore.gypi:
  18675. * inspector/front-end/Images/auditsIcon.png: Removed.
  18676. * inspector/front-end/Images/consoleIcon.png: Removed.
  18677. * inspector/front-end/Images/elementsIcon.png: Removed.
  18678. * inspector/front-end/Images/networkIcon.png: Removed.
  18679. * inspector/front-end/Images/profilesIcon.png: Removed.
  18680. * inspector/front-end/Images/resourcesIcon.png: Removed.
  18681. * inspector/front-end/Images/scriptsIcon.png: Removed.
  18682. * inspector/front-end/Images/timelineIcon.png: Removed.
  18683. * inspector/front-end/Images/toolbarIcons.png: Added.
  18684. * inspector/front-end/Images/toolbarIconsSmall.png: Added.
  18685. * inspector/front-end/WebKit.qrc:
  18686. * inspector/front-end/inspector.css:
  18687. (.toolbar-icon):
  18688. (#toolbar-dropdown .toolbar-icon):
  18689. (.toolbar-item:active .toolbar-icon):
  18690. (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
  18691. (.toolbar-item.elements .toolbar-icon):
  18692. (.toolbar-item.resources .toolbar-icon):
  18693. (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
  18694. (.toolbar-item.network .toolbar-icon):
  18695. (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
  18696. (.toolbar-item.scripts .toolbar-icon):
  18697. (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
  18698. (.toolbar-item.timeline .toolbar-icon):
  18699. (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
  18700. (.toolbar-item.profiles .toolbar-icon):
  18701. (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
  18702. (.toolbar-item.audits .toolbar-icon):
  18703. (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
  18704. (.toolbar-item.console .toolbar-icon):
  18705. (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
  18706. (.status-bar-item > .glyph):
  18707. 2011-05-03 Pavel Feldman <pfeldman@chromium.org>
  18708. Reviewed by Yury Semikhatsky.
  18709. Web Inspector: combine status bar button glyphs.
  18710. https://bugs.webkit.org/show_bug.cgi?id=59885
  18711. * WebCore.gypi:
  18712. * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
  18713. * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
  18714. * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
  18715. * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
  18716. * inspector/front-end/Images/dockButtonGlyph.png: Removed.
  18717. * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
  18718. * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
  18719. * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
  18720. * inspector/front-end/Images/focusButtonGlyph.png: Removed.
  18721. * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
  18722. * inspector/front-end/Images/gearButtonGlyph.png: Removed.
  18723. * inspector/front-end/Images/helpButtonGlyph.png: Removed.
  18724. * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
  18725. * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
  18726. * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
  18727. * inspector/front-end/Images/percentButtonGlyph.png: Removed.
  18728. * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
  18729. * inspector/front-end/Images/recordButtonGlyph.png: Removed.
  18730. * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
  18731. * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
  18732. * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
  18733. * inspector/front-end/Images/undockButtonGlyph.png: Removed.
  18734. * inspector/front-end/WebKit.qrc:
  18735. * inspector/front-end/inspector.css:
  18736. (.status-bar-item > .glyph):
  18737. (#dock-status-bar-item .glyph):
  18738. (body.detached #dock-status-bar-item .glyph):
  18739. (#console-status-bar-item .glyph):
  18740. (.clear-status-bar-item .glyph):
  18741. (button.enable-toggle-status-bar-item .glyph):
  18742. (button.enable-toggle-status-bar-item.toggled-on .glyph):
  18743. (.scripts-pause-on-exceptions-status-bar-item .glyph):
  18744. (.scripts-toggle-pretty-print-status-bar-item .glyph):
  18745. (.toggle-breakpoints .glyph):
  18746. (.toggle-breakpoints.toggled-on .glyph):
  18747. (.resources-larger-resources-status-bar-item .glyph):
  18748. (.timeline-filter-status-bar-item .glyph):
  18749. (.garbage-collect-status-bar-item .glyph):
  18750. (.record-profile-status-bar-item .glyph):
  18751. (.record-profile-status-bar-item.toggled-on .glyph):
  18752. (.heap-snapshot-status-bar-item .glyph):
  18753. (.node-search-status-bar-item .glyph):
  18754. (.percent-time-status-bar-item .glyph):
  18755. (.focus-profile-node-status-bar-item .glyph):
  18756. (.exclude-profile-node-status-bar-item .glyph):
  18757. (.reset-profile-status-bar-item .glyph):
  18758. (.delete-storage-status-bar-item .glyph):
  18759. (.refresh-storage-status-bar-item .glyph):
  18760. * inspector/front-end/inspector.js:
  18761. 2011-05-02 Simon Fraser <simon.fraser@apple.com>
  18762. Reviewed by Dan Bernstein.
  18763. Possible crash when removing elements with reflections
  18764. https://bugs.webkit.org/show_bug.cgi?id=60009
  18765. RenderLayer's destructor deleted its z-order list Vector pointers
  18766. before removing the reflection layer. However, the reflection cleanup
  18767. code could call back into the RenderLayer to dirty z-order lists,
  18768. so move reflection cleanup to before z-order vector deletion.
  18769. The test crashes when run manually a few times with MallocScribble enabled,
  18770. but I was not able to create a test that crashed reliably.
  18771. Test: fast/reflections/remove-reflection-crash.html
  18772. * rendering/RenderLayer.cpp:
  18773. (WebCore::RenderLayer::~RenderLayer):
  18774. 2011-05-02 Ian Henderson <ianh@apple.com>
  18775. Reviewed by Dan Bernstein.
  18776. CSS !important not respected by JavaScript
  18777. https://bugs.webkit.org/show_bug.cgi?id=60007
  18778. The addParsedProperty and addParsedProperties methods were subtly
  18779. different. The former did not check for !important before setting the
  18780. given property.
  18781. Change addParsedProperties to call addParsedProperty and move the
  18782. relevant code. The one other caller of this method, in
  18783. editing/markup.cpp, probably wanted this behavior anyway.
  18784. Test: fast/css/important-js-override.html
  18785. * css/CSSMutableStyleDeclaration.cpp:
  18786. (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
  18787. (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
  18788. 2011-05-02 Ben Wells <benwells@chromium.org>
  18789. Reviewed by Simon Fraser.
  18790. Cleanup variable usage in RenderObject.cpp paintOutline()
  18791. https://bugs.webkit.org/show_bug.cgi?id=59911
  18792. No new tests for this, there should be no change in behaviour.
  18793. * rendering/RenderObject.cpp:
  18794. (WebCore::RenderObject::paintOutline):
  18795. 2011-05-02 Ryosuke Niwa <rniwa@webkit.org>
  18796. Reviewed by James Robinson.
  18797. REGRESSION(r84672): showTree doesn't work for input/textarea elements
  18798. https://bugs.webkit.org/show_bug.cgi?id=60001
  18799. When shadow is null, try retrieving the inner element of a render text control.
  18800. * dom/Node.cpp:
  18801. (WebCore::traverseTreeAndMark):
  18802. 2011-05-02 Joseph Pecoraro <joepeck@webkit.org>
  18803. Reviewed by David Kilzer.
  18804. Respect fixed text-indent on ::-webkit-input-placeholder
  18805. https://bugs.webkit.org/show_bug.cgi?id=59825
  18806. Test: fast/forms/input-placeholder-text-indent.html
  18807. * rendering/RenderTextControl.cpp:
  18808. (WebCore::RenderTextControl::paintPlaceholder): indent by
  18809. a fixed text-indent size specified on the placeholder style.
  18810. 2011-05-02 Eric Uhrhane <ericu@chromium.org>
  18811. Reviewed by Eric Seidel.
  18812. Some FileWriter progress events should be queued
  18813. https://bugs.webkit.org/show_bug.cgi?id=50846
  18814. * fileapi/FileWriter.cpp:
  18815. * fileapi/FileWriter.h:
  18816. Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
  18817. 2011-05-02 Jia Pu <jpu@apple.com>
  18818. Reviewed by Alexey Proskuryakov.
  18819. [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
  18820. https://bugs.webkit.org/show_bug.cgi?id=59836
  18821. <rdar://problem/9275983>
  18822. * platform/DefaultLocalizationStrategy.cpp:
  18823. (WebCore::truncatedStringForLookupMenuItem):
  18824. (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
  18825. 2011-05-02 Brady Eidson <beidson@apple.com>
  18826. Reviewed by Anders Carlsson.
  18827. <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
  18828. In Aperture, a WebView might be dealloc'ed before it finishes loading.
  18829. * WebCore.exp.in:
  18830. * platform/RuntimeApplicationChecks.cpp:
  18831. (WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
  18832. * platform/RuntimeApplicationChecks.h:
  18833. 2011-05-02 Simon Fraser <simon.fraser@apple.com>
  18834. Reviewed by Dan Bernstein.
  18835. Avoid wasted cycles updating paths when popping the context stack
  18836. https://bugs.webkit.org/show_bug.cgi?id=59967
  18837. CanvasRenderingContext2D has to map the current path through
  18838. transforms whenever the context stack is popped, which creates
  18839. a lot of platform path objects. Avoid extra work here when the
  18840. path is empty, or when the transform is identity.
  18841. * platform/graphics/cg/PathCG.cpp:
  18842. (WebCore::Path::transform):
  18843. 2011-05-02 Enrica Casucci <enrica@apple.com>
  18844. Reviewed by Dan Bernstein.
  18845. Text does not split on white space when typing to the edge of window.
  18846. https://bugs.webkit.org/show_bug.cgi?id=59968
  18847. <rdar://problem/9112683>
  18848. Test: editing/inserting/typing-at-end-of-line.html
  18849. This is a regression introduced when we converted the line box tree to
  18850. floating point in r78846. In findNextLineBreak, there was still one place where
  18851. the character width was treated as int and truncated and we were inconsistent
  18852. in the way we treated a character that did not fit entirely in the line.
  18853. * rendering/RenderBlockLineLayout.cpp:
  18854. (WebCore::RenderBlock::findNextLineBreak):
  18855. 2011-04-19 Adrienne Walker <enne@google.com>
  18856. Reviewed by James Robinson.
  18857. [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
  18858. https://bugs.webkit.org/show_bug.cgi?id=58907
  18859. Additionally, move the context save/restore logic to a place where it
  18860. will reset the translation added in LayerTilerChromium.
  18861. Test: compositing/repaint/same-size-invalidation.html
  18862. * platform/graphics/chromium/ContentLayerChromium.cpp:
  18863. (WebCore::ContentLayerPainter::paint):
  18864. * platform/graphics/chromium/PlatformCanvas.cpp:
  18865. (WebCore::PlatformCanvas::resize):
  18866. (WebCore::PlatformCanvas::Painter::Painter):
  18867. (WebCore::PlatformCanvas::Painter::~Painter):
  18868. * platform/graphics/chromium/PlatformCanvas.h:
  18869. 2011-05-02 Csaba Osztrogonác <ossy@webkit.org>
  18870. Enable strict OwnPtr for Qt
  18871. https://bugs.webkit.org/show_bug.cgi?id=59667
  18872. Unreviewed buildfix after r85343.
  18873. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  18874. (WebCore::GraphicsContext3D::GraphicsContext3D):
  18875. 2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
  18876. Unreviewed, rolling out r85483.
  18877. http://trac.webkit.org/changeset/85483
  18878. https://bugs.webkit.org/show_bug.cgi?id=59958
  18879. Causes media test failures. (Requested by eric_carlson on
  18880. #webkit).
  18881. * html/HTMLMediaElement.cpp:
  18882. (WebCore::HTMLMediaElement::HTMLMediaElement):
  18883. (WebCore::HTMLMediaElement::prepareForLoad):
  18884. (WebCore::HTMLMediaElement::seek):
  18885. (WebCore::HTMLMediaElement::updatePlayState):
  18886. * html/HTMLMediaElement.h:
  18887. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  18888. (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
  18889. (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
  18890. (WebCore::MediaPlayerPrivateAVFoundation::load):
  18891. (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
  18892. (WebCore::MediaPlayerPrivateAVFoundation::paint):
  18893. (WebCore::MediaPlayerPrivateAVFoundation::duration):
  18894. (WebCore::MediaPlayerPrivateAVFoundation::seeking):
  18895. (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
  18896. (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
  18897. (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
  18898. (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
  18899. (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
  18900. (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
  18901. (WebCore::MediaPlayerPrivateAVFoundation::repaint):
  18902. (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
  18903. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  18904. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  18905. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  18906. (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
  18907. (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
  18908. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
  18909. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
  18910. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
  18911. (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
  18912. (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
  18913. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
  18914. (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
  18915. (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
  18916. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
  18917. (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
  18918. 2011-05-02 Adam Barth <abarth@webkit.org>
  18919. Reviewed by David Levin.
  18920. PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
  18921. https://bugs.webkit.org/show_bug.cgi?id=59924
  18922. * css/CSSGrammar.y:
  18923. * platform/graphics/mac/SimpleFontDataMac.mm:
  18924. - Memory management for the font cache is somewhat... complext.
  18925. This will require some careful thought to sort out.
  18926. 2011-05-02 Levi Weintraub <leviw@chromium.org>
  18927. Reviewed by Eric Seidel.
  18928. showLineTree/showLineTreeForThis would make working with the line box tree easier
  18929. https://bugs.webkit.org/show_bug.cgi?id=59662
  18930. Adding a showLineTree/showLineTreeForThis method to help visualize and debug
  18931. the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
  18932. No new tests since this is a debugging feature only and not compiled in release.
  18933. * rendering/InlineBox.cpp:
  18934. (WebCore::InlineBox::showLineTreeForThis):
  18935. (WebCore::InlineBox::showLineTreeAndMark):
  18936. (WebCore::InlineBox::showBox):
  18937. (showLineTree):
  18938. * rendering/InlineBox.h:
  18939. * rendering/InlineFlowBox.cpp:
  18940. (WebCore::InlineFlowBox::showLineTreeAndMark):
  18941. * rendering/InlineFlowBox.h:
  18942. * rendering/InlineTextBox.cpp:
  18943. (WebCore::InlineTextBox::showBox):
  18944. * rendering/InlineTextBox.h:
  18945. * rendering/RenderBlock.cpp:
  18946. (WebCore::RenderBlock::showLineTreeAndMark):
  18947. * rendering/RenderBlock.h:
  18948. * rendering/RenderObject.cpp:
  18949. (WebCore::RenderObject::showRenderTreeForThis):
  18950. (WebCore::RenderObject::showLineTreeForThis):
  18951. (showTree):
  18952. (showLineTree):
  18953. * rendering/RenderObject.h:
  18954. 2011-05-02 Dimitri Glazkov <dglazkov@chromium.org>
  18955. Reviewed by Eric Carlson.
  18956. REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
  18957. https://bugs.webkit.org/show_bug.cgi?id=59917
  18958. Since default event handlers are not retargeted, we should always attempt ancestor
  18959. traversal to find out whether the event.
  18960. * html/MediaDocument.cpp:
  18961. (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
  18962. (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
  18963. 2011-05-02 Sam Weinig <sam@webkit.org>
  18964. Attempt to fix the Leopard build.
  18965. * platform/graphics/FontPlatformData.h:
  18966. * platform/graphics/mac/ComplexTextController.h:
  18967. * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  18968. * platform/mac/WebCoreSystemInterface.h:
  18969. 2011-05-02 Tony Chang <tony@chromium.org>
  18970. Reviewed by Kent Tamura.
  18971. convert manual-tests/bugzilla-6821.html to a layout test
  18972. https://bugs.webkit.org/show_bug.cgi?id=59404
  18973. Test: fast/css/hover-update.html
  18974. * manual-tests/bugzilla-6821.html: Removed.
  18975. 2011-05-02 Sam Weinig <sam@webkit.org>
  18976. Reviewed by Anders Carlsson.
  18977. Prune ApplicationServices.h out of the headers
  18978. https://bugs.webkit.org/show_bug.cgi?id=59952
  18979. More forward declares are better.
  18980. * html/canvas/CanvasRenderingContext2D.cpp:
  18981. * html/canvas/CanvasRenderingContext2D.h:
  18982. * platform/graphics/GlyphBuffer.h:
  18983. * platform/graphics/cg/ImageBufferCG.cpp:
  18984. * platform/graphics/cg/PDFDocumentImage.cpp:
  18985. * platform/graphics/cg/PDFDocumentImage.h:
  18986. * platform/graphics/mac/ComplexTextController.h:
  18987. * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  18988. * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  18989. * platform/mac/ScrollAnimatorMac.h:
  18990. * platform/mac/ScrollAnimatorMac.mm:
  18991. * platform/mac/ScrollbarThemeMac.h:
  18992. * platform/mac/ScrollbarThemeMac.mm:
  18993. * platform/mac/WebCoreNSStringExtras.h:
  18994. * platform/mac/WebCoreSystemInterface.h:
  18995. 2011-05-02 Dan Bernstein <mitz@apple.com>
  18996. Reviewed by Simon Fraser.
  18997. <rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
  18998. https://bugs.webkit.org/show_bug.cgi?id=58006
  18999. * rendering/RenderBox.cpp:
  19000. (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
  19001. <http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
  19002. table cell as the immediate containing block, but any case where all containing block ancestors
  19003. up to and including a table cell are auto-or-percent height.
  19004. 2011-05-02 Daniel Bates <dbates@webkit.org>
  19005. Reviewed by Sam Weinig.
  19006. Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
  19007. https://bugs.webkit.org/show_bug.cgi?id=59379
  19008. Move manual test onblur-remove.html to LayoutTests/fast/events.
  19009. Test: fast/events/onblur-remove.html
  19010. * manual-tests/onblur-remove.html: Removed.
  19011. 2011-05-02 Sailesh Agrawal <sail@chromium.org>
  19012. Reviewed by Dimitri Glazkov.
  19013. Chromium Mac: Add scrollbar overlay drawing functions
  19014. https://bugs.webkit.org/show_bug.cgi?id=59741
  19015. These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
  19016. No new tests, since this code is only enabled on future versions of Mac OS X.
  19017. * WebCore.gypi:
  19018. * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
  19019. * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
  19020. (LookUpNSScrollerImpClass):
  19021. (LookUpNSScrollerImpPairClass):
  19022. (ScrollbarControlSizeToNSControlSize):
  19023. (wkScrollbarPainterUsesOverlayScrollers):
  19024. (wkScrollbarPainterIsHorizontal):
  19025. (wkScrollbarPainterKnobAlpha):
  19026. (wkScrollbarPainterSetOverlayState):
  19027. (wkScrollbarPainterPaint):
  19028. (wkScrollbarMinimumThumbLength):
  19029. (wkScrollbarPainterSetDelegate):
  19030. (wkScrollbarPainterTrackAlpha):
  19031. (wkMakeScrollbarPainter):
  19032. (wkScrollbarThickness):
  19033. (wkScrollbarMinimumTotalLengthNeededForThumb):
  19034. (wkVerticalScrollbarPainterForController):
  19035. (wkHorizontalScrollbarPainterForController):
  19036. (wkMakeScrollbarReplacementPainter):
  19037. (wkSetPainterForPainterController):
  19038. (wkSetScrollbarPainterControllerStyle):
  19039. (wkScrollbarPainterKnobRect):
  19040. (wkSetScrollbarPainterKnobAlpha):
  19041. (wkSetScrollbarPainterTrackAlpha):
  19042. (wkSetScrollbarPainterKnobStyle):
  19043. (wkMakeScrollbarPainterController):
  19044. (wkContentAreaScrolled):
  19045. (wkContentAreaWillPaint):
  19046. (wkMouseEnteredContentArea):
  19047. (wkMouseExitedContentArea):
  19048. (wkMouseMovedInContentArea):
  19049. (wkWillStartLiveResize):
  19050. (wkContentAreaResized):
  19051. (wkWillEndLiveResize):
  19052. (wkContentAreaDidShow):
  19053. (wkContentAreaDidHide):
  19054. (wkDidBeginScrollGesture):
  19055. (wkDidEndScrollGesture):
  19056. (wkScrollbarPainterForceFlashScrollers):
  19057. (IsScrollbarOverlayAPIAvailable):
  19058. 2011-05-02 Luke Macpherson <macpherson@chromium.org>
  19059. Reviewed by Dimitri Glazkov.
  19060. Implement Length based CSS properties in CSSStyleApplyProperty
  19061. https://bugs.webkit.org/show_bug.cgi?id=59314
  19062. No new tests as no functionality changed.
  19063. * css/CSSStyleApplyProperty.cpp:
  19064. (WebCore::ApplyPropertyLength::ApplyPropertyLength):
  19065. Added this class to handle all length types.
  19066. Property specific behavior is handled through set of boolean parameters.
  19067. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  19068. Added calls to set up entries for the newly added length properties.
  19069. * css/CSSStyleSelector.cpp:
  19070. (WebCore::CSSStyleSelector::applyProperty):
  19071. Remove property implementations mow implemented in CSSStyleApplyProperty.
  19072. * css/CSSStyleSelector.h:
  19073. (WebCore::CSSStyleSelector::rootElementStyle):
  19074. Expose m_rootElementStyle via getter.
  19075. 2011-05-02 Eric Carlson <eric.carlson@apple.com>
  19076. Reviewed by Eric Seidel.
  19077. HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
  19078. https://bugs.webkit.org/show_bug.cgi?id=59828
  19079. No new tests required, no functional change because seeking to time zero before playback
  19080. begins has no effect.
  19081. * html/HTMLMediaElement.cpp:
  19082. (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
  19083. HAVE_METADATA.
  19084. 2011-05-02 Sam Weinig <sam@webkit.org>
  19085. Reviewed by Gavin Barraclough.
  19086. Fix extra whitespace in license in FocusDirection.h.
  19087. * page/FocusDirection.h:
  19088. 2011-05-02 Sam Weinig <sam@webkit.org>
  19089. Reviewed by Adam Barth.
  19090. Prune some #includes from DOMWindow.h
  19091. https://bugs.webkit.org/show_bug.cgi?id=59907
  19092. * page/DOMWindow.cpp:
  19093. (WebCore::DOMWindow::setSecurityOrigin):
  19094. * page/DOMWindow.h:
  19095. Remove #includes of SecurityOrigin and MessagePort by forward declaring
  19096. and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
  19097. #include that was getting added by MessagePort.h.
  19098. * bindings/js/JSCustomVoidCallback.cpp:
  19099. * bindings/js/JSCustomXPathNSResolver.cpp:
  19100. * bindings/js/JSDOMWindowCustom.h:
  19101. * bindings/js/JSHistoryCustom.cpp:
  19102. * bindings/js/ScriptController.h:
  19103. * html/HTMLAnchorElement.cpp:
  19104. * html/HTMLMediaElement.cpp:
  19105. * html/parser/XSSFilter.cpp:
  19106. * inspector/InspectorDOMStorageResource.cpp:
  19107. * loader/MainResourceLoader.cpp:
  19108. * page/DragController.cpp:
  19109. * page/EventSource.cpp:
  19110. * page/Location.cpp:
  19111. * websockets/WebSocket.cpp:
  19112. * xml/XSLTProcessorLibxslt.cpp:
  19113. Add now missing SecurityOrigin.h #includes.
  19114. 2011-05-02 Eric Carlson <eric.carlson@apple.com>
  19115. Reviewed by Brady Eidson.
  19116. The preload attribute of the video tag is not completely implemented
  19117. https://bugs.webkit.org/show_bug.cgi?id=43673
  19118. <rdar://problem/7508322>
  19119. Tested manually with manual-tests/media-elements/video-preload.html.
  19120. * html/HTMLMediaElement.cpp:
  19121. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
  19122. (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
  19123. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
  19124. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
  19125. because we need to have media data loaded to seek.
  19126. (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
  19127. * html/HTMLMediaElement.h:
  19128. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  19129. (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove
  19130. m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
  19131. (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
  19132. (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
  19133. Move all preload logic to setPreload, call it from here.
  19134. (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
  19135. setPreload, call it.
  19136. (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
  19137. unlikely to be correct and isn't worth caching.
  19138. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
  19139. to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
  19140. 'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
  19141. a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
  19142. when the first frame is available.
  19143. (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
  19144. width, height, hasVideo, etc.
  19145. (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
  19146. in derived classes.
  19147. (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
  19148. AVAsset and AVPlayerItem here.
  19149. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  19150. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  19151. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  19152. (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
  19153. m_videoFrameHasDrawn.
  19154. (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
  19155. videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
  19156. if we have painted a frame to the context.
  19157. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
  19158. if necessary.
  19159. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
  19160. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
  19161. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
  19162. (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
  19163. (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
  19164. the buffer is full.
  19165. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
  19166. AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
  19167. when we only have metadata.
  19168. (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
  19169. (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
  19170. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
  19171. when when we haven't allocated the AVPlayerItem yet so that we can report attributes
  19172. when we only have metadata.
  19173. (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
  19174. we have allocated the AVPlayerItem.
  19175. 2011-05-02 Philippe Normand <pnormand@igalia.com>
  19176. Reviewed by Martin Robinson.
  19177. [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
  19178. https://bugs.webkit.org/show_bug.cgi?id=59932
  19179. Use gdk_window_get_width() and gdk_window_get_height() if
  19180. available, instead of the deprecated gdk_drawable_get_size().
  19181. No new tests, build fix only.
  19182. * platform/gtk/WidgetRenderingContext.cpp:
  19183. (WebCore::WidgetRenderingContext::WidgetRenderingContext):
  19184. 2011-05-02 Eric Carlson <eric.carlson@apple.com>
  19185. Reviewed by Brady Eidson.
  19186. The preload attribute of the video tag is not completely implemented
  19187. https://bugs.webkit.org/show_bug.cgi?id=43673
  19188. <rdar://problem/7508322>
  19189. Test manually with manual-tests/media-elements/video-preload.html.
  19190. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  19191. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  19192. (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
  19193. attribute when preload is not "auto".
  19194. (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
  19195. (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
  19196. (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
  19197. (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
  19198. a QTMovie.
  19199. 2011-05-02 Eric Carlson <eric.carlson@apple.com>
  19200. Reviewed by Brady Eidson.
  19201. The preload attribute of the video tag is not completely implemented
  19202. https://bugs.webkit.org/show_bug.cgi?id=43673
  19203. <rdar://problem/7508322>
  19204. Manual test manual-tests/media-elements/video-preload.html added.
  19205. * manual-tests/media-elements/video-preload.html: Added. New manual test for media element
  19206. 'preload' attribute because it is not possible to detect if a media engine supports
  19207. "preload=metadata" in a way that lets us have per-platform layout test results.
  19208. 2011-05-01 Abhishek Arya <inferno@chromium.org>
  19209. Reviewed by Eric Carlson.
  19210. Regression(r74787): Media document mouse click and double-click
  19211. events should be checked on target node only and not its descendants.
  19212. https://bugs.webkit.org/show_bug.cgi?id=59886
  19213. * html/MediaDocument.cpp:
  19214. (WebCore::MediaDocument::defaultEventHandler):
  19215. 2011-05-01 Adam Barth <abarth@webkit.org>
  19216. Reviewed by Eric Seidel.
  19217. Polish CSP host and port matching
  19218. https://bugs.webkit.org/show_bug.cgi?id=59899
  19219. Finish last two details of host and port matching. I don't think the
  19220. default port handling is testable with our current testing
  19221. infrastructure.
  19222. Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
  19223. http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
  19224. * page/ContentSecurityPolicy.cpp:
  19225. (WebCore::CSPSource::hostMatches):
  19226. (WebCore::CSPSource::portMatches):
  19227. 2011-05-01 Adam Barth <abarth@webkit.org>
  19228. Reviewed by Eric Seidel.
  19229. CSP default-src is missing
  19230. https://bugs.webkit.org/show_bug.cgi?id=58641
  19231. Add support for default-src. The default-src provides a default policy
  19232. for every directive that sends in "-src". If the more-specific
  19233. directive is present, it takes precedence. I also took this
  19234. opportunity to refactor the internals of ContentSecurityPolicy a bit to
  19235. reduce duplicate code.
  19236. Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
  19237. http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
  19238. http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
  19239. * page/ContentSecurityPolicy.cpp:
  19240. (WebCore::ContentSecurityPolicy::didReceiveHeader):
  19241. (WebCore::ContentSecurityPolicy::checkEval):
  19242. (WebCore::ContentSecurityPolicy::operativeDirective):
  19243. (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
  19244. (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
  19245. (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  19246. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  19247. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  19248. (WebCore::ContentSecurityPolicy::allowInlineScript):
  19249. (WebCore::ContentSecurityPolicy::allowInlineStyle):
  19250. (WebCore::ContentSecurityPolicy::allowEval):
  19251. (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  19252. (WebCore::ContentSecurityPolicy::allowObjectFromSource):
  19253. (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
  19254. (WebCore::ContentSecurityPolicy::allowImageFromSource):
  19255. (WebCore::ContentSecurityPolicy::allowStyleFromSource):
  19256. (WebCore::ContentSecurityPolicy::allowFontFromSource):
  19257. (WebCore::ContentSecurityPolicy::allowMediaFromSource):
  19258. (WebCore::ContentSecurityPolicy::addDirective):
  19259. * page/ContentSecurityPolicy.h:
  19260. 2011-05-01 Sam Weinig <sam@webkit.org>
  19261. Reviewed by Anders Carlsson.
  19262. Prune some unnecessary #includes
  19263. https://bugs.webkit.org/show_bug.cgi?id=59895
  19264. Start getting rid of unnecessary #includes and forward declares.
  19265. * bindings/js/JSDOMBinding.h:
  19266. * bindings/js/JSDOMWindowBase.h:
  19267. * bindings/js/JSDOMWindowShell.h:
  19268. * bindings/js/ScheduledAction.cpp:
  19269. * bindings/js/ScriptController.cpp:
  19270. * bindings/js/ScriptController.h:
  19271. * bindings/js/ScriptDebugServer.cpp:
  19272. * editing/Editor.h:
  19273. * inspector/InspectorClient.cpp:
  19274. * loader/FrameLoader.h:
  19275. * loader/NavigationScheduler.h:
  19276. * page/Console.cpp:
  19277. * xml/XMLTreeViewer.cpp:
  19278. * xml/XMLTreeViewer.h:
  19279. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19280. [WIN] Unreviewed buildfix after r85434.
  19281. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  19282. (WebCore::MediaPlayerPrivate::createLayerForMovie):
  19283. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19284. [WIN] Unreviewed buildfix after r85434.
  19285. * platform/graphics/win/QTMovieVisualContext.cpp:
  19286. (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
  19287. 2011-05-01 Justin Schuh <jschuh@chromium.org>
  19288. Reviewed by Adam Barth.
  19289. History::stateObjectAdded should check origin via SecurityOrigin::canRequest
  19290. https://bugs.webkit.org/show_bug.cgi?id=59840
  19291. Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
  19292. http/tests/navigation/replacestate-base-illegal.html
  19293. http/tests/navigation/replacestate-base-legal.html
  19294. * page/History.cpp:
  19295. (WebCore::History::stateObjectAdded):
  19296. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19297. [WIN] Unreviewed buildfix after r85434.
  19298. * platform/graphics/win/QTMovieVisualContext.cpp:
  19299. (QTMovieVisualContext::QTMovieVisualContext):
  19300. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19301. Reviewed by Adam Barth.
  19302. [WINCE] Fix OwnPtr strict issues
  19303. https://bugs.webkit.org/show_bug.cgi?id=59898
  19304. * page/wince/FrameWinCE.cpp:
  19305. (WebCore::imageFromSelection):
  19306. * platform/graphics/wince/FontPlatformData.cpp:
  19307. (WebCore::FixedSizeFontData::create):
  19308. (WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
  19309. (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
  19310. (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
  19311. * platform/graphics/wince/GraphicsContextWinCE.cpp:
  19312. (WebCore::GraphicsContext::strokeArc):
  19313. (WebCore::GraphicsContext::fillRect):
  19314. (WebCore::GraphicsContext::clip):
  19315. (WebCore::GraphicsContext::fillRoundedRect):
  19316. (WebCore::GraphicsContext::drawRoundCorner):
  19317. (WebCore::GraphicsContext::drawText):
  19318. * platform/graphics/wince/ImageBufferWinCE.cpp:
  19319. (WebCore::ImageBuffer::ImageBuffer):
  19320. * platform/graphics/wince/ImageWinCE.cpp:
  19321. (WebCore::BitmapImage::getHBITMAPOfSize):
  19322. * platform/graphics/wince/SharedBitmap.cpp:
  19323. (WebCore::SharedBitmap::SharedBitmap):
  19324. 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
  19325. Reviewed by Eric Seidel.
  19326. Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
  19327. https://bugs.webkit.org/show_bug.cgi?id=59837
  19328. Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
  19329. * WebCore.exp.in:
  19330. * page/EventHandler.h:
  19331. * page/mac/EventHandlerMac.mm:
  19332. 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
  19333. Reviewed by Eric Seidel.
  19334. Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
  19335. https://bugs.webkit.org/show_bug.cgi?id=59835
  19336. Moved currentKeyboardEvent.
  19337. * WebCore.exp.in:
  19338. * page/EventHandler.h:
  19339. * page/mac/EventHandlerMac.mm:
  19340. 2011-05-01 ojab <ojab@ojab.ru>
  19341. Reviewed by Eric Seidel.
  19342. Fix build with --disable-video --enable-fullscreen-api
  19343. https://bugs.webkit.org/show_bug.cgi?id=59698
  19344. * rendering/RenderTheme.h:
  19345. (WebCore::RenderTheme::extraFullScreenStyleSheet):
  19346. 2011-05-01 Jeff Timanus <twiz@chromium.org>
  19347. Reviewed by Eric Seidel.
  19348. Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
  19349. https://bugs.webkit.org/show_bug.cgi?id=59041
  19350. Test:css2.1/t140201-c533-bgimage-00-a.html
  19351. * platform/graphics/Image.cpp:
  19352. (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
  19353. * platform/graphics/skia/ImageSkia.cpp:
  19354. (WebCore::BitmapImage::checkForSolidColor):
  19355. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19356. Reviewed by Adam Barth.
  19357. Fix OwnPtr strict issues in windows build
  19358. https://bugs.webkit.org/show_bug.cgi?id=59878
  19359. * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  19360. (WebCore::getDirtyRects):
  19361. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  19362. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
  19363. * platform/graphics/win/WKCAImageQueue.cpp:
  19364. (WebCore::WKCAImageQueue::WKCAImageQueue):
  19365. * platform/win/CursorWin.cpp:
  19366. (WebCore::createSharedCursor):
  19367. * platform/win/PasteboardWin.cpp:
  19368. (WebCore::Pasteboard::writeImage):
  19369. 2011-05-01 Patrick Gansterer <paroga@webkit.org>
  19370. Reviewed by Eric Seidel.
  19371. Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
  19372. https://bugs.webkit.org/show_bug.cgi?id=59876
  19373. Also pass the size "as reference" instead of "as value".
  19374. * platform/graphics/GraphicsContext.h:
  19375. * platform/graphics/win/FontCGWin.cpp:
  19376. (WebCore::drawGDIGlyphs):
  19377. * platform/graphics/win/GraphicsContextWin.cpp:
  19378. (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
  19379. (WebCore::GraphicsContext::createWindowsBitmap):
  19380. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  19381. (WebCore::MediaPlayerPrivate::paint):
  19382. 2011-05-01 Emil A Eklund <eae@chromium.org>
  19383. Reviewed by Eric Seidel.
  19384. getComputedStyle() returns unitless values for some properties that require units
  19385. https://bugs.webkit.org/show_bug.cgi?id=55111
  19386. Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
  19387. Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
  19388. * css/CSSComputedStyleDeclaration.cpp:
  19389. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  19390. 2011-05-01 Young Han Lee <joybro@company100.net>
  19391. Reviewed by Eric Seidel.
  19392. Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
  19393. https://bugs.webkit.org/show_bug.cgi?id=59608
  19394. TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
  19395. No new functionality, no new tests.
  19396. * platform/graphics/opengl/TextureMapperGL.cpp:
  19397. (WebCore::TextureMapperGL::TextureMapperGL):
  19398. 2011-05-01 Yael Aharon <yael.aharon@nokia.com>
  19399. Reviewed by Eric Seidel.
  19400. CSS3 nth-child(n) selector fails
  19401. https://bugs.webkit.org/show_bug.cgi?id=56943
  19402. Regression from r75158.
  19403. "n" is a valid parameter to nth() and should be allowed.
  19404. Test: fast/css/nth-child-n.html
  19405. * css/CSSParser.cpp:
  19406. (WebCore::isValidNthToken):
  19407. 2011-05-01 Pavel Feldman <pfeldman@chromium.org>
  19408. Not reviewed: address stack frame scriptName -> url rename in timeline panel.
  19409. * inspector/front-end/TimelinePanel.js:
  19410. (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  19411. (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
  19412. 2011-05-01 Chris Fleizach <cfleizach@apple.com>
  19413. Reviewed by Maciej Stachowiak.
  19414. Crash in AccessibilityRenderObject while viewing PDFs in iframes
  19415. https://bugs.webkit.org/show_bug.cgi?id=59629
  19416. Could not reproduce this crash, but it's quite clear how it could happen.
  19417. * accessibility/AccessibilityRenderObject.cpp:
  19418. (WebCore::AccessibilityRenderObject::accessibilityHitTest):
  19419. 2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
  19420. Reviewed by Dirk Schulze.
  19421. LEAK: SVGElement leaks when detaching it in a pending resource state
  19422. https://bugs.webkit.org/show_bug.cgi?id=59072
  19423. Make the pending resources set non-refcounted again. We made it refcounted a while ago
  19424. to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
  19425. Fix the underlying problem, by removing all pending resources referencing to a particular
  19426. SVGElement, upon its destruction or upon removing it from the document.
  19427. Example: <rect fill="url(#foo)" id="rect">
  19428. When we try to render the rect, the foo paint server can't be found and thus "foo" will be
  19429. added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
  19430. itself from the pending resource set, and a ref count to the "rect" would be released.
  19431. If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
  19432. it and the associated document alive.
  19433. Tests: svg/custom/pending-resource-leak-2.svg
  19434. svg/custom/pending-resource-leak-3.svg
  19435. svg/custom/pending-resource-leak.svg
  19436. These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
  19437. I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
  19438. * rendering/svg/RenderSVGResourceContainer.cpp:
  19439. (WebCore::RenderSVGResourceContainer::registerResource):
  19440. * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
  19441. (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  19442. * rendering/svg/SVGResources.cpp:
  19443. (WebCore::registerPendingResource):
  19444. * svg/SVGDocumentExtensions.cpp:
  19445. (WebCore::SVGDocumentExtensions::addPendingResource):
  19446. (WebCore::SVGDocumentExtensions::hasPendingResources):
  19447. (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
  19448. (WebCore::SVGDocumentExtensions::removePendingResource):
  19449. * svg/SVGDocumentExtensions.h:
  19450. * svg/SVGElement.cpp:
  19451. * svg/SVGElement.h:
  19452. * svg/SVGElementRareData.h:
  19453. (WebCore::SVGElementRareData::SVGElementRareData):
  19454. (WebCore::SVGElementRareData::hasPendingResources):
  19455. (WebCore::SVGElementRareData::setHasPendingResources):
  19456. * svg/SVGStyledElement.cpp:
  19457. (WebCore::SVGStyledElement::~SVGStyledElement):
  19458. (WebCore::SVGStyledElement::insertedIntoDocument):
  19459. (WebCore::SVGStyledElement::removedFromDocument):
  19460. (WebCore::SVGStyledElement::hasPendingResources):
  19461. (WebCore::SVGStyledElement::setHasPendingResources):
  19462. * svg/SVGStyledElement.h:
  19463. (WebCore::SVGStyledElement::needsPendingResourceHandling):
  19464. (WebCore::SVGStyledElement::buildPendingResource):
  19465. * svg/SVGUseElement.cpp:
  19466. (WebCore::SVGUseElement::SVGUseElement):
  19467. (WebCore::SVGUseElement::insertedIntoDocument):
  19468. (WebCore::SVGUseElement::svgAttributeChanged):
  19469. (WebCore::SVGUseElement::buildPendingResource):
  19470. * svg/SVGUseElement.h:
  19471. 2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>
  19472. Reviewed by Csaba Osztrogonác.
  19473. [Qt] build-webkit warning Inspector.idl is missing
  19474. https://bugs.webkit.org/show_bug.cgi?id=59047
  19475. Added variable_out to pipe output from one compiler to another,
  19476. and then forced the output to be added to the sources.
  19477. * CodeGenerators.pri:
  19478. 2011-05-01 Dan Bernstein <mitz@apple.com>
  19479. Reviewed by Anders Carlsson.
  19480. <rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
  19481. https://bugs.webkit.org/show_bug.cgi?id=56658
  19482. Test: fast/text/selection-rect-rounding.html
  19483. * platform/graphics/FontFastPath.cpp:
  19484. (WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
  19485. * platform/graphics/mac/FontComplexTextMac.cpp:
  19486. (WebCore::Font::selectionRectForComplexText): Ditto.
  19487. * rendering/InlineTextBox.cpp:
  19488. (WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
  19489. (WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
  19490. since it affects rounding.
  19491. 2011-04-30 Justin Schuh <jschuh@chromium.org>
  19492. Reviewed by Dirk Schulze.
  19493. Make RenderSVGResourceFilter take ownership of filter data when painting
  19494. https://bugs.webkit.org/show_bug.cgi?id=51524
  19495. Test: svg/custom/filter-on-svgimage.svg
  19496. * rendering/svg/RenderSVGResourceFilter.cpp:
  19497. (WebCore::RenderSVGResourceFilter::removeClientFromCache):
  19498. (WebCore::RenderSVGResourceFilter::postApplyResource):
  19499. * rendering/svg/RenderSVGResourceFilter.h:
  19500. (WebCore::FilterData::FilterData):
  19501. 2011-04-30 Martin Robinson <mrobinson@igalia.com>
  19502. Reviewed by Adam Barth.
  19503. Enable strict mode for OwnPtr and PassOwnPtr
  19504. https://bugs.webkit.org/show_bug.cgi?id=59428
  19505. Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
  19506. factory methods return a PassOwnPtr.
  19507. No new tests. This should not change functionality.
  19508. * platform/GeolocationService.cpp:
  19509. (WebCore::createGeolocationServiceNull):
  19510. (WebCore::GeolocationService::create):
  19511. * platform/GeolocationService.h:
  19512. * platform/android/GeolocationServiceAndroid.cpp:
  19513. (WebCore::GeolocationServiceAndroid::create):
  19514. * platform/android/GeolocationServiceAndroid.h:
  19515. * platform/efl/GeolocationServiceEfl.cpp:
  19516. (WebCore::GeolocationServiceEfl::create):
  19517. * platform/efl/GeolocationServiceEfl.h:
  19518. * platform/graphics/cairo/CairoUtilities.cpp:
  19519. (WebCore::appendPathToCairoContext):
  19520. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  19521. (WebCore::drawPathShadow):
  19522. (WebCore::GraphicsContext::clip):
  19523. * platform/graphics/cairo/ImageBufferCairo.cpp:
  19524. (WebCore::ImageBuffer::ImageBuffer):
  19525. * platform/graphics/cairo/OwnPtrCairo.h:
  19526. * platform/graphics/cairo/PathCairo.cpp:
  19527. (WebCore::Path::Path):
  19528. (WebCore::Path::operator=):
  19529. (WebCore::Path::apply):
  19530. * platform/gtk/GeolocationServiceGtk.cpp:
  19531. (WebCore::GeolocationServiceGtk::create):
  19532. * platform/gtk/GeolocationServiceGtk.h:
  19533. * platform/mock/GeolocationServiceMock.cpp:
  19534. (WebCore::GeolocationServiceMock::create):
  19535. * platform/mock/GeolocationServiceMock.h:
  19536. 2011-04-30 Pavel Feldman <pfeldman@chromium.org>
  19537. Not reviewed: inspector toolbar titles were 2px off.
  19538. * inspector/front-end/inspector.css:
  19539. (#toolbar-dropdown .toolbar-label):
  19540. 2011-04-30 Mihai Parparita <mihaip@chromium.org>
  19541. Reviewed by Eric Seidel.
  19542. V8Proxy.h shouldn't include SecurityOrigin.h
  19543. https://bugs.webkit.org/show_bug.cgi?id=59859
  19544. Remove SecurityOrigin.h #include from V8Proxy.h. Touching
  19545. SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
  19546. chromium's DumpRenderTree).
  19547. * bindings/v8/NPV8Object.cpp:
  19548. * bindings/v8/V8Proxy.cpp:
  19549. * bindings/v8/V8Proxy.h:
  19550. * css/CSSStyleSelector.cpp:
  19551. * dom/XMLDocumentParserLibxml2.cpp:
  19552. * html/HTMLLinkElement.cpp:
  19553. * loader/SubframeLoader.cpp:
  19554. * page/History.cpp:
  19555. * storage/IDBFactory.cpp:
  19556. * storage/StorageAreaImpl.cpp:
  19557. 2011-04-29 Adam Barth <abarth@webkit.org>
  19558. Reviewed by Eric Seidel.
  19559. CSP script-src should block eval
  19560. https://bugs.webkit.org/show_bug.cgi?id=59850
  19561. Rather than have JavaScriptCore call back into WebCore to learn whether
  19562. eval is enabled, we push that bit of the policy into JavaScriptCore.
  19563. Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html
  19564. http/tests/security/contentSecurityPolicy/eval-blocked.html
  19565. * bindings/js/ScriptController.cpp:
  19566. (WebCore::ScriptController::disableEval):
  19567. * bindings/js/ScriptController.h:
  19568. * page/ContentSecurityPolicy.cpp:
  19569. (WebCore::ContentSecurityPolicy::didReceiveHeader):
  19570. (WebCore::ContentSecurityPolicy::internalAllowEval):
  19571. (WebCore::ContentSecurityPolicy::allowEval):
  19572. * page/ContentSecurityPolicy.h:
  19573. 2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
  19574. GTK build fix. Missed moving DateComponents and
  19575. adding LocalizedDate files for their build file.
  19576. * GNUmakefile.list.am:
  19577. 2011-04-29 Adam Barth <abarth@webkit.org>
  19578. Reviewed by Eric Seidel.
  19579. style-src should block @style
  19580. https://bugs.webkit.org/show_bug.cgi?id=59293
  19581. This patch blocks @style when style-src doesn't have the
  19582. 'unsafe-inline' token. This patch blocks the parsing of the attribute
  19583. itself. That feels vaguely like too low a level to interpose the
  19584. policy, but there didn't seem to be anywhere else natural to enforce
  19585. the policy.
  19586. Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html
  19587. http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
  19588. http/tests/security/contentSecurityPolicy/inline-style-on-html.html
  19589. * dom/StyledElement.cpp:
  19590. (WebCore::StyledElement::parseMappedAttribute):
  19591. 2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
  19592. Reviewed by Kent Tamura.
  19593. Allow Localized Date Strings for Date Input Fields
  19594. https://bugs.webkit.org/show_bug.cgi?id=59752
  19595. Test: fast/forms/date-input-visible-strings.html
  19596. * CMakeLists.txt:
  19597. * WebCore.gypi:
  19598. * WebCore.pro:
  19599. * WebCore.vcproj/WebCore.vcproj:
  19600. * WebCore.xcodeproj/project.pbxproj: update build files for
  19601. moving DateComponents from WebCore/html to WebCore/platform
  19602. and adding the LocalizedDate files.
  19603. * html/BaseDateAndTimeInputType.cpp:
  19604. (WebCore::BaseDateAndTimeInputType::serialize):
  19605. (WebCore::BaseDateAndTimeInputType::serializeWithComponents):
  19606. (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):
  19607. InputType::serialize for a double value with date types is
  19608. different for the month type because it assumes the incoming
  19609. value is months instead of msecs (matching valueAsNumber in
  19610. HTML5). So provide a more general serialization function,
  19611. serializeWithComponents, that will always serialize a string
  19612. correctly for the current type but taking in a DateComponents
  19613. object. The default serialize, and new serializeWithMilliseconds,
  19614. can fall back to this and allows an override point for
  19615. the month type.
  19616. * html/MonthInputType.cpp:
  19617. (WebCore::MonthInputType::serializeWithMilliseconds): the month
  19618. type is a case where the default serialize does not take msec,
  19619. so provide an implementation for month which handles msec input.
  19620. * html/BaseDateAndTimeInputType.cpp:
  19621. (WebCore::BaseDateAndTimeInputType::setValueAsDate): switch
  19622. to serializeWithMilliseconds as the incoming date value is msec.
  19623. * html/MonthInputType.cpp:
  19624. (WebCore::MonthInputType::setValueAsDate): removed.
  19625. * html/BaseDateAndTimeInputType.cpp:
  19626. (WebCore::BaseDateAndTimeInputType::visibleValue): allow
  19627. localized formatting of a date value.
  19628. (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
  19629. allow parsing for a formatted date value.
  19630. * html/BaseDateAndTimeInputType.h:
  19631. * platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp.
  19632. Expose the Type enum so it can be used outside of the DateComponents class.
  19633. * platform/text/LocalizedDate.h: Added.
  19634. * platform/text/LocalizedDateNone.cpp: Added.
  19635. (WebCore::formatLocalizedDate): Default implementation falls back to
  19636. existing HTML5 date input value formatting.
  19637. * html/BaseDateAndTimeInputType.h:
  19638. * html/DateInputType.cpp:
  19639. (WebCore::DateInputType::dateType):
  19640. * html/DateInputType.h:
  19641. * html/DateTimeInputType.cpp:
  19642. (WebCore::DateTimeInputType::dateType):
  19643. * html/DateTimeInputType.h:
  19644. * html/DateTimeLocalInputType.cpp:
  19645. (WebCore::DateTimeLocalInputType::dateType):
  19646. * html/DateTimeLocalInputType.h:
  19647. * html/MonthInputType.cpp:
  19648. (WebCore::MonthInputType::dateType):
  19649. * html/MonthInputType.h:
  19650. * html/TimeInputType.cpp:
  19651. (WebCore::TimeInputType::dateType):
  19652. * html/TimeInputType.h:
  19653. * html/WeekInputType.cpp:
  19654. (WebCore::WeekInputType::dateType):
  19655. * html/WeekInputType.h: Accessors for the desired date
  19656. type of a date input type. This allows the base class
  19657. to write a generic algorithm.
  19658. 2011-04-29 Adam Barth <abarth@webkit.org>
  19659. Reviewed by Eric Seidel.
  19660. style-src should block inline style from <style>
  19661. https://bugs.webkit.org/show_bug.cgi?id=59292
  19662. The spec has been updated to allow blocking of inline styles with
  19663. style-src. This will help folks defend against tricky CSS3 injections.
  19664. This patch covers the <style> case. The next patch will cover the
  19665. @style case.
  19666. Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html
  19667. http/tests/security/contentSecurityPolicy/inline-style-blocked.html
  19668. * dom/StyleElement.cpp:
  19669. (WebCore::StyleElement::createSheet):
  19670. * page/ContentSecurityPolicy.cpp:
  19671. (WebCore::ContentSecurityPolicy::allowInlineStyle):
  19672. * page/ContentSecurityPolicy.h:
  19673. 2011-04-29 Chris Evans <cevans@chromium.org>
  19674. Reviewed by Adam Barth.
  19675. Add WebCore::Setting to block displaying and/or running insecure content on secure pages
  19676. https://bugs.webkit.org/show_bug.cgi?id=58378
  19677. Test: To follow in subsequent patch, including the wiring to expose the new settings to LayoutTests.
  19678. * loader/FrameLoader.cpp:
  19679. (WebCore::FrameLoader::checkIfDisplayInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
  19680. (WebCore::FrameLoader::checkIfRunInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
  19681. * loader/FrameLoader.h:
  19682. * loader/MainResourceLoader.cpp:
  19683. (WebCore::MainResourceLoader::willSendRequest): Check if the frame load is blocked due to mixed content and cancel it if so. The check was moved up so that it occurs before firing the load callbacks, to avoid any outgoing network hits or accounting. Redirects are handled because willSendRequest is called for each one in the chain.
  19684. * loader/SubframeLoader.cpp:
  19685. (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Handle the blocking of mixed-content plug-in loads.
  19686. (WebCore::SubframeLoader::loadPlugin): Handle the blocking of mixed-content plug-in loads.
  19687. * loader/cache/CachedResourceLoader.cpp:
  19688. (WebCore::CachedResourceLoader::canRequest): Handle the blocking of various loads due to mixed content conditions.
  19689. * page/Settings.cpp:
  19690. (WebCore::Settings::Settings): Permit mixed-content loads by default to avoid a change in behavior by default.
  19691. * page/Settings.h: Add two new booleans to control blocking of mixed content (displaying and running thereof).
  19692. (WebCore::Settings::setAllowDisplayOfInsecureContent):
  19693. (WebCore::Settings::allowDisplayOfInsecureContent):
  19694. (WebCore::Settings::setAllowRunningOfInsecureContent):
  19695. (WebCore::Settings::allowRunningOfInsecureContent):
  19696. 2011-04-29 Ryosuke Niwa <rniwa@webkit.org>
  19697. Reviewed by Eric Seidel.
  19698. Extract a function to obtain VisiblePosition from RenderText::positionForPoint
  19699. https://bugs.webkit.org/show_bug.cgi?id=59811
  19700. Extracted lineDirectionPointFitsInBox from positionForPoint.
  19701. * rendering/RenderText.cpp:
  19702. (WebCore::lineDirectionPointFitsInBox):
  19703. (WebCore::RenderText::positionForPoint):
  19704. 2011-04-29 Geoffrey Garen <ggaren@apple.com>
  19705. Reviewed by Alexey Proskuryakov.
  19706. REGRESSION: r83938 abandons GC memory
  19707. https://bugs.webkit.org/show_bug.cgi?id=59604
  19708. This bug was caused by script and image elements waiting indefinitely
  19709. for their loads to finish.
  19710. * bindings/js/JSNodeCustom.cpp:
  19711. (WebCore::isReachableFromDOM): Don't test for the load event firing,
  19712. since the load event doesn't fire in cases of canceled or errored loads.
  19713. Instead, test hasPendingActivity().
  19714. Don't do this test at all for script elements because script elements
  19715. can't load while outside the document. (fast/dom/script-element-gc.html
  19716. verifies that this is correct.)
  19717. * html/HTMLImageElement.cpp:
  19718. (WebCore::HTMLImageElement::hasPendingActivity):
  19719. * html/HTMLImageElement.h:
  19720. * loader/ImageLoader.cpp:
  19721. (WebCore::ImageEventSender::hasPendingEvents):
  19722. (WebCore::ImageLoader::hasPendingLoadEvent):
  19723. * loader/ImageLoader.h: Added API for finding out if an image element
  19724. has pending activity.
  19725. * loader/cache/CachedResource.cpp:
  19726. (WebCore::CachedResource::setRequest): All loads are supposed to end in
  19727. data(allDataReceived = true) or error(), but in the edge case of a
  19728. canceled load, all we get is a call to setRequest(0). Be sure to
  19729. record that we're no longer loading in that case, otherwise our element
  19730. will leak forever, waiting for its load to complete.
  19731. 2011-04-29 Emil Eklund <eae@chromium.org>
  19732. Reviewed by Tony Chang.
  19733. Setting outerHTML should merge text nodes
  19734. https://bugs.webkit.org/show_bug.cgi?id=52686
  19735. When setting outerHTML adjacent text nodes should be merged. This matches
  19736. the behavior of outerText and the IE implementation of outerHTML.
  19737. Test: fast/dom/set-outer-html.html
  19738. * html/HTMLElement.cpp:
  19739. (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML.
  19740. (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
  19741. 2011-04-29 Emil A Eklund <eae@chromium.org>
  19742. Reviewed by Dimitri Glazkov.
  19743. Onchange on text fields has an incoherent behavior
  19744. https://bugs.webkit.org/show_bug.cgi?id=57330
  19745. * html/HTMLFormControlElement.cpp:
  19746. (WebCore::HTMLTextFormControlElement::insertedIntoDocument):
  19747. Initialize m_textAsOfLastFormControlChangeEvent to empty string rather
  19748. than null for empty fields.
  19749. 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
  19750. [Qt] Unreviewed buildfix after r85343.
  19751. Enable strict OwnPtr for Qt
  19752. https://bugs.webkit.org/show_bug.cgi?id=59667
  19753. * plugins/mac/PluginViewMac.mm:
  19754. (WebCore::PluginView::platformStart):
  19755. 2011-04-29 Jon Lee <jonlee@apple.com>
  19756. Reviewed by mitzpettel.
  19757. REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
  19758. <rdar://problem/9327332>
  19759. https://bugs.webkit.org/show_bug.cgi?id=59721
  19760. Removing shouldClearSelectionWhenLosingWebPageFocus(). Reverting changelist 83814.
  19761. * WebCore.exp.in:
  19762. * editing/EditingBehavior.h:
  19763. 2011-04-29 Abhishek Arya <inferno@chromium.org>
  19764. Reviewed by Dave Hyatt.
  19765. Allow only first table caption and destroy the remaining ones.
  19766. https://bugs.webkit.org/show_bug.cgi?id=58249
  19767. Previously, we were only laying out the first table caption.
  19768. However Table::layout didn't mark the other ones as not needing
  19769. layout. So after table layout completes, table is marked as not
  19770. needing layout with its other table caption still needing layout.
  19771. This causes incorrect layout root calculations and set it to a
  19772. node which is already getting deleted.
  19773. Tests: fast/table/dynamic-caption-add-before-child.xhtml
  19774. fast/table/dynamic-caption-add-remove-before-child.xhtml
  19775. fast/table/multiple-captions-crash.xhtml
  19776. fast/table/multiple-captions-crash2.xhtml
  19777. fast/table/multiple-captions-display.xhtml
  19778. * rendering/RenderTable.cpp:
  19779. (WebCore::RenderTable::addChild): when new caption or a before
  19780. child caption is added, we need to explicitly trigger section
  19781. recalc or otherwise layout won't catch it.
  19782. (WebCore::RenderTable::removeChild): when child to be removed is
  19783. m_caption, make sure to trigger style recalc on the table.
  19784. (WebCore::RenderTable::recalcCaption): code to destroy captions
  19785. other than the first one.
  19786. (WebCore::RenderTable::recalcSections): call recalcCaption
  19787. helper. Store the next sibling early since child can get destroyed
  19788. in recalcCaption.
  19789. * rendering/RenderTable.h:
  19790. 2011-04-29 David Kilzer <ddkilzer@apple.com>
  19791. Remove WML
  19792. https://bugs.webkit.org/show_bug.cgi?id=59678
  19793. * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
  19794. 2011-04-29 James Robinson <jamesr@chromium.org>
  19795. Unreviewed, rolling out r85330.
  19796. http://trac.webkit.org/changeset/85330
  19797. https://bugs.webkit.org/show_bug.cgi?id=41311
  19798. Caused unexpected border rendering change on 500 tests on chromium linux.
  19799. * platform/graphics/skia/GraphicsContextSkia.cpp:
  19800. (WebCore::GraphicsContext::drawConvexPolygon):
  19801. (WebCore::GraphicsContext::clipConvexPolygon):
  19802. 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
  19803. [Qt] Unreviewed buildfix after r85343.
  19804. Enable strict OwnPtr for Qt
  19805. https://bugs.webkit.org/show_bug.cgi?id=59667
  19806. * plugins/win/PluginViewWin.cpp:
  19807. (WebCore::PluginView::wndProc):
  19808. (WebCore::PluginView::snapshot):
  19809. 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
  19810. Reviewed by Adam Barth.
  19811. Enable strict OwnPtr for Qt
  19812. https://bugs.webkit.org/show_bug.cgi?id=59667
  19813. * platform/graphics/qt/ImageBufferQt.cpp:
  19814. (WebCore::ImageBufferData::ImageBufferData):
  19815. (WebCore::ImageBuffer::ImageBuffer):
  19816. * platform/graphics/qt/ImageDecoderQt.cpp:
  19817. (WebCore::ImageDecoderQt::setData):
  19818. * platform/graphics/qt/ImageDecoderQt.h:
  19819. * platform/network/qt/QNetworkReplyHandler.cpp:
  19820. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  19821. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  19822. 2011-04-29 Dean Jackson <dino@apple.com>
  19823. Reviewed by Simon Fraser.
  19824. Add ENABLE macro for WebKitAnimation
  19825. https://bugs.webkit.org/show_bug.cgi?id=59729
  19826. Add new feature to toggle WebKit Animation API.
  19827. * Configurations/FeatureDefines.xcconfig:
  19828. * GNUmakefile.am:
  19829. * dom/Element.idl:
  19830. * features.pri:
  19831. * page/DOMWindow.idl:
  19832. 2011-04-29 Dean Jackson <dino@apple.com>
  19833. Reviewed by Simon Fraser.
  19834. https://bugs.webkit.org/show_bug.cgi?id=59149
  19835. (Regression) Existing animations are not replaced when filling.
  19836. Hardware animations that fill forwards were not being correctly
  19837. replaced when the animation was removed. The actual animation
  19838. logic was working correctly, but it wasn't deleting the
  19839. CoreAnimation animation from the PlatformLayer. The fix was
  19840. to explicitly call endAnimation when disconnecting the animation
  19841. from its RenderObject.
  19842. Test: animations/3d/replace-filling-transform.html
  19843. * page/animation/AnimationBase.h:
  19844. (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
  19845. 2011-04-29 Abhishek Arya <inferno@chromium.org>
  19846. Reviewed by Nikolas Zimmermann.
  19847. When svg inline text is getting destroyed, make sure to mark
  19848. its svg text ancestor as needing a positioning values update.
  19849. This helps to recalculate layout attributes and makes sure
  19850. that svg inline text is not used again.
  19851. https://bugs.webkit.org/show_bug.cgi?id=59161
  19852. Test: svg/text/inline-text-destroy-attributes-crash.xhtml
  19853. * rendering/svg/RenderSVGInlineText.cpp:
  19854. (WebCore::RenderSVGInlineText::destroy):
  19855. * rendering/svg/RenderSVGInlineText.h:
  19856. 2011-04-29 Kevin Ollivier <kevino@theolliviers.com>
  19857. [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
  19858. * platform/graphics/wx/GraphicsContextWx.cpp:
  19859. 2011-04-29 Mike Reed <reed@google.com>
  19860. Reviewed by Ojan Vafai.
  19861. Skia: Need to implement GraphicsContext::clipConvexPolygon()
  19862. https://bugs.webkit.org/show_bug.cgi?id=41311
  19863. This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
  19864. as that shows other issues/question unrelated to clipping.
  19865. https://bugs.webkit.org/show_bug.cgi?id=41311
  19866. No new tests. covered by existing layout tests
  19867. * platform/graphics/skia/GraphicsContextSkia.cpp:
  19868. (WebCore::setPathFromConvexPoints):
  19869. (WebCore::GraphicsContext::drawConvexPolygon):
  19870. (WebCore::GraphicsContext::clipConvexPolygon):
  19871. 2011-04-29 Mike Lawther <mikelawther@chromium.org>
  19872. Reviewed by Ojan Vafai.
  19873. Fix IR->SR typo in enum value (and resulting style fails)
  19874. https://bugs.webkit.org/show_bug.cgi?id=59779
  19875. No functionality change, so no new tests
  19876. * css/CSSPrimitiveValueMappings.h:
  19877. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  19878. (WebCore::CSSPrimitiveValue::operator EShapeRendering):
  19879. 2011-04-29 Pavel Feldman <pfeldman@google.com>
  19880. Reviewed by Yury Semikhatsky.
  19881. Web Inspector: CSS editing breaks when entering "color: rgb(1"
  19882. https://bugs.webkit.org/show_bug.cgi?id=59789
  19883. Tests: inspector/styles/styles-add-invalid-property.html
  19884. inspector/styles/styles-cancel-editing.html
  19885. inspector/styles/styles-commit-editing.html
  19886. * inspector/front-end/CSSStyleModel.js:
  19887. (WebInspector.CSSProperty.prototype.setText.callback):
  19888. (WebInspector.CSSProperty.prototype.setText):
  19889. * inspector/front-end/StylesSidebarPane.js:
  19890. (WebInspector.StylePropertyTreeElement.prototype.selectElement):
  19891. (WebInspector.StylePropertyTreeElement.prototype):
  19892. (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
  19893. * inspector/front-end/inspector.js:
  19894. (WebInspector.startEditing.defaultFinishHandler):
  19895. (WebInspector.startEditing.keyDownEventListener):
  19896. (WebInspector.startEditing):
  19897. 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19898. Reviewed by Simon Hausmann.
  19899. ENABLE(QT_BEARER) -> USE(QT_BEARER)
  19900. * WebCore.pri:
  19901. * WebCore.pro:
  19902. * features.pri:
  19903. * platform/network/NetworkStateNotifier.h:
  19904. * platform/network/qt/NetworkStateNotifierQt.cpp:
  19905. 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19906. Reviewed by Simon Hausmann.
  19907. ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
  19908. * WebCore.pri:
  19909. * features.pri:
  19910. 2011-04-29 Pavel Podivilov <podivilov@chromium.org>
  19911. Reviewed by Pavel Feldman.
  19912. Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
  19913. https://bugs.webkit.org/show_bug.cgi?id=59476
  19914. * inspector/front-end/DebuggerPresentationModel.js:
  19915. (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
  19916. (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
  19917. (WebInspector.PresentationBreakpoint.prototype.serialize):
  19918. * inspector/front-end/ScriptsPanel.js:
  19919. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
  19920. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
  19921. (WebInspector.ScriptsPanel.prototype.reset):
  19922. 2011-04-28 Pavel Podivilov <podivilov@chromium.org>
  19923. Reviewed by Yury Semikhatsky.
  19924. Web Inspector: include script end line:column in scriptParsed parameters.
  19925. https://bugs.webkit.org/show_bug.cgi?id=59717
  19926. * bindings/js/ScriptDebugServer.cpp:
  19927. (WebCore::ScriptDebugServer::dispatchDidParseSource):
  19928. * bindings/v8/DebuggerScript.js:
  19929. ():
  19930. * bindings/v8/ScriptDebugServer.cpp:
  19931. (WebCore::ScriptDebugServer::dispatchDidParseSource):
  19932. * inspector/Inspector.json:
  19933. * inspector/InspectorDebuggerAgent.cpp:
  19934. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  19935. (WebCore::InspectorDebuggerAgent::didParseSource):
  19936. * inspector/InspectorDebuggerAgent.h:
  19937. (WebCore::InspectorDebuggerAgent::Script::Script):
  19938. * inspector/ScriptDebugListener.h:
  19939. * inspector/front-end/DebuggerModel.js:
  19940. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  19941. (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
  19942. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  19943. * inspector/front-end/Script.js:
  19944. (WebInspector.Script):
  19945. 2011-04-28 Yury Semikhatsky <yurys@chromium.org>
  19946. Reviewed by Pavel Feldman.
  19947. Web Inspector: [protocol] Evaluate should expose thrown exception value
  19948. https://bugs.webkit.org/show_bug.cgi?id=59000
  19949. Each evaluation command may have either thrown or returned result. This is indicated
  19950. by wasThrown property in the protocol.
  19951. * inspector/InjectedScript.cpp:
  19952. (WebCore::InjectedScript::evaluate):
  19953. (WebCore::InjectedScript::evaluateOn):
  19954. (WebCore::InjectedScript::evaluateOnCallFrame):
  19955. (WebCore::InjectedScript::getProperties):
  19956. (WebCore::InjectedScript::makeEvalCall):
  19957. * inspector/InjectedScript.h:
  19958. * inspector/InjectedScriptSource.js:
  19959. * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
  19960. the evaluation results.
  19961. * inspector/InspectorDebuggerAgent.cpp:
  19962. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  19963. * inspector/InspectorDebuggerAgent.h:
  19964. * inspector/InspectorRuntimeAgent.cpp:
  19965. (WebCore::InspectorRuntimeAgent::evaluate):
  19966. (WebCore::InspectorRuntimeAgent::evaluateOn):
  19967. (WebCore::InspectorRuntimeAgent::getProperties):
  19968. * inspector/InspectorRuntimeAgent.h:
  19969. * inspector/front-end/ConsoleView.js:
  19970. (WebInspector.ConsoleView.prototype.completions.evaluated):
  19971. (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
  19972. (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
  19973. (WebInspector.ConsoleView.prototype._enterKeyPressed):
  19974. (WebInspector.ConsoleCommandResult):
  19975. * inspector/front-end/DebuggerPresentationModel.js:
  19976. (WebInspector.PresenationCallFrame.prototype.evaluate):
  19977. * inspector/front-end/ElementsTreeOutline.js:
  19978. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  19979. * inspector/front-end/ExtensionPanel.js:
  19980. (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
  19981. * inspector/front-end/ExtensionServer.js:
  19982. (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  19983. * inspector/front-end/ObjectPropertiesSection.js:
  19984. (WebInspector.ObjectPropertyTreeElement.prototype.update):
  19985. * inspector/front-end/PropertiesSidebarPane.js:
  19986. (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  19987. * inspector/front-end/SourceFrame.js:
  19988. (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
  19989. (WebInspector.SourceFrame.prototype._showPopup):
  19990. 2011-04-29 Sheriff Bot <webkit.review.bot@gmail.com>
  19991. Unreviewed, rolling out r85315.
  19992. http://trac.webkit.org/changeset/85315
  19993. https://bugs.webkit.org/show_bug.cgi?id=59792
  19994. Broke script-formatter.html test (Requested by podivilov on
  19995. #webkit).
  19996. * inspector/front-end/DebuggerPresentationModel.js:
  19997. (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
  19998. (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
  19999. (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
  20000. (WebInspector.PresentationBreakpoint.prototype.serialize):
  20001. * inspector/front-end/ScriptsPanel.js:
  20002. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
  20003. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
  20004. (WebInspector.ScriptsPanel.prototype.reset):
  20005. 2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>
  20006. Reviewed by Pavel Feldman.
  20007. Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
  20008. https://bugs.webkit.org/show_bug.cgi?id=58794
  20009. Added ping requests to network panel.
  20010. Test: http/tests/inspector/network/ping.html
  20011. * English.lproj/localizedStrings.js:
  20012. * inspector/InspectorInstrumentation.cpp:
  20013. (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
  20014. * inspector/InspectorInstrumentation.h:
  20015. (WebCore::InspectorInstrumentation::continueAfterPingLoader):
  20016. * inspector/front-end/NetworkPanel.js:
  20017. (WebInspector.NetworkDataGridNode.prototype.refreshResource):
  20018. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  20019. (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
  20020. * inspector/front-end/Resource.js:
  20021. (WebInspector.Resource.prototype.get formParameters):
  20022. (WebInspector.Resource.prototype.requestContentType):
  20023. (WebInspector.Resource.prototype.isPingRequest):
  20024. * loader/PingLoader.cpp:
  20025. (WebCore::PingLoader::PingLoader):
  20026. * loader/PingLoader.h:
  20027. 2011-04-28 Pavel Podivilov <podivilov@chromium.org>
  20028. Reviewed by Pavel Feldman.
  20029. Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
  20030. https://bugs.webkit.org/show_bug.cgi?id=59476
  20031. * inspector/front-end/DebuggerPresentationModel.js:
  20032. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  20033. (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
  20034. (WebInspector.PresentationBreakpoint.prototype.serialize):
  20035. * inspector/front-end/ScriptsPanel.js:
  20036. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
  20037. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
  20038. (WebInspector.ScriptsPanel.prototype.reset):
  20039. 2011-04-29 Pavel Feldman <pfeldman@google.com>
  20040. Reviewed by Yury Semikhatsky.
  20041. Web Inspector: add "open link in new tab" action into the network and resources panels.
  20042. https://bugs.webkit.org/show_bug.cgi?id=59788
  20043. This change also distinguishes context menu items case between platforms.
  20044. * English.lproj/localizedStrings.js:
  20045. * inspector/front-end/ConsoleView.js:
  20046. (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  20047. * inspector/front-end/DOMBreakpointsSidebarPane.js:
  20048. (WebInspector.DOMBreakpointsSidebarPane):
  20049. * inspector/front-end/ElementsPanel.js:
  20050. (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
  20051. (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  20052. * inspector/front-end/ElementsTreeOutline.js:
  20053. (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  20054. (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
  20055. * inspector/front-end/NetworkPanel.js:
  20056. (WebInspector.NetworkPanel.prototype._contextMenu):
  20057. * inspector/front-end/ResourcesPanel.js:
  20058. (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
  20059. (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
  20060. (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  20061. * inspector/front-end/Settings.js:
  20062. * inspector/front-end/SourceFrame.js:
  20063. (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
  20064. * inspector/front-end/TextViewer.js:
  20065. (WebInspector.TextViewer.prototype._contextMenu):
  20066. * inspector/front-end/inspector.js:
  20067. (WebInspector.openLinkExternallyLabel):
  20068. (WebInspector.openResource):
  20069. (WebInspector.useLowerCaseMenuTitles):
  20070. 2011-04-28 Simon Fraser <simon.fraser@apple.com>
  20071. Reviewed by Dan Bernstein.
  20072. Mask placement on composited layer is incorrect sometimes
  20073. https://bugs.webkit.org/show_bug.cgi?id=59775
  20074. The mask layer always has the same size as its owning GraphicsLayer,
  20075. so it needs to share the same offsetFromRenderer as well. This fixes
  20076. the offset at which the mask layer contents are painted in cases where
  20077. that offset is non-zero, for example when outline style bloats all of
  20078. the layer sizes.
  20079. Test: compositing/masks/layer-mask-placement.html
  20080. * rendering/RenderLayerBacking.cpp:
  20081. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  20082. 2011-04-28 Dan Bernstein <mitz@apple.com>
  20083. Rubber-stamped by Mark Rowe.
  20084. Reverted r81319.
  20085. Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
  20086. * page/NavigatorBase.cpp:
  20087. 2011-04-28 Simon Fraser <simon.fraser@apple.com>
  20088. Reviewed by Dirk Schulze.
  20089. 1px box-shadow looks ugly
  20090. https://bugs.webkit.org/show_bug.cgi?id=58100
  20091. and
  20092. ShadowBlur incorrectly handles zero-sized blur radius in one axis
  20093. https://bugs.webkit.org/show_bug.cgi?id=59710
  20094. blurLayerImage() has issues at the edges if the blur radius
  20095. is one, so in that case bump the buffer size out by a pixel.
  20096. This results in a correct, symmetrical blur.
  20097. Also fix an issue noticed during testing where a zero
  20098. height or width radius would still blur on that axis,
  20099. because we clamp the kernel size to a minimum of two.
  20100. Test: fast/box-shadow/single-pixel-shadow.html
  20101. * platform/graphics/ShadowBlur.h:
  20102. * platform/graphics/ShadowBlur.cpp:
  20103. (WebCore::ShadowBlur::blurLayerImage):
  20104. Skip horizontal or vertial passes if the radius on that axis is zero.
  20105. Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
  20106. clause to the end of the loop, since it only needs to execute once
  20107. after the first pass.
  20108. (WebCore::ShadowBlur::blurredEdgeSize):
  20109. New method to compute the width of the blurred edge (radius + extra
  20110. pixel when necessary).
  20111. (WebCore::ShadowBlur::calculateLayerBoundingRect):
  20112. (WebCore::ShadowBlur::templateSize):
  20113. (WebCore::ShadowBlur::drawRectShadow):
  20114. (WebCore::ShadowBlur::drawInsetShadow):
  20115. (WebCore::ShadowBlur::drawInsetShadowWithTiling):
  20116. (WebCore::ShadowBlur::drawRectShadowWithTiling):
  20117. (WebCore::ShadowBlur::drawLayerPieces):
  20118. Use the result of blurredEdgeSize() rather than recomputing.
  20119. 2011-04-28 Yael Aharon <yael.aharon@nokia.com>
  20120. Reviewed by Beth Dakin.
  20121. CSS sibling selector (~) does not work with :target pseudo class
  20122. https://bugs.webkit.org/show_bug.cgi?id=26539
  20123. Allow style recalculation of forward siblings of elements with
  20124. forward positional rules.
  20125. Tests: fast/css/pseudo-target-indirect-sibling-001.html
  20126. fast/css/pseudo-target-indirect-sibling-002.html
  20127. * dom/Element.cpp:
  20128. (WebCore::Element::recalcStyle):
  20129. 2011-04-28 Nat Duca <nduca@chromium.org>
  20130. Reviewed by Kenneth Russell.
  20131. [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
  20132. https://bugs.webkit.org/show_bug.cgi?id=59626
  20133. * platform/graphics/chromium/Extensions3DChromium.h:
  20134. (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
  20135. 2011-04-28 Steve Lacey <sjl@chromium.org>
  20136. Reviewed by Eric Carlson.
  20137. Change chromium media controls to use absolute positioning until bug 59644 is fixed.
  20138. https://bugs.webkit.org/show_bug.cgi?id=59732
  20139. * css/mediaControlsChromium.css:
  20140. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  20141. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  20142. 2011-04-28 Luke Macpherson <macpherson@chromium.org>
  20143. Reviewed by Eric Seidel.
  20144. Implement CSS border width and related properties in CSSStyleApplyProperty.
  20145. https://bugs.webkit.org/show_bug.cgi?id=59414
  20146. No new tests as no functionality added.
  20147. * css/CSSStyleApplyProperty.cpp:
  20148. Separated ApplyPropertyDefault into parent and child so that other classes could inherit
  20149. the applyInheritValue and applyInitialValue methods only.
  20150. This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
  20151. Added ApplyPropertyWidth class for handling width based CSS properties.
  20152. * css/CSSStyleSelector.cpp:
  20153. Removed no-longer-required code for handling width based CSS properties.
  20154. * css/CSSStyleSelector.h:
  20155. Added a getter for m_rootElementStyle.
  20156. 2011-04-28 Kent Tamura <tkent@chromium.org>
  20157. Run sort-Xcode-project-file.
  20158. * WebCore.xcodeproj/project.pbxproj:
  20159. 2011-04-28 Martin Robinson <mrobinson@igalia.com>
  20160. Reviewed by Dirk Schulze.
  20161. [Cairo] Text underline is not shadowed when text-shadow is enabled
  20162. https://bugs.webkit.org/show_bug.cgi?id=48074
  20163. Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
  20164. of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
  20165. originally copied from the CG GraphicsContext.
  20166. * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
  20167. can call it from a static helper function.
  20168. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  20169. (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
  20170. (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
  20171. call it multiple times when shadowing text underlines.
  20172. (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
  20173. (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
  20174. (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
  20175. 2011-04-28 Sam Weinig <sam@webkit.org>
  20176. Rubber-stamped by Mark Rowe.
  20177. Cleanup WebCore.xcodeproj a bit.
  20178. * WebCore.xcodeproj/project.pbxproj:
  20179. Added CompilerVersion.xcconfig and moved some JS bindings files into the
  20180. correct sub groups.
  20181. 2011-04-28 David Levin <levin@chromium.org>
  20182. Reviewed by Adam Barth.
  20183. Remove IMAGE_RESIZER related code.
  20184. https://bugs.webkit.org/show_bug.cgi?id=59735
  20185. * CMakeLists.txt:
  20186. * Configurations/FeatureDefines.xcconfig:
  20187. * GNUmakefile.am:
  20188. * GNUmakefile.list.am:
  20189. * WebCore.gypi:
  20190. * WebCore.pro:
  20191. * WebCore.vcproj/WebCore.vcproj:
  20192. * WebCore.xcodeproj/project.pbxproj:
  20193. * features.pri:
  20194. * html/AsyncImageResizer.cpp: Removed.
  20195. * html/AsyncImageResizer.h: Removed.
  20196. * html/ImageResizerThread.cpp: Removed.
  20197. * html/ImageResizerThread.h: Removed.
  20198. 2011-04-28 Ilya Tikhonovsky <loislo@chromium.org>
  20199. Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
  20200. * inspector/front-end/Settings.js:
  20201. (WebInspector.Settings):
  20202. 2011-04-28 Beth Dakin <bdakin@apple.com>
  20203. Rubber-stamped by Sam Weinig.
  20204. Rolling out revision 85258! I want to fix that bug a different way.
  20205. * platform/mac/ScrollbarThemeMac.mm:
  20206. (WebCore::ScrollbarThemeMac::paint):
  20207. 2011-04-28 Chang Shu <cshu@webkit.org>
  20208. Reviewed by Eric Seidel.
  20209. isContentEditable is not working properly with document.designMode
  20210. https://bugs.webkit.org/show_bug.cgi?id=53031
  20211. The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
  20212. indicates that the element.isContentEditable relies on document.designMode if its
  20213. and its ancestors' contenteditable attributes are set to inherit.
  20214. 1. Sync document render style after document.designMode is changed.
  20215. 2. Removed the code that does unnecessary and incorrect handling for contenteditable
  20216. attribute with "inherit" value.
  20217. 3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
  20218. Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
  20219. fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
  20220. fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
  20221. fast/dom/HTMLElement/iscontenteditable-designmodeon.html
  20222. * css/CSSStyleSelector.cpp:
  20223. (WebCore::CSSStyleSelector::styleForDocument):
  20224. * dom/Document.cpp:
  20225. (WebCore::Document::setDesignMode):
  20226. * dom/Node.cpp:
  20227. (WebCore::Node::rendererIsEditable):
  20228. * editing/ApplyStyleCommand.cpp:
  20229. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  20230. * html/HTMLElement.cpp:
  20231. (WebCore::HTMLElement::setContentEditable):
  20232. 2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
  20233. Unreviewed, rolling out r85101.
  20234. http://trac.webkit.org/changeset/85101
  20235. https://bugs.webkit.org/show_bug.cgi?id=59757
  20236. it'd be better to rollout the patch and do another one with
  20237. another property name. Current one will bring us to a problem
  20238. at first run after upgrade because it's type was changed from
  20239. int to string. (Requested by loislo on #webkit).
  20240. * inspector/front-end/ScriptsPanel.js:
  20241. (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
  20242. (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
  20243. (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  20244. 2011-04-28 Mike Reed <reed@google.com>
  20245. Reviewed by Eric Seidel.
  20246. fix shadw behavior for both CSS and Canvas -- skia only
  20247. https://bugs.webkit.org/show_bug.cgi?id=59700
  20248. Test:
  20249. canvas/philip/tests/2d.shadow.alpha.3.html
  20250. canvas/philip/tests/2d.shadow.alpha.4.html
  20251. canvas/philip/tests/2d.shadow.alpha.5.html
  20252. fast/canvas/canvas-fillPath-alpha-shadow.html
  20253. fast/canvas/canvas-strokePath-alpha-shadow.html
  20254. fast/canvas/canvas-strokeRect-alpha-shadow.html
  20255. fast/css/text-input-with-webkit-border-radius.html
  20256. fast/repaint/shadow-multiple-horizontal.html
  20257. fast/repaint/shadow-multiple-strict-horizontal.html
  20258. fast/repaint/shadow-multiple-strict-vertical.html
  20259. fast/repaint/shadow-multiple-vertical.html
  20260. fast/canvas/canvas-getImageData.html
  20261. * platform/graphics/chromium/FontChromiumWin.cpp:
  20262. (WebCore::Font::drawGlyphs):
  20263. * platform/graphics/skia/GraphicsContextSkia.cpp:
  20264. (WebCore::GraphicsContext::setPlatformShadow):
  20265. 2011-04-28 David Kilzer <ddkilzer@apple.com>
  20266. <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
  20267. Reviewed by Chris Fleizach.
  20268. Previously, AXObjectCache::attachWrapper over-retained each
  20269. AccessibilityObjectWrapper it created, which is why
  20270. AXObjectCache::detachWrapper() contained an extra -release.
  20271. * accessibility/mac/AXObjectCacheMac.mm:
  20272. (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
  20273. (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
  20274. assigns to a RetainPtr<> instance variable, it doesn't need a +1
  20275. retained object passed in. Fix the leak by using a RetainPtr<>
  20276. for the AccessibilityObjectWrapper.
  20277. 2011-04-28 Nat Duca <nduca@chromium.org>
  20278. Reviewed by Darin Fisher.
  20279. [chromium] Compute compositor fps value and history using the frameBegin timestamp
  20280. https://bugs.webkit.org/show_bug.cgi?id=59668
  20281. This change switches the compositor FPS meter to use the timestamp
  20282. of the beginning of the frame rather than the time we call
  20283. swapBuffers. When scheduling is correctly tied to vsync, we can
  20284. have highly variable times when we finish vsync and still have
  20285. stable frame rates.
  20286. * platform/graphics/chromium/LayerRendererChromium.cpp:
  20287. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  20288. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  20289. (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
  20290. (WebCore::CCHeadsUpDisplay::drawFPSCounter):
  20291. (WebCore::CCHeadsUpDisplay::onFrameBegin):
  20292. (WebCore::CCHeadsUpDisplay::onPresent):
  20293. * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  20294. 2011-04-28 Beth Dakin <bdakin@apple.com>
  20295. Reviewed by Darin Adler.
  20296. https://bugs.webkit.org/show_bug.cgi?id=59759
  20297. Overflow:scroll regions with overlay scrollbars show full thumb instead of just a
  20298. track when there is nothing to scroll to
  20299. <rdar://problem/9282066>
  20300. Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is
  20301. nothing to scroll to. Just dividing them to get a knob proportion yields 1, which
  20302. is not right. Set the proportion to 0 in this case instead.
  20303. * platform/mac/ScrollbarThemeMac.mm:
  20304. (WebCore::ScrollbarThemeMac::paint):
  20305. 2011-04-28 Dan Bernstein <mitz@apple.com>
  20306. Reviewed by Simon Fraser.
  20307. <rdar://problem/9291132> Add support for -epub-prefixed properties
  20308. Test: fast/css/epub-properties.html
  20309. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  20310. (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
  20311. * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
  20312. -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
  20313. text-transform, text-transform, word-break, and -webkit-writing-mode.
  20314. 2011-04-28 Adam Barth <abarth@webkit.org>
  20315. Reviewed by Eric Seidel.
  20316. Remove WML
  20317. https://bugs.webkit.org/show_bug.cgi?id=59678
  20318. This patch removes WML from WebCore. After removing WML, there's a
  20319. bunch of twisted code that could be untwisted, but this patch contains
  20320. only the purely mechanical part of removing the feature.
  20321. There's been a lot of discussion on webkit-dev about whether we should
  20322. remove WML. In addition to those threads, we've had an informal poll
  20323. of the reviewers as well as an in-person discussion at the WebKit
  20324. contributor's meeting. Removing any feature is likely to make some
  20325. folks unhappy, but, on balance, removing WML appears to be the right
  20326. thing for the project to do at this time.
  20327. * CMakeLists.txt:
  20328. * CodeGenerators.pri:
  20329. * Configurations/FeatureDefines.xcconfig:
  20330. * DerivedSources.cpp:
  20331. * DerivedSources.make:
  20332. * GNUmakefile.am:
  20333. * GNUmakefile.list.am:
  20334. * WebCore.gyp/WebCore.gyp:
  20335. * WebCore.gypi:
  20336. * WebCore.pro:
  20337. * WebCore.vcproj/WebCore.vcproj:
  20338. * WebCore.xcodeproj/project.pbxproj:
  20339. * css/CSSStyleSelector.cpp:
  20340. (WebCore::linkAttribute):
  20341. (WebCore::CSSStyleSelector::styleForElement):
  20342. (WebCore::CSSStyleSelector::adjustRenderStyle):
  20343. * css/wml.css: Removed.
  20344. * dom/DOMImplementation.cpp:
  20345. (WebCore::DOMImplementation::createDocument):
  20346. * dom/Document.cpp:
  20347. (WebCore::Document::Document):
  20348. (WebCore::Document::createElement):
  20349. * dom/Document.h:
  20350. (WebCore::Document::isMediaDocument):
  20351. * dom/Document.idl:
  20352. * dom/InputElement.h:
  20353. * dom/Node.cpp:
  20354. (WebCore::Node::toInputElement):
  20355. * dom/Node.h:
  20356. * dom/OptionElement.cpp:
  20357. (WebCore::toOptionElement):
  20358. (WebCore::isOptionElement):
  20359. * dom/OptionElement.h:
  20360. * dom/OptionGroupElement.cpp:
  20361. (WebCore::toOptionGroupElement):
  20362. (WebCore::isOptionGroupElement):
  20363. * dom/SelectElement.cpp:
  20364. (WebCore::toSelectElement):
  20365. * dom/SelectElement.h:
  20366. * dom/Text.cpp:
  20367. (WebCore::Text::attach):
  20368. * dom/XMLDocumentParser.cpp:
  20369. (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  20370. * dom/XMLDocumentParser.h:
  20371. * dom/XMLDocumentParserLibxml2.cpp:
  20372. (WebCore::XMLDocumentParser::internalSubset):
  20373. (WebCore::getEntityHandler):
  20374. * dom/XMLDocumentParserQt.cpp:
  20375. (WebCore::XMLDocumentParser::parse):
  20376. (WebCore::XMLDocumentParser::parseDtd):
  20377. * editing/htmlediting.cpp:
  20378. (WebCore::canHaveChildrenForEditing):
  20379. * features.pri:
  20380. * history/BackForwardList.h:
  20381. * history/BackForwardListImpl.cpp:
  20382. * history/BackForwardListImpl.h:
  20383. * history/PageCache.cpp:
  20384. (WebCore::PageCache::canCachePageContainingThisFrame):
  20385. * html/HTMLAnchorElement.h:
  20386. * inspector/ConsoleMessage.cpp:
  20387. (WebCore::messageSourceValue):
  20388. * inspector/front-end/ConsoleView.js:
  20389. (WebInspector.ConsoleMessage.prototype.toString):
  20390. * loader/FrameLoader.cpp:
  20391. (WebCore::isBackForwardLoadType):
  20392. (WebCore::FrameLoader::transitionToCommitted):
  20393. (WebCore::FrameLoader::shouldReload):
  20394. (WebCore::FrameLoader::loadDifferentDocumentItem):
  20395. (WebCore::FrameLoader::loadItem):
  20396. * loader/FrameLoaderTypes.h:
  20397. * loader/HistoryController.cpp:
  20398. (WebCore::HistoryController::restoreDocumentState):
  20399. * manual-tests/wml: Removed.
  20400. * manual-tests/wml/StartTests.wml: Removed.
  20401. * manual-tests/wml/a-br-element.wml: Removed.
  20402. * manual-tests/wml/a-element.wml: Removed.
  20403. * manual-tests/wml/a-img-element.wml: Removed.
  20404. * manual-tests/wml/access-target.wml: Removed.
  20405. * manual-tests/wml/anchor-br-element.wml: Removed.
  20406. * manual-tests/wml/anchor-element.wml: Removed.
  20407. * manual-tests/wml/anchor-img-element.wml: Removed.
  20408. * manual-tests/wml/card-newcontext-attr.wml: Removed.
  20409. * manual-tests/wml/card-onenterbackward.wml: Removed.
  20410. * manual-tests/wml/card-onenterforward.wml: Removed.
  20411. * manual-tests/wml/card-ontimer.wml: Removed.
  20412. * manual-tests/wml/deck-access-control.wml: Removed.
  20413. * manual-tests/wml/input-format.wml: Removed.
  20414. * manual-tests/wml/onevent-go.wml: Removed.
  20415. * manual-tests/wml/onevent-noop.wml: Removed.
  20416. * manual-tests/wml/onevent-prev.wml: Removed.
  20417. * manual-tests/wml/onevent-refresh.wml: Removed.
  20418. * manual-tests/wml/onevent-shadow.wml: Removed.
  20419. * manual-tests/wml/resources: Removed.
  20420. * manual-tests/wml/resources/smiley.png: Removed.
  20421. * manual-tests/wml/select-element.wml: Removed.
  20422. * manual-tests/wml/select-onpick-event-crash.wml: Removed.
  20423. * manual-tests/wml/select-onpick-event.wml: Removed.
  20424. * manual-tests/wml/setvar-element.wml: Removed.
  20425. * manual-tests/wml/targetdeck.wml: Removed.
  20426. * manual-tests/wml/task-go-in-anchor.wml: Removed.
  20427. * manual-tests/wml/task-prev-in-anchor.wml: Removed.
  20428. * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
  20429. * manual-tests/wml/template-go.wml: Removed.
  20430. * manual-tests/wml/template-ontimer.wml: Removed.
  20431. * manual-tests/wml/timer.wml: Removed.
  20432. * manual-tests/wml/variable-substitution.wml: Removed.
  20433. * page/Console.cpp:
  20434. (WebCore::printMessageSourceAndLevelPrefix):
  20435. * page/Console.h:
  20436. * page/Frame.cpp:
  20437. (WebCore::Frame::Frame):
  20438. * page/Page.cpp:
  20439. * page/Page.h:
  20440. * platform/MIMETypeRegistry.cpp:
  20441. (WebCore::initializeSupportedNonImageMimeTypes):
  20442. * platform/network/FormDataBuilder.h:
  20443. * platform/network/mac/ResourceHandleMac.mm:
  20444. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  20445. * platform/wince/MIMETypeRegistryWinCE.cpp:
  20446. (WebCore::initMIMETypeEntensionMap):
  20447. * rendering/HitTestResult.cpp:
  20448. (WebCore::HitTestResult::altDisplayString):
  20449. (WebCore::HitTestResult::absoluteImageURL):
  20450. (WebCore::HitTestResult::absoluteLinkURL):
  20451. (WebCore::HitTestResult::isLiveLink):
  20452. * rendering/RenderBox.cpp:
  20453. * rendering/RenderButton.cpp:
  20454. (WebCore::RenderButton::updateFromElement):
  20455. * rendering/RenderFieldset.cpp:
  20456. (WebCore::RenderFieldset::findLegend):
  20457. * rendering/RenderImage.cpp:
  20458. (WebCore::RenderImage::updateAltText):
  20459. * rendering/RenderObject.cpp:
  20460. (WebCore::RenderObject::isLegend):
  20461. (WebCore::RenderObject::offsetParent):
  20462. * wml: Removed.
  20463. * wml/WMLAElement.cpp: Removed.
  20464. * wml/WMLAElement.h: Removed.
  20465. * wml/WMLAccessElement.cpp: Removed.
  20466. * wml/WMLAccessElement.h: Removed.
  20467. * wml/WMLAnchorElement.cpp: Removed.
  20468. * wml/WMLAnchorElement.h: Removed.
  20469. * wml/WMLAttributeNames.in: Removed.
  20470. * wml/WMLBRElement.cpp: Removed.
  20471. * wml/WMLBRElement.h: Removed.
  20472. * wml/WMLCardElement.cpp: Removed.
  20473. * wml/WMLCardElement.h: Removed.
  20474. * wml/WMLDoElement.cpp: Removed.
  20475. * wml/WMLDoElement.h: Removed.
  20476. * wml/WMLDocument.cpp: Removed.
  20477. * wml/WMLDocument.h: Removed.
  20478. * wml/WMLElement.cpp: Removed.
  20479. * wml/WMLElement.h: Removed.
  20480. * wml/WMLErrorHandling.cpp: Removed.
  20481. * wml/WMLErrorHandling.h: Removed.
  20482. * wml/WMLEventHandlingElement.cpp: Removed.
  20483. * wml/WMLEventHandlingElement.h: Removed.
  20484. * wml/WMLFieldSetElement.cpp: Removed.
  20485. * wml/WMLFieldSetElement.h: Removed.
  20486. * wml/WMLFormControlElement.cpp: Removed.
  20487. * wml/WMLFormControlElement.h: Removed.
  20488. * wml/WMLGoElement.cpp: Removed.
  20489. * wml/WMLGoElement.h: Removed.
  20490. * wml/WMLImageElement.cpp: Removed.
  20491. * wml/WMLImageElement.h: Removed.
  20492. * wml/WMLImageLoader.cpp: Removed.
  20493. * wml/WMLImageLoader.h: Removed.
  20494. * wml/WMLInputElement.cpp: Removed.
  20495. * wml/WMLInputElement.h: Removed.
  20496. * wml/WMLInsertedLegendElement.cpp: Removed.
  20497. * wml/WMLInsertedLegendElement.h: Removed.
  20498. * wml/WMLIntrinsicEvent.cpp: Removed.
  20499. * wml/WMLIntrinsicEvent.h: Removed.
  20500. * wml/WMLIntrinsicEventHandler.cpp: Removed.
  20501. * wml/WMLIntrinsicEventHandler.h: Removed.
  20502. * wml/WMLMetaElement.cpp: Removed.
  20503. * wml/WMLMetaElement.h: Removed.
  20504. * wml/WMLNoopElement.cpp: Removed.
  20505. * wml/WMLNoopElement.h: Removed.
  20506. * wml/WMLOnEventElement.cpp: Removed.
  20507. * wml/WMLOnEventElement.h: Removed.
  20508. * wml/WMLOptGroupElement.cpp: Removed.
  20509. * wml/WMLOptGroupElement.h: Removed.
  20510. * wml/WMLOptionElement.cpp: Removed.
  20511. * wml/WMLOptionElement.h: Removed.
  20512. * wml/WMLPElement.cpp: Removed.
  20513. * wml/WMLPElement.h: Removed.
  20514. * wml/WMLPageState.cpp: Removed.
  20515. * wml/WMLPageState.h: Removed.
  20516. * wml/WMLPostfieldElement.cpp: Removed.
  20517. * wml/WMLPostfieldElement.h: Removed.
  20518. * wml/WMLPrevElement.cpp: Removed.
  20519. * wml/WMLPrevElement.h: Removed.
  20520. * wml/WMLRefreshElement.cpp: Removed.
  20521. * wml/WMLRefreshElement.h: Removed.
  20522. * wml/WMLSelectElement.cpp: Removed.
  20523. * wml/WMLSelectElement.h: Removed.
  20524. * wml/WMLSetvarElement.cpp: Removed.
  20525. * wml/WMLSetvarElement.h: Removed.
  20526. * wml/WMLTableElement.cpp: Removed.
  20527. * wml/WMLTableElement.h: Removed.
  20528. * wml/WMLTagNames.in: Removed.
  20529. * wml/WMLTaskElement.cpp: Removed.
  20530. * wml/WMLTaskElement.h: Removed.
  20531. * wml/WMLTemplateElement.cpp: Removed.
  20532. * wml/WMLTemplateElement.h: Removed.
  20533. * wml/WMLTimerElement.cpp: Removed.
  20534. * wml/WMLTimerElement.h: Removed.
  20535. * wml/WMLVariables.cpp: Removed.
  20536. * wml/WMLVariables.h: Removed.
  20537. 2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
  20538. Unreviewed, rolling out r85233 and r85235.
  20539. http://trac.webkit.org/changeset/85233
  20540. http://trac.webkit.org/changeset/85235
  20541. https://bugs.webkit.org/show_bug.cgi?id=59754
  20542. Causes issues with jsc. (Requested by dave_levin on #webkit).
  20543. * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
  20544. * loader/icon/IconDatabase.cpp:
  20545. (WebCore::IconDatabase::defaultIcon):
  20546. (WebCore::IconDatabase::setIconDataForIconURL):
  20547. (WebCore::IconDatabase::getOrCreateIconRecord):
  20548. (WebCore::IconDatabase::readFromDatabase):
  20549. 2011-04-28 Jay Civelli <jcivelli@chromium.org>
  20550. Reviewed by Adam Barth.
  20551. Introducing a new class that allows serialization of a page back
  20552. to HTML/XML with all its sub-frames and also retrieves the page's
  20553. resources.
  20554. Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
  20555. https://bugs.webkit.org/show_bug.cgi?id=58947
  20556. * Android.mk:
  20557. * CMakeLists.txt:
  20558. * GNUmakefile.list.am:
  20559. * WebCore.gypi:
  20560. * WebCore.pro:
  20561. * WebCore.vcproj/WebCore.vcproj:
  20562. * dom/Document.cpp:
  20563. (WebCore::Document::suggestedMIMEType):
  20564. * dom/Document.h:
  20565. * editing/MarkupAccumulator.cpp:
  20566. (WebCore::MarkupAccumulator::appendCustomAttributes):
  20567. (WebCore::MarkupAccumulator::appendElement):
  20568. * editing/MarkupAccumulator.h:
  20569. * html/parser/HTMLMetaCharsetParser.cpp:
  20570. (WebCore::HTMLMetaCharsetParser::processMeta):
  20571. (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
  20572. * html/parser/HTMLMetaCharsetParser.h:
  20573. * page/PageSerializer.cpp: Added.
  20574. * page/PageSerializer.h: Added.
  20575. 2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
  20576. Reviewed by Tony Chang.
  20577. IndexedDB createIndex should fail if name arg is null
  20578. https://bugs.webkit.org/show_bug.cgi?id=58365
  20579. Test: storage/indexeddb/mozilla/create-index-null-name.html
  20580. * storage/IDBObjectStore.idl:
  20581. * storage/IDBObjectStoreBackendImpl.cpp:
  20582. (WebCore::IDBObjectStoreBackendImpl::createIndex):
  20583. 2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
  20584. Reviewed by Tony Chang.
  20585. IndexedDB put() should fail if second (key) parameter is null
  20586. https://bugs.webkit.org/show_bug.cgi?id=58613
  20587. If key arg is not specified, prpKey ends up as a null pointer in ::put().
  20588. However, if the key arg is specified but is null, prpKey ends up as a
  20589. valid IDBKey which has a null key type. As it happens, we need to be able
  20590. to detect the difference between these cases (the key arg is optional but
  20591. if specified must not be null).
  20592. Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
  20593. * storage/IDBObjectStoreBackendImpl.cpp:
  20594. (WebCore::IDBObjectStoreBackendImpl::put):
  20595. 2011-04-07 David Levin <levin@chromium.org>
  20596. Reviewed by Darin Adler.
  20597. Add asserts to RefCounted to make sure ref/deref happens on the right thread.
  20598. https://bugs.webkit.org/show_bug.cgi?id=31639
  20599. No new functionality exposed so no new tests. (The change is basically adding
  20600. more testing.)
  20601. * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
  20602. * loader/icon/IconDatabase.cpp:
  20603. (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
  20604. (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
  20605. (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
  20606. (WebCore::IconDatabase::readFromDatabase): Ditto.
  20607. 2011-04-28 Kenneth Russell <kbr@google.com>
  20608. Unreviewed build fix for Web Audio with strict OwnPtr.
  20609. * platform/audio/HRTFDatabaseLoader.cpp:
  20610. (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
  20611. 2011-04-28 Dominic Cooney <dominicc@chromium.org>
  20612. Reviewed by Geoffrey Garen.
  20613. Walk shadow hosts as well as parent nodes when finding opaque roots.
  20614. https://bugs.webkit.org/show_bug.cgi?id=59571
  20615. Test: fast/dom/shadow/gc-shadow.html
  20616. * bindings/js/JSDOMBinding.h:
  20617. (WebCore::root):
  20618. 2011-04-28 Martin Robinson <mrobinson@igalia.com>
  20619. Reviewed by Xan Lopez.
  20620. [GTK] Click counting logic should be shared between WebKit1 and WebKit2
  20621. https://bugs.webkit.org/show_bug.cgi?id=59715
  20622. Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
  20623. into WebCore so that WebKit1 and WebKit2 can share the code.
  20624. No new tests. This is covered by fast/events/click-count.html.
  20625. * GNUmakefile.list.am: Added new files.
  20626. * platform/gtk/GtkClickCounter.cpp: Added.
  20627. (WebCore::GtkClickCounter::GtkClickCounter): Added.
  20628. (WebCore::GtkClickCounter::reset): Added.
  20629. (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
  20630. (WebCore::getEventTime): Added.
  20631. (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
  20632. * platform/gtk/GtkClickCounter.h: Added.
  20633. 2011-04-28 Dan Bernstein <mitz@apple.com>
  20634. Build fix.
  20635. * css/CSSParser.cpp:
  20636. (WebCore::cssPropertyID):
  20637. 2011-04-28 Dan Bernstein <mitz@apple.com>
  20638. Reviewed by Simon Fraser.
  20639. Allow specifying CSS property aliases in CSSPropertyNames.in files
  20640. https://bugs.webkit.org/show_bug.cgi?id=59712
  20641. * css/CSSParser.cpp:
  20642. (WebCore::cssPropertyID): Removed code to handle some aliases
  20643. * css/CSSPropertyNames.in: Added aliases no longer handled in code.
  20644. * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
  20645. defining an alias, and add an appropriate entry to the gperf file.
  20646. 2011-04-28 Arno Renevier <arno@renevier.net>
  20647. Reviewed by Gustavo Noronha Silva.
  20648. [Soup] does not load css stylesheets without content-type
  20649. https://bugs.webkit.org/show_bug.cgi?id=59697
  20650. When sniffing content type, do not replace http Content-Type header in
  20651. soup message anymore, but keep sniffed content type in a separate
  20652. variable.
  20653. * platform/network/soup/ResourceHandleSoup.cpp:
  20654. (WebCore::contentSniffedCallback):
  20655. * platform/network/soup/ResourceResponse.h:
  20656. (WebCore::ResourceResponse::sniffedContentType):
  20657. (WebCore::ResourceResponse::setSniffedContentType):
  20658. * platform/network/soup/ResourceResponseSoup.cpp:
  20659. (WebCore::ResourceResponse::updateFromSoupMessage):
  20660. 2011-04-28 Yael Aharon <yael.aharon@nokia.com>
  20661. Reviewed by Andreas Kling.
  20662. Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
  20663. https://bugs.webkit.org/show_bug.cgi?id=59704
  20664. No new tests, just code cleanup.
  20665. * WebCore.pri:
  20666. 2011-04-28 Pavel Podivilov <podivilov@chromium.org>
  20667. Reviewed by Pavel Feldman.
  20668. Web Inspector: remove "Pretty print" source frame context menu item.
  20669. https://bugs.webkit.org/show_bug.cgi?id=59709
  20670. * inspector/front-end/DebuggerPresentationModel.js:
  20671. (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
  20672. * inspector/front-end/ScriptsPanel.js:
  20673. (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  20674. * inspector/front-end/SourceFrame.js:
  20675. (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
  20676. 2011-04-28 Satish Sampath <satish@chromium.org>
  20677. Reviewed by Tony Gentilcore.
  20678. Speech input button layout issues with padding and border.
  20679. https://bugs.webkit.org/show_bug.cgi?id=59613
  20680. * rendering/RenderTextControlSingleLine.cpp:
  20681. (WebCore::RenderTextControlSingleLine::layout):
  20682. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  20683. (WebCore::RenderTextControlSingleLine::forwardEvent):
  20684. 2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
  20685. Reviewed by Martin Robinson.
  20686. [GTK] Check whether to use native scrollbars at run time
  20687. https://bugs.webkit.org/show_bug.cgi?id=59694
  20688. It's currently decided at build time depending on whether webkit2
  20689. build is enabled or not. That makes imposible to build both
  20690. webkit1 and webkit2 using the same libWebCore.
  20691. * GNUmakefile.am:
  20692. * platform/ScrollView.cpp:
  20693. (WebCore::ScrollView::wheelEvent):
  20694. * platform/gtk/ScrollViewGtk.cpp:
  20695. (WebCore::ScrollView::createScrollbar):
  20696. 2011-04-28 Pavel Feldman <pfeldman@google.com>
  20697. Reviewed by Yury Semikhatsky.
  20698. Web Inspector: add status bar button for pretty print.
  20699. https://bugs.webkit.org/show_bug.cgi?id=59467
  20700. * WebCore.gypi:
  20701. * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
  20702. * inspector/front-end/ScriptsPanel.js:
  20703. (WebInspector.ScriptsPanel):
  20704. (WebInspector.ScriptsPanel.prototype.get statusBarItems):
  20705. (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  20706. * inspector/front-end/WebKit.qrc:
  20707. * inspector/front-end/inspector.css:
  20708. (.scripts-toggle-pretty-print-status-bar-item .glyph):
  20709. (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
  20710. 2011-04-28 Pavel Feldman <pfeldman@google.com>
  20711. Reviewed by Yury Semikhatsky.
  20712. Web Inspector: add ResourceTreeModel tests.
  20713. https://bugs.webkit.org/show_bug.cgi?id=59616
  20714. Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
  20715. http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  20716. http/tests/inspector/resource-tree/resource-tree-reload.html
  20717. * inspector/front-end/ResourceTreeModel.js:
  20718. (WebInspector.ResourceTreeModel.prototype.frontendReused):
  20719. (WebInspector.ResourceTreeModel.prototype._addFrame):
  20720. (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  20721. (WebInspector.ResourceTreeModel.prototype._frameDetached):
  20722. (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
  20723. (WebInspector.ResourceTreeModel.prototype.forAllResources):
  20724. (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
  20725. (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
  20726. (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  20727. * inspector/front-end/ResourcesPanel.js:
  20728. (WebInspector.ResourcesPanel.prototype._populateResourceTree):
  20729. (WebInspector.ResourcesPanel.prototype._frameAdded):
  20730. (WebInspector.ResourcesPanel.prototype._frameDetached):
  20731. (WebInspector.ResourcesPanel.prototype._frameNavigated):
  20732. (WebInspector.FrameTreeElement):
  20733. (WebInspector.FrameTreeElement.prototype.frameNavigated):
  20734. 2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
  20735. Reviewed by Yury Semikhatsky.
  20736. WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
  20737. https://bugs.webkit.org/show_bug.cgi?id=59592
  20738. * inspector/front-end/DetailedHeapshotGridNodes.js:
  20739. (WebInspector.HeapSnapshotGridNode.prototype._populate):
  20740. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
  20741. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
  20742. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  20743. * inspector/front-end/DetailedHeapshotView.js:
  20744. (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
  20745. (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
  20746. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
  20747. (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
  20748. (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
  20749. (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
  20750. (WebInspector.DetailedHeapshotView.prototype.changeView):
  20751. * inspector/front-end/HeapSnapshot.js:
  20752. (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
  20753. (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
  20754. (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
  20755. (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
  20756. (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
  20757. * inspector/front-end/heapProfiler.css:
  20758. (div.retaining-paths-view td.path-column div:hover):
  20759. 2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
  20760. Reviewed by Yury Semikhatsky.
  20761. Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
  20762. https://bugs.webkit.org/show_bug.cgi?id=59454
  20763. Test: inspector/profiler/heap-snapshot-loader.html
  20764. * inspector/front-end/HeapSnapshot.js:
  20765. (WebInspector.HeapSnapshotLoader):
  20766. (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
  20767. (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
  20768. (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
  20769. (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
  20770. (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
  20771. * inspector/front-end/HeapSnapshotProxy.js:
  20772. (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
  20773. 2011-04-28 ojab <ojab@ojab.ru>
  20774. Reviewed by David Levin.
  20775. Fix build with libpng-1.5.1
  20776. https://bugs.webkit.org/show_bug.cgi?id=59607
  20777. * platform/image-decoders/png/PNGImageDecoder.cpp:
  20778. (WebCore::readColorProfile):
  20779. 2011-04-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
  20780. Reviewed by Nikolas Zimmermann.
  20781. Optimizing gaussian blur filter to ARM-neon SIMD instruction set
  20782. https://bugs.webkit.org/show_bug.cgi?id=59447
  20783. This patch contains two sub-routines, one for speeding up
  20784. alpha channel only gaussian blur (by 2.5 times) and one
  20785. for speeding up all channel blur (by 4 times).
  20786. The common code is also redesigned to better fit for platform
  20787. specific code. This means large chunks of code was moved to
  20788. different files, and all platform specific files are added to
  20789. all build systems.
  20790. * CMakeLists.txt:
  20791. * GNUmakefile.am:
  20792. * GNUmakefile.list.am:
  20793. * WebCore.gypi:
  20794. * WebCore.pro:
  20795. * WebCore.vcproj/WebCore.vcproj:
  20796. * WebCore.vcproj/WebCoreCommon.vsprops:
  20797. * WebCore.xcodeproj/project.pbxproj:
  20798. * platform/graphics/filters/FEGaussianBlur.cpp:
  20799. (WebCore::FEGaussianBlur::platformApplyGeneric):
  20800. (WebCore::FEGaussianBlur::apply):
  20801. * platform/graphics/filters/FEGaussianBlur.h:
  20802. (WebCore::FEGaussianBlur::kernelPosition):
  20803. (WebCore::FEGaussianBlur::platformApply):
  20804. * platform/graphics/filters/FELighting.cpp:
  20805. (WebCore::FELighting::platformApplyGeneric):
  20806. (WebCore::FELighting::drawLighting):
  20807. * platform/graphics/filters/FELighting.h:
  20808. (WebCore::FELighting::platformApply):
  20809. * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
  20810. (WebCore::WTF_ALIGNED):
  20811. (WebCore::feGaussianBlurConstantsForNeon):
  20812. * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
  20813. (WebCore::FEGaussianBlur::platformApplyNeon):
  20814. * platform/graphics/filters/arm/FELightingNEON.cpp:
  20815. (WebCore::WTF_ALIGNED):
  20816. (WebCore::FELighting::getPowerCoefficients):
  20817. * platform/graphics/filters/arm/FELightingNEON.h:
  20818. (WebCore::FELighting::platformApplyNeon):
  20819. 2011-04-28 Alexander Pavlov <apavlov@chromium.org>
  20820. Reviewed by Yury Semikhatsky.
  20821. Web Inspector: provide a hotkey for script pause
  20822. https://bugs.webkit.org/show_bug.cgi?id=59593
  20823. In fact, F8 works as a hotkey, but this fact was not reflected
  20824. in the shortcut help popup.
  20825. * English.lproj/localizedStrings.js:
  20826. * inspector/front-end/ScriptsPanel.js:
  20827. (WebInspector.ScriptsPanel.prototype._registerShortcuts):
  20828. 2011-04-28 Adam Barth <abarth@webkit.org>
  20829. Reviewed by Eric Seidel.
  20830. PluginStream should play nice with strict OwnPtr
  20831. https://bugs.webkit.org/show_bug.cgi?id=59675
  20832. These failures appear when enabling strict OwnPtr on Qt.
  20833. * plugins/PluginStream.cpp:
  20834. (WebCore::PluginStream::PluginStream):
  20835. (WebCore::PluginStream::didReceiveData):
  20836. 2011-04-26 Alexander Pavlov <apavlov@chromium.org>
  20837. Reviewed by Pavel Feldman.
  20838. Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
  20839. https://bugs.webkit.org/show_bug.cgi?id=59326
  20840. Concrete CachedResource successors for stylesheets and scripts
  20841. can decode their content better than the generic approach we use.
  20842. * inspector/InspectorPageAgent.cpp:
  20843. (WebCore::decodeSharedBuffer):
  20844. (WebCore::prepareCachedResourceBuffer):
  20845. (WebCore::cachedResourceDecoded):
  20846. (WebCore::InspectorPageAgent::resourceContent):
  20847. (WebCore::InspectorPageAgent::resourceData):
  20848. * inspector/InspectorStyleSheet.cpp:
  20849. (WebCore::InspectorStyleSheet::originalStyleSheetText):
  20850. 2011-04-28 Jon Lee <jonlee@apple.com>
  20851. Reviewed by Simon Fraser.
  20852. REGRESSION: white overlay scrollbars on apple.com/startpage
  20853. https://bugs.webkit.org/show_bug.cgi?id=59540
  20854. <rdar://problem/9338653>
  20855. Now we look at the document background in addition to the <body> element,
  20856. and blend those colors in with the base background of the frame view to
  20857. arrive at our aggregate color. This provides a better result to determine
  20858. overlay scrollbar style.
  20859. * page/Frame.cpp:
  20860. (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
  20861. * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
  20862. 2011-04-27 Adam Barth <abarth@webkit.org>
  20863. Reviewed by Maciej Stachowiak.
  20864. Fix OwnPtr issues in IndexedDB
  20865. https://bugs.webkit.org/show_bug.cgi?id=59656
  20866. This patch is an attempt to fix the clang build. Clang can't seem to
  20867. cope with OwnPtrs to classes declared in an anonymous namespace because
  20868. OwnPtr's copy constructor isn't defined (but would need to be defined
  20869. in this translation unit).
  20870. * platform/leveldb/LevelDBDatabase.cpp:
  20871. 2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
  20872. Reviewed by Antonio Gomes.
  20873. [EFL] Change cursor to LAZY_NATIVE_CURSOR
  20874. https://bugs.webkit.org/show_bug.cgi?id=59411
  20875. Enable LAZY_NATIVE_CURSOR on EFL build.
  20876. No test added because functionality is unchanged.
  20877. * CMakeListsEfl.txt: Add Cursor.cpp
  20878. * platform/Cursor.h:
  20879. (WebCore::Cursor::Cursor):
  20880. * platform/efl/CursorEfl.cpp:
  20881. (WebCore::Cursor::Cursor):
  20882. (WebCore::Cursor::~Cursor):
  20883. (WebCore::getCursorString):
  20884. (WebCore::Cursor::ensurePlatformCursor):
  20885. * platform/efl/WidgetEfl.cpp:
  20886. (WebCore::Widget::setCursor):
  20887. 2011-04-27 Adam Barth <abarth@webkit.org>
  20888. Build fix from the future. Another trival strict OwnPtr fixes. This
  20889. is the last futuristic build fix I can detect with my time traveling
  20890. abilities.
  20891. * platform/graphics/chromium/TransparencyWin.cpp:
  20892. (WebCore::TransparencyWin::initializeNewContext):
  20893. 2011-04-27 Dmitry Lomov <dslomov@google.com>
  20894. Reviewed by David Levin.
  20895. CrossThreadCopier should not have a default specialization for raw pointers
  20896. https://bugs.webkit.org/show_bug.cgi?id=59234
  20897. Removed the ablity to pass raw pointers cross-thread
  20898. Added and applied annotations for doing that
  20899. * fileapi/FileReader.cpp:
  20900. (WebCore::FileReader::readInternal):
  20901. (WebCore::FileReader::abort):
  20902. * fileapi/FileStreamProxy.cpp:
  20903. (WebCore::FileStreamProxy::startOnFileThread):
  20904. (WebCore::FileStreamProxy::stopOnFileThread):
  20905. (WebCore::FileStreamProxy::getSize):
  20906. (WebCore::FileStreamProxy::getSizeOnFileThread):
  20907. (WebCore::FileStreamProxy::openForRead):
  20908. (WebCore::FileStreamProxy::openForReadOnFileThread):
  20909. (WebCore::FileStreamProxy::openForWrite):
  20910. (WebCore::FileStreamProxy::openForWriteOnFileThread):
  20911. (WebCore::FileStreamProxy::close):
  20912. (WebCore::FileStreamProxy::read):
  20913. (WebCore::FileStreamProxy::readOnFileThread):
  20914. (WebCore::FileStreamProxy::write):
  20915. (WebCore::FileStreamProxy::writeOnFileThread):
  20916. (WebCore::FileStreamProxy::truncate):
  20917. (WebCore::FileStreamProxy::truncateOnFileThread):
  20918. * loader/WorkerThreadableLoader.cpp:
  20919. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  20920. (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
  20921. (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
  20922. * page/GeolocationPositionCache.cpp:
  20923. (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
  20924. (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
  20925. * platform/CrossThreadCopier.h:
  20926. (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
  20927. (WebCore::AllowCrossThreadAccessWrapper::value):
  20928. (WebCore::AllowCrossThreadAccess):
  20929. (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
  20930. (WebCore::AllowExtendedLifetimeWrapper::value):
  20931. (WebCore::AllowExtendedLifetime):
  20932. * platform/graphics/chromium/cc/CCCompletionEvent.h:
  20933. * storage/IDBObjectStoreBackendImpl.cpp:
  20934. (WebCore::IDBObjectStoreBackendImpl::get):
  20935. (WebCore::IDBObjectStoreBackendImpl::put):
  20936. (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
  20937. (WebCore::IDBObjectStoreBackendImpl::clear):
  20938. (WebCore::IDBObjectStoreBackendImpl::createIndex):
  20939. (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
  20940. (WebCore::IDBObjectStoreBackendImpl::openCursor):
  20941. * storage/SQLCallbackWrapper.h:
  20942. (WebCore::SQLCallbackWrapper::clear):
  20943. * websockets/WorkerThreadableWebSocketChannel.cpp:
  20944. (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
  20945. (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
  20946. (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
  20947. (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
  20948. (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
  20949. (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
  20950. (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
  20951. (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
  20952. (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
  20953. * workers/WorkerMessagingProxy.cpp:
  20954. (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  20955. 2011-04-27 Adam Barth <abarth@webkit.org>
  20956. Two build fixes from the future. (Trivial strict OwnPtr fixes.)
  20957. * page/Frame.cpp:
  20958. (WebCore::Frame::setTiledBackingStoreEnabled):
  20959. * platform/audio/ReverbConvolver.cpp:
  20960. (WebCore::ReverbConvolver::ReverbConvolver):
  20961. 2011-04-27 Adam Barth <abarth@webkit.org>
  20962. Reviewed by David Levin.
  20963. Fix five strict PassOwnPtr violations in WebCore
  20964. https://bugs.webkit.org/show_bug.cgi?id=59640
  20965. * css/MediaList.cpp:
  20966. (WebCore::MediaList::deleteMedium):
  20967. (WebCore::MediaList::setMediaText):
  20968. (WebCore::MediaList::appendMedium):
  20969. * css/MediaQuery.h:
  20970. * dom/MessagePort.cpp:
  20971. (WebCore::MessagePort::disentanglePorts):
  20972. (WebCore::MessagePort::entanglePorts):
  20973. * inspector/InspectorStyleSheet.cpp:
  20974. (ParsedStyleSheet::setText):
  20975. * rendering/RenderTheme.cpp:
  20976. (WebCore::RenderTheme::adjustStyle):
  20977. (WebCore::RenderTheme::adjustMeterStyle):
  20978. * rendering/RenderThemeMac.mm:
  20979. (WebCore::RenderThemeMac::adjustMenuListStyle):
  20980. (WebCore::RenderThemeMac::adjustSliderTrackStyle):
  20981. (WebCore::RenderThemeMac::adjustSliderThumbStyle):
  20982. (WebCore::RenderThemeMac::adjustSearchFieldStyle):
  20983. (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
  20984. (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
  20985. (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
  20986. (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
  20987. 2011-04-27 Chris Fleizach <cfleizach@apple.com>
  20988. Reviewed by Beth Dakin.
  20989. <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
  20990. https://bugs.webkit.org/show_bug.cgi?id=59648
  20991. Test: accessibility/aria-fallback-roles.html
  20992. * accessibility/AccessibilityObject.cpp:
  20993. (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
  20994. 2011-04-27 Beth Dakin <bdakin@apple.com>
  20995. Reviewed by Dan Bernstein.
  20996. https://bugs.webkit.org/show_bug.cgi?id=59671
  20997. Race condition with scrollbar animations and closing a page can cause a crash in
  20998. WebCore::FrameView::setVisibleScrollerThumbRect + 15
  20999. -and corresponding-
  21000. <rdar://problem/9329253>
  21001. It is definitely possible for Page to be null here. So we should null-check it!
  21002. And we should not ASSERT.
  21003. * page/FrameView.cpp:
  21004. (WebCore::FrameView::didCompleteRubberBand):
  21005. (WebCore::FrameView::scrollbarStyleChanged):
  21006. (WebCore::FrameView::setVisibleScrollerThumbRect):
  21007. 2011-04-27 Ryosuke Niwa <rniwa@webkit.org>
  21008. WinCE build fix after r85143.
  21009. * platform/graphics/wince/FontWinCE.cpp:
  21010. (WebCore::TextRunComponent::TextRunComponent):
  21011. 2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
  21012. Reviewed by Tony Chang.
  21013. IndexedDB object store delete should fail if key is null
  21014. https://bugs.webkit.org/show_bug.cgi?id=58614
  21015. Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
  21016. * storage/IDBObjectStoreBackendImpl.cpp:
  21017. (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
  21018. 2011-04-27 Eric Seidel <eric@webkit.org>
  21019. Reviewed by Ryosuke Niwa.
  21020. Should have an easy way to construct starting BidiStatus for a paragraph root
  21021. https://bugs.webkit.org/show_bug.cgi?id=59226
  21022. Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
  21023. I've made this a constructor for BidiStatus instead.
  21024. As part of this effort I added a direction() accessor for TextRun and got
  21025. rid of the old m_rtl bool. This is part of the generic effort in the
  21026. Bidi code to replace old bool usage with the superior TextDirection enum
  21027. (this generally makes the code cleaner).
  21028. As part of this replacement effort I found several places which were
  21029. assuming LTR (by passing rtl=false) when they probably want to use
  21030. the current text direction. I suspect that LTR vs. RTL may affect
  21031. string width in the case of ligatures. It's unclear.
  21032. This is almost entirely a mechanical change.
  21033. * html/canvas/CanvasRenderingContext2D.cpp:
  21034. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  21035. * platform/graphics/GraphicsContext.cpp:
  21036. (WebCore::GraphicsContext::drawBidiText):
  21037. * platform/graphics/TextRun.h:
  21038. (WebCore::TextRun::TextRun):
  21039. (WebCore::TextRun::direction):
  21040. (WebCore::TextRun::rtl):
  21041. (WebCore::TextRun::ltr):
  21042. (WebCore::TextRun::setDirection):
  21043. * platform/text/BidiResolver.h:
  21044. (WebCore::BidiStatus::BidiStatus):
  21045. * rendering/EllipsisBox.cpp:
  21046. (WebCore::EllipsisBox::paint):
  21047. (WebCore::EllipsisBox::selectionRect):
  21048. (WebCore::EllipsisBox::paintSelection):
  21049. * rendering/InlineTextBox.cpp:
  21050. (WebCore::InlineTextBox::selectionRect):
  21051. (WebCore::InlineTextBox::paint):
  21052. (WebCore::InlineTextBox::paintSelection):
  21053. (WebCore::InlineTextBox::paintCompositionBackground):
  21054. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  21055. (WebCore::InlineTextBox::paintTextMatchMarker):
  21056. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  21057. (WebCore::InlineTextBox::offsetForPosition):
  21058. (WebCore::InlineTextBox::positionForOffset):
  21059. * rendering/RenderBlockLineLayout.cpp:
  21060. (WebCore::RenderBlock::determineStartPosition):
  21061. * rendering/RenderFileUploadControl.cpp:
  21062. (WebCore::RenderFileUploadControl::paintObject):
  21063. (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  21064. * rendering/RenderListBox.cpp:
  21065. (WebCore::RenderListBox::updateFromElement):
  21066. (WebCore::RenderListBox::paintItemForeground):
  21067. * rendering/RenderTextControl.cpp:
  21068. (WebCore::RenderTextControl::getAvgCharWidth):
  21069. (WebCore::RenderTextControl::paintPlaceholder):
  21070. * rendering/svg/SVGInlineTextBox.cpp:
  21071. (WebCore::SVGInlineTextBox::constructTextRun):
  21072. * rendering/svg/SVGTextMetrics.cpp:
  21073. (WebCore::constructTextRun):
  21074. 2011-04-27 Robert Hogan <robert@webkit.org>
  21075. Reviewed by Adam Barth.
  21076. Allow shadowing of history object
  21077. https://bugs.webkit.org/show_bug.cgi?id=55965
  21078. Tests: http/tests/history/cross-origin-replace-history-object-child.html
  21079. http/tests/history/cross-origin-replace-history-object.html
  21080. * page/DOMWindow.idl:
  21081. 2011-04-27 James Robinson <jamesr@chromium.org>
  21082. Reviewed by Kenneth Russell.
  21083. [chromium] Ensure compositing layers are up to date before entering doComposite
  21084. https://bugs.webkit.org/show_bug.cgi?id=59159
  21085. Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
  21086. GraphicsLayerClient::paintContents() implementations).
  21087. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  21088. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  21089. * platform/graphics/chromium/LayerChromium.cpp:
  21090. (WebCore::LayerChromium::LayerChromium):
  21091. (WebCore::LayerChromium::~LayerChromium):
  21092. * platform/graphics/chromium/LayerRendererChromium.cpp:
  21093. (WebCore::LayerRendererChromium::updateLayers):
  21094. * platform/graphics/chromium/LayerRendererChromium.h:
  21095. Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
  21096. 2011-04-27 James Robinson <jamesr@chromium.org>
  21097. Reviewed by Adam Barth.
  21098. Fix OwnPtr strict issues in chromium linux build
  21099. https://bugs.webkit.org/show_bug.cgi?id=59664
  21100. * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
  21101. (WebCore::ComplexTextController::getNormalizedTextRun):
  21102. * platform/graphics/skia/ImageBufferSkia.cpp:
  21103. (WebCore::ImageBuffer::ImageBuffer):
  21104. * platform/graphics/skia/PlatformContextSkia.cpp:
  21105. (WebCore::PlatformContextSkia::PlatformContextSkia):
  21106. 2011-04-27 Chris Rogers <crogers@google.com>
  21107. Reviewed by Kenneth Russell.
  21108. Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
  21109. https://bugs.webkit.org/show_bug.cgi?id=59641
  21110. No new tests since audio API is not yet implemented.
  21111. * platform/audio/AudioBus.cpp:
  21112. (WebCore::AudioBus::createBySampleRateConverting):
  21113. (WebCore::AudioBus::createByMixingToMono):
  21114. 2011-04-27 Geoffrey Garen <ggaren@apple.com>
  21115. Motivated by Alexey Proskuryakov.
  21116. * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
  21117. informative, since it confused Alexey and me.
  21118. 2011-04-27 Geoffrey Garen <ggaren@apple.com>
  21119. Reviewed by Sam Weinig.
  21120. Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
  21121. https://bugs.webkit.org/show_bug.cgi?id=59646
  21122. Made the cssValueRoots map per-world, instead of a global. When we deallocate
  21123. a world, we need to clear all entries in the map for that world, since
  21124. the finalizers that would otherwise clear those entries don't run. The
  21125. simplest way to do this is just to make the world own the map.
  21126. * bindings/js/DOMWrapperWorld.h:
  21127. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  21128. (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
  21129. * bindings/js/JSCSSValueCustom.cpp:
  21130. (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
  21131. (WebCore::JSCSSValueOwner::finalize):
  21132. * bindings/js/JSDOMBinding.h:
  21133. 2011-04-27 Adam Barth <abarth@webkit.org>
  21134. Reviewed by David Levin.
  21135. Fix OwnPtr issues in IndexedDB
  21136. https://bugs.webkit.org/show_bug.cgi?id=59656
  21137. I didn't do an exhaustive review of this code, but I fixed the problems
  21138. caught by turning on strict OwnPtr and all their antecedents. This
  21139. patch is entirely tighter bookkeeping. There shouldn't be any actual
  21140. behavior change.
  21141. * platform/leveldb/LevelDBDatabase.cpp:
  21142. (WebCore::LevelDBDatabase::LevelDBDatabase):
  21143. (WebCore::LevelDBDatabase::open):
  21144. (WebCore::LevelDBDatabase::createIterator):
  21145. * platform/leveldb/LevelDBDatabase.h:
  21146. * platform/leveldb/LevelDBIterator.cpp:
  21147. (WebCore::LevelDBIterator::LevelDBIterator):
  21148. * platform/leveldb/LevelDBIterator.h:
  21149. * storage/IDBLevelDBBackingStore.cpp:
  21150. (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  21151. (WebCore::IDBLevelDBBackingStore::open):
  21152. (WebCore::getNewDatabaseId):
  21153. (WebCore::IDBLevelDBBackingStore::getObjectStores):
  21154. (WebCore::getNewObjectStoreId):
  21155. (WebCore::deleteRange):
  21156. (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
  21157. (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
  21158. (WebCore::IDBLevelDBBackingStore::getIndexes):
  21159. (WebCore::getNewIndexId):
  21160. (WebCore::findGreatestKeyLessThan):
  21161. (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
  21162. (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
  21163. (WebCore::findLastIndexKeyEqualTo):
  21164. * storage/IDBLevelDBBackingStore.h:
  21165. 2011-04-19 MORITA Hajime <morrita@google.com>
  21166. Reviewed by Tony Chang.
  21167. [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
  21168. https://bugs.webkit.org/show_bug.cgi?id=58113
  21169. * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
  21170. * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
  21171. * Now MarkerMapVectorPair is no longer used.
  21172. No new tests, No behavior change.
  21173. * GNUmakefile.list.am:
  21174. * WebCore.gypi:
  21175. * WebCore.pro:
  21176. * WebCore.vcproj/WebCore.vcproj:
  21177. * WebCore.xcodeproj/project.pbxproj:
  21178. * dom/DocumentMarker.h:
  21179. * dom/DocumentMarkerController.cpp:
  21180. (WebCore::DocumentMarkerController::addMarker):
  21181. (WebCore::DocumentMarkerController::copyMarkers):
  21182. (WebCore::DocumentMarkerController::removeMarkers):
  21183. (WebCore::DocumentMarkerController::markerContainingPoint):
  21184. (WebCore::DocumentMarkerController::markersForNode):
  21185. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  21186. (WebCore::DocumentMarkerController::removeMarkersFromList):
  21187. (WebCore::DocumentMarkerController::repaintMarkers):
  21188. (WebCore::DocumentMarkerController::setRenderedRectForMarker):
  21189. (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
  21190. (WebCore::DocumentMarkerController::shiftMarkers):
  21191. (WebCore::DocumentMarkerController::setMarkersActive):
  21192. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  21193. (WebCore::DocumentMarkerController::showMarkers):
  21194. * dom/DocumentMarkerController.h:
  21195. * dom/RenderedDocumentMarker.h: Added.
  21196. (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
  21197. (WebCore::RenderedDocumentMarker::isRendered):
  21198. (WebCore::RenderedDocumentMarker::contains):
  21199. (WebCore::RenderedDocumentMarker::setRenderedRect):
  21200. (WebCore::RenderedDocumentMarker::renderedRect):
  21201. (WebCore::RenderedDocumentMarker::invalidate):
  21202. (WebCore::RenderedDocumentMarker::invalidMarkerRect):
  21203. 2011-04-27 James Robinson <jamesr@chromium.org>
  21204. Unreviewed, rolling out r85112.
  21205. http://trac.webkit.org/changeset/85112
  21206. https://bugs.webkit.org/show_bug.cgi?id=59159
  21207. Broke mac compile
  21208. * page/FrameView.cpp:
  21209. (WebCore::FrameView::updateCompositingLayers):
  21210. * page/FrameView.h:
  21211. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  21212. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  21213. * platform/graphics/chromium/LayerChromium.cpp:
  21214. (WebCore::LayerChromium::LayerChromium):
  21215. (WebCore::LayerChromium::~LayerChromium):
  21216. * platform/graphics/chromium/LayerRendererChromium.cpp:
  21217. (WebCore::LayerRendererChromium::updateLayers):
  21218. * platform/graphics/chromium/LayerRendererChromium.h:
  21219. 2011-04-27 Mark Rowe <mrowe@apple.com>
  21220. Build fix.
  21221. * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
  21222. 2011-04-27 Pratik Solanki <psolanki@apple.com>
  21223. Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
  21224. * platform/network/ResourceHandleClient.h:
  21225. 2011-04-27 James Robinson <jamesr@chromium.org>
  21226. Reviewed by Kenneth Russell.
  21227. [chromium] Ensure compositing layers are up to date before entering doComposite
  21228. https://bugs.webkit.org/show_bug.cgi?id=59159
  21229. Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
  21230. GraphicsLayerClient::paintContents() implementations).
  21231. * page/FrameView.cpp:
  21232. (WebCore::FrameView::updateCompositingLayers):
  21233. Add an optional CompositingUpdateType parameter.
  21234. * page/FrameView.h:
  21235. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  21236. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  21237. * platform/graphics/chromium/LayerChromium.cpp:
  21238. (WebCore::LayerChromium::LayerChromium):
  21239. (WebCore::LayerChromium::~LayerChromium):
  21240. * platform/graphics/chromium/LayerRendererChromium.cpp:
  21241. (WebCore::LayerRendererChromium::updateLayers):
  21242. * platform/graphics/chromium/LayerRendererChromium.h:
  21243. Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
  21244. * rendering/RenderLayer.cpp:
  21245. (WebCore::RenderLayer::dirtyZOrderLists):
  21246. (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
  21247. * rendering/RenderLayerCompositor.cpp:
  21248. (WebCore::RenderLayerCompositor::updateCompositingLayers):
  21249. * rendering/RenderLayerCompositor.h:
  21250. Fix a typo in CompositingUpdateType Pait->Paint
  21251. 2011-04-27 Pratik Solanki <psolanki@apple.com>
  21252. Reviewed by Antti Koivisto.
  21253. Part of WebCore should use CFNetwork-based loader on Mac
  21254. https://bugs.webkit.org/show_bug.cgi?id=51836
  21255. Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
  21256. willCacheResponse/shouldCacheResponse.
  21257. * loader/EmptyClients.h:
  21258. * loader/FrameLoaderClient.h:
  21259. * loader/ResourceLoader.h:
  21260. * loader/cf/ResourceLoaderCFNet.cpp:
  21261. * loader/mac/ResourceLoaderMac.mm:
  21262. (WebCore::ResourceLoader::willCacheResponse):
  21263. * platform/network/ResourceHandleClient.h:
  21264. (WebCore::ResourceHandleClient::willCacheResponse):
  21265. (WebCore::ResourceHandleClient::shouldCacheResponse):
  21266. * platform/network/cf/ResourceHandleCFNet.cpp:
  21267. (WebCore::willCacheResponse):
  21268. 2011-04-27 Ilya Tikhonovsky <loislo@chromium.org>
  21269. Reviewed by Brian Weinstein.
  21270. Web Inspector: Stop on Exception state does not persist.
  21271. A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
  21272. https://bugs.webkit.org/show_bug.cgi?id=59630
  21273. * inspector/front-end/ScriptsPanel.js:
  21274. (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
  21275. (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
  21276. (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  21277. 2011-04-27 Adrienne Walker <enne@google.com>
  21278. [chromium] Unreviewed, rollout r85075 (scissor rect changes)
  21279. https://bugs.webkit.org/show_bug.cgi?id=59020
  21280. * platform/graphics/chromium/LayerRendererChromium.cpp:
  21281. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  21282. 2011-04-27 Darin Adler <darin@apple.com>
  21283. Reviewed by David Levin.
  21284. Fix strict OwnPtr issues seen in about 30 more files
  21285. https://bugs.webkit.org/show_bug.cgi?id=59615
  21286. * bindings/js/JSCallbackData.h:
  21287. (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
  21288. * bindings/js/JSMessageEventCustom.cpp:
  21289. (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
  21290. * css/CSSParser.cpp:
  21291. (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
  21292. adoptPtr, and release.
  21293. * dom/MessageEvent.cpp:
  21294. (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
  21295. and release.
  21296. * dom/MessagePortChannel.cpp:
  21297. (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
  21298. * dom/ScriptExecutionContext.cpp:
  21299. (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
  21300. * dom/XMLDocumentParserLibxml2.cpp:
  21301. (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
  21302. * dom/default/PlatformMessagePortChannel.cpp:
  21303. (WebCore::MessagePortChannel::create): Use adoptPtr.
  21304. * html/HTMLFormControlElement.cpp:
  21305. (WebCore::HTMLFormControlElement::detach): Use nullptr.
  21306. * inspector/InspectorAgent.cpp:
  21307. (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
  21308. * inspector/InspectorConsoleAgent.cpp:
  21309. (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
  21310. (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
  21311. (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
  21312. * inspector/InspectorController.cpp:
  21313. (WebCore::InspectorController::connectFrontend): Use adoptPtr.
  21314. * inspector/InspectorDOMAgent.cpp:
  21315. (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
  21316. * inspector/InspectorResourceAgent.cpp:
  21317. (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
  21318. * page/FrameActionScheduler.cpp:
  21319. (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
  21320. * platform/graphics/ShadowBlur.cpp:
  21321. (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
  21322. * platform/graphics/ca/GraphicsLayerCA.cpp:
  21323. (WebCore::GraphicsLayer::create): Use adoptPtr.
  21324. (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
  21325. (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
  21326. * rendering/RenderBlock.cpp:
  21327. (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
  21328. (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
  21329. (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
  21330. (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
  21331. * rendering/RenderLayerBacking.cpp:
  21332. (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
  21333. (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
  21334. (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
  21335. (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
  21336. * rendering/RenderLayerCompositor.cpp:
  21337. (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
  21338. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
  21339. (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
  21340. * rendering/style/StyleRareNonInheritedData.cpp:
  21341. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
  21342. explicit initializations of OwnPtr members to 0. Use adoptPtr.
  21343. * workers/SharedWorkerContext.cpp:
  21344. (WebCore::createConnectEvent): Use adoptPtr.
  21345. * workers/Worker.cpp:
  21346. (WebCore::Worker::notifyFinished): Use nullptr.
  21347. 2011-04-27 Enrica Casucci <enrica@apple.com>
  21348. Reviewed by Darin Adler.
  21349. REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
  21350. https://bugs.webkit.org/show_bug.cgi?id=59251
  21351. <rdar://problem/9327044>
  21352. When we are looking for wrapping elements that are presentational, we should
  21353. include elements that have a non transparent background color only if they
  21354. are not blocks.
  21355. Test: editing/pasteboard/do-not-copy-body-color.html
  21356. * editing/markup.cpp:
  21357. (WebCore::isElementPresentational):
  21358. 2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
  21359. Reviewed by Antti Koivisto.
  21360. Teach sub-selector chains about shadow descendants
  21361. https://bugs.webkit.org/show_bug.cgi?id=58342
  21362. The primary change is to the logic of parsing specifiers:
  21363. 1) The shadow descendant selectors (those specifiers that are unknown
  21364. pseudo element selectors) are always kept at the top of the chain.
  21365. 2) The sub-selectors after shadow descendant selectors are stashed right
  21366. behind the sub-selector, but not at the end of the chain.
  21367. 3) Other sub-selectors are appended at the end of the chain.
  21368. * css/CSSGrammar.y: Changed specifier_list collection to use new
  21369. CSSParser::updateSpecifier helper.
  21370. * css/CSSParser.cpp:
  21371. (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
  21372. look for the last ShadowDescendant relation in the chain of selectors,
  21373. because the next selector after it is the one that should get the
  21374. element name.
  21375. (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
  21376. CSSGrammar.y. The new logic adjusts the selector chain to allow
  21377. shadow descendant selectors have sub-selectors (and have multiple shadow
  21378. descendants in the chain).
  21379. * css/CSSParser.h: Added decl.
  21380. * css/CSSParserValues.cpp:
  21381. (WebCore::CSSParserSelector::insertTagHistory): Added.
  21382. (WebCore::CSSParserSelector::appendTagHistory): Aded.
  21383. * css/CSSParserValues.h: Added decls.
  21384. * css/CSSStyleSelector.cpp:
  21385. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
  21386. shadow descendant selector match check, since now there could be many
  21387. of them in the selector chain.
  21388. 2011-04-20 Adrienne Walker <enne@google.com>
  21389. Reviewed by Kenneth Russell.
  21390. [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
  21391. https://bugs.webkit.org/show_bug.cgi?id=59020
  21392. mapRect is the incorrect transform here. The parent scissor rect
  21393. needs to be projected into layer space instead.
  21394. Test: compositing/flat-with-transformed-child.html
  21395. * platform/graphics/chromium/LayerRendererChromium.cpp:
  21396. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  21397. 2011-04-27 Pratik Solanki <psolanki@apple.com>
  21398. Reviewed by Antti Koivisto.
  21399. Part of WebCore should use CFNetwork-based loader on Mac
  21400. https://bugs.webkit.org/show_bug.cgi?id=51836
  21401. * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
  21402. * platform/mac/SoftLinking.h:
  21403. * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
  21404. 2011-04-27 Nikolas Zimmermann <nzimmermann@rim.com>
  21405. Reviewed by Antti Koivisto.
  21406. Cleanup CSSStyleApplyProperty.cpp
  21407. https://bugs.webkit.org/show_bug.cgi?id=59623
  21408. As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
  21409. Use typedefs instead of repating the function pointer declarations in a few places.
  21410. * css/CSSStyleApplyProperty.cpp:
  21411. (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
  21412. (WebCore::ApplyPropertyColor::ApplyPropertyColor):
  21413. (WebCore::ApplyPropertyColor::applyInheritValue):
  21414. (WebCore::ApplyPropertyColor::applyInitialValue):
  21415. (WebCore::ApplyPropertyColor::applyValue):
  21416. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  21417. 2011-04-27 Dan Bernstein <mitz@apple.com>
  21418. Reviewed by Anders Carlsson.
  21419. <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
  21420. https://bugs.webkit.org/show_bug.cgi?id=59622
  21421. Test: fast/borders/border-image-trumps-radius.html
  21422. * rendering/RenderBox.cpp:
  21423. (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
  21424. image, then border radius is ignored, so no bleed avoidance is needed.
  21425. * rendering/RenderObject.cpp:
  21426. (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
  21427. (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
  21428. * rendering/RenderObject.h:
  21429. 2011-02-03 Martin Robinson <mrobinson@igalia.com>
  21430. Reviewed by Xan Lopez.
  21431. [GTK] editing/pasteboard/copy-standalone-image.html fails
  21432. https://bugs.webkit.org/show_bug.cgi?id=53645
  21433. When writing an image to the clipboard, also write the URL and title
  21434. into the markup and URL portion. This change also abstracts a helper
  21435. imageToMarkup into markup.{cpp/h} from several different locations
  21436. throughout the platform layer.
  21437. * editing/markup.h: Added new function definition.
  21438. * editing/markup.cpp:
  21439. (WebCore::imageToMarkup): Add this function which turns an image URL
  21440. and element into some markup representing that image, while preserving
  21441. non-src attributes.
  21442. * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
  21443. to markup.cpp.
  21444. * platform/gtk/PasteboardGtk.cpp:
  21445. (WebCore::getURLForImageNode): Add this helper which gets the appropriate
  21446. image URL for a variety of image tag types.
  21447. (WebCore::Pasteboard::writeImage): Write the image URL and title to the
  21448. markup and URL portions of the clipboard. This will ensure that images
  21449. paste properly back into WebKit.
  21450. * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
  21451. one from markup.h
  21452. 2011-04-27 Steve Block <steveblock@google.com>
  21453. Reviewed by David Levin.
  21454. Remove Android build system
  21455. https://bugs.webkit.org/show_bug.cgi?id=48111
  21456. This is to avoid the maintenance burden until the Android port is
  21457. fully upstreamed.
  21458. No new tests, build change only.
  21459. * Android.derived.jscbindings.mk: Removed.
  21460. * Android.derived.mk: Removed.
  21461. * Android.derived.v8bindings.mk: Removed.
  21462. * Android.jscbindings.mk: Removed.
  21463. * Android.mk: Removed.
  21464. * Android.v8bindings.mk: Removed.
  21465. 2011-04-27 Darin Adler <darin@apple.com>
  21466. Reviewed by Sam Weinig.
  21467. Somehow about:blank gets into the icon database
  21468. https://bugs.webkit.org/show_bug.cgi?id=58067
  21469. rdar://problem/6751446
  21470. Implemented the policy Brady suggested, where only http and https URLs can
  21471. be associated with and icon, guarding both on the way in to the database,
  21472. and on the way out.
  21473. * loader/icon/IconDatabase.cpp:
  21474. (WebCore::pageCanHaveIcon): Added.
  21475. (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
  21476. instead of just checking for an empty URL.
  21477. (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
  21478. (WebCore::IconDatabase::retainIconForPageURL): Ditto.
  21479. (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
  21480. (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
  21481. (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
  21482. (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
  21483. two separate assertions and added a third.
  21484. (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
  21485. * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
  21486. (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
  21487. overloaded it to work on both UChar and char, and added an assertion to it.
  21488. Also moved this to the top of the file and made the UChar version usable
  21489. in the shared code used even by Google.
  21490. (WebCore::KURL::invalidate): Updated for name change.
  21491. (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
  21492. toASCIILower since it's faster.
  21493. (WebCore::KURL::parse): Updated for name changes.
  21494. (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
  21495. since it's faster.
  21496. (WebCore::protocolIsInHTTPFamily): Added.
  21497. * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
  21498. to protocolIsInHTTPFamily and added a version that works on a string.
  21499. Kept the old name as an inline function so we don't have to rename
  21500. all the cal sites now.
  21501. * platform/KURLGoogle.cpp: Renamed as above.
  21502. (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
  21503. (WebCore::KURLGooglePrivate::setUtf8): Ditto.
  21504. (WebCore::KURLGooglePrivate::setAscii): Ditto.
  21505. (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
  21506. (WebCore::KURLGooglePrivate::copyTo): Ditto.
  21507. (WebCore::KURL::KURL): Ditto.
  21508. (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
  21509. (WebCore::KURL::invalidate): Ditto.
  21510. * platform/KURLGooglePrivate.h: Ditto.
  21511. * WebCore.exp.in: Updated for above changes.
  21512. 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
  21513. Reviewed by Pavel Feldman.
  21514. Web Inspector: browser crash on evaluation of 'throw undefined'
  21515. https://bugs.webkit.org/show_bug.cgi?id=59611
  21516. Test: inspector/console/console-eval-throw-undefined.html
  21517. * inspector/InjectedScriptSource.js: use try/catch to protect from
  21518. exception during conversion of another exception to string.
  21519. 2011-04-27 Pavel Feldman <pfeldman@google.com>
  21520. Reviewed by Yury Semikhatsky.
  21521. Web Inspector: clicking bookmarklet multiplies resources panel entries.
  21522. https://bugs.webkit.org/show_bug.cgi?id=59590
  21523. * inspector/front-end/ResourceTreeModel.js:
  21524. (WebInspector.ResourceTreeModel):
  21525. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  21526. (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  21527. * inspector/front-end/ResourcesPanel.js:
  21528. (WebInspector.ResourcesPanel.prototype._populateResourceTree):
  21529. (WebInspector.FrameTreeElement):
  21530. (WebInspector.FrameTreeElement.prototype.appendResource):
  21531. * inspector/front-end/inspector.js:
  21532. (WebInspector.frontendReused):
  21533. 2011-04-27 Pavel Feldman <pfeldman@google.com>
  21534. Reviewed by Yury Semikhatsky.
  21535. Web Inspector: opening bookmarklet disconnects DOM agent.
  21536. https://bugs.webkit.org/show_bug.cgi?id=59588
  21537. * inspector/InspectorDOMAgent.cpp:
  21538. (WebCore::InspectorDOMAgent::setDocument):
  21539. 2011-04-27 Hans Wennborg <hans@chromium.org>
  21540. Reviewed by Tony Gentilcore.
  21541. IndexedDB: Fix compiler warnings about uninitialized variables
  21542. https://bugs.webkit.org/show_bug.cgi?id=59599
  21543. Build fix. No new tests.
  21544. * storage/IDBLevelDBBackingStore.cpp:
  21545. (WebCore::getNewObjectStoreId):
  21546. (WebCore::getNewIndexId):
  21547. 2011-04-26 Hans Wennborg <hans@chromium.org>
  21548. Reviewed by Tony Gentilcore.
  21549. IndexedDB: Move LevelDB key coding routines to separate file
  21550. https://bugs.webkit.org/show_bug.cgi?id=59452
  21551. Move all routines concerned with encoding, decoding and comparison of
  21552. LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
  21553. IDBLevelDBCoding.cpp.
  21554. This makes IDBLevelDBBackingStore.cpp easier to work with, and will
  21555. allow for unit testing of the coding routines.
  21556. No new functionality, no new tests.
  21557. * WebCore.gypi:
  21558. * storage/IDBLevelDBBackingStore.cpp:
  21559. (WebCore::getInt):
  21560. (WebCore::putInt):
  21561. (WebCore::getString):
  21562. (WebCore::putString):
  21563. (WebCore::compareKeys):
  21564. (WebCore::compareIndexKeys):
  21565. (WebCore::Comparator::compare):
  21566. (WebCore::setUpMetadata):
  21567. (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
  21568. (WebCore::getNewDatabaseId):
  21569. (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
  21570. (WebCore::IDBLevelDBBackingStore::getObjectStores):
  21571. (WebCore::getNewObjectStoreId):
  21572. (WebCore::IDBLevelDBBackingStore::createObjectStore):
  21573. (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
  21574. (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
  21575. (WebCore::getNewVersionNumber):
  21576. (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
  21577. (WebCore::IDBLevelDBBackingStore::clearObjectStore):
  21578. (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
  21579. (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
  21580. (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
  21581. (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
  21582. (WebCore::IDBLevelDBBackingStore::getIndexes):
  21583. (WebCore::getNewIndexId):
  21584. (WebCore::IDBLevelDBBackingStore::createIndex):
  21585. (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
  21586. (WebCore::versionExists):
  21587. (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
  21588. (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
  21589. (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
  21590. (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
  21591. (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  21592. * storage/IDBLevelDBCoding.cpp: Added.
  21593. (WebCore::IDBLevelDBCoding::encodeByte):
  21594. (WebCore::IDBLevelDBCoding::maxIDBKey):
  21595. (WebCore::IDBLevelDBCoding::minIDBKey):
  21596. (WebCore::IDBLevelDBCoding::encodeInt):
  21597. (WebCore::IDBLevelDBCoding::decodeInt):
  21598. (WebCore::IDBLevelDBCoding::encodeVarInt):
  21599. (WebCore::IDBLevelDBCoding::decodeVarInt):
  21600. (WebCore::IDBLevelDBCoding::encodeString):
  21601. (WebCore::IDBLevelDBCoding::decodeString):
  21602. (WebCore::IDBLevelDBCoding::encodeStringWithLength):
  21603. (WebCore::IDBLevelDBCoding::decodeStringWithLength):
  21604. (WebCore::IDBLevelDBCoding::encodeDouble):
  21605. (WebCore::IDBLevelDBCoding::decodeDouble):
  21606. (WebCore::IDBLevelDBCoding::encodeIDBKey):
  21607. (WebCore::IDBLevelDBCoding::decodeIDBKey):
  21608. (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
  21609. (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
  21610. (WebCore::IDBLevelDBCoding::compare):
  21611. (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
  21612. (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
  21613. (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
  21614. (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
  21615. (WebCore::IDBLevelDBCoding::KeyPrefix::type):
  21616. (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
  21617. (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
  21618. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
  21619. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
  21620. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
  21621. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
  21622. (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
  21623. (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
  21624. (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
  21625. (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
  21626. (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
  21627. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
  21628. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
  21629. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
  21630. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
  21631. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
  21632. (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
  21633. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
  21634. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
  21635. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
  21636. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
  21637. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
  21638. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
  21639. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
  21640. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
  21641. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
  21642. (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
  21643. (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
  21644. (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
  21645. (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
  21646. (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
  21647. (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
  21648. (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
  21649. (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
  21650. (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
  21651. (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
  21652. (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
  21653. (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
  21654. (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
  21655. (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
  21656. (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
  21657. (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
  21658. (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
  21659. (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
  21660. (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
  21661. (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
  21662. (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
  21663. (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
  21664. (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
  21665. (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
  21666. (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
  21667. (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
  21668. (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
  21669. (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
  21670. (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
  21671. (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
  21672. (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
  21673. * storage/IDBLevelDBCoding.h: Added.
  21674. (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
  21675. (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
  21676. (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
  21677. (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
  21678. (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
  21679. 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
  21680. Reviewed by Pavel Feldman.
  21681. Web Inspector: expose exception details when script is paused on exception
  21682. https://bugs.webkit.org/show_bug.cgi?id=59591
  21683. When script is paused on an exception, the exception value is added as <exception>
  21684. property in the local scope and the breakpoint details message says
  21685. "Paused on excepion: '<exception to strin value>'."
  21686. * English.lproj/localizedStrings.js:
  21687. * inspector/front-end/ScopeChainSidebarPane.js:
  21688. (WebInspector.ScopeChainSidebarPane.prototype.update):
  21689. * inspector/front-end/ScriptsPanel.js:
  21690. (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
  21691. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  21692. 2011-04-26 Yury Semikhatsky <yurys@chromium.org>
  21693. Reviewed by Pavel Feldman.
  21694. Web Inspector: [protocol] Paused event should expose exception value that caused it
  21695. https://bugs.webkit.org/show_bug.cgi?id=58996
  21696. Debug.pause event now contains an optional reference to the exception
  21697. object in case script execution is paused on a JavaScript exception.
  21698. Also JavaScript call frames are passed directly into the injected script when
  21699. we need to wrap them for passing to the front-end. This change breaks cyclic
  21700. dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
  21701. * bindings/js/JSInjectedScriptHostCustom.cpp:
  21702. * bindings/js/ScriptDebugServer.cpp:
  21703. (WebCore::ScriptDebugServer::dispatchDidPause):
  21704. * bindings/js/ScriptDebugServer.h:
  21705. * bindings/v8/ScriptDebugServer.cpp:
  21706. (WebCore::ScriptDebugServer::breakProgram):
  21707. (WebCore::ScriptDebugServer::editScriptSource):
  21708. (WebCore::ScriptDebugServer::breakProgramCallback):
  21709. (WebCore::ScriptDebugServer::handleV8DebugEvent):
  21710. * bindings/v8/ScriptDebugServer.h:
  21711. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  21712. * inspector/InjectedScript.cpp:
  21713. (WebCore::InjectedScript::evaluateOnCallFrame):
  21714. (WebCore::InjectedScript::wrapCallFrames):
  21715. * inspector/InjectedScript.h:
  21716. * inspector/InjectedScriptHost.cpp:
  21717. * inspector/InjectedScriptHost.h:
  21718. (WebCore::InjectedScriptHost::init):
  21719. * inspector/InjectedScriptHost.idl:
  21720. * inspector/InjectedScriptSource.js:
  21721. (.):
  21722. * inspector/Inspector.json:
  21723. * inspector/InspectorAgent.cpp:
  21724. (WebCore::InspectorAgent::InspectorAgent):
  21725. * inspector/InspectorDebuggerAgent.cpp:
  21726. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  21727. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  21728. (WebCore::InspectorDebuggerAgent::wrapCallFrames):
  21729. (WebCore::InspectorDebuggerAgent::didPause):
  21730. (WebCore::InspectorDebuggerAgent::didContinue):
  21731. (WebCore::InspectorDebuggerAgent::clear):
  21732. * inspector/InspectorDebuggerAgent.h:
  21733. * inspector/ScriptDebugListener.h:
  21734. * inspector/WorkerInspectorController.cpp:
  21735. (WebCore::WorkerInspectorController::WorkerInspectorController):
  21736. 2011-04-27 Pavel Feldman <pfeldman@google.com>
  21737. Reviewed by Yury Semikhatsky.
  21738. Web Inspector: implement incremental CSS editing in the structure view.
  21739. https://bugs.webkit.org/show_bug.cgi?id=59455
  21740. * inspector/front-end/StylesSidebarPane.js:
  21741. (WebInspector.StylePropertyTreeElement.prototype):
  21742. 2011-04-27 Mihai Parparita <mihaip@chromium.org>
  21743. Reviewed by Eric Seidel.
  21744. Frame.h shouldn't include Document.h
  21745. https://bugs.webkit.org/show_bug.cgi?id=59560
  21746. Frame can use a forward-declared Document if we move
  21747. Frame::displayStringModifiedByEncoding's implementation out of the
  21748. header.
  21749. Size #includes Size * #includes
  21750. Before: page/Frame.h: 0.746 653 487.138
  21751. dom/Document.h: 0.220 1306 287.320
  21752. After: page/Frame.h: 0.646 653 421.838
  21753. dom/Document.h: 0.220 1189 261.580
  21754. * WebCore.exp.in:
  21755. * bindings/ScriptControllerBase.cpp:
  21756. * bindings/generic/BindingSecurityBase.cpp:
  21757. * bindings/v8/V8Proxy.cpp:
  21758. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  21759. * dom/CharacterData.cpp:
  21760. * dom/UserTypingGestureIndicator.cpp:
  21761. * editing/chromium/SelectionControllerChromium.cpp:
  21762. * inspector/InspectorDOMStorageResource.cpp:
  21763. * inspector/InspectorInstrumentation.h:
  21764. * loader/PingLoader.cpp:
  21765. * loader/SubresourceLoader.cpp:
  21766. * loader/appcache/DOMApplicationCache.cpp:
  21767. * loader/cache/CachedResourceRequest.cpp:
  21768. * page/Frame.cpp:
  21769. (WebCore::Frame::displayStringModifiedByEncoding):
  21770. * page/Frame.h:
  21771. * page/Geolocation.cpp:
  21772. * page/Location.cpp:
  21773. * page/Navigator.cpp:
  21774. * page/PageGroupLoadDeferrer.cpp:
  21775. * page/PerformanceTiming.cpp:
  21776. * xml/XSLTProcessorLibxslt.cpp:
  21777. 2011-04-27 James Robinson <jamesr@chromium.org>
  21778. Reviewed by Eric Seidel.
  21779. Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
  21780. https://bugs.webkit.org/show_bug.cgi?id=59377
  21781. This cleans up some strict OwnPtr<> violations around text and box shadow data. ShadowData's linked list data
  21782. structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
  21783. * css/CSSStyleSelector.cpp:
  21784. (WebCore::CSSStyleSelector::applyProperty):
  21785. * page/animation/AnimationBase.cpp:
  21786. (WebCore::blendFunc):
  21787. (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
  21788. (WebCore::PropertyWrapperShadow::blend):
  21789. * rendering/style/RenderStyle.cpp:
  21790. (WebCore::RenderStyle::setTextShadow):
  21791. (WebCore::RenderStyle::setBoxShadow):
  21792. * rendering/style/RenderStyle.h:
  21793. (WebCore::InheritedFlags::textShadow):
  21794. * rendering/style/ShadowData.cpp:
  21795. (WebCore::ShadowData::ShadowData):
  21796. * rendering/style/ShadowData.h:
  21797. (WebCore::ShadowData::ShadowData):
  21798. (WebCore::ShadowData::next):
  21799. (WebCore::ShadowData::setNext):
  21800. * rendering/style/StyleRareInheritedData.cpp:
  21801. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  21802. (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
  21803. * rendering/style/StyleRareInheritedData.h:
  21804. * rendering/style/StyleRareNonInheritedData.cpp:
  21805. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  21806. 2011-04-26 David Levin <levin@chromium.org>
  21807. Reviewed by Eric Seidel.
  21808. Fix some strict PassOwnPtr issues in WebCore.
  21809. https://bugs.webkit.org/show_bug.cgi?id=59563
  21810. * css/SVGCSSStyleSelector.cpp:
  21811. (WebCore::CSSStyleSelector::applySVGProperty):
  21812. * html/canvas/WebGLRenderingContext.cpp:
  21813. (WebCore::WebGLRenderingContext::create):
  21814. (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  21815. * platform/text/TextCodecLatin1.cpp:
  21816. (WebCore::newStreamingTextDecoderWindowsLatin1):
  21817. * platform/text/TextCodecUTF16.cpp:
  21818. (WebCore::newStreamingTextDecoderUTF16LE):
  21819. (WebCore::newStreamingTextDecoderUTF16BE):
  21820. * platform/text/TextCodecUserDefined.cpp:
  21821. (WebCore::newStreamingTextDecoderUserDefined):
  21822. * platform/text/mac/TextCodecMac.cpp:
  21823. (WebCore::newTextCodecMac):
  21824. * workers/Worker.cpp:
  21825. (WebCore::Worker::notifyFinished):
  21826. 2011-04-26 Justin Novosad <junov@chromium.org>
  21827. Reviewed by Kenneth Russell.
  21828. [Chromium] Expose skia gpu canvas rendering as a runtime flag
  21829. https://bugs.webkit.org/show_bug.cgi?id=58683
  21830. Replace the SKIA_GPU compile flag by the pre-existing
  21831. acceleratedDrawingEnabled flag. Most code changes are trivial:
  21832. compile-time conditionals on SKIA_GPU were either replaced with
  21833. a run-time check, or a compile time check on USE(SKIA)
  21834. No new tests. Covered by existing tests.
  21835. * html/canvas/CanvasRenderingContext2D.cpp:
  21836. (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  21837. * page/Page.cpp:
  21838. (WebCore::Page::sharedGraphicsContext3D):
  21839. Added check for the acceleratedDrawing flag.
  21840. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  21841. (WebCore::DrawingBuffer::DrawingBuffer):
  21842. (WebCore::DrawingBuffer::publishToPlatformLayer):
  21843. * platform/graphics/gpu/DrawingBuffer.h:
  21844. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  21845. (WebCore::SharedGraphicsContext3D::create):
  21846. On Skia builds, this methos now receives a bool arg to turn on
  21847. GPU-accelerated skia rendering
  21848. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  21849. (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
  21850. (WebCore::SharedGraphicsContext3D::grContext):
  21851. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  21852. * platform/graphics/skia/ImageSkia.cpp:
  21853. (WebCore::computeResamplingMode):
  21854. (WebCore::paintSkBitmap):
  21855. (WebCore::Image::drawPattern):
  21856. * platform/graphics/skia/PlatformContextSkia.cpp:
  21857. (WebCore::PlatformContextSkia::PlatformContextSkia):
  21858. (WebCore::PlatformContextSkia::~PlatformContextSkia):
  21859. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  21860. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  21861. (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
  21862. (WebCore::PlatformContextSkia::prepareForHardwareDraw):
  21863. (WebCore::PlatformContextSkia::syncSoftwareCanvas):
  21864. (WebCore::PlatformContextSkia::markDirtyRect):
  21865. * platform/graphics/skia/PlatformContextSkia.h:
  21866. (WebCore::PlatformContextSkia::accelerationMode):
  21867. (WebCore::PlatformContextSkia::useGPU):
  21868. (WebCore::PlatformContextSkia::useSkiaGPU):
  21869. 2011-04-26 Pavel Feldman <pfeldman@chromium.org>
  21870. Not reviewed: restore inspector test disabled in r84913.
  21871. Test: http/tests/inspector-enabled/dom-storage-open.html
  21872. * inspector/InspectorDOMStorageAgent.cpp:
  21873. (WebCore::InspectorDOMStorageAgent::clearFrontend):
  21874. 2011-04-26 Kenichi Ishibashi <bashi@chromium.org>
  21875. Reviewed by Tony Chang.
  21876. [Chromium] Vertical positions are off for some Arabic glyphs on Linux
  21877. https://bugs.webkit.org/show_bug.cgi?id=59182
  21878. Use vertical offsets of the shaping results.
  21879. Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
  21880. * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
  21881. (WebCore::ComplexTextController::ComplexTextController):
  21882. Added initialization of m_startingY.
  21883. (WebCore::ComplexTextController::nextScriptRun):
  21884. Followed the change in handling positions.
  21885. (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
  21886. (WebCore::ComplexTextController::createGlyphArrays): Ditto.
  21887. (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
  21888. (WebCore::ComplexTextController::setGlyphPositions):
  21889. Changed to use vertical offsets as same as horizontal offsets.
  21890. * platform/graphics/chromium/ComplexTextControllerLinux.h:
  21891. Removed m_xPositions and Added m_positions and m_startingY.
  21892. (WebCore::ComplexTextController::positions): Added.
  21893. * platform/graphics/chromium/FontLinux.cpp:
  21894. Followed the change in ComplexTextController.
  21895. (WebCore::Font::drawComplexText): Ditto.
  21896. (WebCore::Font::floatWidthForComplexText): Ditto.
  21897. (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
  21898. (WebCore::Font::offsetForPositionForComplexText): Ditto.
  21899. (WebCore::Font::selectionRectForComplexText): Ditto.
  21900. 2011-04-26 Levi Weintraub <leviw@chromium.org>
  21901. Reviewed by Eric Seidel.
  21902. Root element should establish a new block formatting context
  21903. https://bugs.webkit.org/show_bug.cgi?id=54573
  21904. Always expanding the root renderer to include overhanging floats.
  21905. Test: fast/block/float/float-overhangs-root.html
  21906. * rendering/RenderBlock.cpp:
  21907. (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
  21908. 2011-04-26 Dawit Alemayehu <adawit@kde.org>
  21909. Reviewed by Andreas Kling.
  21910. [Qt] Improper rendering of <button> tag when it contains a <br>
  21911. https://bugs.webkit.org/show_bug.cgi?id=50521
  21912. Test: platform/qt/fast/forms/button-line-break.html
  21913. * platform/qt/RenderThemeQt.cpp:
  21914. (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
  21915. (WebCore::RenderThemeQt::setButtonPadding):
  21916. 2011-04-26 James Robinson <jamesr@chromium.org>
  21917. Reviewed by Kenneth Russell.
  21918. [chromium] Only reset tiles if the LayerRendererChromium is actually changing
  21919. https://bugs.webkit.org/show_bug.cgi?id=59572
  21920. http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
  21921. when LayerRendererChromium was set. We set this pointer every frame
  21922. and should only reset the tiles if the new LayerRendererChromium is
  21923. different from the old one (indicating a context loss), not just reset
  21924. on every frame.
  21925. * platform/graphics/chromium/LayerTilerChromium.cpp:
  21926. (WebCore::LayerTilerChromium::setLayerRenderer):
  21927. * platform/graphics/chromium/LayerTilerChromium.h:
  21928. 2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>
  21929. Reviewed by Eric Seidel.
  21930. beginElement broken by setAttribute
  21931. https://bugs.webkit.org/show_bug.cgi?id=26019
  21932. Test: svg/animations/animate-beginElementAt.svg
  21933. * svg/SVGAnimationElement.cpp:
  21934. (WebCore::SVGAnimationElement::attributeChanged):
  21935. Reset the animation state here as the rest of the code reads it and would still
  21936. think we are animating when we are not.
  21937. * svg/animation/SVGSMILElement.h:
  21938. (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
  21939. 2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
  21940. Unreviewed, rolling out r84989.
  21941. http://trac.webkit.org/changeset/84989
  21942. https://bugs.webkit.org/show_bug.cgi?id=59566
  21943. REGRESSION (r84989): Lots of vertical text tests failing on
  21944. windows (Requested by weinig on #webkit).
  21945. * platform/graphics/FontPlatformData.h:
  21946. * platform/graphics/win/FontCacheWin.cpp:
  21947. (WebCore::FontCache::getFontDataForCharacters):
  21948. (WebCore::FontCache::createFontPlatformData):
  21949. * platform/graphics/win/FontCustomPlatformData.cpp:
  21950. (WebCore::FontCustomPlatformData::fontPlatformData):
  21951. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  21952. (WebCore::FontPlatformData::FontPlatformData):
  21953. * platform/graphics/win/FontPlatformDataWin.cpp:
  21954. (WebCore::FontPlatformData::FontPlatformData):
  21955. 2011-04-26 Sam Weinig <sam@webkit.org>
  21956. Reviewed by Eric Seidel.
  21957. Try again:
  21958. Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
  21959. https://bugs.webkit.org/show_bug.cgi?id=59310
  21960. * bindings/js/JSDOMBinding.h:
  21961. (WebCore::DOMConstructorObject::DOMConstructorObject):
  21962. * bindings/js/JSDOMWrapper.h:
  21963. (WebCore::JSDOMWrapper::globalObject):
  21964. (WebCore::JSDOMWrapper::scriptExecutionContext):
  21965. (WebCore::JSDOMWrapper::createStructure):
  21966. (WebCore::JSDOMWrapper::JSDOMWrapper):
  21967. * bindings/scripts/CodeGeneratorJS.pm:
  21968. 2011-04-26 Sam Weinig <sam@webkit.org>
  21969. Reviewed by David Hyatt.
  21970. Remove Datagrid from the tree
  21971. https://bugs.webkit.org/show_bug.cgi?id=59543
  21972. * Android.derived.jscbindings.mk:
  21973. * Android.derived.v8bindings.mk:
  21974. * Android.jscbindings.mk:
  21975. * Android.v8bindings.mk:
  21976. * CMakeLists.txt:
  21977. * CodeGenerators.pri:
  21978. * Configurations/FeatureDefines.xcconfig:
  21979. * DerivedSources.cpp:
  21980. * DerivedSources.make:
  21981. * GNUmakefile.am:
  21982. * GNUmakefile.list.am:
  21983. * UseJSC.cmake:
  21984. * WebCore.gypi:
  21985. * WebCore.pro:
  21986. * WebCore.vcproj/WebCore.vcproj:
  21987. * WebCore.xcodeproj/project.pbxproj:
  21988. * bindings/js/JSBindingsAllInOne.cpp:
  21989. * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
  21990. * bindings/js/JSDataGridDataSource.cpp: Removed.
  21991. * bindings/js/JSDataGridDataSource.h: Removed.
  21992. * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
  21993. * bindings/v8/V8DataGridDataSource.cpp: Removed.
  21994. * bindings/v8/V8DataGridDataSource.h: Removed.
  21995. * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
  21996. * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
  21997. * css/CSSStyleSelector.cpp:
  21998. * css/CSSStyleSelector.h:
  21999. * css/html.css:
  22000. (input, textarea, keygen, select, button, isindex):
  22001. (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
  22002. * editing/htmlediting.cpp:
  22003. (WebCore::canHaveChildrenForEditing):
  22004. * features.pri:
  22005. * html/DOMDataGridDataSource.cpp: Removed.
  22006. * html/DOMDataGridDataSource.h: Removed.
  22007. * html/DataGridColumn.cpp: Removed.
  22008. * html/DataGridColumn.h: Removed.
  22009. * html/DataGridColumn.idl: Removed.
  22010. * html/DataGridColumnList.cpp: Removed.
  22011. * html/DataGridColumnList.h: Removed.
  22012. * html/DataGridColumnList.idl: Removed.
  22013. * html/DataGridDataSource.h: Removed.
  22014. * html/HTMLDataGridCellElement.cpp: Removed.
  22015. * html/HTMLDataGridCellElement.h: Removed.
  22016. * html/HTMLDataGridCellElement.idl: Removed.
  22017. * html/HTMLDataGridColElement.cpp: Removed.
  22018. * html/HTMLDataGridColElement.h: Removed.
  22019. * html/HTMLDataGridColElement.idl: Removed.
  22020. * html/HTMLDataGridElement.cpp: Removed.
  22021. * html/HTMLDataGridElement.h: Removed.
  22022. * html/HTMLDataGridElement.idl: Removed.
  22023. * html/HTMLDataGridRowElement.cpp: Removed.
  22024. * html/HTMLDataGridRowElement.h: Removed.
  22025. * html/HTMLDataGridRowElement.idl: Removed.
  22026. * html/HTMLElement.cpp:
  22027. (WebCore::HTMLElement::ieForbidsInsertHTML):
  22028. * html/HTMLElementsAllInOne.cpp:
  22029. * html/HTMLTagNames.in:
  22030. * page/DOMWindow.idl:
  22031. * rendering/RenderBox.cpp:
  22032. (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
  22033. * rendering/RenderDataGrid.cpp: Removed.
  22034. * rendering/RenderDataGrid.h: Removed.
  22035. * rendering/RenderingAllInOne.cpp:
  22036. 2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com>
  22037. Reviewed by Adele Peterson.
  22038. On WebKit (Windows), glyphs in vertical text tests are rotated 90
  22039. degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=48459
  22040. This platform dependent patch makes WebKit (Windows) show the
  22041. vertical writing text correctly. Job was done by adding a prefix '@'
  22042. in front of the font family name (Windows Only). No new tests added.
  22043. Some layout tests images:
  22044. http://www.flickr.com/photos/burorly/sets/72157625585506341/
  22045. * platform/graphics/FontPlatformData.h:
  22046. * platform/graphics/win/FontCacheWin.cpp:
  22047. (WebCore::FontCache::getFontDataForCharacters):
  22048. (WebCore::FontCache::createFontPlatformData):
  22049. * platform/graphics/win/FontCustomPlatformData.cpp:
  22050. (WebCore::FontCustomPlatformData::fontPlatformData):
  22051. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  22052. (WebCore::FontPlatformData::FontPlatformData):
  22053. * platform/graphics/win/FontPlatformDataWin.cpp:
  22054. (WebCore::FontPlatformData::FontPlatformData):
  22055. 2011-04-26 Jer Noble <jer.noble@apple.com>
  22056. Reviewed by Brady Eidson.
  22057. HTML5 video fullscreen transition causes an audio stutter
  22058. https://bugs.webkit.org/show_bug.cgi?id=59544
  22059. AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer
  22060. from its AVPlayer. Since you shouldn't necessarily have to destroy the
  22061. layer to render it invisible, instead just set the layer as hidden.
  22062. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  22063. (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
  22064. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  22065. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  22066. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  22067. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
  22068. 2011-04-26 Christian Dywan <christian@lanedo.com>
  22069. Reviewed by Eric Seidel.
  22070. Extra separator after Select All in context menu
  22071. https://bugs.webkit.org/show_bug.cgi?id=54092
  22072. * page/ContextMenuController.cpp: Move separator to non-GTK+
  22073. port guards since it is for the spelling options menu
  22074. which the GTK+ port doesn't use.
  22075. 2011-04-26 James Robinson <jamesr@chromium.org>
  22076. Reviewed by Kenneth Russell.
  22077. [chromium] Clear out LayerTilerChromium's tiles on lost context
  22078. https://bugs.webkit.org/show_bug.cgi?id=59233
  22079. Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are
  22080. no longer valid since they exist in the previous LayerRendererChromium.
  22081. Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
  22082. * platform/graphics/chromium/LayerTilerChromium.h:
  22083. (WebCore::LayerTilerChromium::setLayerRenderer):
  22084. 2011-04-26 Martin Robinson <mrobinson@igalia.com>
  22085. Reviewed by Dirk Schulze.
  22086. [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
  22087. https://bugs.webkit.org/show_bug.cgi?id=57644
  22088. Manual test: plugins/windowed-in-iframe-2.html
  22089. * manual-tests/plugins/windowed-in-iframe-2.html: Added.
  22090. * platform/gtk/WidgetGtk.cpp:
  22091. (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
  22092. * plugins/PluginView.h: Added helper method to set the allocation and clip.
  22093. * plugins/gtk/PluginViewGtk.cpp:
  22094. (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
  22095. the allocation immediately. Bring this method into sync with the implementation in
  22096. the Qt port.
  22097. (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
  22098. (WebCore::PluginView::plugAddedCallback): Call the new helper method.
  22099. 2011-04-26 Martin Robinson <mrobinson@igalia.com>
  22100. Reviewed by Eric Seidel.
  22101. [GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
  22102. https://bugs.webkit.org/show_bug.cgi?id=58818
  22103. Prevent allocating scratch buffers larger than the target GdkDrawable
  22104. when creating a WidgetRenderingContext. This prevents incredibly large
  22105. widgets from crashing the X Server. This change also allowed greatly
  22106. simplifying the way that the painting offset is calculated.
  22107. * platform/gtk/WidgetRenderingContext.cpp:
  22108. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
  22109. larger than the target GdkDrawable.
  22110. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
  22111. blit by looking at the location of the target rect itself, rather than delaying the
  22112. calculation up to this point.
  22113. (WebCore::WidgetRenderingContext::calculateClipRect): Added.
  22114. (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
  22115. (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
  22116. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
  22117. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
  22118. (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
  22119. (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
  22120. (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
  22121. (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
  22122. (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
  22123. * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
  22124. a member to store the IntSize mapping from the coordinates of the target to the coordinates
  22125. of the scratch buffer.
  22126. 2011-04-26 Patrick Gansterer <paroga@webkit.org>
  22127. Reviewed by Adam Barth.
  22128. Respect charset in handleDataURL
  22129. https://bugs.webkit.org/show_bug.cgi?id=47746
  22130. Original patch by Kwang Yul Seo <skyul@company100.net>
  22131. We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
  22132. returns an empty string because encoding name is not specified.
  22133. Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
  22134. This change fixes over 130 layout tests when running GTK port with cURL network backend.
  22135. * platform/network/DataURL.cpp:
  22136. (WebCore::handleDataURL):
  22137. 2011-04-26 Anders Carlsson <andersca@apple.com>
  22138. Fix clang++ build.
  22139. You can never have too many casts!
  22140. * accessibility/mac/AccessibilityObjectWrapper.mm:
  22141. (-[AccessibilityObjectWrapper position]):
  22142. * editing/mac/SelectionControllerMac.mm:
  22143. (WebCore::accessibilityConvertScreenRect):
  22144. 2011-04-26 Chris Rogers <crogers@google.com>
  22145. Reviewed by Kenneth Russell.
  22146. Fix web audio build on mac port
  22147. https://bugs.webkit.org/show_bug.cgi?id=59355
  22148. No new tests since audio API is not yet implemented.
  22149. * WebCore.xcodeproj/project.pbxproj:
  22150. * bindings/js/JSAudioContextCustom.cpp:
  22151. (WebCore::JSAudioContext::visitChildren):
  22152. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  22153. (WebCore::JSJavaScriptAudioNode::visitChildren):
  22154. * webaudio/AudioContext.idl:
  22155. 2011-04-26 Chris Rogers <crogers@google.com>
  22156. Reviewed by Kenneth Russell.
  22157. Add FFTFrame implementation for FFmpeg
  22158. https://bugs.webkit.org/show_bug.cgi?id=59408
  22159. No new tests since audio API is not yet implemented.
  22160. * WebCore.gyp/WebCore.gyp:
  22161. * WebCore.gypi:
  22162. * platform/audio/FFTFrame.h:
  22163. * platform/audio/FFTFrameStub.cpp:
  22164. * platform/audio/ffmpeg: Added.
  22165. * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
  22166. (WebCore::FFTFrame::FFTFrame):
  22167. (WebCore::FFTFrame::initialize):
  22168. (WebCore::FFTFrame::cleanup):
  22169. (WebCore::FFTFrame::~FFTFrame):
  22170. (WebCore::FFTFrame::multiply):
  22171. (WebCore::FFTFrame::doFFT):
  22172. (WebCore::FFTFrame::doInverseFFT):
  22173. (WebCore::FFTFrame::realData):
  22174. (WebCore::FFTFrame::imagData):
  22175. (WebCore::FFTFrame::getUpToDateComplexData):
  22176. (WebCore::FFTFrame::contextForSize):
  22177. * platform/audio/mac/FFTFrameMac.cpp:
  22178. * webaudio/ConvolverNode.cpp:
  22179. 2011-04-26 Jeff Miller <jeffm@apple.com>
  22180. Add a newline at the end of SVGFEDropShadowElement.idl.
  22181. * svg/SVGFEDropShadowElement.idl:
  22182. 2011-04-26 Mihai Parparita <mihaip@chromium.org>
  22183. Reviewed by Eric Seidel.
  22184. InlineBox.h shouldn't include RenderBR.h
  22185. https://bugs.webkit.org/show_bug.cgi?id=59480
  22186. Per bug 59348 RenderBR.h is a "top header" by include * size, because
  22187. InlineBox.h includes it. There's no reason why it has to.
  22188. * rendering/InlineBox.h:
  22189. * rendering/InlineTextBox.cpp:
  22190. * rendering/RenderBlock.h:
  22191. 2011-04-26 Sam Weinig <sam@webkit.org>
  22192. Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
  22193. I should do.
  22194. * bindings/js/JSDOMBinding.h:
  22195. (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
  22196. (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
  22197. (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
  22198. (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
  22199. (WebCore::DOMConstructorObject::DOMConstructorObject):
  22200. * bindings/js/JSDOMWrapper.h:
  22201. (WebCore::JSDOMWrapper::JSDOMWrapper):
  22202. * bindings/scripts/CodeGeneratorJS.pm:
  22203. 2011-04-26 Sam Weinig <sam@webkit.org>
  22204. Fix build.
  22205. * bindings/js/JSDOMWrapper.h:
  22206. (WebCore::JSDOMWrapper::globalObject):
  22207. 2011-04-26 Sam Weinig <sam@webkit.org>
  22208. Roll r84945 back in with infinite recursion removed.
  22209. * bindings/js/JSDOMBinding.h:
  22210. (WebCore::DOMConstructorObject::DOMConstructorObject):
  22211. * bindings/js/JSDOMWrapper.h:
  22212. (WebCore::JSDOMWrapper::globalObject):
  22213. (WebCore::JSDOMWrapper::scriptExecutionContext):
  22214. (WebCore::JSDOMWrapper::createStructure):
  22215. (WebCore::JSDOMWrapper::JSDOMWrapper):
  22216. * bindings/scripts/CodeGeneratorJS.pm:
  22217. 2011-04-26 Sam Weinig <sam@webkit.org>
  22218. Rollout previous patch. It broke stuff.
  22219. * bindings/js/JSDOMBinding.h:
  22220. (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
  22221. (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
  22222. (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
  22223. (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
  22224. (WebCore::DOMConstructorObject::DOMConstructorObject):
  22225. * bindings/js/JSDOMWrapper.h:
  22226. (WebCore::JSDOMWrapper::JSDOMWrapper):
  22227. * bindings/scripts/CodeGeneratorJS.pm:
  22228. 2011-04-26 Sam Weinig <sam@webkit.org>
  22229. Reviewed by Maciej Stachowiak.
  22230. Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
  22231. https://bugs.webkit.org/show_bug.cgi?id=59310
  22232. * bindings/js/JSDOMBinding.h:
  22233. (WebCore::DOMConstructorObject::DOMConstructorObject):
  22234. * bindings/js/JSDOMWrapper.h:
  22235. (WebCore::JSDOMWrapper::globalObject):
  22236. (WebCore::JSDOMWrapper::scriptExecutionContext):
  22237. (WebCore::JSDOMWrapper::createStructure):
  22238. (WebCore::JSDOMWrapper::JSDOMWrapper):
  22239. Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
  22240. * bindings/scripts/CodeGeneratorJS.pm:
  22241. Make JSDOMWrapper the base class.
  22242. 2011-04-26 Dan Bernstein <mitz@apple.com>
  22243. Reviewed by Mark Rowe.
  22244. Choose the compiler based on the Xcode version for Snow Leopard debug builds.
  22245. * Configurations/Base.xcconfig:
  22246. * Configurations/CompilerVersion.xcconfig: Added.
  22247. 2011-04-26 Adrienne Walker <enne@google.com>
  22248. Reviewed by Geoffrey Garen.
  22249. Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
  22250. https://bugs.webkit.org/show_bug.cgi?id=59469
  22251. * platform/chromium/TraceEvent.h:
  22252. (WebCore::internal::ScopeTracer::ScopeTracer):
  22253. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  22254. Reviewed by Oliver Hunt.
  22255. Nixed special finalizer handling for WebCore strings
  22256. https://bugs.webkit.org/show_bug.cgi?id=59425
  22257. Not needed anymore, since weak handles have finalizers.
  22258. * WebCore.exp.in: Exports!
  22259. * bindings/js/DOMWrapperWorld.cpp:
  22260. (WebCore::JSStringOwner::finalize):
  22261. (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
  22262. so we don't need special treatment anymore.
  22263. * bindings/js/DOMWrapperWorld.h:
  22264. (WebCore::JSStringOwner::JSStringOwner):
  22265. (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
  22266. instead of a WeakGCMap, so we can specify a custom finalizer.
  22267. * bindings/js/JSDOMBinding.cpp:
  22268. (WebCore::jsStringSlowCase):
  22269. * bindings/js/JSDOMBinding.h:
  22270. (WebCore::jsString): Updated for string map change.
  22271. 2011-04-26 David Kilzer <ddkilzer@apple.com>
  22272. <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
  22273. Reviewed by Antti Koivisto.
  22274. To enable HTTP pipelining post-SnowLeopard, use this command:
  22275. defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
  22276. * platform/network/cf/ResourceRequestCFNet.cpp:
  22277. (WebCore::readBooleanPreference): Re-added. Originally added in
  22278. r76756 and removed in r84120.
  22279. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
  22280. HTTP pipelining if use default is set to true. Added macro
  22281. guards to match those in ResourceRequestMac.mm.
  22282. 2011-04-26 Antti Koivisto <antti@apple.com>
  22283. Reviewed by Adele Peterson.
  22284. Don't strip fragments from file: urls in memory cache
  22285. https://bugs.webkit.org/show_bug.cgi?id=59463
  22286. <rdar://problem/9231130>
  22287. Some clients expect file: resources to be unique based on fragment identifier.
  22288. Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
  22289. Test: fast/loader/file-protocol-fragment.html
  22290. * loader/cache/MemoryCache.cpp:
  22291. (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
  22292. 2011-04-26 David Levin <levin@chromium.org>
  22293. Reviewed by Darin Adler.
  22294. Fix more strict OwnPtr in WebCore (round N).
  22295. https://bugs.webkit.org/show_bug.cgi?id=59464
  22296. * dom/Document.cpp:
  22297. (WebCore::Document::Document):
  22298. (WebCore::Document::attach):
  22299. * fileapi/FileReader.cpp:
  22300. (WebCore::FileReader::terminate):
  22301. * loader/DocumentThreadableLoader.cpp:
  22302. (WebCore::DocumentThreadableLoader::preflightFailure):
  22303. * workers/DefaultSharedWorkerRepository.cpp:
  22304. (WebCore::SharedWorkerConnectTask::create):
  22305. (WebCore::SharedWorkerScriptLoader::load):
  22306. 2011-04-26 Ruben <chromium@hybridsource.org>
  22307. Reviewed by Tony Chang.
  22308. Change linux ifdefs for Chromium to Unix instead, allowing
  22309. new Unix ports to be enabled by default
  22310. https://bugs.webkit.org/show_bug.cgi?id=59297
  22311. No new tests, just changing preprocessor defines.
  22312. * bindings/js/JSInspectorFrontendHostCustom.cpp:
  22313. * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  22314. * dom/SelectElement.cpp:
  22315. * loader/cache/CachedFont.cpp:
  22316. * page/EventHandler.cpp:
  22317. * page/chromium/EventHandlerChromium.cpp:
  22318. * platform/Scrollbar.cpp:
  22319. * platform/chromium/PlatformBridge.h:
  22320. * platform/graphics/chromium/FontPlatformData.h:
  22321. * platform/graphics/skia/FontCustomPlatformData.cpp:
  22322. * platform/graphics/skia/FontCustomPlatformData.h:
  22323. 2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
  22324. Reviewed by Dan Bernstein.
  22325. [RTL] Arabic/AB - after typing a date, cursors doesn't go back
  22326. https://bugs.webkit.org/show_bug.cgi?id=49111
  22327. Even when the offset corresponds to a position visually left of the box
  22328. and there aren't any inline boxes on the left, the previous/next position
  22329. may still correspond to some position in the same line.
  22330. The bug was caused by our ignoring such cases. Fixed the bug by comparing
  22331. previous/next position's inline box to the current box. If they match,
  22332. then we stay on the same position because moving to the left visually at
  22333. the left edge should not result in a position on the same line.
  22334. Also fixed a bug that WebKit uses offsets that are not extrema when moved to
  22335. the left edge or to the right edge, and a bug that WebKit could not move to
  22336. the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
  22337. Test cases are added to editing/selection/move-left-right.html
  22338. * editing/VisiblePosition.cpp:
  22339. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  22340. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  22341. 2011-04-26 Gabor Loki <loki@webkit.org>
  22342. Reviewed by Csaba Osztrogonác.
  22343. Speeding up SVG filters with multicore (SMP) support
  22344. https://bugs.webkit.org/show_bug.cgi?id=43903
  22345. Some SVG filters execute a huge number of pixel manipulations, which
  22346. cannot be sped up by graphics accelerators, since their algorithm is
  22347. too complex. Using the power of Symmetric Multi Processing (SMP) we
  22348. can split up a task to smaller (data independent) tasks, which can be
  22349. executed independently.
  22350. The ParallelJobs framework provides a simple way for distributed
  22351. programming. The framework is based on WebKit's threading infrastructure,
  22352. Open Multi-Processing's (OpenMP) API, and libdispatch API.
  22353. * ForwardingHeaders/wtf/ParallelJobs.h: Added.
  22354. * platform/graphics/filters/FETurbulence.cpp:
  22355. (WebCore::FETurbulence::PaintingData::PaintingData):
  22356. (WebCore::FETurbulence::noise2D):
  22357. (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
  22358. (WebCore::FETurbulence::fillRegion):
  22359. (WebCore::FETurbulence::fillRegionWorker):
  22360. (WebCore::FETurbulence::apply):
  22361. * platform/graphics/filters/FETurbulence.h:
  22362. 2011-04-26 Pavel Feldman <pfeldman@google.com>
  22363. Reviewed by Yury Semikhatsky.
  22364. Web Inspector: close button is off in docked mode on a mac.
  22365. https://bugs.webkit.org/show_bug.cgi?id=59453
  22366. * inspector/front-end/inspector.css:
  22367. (.toolbar-item.close-left):
  22368. 2011-04-26 Pavel Feldman <pfeldman@google.com>
  22369. Reviewed by Yury Semikhatsky.
  22370. Web Inspector: New Style is not working (UI glitch)
  22371. https://bugs.webkit.org/show_bug.cgi?id=59451
  22372. * inspector/InspectorDOMStorageAgent.cpp:
  22373. (WebCore::InspectorDOMStorageAgent::setFrontend):
  22374. * inspector/front-end/AuditRules.js:
  22375. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  22376. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
  22377. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
  22378. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
  22379. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
  22380. * inspector/front-end/CSSStyleModel.js:
  22381. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  22382. (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
  22383. (WebInspector.CSSStyleModel.prototype.addRule):
  22384. (WebInspector.CSSStyleModel.prototype.addRule.callback):
  22385. (WebInspector.CSSStyleModel.prototype._documentElementId):
  22386. * inspector/front-end/DOMAgent.js:
  22387. (WebInspector.DOMNode.prototype._addAttribute):
  22388. (WebInspector.DOMNode.prototype.documentElement):
  22389. * inspector/front-end/ResourceTreeModel.js:
  22390. (WebInspector.PageDispatcher.prototype.frameDetached):
  22391. * inspector/front-end/StylesSidebarPane.js:
  22392. (WebInspector.StylesSidebarPane.prototype._createNewRule):
  22393. 2011-04-26 Pavel Feldman <pfeldman@google.com>
  22394. Reviewed by Yury Semikhatsky.
  22395. Web Inspector: introduce DOMStorage::enable and disable.
  22396. https://bugs.webkit.org/show_bug.cgi?id=59445
  22397. * inspector/Inspector.json:
  22398. * inspector/InspectorAgent.cpp:
  22399. (WebCore::InspectorAgent::InspectorAgent):
  22400. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  22401. * inspector/InspectorDOMStorageAgent.cpp:
  22402. (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
  22403. (WebCore::InspectorDOMStorageAgent::restore):
  22404. (WebCore::InspectorDOMStorageAgent::enable):
  22405. (WebCore::InspectorDOMStorageAgent::disable):
  22406. * inspector/InspectorDOMStorageAgent.h:
  22407. (WebCore::InspectorDOMStorageAgent::create):
  22408. * inspector/front-end/DOMStorage.js:
  22409. (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
  22410. * inspector/front-end/ResourcesPanel.js:
  22411. (WebInspector.ResourcesPanel.prototype._reset):
  22412. * inspector/front-end/inspector.js:
  22413. 2011-04-26 Pavel Feldman <pfeldman@google.com>
  22414. Reviewed by Yury Semikhatsky.
  22415. Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
  22416. https://bugs.webkit.org/show_bug.cgi?id=59440
  22417. * inspector/Inspector.json:
  22418. * inspector/InspectorAgent.cpp:
  22419. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  22420. * inspector/InspectorPageAgent.cpp:
  22421. (WebCore::InspectorPageAgent::setFrontend):
  22422. (WebCore::InspectorPageAgent::frameNavigated):
  22423. * inspector/InspectorPageAgent.h:
  22424. * inspector/front-end/AuditsPanel.js:
  22425. (WebInspector.AuditsPanel):
  22426. (WebInspector.AuditsPanel.prototype._onLoadEventFired):
  22427. (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
  22428. * inspector/front-end/CSSStyleModel.js:
  22429. (WebInspector.CSSStyleModelResourceBinding):
  22430. (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
  22431. * inspector/front-end/DOMBreakpointsSidebarPane.js:
  22432. (WebInspector.DOMBreakpointsSidebarPane):
  22433. (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
  22434. * inspector/front-end/DOMStorage.js:
  22435. (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
  22436. * inspector/front-end/ExtensionServer.js:
  22437. (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
  22438. (WebInspector.ExtensionServer.prototype.initExtensions):
  22439. * inspector/front-end/NetworkPanel.js:
  22440. (WebInspector.NetworkPanel):
  22441. (WebInspector.NetworkPanel.prototype._onLoadEventFired):
  22442. (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
  22443. (WebInspector.NetworkPanel.prototype._frameNavigated):
  22444. * inspector/front-end/ResourceTreeModel.js:
  22445. (WebInspector.ResourceTreeModel):
  22446. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  22447. (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
  22448. (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  22449. (WebInspector.ResourceTreeModel.prototype._frameDetached):
  22450. (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
  22451. (WebInspector.PageDispatcher):
  22452. (WebInspector.PageDispatcher.prototype.domContentEventFired):
  22453. (WebInspector.PageDispatcher.prototype.loadEventFired):
  22454. (WebInspector.PageDispatcher.prototype.frameNavigated):
  22455. (WebInspector.PageDispatcher.prototype.frameDetached):
  22456. * inspector/front-end/ResourcesPanel.js:
  22457. (WebInspector.ResourcesPanel):
  22458. (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
  22459. (WebInspector.ResourcesPanel.prototype._frameNavigated):
  22460. * inspector/front-end/inspector.js:
  22461. 2011-04-26 Csaba Osztrogonác <ossy@webkit.org>
  22462. Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
  22463. because it broke transitions/multiple-text-shadow-transition.html
  22464. Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
  22465. https://bugs.webkit.org/show_bug.cgi?id=59377
  22466. * css/CSSStyleSelector.cpp:
  22467. (WebCore::CSSStyleSelector::applyProperty):
  22468. * page/animation/AnimationBase.cpp:
  22469. (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
  22470. (WebCore::PropertyWrapperShadow::blend):
  22471. * rendering/style/RenderStyle.cpp:
  22472. (WebCore::RenderStyle::setTextShadow):
  22473. (WebCore::RenderStyle::setBoxShadow):
  22474. * rendering/style/RenderStyle.h:
  22475. (WebCore::InheritedFlags::textShadow):
  22476. * rendering/style/StyleRareInheritedData.cpp:
  22477. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  22478. (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
  22479. * rendering/style/StyleRareInheritedData.h:
  22480. * rendering/style/StyleRareNonInheritedData.cpp:
  22481. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  22482. 2011-04-26 Mihai Parparita <mihaip@chromium.org>
  22483. Reviewed by Adam Barth.
  22484. Turn off make built-in implicit rules for derived sources makefile
  22485. https://bugs.webkit.org/show_bug.cgi?id=59418
  22486. We don't use any of make's built-in implicit rules, turning them off
  22487. speeds up parsing of the makefile.
  22488. * WebCore.xcodeproj/project.pbxproj:
  22489. * gyp/generate-derived-sources.sh:
  22490. 2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
  22491. Reviewed by Nikolas Zimmermann.
  22492. ASSERT failure in SVGUseElement
  22493. https://bugs.webkit.org/show_bug.cgi?id=59313
  22494. In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
  22495. was wrong because the document may not be well-formed.
  22496. This patch asserts the element is not pending on resource or the
  22497. document is not well-formed.
  22498. Test: svg/custom/use-crash-in-non-wellformed-document.svg
  22499. * svg/SVGUseElement.cpp:
  22500. (WebCore::isWellFormedDocument):
  22501. (WebCore::SVGUseElement::insertedIntoDocument):
  22502. 2011-04-26 Mikhail Naganov <mnaganov@chromium.org>
  22503. Reviewed by Pavel Feldman.
  22504. Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
  22505. https://bugs.webkit.org/show_bug.cgi?id=59438
  22506. * inspector/front-end/DetailedHeapshotView.js:
  22507. (WebInspector.DetailedHeapshotView.prototype._changeView):
  22508. 2011-04-26 David Levin <levin@chromium.org>
  22509. Reviewed by Adam Barth.
  22510. Fix a few OwnPtr strict errors in WebCore headers.
  22511. https://bugs.webkit.org/show_bug.cgi?id=59431
  22512. * bindings/js/ScheduledAction.cpp:
  22513. (WebCore::ScheduledAction::create):
  22514. * css/MediaQueryMatcher.cpp:
  22515. (WebCore::MediaQueryMatcher::prepareEvaluator):
  22516. * dom/NodeRareData.h:
  22517. (WebCore::NodeListsNodeData::create):
  22518. * dom/ScriptRunner.h:
  22519. (WebCore::ScriptRunner::create):
  22520. * inspector/WorkerInspectorController.cpp:
  22521. (WebCore::WorkerInspectorController::connectFrontend):
  22522. * loader/icon/IconDatabase.h:
  22523. (WebCore::IconDatabase::create):
  22524. * platform/graphics/SimpleFontData.cpp:
  22525. (WebCore::SimpleFontData::verticalRightOrientationFontData):
  22526. (WebCore::SimpleFontData::uprightOrientationFontData):
  22527. (WebCore::SimpleFontData::brokenIdeographFontData):
  22528. * rendering/style/StyleRareInheritedData.cpp:
  22529. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  22530. * rendering/svg/SVGResources.h:
  22531. (WebCore::SVGResources::ClipperFilterMaskerData::create):
  22532. (WebCore::SVGResources::MarkerData::create):
  22533. (WebCore::SVGResources::FillStrokeData::create):
  22534. * storage/StorageSyncManager.cpp:
  22535. (WebCore::StorageSyncManager::close):
  22536. * workers/WorkerContext.cpp:
  22537. (WebCore::CloseWorkerContextTask::create):
  22538. * workers/WorkerMessagingProxy.cpp:
  22539. (WebCore::MessageWorkerContextTask::create):
  22540. (WebCore::MessageWorkerTask::create):
  22541. (WebCore::WorkerExceptionTask::create):
  22542. (WebCore::WorkerContextDestroyedTask::create):
  22543. (WebCore::WorkerTerminateTask::create):
  22544. (WebCore::WorkerThreadActivityReportTask::create):
  22545. * workers/WorkerRunLoop.cpp:
  22546. (WebCore::WorkerRunLoop::Task::create):
  22547. * workers/WorkerThread.cpp:
  22548. (WebCore::WorkerThreadStartupData::create):
  22549. (WebCore::WorkerThreadShutdownFinishTask::create):
  22550. (WebCore::WorkerThreadShutdownStartTask::create):
  22551. 2011-04-26 Adam Klein <adamk@chromium.org>
  22552. Reviewed by Adam Barth.
  22553. Fix last strict OwnPtr violation under svg/...
  22554. https://bugs.webkit.org/show_bug.cgi?id=59429
  22555. * svg/SVGDocumentExtensions.cpp:
  22556. (WebCore::SVGDocumentExtensions::removePendingResource):
  22557. 2011-04-26 Adam Barth <abarth@webkit.org>
  22558. Reviewed by David Levin.
  22559. Fix more strict OwnPtr violations in WebCore
  22560. https://bugs.webkit.org/show_bug.cgi?id=59433
  22561. These manifest in the Chromium build.
  22562. * bindings/v8/ScriptController.cpp:
  22563. (WebCore::ScriptController::ScriptController):
  22564. * bindings/v8/ScriptDebugServer.cpp:
  22565. (WebCore::ScriptDebugServer::editScriptSource):
  22566. * bindings/v8/V8DOMMap.cpp:
  22567. (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
  22568. * bindings/v8/V8Proxy.cpp:
  22569. (WebCore::V8Proxy::precompileScript):
  22570. * bindings/v8/WorkerScriptController.cpp:
  22571. (WebCore::WorkerScriptController::WorkerScriptController):
  22572. * page/Page.cpp:
  22573. (WebCore::Page::Page):
  22574. (WebCore::Page::speechInput):
  22575. * platform/PlatformGestureRecognizer.cpp:
  22576. (WebCore::PlatformGestureRecognizer::create):
  22577. * platform/PlatformGestureRecognizer.h:
  22578. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  22579. (WebCore::DrawingBuffer::DrawingBuffer):
  22580. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  22581. (WebCore::CCLayerImpl::CCLayerImpl):
  22582. * platform/graphics/gpu/Texture.cpp:
  22583. (WebCore::Texture::create):
  22584. * platform/image-decoders/bmp/BMPImageDecoder.cpp:
  22585. (WebCore::BMPImageDecoder::decodeHelper):
  22586. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  22587. (WebCore::GIFImageDecoder::decode):
  22588. * platform/image-decoders/ico/ICOImageDecoder.cpp:
  22589. (WebCore::ICOImageDecoder::decodeAtIndex):
  22590. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  22591. (WebCore::JPEGImageDecoder::decode):
  22592. * platform/image-decoders/png/PNGImageDecoder.cpp:
  22593. (WebCore::PNGImageDecoder::decode):
  22594. * storage/chromium/DatabaseTrackerChromium.cpp:
  22595. (WebCore::DatabaseTracker::addOpenDatabase):
  22596. 2011-04-25 David Levin <levin@chromium.org>
  22597. Reviewed by Adam Barth.
  22598. Fix OwnPtr strict errors in CrossThreadTask.h
  22599. https://bugs.webkit.org/show_bug.cgi?id=59427
  22600. * dom/CrossThreadTask.h:
  22601. (WebCore::CrossThreadTask1::create):
  22602. (WebCore::CrossThreadTask2::create):
  22603. (WebCore::CrossThreadTask3::create):
  22604. (WebCore::CrossThreadTask4::create):
  22605. (WebCore::CrossThreadTask5::create):
  22606. (WebCore::CrossThreadTask6::create):
  22607. (WebCore::CrossThreadTask7::create):
  22608. (WebCore::CrossThreadTask8::create):
  22609. 2011-04-25 Mark Rowe <mrowe@apple.com>
  22610. Reviewed by Dan Bernstein.
  22611. <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
  22612. * css/CSSStyleApplyProperty.cpp:
  22613. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
  22614. * css/CSSStyleApplyProperty.h:
  22615. (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
  22616. 2011-04-25 Levi Weintraub <leviw@chromium.org>
  22617. Reviewed by Ryosuke Niwa.
  22618. REGRESSION: a character appears after tab span when typing immediately before the tab span
  22619. https://bugs.webkit.org/show_bug.cgi?id=58132
  22620. Correcting the order of operations we use to avoid inserting into invalid positions in
  22621. ReplaceSelectionCommand to avoid inserting into tab-spans.
  22622. Test: editing/pasteboard/paste-before-tab-span.html
  22623. * editing/ReplaceSelectionCommand.cpp:
  22624. (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
  22625. positionAvoidingPrecedingNodes, since that function could once again put our position
  22626. inside a tab span.
  22627. 2011-04-25 David Levin <levin@chromium.org>
  22628. Reviewed by Adam Barth.
  22629. Fix OwnPtr strict error in ImageBuffer.h
  22630. https://bugs.webkit.org/show_bug.cgi?id=59422
  22631. * platform/graphics/ImageBuffer.h:
  22632. (WebCore::ImageBuffer::create):
  22633. 2011-04-25 Adam Barth <abarth@webkit.org>
  22634. Reviewed by David Levin.
  22635. Fix strict OwnPtr violations and whitelist known-tricky files
  22636. https://bugs.webkit.org/show_bug.cgi?id=59421
  22637. With this patch, WebCore builds cleanly with strict OwnPtrs.
  22638. * dom/MessagePort.cpp:
  22639. (WebCore::MessagePort::MessagePort):
  22640. * dom/XMLDocumentParserLibxml2.cpp:
  22641. * page/ContextMenuController.cpp:
  22642. (WebCore::ContextMenuController::ContextMenuController):
  22643. (WebCore::ContextMenuController::clearContextMenu):
  22644. * page/PluginHalter.cpp:
  22645. * platform/graphics/MediaPlayer.cpp:
  22646. * platform/network/ResourceRequestBase.cpp:
  22647. (WebCore::ResourceRequestBase::adopt):
  22648. (WebCore::ResourceRequestBase::copyData):
  22649. * svg/SVGDocumentExtensions.cpp:
  22650. 2011-04-25 David Levin <levin@chromium.org>
  22651. Reviewed by Adam Barth.
  22652. Fix OwnPtr strict errors in DatasetDOMStringMap.h.
  22653. https://bugs.webkit.org/show_bug.cgi?id=59419
  22654. * dom/DatasetDOMStringMap.h:
  22655. (WebCore::DatasetDOMStringMap::create):
  22656. 2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  22657. Reviewed by Eric Seidel.
  22658. KeyboardEvent.cpp should work with strict OwnPtrs.
  22659. https://bugs.webkit.org/show_bug.cgi?id=59403
  22660. * dom/KeyboardEvent.cpp:
  22661. (WebCore::KeyboardEvent::KeyboardEvent):
  22662. 2011-04-25 James Robinson <jamesr@chromium.org>
  22663. Reviewed by Eric Seidel.
  22664. Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
  22665. https://bugs.webkit.org/show_bug.cgi?id=59377
  22666. * css/CSSStyleSelector.cpp:
  22667. (WebCore::CSSStyleSelector::applyProperty):
  22668. * page/animation/AnimationBase.cpp:
  22669. (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
  22670. (WebCore::PropertyWrapperShadow::blend):
  22671. * rendering/style/RenderStyle.cpp:
  22672. (WebCore::RenderStyle::setTextShadow):
  22673. (WebCore::RenderStyle::setBoxShadow):
  22674. * rendering/style/RenderStyle.h:
  22675. (WebCore::InheritedFlags::textShadow):
  22676. * rendering/style/StyleRareInheritedData.cpp:
  22677. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  22678. (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
  22679. * rendering/style/StyleRareInheritedData.h:
  22680. * rendering/style/StyleRareNonInheritedData.cpp:
  22681. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  22682. 2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
  22683. Unreviewed, rolling out r84864.
  22684. http://trac.webkit.org/changeset/84864
  22685. https://bugs.webkit.org/show_bug.cgi?id=59413
  22686. Expect result of use-crash-in-non-wellformed-document.svg is
  22687. platform dependent (Requested by leoyang on #webkit).
  22688. * svg/SVGUseElement.cpp:
  22689. (WebCore::SVGUseElement::insertedIntoDocument):
  22690. 2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
  22691. Reviewed by Nikolas Zimmermann.
  22692. ASSERT failure in SVGUseElement
  22693. https://bugs.webkit.org/show_bug.cgi?id=59313
  22694. In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
  22695. was wrong because the document may not be well-formed.
  22696. This patch asserts the element is not pending on resource or the
  22697. document is not well-formed.
  22698. Test: svg/custom/use-crash-in-non-wellformed-document.svg
  22699. * svg/SVGUseElement.cpp:
  22700. (WebCore::isWellFormedDocument):
  22701. (WebCore::SVGUseElement::insertedIntoDocument):
  22702. 2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
  22703. Reviewed by Tony Chang.
  22704. Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
  22705. https://bugs.webkit.org/show_bug.cgi?id=59028
  22706. The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
  22707. Moving the code for base class we can reduce the efforts to support DataTransferItems
  22708. element in different platforms.
  22709. * Android.mk:
  22710. * CMakeLists.txt:
  22711. * GNUmakefile.list.am:
  22712. * WebCore.gypi:
  22713. * WebCore.pro:
  22714. * WebCore.vcproj/WebCore.vcproj:
  22715. * WebCore.xcodeproj/project.pbxproj:
  22716. * dom/DataTransferItem.cpp:
  22717. (WebCore::DataTransferItem::DataTransferItem):
  22718. (WebCore::DataTransferItem::owner):
  22719. (WebCore::DataTransferItem::kind):
  22720. (WebCore::DataTransferItem::type):
  22721. * dom/DataTransferItem.h:
  22722. * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
  22723. (WebCore::DataTransferItems::DataTransferItems):
  22724. (WebCore::DataTransferItems::length):
  22725. (WebCore::DataTransferItems::item):
  22726. (WebCore::DataTransferItems::deleteItem):
  22727. (WebCore::DataTransferItems::clear):
  22728. (WebCore::DataTransferItems::add):
  22729. * dom/DataTransferItems.h:
  22730. * platform/chromium/DataTransferItemChromium.cpp:
  22731. (WebCore::DataTransferItem::create):
  22732. (WebCore::DataTransferItemChromium::DataTransferItemChromium):
  22733. (WebCore::DataTransferItemChromium::getAsString):
  22734. (WebCore::DataTransferItemChromium::getAsFile):
  22735. * platform/chromium/DataTransferItemChromium.h:
  22736. * platform/chromium/DataTransferItemsChromium.cpp:
  22737. (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
  22738. * platform/chromium/DataTransferItemsChromium.h:
  22739. 2011-04-25 Chris Marrin <cmarrin@apple.com>
  22740. Reviewed by Simon Fraser.
  22741. REGRESSION(75137): directly composited images are double-drawn sometimes
  22742. https://bugs.webkit.org/show_bug.cgi?id=58632
  22743. Depending on the order of operations (layout, creating compositing
  22744. layers and creating simple image layers) a layer can have both image
  22745. content and have m_drawsContent=true. In this case 2 copies of the image
  22746. are drawn in the layer. If the image has alpha, it looks wrong.
  22747. I added an updateDrawsContent() call after setting the image contents
  22748. to make sure it's correct.
  22749. I couldn't create a test case that shows the problem because layerTreeAsText()
  22750. doesn't emit enough info to show this level of detail. I've opened
  22751. https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
  22752. * rendering/RenderLayerBacking.cpp:
  22753. (WebCore::RenderLayerBacking::updateImageContents):
  22754. 2011-04-25 Kenneth Russell <kbr@google.com>
  22755. Reviewed by David Levin.
  22756. Fix OwnPtr strict errors in InlineFlowBox.cpp
  22757. https://bugs.webkit.org/show_bug.cgi?id=59392
  22758. * rendering/InlineFlowBox.cpp:
  22759. (WebCore::InlineFlowBox::setLayoutOverflow):
  22760. (WebCore::InlineFlowBox::setVisualOverflow):
  22761. 2011-04-25 Kenneth Russell <kbr@google.com>
  22762. Reviewed by David Levin.
  22763. Fix OwnPtr strict errors in TransformState.cpp
  22764. https://bugs.webkit.org/show_bug.cgi?id=59380
  22765. * rendering/TransformState.cpp:
  22766. (WebCore::TransformState::applyTransform):
  22767. 2011-04-25 Adam Barth <abarth@webkit.org>
  22768. Reviewed by James Robinson.
  22769. DOMWindow.cpp should work with strict OwnPtrs
  22770. https://bugs.webkit.org/show_bug.cgi?id=59356
  22771. * page/DOMWindow.cpp:
  22772. (WebCore::PostMessageTimer::fired):
  22773. (WebCore::DOMWindow::postMessageTimerFired):
  22774. * page/DOMWindow.h:
  22775. 2011-04-25 Adam Klein <adamk@chromium.org>
  22776. Reviewed by James Robinson.
  22777. Fix OwnPtr strict errors in some SVG classes.
  22778. https://bugs.webkit.org/show_bug.cgi?id=59395
  22779. * rendering/style/SVGRenderStyleDefs.cpp:
  22780. (WebCore::StyleShadowSVGData::StyleShadowSVGData):
  22781. * svg/SVGSVGElement.cpp:
  22782. (WebCore::SVGSVGElement::SVGSVGElement):
  22783. * svg/SVGStyledTransformableElement.cpp:
  22784. (WebCore::SVGStyledTransformableElement::supplementalTransform):
  22785. * svg/SVGTextElement.cpp:
  22786. (WebCore::SVGTextElement::supplementalTransform):
  22787. * svg/graphics/SVGImage.cpp:
  22788. (WebCore::SVGImage::dataChanged):
  22789. 2011-04-25 Adam Barth <abarth@webkit.org>
  22790. Re-land changes to ValidationMessage.
  22791. * html/ValidationMessage.cpp:
  22792. (WebCore::ValidationMessage::setMessage):
  22793. (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
  22794. (WebCore::ValidationMessage::requestToHideMessage):
  22795. 2011-04-25 Ojan Vafai <ojan@chromium.org>
  22796. Reviewed by James Robinson.
  22797. fix OwnPtr strict error in FrameView.cpp
  22798. https://bugs.webkit.org/show_bug.cgi?id=59402
  22799. * page/FrameView.cpp:
  22800. (WebCore::FrameView::FrameView):
  22801. (WebCore::FrameView::addWidgetToUpdate):
  22802. 2011-04-25 Adam Klein <adamk@chromium.org>
  22803. Unreviewed, rolling out r84844.
  22804. http://trac.webkit.org/changeset/84844
  22805. https://bugs.webkit.org/show_bug.cgi?id=59395
  22806. Checked in too much.
  22807. * rendering/style/SVGRenderStyleDefs.cpp:
  22808. (WebCore::StyleShadowSVGData::StyleShadowSVGData):
  22809. * svg/SVGDocumentExtensions.cpp:
  22810. (WebCore::SVGDocumentExtensions::removePendingResource):
  22811. * svg/SVGSVGElement.cpp:
  22812. (WebCore::SVGSVGElement::SVGSVGElement):
  22813. * svg/SVGStyledTransformableElement.cpp:
  22814. (WebCore::SVGStyledTransformableElement::supplementalTransform):
  22815. * svg/SVGTextElement.cpp:
  22816. (WebCore::SVGTextElement::supplementalTransform):
  22817. * svg/graphics/SVGImage.cpp:
  22818. (WebCore::SVGImage::dataChanged):
  22819. 2011-04-25 Adrienne Walker <enne@google.com>
  22820. Reviewed by David Levin.
  22821. Make ActiveDOMCallback play nice with OwnPtr strict mode
  22822. https://bugs.webkit.org/show_bug.cgi?id=59398
  22823. * bindings/generic/ActiveDOMCallback.cpp:
  22824. (WebCore::ActiveDOMCallback::ActiveDOMCallback):
  22825. 2011-04-25 Adam Klein <adamk@chromium.org>
  22826. Reviewed by James Robinson.
  22827. Fix OwnPtr strict errors in some SVG classes.
  22828. https://bugs.webkit.org/show_bug.cgi?id=59395
  22829. * rendering/style/SVGRenderStyleDefs.cpp:
  22830. (WebCore::StyleShadowSVGData::StyleShadowSVGData):
  22831. * svg/SVGSVGElement.cpp:
  22832. (WebCore::SVGSVGElement::SVGSVGElement):
  22833. * svg/SVGStyledTransformableElement.cpp:
  22834. (WebCore::SVGStyledTransformableElement::supplementalTransform):
  22835. * svg/SVGTextElement.cpp:
  22836. (WebCore::SVGTextElement::supplementalTransform):
  22837. * svg/graphics/SVGImage.cpp:
  22838. (WebCore::SVGImage::dataChanged):
  22839. 2011-04-25 James Robinson <jamesr@chromium.org>
  22840. Unreviewed, rolling out r84835.
  22841. http://trac.webkit.org/changeset/84835
  22842. https://bugs.webkit.org/show_bug.cgi?id=59394
  22843. Breaks compile because Deque<OwnPtr> doesn't work
  22844. * dom/XMLDocumentParserLibxml2.cpp:
  22845. (WebCore::PendingCallbacks::~PendingCallbacks):
  22846. (WebCore::PendingCallbacks::appendStartElementNSCallback):
  22847. (WebCore::PendingCallbacks::appendEndElementNSCallback):
  22848. (WebCore::PendingCallbacks::appendCharactersCallback):
  22849. (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
  22850. (WebCore::PendingCallbacks::appendCDATABlockCallback):
  22851. (WebCore::PendingCallbacks::appendCommentCallback):
  22852. (WebCore::PendingCallbacks::appendInternalSubsetCallback):
  22853. (WebCore::PendingCallbacks::appendErrorCallback):
  22854. (WebCore::XMLDocumentParser::XMLDocumentParser):
  22855. * html/ValidationMessage.cpp:
  22856. (WebCore::ValidationMessage::setMessage):
  22857. (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
  22858. (WebCore::ValidationMessage::requestToHideMessage):
  22859. 2011-04-25 James Robinson <jamesr@chromium.org>
  22860. Reviewed by Sam Weinig.
  22861. Fix OwnPtr strict mode violation in ImageBufferCG
  22862. https://bugs.webkit.org/show_bug.cgi?id=59396
  22863. * platform/graphics/cg/ImageBufferCG.cpp:
  22864. (WebCore::ImageBuffer::ImageBuffer):
  22865. 2011-04-25 Huang Dongsung <luxtella@company100.net>
  22866. Reviewed by Dirk Schulze.
  22867. [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
  22868. https://bugs.webkit.org/show_bug.cgi?id=59308
  22869. An unused local variable is created and even allocates heap memory.
  22870. * platform/graphics/skia/PlatformContextSkia.cpp:
  22871. (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  22872. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  22873. Qt build fix: Updated files not used by other ports for rename.
  22874. * bindings/js/JSTouchCustom.cpp:
  22875. (WebCore::toJSNewlyCreated):
  22876. * bindings/js/JSTouchListCustom.cpp:
  22877. (WebCore::toJSNewlyCreated):
  22878. 2011-04-25 Adrienne Walker <enne@google.com>
  22879. Reviewed by David Levin.
  22880. WebCore/css/CSS* files should play nice with strict OwnPtrs
  22881. https://bugs.webkit.org/show_bug.cgi?id=59382
  22882. * css/CSSFontFaceSource.cpp:
  22883. (WebCore::CSSFontFaceSource::getFontData):
  22884. * css/CSSParser.cpp:
  22885. (WebCore::CSSParser::addProperty):
  22886. (WebCore::CSSParser::parseValue):
  22887. 2011-04-25 Adam Barth <abarth@webkit.org>
  22888. Reviewed by James Robinson.
  22889. ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
  22890. https://bugs.webkit.org/show_bug.cgi?id=59394
  22891. * dom/XMLDocumentParserLibxml2.cpp:
  22892. (WebCore::PendingCallbacks::PendingCallbacks):
  22893. (WebCore::PendingCallbacks::appendStartElementNSCallback):
  22894. (WebCore::PendingCallbacks::appendEndElementNSCallback):
  22895. (WebCore::PendingCallbacks::appendCharactersCallback):
  22896. (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
  22897. (WebCore::PendingCallbacks::appendCDATABlockCallback):
  22898. (WebCore::PendingCallbacks::appendCommentCallback):
  22899. (WebCore::PendingCallbacks::appendInternalSubsetCallback):
  22900. (WebCore::PendingCallbacks::appendErrorCallback):
  22901. (WebCore::XMLDocumentParser::XMLDocumentParser):
  22902. * html/ValidationMessage.cpp:
  22903. (WebCore::ValidationMessage::setMessage):
  22904. (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
  22905. (WebCore::ValidationMessage::requestToHideMessage):
  22906. 2011-04-25 James Robinson <jamesr@chromium.org>
  22907. Reviewed by Adam Barth.
  22908. Fix OwnPtr strictness issues in WebCore/inspector/
  22909. https://bugs.webkit.org/show_bug.cgi?id=59387
  22910. * inspector/InspectorAgent.cpp:
  22911. (WebCore::InspectorAgent::InspectorAgent):
  22912. * inspector/InspectorController.cpp:
  22913. (WebCore::InspectorController::InspectorController):
  22914. * inspector/InspectorStyleSheet.cpp:
  22915. (WebCore::InspectorStyleSheet::ensureSourceData):
  22916. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  22917. Reviewed by Beth Dakin.
  22918. Removed XPathNamespace because it was unused
  22919. https://bugs.webkit.org/show_bug.cgi?id=59381
  22920. This allows us to make Node::ownerDocument() non-virtual, though it has
  22921. the unhappy side-effect of rebuilding the world.
  22922. * CMakeLists.txt:
  22923. * GNUmakefile.list.am:
  22924. * WebCore.gypi:
  22925. * WebCore.pro:
  22926. * WebCore.vcproj/WebCore.vcproj:
  22927. * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
  22928. * dom/Node.h: Hello fast code!
  22929. * xml/XPathNamespace.cpp: Removed.
  22930. * xml/XPathNamespace.h: Removed.
  22931. 2011-04-25 Adam Barth <abarth@webkit.org>
  22932. Reviewed by Darin Adler.
  22933. HistoryItemMac should play nice with OwnPtrs
  22934. https://bugs.webkit.org/show_bug.cgi?id=59388
  22935. * history/mac/HistoryItemMac.mm:
  22936. (WebCore::HistoryItem::setTransientProperty):
  22937. 2011-04-25 David Levin <levin@chromium.org>
  22938. Reviewed by Kenneth Russell.
  22939. Fix strict OwnPtrs in ContextMenuController.cpp
  22940. https://bugs.webkit.org/show_bug.cgi?id=59375
  22941. * page/ContextMenuController.cpp:
  22942. (WebCore::ContextMenuController::createContextMenu):
  22943. (WebCore::separatorItem):
  22944. 2011-04-25 Adam Barth <abarth@webkit.org>
  22945. Reviewed by Darin Adler.
  22946. CheckedRadioButton should play nice with strict OwnPtr
  22947. https://bugs.webkit.org/show_bug.cgi?id=59386
  22948. * dom/CheckedRadioButtons.cpp:
  22949. (WebCore::CheckedRadioButtons::addButton):
  22950. 2011-04-25 Adam Barth <abarth@webkit.org>
  22951. Reviewed by David Levin.
  22952. Resource*.cpp should play nice with strict OwnPtrs
  22953. https://bugs.webkit.org/show_bug.cgi?id=59383
  22954. * bridge/runtime_method.cpp:
  22955. (JSC::RuntimeMethod::RuntimeMethod):
  22956. * platform/network/ResourceHandle.cpp:
  22957. (WebCore::ResourceHandle::ResourceHandle):
  22958. * platform/network/ResourceResponseBase.cpp:
  22959. (WebCore::ResourceResponseBase::adopt):
  22960. (WebCore::ResourceResponseBase::copyData):
  22961. 2011-04-25 Adam Barth <abarth@webkit.org>
  22962. Reviewed by David Levin.
  22963. Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
  22964. https://bugs.webkit.org/show_bug.cgi?id=59374
  22965. * bridge/objc/objc_runtime.mm:
  22966. (JSC::Bindings::callObjCFallbackObject):
  22967. * page/Page.cpp:
  22968. (WebCore::Page::Page):
  22969. (WebCore::Page::initGroup):
  22970. * page/PageGroup.cpp:
  22971. (WebCore::PageGroup::addUserScriptToWorld):
  22972. (WebCore::PageGroup::addUserStyleSheetToWorld):
  22973. * page/mac/PageMac.cpp:
  22974. (WebCore::Page::addSchedulePair):
  22975. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  22976. Build fix: This time for sure!
  22977. * dom/make_names.pl:
  22978. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  22979. Build fix: Let's edit the script instead of the autogenrated file. That
  22980. way, our change will stand the test of time.
  22981. * dom/make_names.pl:
  22982. 2011-04-25 Adam Barth <abarth@webkit.org>
  22983. Reviewed by David Levin.
  22984. Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
  22985. https://bugs.webkit.org/show_bug.cgi?id=59368
  22986. * html/HTMLMediaElement.cpp:
  22987. (WebCore::HTMLMediaElement::HTMLMediaElement):
  22988. * platform/network/HTTPHeaderMap.cpp:
  22989. (WebCore::HTTPHeaderMap::copyData):
  22990. 2011-04-25 James Robinson <jamesr@chromium.org>
  22991. Reviewed by Adam Barth.
  22992. Fix strict OwnPtr violations in Render*.cpp
  22993. https://bugs.webkit.org/show_bug.cgi?id=59361
  22994. * rendering/RenderBlock.cpp:
  22995. (WebCore::RenderBlock::RenderBlock):
  22996. (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
  22997. * rendering/RenderBox.cpp:
  22998. (WebCore::RenderBox::addLayoutOverflow):
  22999. (WebCore::RenderBox::addVisualOverflow):
  23000. * rendering/RenderButton.cpp:
  23001. (WebCore::RenderButton::styleDidChange):
  23002. * rendering/RenderLayer.cpp:
  23003. (WebCore::RenderLayer::updateTransform):
  23004. (WebCore::RenderLayer::paintChildLayerIntoColumns):
  23005. (WebCore::RenderLayer::hitTestChildLayerColumns):
  23006. (WebCore::RenderLayer::ensureBacking):
  23007. * rendering/RenderTable.cpp:
  23008. (WebCore::RenderTable::styleDidChange):
  23009. * rendering/RenderView.cpp:
  23010. (WebCore::RenderView::compositor):
  23011. * rendering/style/RenderStyle.cpp:
  23012. (WebCore::RenderStyle::addCachedPseudoStyle):
  23013. (WebCore::RenderStyle::accessCounterDirectives):
  23014. (WebCore::RenderStyle::accessAnimations):
  23015. (WebCore::RenderStyle::accessTransitions):
  23016. * rendering/svg/RenderSVGResourceFilter.cpp:
  23017. (WebCore::RenderSVGResourceFilter::applyResource):
  23018. * rendering/svg/SVGResources.cpp:
  23019. (WebCore::SVGResources::SVGResources):
  23020. 2011-04-25 Adam Barth <abarth@webkit.org>
  23021. Attempt to fix the compile.
  23022. * platform/graphics/MediaPlayer.cpp:
  23023. (WebCore::MediaPlayer::loadWithNextMediaEngine):
  23024. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  23025. Rubber-stamped by Beth Dakin.
  23026. Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
  23027. CREATE_DOM_WRAPPER because there's no meaningful difference between
  23028. them anymore.
  23029. * bindings/js/JSCDATASectionCustom.cpp:
  23030. (WebCore::toJSNewlyCreated):
  23031. * bindings/js/JSCSSRuleCustom.cpp:
  23032. (WebCore::toJS):
  23033. * bindings/js/JSCSSValueCustom.cpp:
  23034. (WebCore::toJS):
  23035. * bindings/js/JSDOMBinding.h:
  23036. * bindings/js/JSDocumentCustom.cpp:
  23037. (WebCore::toJS):
  23038. * bindings/js/JSElementCustom.cpp:
  23039. (WebCore::toJSNewlyCreated):
  23040. * bindings/js/JSEventCustom.cpp:
  23041. (WebCore::toJS):
  23042. * bindings/js/JSHTMLCollectionCustom.cpp:
  23043. (WebCore::toJS):
  23044. * bindings/js/JSImageDataCustom.cpp:
  23045. (WebCore::toJS):
  23046. * bindings/js/JSNodeCustom.cpp:
  23047. (WebCore::createWrapperInline):
  23048. * bindings/js/JSSVGPathSegCustom.cpp:
  23049. (WebCore::toJS):
  23050. * bindings/js/JSStyleSheetCustom.cpp:
  23051. (WebCore::toJS):
  23052. * bindings/js/JSTextCustom.cpp:
  23053. (WebCore::toJSNewlyCreated):
  23054. * bindings/js/JSWebKitCSSMatrixCustom.cpp:
  23055. (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
  23056. * bindings/js/JSWebSocketCustom.cpp:
  23057. (WebCore::JSWebSocketConstructor::constructJSWebSocket):
  23058. * bindings/js/JSXMLHttpRequestCustom.cpp:
  23059. (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
  23060. * bindings/js/JSXSLTProcessorCustom.cpp:
  23061. (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
  23062. 2011-04-25 Adam Barth <abarth@webkit.org>
  23063. Reviewed by James Robinson.
  23064. HTMLDocumentParser should play nice with OwnPtrs
  23065. https://bugs.webkit.org/show_bug.cgi?id=59363
  23066. * html/parser/HTMLDocumentParser.cpp:
  23067. (WebCore::HTMLDocumentParser::pumpTokenizer):
  23068. 2011-04-25 Adam Barth <abarth@webkit.org>
  23069. Reviewed by James Robinson.
  23070. Frame.cpp should work with strict OwnPtrs
  23071. https://bugs.webkit.org/show_bug.cgi?id=59360
  23072. * page/Frame.cpp:
  23073. (WebCore::createRegExpForLabels):
  23074. 2011-04-25 Adam Barth <abarth@webkit.org>
  23075. Reviewed by David Levin.
  23076. Fix strict OwnPtr in Element.cpp
  23077. https://bugs.webkit.org/show_bug.cgi?id=59357
  23078. * dom/NodeRareData.h:
  23079. (WebCore::NodeRareData::ensureEventTargetData):
  23080. 2011-04-25 Adam Barth <abarth@webkit.org>
  23081. Reviewed by David Levin.
  23082. Fix strict OwnPtr issues in Media*.cpp
  23083. https://bugs.webkit.org/show_bug.cgi?id=59354
  23084. There's still a tricky case in MediaPlayer.cpp, but we'll worry about
  23085. that later.
  23086. * css/MediaQueryMatcher.cpp:
  23087. (WebCore::MediaQueryMatcher::addListener):
  23088. * dom/Document.cpp:
  23089. * platform/graphics/MediaPlayer.cpp:
  23090. (WebCore::createNullMediaPlayer):
  23091. 2011-04-25 James Robinson <jamesr@chromium.org>
  23092. Reviewed by David Levin.
  23093. Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
  23094. https://bugs.webkit.org/show_bug.cgi?id=59353
  23095. * rendering/RenderLayerCompositor.cpp:
  23096. (WebCore::RenderLayerCompositor::RenderLayerCompositor):
  23097. 2011-04-25 Adam Barth <abarth@webkit.org>
  23098. Reviewed by James Robinson.
  23099. Worker*.cpp should work with strict OwnPtrs
  23100. https://bugs.webkit.org/show_bug.cgi?id=59346
  23101. * inspector/WorkerInspectorController.cpp:
  23102. (WebCore::WorkerInspectorController::WorkerInspectorController):
  23103. * workers/WorkerContext.cpp:
  23104. (WebCore::WorkerContext::WorkerContext):
  23105. * workers/WorkerRunLoop.cpp:
  23106. (WebCore::WorkerRunLoop::WorkerRunLoop):
  23107. * workers/WorkerScriptLoader.cpp:
  23108. (WebCore::WorkerScriptLoader::createResourceRequest):
  23109. 2011-04-25 James Robinson <jamesr@chromium.org>
  23110. Reviewed by Adam Barth.
  23111. Remove bad use of OwnPtr::set() in IconDatabase.cpp
  23112. https://bugs.webkit.org/show_bug.cgi?id=59344
  23113. Needed for strict OwnPtr compliance.
  23114. * loader/icon/IconDatabase.cpp:
  23115. (WebCore::readySQLiteStatement):
  23116. 2011-04-25 Adam Barth <abarth@webkit.org>
  23117. Reviewed by Maciej Stachowiak.
  23118. ImageBuffer.h should work with strict OwnPtrs
  23119. https://bugs.webkit.org/show_bug.cgi?id=59341
  23120. This patch is to prepare for the strict OwnPtr hack-a-thon.
  23121. * platform/graphics/ImageBuffer.h:
  23122. (WebCore::ImageBuffer::create):
  23123. 2011-04-25 Steve Falkenburg <sfalken@apple.com>
  23124. Reviewed by Brian Weinstein.
  23125. WebCore build on Windows should include windows.h in its precompiled header to speed builds
  23126. https://bugs.webkit.org/show_bug.cgi?id=59339
  23127. windows.h is included by several of the underlying wtf headers, including Atomics.h and
  23128. ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
  23129. On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
  23130. (a 12% speedup).
  23131. * WebCorePrefix.h: Include windows.h
  23132. 2011-04-25 Martin Robinson <mrobinson@igalia.com>
  23133. Reviewed by Xan Lopez.
  23134. [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
  23135. https://bugs.webkit.org/show_bug.cgi?id=59311
  23136. * platform/gtk/MainFrameScrollbarGtk.cpp:
  23137. (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
  23138. disconnect any lingering signal handlers. This prevents an adjustment from controlling the
  23139. active ScrollView and some zombie ScrollView.
  23140. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  23141. Another shot at fixing the EFL build.
  23142. * UseJSC.cmake:
  23143. * bindings/js/JSDOMBinding.cpp:
  23144. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  23145. Try to fix EFL build.
  23146. * UseJSC.cmake: Added a missing file.
  23147. 2011-04-25 Geoffrey Garen <ggaren@apple.com>
  23148. Reviewed by Oliver Hunt.
  23149. Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
  23150. https://bugs.webkit.org/show_bug.cgi?id=59333
  23151. * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
  23152. * bindings/js/JSDOMBinding.cpp:
  23153. * bindings/js/JSDOMBinding.h:
  23154. * bindings/js/JSDocumentCustom.cpp:
  23155. * bindings/js/JSWorkerContextCustom.cpp:
  23156. (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
  23157. * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
  23158. lifetime management.
  23159. * dom/Document.idl: No need for a custom mark function anymore, since
  23160. ActiveDOMObjets now manage their own lifetimes.
  23161. * dom/MessagePort.cpp:
  23162. (WebCore::MessagePort::hasPendingActivity): Correctly report that we
  23163. have pending activity when we're remotely entangled, instead of relying
  23164. on our clients to know this about us and do the check for us.
  23165. * dom/MessagePort.h: FIXME!
  23166. * dom/MessagePort.idl:
  23167. * fileapi/DOMFileSystem.idl:
  23168. * fileapi/FileReader.idl:
  23169. * fileapi/FileWriter.idl:
  23170. * notifications/Notification.idl:
  23171. * notifications/NotificationCenter.idl:
  23172. * page/EventSource.idl:
  23173. * storage/IDBDatabase.idl:
  23174. * storage/IDBRequest.idl:
  23175. * storage/IDBTransaction.idl:
  23176. * webaudio/AudioContext.idl:
  23177. * websockets/WebSocket.idl:
  23178. * workers/AbstractWorker.idl:
  23179. * workers/SharedWorker.idl:
  23180. * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
  23181. * workers/WorkerContext.cpp:
  23182. (WebCore::WorkerContext::hasPendingActivity): No need to make up for
  23183. MessagePort::hasPendingActivity being wrong anymore, since it's now right.
  23184. * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
  23185. 2011-04-25 Yury Semikhatsky <yurys@chromium.org>
  23186. Reviewed by Pavel Feldman.
  23187. Web Inspector: worker messages should be routed to corresponding worker front-end
  23188. https://bugs.webkit.org/show_bug.cgi?id=59323
  23189. Added WorkerManager which is responsible for routing messages between
  23190. Page inspector front-end and Worker inspector front-ends.
  23191. * WebCore.gypi:
  23192. * inspector/front-end/WebKit.qrc:
  23193. * inspector/front-end/WorkerManager.js: Added.
  23194. (WebInspector.WorkerManager):
  23195. (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
  23196. (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
  23197. (WebInspector.WorkerManager.loaded):
  23198. (WebInspector.WorkerFrontendStub):
  23199. (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
  23200. (WebInspector.WorkerDispatcher):
  23201. (WebInspector.WorkerDispatcher.prototype._receiveMessage):
  23202. (WebInspector.WorkerDispatcher.prototype.workerCreated):
  23203. (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
  23204. * inspector/front-end/inspector.html:
  23205. * inspector/front-end/inspector.js:
  23206. (WebInspector.loaded):
  23207. 2011-04-25 Annie Sullivan <sullivan@chromium.org>
  23208. Reviewed by Pavel Feldman.
  23209. Web Inspector: [Resources panel] Should be easy to copy data.
  23210. https://bugs.webkit.org/show_bug.cgi?id=45662
  23211. Adds context menu items to copy resource location, resource request headers, and resource response headers.
  23212. * inspector/front-end/NetworkPanel.js:
  23213. (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
  23214. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
  23215. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
  23216. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
  23217. * inspector/front-end/Resource.js:
  23218. (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
  23219. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
  23220. 2011-04-25 Alexander Pavlov <apavlov@chromium.org>
  23221. Reviewed by Yury Semikhatsky.
  23222. Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
  23223. https://bugs.webkit.org/show_bug.cgi?id=59322
  23224. Use TextResourceDecoder to determine external stylesheet charsets correctly.
  23225. Test: inspector/styles/parse-utf8-bom.html
  23226. * inspector/InspectorStyleSheet.cpp:
  23227. (WebCore::InspectorStyleSheet::originalStyleSheetText):
  23228. 2011-04-25 Pavel Feldman <pfeldman@google.com>
  23229. Not reviewed: Inspector.json cleanup.
  23230. * inspector/Inspector.json:
  23231. 2011-04-25 Yury Semikhatsky <yurys@chromium.org>
  23232. Reviewed by Pavel Feldman.
  23233. Web Inspector: introduce InspectorWorkerAgent
  23234. https://bugs.webkit.org/show_bug.cgi?id=59320
  23235. InspectorWorkerAgent is responsible for routing inspector messages
  23236. between worker context inspector agents and corresponding worker
  23237. inspector front-end.
  23238. * CMakeLists.txt:
  23239. * GNUmakefile.list.am:
  23240. * WebCore.gypi:
  23241. * WebCore.pro:
  23242. * WebCore.vcproj/WebCore.vcproj:
  23243. * WebCore.xcodeproj/project.pbxproj:
  23244. * inspector/CodeGeneratorInspector.pm:
  23245. * inspector/Inspector.json:
  23246. * inspector/InspectorAgent.cpp:
  23247. (WebCore::InspectorAgent::InspectorAgent):
  23248. (WebCore::InspectorAgent::setFrontend):
  23249. (WebCore::InspectorAgent::disconnectFrontend):
  23250. * inspector/InspectorAgent.h:
  23251. (WebCore::InspectorAgent::workerAgent):
  23252. * inspector/InspectorController.cpp:
  23253. (WebCore::InspectorController::connectFrontend):
  23254. (WebCore::InspectorController::disconnectFrontend):
  23255. * inspector/InspectorInstrumentation.cpp:
  23256. (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
  23257. * inspector/InspectorInstrumentation.h:
  23258. (WebCore::InspectorInstrumentation::willStartWorkerContext):
  23259. (WebCore::InspectorInstrumentation::didStartWorkerContext):
  23260. * inspector/InspectorWorkerAgent.cpp: Added.
  23261. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
  23262. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
  23263. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
  23264. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
  23265. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
  23266. (WebCore::InspectorWorkerAgent::create):
  23267. (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
  23268. (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
  23269. (WebCore::InspectorWorkerAgent::setFrontend):
  23270. (WebCore::InspectorWorkerAgent::clearFrontend):
  23271. (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
  23272. (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  23273. * inspector/InspectorWorkerAgent.h: Added.
  23274. * inspector/InstrumentingAgents.h:
  23275. (WebCore::InstrumentingAgents::InstrumentingAgents):
  23276. (WebCore::InstrumentingAgents::inspectorWorkerAgent):
  23277. (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
  23278. * inspector/WorkerInspectorController.cpp:
  23279. (WebCore::WorkerInspectorController::connectFrontend):
  23280. * inspector/generate-inspector-idl:
  23281. * workers/Worker.cpp:
  23282. (WebCore::Worker::notifyFinished):
  23283. * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
  23284. messages sent from the inspected page worker agent to the worker context inspector agents.
  23285. (WebCore::WorkerContextInspectorProxy::connectFrontend):
  23286. (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
  23287. (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
  23288. (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
  23289. * workers/WorkerContextProxy.h:
  23290. (WebCore::WorkerContextProxy::inspectorProxy):
  23291. 2011-04-25 Pavel Feldman <pfeldman@google.com>
  23292. Reviewed by Yury Semikhatsky.
  23293. Web Inspector: move Frame and Resource Tree management into the Page agent.
  23294. https://bugs.webkit.org/show_bug.cgi?id=59321
  23295. Network agent should only handle network-related activities.
  23296. Frame structure should be managed by the Page agent instead.
  23297. * inspector/Inspector.json:
  23298. * inspector/InspectorAgent.cpp:
  23299. (WebCore::InspectorAgent::InspectorAgent):
  23300. * inspector/InspectorDOMAgent.cpp:
  23301. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  23302. (WebCore::InspectorDOMAgent::setFrontend):
  23303. (WebCore::InspectorDOMAgent::restore):
  23304. (WebCore::InspectorDOMAgent::highlightFrame):
  23305. * inspector/InspectorDOMAgent.h:
  23306. (WebCore::InspectorDOMAgent::create):
  23307. * inspector/InspectorInstrumentation.cpp:
  23308. (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
  23309. (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  23310. (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
  23311. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  23312. * inspector/InspectorPageAgent.cpp:
  23313. (WebCore::InspectorPageAgent::create):
  23314. (WebCore::InspectorPageAgent::resourceContent):
  23315. (WebCore::InspectorPageAgent::resourceContentBase64):
  23316. (WebCore::InspectorPageAgent::resourceData):
  23317. (WebCore::InspectorPageAgent::cachedResource):
  23318. (WebCore::InspectorPageAgent::resourceTypeString):
  23319. (WebCore::InspectorPageAgent::cachedResourceType):
  23320. (WebCore::InspectorPageAgent::cachedResourceTypeString):
  23321. (WebCore::InspectorPageAgent::InspectorPageAgent):
  23322. (WebCore::InspectorPageAgent::setFrontend):
  23323. (WebCore::InspectorPageAgent::reload):
  23324. (WebCore::InspectorPageAgent::open):
  23325. (WebCore::InspectorPageAgent::getCookies):
  23326. (WebCore::InspectorPageAgent::deleteCookie):
  23327. (WebCore::InspectorPageAgent::getResourceTree):
  23328. (WebCore::InspectorPageAgent::getResourceContent):
  23329. (WebCore::InspectorPageAgent::restore):
  23330. (WebCore::InspectorPageAgent::domContentEventFired):
  23331. (WebCore::InspectorPageAgent::loadEventFired):
  23332. (WebCore::InspectorPageAgent::frameNavigated):
  23333. (WebCore::InspectorPageAgent::frameDetached):
  23334. (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
  23335. (WebCore::InspectorPageAgent::mainFrame):
  23336. (WebCore::pointerAsId):
  23337. (WebCore::InspectorPageAgent::frameForId):
  23338. (WebCore::InspectorPageAgent::frameId):
  23339. (WebCore::InspectorPageAgent::loaderId):
  23340. (WebCore::InspectorPageAgent::buildObjectForFrame):
  23341. (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  23342. * inspector/InspectorPageAgent.h:
  23343. * inspector/InspectorResourceAgent.cpp:
  23344. (WebCore::buildObjectForCachedResource):
  23345. (WebCore::InspectorResourceAgent::willSendRequest):
  23346. (WebCore::InspectorResourceAgent::didReceiveResponse):
  23347. (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
  23348. (WebCore::InspectorResourceAgent::setInitialScriptContent):
  23349. (WebCore::InspectorResourceAgent::setInitialXHRContent):
  23350. (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  23351. * inspector/InspectorResourceAgent.h:
  23352. (WebCore::InspectorResourceAgent::create):
  23353. * inspector/InspectorStyleSheet.cpp:
  23354. (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  23355. * inspector/front-end/NetworkManager.js:
  23356. (WebInspector.NetworkManager.prototype.requestContent):
  23357. * inspector/front-end/NetworkPanel.js:
  23358. (WebInspector.NetworkPanel):
  23359. (WebInspector.NetworkPanel.prototype.frameNavigated):
  23360. * inspector/front-end/ResourceTreeModel.js:
  23361. (WebInspector.ResourceTreeModel):
  23362. (WebInspector.ResourceTreeModel.prototype.frontendReused):
  23363. (WebInspector.ResourceTreeModel.prototype.frameNavigated):
  23364. (WebInspector.ResourceTreeModel.prototype.frameDetached):
  23365. * inspector/front-end/inspector.js:
  23366. (WebInspector.domContentEventFired):
  23367. (WebInspector.loadEventFired):
  23368. (WebInspector.frameNavigated):
  23369. (WebInspector.frameDetached):
  23370. 2011-04-25 Pavel Feldman <pfeldman@google.com>
  23371. Reviewed by Yury Semikhatsky.
  23372. Web Inspector: few protocol improvements.
  23373. https://bugs.webkit.org/show_bug.cgi?id=59319
  23374. - Page domain is documented
  23375. - setUserAgentOverride is moved to the Network agent
  23376. - setSearchingForNode -> setInspectModeEnabled
  23377. - highlightDOMNode -> highlightNode
  23378. - reloadPage -> reload
  23379. - openInNewWindow -> open with optional parameter
  23380. * inspector/Inspector.json:
  23381. * inspector/InspectorDOMAgent.cpp:
  23382. (WebCore::InspectorDOMAgent::setInspectModeEnabled):
  23383. (WebCore::InspectorDOMAgent::highlightNode):
  23384. * inspector/InspectorDOMAgent.h:
  23385. (WebCore::InspectorDOMAgent::hideNodeHighlight):
  23386. * inspector/InspectorInstrumentation.cpp:
  23387. (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
  23388. * inspector/InspectorPageAgent.cpp:
  23389. (WebCore::InspectorPageAgent::clearFrontend):
  23390. (WebCore::InspectorPageAgent::reload):
  23391. (WebCore::InspectorPageAgent::open):
  23392. * inspector/InspectorPageAgent.h:
  23393. * inspector/InspectorResourceAgent.cpp:
  23394. (WebCore::InspectorResourceAgent::clearFrontend):
  23395. (WebCore::InspectorResourceAgent::applyUserAgentOverride):
  23396. (WebCore::InspectorResourceAgent::setUserAgentOverride):
  23397. * inspector/InspectorResourceAgent.h:
  23398. * inspector/front-end/AuditsPanel.js:
  23399. (WebInspector.AuditsPanel.prototype._reloadResources):
  23400. * inspector/front-end/ElementsPanel.js:
  23401. (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  23402. * inspector/front-end/ExtensionServer.js:
  23403. (WebInspector.ExtensionServer.prototype._onReload):
  23404. * inspector/front-end/NetworkPanel.js:
  23405. (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
  23406. * inspector/front-end/ResourcesPanel.js:
  23407. (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
  23408. * inspector/front-end/inspector.js:
  23409. (WebInspector.highlightDOMNode):
  23410. (WebInspector.openResource):
  23411. (WebInspector.documentKeyDown):
  23412. 2011-04-25 Jon Lee <jonlee@apple.com>
  23413. Reviewed by Maciej Stachowiak.
  23414. Overlay scroller hard to see on pages with dark background (59183)
  23415. https://bugs.webkit.org/show_bug.cgi?id=59183
  23416. <rdar://problem/8975367>
  23417. Switch the scrollbar's overlay style depending on its frame's background color.
  23418. This refactors the getDocumentBackgroundColor method needed for gestures. The style
  23419. is determined and set on every paint() call to the Mac scrollbar theme.
  23420. * WebCore.exp.in: adding method to allow changing style
  23421. * page/Frame.cpp:
  23422. (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
  23423. * page/Frame.h:
  23424. * page/FrameView.cpp:
  23425. (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
  23426. * page/FrameView.h:
  23427. * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
  23428. * platform/ScrollableArea.h:
  23429. (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
  23430. * platform/mac/ScrollbarThemeMac.mm:
  23431. (WebCore::ScrollbarThemeMac::paint):
  23432. * platform/mac/WebCoreSystemInterface.h:
  23433. * platform/mac/WebCoreSystemInterface.mm:
  23434. 2011-04-25 Dan Bernstein <mitz@apple.com>
  23435. Reviewed by Maciej Stachowiak.
  23436. <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
  23437. https://bugs.webkit.org/show_bug.cgi?id=59315
  23438. * platform/Scrollbar.cpp:
  23439. (WebCore::Scrollbar::Scrollbar): Initialize new member variables.
  23440. (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
  23441. is scrolled a distance equal to the change in the mouse position.
  23442. (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
  23443. the document rather than the thumb, and pass the result to moveThumb.
  23444. (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
  23445. * platform/Scrollbar.h:
  23446. * platform/ScrollbarTheme.h:
  23447. (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
  23448. returns false.
  23449. * platform/mac/ScrollbarThemeMac.h:
  23450. * platform/mac/ScrollbarThemeMac.mm:
  23451. (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
  23452. Option key is down.
  23453. 2011-04-24 Geoffrey Garen <ggaren@apple.com>
  23454. Reviewed by Sam Weinig.
  23455. Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
  23456. https://bugs.webkit.org/show_bug.cgi?id=59307
  23457. * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
  23458. * bindings/js/JSCSSRuleCustom.cpp:
  23459. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  23460. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  23461. * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
  23462. of hand-coding them.
  23463. * bindings/js/JSDOMBinding.h:
  23464. (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
  23465. they're reasonably generic.
  23466. * bindings/js/JSDOMImplementationCustom.cpp:
  23467. * bindings/js/JSDOMStringMapCustom.cpp:
  23468. * bindings/js/JSDOMTokenListCustom.cpp:
  23469. * bindings/js/JSHTMLCollectionCustom.cpp:
  23470. * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
  23471. hand-coding them.
  23472. * bindings/js/JSMessageChannelCustom.cpp:
  23473. (WebCore::JSMessageChannel::visitChildren):
  23474. * bindings/js/JSMessagePortCustom.cpp:
  23475. (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
  23476. markDOMObjectWrapper. This is one of the few cases where a DOM object is
  23477. considered a stand-alone root. It's not as efficient as the shared root
  23478. case, but workers and message ports are very rare objects, so it's no
  23479. big deal.
  23480. * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
  23481. * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
  23482. * bindings/js/JSSharedWorkerCustom.cpp:
  23483. (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
  23484. markDOMObjectWrapper, as above. Once again, a stand-alone root.
  23485. * bindings/js/JSStyleSheetCustom.cpp:
  23486. * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
  23487. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  23488. (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
  23489. system for marking WebGL contexts and their associated satellite objects.
  23490. * bindings/js/JSWorkerContextCustom.cpp:
  23491. (WebCore::JSWorkerContext::visitChildren):
  23492. * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
  23493. markDOMObjectWrapper, as above. Once again, stand-alone roots.
  23494. (WebCore::JSXMLHttpRequest::visitChildren):
  23495. * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
  23496. XHR because it is not reachable from us.
  23497. * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
  23498. bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
  23499. * css/CSSRule.idl:
  23500. * css/CSSStyleDeclaration.idl:
  23501. * css/MediaList.idl:
  23502. * css/StyleMedia.idl:
  23503. * css/StyleSheet.idl:
  23504. * css/StyleSheetList.idl:
  23505. * dom/DOMImplementation.idl:
  23506. * dom/DOMStringMap.idl:
  23507. * dom/MessagePort.idl:
  23508. * dom/NamedNodeMap.idl:
  23509. * fileapi/Blob.idl:
  23510. * html/DOMTokenList.idl: Opt in to autogeneration.
  23511. * html/HTMLCanvasElement.cpp:
  23512. (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
  23513. usage, to reduce human error and make ownership rules more obvious.
  23514. * html/HTMLCollection.idl:
  23515. * html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
  23516. * html/canvas/CanvasRenderingContext.cpp:
  23517. * html/canvas/CanvasRenderingContext.h:
  23518. (WebCore::CanvasRenderingContext::ref):
  23519. (WebCore::CanvasRenderingContext::deref):
  23520. * html/canvas/CanvasRenderingContext2D.h:
  23521. (WebCore::CanvasRenderingContext2D::create):
  23522. (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
  23523. usage, to reduce human error and make ownership rules more obvious.
  23524. Inlined some functions to match our standard idiom and to make the code
  23525. in the header document itself.
  23526. * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
  23527. * html/canvas/OESStandardDerivatives.cpp:
  23528. (WebCore::OESStandardDerivatives::OESStandardDerivatives):
  23529. (WebCore::OESStandardDerivatives::create):
  23530. * html/canvas/OESStandardDerivatives.h:
  23531. * html/canvas/OESStandardDerivatives.idl:
  23532. * html/canvas/OESTextureFloat.cpp:
  23533. (WebCore::OESTextureFloat::OESTextureFloat):
  23534. (WebCore::OESTextureFloat::create):
  23535. * html/canvas/OESTextureFloat.h:
  23536. * html/canvas/OESTextureFloat.idl:
  23537. * html/canvas/OESVertexArrayObject.cpp:
  23538. (WebCore::OESVertexArrayObject::OESVertexArrayObject):
  23539. (WebCore::OESVertexArrayObject::create):
  23540. * html/canvas/OESVertexArrayObject.h:
  23541. * html/canvas/OESVertexArrayObject.idl:
  23542. * html/canvas/WebGLExtension.cpp:
  23543. (WebCore::WebGLExtension::WebGLExtension):
  23544. * html/canvas/WebGLExtension.h:
  23545. (WebCore::WebGLExtension::ref):
  23546. (WebCore::WebGLExtension::deref):
  23547. (WebCore::WebGLExtension::context):
  23548. * html/canvas/WebGLRenderingContext.cpp:
  23549. (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  23550. (WebCore::WebGLRenderingContext::getExtension):
  23551. * html/canvas/WebGLRenderingContext.h:
  23552. * html/canvas/WebKitLoseContext.cpp:
  23553. (WebCore::WebKitLoseContext::WebKitLoseContext):
  23554. (WebCore::WebKitLoseContext::create):
  23555. (WebCore::WebKitLoseContext::loseContext):
  23556. * html/canvas/WebKitLoseContext.h:
  23557. * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL
  23558. canavs rendering contexts to match the model for 2D canvas rendering
  23559. contexts. This makes garbage collection a lot more straightforward, but
  23560. it also makes the behavior of these objects more reliable. (Previously,
  23561. satellite objects would magically stop working when the last reference
  23562. to their owner object was dropped. Now, satellite objects keep their owner
  23563. alive through reference counting.)
  23564. * loader/appcache/DOMApplicationCache.idl:
  23565. * page/BarInfo.idl:
  23566. * page/Console.idl:
  23567. * page/DOMSelection.idl:
  23568. * page/Geolocation.idl:
  23569. * page/History.idl:
  23570. * page/Location.idl:
  23571. * page/Navigator.idl:
  23572. * page/Screen.idl:
  23573. * page/WorkerNavigator.idl:
  23574. * plugins/DOMMimeTypeArray.h:
  23575. (WebCore::DOMMimeTypeArray::frame):
  23576. * plugins/DOMMimeTypeArray.idl:
  23577. * plugins/DOMPluginArray.h:
  23578. (WebCore::DOMPluginArray::frame):
  23579. * plugins/DOMPluginArray.idl:
  23580. * storage/Storage.idl:
  23581. * workers/WorkerLocation.idl: Opt in to autogeneration.
  23582. * xml/XMLHttpRequest.cpp:
  23583. (WebCore::XMLHttpRequest::~XMLHttpRequest):
  23584. * xml/XMLHttpRequest.h:
  23585. * xml/XMLHttpRequestUpload.cpp:
  23586. (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
  23587. * xml/XMLHttpRequestUpload.h:
  23588. (WebCore::XMLHttpRequestUpload::create):
  23589. (WebCore::XMLHttpRequestUpload::ref):
  23590. (WebCore::XMLHttpRequestUpload::deref):
  23591. (WebCore::XMLHttpRequestUpload::xmlHttpRequest):
  23592. (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
  23593. * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and
  23594. its associated upload object to match the model for canvas. This makes
  23595. garbage collection a lot more straightforward, but it also makes the
  23596. behavior of these objects more reliable.
  23597. 2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
  23598. Unreviewed, rolling out r84759.
  23599. http://trac.webkit.org/changeset/84759
  23600. https://bugs.webkit.org/show_bug.cgi?id=59306
  23601. Caused gc-shadow.html to start crashing in V8. (Requested by
  23602. dglazkov|away on #webkit).
  23603. * dom/Node.cpp:
  23604. (WebCore::NodeRendererFactory::createRendererAndStyle):
  23605. (WebCore::Node::styleForRenderer):
  23606. 2011-04-24 Maciej Stachowiak <mjs@apple.com>
  23607. Reviewed by George Staikos.
  23608. Handling of URLs like http:/example.com/ is incorrect
  23609. https://bugs.webkit.org/show_bug.cgi?id=59300
  23610. <rdar://problem/9231956>
  23611. URLs like http:/example.com/ or http:example.com/ are now correctly
  23612. canonicalized as http://example.com/
  23613. The code still doesn't quite match other browsers - at least some
  23614. other browsers seem to base parsing behavior on whether they
  23615. recongize a scheme from a fixed list, and ignore whether // is
  23616. present in the URL or not.
  23617. * platform/KURL.cpp:
  23618. (WebCore::isNonFileHierarchicalScheme): New helper function.
  23619. (WebCore::KURL::parse): For a particular list of whitelisted schemes,
  23620. assume they are hierarchical and need an authority even if there is no //
  23621. after the :/
  23622. 2011-04-24 Dan Bernstein <mitz@apple.com>
  23623. LLVM Compiler build fix.
  23624. * page/ContentSecurityPolicy.cpp: Removed an unused function.
  23625. 2011-04-24 Dominic Cooney <dominicc@chromium.org>
  23626. Reviewed by Dimitri Glazkov.
  23627. Crash when adding a text node to a shadow root
  23628. https://bugs.webkit.org/show_bug.cgi?id=59304
  23629. Text nodes need to consult their host element for style.
  23630. Test: fast/dom/shadow/append-child-text.html
  23631. * dom/Node.cpp:
  23632. (WebCore::NodeRendererFactory::styleForRenderer):
  23633. (WebCore::NodeRendererFactory::createRendererAndStyle):
  23634. (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
  23635. 2011-04-24 Adam Barth <abarth@webkit.org>
  23636. Reviewed by Eric Seidel.
  23637. Update Content-Security-Policy syntax to match new version of spec
  23638. https://bugs.webkit.org/show_bug.cgi?id=59291
  23639. Brandon removed disable-xss-protection in favor of unsafe-inline and
  23640. allow-eval in favor of unsafe-eval. This change in syntax also means
  23641. the options directive no longer exists.
  23642. * page/ContentSecurityPolicy.cpp:
  23643. (WebCore::CSPSourceList::allowInline):
  23644. (WebCore::CSPSourceList::allowEval):
  23645. (WebCore::CSPSourceList::CSPSourceList):
  23646. (WebCore::CSPSourceList::parseSource):
  23647. (WebCore::CSPSourceList::addSourceUnsafeInline):
  23648. (WebCore::CSPSourceList::addSourceUnsafeEval):
  23649. (WebCore::CSPDirective::allowInline):
  23650. (WebCore::CSPDirective::allowEval):
  23651. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  23652. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  23653. (WebCore::ContentSecurityPolicy::allowInlineScript):
  23654. (WebCore::ContentSecurityPolicy::allowEval):
  23655. (WebCore::ContentSecurityPolicy::addDirective):
  23656. * page/ContentSecurityPolicy.h:
  23657. 2011-04-24 Dan Bernstein <mitz@apple.com>
  23658. Reviewed by Maciej Stachowiak.
  23659. Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
  23660. https://bugs.webkit.org/show_bug.cgi?id=59299
  23661. * manual-tests/back-from-document-with-scrollbar.html: Added.
  23662. 2011-04-24 Rik Cabanier <cabanier@adobe.com>
  23663. Reviewed by Simon Fraser.
  23664. Tables are not rendered correctly
  23665. https://bugs.webkit.org/show_bug.cgi?id=59138
  23666. Test: fast/table/auto-100-percent-width.html
  23667. * rendering/AutoTableLayout.cpp:
  23668. (WebCore::AutoTableLayout::computePreferredLogicalWidths):
  23669. 2011-04-23 Simon Fraser <simon.fraser@apple.com>
  23670. Fix Windows build, which complains about unreachable code.
  23671. * platform/ScrollableArea.cpp:
  23672. (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
  23673. (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
  23674. (WebCore::ScrollableArea::hasLayerForScrollCorner):
  23675. 2011-04-23 Simon Fraser <simon.fraser@apple.com>
  23676. Reviewed by Dan Bernstein.
  23677. Area under composited scrollbars not repainted in WebKit2 on scrolling
  23678. https://bugs.webkit.org/show_bug.cgi?id=59294
  23679. <rdar://problem/9299062>
  23680. When computing the rect that can be copied on scrolling, we normally
  23681. exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
  23682. the assumption is that other code will repaint these areas. However, when
  23683. scrollbars are in their own compositing layers, we can, and should
  23684. copy the entire area.
  23685. Not testable in DRT because it does not allow tests to use overlay scrollbars.
  23686. * platform/ScrollView.h:
  23687. * platform/ScrollView.cpp:
  23688. (WebCore::ScrollView::rectToCopyOnScroll):
  23689. New method, with code moved from scrollContents and fixed to look
  23690. for scrollbars in layers.
  23691. (WebCore::ScrollView::scrollContents):
  23692. Call rectToCopyOnScroll().
  23693. * platform/ScrollableArea.h:
  23694. * platform/ScrollableArea.cpp:
  23695. (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
  23696. (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
  23697. (WebCore::ScrollableArea::hasLayerForScrollCorner):
  23698. Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
  23699. 2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
  23700. Unreviewed, rolling out r84740.
  23701. http://trac.webkit.org/changeset/84740
  23702. https://bugs.webkit.org/show_bug.cgi?id=59290
  23703. change breaks apple internal builds and is incorrect
  23704. (Requested by smfr on #webkit).
  23705. * WebCore.exp.in:
  23706. * page/FrameView.cpp:
  23707. * page/FrameView.h:
  23708. * platform/ScrollTypes.h:
  23709. * platform/ScrollableArea.h:
  23710. * platform/mac/ScrollbarThemeMac.mm:
  23711. (WebCore::ScrollbarThemeMac::paint):
  23712. * platform/mac/WebCoreSystemInterface.h:
  23713. * platform/mac/WebCoreSystemInterface.mm:
  23714. 2011-04-23 Dan Bernstein <mitz@apple.com>
  23715. Reviewed by Simon Fraser.
  23716. <rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
  23717. https://bugs.webkit.org/show_bug.cgi?id=59288
  23718. * platform/text/mac/TextBoundaries.mm:
  23719. (WebCore::wordStringTokenizer): Added this helper function.
  23720. (WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
  23721. whose behavior is not locale-dependent.
  23722. 2011-04-23 Dominic Cooney <dominicc@chromium.org>
  23723. Reviewed by Dimitri Glazkov.
  23724. [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
  23725. https://bugs.webkit.org/show_bug.cgi?id=59284
  23726. Test: fast/dom/shadow/gc-shadow.html
  23727. * bindings/v8/V8GCController.cpp:
  23728. (WebCore::calculateGroupId): group shadow nodes with their hosts
  23729. 2011-04-23 MORITA Hajime <morrita@google.com>
  23730. Reviewed by Dimitri Glazkov.
  23731. [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
  23732. https://bugs.webkit.org/show_bug.cgi?id=59280
  23733. - Rename NodeRenderParentDetector to NodeRendererFactory
  23734. - move createRendererAndStyle() and createRendererIfNeeded to
  23735. NodeRendererFactory
  23736. No new test, no behavioral change.
  23737. * dom/Node.cpp:
  23738. (WebCore::NodeRendererFactory::NodeRendererFactory):
  23739. (WebCore::NodeRendererFactory::document):
  23740. (WebCore::NodeRendererFactory::nextRenderer):
  23741. (WebCore::NodeRendererFactory::findVisualParent):
  23742. (WebCore::NodeRendererFactory::shouldCreateRenderer):
  23743. (WebCore::NodeRendererFactory::createRendererAndStyle):
  23744. (WebCore::NodeRendererFactory::createRendererIfNeeded):
  23745. (WebCore::Node::parentNodeForRenderingAndStyle):
  23746. (WebCore::Node::createRendererIfNeeded):
  23747. * dom/Node.h:
  23748. * html/HTMLDetailsElement.cpp:
  23749. (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()
  23750. 2011-04-23 MORITA Hajime <morrita@google.com>
  23751. Reviewed by Kent Tamura.
  23752. REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
  23753. https://bugs.webkit.org/show_bug.cgi?id=59281
  23754. Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
  23755. for vertical writing modes. This fix added a width property for each of them.
  23756. Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
  23757. fast/dom/HTMLProgressElement/progress-writing-mode.html
  23758. * css/html.css:
  23759. (meter::-webkit-meter-bar):
  23760. (progress::-webkit-progress-bar):
  23761. 2011-04-23 Kevin Ollivier <kevino@theolliviers.com>
  23762. [wx] Unreviewed build fix. Added missing header.
  23763. * platform/graphics/filters/FEDropShadow.h:
  23764. 2011-04-23 Alexey Proskuryakov <ap@apple.com>
  23765. Reviewed by Maciej Stachowiak.
  23766. REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
  23767. https://bugs.webkit.org/show_bug.cgi?id=59241
  23768. <rdar://problem/9150861>
  23769. Covered by manual-tests/print-after-window-close.html.
  23770. Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
  23771. regression.
  23772. * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be
  23773. doing complicated work while the loader is half-canceled.
  23774. * manual-tests/print-after-window-close.html: Extended to actually print a non-empty page,
  23775. thus being more practical.
  23776. * page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer.
  23777. It's too scary for me to try now.
  23778. * page/DOMWindow.cpp:
  23779. (WebCore::DOMWindow::DOMWindow):
  23780. (WebCore::DOMWindow::finishedLoading):
  23781. * page/DOMWindow.h:
  23782. Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.
  23783. 2011-04-19 Vitaly Repeshko <vitalyr@chromium.org>
  23784. Reviewed by Adam Barth.
  23785. [V8] Use implicit references for V8 listeners on DOM nodes.
  23786. https://bugs.webkit.org/show_bug.cgi?id=58953
  23787. Instead of allocating an auxiliary V8 array referencing V8
  23788. listener objects associated with a DOM node and using an extra
  23789. pointer in every DOM node wrapper, we can register implicit
  23790. references between nodes and their listeners during GC. This also
  23791. makes V8 bindings more aligned with JSC bindings.
  23792. No new tests because this is a refactoring.
  23793. * bindings/scripts/CodeGeneratorV8.pm: Stopped generating the
  23794. listener cache internal field for DOM nodes.
  23795. * bindings/v8/V8AbstractEventListener.h: Exposed the lister handle
  23796. to the GC.
  23797. (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
  23798. * bindings/v8/V8GCController.cpp: Started using implicit references.
  23799. (WebCore::GrouperVisitor::visitDOMWrapper):
  23800. * dom/EventTarget.h: Implemented an iterator over all listeners.
  23801. (WebCore::EventListenerIterator):
  23802. 2011-04-22 Jon Lee <jonlee@apple.com>
  23803. Reviewed by Beth Dakin.
  23804. Overlay scroller hard to see on pages with dark background (59183)
  23805. https://bugs.webkit.org/show_bug.cgi?id=59183
  23806. <rdar://problem/8975367>
  23807. * WebCore.exp.in: adding method to allow changing style
  23808. * page/FrameView.cpp:
  23809. (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
  23810. * page/FrameView.h:
  23811. * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
  23812. * platform/ScrollableArea.cpp:
  23813. (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
  23814. * platform/ScrollableArea.h:
  23815. * platform/mac/ScrollbarThemeMac.mm:
  23816. (WebCore::ScrollbarThemeMac::paint):
  23817. * platform/mac/WebCoreSystemInterface.h:
  23818. * platform/mac/WebCoreSystemInterface.mm:
  23819. 2011-04-22 Chris Evans <cevans@chromium.org>
  23820. Reviewed by Adam Barth.
  23821. Upgrade CSS loads from mixed content warning (displayed) to mixed
  23822. content error (ran)
  23823. https://bugs.webkit.org/show_bug.cgi?id=59056
  23824. Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
  23825. Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html
  23826. * loader/cache/CachedResourceLoader.cpp:
  23827. (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
  23828. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  23829. Fixed an upside-down conditional in my last check-in.
  23830. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  23831. (WebCore::isObservable):
  23832. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  23833. Rolled back in r84725 and r84728 with appcache crash fixed.
  23834. Reviewed by Oliver Hunt.
  23835. Removed a use of markDOMObjectWrapper: DOMWindow
  23836. https://bugs.webkit.org/show_bug.cgi?id=59260
  23837. * bindings/js/JSDOMWindowCustom.cpp:
  23838. (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
  23839. we use the opaque roots system now.
  23840. * bindings/js/JSNavigatorCustom.cpp: Ditto.
  23841. * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
  23842. whose opaque roots are frames.
  23843. * css/StyleMedia.h:
  23844. (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
  23845. * css/StyleMedia.idl:
  23846. * loader/appcache/DOMApplicationCache.idl:
  23847. * page/BarInfo.idl:
  23848. * page/Console.idl:
  23849. * page/DOMSelection.idl:
  23850. * page/Geolocation.idl:
  23851. * page/History.idl:
  23852. * page/Location.idl:
  23853. * page/Navigator.idl:
  23854. * page/Screen.idl:
  23855. * storage/Storage.idl: Updated to use the opaque roots system.
  23856. 2011-04-22 Nate Chapin <japhet@chromium.org>
  23857. Reviewed by Adam Barth.
  23858. Don't use XMLTreeViewer when script is disabled (it uses Javascript
  23859. to build a prettified version of the xml document).
  23860. https://bugs.webkit.org/show_bug.cgi?id=59113
  23861. * xml/XMLTreeViewer.cpp:
  23862. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  23863. 2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
  23864. Unreviewed, rolling out r84725 and r84728.
  23865. http://trac.webkit.org/changeset/84725
  23866. http://trac.webkit.org/changeset/84728
  23867. https://bugs.webkit.org/show_bug.cgi?id=59270
  23868. It broke http/tests/appcache tests (Requested by Ossy on
  23869. #webkit).
  23870. * bindings/js/JSDOMWindowCustom.cpp:
  23871. (WebCore::JSDOMWindow::visitChildren):
  23872. * bindings/js/JSNavigatorCustom.cpp:
  23873. (WebCore::JSNavigator::visitChildren):
  23874. * bindings/scripts/CodeGeneratorJS.pm:
  23875. * css/StyleMedia.h:
  23876. * css/StyleMedia.idl:
  23877. * loader/appcache/DOMApplicationCache.idl:
  23878. * page/BarInfo.idl:
  23879. * page/Console.idl:
  23880. * page/DOMSelection.idl:
  23881. * page/DOMWindow.h:
  23882. (WebCore::DOMWindow::optionalScreen):
  23883. (WebCore::DOMWindow::optionalSelection):
  23884. (WebCore::DOMWindow::optionalHistory):
  23885. (WebCore::DOMWindow::optionalCrypto):
  23886. (WebCore::DOMWindow::optionalLocationbar):
  23887. (WebCore::DOMWindow::optionalMenubar):
  23888. (WebCore::DOMWindow::optionalPersonalbar):
  23889. (WebCore::DOMWindow::optionalScrollbars):
  23890. (WebCore::DOMWindow::optionalStatusbar):
  23891. (WebCore::DOMWindow::optionalToolbar):
  23892. (WebCore::DOMWindow::optionalConsole):
  23893. (WebCore::DOMWindow::optionalNavigator):
  23894. (WebCore::DOMWindow::optionalLocation):
  23895. (WebCore::DOMWindow::optionalMedia):
  23896. (WebCore::DOMWindow::optionalSessionStorage):
  23897. (WebCore::DOMWindow::optionalLocalStorage):
  23898. (WebCore::DOMWindow::optionalPerformance):
  23899. * page/Geolocation.idl:
  23900. * page/History.idl:
  23901. * page/Location.idl:
  23902. * page/Navigator.h:
  23903. (WebCore::Navigator::optionalGeolocation):
  23904. * page/Navigator.idl:
  23905. * page/Screen.idl:
  23906. * storage/Storage.idl:
  23907. 2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
  23908. Reviewed by Kent Tamura.
  23909. Change SVG-related shadow root checks to use isSVGShadowRoot.
  23910. https://bugs.webkit.org/show_bug.cgi?id=59237
  23911. Covered by existing tests, no behavior change.
  23912. * css/CSSStyleSelector.cpp:
  23913. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
  23914. * svg/SVGUseElement.cpp:
  23915. (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
  23916. * svg/animation/SVGSMILElement.cpp:
  23917. (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
  23918. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  23919. Mac build fix.
  23920. * page/DOMWindow.h:
  23921. (WebCore::DOMWindow::optionalApplicationCache): Restored this function,
  23922. which is used after all.
  23923. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  23924. Mac build fix.
  23925. * page/DOMWindow.h:
  23926. (WebCore::DOMWindow::optionalApplicationCache): Restored this function,
  23927. which is used after all.
  23928. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  23929. Reviewed by Oliver Hunt.
  23930. Removed a use of markDOMObjectWrapper: DOMWindow
  23931. https://bugs.webkit.org/show_bug.cgi?id=59260
  23932. * bindings/js/JSDOMWindowCustom.cpp:
  23933. (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
  23934. we use the opaque roots system now.
  23935. * bindings/js/JSNavigatorCustom.cpp: Ditto.
  23936. * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
  23937. whose opaque roots are frames.
  23938. * css/StyleMedia.h:
  23939. (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
  23940. * css/StyleMedia.idl:
  23941. * loader/appcache/DOMApplicationCache.idl:
  23942. * page/BarInfo.idl:
  23943. * page/Console.idl:
  23944. * page/DOMSelection.idl:
  23945. * page/Geolocation.idl:
  23946. * page/History.idl:
  23947. * page/Location.idl:
  23948. * page/Navigator.idl:
  23949. * page/Screen.idl:
  23950. * storage/Storage.idl: Updated to use the opaque roots system.
  23951. 2011-04-22 Xiaomei Ji <xji@chromium.org>
  23952. Reviewed by Ryosuke Niwa.
  23953. move caret by word in visual order returns wrong result when caret itself is at word boundary.
  23954. https://bugs.webkit.org/show_bug.cgi?id=58504.
  23955. positionBeforeNextWord should take care that the current position is after current word.
  23956. positionAfterPreviousWord should take care that the current positin is before current word.
  23957. * editing/visible_units.cpp:
  23958. (WebCore::positionBeforeNextWord):
  23959. (WebCore::positionAfterPreviousWord):
  23960. 2011-04-19 Jer Noble <jer.noble@apple.com>
  23961. Reviewed by Daniel Bates.
  23962. Full Screen from within an <iframe> does not cause <iframe> to resize.
  23963. https://bugs.webkit.org/show_bug.cgi?id=58638
  23964. Tests: fullscreen/full-screen-frameset.html
  23965. * css/CSSStyleSelector.cpp:
  23966. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
  23967. -webkit-full-screen pseudo class to frame elements which contain
  23968. full screen elements.
  23969. * css/fullscreen.css:
  23970. (iframe:-webkit-full-screen): Add iframe-specific styling rules.
  23971. * dom/Document.cpp:
  23972. (WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each
  23973. successive document owner element, calling setContainsFullScreenElement() if
  23974. owner is a frame element.
  23975. (WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
  23976. call instead of checking the element's tag name.
  23977. (WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
  23978. iframes as containing a full screen element.
  23979. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
  23980. * dom/Element.h:
  23981. (WebCore::Element::isFrameElementBase): Added.
  23982. * html/HTMLFrameElement.h:
  23983. (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
  23984. HTMLFrameElements.
  23985. * html/HTMLFrameElementBase.cpp:
  23986. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
  23987. * html/HTMLFrameElementBase.h:
  23988. (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added.
  23989. (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
  23990. 2011-04-22 Michael Saboff <msaboff@apple.com>
  23991. Reviewed by Maciej Stachowiak.
  23992. Creating copy of ContainerNode's when inserting or removing is inefficient
  23993. https://bugs.webkit.org/show_bug.cgi?id=58695
  23994. Eliminated node copying in willRemove() and insertedIntoDocument().
  23995. No new tests as this is a more efficient implementation of
  23996. existing code that is covered by existing tests.
  23997. * dom/ContainerNode.cpp:
  23998. (WebCore::ContainerNode::willRemove): Changed method to use
  23999. RefPtr<> to protect against modification during removal.
  24000. (WebCore::ContainerNode::insertedIntoDocument): Changed method to use
  24001. RefPtr<> and two other deletion checks to protect against
  24002. modification during insertion.
  24003. 2011-04-22 Geoffrey Garen <ggaren@apple.com>
  24004. Reviewed by Sam Weinig.
  24005. We have an autogenerator, so use it
  24006. https://bugs.webkit.org/show_bug.cgi?id=59247
  24007. * bindings/js/JSCSSRuleCustom.cpp:
  24008. * bindings/js/JSCSSRuleListCustom.cpp:
  24009. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  24010. * bindings/js/JSCSSValueCustom.cpp:
  24011. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  24012. * bindings/js/JSDOMImplementationCustom.cpp:
  24013. * bindings/js/JSDOMStringMapCustom.cpp:
  24014. * bindings/js/JSHTMLCollectionCustom.cpp:
  24015. * bindings/js/JSNamedNodeMapCustom.cpp:
  24016. * bindings/js/JSNodeCustom.h:
  24017. * bindings/js/JSNodeListCustom.cpp:
  24018. * bindings/js/JSStyleSheetCustom.cpp:
  24019. * bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
  24020. * bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
  24021. * css/CSSRule.idl:
  24022. * css/CSSRuleList.idl:
  24023. * css/CSSStyleDeclaration.idl:
  24024. * css/CSSValue.idl:
  24025. * css/MediaList.idl:
  24026. * css/StyleSheet.idl:
  24027. * css/StyleSheetList.idl:
  24028. * dom/DOMImplementation.idl:
  24029. * dom/DOMStringMap.idl:
  24030. * dom/NamedNodeMap.idl:
  24031. * dom/Node.idl:
  24032. * dom/NodeList.idl:
  24033. * html/DOMTokenList.idl:
  24034. * html/HTMLCollection.idl:
  24035. * html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into
  24036. the autogenerator.
  24037. 2011-04-22 Beth Dakin <bdakin@apple.com>
  24038. Reviewed by Maciej Stachowiak.
  24039. https://bugs.webkit.org/show_bug.cgi?id=59223
  24040. REGRESSION (r82185): iframe not displayed after navigation back to cached page
  24041. Manual test added.
  24042. * manual-tests/frame-layout-on-back.html: Added.
  24043. * manual-tests/resources/empty-document-goes-back.html: Added.
  24044. * manual-tests/resources/simple-iframe.html: Added.
  24045. 2011-04-22 Yael Aharon <yael.aharon@nokia.com>
  24046. Reviewed by Sam Weinig.
  24047. HTMLFormControlElement::labels should allow custom attributes.
  24048. https://bugs.webkit.org/show_bug.cgi?id=59128
  24049. Cache the labels list when it is created and keep using it for future
  24050. labels calls.
  24051. Test: fast/forms/labels-custom-property.html
  24052. * html/HTMLFormControlElement.cpp:
  24053. (WebCore::HTMLFormControlElement::labels):
  24054. 2011-04-22 Adrienne Walker <enne@google.com>
  24055. Reviewed by James Robinson.
  24056. [chromium] Remove minimum texture size for compositor tiling
  24057. https://bugs.webkit.org/show_bug.cgi?id=59236
  24058. This was mistakenly committed in r83915 and causes bad filtering
  24059. on very small textures.
  24060. Tests: compositing/images/content-image-change.html
  24061. * platform/graphics/chromium/LayerTilerChromium.cpp:
  24062. (WebCore::LayerTilerChromium::setTileSize):
  24063. 2011-04-22 Beth Dakin <bdakin@apple.com>
  24064. Reviewed by Maciej Stachowiak.
  24065. https://bugs.webkit.org/show_bug.cgi?id=59223
  24066. REGRESSION (r82185): iframe not displayed after navigation back to cached page
  24067. -and corresponding-
  24068. <rdar://problem/9323763>
  24069. Cache the scroll position in Document::setInPageCache() instead of
  24070. FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
  24071. for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
  24072. r82185 code.
  24073. * dom/Document.cpp:
  24074. (WebCore::Document::setInPageCache):
  24075. * page/FrameView.cpp:
  24076. (WebCore::FrameView::resetScrollbarsAndClearContentsSize):
  24077. 2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
  24078. Reviewed by Kent Tamura.
  24079. Let the RenderTheme decide if an input type should have a spinner
  24080. https://bugs.webkit.org/show_bug.cgi?id=59246
  24081. Whether an input should have a spinner or not should
  24082. be a UI decision made by the RenderTheme. Remove
  24083. WebCore's default hasSpinButton values and defer
  24084. to the RenderTheme.
  24085. No change in functionality, covered by existing tests.
  24086. * html/HTMLInputElement.cpp:
  24087. (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl
  24088. for possible RenderTheme queries.
  24089. * html/HTMLInputElement.h:
  24090. * rendering/RenderTextControlSingleLine.cpp:
  24091. (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
  24092. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  24093. For both of these ask the render theme if the input should
  24094. have a spinner.
  24095. * rendering/RenderTheme.cpp:
  24096. (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement):
  24097. Steppable inputs (number, date, and range) but not range
  24098. should have spinners. This does not change existing behavior.
  24099. * rendering/RenderTheme.h:
  24100. * dom/InputElement.h:
  24101. * html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
  24102. * html/BaseDateAndTimeInputType.h: remove hasSpinButton.
  24103. * html/InputType.cpp: remove hasSpinButton.
  24104. * html/InputType.h: remove hasSpinButton.
  24105. * html/NumberInputType.cpp: remove hasSpinButton.
  24106. * html/NumberInputType.h: remove hasSpinButton.
  24107. 2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
  24108. Reviewed by Kent Tamura.
  24109. Don't rely on hasSpinButton to check if an input type can be stepped
  24110. https://bugs.webkit.org/show_bug.cgi?id=59224
  24111. Add isSteppable to know for certain if an input type can
  24112. be stepped or not. Previously we were checking if the input
  24113. has a spin control or is the range input type. These are UI
  24114. details, but the step functionality does not require there
  24115. to be a UI.
  24116. No change in behavior, covered by existing tests.
  24117. * html/BaseDateAndTimeInputType.cpp:
  24118. (WebCore::BaseDateAndTimeInputType::isSteppable):
  24119. * html/BaseDateAndTimeInputType.h:
  24120. * html/HTMLInputElement.cpp:
  24121. (WebCore::HTMLInputElement::isSteppable):
  24122. (WebCore::HTMLInputElement::stepUpFromRenderer): remove the
  24123. check for a spinner and range control and instead ASSERT
  24124. that the type is steppable.
  24125. * html/HTMLInputElement.h:
  24126. * html/InputType.cpp:
  24127. (WebCore::InputType::isSteppable):
  24128. * html/InputType.h:
  24129. * html/NumberInputType.cpp:
  24130. (WebCore::NumberInputType::isSteppable):
  24131. * html/NumberInputType.h:
  24132. * html/RangeInputType.cpp:
  24133. (WebCore::RangeInputType::isSteppable):
  24134. * html/RangeInputType.h:
  24135. 2011-04-22 Adam Barth <abarth@webkit.org>
  24136. Reviewed by Eric Seidel.
  24137. CSP frame-src is missing
  24138. https://bugs.webkit.org/show_bug.cgi?id=58643
  24139. In this patch, I've audited all the callers to
  24140. SecurityOrigin::canDisplay to make sure they all the appropriate
  24141. Content-Security-Policy method as well. I'm not sure how to test all
  24142. these cases, but making this changes fixed the frame-src test.
  24143. * loader/SubframeLoader.cpp:
  24144. (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
  24145. (WebCore::SubframeLoader::createJavaAppletWidget):
  24146. (WebCore::SubframeLoader::loadSubframe):
  24147. (WebCore::SubframeLoader::loadPlugin):
  24148. * loader/SubresourceLoader.cpp:
  24149. (WebCore::SubresourceLoader::create):
  24150. * loader/cache/CachedResourceLoader.cpp:
  24151. (WebCore::CachedResourceLoader::canRequest):
  24152. (WebCore::CachedResourceLoader::requestResource):
  24153. - While I was understanding this code, I fixed the FIXME here.
  24154. * loader/cache/CachedResourceLoader.h:
  24155. 2011-04-22 Adrienne Walker <enne@google.com>
  24156. Reviewed by Simon Fraser.
  24157. Clear shared graphics context when destroying CanvasRenderingContext2D.
  24158. https://bugs.webkit.org/show_bug.cgi?id=59212
  24159. * html/canvas/CanvasRenderingContext2D.cpp:
  24160. (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
  24161. 2011-04-22 Levi Weintraub <leviw@chromium.org>
  24162. Reviewed by Ryosuke Niwa.
  24163. End/Home keys do not work in a contentEditable element
  24164. https://bugs.webkit.org/show_bug.cgi?id=50564
  24165. Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
  24166. inline and share a line with non-editable content.
  24167. Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html
  24168. * editing/visible_units.cpp:
  24169. (WebCore::logicalStartOfLine):
  24170. (WebCore::logicalEndOfLine):
  24171. 2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
  24172. Reviewed by Kent Tamura.
  24173. Make showTree/showTreeForThis aware of the shadow DOM
  24174. https://bugs.webkit.org/show_bug.cgi?id=52965
  24175. No new tests, because this code is only compiled in DEBUG.
  24176. * dom/Node.cpp:
  24177. (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
  24178. recursive sub-traversal of the shadow tree.
  24179. (WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.
  24180. 2011-04-22 Sam Weinig <sam@webkit.org>
  24181. Reviewed by Gavin Barraclough and Oliver Hunt.
  24182. Arrays should participate in global object forwarding fun
  24183. https://bugs.webkit.org/show_bug.cgi?id=59215
  24184. Change callers of constructArray to use the new variant that takes
  24185. a global object.
  24186. * bindings/js/JSClipboardCustom.cpp:
  24187. (WebCore::JSClipboard::types):
  24188. * bindings/js/JSConsoleCustom.cpp:
  24189. (WebCore::JSConsole::profiles):
  24190. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  24191. (WebCore::JSJavaScriptCallFrame::scopeChain):
  24192. * bindings/js/JSMessageEventCustom.cpp:
  24193. (WebCore::JSMessageEvent::ports):
  24194. * bindings/js/JSScriptProfileNodeCustom.cpp:
  24195. (WebCore::JSScriptProfileNode::children):
  24196. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  24197. (WebCore::toJS):
  24198. (WebCore::JSWebGLRenderingContext::getAttachedShaders):
  24199. (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
  24200. 2011-04-22 Csaba Osztrogonác <ossy@webkit.org>
  24201. [Qt] Unreviewed typo fix after r84522.
  24202. * WebCore.pro:
  24203. 2011-04-22 Daniel Bates <dbates@rim.com>
  24204. Fix misspelled word in comment; tagets => targets.
  24205. * page/EventHandler.cpp:
  24206. (WebCore::EventHandler::handleTouchEvent):
  24207. 2011-04-21 Geoffrey Garen <ggaren@apple.com>
  24208. Reviewed by Oliver Hunt.
  24209. Removed a use of markDOMObjectWrapper: Element and Document
  24210. https://bugs.webkit.org/show_bug.cgi?id=59178
  24211. * GNUmakefile.list.am:
  24212. * UseJSC.cmake:
  24213. * WebCore.gypi:
  24214. * WebCore.pro:
  24215. * WebCore.vcproj/WebCore.vcproj:
  24216. * WebCore.xcodeproj/project.pbxproj:
  24217. * bindings/js/JSBindingsAllInOne.cpp: Build!
  24218. * bindings/js/JSDOMImplementationCustom.cpp:
  24219. (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots):
  24220. (WebCore::JSDOMImplementationOwner::finalize):
  24221. (WebCore::wrapperOwner):
  24222. (WebCore::wrapperContext):
  24223. (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also,
  24224. DOMImplementation does not need to keep its document wrapper alive, since
  24225. there's no DOM API for getting a DOMImplementation's document.
  24226. * bindings/js/JSDOMStringMapCustom.cpp:
  24227. (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots):
  24228. (WebCore::JSDOMStringMapOwner::finalize):
  24229. (WebCore::wrapperOwner):
  24230. (WebCore::wrapperContext):
  24231. (WebCore::toJS): Use the opaque roots system for DOMStringMap.
  24232. * bindings/js/JSDOMTokenListCustom.cpp: Added.
  24233. (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots):
  24234. (WebCore::JSDOMTokenListOwner::finalize):
  24235. (WebCore::wrapperOwner):
  24236. (WebCore::wrapperContext):
  24237. (WebCore::toJS): Use the opaque roots system for DOMTokenList.
  24238. * bindings/js/JSDocumentCustom.cpp:
  24239. (WebCore::JSDocument::visitChildren):
  24240. * bindings/js/JSElementCustom.cpp: No more need for explicit marking.
  24241. * bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.
  24242. * dom/DOMImplementation.cpp:
  24243. (WebCore::DOMImplementation::DOMImplementation):
  24244. (WebCore::DOMImplementation::createDocument):
  24245. (WebCore::DOMImplementation::createHTMLDocument):
  24246. * dom/DOMImplementation.h:
  24247. (WebCore::DOMImplementation::create):
  24248. (WebCore::DOMImplementation::ref):
  24249. (WebCore::DOMImplementation::deref):
  24250. (WebCore::DOMImplementation::document): Fixed the DOMImplementation
  24251. ownership model to match other satellite objects in the DOM. This was
  24252. necessary to fix some crashes due to incorrect reference counting.
  24253. * dom/DOMImplementation.idl:
  24254. * dom/DOMStringMap.idl:
  24255. * dom/Document.cpp:
  24256. (WebCore::Document::~Document):
  24257. * dom/Document.h:
  24258. * dom/Element.cpp:
  24259. * dom/Element.h:
  24260. * dom/Element.idl:
  24261. * html/DOMTokenList.idl: Updated to match changes above.
  24262. 2011-04-22 Simon Fraser <simon.fraser@apple.com>
  24263. Reviewed by Dan Bernstein.
  24264. Rounded corners don't looks smooth when background-image is a gradient
  24265. https://bugs.webkit.org/show_bug.cgi?id=59213
  24266. Add the "shrink background" behavior to the slow background
  24267. drawing code path.
  24268. Test: fast/backgrounds/gradient-background-leakage.html
  24269. * rendering/RenderBoxModelObject.cpp:
  24270. (WebCore::backgroundRectAdjustedForBleedAvoidance):
  24271. Utility function that returns a shrunk border rect based
  24272. on the context scale.
  24273. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  24274. Use backgroundRectAdjustedForBleedAvoidance() in both the fast
  24275. and slow paths.
  24276. 2011-04-22 Xiaomei Ji <xji@chromium.org>
  24277. Reviewed by David Hyatt.
  24278. Local caret rectangle calculation should be relative to its containing block.
  24279. https://bugs.webkit.org/show_bug.cgi?id=49508.
  24280. InlineBox and caret rectangle are positioned relative to its containing block.
  24281. So its left and right edge value should be relative to its containing block as well.
  24282. Test: fast/forms/cursor-at-editable-content-boundary.html
  24283. * rendering/RenderText.cpp:
  24284. (WebCore::RenderText::localCaretRect):
  24285. 2011-04-22 Levi Weintraub <leviw@chromium.org>
  24286. Reviewed by Darin Fisher.
  24287. REGRESSION: left property broken with position:fixed elements in RTL documents
  24288. https://bugs.webkit.org/show_bug.cgi?id=59204
  24289. http://code.google.com/p/chromium/issues/detail?id=80216
  24290. Test: fast/block/positioning/rtl-fixed-positioning.html
  24291. fast/block/positioning/vertical-rl/fixed-positioning.html
  24292. Returning the proper scroll offsets for fixed position content in RTL documents.
  24293. We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
  24294. but RTL documents scroll in negative space.
  24295. * page/FrameView.cpp:
  24296. (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where
  24297. the scroll origin and offsets are negative.
  24298. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing-
  24299. mode RTL documents, like above.
  24300. * platform/ScrollView.h:
  24301. (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
  24302. 2011-04-22 Justin Schuh <jschuh@chromium.org>
  24303. Reviewed by Eric Seidel.
  24304. Should assert on invalid type in FEComponentTransfer::apply
  24305. https://bugs.webkit.org/show_bug.cgi?id=57959
  24306. No functional change. No new tests needed.
  24307. * platform/graphics/filters/FEComponentTransfer.cpp:
  24308. (WebCore::FEComponentTransfer::apply):
  24309. 2011-04-22 MORITA Hajime <morrita@google.com>
  24310. Unreviewed crash fix.
  24311. * html/HTMLDetailsElement.cpp:
  24312. (WebCore::DetailsSummaryElement::shouldInclude):
  24313. 2011-04-22 Dan Bernstein <mitz@apple.com>
  24314. Reviewed by Sam Weinig.
  24315. Exclude scrollbars from the dirty rect passed to the document
  24316. https://bugs.webkit.org/show_bug.cgi?id=59206
  24317. No test added because functionality is unchanged.
  24318. * platform/ScrollView.cpp:
  24319. (WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
  24320. in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
  24321. with it. If the result is empty, avoid calling paintContents().
  24322. 2011-04-22 Jer Noble <jer.noble@apple.com>
  24323. Reviewed by Maciej Stachowiak.
  24324. Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
  24325. https://bugs.webkit.org/show_bug.cgi?id=59147
  24326. Add a new isAVFoundationEnabled setting and check it before adding
  24327. MediaPlayerPrivateAVFoundationObjC to the media engine registry.
  24328. * WebCore.exp.in:
  24329. * page/Settings.cpp:
  24330. * page/Settings.h:
  24331. (WebCore::Settings::setAVFoundationEnabled): Added.
  24332. (WebCore::Settings::isAVFoundationEnabled): Added.
  24333. * platform/graphics/MediaPlayer.cpp:
  24334. (WebCore::installedMediaEngines): Check the settings added above.
  24335. 2011-04-22 Sam Weinig <sam@webkit.org>
  24336. Reviewed by Gavin Barraclough.
  24337. Remove remaining uses of deprecated version of toJS
  24338. https://bugs.webkit.org/show_bug.cgi?id=59170
  24339. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  24340. (WebCore::toJS):
  24341. (WebCore::JSCanvasRenderingContext2D::strokeStyle):
  24342. (WebCore::JSCanvasRenderingContext2D::fillStyle):
  24343. (WebCore::JSCanvasRenderingContext2D::createPattern):
  24344. * bindings/js/JSConsoleCustom.cpp:
  24345. (WebCore::JSConsole::profiles):
  24346. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  24347. (WebCore::JSSQLStatementErrorCallback::handleEvent):
  24348. * bindings/js/JSDOMBinding.h:
  24349. * bindings/js/JSDOMMimeTypeArrayCustom.cpp:
  24350. (WebCore::JSDOMMimeTypeArray::nameGetter):
  24351. * bindings/js/JSDOMPluginArrayCustom.cpp:
  24352. (WebCore::JSDOMPluginArray::nameGetter):
  24353. * bindings/js/JSDOMPluginCustom.cpp:
  24354. (WebCore::JSDOMPlugin::nameGetter):
  24355. * bindings/js/JSDOMWindowCustom.cpp:
  24356. (WebCore::namedItemGetter):
  24357. (WebCore::JSDOMWindow::event):
  24358. * bindings/js/JSEventTarget.cpp:
  24359. (WebCore::toJS):
  24360. * bindings/js/JSInjectedScriptHostCustom.cpp:
  24361. Propagate stored global object down access chain.
  24362. (WebCore::InjectedScriptHost::nodeAsScriptValue):
  24363. Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
  24364. (WebCore::JSInjectedScriptHost::currentCallFrame):
  24365. (WebCore::JSInjectedScriptHost::inspectedNode):
  24366. * bindings/js/JSNamedNodeMapCustom.cpp:
  24367. (WebCore::JSNamedNodeMap::nameGetter):
  24368. * bindings/js/JSNodeListCustom.cpp:
  24369. (WebCore::callNodeList):
  24370. (WebCore::JSNodeList::nameGetter):
  24371. * bindings/js/JSScriptProfileNodeCustom.cpp:
  24372. (WebCore::JSScriptProfileNode::children):
  24373. * bindings/js/JSStyleSheetListCustom.cpp:
  24374. (WebCore::JSStyleSheetList::nameGetter):
  24375. * bindings/js/JSXSLTProcessorCustom.cpp:
  24376. (WebCore::JSXSLTProcessor::transformToFragment):
  24377. (WebCore::JSXSLTProcessor::transformToDocument):
  24378. * bindings/scripts/CodeGeneratorJS.pm:
  24379. Propagate stored global object down access chain.
  24380. * css/MediaQueryListListener.cpp:
  24381. (WebCore::MediaQueryListListener::queryChanged):
  24382. Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype,
  24383. we will want refactor this to match other callbacks so we can remove this.
  24384. 2011-04-22 Naoki Takano <takano.naoki@gmail.com>
  24385. Reviewed by Eric Seidel.
  24386. [Chromium]Mac UI polish to add left/right padding space for autofill popup window.
  24387. https://bugs.webkit.org/show_bug.cgi?id=58960
  24388. http://code.google.com/p/chromium/issues/detail?id=51077
  24389. No new test because Chromium Autofill popup window doesn't have any test framework.
  24390. This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
  24391. Only if Autofill popup window has right/left padding.
  24392. The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
  24393. * rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
  24394. * rendering/RenderThemeChromiumMac.mm:
  24395. (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified.
  24396. (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
  24397. 2011-04-21 Adam Roben <aroben@apple.com>
  24398. Add code to enumerate all the functions imported by a particular Windows binary
  24399. PEImage is where all the logic starts. It represents a single Portable Executable (PE)
  24400. binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
  24401. modules and functions imported by that image.
  24402. I couldn't figure out how to write a test for this. :-(
  24403. Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
  24404. context menu appears when right-clicking on windowless Flash plugin
  24405. Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.
  24406. * WebCore.vcproj/WebCore.vcproj: Added the new files.
  24407. * platform/win/PEImage.cpp: Added.
  24408. (WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
  24409. then initializes m_ntHeaders using the module.
  24410. (WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
  24411. non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
  24412. places.)
  24413. (WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
  24414. with the given entry in the image's DataDirectory.
  24415. * platform/win/PEImage.h: Added.
  24416. (WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
  24417. succeeded, in which case m_ntHeaders will be set.
  24418. * platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
  24419. functions imported by the image from a single module by walking the Import Name Table (INT)
  24420. and Import Address Table (IAT).
  24421. (WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
  24422. (WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
  24423. arrays.
  24424. (WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
  24425. (WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
  24426. function's name, if possible, using the INT.
  24427. (WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
  24428. of the function pointer for the current function. This function pointer is used whenever
  24429. code in m_image calls the current function. (A future patch will take advantage of this by
  24430. overwriting this function pointer with another, thereby redirecting calls to that function.)
  24431. * platform/win/ImportedFunctionsEnumerator.h: Added.
  24432. * platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
  24433. ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
  24434. that works with either one.
  24435. * platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
  24436. non-delay-loaded modules imported by the image by walking the image's import array.
  24437. (WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
  24438. is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
  24439. (WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
  24440. (WebCore::ImportedModulesEnumerator::next): Steps along the import array.
  24441. (WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
  24442. name.
  24443. (WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
  24444. and IAT for this module and wraps them in an ImportedFunctionsEnumerator.
  24445. * platform/win/ImportedModulesEnumerator.h: Added.
  24446. * platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
  24447. delay-loaded modules that are imported by the given PEImage by walking the image's
  24448. ImageDelayDescr array.
  24449. (WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
  24450. information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
  24451. DataDirectory.
  24452. (WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
  24453. 0-terminated.
  24454. (WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
  24455. (WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
  24456. name out of the descriptor.
  24457. (WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
  24458. current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
  24459. (WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
  24460. stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
  24461. images store RVAs. This function abstracts away the difference.
  24462. * platform/win/DelayLoadedModulesEnumerator.h: Added.
  24463. 2011-04-21 Adam Roben <aroben@apple.com>
  24464. Add a shared do-nothing window class that anyone can use
  24465. Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes
  24466. Reviewed by Anders Carlsson.
  24467. * WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
  24468. platform/win and into platform. Let VS reorder other files.
  24469. * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  24470. (WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
  24471. dummy window class instead of creating our own.
  24472. * platform/win/DefWndProcWindowClass.cpp: Added.
  24473. (WebCore::registerClass): Register it!
  24474. (WebCore::defWndProcWindowClassName): Register it and return it!
  24475. * platform/win/DefWndProcWindowClass.h: Added.
  24476. 2011-04-21 MORITA Hajime <morrita@google.com>
  24477. Reviewed by Dimitri Glazkov.
  24478. Content of <details> should be forwarded through the shadow DOM
  24479. https://bugs.webkit.org/show_bug.cgi?id=59055
  24480. - Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
  24481. - Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as
  24482. subclasses of ShadowContentElement.
  24483. - Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that
  24484. handles non-summary contents of <details>. Another is SummaryContentElement, that
  24485. handles the main summary element.
  24486. - Removed most of RenderDetails custom layout mechanism, which is replaced by
  24487. ShadowContentElement subclasses.
  24488. Tests: fast/html/details-add-child-1.html
  24489. fast/html/details-add-child-2.html
  24490. fast/html/details-remove-child-1.html
  24491. fast/html/details-remove-child-2.html
  24492. * dom/ShadowRoot.cpp:
  24493. (WebCore::ShadowRoot::contentContainerFor):
  24494. (WebCore::ShadowRoot::hostChildrenChanged):
  24495. (WebCore::ShadowRoot::hasContentElement):
  24496. * dom/ShadowRoot.h:
  24497. * html/HTMLDetailsElement.cpp:
  24498. (WebCore::DetailsContentElement::DetailsContentElement):
  24499. (WebCore::DetailsContentElement::create):
  24500. (WebCore::DetailsContentElement::shouldInclude):
  24501. (WebCore::DetailsSummaryElement::DetailsSummaryElement):
  24502. (WebCore::DetailsSummaryElement::create):
  24503. (WebCore::DetailsSummaryElement::shouldInclude):
  24504. (WebCore::HTMLDetailsElement::create):
  24505. (WebCore::HTMLDetailsElement::HTMLDetailsElement):
  24506. (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf):
  24507. (WebCore::findSummaryFor):
  24508. (WebCore::HTMLDetailsElement::ensureMainSummary):
  24509. (WebCore::HTMLDetailsElement::refreshMainSummary):
  24510. (WebCore::HTMLDetailsElement::createShadowSubtree):
  24511. * html/HTMLDetailsElement.h:
  24512. * html/HTMLSummaryElement.cpp:
  24513. (WebCore::SummaryContentElement::SummaryContentElement):
  24514. (WebCore::SummaryContentElement::shouldInclude):
  24515. (WebCore::SummaryContentElement::create):
  24516. (WebCore::HTMLSummaryElement::createShadowSubtree):
  24517. * html/shadow/ShadowContentElement.h:
  24518. * rendering/RenderDetails.cpp:
  24519. (WebCore::RenderDetails::RenderDetails):
  24520. (WebCore::RenderDetails::addChild):
  24521. * rendering/RenderDetails.h:
  24522. * rendering/RenderSummary.cpp:
  24523. * rendering/RenderSummary.h:
  24524. 2011-04-21 Simon Fraser <simon.fraser@apple.com>
  24525. Reviewed by Dan Bernstein.
  24526. Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
  24527. https://bugs.webkit.org/show_bug.cgi?id=59109
  24528. Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().
  24529. Add an assertion that fires when a GraphicsContext() is destroyed with a non-
  24530. empty state stack. Fix canvas to avoid this assertion, since bad content might
  24531. trigger it.
  24532. Also add an assertion that fires for mismatched begin/endTransparencyLayers.
  24533. Test: fast/text/multiple-text-shadow-alpha.html
  24534. * html/HTMLCanvasElement.cpp:
  24535. (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
  24536. Make sure that the CanvasRenderingContext goes away before the ImageBuffer,
  24537. so that CanvasRenderingContext2D has a chance to unwind the state stack in
  24538. the ImageBuffer's GraphicsContext.
  24539. * html/canvas/CanvasRenderingContext2D.cpp:
  24540. (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
  24541. Balance unmatched state saves in the canvas context.
  24542. * platform/graphics/GraphicsContext.cpp:
  24543. (WebCore::GraphicsContext::~GraphicsContext):
  24544. Assert that the stack is empty.
  24545. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  24546. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  24547. (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
  24548. (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
  24549. (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
  24550. Changes to allow for asserting for unmatched transparency layer begin/ends.
  24551. * rendering/InlineTextBox.cpp:
  24552. (WebCore::InlineTextBox::paintDecoration):
  24553. Remove an unbalanced save().
  24554. 2011-04-22 Pavel Feldman <pfeldman@google.com>
  24555. Reviewed by Yury Semikhatsky.
  24556. Web Inspector: add Save As context menu item to the TextViewer.
  24557. https://bugs.webkit.org/show_bug.cgi?id=59196
  24558. * inspector/front-end/ResourceView.js:
  24559. (WebInspector.ResourceSourceFrame.prototype.requestContent):
  24560. (WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
  24561. (WebInspector.RevisionSourceFrame.prototype.requestContent):
  24562. (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
  24563. * inspector/front-end/ScriptsPanel.js:
  24564. (WebInspector.ScriptsPanel.prototype._createSourceFrame):
  24565. (WebInspector.SourceFrameDelegateForScriptsPanel):
  24566. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
  24567. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
  24568. * inspector/front-end/SourceFrame.js:
  24569. (WebInspector.SourceFrame.prototype._initializeTextViewer):
  24570. (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
  24571. (WebInspector.SourceFrame.prototype.suggestedFileName):
  24572. (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
  24573. (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
  24574. * inspector/front-end/TextViewer.js:
  24575. (WebInspector.TextViewer.prototype._contextMenu):
  24576. (WebInspector.TextViewerDelegate.prototype.cancelEditing):
  24577. (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
  24578. (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
  24579. (WebInspector.TextViewerDelegate.prototype.suggestedFileName):
  24580. 2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
  24581. Reviewed by Pavel Feldman.
  24582. Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
  24583. https://bugs.webkit.org/show_bug.cgi?id=59094
  24584. * WebCore.gypi:
  24585. * WebCore.vcproj/WebCore.vcproj:
  24586. * gyp/streamline-inspector-source.sh:
  24587. * inspector/front-end/DetailedHeapshotGridNodes.js:
  24588. (WebInspector.HeapSnapshotGridNode.prototype.dispose):
  24589. (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
  24590. (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
  24591. (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  24592. (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
  24593. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
  24594. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  24595. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  24596. (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  24597. (MixInSnapshotNodeFunctions):
  24598. * inspector/front-end/DetailedHeapshotView.js:
  24599. (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
  24600. (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
  24601. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
  24602. (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose):
  24603. (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
  24604. (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
  24605. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
  24606. (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled):
  24607. (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
  24608. (WebInspector.DetailedHeapshotView.prototype.dispose):
  24609. (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
  24610. (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
  24611. * inspector/front-end/HeapSnapshot.js:
  24612. (WebInspector.HeapSnapshotLoader):
  24613. (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
  24614. (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
  24615. (WebInspector.HeapSnapshot.prototype.pushBaseIds):
  24616. (WebInspector.HeapSnapshot.prototype.createDiff):
  24617. (WebInspector.HeapSnapshot.prototype._parseFilter):
  24618. (WebInspector.HeapSnapshot.prototype.createEdgesProvider):
  24619. (WebInspector.HeapSnapshot.prototype.createNodesProvider):
  24620. (WebInspector.HeapSnapshot.prototype.createPathFinder):
  24621. (WebInspector.HeapSnapshot.prototype.updateStaticData):
  24622. (WebInspector.HeapSnapshotPathFinder):
  24623. (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
  24624. (WebInspector.HeapSnapshotPathFinder.prototype._reset):
  24625. * inspector/front-end/HeapSnapshotProxy.js:
  24626. (WebInspector.HeapSnapshotRealWorker):
  24627. (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):
  24628. (WebInspector.HeapSnapshotRealWorker.prototype.postMessage):
  24629. (WebInspector.HeapSnapshotRealWorker.prototype.terminate):
  24630. (WebInspector.HeapSnapshotFakeWorker):
  24631. (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
  24632. (WebInspector.HeapSnapshotFakeWorker.prototype.terminate):
  24633. (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
  24634. (WebInspector.HeapSnapshotWorker):
  24635. (WebInspector.HeapSnapshotWorker.prototype.createObject):
  24636. (WebInspector.HeapSnapshotWorker.prototype.dispose):
  24637. (WebInspector.HeapSnapshotWorker.prototype.disposeObject):
  24638. (WebInspector.HeapSnapshotWorker.prototype.callGetter):
  24639. (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback):
  24640. (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod):
  24641. (WebInspector.HeapSnapshotWorker.prototype.callMethod):
  24642. (WebInspector.HeapSnapshotWorker.prototype._findFunction):
  24643. (WebInspector.HeapSnapshotWorker.prototype._messageReceived):
  24644. (WebInspector.HeapSnapshotWorker.prototype._postMessage):
  24645. (WebInspector.HeapSnapshotProxyObject):
  24646. (WebInspector.HeapSnapshotProxyObject.prototype._callWorker):
  24647. (WebInspector.HeapSnapshotProxyObject.prototype.dispose):
  24648. (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker):
  24649. (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
  24650. (WebInspector.HeapSnapshotProxyObject.prototype.callGetter):
  24651. (WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
  24652. (WebInspector.HeapSnapshotLoaderProxy):
  24653. (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
  24654. (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
  24655. (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
  24656. (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
  24657. (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
  24658. (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
  24659. (WebInspector.HeapSnapshotProxy):
  24660. (WebInspector.HeapSnapshotProxy.prototype.aggregates):
  24661. (WebInspector.HeapSnapshotProxy.prototype.createDiff):
  24662. (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
  24663. (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
  24664. (WebInspector.HeapSnapshotProxy.prototype.createPathFinder):
  24665. (WebInspector.HeapSnapshotProxy.prototype.dispose):
  24666. (WebInspector.HeapSnapshotProxy.prototype.finishLoading):
  24667. (WebInspector.HeapSnapshotProxy.prototype.get loaded):
  24668. (WebInspector.HeapSnapshotProxy.prototype.get nodeCount):
  24669. (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
  24670. (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
  24671. (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex):
  24672. (WebInspector.HeapSnapshotProxy.prototype.updateStaticData):
  24673. (WebInspector.HeapSnapshotProxy.prototype.startLoading):
  24674. (WebInspector.HeapSnapshotProxy.prototype.get totalSize):
  24675. (WebInspector.HeapSnapshotProxy.prototype.get uid):
  24676. (WebInspector.HeapSnapshotProviderProxy):
  24677. (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):
  24678. (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
  24679. (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
  24680. (WebInspector.HeapSnapshotPathFinderProxy):
  24681. (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext):
  24682. (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots):
  24683. (WebInspector.HeapSnapshotsDiffProxy):
  24684. (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
  24685. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
  24686. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
  24687. * inspector/front-end/HeapSnapshotWorker.js: Added.
  24688. (WebInspector.UIString):
  24689. (postMessageWrapper):
  24690. * inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added.
  24691. (WebInspector.HeapSnapshotWorkerDispatcher):
  24692. (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction):
  24693. (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
  24694. * inspector/front-end/ProfilesPanel.js:
  24695. (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
  24696. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
  24697. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  24698. * inspector/front-end/WebKit.qrc:
  24699. * inspector/front-end/inspector.html:
  24700. 2011-04-22 Pavel Podivilov <podivilov@chromium.org>
  24701. Reviewed by Pavel Feldman.
  24702. Web Inspector: fix de-obfuscation of scripts inlined in html.
  24703. https://bugs.webkit.org/show_bug.cgi?id=58538
  24704. Use html tokenizer to find script boundaries instead of relying on scriptParsed events.
  24705. Test: inspector/debugger/script-formatter.html
  24706. * WebCore.gypi:
  24707. * WebCore.vcproj/WebCore.vcproj:
  24708. * inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
  24709. * inspector/front-end/ScriptFormatter.js:
  24710. (WebInspector.ScriptFormatter):
  24711. (WebInspector.ScriptFormatter.prototype.formatContent):
  24712. (WebInspector.ScriptFormatter.prototype._didFormatContent):
  24713. * inspector/front-end/ScriptFormatterWorker.js:
  24714. (onmessage):
  24715. (formatScript):
  24716. (HTMLScriptFormatter):
  24717. (HTMLScriptFormatter.prototype.format):
  24718. (HTMLScriptFormatter.prototype.scriptStarted):
  24719. (HTMLScriptFormatter.prototype.scriptEnded):
  24720. (HTMLScriptFormatter.prototype.styleSheetStarted):
  24721. (HTMLScriptFormatter.prototype.styleSheetEnded):
  24722. * inspector/front-end/SourceFile.js:
  24723. (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  24724. * inspector/front-end/SourceHTMLTokenizer.js:
  24725. (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
  24726. (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded):
  24727. (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
  24728. (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded):
  24729. (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  24730. * inspector/front-end/SourceHTMLTokenizer.re2js:
  24731. * inspector/front-end/WebKit.qrc:
  24732. 2011-04-22 Andrey Kosyakov <caseq@chromium.org>
  24733. Reviewed by Pavel Feldman.
  24734. Web Inspector: [Extensions API] misc API cleanup
  24735. https://bugs.webkit.org/show_bug.cgi?id=59194
  24736. * inspector/front-end/ExtensionAPISchema.json:
  24737. * inspector/front-end/ExtensionPanel.js:
  24738. (WebInspector.ExtensionSidebarPane.prototype._setObject):
  24739. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  24740. Reviewed by Yury Semikhatsky.
  24741. Web Inspector: group content scripts in the scripts panel drop down.
  24742. https://bugs.webkit.org/show_bug.cgi?id=59108
  24743. * English.lproj/localizedStrings.js:
  24744. * inspector/front-end/ScriptsPanel.js:
  24745. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
  24746. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
  24747. 2011-04-22 Mike West <mkwst@google.com>
  24748. Reviewed by Pavel Feldman.
  24749. Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
  24750. https://bugs.webkit.org/show_bug.cgi?id=59100
  24751. Improve web inspector UI around adding XHR breakpoints by adding
  24752. a textual label to the input-like `span` used to specify which
  24753. XHR requests the breakpoint ought to target.
  24754. * inspector/front-end/BreakpointsSidebarPane.js:
  24755. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
  24756. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
  24757. * inspector/front-end/inspector.css:
  24758. (#breakpoint-condition-input):
  24759. 2011-04-22 Pavel Podivilov <podivilov@chromium.org>
  24760. Reviewed by Pavel Feldman.
  24761. Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
  24762. https://bugs.webkit.org/show_bug.cgi?id=59191
  24763. * WebCore.gypi:
  24764. * WebCore.vcproj/WebCore.vcproj:
  24765. * inspector/front-end/ScriptFormatter.js:
  24766. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
  24767. (WebInspector.ScriptFormatter.prototype.formatContent):
  24768. * inspector/front-end/ScriptFormatterWorker.js:
  24769. (onmessage):
  24770. * inspector/front-end/SourceFile.js:
  24771. (WebInspector.SourceFile.prototype._loadResourceContent):
  24772. (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  24773. (WebInspector.FormattedSourceMapping):
  24774. (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
  24775. (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
  24776. (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  24777. * inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added.
  24778. (FormattedContentBuilder): Helper class for building formatted script content.
  24779. (FormattedContentBuilder.prototype.addToken):
  24780. (FormattedContentBuilder.prototype.addSpace):
  24781. (FormattedContentBuilder.prototype.addNewLine):
  24782. (FormattedContentBuilder.prototype.increaseNestingLevel):
  24783. (FormattedContentBuilder.prototype.decreaseNestingLevel):
  24784. (FormattedContentBuilder.prototype.content):
  24785. (FormattedContentBuilder.prototype.mapping):
  24786. (Tokenizer): Wrapper class for UglifyJS tokenizer.
  24787. (Tokenizer.prototype.content):
  24788. (Tokenizer.prototype.next):
  24789. (Tokenizer.prototype._convertUglifyToken):
  24790. (JavaScriptFormatter): New formatter based on UglifyJS tokenizer.
  24791. (JavaScriptFormatter.prototype.format):
  24792. * inspector/front-end/UglifyJS/process.js: Removed.
  24793. * inspector/front-end/WebKit.qrc:
  24794. 2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
  24795. Reviewed by Pavel Feldman.
  24796. Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
  24797. https://bugs.webkit.org/show_bug.cgi?id=59189
  24798. * WebCore.gypi:
  24799. * WebCore.vcproj/WebCore.vcproj:
  24800. * inspector/front-end/BinarySearch.js: Added.
  24801. * inspector/front-end/DetailedHeapshotGridNodes.js:
  24802. (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
  24803. (WebInspector.HeapSnapshotGridNode.prototype._populate):
  24804. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  24805. (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
  24806. (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
  24807. (WebInspector.HeapSnapshotGridNode.prototype.sort):
  24808. (WebInspector.HeapSnapshotObjectNode):
  24809. (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
  24810. (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
  24811. (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
  24812. (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
  24813. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
  24814. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
  24815. (WebInspector.HeapSnapshotDiffNode.prototype.get data):
  24816. * inspector/front-end/DetailedHeapshotView.js:
  24817. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort):
  24818. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
  24819. (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
  24820. (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
  24821. (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
  24822. (WebInspector.HeapSnapshotContainmentDataGrid):
  24823. (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource):
  24824. (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
  24825. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
  24826. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
  24827. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
  24828. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
  24829. (WebInspector.HeapSnapshotDominatorsDataGrid):
  24830. (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
  24831. (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
  24832. (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting):
  24833. (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
  24834. (WebInspector.DetailedHeapshotView.prototype._changeBase):
  24835. (WebInspector.DetailedHeapshotView.prototype._changeView):
  24836. (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
  24837. (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  24838. * inspector/front-end/HeapSnapshot.js:
  24839. (WebInspector.HeapSnapshot.prototype.dispose):
  24840. (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds):
  24841. (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
  24842. (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
  24843. (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
  24844. (WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
  24845. (WebInspector.HeapSnapshotsDiff.prototype.calculate):
  24846. (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds):
  24847. (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
  24848. * inspector/front-end/HeapSnapshotProxy.js:
  24849. (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
  24850. (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
  24851. (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
  24852. (WebInspector.HeapSnapshotProviderProxy):
  24853. (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
  24854. (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
  24855. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
  24856. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
  24857. * inspector/front-end/PleaseWaitMessage.js:
  24858. (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
  24859. (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
  24860. * inspector/front-end/WebKit.qrc:
  24861. * inspector/front-end/inspector.html:
  24862. * inspector/front-end/utilities.js:
  24863. 2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
  24864. Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.
  24865. * inspector/front-end/ProfilesPanel.js:
  24866. (WebInspector.ProfilesPanel.prototype.handleShortcut):
  24867. 2011-04-22 Annie Sullivan <sullivan@chromium.org>
  24868. Reviewed by Pavel Feldman.
  24869. Web Inspector: Timeline is too narrow
  24870. https://bugs.webkit.org/show_bug.cgi?id=58399
  24871. Changed Network Panel widths so that Timeline is 50%.
  24872. Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.
  24873. * inspector/front-end/NetworkPanel.js:
  24874. (WebInspector.NetworkPanel.prototype._createTable): Changed column widths.
  24875. (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths.
  24876. (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values.
  24877. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto
  24878. (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto
  24879. (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
  24880. * inspector/front-end/utilities.js:
  24881. (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.
  24882. 2011-04-22 Dan Bernstein <mitz@apple.com>
  24883. Reviewed by Maciej Stachowiak.
  24884. <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
  24885. https://bugs.webkit.org/show_bug.cgi?id=59180
  24886. Test: media/audio-controls-do-not-fade-out.html
  24887. * html/HTMLMediaElement.cpp:
  24888. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
  24889. a video track.
  24890. 2011-04-22 Luke Macpherson <macpherson@chromium.org>
  24891. Reviewed by Eric Seidel.
  24892. Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
  24893. https://bugs.webkit.org/show_bug.cgi?id=59080
  24894. No new tests as no new functionality added.
  24895. * css/CSSPrimitiveValueMappings.h:
  24896. Add casts to/from FontItalics and FontSmallCaps
  24897. * css/CSSStyleSelector.cpp:
  24898. Use new casts defined in PrimitiveValueMappings.h
  24899. * platform/graphics/Font.h:
  24900. Use FontItalics enum.
  24901. * platform/graphics/FontDescription.h:
  24902. Define and use FontItalics and FontSmallCaps enums.
  24903. 2011-04-21 Andrey Kosyakov <caseq@chromium.org>
  24904. Reviewed by Yury Semikhatsky.
  24905. Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
  24906. https://bugs.webkit.org/show_bug.cgi?id=59123
  24907. * inspector/front-end/ResourceCookiesView.js:
  24908. (WebInspector.ResourceCookiesView):
  24909. (WebInspector.ResourceCookiesView.prototype.show):
  24910. (WebInspector.ResourceCookiesView.prototype.get _gotCookies):
  24911. (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
  24912. 2011-04-21 Beth Dakin <bdakin@apple.com>
  24913. Reviewed by Dan Bernstein.
  24914. https://bugs.webkit.org/show_bug.cgi?id=57898
  24915. REGRESSION (r82185): Scroll position not restored on navigation back to a page in
  24916. the page cache
  24917. -and corresponding-
  24918. <rdar://problem/9226652>
  24919. The original fix for this change broke scroll-position restore for pages that are
  24920. *not* in the page cache. This patch fixes both cached and non-cached pages by
  24921. using the cachedScrollPosition() only for cached pages.
  24922. * loader/HistoryController.cpp:
  24923. (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
  24924. 2011-04-21 Luke Macpherson <macpherson@chromium.org>
  24925. Reviewed by Eric Seidel.
  24926. Remove redundant calls to RenderStyle::setDisplay()
  24927. https://bugs.webkit.org/show_bug.cgi?id=59060
  24928. No new tests / no new functionality added.
  24929. * css/CSSStyleSelector.cpp:
  24930. (WebCore::CSSStyleSelector::applyProperty):
  24931. Remove redundant calls to RenderStyle::setDisplay()
  24932. 2011-04-21 John Bauman <jbauman@chromium.org>
  24933. Reviewed by Kenneth Russell.
  24934. WebGL context drawing buffer may not be cleared if FBO bound
  24935. https://bugs.webkit.org/show_bug.cgi?id=58956
  24936. Clear the drawing buffer even if it's not currently bound, by
  24937. switching between FBOs around the clear. Also, make sure that we
  24938. handle depth and stencil masks properly.
  24939. No new tests, because testing this under DRT doesn't work.
  24940. * html/canvas/WebGLRenderingContext.cpp:
  24941. (WebCore::WebGLRenderingContext::initializeNewContext):
  24942. (WebCore::WebGLRenderingContext::clearIfComposited):
  24943. (WebCore::WebGLRenderingContext::depthMask):
  24944. * html/canvas/WebGLRenderingContext.h:
  24945. *
  24946. 2011-04-21 Chris Fleizach <cfleizach@apple.com>
  24947. Reviewed by Beth Dakin.
  24948. WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
  24949. https://bugs.webkit.org/show_bug.cgi?id=59140
  24950. WebKit should not modify the DOM when the screen reader requests certain things be set. There is no
  24951. specification that allows this behavior yet, but we are working on something for the future.
  24952. * accessibility/AccessibilityRenderObject.cpp:
  24953. (WebCore::AccessibilityRenderObject::setARIAGrabbed):
  24954. (WebCore::AccessibilityRenderObject::setIsExpanded):
  24955. (WebCore::AccessibilityRenderObject::setSelected):
  24956. (WebCore::AccessibilityRenderObject::setValue):
  24957. 2011-04-21 Chris Fleizach <cfleizach@apple.com>
  24958. Reviewed by Beth Dakin.
  24959. AX: order AccessibilityRole alphabetically
  24960. https://bugs.webkit.org/show_bug.cgi?id=31524
  24961. * accessibility/AccessibilityObject.h:
  24962. 2011-04-21 Jia Pu <jpu@apple.com>
  24963. Reviewed by Maciej Stachowiak.
  24964. [Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared.
  24965. https://bugs.webkit.org/show_bug.cgi?id=59155
  24966. <rdar://problem/9261698>
  24967. Make sure the range isn't cleared before calling windowRectForRange() on it. Also removed unused functions in Editor.h,
  24968. and fixed a typo in function name.
  24969. * editing/Editor.h:
  24970. * editing/SpellingCorrectionController.cpp:
  24971. (WebCore::SpellingCorrectionController::correctionPanelTimerFired):
  24972. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  24973. * editing/SpellingCorrectionController.h:
  24974. (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  24975. 2011-04-21 Maciej Stachowiak <mjs@apple.com>
  24976. Reviewed by Adam Roben.
  24977. Add a feature define to allow <details> and <summary> to be disabled
  24978. https://bugs.webkit.org/show_bug.cgi?id=59118
  24979. <rdar://problem/9257045>
  24980. No new tests; no behavior change.
  24981. * Configurations/FeatureDefines.xcconfig:
  24982. * DerivedSources.make:
  24983. * GNUmakefile.am:
  24984. * features.pri:
  24985. * html/HTMLDetailsElement.cpp:
  24986. * html/HTMLSummaryElement.cpp:
  24987. * html/HTMLTagNames.in:
  24988. * html/shadow/DetailsMarkerControl.cpp:
  24989. * rendering/RenderBlock.cpp:
  24990. (WebCore::canMergeContiguousAnonymousBlocks):
  24991. * rendering/RenderDetails.cpp:
  24992. * rendering/RenderDetails.h:
  24993. * rendering/RenderDetailsMarker.cpp:
  24994. * rendering/RenderDetailsMarker.h:
  24995. * rendering/RenderObject.h:
  24996. * rendering/RenderSummary.cpp:
  24997. * rendering/RenderSummary.h:
  24998. * rendering/RenderTreeAsText.cpp:
  24999. (WebCore::RenderTreeAsText::writeRenderObject):
  25000. 2011-04-21 Dimitri Glazkov <dglazkov@chromium.org>
  25001. Reviewed by Adele Peterson.
  25002. REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
  25003. https://bugs.webkit.org/show_bug.cgi?id=59053
  25004. Turns out, the relatedTarget of an event could be also an ancestor of an event,
  25005. not just its parent. Duh.
  25006. * dom/EventDispatcher.cpp:
  25007. (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost
  25008. explicitly.
  25009. 2011-04-21 Michael Saboff <msaboff@apple.com>
  25010. Reviewed by Maciej Stachowiak.
  25011. Qualified names used for all TagName access, yet namespace usage is rare
  25012. https://bugs.webkit.org/show_bug.cgi?id=58997
  25013. The methods getElementsByTagName and getElementsByTagNameNS where
  25014. always creating and using QualifiedNames. QualifiedName::init
  25015. was consistently in the top 3 routines when running the Dromaeo
  25016. DOM-query benchmark. Split out the functionality so that
  25017. getElementsByTagName uses just the local name, an implied "*"
  25018. namespace and a separate TagNodeListCache keyed by an atomic name
  25019. instead of a QualifiedName. Access to elements via
  25020. getElementsByTagNameNS that have "*" namespace are forwarded to
  25021. getElementsByTagName as well. This provides ~10% speed up in that
  25022. Dromaeo test.
  25023. No new tests added, existing tests have coverage. The changes are
  25024. an optimization of existing functionality.
  25025. * dom/Node.cpp:
  25026. (WebCore::Node::removeCachedTagNodeList):
  25027. (WebCore::Node::getElementsByTagName):
  25028. (WebCore::Node::getElementsByTagNameNS):
  25029. (WebCore::NodeListsNodeData::invalidateCaches):
  25030. (WebCore::NodeListsNodeData::isEmpty):
  25031. * dom/Node.h:
  25032. * dom/NodeRareData.h:
  25033. * dom/TagNodeList.cpp:
  25034. (WebCore::TagNodeList::~TagNodeList):
  25035. 2011-04-21 Geoffrey Garen <ggaren@apple.com>
  25036. Reviewed by Oliver Hunt.
  25037. Removed a use of markDOMObjectWrapper: more style- and node-related stuff
  25038. https://bugs.webkit.org/show_bug.cgi?id=59127
  25039. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  25040. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  25041. (WebCore::JSCanvasRenderingContextOwner::isReachableFromOpaqueRoots):
  25042. (WebCore::JSCanvasRenderingContextOwner::finalize):
  25043. (WebCore::wrapperOwner):
  25044. (WebCore::wrapperContext): Use opaque roots for marking canvas rendering
  25045. contexts, so JSNode isn't responsible for it.
  25046. * bindings/js/JSElementCustom.cpp:
  25047. (WebCore::JSElement::markChildren):
  25048. * bindings/js/JSHTMLCanvasElementCustom.cpp:
  25049. * bindings/js/JSHTMLLinkElementCustom.cpp:
  25050. * bindings/js/JSHTMLStyleElementCustom.cpp: Removed obsolete marking code.
  25051. * bindings/js/JSNodeCustom.cpp:
  25052. (WebCore::isObservable):
  25053. (WebCore::isReachableFromDOM):
  25054. (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): Removed a bunch of
  25055. CSS object model related special cases, since the CSS object model
  25056. now tracks its own lifetime through the opaque roots system. Removed
  25057. canvas special case, covered above.
  25058. * bindings/js/JSProcessingInstructionCustom.cpp:
  25059. * bindings/js/JSWebKitAnimationListCustom.cpp:
  25060. * dom/ProcessingInstruction.idl:
  25061. * html/HTMLCanvasElement.idl:
  25062. * html/HTMLLinkElement.idl:
  25063. * html/HTMLStyleElement.idl:
  25064. * page/WebKitAnimationList.idl: Removed obsolete marking code.
  25065. 2011-04-21 Vangelis Kokkevis <vangelis@chromium.org>
  25066. Reviewed by James Robinson.
  25067. [chromium] Only update the contents of layers that are going to
  25068. be drawn. Remove individual texture unreserves that happen
  25069. after the layer draw calls with a single unreserve for all the
  25070. textures in the texture manager.
  25071. https://bugs.webkit.org/show_bug.cgi?id=59129
  25072. Tests: No new functionality. Covered by existing layout tests.
  25073. * platform/graphics/chromium/ContentLayerChromium.cpp:
  25074. (WebCore::ContentLayerChromium::draw):
  25075. * platform/graphics/chromium/ContentLayerChromium.h:
  25076. * platform/graphics/chromium/ImageLayerChromium.cpp:
  25077. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  25078. (WebCore::ImageLayerChromium::updateCompositorResources):
  25079. * platform/graphics/chromium/LayerRendererChromium.cpp:
  25080. (WebCore::LayerRendererChromium::drawRootLayer):
  25081. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  25082. (WebCore::LayerRendererChromium::updateLayers):
  25083. (WebCore::LayerRendererChromium::paintLayerContents):
  25084. * platform/graphics/chromium/LayerRendererChromium.h:
  25085. * platform/graphics/chromium/LayerTexture.cpp:
  25086. * platform/graphics/chromium/LayerTexture.h:
  25087. * platform/graphics/chromium/LayerTilerChromium.cpp:
  25088. * platform/graphics/chromium/LayerTilerChromium.h:
  25089. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  25090. (WebCore::RenderSurfaceChromium::drawSurface):
  25091. * platform/graphics/chromium/TextureManager.cpp:
  25092. (WebCore::TextureManager::unprotectAllTextures):
  25093. * platform/graphics/chromium/TextureManager.h:
  25094. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  25095. (WebCore::CCHeadsUpDisplay::draw):
  25096. * platform/graphics/chromium/cc/CCLayerImpl.h:
  25097. (WebCore::CCLayerImpl::owner):
  25098. 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
  25099. Reviewed by Sam Weinig.
  25100. Add Frame* to the argument lists of canCopyCut and canPaste
  25101. https://bugs.webkit.org/show_bug.cgi?id=59153
  25102. canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
  25103. This allows editor client to grant copy/cut and paste permissions per origin.
  25104. * editing/EditorCommand.cpp:
  25105. (WebCore::supportedCopyCut):
  25106. (WebCore::supportedPaste):
  25107. * loader/EmptyClients.h:
  25108. (WebCore::EmptyEditorClient::canCopyCut):
  25109. (WebCore::EmptyEditorClient::canPaste):
  25110. * page/EditorClient.h:
  25111. 2011-04-21 Oliver Hunt <oliver@apple.com>
  25112. Whoops, change lost during merge
  25113. * bindings/js/JSEventListener.h:
  25114. 2011-04-21 Geoffrey Garen <ggaren@apple.com>
  25115. Reviewed by Sam Weinig.
  25116. Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
  25117. wrong global object use.
  25118. * bindings/js/JSHTMLDocumentCustom.cpp:
  25119. (WebCore::JSHTMLDocument::nameGetter):
  25120. (WebCore::JSHTMLDocument::all):
  25121. * bindings/js/JSHTMLFormElementCustom.cpp:
  25122. (WebCore::JSHTMLFormElement::nameGetter): Use the right global object.
  25123. 2011-04-21 Oliver Hunt <oliver@apple.com>
  25124. Reviewed by Geoffrey Garen.
  25125. Start moving to a general visitor pattern for GC traversal
  25126. https://bugs.webkit.org/show_bug.cgi?id=59141
  25127. This is just a rename:
  25128. markChildren -> visitChildren
  25129. markAggregate -> visitAggregate
  25130. markStack -> visitor
  25131. MarkStack -> typedef'd to SlotVisitor
  25132. * bindings/js/JSAttrCustom.cpp:
  25133. (WebCore::JSAttr::visitChildren):
  25134. * bindings/js/JSAudioConstructor.cpp:
  25135. (WebCore::constructAudio):
  25136. * bindings/js/JSCSSRuleCustom.cpp:
  25137. (WebCore::JSCSSRule::visitChildren):
  25138. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  25139. (WebCore::JSCSSStyleDeclaration::visitChildren):
  25140. * bindings/js/JSDOMBinding.cpp:
  25141. (WebCore::visitActiveObjectsForContext):
  25142. (WebCore::markDOMObjectWrapper):
  25143. * bindings/js/JSDOMBinding.h:
  25144. * bindings/js/JSDOMGlobalObject.cpp:
  25145. (WebCore::JSDOMGlobalObject::visitChildren):
  25146. * bindings/js/JSDOMGlobalObject.h:
  25147. * bindings/js/JSDOMImplementationCustom.cpp:
  25148. (WebCore::JSDOMImplementation::visitChildren):
  25149. * bindings/js/JSDOMWindowCustom.cpp:
  25150. (WebCore::JSDOMWindow::visitChildren):
  25151. * bindings/js/JSDOMWindowShell.cpp:
  25152. (WebCore::JSDOMWindowShell::visitChildren):
  25153. * bindings/js/JSDOMWindowShell.h:
  25154. * bindings/js/JSDocumentCustom.cpp:
  25155. (WebCore::JSDocument::visitChildren):
  25156. * bindings/js/JSElementCustom.cpp:
  25157. (WebCore::JSElement::visitChildren):
  25158. * bindings/js/JSEventListener.cpp:
  25159. (WebCore::JSEventListener::markJSFunction):
  25160. * bindings/js/JSEventListener.h:
  25161. * bindings/js/JSHTMLCanvasElementCustom.cpp:
  25162. (WebCore::JSHTMLCanvasElement::visitChildren):
  25163. * bindings/js/JSHTMLLinkElementCustom.cpp:
  25164. (WebCore::JSHTMLLinkElement::visitChildren):
  25165. * bindings/js/JSHTMLStyleElementCustom.cpp:
  25166. (WebCore::JSHTMLStyleElement::visitChildren):
  25167. * bindings/js/JSImageConstructor.cpp:
  25168. (WebCore::constructImage):
  25169. * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
  25170. (WebCore::JSJavaScriptAudioNode::visitChildren):
  25171. * bindings/js/JSMessageChannelCustom.cpp:
  25172. (WebCore::JSMessageChannel::visitChildren):
  25173. * bindings/js/JSMessagePortCustom.cpp:
  25174. (WebCore::JSMessagePort::visitChildren):
  25175. * bindings/js/JSNamedNodeMapCustom.cpp:
  25176. (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
  25177. (WebCore::JSNamedNodeMap::visitChildren):
  25178. * bindings/js/JSNavigatorCustom.cpp:
  25179. (WebCore::JSNavigator::visitChildren):
  25180. * bindings/js/JSNodeCustom.cpp:
  25181. (WebCore::isObservable):
  25182. (WebCore::isReachableFromDOM):
  25183. (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
  25184. (WebCore::JSNode::visitChildren):
  25185. * bindings/js/JSNodeCustom.h:
  25186. * bindings/js/JSNodeFilterCondition.cpp:
  25187. (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  25188. * bindings/js/JSNodeFilterCondition.h:
  25189. * bindings/js/JSNodeFilterCustom.cpp:
  25190. (WebCore::JSNodeFilter::visitChildren):
  25191. * bindings/js/JSNodeIteratorCustom.cpp:
  25192. (WebCore::JSNodeIterator::visitChildren):
  25193. * bindings/js/JSNodeListCustom.cpp:
  25194. (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
  25195. * bindings/js/JSProcessingInstructionCustom.cpp:
  25196. (WebCore::JSProcessingInstruction::visitChildren):
  25197. * bindings/js/JSSVGElementInstanceCustom.cpp:
  25198. (WebCore::JSSVGElementInstance::visitChildren):
  25199. * bindings/js/JSSharedWorkerCustom.cpp:
  25200. (WebCore::JSSharedWorker::visitChildren):
  25201. * bindings/js/JSStyleSheetCustom.cpp:
  25202. (WebCore::JSStyleSheet::visitChildren):
  25203. * bindings/js/JSTreeWalkerCustom.cpp:
  25204. (WebCore::JSTreeWalker::visitChildren):
  25205. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  25206. (WebCore::JSWebGLRenderingContext::visitChildren):
  25207. * bindings/js/JSWebKitAnimationListCustom.cpp:
  25208. (WebCore::JSWebKitAnimationList::visitChildren):
  25209. * bindings/js/JSWorkerContextCustom.cpp:
  25210. (WebCore::JSWorkerContext::visitChildren):
  25211. * bindings/js/JSXMLHttpRequestCustom.cpp:
  25212. (WebCore::JSXMLHttpRequest::visitChildren):
  25213. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  25214. (WebCore::JSXMLHttpRequestUpload::visitChildren):
  25215. * bindings/scripts/CodeGeneratorJS.pm:
  25216. * bridge/qt/qt_instance.cpp:
  25217. (JSC::Bindings::QtRuntimeObject::visitChildren):
  25218. (JSC::Bindings::QtInstance::markAggregate):
  25219. * bridge/qt/qt_instance.h:
  25220. * bridge/qt/qt_pixmapruntime.cpp:
  25221. * bridge/qt/qt_runtime.cpp:
  25222. (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
  25223. * bridge/qt/qt_runtime.h:
  25224. * dom/EventListener.h:
  25225. (WebCore::EventListener::visitJSFunction):
  25226. * dom/EventTarget.h:
  25227. (WebCore::EventTarget::visitJSEventListeners):
  25228. * dom/Node.h:
  25229. * dom/NodeFilterCondition.h:
  25230. (WebCore::NodeFilterCondition::visitAggregate):
  25231. * page/DOMWindow.h:
  25232. * workers/WorkerContext.h:
  25233. 2011-04-21 Beth Dakin <bdakin@apple.com>
  25234. Reviewed by Dan Bernstein.
  25235. https://bugs.webkit.org/show_bug.cgi?id=59048
  25236. Need to track whether overlay scrollbar is currently visible and in lower-
  25237. righthand corner
  25238. -and corresponding-
  25239. <rdar://problem/9211232>
  25240. Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
  25241. and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
  25242. knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
  25243. track this value so that it can avoid sending messages across the ChromeClient to
  25244. the UIProcess if the rect has not changed.
  25245. * platform/mac/ScrollAnimatorMac.h:
  25246. * platform/mac/ScrollAnimatorMac.mm:
  25247. (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
  25248. (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
  25249. (WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):
  25250. Plumbing for the chrome client.
  25251. * page/ChromeClient.h:
  25252. (WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):
  25253. * page/FrameView.cpp:
  25254. (WebCore::FrameView::setVisibleScrollerThumbRect):
  25255. * page/FrameView.h:
  25256. * platform/ScrollableArea.h:
  25257. (WebCore::ScrollableArea::setVisibleScrollerThumbRect):
  25258. New WebCoreSystemInterface function to get the knob rect.
  25259. * WebCore.exp.in:
  25260. * platform/mac/WebCoreSystemInterface.h:
  25261. * platform/mac/WebCoreSystemInterface.mm:
  25262. 2011-04-21 Nat Duca <nduca@chromium.org>
  25263. Reviewed by James Robinson.
  25264. [chromium] Fix artefacts in compositor HUD when resizing
  25265. https://bugs.webkit.org/show_bug.cgi?id=58969
  25266. HUD was using the tiler program and not setting the texture
  25267. transform. The HUD would thus draw with a texture transform based
  25268. on the last tile drawn, leading sometimes to distortion.
  25269. * platform/graphics/chromium/LayerRendererChromium.cpp:
  25270. (WebCore::LayerRendererChromium::initializeSharedObjects):
  25271. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  25272. * platform/graphics/chromium/LayerRendererChromium.h:
  25273. (WebCore::LayerRendererChromium::headsUpDisplayProgram):
  25274. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  25275. (WebCore::CCHeadsUpDisplay::draw):
  25276. * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  25277. 2011-04-21 Mike Reed <reed@google.com>
  25278. Reviewed by Kenneth Russell.
  25279. only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
  25280. https://bugs.webkit.org/show_bug.cgi?id=59024
  25281. No new tests. The bug (and fix) depend on enabling SKIA_GPU. When that is enabled, the bug
  25282. shows all text w/o lcd rendering. This is a regression from a recent CL when we switch to
  25283. calling skia::SupportsPlatformPaint. This CL fixes that.
  25284. There should be no change for the default builds when SKIA_GPU is not enabled.
  25285. * platform/graphics/skia/PlatformContextSkia.cpp:
  25286. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  25287. 2011-04-21 Adrienne Walker <enne@google.com>
  25288. Reviewed by James Robinson.
  25289. [chromium] Don't upload partially drawn tiles in the compositor
  25290. https://bugs.webkit.org/show_bug.cgi?id=59112
  25291. Use the same set of tiles for painting as is used for updating.
  25292. Before, a larger set of tiles were being uploaded, causing some to
  25293. only be partially undirtied because they were not fully painted.
  25294. As tiles are clear their dirty rect after being unpainted, this caused
  25295. artifacts to appear when scrolling.
  25296. Unfortunately, no layout test can test this behavior yet because
  25297. scrolling invalidations are done differently in test shell.
  25298. * platform/graphics/chromium/ImageLayerChromium.cpp:
  25299. (WebCore::ImageLayerChromium::updateCompositorResources):
  25300. * platform/graphics/chromium/LayerTilerChromium.cpp:
  25301. (WebCore::LayerTilerChromium::update):
  25302. (WebCore::LayerTilerChromium::uploadCanvas):
  25303. (WebCore::LayerTilerChromium::updateFromPixels):
  25304. * platform/graphics/chromium/LayerTilerChromium.h:
  25305. 2011-04-21 Ben Taylor <bentaylor.solx86@gmail.com>
  25306. Reviewed by Alexey Proskuryakov.
  25307. https://bugs.webkit.org/show_bug.cgi?id=58725
  25308. Fix a compile issue on Solaris 10 with Sun Studio 12,
  25309. ternary operators (?:) must have the same types
  25310. * loader/DocumentLoader.cpp:
  25311. (WebCore::DocumentLoader::popArchiveForSubframe):
  25312. * loader/archive/ArchiveFactory.cpp:
  25313. (WebCore::ArchiveFactory::create):
  25314. * loader/icon/IconDatabase.cpp:
  25315. (WebCore::IconDatabase::setIconDataForIconURL):
  25316. * page/animation/AnimationBase.cpp:
  25317. (WebCore::blendFunc):
  25318. * rendering/RenderLayer.cpp:
  25319. (WebCore::RenderLayer::updateScrollCornerStyle):
  25320. (WebCore::RenderLayer::updateResizerStyle):
  25321. * rendering/RenderScrollbar.cpp:
  25322. (WebCore::RenderScrollbar::updateScrollbarPart):
  25323. * rendering/RenderTextFragment.cpp:
  25324. (WebCore::RenderTextFragment::RenderTextFragment):
  25325. 2011-04-21 Mike Reed <reed@google.com>
  25326. Reviewed by Kenneth Russell.
  25327. [chromium, win] Multiple failures of shadow rendering layout tests
  25328. https://bugs.webkit.org/show_bug.cgi?id=58772
  25329. No new tests. This CL fixes a regression in the following tests
  25330. fast/multicol/shadow-breaking.html
  25331. fast/repaint/shadow-multiple-horizontal.html
  25332. fast/repaint/shadow-multiple-strict-horizontal.html
  25333. fast/repaint/shadow-multiple-strict-vertical.html
  25334. fast/repaint/shadow-multiple-vertical.html
  25335. fast/text/shadow-translucent-fill.html
  25336. fast/transforms/shadows.html
  25337. svg/css/group-with-shadow.svg
  25338. svg/css/shadow-changes.svg
  25339. svg/css/text-shadow-multiple.xhtml
  25340. transitions/svg-text-shadow-transition.html
  25341. svg/css/composite-shadow-text.svg
  25342. * platform/graphics/skia/GraphicsContextSkia.cpp:
  25343. (WebCore::GraphicsContext::setPlatformShadow):
  25344. 2011-04-21 Geoffrey Garen <ggaren@apple.com>
  25345. Try to fix the Qt build.
  25346. * UseJSC.cmake:
  25347. * WebCore.pro: Use correct file name.
  25348. 2011-04-21 Dirk Schulze <krit@webkit.org>
  25349. Unreviewed Qt build fix.
  25350. SVG feDropShadow implementation of SVG Filters 1.2
  25351. https://bugs.webkit.org/show_bug.cgi?id=52513
  25352. * CodeGenerators.pri:
  25353. 2011-04-21 Adrienne Walker <enne@google.com>
  25354. Reviewed by James Robinson.
  25355. [chromium] Clamp dirty regions on content layers to layer bounds
  25356. https://bugs.webkit.org/show_bug.cgi?id=58933
  25357. This prevents garbage being rendered when layers are resized and a
  25358. previous invalidation (now off-layer) is no longer valid.
  25359. * platform/graphics/chromium/ContentLayerChromium.cpp:
  25360. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  25361. 2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
  25362. Reviewed by Kent Tamura.
  25363. Bug 59012 - Shadows should be imported along with their host nodes
  25364. https://bugs.webkit.org/show_bug.cgi?id=59012
  25365. Copy the shadow tree of an element (even on a shallow copy!).
  25366. Test: fast/dom/shadow/import-shadowroot.html
  25367. * dom/Element.cpp:
  25368. (WebCore::Element::copyNonAttributeProperties):
  25369. * dom/Element.h:
  25370. 2011-04-20 Geoffrey Garen <ggaren@apple.com>
  25371. Reviewed by Oliver Hunt.
  25372. Removed a use of markDOMObjectWrapper: CSS Object Model
  25373. https://bugs.webkit.org/show_bug.cgi?id=59057
  25374. This is 24 hours of my life I will never get back. Thank you, W3C.
  25375. * GNUmakefile.list.am:
  25376. * WebCore.gypi:
  25377. * WebCore.vcproj/WebCore.vcproj:
  25378. * WebCore.xcodeproj/project.pbxproj: Build!
  25379. * bindings/js/JSCSSFontFaceRuleCustom.cpp:
  25380. * bindings/js/JSCSSImportRuleCustom.cpp:
  25381. * bindings/js/JSCSSMediaRuleCustom.cpp:
  25382. * bindings/js/JSCSSPageRuleCustom.cpp:
  25383. * bindings/js/JSCSSRuleCustom.cpp:
  25384. (WebCore::JSCSSRuleOwner::isReachableFromOpaqueRoots):
  25385. (WebCore::JSCSSRuleOwner::finalize):
  25386. (WebCore::wrapperOwner):
  25387. (WebCore::wrapperContext):
  25388. (WebCore::JSCSSRule::markChildren):
  25389. * bindings/js/JSCSSRuleListCustom.cpp:
  25390. (WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
  25391. (WebCore::JSCSSRuleListOwner::finalize):
  25392. (WebCore::wrapperOwner):
  25393. (WebCore::wrapperContext):
  25394. (WebCore::toJS):
  25395. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  25396. (WebCore::JSCSSStyleDeclarationOwner::isReachableFromOpaqueRoots):
  25397. (WebCore::JSCSSStyleDeclarationOwner::finalize):
  25398. (WebCore::wrapperOwner):
  25399. (WebCore::wrapperContext):
  25400. (WebCore::JSCSSStyleDeclaration::markChildren): Removed custom mark functions,
  25401. and replaced with use of the opaque roots system. This has the nice benefit
  25402. of allowing us to eagerly recycle far more CSS wrappers and their associated
  25403. DOM wrappers.
  25404. (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Made this function
  25405. custom because it must maintain the sorrowful invariant that primitive
  25406. values can be mapped back to objects that are reachable through the DOM.
  25407. We maintain this invariant through an external hash table because
  25408. making all primitive values bigger would be a too-large memory use
  25409. penalty. Luckily, nobody uses this feature, so the cost of the hash table
  25410. is no big deal.
  25411. (WebCore::toJS): We need a custom toJS so we can specify our own WeakHandleOwner.
  25412. * bindings/js/JSCSSStyleRuleCustom.cpp: Removed custom mark, as above.
  25413. * bindings/js/JSCSSValueCustom.cpp:
  25414. (WebCore::cssValueRoots):
  25415. (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
  25416. (WebCore::JSCSSValueOwner::finalize):
  25417. (WebCore::wrapperOwner):
  25418. (WebCore::wrapperContext): Use the opaque roots system. Piggy-back on
  25419. the external hash table filled by JSCSSStyleDeclaration::getPropertyCSSValue.
  25420. * bindings/js/JSDocumentCustom.cpp:
  25421. (WebCore::JSDocument::markChildren): No need to mark our stylesheet list,
  25422. since all style-related objects can use our opaque root to determine
  25423. liveness.
  25424. * bindings/js/JSMediaListCustom.cpp: Added.
  25425. (WebCore::JSMediaListOwner::isReachableFromOpaqueRoots):
  25426. (WebCore::JSMediaListOwner::finalize):
  25427. (WebCore::wrapperOwner):
  25428. (WebCore::wrapperContext):
  25429. (WebCore::toJS): Use the opaque roots system.
  25430. * bindings/js/JSNodeCustom.h:
  25431. (WebCore::root): Added helpers for computing style-related roots.
  25432. * bindings/js/JSStyleSheetCustom.cpp:
  25433. (WebCore::JSStyleSheetOwner::isReachableFromOpaqueRoots):
  25434. (WebCore::JSStyleSheetOwner::finalize):
  25435. (WebCore::wrapperOwner):
  25436. (WebCore::wrapperContext):
  25437. (WebCore::JSStyleSheet::markChildren): Use the opaque roots system instead
  25438. of direct marking.
  25439. * bindings/js/JSStyleSheetListCustom.cpp:
  25440. (WebCore::JSStyleSheetListOwner::isReachableFromOpaqueRoots):
  25441. (WebCore::JSStyleSheetListOwner::finalize):
  25442. (WebCore::wrapperOwner):
  25443. (WebCore::wrapperContext):
  25444. (WebCore::toJS): Ditto.
  25445. * bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp:
  25446. * bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp:
  25447. * css/CSSFontFaceRule.idl:
  25448. * css/CSSImportRule.idl: No more custom mark, since we use the opaque
  25449. roots system instead.
  25450. * css/CSSMediaRule.cpp:
  25451. (WebCore::CSSMediaRule::CSSMediaRule): Fixed a bug where a media rule
  25452. would incorrectly have no parent, since this got in the way of correctly
  25453. computing the media rule's root.
  25454. * css/CSSMediaRule.idl:
  25455. * css/CSSPageRule.idl:
  25456. * css/CSSRuleList.idl:
  25457. * css/CSSStyleDeclaration.idl:
  25458. * css/CSSStyleRule.idl:
  25459. * css/MediaList.idl: Match behavior changes above.
  25460. * css/StyleBase.cpp:
  25461. (WebCore::StyleBase::node): Helper function for computing roots of the
  25462. style system. This object model is pretty weird and not very well factored,
  25463. but I'm pretty sure this covers all the relevant cases.
  25464. * css/StyleBase.h:
  25465. * css/StyleSheetList.idl:
  25466. * css/WebKitCSSKeyframeRule.idl:
  25467. * css/WebKitCSSKeyframesRule.idl: Updated to match the behavior changes above.
  25468. 2011-04-21 Dirk Schulze <krit@webkit.org>
  25469. Reviewed by Nikolas Zimmermann.
  25470. SVG feDropShadow implementation of SVG Filters 1.2
  25471. https://bugs.webkit.org/show_bug.cgi?id=52513
  25472. This is the implementation of feDropShadow, a shorthand filter and a combination of feGaussianBlur,
  25473. feOffset, feFlood and feComposite to create a drop shadow of an input effect.
  25474. Creating this new filter effect makes it possible to optimize the often used workflow. ShadowBlur, with its
  25475. fast blurring algorithm, is used to blur the shadow and composite operators are responsible for combining the
  25476. source with different colored shadows.
  25477. Shadow color and opacity can be set with the properties flood-color and flood-opacity.
  25478. Tests: svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html
  25479. svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html
  25480. svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html
  25481. svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
  25482. svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
  25483. svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html
  25484. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html
  25485. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html
  25486. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html
  25487. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
  25488. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
  25489. svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
  25490. svg/filters/feDropShadow.svg
  25491. * Android.mk:
  25492. * CMakeLists.txt:
  25493. * DerivedSources.cpp:
  25494. * DerivedSources.make:
  25495. * GNUmakefile.list.am:
  25496. * WebCore.exp.in:
  25497. * WebCore.gypi:
  25498. * WebCore.pro:
  25499. * WebCore.vcproj/WebCore.vcproj:
  25500. * WebCore.xcodeproj/project.pbxproj:
  25501. * bindings/objc/DOM.mm:
  25502. (WebCore::createElementClassMap):
  25503. * bindings/objc/DOMSVG.h:
  25504. * page/DOMWindow.idl:
  25505. * platform/graphics/ShadowBlur.cpp: Added missing copyright after r84410.
  25506. * platform/graphics/ShadowBlur.h: Made blurLayerImage public.
  25507. * platform/graphics/filters/FEDropShadow.cpp: Added.
  25508. (WebCore::FEDropShadow::FEDropShadow):
  25509. (WebCore::FEDropShadow::create):
  25510. (WebCore::FEDropShadow::determineAbsolutePaintRect):
  25511. (WebCore::FEDropShadow::apply):
  25512. (WebCore::FEDropShadow::dump):
  25513. (WebCore::FEDropShadow::externalRepresentation):
  25514. * platform/graphics/filters/FEDropShadow.h: Added.
  25515. (WebCore::FEDropShadow::stdDeviationX):
  25516. (WebCore::FEDropShadow::setStdDeviationX):
  25517. (WebCore::FEDropShadow::stdDeviationY):
  25518. (WebCore::FEDropShadow::setStdDeviationY):
  25519. (WebCore::FEDropShadow::dx):
  25520. (WebCore::FEDropShadow::setDx):
  25521. (WebCore::FEDropShadow::dy):
  25522. (WebCore::FEDropShadow::setDy):
  25523. (WebCore::FEDropShadow::shadowColor):
  25524. (WebCore::FEDropShadow::setShadowColor):
  25525. (WebCore::FEDropShadow::shadowOpacity):
  25526. (WebCore::FEDropShadow::setShadowOpacity):
  25527. * platform/graphics/filters/FEGaussianBlur.cpp:
  25528. (WebCore::FEGaussianBlur::calculateKernelSize): Make kernel calculations accessible for feDropShadow.
  25529. * platform/graphics/filters/FEGaussianBlur.h:
  25530. * svg/SVGAllInOne.cpp:
  25531. * svg/SVGFEDropShadowElement.cpp: Added.
  25532. (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
  25533. (WebCore::SVGFEDropShadowElement::create):
  25534. (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
  25535. (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
  25536. (WebCore::SVGFEDropShadowElement::setStdDeviation):
  25537. (WebCore::SVGFEDropShadowElement::parseMappedAttribute):
  25538. (WebCore::SVGFEDropShadowElement::svgAttributeChanged):
  25539. (WebCore::SVGFEDropShadowElement::synchronizeProperty):
  25540. (WebCore::SVGFEDropShadowElement::build):
  25541. * svg/SVGFEDropShadowElement.h: Added.
  25542. * svg/SVGFEDropShadowElement.idl: Added.
  25543. * svg/svgtags.in:
  25544. 2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
  25545. Reviewed by Dimitri Glazkov.
  25546. Bug 58704 - Decide on node type for ShadowRoot
  25547. https://bugs.webkit.org/show_bug.cgi?id=58704
  25548. Add a new node type SHADOW_ROOT_NODE.
  25549. Adapt all calling sites of nodeType().
  25550. Test: fast/dom/shadow/nodetype.html
  25551. * bindings/js/JSNodeCustom.cpp:
  25552. (WebCore::createWrapperInline):
  25553. * bindings/objc/DOM.mm:
  25554. (kitClass):
  25555. * bindings/v8/custom/V8NodeCustom.cpp:
  25556. (WebCore::toV8Slow):
  25557. * dom/Document.cpp:
  25558. (WebCore::Document::importNode):
  25559. (WebCore::Document::childTypeAllowed):
  25560. (WebCore::Document::canReplaceChild):
  25561. * dom/Node.cpp:
  25562. (WebCore::Node::dumpStatistics):
  25563. (WebCore::Node::isDefaultNamespace):
  25564. (WebCore::Node::lookupPrefix):
  25565. (WebCore::Node::lookupNamespaceURI):
  25566. (WebCore::appendTextContent):
  25567. (WebCore::Node::setTextContent):
  25568. * dom/Node.h:
  25569. * dom/Range.cpp:
  25570. (WebCore::lengthOfContentsInNode):
  25571. (WebCore::Range::processContentsBetweenOffsets):
  25572. (WebCore::Range::insertNode):
  25573. (WebCore::Range::checkNodeWOffset):
  25574. (WebCore::Range::checkNodeBA):
  25575. (WebCore::Range::selectNode):
  25576. (WebCore::Range::selectNodeContents):
  25577. (WebCore::Range::surroundContents):
  25578. * dom/ShadowRoot.cpp:
  25579. (WebCore::ShadowRoot::nodeType):
  25580. * dom/Traversal.cpp:
  25581. (WebCore::Traversal::acceptNode):
  25582. * editing/MarkupAccumulator.cpp:
  25583. (WebCore::MarkupAccumulator::appendStartMarkup):
  25584. * html/parser/HTMLElementStack.cpp:
  25585. (WebCore::HTMLNames::isRootNode):
  25586. (WebCore::HTMLElementStack::pushRootNode):
  25587. * html/parser/HTMLElementStack.h:
  25588. (WebCore::isInHTMLNamespace):
  25589. * xml/XPathUtil.cpp:
  25590. (WebCore::XPath::isValidContextNode):
  25591. 2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
  25592. Reviewed by Kent Tamura.
  25593. REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
  25594. https://bugs.webkit.org/show_bug.cgi?id=52917
  25595. In order to determine whether a rule should apply inside of a shadow DOM subtree,
  25596. we collect three pieces of information:
  25597. 1) Are we parsing UA sheets?
  25598. 2) Does the current tree scope allows applying author sheets?
  25599. 3) Does the rule explicitly reach into shadow DOM (using pseudo-elements, for example)?
  25600. If the answer to all of these is no, we ignore the rule.
  25601. Test: fast/css/shadow-dom-scope.html
  25602. * css/CSSStyleSelector.cpp:
  25603. (WebCore::MatchingUARulesScope::MatchingUARulesScope): Added a scope helper to
  25604. track whether we are currently matching UA rules.
  25605. (WebCore::CSSStyleSelector::matchRulesForList): Added the check for three
  25606. conditions mentioned above.
  25607. (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added
  25608. initializer for the flag, which helps us determine whether the rule
  25609. explicitly reaches into shadow DOM.
  25610. (WebCore::CSSStyleSelector::matchUARules): Started using the scope helper.
  25611. (WebCore::CSSStyleSelector::checkSelector): Added initializing of the
  25612. flag.
  25613. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added setting
  25614. of the flag when we encounter unknown pseudo-elements.
  25615. * css/CSSStyleSelector.h: Adjusted decls.
  25616. * dom/ShadowRoot.cpp:
  25617. (WebCore::ShadowRoot::applyAuthorSheets): Added.
  25618. * dom/ShadowRoot.h: Adjusted decls.
  25619. * dom/TreeScope.cpp:
  25620. (WebCore::TreeScope::applyAuthorSheets): Added.
  25621. * dom/TreeScope.h: Adjusted decls.
  25622. 2011-04-21 Levi Weintraub <leviw@chromium.org>
  25623. Reviewed by Simon Fraser.
  25624. position fixed element does not render properly when dynamically updated via javascript
  25625. https://bugs.webkit.org/show_bug.cgi?id=54297
  25626. Disabling the LayoutState fast-path for fixed-position content.
  25627. Tests: fast/repaint/fixed-contents-changed-after-scroll.html
  25628. fast/repaint/transformed-contents-changed-after-scroll.html
  25629. * rendering/RenderBox.cpp:
  25630. (WebCore::RenderBox::computeRectForRepaint):
  25631. 2011-04-20 Matthew Delaney <mdelaney@apple.com>
  25632. Reviewed by Maciej Stachowiak.
  25633. arc() should add a circle to the path when start and end angles are far enough apart
  25634. https://bugs.webkit.org/show_bug.cgi?id=58934
  25635. Test: fast/canvas/canvas_arc_largeangles.html
  25636. * html/canvas/CanvasRenderingContext2D.cpp:
  25637. (WebCore::CanvasRenderingContext2D::arc):
  25638. 2011-04-20 MORITA Hajime <morrita@google.com>
  25639. Reviewed by Dimitri Glazkov.
  25640. Content of <summary> should be forwarded through the shadow DOM
  25641. https://bugs.webkit.org/show_bug.cgi?id=58914
  25642. - Introduced ShadowContentElement which hosts forwarded children of <summary>
  25643. - Encapsulated Node::parentNodeForRenderingAndStyle() and shouldCreateRendererFor()
  25644. into NodeVisualParentLookupResult class.
  25645. - The parent lookup is also aware of node forwarding. If the visual parent node has
  25646. a shadow root, the node is possibly forwarded to ShadowContentElement
  25647. - ShadowContentElement lookup is implemented inside ShadowRoot.
  25648. Tests: fast/html/details-add-summary-child-1.html
  25649. fast/html/details-add-summary-child-2.html
  25650. fast/html/details-remove-summary-child-1.html
  25651. fast/html/details-remove-summary-child-2.html
  25652. * GNUmakefile.list.am:
  25653. * WebCore.gypi:
  25654. * WebCore.vcproj/WebCore.vcproj:
  25655. * WebCore.xcodeproj/project.pbxproj:
  25656. * dom/Element.cpp:
  25657. (WebCore::Element::childrenChanged):
  25658. * dom/Node.cpp:
  25659. (WebCore::NodeRenderParentDetector::NodeRenderParentDetector):
  25660. (WebCore::NodeRenderParentDetector::parentNodeForRenderingAndStyle):
  25661. (WebCore::NodeRenderParentDetector::findVisualParent):
  25662. (WebCore::NodeRenderParentDetector::shouldCreateRenderer):
  25663. (WebCore::Node::parentNodeForRenderingAndStyle):
  25664. (WebCore::Node::createRendererAndStyle):
  25665. * dom/ShadowRoot.cpp:
  25666. (WebCore::ShadowRoot::contentContainerFor):
  25667. (WebCore::ShadowRoot::hostChildrenChanged):
  25668. (WebCore::ShadowRoot::firstContentElement):
  25669. * dom/ShadowRoot.h:
  25670. * html/HTMLSummaryElement.cpp:
  25671. (WebCore::HTMLSummaryElement::createShadowSubtree):
  25672. * html/HTMLSummaryElement.h:
  25673. * html/shadow/ShadowContentElement.h: Copied from Source/WebCore/dom/ShadowRoot.h.
  25674. (WebCore::ShadowContentElement::ShadowContentElement):
  25675. (WebCore::ShadowContentElement::isShadowBoundary):
  25676. (WebCore::ShadowContentElement::createRenderer):
  25677. (WebCore::ShadowContentElement::create):
  25678. 2011-04-21 Andrey Kosyakov <caseq@chromium.org>
  25679. Reviewed by Pavel Feldman.
  25680. Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
  25681. https://bugs.webkit.org/show_bug.cgi?id=59105
  25682. * inspector/front-end/ConsoleView.js:
  25683. (WebInspector.ConsoleView.prototype._formatobject):
  25684. * inspector/front-end/ExtensionPanel.js:
  25685. (WebInspector.ExtensionSidebarPane.prototype._setObject):
  25686. * inspector/front-end/ResourceJSONView.js:
  25687. (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
  25688. * inspector/front-end/SourceFrame.js:
  25689. (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
  25690. (WebInspector.SourceFrame.prototype._showPopup):
  25691. 2011-04-21 Adam Barth <abarth@webkit.org>
  25692. Remove support for CSP's frame-src. This approach causes too many
  25693. extra console messages to be logged. I'm leaving in the test (which
  25694. now shows failure).
  25695. * html/HTMLFrameElementBase.cpp:
  25696. (WebCore::HTMLFrameElementBase::isURLAllowed):
  25697. 2011-04-21 Eunsol Park <eunsol47.park@samsung.com>
  25698. Reviewed by Antonio Gomes.
  25699. [EFL] Scroll doesn't work on tiled backing store.
  25700. https://bugs.webkit.org/show_bug.cgi?id=55021
  25701. It was added from Changeset 72242, but it worked wrong in EFL port.
  25702. The visible rect should not be returned as content rect for scrolling in EFL tiled backing store,
  25703. because it works differently from QT.
  25704. * platform/ScrollView.cpp:
  25705. (WebCore::ScrollView::visibleContentRect):
  25706. 2011-04-21 Simon Fraser <simon.fraser@apple.com>
  25707. Reviewed by Eric Seidel.
  25708. Create RIAA class for GraphicsContext::save() and restore()
  25709. https://bugs.webkit.org/show_bug.cgi?id=58807
  25710. Use GraphicsContextStateSaver in a lot more places.
  25711. * html/canvas/CanvasRenderingContext2D.cpp:
  25712. (WebCore::CanvasRenderingContext2D::drawImage):
  25713. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  25714. * platform/ScrollView.cpp:
  25715. (WebCore::ScrollView::wheelEvent):
  25716. * platform/graphics/GeneratedImage.cpp:
  25717. (WebCore::GeneratedImage::draw):
  25718. * platform/graphics/GraphicsContext.h:
  25719. (WebCore::GraphicsContextStateSaver::save):
  25720. (WebCore::GraphicsContextStateSaver::restore):
  25721. * platform/graphics/ShadowBlur.cpp:
  25722. (WebCore::ShadowBlur::drawShadowBuffer):
  25723. (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
  25724. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
  25725. (WebCore::ShadowBlur::drawInsetShadowWithTiling):
  25726. (WebCore::ShadowBlur::drawRectShadowWithTiling):
  25727. (WebCore::ShadowBlur::drawLayerPieces):
  25728. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  25729. (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
  25730. * platform/graphics/cg/ImageCG.cpp:
  25731. (WebCore::BitmapImage::draw):
  25732. (WebCore::Image::drawPattern):
  25733. * platform/graphics/cg/PDFDocumentImage.cpp:
  25734. (WebCore::PDFDocumentImage::draw):
  25735. * platform/graphics/filters/FEComposite.cpp:
  25736. (WebCore::FEComposite::apply):
  25737. * platform/graphics/filters/SourceAlpha.cpp:
  25738. (WebCore::SourceAlpha::apply):
  25739. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  25740. (WebCore::MediaPlayerPrivateQTKit::paint):
  25741. * platform/mac/ScrollbarThemeMac.mm:
  25742. (WebCore::ScrollbarThemeMac::paint):
  25743. * platform/mac/ThemeMac.mm:
  25744. (WebCore::paintCheckbox):
  25745. (WebCore::paintRadio):
  25746. (WebCore::paintStepper):
  25747. * rendering/EllipsisBox.cpp:
  25748. (WebCore::EllipsisBox::paintSelection):
  25749. * rendering/InlineFlowBox.cpp:
  25750. (WebCore::InlineFlowBox::paintFillLayer):
  25751. (WebCore::InlineFlowBox::paintBoxDecorations):
  25752. (WebCore::InlineFlowBox::paintMask):
  25753. * rendering/InlineTextBox.cpp:
  25754. (WebCore::InlineTextBox::paint):
  25755. (WebCore::InlineTextBox::paintSelection):
  25756. (WebCore::InlineTextBox::paintCompositionBackground):
  25757. (WebCore::InlineTextBox::paintDecoration):
  25758. (WebCore::InlineTextBox::paintTextMatchMarker):
  25759. * rendering/RenderBlock.cpp:
  25760. (WebCore::RenderBlock::paintColumnContents):
  25761. (WebCore::RenderBlock::paintSelection):
  25762. * rendering/RenderBox.cpp:
  25763. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  25764. * rendering/RenderBoxModelObject.cpp:
  25765. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  25766. (WebCore::RenderBoxModelObject::paintBorder):
  25767. * rendering/RenderEmbeddedObject.cpp:
  25768. (WebCore::RenderEmbeddedObject::paintReplaced):
  25769. * rendering/RenderFieldset.cpp:
  25770. (WebCore::RenderFieldset::paintBoxDecorations):
  25771. * rendering/RenderFileUploadControl.cpp:
  25772. (WebCore::RenderFileUploadControl::paintObject):
  25773. * rendering/RenderLayer.cpp:
  25774. (WebCore::RenderLayer::paintResizer):
  25775. (WebCore::RenderLayer::paintLayer):
  25776. (WebCore::RenderLayer::paintChildLayerIntoColumns):
  25777. * rendering/RenderListMarker.cpp:
  25778. (WebCore::RenderListMarker::paint):
  25779. * rendering/RenderMediaControls.cpp:
  25780. (WebCore::RenderMediaControls::paintMediaControlsPart):
  25781. * rendering/RenderTableCell.cpp:
  25782. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  25783. * rendering/RenderTextControl.cpp:
  25784. (WebCore::RenderTextControl::paintPlaceholder):
  25785. * rendering/RenderThemeMac.mm:
  25786. (WebCore::RenderThemeMac::paintMenuList):
  25787. (WebCore::RenderThemeMac::paintMeter):
  25788. (WebCore::RenderThemeMac::paintProgressBar):
  25789. (WebCore::RenderThemeMac::paintMenuListButtonGradients):
  25790. (WebCore::RenderThemeMac::paintMenuListButton):
  25791. (WebCore::RenderThemeMac::paintSliderTrack):
  25792. (WebCore::RenderThemeMac::paintSliderThumb):
  25793. (WebCore::RenderThemeMac::paintSearchField):
  25794. (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
  25795. (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
  25796. (WebCore::RenderThemeMac::paintMediaSliderTrack):
  25797. (WebCore::RenderThemeMac::paintMediaCurrentTime):
  25798. (WebCore::RenderThemeMac::paintMediaTimeRemaining):
  25799. * rendering/mathml/RenderMathMLBlock.cpp:
  25800. (WebCore::RenderMathMLBlock::paint):
  25801. * rendering/mathml/RenderMathMLFraction.cpp:
  25802. (WebCore::RenderMathMLFraction::paint):
  25803. * rendering/mathml/RenderMathMLRoot.cpp:
  25804. (WebCore::RenderMathMLRoot::paint):
  25805. * rendering/mathml/RenderMathMLSquareRoot.cpp:
  25806. (WebCore::RenderMathMLSquareRoot::paint):
  25807. * rendering/svg/RenderSVGContainer.cpp:
  25808. (WebCore::RenderSVGContainer::paint):
  25809. * rendering/svg/RenderSVGForeignObject.cpp:
  25810. (WebCore::RenderSVGForeignObject::paint):
  25811. * rendering/svg/RenderSVGImage.cpp:
  25812. (WebCore::RenderSVGImage::paint):
  25813. * rendering/svg/RenderSVGPath.cpp:
  25814. (WebCore::RenderSVGPath::fillAndStrokePath):
  25815. (WebCore::RenderSVGPath::paint):
  25816. * rendering/svg/RenderSVGResourceClipper.cpp:
  25817. (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  25818. * rendering/svg/RenderSVGResourceMarker.cpp:
  25819. (WebCore::RenderSVGResourceMarker::draw):
  25820. * rendering/svg/RenderSVGText.cpp:
  25821. (WebCore::RenderSVGText::paint):
  25822. * rendering/svg/SVGInlineFlowBox.cpp:
  25823. (WebCore::SVGInlineFlowBox::paint):
  25824. * rendering/svg/SVGInlineTextBox.cpp:
  25825. (WebCore::SVGInlineTextBox::paintSelectionBackground):
  25826. (WebCore::SVGInlineTextBox::paint):
  25827. (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  25828. * rendering/svg/SVGRootInlineBox.cpp:
  25829. (WebCore::SVGRootInlineBox::paint):
  25830. * svg/SVGFont.cpp:
  25831. (WebCore::Font::drawTextUsingSVGFont):
  25832. * svg/graphics/SVGImage.cpp:
  25833. (WebCore::SVGImage::draw):
  25834. 2011-04-20 Andrey Kosyakov <caseq@chromium.org>
  25835. Reviewed by Pavel Feldman.
  25836. Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
  25837. https://bugs.webkit.org/show_bug.cgi?id=59006
  25838. * inspector/front-end/ExtensionPanel.js:
  25839. (WebInspector.ExtensionSidebarPane.prototype.setExpression):
  25840. 2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
  25841. Reviewed by Dirk Schulze.
  25842. Split SVGGlyphIdentifier class out of SVGGlyphElement.h
  25843. https://bugs.webkit.org/show_bug.cgi?id=59101
  25844. Move SVGGlyphIdentifier class out of SVGGlyphElement.h, place it in platform/graphics/SVGGlyph.h
  25845. and rename the contained struct to SVGGlyph. It will be used in follow-up patches that will integrate SVGGlyph & GlyphPage.
  25846. Several utility functions are moved from SVGFont.cpp to SVGGlyph.cpp, as that's the place where they really belong to.
  25847. Renamed nameLength to unicodeStringLength in the SVGGlyph struct for clarity.
  25848. * Android.mk: Add SVGGlyph.cpp/h to build.
  25849. * CMakeLists.txt: Ditto.
  25850. * GNUmakefile.list.am: Ditto.
  25851. * WebCore.gypi: Ditto.
  25852. * WebCore.pro: Ditto.
  25853. * WebCore.vcproj/WebCore.vcproj: Ditto.
  25854. * WebCore.xcodeproj/project.pbxproj: Ditto.
  25855. * platform/graphics/SVGGlyph.cpp: Copied from svg/SVGFont.cpp. Removed everything except the methods listed below, that belong here.
  25856. (WebCore::processArabicFormDetection):
  25857. (WebCore::charactersWithArabicForm):
  25858. (WebCore::isCompatibleArabicForm):
  25859. (WebCore::isCompatibleGlyph):
  25860. * platform/graphics/SVGGlyph.h: Copied from svg/SVGGlyphElement.h. Renamed SVGGlyphIdentifier to SVGGlyph.
  25861. (WebCore::SVGGlyph::SVGGlyph):
  25862. (WebCore::SVGGlyph::operator==):
  25863. * platform/graphics/SimpleFontData.cpp: Adapt for SVGGlyphIdentifier -> SVGGlyph and nameLength -> unicodeStringLength rename.
  25864. (WebCore::SimpleFontData::SimpleFontData):
  25865. * svg/SVGFont.cpp: Ditto. Remove helper functions that are now living in SVGGlyph.cpp
  25866. (WebCore::SVGTextRunWalker::walk):
  25867. (WebCore::floatWidthUsingSVGFontCallback):
  25868. (WebCore::drawTextUsingSVGFontCallback):
  25869. (WebCore::drawTextMissingGlyphCallback):
  25870. (WebCore::Font::drawTextUsingSVGFont):
  25871. * svg/SVGFontElement.cpp: Ditto.
  25872. (WebCore::SVGFontElement::getGlyphIdentifiersForString):
  25873. * svg/SVGFontElement.h: Ditto.
  25874. * svg/SVGGlyphElement.cpp: Ditto.
  25875. (WebCore::parseArabicForm):
  25876. (WebCore::parseOrientation):
  25877. (WebCore::SVGGlyphElement::inheritUnspecifiedAttributes):
  25878. (WebCore::parseSVGGlyphAttribute):
  25879. (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier):
  25880. (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  25881. * svg/SVGGlyphElement.h: Ditto.
  25882. * svg/SVGGlyphMap.h: Ditto.
  25883. (WebCore::SVGGlyphMap::add):
  25884. (WebCore::SVGGlyphMap::compareGlyphPriority):
  25885. (WebCore::SVGGlyphMap::get):
  25886. 2011-04-21 Eric Carlson <eric.carlson@apple.com>
  25887. Reviewed by Dan Bernstein.
  25888. Live streams won't play with AVFoundation backend
  25889. https://bugs.webkit.org/show_bug.cgi?id=58961
  25890. rdar://problem/9284748
  25891. Tested manually because we don't have any live streams to test in DRT.
  25892. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  25893. (WebCore::MediaPlayerPrivateAVFoundation::seek): Do nothing when asked to seek to the
  25894. current time.
  25895. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): If the readyState is HaveEnoughData,
  25896. don't revert when the new state is "ready to play" or "buffer full".
  25897. (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Use new convenience function isLiveStream.
  25898. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  25899. (WebCore::MediaPlayerPrivateAVFoundation::isLiveStream): New.
  25900. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  25901. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't use AVAsset's
  25902. tracksWithMediaCharacteristic because it doesn't give us what we need with live
  25903. streams.
  25904. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  25905. Reviewed by Yury Semikhatsky.
  25906. Web Inspector: Cookies section in empty on page re-launch.
  25907. https://bugs.webkit.org/show_bug.cgi?id=59095
  25908. * inspector/front-end/ResourcesPanel.js:
  25909. (WebInspector.ResourcesPanel.prototype._reset):
  25910. (WebInspector.ResourcesPanel.prototype._frameNavigated):
  25911. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  25912. Reviewed by Yury Semikhatsky.
  25913. Web Inspector: rename De-obfuscate to Pretty print.
  25914. https://bugs.webkit.org/show_bug.cgi?id=59093
  25915. * English.lproj/localizedStrings.js:
  25916. * inspector/front-end/SourceFrame.js:
  25917. (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
  25918. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  25919. Reviewed by Yury Semikhatsky.
  25920. Web Inspector: following Image URL link in the network panel does nothing.
  25921. https://bugs.webkit.org/show_bug.cgi?id=59092
  25922. * inspector/front-end/ImageView.js:
  25923. (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
  25924. (WebInspector.ImageView.prototype._createContentIfNeeded):
  25925. * inspector/front-end/inspector.js:
  25926. (WebInspector.linkifyURLAsNode):
  25927. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  25928. Reviewed by Yury Semikhatsky.
  25929. Web Inspector: implement Go To Line for network panel.
  25930. https://bugs.webkit.org/show_bug.cgi?id=59090
  25931. * inspector/front-end/GoToLineDialog.js:
  25932. (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
  25933. * inspector/front-end/NetworkItemView.js:
  25934. (WebInspector.NetworkItemView.prototype._tabSelected):
  25935. (WebInspector.NetworkItemView.prototype._installHighlightSupport):
  25936. * inspector/front-end/NetworkPanel.js:
  25937. (WebInspector.NetworkPanel):
  25938. * inspector/front-end/TabbedPane.js:
  25939. (WebInspector.TabbedPane.prototype.appendTab):
  25940. (WebInspector.TabbedPane.prototype.selectTab):
  25941. * inspector/front-end/TextViewer.js:
  25942. (WebInspector.TextViewer.prototype.highlightLine):
  25943. 2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
  25944. Reviewed by Dirk Schulze.
  25945. Split GlyphPage from GlyphPageTreeNode.h into its own header
  25946. https://bugs.webkit.org/show_bug.cgi?id=59096
  25947. * GNUmakefile.list.am: Add GlyphPage.h to build.
  25948. * WebCore.gypi: Ditto.
  25949. * WebCore.vcproj/WebCore.vcproj: Ditto.
  25950. * WebCore.xcodeproj/project.pbxproj: Ditto.
  25951. * platform/graphics/GlyphPage.h: Copied from platform/graphics/GlyphPageTreeNode.h. Removed GlyphPageTreeNode class, leaving only GlyphPage.
  25952. * platform/graphics/GlyphPageTreeNode.h: Removed GlyphPage class.
  25953. 2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
  25954. Reviewed by Dirk Schulze.
  25955. Centralize typedef unsigned short Glyph in Glyph.h
  25956. https://bugs.webkit.org/show_bug.cgi?id=59087
  25957. * GNUmakefile.list.am: Add Glyph.h to build.
  25958. * WebCore.gypi: Ditto.
  25959. * WebCore.vcproj/WebCore.vcproj: Ditto.
  25960. * WebCore.xcodeproj/project.pbxproj: Ditto.
  25961. * platform/graphics/Glyph.h: Added.
  25962. * platform/graphics/GlyphBuffer.h: Include Glyph.h instead of duplicating the Glyph typedef.
  25963. * platform/graphics/GlyphMetricsMap.h: Ditto.
  25964. * platform/graphics/GlyphPageTreeNode.h: Ditto.
  25965. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  25966. Reviewed by Yury Semikhatsky.
  25967. Web Inspector: toolbar background is blank on Mac Chromium port.
  25968. https://bugs.webkit.org/show_bug.cgi?id=59089
  25969. * inspector/front-end/inspector.css:
  25970. (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):
  25971. 2011-04-21 Pavel Feldman <pfeldman@chromium.org>
  25972. Reviewed by Yury Semikhatsky.
  25973. Web Inspector: add support for Go To Line in Resources panel.
  25974. https://bugs.webkit.org/show_bug.cgi?id=59077
  25975. * inspector/front-end/CallStackSidebarPane.js:
  25976. (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  25977. * inspector/front-end/GoToLineDialog.js:
  25978. (WebInspector.GoToLineDialog.show):
  25979. (WebInspector.GoToLineDialog.createShortcut):
  25980. (WebInspector.GoToLineDialog.prototype._onKeyDown):
  25981. * inspector/front-end/NetworkPanel.js:
  25982. (WebInspector.NetworkPanel.prototype.handleShortcut):
  25983. * inspector/front-end/Panel.js:
  25984. (WebInspector.Panel):
  25985. (WebInspector.Panel.prototype._restoreScrollPositions):
  25986. (WebInspector.Panel.prototype.handleShortcut):
  25987. (WebInspector.Panel.prototype.registerShortcuts):
  25988. (WebInspector.Panel.prototype._showGoToLineDialog):
  25989. * inspector/front-end/ProfilesPanel.js:
  25990. (WebInspector.ProfilesPanel.prototype.handleShortcut):
  25991. * inspector/front-end/ResourcesPanel.js:
  25992. (WebInspector.ResourcesPanel):
  25993. * inspector/front-end/ScriptsPanel.js:
  25994. (WebInspector.ScriptsPanel.prototype._registerShortcuts):
  25995. (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
  25996. * inspector/front-end/inspector.js:
  25997. (WebInspector._registerShortcuts):
  25998. (WebInspector.documentKeyDown):
  25999. 2011-04-21 Pavel Feldman <pfeldman@google.com>
  26000. Reviewed by Yury Semikhatsky.
  26001. Web Inspector: persist local resource history between inspector / browser launches.
  26002. https://bugs.webkit.org/show_bug.cgi?id=58993
  26003. * inspector/front-end/Resource.js:
  26004. (WebInspector.Resource.prototype._restoreRevisions):
  26005. 2011-04-20 Alexander Pavlov <apavlov@chromium.org>
  26006. Reviewed by Pavel Feldman.
  26007. Web Inspector: Metrics pane editing and visual feedback improvements
  26008. https://bugs.webkit.org/show_bug.cgi?id=58992
  26009. Added visual feedback when hovering over the box model components of the Metrics pane
  26010. and handling of the [Page]Up/Down keys when editing the box model values.
  26011. * inspector/DOMNodeHighlighter.cpp:
  26012. (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  26013. * inspector/DOMNodeHighlighter.h:
  26014. * inspector/Inspector.json:
  26015. * inspector/InspectorDOMAgent.cpp:
  26016. (WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
  26017. (WebCore::InspectorDOMAgent::highlight):
  26018. (WebCore::InspectorDOMAgent::highlightDOMNode):
  26019. (WebCore::InspectorDOMAgent::highlightFrame):
  26020. (WebCore::InspectorDOMAgent::drawNodeHighlight):
  26021. * inspector/InspectorDOMAgent.h:
  26022. * inspector/front-end/CSSStyleModel.js:
  26023. (WebInspector.CSSProperty.prototype.setText.callback):
  26024. (WebInspector.CSSProperty.prototype.setText):
  26025. (WebInspector.CSSProperty.prototype.setValue):
  26026. (WebInspector.CSSProperty.prototype.setDisabled.callback):
  26027. (WebInspector.CSSProperty.prototype.setDisabled):
  26028. * inspector/front-end/ElementsPanel.js:
  26029. (WebInspector.ElementsPanel.prototype.startEditingStyle):
  26030. (WebInspector.ElementsPanel.prototype.endEditingStyle):
  26031. (WebInspector.ElementsPanel.prototype._attributesUpdated):
  26032. * inspector/front-end/MetricsSidebarPane.js:
  26033. (WebInspector.MetricsSidebarPane):
  26034. (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
  26035. (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.getBoxRectangleElement):
  26036. (WebInspector.MetricsSidebarPane.prototype._update.createBoxPartElement):
  26037. (WebInspector.MetricsSidebarPane.prototype._update):
  26038. (WebInspector.MetricsSidebarPane.prototype.startEditing):
  26039. (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
  26040. (WebInspector.MetricsSidebarPane.prototype.editingEnded):
  26041. (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
  26042. (WebInspector.MetricsSidebarPane.prototype._applyUserInput.callback):
  26043. (WebInspector.MetricsSidebarPane.prototype._applyUserInput):
  26044. (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  26045. * inspector/front-end/StylesSidebarPane.js:
  26046. (WebInspector.StylesSidebarPane.alteredFloatNumber):
  26047. (WebInspector.StylesSidebarPane.alteredHexNumber):
  26048. (WebInspector.StylePropertyTreeElement.prototype):
  26049. (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
  26050. * inspector/front-end/inspector.css:
  26051. (.metrics .hovered > .label):
  26052. (.metrics .position):
  26053. (.metrics .margin):
  26054. (.metrics .margin.hovered):
  26055. (.metrics .border):
  26056. (.metrics .border.hovered):
  26057. (.metrics .padding):
  26058. (.metrics .padding.hovered):
  26059. (.metrics .content):
  26060. (.metrics .content.hovered):
  26061. * inspector/front-end/inspector.js:
  26062. (WebInspector.highlightDOMNode):
  26063. 2011-04-21 Adam Barth <abarth@webkit.org>
  26064. Reviewed by Eric Seidel.
  26065. CSP report-uri is missing
  26066. https://bugs.webkit.org/show_bug.cgi?id=58639
  26067. Our implementation of report-uri differs from what's currently in the
  26068. spec. I sent the working group an email explaining why. Generally,
  26069. we're using normal form encoding instead of JSON and we're sending less
  26070. information to a wider set of URLs. Specifically, we send the current
  26071. document's URL as well as the directive that was violated. The spec
  26072. (currently) tells us to send the raw HTTP headers and the URL that
  26073. caused the violation, but both of these pieces of data could contain
  26074. information that's sensitive, so we omit them for now.
  26075. Test: http/tests/security/contentSecurityPolicy/report-uri.html
  26076. * loader/PingLoader.cpp:
  26077. (WebCore::PingLoader::reportContentSecurityPolicyViolation):
  26078. * loader/PingLoader.h:
  26079. * page/ContentSecurityPolicy.cpp:
  26080. (WebCore::CSPDirective::CSPDirective):
  26081. (WebCore::CSPDirective::text):
  26082. (WebCore::ContentSecurityPolicy::reportViolation):
  26083. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  26084. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  26085. (WebCore::ContentSecurityPolicy::allowInlineScript):
  26086. (WebCore::ContentSecurityPolicy::allowEval):
  26087. (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  26088. (WebCore::ContentSecurityPolicy::allowObjectFromSource):
  26089. (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
  26090. (WebCore::ContentSecurityPolicy::allowImageFromSource):
  26091. (WebCore::ContentSecurityPolicy::allowStyleFromSource):
  26092. (WebCore::ContentSecurityPolicy::allowFontFromSource):
  26093. (WebCore::ContentSecurityPolicy::allowMediaFromSource):
  26094. (WebCore::ContentSecurityPolicy::parseReportURI):
  26095. (WebCore::ContentSecurityPolicy::addDirective):
  26096. * page/ContentSecurityPolicy.h:
  26097. 2011-04-21 Jon Lee <jonlee@apple.com>
  26098. Reviewed by Maciej Stachowiak.
  26099. remove unneeded function from graphicscontext3d.cpp (59076)
  26100. https://bugs.webkit.org/show_bug.cgi?id=59076
  26101. <rdar://problem/9315681>
  26102. * platform/graphics/GraphicsContext3D.cpp: removing unused function unpackOneRowOfRGBA8ToRGBA8
  26103. 2011-04-21 Alexey Proskuryakov <ap@apple.com>
  26104. Reviewed by Dan Bernstein.
  26105. REGRESSION: Korean encoding alias KSC5601 does not work
  26106. https://bugs.webkit.org/show_bug.cgi?id=59075
  26107. <rdar://problem/9303233>
  26108. * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Added a
  26109. KSC5601 alias for KSC_5601, which effectively makes it windows-949.
  26110. 2011-04-20 Dominic Cooney <dominicc@chromium.org>
  26111. Reviewed by Dimitri Glazkov.
  26112. layoutTestController can create and destroy shadow DOM
  26113. https://bugs.webkit.org/show_bug.cgi?id=59058
  26114. Test: fast/dom/shadow/layout-tests-can-access-shadow.html
  26115. * WebCore.exp.in: Mac DRT needs to see Element::ensure/removeShadowRoot
  26116. 2011-04-20 Pratik Solanki <psolanki@apple.com>
  26117. Reviewed by Ryosuke Niwa.
  26118. Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
  26119. Fix assertions in Chromium builds.
  26120. * platform/graphics/Image.cpp:
  26121. (WebCore::Image::drawTiled): Skia and Wx do not have proper implementations of
  26122. BitmapImage::checkForSolidColor() so we shouldn't assert on those platforms.
  26123. 2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  26124. Reviewed by Eric Seidel.
  26125. [EFL] Add timeline to mediaControlsEfl.css
  26126. https://bugs.webkit.org/show_bug.cgi?id=58865
  26127. Add timeline to mediaControlsEfl.css in order to show playing time of media
  26128. content.
  26129. * css/mediaControlsEfl.css:
  26130. (audio):
  26131. (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
  26132. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
  26133. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
  26134. (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
  26135. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  26136. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  26137. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
  26138. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
  26139. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
  26140. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  26141. 2011-04-20 Simon Fraser <simon.fraser@apple.com>
  26142. Reviewed by Eric Seidel.
  26143. Create RIAA class for GraphicsContext::save() and restore()
  26144. https://bugs.webkit.org/show_bug.cgi?id=58807
  26145. Make a stack-based class that can be used to save and restore
  26146. the graphics state. It has conditional behavior to deal with the many cases
  26147. where we decide to save/restore based on some runtime condition.
  26148. Change RenderBoxModelObject to use it for now; it can be used more widely
  26149. once committed.
  26150. * platform/graphics/GraphicsContext.h:
  26151. (WebCore::GraphicsContextStateSaver::GraphicsContextStateSaver):
  26152. (WebCore::GraphicsContextStateSaver::~GraphicsContextStateSaver):
  26153. (WebCore::GraphicsContextStateSaver::saveState):
  26154. * rendering/RenderBoxModelObject.cpp:
  26155. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  26156. (WebCore::RenderBoxModelObject::paintOneBorderSide):
  26157. (WebCore::RenderBoxModelObject::paintBorder):
  26158. (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
  26159. (WebCore::RenderBoxModelObject::paintBoxShadow):
  26160. 2011-04-20 Adam Barth <abarth@webkit.org>
  26161. Reviewed by Eric Seidel.
  26162. CSP frame-src is missing
  26163. https://bugs.webkit.org/show_bug.cgi?id=58643
  26164. This is a first cut at an implementation of frame-src. There are a
  26165. couple things that will need to be improved:
  26166. 1) I don't think we're handling in-frame navigation properly. This
  26167. patch only covers setting the src attribute of the frame, but I
  26168. think the intent of the spec is to cover navigation as well.
  26169. 2) The console message is printed twice, once when we try to load the
  26170. frame and again when we attach the frame to the render tree.
  26171. I'll file bugs about these issues (blocking
  26172. https://bugs.webkit.org/show_bug.cgi?id=53572) once this patch lands.
  26173. Tests: http/tests/security/contentSecurityPolicy/frame-src-allowed.html
  26174. http/tests/security/contentSecurityPolicy/frame-src-blocked.html
  26175. * html/HTMLFrameElementBase.cpp:
  26176. (WebCore::HTMLFrameElementBase::isURLAllowed):
  26177. * page/ContentSecurityPolicy.cpp:
  26178. (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
  26179. (WebCore::ContentSecurityPolicy::addDirective):
  26180. * page/ContentSecurityPolicy.h:
  26181. 2011-04-20 Jia Pu <jpu@apple.com>
  26182. Reviewed by Maciej Stachowiak.
  26183. [Mac] Correction panel shows up at incorrect location after webpage is scrolled.
  26184. https://bugs.webkit.org/show_bug.cgi?id=59052
  26185. <rdar://problem/9312513>
  26186. Fixed a regression caused by interaction between patch for bug 57353 and patch for bug 55571.
  26187. See bug webpage for detail.
  26188. * editing/Editor.cpp:
  26189. (WebCore::Editor::selectionStartHasMarkerFor):
  26190. * editing/SpellingCorrectionController.cpp:
  26191. (WebCore::SpellingCorrectionController::windowRectForRange):
  26192. 2011-04-20 Adam Barth <abarth@webkit.org>
  26193. Reviewed by Eric Seidel.
  26194. CSP policy violations should log to the console
  26195. https://bugs.webkit.org/show_bug.cgi?id=58646
  26196. We now log policy violations to the JavaScript console to help
  26197. developers debug what's going on with their Content-Security-Policy.
  26198. Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
  26199. http/tests/security/contentSecurityPolicy/javascript-url-allowed.html
  26200. http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
  26201. http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
  26202. http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
  26203. http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html
  26204. http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html
  26205. http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html
  26206. * dom/Document.cpp:
  26207. (WebCore::Document::initSecurityContext):
  26208. * page/ContentSecurityPolicy.cpp:
  26209. (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
  26210. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  26211. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  26212. (WebCore::ContentSecurityPolicy::allowInlineScript):
  26213. (WebCore::ContentSecurityPolicy::allowEval):
  26214. (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  26215. (WebCore::ContentSecurityPolicy::allowObjectFromSource):
  26216. (WebCore::ContentSecurityPolicy::allowImageFromSource):
  26217. (WebCore::ContentSecurityPolicy::allowStyleFromSource):
  26218. (WebCore::ContentSecurityPolicy::allowFontFromSource):
  26219. (WebCore::ContentSecurityPolicy::allowMediaFromSource):
  26220. (WebCore::ContentSecurityPolicy::addDirective):
  26221. * page/ContentSecurityPolicy.h:
  26222. (WebCore::ContentSecurityPolicy::create):
  26223. 2011-04-20 Dan Bernstein <mitz@apple.com>
  26224. Reviewed by Maciej Stachowiak.
  26225. <rdar://problem/9095366> With a non-1 page scale, scrolling to reveal selection fails
  26226. https://bugs.webkit.org/show_bug.cgi?id=59046
  26227. Test: fast/transforms/selection-bounds-in-transformed-view.html
  26228. * rendering/RenderObject.cpp:
  26229. (WebCore::RenderObject::repaintUsingContainer): If the repaint container is the RenderView, and
  26230. it has a composited layer that paints straight to the window, then translate from view coordinates
  26231. to window coordinates here.
  26232. * rendering/RenderView.cpp:
  26233. (WebCore::RenderView::mapLocalToContainer): Do not apply our transform if we are the painting root.
  26234. (WebCore::RenderView::computeRectForRepaint): Ditto. Applying the transform here was compensating
  26235. for not applying it in RenderObject::repaintUsingContainer(), but for purposes other than repainting,
  26236. such as computing selection bounds, this function was returning the wrong results.
  26237. 2011-04-20 Dan Bernstein <mitz@apple.com>
  26238. Reviewed by Eric Carlson.
  26239. <rdar://problem/9304956> media/broken-video.html crashes
  26240. * platform/graphics/MediaPlayer.cpp:
  26241. (WebCore::nextMediaEngine): Fixed an off-by-one error.
  26242. 2011-04-20 Eric Seidel <eric@webkit.org>
  26243. Reviewed by Adam Barth.
  26244. Split out isIteratorTarget from bidiNext and bidiFirst
  26245. https://bugs.webkit.org/show_bug.cgi?id=59033
  26246. This is the first (tiny) step of many. When I tried to
  26247. make larger changes to this function I broke stuff, so
  26248. doing this in tiny pieces so we know it's right.
  26249. * rendering/InlineIterator.h:
  26250. (WebCore::isIteratorTarget):
  26251. (WebCore::bidiNext):
  26252. (WebCore::bidiFirstSkippingInlines):
  26253. (WebCore::bidiFirstNotSkippingInlines):
  26254. 2011-04-20 Alexey Marinichev <amarinichev@chromium.org>
  26255. Reviewed by Kenneth Russell.
  26256. Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
  26257. https://bugs.webkit.org/show_bug.cgi?id=59045
  26258. Lose context extension test might not catch this bug, more reliable
  26259. way is forcing the crash of the GPU process, which is done by Chromium
  26260. browser tests.
  26261. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  26262. (WebCore::WebGLLayerChromium::updateCompositorResources):
  26263. (WebCore::WebGLLayerChromium::setContext):
  26264. * platform/graphics/chromium/WebGLLayerChromium.h:
  26265. 2011-04-20 Jia Pu <jpu@apple.com>
  26266. Reviewed by Maciej Stachowiak.
  26267. [Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
  26268. https://bugs.webkit.org/show_bug.cgi?id=59032
  26269. <rdar://problem/9312444>
  26270. This fixes a regression introduced in recent refactoring work in Editor. See bug webpage for detail.
  26271. manual test: Source/WebCore/manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html
  26272. * editing/Editor.cpp:
  26273. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  26274. * manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html: Added.
  26275. 2011-04-20 Chris Fleizach <cfleizach@apple.com>
  26276. Reviewed by Beth Dakin.
  26277. CrashTracer: 301 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityRenderObject::visiblePositionForPoint const + 297
  26278. https://bugs.webkit.org/show_bug.cgi?id=57405
  26279. The offending line in this crash was a null pointer access in
  26280. m_renderer->document()->topDocument()->renderer()->view()->frameView();
  26281. It seems likely that one of those calls was invalid. I could not reproduce and there was no
  26282. information on reproducible steps, hence the absence of a layout test.
  26283. * accessibility/AccessibilityRenderObject.cpp:
  26284. (WebCore::AccessibilityRenderObject::topRenderer):
  26285. (WebCore::AccessibilityRenderObject::topDocument):
  26286. (WebCore::AccessibilityRenderObject::topDocumentFrameView):
  26287. (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  26288. * accessibility/AccessibilityRenderObject.h:
  26289. 2011-04-20 Andy Estes <aestes@apple.com>
  26290. Reviewed by Maciej Stachowiak.
  26291. REGRESSION (WK2): Animated GIF stops when navigating forward, back
  26292. https://bugs.webkit.org/show_bug.cgi?id=59042
  26293. When loading the page from the b/f cache,
  26294. document()->view()->isOffscreen() returns true in
  26295. RenderObject::willRenderImage(), so BitmapImage::startAnimation()
  26296. returns without actually kicking off the animation.
  26297. In WebKit1, the ScrollView is a platform widget, so
  26298. ScrollView::isOffscreen() calls [NSWindow isVisible]. In WebKit2, the
  26299. ScrollView isn't a platform widget so it asks the WebCore Widget
  26300. whether or not it is visible. It always returns false since
  26301. setParentVisible(false) was called on the old ScrollView before
  26302. navigating to a new page, but setParentVisible(true) is never called
  26303. when restoring it from the back/forward cache. This is probably a
  26304. long-standing bug.
  26305. Fix this by calling setParentVisible(true) when a cached main frame is
  26306. being restored.
  26307. Test: fast/images/animated-gif-restored-from-bfcache.html
  26308. * history/CachedFrame.cpp:
  26309. (WebCore::CachedFrameBase::restore): If the cached frame is the main
  26310. frame, call setParentVisible(true) on the frame's view.
  26311. 2011-04-20 Sam Weinig <sam@webkit.org>
  26312. Reviewed by Anders Carlsson.
  26313. WebKit2: Can't scroll page after printing on Yahoo.com and other sites
  26314. <rdar://problem/9233291>
  26315. https://bugs.webkit.org/show_bug.cgi?id=59049
  26316. * page/Frame.cpp:
  26317. (WebCore::Frame::setPrinting): Match Mac WebKit1 code when ending printing,
  26318. and call forceLayout() instead of forceLayoutForPagination().
  26319. 2011-04-20 Kenneth Russell <kbr@google.com>
  26320. Reviewed by James Robinson.
  26321. Reduce size of GraphicsContext3D's compiled code
  26322. https://bugs.webkit.org/show_bug.cgi?id=59029
  26323. Changed format conversion operations to work line-by-line instead
  26324. of pixel-by-pixel, and passed them as function pointers rather
  26325. than template parameters. Simplified computation of source
  26326. increment, since elements per row is now all that is needed.
  26327. These changes reduce the size of GraphicsContext3D.o in release
  26328. mode on Linux from 299 KB to 53 KB.
  26329. No new tests. Existing layout tests cover these format conversions
  26330. well, and caught one typo in the restructuring. Also ran WebGL
  26331. conformance suite and other demos.
  26332. * platform/graphics/GraphicsContext3D.cpp:
  26333. (WebCore::doUnpackingAndPacking):
  26334. (WebCore::computeSourceElementsPerRow):
  26335. (WebCore::doPacking):
  26336. (WebCore::doFloatingPointPacking):
  26337. (WebCore::GraphicsContext3D::packPixels):
  26338. 2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
  26339. Reviewed by Kent Tamura.
  26340. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
  26341. https://bugs.webkit.org/show_bug.cgi?id=59037
  26342. Test: fast/events/simulated-click-disabled.html
  26343. * dom/EventDispatcher.cpp:
  26344. (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
  26345. 2011-04-20 Eric Seidel <eric@webkit.org>
  26346. Reviewed by Ryosuke Niwa.
  26347. Split bidiFirst into two functions
  26348. https://bugs.webkit.org/show_bug.cgi?id=59025
  26349. I don't have a full understanding of the skipInlines case yet
  26350. (hence it's not as pretty as the non-skipping case), but
  26351. this is clearly a win, as both functions are much simpler
  26352. than their combined version.
  26353. Both of these functions still have bad names. However the
  26354. bidiNext/bidiFirst names date all the way back to revision 1
  26355. of the WebKit repository. :) So I don't feel too bad keeping
  26356. them for the moment.
  26357. * rendering/InlineIterator.h:
  26358. (WebCore::bidiNext):
  26359. (WebCore::bidiFirstSkippingInlines):
  26360. (WebCore::bidiFirstNotSkippingInlines):
  26361. * rendering/RenderBlock.cpp:
  26362. (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  26363. * rendering/RenderBlockLineLayout.cpp:
  26364. (WebCore::RenderBlock::layoutInlineChildren):
  26365. (WebCore::RenderBlock::determineStartPosition):
  26366. 2011-04-20 Jia Pu <jpu@apple.com>
  26367. Reviewed by Adele Peterson.
  26368. [Mac] Like autocorrection, other types of substitution need to respect undo.
  26369. https://bugs.webkit.org/show_bug.cgi?id=59009
  26370. <rdar://problem/8601537>
  26371. Similar to autocorrection, we use SpellingCorrectionCommand to carry out other types of text substitution, so that
  26372. if user undoes the substitution, it will not be applied again. For CreateLinkCommand, we add marker when it's undone
  26373. so that we won't automatically add link again.
  26374. * editing/CreateLinkCommand.h:
  26375. (WebCore::CreateLinkCommand::isCreateLinkCommand):
  26376. * editing/EditCommand.cpp:
  26377. (WebCore::EditCommand::isCreateLinkCommand):
  26378. * editing/EditCommand.h:
  26379. * editing/Editor.cpp:
  26380. (WebCore::Editor::unappliedEditing):
  26381. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  26382. * editing/SpellingCorrectionController.cpp:
  26383. (WebCore::SpellingCorrectionController::respondToAppliedEditing):
  26384. (WebCore::SpellingCorrectionController::respondToUnappliedEditing):
  26385. * editing/SpellingCorrectionController.h:
  26386. (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  26387. 2011-04-20 Steve Lacey <sjl@chromium.org>
  26388. Reviewed by Eric Carlson.
  26389. [chromium] Move Chromium media controls into own root element.
  26390. https://bugs.webkit.org/show_bug.cgi?id=59018
  26391. No new tests as there is no functional change
  26392. * WebCore.gypi:
  26393. * css/mediaControlsChromium.css:
  26394. (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
  26395. * html/shadow/MediaControlRootElementChromium.cpp: Added.
  26396. Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
  26397. * html/shadow/MediaControlRootElementChromium.h: Added.
  26398. 2011-04-20 Charlie Lee <chocobo@chromium.org>
  26399. Reviewed by Dirk Schulze.
  26400. LEFilter change doesn't compile on ARM neon targets
  26401. https://bugs.webkit.org/show_bug.cgi?id=58671
  26402. Build fix for Chromium ARM/NEON platform. Added platform/graphics/filters/arm directory to build system.
  26403. * WebCore.gyp/WebCore.gyp:
  26404. 2011-04-20 Xiaomei Ji <xji@chromium.org>
  26405. Reviewed by Ryosuke Niwa.
  26406. Continue (3rd) experiment with moving caret by word in visual order.
  26407. https://bugs.webkit.org/show_bug.cgi?id=58294
  26408. This patch along with r82588 and r83483 implements moving caret by
  26409. word in visual order.
  26410. The overall algorithm is:
  26411. 1. First get the InlineBox and offset of the pass-in VisiblePosition.
  26412. 2. Based on the position (left boundary, middle, right boundary) of the offset and the
  26413. direction of the movement, look for visually adjacent word breaks.
  26414. 2.1 If the offset is the minimum offset of the box,
  26415. return the rightmost word boundary in previous boxes if moving left.
  26416. return the leftmost word boundary in box and next boxes if moving right.
  26417. 2.2 Similar for the case when offset is at the maximum offset of the box.
  26418. 2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
  26419. or nextWordPosition based on the directionality of the box. If this word break position
  26420. is also inside the same box, return it. Otherwise (the nextWordPosition or
  26421. previousWordPosition is not in the same box or is at the box boundary), collect all the
  26422. word breaks in the box and search for the one closest to the input "offset" based on
  26423. box directionality, block directionality, and movement direction. Continue search in
  26424. adjacent boxes if needed.
  26425. Notes:
  26426. 1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
  26427. the input position (in the moving direction) is not available in current box, word
  26428. boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
  26429. word boundaries. Instead, the word boundaries are saved as a pair
  26430. (VisiblePosition, offset) to avoid recomputing VisiblePosition.
  26431. 2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
  26432. and right boundary of a word in RTL block). And word boundaries are collected using
  26433. previousWordPosition() and nextWordPosition(). So when box directionality is the same as
  26434. block directionality, word boundaries are collected from right to left visually in a LTR
  26435. box, and word boundaries are collected from left to right visually in a RTL box. It is
  26436. the other way around when box directionality is different from block directionality.
  26437. 3. To find the right kinds of word boundaries, we must move back and forth between words
  26438. in some situations. For example, if we're moving to the right in a LTR box in LTR block,
  26439. we cannot simply return nextWordPosition() because it would return the right boundary
  26440. of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
  26441. 4. When collecting word breaks inside a box, it first computes a start position, then
  26442. collect the right kind of word breaks until it reaches the end of (or beyond) the box.
  26443. In the meanwhile, it might need special handling on the rightmost or leftmost position
  26444. based on the directionality of the box and block. These computations do not consider the
  26445. box's bidi level.
  26446. * editing/visible_units.cpp:
  26447. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
  26448. (WebCore::collectWordBreaksInBox):
  26449. (WebCore::previousWordBoundaryInBox):
  26450. (WebCore::nextWordBoundaryInBox):
  26451. (WebCore::visuallyLastWordBoundaryInBox):
  26452. (WebCore::leftWordBoundary):
  26453. (WebCore::rightWordBoundary):
  26454. (WebCore::leftWordPosition):
  26455. (WebCore::rightWordPosition):
  26456. 2011-04-20 Cris Neckar <cdn@chromium.org>
  26457. Reviewed by Dirk Schulze.
  26458. Return early when the paint rect and the source rect do not overlap as no bytes need to be copied.
  26459. https://bugs.webkit.org/show_bug.cgi?id=57885
  26460. Test: svg/filters/svg-transform-blur-crash.xhtml
  26461. * platform/graphics/filters/FilterEffect.cpp:
  26462. (WebCore::FilterEffect::copyImageBytes):
  26463. 2011-04-20 Jian Li <jianli@chromium.org>
  26464. Reviewed by Kenneth Russell.
  26465. Support DataView in workers
  26466. https://bugs.webkit.org/show_bug.cgi?id=59014
  26467. Test: fast/canvas/webgl/worker-data-view-test.html
  26468. * workers/WorkerContext.idl: Expose DataView constructor.
  26469. 2011-04-20 Chris Marrin <cmarrin@apple.com>
  26470. Reviewed by Adam Roben.
  26471. REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
  26472. https://bugs.webkit.org/show_bug.cgi?id=57868
  26473. Running CACFAnimations aren't remembered when layer tree is unparented and
  26474. then reparented. Added a new ensureAnimationsSubmitted function to
  26475. PlatformCALayer to traverse the tree and resubmit animations, setting the
  26476. beginTime to the original start time of the animation. This is called in WK2
  26477. when layer tree is newly parented.
  26478. I also consolidated currentTimeToMediaTime into PlatformCALayer so it can be shared
  26479. between PlatformCALayer and GraphicsLayerCA.
  26480. * platform/graphics/ca/GraphicsLayerCA.cpp:
  26481. * platform/graphics/ca/PlatformCAAnimation.h:
  26482. Remember actual animation start time in CACFAnimation beginTime property
  26483. * platform/graphics/ca/PlatformCALayer.h:
  26484. New ensureAnimationsSubmitted function which traverses layers and resubmits all animations
  26485. * platform/graphics/ca/mac/PlatformCALayerMac.mm:
  26486. * platform/graphics/ca/win/PlatformCALayerWin.cpp:
  26487. 2011-04-20 Eric Carlson <eric.carlson@apple.com>
  26488. Reviewed by Dan Bernstein.
  26489. Adopt QTKit API for listing and deleting file in its media cache.
  26490. <rdar://problem/9130029>
  26491. https://bugs.webkit.org/show_bug.cgi?id=58795
  26492. Not possible to test automatically, verified manually.
  26493. * WebCore.exp.in: Export new media download cache functions.
  26494. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  26495. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  26496. (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register cache management functions.
  26497. (WebCore::MediaPlayerPrivateQTKit::getSitesInMediaCache): New, return cache origins.
  26498. (WebCore::MediaPlayerPrivateQTKit::clearMediaCache): New, empty the media cache.
  26499. (WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite): New, delete files in the media
  26500. cache for one origin.
  26501. * platform/mac/WebCoreSystemInterface.h: Add new WKSI functions.
  26502. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  26503. 2011-04-20 Dirk Schulze <krit@webkit.org>
  26504. Reviewed by Simon Fraser.
  26505. SVG feDropShadow implementation of SVG Filters 1.2
  26506. https://bugs.webkit.org/show_bug.cgi?id=52513
  26507. Support different radii for horizontal and vertical blurring in ShadowBlur. This is a preperation for feDropShadow.
  26508. feDropShadow is a new shorthand filter effect for the up-comming Filter 1.0 specification and will use ShadowBlur.
  26509. feGaussianBlur might make use of ShadowBlur as well later (on SourceAlpha input).
  26510. Added ShadowBlur to remaining platforms.
  26511. The changes can't be tested before the changes in feGaussianBlur or feDropShadow. Current behavior is not affected.
  26512. * Android.mk:
  26513. * CMakeLists.txt:
  26514. * GNUmakefile.list.am:
  26515. * WebCore.pro:
  26516. * platform/graphics/FloatSize.h:
  26517. (WebCore::FloatSize::scale):
  26518. * platform/graphics/ShadowBlur.cpp:
  26519. (WebCore::ScratchBuffer::ScratchBuffer):
  26520. (WebCore::ScratchBuffer::setLastShadowValues):
  26521. (WebCore::ScratchBuffer::setLastInsetShadowValues):
  26522. (WebCore::ScratchBuffer::matchesLastShadow):
  26523. (WebCore::ScratchBuffer::matchesLastInsetShadow):
  26524. (WebCore::ScratchBuffer::clearScratchBuffer):
  26525. (WebCore::ShadowBlur::ShadowBlur):
  26526. (WebCore::calculateLobes):
  26527. (WebCore::ShadowBlur::blurLayerImage):
  26528. (WebCore::ShadowBlur::adjustBlurRadius):
  26529. (WebCore::ShadowBlur::calculateLayerBoundingRect):
  26530. (WebCore::computeSliceSizesFromRadii):
  26531. (WebCore::ShadowBlur::templateSize):
  26532. (WebCore::ShadowBlur::drawInsetShadowWithTiling):
  26533. (WebCore::ShadowBlur::drawRectShadowWithTiling):
  26534. (WebCore::ShadowBlur::drawLayerPieces):
  26535. * platform/graphics/ShadowBlur.h:
  26536. * platform/graphics/cg/GraphicsContextCG.cpp:
  26537. (WebCore::GraphicsContext::fillRect):
  26538. (WebCore::GraphicsContext::fillRoundedRect):
  26539. (WebCore::GraphicsContext::fillRectWithRoundedHole):
  26540. 2011-04-19 Roland Steiner <rolandsteiner@chromium.org>
  26541. Reviewed by Dimitri Glazkov.
  26542. Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
  26543. https://bugs.webkit.org/show_bug.cgi?id=52963
  26544. .) Change base class of ShadowRoot from DocumentFragment to TreeScope.
  26545. .) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
  26546. .) Merged setTreeScope() with setTreeScopeRecursively()
  26547. .) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
  26548. .) Adapt JavaScript Node wrappers (temporary code - see https://bugs.webkit.org/show_bug.cgi?id=58704).
  26549. No new tests. (refactoring)
  26550. * bindings/js/JSNodeCustom.cpp:
  26551. (WebCore::createWrapperInline):
  26552. * bindings/v8/custom/V8NodeCustom.cpp:
  26553. (WebCore::toV8Slow):
  26554. * dom/ContainerNode.cpp:
  26555. (WebCore::ContainerNode::takeAllChildrenFrom):
  26556. (WebCore::ContainerNode::removeBetween):
  26557. (WebCore::ContainerNode::removeChildren):
  26558. (WebCore::ContainerNode::parserAddChild):
  26559. * dom/Document.cpp:
  26560. (WebCore::Document::Document):
  26561. (WebCore::Document::~Document):
  26562. (WebCore::Document::setDocType):
  26563. * dom/Element.h:
  26564. * dom/Node.cpp:
  26565. (WebCore::Node::treeScope):
  26566. (WebCore::Node::setTreeScopeRecursively):
  26567. * dom/Node.h:
  26568. (WebCore::Node::document):
  26569. * dom/ShadowRoot.cpp:
  26570. (WebCore::ShadowRoot::ShadowRoot):
  26571. (WebCore::ShadowRoot::~ShadowRoot):
  26572. (WebCore::ShadowRoot::nodeType):
  26573. (WebCore::ShadowRoot::cloneNode):
  26574. (WebCore::ShadowRoot::childTypeAllowed):
  26575. * dom/ShadowRoot.h:
  26576. (WebCore::toShadowRoot):
  26577. * dom/TreeScope.cpp:
  26578. (WebCore::TreeScope::TreeScope):
  26579. (WebCore::TreeScope::setParentTreeScope):
  26580. * dom/TreeScope.h:
  26581. * rendering/RenderSlider.cpp:
  26582. 2011-04-20 Vsevolod Vlasov <vsevik@chromium.org>
  26583. Reviewed by Pavel Feldman.
  26584. Web Inspector: Update front-end files list in WebCore.vcproj
  26585. https://bugs.webkit.org/show_bug.cgi?id=58896
  26586. * WebCore.vcproj/WebCore.vcproj:
  26587. 2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
  26588. Qt build fix after r84380.
  26589. * css/CSSPrimitiveValueMappings.h: Moved EBorderCollapse-related casts from under ENABLE(SVG) guard.
  26590. 2011-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
  26591. Reviewed by Martin Robinson.
  26592. [GTK] Build libWebCore with the gtk sources too
  26593. https://bugs.webkit.org/show_bug.cgi?id=58968
  26594. In some cases webcore files are compiled twice, so it improves the
  26595. build time.
  26596. * GNUmakefile.am: Add webcore gtk sources to libWebCore sources.
  26597. 2011-04-20 Luke Macpherson <macpherson@chromium.org>
  26598. Reviewed by Dimitri Glazkov.
  26599. Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.
  26600. https://bugs.webkit.org/show_bug.cgi?id=58964
  26601. No new tests as no new functionality added.
  26602. * css/CSSPrimitiveValueMappings.h:
  26603. Support casting to/from EBorderCollapse.
  26604. * css/CSSStyleSelector.cpp:
  26605. Use new casting ability to simplify code.
  26606. * rendering/style/RenderStyle.h:
  26607. Use EBorderCollapse instead of a bool for representing border collapse member variable.
  26608. * rendering/style/RenderStyleConstants.h:
  26609. Added EBorderCollapse enum.
  26610. 2011-04-19 Stephen White <senorblanco@chromium.org>
  26611. Reviewed by Kenneth Russell.
  26612. Move and rename GLES2Canvas.
  26613. https://bugs.webkit.org/show_bug.cgi?id=58927
  26614. Move GLES2Canvas to platform/graphcs/gpu, where all the other
  26615. gpu-related files live, and rename it to GraphicsContextGPU to better
  26616. reflect its purpose.
  26617. Covered by existing tests.
  26618. * WebCore.gypi:
  26619. * platform/graphics/chromium/GLES2Canvas.cpp:
  26620. * platform/graphics/chromium/GLES2Canvas.h:
  26621. * platform/graphics/skia/GraphicsContextSkia.cpp:
  26622. (WebCore::GraphicsContext::fillPath):
  26623. (WebCore::GraphicsContext::setPlatformShadow):
  26624. * platform/graphics/skia/ImageBufferSkia.cpp:
  26625. * platform/graphics/skia/ImageSkia.cpp:
  26626. (WebCore::drawBitmapGLES2):
  26627. * platform/graphics/skia/PlatformContextSkia.cpp:
  26628. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  26629. * platform/graphics/skia/PlatformContextSkia.h:
  26630. (WebCore::PlatformContextSkia::gpuCanvas):
  26631. 2011-04-20 Benjamin Poulain <benjamin.poulain@nokia.com>
  26632. Reviewed by Andreas Kling.
  26633. [Qt] Clean the style of our cookie methods
  26634. https://bugs.webkit.org/show_bug.cgi?id=58987
  26635. Got rid of the variables named "u" in favor just converting the url when needed.
  26636. * platform/qt/CookieJarQt.cpp:
  26637. (WebCore::setCookies): The variable p was unused.
  26638. The ::toAscii() depends on the default codec, use toLatin1() instead.
  26639. (WebCore::cookies): foreach() should use const reference.
  26640. (WebCore::cookieRequestHeaderFieldValue):
  26641. 2011-04-19 Mihai Parparita <mihaip@chromium.org>
  26642. Reviewed by Adam Barth.
  26643. ScriptController.h is included in too many places
  26644. https://bugs.webkit.org/show_bug.cgi?id=58963
  26645. Remove ScriptController.h #includes from a bunch of .cpp files where it
  26646. doesn't appear to be necessary.
  26647. * bindings/js/JSCustomPositionCallback.cpp:
  26648. * bindings/js/JSCustomPositionErrorCallback.cpp:
  26649. * bindings/js/JSCustomVoidCallback.cpp:
  26650. * bindings/js/JSCustomXPathNSResolver.cpp:
  26651. * bindings/js/JSDOMWindowBase.cpp:
  26652. * bindings/js/JSDOMWindowShell.cpp:
  26653. * bindings/js/JSDocumentCustom.cpp:
  26654. * bindings/js/ScriptDebugServer.cpp:
  26655. * bindings/v8/NPV8Object.cpp:
  26656. * bindings/v8/ScriptCachedFrameData.cpp:
  26657. * bindings/v8/V8DOMWindowShell.cpp:
  26658. * bindings/v8/V8DOMWrapper.cpp:
  26659. * bindings/v8/V8IsolatedContext.cpp:
  26660. * bindings/v8/V8Proxy.cpp:
  26661. * bindings/v8/custom/V8LocationCustom.cpp:
  26662. * dom/Node.cpp:
  26663. * dom/ScriptElement.cpp:
  26664. * dom/XMLDocumentParser.cpp:
  26665. * dom/XMLDocumentParserQt.cpp:
  26666. * html/HTMLEmbedElement.cpp:
  26667. * html/HTMLObjectElement.cpp:
  26668. * html/HTMLPlugInElement.cpp:
  26669. * html/parser/HTMLConstructionSite.cpp:
  26670. * html/parser/HTMLTreeBuilder.cpp:
  26671. * inspector/InspectorProfilerAgent.cpp:
  26672. * loader/icon/IconDatabase.cpp:
  26673. * page/Chrome.cpp:
  26674. * page/Navigator.cpp:
  26675. * page/Page.cpp:
  26676. * plugins/PluginView.cpp:
  26677. * plugins/gtk/PluginViewGtk.cpp:
  26678. * plugins/qt/PluginViewQt.cpp:
  26679. * plugins/symbian/PluginViewSymbian.cpp:
  26680. * plugins/win/PluginViewWin.cpp:
  26681. * svg/SVGDocumentExtensions.cpp:
  26682. * xml/XMLTreeViewer.cpp:
  26683. 2011-04-20 Pavel Feldman <pfeldman@google.com>
  26684. Reviewed by Yury Semikhatsky.
  26685. Web Inspector: add Save As to the Resources panel context menu.
  26686. https://bugs.webkit.org/show_bug.cgi?id=58983
  26687. * English.lproj/localizedStrings.js:
  26688. * inspector/front-end/ResourcesPanel.js:
  26689. (WebInspector.FrameResourceTreeElement.prototype.onattach):
  26690. (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent.save):
  26691. (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
  26692. (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
  26693. (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  26694. 2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
  26695. Reviewed by Csaba Osztrogonác.
  26696. [Qt] Cleanup includepath adjustment for generated files
  26697. https://bugs.webkit.org/show_bug.cgi?id=58869
  26698. Build cleanup, no new tests.
  26699. * WebCore.pri: Add the directory of generated files to the include path
  26700. with absolute path to make it valid in the final build step. Remove
  26701. unnecessary logic.
  26702. 2011-04-20 Mariusz Grzegorczyk <mariusz.g@samsung.com>
  26703. Reviewed by Andreas Kling.
  26704. [EFL] Initializing m_window member field in PluginView.cpp for efl port
  26705. https://bugs.webkit.org/show_bug.cgi?id=58311
  26706. No new tests needed: only initializing class member.
  26707. * plugins/PluginView.cpp:
  26708. (WebCore::PluginView::PluginView):
  26709. 2011-04-20 Pavel Feldman <pfeldman@google.com>
  26710. Not reviewed: fix Leopard compile.
  26711. * inspector/InspectorFrontendClient.h:
  26712. * inspector/InspectorFrontendClientLocal.h:
  26713. (WebCore::InspectorFrontendClientLocal::saveAs):
  26714. 2011-04-20 Pavel Feldman <pfeldman@google.com>
  26715. Reviewed by Yury Semikhatsky.
  26716. Web Inspector: add saveAs into the InspectorFrontendHost binding.
  26717. https://bugs.webkit.org/show_bug.cgi?id=58979
  26718. * English.lproj/localizedStrings.js:
  26719. * inspector/InspectorFrontendClient.h:
  26720. (WebCore::InspectorFrontendClient::saveAs):
  26721. (WebCore::InspectorFrontendClient::saveSessionSetting):
  26722. (WebCore::InspectorFrontendClient::loadSessionSetting):
  26723. * inspector/InspectorFrontendHost.cpp:
  26724. (WebCore::InspectorFrontendHost::saveAs):
  26725. * inspector/InspectorFrontendHost.h:
  26726. * inspector/InspectorFrontendHost.idl:
  26727. * inspector/front-end/InspectorFrontendHostStub.js:
  26728. (.WebInspector.InspectorFrontendHostStub.prototype.saveAs.fr.onload):
  26729. (.WebInspector.InspectorFrontendHostStub.prototype.saveAs):
  26730. * inspector/front-end/NetworkPanel.js:
  26731. (WebInspector.NetworkPanel.prototype._contextMenu):
  26732. (WebInspector.NetworkPanel.prototype._copyAll):
  26733. (WebInspector.NetworkPanel.prototype._copyResource):
  26734. (WebInspector.NetworkPanel.prototype._exportAll):
  26735. (WebInspector.NetworkPanel.prototype._exportResource):
  26736. * inspector/front-end/Settings.js:
  26737. * inspector/front-end/utilities.js:
  26738. ():
  26739. 2011-04-20 Yury Semikhatsky <yurys@chromium.org>
  26740. Reviewed by Tony Gentilcore.
  26741. Error event in <script> element shouldn't bubble
  26742. https://bugs.webkit.org/show_bug.cgi?id=51040
  26743. Test: svg/dom/SVGScriptElement/script-onerror-bubbling.svg
  26744. * dom/ScriptElement.cpp:
  26745. (WebCore::ScriptElement::dispatchErrorEvent): the method now has same implementation for all script
  26746. elements, script load error event doesn' bubble.
  26747. * dom/ScriptElement.h:
  26748. * html/HTMLScriptElement.cpp:
  26749. * html/HTMLScriptElement.h:
  26750. * html/parser/HTMLScriptRunner.cpp:
  26751. (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
  26752. * svg/SVGScriptElement.cpp:
  26753. (WebCore::SVGScriptElement::parseMappedAttribute): SVG script element now supports onerror
  26754. hanlder which behaves the same way as onerror in HTML script element: it's invoked when
  26755. script loading fails and the event doesn't bubble.
  26756. * svg/SVGScriptElement.h:
  26757. 2011-04-20 Pavel Feldman <pfeldman@google.com>
  26758. Reviewed by Yury Semikhatsky.
  26759. Web Inspector: minor protocol cleanups (refined types).
  26760. https://bugs.webkit.org/show_bug.cgi?id=58970
  26761. * inspector/InjectedScriptSource.js:
  26762. * inspector/Inspector.json:
  26763. 2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
  26764. Reviewed by Eric Seidel.
  26765. Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks
  26766. https://bugs.webkit.org/show_bug.cgi?id=56672
  26767. ~RenderSVGShadowTreeRootContainer() cleared shadow host only if
  26768. the shadow root is attached. This is wrong because it will
  26769. leak shadow root when the root is not attached. For example, it
  26770. leaks shadow root of <use> element which is pending on resource.
  26771. This patch is clearing shadow host if m_shadowRoot is valid to
  26772. prevent leaking.
  26773. Fixing leaking, no new tests.
  26774. * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
  26775. (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
  26776. 2011-04-19 Maciej Stachowiak <mjs@apple.com>
  26777. Reviewed by Antti Koivisto.
  26778. Reproducible crash two-finger zooming at multiple sites in WebCore::RenderLayer::isTransparent
  26779. https://bugs.webkit.org/show_bug.cgi?id=58868
  26780. I could not figure out how to make a test.
  26781. * rendering/RenderLayer.cpp:
  26782. (WebCore::RenderLayer::paintLayer): Check for existence of a
  26783. parent before calling a method on it.
  26784. 2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  26785. Reviewed by Daniel Bates.
  26786. [EFL] Add current time to media control panel.
  26787. https://bugs.webkit.org/show_bug.cgi?id=58866
  26788. Implement paintMediaCurrentTime() to show playing time of media content.
  26789. * platform/efl/RenderThemeEfl.cpp:
  26790. (WebCore::RenderThemeEfl::RenderThemeEfl):
  26791. (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
  26792. (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  26793. * platform/efl/RenderThemeEfl.h:
  26794. 2011-04-19 Jungshik Shin <jshin@chromium.org>
  26795. Reviewed by Adam Barth
  26796. Update the list of Unicode blocks to treat as complex scripts
  26797. per Unicode 6.0. Also, make [U+02E5..U+02E9] (IPA tone marks)
  26798. go through the complex script code path.
  26799. Test: fast/text/ipa-tone-letters.html
  26800. http://bugs.webkit.org/show_bug.cgi?id=39799
  26801. * platform/graphics/Font.cpp:
  26802. (WebCore::Font::codePath):
  26803. 2011-04-19 Pratik Solanki <psolanki@apple.com>
  26804. Reviewed by Simon Fraser.
  26805. Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
  26806. Move the assert from Image::drawPattern() to Image::drawTiled() so we don't hit it when
  26807. trying to paint GeneratedImages.
  26808. * platform/graphics/Image.cpp:
  26809. (WebCore::Image::drawTiled):
  26810. * platform/graphics/cg/ImageCG.cpp:
  26811. (WebCore::Image::drawPattern):
  26812. 2011-04-19 Simon Fraser <simon.fraser@apple.com>
  26813. Fix 32-bit builds.
  26814. * rendering/RenderBox.cpp:
  26815. (WebCore::RenderBox::determineBackgroundBleedAvoidance):
  26816. * rendering/RenderBoxModelObject.cpp:
  26817. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  26818. 2011-04-19 Naoki Takano <takano.naoki@gmail.com>
  26819. Reviewed by Kent Tamura.
  26820. [Chromium]UI polishes and tweaks to Autofill dropdown menu.
  26821. https://bugs.webkit.org/show_bug.cgi?id=58505
  26822. http://code.google.com/p/chromium/issues/detail?id=51077
  26823. No new tests. Because this is autofill looking problem in Chromium.
  26824. Add m_menuType as PopupMenuStyle to change popup style change.
  26825. Put kLinePaddingHeight at the top and bottom of each line if m_menuType is AutofillPopup.
  26826. Change separator color to #dcdcdc and remove sparatorPadding at the edge if m_menuType is AutofillPopup.
  26827. Change the line height of separator as only the piece if m_menuType is AutofillPopup.
  26828. Change the label font size 0.9 time smaller than regular font size if m_menuType is AutofillPopup.
  26829. * platform/PopupMenuStyle.h: Add enum PopupMenuType;
  26830. (WebCore::PopupMenuStyle::PopupMenuStyle): Add m_menuType.
  26831. (WebCore::PopupMenuStyle::menuType): Add to change the style according to the return value.
  26832. * platform/chromium/PopupMenuChromium.cpp:
  26833. (WebCore::PopupListBox::paintRow):Change the separator color to #dcdcdc.
  26834. Change the edge padding according to menuStyle().
  26835. (WebCore::PopupListBox::getRowHeight): Add kLineHeightMargin*2 for each line height.
  26836. 2011-04-19 Simon Fraser <simon.fraser@apple.com>
  26837. Reviewed by Dan Bernstein.
  26838. background color of elements with border-radius shows around outer edge of border at corners
  26839. https://bugs.webkit.org/show_bug.cgi?id=21819
  26840. When drawing a background followed by a border with the same rounded
  26841. clip, some border color leaks out because of antialiasing.
  26842. Fix this by using two different strategies depending on the colors.
  26843. If the border is opaque on all sides, we can inset the background by
  26844. a device pixel. If not, then we have to draw the unclipped background
  26845. and border into a transparency layer, and then clip that.
  26846. A futher possible solution is mentioned in a comment in
  26847. determineBackgroundBleedAvoidance() but not yet implemented.
  26848. Also don't try to paint shadows with zero offset, spread and blur.
  26849. Test: fast/backgrounds/background-leakage.html,
  26850. fast/backgrounds/background-leakage-transforms.html
  26851. * rendering/RenderBoxModelObject.h:
  26852. Add a BackgroundBleedAvoidance enum with a value for each
  26853. strategy.
  26854. * rendering/RenderBoxModelObject.cpp:
  26855. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  26856. Pass BackgroundBleedAvoidance, bail early if the border rect is empty.
  26857. If using the transparency layer solution, don't bother to clip
  26858. to the rounded rect for the background. If the strategy is to
  26859. shrink the background, do that.
  26860. (WebCore::BorderEdge::BorderEdge):
  26861. (WebCore::BorderEdge::obscuresBackgroundEdge):
  26862. Helper method to determine if this border side will totally
  26863. obscured by the border edge, allowing us to inset it.
  26864. (WebCore::RenderBoxModelObject::paintOneBorderSide):
  26865. Pass BackgroundBleedAvoidance through.
  26866. (WebCore::RenderBoxModelObject::paintBorderSides):
  26867. Ditto.
  26868. (WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
  26869. Ditto.
  26870. (WebCore::RenderBoxModelObject::paintBorder):
  26871. Fill BorderEdges using getBorderEdgeInfo now.
  26872. Don't clip to the rounded border if we are using the
  26873. transparency layer solution.
  26874. (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
  26875. Pass bleedAvoidance through, and use it for double borders.
  26876. (WebCore::RenderBoxModelObject::getBorderEdgeInfo):
  26877. Helper to fill in the BorderEdge array.
  26878. (WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
  26879. Used to determine if we can use the background shrinkage solution.
  26880. (WebCore::RenderBoxModelObject::paintBoxShadow):
  26881. Don't paint shadows that should not be visible.
  26882. * rendering/RenderBox.h:
  26883. * rendering/RenderBox.cpp:
  26884. (WebCore::RenderBox::paintRootBoxFillLayers):
  26885. Pass BackgroundBleedNone for the root box.
  26886. (WebCore::RenderBox::determineBackgroundBleedAvoidance):
  26887. Determine which bleed strategy we can use.
  26888. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  26889. Based on the bleedAvoidance, make a transparency layer
  26890. which will be clipped to the rounded border outside edge,
  26891. and pass bleedAvoidance to the background and border-painting
  26892. methods.
  26893. (WebCore::RenderBox::paintMaskImages):
  26894. Use BackgroundBleedNone.
  26895. (WebCore::RenderBox::paintFillLayers):
  26896. (WebCore::RenderBox::paintFillLayer):
  26897. Pass bleedAvoidance through.
  26898. * rendering/InlineFlowBox.cpp:
  26899. (WebCore::InlineFlowBox::paintFillLayer):
  26900. (WebCore::InlineFlowBox::paintBoxDecorations):
  26901. Pass BackgroundBleedNone. At some point we may want to do the right
  26902. thing for split inlines.
  26903. * rendering/RenderFieldset.cpp:
  26904. (WebCore::RenderFieldset::paintBoxDecorations):
  26905. * rendering/RenderTableCell.cpp:
  26906. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  26907. Pass BackgroundBleedNone.
  26908. 2011-04-19 Yuta Kitamura <yutak@chromium.org>
  26909. Reviewed by Alexey Proskuryakov.
  26910. WebSocket: Add assertion for SocketStreamError::failingURL.
  26911. https://bugs.webkit.org/show_bug.cgi?id=58765
  26912. No new tests, because an existing test http/tests/inspector/console-websocket-error.html should cover this.
  26913. * websockets/WebSocketChannel.cpp:
  26914. (WebCore::WebSocketChannel::didFail): If error.failingURL() is provided, it must be the same as
  26915. m_handshake.url(). failingURL may be null if SocketStreamHandle has created a SocketStreamError
  26916. using zero- or one-argument constructor (which is old version but some ports are still using it).
  26917. In that case, m_handshake.url() is passed to addMessage().
  26918. 2011-04-19 Eric Carlson <eric.carlson@apple.com>
  26919. Reviewed by Dimitri Glazkov.
  26920. Media controls status display should not be hidden for live streams
  26921. https://bugs.webkit.org/show_bug.cgi?id=58952
  26922. Tested manually because we don't have any live streams to test in DRT.
  26923. * html/shadow/MediaControlElements.cpp:
  26924. (WebCore::MediaControlStatusDisplayElement::update): Set the status to "Loading" only until
  26925. there is something to display (readyState exceeds HAVE_METADATA).
  26926. * html/shadow/MediaControlRootElement.cpp:
  26927. (WebCore::MediaControlRootElement::loadedMetadata): Don't hide the status display for
  26928. live streams.
  26929. 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>
  26930. Reviewed by Alexey Proskuryakov.
  26931. https://bugs.webkit.org/show_bug.cgi?id=45425
  26932. HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting
  26933. Test: fast/html/htmllink-disable.html
  26934. Test: fast/dom/HTMLLinkElement/disabled-attribute.html
  26935. Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.
  26936. Based on previous work by Bijan Amirzada <bijana@codeaurora.org>.
  26937. * html/HTMLLinkElement.cpp:
  26938. (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or
  26939. false if we don't have a stylesheet.
  26940. (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or
  26941. ignore the call if we don't have a stylesheet.
  26942. * html/HTMLLinkElement.h:
  26943. * html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5.
  26944. This matches the way FF4, Opera and IE9 handle the attribute.
  26945. 2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
  26946. Reviewed by Eric Seidel.
  26947. Remove calls to deprecatedOffset and deprecatedNode in TypingCommand
  26948. https://bugs.webkit.org/show_bug.cgi?id=58569
  26949. Removed all calls to deprecatedOffset and deprecatedNode.
  26950. * editing/TypingCommand.cpp:
  26951. (WebCore::TypingCommand::insertText):
  26952. (WebCore::TypingCommand::deleteKeyPressed):
  26953. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  26954. 2011-04-19 Adrienne Walker <enne@google.com>
  26955. Reviewed by Kenneth Russell.
  26956. [chromium] Initialize depth mask to known value before getBooleanv call
  26957. https://bugs.webkit.org/show_bug.cgi?id=58948
  26958. This trips an assert in the GPU command buffer client code if the
  26959. pointed-to value is not initialized to 0 or -1.
  26960. * platform/graphics/gpu/DrawingBuffer.cpp:
  26961. (WebCore::DrawingBuffer::clearFramebuffer):
  26962. 2011-04-19 Pratik Solanki <psolanki@apple.com>
  26963. Reviewed by Simon Fraser.
  26964. BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
  26965. https://bugs.webkit.org/show_bug.cgi?id=58926
  26966. * platform/graphics/BitmapImage.cpp:
  26967. (WebCore::BitmapImage::destroyMetadataAndNotify): Set m_checkedForSolidColor to false.
  26968. * platform/graphics/BitmapImage.h:
  26969. (WebCore::BitmapImage::assertNotSolidColor):
  26970. * platform/graphics/cg/ImageCG.cpp:
  26971. (WebCore::Image::drawPattern): Add assert to make sure this is not called for a 1x1 image.
  26972. 2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
  26973. Reviewed by Ojan Vafai.
  26974. REGRESSION(r83967): Crash in selectionExtentRespectingEditingBoundary
  26975. https://bugs.webkit.org/show_bug.cgi?id=58910
  26976. The crash was caused by selectionExtentRespectingEditingBoundary's incorrectly assuming that
  26977. targetNode always have renderer when there selection has an editable root and the target node
  26978. is outside of the editable root.
  26979. Fixed the bug by adding an early exit when the target node is null.
  26980. No new tests are added since we don't have a reduction for this crash.
  26981. * page/EventHandler.cpp:
  26982. (WebCore::selectionExtentRespectingEditingBoundary):
  26983. 2011-04-19 Geoffrey Garen <ggaren@apple.com>
  26984. Try to fix v8 build.
  26985. * bindings/scripts/CodeGeneratorV8.pm: This is a pretty bad system.
  26986. 2011-04-19 Enrica Casucci <enrica@apple.com>
  26987. Reviewed by Ryosuke Niwa.
  26988. REGRESSION(r55762): Highlight color can't be copied in gmail.
  26989. https://bugs.webkit.org/show_bug.cgi?id=58925
  26990. <rdar://problem/9253057>
  26991. Test: editing/pasteboard/copy-text-with-backgroundcolor.html
  26992. The changes of r55762 uncovered the underlying issue here. The markup fragment
  26993. placed in the pasteboard does not contain the background color style.
  26994. This occurs only if the selection is limited to a single text node, whereas if the
  26995. selection spans across multiple nodes, the style is preserved correctly.
  26996. The fix consists in changing the logic that decides whether we should include the wrapping
  26997. node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
  26998. on isElementPresentational to choose candidates to be the wrapping node.
  26999. I've extended it to accept nodes that have non fully transparent background colors.
  27000. * editing/Editor.cpp:
  27001. (WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.
  27002. * editing/Editor.h:
  27003. * editing/markup.cpp:
  27004. (WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.
  27005. 2011-04-19 Geoffrey Garen <ggaren@apple.com>
  27006. Reviewed by Oliver Hunt.
  27007. Removed a use of markDOMObjectWrapper: NodeLists
  27008. https://bugs.webkit.org/show_bug.cgi?id=58939
  27009. * bindings/js/JSDocumentCustom.cpp:
  27010. (WebCore::JSDocument::markChildren): No need to mark node lists, because
  27011. now they use the opaque roots system to decide their lifetimes.
  27012. * bindings/js/JSNamedNodeMapCustom.cpp: Removed stray newline.
  27013. * bindings/js/JSNodeListCustom.cpp:
  27014. (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
  27015. (WebCore::JSNodeListOwner::finalize):
  27016. (WebCore::wrapperOwner):
  27017. (WebCore::wrapperContext):
  27018. (WebCore::toJS): Use the opaque roots system to avoid relying on
  27019. markDOMObjectWrapper.
  27020. * dom/DynamicNodeList.cpp:
  27021. (WebCore::DynamicNodeList::isDynamicNodeList):
  27022. * dom/DynamicNodeList.h:
  27023. (WebCore::DynamicNodeList::rootNode): Added the ability to get the node
  27024. backing a NodeList, for use in the opaque roots system.
  27025. * dom/Node.cpp:
  27026. * dom/Node.h:
  27027. * dom/NodeList.h:
  27028. (WebCore::NodeList::isDynamicNodeList): Ditto. Removed cruft related
  27029. to the old way of marking NodeLists.
  27030. * dom/NodeList.idl: We need a custom toJS so we can specify a custom
  27031. WeakHandleOwner at construction time.
  27032. 2011-04-19 Antoine Labour <piman@chromium.org>
  27033. Reviewed by James Robinson.
  27034. For invisible iframes, propagate compositing to parent instead of setting self
  27035. as root.
  27036. https://bugs.webkit.org/show_bug.cgi?id=58414
  27037. Tests: compositing/iframes/invisible-iframe.html
  27038. compositing/iframes/invisible-nested-iframe-hide.html
  27039. compositing/iframes/invisible-nested-iframe-show.html
  27040. compositing/iframes/invisible-nested-iframe.html
  27041. * rendering/RenderLayerCompositor.cpp:
  27042. (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
  27043. Propagate compositing to parent even if frame owner has no renderer.
  27044. 2011-04-19 Dan Bernstein <mitz@apple.com>
  27045. Reviewed by Beth Dakin.
  27046. <rdar://problem/9271848> Crash when the document element is removed
  27047. Test: fast/events/overflow-viewport-renderer-deleted.html
  27048. * page/FrameView.cpp:
  27049. (WebCore::FrameView::calculateScrollbarModesForLayout): Reset m_viewportRenderer, in case this
  27050. function takes a code path that doesn’t call applyOverflowToViewport().
  27051. (WebCore::FrameView::layout): Whitespace change.
  27052. 2011-04-19 Beth Dakin <bdakin@apple.com>
  27053. Reviewed by Maciej Stachowiak.
  27054. https://bugs.webkit.org/show_bug.cgi?id=57898
  27055. REGRESSION (r82185): Scroll position not restored on navigation back to a page in
  27056. the page cache
  27057. -and corresponding-
  27058. <rdar://problem/9226652>
  27059. Setting the contentsSize of a ScrollView to (0, 0) necessarily causes the scroll
  27060. position to be lost. (The scroll position is computed based on the
  27061. visibleContentSize.) This patch provides a mechanism to cache the current scroll
  27062. position, and then the HistoryController accesses only the cached position rather
  27063. than calling scrollPosition() which does a computation based on the
  27064. visibleContentSize.
  27065. * loader/HistoryController.cpp:
  27066. (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
  27067. * page/FrameView.cpp:
  27068. (WebCore::FrameView::resetScrollbarsAndClearContentsSize):
  27069. * platform/ScrollView.h:
  27070. (WebCore::ScrollView::cacheCurrentScrollPosition):
  27071. (WebCore::ScrollView::cachedScrollPosition):
  27072. 2011-04-19 Renata Hodovan <reni@webkit.org>
  27073. Reviewed by Eric Seidel.
  27074. Move the alignment related macros in Vector.h to new Alignment.h.
  27075. https://bugs.webkit.org/show_bug.cgi?id=56000
  27076. Adding the new file to the forwarding headers of WebCore.
  27077. * ForwardingHeaders/wtf/Alignment.h: Added.
  27078. 2011-04-19 Oliver Hunt <oliver@apple.com>
  27079. Reviewed by Andreas Kling.
  27080. [Qt] QtInstance method cache ownership rules are unclear
  27081. https://bugs.webkit.org/show_bug.cgi?id=58820
  27082. Make the QtInstance method cache use WriteBarrier, and handle
  27083. ownership properly.
  27084. * bridge/qt/qt_class.cpp:
  27085. (JSC::Bindings::QtClass::fallbackObject):
  27086. (JSC::Bindings::QtClass::fieldNamed):
  27087. * bridge/qt/qt_instance.cpp:
  27088. (JSC::Bindings::QtInstance::~QtInstance):
  27089. (JSC::Bindings::QtInstance::removeCachedMethod):
  27090. (JSC::Bindings::QtInstance::newRuntimeObject):
  27091. (JSC::Bindings::QtInstance::markAggregate):
  27092. * bridge/qt/qt_instance.h:
  27093. 2011-04-19 David Kilzer <ddkilzer@apple.com>
  27094. <http://webkit.org/b/57867> Re-order enum ResourceLoadPriority to make Unresolved value less important
  27095. Reviewed by Antti Koivisto.
  27096. * platform/network/ResourceLoadPriority.h:
  27097. (enum ResourceLoadPriority): Moved Unresolved enum to the top of
  27098. the list and set to -1 to emphasize the fact that this is an
  27099. unresolved priority (rather than one higher than the highest
  27100. priority). Removed whitespace from the end of all enum lines.
  27101. 2011-04-19 Simon Fraser <simon.fraser@apple.com>
  27102. Reviewed by David Hyatt.
  27103. Background radius is wrong for split inline
  27104. https://bugs.webkit.org/show_bug.cgi?id=58843
  27105. When computing the radii for a segment of a split inline, we have to
  27106. constrain those radii for the current segment, while still drawing
  27107. using the entire logical width.
  27108. Tests: fast/backgrounds/border-radius-split-background-image.html
  27109. fast/backgrounds/border-radius-split-background.html
  27110. * rendering/InlineFlowBox.cpp:
  27111. (WebCore::InlineFlowBox::paintFillLayer):
  27112. Pass height and width for this box only to paintFillLayer()
  27113. * rendering/RenderBox.cpp:
  27114. (WebCore::RenderBox::paintFillLayer):
  27115. Pass 0 for unused inlineBox height and width.
  27116. * rendering/RenderBoxModelObject.h:
  27117. * rendering/RenderBoxModelObject.cpp:
  27118. (WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
  27119. When computing the rounded background rect, we have to take the size of
  27120. this segment of the inline box into account for radius constraining.
  27121. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  27122. Call getBackgroundRoundedRect() in two places.
  27123. 2011-04-19 Simon Fraser <simon.fraser@apple.com>
  27124. Build fix. For some reason RenderBoxModelObject.cpp
  27125. was missing from my last commit.
  27126. * rendering/RenderBoxModelObject.cpp:
  27127. (WebCore::borderWillArcInnerEdge):
  27128. (WebCore::edgeFlagForSide):
  27129. (WebCore::includesEdge):
  27130. (WebCore::BorderEdge::BorderEdge):
  27131. (WebCore::BorderEdge::hasVisibleColorAndStyle):
  27132. (WebCore::BorderEdge::shouldRender):
  27133. (WebCore::BorderEdge::presentButInvisible):
  27134. (WebCore::BorderEdge::usedWidth):
  27135. (WebCore::BorderEdge::getDoubleBorderStripeWidths):
  27136. (WebCore::edgesShareColor):
  27137. (WebCore::styleRequiresClipPolygon):
  27138. (WebCore::borderStyleFillsBorderArea):
  27139. (WebCore::borderStyleHasInnerDetail):
  27140. (WebCore::borderStyleIsDottedOrDashed):
  27141. (WebCore::borderStyleHasUnmatchedColorsAtCorner):
  27142. (WebCore::colorsMatchAtCorner):
  27143. (WebCore::willBeOverdrawn):
  27144. (WebCore::borderStylesRequireMitre):
  27145. (WebCore::joinRequiresMitre):
  27146. (WebCore::RenderBoxModelObject::paintOneBorderSide):
  27147. (WebCore::RenderBoxModelObject::paintBorderSides):
  27148. (WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
  27149. (WebCore::RenderBoxModelObject::paintBorder):
  27150. (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
  27151. (WebCore::findInnerVertex):
  27152. (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
  27153. (WebCore::RenderBoxModelObject::paintBoxShadow):
  27154. 2011-04-19 Stephen White <senorblanco@chromium.org>
  27155. Reviewed by Kenneth Russell.
  27156. Refactor GLES2Canvas state application out into its own function.
  27157. https://bugs.webkit.org/show_bug.cgi?id=58906
  27158. Covered by existing tests in fast/canvas and canvas/philip.
  27159. * platform/graphics/chromium/GLES2Canvas.cpp:
  27160. (WebCore::GLES2Canvas::applyState):
  27161. New function to apply compositing and clipping state.
  27162. (WebCore::GLES2Canvas::fillPath):
  27163. (WebCore::GLES2Canvas::fillRect):
  27164. (WebCore::GLES2Canvas::beginShadowDraw):
  27165. (WebCore::GLES2Canvas::endShadowDraw):
  27166. Refactor calls to applyState().
  27167. * platform/graphics/chromium/GLES2Canvas.h:
  27168. 2011-04-19 Simon Fraser <simon.fraser@apple.com>
  27169. Reviewed by Dave Hyatt.
  27170. Fix multiple border rendering issues
  27171. https://bugs.webkit.org/show_bug.cgi?id=58761
  27172. Fix various border-drawing bugs, and optimize some common cases.
  27173. Also refactors a lot of the border-drawing code to be more maintainable.
  27174. Rounded border rendering with different border widths looks strange
  27175. https://bugs.webkit.org/show_bug.cgi?id=17468
  27176. paintBorder in RenderObject paint two times the corners
  27177. https://bugs.webkit.org/show_bug.cgi?id=20495
  27178. Overdraw at box corners when using RGBA colors with alpha
  27179. https://bugs.webkit.org/show_bug.cgi?id=21835
  27180. Enable antialiasing for border drawing, when transformed
  27181. https://bugs.webkit.org/show_bug.cgi?id=22746
  27182. Drawing border-radius from path sometimes fails to round outer border in the double style when it should
  27183. https://bugs.webkit.org/show_bug.cgi?id=41301
  27184. Drawing border-radius from path doesn't appear to always match up border edges correctly
  27185. https://bugs.webkit.org/show_bug.cgi?id=41302
  27186. Also fixes
  27187. Should be able to create Path from RoundedIntRect
  27188. https://bugs.webkit.org/show_bug.cgi?id=58809
  27189. Tests: fast/borders/border-radius-different-width-001.html
  27190. fast/borders/border-radius-inset-outset.html
  27191. fast/borders/table-borders.html
  27192. * platform/graphics/FloatPoint.h:
  27193. * platform/graphics/FloatPoint.cpp:
  27194. (WebCore::findSlope):
  27195. (WebCore::findIntersection):
  27196. New geometry helper functions (should eventually move into a new
  27197. GeometryUtilities file).
  27198. * platform/graphics/Path.h:
  27199. * platform/graphics/Path.cpp:
  27200. (WebCore::Path::addRoundedRect):
  27201. Add an overload of addRoundedRect() that takes a RoundedIntRect.
  27202. * platform/graphics/GraphicsContext.cpp:
  27203. (WebCore::GraphicsContext::addRoundedRectClip):
  27204. (WebCore::GraphicsContext::clipOutRoundedRect):
  27205. (WebCore::GraphicsContext::fillRectWithRoundedHole):
  27206. Can now add a RoundedIntRect to a Path directly.
  27207. * platform/graphics/IntRect.h:
  27208. (WebCore::IntRect::minXMinYCorner):
  27209. (WebCore::IntRect::maxXMinYCorner):
  27210. (WebCore::IntRect::minXMaxYCorner):
  27211. (WebCore::IntRect::maxXMaxYCorner):
  27212. Convenience functions to get the rect corners, in a writing-mode-
  27213. friendly way.
  27214. * platform/graphics/RoundedIntRect.h:
  27215. * platform/graphics/RoundedIntRect.cpp:
  27216. (WebCore::RoundedIntRect::isRenderable):
  27217. We need to know when Path::addRoundedRect() will fail because
  27218. the sum of the radii exceed the height or width. This method tells
  27219. us that.
  27220. * platform/graphics/cg/GraphicsContextCG.cpp:
  27221. (WebCore::GraphicsContext::fillRectWithRoundedHole):
  27222. Can now add a RoundedIntRect to a Path directly.
  27223. * rendering/RenderBoxModelObject.h:
  27224. * rendering/RenderBoxModelObject.cpp:
  27225. (WebCore::borderWillArcInnerEdge):
  27226. This can just to see if there are inner radii now.
  27227. (WebCore::edgeFlagForSide):
  27228. (WebCore::includesEdge):
  27229. Convenience functions for the BorderEdgeFlags bitmask.
  27230. (WebCore::BorderEdge::BorderEdge):
  27231. (WebCore::BorderEdge::hasVisibleColorAndStyle):
  27232. (WebCore::BorderEdge::shouldRender):
  27233. (WebCore::BorderEdge::presentButInvisible):
  27234. (WebCore::BorderEdge::usedWidth):
  27235. (WebCore::BorderEdge::getDoubleBorderStripeWidths):
  27236. Convenience class to hold data about how a single edge
  27237. is drawn, and to contain some commonly used width-related methods.
  27238. (WebCore::edgesShareColor):
  27239. (WebCore::styleRequiresClipPolygon):
  27240. (WebCore::borderStyleFillsBorderArea):
  27241. (WebCore::borderStyleHasInnerDetail):
  27242. (WebCore::borderStyleIsDottedOrDashed):
  27243. (WebCore::borderStyleHasUnmatchedColorsAtCorner):
  27244. (WebCore::colorsMatchAtCorner):
  27245. (WebCore::willBeOverdrawn):
  27246. (WebCore::borderStylesRequireMitre):
  27247. (WebCore::joinRequiresMitre):
  27248. Functions used to make the border drawing code more readable,
  27249. which are used to determine when corners need a mitre, and
  27250. need antialiasing.
  27251. (WebCore::RenderBoxModelObject::paintOneBorderSide):
  27252. Code to paint one side of a border, either via the path, or
  27253. using rects/polygons, the appropriate mitres and antialiasing
  27254. at the corners. includeLogicalLeftEdge and includeLogicalRightEdge need
  27255. to be passed all the way down here so that when we recompute the
  27256. path for double and ridge/groove borders, we correctly handle split box
  27257. borders.
  27258. (WebCore::RenderBoxModelObject::paintBorderSides):
  27259. Paints the 4 border sides (if present).
  27260. (WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
  27261. Called when one or more of the borders has a non-opaque color,
  27262. and uses a transparency layer for each set of same-colored
  27263. sides to avoid overdraw at the corners.
  27264. (WebCore::RenderBoxModelObject::paintBorder):
  27265. Builds an array of BorderEdge so we can iterate over them to
  27266. detect different border compbinations, and optimizations. Has
  27267. a fast path for all-solid borders.
  27268. (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
  27269. Moved from RenderObject, since all callers are in RenderBoxModelObject.
  27270. Has the following changes:
  27271. * Don't attempt to draw dashes if there is only space for a few,
  27272. since it looks bad.
  27273. * Handle double and groove borders on split inlines correctly,
  27274. making use of includeLogicalLeftEdge, includeLogicalRightEdge
  27275. (WebCore::findInnerVertex):
  27276. For borders with a radiused inner edge, the per-side clip polygon
  27277. has to project inside the padding box to avoid clipping the inner edge.
  27278. This function computes a reasonable inner corner for the clipping
  27279. polygon.
  27280. (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
  27281. Have the corner joins pass through the corners of the inner and outer
  27282. border rectangles, ensure we don't clip the inside if necessary,
  27283. and handle antialiasing on the two mitres.
  27284. (WebCore::RenderBoxModelObject::paintBoxShadow):
  27285. Use RenderStyle::getRoundedInnerBorderFor() rather than computeBorderInnerRect()
  27286. etc.
  27287. * rendering/RenderObject.h:
  27288. * rendering/RenderObject.cpp:
  27289. (WebCore::RenderObject::drawLineForBoxSide):
  27290. Moved to RenderBoxModelObject.
  27291. * rendering/style/RenderStyle.h:
  27292. * rendering/style/RenderStyle.cpp:
  27293. (WebCore::RenderStyle::getRoundedBorderFor):
  27294. (WebCore::RenderStyle::getRoundedInnerBorderFor):
  27295. There was some very clumsy code that computed a rounded rect
  27296. given the border rect and side widths. Cleaned this up by moving
  27297. some code into RenderStyle. The overloaded getRoundedInnerBorderFor()
  27298. which takes the border widths is used by the double and groove drawing
  27299. code.
  27300. 2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
  27301. Reviewed by Dimitri Glazkov.
  27302. REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
  27303. https://bugs.webkit.org/show_bug.cgi?id=57061
  27304. The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
  27305. a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
  27306. RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
  27307. a significant performance regression.
  27308. Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
  27309. no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
  27310. and prevents respondToNodeModification from clearing selection.
  27311. No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
  27312. isn't exposed to JavaScript.
  27313. * dom/Range.cpp:
  27314. (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of
  27315. start and end nodes are same, we should never get an exception from compareBoundaryPoints.
  27316. (WebCore::Range::setEnd): Ditto.
  27317. (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints
  27318. throws an exception.
  27319. (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by
  27320. compareBoundaryPoints.
  27321. (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor.
  27322. (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
  27323. * dom/Range.h:
  27324. * editing/SelectionController.cpp:
  27325. (WebCore::SelectionController::respondToNodeModification):
  27326. * editing/htmlediting.cpp:
  27327. (WebCore::comparePositions): Calls compareBoundaryPoints.
  27328. * editing/markup.cpp:
  27329. (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document
  27330. and neither are in a shadow DOM, it should never throw an exception.
  27331. * page/DOMSelection.cpp:
  27332. (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception
  27333. was thrown.
  27334. 2011-04-19 Jungshik Shin <jshin@chromium.org>
  27335. Reviewed by David Levin
  27336. Make U+FEFF be treated as a zero-width character in both
  27337. simple script and complex script code paths. In Chromium
  27338. Windows, UniscribeHelper needs a rather extensive changes
  27339. summarized below. Other ports need minor changes.
  27340. https://bugs.webkit.org/show_bug.cgi?id=48860
  27341. Test: fast/text/zero-width-characters-complex-script.html
  27342. * platform/graphics/Font.h:
  27343. (WebCore::Font::treatAsZeroWidthSpace): U+FEFF is added to the list
  27344. (WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Added. Same as the above except that ZWNJ and ZWJ are excluded.
  27345. * platform/graphics/GlyphPageTreeNode.cpp:
  27346. (WebCore::GlyphPageTreeNode::initializePage): U+FEFF is made to have zero-width characters in simple script (fast) code path.
  27347. * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  27348. (WebCore::FontMap::getSpaceGlyph): Added to get the gid for space glyph to use in adjustSpaceAdvance when zero-width glyph character has a non-zero width and potentially 'visible' glyph.
  27349. (WebCore::FontMap::FontData::FontData): spaceGlyph member added.
  27350. (WebCore::getDerivedFontData): spaceGlyph is retrieved as well.
  27351. * platform/graphics/chromium/FontUtilsChromiumWin.h:
  27352. * platform/graphics/chromium/UniscribeHelper.cpp:
  27353. (WebCore::UniscribeHelper::UniscribeHelper): m_spaceGlyph added.
  27354. (WebCore::UniscribeHelper::shape): spaceGlyph is obtained stored for a font tried for each item.
  27355. (WebCore::UniscribeHelper::adjustSpaceAdvances): For zero-width complex script characters, set the advance width to zero and replace a non-zero-width/visible glyph with a space glyph.
  27356. (WebCore::UniscribeHelper::applySpacing):
  27357. (WebCore::UniscribeHelper::containsMissingGlyphs): turned to a member function because it cannot work on glyphs alone any more but need to take into account a character corresponding to a glyph
  27358. * platform/graphics/chromium/UniscribeHelper.h:
  27359. (WebCore::UniscribeHelper::Shaping::Shaping): m_spaceGlyph is added
  27360. * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
  27361. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): When calling UniscriberHelper, add a new argument for spaceGlyph.
  27362. 2011-04-19 Brent Fulgham <bfulgham@webkit.org>
  27363. Reviewed by Adam Roben.
  27364. Extend the DIBPixelData class with the facility for writing the
  27365. bitmap representation to disk for debugging purposes.
  27366. https://bugs.webkit.org/show_bug.cgi?id=58862.
  27367. * platform/graphics/win/DIBPixelData.cpp:
  27368. (WebCore::DIBPixelData::writeToFile): New function.
  27369. * platform/graphics/win/DIBPixelData.h:
  27370. 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
  27371. Reviewed by Pavel Feldman.
  27372. Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
  27373. https://bugs.webkit.org/show_bug.cgi?id=58883
  27374. * fileapi/FileReaderLoader.cpp:
  27375. (WebCore::FileReaderLoader::didReceiveData):
  27376. * inspector/InspectorInstrumentation.cpp:
  27377. (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  27378. * inspector/InspectorInstrumentation.h:
  27379. (WebCore::InspectorInstrumentation::didReceiveContentLength):
  27380. * inspector/InspectorResourceAgent.cpp:
  27381. (WebCore::InspectorResourceAgent::didReceiveContentLength):
  27382. * inspector/InspectorResourceAgent.h:
  27383. * inspector/front-end/NetworkManager.js:
  27384. (WebInspector.NetworkDispatcher.prototype.dataReceived):
  27385. * loader/DocumentThreadableLoader.cpp:
  27386. (WebCore::DocumentThreadableLoader::didReceiveData):
  27387. (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  27388. * loader/DocumentThreadableLoader.h:
  27389. * loader/FrameLoaderClient.h:
  27390. * loader/MainResourceLoader.cpp:
  27391. (WebCore::MainResourceLoader::didReceiveData):
  27392. * loader/MainResourceLoader.h:
  27393. * loader/NetscapePlugInStreamLoader.cpp:
  27394. (WebCore::NetscapePlugInStreamLoader::didReceiveData):
  27395. * loader/NetscapePlugInStreamLoader.h:
  27396. * loader/ResourceLoadNotifier.cpp:
  27397. (WebCore::ResourceLoadNotifier::didReceiveData):
  27398. (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
  27399. (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  27400. * loader/ResourceLoadNotifier.h:
  27401. * loader/ResourceLoader.cpp:
  27402. (WebCore::ResourceLoader::didReceiveData):
  27403. * loader/ResourceLoader.h:
  27404. * loader/SubresourceLoader.cpp:
  27405. (WebCore::SubresourceLoader::didReceiveData):
  27406. * loader/SubresourceLoader.h:
  27407. * loader/SubresourceLoaderClient.h:
  27408. (WebCore::SubresourceLoaderClient::didReceiveData):
  27409. (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
  27410. * loader/WorkerThreadableLoader.cpp:
  27411. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
  27412. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
  27413. * loader/appcache/ApplicationCacheGroup.cpp:
  27414. (WebCore::ApplicationCacheGroup::didReceiveData):
  27415. * loader/appcache/ApplicationCacheGroup.h:
  27416. * loader/appcache/ApplicationCacheHost.h:
  27417. * notifications/Notification.cpp:
  27418. (WebCore::Notification::didReceiveData):
  27419. * notifications/Notification.h:
  27420. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  27421. (StreamingClient::didReceiveData):
  27422. * platform/network/BlobResourceHandle.cpp:
  27423. * platform/network/ResourceHandleClient.h:
  27424. (WebCore::ResourceHandleClient::didReceiveData):
  27425. * platform/network/android/ResourceHandleAndroid.cpp:
  27426. (WebCore::SyncLoader::didReceiveData):
  27427. * platform/network/cf/ResourceHandleCFNet.cpp:
  27428. (WebCore::WebCoreSynchronousLoaderClient::didReceiveData):
  27429. * platform/network/curl/ResourceHandleCurl.cpp:
  27430. * platform/network/mac/ResourceHandleMac.mm:
  27431. (WebCoreSynchronousLoaderClient::didReceiveData):
  27432. * platform/network/soup/ResourceHandleSoup.cpp:
  27433. * platform/network/win/ResourceHandleWin.cpp:
  27434. * workers/WorkerScriptLoader.h:
  27435. * xml/XMLHttpRequest.h:
  27436. 2011-04-19 Stephen White <senorblanco@chromium.org>
  27437. Reviewed by Eric Seidel.
  27438. Pull framebuffer clearing out into its own function.
  27439. https://bugs.webkit.org/show_bug.cgi?id=58897
  27440. Covered by fast/canvas and canvas/philip tests.
  27441. * platform/graphics/gpu/DrawingBuffer.cpp:
  27442. (WebCore::DrawingBuffer::clearFramebuffer):
  27443. (WebCore::DrawingBuffer::reset):
  27444. * platform/graphics/gpu/DrawingBuffer.h:
  27445. 2011-04-19 Brian Salomon <bsalomon@google.com>
  27446. Reviewed by Eric Seidel.
  27447. When flushing GrContext in ~PlatformContextSkia be sure correct GL context is set
  27448. https://bugs.webkit.org/show_bug.cgi?id=58788
  27449. Chromium browser test will be added that loads canvas page and then an
  27450. acclerated-composited page. Test must trigger ~PlatformContextSkia()
  27451. followed by invocation of GL compositor.
  27452. * platform/graphics/skia/PlatformContextSkia.cpp:
  27453. (WebCore::PlatformContextSkia::~PlatformContextSkia):
  27454. 2011-04-19 Csaba Osztrogonác <ossy@webkit.org>
  27455. [Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
  27456. https://bugs.webkit.org/show_bug.cgi?id=58871
  27457. Unreviewed, rolling out r84176, r84178, r84186, r84212 and r84231.
  27458. http://trac.webkit.org/changeset/84176 (original patch)
  27459. http://trac.webkit.org/changeset/84178 (original patch - part 2)
  27460. http://trac.webkit.org/changeset/84186 (build fix)
  27461. http://trac.webkit.org/changeset/84212
  27462. http://trac.webkit.org/changeset/84231 (skip failing test)
  27463. original bugs:
  27464. - https://bugs.webkit.org/show_bug.cgi?id=58718
  27465. - https://bugs.webkit.org/show_bug.cgi?id=58853
  27466. * bridge/qt/qt_class.cpp:
  27467. (JSC::Bindings::QtClass::fallbackObject):
  27468. * bridge/qt/qt_instance.cpp:
  27469. (JSC::Bindings::QtInstance::removeCachedMethod):
  27470. (JSC::Bindings::QtInstance::markAggregate):
  27471. * bridge/qt/qt_instance.h:
  27472. 2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
  27473. Unreviewed, rolling out r84050.
  27474. http://trac.webkit.org/changeset/84050
  27475. https://bugs.webkit.org/show_bug.cgi?id=58892
  27476. fast/dom/HTMLKeygenElement/keygen.html is crashing on Chromium
  27477. (Requested by jknotten on #webkit).
  27478. * dom/ContainerNode.cpp:
  27479. (WebCore::ContainerNode::takeAllChildrenFrom):
  27480. (WebCore::ContainerNode::removeBetween):
  27481. (WebCore::ContainerNode::removeChildren):
  27482. (WebCore::ContainerNode::parserAddChild):
  27483. * dom/Document.cpp:
  27484. (WebCore::Document::Document):
  27485. (WebCore::Document::~Document):
  27486. (WebCore::Document::setDocType):
  27487. * dom/Element.h:
  27488. * dom/Node.cpp:
  27489. (WebCore::Node::treeScope):
  27490. (WebCore::Node::setTreeScope):
  27491. (WebCore::Node::setTreeScopeRecursively):
  27492. * dom/Node.h:
  27493. (WebCore::Node::document):
  27494. * dom/ShadowRoot.cpp:
  27495. (WebCore::ShadowRoot::ShadowRoot):
  27496. * dom/ShadowRoot.h:
  27497. * dom/TreeScope.cpp:
  27498. (WebCore::TreeScope::TreeScope):
  27499. (WebCore::TreeScope::setParentTreeScope):
  27500. * dom/TreeScope.h:
  27501. * rendering/RenderSlider.cpp:
  27502. 2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
  27503. Not reviewed; windows build fix attempt.
  27504. * storage/StorageInfo.cpp:
  27505. (WebCore::StorageInfo::~StorageInfo):
  27506. * storage/StorageInfo.h:
  27507. 2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
  27508. Reviewed by David Levin.
  27509. [Chromium] Enable QUOTA API at runtime if enable-quota flag is given
  27510. https://bugs.webkit.org/show_bug.cgi?id=58784
  27511. No new tests as this does not change any functionality.
  27512. * bindings/generic/RuntimeEnabledFeatures.cpp:
  27513. * bindings/generic/RuntimeEnabledFeatures.h:
  27514. (WebCore::RuntimeEnabledFeatures::quotaEnabled):
  27515. (WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
  27516. * page/DOMWindow.idl:
  27517. 2011-04-19 John Gregg <johnnyg@google.com>
  27518. Reviewed by Darin Fisher.
  27519. Enable folder drag-n-drop when using a "webkitdirectory" file input
  27520. https://bugs.webkit.org/show_bug.cgi?id=58401
  27521. This uses a new ChromeClient API to enumerate the directory and
  27522. return all the files, as if the user had selected that directory
  27523. by clicking the control in the normal way.
  27524. * loader/EmptyClients.h:
  27525. (WebCore::EmptyChromeClient::enumerateChosenDirectory):
  27526. * page/Chrome.cpp:
  27527. (WebCore::Chrome::enumerateChosenDirectory):
  27528. * page/Chrome.h:
  27529. * page/ChromeClient.h:
  27530. * platform/network/FormData.cpp:
  27531. (WebCore::FormData::appendKeyValuePairItems):
  27532. * rendering/RenderFileUploadControl.cpp:
  27533. (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload):
  27534. (WebCore::RenderFileUploadControl::receiveDroppedFiles):
  27535. * rendering/RenderFileUploadControl.h:
  27536. 2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
  27537. Unreviewed, rolling out r84150.
  27538. http://trac.webkit.org/changeset/84150
  27539. https://bugs.webkit.org/show_bug.cgi?id=58875
  27540. Broken backspace in Search box of Web Inspector (Requested by
  27541. apavlov on #webkit).
  27542. * inspector/front-end/inspector.js:
  27543. (WebInspector.documentKeyDown):
  27544. 2011-04-19 Andrey Adaikin <aandrey@google.com>
  27545. Reviewed by Pavel Feldman.
  27546. Web Inspector: NPE in TextEditorModel
  27547. https://bugs.webkit.org/show_bug.cgi?id=58870
  27548. * inspector/front-end/ResourcesPanel.js:
  27549. (WebInspector.ResourcesPanel.prototype._frameAdded):
  27550. * inspector/front-end/TextEditorModel.js:
  27551. (WebInspector.TextEditorModel.prototype.setText):
  27552. 2011-04-19 Hans Wennborg <hans@chromium.org>
  27553. Reviewed by Tony Gentilcore.
  27554. IndexedDB: Remove accidental header include directive from LevelDB backend.
  27555. https://bugs.webkit.org/show_bug.cgi?id=58872
  27556. No new functionality, no new tests.
  27557. * storage/IDBLevelDBBackingStore.cpp:
  27558. 2011-04-19 Herczeg Zoltan <zherczeg@webkit.org>
  27559. Build fix.
  27560. LEFilter change doesn't compile on ARM neon targets
  27561. https://bugs.webkit.org/show_bug.cgi?id=58671
  27562. Thanks for Charlie Lee to fixing this.
  27563. * WebCore.gypi:
  27564. 2011-04-19 Daniel Bates <dbates@webkit.org>
  27565. Attempt to fix the Qt Linux Release Minimal build after changeset 84225
  27566. <http://trac.webkit.org/changeset/84225> (https://bugs.webkit.org/show_bug.cgi?id=52788).
  27567. * dom/EventDispatcher.cpp:
  27568. (WebCore::EventDispatcher::ensureEventAncestors): Add ENABLE(SVG) guards around call
  27569. to Node::svgShadowHost() since this method is only defined when building with SVG enabled.
  27570. 2011-04-18 Dominic Cooney <dominicc@chromium.org>
  27571. Reviewed by Dimitri Glazkov.
  27572. Makes SVG shadow roots and DOM shadow roots distinct.
  27573. https://bugs.webkit.org/show_bug.cgi?id=52788
  27574. Not a functional change. Covered by existing SVG tests.
  27575. * dom/EventDispatcher.cpp:
  27576. (WebCore::findElementInstance):
  27577. (WebCore::EventDispatcher::adjustToShadowBoundaries):
  27578. (WebCore::EventDispatcher::adjustRelatedTarget):
  27579. (WebCore::EventDispatcher::ensureEventAncestors):
  27580. * dom/Node.cpp:
  27581. (WebCore::Node::setShadowHost):
  27582. (WebCore::Node::svgShadowHost):
  27583. (WebCore::Node::shadowTreeRootNode):
  27584. * dom/Node.h:
  27585. (WebCore::Node::isSVGShadowRoot):
  27586. (WebCore::Node::parentNode):
  27587. (WebCore::Node::parentNodeGuaranteedHostFree):
  27588. * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
  27589. (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
  27590. (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  27591. * rendering/svg/SVGShadowTreeElements.cpp:
  27592. (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
  27593. (WebCore::SVGShadowTreeRootElement::create):
  27594. (WebCore::SVGShadowTreeRootElement::attachElement):
  27595. (WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
  27596. * rendering/svg/SVGShadowTreeElements.h:
  27597. (WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
  27598. * svg/SVGStyledElement.cpp:
  27599. (WebCore::SVGStyledElement::title):
  27600. 2011-04-18 Taiju TSUIKI <develop@tzik.jp>
  27601. Reviewed by Darin Fisher.
  27602. Vendor-prefix requestFileSystem in FileSystem API
  27603. https://bugs.webkit.org/show_bug.cgi?id=58517
  27604. Prefix from:
  27605. - window.requestFileSystem to window.webkitRequestFileSystem
  27606. - window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
  27607. - window.Flags to window.WebKitFlags
  27608. - WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
  27609. - WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
  27610. - WorkerContext.Flags to WorkerContext.WebKitFlags
  27611. * CMakeLists.txt:
  27612. * CodeGenerators.pri:
  27613. * DerivedSources.cpp:
  27614. * DerivedSources.make:
  27615. * GNUmakefile.list.am:
  27616. * WebCore.gypi:
  27617. * WebCore.pro:
  27618. * WebCore.vcproj/WebCore.vcproj:
  27619. * WebCore.xcodeproj/project.pbxproj:
  27620. * bindings/js/JSDirectoryEntryCustom.cpp:
  27621. (WebCore::JSDirectoryEntry::getFile):
  27622. (WebCore::JSDirectoryEntry::getDirectory):
  27623. * bindings/js/JSDirectoryEntrySyncCustom.cpp:
  27624. (WebCore::getFlags):
  27625. (WebCore::JSDirectoryEntrySync::getFile):
  27626. (WebCore::JSDirectoryEntrySync::getDirectory):
  27627. * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
  27628. (WebCore::V8DirectoryEntry::getDirectoryCallback):
  27629. (WebCore::V8DirectoryEntry::getFileCallback):
  27630. * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
  27631. (WebCore::getFlags):
  27632. (WebCore::V8DirectoryEntrySync::getDirectoryCallback):
  27633. (WebCore::V8DirectoryEntrySync::getFileCallback):
  27634. * fileapi/DOMFileSystemBase.cpp:
  27635. (WebCore::DOMFileSystemBase::getFile):
  27636. (WebCore::DOMFileSystemBase::getDirectory):
  27637. * fileapi/DOMFileSystemBase.h:
  27638. * fileapi/DirectoryEntry.cpp:
  27639. (WebCore::DirectoryEntry::getFile):
  27640. (WebCore::DirectoryEntry::getDirectory):
  27641. * fileapi/DirectoryEntry.h:
  27642. * fileapi/DirectoryEntry.idl:
  27643. * fileapi/DirectoryEntrySync.cpp:
  27644. (WebCore::DirectoryEntrySync::getFile):
  27645. (WebCore::DirectoryEntrySync::getDirectory):
  27646. * fileapi/DirectoryEntrySync.h:
  27647. * fileapi/DirectoryEntrySync.idl:
  27648. * fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h.
  27649. (WebCore::WebKitFlags::create):
  27650. (WebCore::WebKitFlags::isCreate):
  27651. (WebCore::WebKitFlags::setCreate):
  27652. (WebCore::WebKitFlags::isExclusive):
  27653. (WebCore::WebKitFlags::setExclusive):
  27654. (WebCore::WebKitFlags::WebKitFlags):
  27655. * fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
  27656. * page/DOMWindow.cpp:
  27657. (WebCore::DOMWindow::webkitRequestFileSystem):
  27658. (WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
  27659. * page/DOMWindow.h:
  27660. * page/DOMWindow.idl:
  27661. * workers/WorkerContext.cpp:
  27662. (WebCore::WorkerContext::webkitRequestFileSystem):
  27663. (WebCore::WorkerContext::webkitRequestFileSystemSync):
  27664. (WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
  27665. (WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
  27666. * workers/WorkerContext.h:
  27667. * workers/WorkerContext.idl:
  27668. 2011-04-18 Steve Lacey <sjl@chromium.org>
  27669. Reviewed by Dimitri Glazkov.
  27670. Decouple media controls usage from implementation.
  27671. This allows each port to implement thier own controls in a different
  27672. manner to the default webkit implementation.
  27673. Convert media controls hooks to a client interface
  27674. https://bugs.webkit.org/show_bug.cgi?id=58346
  27675. No new tests as there is no functional change.
  27676. * Android.mk:
  27677. * CMakeLists.txt:
  27678. * GNUmakefile.list.am:
  27679. * WebCore.gypi:
  27680. * WebCore.pro:
  27681. * WebCore.vcproj/WebCore.vcproj:
  27682. * WebCore.xcodeproj/project.pbxproj:
  27683. * html/HTMLMediaElement.cpp:
  27684. (WebCore::HTMLMediaElement::mediaControls):
  27685. (WebCore::HTMLMediaElement::ensureMediaControls):
  27686. (WebCore::HTMLMediaElement::preDispatchEventHandler):
  27687. * html/HTMLMediaElement.h:
  27688. * html/shadow/MediaControlElements.cpp:
  27689. (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
  27690. (WebCore::MediaControlPanelMuteButtonElement::create):
  27691. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
  27692. (WebCore::MediaControlTimelineElement::create):
  27693. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
  27694. (WebCore::MediaControlFullscreenButtonElement::create):
  27695. * html/shadow/MediaControlElements.h:
  27696. * html/shadow/MediaControlRootElement.cpp:
  27697. (WebCore::MediaControlRootElement::MediaControlRootElement):
  27698. (WebCore::MediaControls::create):
  27699. * html/shadow/MediaControlRootElement.h:
  27700. * html/shadow/MediaControls.cpp: Added.
  27701. (WebCore::MediaControls::MediaControls):
  27702. * html/shadow/MediaControls.h: Added.
  27703. (WebCore::MediaControls::~MediaControls):
  27704. 2011-04-18 Pascal Massimino <pascal.massimino@gmail.com>
  27705. Reviewed by Adam Barth.
  27706. Add incremental decoding to WebP decoder
  27707. https://bugs.webkit.org/show_bug.cgi?id=58851
  27708. No new tests, as it's not possible for the layout test framework to
  27709. force the decoders to decode incrementally.
  27710. * platform/image-decoders/webp/WEBPImageDecoder.cpp:
  27711. (WebCore::WEBPImageDecoder::WEBPImageDecoder):
  27712. (WebCore::WEBPImageDecoder::decode):
  27713. * platform/image-decoders/webp/WEBPImageDecoder.h:
  27714. 2011-04-18 Daniel Bates <dbates@rim.com>
  27715. Reviewed by Adam Roben.
  27716. With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
  27717. pressing-and-holding another mouse button
  27718. https://bugs.webkit.org/show_bug.cgi?id=58700
  27719. Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
  27720. while pressing and holding a mouse button B, where A != B. This issue only affects builds
  27721. that enable PAN_SCROLLING.
  27722. On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
  27723. the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
  27724. should only stop the autoscroll timer.
  27725. Test: fast/events/fire-mousedown-while-pressing-mouse-button.html
  27726. * page/EventHandler.cpp:
  27727. (WebCore::EventHandler::handleMousePressEvent):
  27728. 2011-04-18 Jon Lee <jonlee@apple.com>
  27729. Reviewed by Maciej Stachowiak.
  27730. With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
  27731. https://bugs.webkit.org/show_bug.cgi?id=58617
  27732. <rdar://problem/9048012>
  27733. * rendering/RenderLayer.cpp:
  27734. (WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders
  27735. 2011-04-18 Jon Lee <jonlee@apple.com>
  27736. Reviewed by Maciej Stachowiak.
  27737. Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
  27738. https://bugs.webkit.org/show_bug.cgi?id=58824
  27739. <rdar://problem/9292680>
  27740. * rendering/RenderListBox.cpp:
  27741. (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
  27742. 2011-04-18 John Bauman <jbauman@chromium.org>
  27743. Reviewed by Kenneth Russell.
  27744. Don't cast BitmapImageSingleFrameSkia to BitmapImage
  27745. https://bugs.webkit.org/show_bug.cgi?id=58821
  27746. BitmapImageSingleFrameSkia has isBitmap return true, but
  27747. can't be cast to a BitmapImage. Instead of using BitmapImage,
  27748. use isOpaque from SkBitmap to determine if the image has alpha.
  27749. No new tests.
  27750. * platform/graphics/skia/GraphicsContext3DSkia.cpp:
  27751. (WebCore::GraphicsContext3D::getImageData):
  27752. 2011-04-18 Jessie Berlin <jberlin@apple.com>
  27753. Reviewed by Steve Falkenburg.
  27754. If deleting the StorageTracker.db file fails, local storage is left in a strange state.
  27755. https://bugs.webkit.org/show_bug.cgi?id=58805
  27756. * storage/StorageTracker.cpp:
  27757. (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
  27758. When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
  27759. deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
  27760. depends on and to prevent clashes between a theoretical web page editing local storage
  27761. at the same time this method is called.
  27762. (WebCore::StorageTracker::syncDeleteAllOrigins):
  27763. If it is not possible to delete the StorageTracker.db file, empty it.
  27764. (WebCore::StorageTracker::deleteOriginOnMainThread):
  27765. Wrapper for deleteOrigin.
  27766. * storage/StorageTracker.h:
  27767. 2011-04-18 Geoffrey Garen <ggaren@apple.com>
  27768. Build fix.
  27769. Added back missing #include.
  27770. * bindings/js/DOMWrapperWorld.cpp:
  27771. 2011-04-18 Enrica Casucci <enrica@apple.com>
  27772. Reviewed by Maciej Stachowiak.
  27773. Dropping a file in a WKView (WebKit2) doesn't load the file.
  27774. https://bugs.webkit.org/show_bug.cgi?id=58842
  27775. <rdar://problem/8514409>
  27776. The URL string for the file contains an extra %00 at the end
  27777. that causes the network framework to fail to load the file.
  27778. * platform/win/ClipboardUtilitiesWin.cpp:
  27779. (WebCore::getURL):
  27780. 2011-04-18 Geoffrey Garen <ggaren@apple.com>
  27781. Discovered and rubber-stamped by Stephanie Lewis.
  27782. Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>
  27783. * bindings/js/DOMWrapperWorld.cpp:
  27784. (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
  27785. (WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our
  27786. window shells when clearing / destroying ourselves. r83990 removed this
  27787. behavior for documents since there are no per-document maps anymore,
  27788. but removing this behavior for window shells too was a typo.
  27789. 2011-04-18 Geoffrey Garen <ggaren@apple.com>
  27790. Reviewed by Oliver Hunt.
  27791. Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
  27792. https://bugs.webkit.org/show_bug.cgi?id=58828
  27793. * WebCore.exp.in: Blah.
  27794. * bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership
  27795. to JSNodeCustom, where other custom JSNode-related code goes.
  27796. (WebCore::JSDOMWrapperOwner::finalize):
  27797. (WebCore::DOMWrapperWorld::DOMWrapperWorld):
  27798. * bindings/js/DOMWrapperWorld.h:
  27799. (WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner):
  27800. (WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner
  27801. to JSDOMWrapperOwner, to match the name of JSDOMWrapper.
  27802. * bindings/js/JSArrayBufferViewHelper.h:
  27803. (WebCore::toJSArrayBufferView):
  27804. * bindings/js/JSCSSRuleCustom.cpp:
  27805. (WebCore::toJS):
  27806. * bindings/js/JSCSSValueCustom.cpp:
  27807. (WebCore::toJS):
  27808. * bindings/js/JSCanvasRenderingContextCustom.cpp:
  27809. (WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper-
  27810. related functions, since there is no meaningful distinction between the
  27811. two anymore -- they both use the same extensible interface.
  27812. * bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.
  27813. * bindings/js/JSDOMBinding.h:
  27814. (WebCore::getInlineCachedWrapper):
  27815. (WebCore::setInlineCachedWrapper):
  27816. (WebCore::clearInlineCachedWrapper):
  27817. (WebCore::wrapperOwner):
  27818. (WebCore::wrapperContext):
  27819. (WebCore::getCachedWrapper):
  27820. (WebCore::cacheWrapper):
  27821. (WebCore::uncacheWrapper):
  27822. (WebCore::createWrapper):
  27823. (WebCore::wrap): Created a generic, extensible mechanism for creating,
  27824. caching, retrieving, marking, and destroying DOM wrappers. This eliminates
  27825. the difference between DOM object wrappers and DOM node wrappers, and
  27826. lays the groundwork for getting rid of MarkStack::deprecatedAppend usage
  27827. for marking the remainder of our DOM objects.
  27828. * bindings/js/JSDOMWindowCustom.cpp:
  27829. (WebCore::JSDOMWindow::history):
  27830. (WebCore::JSDOMWindow::location):
  27831. * bindings/js/JSDataViewCustom.cpp:
  27832. (WebCore::toJS):
  27833. * bindings/js/JSDocumentCustom.cpp:
  27834. (WebCore::JSDocument::location):
  27835. (WebCore::toJS):
  27836. * bindings/js/JSElementCustom.cpp:
  27837. (WebCore::toJSNewlyCreated):
  27838. * bindings/js/JSEventCustom.cpp:
  27839. (WebCore::toJS):
  27840. * bindings/js/JSHTMLCollectionCustom.cpp:
  27841. (WebCore::toJS):
  27842. * bindings/js/JSImageDataCustom.cpp:
  27843. (WebCore::toJS): Updated for renames mentioned above.
  27844. * bindings/js/JSNamedNodeMapCustom.cpp:
  27845. (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
  27846. (WebCore::JSNamedNodeMapOwner::finalize):
  27847. (WebCore::wrapperOwner):
  27848. (WebCore::wrapperContext):
  27849. (WebCore::JSNamedNodeMap::markChildren):
  27850. (WebCore::toJS): Updated to use our new interface for customizing wrapper
  27851. lifetime management through function overloading without using
  27852. MarkStack::deprecatedAppend.
  27853. * bindings/js/JSNodeCustom.cpp:
  27854. (WebCore::isObservable):
  27855. (WebCore::isReachableFromDOM):
  27856. (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
  27857. (WebCore::JSNodeOwner::finalize):
  27858. (WebCore::createWrapperInline): Moved node-related code from JSDOMBinding
  27859. to here. Removed special case marking code for JSNamedNodeMap because
  27860. JSNamedNodeMap now knows how to maintain its own lifetime invariants.
  27861. * bindings/js/JSNodeCustom.h:
  27862. (WebCore::wrapperOwner):
  27863. (WebCore::wrapperContext):
  27864. (WebCore::getInlineCachedWrapper):
  27865. (WebCore::setInlineCachedWrapper):
  27866. (WebCore::clearInlineCachedWrapper):
  27867. (WebCore::toJS): Updated to use our new interface for customizing wrapper
  27868. lifetime management through function overloading without using
  27869. MarkStack::deprecatedAppend or special-case code for nodes.
  27870. * bindings/js/JSSVGPathSegCustom.cpp:
  27871. (WebCore::toJS):
  27872. * bindings/js/JSStyleSheetCustom.cpp:
  27873. (WebCore::toJS): Updated for renames mentioned above.
  27874. * bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for
  27875. renames mentioned above.
  27876. * dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now
  27877. because it needs to provide a custom WeakHandleOwner at wrapper creation time.
  27878. 2011-04-18 Jessie Berlin <jberlin@apple.com>
  27879. Rubber-stamped by Sam Weinig.
  27880. REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows.
  27881. https://bugs.webkit.org/show_bug.cgi?id=58747
  27882. Copy the WebCore Localizable.strings file into the output directory.
  27883. * WebCore.vcproj/WebCoreGenerated.vcproj:
  27884. * WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
  27885. * WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
  27886. * WebCore.vcproj/copyInspectorFiles.cmd: Removed.
  27887. * WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.
  27888. 2011-04-18 Robert Hogan <robert@webkit.org>
  27889. Reviewed by Andreas Kling.
  27890. [Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint
  27891. When scheduling a repaint for the plugin's widget, PluginViewQt
  27892. needs to make sure the widget's geometry is up to date. Otherwise
  27893. the paint event happens on the widget's old location.
  27894. https://bugs.webkit.org/show_bug.cgi?id=57179
  27895. Added a manual test.
  27896. * manual-tests/qt/plugin-painting.html: Added.
  27897. * plugins/qt/PluginViewQt.cpp:
  27898. (WebCore::PluginView::updatePluginWidget):
  27899. (WebCore::PluginView::invalidateRect):
  27900. 2011-04-18 Oliver Hunt <oliver@apple.com>
  27901. Fix Qt build
  27902. * bridge/qt/qt_class.cpp:
  27903. (JSC::Bindings::QtClass::fallbackObject):
  27904. * bridge/qt/qt_instance.cpp:
  27905. (JSC::Bindings::QtInstance::removeCachedMethod):
  27906. * bridge/qt/qt_instance.h:
  27907. 2011-04-18 Oliver Hunt <oliver@apple.com>
  27908. Reviewed by Gavin Barraclough.
  27909. Remove DeprecatedPtr
  27910. https://bugs.webkit.org/show_bug.cgi?id=58718
  27911. Replace use of DeprecatedPtr<> with Global<> as ownership rules
  27912. aren't obvious, have filed bug #58820 on seeing if this is safe.
  27913. * bridge/qt/qt_class.cpp:
  27914. (JSC::Bindings::QtClass::fallbackObject):
  27915. * bridge/qt/qt_instance.cpp:
  27916. (JSC::Bindings::QtInstance::removeCachedMethod):
  27917. (JSC::Bindings::QtInstance::markAggregate):
  27918. * bridge/qt/qt_instance.h:
  27919. 2011-04-14 Matthew Delaney <mdelaney@apple.com>
  27920. Reviewed by Simon Fraser.
  27921. [CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces
  27922. https://bugs.webkit.org/show_bug.cgi?id=58088
  27923. * platform/graphics/cg/ImageBufferDataCG.cpp:
  27924. (WebCore::convertScanline): un/premultiplies and converts a scanline of image data from/to BGRA to/from RGBA
  27925. (WebCore::unpremultitplyScanline):
  27926. (WebCore::premultitplyScanline):
  27927. (WebCore::ImageBufferData::getData):
  27928. (WebCore::ImageBufferData::putData):
  27929. 2011-04-18 Jeff Miller <jeffm@apple.com>
  27930. Reviewed by Dan Bernstein.
  27931. Allow all log channels to be initialized from WebCoreLogLevel Windows environment variable
  27932. https://bugs.webkit.org/show_bug.cgi?id=58811
  27933. * platform/win/LoggingWin.cpp:
  27934. (WebCore::InitializeLoggingChannelsIfNecessary): Support initializing LogResourceLoading, LogProgress, and LogFileAPI from WebCoreLogLevel Windows environment variable.
  27935. 2011-04-18 Andrew Scherkus <scherkus@chromium.org>
  27936. Reviewed by Eric Seidel.
  27937. Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
  27938. https://bugs.webkit.org/show_bug.cgi?id=58719
  27939. Test: fullscreen/full-screen-cancel.html
  27940. * dom/Document.cpp:
  27941. (WebCore::Document::Document): Remove m_isFullscreen.
  27942. (WebCore::Document::webkitWillEnterFullScreenForElement):
  27943. (WebCore::Document::webkitWillExitFullScreenForElement): Remove duplicate call to setAnimating().
  27944. (WebCore::Document::webkitDidExitFullScreenForElement): Reset m_fullScreenElement reference.
  27945. * dom/Document.h:
  27946. (WebCore::Document::webkitIsFullScreen): Use m_fullScreenElement instead of m_isFullscreen.
  27947. (WebCore::Document::webkitFullScreenKeyboardInputAllowed): Ditto.
  27948. 2011-04-18 Dan Bernstein <mitz@apple.com>
  27949. Reviewed by Eric Seidel.
  27950. <rdar://problem/9282486> REGRESSION (r81992): Facebook photo tags can get cut off when moving the mouse.
  27951. https://bugs.webkit.org/show_bug.cgi?id=58500
  27952. Test: fast/repaint/text-in-relative-positioned-inline.html
  27953. * rendering/RenderText.cpp:
  27954. (WebCore::RenderText::clippedOverflowRectForRepaint): Use the container’s repaint rect, not
  27955. the containing block’s. This matters when the containing block is outside the RenderText’s
  27956. enclosing layer, as is the case here.
  27957. 2011-04-15 Stephen White <senorblanco@chromium.org>
  27958. Reviewed by Kenneth Russell.
  27959. Speed up DrawingBuffer::reset().
  27960. https://bugs.webkit.org/show_bug.cgi?id=58706
  27961. When DrawingBuffer::reset() is called, it should not reallocate
  27962. the FBOs if the size has not changed. It should just do a glClear().
  27963. Covered by tests in fast/canvas and canvas/philip.
  27964. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  27965. (WebCore::DrawingBuffer::DrawingBuffer):
  27966. Initialize the size to -1, -1, so the size change check will work on
  27967. first reset.
  27968. * platform/graphics/gpu/DrawingBuffer.cpp:
  27969. (WebCore::DrawingBuffer::reset):
  27970. If the size hasn't changed, don't resize the FBOs. Just clear the
  27971. relevant buffers.
  27972. 2011-04-18 Pavel Feldman <pfeldman@google.com>
  27973. Reviewed by Yury Semikhatsky.
  27974. Web Inspector: group resources by type in the resources panel.
  27975. https://bugs.webkit.org/show_bug.cgi?id=58796
  27976. * inspector/front-end/ResourcesPanel.js:
  27977. (WebInspector.ResourcesPanel.prototype._frameAdded):
  27978. (WebInspector.ResourcesPanel.prototype._resourceAdded):
  27979. (WebInspector.BaseStorageTreeElement):
  27980. (WebInspector.BaseStorageTreeElement.prototype.onattach):
  27981. (WebInspector.StorageCategoryTreeElement):
  27982. (WebInspector.FrameTreeElement):
  27983. (WebInspector.FrameTreeElement.prototype.setTitles):
  27984. (WebInspector.FrameTreeElement.prototype.set hovered):
  27985. (WebInspector.FrameTreeElement.prototype.appendResource):
  27986. (WebInspector.FrameTreeElement.prototype.appendChild):
  27987. (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder):
  27988. (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder.compare):
  27989. 2011-04-18 Timothy Hatcher <timothy@apple.com>
  27990. Make update-webkit-localizable-strings put WebKit/win strings in WebCore
  27991. now that all localized strings in WebKit/win use WEB_UI_STRING.
  27992. https://webkit.org/b/58747
  27993. Reviewed by Dan Bernstein.
  27994. * English.lproj/Localizable.strings: Updated with strings from WebKit/win.
  27995. 2011-04-15 MORITA Hajime <morrita@google.com>
  27996. Reviewed by Adam Barth.
  27997. REGRESSION: <progress> doesn't animate if it doesn't have value
  27998. https://bugs.webkit.org/show_bug.cgi?id=58693
  27999. The initial value of RenderProgress::m_position is accidentally same as
  28000. the indeterminate value, that makes update code on updateFromElement() skipped.
  28001. This change set unique invalid value for the initial value of m_position.
  28002. No new tests. Testing animated bar is not possible with DRT.
  28003. * html/HTMLProgressElement.cpp:
  28004. (WebCore::HTMLProgressElement::position):
  28005. * html/HTMLProgressElement.h:
  28006. * rendering/RenderProgress.cpp:
  28007. (WebCore::RenderProgress::RenderProgress):
  28008. (WebCore::RenderProgress::isDeterminate):
  28009. 2011-04-18 MORITA Hajime <morrita@google.com>
  28010. Reviewed by Eric Seidel.
  28011. REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
  28012. https://bugs.webkit.org/show_bug.cgi?id=58791
  28013. On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
  28014. We should guard it again RefPtr.
  28015. * html/HTMLDetailsElement.cpp:
  28016. (WebCore::HTMLDetailsElement::refreshMainSummary):
  28017. 2011-04-18 Antti Koivisto <antti@apple.com>
  28018. Reviewed by Simon Fraser.
  28019. CSSSelector double frees
  28020. https://bugs.webkit.org/show_bug.cgi?id=56124
  28021. <rdar://problem/9119036>
  28022. In all stacks this is occuring when the document is kept alive by the guard ref only
  28023. and the node holding it is deleted.
  28024. As a speculative fix, clear the document stylesheets when it turns into a guard ref zombie.
  28025. This has a pretty good chance of fixing the actual bug. At minimum it will move the
  28026. crash to an earlier, more easily traceble point.
  28027. No tests, crash stacks only, no idea how to reproduce.
  28028. * dom/Document.cpp:
  28029. (WebCore::Document::removedLastRef):
  28030. 2011-04-18 Alexander Pavlov <apavlov@chromium.org>
  28031. Reviewed by Yury Semikhatsky.
  28032. Web Inspector: Backspace in the Console is broken
  28033. https://bugs.webkit.org/show_bug.cgi?id=58764
  28034. * inspector/front-end/inspector.js:
  28035. (WebInspector.documentKeyDown):
  28036. 2011-04-18 Hans Wennborg <hans@chromium.org>
  28037. Reviewed by Steve Block.
  28038. LevelDB backend for IndexedDB
  28039. https://bugs.webkit.org/show_bug.cgi?id=57372
  28040. Only available behind a run-time flag. Covered by existing layout
  28041. tests.
  28042. * Android.mk:
  28043. * CMakeLists.txt:
  28044. * GNUmakefile.am:
  28045. * GNUmakefile.list.am:
  28046. * WebCore.gyp/WebCore.gyp:
  28047. * WebCore.gypi:
  28048. * WebCore.pri:
  28049. * WebCore.pro:
  28050. * WebCore.xcodeproj/project.pbxproj:
  28051. * platform/leveldb/LevelDBComparator.h: Added.
  28052. (WebCore::LevelDBComparator::~LevelDBComparator):
  28053. * platform/leveldb/LevelDBDatabase.cpp: Added.
  28054. (WebCore::makeSlice):
  28055. (WebCore::makeLevelDBSlice):
  28056. (WebCore::makeVector):
  28057. (WebCore::LevelDBDatabase::LevelDBDatabase):
  28058. (WebCore::LevelDBDatabase::~LevelDBDatabase):
  28059. (WebCore::LevelDBDatabase::open):
  28060. (WebCore::LevelDBDatabase::put):
  28061. (WebCore::LevelDBDatabase::remove):
  28062. (WebCore::LevelDBDatabase::get):
  28063. (WebCore::LevelDBDatabase::newIterator):
  28064. * platform/leveldb/LevelDBDatabase.h: Added.
  28065. * platform/leveldb/LevelDBIterator.cpp: Added.
  28066. (WebCore::LevelDBIterator::~LevelDBIterator):
  28067. (WebCore::LevelDBIterator::LevelDBIterator):
  28068. (WebCore::makeSlice):
  28069. (WebCore::makeLevelDBSlice):
  28070. (WebCore::LevelDBIterator::isValid):
  28071. (WebCore::LevelDBIterator::seekToLast):
  28072. (WebCore::LevelDBIterator::seek):
  28073. (WebCore::LevelDBIterator::next):
  28074. (WebCore::LevelDBIterator::prev):
  28075. (WebCore::LevelDBIterator::key):
  28076. (WebCore::LevelDBIterator::value):
  28077. * platform/leveldb/LevelDBIterator.h: Added.
  28078. * platform/leveldb/LevelDBSlice.h: Added.
  28079. (WebCore::LevelDBSlice::LevelDBSlice):
  28080. (WebCore::LevelDBSlice::~LevelDBSlice):
  28081. (WebCore::LevelDBSlice::begin):
  28082. (WebCore::LevelDBSlice::end):
  28083. * storage/IDBLevelDBBackingStore.cpp:
  28084. (WebCore::encodeByte):
  28085. (WebCore::maxIDBKey):
  28086. (WebCore::minIDBKey):
  28087. (WebCore::encodeInt):
  28088. (WebCore::decodeInt):
  28089. (WebCore::encodeVarInt):
  28090. (WebCore::decodeVarInt):
  28091. (WebCore::encodeString):
  28092. (WebCore::decodeString):
  28093. (WebCore::encodeStringWithLength):
  28094. (WebCore::decodeStringWithLength):
  28095. (WebCore::encodeDouble):
  28096. (WebCore::decodeDouble):
  28097. (WebCore::encodeIDBKey):
  28098. (WebCore::decodeIDBKey):
  28099. (WebCore::extractEncodedIDBKey):
  28100. (WebCore::compareEncodedIDBKeys):
  28101. (WebCore::getInt):
  28102. (WebCore::putInt):
  28103. (WebCore::getString):
  28104. (WebCore::putString):
  28105. (WebCore::KeyPrefix::SchemaVersionKey::encode):
  28106. (WebCore::KeyPrefix::MaxDatabaseIdKey::encode):
  28107. (WebCore::KeyPrefix::DatabaseFreeListKey::DatabaseFreeListKey):
  28108. (WebCore::KeyPrefix::DatabaseFreeListKey::decode):
  28109. (WebCore::KeyPrefix::DatabaseFreeListKey::encode):
  28110. (WebCore::KeyPrefix::DatabaseFreeListKey::databaseId):
  28111. (WebCore::KeyPrefix::DatabaseFreeListKey::compare):
  28112. (WebCore::KeyPrefix::DatabaseNameKey::decode):
  28113. (WebCore::KeyPrefix::DatabaseNameKey::encode):
  28114. (WebCore::KeyPrefix::DatabaseNameKey::origin):
  28115. (WebCore::KeyPrefix::DatabaseNameKey::databaseName):
  28116. (WebCore::KeyPrefix::DatabaseNameKey::compare):
  28117. (WebCore::KeyPrefix::DatabaseMetaDataKey::encode):
  28118. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
  28119. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::decode):
  28120. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::encode):
  28121. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::objectStoreId):
  28122. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::metaDataType):
  28123. (WebCore::KeyPrefix::ObjectStoreMetaDataKey::compare):
  28124. (WebCore::KeyPrefix::IndexMetaDataKey::IndexMetaDataKey):
  28125. (WebCore::KeyPrefix::IndexMetaDataKey::decode):
  28126. (WebCore::KeyPrefix::IndexMetaDataKey::encode):
  28127. (WebCore::KeyPrefix::IndexMetaDataKey::compare):
  28128. (WebCore::KeyPrefix::IndexMetaDataKey::indexId):
  28129. (WebCore::KeyPrefix::IndexMetaDataKey::metaDataType):
  28130. (WebCore::KeyPrefix::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
  28131. (WebCore::KeyPrefix::ObjectStoreFreeListKey::decode):
  28132. (WebCore::KeyPrefix::ObjectStoreFreeListKey::encode):
  28133. (WebCore::KeyPrefix::ObjectStoreFreeListKey::objectStoreId):
  28134. (WebCore::KeyPrefix::ObjectStoreFreeListKey::compare):
  28135. (WebCore::KeyPrefix::IndexFreeListKey::IndexFreeListKey):
  28136. (WebCore::KeyPrefix::IndexFreeListKey::decode):
  28137. (WebCore::KeyPrefix::IndexFreeListKey::encode):
  28138. (WebCore::KeyPrefix::IndexFreeListKey::compare):
  28139. (WebCore::KeyPrefix::IndexFreeListKey::objectStoreId):
  28140. (WebCore::KeyPrefix::IndexFreeListKey::indexId):
  28141. (WebCore::KeyPrefix::ObjectStoreNamesKey::decode):
  28142. (WebCore::KeyPrefix::ObjectStoreNamesKey::encode):
  28143. (WebCore::KeyPrefix::ObjectStoreNamesKey::compare):
  28144. (WebCore::KeyPrefix::ObjectStoreNamesKey::objectStoreName):
  28145. (WebCore::KeyPrefix::IndexNamesKey::IndexNamesKey):
  28146. (WebCore::KeyPrefix::IndexNamesKey::decode):
  28147. (WebCore::KeyPrefix::IndexNamesKey::encode):
  28148. (WebCore::KeyPrefix::IndexNamesKey::compare):
  28149. (WebCore::KeyPrefix::IndexNamesKey::indexName):
  28150. (WebCore::KeyPrefix::ObjectStoreDataKey::decode):
  28151. (WebCore::KeyPrefix::ObjectStoreDataKey::encode):
  28152. (WebCore::KeyPrefix::ObjectStoreDataKey::compare):
  28153. (WebCore::KeyPrefix::ObjectStoreDataKey::userKey):
  28154. (WebCore::KeyPrefix::ExistsEntryKey::decode):
  28155. (WebCore::KeyPrefix::ExistsEntryKey::encode):
  28156. (WebCore::KeyPrefix::ExistsEntryKey::compare):
  28157. (WebCore::KeyPrefix::ExistsEntryKey::userKey):
  28158. (WebCore::KeyPrefix::IndexDataKey::IndexDataKey):
  28159. (WebCore::KeyPrefix::IndexDataKey::decode):
  28160. (WebCore::KeyPrefix::IndexDataKey::encode):
  28161. (WebCore::KeyPrefix::IndexDataKey::encodeMaxKey):
  28162. (WebCore::KeyPrefix::IndexDataKey::compare):
  28163. (WebCore::KeyPrefix::IndexDataKey::databaseId):
  28164. (WebCore::KeyPrefix::IndexDataKey::objectStoreId):
  28165. (WebCore::KeyPrefix::IndexDataKey::indexId):
  28166. (WebCore::KeyPrefix::IndexDataKey::userKey):
  28167. (WebCore::KeyPrefix::realCompare):
  28168. (WebCore::KeyPrefix::compareKeys):
  28169. (WebCore::KeyPrefix::compareIndexKeys):
  28170. (WebCore::KeyPrefix::Comparator::compare):
  28171. (WebCore::KeyPrefix::Comparator::name):
  28172. (WebCore::setUpMetadata):
  28173. (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  28174. (WebCore::IDBLevelDBBackingStore::open):
  28175. (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
  28176. (WebCore::getNewDatabaseId):
  28177. (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
  28178. (WebCore::IDBLevelDBBackingStore::getObjectStores):
  28179. (WebCore::getNewObjectStoreId):
  28180. (WebCore::IDBLevelDBBackingStore::createObjectStore):
  28181. (WebCore::deleteRange):
  28182. (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
  28183. (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
  28184. (WebCore::getNewVersionNumber):
  28185. (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
  28186. (WebCore::IDBLevelDBBackingStore::clearObjectStore):
  28187. (WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
  28188. (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
  28189. (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
  28190. (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
  28191. (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
  28192. (WebCore::IDBLevelDBBackingStore::getIndexes):
  28193. (WebCore::getNewIndexId):
  28194. (WebCore::IDBLevelDBBackingStore::createIndex):
  28195. (WebCore::IDBLevelDBBackingStore::deleteIndex):
  28196. (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
  28197. (WebCore::findGreatestKeyLessThan):
  28198. (WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
  28199. (WebCore::IDBLevelDBBackingStore::getObjectViaIndex):
  28200. (WebCore::versionExists):
  28201. (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
  28202. (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
  28203. (WebCore::findLastIndexKeyEqualTo):
  28204. (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
  28205. (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
  28206. (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  28207. (WebCore::IDBLevelDBBackingStore::createTransaction):
  28208. * storage/IDBLevelDBBackingStore.h:
  28209. 2011-04-18 Pavel Feldman <pfeldman@google.com>
  28210. Reviewed by Yury Semikhatsky.
  28211. Web Inspector: add test for CSS-resource binding.
  28212. https://bugs.webkit.org/show_bug.cgi?id=58786
  28213. Test: inspector/styles/styles-history.html
  28214. * inspector/InspectorCSSAgent.cpp:
  28215. (WebCore::InspectorCSSAgent::setPropertyText):
  28216. (WebCore::InspectorCSSAgent::toggleProperty):
  28217. * inspector/InspectorStyleSheet.cpp:
  28218. (WebCore::InspectorStyle::setPropertyText):
  28219. (WebCore::InspectorStyle::toggleProperty):
  28220. (WebCore::InspectorStyleSheet::setPropertyText):
  28221. (WebCore::InspectorStyleSheet::toggleProperty):
  28222. * inspector/InspectorStyleSheet.h:
  28223. * inspector/front-end/CSSStyleModel.js:
  28224. (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.if):
  28225. (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.mycallback):
  28226. (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
  28227. (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
  28228. (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
  28229. (WebInspector.CSSProperty.prototype.setText.callback):
  28230. (WebInspector.CSSProperty.prototype.setText):
  28231. 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  28232. Unreviewed, rolling out r83996.
  28233. http://trac.webkit.org/changeset/83996
  28234. https://bugs.webkit.org/show_bug.cgi?id=58790
  28235. layout test editing/selection/move-by-word-visually.html is
  28236. failing (Requested by jknotten on #webkit).
  28237. * editing/visible_units.cpp:
  28238. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
  28239. (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
  28240. (WebCore::previousWordBreakInBox):
  28241. (WebCore::leftWordBoundary):
  28242. (WebCore::rightWordBoundary):
  28243. (WebCore::leftWordPosition):
  28244. (WebCore::rightWordPosition):
  28245. 2011-04-18 Adam Bergkvist <adam.bergkvist@ericsson.com>
  28246. Reviewed by Daniel Bates.
  28247. Modify make_names.pl to not include conditional includes unconditionally
  28248. https://bugs.webkit.org/show_bug.cgi?id=53672
  28249. Fixed conditional includes being unconditionally included.
  28250. No new tests (no change in functionality)
  28251. * dom/make_names.pl:
  28252. - Modified printJSElementIncludes() to only print unconditional element includes.
  28253. - Modified printElementIncludes() to only print unconditional element includes.
  28254. - Added printConditionalElementIncludes() which takes care of printing conditional element includes.
  28255. 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  28256. Unreviewed, rolling out r83803.
  28257. http://trac.webkit.org/changeset/83803
  28258. https://bugs.webkit.org/show_bug.cgi?id=58782
  28259. Caused focus rings to appear in youtube videos (Requested by
  28260. inferno-sec on #webkit).
  28261. * rendering/RenderWidget.cpp:
  28262. (WebCore::RenderWidget::paint):
  28263. 2011-04-18 Alexander Pavlov <apavlov@chromium.org>
  28264. Reviewed by Pavel Feldman.
  28265. Web Inspector: Need a workaround for bug 58422
  28266. https://bugs.webkit.org/show_bug.cgi?id=58780
  28267. Instead of the A:before content, the link text is displayed as the A tag content.
  28268. * inspector/front-end/StylesSidebarPane.js:
  28269. (WebInspector.StylePropertiesSection.linkifyUncopyable):
  28270. (WebInspector.StylePropertiesSection):
  28271. * inspector/front-end/inspector.css:
  28272. 2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
  28273. Unreviewed. Fix WebKit2 GTK build after 82465.
  28274. * platform/gtk/LocalizedStringsGtk.cpp:
  28275. (WebCore::localizedString):
  28276. 2011-04-18 Andrey Adaikin <aandrey@google.com>
  28277. Reviewed by Yury Semikhatsky.
  28278. Web Inspector: TAB should not move focus from the text editor while live editing
  28279. https://bugs.webkit.org/show_bug.cgi?id=58537
  28280. * inspector/front-end/TextViewer.js:
  28281. (WebInspector.TextViewer.prototype._registerShortcuts):
  28282. (WebInspector.TextViewer.prototype._cancelEditing):
  28283. (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
  28284. (WebInspector.TextEditorMainPanel.prototype.handleTabKeyPress):
  28285. (WebInspector.TextEditorMainPanel.prototype._setCaretLocation):
  28286. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  28287. (WebInspector.TextEditorMainPanel.prototype._setText):
  28288. 2011-04-18 Alexander Pavlov <apavlov@chromium.org>
  28289. Reviewed by Yury Semikhatsky.
  28290. Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
  28291. https://bugs.webkit.org/show_bug.cgi?id=58551
  28292. Test: inspector/styles/metrics-box-sizing.html
  28293. * inspector/front-end/MetricsSidebarPane.js:
  28294. (WebInspector.MetricsSidebarPane.prototype._getPropertyValueAsPx):
  28295. (WebInspector.MetricsSidebarPane.prototype._getBox):
  28296. (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaWidthPx):
  28297. (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaHeightPx):
  28298. (WebInspector.MetricsSidebarPane.prototype._update):
  28299. (WebInspector.MetricsSidebarPane.prototype.startEditing):
  28300. (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback):
  28301. (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  28302. 2011-04-18 Ilya Tikhonovsky <loislo@chromium.org>
  28303. Reviewed by Yury Semikhatsky.
  28304. Web Inspector: Database agent stops to propagate it's events after navigation.
  28305. https://bugs.webkit.org/show_bug.cgi?id=58776
  28306. * inspector/InspectorAgent.cpp:
  28307. (WebCore::InspectorAgent::InspectorAgent):
  28308. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  28309. * inspector/InspectorDatabaseAgent.cpp:
  28310. (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  28311. (WebCore::InspectorDatabaseAgent::clearFrontend):
  28312. (WebCore::InspectorDatabaseAgent::enable):
  28313. (WebCore::InspectorDatabaseAgent::disable):
  28314. (WebCore::InspectorDatabaseAgent::restore):
  28315. * inspector/InspectorDatabaseAgent.h:
  28316. (WebCore::InspectorDatabaseAgent::create):
  28317. 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  28318. Unreviewed, rolling out r83968.
  28319. http://trac.webkit.org/changeset/83968
  28320. https://bugs.webkit.org/show_bug.cgi?id=58769
  28321. Breaks Backspace in Web Inspector console (Requested by
  28322. apavlov on #webkit).
  28323. * inspector/front-end/inspector.js:
  28324. (WebInspector.documentKeyDown):
  28325. 2011-04-15 Yury Semikhatsky <yurys@chromium.org>
  28326. Reviewed by Pavel Feldman.
  28327. Web Inspector: introduce WorkerInspectorController
  28328. https://bugs.webkit.org/show_bug.cgi?id=58668
  28329. WorkerInspectorController will be owned by WorkerContext and will hold all inspector
  28330. agents and will also manage connection to the inspector frontend.
  28331. * CMakeLists.txt:
  28332. * GNUmakefile.list.am:
  28333. * WebCore.gypi:
  28334. * WebCore.pro:
  28335. * WebCore.vcproj/WebCore.vcproj:
  28336. * WebCore.xcodeproj/project.pbxproj:
  28337. * bindings/js/ScriptState.cpp:
  28338. (WebCore::scriptStateFromWorkerContext):
  28339. * bindings/js/ScriptState.h:
  28340. * bindings/v8/ScriptState.cpp:
  28341. (WebCore::scriptStateFromWorkerContext):
  28342. * bindings/v8/ScriptState.h:
  28343. * inspector/InspectorState.cpp:
  28344. (WebCore::InspectorState::updateCookie):
  28345. * inspector/WorkerInspectorController.cpp: Added.
  28346. (WebCore::WorkerInspectorController::WorkerInspectorController):
  28347. (WebCore::WorkerInspectorController::~WorkerInspectorController):
  28348. (WebCore::WorkerInspectorController::connectFrontend):
  28349. (WebCore::WorkerInspectorController::disconnectFrontend):
  28350. (WebCore::WorkerInspectorController::dispatchMessageFromFrontend):
  28351. * inspector/WorkerInspectorController.h: Copied from Source/WebCore/bindings/js/ScriptState.h.
  28352. * workers/WorkerContext.cpp:
  28353. (WebCore::WorkerContext::WorkerContext):
  28354. * workers/WorkerContext.h:
  28355. (WebCore::WorkerContext::workerInspectorController):
  28356. 2011-04-17 Thierry Reding <thierry.reding@avionic-design.de>
  28357. Reviewed by Adam Barth.
  28358. Fix build with GCC 4.6.
  28359. * dom/make_names.pl: Execute preprocessor without the -P option. The
  28360. preprocessor in GCC 4.6 eats empty lines, effectively breaking the
  28361. parsing performed by this script. Dropping the -P option when invoking
  28362. the preprocessor keeps the empty lines but as a side-effect also adds
  28363. additional linemarkers.
  28364. From the cpp manpage:
  28365. -P Inhibit generation of linemarkers in the output from the
  28366. preprocessor. This might be useful when running the preprocessor
  28367. on something that is not C code, and will be sent to a program
  28368. which might be confused by the linemarkers.
  28369. The linemarkers are not problematic, however, because the script
  28370. properly handles them by ignoring all lines starting with a #.
  28371. 2011-04-17 David Kilzer <ddkilzer@apple.com>
  28372. <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
  28373. <rdar://problem/9268729>
  28374. Reviewed by Dan Bernstein.
  28375. This replaces support for the WebKitEnableHTTPPipelining user
  28376. default with methods on the WebCore::ResourceRequest class in
  28377. WebCore, the WebView class in WebKit1, and the WebContext class
  28378. in WebKit2. It also removes support for the
  28379. WebKitForceHTTPPipeliningPriorityHigh user default which was not
  28380. needed.
  28381. Run these commands if you set the user defaults previously,
  28382. replacing "BUNDLE.ID" with your application's bundle ID:
  28383. defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
  28384. defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh
  28385. * WebCore.exp.in: Export ResourceRequest::httpPipeliningEnabled()
  28386. and ResourceRequest::setHTTPPipeliningEnabled().
  28387. * platform/network/ResourceRequestBase.h:
  28388. (WebCore::isHTTPPipeliningEnabled): Removed declaration.
  28389. (WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.
  28390. * platform/network/cf/ResourceRequest.h:
  28391. (WebCore::ResourceRequest::httpPipeliningEnabled): Added declaration.
  28392. (WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added declaration.
  28393. (WebCore::ResourceRequest::s_httpPipeliningEnabled): Added declaration.
  28394. * platform/network/cf/ResourceRequestCFNet.cpp:
  28395. (WebCore::ResourceRequest::s_httpPipeliningEnabled): Added.
  28396. (WebCore::ResourceRequest::httpPipeliningEnabled): Added.
  28397. (WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added.
  28398. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
  28399. to use ResourceRequest::httpPipeliningEnabled().
  28400. (WebCore::readBooleanPreference): Removed.
  28401. (WebCore::isHTTPPipeliningEnabled): Removed.
  28402. (WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.
  28403. * platform/network/mac/ResourceRequestMac.mm:
  28404. (WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
  28405. use ResourceRequest::httpPipeliningEnabled(). Removed check for
  28406. shouldForceHTTPPipeliningPriorityHigh().
  28407. (WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.
  28408. 2011-04-17 Dan Bernstein <mitz@apple.com>
  28409. Reviewed by Maciej Stachowiak.
  28410. REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html
  28411. https://bugs.webkit.org/show_bug.cgi?id=58736
  28412. * rendering/RenderBlockLineLayout.cpp:
  28413. (WebCore::RenderBlock::appendFloatingObjectToLastLine): It is enough to extend the float so
  28414. that it touches the bottom of the previous line, since RenderBlock::markLinesDirtyInBlockRange()
  28415. always dirties the line after the last one in the range.
  28416. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  28417. Unreviewed. Add missing include to fix build without precompiled header.
  28418. * rendering/RenderMediaControls.cpp:
  28419. 2011-04-17 Daniel Bates <dbates@webkit.org>
  28420. Attempt to fix the Chromium build after changeset 84110 <http://trac.webkit.org/changeset/84110>
  28421. (https://bugs.webkit.org/show_bug.cgi?id=57842).
  28422. * loader/cache/CachedResourceLoader.cpp:
  28423. (WebCore::CachedResourceLoader::canRequest): Rename CachedResource::LinkPrefetch to CachedResource::LinkResource.
  28424. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  28425. Reviewed by Eric Seidel.
  28426. Remove pthread dependency of GCController
  28427. https://bugs.webkit.org/show_bug.cgi?id=54833
  28428. * bindings/js/GCController.cpp:
  28429. (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
  28430. 2011-04-17 Gavin Peters <gavinp@chromium.org>
  28431. Reviewed by Adam Barth.
  28432. Add support for link rel type "subresource"
  28433. https://bugs.webkit.org/show_bug.cgi?id=57842
  28434. Link rel=prefetch is great for cache warming for resources on
  28435. subsequent pages, but it launches requests at too low a priority
  28436. to use for subresources of the current page.
  28437. Particularly after https://bugs.webkit.org/show_bug.cgi?id=51940
  28438. is implemented, a rel type that launches requests at an higher
  28439. priority is going to be very useful. This rel type is in the
  28440. HTML5 spec at http://wiki.whatwg.org/wiki/RelExtensions . An
  28441. expected use case will be for servers to provide subresource hints
  28442. in link headers, which will allow servers to help make the web
  28443. faster.
  28444. This feature continues my implementation of the Link header, which
  28445. we've talked about in WebKit-dev in
  28446. https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html.
  28447. Tests: fast/dom/HTMLLinkElement/subresource.html
  28448. http/tests/misc/link-rel-prefetch-and-subresource.html
  28449. * html/HTMLLinkElement.cpp:
  28450. (WebCore::HTMLLinkElement::~HTMLLinkElement):
  28451. (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  28452. (WebCore::HTMLLinkElement::process):
  28453. (WebCore::HTMLLinkElement::onloadTimerFired):
  28454. (WebCore::HTMLLinkElement::notifyFinished):
  28455. * html/HTMLLinkElement.h:
  28456. (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  28457. * loader/cache/CachedResource.cpp:
  28458. (WebCore::defaultPriorityForResourceType):
  28459. * loader/cache/CachedResource.h:
  28460. (WebCore::CachedResource::isLinkResource):
  28461. * loader/cache/CachedResourceLoader.cpp:
  28462. (WebCore::createResource):
  28463. (WebCore::CachedResourceLoader::requestLinkResource):
  28464. (WebCore::CachedResourceLoader::canRequest):
  28465. (WebCore::CachedResourceLoader::incrementRequestCount):
  28466. (WebCore::CachedResourceLoader::decrementRequestCount):
  28467. * loader/cache/CachedResourceLoader.h:
  28468. * loader/cache/CachedResourceRequest.cpp:
  28469. (WebCore::cachedResourceTypeToTargetType):
  28470. (WebCore::CachedResourceRequest::load):
  28471. 2011-04-17 Dan Bernstein <mitz@apple.com>
  28472. Reviewed by Joseph Pecoraro.
  28473. <rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
  28474. https://bugs.webkit.org/show_bug.cgi?id=58745
  28475. This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
  28476. which was fixed in r83514.
  28477. * rendering/RenderBlockLineLayout.cpp:
  28478. (WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
  28479. variable so named, not the top layout overflow.
  28480. 2011-04-17 Geoffrey Garen <ggaren@apple.com>
  28481. Strongly suggested, but not necessarily reviewed, by
  28482. Sam Weinig and Maciej Stachowiak.
  28483. Renamed DOMObject* => JSDOMWrapper*.
  28484. * bindings/js/DOMWrapperWorld.cpp:
  28485. (WebCore::isObservable):
  28486. (WebCore::DOMObjectHandleOwner::finalize):
  28487. * bindings/js/DOMWrapperWorld.h:
  28488. * bindings/js/JSArrayBufferViewHelper.h:
  28489. (WebCore::toJSArrayBufferView):
  28490. * bindings/js/JSCSSRuleCustom.cpp:
  28491. (WebCore::toJS):
  28492. * bindings/js/JSCSSValueCustom.cpp:
  28493. (WebCore::toJS):
  28494. * bindings/js/JSDOMBinding.h:
  28495. (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
  28496. (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
  28497. (WebCore::DOMConstructorObject::DOMConstructorObject):
  28498. (WebCore::createDOMObjectWrapper):
  28499. (WebCore::getDOMObjectWrapper):
  28500. * bindings/js/JSDOMWrapper.cpp:
  28501. (WebCore::JSDOMWrapper::~JSDOMWrapper):
  28502. * bindings/js/JSDOMWrapper.h:
  28503. (WebCore::JSDOMWrapper::JSDOMWrapper):
  28504. * bindings/js/JSDocumentCustom.cpp:
  28505. (WebCore::JSDocument::location):
  28506. (WebCore::toJS):
  28507. * bindings/js/JSEventCustom.cpp:
  28508. (WebCore::toJS):
  28509. * bindings/js/JSHTMLCollectionCustom.cpp:
  28510. (WebCore::toJS):
  28511. * bindings/js/JSImageDataCustom.cpp:
  28512. (WebCore::toJS):
  28513. * bindings/js/JSSVGPathSegCustom.cpp:
  28514. (WebCore::toJS):
  28515. * bindings/js/JSStyleSheetCustom.cpp:
  28516. (WebCore::toJS):
  28517. * bindings/js/ScriptWrappable.h:
  28518. (WebCore::ScriptWrappable::wrapper):
  28519. (WebCore::ScriptWrappable::setWrapper):
  28520. * bindings/scripts/CodeGeneratorJS.pm:
  28521. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  28522. Reviewed by Adam Barth.
  28523. Rename PLATFORM(CA) to USE(CA)
  28524. https://bugs.webkit.org/show_bug.cgi?id=58742
  28525. * config.h:
  28526. * platform/graphics/ca/TransformationMatrixCA.cpp:
  28527. * platform/graphics/cg/ImageBufferDataCG.h:
  28528. * platform/graphics/transforms/TransformationMatrix.h:
  28529. * platform/mac/WebCoreSystemInterface.h:
  28530. * rendering/RenderLayerBacking.cpp:
  28531. (WebCore::RenderLayerBacking::containsPaintedContent):
  28532. * rendering/RenderLayerCompositor.cpp:
  28533. (WebCore::RenderLayerCompositor::updateBacking):
  28534. 2011-04-17 Young Han Lee <joybro@company100.net>
  28535. Reviewed by Benjamin Poulain.
  28536. [Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
  28537. https://bugs.webkit.org/show_bug.cgi?id=58739
  28538. gInVertexAttributeIndex is a constant variable to point the location of
  28539. "InVertex" attribute of the vertex shaders.
  28540. * platform/graphics/opengl/TextureMapperGL.cpp:
  28541. (WebCore::TextureMapperGL::drawTexture):
  28542. (WebCore::TextureMapperGL::paintToTarget):
  28543. 2011-04-17 Kinuko Yasuda <kinuko@chromium.org>
  28544. Not reviewed: Fix copyright (I had submitted the file with wrong
  28545. copyright line).
  28546. * storage/StorageInfo.idl:
  28547. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  28548. Reviewed by Adam Barth.
  28549. Rename PLATFORM(CG) to USE(CG)
  28550. https://bugs.webkit.org/show_bug.cgi?id=58729
  28551. * config.h:
  28552. * html/HTMLCanvasElement.cpp:
  28553. (WebCore::HTMLCanvasElement::toDataURL):
  28554. * html/HTMLCanvasElement.h:
  28555. * html/canvas/CanvasRenderingContext2D.cpp:
  28556. (WebCore::CanvasRenderingContext2D::setShadow):
  28557. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  28558. * html/canvas/CanvasRenderingContext2D.h:
  28559. * html/canvas/CanvasStyle.cpp:
  28560. (WebCore::CanvasStyle::applyStrokeColor):
  28561. (WebCore::CanvasStyle::applyFillColor):
  28562. * loader/cache/CachedFont.cpp:
  28563. * loader/cache/CachedImage.cpp:
  28564. (WebCore::CachedImage::createImage):
  28565. * platform/FloatConversion.h:
  28566. * platform/MIMETypeRegistry.cpp:
  28567. (WebCore::initializeSupportedImageMIMETypes):
  28568. (WebCore::initializeSupportedImageMIMETypesForEncoding):
  28569. * platform/graphics/BitmapImage.h:
  28570. * platform/graphics/Color.h:
  28571. * platform/graphics/DashArray.h:
  28572. * platform/graphics/FloatPoint.h:
  28573. * platform/graphics/FloatRect.h:
  28574. * platform/graphics/FloatSize.h:
  28575. * platform/graphics/FontPlatformData.h:
  28576. (WebCore::FontPlatformData::FontPlatformData):
  28577. (WebCore::FontPlatformData::hash):
  28578. * platform/graphics/GlyphBuffer.h:
  28579. (WebCore::GlyphBuffer::advanceAt):
  28580. (WebCore::GlyphBuffer::add):
  28581. (WebCore::GlyphBuffer::expandLastAdvance):
  28582. * platform/graphics/Gradient.h:
  28583. * platform/graphics/GraphicsContext.cpp:
  28584. (WebCore::GraphicsContext::setLegacyShadow):
  28585. * platform/graphics/GraphicsContext.h:
  28586. (WebCore::GraphicsContextState::GraphicsContextState):
  28587. * platform/graphics/GraphicsContext3D.h:
  28588. * platform/graphics/Image.cpp:
  28589. * platform/graphics/Image.h:
  28590. * platform/graphics/ImageBuffer.cpp:
  28591. * platform/graphics/ImageBuffer.h:
  28592. * platform/graphics/ImageBufferData.h:
  28593. * platform/graphics/ImageSource.h:
  28594. * platform/graphics/IntPoint.h:
  28595. * platform/graphics/IntRect.h:
  28596. * platform/graphics/IntSize.h:
  28597. * platform/graphics/Path.h:
  28598. * platform/graphics/Pattern.h:
  28599. * platform/graphics/SimpleFontData.h:
  28600. * platform/graphics/cg/ColorCG.cpp:
  28601. * platform/graphics/cg/FloatPointCG.cpp:
  28602. * platform/graphics/cg/FloatRectCG.cpp:
  28603. * platform/graphics/cg/FloatSizeCG.cpp:
  28604. * platform/graphics/cg/ImageCG.cpp:
  28605. * platform/graphics/cg/ImageSourceCG.cpp:
  28606. * platform/graphics/cg/IntPointCG.cpp:
  28607. * platform/graphics/cg/IntRectCG.cpp:
  28608. * platform/graphics/cg/IntSizeCG.cpp:
  28609. * platform/graphics/cg/PDFDocumentImage.cpp:
  28610. * platform/graphics/cg/PDFDocumentImage.h:
  28611. * platform/graphics/cg/PathCG.cpp:
  28612. * platform/graphics/cg/TransformationMatrixCG.cpp:
  28613. * platform/graphics/chromium/ImageLayerChromium.h:
  28614. * platform/graphics/chromium/LayerRendererChromium.cpp:
  28615. * platform/graphics/chromium/LayerRendererChromium.h:
  28616. * platform/graphics/chromium/PlatformCanvas.cpp:
  28617. (WebCore::PlatformCanvas::resize):
  28618. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  28619. (WebCore::PlatformCanvas::Painter::Painter):
  28620. * platform/graphics/chromium/PlatformCanvas.h:
  28621. * platform/graphics/chromium/PlatformImage.cpp:
  28622. (WebCore::PlatformImage::updateFromImage):
  28623. * platform/graphics/opentype/OpenTypeUtilities.cpp:
  28624. * platform/graphics/transforms/AffineTransform.h:
  28625. * platform/graphics/transforms/TransformationMatrix.h:
  28626. * platform/graphics/win/DIBPixelData.h:
  28627. * platform/graphics/win/FontCacheWin.cpp:
  28628. (WebCore::FontCache::platformInit):
  28629. (WebCore::createGDIFont):
  28630. (WebCore::FontCache::createFontPlatformData):
  28631. * platform/graphics/win/FontPlatformDataWin.cpp:
  28632. (WebCore::FontPlatformData::FontPlatformData):
  28633. * platform/graphics/win/GraphicsContextWin.cpp:
  28634. * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  28635. * platform/graphics/win/SimpleFontDataWin.cpp:
  28636. * platform/image-decoders/ImageDecoder.cpp:
  28637. * platform/image-decoders/ImageDecoder.h:
  28638. * rendering/RenderObject.h:
  28639. * rendering/svg/RenderSVGResourceFilter.cpp:
  28640. (WebCore::RenderSVGResourceFilter::postApplyResource):
  28641. * rendering/svg/RenderSVGResourceGradient.cpp:
  28642. (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
  28643. (WebCore::RenderSVGResourceGradient::applyResource):
  28644. * rendering/svg/RenderSVGResourceGradient.h:
  28645. * rendering/svg/RenderSVGResourceMasker.cpp:
  28646. (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
  28647. * rendering/svg/RenderSVGResourcePattern.cpp:
  28648. (WebCore::RenderSVGResourcePattern::applyResource):
  28649. 2011-04-16 Adam Barth <abarth@webkit.org>
  28650. Reviewed by Sam Weinig.
  28651. about:blank documents in new tabs can XHR anywhere
  28652. https://bugs.webkit.org/show_bug.cgi?id=58712
  28653. Empty security origins have supposed to be low-privilege, we should
  28654. mark them as having a unique origin.
  28655. * manual-tests/about-blank-xhr.html: Added.
  28656. * page/SecurityOrigin.cpp:
  28657. (WebCore::SecurityOrigin::SecurityOrigin):
  28658. * page/SecurityOrigin.h:
  28659. 2011-04-16 Dan Bernstein <mitz@apple.com>
  28660. Reviewed by Simon Fraser.
  28661. <rdar://problem/9190108> Crash when hiding a float
  28662. Test: fast/block/float/overhanging-tall-block.html
  28663. * rendering/RenderBlock.cpp:
  28664. (WebCore::RenderBlock::addOverhangingFloats): Moved the call to childLogicalTop() out of the loop.
  28665. Capped the logical bottom so that we get the correct maximum.
  28666. * rendering/RenderBlock.h: Decleared appendFloatingObjectToLastLine().
  28667. * rendering/RenderBlockLineLayout.cpp:
  28668. (WebCore::RenderBlock::appendFloatingObjectToLastLine): Added. Ensures correct bookkeeping by
  28669. extending the float if needed so that it touches the line.
  28670. (WebCore::RenderBlock::layoutInlineChildren): Changed to call appendFloatingObjectToLastLine().
  28671. (WebCore::RenderBlock::checkFloatsInCleanLine): Capped the float height so the we mark the right
  28672. range of lines as dirty.
  28673. * rendering/RootInlineBox.h:
  28674. (WebCore::RootInlineBox::appendFloat): Replaced the floats() accessor with this function, which
  28675. allows the creation of the vector to be combined with appending the first float.
  28676. 2011-04-16 Sam Weinig <sam@webkit.org>
  28677. Reviewed by Simon Fraser.
  28678. Pages in the PageCache don't have the correct visited link coloring after being restored
  28679. https://bugs.webkit.org/show_bug.cgi?id=58721
  28680. * WebCore.exp.in:
  28681. Add export of markPagesForVistedLinkStyleRecalc for use by WebKit2.
  28682. * history/CachedPage.cpp:
  28683. (WebCore::CachedPage::CachedPage):
  28684. (WebCore::CachedPage::restore):
  28685. (WebCore::CachedPage::clear):
  28686. * history/CachedPage.h:
  28687. (WebCore::CachedPage::markForVistedLinkStyleRecalc):
  28688. Add bit, set by calling markForVistedLinkStyleRecalc, which forces a visited link
  28689. style recalc when being restored.
  28690. * history/PageCache.h:
  28691. * history/PageCache.cpp:
  28692. (WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
  28693. Mark all pages in the page cache as requiring visited link style recalc.
  28694. * page/PageGroup.cpp:
  28695. (WebCore::PageGroup::addVisitedLink):
  28696. (WebCore::PageGroup::removeVisitedLinks):
  28697. (WebCore::PageGroup::removeAllVisitedLinks):
  28698. Set dirty bit when changing any visited link information.
  28699. 2011-04-16 Leo Yang <leoyang.webkit@gmail.com>
  28700. Reviewed by Nikolas Zimmermann.
  28701. ASSERT failure when svg <use> element changes href
  28702. https://bugs.webkit.org/show_bug.cgi?id=58726
  28703. m_resourceId was not empty after the pending resource
  28704. becomes available. This will trigger the assertion at
  28705. line 509 of SVGUseElement.cpp when the <use> element's
  28706. href becomes empty or invalid.
  28707. This patch makes m_resourceId be empty after the pending
  28708. resource becomes available to avoid assertion failure.
  28709. Test: svg/custom/use-crash-when-href-change.svg
  28710. * svg/SVGUseElement.cpp:
  28711. (WebCore::SVGUseElement::buildPendingResource):
  28712. 2011-04-16 Patrick Gansterer <paroga@webkit.org>
  28713. Reviewed by Eric Seidel.
  28714. Rename PLATFORM(CAIRO) to USE(CAIRO)
  28715. https://bugs.webkit.org/show_bug.cgi?id=55192
  28716. * CMakeListsEfl.txt:
  28717. * config.h:
  28718. * platform/MIMETypeRegistry.cpp:
  28719. (WebCore::initializeSupportedImageMIMETypesForEncoding):
  28720. * platform/graphics/ContextShadow.h:
  28721. * platform/graphics/DashArray.h:
  28722. * platform/graphics/FloatRect.h:
  28723. * platform/graphics/FontPlatformData.h:
  28724. (WebCore::FontPlatformData::FontPlatformData):
  28725. (WebCore::FontPlatformData::hash):
  28726. (WebCore::FontPlatformData::isHashTableDeletedValue):
  28727. * platform/graphics/GlyphBuffer.h:
  28728. (WebCore::GlyphBuffer::glyphAt):
  28729. (WebCore::GlyphBuffer::add):
  28730. * platform/graphics/Gradient.cpp:
  28731. * platform/graphics/Gradient.h:
  28732. * platform/graphics/GraphicsContext.cpp:
  28733. * platform/graphics/GraphicsContext.h:
  28734. (WebCore::GraphicsContextState::GraphicsContextState):
  28735. * platform/graphics/GraphicsContext3D.h:
  28736. * platform/graphics/ImageBufferData.h:
  28737. * platform/graphics/ImageSource.h:
  28738. * platform/graphics/Path.h:
  28739. * platform/graphics/Pattern.h:
  28740. * platform/graphics/SimpleFontData.h:
  28741. * platform/graphics/cairo/DrawErrorUnderline.h:
  28742. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  28743. * platform/graphics/cairo/ImageCairo.cpp:
  28744. * platform/graphics/gstreamer/ImageGStreamer.h:
  28745. * platform/graphics/transforms/AffineTransform.h:
  28746. * platform/graphics/transforms/TransformationMatrix.h:
  28747. * platform/graphics/win/FontCacheWin.cpp:
  28748. (WebCore::createGDIFont):
  28749. (WebCore::FontCache::createFontPlatformData):
  28750. * platform/graphics/win/FontPlatformDataWin.cpp:
  28751. (WebCore::FontPlatformData::FontPlatformData):
  28752. * platform/graphics/win/GraphicsContextWin.cpp:
  28753. * plugins/win/PluginViewWin.cpp:
  28754. (WebCore::PluginView::paintWindowedPluginIntoContext):
  28755. * rendering/RenderObject.h:
  28756. 2011-04-16 Patrick Gansterer <paroga@webkit.org>
  28757. Unreviewed WinCE build fix for r84033.
  28758. * platform/win/LocalizedStringsWin.cpp:
  28759. (WebCore::localizedString):
  28760. 2011-04-16 Abhishek Arya <inferno@chromium.org>
  28761. Reviewed by Nikolas Zimmermann.
  28762. Only allow inline child for SVG text since we cannot
  28763. handle block childs.
  28764. https://bugs.webkit.org/show_bug.cgi?id=58678
  28765. Test: svg/text/text-block-child-crash.xhtml
  28766. * rendering/svg/RenderSVGText.cpp:
  28767. (WebCore::RenderSVGText::isChildAllowed):
  28768. * rendering/svg/RenderSVGText.h:
  28769. 2011-04-15 Ilya Tikhonovsky <loislo@chromium.org>
  28770. Reviewed by Pavel Feldman.
  28771. Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
  28772. https://bugs.webkit.org/show_bug.cgi?id=57833
  28773. * inspector/Inspector.json:
  28774. * inspector/InspectorDatabaseAgent.cpp:
  28775. (WebCore::InspectorDatabaseAgent::didOpenDatabase):
  28776. (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  28777. (WebCore::InspectorDatabaseAgent::setFrontend):
  28778. (WebCore::InspectorDatabaseAgent::clearFrontend):
  28779. (WebCore::InspectorDatabaseAgent::enable):
  28780. (WebCore::InspectorDatabaseAgent::disable):
  28781. (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
  28782. (WebCore::InspectorDatabaseAgent::executeSQL):
  28783. * inspector/InspectorDatabaseAgent.h:
  28784. * inspector/front-end/inspector.js:
  28785. 2011-04-15 Adam Barth <abarth@webkit.org>
  28786. Reviewed by Eric Seidel.
  28787. CSP media-src is missing
  28788. https://bugs.webkit.org/show_bug.cgi?id=58642
  28789. Yay HTMLMediaElement for having the exact hook we need!
  28790. Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html
  28791. http/tests/security/contentSecurityPolicy/media-src-blocked.html
  28792. * html/HTMLMediaElement.cpp:
  28793. (WebCore::HTMLMediaElement::isSafeToLoadURL):
  28794. - Although it's tempting to add this branch to the previous
  28795. if-block, that results in the wrong error message being logged to
  28796. the console (covered by the "blocked" test).
  28797. * page/ContentSecurityPolicy.cpp:
  28798. (WebCore::ContentSecurityPolicy::allowMediaFromSource):
  28799. (WebCore::ContentSecurityPolicy::addDirective):
  28800. * page/ContentSecurityPolicy.h:
  28801. - These changes are routine.
  28802. 2011-04-15 Adam Barth <abarth@webkit.org>
  28803. Reviewed by Eric Seidel.
  28804. CSP should block string arguments to setTimeout and setInterval unless options eval-script
  28805. https://bugs.webkit.org/show_bug.cgi?id=58610
  28806. It's somewhat sadness that the JSC and V8 code for setTimeout and
  28807. setInterval are so different. I struggled for a while with how to
  28808. handle the worker case, but I decided to punt on it for now.
  28809. Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
  28810. http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
  28811. http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
  28812. http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
  28813. * bindings/js/JSDOMWindowCustom.cpp:
  28814. (WebCore::JSDOMWindow::setTimeout):
  28815. (WebCore::JSDOMWindow::setInterval):
  28816. * bindings/js/JSWorkerContextCustom.cpp:
  28817. (WebCore::JSWorkerContext::setTimeout):
  28818. (WebCore::JSWorkerContext::setInterval):
  28819. * bindings/js/ScheduledAction.cpp:
  28820. (WebCore::ScheduledAction::create):
  28821. * bindings/js/ScheduledAction.h:
  28822. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  28823. (WebCore::WindowSetTimeoutImpl):
  28824. * page/ContentSecurityPolicy.cpp:
  28825. (WebCore::ContentSecurityPolicy::allowEval):
  28826. * page/ContentSecurityPolicy.h:
  28827. 2011-04-15 Shishir Agrawal <shishir@chromium.org>
  28828. Reviewed by James Robinson.
  28829. Add a flag to guard Page Visibility API changes.
  28830. https://bugs.webkit.org/show_bug.cgi?id=58464
  28831. * Configurations/FeatureDefines.xcconfig:
  28832. 2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
  28833. Reviewed by Martin Robinson.
  28834. Make plugins compile during WebKit GTK Windows build.
  28835. Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
  28836. https://bugs.webkit.org/show_bug.cgi?id=58580
  28837. * plugins/PluginView.cpp:
  28838. (WebCore::PluginView::stop):
  28839. * plugins/PluginView.h:
  28840. * plugins/gtk/PluginViewGtk.cpp:
  28841. (WebCore::PluginView::platformGetValue):
  28842. (WebCore::PluginView::platformStart):
  28843. 2011-04-15 MORITA Hajime <morrita@google.com>
  28844. Reviewed by Simon Fraser.
  28845. Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
  28846. https://bugs.webkit.org/show_bug.cgi?id=58512
  28847. Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
  28848. This change keeps an small refactoring on
  28849. FrameView::shouldUpdate(), which doesn't affect on the behavior.
  28850. * dom/Document.cpp:
  28851. * dom/Document.h:
  28852. * page/FrameView.cpp:
  28853. (WebCore::FrameView::invalidateRect):
  28854. (WebCore::FrameView::shouldUpdate):
  28855. * rendering/RenderBlock.cpp:
  28856. (WebCore::RenderBlock::paintContents):
  28857. * rendering/RenderLayer.cpp:
  28858. (WebCore::RenderLayer::paintLayer):
  28859. 2011-04-15 Chris Rogers <crogers@google.com>
  28860. Reviewed by Kenneth Russell.
  28861. Reduce default kernel size of SincResampler to favor better speed over quality
  28862. https://bugs.webkit.org/show_bug.cgi?id=58710
  28863. No new tests since audio API is not yet implemented.
  28864. * platform/audio/SincResampler.h:
  28865. 2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
  28866. Reviewed by Martin Robinson.
  28867. Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
  28868. These have to be defined for Windows in general, since win32 API
  28869. does not provide them.
  28870. https://bugs.webkit.org/show_bug.cgi?id=58582
  28871. * platform/graphics/WOFFFileFormat.cpp:
  28872. 2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
  28873. Reviewed by Adam Barth.
  28874. Show a console message when X-Frame-Options blocks a load
  28875. https://bugs.webkit.org/show_bug.cgi?id=39087
  28876. Added console message when X-Frame-Options headers block resource loading
  28877. * loader/MainResourceLoader.cpp:
  28878. (WebCore::MainResourceLoader::didReceiveResponse):
  28879. 2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
  28880. Reviewed by Martin Robinson.
  28881. Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
  28882. test. This allows Windows build of WebKit GTK to chose the right
  28883. path.
  28884. https://bugs.webkit.org/show_bug.cgi?id=58576
  28885. * platform/FileSystem.h:
  28886. 2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
  28887. Reviewed by Kenneth Rohde Christiansen.
  28888. [Qt] QWebPage MIME type handling inconsistency with other web browsers
  28889. https://bugs.webkit.org/show_bug.cgi?id=46968
  28890. Implementing mime type sniffing based on
  28891. http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
  28892. * WebCore.pro:
  28893. * platform/network/MIMESniffing.cpp: Added.
  28894. (MagicNumbers::dataSizeNeededForImageSniffing):
  28895. (MagicNumbers::maskedCompare):
  28896. (MagicNumbers::checkSpaceOrBracket):
  28897. (MagicNumbers::compare):
  28898. (MagicNumbers::findMIMEType):
  28899. (MagicNumbers::findSimpleMIMEType):
  28900. (MagicNumbers::textOrBinaryTypeSniffingProcedure):
  28901. (MagicNumbers::unknownTypeSniffingProcedure):
  28902. (MagicNumbers::imageTypeSniffingProcedure):
  28903. (MagicNumbers::checkText):
  28904. (MagicNumbers::checkRDF):
  28905. (MagicNumbers::skipTag):
  28906. (MagicNumbers::feedTypeSniffingProcedure):
  28907. (MIMESniffer::MIMESniffer):
  28908. * platform/network/MIMESniffing.h: Added.
  28909. (MIMESniffer::dataSize):
  28910. (MIMESniffer::sniff):
  28911. (MIMESniffer::isValid):
  28912. * platform/network/NetworkingContext.h:
  28913. * platform/network/qt/QNetworkReplyHandler.cpp:
  28914. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  28915. (WebCore::QNetworkReplyWrapper::release):
  28916. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  28917. (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
  28918. (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
  28919. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  28920. (WebCore::QNetworkReplyHandler::sendNetworkRequest):
  28921. (WebCore::QNetworkReplyHandler::start):
  28922. * platform/network/qt/QNetworkReplyHandler.h:
  28923. (WebCore::QNetworkReplyWrapper::advertisedMIMEType):
  28924. (WebCore::QNetworkReplyWrapper::mimeType):
  28925. * platform/network/qt/QtMIMETypeSniffer.cpp: Added.
  28926. (QtMIMETypeSniffer::QtMIMETypeSniffer):
  28927. (QtMIMETypeSniffer::sniff):
  28928. (QtMIMETypeSniffer::trySniffing):
  28929. * platform/network/qt/QtMIMETypeSniffer.h: Added.
  28930. (QtMIMETypeSniffer::mimeType):
  28931. (QtMIMETypeSniffer::isFinished):
  28932. 2011-04-15 Emil A Eklund <eae@chromium.org>
  28933. Reviewed by Dimitri Glazkov.
  28934. input field with focus makes appendChild operation ~42x slower
  28935. https://bugs.webkit.org/show_bug.cgi?id=57059
  28936. Change ContainerNode::cloneChildNodes to only disable the
  28937. deleteButtonController if the container itself (or any of its children)
  28938. is being edited. Thus avoiding a reflow in cases where it's not.
  28939. Test: perf/clone-with-focus.html
  28940. * dom/ContainerNode.cpp:
  28941. (WebCore::ContainerNode::cloneChildNodes):
  28942. 2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
  28943. Reviewed by David Levin.
  28944. Expose unified Quota API if QUOTA build flag is enabled
  28945. https://bugs.webkit.org/show_bug.cgi?id=58648
  28946. Test: storage/storageinfo-query-usage.html
  28947. * CMakeLists.txt: Added new file entries.
  28948. * DerivedSources.cpp: Added new file entries.
  28949. * DerivedSources.make: Added new file entries.
  28950. * GNUmakefile.am: Added new file entries.
  28951. * WebCore.gypi: Added new file entries.
  28952. * WebCore.vcproj/WebCore.vcproj: Added new file entries.
  28953. * WebCore.xcodeproj/project.pbxproj: Added new file entries.
  28954. * page/DOMWindow.cpp:
  28955. (WebCore::DOMWindow::webkitStorageInfo): Added.
  28956. * page/DOMWindow.h:
  28957. * page/DOMWindow.idl:
  28958. * storage/StorageInfo.h: Added storage type enum.
  28959. * storage/StorageInfo.idl: Added.
  28960. * storage/StorageInfoErrorCallback.idl: Added.
  28961. * storage/StorageInfoUsageCallback.idl: Added.
  28962. 2011-04-15 Oliver Hunt <oliver@apple.com>
  28963. GC allocate Structure
  28964. https://bugs.webkit.org/show_bug.cgi?id=58483
  28965. Rolling r83894 r83827 r83810 r83809 r83808 back in with
  28966. a workaround for the gcc bug seen by the gtk bots
  28967. * WebCore.exp.in:
  28968. * bindings/js/JSAudioConstructor.h:
  28969. (WebCore::JSAudioConstructor::createStructure):
  28970. * bindings/js/JSDOMBinding.cpp:
  28971. (WebCore::cacheDOMStructure):
  28972. * bindings/js/JSDOMBinding.h:
  28973. (WebCore::DOMObjectWithGlobalPointer::createStructure):
  28974. (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
  28975. (WebCore::DOMConstructorObject::createStructure):
  28976. (WebCore::DOMConstructorObject::DOMConstructorObject):
  28977. (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  28978. * bindings/js/JSDOMGlobalObject.cpp:
  28979. (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
  28980. (WebCore::JSDOMGlobalObject::markChildren):
  28981. * bindings/js/JSDOMGlobalObject.h:
  28982. (WebCore::JSDOMGlobalObject::createStructure):
  28983. * bindings/js/JSDOMWindowBase.cpp:
  28984. (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  28985. * bindings/js/JSDOMWindowBase.h:
  28986. (WebCore::JSDOMWindowBase::createStructure):
  28987. * bindings/js/JSDOMWindowShell.cpp:
  28988. (WebCore::JSDOMWindowShell::JSDOMWindowShell):
  28989. (WebCore::JSDOMWindowShell::setWindow):
  28990. * bindings/js/JSDOMWindowShell.h:
  28991. (WebCore::JSDOMWindowShell::createStructure):
  28992. * bindings/js/JSDOMWrapper.h:
  28993. (WebCore::DOMObject::DOMObject):
  28994. * bindings/js/JSEventListener.cpp:
  28995. (WebCore::JSEventListener::JSEventListener):
  28996. * bindings/js/JSImageConstructor.h:
  28997. (WebCore::JSImageConstructor::createStructure):
  28998. * bindings/js/JSImageDataCustom.cpp:
  28999. (WebCore::toJS):
  29000. * bindings/js/JSOptionConstructor.h:
  29001. (WebCore::JSOptionConstructor::createStructure):
  29002. * bindings/js/JSWorkerContextBase.cpp:
  29003. (WebCore::JSWorkerContextBase::JSWorkerContextBase):
  29004. * bindings/js/JSWorkerContextBase.h:
  29005. (WebCore::JSWorkerContextBase::createStructure):
  29006. * bindings/js/ScriptCachedFrameData.h:
  29007. * bindings/js/SerializedScriptValue.h:
  29008. * bindings/js/WorkerScriptController.cpp:
  29009. (WebCore::WorkerScriptController::~WorkerScriptController):
  29010. (WebCore::WorkerScriptController::initScript):
  29011. * bindings/scripts/CodeGeneratorJS.pm:
  29012. * bridge/c/CRuntimeObject.h:
  29013. (JSC::Bindings::CRuntimeObject::createStructure):
  29014. * bridge/c/c_instance.cpp:
  29015. (JSC::Bindings::CRuntimeMethod::createStructure):
  29016. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  29017. (JavaRuntimeMethod::createStructure):
  29018. * bridge/jni/jsc/JavaRuntimeObject.h:
  29019. (JSC::Bindings::JavaRuntimeObject::createStructure):
  29020. * bridge/objc/ObjCRuntimeObject.h:
  29021. (JSC::Bindings::ObjCRuntimeObject::createStructure):
  29022. * bridge/objc/objc_instance.mm:
  29023. (ObjCRuntimeMethod::createStructure):
  29024. * bridge/objc/objc_runtime.h:
  29025. (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  29026. * bridge/qt/qt_instance.cpp:
  29027. (JSC::Bindings::QtRuntimeObject::createStructure):
  29028. * bridge/qt/qt_pixmapruntime.cpp:
  29029. (JSC::Bindings::QtPixmapRuntimeObject::createStructure):
  29030. * bridge/qt/qt_runtime.h:
  29031. (JSC::Bindings::QtRuntimeMethod::createStructure):
  29032. * bridge/runtime_array.cpp:
  29033. (JSC::RuntimeArray::RuntimeArray):
  29034. * bridge/runtime_array.h:
  29035. (JSC::RuntimeArray::createStructure):
  29036. * bridge/runtime_method.cpp:
  29037. (JSC::RuntimeMethod::RuntimeMethod):
  29038. * bridge/runtime_method.h:
  29039. (JSC::RuntimeMethod::createStructure):
  29040. * bridge/runtime_object.cpp:
  29041. (JSC::Bindings::RuntimeObject::RuntimeObject):
  29042. * bridge/runtime_object.h:
  29043. (JSC::Bindings::RuntimeObject::createStructure):
  29044. * history/HistoryItem.h:
  29045. 2011-04-15 Jessie Berlin <jberlin@apple.com>
  29046. Reviewed by Brian Weinstein.
  29047. Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
  29048. http://www.webkit.org/demos/calendar.
  29049. https://bugs.webkit.org/show_bug.cgi?id=58698
  29050. * platform/win/FileSystemWin.cpp:
  29051. (WebCore::openFile):
  29052. Add breaks to the case statement.
  29053. (WebCore::directoryName):
  29054. Remove any trailing slash in directoryName. After closer inspection of all callers, it
  29055. appears the that callers do not need the trailing slash, and those that use the length do
  29056. so only to change the direction of the slashes throughout the length of the path.
  29057. 2011-04-15 Roland Steiner <rolandsteiner@chromium.org>
  29058. Reviewed by Dimitri Glazkov.
  29059. Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
  29060. https://bugs.webkit.org/show_bug.cgi?id=52963
  29061. .) Change base class of ShadowRoot from DocumentFragment to TreeScope.
  29062. .) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
  29063. .) Merged setTreeScope() with setTreeScopeRecursively()
  29064. .) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
  29065. No new tests. (refactoring)
  29066. * dom/ContainerNode.cpp:
  29067. (WebCore::ContainerNode::takeAllChildrenFrom):
  29068. (WebCore::ContainerNode::removeBetween):
  29069. (WebCore::ContainerNode::removeChildren):
  29070. (WebCore::ContainerNode::parserAddChild):
  29071. * dom/Document.cpp:
  29072. (WebCore::Document::Document):
  29073. (WebCore::Document::~Document):
  29074. (WebCore::Document::setDocType):
  29075. * dom/Element.h:
  29076. * dom/Node.cpp:
  29077. (WebCore::Node::treeScope):
  29078. (WebCore::Node::setTreeScopeRecursively):
  29079. * dom/Node.h:
  29080. (WebCore::Node::document):
  29081. * dom/ShadowRoot.cpp:
  29082. (WebCore::ShadowRoot::ShadowRoot):
  29083. (WebCore::ShadowRoot::~ShadowRoot):
  29084. (WebCore::ShadowRoot::nodeType):
  29085. (WebCore::ShadowRoot::cloneNode):
  29086. (WebCore::ShadowRoot::childTypeAllowed):
  29087. * dom/ShadowRoot.h:
  29088. (WebCore::toShadowRoot):
  29089. * dom/TreeScope.cpp:
  29090. (WebCore::TreeScope::TreeScope):
  29091. (WebCore::TreeScope::setParentTreeScope):
  29092. * dom/TreeScope.h:
  29093. * rendering/RenderSlider.cpp:
  29094. 2011-04-15 Geoffrey Garen <ggaren@apple.com>
  29095. Reviewed by Oliver Hunt.
  29096. DOM object handles are never removed from cache
  29097. https://bugs.webkit.org/show_bug.cgi?id=58707
  29098. We were trying to remove hash table items by value instead of by key.
  29099. * bindings/js/DOMWrapperWorld.cpp:
  29100. (WebCore::JSNodeHandleOwner::finalize): Changed to work more like
  29101. DOMObjectHandleOwner::finalize because I'm going to merge them.
  29102. (WebCore::DOMObjectHandleOwner::finalize): Remove hash table items
  29103. by key, not value. (Oops!) Use a helper function to make sure we get
  29104. this right.
  29105. * bindings/js/JSDOMBinding.cpp:
  29106. (WebCore::cacheDOMObjectWrapper): Store the hash table key as our weak
  29107. handle context, so we can use it at destruction time.
  29108. * bindings/js/JSDOMBinding.h: Removed unnecessary include.
  29109. * bindings/js/JSNodeCustom.h:
  29110. (WebCore::cacheDOMNodeWrapper): Store the hash table key as our weak
  29111. handle context, so we can use it at destruction time.
  29112. * bindings/js/ScriptWrappable.h:
  29113. (WebCore::ScriptWrappable::setWrapper): Forward context parameter, to
  29114. support the above.
  29115. 2011-04-15 Kenneth Russell <kbr@google.com>
  29116. Unreviewed. Chromium Linux Release build fix due to unused variables.
  29117. * platform/audio/mkl/FFTFrameMKL.cpp:
  29118. (WebCore::FFTFrame::doFFT):
  29119. (WebCore::FFTFrame::doInverseFFT):
  29120. (WebCore::FFTFrame::cleanup):
  29121. 2011-04-15 Brent Fulgham <bfulgham@webkit.org>
  29122. Unreviewed build change after r83945.
  29123. New 'PlatformPathCairo.cpp' was not added to the WinCairo build.
  29124. * WebCore.vcproj/WebCore.vcproj: Add missing file to WinCairo
  29125. build. Exclude for standard Apple build.
  29126. 2011-04-15 Anders Carlsson <andersca@apple.com>
  29127. Reviewed by Dan Bernstein.
  29128. Fade the find page overlay
  29129. https://bugs.webkit.org/show_bug.cgi?id=58697
  29130. Add a symbol that WebKit2 needs.
  29131. * WebCore.exp.in:
  29132. 2011-04-15 MORITA Hajime <morrita@google.com>
  29133. Reviewed by Dimitri Glazkov.
  29134. RenderDetailsMarker should belong to shadow element.
  29135. https://bugs.webkit.org/show_bug.cgi?id=58591
  29136. - Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker.
  29137. - Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout.
  29138. Note that marker size is given via style for -webkit-details-marker pseudo class.
  29139. - Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement.
  29140. Now RenderDetails knows nothing about default summary.
  29141. - Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of
  29142. <summary>, and the clickable area is now <summary> itself.
  29143. - Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling.
  29144. * Android.mk:
  29145. * CMakeLists.txt:
  29146. * GNUmakefile.list.am:
  29147. * WebCore.gypi:
  29148. * WebCore.pro:
  29149. * WebCore.vcproj/WebCore.vcproj:
  29150. * WebCore.xcodeproj/project.pbxproj:
  29151. * css/html.css:
  29152. (summary::-webkit-details-marker):
  29153. * dom/Element.cpp:
  29154. (WebCore::Element::attach):
  29155. * dom/Node.cpp:
  29156. (WebCore::shouldCreateRendererFor):
  29157. * dom/Node.h:
  29158. (WebCore::Node::canHaveLightChildRendererWithShadow):
  29159. * html/HTMLDetailsElement.cpp:
  29160. (WebCore::HTMLDetailsElement::findSummaryFor):
  29161. (WebCore::HTMLDetailsElement::findMainSummary):
  29162. (WebCore::HTMLDetailsElement::refreshMainSummary):
  29163. (WebCore::HTMLDetailsElement::createShadowSubtree):
  29164. (WebCore::HTMLDetailsElement::childrenChanged):
  29165. (WebCore::HTMLDetailsElement::finishParsingChildren):
  29166. (WebCore::HTMLDetailsElement::toggleOpen):
  29167. * html/HTMLDetailsElement.h:
  29168. (WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow):
  29169. * html/HTMLSummaryElement.cpp:
  29170. (WebCore::HTMLSummaryElement::create):
  29171. (WebCore::HTMLSummaryElement::createShadowSubtree):
  29172. (WebCore::HTMLSummaryElement::detailsElement):
  29173. (WebCore::HTMLSummaryElement::isMainSummary):
  29174. (WebCore::HTMLSummaryElement::defaultEventHandler):
  29175. * html/HTMLSummaryElement.h:
  29176. (WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow):
  29177. * html/shadow/DetailsMarkerControl.cpp: Added.
  29178. (WebCore::DetailsMarkerControl::DetailsMarkerControl):
  29179. (WebCore::DetailsMarkerControl::createRenderer):
  29180. (WebCore::DetailsMarkerControl::rendererIsNeeded):
  29181. (WebCore::DetailsMarkerControl::shadowPseudoId):
  29182. (WebCore::DetailsMarkerControl::summaryElement):
  29183. * html/shadow/DetailsMarkerControl.h: Added.
  29184. (WebCore::DetailsMarkerControl::create):
  29185. * rendering/RenderDetails.cpp:
  29186. (WebCore::RenderDetails::RenderDetails):
  29187. (WebCore::RenderDetails::styleDidChange):
  29188. (WebCore::RenderDetails::moveSummaryToContents):
  29189. (WebCore::RenderDetails::checkMainSummary):
  29190. (WebCore::RenderDetails::layout):
  29191. * rendering/RenderDetails.h:
  29192. * rendering/RenderDetailsMarker.cpp:
  29193. (WebCore::RenderDetailsMarker::RenderDetailsMarker):
  29194. (WebCore::RenderDetailsMarker::isOpen):
  29195. (WebCore::RenderDetailsMarker::getPath):
  29196. (WebCore::RenderDetailsMarker::paint):
  29197. (WebCore::RenderDetailsMarker::details):
  29198. * rendering/RenderDetailsMarker.h:
  29199. 2011-04-15 Sam Weinig <sam@webkit.org>
  29200. Reviewed by Adam Roben.
  29201. Implement localize strings for windows WebKit2
  29202. https://bugs.webkit.org/show_bug.cgi?id=58688
  29203. * platform/win/LocalizedStringsWin.cpp:
  29204. (WebCore::createWebKitBundle):
  29205. (WebCore::webKitBundle):
  29206. (WebCore::localizedString):
  29207. Add implementation of localizedString for Windows.
  29208. 2011-04-15 Geoffrey Garen <ggaren@apple.com>
  29209. Reviewed by Oliver Hunt.
  29210. Some mechanical DOM wrapper cleanup
  29211. https://bugs.webkit.org/show_bug.cgi?id=58689
  29212. * WebCore.exp.in: Export!
  29213. * bindings/js/DOMWrapperWorld.cpp:
  29214. (WebCore::isReachableFromDOM): Inverted the inDocument test to make the
  29215. relationship of the special cases to the normal case clearer.
  29216. * bindings/js/JSArrayBufferViewHelper.h:
  29217. (WebCore::toJSArrayBufferView):
  29218. * bindings/js/JSCSSRuleCustom.cpp:
  29219. (WebCore::toJS):
  29220. * bindings/js/JSCSSValueCustom.cpp:
  29221. (WebCore::toJS):
  29222. * bindings/js/JSDOMBinding.cpp:
  29223. (WebCore::getCachedDOMObjectWrapper):
  29224. (WebCore::cacheDOMObjectWrapper):
  29225. * bindings/js/JSDOMBinding.h:
  29226. (WebCore::createDOMObjectWrapper):
  29227. (WebCore::getDOMObjectWrapper):
  29228. (WebCore::createDOMNodeWrapper):
  29229. (WebCore::getDOMNodeWrapper): Changed DOM wrapper functions to operate
  29230. in terms of DOMWrapperWorlds instead of ExecStates. This is clearer,
  29231. and ever-so-slightly faster.
  29232. Removed hasCachedXXX functions, now that they're unused.
  29233. * bindings/js/JSDOMWindowCustom.cpp:
  29234. (WebCore::JSDOMWindow::history):
  29235. (WebCore::JSDOMWindow::location):
  29236. * bindings/js/JSDocumentCustom.cpp:
  29237. (WebCore::JSDocument::location):
  29238. (WebCore::toJS):
  29239. * bindings/js/JSElementCustom.cpp:
  29240. (WebCore::toJSNewlyCreated):
  29241. * bindings/js/JSEventCustom.cpp:
  29242. (WebCore::toJS):
  29243. * bindings/js/JSHTMLCollectionCustom.cpp:
  29244. (WebCore::toJS):
  29245. * bindings/js/JSImageDataCustom.cpp:
  29246. (WebCore::toJS):
  29247. * bindings/js/JSNodeCustom.cpp:
  29248. (WebCore::createWrapperInline):
  29249. * bindings/js/JSNodeCustom.h:
  29250. (WebCore::getCachedDOMNodeWrapper):
  29251. (WebCore::cacheDOMNodeWrapper):
  29252. (WebCore::toJS):
  29253. * bindings/js/JSSVGPathSegCustom.cpp:
  29254. (WebCore::toJS):
  29255. * bindings/js/JSStyleSheetCustom.cpp:
  29256. (WebCore::toJS): Updated for changes above.
  29257. * xml/XMLHttpRequest.cpp:
  29258. (WebCore::XMLHttpRequest::dropProtection): Removed use of hasCachedDOMObjectWrapper
  29259. because XHR is almost always created and used by JavaScript, so it's
  29260. simpler to just always report extra cost.
  29261. 2011-04-15 Andreas Kling <kling@webkit.org>
  29262. Rolling out accidental part of r84010.
  29263. * platform/qt/RenderThemeQt.cpp:
  29264. (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
  29265. (WebCore::RenderThemeQt::setButtonPadding):
  29266. 2011-04-15 Oliver Hunt <oliver@apple.com>
  29267. Forgot windows build fix.
  29268. * bindings/js/JSNodeFilterCondition.cpp:
  29269. (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  29270. 2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
  29271. Reviewed by Yury Semikhatsky.
  29272. Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
  29273. https://bugs.webkit.org/show_bug.cgi?id=51364
  29274. The front end should not use a transparent background when
  29275. loaded as a web page (remote debugging) but should when loaded
  29276. regularly in a custom window. This adds a "remote" style class
  29277. onto the document body when the page is loaded remotely.
  29278. * inspector/front-end/inspector.css:
  29279. (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
  29280. * inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.
  29281. 2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
  29282. Reviewed by David Kilzer.
  29283. JSLock ASSERT seen often when using the inspector for long
  29284. periods of time. We should take the JSLock whenever we
  29285. might allocate memory in the JavaScript Heap.
  29286. JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
  29287. https://bugs.webkit.org/show_bug.cgi?id=58674
  29288. * bindings/js/JSInjectedScriptHostCustom.cpp:
  29289. (WebCore::InjectedScriptHost::nodeAsScriptValue): take the JSLock.
  29290. 2011-04-14 Oliver Hunt <oliver@apple.com>
  29291. Reviewed by Geoffrey Garen.
  29292. Make JSNodeFilterCondition handle its lifetime correctly
  29293. https://bugs.webkit.org/show_bug.cgi?id=58622
  29294. Switch over to a WeakHandle and external roots to keep the
  29295. condition value live.
  29296. * bindings/js/JSNodeFilterCondition.cpp:
  29297. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
  29298. (WebCore::JSNodeFilterCondition::markAggregate):
  29299. (WebCore::JSNodeFilterCondition::acceptNode):
  29300. (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  29301. * bindings/js/JSNodeFilterCondition.h:
  29302. (WebCore::JSNodeFilterCondition::create):
  29303. * bindings/js/JSNodeFilterCustom.cpp:
  29304. (WebCore::toNodeFilter):
  29305. * bindings/scripts/CodeGeneratorJS.pm:
  29306. 2011-04-13 Luiz Agostini <luiz.agostini@openbossa.org>
  29307. Reviewed by Andreas Kling.
  29308. [Qt] QNetworkReplyHandler refactoring: some adjustments
  29309. https://bugs.webkit.org/show_bug.cgi?id=57092
  29310. - Removing flag m_redirected from QNetworkReplyHandler and using m_redirectionTargetUrl.isValid() instead.
  29311. - Moving flag m_responseContainsData from QNetworkReplyHandler to the reply wrapper and removing the connection of
  29312. signal metaDataChanged for m_responseContainsData to be consistent.
  29313. - Using an OwnPtr to keep the reference to the QNetworkReplyWrapper.
  29314. * platform/network/qt/QNetworkReplyHandler.cpp:
  29315. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  29316. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  29317. (WebCore::QNetworkReplyWrapper::didReceiveReadyRead):
  29318. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  29319. (WebCore::QNetworkReplyHandler::release):
  29320. (WebCore::shouldIgnoreHttpError):
  29321. (WebCore::QNetworkReplyHandler::finish):
  29322. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  29323. (WebCore::QNetworkReplyHandler::redirect):
  29324. (WebCore::QNetworkReplyHandler::forwardData):
  29325. * platform/network/qt/QNetworkReplyHandler.h:
  29326. (WebCore::QNetworkReplyWrapper::responseContainsData):
  29327. (WebCore::QNetworkReplyWrapper::redirected):
  29328. 2011-04-15 Alexey Proskuryakov <ap@apple.com>
  29329. Chromium build fix.
  29330. * platform/SecureTextInput.h: CARBON_SECURE_INPUT_MODE no longer exists.
  29331. 2011-04-15 Mike Reed <reed@google.com>
  29332. Reviewed by Darin Fisher.
  29333. hide unused static function when SKIA_GPU is enabled
  29334. https://bugs.webkit.org/show_bug.cgi?id=58670
  29335. No new tests. Just fixes a warning (treated as an error) when SKIA_GPU is enabled
  29336. * platform/graphics/skia/ImageSkia.cpp:
  29337. 2011-04-15 Simon Fraser <simon.fraser@apple.com>
  29338. Reviewed by Beth Dakin.
  29339. Some borders with border-radius do not have rounded inner edges
  29340. https://bugs.webkit.org/show_bug.cgi?id=58457
  29341. Improve the logic used to compute the inner radii on curved
  29342. borders, to maintain borders of even thickness around the curve.
  29343. Tests: fast/borders/mixed-border-styles-radius.html
  29344. fast/borders/mixed-border-styles.html
  29345. * rendering/RenderBoxModelObject.h:
  29346. * rendering/RenderBoxModelObject.cpp:
  29347. (WebCore::RenderBoxModelObject::computeBorderOuterRect):
  29348. (WebCore::RenderBoxModelObject::computeBorderInnerRect):
  29349. Two new utility functions to share some code that was in both paintBorder()
  29350. and paintBoxShaadow().
  29351. getRoundedInnerBorderWithBorderWidths() now takes the outer border box
  29352. as well as the inner box.
  29353. (WebCore::RenderBoxModelObject::paintBorder): Call new methods.
  29354. (WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
  29355. * rendering/RenderObject.cpp:
  29356. (WebCore::RenderObject::drawBoxSideFromPath):
  29357. getRoundedInnerBorderWithBorderWidths() now takes the outer border box
  29358. as well as the inner box.
  29359. * rendering/style/RenderStyle.cpp:
  29360. (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  29361. * rendering/style/RenderStyle.h:
  29362. Compute the inner radii by starting with teh radii used for the
  29363. outer box, and then shrinking them down based on the border thickness.
  29364. 2011-04-14 Alexey Proskuryakov <ap@apple.com>
  29365. Reviewed by Dan Bernstein.
  29366. WebKit2: Password field input does not switch to ASCII-compatible source
  29367. https://bugs.webkit.org/show_bug.cgi?id=58583
  29368. <rdar://problem/9059651>
  29369. * platform/SecureTextInput.cpp:
  29370. (WebCore::enableSecureTextInput):
  29371. (WebCore::disableSecureTextInput):
  29372. This is now only used by Chromium. There is no need to change TSMDocument properties in
  29373. renderer process (and really, all secure text input logic in WebCore should be eliminated).
  29374. 2011-04-13 Xiaomei Ji <xji@chromium.org>
  29375. Reviewed by Ryosuke Niwa.
  29376. Continue (3rd) experiment with moving caret by word in visual order.
  29377. https://bugs.webkit.org/show_bug.cgi?id=58294
  29378. This patch along with r82588 and r83483 implements moving caret by
  29379. word in visual order.
  29380. The overall algorithm is:
  29381. 1. First get the InlineBox and offset of the pass-in VisiblePosition.
  29382. 2. Based on the position (left boundary, middle, right boundary) of the offset and the
  29383. direction of the movement, look for visually adjacent word breaks.
  29384. 2.1 If the offset is the minimum offset of the box,
  29385. return the rightmost word boundary in previous boxes if moving left.
  29386. return the leftmost word boundary in box and next boxes if moving right.
  29387. 2.2 Similar for the case when offset is at the maximum offset of the box.
  29388. 2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
  29389. or nextWordPosition based on the directionality of the box. If this word break position
  29390. is also inside the same box, return it. Otherwise (the nextWordPosition or
  29391. previousWordPosition is not in the same box or is at the box boundary), collect all the
  29392. word breaks in the box and search for the one closest to the input "offset" based on
  29393. box directionality, block directionality, and movement direction. Continue search in
  29394. adjacent boxes if needed.
  29395. Notes:
  29396. 1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
  29397. the input position (in the moving direction) is not available in current box, word
  29398. boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
  29399. word boundaries. Instead, the word boundaries are saved as a pair
  29400. (VisiblePosition, offset) to avoid recomputing VisiblePosition.
  29401. 2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
  29402. and right boundary of a word in RTL block). And word boundaries are collected using
  29403. previousWordPosition() and nextWordPosition(). So when box directionality is the same as
  29404. block directionality, word boundaries are collected from right to left visually in a LTR
  29405. box, and word boundaries are collected from left to right visually in a RTL box. It is
  29406. the other way around when box directionality is different from block directionality.
  29407. 3. To find the right kinds of word boundaries, we must move back and forth between words
  29408. in some situations. For example, if we're moving to the right in a LTR box in LTR block,
  29409. we cannot simply return nextWordPosition() because it would return the right boundary
  29410. of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
  29411. 4. When collecting word breaks inside a box, it first computes a start position, then
  29412. collect the right kind of word breaks until it reaches the end of (or beyond) the box.
  29413. In the meanwhile, it might need special handling on the rightmost or leftmost position
  29414. based on the directionality of the box and block. These computations do not consider the
  29415. box's bidi level.
  29416. * editing/visible_units.cpp:
  29417. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
  29418. (WebCore::collectWordBreaksInBox):
  29419. (WebCore::previousWordBoundaryInBox):
  29420. (WebCore::nextWordBoundaryInBox):
  29421. (WebCore::visuallyLastWordBoundaryInBox):
  29422. (WebCore::leftWordBoundary):
  29423. (WebCore::rightWordBoundary):
  29424. (WebCore::leftWordPosition):
  29425. (WebCore::rightWordPosition):
  29426. 2011-04-14 Zhenyao Mo <zmo@google.com>
  29427. Reviewed by Kenneth Russell.
  29428. Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash
  29429. https://bugs.webkit.org/show_bug.cgi?id=58501
  29430. * html/canvas/WebGLRenderingContext.cpp:
  29431. (WebCore::WebGLRenderingContext::texImage2D): Call validateHTMLImageElement().
  29432. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
  29433. (WebCore::WebGLRenderingContext::validateHTMLImageElement): Make sure image is ready.
  29434. * html/canvas/WebGLRenderingContext.h:
  29435. 2011-04-07 MORITA Hajime <morrita@google.com>
  29436. Reviewed by Ryosuke Niwa.
  29437. DocumentMaker::AllMarkers should not be a part of DocumentMarker::MarkerType
  29438. https://bugs.webkit.org/show_bug.cgi?id=58112
  29439. - Converted DocumentMarker::MarkerTypes from unsigned int to a class.
  29440. - Converted DocumentMarker::AllMarkers from an enum entry to a subclass of MarkerTypes.
  29441. - Changed type of some MarkerType argument on DocumentMarkerController API to MarkerTypes
  29442. which should allow a combination of MarkerType constansts.
  29443. - Removed some MarkerType arguments on DocumentMarkerController API
  29444. which only received AllMarkers.
  29445. No new tests, no behavior change.
  29446. * WebCore.exp.in:
  29447. * dom/DocumentMarker.h:
  29448. (WebCore::DocumentMarker::MarkerTypes::MarkerTypes):
  29449. (WebCore::DocumentMarker::MarkerTypes::contains):
  29450. (WebCore::DocumentMarker::MarkerTypes::intersects):
  29451. (WebCore::DocumentMarker::MarkerTypes::operator==):
  29452. (WebCore::DocumentMarker::MarkerTypes::add):
  29453. (WebCore::DocumentMarker::MarkerTypes::remove):
  29454. (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  29455. * dom/DocumentMarkerController.cpp:
  29456. (WebCore::DocumentMarkerController::possiblyHasMarkers):
  29457. (WebCore::DocumentMarkerController::addMarker):
  29458. (WebCore::DocumentMarkerController::copyMarkers):
  29459. (WebCore::DocumentMarkerController::removeMarkers):
  29460. (WebCore::DocumentMarkerController::markerContainingPoint):
  29461. (WebCore::DocumentMarkerController::markersInRange):
  29462. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  29463. (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
  29464. (WebCore::DocumentMarkerController::repaintMarkers):
  29465. (WebCore::DocumentMarkerController::shiftMarkers):
  29466. (WebCore::DocumentMarkerController::setMarkersActive):
  29467. (WebCore::DocumentMarkerController::hasMarkers):
  29468. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  29469. * dom/DocumentMarkerController.h:
  29470. 2011-04-14 Geoffrey Garen <ggaren@apple.com>
  29471. Reviewed by Oliver Hunt.
  29472. Complicated hash table is complicated
  29473. https://bugs.webkit.org/show_bug.cgi?id=58631
  29474. Now that we use the opaque roots system to track node wrapper lifetime,
  29475. we can remove a lot of complicated hash-tablery that used to do the same.
  29476. Now normal world node wrappers are just set as direct properties of
  29477. ScriptWrappable, while isolated world node wrappers and other DOM object
  29478. wrappers are stored in a shared, per-world hash table.
  29479. In addition to reducing complexity, this makes DOM wrapper allocation
  29480. 1.6X faster (tested with scratch-gc-dom3.html), and it reduces the memory
  29481. footprint of normal world wrappers by ~2/3, and isolated world wrappers
  29482. by ~1/3.
  29483. * WebCore.exp.in: Paying the patch tithe.
  29484. * bindings/js/DOMWrapperWorld.cpp:
  29485. (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
  29486. (WebCore::DOMWrapperWorld::clearWrappers): No more per-document hash tables.
  29487. (WebCore::JSNodeHandleOwner::finalize): Changed to call a helper function,
  29488. so the code to destroy a wrapper can live next to the code to create one.
  29489. * bindings/js/DOMWrapperWorld.h: No more per-document hash tables.
  29490. * bindings/js/JSDOMBinding.cpp:
  29491. (WebCore::uncacheDOMObjectWrapper):
  29492. * bindings/js/JSDOMBinding.h:
  29493. (WebCore::createDOMNodeWrapper):
  29494. (WebCore::getDOMNodeWrapper): No more per-document hash tables.
  29495. Added uncacheDOMObjectWrapper to be symmetrical with cacheDOMObjectWrapper.
  29496. * bindings/js/JSDocumentCustom.cpp:
  29497. (WebCore::toJS):
  29498. * bindings/js/JSElementCustom.cpp:
  29499. (WebCore::toJSNewlyCreated):
  29500. * bindings/js/JSNodeCustom.cpp:
  29501. (WebCore::createWrapperInline): Ditto.
  29502. * bindings/js/JSNodeCustom.h:
  29503. (WebCore::getCachedDOMNodeWrapper):
  29504. (WebCore::cacheDOMNodeWrapper):
  29505. (WebCore::uncacheDOMNodeWrapper):
  29506. (WebCore::toJS): Implemented the scheme described above.
  29507. * bindings/js/ScriptWrappable.h:
  29508. (WebCore::ScriptWrappable::wrapper):
  29509. (WebCore::ScriptWrappable::setWrapper):
  29510. (WebCore::ScriptWrappable::clearWrapper): ScriptWrappable needs a handle
  29511. owner now, since we don't have an extra handle living in a hash table
  29512. to maintain ownership for us.
  29513. * dom/Document.cpp:
  29514. (WebCore::Document::Document):
  29515. (WebCore::Document::~Document):
  29516. * dom/Document.h:
  29517. * dom/Node.cpp:
  29518. (WebCore::Node::setDocument): No more per-document hash tables.
  29519. * html/HTMLCanvasElement.cpp:
  29520. (WebCore::HTMLCanvasElement::createImageBuffer): Removed call to
  29521. hasCachedDOMNodeWrapperUnchecked because that was the old way of doing
  29522. things, and I was in the mood for getting rid of the old way. It's
  29523. debatable whether the check was ever a good idea. Even when a <canvas>
  29524. doesn't have a direct JS wrapper, other JS references can still keep
  29525. the <canvas> alive. So, it's probably best always to report extra cost.
  29526. 2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
  29527. Reviewed by Pavel Feldman.
  29528. Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
  29529. https://bugs.webkit.org/show_bug.cgi?id=58650
  29530. * inspector/Inspector.json:
  29531. * inspector/InspectorResourceAgent.cpp:
  29532. (WebCore::buildObjectForResourceResponse):
  29533. * inspector/front-end/NetworkManager.js:
  29534. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  29535. * inspector/front-end/Resource.js:
  29536. (WebInspector.Resource.prototype.get requestHeadersText):
  29537. (WebInspector.Resource.prototype.set requestHeadersText):
  29538. (WebInspector.Resource.prototype.get requestHeadersSize):
  29539. (WebInspector.Resource.prototype.get responseHeadersText):
  29540. (WebInspector.Resource.prototype.set responseHeadersText):
  29541. (WebInspector.Resource.prototype.get responseHeadersSize):
  29542. (WebInspector.Resource.prototype._headersSize):
  29543. * inspector/front-end/ResourceHeadersView.js:
  29544. (WebInspector.ResourceHeadersView):
  29545. (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
  29546. (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
  29547. (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
  29548. (WebInspector.ResourceHeadersView.prototype._refreshHeadersText):
  29549. (WebInspector.ResourceHeadersView.prototype._toggleRequestHeadersText):
  29550. (WebInspector.ResourceHeadersView.prototype._toggleResponseHeadersText):
  29551. (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
  29552. * inspector/front-end/networkPanel.css:
  29553. (.resource-headers-view .outline-disclosure li.headers-text):
  29554. * platform/network/ResourceLoadInfo.h:
  29555. 2011-04-15 Luke Macpherson <macpherson@chromium.org>
  29556. Reviewed by Dimitri Glazkov.
  29557. Implement css overflow properties in CSSStyleApplyProperty
  29558. https://bugs.webkit.org/show_bug.cgi?id=58633
  29559. No new tests required as no functionality changes.
  29560. * css/CSSStyleApplyProperty.cpp:
  29561. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  29562. Add initializers for CSSPropertyOverflowX, CSSPropertyOverflowY and CSSPropertyOverflow.
  29563. * css/CSSStyleSelector.cpp:
  29564. (WebCore::CSSStyleSelector::applyProperty):
  29565. Delete existing implementations.
  29566. 2011-04-15 Sam Weinig <sam@webkit.org>
  29567. Reviewed by Maciej Stachowiak.
  29568. Make mac WebKit1 use the default localization strategy
  29569. https://bugs.webkit.org/show_bug.cgi?id=58628
  29570. * English.lproj/Localizable.strings:
  29571. Update by running update-webkit-localizable-strings.
  29572. * platform/DefaultLocalizationStrategy.cpp:
  29573. (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
  29574. (WebCore::DefaultLocalizationStrategy::keygenKeychainItemName):
  29575. (WebCore::DefaultLocalizationStrategy::imageTitle):
  29576. Match the WebKit1 versions of these functions by special casing CF platforms.
  29577. 2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
  29578. Reviewed by Pavel Feldman.
  29579. Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
  29580. https://bugs.webkit.org/show_bug.cgi?id=58136
  29581. Passed response info to inspector when X-Frame-Options header blocks resource loading.
  29582. Test: http/tests/inspector/network/x-frame-options-deny.html
  29583. * inspector/InspectorInstrumentation.cpp:
  29584. (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDeniedImpl):
  29585. * inspector/InspectorInstrumentation.h:
  29586. (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
  29587. * loader/MainResourceLoader.cpp:
  29588. (WebCore::MainResourceLoader::didReceiveResponse):
  29589. 2011-04-15 Andrey Adaikin <aandrey@google.com>
  29590. Reviewed by Pavel Feldman.
  29591. Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
  29592. https://bugs.webkit.org/show_bug.cgi?id=58449
  29593. Test: inspector/editor/text-editor-model.html
  29594. * inspector/front-end/TextEditorModel.js:
  29595. (WebInspector.TextEditorModel):
  29596. (WebInspector.TextEditorModel.prototype.get text):
  29597. (WebInspector.TextEditorModel.prototype.setText):
  29598. (WebInspector.TextEditorModel.prototype._innerSetText):
  29599. (WebInspector.TextEditorModel.prototype.copyRange):
  29600. 2011-04-15 Sergey Vorobyev <sergeyvorobyev@google.com>
  29601. Reviewed by Yury Semikhatsky.
  29602. Web Inspector: Network events don't preserves,
  29603. when inspector frontend closed and open again
  29604. https://bugs.webkit.org/show_bug.cgi?id=58064
  29605. Added InspectorFrontendProxy and EventsCollector.
  29606. They allow captured messages from InspectorResourceAgent
  29607. to frontend (or mockFrontend if frontend disabled) and
  29608. push collected data when frontend reconnect.
  29609. This functionality is disabled by default.
  29610. * CMakeLists.txt:
  29611. * GNUmakefile.list.am:
  29612. * WebCore.gypi:
  29613. * WebCore.pro:
  29614. * WebCore.vcproj/WebCore.vcproj:
  29615. * WebCore.xcodeproj/project.pbxproj:
  29616. * inspector/EventsCollector.cpp: Added.
  29617. (WebCore::EventsCollector::EventsCollector):
  29618. (WebCore::EventsCollector::addEvent):
  29619. (WebCore::EventsCollector::sendCollectedEvents):
  29620. * inspector/EventsCollector.h: Added.
  29621. (WebCore::EventsCollector::~EventsCollector):
  29622. * inspector/Inspector.json:
  29623. * inspector/InspectorFrontendProxy.cpp: Added.
  29624. (WebCore::InspectorFrontendProxy::InspectorFrontendProxy):
  29625. (WebCore::InspectorFrontendProxy::setInspectorFrontendChannel):
  29626. (WebCore::InspectorFrontendProxy::setEventsCollector):
  29627. (WebCore::InspectorFrontendProxy::sendMessageToFrontend):
  29628. * inspector/InspectorFrontendProxy.h: Added.
  29629. (WebCore::InspectorFrontendProxy::~InspectorFrontendProxy):
  29630. * inspector/InspectorInstrumentation.cpp:
  29631. (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
  29632. (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  29633. * inspector/InspectorInstrumentation.h:
  29634. (WebCore::InspectorInstrumentation::willSendRequest):
  29635. (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
  29636. (WebCore::InspectorInstrumentation::didReceiveContentLength):
  29637. (WebCore::InspectorInstrumentation::didFinishLoading):
  29638. (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
  29639. (WebCore::InspectorInstrumentation::loadEventFired):
  29640. (WebCore::InspectorInstrumentation::frameDetachedFromParent):
  29641. (WebCore::InspectorInstrumentation::didCreateWebSocket):
  29642. (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
  29643. (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
  29644. (WebCore::InspectorInstrumentation::didCloseWebSocket):
  29645. * inspector/InspectorResourceAgent.cpp:
  29646. (WebCore::InspectorResourceAgent::setFrontend):
  29647. (WebCore::InspectorResourceAgent::resourceContent):
  29648. (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
  29649. (WebCore::InspectorResourceAgent::didReceiveResponse):
  29650. (WebCore::InspectorResourceAgent::domContentEventFired):
  29651. (WebCore::InspectorResourceAgent::loadEventFired):
  29652. (WebCore::InspectorResourceAgent::enabledBackgoundEventsCoollection):
  29653. (WebCore::InspectorResourceAgent::enable):
  29654. (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  29655. * inspector/InspectorResourceAgent.h:
  29656. * inspector/front-end/NetworkManager.js:
  29657. (WebInspector.NetworkDispatcher.prototype.domContentEventFired):
  29658. (WebInspector.NetworkDispatcher.prototype.loadEventFired):
  29659. * inspector/front-end/inspector.js:
  29660. (WebInspector.domContentEventFired):
  29661. (WebInspector.loadEventFired):
  29662. 2011-04-15 Alexis Menard <alexis.menard@openbossa.org>
  29663. Reviewed by Dimitri Glazkov.
  29664. REGRESSION(r83397) [Qt] When clicking on the media elements they grow 2 pixels.
  29665. https://bugs.webkit.org/show_bug.cgi?id=58477
  29666. Since r83397 the media controls elements are actual DOM elements.
  29667. Therefore the global style-sheet applies to them. html.css defines
  29668. input[type="button"]:active to be border-style: inset which means
  29669. that when the buttons are active they grow by their border size. Therefore
  29670. ports which are not using the borders must explicitly disable them in their custom
  29671. stylesheet.
  29672. * css/mediaControlsQt.css:
  29673. (audio::-webkit-media-controls-mute-button):
  29674. (video::-webkit-media-controls-mute-button):
  29675. (audio::-webkit-media-controls-play-button):
  29676. (video::-webkit-media-controls-play-button):
  29677. (video::-webkit-media-controls-fullscreen-button):
  29678. * css/mediaControlsQuickTime.css:
  29679. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
  29680. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
  29681. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
  29682. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
  29683. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
  29684. (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
  29685. (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
  29686. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  29687. (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
  29688. 2011-04-15 Zelidrag Hornung <zelidrag@chromium.org>
  29689. Reviewed by Darin Fisher.
  29690. Added enums for external file system type.
  29691. https://bugs.webkit.org/show_bug.cgi?id=58456
  29692. * fileapi/DOMFileSystemBase.cpp:
  29693. (WebCore::DOMFileSystemBase::crackFileSystemURL):
  29694. * fileapi/DOMFileSystemBase.h:
  29695. * fileapi/EntryBase.cpp:
  29696. (WebCore::EntryBase::toURL):
  29697. * page/DOMWindow.cpp:
  29698. (WebCore::DOMWindow::requestFileSystem):
  29699. * page/DOMWindow.h:
  29700. * platform/AsyncFileSystem.h:
  29701. * workers/WorkerContext.cpp:
  29702. (WebCore::WorkerContext::requestFileSystem):
  29703. (WebCore::WorkerContext::requestFileSystemSync):
  29704. * workers/WorkerContext.h:
  29705. 2011-04-15 Pavel Feldman <pfeldman@google.com>
  29706. Reviewed by Yury Semikhatsky.
  29707. Web Inspector: make resource revisions use dedicated type (not Resource clone).
  29708. https://bugs.webkit.org/show_bug.cgi?id=58659
  29709. * inspector/front-end/CSSStyleModel.js:
  29710. (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
  29711. * inspector/front-end/Resource.js:
  29712. (WebInspector.Resource.prototype.addRevision):
  29713. (WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
  29714. (WebInspector.Resource.prototype._innerRequestContent):
  29715. (WebInspector.ResourceRevision):
  29716. (WebInspector.ResourceRevision.prototype.get resource):
  29717. (WebInspector.ResourceRevision.prototype.get timestamp):
  29718. (WebInspector.ResourceRevision.prototype.get content):
  29719. (WebInspector.ResourceRevision.prototype.revertToThis):
  29720. (WebInspector.ResourceRevision.prototype.requestContent.mycallback):
  29721. (WebInspector.ResourceRevision.prototype.requestContent):
  29722. * inspector/front-end/ResourceView.js:
  29723. (WebInspector.ResourceView.resourceViewTypeMatchesResource):
  29724. (WebInspector.ResourceView.resourceViewForResource):
  29725. (WebInspector.ResourceView.recreateResourceView):
  29726. (WebInspector.ResourceView.existingResourceViewForResource):
  29727. (WebInspector.RevisionSourceFrame):
  29728. (WebInspector.RevisionSourceFrame.prototype.get resource):
  29729. (WebInspector.RevisionSourceFrame.prototype.isContentEditable):
  29730. (WebInspector.RevisionSourceFrame.prototype.requestContent):
  29731. * inspector/front-end/ResourcesPanel.js:
  29732. (WebInspector.ResourcesPanel.prototype._showResourceView):
  29733. (WebInspector.ResourcesPanel.prototype._showRevisionView):
  29734. (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step1):
  29735. (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step2):
  29736. (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup):
  29737. (WebInspector.ResourceRevisionTreeElement):
  29738. (WebInspector.ResourceRevisionTreeElement.prototype.get itemURL):
  29739. (WebInspector.ResourceRevisionTreeElement.prototype.onselect):
  29740. (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
  29741. (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  29742. * inspector/front-end/SourceFrame.js:
  29743. (WebInspector.SourceFrame.prototype._ensureContentLoaded):
  29744. (WebInspector.SourceFrame.prototype.requestContent):
  29745. (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
  29746. (WebInspector.SourceFrame.prototype.commitEditing):
  29747. 2011-04-15 Alexander Pavlov <apavlov@chromium.org>
  29748. Reviewed by Yury Semikhatsky.
  29749. Web Inspector: Prevent Backspace keypresses from routing into the inspected page
  29750. https://bugs.webkit.org/show_bug.cgi?id=58653
  29751. * inspector/front-end/inspector.js:
  29752. (WebInspector.documentKeyDown):
  29753. 2011-04-15 Alice Boxhall <aboxhall@chromium.org>
  29754. Reviewed by Ryosuke Niwa.
  29755. Text selection changes unexpectedly when dragging out of the <input>
  29756. https://bugs.webkit.org/show_bug.cgi?id=55552
  29757. Tests: editing/selection/select-out-of-editable.html
  29758. editing/selection/select-out-of-floated-contenteditable.html
  29759. editing/selection/select-out-of-floated-input.html
  29760. editing/selection/select-out-of-floated-textarea.html
  29761. * page/EventHandler.cpp:
  29762. (WebCore::selectionExtentRespectingEditingBoundary): When dragging from an editable element, check that
  29763. the endpoint is not outside the element. If it is, translate the point into a local point within
  29764. the editable element.
  29765. (WebCore::EventHandler::updateSelectionForMouseDrag): Call targetPositionForSelectionEndpoint() to
  29766. calculate the selection endpoint.
  29767. 2011-04-15 Adam Roben <aroben@apple.com>
  29768. Roll out r83954
  29769. It was causing fast/dom/Window/timer-null-script-execution-context.html to crash on multiple
  29770. bots.
  29771. See <http://webkit.org/b/58610>.
  29772. * bindings/js/JSDOMWindowCustom.cpp:
  29773. (WebCore::JSDOMWindow::setTimeout):
  29774. (WebCore::JSDOMWindow::setInterval):
  29775. * bindings/js/JSWorkerContextCustom.cpp:
  29776. (WebCore::JSWorkerContext::setTimeout):
  29777. (WebCore::JSWorkerContext::setInterval):
  29778. * bindings/js/ScheduledAction.cpp:
  29779. (WebCore::ScheduledAction::create):
  29780. * bindings/js/ScheduledAction.h:
  29781. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  29782. (WebCore::WindowSetTimeoutImpl):
  29783. * page/ContentSecurityPolicy.cpp:
  29784. * page/ContentSecurityPolicy.h:
  29785. 2011-04-15 Pavel Feldman <pfeldman@google.com>
  29786. Reviewed by Yury Semikhatsky.
  29787. Web Inspector: refactor resource setContent / revisions infrastructure to get
  29788. rid of onRevert callback.
  29789. https://bugs.webkit.org/show_bug.cgi?id=58649
  29790. Instead, we will have DomainModel/Resource binding responsible for changing
  29791. underlying model upon resource changes and vice versa.
  29792. * inspector/Inspector.json:
  29793. * inspector/InspectorCSSAgent.cpp:
  29794. (WebCore::InspectorCSSAgent::getStyleSheet):
  29795. (WebCore::InspectorCSSAgent::getStyleSheetText):
  29796. (WebCore::InspectorCSSAgent::setStyleSheetText):
  29797. (WebCore::InspectorCSSAgent::setPropertyText):
  29798. (WebCore::InspectorCSSAgent::toggleProperty):
  29799. (WebCore::InspectorCSSAgent::setRuleSelector):
  29800. (WebCore::InspectorCSSAgent::assertStyleSheetForId):
  29801. * inspector/InspectorCSSAgent.h:
  29802. * inspector/front-end/CSSStyleModel.js:
  29803. (WebInspector.CSSStyleModel):
  29804. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  29805. (WebInspector.CSSStyleModel.prototype.addRule):
  29806. (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
  29807. (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
  29808. (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
  29809. (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
  29810. (WebInspector.CSSProperty.prototype.setText):
  29811. (WebInspector.CSSProperty.prototype.setText.callback):
  29812. (WebInspector.CSSProperty.prototype.setDisabled.callback):
  29813. (WebInspector.CSSProperty.prototype.setDisabled):
  29814. (WebInspector.CSSStyleSheet.prototype.setText):
  29815. (WebInspector.CSSStyleModelResourceBinding):
  29816. (WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
  29817. (WebInspector.CSSStyleModelResourceBinding.prototype._frameNavigated):
  29818. (WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent):
  29819. (WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
  29820. (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
  29821. (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
  29822. * inspector/front-end/DebuggerPresentationModel.js:
  29823. (WebInspector.DebuggerPresentationModel):
  29824. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
  29825. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
  29826. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  29827. (WebInspector.DebuggerPresentationModelResourceBinding):
  29828. (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
  29829. (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
  29830. * inspector/front-end/Object.js:
  29831. (WebInspector.Object.prototype.hasEventListeners):
  29832. * inspector/front-end/Resource.js:
  29833. (WebInspector.Resource):
  29834. (WebInspector.Resource.registerDomainModelBinding):
  29835. (WebInspector.Resource.prototype.isEditable):
  29836. (WebInspector.Resource.prototype.setContent):
  29837. (WebInspector.Resource.prototype.addRevision):
  29838. (WebInspector.Resource.prototype.revertToThis.callback):
  29839. (WebInspector.Resource.prototype.revertToThis):
  29840. (WebInspector.ResourceDomainModelBinding):
  29841. (WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
  29842. (WebInspector.ResourceDomainModelBinding.prototype.setContent):
  29843. * inspector/front-end/ResourceView.js:
  29844. (WebInspector.ResourceView.createResourceView):
  29845. (WebInspector.ResourceView.resourceViewTypeMatchesResource):
  29846. (WebInspector.ResourceSourceFrame.prototype.isContentEditable):
  29847. (WebInspector.ResourceSourceFrame.prototype.editContent):
  29848. (WebInspector.ResourceSourceFrame.prototype.endEditing):
  29849. (WebInspector.ResourceSourceFrame.prototype._clearIncrementalUpdateTimer):
  29850. (WebInspector.ResourceSourceFrame.prototype._requestContent):
  29851. * inspector/front-end/ResourcesPanel.js:
  29852. (WebInspector.ResourcesPanel.prototype._resourceAdded):
  29853. (WebInspector.FrameResourceTreeElement):
  29854. (WebInspector.FrameResourceTreeElement.prototype._populateRevisions):
  29855. (WebInspector.FrameResourceTreeElement.prototype._revisionAdded):
  29856. (WebInspector.FrameResourceTreeElement.prototype._appendRevision):
  29857. * inspector/front-end/inspector.html:
  29858. 2011-04-15 Andrey Kosyakov <caseq@chromium.org>
  29859. Unreviewed, rolling out r83949.
  29860. http://trac.webkit.org/changeset/83949
  29861. https://bugs.webkit.org/show_bug.cgi?id=57960
  29862. broke 31 tests in chromium win & linux
  29863. * platform/graphics/chromium/GLES2Canvas.cpp:
  29864. (WebCore::GLES2Canvas::drawTexturedRect):
  29865. * platform/graphics/chromium/GLES2Canvas.h:
  29866. * platform/graphics/gpu/Texture.cpp:
  29867. (WebCore::copySubRect):
  29868. (WebCore::Texture::load):
  29869. (WebCore::Texture::updateSubRect):
  29870. * platform/graphics/gpu/Texture.h:
  29871. * platform/graphics/skia/ImageBufferSkia.cpp:
  29872. (WebCore::getImageData):
  29873. (WebCore::putImageData):
  29874. (WebCore::ImageBuffer::putUnmultipliedImageData):
  29875. (WebCore::ImageBuffer::putPremultipliedImageData):
  29876. 2011-04-15 Ben Taylor <bentaylor.solx86@gmail.com>
  29877. Reviewed by Alexey Proskuryakov.
  29878. Fix building with Sun Studio 12: function pointers for extern "C" are treated differently
  29879. https://bugs.webkit.org/show_bug.cgi?id=58508
  29880. Since extern "C" makes a different type (although most compilers ignore that),
  29881. we should be more careful when passing NPAPI callback functions.
  29882. * plugins/npapi.cpp:
  29883. (NPN_PluginThreadAsyncCall):
  29884. 2011-04-15 Adam Barth <abarth@webkit.org>
  29885. Reviewed by Eric Seidel.
  29886. CSP should block string arguments to setTimeout and setInterval unless options eval-script
  29887. https://bugs.webkit.org/show_bug.cgi?id=58610
  29888. It's somewhat sadness that the JSC and V8 code for setTimeout and
  29889. setInterval are so different. I struggled for a while with how to
  29890. handle the worker case, but I decided to punt on it for now.
  29891. Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
  29892. http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
  29893. http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
  29894. http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
  29895. * bindings/js/JSDOMWindowCustom.cpp:
  29896. (WebCore::JSDOMWindow::setTimeout):
  29897. (WebCore::JSDOMWindow::setInterval):
  29898. * bindings/js/JSWorkerContextCustom.cpp:
  29899. (WebCore::JSWorkerContext::setTimeout):
  29900. (WebCore::JSWorkerContext::setInterval):
  29901. * bindings/js/ScheduledAction.cpp:
  29902. (WebCore::ScheduledAction::create):
  29903. * bindings/js/ScheduledAction.h:
  29904. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  29905. (WebCore::WindowSetTimeoutImpl):
  29906. * page/ContentSecurityPolicy.cpp:
  29907. (WebCore::ContentSecurityPolicy::allowEval):
  29908. * page/ContentSecurityPolicy.h:
  29909. 2011-04-15 Adam Barth <abarth@webkit.org>
  29910. Reviewed by Eric Seidel.
  29911. Add support for CSP's 'self' source
  29912. https://bugs.webkit.org/show_bug.cgi?id=58604
  29913. This change is now trivially easy.
  29914. Test: http/tests/security/contentSecurityPolicy/script-src-self.html
  29915. * page/ContentSecurityPolicy.cpp:
  29916. (WebCore::CSPSourceList::addSourceSelf):
  29917. 2011-04-15 Anna Cavender <annacc@chromium.org>
  29918. Reviewed by Eric Carlson.
  29919. Renaming TRACK feature define to VIDEO_TRACK
  29920. https://bugs.webkit.org/show_bug.cgi?id=53556
  29921. No new tests. No new functionality.
  29922. * CMakeLists.txt:
  29923. * Configurations/FeatureDefines.xcconfig:
  29924. * DerivedSources.make:
  29925. * GNUmakefile.am:
  29926. * features.pri:
  29927. * html/HTMLTagNames.in:
  29928. * html/HTMLTrackElement.cpp:
  29929. * html/HTMLTrackElement.h:
  29930. * html/HTMLTrackElement.idl:
  29931. 2011-04-14 Andrey Adaikin <aandrey@google.com>
  29932. Reviewed by Pavel Feldman.
  29933. Web Inspector: Ctrl+Left/Right switch panels during live editing
  29934. https://bugs.webkit.org/show_bug.cgi?id=58521
  29935. Disable Ctrl+Left/Right keyboard shortcuts while in live edit.
  29936. * inspector/front-end/SourceFrame.js:
  29937. (WebInspector.SourceFrame.prototype.readOnlyStateChanged):
  29938. * inspector/front-end/TextViewer.js:
  29939. (WebInspector.TextViewer.prototype.set readOnly):
  29940. (WebInspector.TextViewer.prototype.get readOnly):
  29941. (WebInspector.TextViewer.prototype._doubleClick):
  29942. (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
  29943. (WebInspector.TextViewer.prototype._commitEditing):
  29944. (WebInspector.TextViewer.prototype._cancelEditing):
  29945. (WebInspector.TextViewerDelegate.prototype.readOnlyStateChanged):
  29946. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  29947. * inspector/front-end/inspector.js:
  29948. (WebInspector.markBeingEdited):
  29949. (WebInspector.isEditingAnyField):
  29950. (WebInspector.startEditing.cleanUpAfterEditing):
  29951. 2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
  29952. Reviewed by Pavel Feldman.
  29953. Web Inspector: Enable raw HTTP headers support
  29954. https://bugs.webkit.org/show_bug.cgi?id=58259
  29955. Added raw headers text support to inspector.
  29956. * English.lproj/localizedStrings.js:
  29957. * inspector/Inspector.json:
  29958. * inspector/InspectorResourceAgent.cpp:
  29959. (WebCore::buildObjectForResourceResponse):
  29960. * inspector/front-end/NetworkManager.js:
  29961. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  29962. * inspector/front-end/Resource.js:
  29963. (WebInspector.Resource):
  29964. (WebInspector.Resource.prototype.get transferSize):
  29965. (WebInspector.Resource.prototype.set requestHeaders):
  29966. (WebInspector.Resource.prototype.get rawRequestHeadersText):
  29967. (WebInspector.Resource.prototype.set rawRequestHeadersText):
  29968. (WebInspector.Resource.prototype.get requestHeadersSize):
  29969. (WebInspector.Resource.prototype.set responseHeaders):
  29970. (WebInspector.Resource.prototype.get rawResponseHeadersText):
  29971. (WebInspector.Resource.prototype.set rawResponseHeadersText):
  29972. (WebInspector.Resource.prototype.get responseHeadersSize):
  29973. (WebInspector.Resource.prototype._headersSize):
  29974. * inspector/front-end/ResourceHeadersView.js:
  29975. (WebInspector.ResourceHeadersView):
  29976. (WebInspector.ResourceHeadersView.prototype._refreshParms):
  29977. (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
  29978. (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
  29979. (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
  29980. (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
  29981. (WebInspector.ResourceHeadersView.prototype._refreshRawHeadersText):
  29982. (WebInspector.ResourceHeadersView.prototype._toggleRawRequestHeadersText):
  29983. (WebInspector.ResourceHeadersView.prototype._toggleRawResponseHeadersText):
  29984. (WebInspector.ResourceHeadersView.prototype._createToggleButton):
  29985. (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
  29986. * inspector/front-end/networkPanel.css:
  29987. (.resource-headers-view .outline-disclosure li .header-toggle):
  29988. (.resource-headers-view .outline-disclosure li.expanded .header-toggle):
  29989. (.resource-headers-view .outline-disclosure li .header-toggle:hover):
  29990. (.resource-headers-view .outline-disclosure li.raw-headers-text):
  29991. * platform/network/ResourceLoadInfo.h:
  29992. 2011-04-14 Justin Novosad <junov@chromium.org>
  29993. Reviewed by Kenneth Russell.
  29994. [Chromium] Accelerated 2D Canvas is slow to execute putImageData
  29995. https://bugs.webkit.org/show_bug.cgi?id=57960
  29996. * platform/graphics/chromium/GLES2Canvas.cpp:
  29997. (WebCore::GLES2Canvas::drawTexturedRect):
  29998. Added an option for using the blend ops for alpha multiplication
  29999. instead of compositing.
  30000. (WebCore::GLES2Canvas::applyClipping):
  30001. (WebCore::GLES2Canvas::putImageData):
  30002. New method for drawing raw pixel data from memory to the canvas
  30003. (WebCore::GLES2Canvas::putUnmultipliedImageData):
  30004. Wrapper for putImageData
  30005. (WebCore::GLES2Canvas::putPremultipliedImageData):
  30006. Wrapper for putImageData
  30007. * platform/graphics/chromium/GLES2Canvas.h:
  30008. * platform/graphics/gpu/Texture.cpp:
  30009. (WebCore::copySubRect):
  30010. (WebCore::Texture::load):
  30011. (WebCore::Texture::updateSubRect):
  30012. Added an overload of the updateSubRect method that can receive a pixel
  30013. of a size that is different from texture size. Improved the performance
  30014. of updateSubrect by avoiding the allocation of a temporary buffer when
  30015. not required.
  30016. * platform/graphics/gpu/Texture.h:
  30017. * platform/graphics/skia/ImageBufferSkia.cpp:
  30018. (WebCore::getImageData):
  30019. In the unmultiplied path, division by alpha now performs proper
  30020. rounding in order to avoid generational degradation with putImageData
  30021. (WebCore::putImageData):
  30022. Alpha multiplication now performs proper rounding in order to be
  30023. consistent with the hardware rendering path: OpenGL always rounds when
  30024. converting to fixed point representation.
  30025. (WebCore::ImageBuffer::putUnmultipliedImageData):
  30026. Now supports a hardware rendering path, which eliminates the need
  30027. for a readback from the GPU
  30028. (WebCore::ImageBuffer::putPremultipliedImageData):
  30029. Now supports a hardware rendering path, which eliminates the need
  30030. for a readback from the GPU
  30031. 2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
  30032. Reviewed by Martin Robinson.
  30033. Creating a CairoPath instance is not thread safe
  30034. https://bugs.webkit.org/show_bug.cgi?id=58514
  30035. This patch allows a cairo surface to be created just one time in order to
  30036. guarantee thread safety.
  30037. In addition, CairoPath.{h,cpp} is renamed to PlatformPathCairo.{h,cpp} to
  30038. prevent confusing them with PathCairo.cpp
  30039. * CMakeListsEfl.txt: Added PlatformPathCairo.cpp
  30040. * GNUmakefile.list.am: Added PlatformPathCairo.{h,cpp} instead of CairoPath.h.
  30041. * platform/graphics/cairo/CairoPath.h: Removed.
  30042. * platform/graphics/cairo/CairoUtilities.cpp: Include PlatformPathCairo.h instead of CairoPath.h.
  30043. * platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
  30044. * platform/graphics/cairo/PathCairo.cpp: Ditto.
  30045. * platform/graphics/cairo/PlatformPathCairo.cpp: Added.
  30046. (WebCore::getPathSurface): Getting a static cairo surface.
  30047. (WebCore::CairoPath::CairoPath): Moved the implementation of the constructor
  30048. into the CPP file.
  30049. * platform/graphics/cairo/PlatformPathCairo.h: Renamed CairoPath.h to this.
  30050. (WebCore::CairoPath::~CairoPath):
  30051. (WebCore::CairoPath::context):
  30052. 2011-04-14 Nat Duca <nduca@chromium.org>
  30053. Reviewed by Darin Fisher.
  30054. [chromium] Add lowpass filter and graph to fps indicator
  30055. https://bugs.webkit.org/show_bug.cgi?id=58186
  30056. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  30057. (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
  30058. (WebCore::CCHeadsUpDisplay::drawHudContents):
  30059. (WebCore::CCHeadsUpDisplay::drawFPSCounter):
  30060. (WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
  30061. (WebCore::CCHeadsUpDisplay::onPresent):
  30062. * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  30063. 2011-04-14 Beth Dakin <bdakin@apple.com>
  30064. Reviewed by Adele Peterson.
  30065. https://bugs.webkit.org/show_bug.cgi?id=58612
  30066. Crash switching overlay/non-overlay scrollbar preference
  30067. (WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
  30068. -and corresponding-
  30069. <rdar://problem/9241920>
  30070. Speculative fix: Page could definitely be null here.
  30071. * page/FrameView.cpp:
  30072. (WebCore::FrameView::scrollbarStyleChanged):
  30073. 2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
  30074. Reviewed by Pavel Feldman.
  30075. Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
  30076. https://bugs.webkit.org/show_bug.cgi?id=58447
  30077. FrameLoader now takes encoded data length for synchronous requests from the field with the same name.
  30078. * loader/FrameLoader.cpp:
  30079. (WebCore::FrameLoader::loadResourceSynchronously):
  30080. * platform/network/ResourceLoadInfo.h:
  30081. (WebCore::ResourceLoadInfo::ResourceLoadInfo):
  30082. 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
  30083. Reviewed by James Robinson.
  30084. Remove dependency on chromium skia::PlatformCanvas
  30085. https://bugs.webkit.org/show_bug.cgi?id=57563
  30086. This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas. The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium. We will eventually define an API that every port using skia will define.
  30087. * platform/graphics/chromium/FontChromiumWin.cpp:
  30088. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
  30089. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  30090. (WebCore::Font::drawComplexText):
  30091. * platform/graphics/chromium/ImageBufferDataSkia.h:
  30092. * platform/graphics/chromium/LayerChromium.h:
  30093. * platform/graphics/chromium/LayerRendererChromium.h:
  30094. * platform/graphics/chromium/PlatformCanvas.cpp:
  30095. (WebCore::PlatformCanvas::resize):
  30096. * platform/graphics/chromium/PlatformCanvas.h:
  30097. * platform/graphics/chromium/TransparencyWin.cpp:
  30098. (WebCore::TransparencyWin::compositeTextComposite):
  30099. (WebCore::TransparencyWin::makeLayerOpaque):
  30100. * platform/graphics/skia/ImageBufferSkia.cpp:
  30101. (WebCore::ImageBuffer::ImageBuffer):
  30102. * platform/graphics/skia/ImageSkia.cpp:
  30103. (WebCore::paintSkBitmap):
  30104. (WebCore::Image::drawPattern):
  30105. * platform/graphics/skia/PlatformContextSkia.cpp:
  30106. (WebCore::PlatformContextSkia::PlatformContextSkia):
  30107. (WebCore::PlatformContextSkia::setCanvas):
  30108. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  30109. * platform/graphics/skia/PlatformContextSkia.h:
  30110. (WebCore::PlatformContextSkia::canvas):
  30111. (WebCore::PlatformContextSkia::printing):
  30112. (WebCore::PlatformContextSkia::setPrinting):
  30113. 2011-04-14 Eric Seidel <eric@webkit.org>
  30114. Reviewed by Simon Fraser.
  30115. PumpSession should not call currentTime() in the constructor
  30116. https://bugs.webkit.org/show_bug.cgi?id=55211
  30117. currentTime() is expensive. So we avoid calling it in the constructor
  30118. and instead set startTime on the first check for a yield
  30119. (which in the synchronous case never happens, and in the yielding
  30120. case will happen immediately after the first token due to
  30121. processedTokens being set to INT_MAX).
  30122. This ended up being a large win on (my local copy of)
  30123. peacekeeper's domDynamicCreationCreateElement:
  30124. Before:
  30125. avg 366.3333333333333
  30126. median 366
  30127. stdev 2.712112747574399
  30128. min 362
  30129. max 377
  30130. After:
  30131. avg 345.96666666666664
  30132. median 346
  30133. stdev 1.6829207415152454
  30134. min 343
  30135. max 349
  30136. * html/parser/HTMLDocumentParser.cpp:
  30137. * html/parser/HTMLParserScheduler.h:
  30138. (WebCore::PumpSession::PumpSession):
  30139. (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  30140. 2011-04-14 Ami Fischman <fischman@google.com>
  30141. Reviewed by Eric Carlson.
  30142. Remove unnecessary bottom margin of controls in video elements on media documents.
  30143. This makes the cases of media documents and non-media documents consistent,
  30144. and makes it possible to reason about the height of a rendered media document
  30145. (needed e.g. for sizing iframes).
  30146. This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
  30147. media/video-controls-in-media-document.html layouttest (see bug 54634 for
  30148. the un-Skipping).
  30149. https://bugs.webkit.org/show_bug.cgi?id=58442
  30150. * css/mediaControls.css:
  30151. (video:-webkit-full-page-media::-webkit-media-controls-panel):
  30152. * css/mediaControlsEfl.css:
  30153. (video:-webkit-full-page-media::-webkit-media-controls-panel):
  30154. * css/mediaControlsQuickTime.css:
  30155. (video:-webkit-full-page-media::-webkit-media-controls-panel):
  30156. 2011-04-14 Geoffrey Garen <ggaren@apple.com>
  30157. Reviewed by Oliver Hunt.
  30158. Use opaque roots instead of direct marking for nodes in the DOM
  30159. https://bugs.webkit.org/show_bug.cgi?id=58624
  30160. A node treats the root of its tree (usually the document) as its opaque
  30161. root during GC.
  30162. This is needed for correctness in a generational GC world, but it also
  30163. happens to be a 3.5X speedup in a DOM-heavy GC test (scratch-gc-dom2.html).
  30164. * bindings/js/DOMWrapperWorld.cpp:
  30165. (WebCore::isObservable):
  30166. (WebCore::isReachableFromDOM): Moved a helper function from JSDOMBinding.
  30167. We use this function to determine whether a node is observable.
  30168. (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): Start using
  30169. our weak handle callback to determine reachability, instead of direct
  30170. marking traversal through the DOM.
  30171. * bindings/js/JSAttrCustom.cpp:
  30172. (WebCore::JSAttr::markChildren): Updated to use the opaque roots mechanism
  30173. instead of direct marking.
  30174. * bindings/js/JSDOMBinding.cpp:
  30175. * bindings/js/JSDOMBinding.h: Moved code mentioned above. Removed
  30176. markDOMNodeWrapper because it is now unused. This is a good thing because
  30177. markDOMNodeWrapper used deprecatedAppend, which is not compatible
  30178. with generational GC.
  30179. * bindings/js/JSDOMImplementationCustom.cpp:
  30180. (WebCore::JSDOMImplementation::markChildren): Updated to use opaque roots.
  30181. * bindings/js/JSDocumentCustom.cpp:
  30182. (WebCore::JSDocument::markChildren): No need to mark our child nodes directly,
  30183. since they will take care of themselves through the opaque roots mechanism.
  30184. * bindings/js/JSNamedNodeMapCustom.cpp:
  30185. (WebCore::JSNamedNodeMap::markChildren): Updated to use opaque roots.
  30186. * bindings/js/JSNodeCustom.cpp:
  30187. (WebCore::JSNode::markChildren): No need to mark our tree or our document
  30188. directly, since they will take care of themselves through the opaque
  30189. roots mechanism.
  30190. * bindings/js/JSNodeCustom.h:
  30191. (WebCore::root): Helper function for accessing the root of a node tree.
  30192. This is O(1) while you're in the document, O(log(N)) when you're in a
  30193. reasonably balanced disconnected tree, and O(N) in the pathological case
  30194. of a disconnected tree that's shaped like a linked list. If average case
  30195. O(long(N)) turns out to be too slow, we can optimize through use of
  30196. rare data or an external hash table, but it is so uncommon that I have
  30197. ignored it for now.
  30198. * bindings/js/JSSVGElementInstanceCustom.cpp:
  30199. (WebCore::JSSVGElementInstance::markChildren): Updated to use opaque roots.
  30200. 2011-04-14 Mike Reed <reed@google.com>
  30201. Reviewed by Kenneth Russell.
  30202. fix shadows with gradients
  30203. https://bugs.webkit.org/show_bug.cgi?id=58376
  30204. No new tests. Existing tests exercise this
  30205. LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html
  30206. * platform/graphics/skia/GraphicsContextSkia.cpp:
  30207. (WebCore::GraphicsContext::setPlatformShadow):
  30208. 2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
  30209. Reviewed by Pavel Feldman.
  30210. Web Inspector: No headers information in network panel for downloads.
  30211. https://bugs.webkit.org/show_bug.cgi?id=58139
  30212. Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.
  30213. Test: http/tests/inspector/network/download.html
  30214. * inspector/InspectorInstrumentation.cpp:
  30215. (WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
  30216. (WebCore::InspectorInstrumentation::continueWithPolicyDownloadImpl):
  30217. (WebCore::InspectorInstrumentation::continueWithPolicyIgnoreImpl):
  30218. * inspector/InspectorInstrumentation.h:
  30219. (WebCore::InspectorInstrumentation::continueWithPolicyDownload):
  30220. (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
  30221. * loader/MainResourceLoader.cpp:
  30222. (WebCore::MainResourceLoader::continueAfterContentPolicy):
  30223. 2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
  30224. Reviewed by Martin Robinson.
  30225. Convert use of raw pointers to RefPtr in using Cairo
  30226. https://bugs.webkit.org/show_bug.cgi?id=57717
  30227. No new tests added becaue of just replacing raw pointers with smart pointers.
  30228. * platform/graphics/cairo/ContextShadowCairo.cpp: Use a RefPtr<cairo_surface_t> instead of raw pointer.
  30229. (WebCore::purgeScratchBuffer):
  30230. (WebCore::getScratchBuffer):
  30231. * platform/graphics/cairo/ImageBufferCairo.cpp: Use a RefPtr<cairo_t> instead of raw pointer.
  30232. (copySurface):
  30233. 2011-04-14 Naoki Takano <takano.naoki@gmail.com>
  30234. Reviewed by Eric Seidel.
  30235. [Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
  30236. https://bugs.webkit.org/show_bug.cgi?id=57818
  30237. Test: fast/forms/select-background-none.html
  30238. This fix is only for Chromium on Linux. Chromium on Mac already works fine.
  30239. But Windows has the same problem. This change doesn't include Windows part.
  30240. * rendering/RenderThemeChromiumLinux.cpp:
  30241. (WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
  30242. 2011-04-14 Luke Macpherson <macpherson@chromium.org>
  30243. Reviewed by Dimitri Glazkov.
  30244. Implement border style css properties in CSSStyleApplyProperty
  30245. https://bugs.webkit.org/show_bug.cgi?id=58506
  30246. No new functionality added.
  30247. * css/CSSStyleApplyProperty.cpp:
  30248. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  30249. Added new property initializers.
  30250. * css/CSSStyleSelector.cpp:
  30251. (WebCore::CSSStyleSelector::applyProperty):
  30252. Removed old property handlers.
  30253. 2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
  30254. Reviewed by Ojan Vafai.
  30255. Presence of shadow DOM should suppress rendering of ordinary child nodes
  30256. https://bugs.webkit.org/show_bug.cgi?id=58073
  30257. Test: fast/dom/shadow/no-renderers-for-light-children.html
  30258. * dom/Node.cpp:
  30259. (WebCore::shadowRoot): Added a helper function.
  30260. (WebCore::Node::setDocumentRecursively): Changed to use the helper.
  30261. (WebCore::shouldCreateRendererFor): Expanded a long condition check into a helper function,
  30262. added a check for children of an element with a shadow DOM.
  30263. (WebCore::Node::createRendererAndStyle): Changed to use the helper.
  30264. 2011-04-14 Adrienne Walker <enne@google.com>
  30265. Reviewed by James Robinson.
  30266. [chromium] Tile content and image layers
  30267. https://bugs.webkit.org/show_bug.cgi?id=57113
  30268. Layers tile by default if any dimension is larger than 512. Smaller
  30269. layers are contained within a single texture but still use the tiler
  30270. infrastructure so that there's only one code path.
  30271. Remove large layer support from content layers. Content layers no
  30272. longer own a platform canvas--they own a tiler. Refactor tiler to
  30273. allow for better separation of update/upload/paint. Add rect
  30274. parameter to update and draw functions on layers for the layer-space
  30275. rect of interest. This is necessary to know which tiles need to be
  30276. drawn.
  30277. * platform/graphics/chromium/ContentLayerChromium.cpp:
  30278. (WebCore::ContentLayerChromium::ContentLayerChromium):
  30279. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  30280. (WebCore::ContentLayerPainter::ContentLayerPainter):
  30281. (WebCore::ContentLayerPainter::paint):
  30282. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  30283. (WebCore::ContentLayerChromium::setLayerRenderer):
  30284. (WebCore::ContentLayerChromium::tilingTransform):
  30285. (WebCore::ContentLayerChromium::visibleLayerRect):
  30286. (WebCore::ContentLayerChromium::layerBounds):
  30287. (WebCore::ContentLayerChromium::updateLayerSize):
  30288. (WebCore::ContentLayerChromium::draw):
  30289. (WebCore::ContentLayerChromium::createTilerIfNeeded):
  30290. (WebCore::ContentLayerChromium::updateCompositorResources):
  30291. (WebCore::ContentLayerChromium::setTilingOption):
  30292. (WebCore::ContentLayerChromium::bindContentsTexture):
  30293. (WebCore::ContentLayerChromium::unreserveContentsTexture):
  30294. (WebCore::ContentLayerChromium::setIsMask):
  30295. (WebCore::ContentLayerChromium::dumpLayerProperties):
  30296. * platform/graphics/chromium/ContentLayerChromium.h:
  30297. (WebCore::ContentLayerChromium::drawsContent):
  30298. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  30299. (WebCore::GraphicsLayerChromium::setMaskLayer):
  30300. * platform/graphics/chromium/ImageLayerChromium.cpp:
  30301. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  30302. (WebCore::ImageLayerChromium::updateCompositorResources):
  30303. (WebCore::ImageLayerChromium::layerBounds):
  30304. (WebCore::ImageLayerChromium::tilingTransform):
  30305. * platform/graphics/chromium/ImageLayerChromium.h:
  30306. * platform/graphics/chromium/LayerChromium.h:
  30307. (WebCore::LayerChromium::invalidateRect):
  30308. (WebCore::LayerChromium::paintContentsIfDirty):
  30309. (WebCore::LayerChromium::setIsMask):
  30310. (WebCore::LayerChromium::draw):
  30311. * platform/graphics/chromium/LayerRendererChromium.cpp:
  30312. (WebCore::LayerRendererChromium::drawRootLayer):
  30313. (WebCore::LayerRendererChromium::drawLayers):
  30314. (WebCore::LayerRendererChromium::paintContentsRecursive):
  30315. (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
  30316. (WebCore::LayerRendererChromium::drawLayer):
  30317. (WebCore::LayerRendererChromium::initializeSharedObjects):
  30318. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  30319. * platform/graphics/chromium/LayerRendererChromium.h:
  30320. * platform/graphics/chromium/LayerTilerChromium.cpp:
  30321. (WebCore::LayerTilerChromium::setTileSize):
  30322. (WebCore::LayerTilerChromium::getSingleTexture):
  30323. (WebCore::LayerTilerChromium::invalidateRect):
  30324. (WebCore::LayerTilerChromium::update):
  30325. (WebCore::LayerTilerChromium::uploadCanvas):
  30326. (WebCore::LayerTilerChromium::updateFromPixels):
  30327. (WebCore::LayerTilerChromium::draw):
  30328. (WebCore::LayerTilerChromium::unreserveTextures):
  30329. * platform/graphics/chromium/LayerTilerChromium.h:
  30330. (WebCore::LayerTilerChromium::setLayerRenderer):
  30331. (WebCore::LayerTilerChromium::skipsDraw):
  30332. * platform/graphics/chromium/PlatformCanvas.cpp:
  30333. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  30334. (WebCore::PlatformCanvas::Painter::Painter):
  30335. * platform/graphics/chromium/PlatformCanvas.h:
  30336. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  30337. (WebCore::RenderSurfaceChromium::draw):
  30338. * platform/graphics/chromium/RenderSurfaceChromium.h:
  30339. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  30340. (WebCore::CCCanvasLayerImpl::draw):
  30341. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  30342. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  30343. (WebCore::CCHeadsUpDisplay::draw):
  30344. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  30345. (WebCore::CCLayerImpl::draw):
  30346. * platform/graphics/chromium/cc/CCLayerImpl.h:
  30347. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
  30348. (WebCore::CCPluginLayerImpl::draw):
  30349. * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  30350. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
  30351. (WebCore::CCVideoLayerImpl::draw):
  30352. * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
  30353. 2011-04-14 James Robinson <jamesr@chromium.org>
  30354. Reviewed by Darin Fisher.
  30355. [chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
  30356. https://bugs.webkit.org/show_bug.cgi?id=58575
  30357. Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
  30358. is called, not contentsResized() so that we always update layers when adding or removing scrollbars.
  30359. Covered by several chromium pixel tests.
  30360. * page/FrameView.cpp:
  30361. (WebCore::FrameView::contentsResized):
  30362. (WebCore::FrameView::visibleContentsResized):
  30363. 2011-04-07 David Levin <levin@chromium.org>
  30364. Reviewed by Brady Eidson.
  30365. Fix some threading issues in IconDatabase.
  30366. https://bugs.webkit.org/show_bug.cgi?id=57985
  30367. No functionality change so no new tests. It would be very hard to test this, but
  30368. I am working on a change for bug 31639 to detect these (which makes layout tests
  30369. fail for at least one of these issues).
  30370. * loader/icon/IconDatabase.cpp:
  30371. (WebCore::IconDatabase::setIconDataForIconURL): Release imageData so that it won't get deref'ed outside of locks.
  30372. (WebCore::IconDatabase::readFromDatabase): Ditto.
  30373. (WebCore::IconDatabase::writeToDatabase): Acquire m_urlAndIconLock because the SharedBuffer<> data
  30374. is used, and this lock seems to be the one which consistently guards it.
  30375. 2011-04-14 Dmitry Titov <dimich@chromium.org>
  30376. Reviewed by David Levin.
  30377. Simplifying Worker termination sequence (removing unnecessary mutex)
  30378. https://bugs.webkit.org/show_bug.cgi?id=57090
  30379. No new tests. Existing Worker tests should pass.
  30380. * bindings/js/JSEventListener.cpp:
  30381. (WebCore::JSEventListener::handleEvent):
  30382. Check for Terminator-caused exception (or Terminator::shouldTerminate since sometimes
  30383. JS might not run significant enough chunk to be terminated by Terminator) and set
  30384. the flag to forbid future reentry into JS.
  30385. * bindings/js/WorkerScriptController.cpp:
  30386. (WebCore::WorkerScriptController::evaluate):
  30387. (WebCore::WorkerScriptController::scheduleExecutionTermination):
  30388. (WebCore::WorkerScriptController::forbidExecution):
  30389. (WebCore::WorkerScriptController::isExecutionForbidden):
  30390. * bindings/js/WorkerScriptController.h:
  30391. * bindings/v8/WorkerScriptController.cpp:
  30392. (WebCore::WorkerScriptController::evaluate):
  30393. (WebCore::WorkerScriptController::scheduleExecutionTermination):
  30394. (WebCore::WorkerScriptController::forbidExecution):
  30395. (WebCore::WorkerScriptController::isExecutionForbidden):
  30396. * bindings/v8/WorkerScriptController.h:
  30397. (WebCore::WorkerScriptController::proxy):
  30398. Symmetrical changes to JSC and V8 WorkerScriptControllers:
  30399. - remove Mutex around operations with executionForbidden flag.
  30400. - set/check that flag only on Worker thread.
  30401. - some renaming in attempt to better reflect what the methods do.
  30402. * bindings/v8/V8AbstractEventListener.cpp:
  30403. (WebCore::V8AbstractEventListener::handleEvent):
  30404. (WebCore::V8AbstractEventListener::invokeEventHandler):
  30405. * bindings/v8/WorkerContextExecutionProxy.cpp:
  30406. (WebCore::WorkerContextExecutionProxy::evaluate):
  30407. Check for v8::TryCatch::CanContinue() and set forbidExecution flag.
  30408. This result indicates that TerminateExecution() was in effect - we should
  30409. not reenter V8 anymore after that.
  30410. * dom/Document.h:
  30411. (WebCore::Document::isJSExecutionForbidden):
  30412. * dom/MessagePort.cpp:
  30413. (WebCore::MessagePort::dispatchMessages):
  30414. Stop dispatching messages once the worker context started to close.
  30415. Per Workers spec, once WorkerGlobalScope.Close() is called, the next
  30416. JS execution does not happen, including onmessage events. Before this
  30417. change, Close() was setting the forbidExecution flag, indirectly stopping
  30418. events from dispatching.
  30419. * dom/ScriptExecutionContext.h:
  30420. * workers/WorkerContext.cpp:
  30421. (WebCore::WorkerContext::close):
  30422. (WebCore::WorkerContext::isJSExecutionForbidden):
  30423. * workers/WorkerContext.h:
  30424. * workers/WorkerThread.cpp:
  30425. (WebCore::WorkerThread::workerThread):
  30426. (WebCore::WorkerThread::stop):
  30427. 2011-04-14 Beth Dakin <bdakin@apple.com>
  30428. Reviewed by Simon Fraser.
  30429. https://bugs.webkit.org/show_bug.cgi?id=56493
  30430. Drag-scrolling overlay scrollbars thumb in overflow regions does not work
  30431. -and corresponding-
  30432. <rdar://problem/9112688>
  30433. There was an original change to fix this in the normal hit-testing case, but hit
  30434. testing of transformed and/or positioned objects was still broken. The transformed
  30435. case is fixed by sending an OverlayScrollbarSizeRelevancy parameter to
  30436. calculateRects(). Getting positioned objects right is a little trickier. Those need
  30437. to opt into using temporary clip rects during hit testing. To avoid doing that when
  30438. it is not necessary, I added a new bit to ScrollView to track whether there are
  30439. currently overlay scrollbars painted in the view.
  30440. * platform/ScrollView.cpp:
  30441. (WebCore::ScrollView::ScrollView):
  30442. (WebCore::ScrollView::wheelEvent):
  30443. * platform/ScrollView.h:
  30444. (WebCore::ScrollView::containsScrollableAreaWithOverlayScrollbars):
  30445. (WebCore::ScrollView::setContainsScrollableAreaWithOverlayScrollbars):
  30446. * rendering/RenderLayer.cpp:
  30447. (WebCore::RenderLayer::paintOverflowControls):
  30448. (WebCore::RenderLayer::hitTestLayer):
  30449. (WebCore::RenderLayer::updateClipRects):
  30450. (WebCore::RenderLayer::calculateClipRects):
  30451. (WebCore::RenderLayer::parentClipRects):
  30452. (WebCore::RenderLayer::backgroundClipRect):
  30453. (WebCore::RenderLayer::calculateRects):
  30454. * rendering/RenderLayer.h:
  30455. 2011-04-14 Antti Koivisto <antti@apple.com>
  30456. Reviewed by Oliver Hunt.
  30457. REGRESSION(r74107): Including svg format in @font-face rules makes Web Fonts fail to load
  30458. https://bugs.webkit.org/show_bug.cgi?id=57766
  30459. <rdar://problem/9232183>
  30460. Move the knowledge of whether to interpret a font as SVG from CachedFont to CSSFontFaceSource. This way
  30461. we can try to interpret the same cached resource in multiple ways.
  30462. Test: fast/css/font-face-repeated-url.html
  30463. * css/CSSFontFaceSource.cpp:
  30464. (WebCore::CSSFontFaceSource::CSSFontFaceSource):
  30465. (WebCore::CSSFontFaceSource::getFontData):
  30466. * css/CSSFontFaceSource.h:
  30467. (WebCore::CSSFontFaceSource::setHasExternalSVGFont):
  30468. * css/CSSFontSelector.cpp:
  30469. (WebCore::CSSFontSelector::addFontFaceRule):
  30470. * loader/cache/CachedFont.cpp:
  30471. (WebCore::CachedFont::CachedFont):
  30472. (WebCore::CachedFont::ensureCustomFontData):
  30473. (WebCore::CachedFont::ensureSVGFontData):
  30474. Use TextResourceDecoder correctly.
  30475. (WebCore::CachedFont::getSVGFontById):
  30476. * loader/cache/CachedFont.h:
  30477. * svg/SVGFontFaceUriElement.cpp:
  30478. (WebCore::SVGFontFaceUriElement::loadFont):
  30479. 2011-04-14 Kenneth Russell <kbr@google.com>
  30480. Reviewed by Dimitri Glazkov.
  30481. Enable building Web Audio with MKL in Chrome-branded builds
  30482. https://bugs.webkit.org/show_bug.cgi?id=58561
  30483. Factored out MKL support into a separate GYP file that is
  30484. incorporated in Chrome-branded builds. Changed how the FFTFrame
  30485. implementations are pulled in and chosen so that all files can be
  30486. unconditionally compiled.
  30487. Tested with both Chrome-branded build (incorporating MKL) and
  30488. Chromium build (building just FFTFrameStub.cpp) on Linux.
  30489. * WebCore.gyp/WebCore.gyp:
  30490. * platform/audio/fftw/FFTFrameFFTW.cpp:
  30491. * platform/audio/mkl/FFTFrameMKL.cpp:
  30492. 2011-04-14 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
  30493. Reviewed by Antonio Gomes.
  30494. [Qt] Web Inspector does not highlight elements
  30495. https://bugs.webkit.org/show_bug.cgi?id=35125
  30496. We should call drawNodeHighlight() just if a highlighted node exists
  30497. to avoid do save()/restore() on the Graphics Context unnecessarily.
  30498. Added highlightedNode() method to check if we need to call drawNodeHighlight()
  30499. and only on this case do save()/restore() on the Graphics Context.
  30500. * inspector/InspectorAgent.h:
  30501. (WebCore::InspectorAgent::highlightedNode):
  30502. 2011-04-14 Adrienne Walker <enne@google.com>
  30503. Reviewed by James Robinson.
  30504. [chromium] TilingData should return 1 tile when tile size is texture size.
  30505. https://bugs.webkit.org/show_bug.cgi?id=58364
  30506. * platform/graphics/gpu/TilingData.cpp:
  30507. (WebCore::computeNumTiles):
  30508. 2011-04-14 Andy Estes <aestes@apple.com>
  30509. Reviewed by Dan Bernstein.
  30510. REGRESSION (r72141): Acid3 rendering is not pixel perfect.
  30511. https://bugs.webkit.org/show_bug.cgi?id=55734
  30512. WebCore should render text with a 0px font size at 0px regardless of
  30513. minimum font size settings. This is compatible with other browsers that
  30514. have a minimum font size preference and ensures pixel-perfect rendering
  30515. on Acid3.
  30516. Test: fast/text/zero-font-size.html
  30517. * css/CSSStyleSelector.cpp:
  30518. (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If
  30519. specifiedSize is 0, return specified size regardless of zoom factor or
  30520. minimum font size.
  30521. 2011-04-14 Matthew Delaney <mdelaney@apple.com>
  30522. Reviewed by Simon Fraser.
  30523. Have canvas drawImageFromRect just redirect to use drawImage
  30524. https://bugs.webkit.org/show_bug.cgi?id=58516
  30525. Test: fast/canvas/drawImageFromRect_withToDataURLAsSource.html
  30526. * html/canvas/CanvasRenderingContext2D.cpp:
  30527. (WebCore::CanvasRenderingContext2D::drawImage):
  30528. (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  30529. * html/canvas/CanvasRenderingContext2D.h:
  30530. 2011-04-14 James Robinson <jamesr@chromium.org>
  30531. Reviewed by Simon Fraser.
  30532. REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
  30533. https://bugs.webkit.org/show_bug.cgi?id=58535
  30534. Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.
  30535. * rendering/RenderLayerBacking.cpp:
  30536. (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
  30537. (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
  30538. (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
  30539. * rendering/RenderLayerCompositor.cpp:
  30540. (WebCore::shouldCompositeOverflowControls):
  30541. 2011-04-14 Jian Li <jianli@chromium.org>
  30542. Reviewed by Darin Fisher.
  30543. BlobBuilder should be vendor-prefixed
  30544. https://bugs.webkit.org/show_bug.cgi?id=58518
  30545. Renamed BlobBuilder to WebKitBlobBuilder.
  30546. * Android.derived.jscbindings.mk:
  30547. * Android.derived.v8bindings.mk:
  30548. * CMakeLists.txt:
  30549. * CodeGenerators.pri:
  30550. * DerivedSources.cpp:
  30551. * DerivedSources.make:
  30552. * GNUmakefile.list.am:
  30553. * WebCore.gypi:
  30554. * WebCore.pro:
  30555. * WebCore.vcproj/WebCore.vcproj:
  30556. * WebCore.xcodeproj/project.pbxproj:
  30557. * fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.
  30558. (WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
  30559. (WebCore::WebKitBlobBuilder::getBuffer):
  30560. (WebCore::WebKitBlobBuilder::append):
  30561. (WebCore::WebKitBlobBuilder::getBlob):
  30562. * fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.
  30563. (WebCore::WebKitBlobBuilder::create):
  30564. * fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
  30565. * page/DOMWindow.idl:
  30566. * workers/WorkerContext.idl:
  30567. 2011-04-14 Adam Barth <abarth@webkit.org>
  30568. Remove some trailing whitespace. I'm making this change to initialize
  30569. the SVN credentials on a new commit-queue machine. I'm sure there's a
  30570. better way to do this, but I don't know it.
  30571. * dom/Document.cpp:
  30572. (WebCore::Document::Document):
  30573. 2011-04-14 Pratik Solanki <psolanki@apple.com>
  30574. Reviewed by David Kilzer.
  30575. Set minimum priority for fast lane connections
  30576. https://bugs.webkit.org/show_bug.cgi?id=58353
  30577. * WebCore.exp.in:
  30578. * platform/mac/WebCoreSystemInterface.h:
  30579. * platform/mac/WebCoreSystemInterface.mm:
  30580. * platform/network/cf/ResourceRequestCFNet.cpp:
  30581. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
  30582. wkSetHTTPPipeliningMinimumFastLanePriority to allow javascript resources to use the fast
  30583. lane connections.
  30584. 2011-04-14 Kenneth Russell <kbr@google.com>
  30585. Reviewed by Dimitri Glazkov.
  30586. Fix Web Audio build on Linux Debug and with stub FFTFrame
  30587. https://bugs.webkit.org/show_bug.cgi?id=58555
  30588. Built Chromium/Linux in Debug mode to test.
  30589. * platform/audio/FFTFrame.cpp:
  30590. * platform/audio/FFTFrameStub.cpp:
  30591. (WebCore::FFTFrame::initialize):
  30592. * webaudio/AudioContext.cpp:
  30593. * webaudio/DefaultAudioDestinationNode.cpp:
  30594. 2011-04-14 Yury Semikhatsky <yurys@chromium.org>
  30595. Reviewed by Pavel Feldman.
  30596. [v8] Web Inspector: add initial implementation of WorkerScriptDebugServer
  30597. https://bugs.webkit.org/show_bug.cgi?id=58552
  30598. * bindings/v8/DebuggerScript.js:
  30599. * bindings/v8/WorkerContextExecutionProxy.cpp:
  30600. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): each worker context
  30601. now have a debug id (similar to frame contexts).
  30602. * bindings/v8/WorkerScriptDebugServer.cpp:
  30603. (WebCore::retrieveWorkerContext):
  30604. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
  30605. (WebCore::WorkerScriptDebugServer::addListener):
  30606. (WebCore::WorkerScriptDebugServer::removeListener):
  30607. (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
  30608. (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): run message loop until
  30609. debugger command is received and execution is resumed.
  30610. (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  30611. * bindings/v8/WorkerScriptDebugServer.h:
  30612. * inspector/WorkerDebuggerAgent.cpp:
  30613. (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
  30614. (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
  30615. 2011-04-14 Jian Li <jianli@chromium.org>
  30616. Reviewed by Darin Fisher.
  30617. Add webkit prefix to Blob.slice method and change its semantics to be
  30618. like Array.slice
  30619. https://bugs.webkit.org/show_bug.cgi?id=58496
  30620. Renamed Blob.slice to blob.webkitSlice and made it take start and end
  30621. parameters that're like Array.slice.
  30622. Test: fast/files/blob-slice-test.html
  30623. * fileapi/Blob.cpp:
  30624. (WebCore::Blob::webkitSlice):
  30625. * fileapi/Blob.h:
  30626. * fileapi/Blob.idl:
  30627. 2011-04-14 Andreas Kling <kling@webkit.org>
  30628. Reviewed by Benjamin Poulain.
  30629. [Qt] Height of "Ahem" font differs from all other ports.
  30630. https://bugs.webkit.org/show_bug.cgi?id=57954
  30631. QFontMetricsF::descent() returns the actual descent minus 1,
  30632. to account for the baseline. Add it back to get correct metrics
  30633. for WebKit.
  30634. QFontMetricsF::leading() may return negative values on some
  30635. platforms (those using FreeType), this breaks WebKit's assumption
  30636. that lineSpacing >= (ascent + descent), so we work around this in
  30637. the same fashion as SimpleFontDataFreeType and SimpleFontDataPango.
  30638. This is covered by thousands of layout tests.
  30639. * platform/graphics/qt/SimpleFontDataQt.cpp:
  30640. (WebCore::SimpleFontData::platformInit):
  30641. 2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
  30642. [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
  30643. * platform/graphics/wx/FontPlatformDataWx.cpp:
  30644. (WebCore::FontPlatformData::FontPlatformData):
  30645. * platform/wx/FileSystemWx.cpp:
  30646. (WebCore::writeToFile):
  30647. 2011-04-14 Anders Carlsson <andersca@apple.com>
  30648. Fix build.
  30649. RuntimeApplicationChecks.h needs to be a private header so WebKit can find it.
  30650. * WebCore.xcodeproj/project.pbxproj:
  30651. 2011-04-14 Pavel Podivilov <podivilov@chromium.org>
  30652. Unreviewed, build fix for r83864.
  30653. * inspector/front-end/DOMAgent.js:
  30654. (WebInspector.DOMAgent.prototype._childNodeRemoved):
  30655. 2011-04-14 Alexander Pavlov <apavlov@chromium.org>
  30656. Reviewed by Pavel Feldman.
  30657. Web Inspector: Content area highlight does not cover scrollbars
  30658. https://bugs.webkit.org/show_bug.cgi?id=58528
  30659. * inspector/DOMNodeHighlighter.cpp:
  30660. (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  30661. 2011-04-14 Pavel Podivilov <podivilov@chromium.org>
  30662. Reviewed by Pavel Feldman.
  30663. Web Inspector: re-implement dom breakpoints.
  30664. https://bugs.webkit.org/show_bug.cgi?id=57038
  30665. * WebCore.gypi:
  30666. * WebCore.vcproj/WebCore.vcproj:
  30667. * inspector/front-end/BreakpointManager.js: Removed.
  30668. * inspector/front-end/BreakpointsSidebarPane.js:
  30669. (WebInspector.NativeBreakpointsSidebarPane):
  30670. (WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
  30671. (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
  30672. * inspector/front-end/CallStackSidebarPane.js:
  30673. (WebInspector.CallStackSidebarPane.prototype.update):
  30674. (WebInspector.CallStackSidebarPane.prototype.setStatus):
  30675. * inspector/front-end/DOMAgent.js:
  30676. (WebInspector.DOMNode):
  30677. (WebInspector.DOMAgent.prototype._childNodeRemoved):
  30678. * inspector/front-end/DOMBreakpointsSidebarPane.js: Added.
  30679. (WebInspector.DOMBreakpointsSidebarPane):
  30680. (WebInspector.DOMBreakpointsSidebarPane.prototype.setInspectedURL):
  30681. (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu.toggleBreakpoint):
  30682. (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu):
  30683. (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
  30684. (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
  30685. (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.formatters.s):
  30686. (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.append):
  30687. (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage):
  30688. (WebInspector.DOMBreakpointsSidebarPane.prototype.nodeRemoved):
  30689. (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpointsForNode):
  30690. (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
  30691. (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpoint):
  30692. (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
  30693. (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
  30694. (WebInspector.DOMBreakpointsSidebarPane.prototype._checkboxClicked):
  30695. (WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
  30696. (WebInspector.DOMBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  30697. (WebInspector.DOMBreakpointsSidebarPane.prototype._createBreakpointId):
  30698. (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
  30699. (WebInspector.DOMBreakpointsSidebarPane.prototype.restoreBreakpoints):
  30700. * inspector/front-end/ElementsPanel.js:
  30701. (WebInspector.ElementsPanel):
  30702. (WebInspector.ElementsPanel.prototype.show):
  30703. (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  30704. (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.coalesceCollapsedCrumbs):
  30705. * inspector/front-end/ElementsTreeOutline.js:
  30706. (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  30707. * inspector/front-end/ScriptsPanel.js:
  30708. (WebInspector.ScriptsPanel):
  30709. (WebInspector.ScriptsPanel.prototype.show):
  30710. (WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
  30711. (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
  30712. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  30713. (WebInspector.ScriptsPanel.prototype._clearInterface):
  30714. * inspector/front-end/Settings.js:
  30715. (WebInspector.Settings):
  30716. (WebInspector.Settings.prototype._set):
  30717. * inspector/front-end/WebKit.qrc:
  30718. * inspector/front-end/inspector.html:
  30719. * inspector/front-end/inspector.js:
  30720. (WebInspector.inspectedURLChanged):
  30721. * inspector/front-end/utilities.js:
  30722. ():
  30723. 2011-04-14 Satish Sampath <satish@chromium.org>
  30724. Reviewed by Kent Tamura.
  30725. Disable speech input for readonly and disabled input fields.
  30726. https://bugs.webkit.org/show_bug.cgi?id=58540
  30727. Test: fast/speech/input-readonly-and-disabled.html
  30728. * html/shadow/TextControlInnerElements.cpp:
  30729. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  30730. (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
  30731. 2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
  30732. Unreviewed. Rollout r83849 and r83857.
  30733. * inspector/Inspector.json:
  30734. * inspector/InspectorDatabaseAgent.cpp:
  30735. (WebCore::InspectorDatabaseAgent::didOpenDatabase):
  30736. (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  30737. (WebCore::InspectorDatabaseAgent::setFrontend):
  30738. (WebCore::InspectorDatabaseAgent::clearFrontend):
  30739. (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
  30740. (WebCore::InspectorDatabaseAgent::executeSQL):
  30741. * inspector/InspectorDatabaseAgent.h:
  30742. * inspector/front-end/inspector.js:
  30743. 2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
  30744. Unreviewed, rolling out r83847.
  30745. http://trac.webkit.org/changeset/83847
  30746. https://bugs.webkit.org/show_bug.cgi?id=58477
  30747. Chromium media controls do use button borders, so this change
  30748. is incorrect.
  30749. * css/mediaControls.css:
  30750. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
  30751. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
  30752. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  30753. (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
  30754. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
  30755. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
  30756. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
  30757. (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
  30758. (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
  30759. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  30760. (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
  30761. 2011-04-14 Andrew Wason <rectalogic@rectalogic.com>
  30762. Reviewed by Andreas Kling.
  30763. Fix GraphicsContext3DQt.cpp compilation warnings treated as errors
  30764. https://bugs.webkit.org/show_bug.cgi?id=58478
  30765. No new tests.
  30766. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  30767. (WebCore::GraphicsContext3DInternal::getProcAddress):
  30768. Do not use deprecated QString constructor to avoid warning.
  30769. (WebCore::GraphicsContext3D::reshape):
  30770. Use parenthesis to avoid warning.
  30771. 2011-04-14 Andrey Kosyakov <caseq@chromium.org>
  30772. Unreviewed. Removed ScrollableArea::paintScrollCorner() added in r83820,
  30773. as it breaks chromium clang build (shadowed by RenderLayer::paintScrollCorner()
  30774. with a different signature)
  30775. * platform/ScrollableArea.h:
  30776. 2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
  30777. Reviewed by Pavel Feldman.
  30778. Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
  30779. https://bugs.webkit.org/show_bug.cgi?id=58534
  30780. * inspector/front-end/DetailedHeapshotGridNodes.js:
  30781. (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
  30782. (WebInspector.HeapSnapshotDiffNode):
  30783. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
  30784. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
  30785. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
  30786. (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
  30787. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  30788. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  30789. (WebInspector.HeapSnapshotDiffNode.prototype.get data):
  30790. * inspector/front-end/DetailedHeapshotView.js:
  30791. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
  30792. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
  30793. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
  30794. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
  30795. * inspector/front-end/HeapSnapshot.js:
  30796. (WebInspector.HeapSnapshot):
  30797. (WebInspector.HeapSnapshot.prototype.dispose):
  30798. (WebInspector.HeapSnapshot.prototype.nodeFieldValuesByIndex):
  30799. (WebInspector.HeapSnapshot.prototype._numbersComparator):
  30800. (WebInspector.HeapSnapshot.prototype.baseSnapshotHasNode):
  30801. (WebInspector.HeapSnapshot.prototype.updateBaseNodeIds):
  30802. (WebInspector.HeapSnapshotsDiff):
  30803. (WebInspector.HeapSnapshotsDiff.prototype.set baseIds):
  30804. (WebInspector.HeapSnapshotsDiff.prototype.set baseSelfSizes):
  30805. (WebInspector.HeapSnapshotsDiff.prototype.calculate):
  30806. * inspector/front-end/HeapSnapshotProxy.js:
  30807. (WebInspector.HeapSnapshotProxy):
  30808. (WebInspector.HeapSnapshotProxy.prototype.createDiff):
  30809. (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
  30810. (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
  30811. (WebInspector.HeapSnapshotProxy.prototype.dispose):
  30812. (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
  30813. (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
  30814. (WebInspector.HeapSnapshotsDiffProxy):
  30815. (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
  30816. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
  30817. (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
  30818. 2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
  30819. Reviewed by Pavel Feldman.
  30820. Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
  30821. https://bugs.webkit.org/show_bug.cgi?id=57833
  30822. * inspector/Inspector.json:
  30823. * inspector/InspectorDatabaseAgent.cpp:
  30824. (WebCore::InspectorDatabaseAgent::didOpenDatabase):
  30825. (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  30826. (WebCore::InspectorDatabaseAgent::setFrontend):
  30827. (WebCore::InspectorDatabaseAgent::enable):
  30828. (WebCore::InspectorDatabaseAgent::disable):
  30829. (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
  30830. (WebCore::InspectorDatabaseAgent::executeSQL):
  30831. * inspector/InspectorDatabaseAgent.h:
  30832. * inspector/front-end/inspector.js:
  30833. 2011-04-14 Alexander Pavlov <apavlov@chromium.org>
  30834. Reviewed by Yury Semikhatsky.
  30835. Web Inspector: [Chromium] "Remove Breakpoint" menu item is absent in the DOM breakpoints sidebar pane
  30836. https://bugs.webkit.org/show_bug.cgi?id=58530
  30837. * inspector/front-end/ElementsPanel.js:
  30838. 2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
  30839. Reviewed by Dimitri Glazkov.
  30840. REGRESSION(r83397) [Qt] When clicking on the media elements they
  30841. grow 2 pixels.
  30842. https://bugs.webkit.org/show_bug.cgi?id=58477
  30843. Since r83397 the media controls elements are actual DOM elements.
  30844. Therefore the global style-sheet applies to them. html.css defines
  30845. input[type="button"]:active to be border-style: inset which means
  30846. that when the buttons are active they grow by their border size.
  30847. * css/mediaControls.css:
  30848. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
  30849. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
  30850. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  30851. (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
  30852. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
  30853. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
  30854. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
  30855. (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
  30856. (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
  30857. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  30858. (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
  30859. 2011-04-14 Diego Gonzalez <diegohcg@webkit.org>
  30860. Reviewed by Kenneth Rohde Christiansen.
  30861. [Qt] Improve disable style for input elements in mobile theme
  30862. https://bugs.webkit.org/show_bug.cgi?id=58480
  30863. * platform/qt/QtMobileWebStyle.cpp:
  30864. (QtMobileWebStyle::drawControl):
  30865. (QtMobileWebStyle::drawPrimitive):
  30866. (QtMobileWebStyle::drawComplexControl):
  30867. 2011-04-14 Pavel Feldman <pfeldman@google.com>
  30868. Reviewed by Yury Semikhatsky.
  30869. Web Inspector: restore previous selection in Resources panel upon front-end reopen.
  30870. https://bugs.webkit.org/show_bug.cgi?id=58533
  30871. * inspector/front-end/ResourceTreeModel.js:
  30872. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  30873. * inspector/front-end/ResourcesPanel.js:
  30874. (WebInspector.ResourcesPanel.prototype._initDefaultSelection):
  30875. (WebInspector.ResourcesPanel.prototype._populateResourceTree):
  30876. (WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
  30877. * inspector/front-end/inspector.css:
  30878. (#close-button-left, #close-button-right):
  30879. 2011-04-14 Pavel Feldman <pfeldman@google.com>
  30880. Reviewed by Yury Semikhatsky.
  30881. Web Inspector: implement incremental CSS free flow editing.
  30882. https://bugs.webkit.org/show_bug.cgi?id=58529
  30883. * inspector/front-end/CSSStyleModel.js:
  30884. (WebInspector.CSSStyleSheet.prototype.setText):
  30885. * inspector/front-end/Resource.js:
  30886. (WebInspector.Resource.prototype.isResourceRevision):
  30887. (WebInspector.Resource.prototype.setContent):
  30888. * inspector/front-end/ResourceView.js:
  30889. (WebInspector.CSSSourceFrame.prototype.isContentEditable):
  30890. (WebInspector.CSSSourceFrame.prototype.editContent):
  30891. (WebInspector.CSSSourceFrame.prototype.endEditing.commitIncrementalEdit):
  30892. (WebInspector.CSSSourceFrame.prototype.endEditing):
  30893. * inspector/front-end/SourceFrame.js:
  30894. (WebInspector.SourceFrame.prototype.commitEditing):
  30895. (WebInspector.SourceFrame.prototype.editContent):
  30896. 2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
  30897. Reviewed by Pavel Feldman.
  30898. Web Inspector:Duplicated display of storage db when running Web SQL from an iframe.
  30899. https://bugs.webkit.org/show_bug.cgi?id=57830
  30900. There was created a new InspectorDatabaseResource entry for every didOpenDatabase event.
  30901. Moreover there is new WebCore::Database for each didOpenDatabase event.
  30902. I decided to change the old instance of the Database to a new one if they both use the same file.
  30903. * inspector/InspectorDatabaseAgent.cpp:
  30904. (WebCore::InspectorDatabaseAgent::didOpenDatabase):
  30905. (WebCore::InspectorDatabaseAgent::findByFileName):
  30906. * inspector/InspectorDatabaseAgent.h:
  30907. * inspector/InspectorDatabaseResource.h:
  30908. (WebCore::InspectorDatabaseResource::setDatabase):
  30909. 2011-04-14 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
  30910. Reviewed by Dirk Schulze.
  30911. svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
  30912. https://bugs.webkit.org/show_bug.cgi?id=58525
  30913. A renderer is created even for those filter primitives
  30914. which parent is not a filter. A rendererIsNeeded() is
  30915. added to SVGFilterPrimitiveStandardAttributes.
  30916. Test: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
  30917. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  30918. (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  30919. * svg/SVGFilterPrimitiveStandardAttributes.h:
  30920. 2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
  30921. Reviewed by Andreas Kling.
  30922. REGRESSION(r83397) [Qt] When the video is loading and the poster is shown
  30923. all the controls are not visible except the play button.
  30924. https://bugs.webkit.org/show_bug.cgi?id=58484
  30925. r83397 introduces a new API hasOwnDisabledStateHandlingFor to handle when
  30926. the controls should be disabled. Qt port paints its own controls, we don't want
  30927. the default implementation to handle the hidden/disable state for us.
  30928. Existing tests covers the visibility of the controls.
  30929. * platform/qt/RenderThemeQt.h:
  30930. (WebCore::RenderThemeQt::hasOwnDisabledStateHandlingFor):
  30931. 2011-04-14 Andreas Kling <andreas.kling@nokia.com>
  30932. Reviewed by Kenneth Rohde Christiansen.
  30933. [Qt] Disabled form controls don't actually look disabled.
  30934. https://bugs.webkit.org/show_bug.cgi?id=58490
  30935. Unsetting QStyle::State_Enabled is not enough to get the "disabled" appearance
  30936. when painting controls. We must also set the QStyleOption's palette's current
  30937. color group.
  30938. * platform/qt/RenderThemeQt.cpp:
  30939. (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
  30940. 2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
  30941. Reviewed by Benjamin Poulain.
  30942. [Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter
  30943. https://bugs.webkit.org/show_bug.cgi?id=58188
  30944. The codec parameter in MediaPlayerPrivateQt::supportsType was not parsed into
  30945. a QStringList. This change parses and trims the list.
  30946. An additional test was added to video-can-play-type.html to test parsing of codec parameter.
  30947. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  30948. (WebCore::MediaPlayerPrivateQt::supportsType):
  30949. 2011-04-14 Zoltan Herczeg <zherczeg@webkit.org>
  30950. Reviewed by Nikolas Zimmermann.
  30951. Optimizing lightning filter to ARM-NEON SIMD instruction set
  30952. https://bugs.webkit.org/show_bug.cgi?id=54456
  30953. NEON is the SIMD instruction set for ARM. This instruction set
  30954. allows to speed-up the lighting filter by 4 times on ARM
  30955. (on WebCore/manual-tests/svg-filter-animation.svg).
  30956. * WebCore.pri:
  30957. * WebCore.pro:
  30958. * platform/graphics/filters/FELighting.cpp:
  30959. (WebCore::FELighting::drawLighting):
  30960. (WebCore::getPowerCoefficients):
  30961. (WebCore::FELighting::drawInteriorPixels):
  30962. * platform/graphics/filters/FELighting.h:
  30963. * platform/graphics/filters/arm/FELightingNEON.cpp: Added.
  30964. (__attribute__):
  30965. * platform/graphics/filters/arm/FELightingNEON.h: Added.
  30966. 2011-04-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  30967. Reviewed by Benjamin Poulain.
  30968. [Qt] GraphicsContext3D internal buffers are not freed
  30969. https://bugs.webkit.org/show_bug.cgi?id=57530
  30970. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  30971. (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
  30972. 2011-04-14 Andy Estes <aestes@apple.com>
  30973. Reviewed by Maciej Stachowiak.
  30974. REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling
  30975. https://bugs.webkit.org/show_bug.cgi?id=52988
  30976. Safari RSS relies on synchronous dispatch of ScrollEvent to update the
  30977. position of its sidebar during scrolling without producing a jiggling
  30978. effect. Due to r75555, this event is no longer dispatched synchronously
  30979. which results in stale repaints before the onscroll handler gets a
  30980. chance to update the position of the sidebar.
  30981. Since it is impractical to resolve this issue in Safari RSS itself, add
  30982. a quirk that restores synchronous ScrollEvent dispatch for Safari RSS.
  30983. No tests. This is an app-specific change that doesn't affect web
  30984. content.
  30985. * Android.mk: Add platform/RuntimeApplicationChecks.[cpp|h]
  30986. * CMakeLists.txt: Ditto.
  30987. * GNUmakefile.list.am: Ditto.
  30988. * WebCore.gypi: Ditto.
  30989. * WebCore.pro: Ditto.
  30990. * WebCore.vcproj/WebCore.vcproj: Ditto.
  30991. * WebCore.xcodeproj/project.pbxproj: Ditto.
  30992. * dom/EventQueue.cpp:
  30993. (WebCore::shouldDispatchScrollEventSynchronously): Send ScrollEvent
  30994. synchronously if the embedding application is Safari and the document's
  30995. URL scheme is "feed" or "feeds".
  30996. (WebCore::EventQueue::enqueueOrDispatchScrollEvent): Dispatch
  30997. ScrollEvent synchronously if shouldDispatchScrollEventSynchronously()
  30998. returns true.
  30999. * dom/EventQueue.h:
  31000. * page/EventHandler.cpp:
  31001. (WebCore::EventHandler::sendScrollEvent): Call enqueueOrDispatchScrollEvent().
  31002. * platform/RuntimeApplicationChecks.cpp: Added.
  31003. (WebCore::mainBundleIsEqualTo): Add a helper routine for CF platforms
  31004. that checks if the main bundle's identifier is equal to a given string.
  31005. This function returns false for non-CF platforms.
  31006. (WebCore::applicationIsSafari): Call mainBundleIsEqualTo().
  31007. (WebCore::applicationIsAppleMail): Ditto.
  31008. (WebCore::applicationIsMicrosoftMessenger): Ditto.
  31009. (WebCore::applicationIsAdobeInstaller): Ditto.
  31010. (WebCore::applicationIsAOLInstantMessenger): Ditto.
  31011. (WebCore::applicationIsMicrosoftMyDay): Ditto.
  31012. (WebCore::applicationIsMicrosoftOutlook): Ditto.
  31013. * platform/mac/RuntimeApplicationChecks.mm: Removed. Functions moved to
  31014. RuntimeApplicationChecks.cpp.
  31015. * rendering/RenderLayer.cpp:
  31016. (WebCore::RenderLayer::scrollTo): Call enqueueOrDispatchScrollEvent().
  31017. * rendering/RenderListBox.cpp:
  31018. (WebCore::RenderListBox::scrollTo): Call enqueueOrDispatchScrollEvent().
  31019. 2011-04-14 John Bates <jbates@google.com>
  31020. Reviewed by Kenneth Russell.
  31021. Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop.
  31022. https://bugs.webkit.org/show_bug.cgi?id=58383
  31023. * platform/graphics/chromium/LayerRendererChromium.cpp:
  31024. (WebCore::LayerRendererChromium::addChildContext):
  31025. (WebCore::LayerRendererChromium::removeChildContext):
  31026. * platform/graphics/chromium/LayerRendererChromium.h:
  31027. 2011-04-14 Renata Hodovan <reni@webkit.org>
  31028. Reviewed by Nikolas Zimmermann.
  31029. CSS related SVG*Element changes doesn't require relayout
  31030. https://bugs.webkit.org/show_bug.cgi?id=56906
  31031. The changes of some CSS related SVGFilter properties e.g. lighting_color, flood_color, flood_opacity
  31032. need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
  31033. we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
  31034. via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
  31035. Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
  31036. svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
  31037. svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
  31038. svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
  31039. * platform/graphics/filters/FEFlood.cpp:
  31040. (WebCore::FEFlood::setFloodColor):
  31041. (WebCore::FEFlood::setFloodOpacity):
  31042. * platform/graphics/filters/FEFlood.h:
  31043. * platform/graphics/filters/FESpecularLighting.cpp:
  31044. (WebCore::FESpecularLighting::setLightingColor):
  31045. * platform/graphics/filters/FESpecularLighting.h:
  31046. * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  31047. (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
  31048. * rendering/svg/RenderSVGResourceFilterPrimitive.h:
  31049. * rendering/svg/SVGResourcesCache.cpp:
  31050. (WebCore::SVGResourcesCache::clientStyleChanged):
  31051. * svg/SVGFEDiffuseLightingElement.cpp:
  31052. (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  31053. * svg/SVGFEFloodElement.cpp:
  31054. (WebCore::SVGFEFloodElement::setFilterEffectAttribute):
  31055. * svg/SVGFEFloodElement.h:
  31056. * svg/SVGFESpecularLightingElement.cpp:
  31057. (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
  31058. 2011-04-13 James Robinson <jamesr@chromium.org>
  31059. Reviewed by Simon Fraser.
  31060. Allow setting composited backing stores for scrollbars and scroll corners
  31061. https://bugs.webkit.org/show_bug.cgi?id=57202
  31062. This teaches ScrollableArea to manage GraphicsLayer backings for the two scrollbars and
  31063. scroll corner. ScrollableArea can position the layers and route invalidation and paint calls to
  31064. the correct place but depends on subclasses to manage the lifetime of the GraphicsLayers and
  31065. place them into the correct place in the hierarchy.
  31066. FrameView and RenderLayerCompositor updated to provide layers for frames with overflow controls.
  31067. that need them. The overflow control layers are siblings of the frame's clip layer.
  31068. RenderLayer and RenderLayerBacking updated to provide overflow control layers for layers that
  31069. need them. Currently, layers are only created for overflow controls on layers that are already composited
  31070. for other reasons and not necessarily for every RenderLayer with overflow. Overflow control layers are siblings
  31071. of the RenderLayerBacking's clipping layer if it exists, otherwise they are siblings of the layer's normal
  31072. children.
  31073. Tested by a number of compositing/ tests that have scrollbars and by these new tests:
  31074. compositing/iframes/repaint-after-losing-scrollbars.html
  31075. compositing/overflow/clip-content-under-overflow-controls.html
  31076. compositing/overflow/content-gains-scrollbars.html
  31077. compositing/overflow/content-loses-scrollbars.html
  31078. compositing/overflow/overflow-scrollbar-layers.html
  31079. compositing/overflow/repaint-after-losing-scrollbars.html
  31080. * css/CSSStyleSelector.cpp:
  31081. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  31082. * page/FrameView.cpp:
  31083. (WebCore::FrameView::layerForHorizontalScrollbar):
  31084. (WebCore::FrameView::layerForVerticalScrollbar):
  31085. (WebCore::FrameView::layerForScrollCorner):
  31086. (WebCore::FrameView::syncCompositingStateForThisFrame):
  31087. (WebCore::FrameView::contentsResized):
  31088. (WebCore::FrameView::updateScrollCorner):
  31089. * page/FrameView.h:
  31090. * platform/ScrollView.cpp:
  31091. (WebCore::ScrollView::wheelEvent):
  31092. * platform/ScrollView.h:
  31093. * platform/ScrollableArea.cpp:
  31094. (WebCore::ScrollableArea::invalidateScrollbar):
  31095. (WebCore::ScrollableArea::invalidateScrollCorner):
  31096. * platform/ScrollableArea.h:
  31097. (WebCore::ScrollableArea::paintScrollCorner):
  31098. (WebCore::ScrollableArea::layerForHorizontalScrollbar):
  31099. (WebCore::ScrollableArea::layerForVerticalScrollbar):
  31100. (WebCore::ScrollableArea::layerForScrollCorner):
  31101. * platform/Scrollbar.cpp:
  31102. (WebCore::Scrollbar::invalidateRect):
  31103. * platform/Scrollbar.h:
  31104. * platform/ScrollbarThemeComposite.cpp:
  31105. (WebCore::ScrollbarThemeComposite::paint):
  31106. * platform/graphics/chromium/ContentLayerChromium.cpp:
  31107. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  31108. * platform/graphics/chromium/LayerRendererChromium.cpp:
  31109. (WebCore::LayerRendererChromium::create):
  31110. (WebCore::LayerRendererChromium::LayerRendererChromium):
  31111. (WebCore::LayerRendererChromium::invalidateRootLayerRect):
  31112. (WebCore::LayerRendererChromium::drawRootLayer):
  31113. (WebCore::LayerRendererChromium::setViewport):
  31114. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  31115. (WebCore::LayerRendererChromium::updateLayers):
  31116. (WebCore::LayerRendererChromium::setRootLayer):
  31117. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  31118. * platform/graphics/chromium/LayerRendererChromium.h:
  31119. * platform/mac/ScrollAnimatorMac.mm:
  31120. (-[ScrollbarPartAnimation setCurrentProgress:]):
  31121. * platform/win/PopupMenuWin.h:
  31122. (WebCore::PopupMenuWin::invalidateScrollCornerRect):
  31123. (WebCore::PopupMenuWin::isScrollCornerVisible):
  31124. (WebCore::PopupMenuWin::scrollCornerRect):
  31125. * rendering/RenderLayer.cpp:
  31126. (WebCore::RenderLayer::scrollCornerRect):
  31127. (WebCore::RenderLayer::scrollCornerAndResizerRect):
  31128. (WebCore::RenderLayer::isScrollCornerVisible):
  31129. (WebCore::RenderLayer::invalidateScrollbarRect):
  31130. (WebCore::RenderLayer::invalidateScrollCornerRect):
  31131. (WebCore::RenderLayer::positionOverflowControls):
  31132. (WebCore::RenderLayer::paintOverflowControls):
  31133. (WebCore::RenderLayer::paintScrollCorner):
  31134. (WebCore::RenderLayer::layerForHorizontalScrollbar):
  31135. (WebCore::RenderLayer::layerForVerticalScrollbar):
  31136. (WebCore::RenderLayer::layerForScrollCorner):
  31137. * rendering/RenderLayer.h:
  31138. (WebCore::RenderLayer::horizontalScrollbar):
  31139. (WebCore::RenderLayer::verticalScrollbar):
  31140. * rendering/RenderLayerBacking.cpp:
  31141. (WebCore::RenderLayerBacking::~RenderLayerBacking):
  31142. (WebCore::RenderLayerBacking::updateAfterWidgetResize):
  31143. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
  31144. (WebCore::RenderLayerBacking::updateInternalHierarchy):
  31145. (WebCore::RenderLayerBacking::updateClippingLayers):
  31146. (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
  31147. (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
  31148. (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
  31149. (WebCore::RenderLayerBacking::updateOverflowControlsLayers):
  31150. (WebCore::paintScrollbar):
  31151. (WebCore::RenderLayerBacking::paintContents):
  31152. * rendering/RenderLayerBacking.h:
  31153. (WebCore::RenderLayerBacking::layerForHorizontalScrollbar):
  31154. (WebCore::RenderLayerBacking::layerForVerticalScrollbar):
  31155. (WebCore::RenderLayerBacking::layerForScrollCorner):
  31156. * rendering/RenderLayerCompositor.cpp:
  31157. (WebCore::RenderLayerCompositor::updateCompositingLayers):
  31158. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  31159. (WebCore::RenderLayerCompositor::frameViewDidChangeLocation):
  31160. (WebCore::RenderLayerCompositor::frameViewDidChangeSize):
  31161. (WebCore::RenderLayerCompositor::rootPlatformLayer):
  31162. (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  31163. (WebCore::paintScrollbar):
  31164. (WebCore::RenderLayerCompositor::paintContents):
  31165. (WebCore::shouldCompositeOverflowControls):
  31166. (WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer):
  31167. (WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer):
  31168. (WebCore::RenderLayerCompositor::requiresScrollCornerLayer):
  31169. (WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
  31170. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  31171. (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
  31172. (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
  31173. * rendering/RenderLayerCompositor.h:
  31174. (WebCore::RenderLayerCompositor::layerForHorizontalScrollbar):
  31175. (WebCore::RenderLayerCompositor::layerForVerticalScrollbar):
  31176. (WebCore::RenderLayerCompositor::layerForScrollCorner):
  31177. * rendering/RenderListBox.h:
  31178. (WebCore::RenderListBox::isScrollCornerVisible):
  31179. (WebCore::RenderListBox::scrollCornerRect):
  31180. (WebCore::RenderListBox::invalidateScrollCornerRect):
  31181. 2011-04-13 Cary Clark <caryclark@chromium.org>
  31182. Reviewed by Eric Seidel.
  31183. [Chromium] allow concurrent Skia and CG datatypes
  31184. https://bugs.webkit.org/show_bug.cgi?id=57848
  31185. The Chromium port is experimenting with running Skia as the WebKit rendering engine, and CoreGraphics
  31186. as the UI rendering engine. This permits Chromium to unify its graphics story while leveraging OS X to
  31187. draw elements like scrollbars and buttons.
  31188. Restructure the common graphics units, points, and rectangles, to convert to Sk-types and CG-types at
  31189. the same time. This requires only adding to the existing preprocessor commands, and will have no effect
  31190. on any existing platform.
  31191. Eventually, WTF_USE_SKIA_ON_MAC_CHROME will be defined to enable this, but for now, there's no
  31192. functional change.
  31193. No new tests as this provides no new functionality.
  31194. * platform/graphics/FloatPoint.h: Add USE(SKIA_ON_MAC_CHROME) to make CG type and operators visible
  31195. to a Skia-based Chrome Mac build.
  31196. * platform/graphics/FloatRect.h: Ditto.
  31197. * platform/graphics/FloatSize.h: Ditto.
  31198. * platform/graphics/IntPoint.h: Ditto.
  31199. * platform/graphics/IntRect.h: Ditto.
  31200. * platform/graphics/IntSize.h: Ditto.
  31201. * platform/graphics/cg/FloatPointCG.cpp: Ditto.
  31202. * platform/graphics/cg/FloatRectCG.cpp: Ditto.
  31203. * platform/graphics/cg/FloatSizeCG.cpp: Ditto.
  31204. * platform/graphics/cg/IntPointCG.cpp: Ditto.
  31205. * platform/graphics/cg/IntRectCG.cpp: Ditto.
  31206. * platform/graphics/cg/IntSizeCG.cpp: Ditto.
  31207. 2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
  31208. Reviewed by Dimitri Glazkov.
  31209. Bug 58460 - childTypeAllowed() should be const
  31210. https://bugs.webkit.org/show_bug.cgi?id=58460
  31211. Made childTypeAllowed const.
  31212. No new tests. (minor refactoring).
  31213. * dom/Attr.cpp:
  31214. (WebCore::Attr::childTypeAllowed):
  31215. * dom/Attr.h:
  31216. * dom/CDATASection.cpp:
  31217. (WebCore::CDATASection::childTypeAllowed):
  31218. * dom/CDATASection.h:
  31219. * dom/Comment.cpp:
  31220. (WebCore::Comment::childTypeAllowed):
  31221. * dom/Comment.h:
  31222. * dom/Document.cpp:
  31223. (WebCore::Document::childTypeAllowed):
  31224. * dom/Document.h:
  31225. * dom/DocumentFragment.cpp:
  31226. (WebCore::DocumentFragment::childTypeAllowed):
  31227. * dom/DocumentFragment.h:
  31228. * dom/Element.cpp:
  31229. (WebCore::Element::childTypeAllowed):
  31230. * dom/Element.h:
  31231. * dom/Node.h:
  31232. (WebCore::Node::childTypeAllowed):
  31233. * dom/Notation.cpp:
  31234. (WebCore::Notation::childTypeAllowed):
  31235. * dom/Notation.h:
  31236. * dom/ProcessingInstruction.cpp:
  31237. (WebCore::ProcessingInstruction::childTypeAllowed):
  31238. * dom/ProcessingInstruction.h:
  31239. * dom/Text.cpp:
  31240. (WebCore::Text::childTypeAllowed):
  31241. * dom/Text.h:
  31242. 2011-04-13 Jon Lee <jonlee@apple.com>
  31243. Reviewed by Maciej Stachowiak.
  31244. REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
  31245. https://bugs.webkit.org/show_bug.cgi?id=58284
  31246. <rdar://problem/9246149>
  31247. * WebCore.exp.in: Exporting EditingBehavior.h for use in WebKit2
  31248. * editing/EditingBehavior.h:
  31249. (WebCore::EditingBehavior::shouldClearSelectionWhenLosingWebPageFocus): moving the platform-specific code out of an #ifdef and into this class for run-time instead of compile-time checking
  31250. 2011-04-13 Yael Aharon <yael.aharon@nokia.com>
  31251. Reviewed by Eric Seidel.
  31252. constructLine should take bidiRuns as a parameter
  31253. https://bugs.webkit.org/show_bug.cgi?id=58458
  31254. Pass bidiRuns to constructLine and move reachedEndOfTextRenderer so that it is
  31255. declared before constructLine.
  31256. No new tests as this is refactoring only.
  31257. * rendering/RenderBlock.h:
  31258. * rendering/RenderBlockLineLayout.cpp:
  31259. (WebCore::reachedEndOfTextRenderer):
  31260. (WebCore::RenderBlock::constructLine):
  31261. (WebCore::RenderBlock::layoutInlineChildren):
  31262. 2011-04-13 Cary Clark <caryclark@google.com>
  31263. Reviewed by Eric Seidel.
  31264. Allow CG Font support in Chrome Darwin build using Skia
  31265. https://bugs.webkit.org/show_bug.cgi?id=58321
  31266. This allows Chrome to use Skia to do WebKit rendering, while
  31267. using CoreGraphics for glyph creation and computing font metrics.
  31268. It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.
  31269. No new tests needed, no functionality change.
  31270. * loader/cache/CachedFont.cpp: Make CGFontRef functions and
  31271. CG-specific font code available to Chrome builds on Darwin using Skia.
  31272. * platform/graphics/FontPlatformData.h: Ditto.
  31273. (WebCore::FontPlatformData::hash): Ditto.
  31274. * platform/graphics/GlyphBuffer.h: Ditto.
  31275. (WebCore::GlyphBuffer::advanceAt): Ditto.
  31276. (WebCore::GlyphBuffer::add): Ditto.
  31277. (WebCore::GlyphBuffer::expandLastAdvance): Ditto.
  31278. * platform/graphics/SimpleFontData.h: Ditto.
  31279. 2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
  31280. Reviewed by Dimitri Glazkov.
  31281. The timeline of the video controls is unusable if the multimedia backend returns a
  31282. infinite duration.
  31283. https://bugs.webkit.org/show_bug.cgi?id=58452
  31284. In case the underlaying media element backend returns crazy values, e.g.
  31285. an infinite duration for the video we need to bail out and hide the timeline
  31286. rather than in a broken state where you can't use it. The previous code was just
  31287. checking if the duration was NaN.
  31288. We can't control from JS what the backend will return as a duration for the video
  31289. so we can't make an test for it.
  31290. * html/shadow/MediaControlRootElement.cpp:
  31291. (WebCore::MediaControlRootElement::reset):
  31292. 2011-04-13 Abhishek Arya <inferno@chromium.org>
  31293. Reviewed by James Robinson.
  31294. Draw outline for render widgets.
  31295. https://bugs.webkit.org/show_bug.cgi?id=57439
  31296. Test: fast/frames/iframe-outline.html
  31297. * rendering/RenderWidget.cpp:
  31298. (WebCore::RenderWidget::paint):
  31299. 2011-04-13 Kent Tamura <tkent@chromium.org>
  31300. Reviewed by Dimitri Glazkov.
  31301. Change the representation of ShadowRoot nodes in render tree dumps
  31302. https://bugs.webkit.org/show_bug.cgi?id=58432
  31303. Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
  31304. in DRT results.
  31305. No new tests. This change doesn't affect existing tests yet.
  31306. * dom/DocumentFragment.h:
  31307. Make nodeName() protected in order that ShdowRoot can override it.
  31308. * dom/ShadowRoot.cpp:
  31309. (WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
  31310. * dom/ShadowRoot.h: Declare nodeName().
  31311. * rendering/RenderTreeAsText.cpp:
  31312. (WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary.
  31313. We don't use isShadowRoot() here because the legacy shadow root nodes
  31314. return true for isShadowRoot() and we don't want to update existing
  31315. test results.
  31316. 2011-04-13 Ryosuke Niwa <rniwa@webkit.org>
  31317. Reviewed by Eric Seidel.
  31318. Merge LineOffsets and LineWidth
  31319. https://bugs.webkit.org/show_bug.cgi?id=58411
  31320. Merged lineOffsets into LineWidth.
  31321. After this patch, available width is updated in positionNewFloatOnLine via updateAvailableWidth and
  31322. shrinkAvailableWidthForNewFloatIfNeeded instead of findNextBreak. This is correct because
  31323. - LineOffsets::update and LineOffsets::shrinkWidthForNewFloatIfNeeded were only called in positionNewFloatOnLine
  31324. besides LineOffsets' constructor
  31325. - positionNewFloatOnLine was only called in skipLeadingWhitespace and findNextLineBreak
  31326. - findNextLineBreak updates the available width whenever it calls skipLeadingWhitespace or positionNewFloatOnLine
  31327. * rendering/RenderBlock.h:
  31328. * rendering/RenderBlockLineLayout.cpp:
  31329. (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineWidth instead of LineOffset
  31330. (WebCore::LineWidth::LineWidth): Takes RenderBlock* and boolean isFirstLine; call updateAvailableWidth
  31331. because the initial available width was used to be computed from lineOffsets.width().
  31332. (WebCore::LineWidth::computeAvailableWidthFromLeftAndRight): Added.
  31333. (WebCore::LineWidth::updateAvailableWidth): Renamed from LineOffsets::update; this function now updates
  31334. m_availableWidth via computeAvailableWidthFromLeftAndRight as well as m_left and m_right.
  31335. (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Renamed from
  31336. LineOffsets::shrinkWidthForNewFloatIfNeeded. This function also calls computeAvailableWidthFromLeftAndRight.
  31337. (WebCore::LineWidth::applyOverhang): No longer takes arguments since both arguments were member variables
  31338. of LineOffsets.
  31339. (WebCore::LineWidth::fitBelowFloats): No longer takes isFirstLine.
  31340. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
  31341. (WebCore::RenderBlock::positionNewFloatOnLine): Takes a reference to LineWidth.
  31342. 2011-04-13 Ryuan Choi <ryuan.choi@samsung.com>
  31343. Reviewed by Kenneth Rohde Christiansen.
  31344. [CMAKE] Separate DerivedSources.
  31345. https://bugs.webkit.org/show_bug.cgi?id=58427
  31346. No new tests since these are refactoring only.
  31347. * CMakeLists.txt:
  31348. * UseJSC.cmake:
  31349. 2011-04-13 Noel Gordon <noel.gordon@gmail.com>
  31350. Reviewed by Kenneth Russell.
  31351. [chromium] Fix canvas.toDataURL mimeType assertion
  31352. https://bugs.webkit.org/show_bug.cgi?id=58425
  31353. Following r81213, reassert expected toDataURL() mimeType, remove an unused variable.
  31354. No new tests. Covered by existing tests.
  31355. * platform/graphics/skia/ImageBufferSkia.cpp:
  31356. (WebCore::ImageToDataURL):
  31357. (WebCore::ImageBuffer::toDataURL):
  31358. 2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
  31359. Reviewed by Andreas Kling.
  31360. [Qt] QNetworkReplyHandler refactoring: remove nested event loop.
  31361. https://bugs.webkit.org/show_bug.cgi?id=58375
  31362. As QNAM now makes actual synchronous loads there is no need for a nested event loop
  31363. in ResourceHandleQt.
  31364. Moving the call for QNetworkReplyWrapper::synchronousLoad from
  31365. ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
  31366. redirections to work in synchronous requests.
  31367. * platform/network/qt/QNetworkReplyHandler.cpp:
  31368. (WebCore::QNetworkReplyHandler::start):
  31369. * platform/network/qt/QNetworkReplyHandler.h:
  31370. * platform/network/qt/ResourceHandleQt.cpp:
  31371. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  31372. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  31373. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  31374. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  31375. (WebCore::WebCoreSynchronousLoader::didFail):
  31376. (WebCore::ResourceHandle::loadResourceSynchronously):
  31377. 2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
  31378. Reviewed by David Hyatt.
  31379. Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
  31380. https://bugs.webkit.org/show_bug.cgi?id=55930
  31381. Non-inline :before/:after generated content is now wrapped with an anonymous inline block.
  31382. Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
  31383. to verify that the created render object is legal under the parent.
  31384. Tests: fast/ruby/after-block-doesnt-crash.html
  31385. fast/ruby/after-table-doesnt-crash.html
  31386. fast/ruby/before-block-doesnt-crash.html
  31387. fast/ruby/before-table-doesnt-crash.html
  31388. * rendering/RenderObjectChildList.cpp:
  31389. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  31390. * rendering/RenderRuby.cpp:
  31391. (WebCore::isAnonymousRubyInlineBlock):
  31392. (WebCore::rubyBeforeBlock):
  31393. (WebCore::rubyAfterBlock):
  31394. (WebCore::createAnonymousRubyInlineBlock):
  31395. (WebCore::lastRubyRun):
  31396. (WebCore::RenderRubyAsInline::addChild):
  31397. (WebCore::RenderRubyAsInline::removeChild):
  31398. (WebCore::RenderRubyAsBlock::addChild):
  31399. (WebCore::RenderRubyAsBlock::removeChild):
  31400. * rendering/RenderRuby.h:
  31401. 2011-04-13 Matthew Delaney <mdelaney@apple.com>
  31402. Reviewed by Simon Fraser.
  31403. [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
  31404. https://bugs.webkit.org/show_bug.cgi?id=58084
  31405. No new tests. Does not affect outward behavior.
  31406. * WebCore.gypi:
  31407. * WebCore.vcproj/WebCore.vcproj:
  31408. * WebCore.xcodeproj/project.pbxproj:
  31409. * platform/graphics/ImageBuffer.h:
  31410. * platform/graphics/ImageBufferData.h: Added.
  31411. * platform/graphics/cairo/ImageBufferData.h: Removed.
  31412. * platform/graphics/cairo/ImageBufferDataCairo.h: Added.
  31413. * platform/graphics/cg/ImageBufferCG.cpp:
  31414. (WebCore::ImageBuffer::getUnmultipliedImageData):
  31415. (WebCore::ImageBuffer::getPremultipliedImageData):
  31416. (WebCore::ImageBuffer::putUnmultipliedImageData):
  31417. (WebCore::ImageBuffer::putPremultipliedImageData):
  31418. * platform/graphics/cg/ImageBufferDataCG.cpp: Added.
  31419. (WebCore::ImageBufferData::ImageBufferData):
  31420. (WebCore::haveVImageRoundingErrorFix):
  31421. (WebCore::ImageBufferData::getData):
  31422. (WebCore::ImageBufferData::putData):
  31423. * platform/graphics/cg/ImageBufferData.h: Removed.
  31424. * platform/graphics/cg/ImageBufferDataCG.h: Added.
  31425. * platform/graphics/chromium/ImageBufferData.h: Removed.
  31426. * platform/graphics/chromium/ImageBufferDataSkia.h: Added.
  31427. * platform/graphics/haiku/ImageBufferData.h: Removed.
  31428. * platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
  31429. * platform/graphics/qt/ImageBufferData.h: Removed.
  31430. * platform/graphics/qt/ImageBufferDataQt.h: Added.
  31431. * platform/graphics/wince/ImageBufferData.h: Removed.
  31432. * platform/graphics/wince/ImageBufferDataWince.h: Added.
  31433. * platform/graphics/wx/ImageBufferData.h: Removed.
  31434. * platform/graphics/wx/ImageBufferDataWx.h: Added.
  31435. 2011-04-13 Simon Fraser <simon.fraser@apple.com>
  31436. Reviewed by Dan Bernstein.
  31437. Remove std:: prefix on some min/max calls
  31438. https://bugs.webkit.org/show_bug.cgi?id=58493
  31439. Remove std:: namespacing on min/max in favor of a 'using' clause.
  31440. * platform/graphics/RoundedIntRect.cpp:
  31441. (WebCore::RoundedIntRect::Radii::expand):
  31442. * rendering/style/RenderStyle.cpp:
  31443. (WebCore::calcConstraintScaleFor):
  31444. 2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
  31445. Reviewed by Andreas Kling.
  31446. Replace our own RenderThemeQt::getMediaElementFromRenderObject by
  31447. MediaControlsElement::toParentMediaElement used by every other port.
  31448. * platform/qt/RenderThemeQt.cpp:
  31449. (WebCore::RenderThemeQt::paintMediaFullscreenButton):
  31450. (WebCore::RenderThemeQt::paintMediaMuteButton):
  31451. (WebCore::RenderThemeQt::paintMediaPlayButton):
  31452. (WebCore::RenderThemeQt::paintMediaSliderTrack):
  31453. * platform/qt/RenderThemeQt.h:
  31454. 2011-04-13 Geoffrey Garen <ggaren@apple.com>
  31455. Reviewed by Oliver Hunt.
  31456. Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
  31457. https://bugs.webkit.org/show_bug.cgi?id=58482
  31458. This will allow wrappers to make individual decisions about their lifetimes.
  31459. * bindings/js/DOMWrapperWorld.cpp:
  31460. (WebCore::DOMWrapperWorld::DOMWrapperWorld):
  31461. (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots):
  31462. (WebCore::JSNodeHandleOwner::finalize):
  31463. (WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots):
  31464. (WebCore::DOMObjectHandleOwner::finalize):
  31465. * bindings/js/DOMWrapperWorld.h:
  31466. (WebCore::JSNodeHandleOwner::JSNodeHandleOwner):
  31467. (WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner):
  31468. (WebCore::DOMWrapperWorld::jsNodeHandleOwner):
  31469. (WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners
  31470. for JSNode and DOMObject, our two hash table values. For now, the owners
  31471. just take care to remove their handles from their respective hash tables.
  31472. Changed the hash table type to be a standard HashMap of weak pointers,
  31473. instead of a WeakGCMap.
  31474. * bindings/js/JSDOMBinding.cpp:
  31475. (WebCore::getCachedDOMObjectWrapper):
  31476. (WebCore::cacheDOMObjectWrapper):
  31477. (WebCore::cacheDOMNodeWrapper):
  31478. (WebCore::isObservableThroughDOM):
  31479. (WebCore::markDOMNodesForDocument):
  31480. (WebCore::takeWrappers):
  31481. (WebCore::updateDOMNodeDocument):
  31482. (WebCore::markDOMObjectWrapper):
  31483. (WebCore::markDOMNodeWrapper): Updated wrapper hash table access to
  31484. accomodate its new data type.
  31485. * bindings/js/JSNodeCustom.h:
  31486. (WebCore::getCachedDOMNodeWrapper): Ditto.
  31487. * dom/Document.h: Updated declaration to match the above.
  31488. 2011-04-13 Sam Weinig <sam@webkit.org>
  31489. Fix Mac builds.
  31490. * WebCore.exp.in:
  31491. 2011-04-13 Sam Weinig <sam@webkit.org>
  31492. Reviewed by Gavin Barraclough.
  31493. WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
  31494. <rdar://problem/9260518>
  31495. Notify the scrollbar painter controller when gesture scrolls begin and end.
  31496. * WebCore.exp.in:
  31497. * platform/mac/ScrollAnimatorMac.h:
  31498. * platform/mac/ScrollAnimatorMac.mm:
  31499. (WebCore::ScrollAnimatorMac::didBeginScrollGesture):
  31500. (WebCore::ScrollAnimatorMac::didEndScrollGesture):
  31501. (WebCore::ScrollAnimatorMac::beginScrollGesture):
  31502. (WebCore::ScrollAnimatorMac::endScrollGesture):
  31503. * platform/mac/WebCoreSystemInterface.h:
  31504. * platform/mac/WebCoreSystemInterface.mm:
  31505. 2011-04-13 Eric Carlson <eric.carlson@apple.com>
  31506. Reviewed by Maciej Stachowiak.
  31507. MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
  31508. https://bugs.webkit.org/show_bug.cgi?id=58451
  31509. <rdar://problem/9278468>
  31510. No new tests, supported MIME types haven't changed.
  31511. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  31512. (WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use
  31513. [AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.
  31514. 2011-04-13 Eric Carlson <eric.carlson@apple.com>
  31515. Reviewed by Alexey Proskuryakov.
  31516. Media engine fallback doesn't always work
  31517. https://bugs.webkit.org/show_bug.cgi?id=58462
  31518. No new tests, this was verified manually with the url noted in the bug.
  31519. * platform/graphics/MediaPlayer.cpp:
  31520. (WebCore::MediaPlayer::networkStateChanged):
  31521. 2011-04-13 Zhenyao Mo <zmo@google.com>
  31522. Reviewed by Kenneth Russell.
  31523. Extension3D needs to provide a way to check if an extension is enabled
  31524. https://bugs.webkit.org/show_bug.cgi?id=58410
  31525. * html/canvas/WebGLRenderingContext.cpp:
  31526. (WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
  31527. * platform/graphics/Extensions3D.h: Add isEnabled().
  31528. * platform/graphics/chromium/Extensions3DChromium.h: Ditto.
  31529. * platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.
  31530. (WebCore::Extensions3DOpenGL::isEnabled):
  31531. * platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
  31532. * platform/graphics/qt/Extensions3DQt.cpp: Ditto.
  31533. (WebCore::Extensions3DQt::isEnabled):
  31534. * platform/graphics/qt/Extensions3DQt.h: Ditto.
  31535. 2011-04-13 Oliver Hunt <oliver@apple.com>
  31536. Reviewed by Gavin Barraclough.
  31537. Make PropertyMapEntry use a WriteBarrier for specificValue
  31538. https://bugs.webkit.org/show_bug.cgi?id=58407
  31539. Pass JSGlobalData reference on to APIs that now need them
  31540. * bindings/js/JSDOMWindowShell.h:
  31541. (WebCore::JSDOMWindowShell::setWindow):
  31542. * bindings/js/JSHTMLDocumentCustom.cpp:
  31543. (WebCore::JSHTMLDocument::all):
  31544. 2011-04-12 Pavel Podivilov <podivilov@chromium.org>
  31545. Reviewed by Pavel Feldman.
  31546. Web Inspector: fix source mapping for de-obfuscated scripts.
  31547. https://bugs.webkit.org/show_bug.cgi?id=58231
  31548. * inspector/front-end/ScriptFormatterWorker.js:
  31549. (buildMapping):
  31550. * inspector/front-end/SourceFile.js:
  31551. (WebInspector.SourceMapping):
  31552. (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
  31553. (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
  31554. (WebInspector):
  31555. (WebInspector.FormattedSourceMapping):
  31556. (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
  31557. (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
  31558. 2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
  31559. Reviewed by Martin Robinson.
  31560. [GTK] Consider editable and non editable nodes when calculating selection offsets
  31561. https://bugs.webkit.org/show_bug.cgi?id=58431
  31562. Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().
  31563. This is needed to ensure that getSelectionOffsetsForObject() works
  31564. well when non editable nodes are present in the selection, since
  31565. firstPositionInNode() and lastPositionInNode() don't work in those
  31566. cases (they assume the node is editable).
  31567. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  31568. (getSelectionOffsetsForObject): Updated calls.
  31569. 2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
  31570. Reviewed by Martin Robinson.
  31571. [GTK] Missing nullchecks in GTK's a11y wrapper
  31572. https://bugs.webkit.org/show_bug.cgi?id=58429
  31573. Add missing nullchecks for coreObject->document().
  31574. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  31575. (atkParentOfRootObject): Add missing nullcheck.
  31576. (getPangoLayoutForAtk): Ditto.
  31577. (webkit_accessible_text_get_caret_offset): Ditto.
  31578. (textExtents): Ditto.
  31579. (webkit_accessible_editable_text_insert_text): Ditto.
  31580. (webkit_accessible_editable_text_delete_text): Ditto.
  31581. 2011-04-13 Thierry Reding <thierry.reding@avionic-design.de>
  31582. Gtk+ port fails to build when enabling WebGL
  31583. https://bugs.webkit.org/show_bug.cgi?id=58434
  31584. Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.
  31585. * platform/graphics/GraphicsContext3D.h:
  31586. * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
  31587. (WebCore::GraphicsContext3D::paintToCanvas):
  31588. 2011-04-12 Philippe Normand <pnormand@igalia.com>
  31589. Reviewed by Martin Robinson.
  31590. REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
  31591. https://bugs.webkit.org/show_bug.cgi?id=58312
  31592. Make sure to link the videoValve in all cases, fpsdisplaysink
  31593. being used or not.
  31594. No new test, this patch fixes an internal feature of the player,
  31595. not publicly exposed. Having two video sinks and pausing one while
  31596. the other displays the fullscreen video is an implementation
  31597. detail of the GStreamer player.
  31598. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  31599. (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  31600. 2011-04-13 Ilya Tikhonovsky <loislo@chromium.org>
  31601. Reviewed by Yury Semikhatsky.
  31602. Web Inspector: there is a problem if an optional param is not at the end of a params list.
  31603. https://bugs.webkit.org/show_bug.cgi?id=58440
  31604. In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
  31605. for a callback. But in some cases the optional parameter is declared in the middle of the params list.
  31606. That gets us into a problem if this param has been skipped in the message. In that case the tail of the
  31607. event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.
  31608. * inspector/CodeGeneratorInspector.pm:
  31609. 2011-04-13 Ben Taylor <bentaylor.solx86@gmail.com>
  31610. Reviewed by Eric Seidel.
  31611. https://bugs.webkit.org/show_bug.cgi?id=57337
  31612. Work around a bug in ternary opertions in the Solaris Studio
  31613. 12/12.1/12.2 compilers, using an if clause.
  31614. * dom/NodeRenderStyle.h:
  31615. (WebCore::Node::renderStyle):
  31616. 2011-04-13 Brian Salomon <bsalomon@google.com>
  31617. Reviewed by Kenneth Russell.
  31618. Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
  31619. https://bugs.webkit.org/show_bug.cgi?id=58363
  31620. No new tests needed, exercised by all existing canvas2d tests.
  31621. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  31622. (WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
  31623. * platform/graphics/gpu/DrawingBuffer.h:
  31624. * platform/graphics/skia/PlatformContextSkia.cpp:
  31625. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  31626. 2011-04-13 Andrey Kosyakov <caseq@chromium.org>
  31627. Unreviewed. Fix chromium clang build problem:
  31628. ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
  31629. with a different signature in base class instead of overriding it.
  31630. * css/CSSStyleApplyProperty.cpp:
  31631. (WebCore::ApplyPropertyExpandingSuppressValue::applyValue):
  31632. 2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
  31633. Reviewed by David Levin.
  31634. Add mock implementation and plumbing code for unified Quota API
  31635. https://bugs.webkit.org/show_bug.cgi?id=57927
  31636. Added mock implementation and some plumbing code for the quota API,
  31637. that is based on the discussion on public-webapps:
  31638. http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
  31639. No new tests: tests will be added when we expose the API.
  31640. * CMakeLists.txt: Added new file entries.
  31641. * DerivedSources.cpp: Added new file entries.
  31642. * DerivedSources.make: Added new file entries.
  31643. * GNUmakefile.am: Added new file entries.
  31644. * WebCore.gypi: Added new file entries.
  31645. * WebCore.pro: Added new file entries.
  31646. * WebCore.vcproj/WebCore.vcproj: Added new file entries.
  31647. * WebCore.xcodeproj/project.pbxproj: Added new file entries.
  31648. * storage/StorageInfo.cpp: Added.
  31649. * storage/StorageInfo.h: Added.
  31650. * storage/StorageInfoErrorCallback.h: Added.
  31651. * storage/StorageInfoQuotaCallback.h: Added.
  31652. * storage/StorageInfoUsageCallback.h: Added.
  31653. 2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
  31654. Reviewed by Martin Robinson.
  31655. [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
  31656. https://bugs.webkit.org/show_bug.cgi?id=58297
  31657. Make sure we do not load plugins that use symbols of a different
  31658. GTK+ major version to avoid bugs and crashes.
  31659. * plugins/gtk/PluginPackageGtk.cpp:
  31660. (WebCore::moduleMixesGtkSymbols):
  31661. (WebCore::PluginPackage::load):
  31662. 2011-04-13 Andrey Adaikin <aandrey@google.com>
  31663. Reviewed by Pavel Feldman.
  31664. Web Inspector: Implement undo/redo in text editor
  31665. https://bugs.webkit.org/show_bug.cgi?id=58426
  31666. Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
  31667. Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
  31668. FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.
  31669. * inspector/front-end/SourceFrame.js:
  31670. (WebInspector.SourceFrame.prototype.endEditing):
  31671. * inspector/front-end/TextEditorModel.js:
  31672. (WebInspector.TextEditorModel.prototype.setText):
  31673. (WebInspector.TextEditorModel.prototype._innerSetText):
  31674. (WebInspector.TextEditorModel.prototype._pushUndoableCommand):
  31675. (WebInspector.TextEditorModel.prototype.undo):
  31676. (WebInspector.TextEditorModel.prototype.redo):
  31677. (WebInspector.TextEditorModel.prototype._doUndo):
  31678. * inspector/front-end/TextViewer.js:
  31679. (WebInspector.TextViewer.prototype._textChanged):
  31680. (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
  31681. (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
  31682. (WebInspector.TextViewer.prototype._registerShortcuts):
  31683. (WebInspector.TextViewer.prototype._cancelEditing):
  31684. (WebInspector.TextViewer.prototype._handleUndoRedo):
  31685. (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
  31686. (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
  31687. (WebInspector.TextEditorGutterPanel.prototype.textChanged):
  31688. (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
  31689. (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
  31690. (WebInspector.TextEditorMainPanel.prototype._restoreSelection):
  31691. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  31692. (WebInspector.TextEditorMainPanel.prototype.textChanged):
  31693. (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  31694. 2011-04-13 Pavel Feldman <pfeldman@chromium.org>
  31695. Reviewed by Yury Semikhatsky.
  31696. Web Inspector: make optional event parameter last to prevent regressions.
  31697. https://bugs.webkit.org/show_bug.cgi?id=58433
  31698. * inspector/Inspector.json:
  31699. * inspector/InspectorResourceAgent.cpp:
  31700. (WebCore::InspectorResourceAgent::willSendRequest):
  31701. * inspector/front-end/NetworkManager.js:
  31702. (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
  31703. 2011-04-13 Pavel Feldman <pfeldman@chromium.org>
  31704. Not reviewed: revert Inspector.json change for breaking world.
  31705. * inspector/Inspector.json:
  31706. 2011-04-13 Pavel Feldman <pfeldman@chromium.org>
  31707. Not reviewed: swap methods in the Inspector.json.
  31708. * inspector/Inspector.json:
  31709. 2011-04-13 Csaba Osztrogonác <ossy@webkit.org>
  31710. Unreviewed, rolling out r83695.
  31711. http://trac.webkit.org/changeset/83695
  31712. https://bugs.webkit.org/show_bug.cgi?id=58375
  31713. [Qt][WK2]It broke http tests
  31714. * platform/network/qt/QNetworkReplyHandler.cpp:
  31715. (WebCore::QNetworkReplyHandler::start):
  31716. (WebCore::QNetworkReplyHandler::synchronousLoad):
  31717. * platform/network/qt/QNetworkReplyHandler.h:
  31718. * platform/network/qt/ResourceHandleQt.cpp:
  31719. (WebCore::WebCoreSynchronousLoader::resourceResponse):
  31720. (WebCore::WebCoreSynchronousLoader::resourceError):
  31721. (WebCore::WebCoreSynchronousLoader::data):
  31722. (WebCore::WebCoreSynchronousLoader::setReplyFinished):
  31723. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  31724. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  31725. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  31726. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  31727. (WebCore::WebCoreSynchronousLoader::didFail):
  31728. (WebCore::WebCoreSynchronousLoader::waitForCompletion):
  31729. (WebCore::ResourceHandle::loadResourceSynchronously):
  31730. 2011-04-13 Pavel Podivilov <podivilov@chromium.org>
  31731. Reviewed by Pavel Feldman.
  31732. Web Inspector: inactive style sheets should be read only.
  31733. https://bugs.webkit.org/show_bug.cgi?id=58423
  31734. * inspector/front-end/ResourceView.js:
  31735. (WebInspector.CSSSourceFrame):
  31736. (WebInspector.CSSSourceFrame.prototype.isContentEditable):
  31737. (WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId):
  31738. (WebInspector.CSSSourceFrame.prototype._loadStyleSheet):
  31739. 2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
  31740. Reviewed by Pavel Feldman.
  31741. Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
  31742. https://bugs.webkit.org/show_bug.cgi?id=58320
  31743. Introduce a proxy object that emulates worker behavior and change UI code to cope with it.
  31744. * WebCore.gypi:
  31745. * WebCore.vcproj/WebCore.vcproj:
  31746. * inspector/front-end/DetailedHeapshotGridNodes.js:
  31747. (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted):
  31748. (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
  31749. (WebInspector.HeapSnapshotGridNode.prototype._populate):
  31750. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
  31751. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
  31752. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  31753. (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate):
  31754. (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort):
  31755. (WebInspector.HeapSnapshotGridNode.prototype.sort):
  31756. (WebInspector.HeapSnapshotGenericObjectNode):
  31757. (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
  31758. (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
  31759. (WebInspector.HeapSnapshotObjectNode):
  31760. (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
  31761. (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
  31762. (WebInspector.HeapSnapshotInstanceNode):
  31763. (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
  31764. (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
  31765. (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
  31766. (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  31767. (WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
  31768. (WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff):
  31769. (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
  31770. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  31771. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  31772. (WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
  31773. (WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
  31774. (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
  31775. (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
  31776. (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
  31777. (WebInspector.HeapSnapshotDominatorObjectNode):
  31778. (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
  31779. (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  31780. * inspector/front-end/DetailedHeapshotView.js:
  31781. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
  31782. (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
  31783. (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
  31784. (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
  31785. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived):
  31786. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds):
  31787. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived):
  31788. (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
  31789. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
  31790. (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
  31791. (WebInspector.HeapSnapshotRetainingPathsList):
  31792. (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
  31793. (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
  31794. (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
  31795. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
  31796. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
  31797. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
  31798. (WebInspector.DetailedHeapshotView.profileCallback):
  31799. (WebInspector.DetailedHeapshotView):
  31800. (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
  31801. (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
  31802. (WebInspector.DetailedHeapshotView.prototype.show.profileCallback1):
  31803. (WebInspector.DetailedHeapshotView.prototype.show.profileCallback2):
  31804. (WebInspector.DetailedHeapshotView.prototype.show):
  31805. (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
  31806. * inspector/front-end/HeapSnapshot.js:
  31807. * inspector/front-end/HeapSnapshotProxy.js: Added.
  31808. * inspector/front-end/PleaseWaitMessage.js:
  31809. * inspector/front-end/ProfilesPanel.js:
  31810. (WebInspector.ProfilesPanel.prototype._reset):
  31811. (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
  31812. (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
  31813. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
  31814. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
  31815. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  31816. * inspector/front-end/WebKit.qrc:
  31817. * inspector/front-end/inspector.html:
  31818. 2011-04-13 Alexander Pavlov <apavlov@chromium.org>
  31819. Reviewed by Pavel Feldman.
  31820. Web Inspector: Web Page Performance auditing fails
  31821. https://bugs.webkit.org/show_bug.cgi?id=58322
  31822. * inspector/front-end/AuditRules.js:
  31823. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
  31824. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
  31825. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  31826. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
  31827. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
  31828. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
  31829. (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
  31830. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
  31831. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
  31832. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
  31833. (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
  31834. 2011-04-13 Pavel Feldman <pfeldman@google.com>
  31835. Reviewed by Yury Semikhatsky.
  31836. Web Inspector: enumerate properties in Inspector.json using array, not object keys.
  31837. https://bugs.webkit.org/show_bug.cgi?id=58418
  31838. * inspector/Inspector.json:
  31839. 2011-04-06 Pavel Podivilov <podivilov@chromium.org>
  31840. Reviewed by Pavel Feldman.
  31841. Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
  31842. https://bugs.webkit.org/show_bug.cgi?id=57942
  31843. * English.lproj/localizedStrings.js:
  31844. * inspector/front-end/DebuggerPresentationModel.js:
  31845. (WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
  31846. * inspector/front-end/ScriptsPanel.js:
  31847. (WebInspector.ScriptsPanel):
  31848. (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  31849. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
  31850. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles):
  31851. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
  31852. * inspector/front-end/SourceFrame.js:
  31853. (WebInspector.SourceFrame.prototype._contextMenu):
  31854. (WebInspector.SourceFrame.prototype._populateLineGutterContextMenu):
  31855. (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
  31856. (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
  31857. (WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles):
  31858. (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
  31859. 2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
  31860. Reviewed by Dirk Schulze.
  31861. SVGTextContentElements textLength returns 0
  31862. https://bugs.webkit.org/show_bug.cgi?id=52543
  31863. Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.
  31864. If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
  31865. will return the same as "textContentElement.getComputedTextLength()". If it's set the values
  31866. aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
  31867. lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
  31868. This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
  31869. and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
  31870. in the SVG Text DOM API.
  31871. Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
  31872. Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).
  31873. Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
  31874. with getComputedTextLength().
  31875. Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
  31876. svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
  31877. svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
  31878. svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
  31879. svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html
  31880. * rendering/svg/RenderSVGInlineText.cpp:
  31881. (WebCore::RenderSVGInlineText::positionForPoint):
  31882. * rendering/svg/SVGInlineFlowBox.cpp:
  31883. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  31884. * rendering/svg/SVGInlineTextBox.cpp:
  31885. (WebCore::SVGInlineTextBox::offsetForPositionInFragment):
  31886. (WebCore::SVGInlineTextBox::selectionRect):
  31887. (WebCore::SVGInlineTextBox::paintSelectionBackground):
  31888. (WebCore::SVGInlineTextBox::paint):
  31889. (WebCore::SVGInlineTextBox::calculateBoundaries):
  31890. * rendering/svg/SVGTextChunkBuilder.cpp:
  31891. (WebCore::SVGTextChunkBuilder::buildTextChunks):
  31892. (WebCore::SVGTextChunkBuilder::layoutTextChunks):
  31893. (WebCore::SVGTextChunkBuilder::addTextChunk):
  31894. (WebCore::SVGTextChunkBuilder::processTextChunk):
  31895. (WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection):
  31896. (WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
  31897. * rendering/svg/SVGTextFragment.h:
  31898. (WebCore::SVGTextFragment::SVGTextFragment):
  31899. (WebCore::SVGTextFragment::buildFragmentTransform):
  31900. (WebCore::SVGTextFragment::transformAroundOrigin):
  31901. (WebCore::SVGTextFragment::buildTransformForTextOnPath):
  31902. (WebCore::SVGTextFragment::buildTransformForTextOnLine):
  31903. * rendering/svg/SVGTextLayoutEngine.cpp:
  31904. (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
  31905. (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  31906. (WebCore::dumpTextBoxes):
  31907. (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
  31908. (WebCore::SVGTextLayoutEngine::finishLayout):
  31909. (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  31910. * rendering/svg/SVGTextQuery.cpp:
  31911. (WebCore::SVGTextQuery::textLengthCallback):
  31912. (WebCore::SVGTextQuery::subStringLengthCallback):
  31913. (WebCore::SVGTextQuery::startPositionOfCharacterCallback):
  31914. (WebCore::SVGTextQuery::endPositionOfCharacterCallback):
  31915. (WebCore::SVGTextQuery::rotationOfCharacterCallback):
  31916. (WebCore::calculateGlyphBoundaries):
  31917. * svg/SVGTextContentElement.cpp:
  31918. (WebCore::SVGTextContentElement::SVGTextContentElement):
  31919. (WebCore::SVGTextContentElement::synchronizeTextLength):
  31920. (WebCore::SVGTextContentElement::textLengthAnimated):
  31921. (WebCore::SVGTextContentElement::parseMappedAttribute):
  31922. (WebCore::SVGTextContentElement::svgAttributeChanged):
  31923. * svg/SVGTextContentElement.h:
  31924. (WebCore::SVGTextContentElement::specifiedTextLength):
  31925. * svg/SVGTextPathElement.cpp:
  31926. (WebCore::SVGTextPathElement::svgAttributeChanged):
  31927. * svg/SVGTextPositioningElement.cpp:
  31928. (WebCore::SVGTextPositioningElement::svgAttributeChanged):
  31929. 2011-04-13 Pavel Feldman <pfeldman@google.com>
  31930. Reviewed by Yury Semikhatsky.
  31931. Web Inspector: requestDocument can result in race condition in DOMAgent.js
  31932. https://bugs.webkit.org/show_bug.cgi?id=58415
  31933. * inspector/front-end/DOMAgent.js:
  31934. (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
  31935. (WebInspector.DOMAgent.prototype.requestDocument):
  31936. 2011-04-12 Pavel Feldman <pfeldman@google.com>
  31937. Reviewed by Yury Semikhatsky.
  31938. Web Inspector: another pass of protocol renames.
  31939. https://bugs.webkit.org/show_bug.cgi?id=58340
  31940. * inspector/Inspector.json:
  31941. * inspector/InspectorDOMAgent.cpp:
  31942. (WebCore::InspectorDOMAgent::getDocument):
  31943. (WebCore::InspectorDOMAgent::performSearch):
  31944. (WebCore::InspectorDOMAgent::setSearchingForNode):
  31945. * inspector/InspectorDOMAgent.h:
  31946. * inspector/InspectorDebuggerAgent.cpp:
  31947. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  31948. * inspector/InspectorDebuggerAgent.h:
  31949. * inspector/InspectorRuntimeAgent.cpp:
  31950. (WebCore::InspectorRuntimeAgent::evaluate):
  31951. * inspector/InspectorRuntimeAgent.h:
  31952. * inspector/front-end/ElementsPanel.js:
  31953. (WebInspector.ElementsPanel.prototype._setSearchingForNode):
  31954. (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  31955. 2011-04-12 Luke Macpherson <macpherson@chromium.org>
  31956. Reviewed by Dimitri Glazkov.
  31957. Implement remaining Background and Mask css properties in CSSStyleApplyProperty
  31958. https://bugs.webkit.org/show_bug.cgi?id=58390
  31959. No new tests required as no functionality changed.
  31960. * css/CSSStyleApplyProperty.cpp:
  31961. (WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties.
  31962. (WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.
  31963. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  31964. (WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.
  31965. 2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com>
  31966. Reviewed by Dimitri Glazkov.
  31967. Element::setAttribute should check the namespace of an id attribute
  31968. https://bugs.webkit.org/show_bug.cgi?id=58359
  31969. Test: fast/dom/id-attribute-with-namespace-crash.html
  31970. * dom/Element.cpp:
  31971. (WebCore::Element::setAttribute):
  31972. 2011-04-12 Mike Lawther <mikelawther@chromium.org>
  31973. Reviewed by James Robinson.
  31974. Update boolean operators in RenderStyle to be compatible with check-webkit-style
  31975. https://bugs.webkit.org/show_bug.cgi?id=58409
  31976. No new functionality, so no new tests.
  31977. * rendering/style/RenderStyle.cpp:
  31978. (WebCore::RenderStyle::operator==):
  31979. (WebCore::RenderStyle::inheritedNotEqual):
  31980. (WebCore::positionedObjectMoved):
  31981. (WebCore::RenderStyle::diff):
  31982. (WebCore::RenderStyle::applyTransform):
  31983. * rendering/style/RenderStyle.h:
  31984. (WebCore::InheritedFlags::isOriginalDisplayInlineType):
  31985. 2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
  31986. Reviewed by Andreas Kling.
  31987. [Qt] QNetworkReplyHandler refactoring: remove nested event loop.
  31988. https://bugs.webkit.org/show_bug.cgi?id=58375
  31989. As QNAM now makes actual synchronous loads there is no need for a nested event loop
  31990. in ResourceHandleQt.
  31991. Moving the call for QNetworkReplyWrapper::synchronousLoad from
  31992. ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
  31993. redirections to work in synchronous requests.
  31994. * platform/network/qt/QNetworkReplyHandler.cpp:
  31995. (WebCore::QNetworkReplyHandler::start):
  31996. * platform/network/qt/QNetworkReplyHandler.h:
  31997. * platform/network/qt/ResourceHandleQt.cpp:
  31998. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  31999. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  32000. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  32001. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  32002. (WebCore::WebCoreSynchronousLoader::didFail):
  32003. (WebCore::ResourceHandle::loadResourceSynchronously):
  32004. 2011-04-12 Vangelis Kokkevis <vangelis@chromium.org>
  32005. Reviewed by James Robinson.
  32006. [chromium] Move the calculation of the layer's z coordinate to the
  32007. right spot so that it can be picked up by its sublayers.
  32008. https://bugs.webkit.org/show_bug.cgi?id=58397
  32009. Test: platform/chromium/compositing/child-layer-3d-sorting.html
  32010. * platform/graphics/chromium/LayerRendererChromium.cpp:
  32011. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  32012. 2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
  32013. Reviewed by Andreas Kling.
  32014. [Qt] QNetworkReplyHandler refactoring: signal queue
  32015. https://bugs.webkit.org/show_bug.cgi?id=57075
  32016. The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
  32017. stop that queue when loading is deferred. This way almost all the deferred logic can be removed
  32018. from QNetworkReplyHandler class and encapsulated in its own class.
  32019. To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
  32020. methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
  32021. This together with empting the queue at wrapper destruction time makes sure that the handler will
  32022. not receive calls from a dead wrapper.
  32023. The new class is named QNetworkReplyHandlerCallQueue.
  32024. * platform/network/qt/QNetworkReplyHandler.cpp:
  32025. (WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
  32026. (WebCore::QNetworkReplyHandlerCallQueue::push):
  32027. (WebCore::QNetworkReplyHandlerCallQueue::lock):
  32028. (WebCore::QNetworkReplyHandlerCallQueue::unlock):
  32029. (WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
  32030. (WebCore::QNetworkReplyHandlerCallQueue::flush):
  32031. (WebCore::QueueLocker::QueueLocker):
  32032. (WebCore::QueueLocker::~QueueLocker):
  32033. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  32034. (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
  32035. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  32036. (WebCore::QNetworkReplyWrapper::readyRead):
  32037. (WebCore::QNetworkReplyWrapper::didReceiveFinished):
  32038. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  32039. (WebCore::QNetworkReplyHandler::resetState):
  32040. (WebCore::QNetworkReplyHandler::release):
  32041. (WebCore::QNetworkReplyHandler::finish):
  32042. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  32043. (WebCore::QNetworkReplyHandler::forwardData):
  32044. (WebCore::QNetworkReplyHandler::start):
  32045. (WebCore::QNetworkReplyHandler::synchronousLoad):
  32046. * platform/network/qt/QNetworkReplyHandler.h:
  32047. (WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
  32048. (WebCore::QNetworkReplyHandlerCallQueue::clear):
  32049. (WebCore::QNetworkReplyWrapper::synchronousLoad):
  32050. (WebCore::QNetworkReplyHandler::setLoadingDeferred):
  32051. * platform/network/qt/ResourceHandleQt.cpp:
  32052. (WebCore::ResourceHandle::loadResourceSynchronously):
  32053. 2011-04-12 Kenichi Ishibashi <bashi@chromium.org>
  32054. Reviewed by Kent Tamura.
  32055. Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
  32056. https://bugs.webkit.org/show_bug.cgi?id=58247
  32057. - Increment m_associatedElementsAfterIndex when the form owner and an
  32058. inserted form associated element have the same parent chain.
  32059. - Always iterate over m_associatedElements to decrease indexes when a
  32060. form associated element is removed. This is needed for a case that the
  32061. form associated element is removed from the form element due to
  32062. deleting the 'form' attribute. No behavioral change expected with this
  32063. change.
  32064. Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html
  32065. fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html
  32066. * html/HTMLFormElement.cpp:
  32067. (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
  32068. Incremet m_associatedElementsAfterIndex when compareDocumentPosition()
  32069. returns DOCUMENT_POSITION_CONTAINED_BY.
  32070. (WebCore::HTMLFormElement::removeFormElement):
  32071. Always iterate m_associatedElements to adjust indexes.
  32072. 2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
  32073. Reviewed by Kenneth Rohde Christiansen.
  32074. [Qt] Do not show scrollbars when use mobile theme
  32075. https://bugs.webkit.org/show_bug.cgi?id=58380
  32076. * platform/qt/ScrollbarThemeQt.cpp:
  32077. (WebCore::ScrollbarThemeQt::scrollbarThickness):
  32078. 2011-04-12 Anantanarayanan G Iyengar <ananta@chromium.org>
  32079. Reviewed by Alexey Proskuryakov.
  32080. The default backspace event handler should mark the event as handled if navigation succeeds.
  32081. https://bugs.webkit.org/show_bug.cgi?id=58379
  32082. We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
  32083. These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
  32084. where history is managed by an external browser like IE.
  32085. No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
  32086. It is non trivial to simulate this environment.
  32087. * page/EventHandler.cpp:
  32088. (WebCore::EventHandler::defaultBackspaceEventHandler):
  32089. 2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
  32090. Reviewed by Eric Seidel.
  32091. Make availableWidth and totalOverhangWidth in findNextLineBreak member variables of LineWidth
  32092. https://bugs.webkit.org/show_bug.cgi?id=58400
  32093. Added m_availableWidth and m_overhangWidth to LineWidth this allows us to encapsulate m_overhangWidth.
  32094. * rendering/RenderBlock.h:
  32095. * rendering/RenderBlockLineLayout.cpp:
  32096. (WebCore::LineWidth::LineWidth):
  32097. (WebCore::LineWidth::fitsOnLine): Added; returns true if current width + first argument <= availableWidth.
  32098. (WebCore::LineWidth::availableWidth): Added.
  32099. (WebCore::LineWidth::setAvailableWidth): Added; takes LineOffsets.
  32100. (WebCore::LineWidth::applyOverhang): Added; obtains the overhang width from ruby run and inflates
  32101. the available width.
  32102. (WebCore::LineWidth::fitBelowFloats): Moved from RenderBlock.
  32103. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
  32104. 2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
  32105. Unreviewed warning fix.
  32106. MediaControlElements has been moved to html/shadow.
  32107. * WebCore.pro:
  32108. 2011-04-12 Yael Aharon <yael.aharon@nokia.com>
  32109. Reviewed by Eric Seidel.
  32110. Rename onEndChain and make it a static method.
  32111. https://bugs.webkit.org/show_bug.cgi?id=58403
  32112. No new tests since this is refactoring only.
  32113. * rendering/InlineFlowBox.cpp:
  32114. (WebCore::isLastChildForRenderer):
  32115. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  32116. * rendering/InlineFlowBox.h:
  32117. 2011-04-12 Eric Carlson <eric.carlson@apple.com>
  32118. Not reviewed, build fix.
  32119. Fix non-accelerated build after r83667.
  32120. * html/HTMLMediaElement.cpp:
  32121. (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Guard call to
  32122. mediaPlayerRenderingModeChanged with USE(ACCELERATED_COMPOSITING.
  32123. 2011-04-12 Adrienne Walker <enne@google.com>
  32124. Reviewed by James Robinson.
  32125. [chromium] TilingData mishandles very small texture sizes
  32126. https://bugs.webkit.org/show_bug.cgi?id=58364
  32127. Use zero tiles when the texture size is too small for tiling.
  32128. * platform/graphics/gpu/TilingData.cpp:
  32129. (WebCore::TilingData::TilingData):
  32130. (WebCore::TilingData::setMaxTextureSize):
  32131. 2011-04-12 Csaba Osztrogonác <ossy@webkit.org>
  32132. Unreviewed, rolling out r83634 and r83659.
  32133. http://trac.webkit.org/changeset/83634
  32134. http://trac.webkit.org/changeset/83659
  32135. https://bugs.webkit.org/show_bug.cgi?id=57075
  32136. It made 2 tests time out
  32137. * platform/network/qt/QNetworkReplyHandler.cpp:
  32138. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  32139. (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
  32140. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  32141. (WebCore::QNetworkReplyWrapper::didReceiveFinished):
  32142. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  32143. (WebCore::QNetworkReplyHandler::resetState):
  32144. (WebCore::QNetworkReplyHandler::setLoadingDeferred):
  32145. (WebCore::QNetworkReplyHandler::resumeDeferredLoad):
  32146. (WebCore::QNetworkReplyHandler::release):
  32147. (WebCore::QNetworkReplyHandler::finish):
  32148. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  32149. (WebCore::QNetworkReplyHandler::forwardData):
  32150. (WebCore::QNetworkReplyHandler::start):
  32151. * platform/network/qt/QNetworkReplyHandler.h:
  32152. * platform/network/qt/ResourceHandleQt.cpp:
  32153. (WebCore::WebCoreSynchronousLoader::resourceResponse):
  32154. (WebCore::WebCoreSynchronousLoader::resourceError):
  32155. (WebCore::WebCoreSynchronousLoader::data):
  32156. (WebCore::WebCoreSynchronousLoader::setReplyFinished):
  32157. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  32158. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  32159. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  32160. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  32161. (WebCore::WebCoreSynchronousLoader::didFail):
  32162. (WebCore::WebCoreSynchronousLoader::waitForCompletion):
  32163. (WebCore::ResourceHandle::loadResourceSynchronously):
  32164. 2011-04-12 Sam Weinig <sam@webkit.org>
  32165. Reviewed by Simon Fraser.
  32166. Frames prevent scrolling containing page
  32167. <rdar://problem/8990409>
  32168. https://bugs.webkit.org/show_bug.cgi?id=58392
  32169. Also fixes:
  32170. Should rubber-band on pages with no scrollbars
  32171. <rdar://problem/9034280>
  32172. * page/FrameView.cpp:
  32173. (WebCore::FrameView::FrameView):
  32174. Make the main frame rubber-band horizontally and vertically always.
  32175. * platform/ScrollTypes.h:
  32176. Add ScrollElasticity enum.
  32177. * platform/ScrollableArea.cpp:
  32178. Default to no elasticity.
  32179. (WebCore::ScrollableArea::ScrollableArea):
  32180. * platform/ScrollableArea.h:
  32181. (WebCore::ScrollableArea::setVerticalScrollElasticity):
  32182. (WebCore::ScrollableArea::verticalScrollElasticity):
  32183. (WebCore::ScrollableArea::setHorizontalScrollElasticity):
  32184. (WebCore::ScrollableArea::horizontalScrollElasticity):
  32185. Add state for horizontal and vertical elasticity.
  32186. * platform/mac/ScrollAnimatorMac.mm:
  32187. (WebCore::ScrollAnimatorMac::handleWheelEvent):
  32188. Bail out of new scrolling behavior if we can't rubber-band. By bailing before
  32189. accepting the wheel event, we allow the wheel event to be forwarded. We will
  32190. need to refine this logic to allow subframe scrolling in the future.
  32191. (WebCore::ScrollAnimatorMac::allowsVerticalStretching):
  32192. (WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
  32193. Switch stretching behavior based on the ScrollableArea's elasticity.
  32194. 2011-04-12 Geoffrey Garen <ggaren@apple.com>
  32195. Not reviewed.
  32196. Try to fix the Chromium build.
  32197. Why have one URL when you can have two at twice the price?
  32198. * platform/KURL.h:
  32199. (WebCore::KURL::KURL):
  32200. (WebCore::KURL::isHashTableDeletedValue):
  32201. * platform/KURLGoogle.cpp:
  32202. (WebCore::KURLGooglePrivate::KURLGooglePrivate):
  32203. * platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash
  32204. table deleted value constructor.
  32205. 2011-04-12 Stephanie Lewis <slewis@apple.com>
  32206. Reviewed by Oliver Hunt.
  32207. https://bugs.webkit.org/show_bug.cgi?id=58280
  32208. Fix a layout test by correctly comparing enums, and not adding exceptions.
  32209. * bindings/js/SerializedScriptValue.cpp:
  32210. (WebCore::SerializedScriptValue::create):
  32211. (WebCore::SerializedScriptValue::deserialize):
  32212. * bindings/js/SerializedScriptValue.h:
  32213. 2011-04-12 Eric Carlson <eric.carlson@apple.com>
  32214. Reviewed by Simon Fraser.
  32215. Apple movie trailers play only audio
  32216. https://bugs.webkit.org/show_bug.cgi?id=58339
  32217. <rdar://problem/9237606>
  32218. No new tests, covered by existing layout and manual tests.
  32219. * html/HTMLMediaElement.cpp:
  32220. (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions.
  32221. (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster
  32222. change the display mode to Video and force a style recalc so the video layer gets hooked
  32223. up the the render tree.
  32224. * html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we
  32225. want to stop displaying the poster as soon as the first frame of video is available.
  32226. * html/HTMLVideoElement.cpp:
  32227. (WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when
  32228. we want to display Video but the media engines doesn't have the first frame yet.
  32229. * html/HTMLVideoElement.h:
  32230. (WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode
  32231. is PosterWaitingForVideo.
  32232. * manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.
  32233. * platform/graphics/MediaPlayer.cpp:
  32234. (WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
  32235. * platform/graphics/MediaPlayer.h:
  32236. (WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):
  32237. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  32238. (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize
  32239. m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.
  32240. (WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first
  32241. frame of video has loaded, or audio will begin to play before we can show video.
  32242. (WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
  32243. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is
  32244. available, inform elment and begin playback if it was previousl requested.
  32245. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  32246. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  32247. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  32248. (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging.
  32249. (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto.
  32250. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play.
  32251. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.
  32252. 2011-04-12 Jian Li <jianli@chromium.org>
  32253. Unreviewed, rolling out r83649.
  32254. http://trac.webkit.org/changeset/83649
  32255. https://bugs.webkit.org/show_bug.cgi?id=57563
  32256. This patch causes compiling errors for chromium
  32257. * platform/graphics/chromium/FontChromiumWin.cpp:
  32258. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
  32259. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  32260. (WebCore::Font::drawComplexText):
  32261. * platform/graphics/chromium/ImageBufferData.h:
  32262. * platform/graphics/chromium/LayerChromium.h:
  32263. * platform/graphics/chromium/LayerRendererChromium.h:
  32264. * platform/graphics/chromium/PlatformCanvas.cpp:
  32265. (WebCore::PlatformCanvas::resize):
  32266. * platform/graphics/chromium/PlatformCanvas.h:
  32267. * platform/graphics/chromium/TransparencyWin.cpp:
  32268. (WebCore::TransparencyWin::compositeTextComposite):
  32269. (WebCore::TransparencyWin::makeLayerOpaque):
  32270. * platform/graphics/skia/ImageBufferSkia.cpp:
  32271. (WebCore::ImageBuffer::ImageBuffer):
  32272. * platform/graphics/skia/ImageSkia.cpp:
  32273. (WebCore::paintSkBitmap):
  32274. (WebCore::Image::drawPattern):
  32275. * platform/graphics/skia/PlatformContextSkia.cpp:
  32276. (WebCore::PlatformContextSkia::PlatformContextSkia):
  32277. (WebCore::PlatformContextSkia::setCanvas):
  32278. (WebCore::PlatformContextSkia::isPrinting):
  32279. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  32280. * platform/graphics/skia/PlatformContextSkia.h:
  32281. (WebCore::PlatformContextSkia::canvas):
  32282. 2011-04-12 Enrica Casucci <enrica@apple.com>
  32283. Reviewed by Alexey Proskuryakov.
  32284. Implement non-activating clicks to allow dragging out of a background window.
  32285. https://bugs.webkit.org/show_bug.cgi?id=55053
  32286. <rdar://problem/9042197>
  32287. * WebCore.exp.in: Added new exported method.
  32288. 2011-04-12 Geoffrey Garen <ggaren@apple.com>
  32289. Reviewed by Geoffrey Garen.
  32290. Cleaned up hash traits, and added hash traits for handles
  32291. https://bugs.webkit.org/show_bug.cgi?id=58381
  32292. * dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.
  32293. * platform/KURL.h:
  32294. (WebCore::KURL::KURL):
  32295. (WebCore::KURL::isHashTableDeletedValue): Added explicit hash table
  32296. deleted value constructor, to be more explicit and enable use of
  32297. SimpleClassHashTraits.
  32298. * platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.
  32299. * platform/graphics/FontCache.cpp: Ditto.
  32300. * platform/network/ProtectionSpaceHash.h: Ditto.
  32301. * svg/properties/SVGAnimatedPropertyDescription.h: Ditto.
  32302. 2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
  32303. Reviewed by Andreas Kling.
  32304. [Qt] QNetworkReplyHandler refactoring: remove nested event loop.
  32305. https://bugs.webkit.org/show_bug.cgi?id=58375
  32306. As QNAM now makes actual synchronous loads there is no need for a nested event loop
  32307. in ResourceHandleQt.
  32308. Moving the call for QNetworkReplyWrapper::synchronousLoad from
  32309. ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
  32310. redirections to work in synchronous requests.
  32311. * platform/network/qt/QNetworkReplyHandler.cpp:
  32312. (WebCore::QNetworkReplyHandler::start):
  32313. * platform/network/qt/QNetworkReplyHandler.h:
  32314. * platform/network/qt/ResourceHandleQt.cpp:
  32315. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  32316. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  32317. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  32318. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  32319. (WebCore::WebCoreSynchronousLoader::didFail):
  32320. (WebCore::ResourceHandle::loadResourceSynchronously):
  32321. 2011-04-11 Jer Noble <jer.noble@apple.com>
  32322. Reviewed by Simon Fraser.
  32323. REGRESSION: Vimeo fullscreen video displays incorrectly
  32324. https://bugs.webkit.org/show_bug.cgi?id=58291
  32325. Set the RenderFullScreen's zIndex to the max. And make sure to override
  32326. a video element's specified width and height by making its full screen rules
  32327. important. Also, always show the controls when a media element is in full
  32328. screen mode.
  32329. Test: fullscreen/video-specified-size.html
  32330. Test: fullscreen/full-screen-zIndex.html
  32331. * css/fullscreen.css:
  32332. (video:-webkit-full-screen):
  32333. * html/HTMLMediaElement.cpp:
  32334. (WebCore::HTMLMediaElement::controls): Always show controls in full screen mode.
  32335. (WebCore::HTMLMediaElement::preDispatchEventHandler): Added. Handle the fullscreen
  32336. change event and hide or show the controls accordingly.
  32337. * html/HTMLMediaElement.h:
  32338. * rendering/RenderFullScreen.cpp:
  32339. (RenderFullScreen::createFullScreenStyle): Set the zIndex to INT_MAX and use a
  32340. vertical flexbox instead of a horizontal one.
  32341. 2011-04-12 Chris Marrin <cmarrin@apple.com>
  32342. Reviewed by Simon Fraser.
  32343. Page tears and stutters in WebKit2 when page is > 2048 pixels wide
  32344. https://bugs.webkit.org/show_bug.cgi?id=58330
  32345. Added API to GraphicsLayer to disable switching to tiled layers. This is
  32346. set in the nonCompositedContentLayer in WK2, causing that layer to never
  32347. switch to tiles and avoiding the asynchronous update of the content during
  32348. scroll.
  32349. * platform/graphics/ca/GraphicsLayerCA.cpp:
  32350. Implement setAllowTiledLayer() to simulate a SizeChanged action to
  32351. properly switch between tiled and untiled layer.
  32352. * platform/graphics/ca/GraphicsLayerCA.h:
  32353. 2011-04-12 Alok Priyadarshi <alokp@chromium.org>
  32354. Reviewed by James Robinson.
  32355. Remove dependency on chromium skia::PlatformCanvas
  32356. https://bugs.webkit.org/show_bug.cgi?id=57563
  32357. This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas.
  32358. The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium.
  32359. We will eventually define an API that every port using skia will define.
  32360. * platform/graphics/chromium/FontChromiumWin.cpp:
  32361. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
  32362. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  32363. (WebCore::Font::drawComplexText):
  32364. * platform/graphics/chromium/ImageBufferData.h:
  32365. * platform/graphics/chromium/LayerChromium.h:
  32366. * platform/graphics/chromium/LayerRendererChromium.h:
  32367. * platform/graphics/chromium/PlatformCanvas.cpp:
  32368. (WebCore::PlatformCanvas::resize):
  32369. * platform/graphics/chromium/PlatformCanvas.h:
  32370. * platform/graphics/chromium/TransparencyWin.cpp:
  32371. (WebCore::TransparencyWin::compositeTextComposite):
  32372. (WebCore::TransparencyWin::makeLayerOpaque):
  32373. * platform/graphics/skia/ImageBufferSkia.cpp:
  32374. (WebCore::ImageBuffer::ImageBuffer):
  32375. * platform/graphics/skia/ImageSkia.cpp:
  32376. (WebCore::paintSkBitmap):
  32377. (WebCore::Image::drawPattern):
  32378. * platform/graphics/skia/PlatformContextSkia.cpp:
  32379. (WebCore::PlatformContextSkia::PlatformContextSkia):
  32380. (WebCore::PlatformContextSkia::setCanvas):
  32381. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  32382. * platform/graphics/skia/PlatformContextSkia.h:
  32383. (WebCore::PlatformContextSkia::canvas):
  32384. (WebCore::PlatformContextSkia::printing):
  32385. (WebCore::PlatformContextSkia::setPrinting):
  32386. 2011-04-11 Stephanie Lewis <slewis@apple.com>
  32387. Reviewed by Oliver Hunt.
  32388. https://bugs.webkit.org/show_bug.cgi?id=58280
  32389. <rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
  32390. Currently serialization and deserialization can throw javascript exceptions. Since SerializedScriptValue is called in
  32391. several places that do not always involve direct calls into javascript have the functions return an error code and the callers
  32392. decide whether or not to throw exceptions.
  32393. Don't allow SerializedScriptValue to attempt to serialize objects that inherit from JSNavigator.h. Walking that object creates
  32394. additional objects which eventually causes serialization to end up throwing a stack overflow error. Instead fail immediately.
  32395. Untangle header includes. SerializedScriptValue was inheriting ScriptValue.h, but not using it. Since ScriptValue depends on
  32396. SerializedScriptValue this could lead to a circular header dependency.
  32397. No change in functionality, covered by current tests
  32398. * WebCore.exp.in:
  32399. * bindings/js/JSMessageEventCustom.cpp:
  32400. (WebCore::JSMessageEvent::initMessageEvent):
  32401. * bindings/js/ScriptValue.cpp:
  32402. (WebCore::ScriptValue::serialize):
  32403. (WebCore::ScriptValue::deserialize):
  32404. * bindings/js/ScriptValue.h:
  32405. * bindings/js/SerializedScriptValue.cpp:
  32406. (WebCore::CloneSerializer::serialize):
  32407. (WebCore::CloneSerializer::dumpIfTerminal):
  32408. (WebCore::CloneDeserializer::deserialize):
  32409. (WebCore::SerializedScriptValue::create):
  32410. (WebCore::SerializedScriptValue::deserialize):
  32411. (WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
  32412. (WebCore::SerializedScriptValue::serializationDidCompleteSuccessfully):
  32413. * bindings/js/SerializedScriptValue.h:
  32414. * bindings/js/JSWorkerContextBase.cpp: header include fix
  32415. * loader/FrameLoader.h: header include fix
  32416. * page/Frame.cpp: header include fix
  32417. 2011-03-28 Adam Barth <abarth@webkit.org>
  32418. Reviewed by Kenneth Russell.
  32419. Move libtess from WebCore/thirdparty to ThirdParty
  32420. https://bugs.webkit.org/show_bug.cgi?id=57288
  32421. * WebCore.gyp/WebCore.gyp:
  32422. - Add libtess as a legit dependency.
  32423. * WebCore.gypi:
  32424. - Remove libtess files from the gypi.
  32425. * thirdparty/glu: Removed.
  32426. 2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
  32427. Reviewed by David Hyatt.
  32428. Bundle w and tmpW in findNextLineBreak together as a class
  32429. https://bugs.webkit.org/show_bug.cgi?id=58362
  32430. Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
  32431. and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
  32432. named LineWidth.
  32433. * rendering/RenderBlockLineLayout.cpp:
  32434. (WebCore::LineWidth::LineWidth): Added.
  32435. (WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width.
  32436. (WebCore::LineWidth::uncommittedWidth): Added.
  32437. (WebCore::LineWidth::committedWidth): Added.
  32438. (WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width.
  32439. (WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width.
  32440. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
  32441. 2011-04-12 Yael Aharon <yael.aharon@nokia.com>
  32442. Reviewed by Eric Seidel.
  32443. REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
  32444. https://bugs.webkit.org/show_bug.cgi?id=57459
  32445. Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
  32446. We include the border in that box under these conditions:
  32447. (1) The next line was not created, or it is constructed. We check the previous line for rtl.
  32448. (2) The logicallyLastRun is not a descendant of this renderer.
  32449. (3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
  32450. I added the tests from bug 47210, because now the draw the borders correctly.
  32451. Tests: fast/borders/bidi-002.html
  32452. fast/borders/bidi-004.html
  32453. fast/borders/bidi-009a.html
  32454. * rendering/InlineFlowBox.cpp:
  32455. (WebCore::InlineFlowBox::onEndChain):
  32456. (WebCore::isAnsectorAndWithinBlock):
  32457. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  32458. * rendering/InlineFlowBox.h:
  32459. * rendering/RenderBlock.h:
  32460. * rendering/RenderBlockLineLayout.cpp:
  32461. (WebCore::RenderBlock::constructLine):
  32462. (WebCore::RenderBlock::layoutInlineChildren):
  32463. 2011-04-12 Geoffrey Garen <ggaren@apple.com>
  32464. Reviewed by Sam Weinig.
  32465. Cleaned up some Vector traits, and added missing Vector traits for handles
  32466. https://bugs.webkit.org/show_bug.cgi?id=58372
  32467. * platform/graphics/BitmapImage.h: Added a FIXME because the current
  32468. Vector traits for FrameData are logically incorrect, but I couldn't find
  32469. a place where this currently results in bad behavior, and it's not
  32470. immediately obvious what the right solution is.
  32471. 2011-04-12 Dimitri Glazkov <dglazkov@chromium.org>
  32472. Reviewed by Eric Seidel.
  32473. Move MediaControlElements to html/shadow.
  32474. https://bugs.webkit.org/show_bug.cgi?id=58347
  32475. Mechanical move of the files.
  32476. * Android.mk: Updated the build file.
  32477. * CMakeLists.txt: Ditto.
  32478. * GNUmakefile.list.am: Ditto.
  32479. * WebCore.gypi: Ditto.
  32480. * WebCore.pro: Ditto.
  32481. * WebCore.vcproj/WebCore.vcproj: Ditto.
  32482. * WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
  32483. * html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp.
  32484. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
  32485. * html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
  32486. * rendering/MediaControlElements.cpp: Removed.
  32487. * rendering/MediaControlElements.h: Removed.
  32488. * rendering/RenderingAllInOne.cpp: Removed the files that were moved.
  32489. 2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
  32490. Reviewed by Andreas Kling.
  32491. [Qt] QNetworkReplyHandler refactoring: signal queue
  32492. https://bugs.webkit.org/show_bug.cgi?id=57075
  32493. The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
  32494. stop that queue when loading is deferred. This way almost all the deferred logic can be removed
  32495. from QNetworkReplyHandler class and encapsulated in its own class.
  32496. To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
  32497. methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
  32498. This together with empting the queue at wrapper destruction time makes sure that the handler will
  32499. not receive calls from a dead wrapper.
  32500. The new class is named QNetworkReplyHandlerCallQueue.
  32501. * platform/network/qt/QNetworkReplyHandler.cpp:
  32502. (WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
  32503. (WebCore::QNetworkReplyHandlerCallQueue::push):
  32504. (WebCore::QNetworkReplyHandlerCallQueue::lock):
  32505. (WebCore::QNetworkReplyHandlerCallQueue::unlock):
  32506. (WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
  32507. (WebCore::QueueLocker::QueueLocker):
  32508. (WebCore::QueueLocker::~QueueLocker):
  32509. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  32510. (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
  32511. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  32512. (WebCore::QNetworkReplyWrapper::readyRead):
  32513. (WebCore::QNetworkReplyWrapper::didReceiveFinished):
  32514. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  32515. (WebCore::QNetworkReplyHandler::resetState):
  32516. (WebCore::QNetworkReplyHandler::release):
  32517. (WebCore::QNetworkReplyHandler::finish):
  32518. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  32519. (WebCore::QNetworkReplyHandler::forwardData):
  32520. (WebCore::QNetworkReplyHandler::start):
  32521. (WebCore::QNetworkReplyHandler::synchronousLoad):
  32522. * platform/network/qt/QNetworkReplyHandler.h:
  32523. (WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
  32524. (WebCore::QNetworkReplyHandlerCallQueue::clear):
  32525. (WebCore::QNetworkReplyWrapper::synchronousLoad):
  32526. (WebCore::QNetworkReplyHandler::setLoadingDeferred):
  32527. * platform/network/qt/ResourceHandleQt.cpp:
  32528. (WebCore::ResourceHandle::loadResourceSynchronously):
  32529. 2011-04-12 David Hyatt <hyatt@apple.com>
  32530. Reviewed by Dan Bernstein.
  32531. https://bugs.webkit.org/show_bug.cgi?id=58176
  32532. Inline replaced elements following positioned elements on lines are not rendered. Make sure the
  32533. logic for skipping run construction in appendRunsForObject matches the new logic that I added
  32534. to findNextLineBreak. If they don't match up, you risk confusing the run construction code and
  32535. causing it to not make runs for objects that follow the positioned object on the line.
  32536. Added fast/inline/positioned-object-between-replaced-elements.html
  32537. * rendering/RenderBlockLineLayout.cpp:
  32538. (WebCore::RenderBlock::appendRunsForObject):
  32539. 2011-04-12 Alice Liu <alice.liu@apple.com>
  32540. Reviewed by Sam Weinig.
  32541. https://bugs.webkit.org/show_bug.cgi?id=58292
  32542. Provide new setting to allow site icon loading despite disabling automatic image loading in general.
  32543. Test: http/tests/misc/favicon-loads-with-icon-loading-override.html
  32544. * WebCore.exp.in: Added export symbol
  32545. * loader/FrameLoader.cpp:
  32546. (WebCore::FrameLoader::startIconLoader): Check new setting before deciding that site icon images shouldn't be loaded.
  32547. * page/Settings.cpp:
  32548. (WebCore::Settings::Settings): Add initializer for new setting
  32549. (WebCore::Settings::setLoadsSiteIconsIgnoringImageLoadingSetting): Add setter for new setting.
  32550. * page/Settings.h: Explain nuances regarding loadsImagesAutomatically setting.
  32551. (WebCore::Settings::loadsSiteIconsIgnoringImageLoadingSetting): Added getter.
  32552. 2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
  32553. Reviewed by Eric Seidel.
  32554. Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
  32555. https://bugs.webkit.org/show_bug.cgi?id=55974
  32556. Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
  32557. to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
  32558. setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
  32559. diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.
  32560. Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp
  32561. * editing/ApplyStyleCommand.cpp:
  32562. * editing/ApplyStyleCommand.h:
  32563. * editing/EditingStyle.cpp:
  32564. (WebCore::reconcileTextDecorationProperties):
  32565. (WebCore::StyleChange::StyleChange):
  32566. (WebCore::setTextDecorationProperty):
  32567. (WebCore::getRGBAFontColor):
  32568. (WebCore::StyleChange::extractTextStyles):
  32569. (WebCore::diffTextDecorations):
  32570. (WebCore::fontWeightIsBold):
  32571. (WebCore::getTextAlignment):
  32572. (WebCore::getPropertiesNotIn):
  32573. (WebCore::getIdentifierValue):
  32574. (WebCore::isCSSValueLength):
  32575. (WebCore::legacyFontSizeFromCSSValue):
  32576. * editing/EditingStyle.h:
  32577. (WebCore::StyleChange::cssStyle):
  32578. (WebCore::StyleChange::applyBold):
  32579. (WebCore::StyleChange::applyItalic):
  32580. (WebCore::StyleChange::applyUnderline):
  32581. (WebCore::StyleChange::applyLineThrough):
  32582. (WebCore::StyleChange::applySubscript):
  32583. (WebCore::StyleChange::applySuperscript):
  32584. (WebCore::StyleChange::applyFontColor):
  32585. (WebCore::StyleChange::applyFontFace):
  32586. (WebCore::StyleChange::applyFontSize):
  32587. (WebCore::StyleChange::fontColor):
  32588. (WebCore::StyleChange::fontFace):
  32589. (WebCore::StyleChange::fontSize):
  32590. (WebCore::StyleChange::operator==):
  32591. (WebCore::StyleChange::operator!=):
  32592. 2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
  32593. Reviewed by Kenneth Rohde Christiansen.
  32594. [Qt] Better padding for inputs and comboxes in mobile theme
  32595. https://bugs.webkit.org/show_bug.cgi?id=58248
  32596. * platform/qt/RenderThemeQt.cpp:
  32597. (WebCore::RenderThemeQt::setButtonPadding):
  32598. (WebCore::RenderThemeQt::adjustTextFieldStyle):
  32599. (WebCore::RenderThemeQt::paintTextField):
  32600. (WebCore::RenderThemeQt::adjustMenuListStyle):
  32601. 2011-04-11 Abhishek Arya <inferno@chromium.org>
  32602. Reviewed by Dave Hyatt.
  32603. Replace insertChildNode with addChild in handleRunIn's reparenting
  32604. of inlineRunIn to currBlock.
  32605. https://bugs.webkit.org/show_bug.cgi?id=58228
  32606. Use addChild instead of insertChildNode since it handles
  32607. correct placement of the children, esp where we cannot insert
  32608. anything before the first child. e.g. details tag requires that its
  32609. first child be a summary child and won't be able to remove child if
  32610. that is not the case.
  32611. Test: fast/runin/runin-reparent-crash.html
  32612. * rendering/RenderBlock.cpp:
  32613. (WebCore::RenderBlock::handleRunInChild):
  32614. 2011-04-12 Chris Fleizach <cfleizach@apple.com>
  32615. Unreviewed. Fixing Leopard build.
  32616. REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
  32617. https://bugs.webkit.org/show_bug.cgi?id=58304
  32618. checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).
  32619. * accessibility/mac/AccessibilityObjectWrapper.mm:
  32620. (AXAttributeStringSetSpelling):
  32621. 2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
  32622. Unreviewed. Added missing files to GNUmakefile.list.am.
  32623. * GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].
  32624. 2011-04-12 Cris Neckar <cdn@chromium.org>
  32625. Reviewed by Nikolas Zimmermann.
  32626. Add handling for non-svg inline text boxes in text box lists.
  32627. https://bugs.webkit.org/show_bug.cgi?id=57933
  32628. Test: svg/text/svg-rtl-text-crash.html
  32629. * rendering/svg/RenderSVGInlineText.cpp:
  32630. (WebCore::RenderSVGInlineText::positionForPoint):
  32631. * rendering/svg/SVGInlineFlowBox.cpp:
  32632. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  32633. * rendering/svg/SVGRenderTreeAsText.cpp:
  32634. (WebCore::writeSVGInlineTextBoxes):
  32635. * rendering/svg/SVGRootInlineBox.cpp:
  32636. (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
  32637. (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
  32638. * rendering/svg/SVGTextQuery.cpp:
  32639. (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
  32640. 2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
  32641. Reviewed by Chris Fleizach.
  32642. [GTK] Expose menu items and menus as children of a menu bar
  32643. https://bugs.webkit.org/show_bug.cgi?id=56659
  32644. Ensure menu items get exposed when they're children of menu bars.
  32645. * accessibility/AccessibilityRenderObject.cpp:
  32646. (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
  32647. Consider menu bars as potential parent objects for menu items.
  32648. 2011-04-12 Pavel Feldman <pfeldman@google.com>
  32649. Reviewed by Yury Semikhatsky.
  32650. Web Inspector: remove scriptWorldType from the protocol.
  32651. https://bugs.webkit.org/show_bug.cgi?id=58324
  32652. * inspector/Inspector.json:
  32653. * inspector/InspectorDebuggerAgent.cpp:
  32654. (WebCore::InspectorDebuggerAgent::didParseSource):
  32655. * inspector/ScriptDebugListener.h:
  32656. (WebCore::ScriptDebugListener::~ScriptDebugListener):
  32657. * inspector/front-end/DebuggerModel.js:
  32658. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  32659. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  32660. * inspector/front-end/Script.js:
  32661. (WebInspector.Script):
  32662. * inspector/front-end/ScriptsPanel.js:
  32663. * inspector/front-end/SourceFile.js:
  32664. (WebInspector.SourceFile):
  32665. 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
  32666. Reviewed by Eric Carlson.
  32667. Should MediaControls::changedNetworkState fiddle with Fullscreen controls?
  32668. https://bugs.webkit.org/show_bug.cgi?id=58163
  32669. Covered by existing tests and manual-tests/media-controls.html.
  32670. * html/shadow/MediaControls.cpp:
  32671. (WebCore::MediaControls::reset): Moved fullscreen showing/hiding here.
  32672. (WebCore::MediaControls::changedNetworkState): ... from here.
  32673. 2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
  32674. Reviewed by Pavel Feldman.
  32675. Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
  32676. https://bugs.webkit.org/show_bug.cgi?id=58335
  32677. It was the method for Inspector layout tests.
  32678. We can use RuntimeAgent.evaluate instead.
  32679. * inspector/Inspector.json:
  32680. * inspector/InspectorAgent.cpp:
  32681. * inspector/InspectorAgent.h:
  32682. * inspector/InspectorController.cpp:
  32683. (WebCore::InspectorController::connectFrontend):
  32684. * inspector/front-end/TestController.js:
  32685. (WebInspector.TestController.prototype.notifyDone):
  32686. 2011-04-12 Philippe Normand <pnormand@igalia.com>
  32687. Reviewed by Martin Robinson.
  32688. [GStreamer] some public callbacks remain
  32689. https://bugs.webkit.org/show_bug.cgi?id=58307
  32690. Cleanup of the player public/private APIs. Moving the GstMessage
  32691. handling code inside of the player allowed some APIs to move to
  32692. the private scope of the class.
  32693. No new tests, this patch is a cleanup and should not affect
  32694. current tests coverage.
  32695. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  32696. (WebCore::mediaPlayerPrivateMessageCallback):
  32697. (WebCore::mediaPlayerPrivateSourceChangedCallback):
  32698. (WebCore::mediaPlayerPrivateVolumeChangedCallback):
  32699. (WebCore::mediaPlayerPrivateMuteChangedCallback):
  32700. (WebCore::mediaPlayerPrivateRepaintCallback):
  32701. (WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
  32702. (WebCore::MediaPlayerPrivateGStreamer::currentTime):
  32703. (WebCore::MediaPlayerPrivateGStreamer::seek):
  32704. (WebCore::MediaPlayerPrivateGStreamer::setRate):
  32705. (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
  32706. (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
  32707. (WebCore::MediaPlayerPrivateGStreamer::triggerRepaint):
  32708. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  32709. 2011-04-12 Philippe Normand <pnormand@igalia.com>
  32710. Reviewed by Martin Robinson.
  32711. [GStreamer] advertize HTTP Live Streaming mime-type
  32712. https://bugs.webkit.org/show_bug.cgi?id=58318
  32713. Register the hls mime-type in the internal cache if found in the
  32714. typefind factories.
  32715. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  32716. (WebCore::mimeTypeCache):
  32717. 2011-04-11 MORITA Hajime <morrita@google.com>
  32718. Reviewed by Ryosuke Niwa.
  32719. RenderIndicator and ShadowBlockElement are no longer used.
  32720. https://bugs.webkit.org/show_bug.cgi?id=58277
  32721. Removed RenderIndicator and ShadowBlockElement.
  32722. No new tests. Just removed unused code.
  32723. * CMakeLists.txt:
  32724. * GNUmakefile.list.am:
  32725. * WebCore.gypi:
  32726. * WebCore.pro:
  32727. * WebCore.vcproj/WebCore.vcproj:
  32728. * WebCore.xcodeproj/project.pbxproj:
  32729. * rendering/RenderIndicator.cpp: Removed.
  32730. * rendering/RenderIndicator.h: Removed.
  32731. * rendering/RenderMeter.h:
  32732. * rendering/RenderingAllInOne.cpp:
  32733. * rendering/ShadowElement.cpp:
  32734. * rendering/ShadowElement.h:
  32735. 2011-04-12 Csaba Osztrogonác <ossy@webkit.org>
  32736. Reviewed by Benjamin Poulain.
  32737. fast/css/dashboard-regions-attr-crash.html asserts
  32738. https://bugs.webkit.org/show_bug.cgi?id=58233
  32739. Move DASHBOARD_SUPPORT feature detection from features.pri to CodeGenerators.pri
  32740. not to generate incorrect properties into CSSPropertyNames.h.
  32741. * CodeGenerators.pri:
  32742. * features.pri:
  32743. 2011-04-12 Chris Fleizach <cfleizach@apple.com>
  32744. Reviewed by Dan Bernstein.
  32745. REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
  32746. https://bugs.webkit.org/show_bug.cgi?id=58304
  32747. checkSpellingOfString is no longer implemented in WK2. Accessibility needs to change to use
  32748. checkTextOfParagraph in order to retrieve misspelled ranges.
  32749. Existing tests cover this functionality.
  32750. * accessibility/mac/AccessibilityObjectWrapper.mm:
  32751. (AXAttributeStringSetSpelling):
  32752. 2011-04-12 Sergio Villar Senin <svillar@igalia.com>
  32753. Reviewed by Martin Robinson.
  32754. [GTK] Remove m_idleHandler from ResourceHandleSoup
  32755. https://bugs.webkit.org/show_bug.cgi?id=58319
  32756. The m_idleHandler attribute is no longer used in ResourceHandleSoup.
  32757. No new tests needed, no functionality change.
  32758. * platform/network/ResourceHandleInternal.h:
  32759. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  32760. * platform/network/soup/ResourceHandleSoup.cpp:
  32761. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  32762. 2011-04-12 Andrey Adaikin <aandrey@google.com>
  32763. Reviewed by Yury Semikhatsky.
  32764. Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace
  32765. https://bugs.webkit.org/show_bug.cgi?id=58314
  32766. * inspector/front-end/SourceFrame.js:
  32767. (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
  32768. 2011-04-11 Pavel Podivilov <podivilov@chromium.org>
  32769. Reviewed by Pavel Feldman.
  32770. Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
  32771. https://bugs.webkit.org/show_bug.cgi?id=58238
  32772. Commit/cancel editing functionality is common for all resource types, and it deals with TextViewer state.
  32773. * inspector/front-end/SourceFrame.js:
  32774. (WebInspector.SourceFrame):
  32775. (WebInspector.SourceFrame.prototype.isContentEditable):
  32776. (WebInspector.SourceFrame.prototype._createTextViewer):
  32777. (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
  32778. (WebInspector.SourceFrame.prototype.commitEditing):
  32779. (WebInspector.SourceFrame.prototype.cancelEditing):
  32780. * inspector/front-end/TextViewer.js:
  32781. (WebInspector.TextViewer.prototype._doubleClick):
  32782. (WebInspector.TextViewer.prototype._registerShortcuts):
  32783. (WebInspector.TextViewer.prototype._handleKeyDown):
  32784. (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
  32785. (WebInspector.TextViewer.prototype._commitEditing):
  32786. (WebInspector.TextViewer.prototype._cancelEditing):
  32787. (WebInspector.TextViewerDelegate.prototype.endEditing):
  32788. (WebInspector.TextViewerDelegate.prototype.commitEditing):
  32789. (WebInspector.TextViewerDelegate.prototype.cancelEditing):
  32790. 2011-04-12 Pavel Feldman <pfeldman@google.com>
  32791. Reviewed by Yury Semikhatsky.
  32792. Web Inspector: cookies view is empty even for sites with cookies.
  32793. https://bugs.webkit.org/show_bug.cgi?id=58316
  32794. Test: http/tests/inspector/resource-tree-model.html
  32795. * inspector/front-end/ResourceTreeModel.js:
  32796. (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
  32797. 2011-04-11 Stephen White <senorblanco@chromium.org>
  32798. Reviewed by James Robinson.
  32799. [chromium] GPU-accelerated canvas-to-canvas drawImage is incorrect.
  32800. https://bugs.webkit.org/show_bug.cgi?id=58258
  32801. When one accelerated canvas is drawn to another via drawImage(), if the
  32802. prior call in the source canvas was non-accelerated, the
  32803. hardware canvas is not up-to-date, and the results will be incorrect.
  32804. Fixed by calling prepareForHardwareDraw() on the source context.
  32805. Test: fast/canvas/canvas-to-canvas.html
  32806. * platform/graphics/skia/ImageBufferSkia.cpp:
  32807. (WebCore::ImageBuffer::draw):
  32808. 2011-04-12 Mikhail Naganov <mnaganov@chromium.org>
  32809. Reviewed by Pavel Feldman.
  32810. Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
  32811. https://bugs.webkit.org/show_bug.cgi?id=58146
  32812. Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html
  32813. inspector/profiler/detailed-heapshots-comparison-show-all.html
  32814. inspector/profiler/detailed-heapshots-comparison-show-next.html
  32815. inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html
  32816. inspector/profiler/detailed-heapshots-comparison-sorting.html
  32817. inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html
  32818. inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html
  32819. inspector/profiler/detailed-heapshots-dominators-show-all.html
  32820. inspector/profiler/detailed-heapshots-dominators-show-next.html
  32821. inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html
  32822. inspector/profiler/detailed-heapshots-dominators-sorting.html
  32823. inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html
  32824. * inspector/front-end/DetailedHeapshotView.js:
  32825. (WebInspector.HeapSnapshotDiffDataGrid):
  32826. 2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
  32827. Reviewed by Yury Semikhatsky.
  32828. Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
  32829. https://bugs.webkit.org/show_bug.cgi?id=58305
  32830. It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.
  32831. * inspector/CodeGeneratorInspector.pm:
  32832. 2011-04-11 Pavel Podivilov <podivilov@chromium.org>
  32833. Reviewed by Pavel Feldman.
  32834. Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
  32835. https://bugs.webkit.org/show_bug.cgi?id=58232
  32836. * WebCore.gypi:
  32837. 2011-04-12 Pavel Podivilov <podivilov@chromium.org>
  32838. Reviewed by Pavel Feldman.
  32839. Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
  32840. https://bugs.webkit.org/show_bug.cgi?id=58273
  32841. * inspector/front-end/SourceFrame.js:
  32842. (WebInspector.SourceFrame):
  32843. (WebInspector.SourceFrame.prototype.get visible):
  32844. (WebInspector.SourceFrame.prototype.set visible):
  32845. (WebInspector.SourceFrame.prototype.show):
  32846. (WebInspector.SourceFrame.prototype.hide):
  32847. (WebInspector.SourceFrame.prototype.detach):
  32848. (WebInspector.SourceFrame.prototype._ensureContentLoaded):
  32849. (WebInspector.SourceFrame.prototype.markDiff):
  32850. (WebInspector.SourceFrame.prototype.addMessage):
  32851. (WebInspector.SourceFrame.prototype.clearMessages):
  32852. (WebInspector.SourceFrame.prototype.get scrollTop):
  32853. (WebInspector.SourceFrame.prototype.set scrollTop):
  32854. (WebInspector.SourceFrame.prototype.highlightLine):
  32855. (WebInspector.SourceFrame.prototype._clearLineHighlight):
  32856. (WebInspector.SourceFrame.prototype._initializeTextViewer):
  32857. (WebInspector.SourceFrame.prototype.performSearch):
  32858. (WebInspector.SourceFrame.prototype.searchCanceled):
  32859. (WebInspector.SourceFrame.prototype._jumpToSearchResult):
  32860. (WebInspector.SourceFrame.prototype.setExecutionLine):
  32861. (WebInspector.SourceFrame.prototype.clearExecutionLine):
  32862. (WebInspector.SourceFrame.prototype.resize):
  32863. 2011-04-12 Pavel Feldman <pfeldman@google.com>
  32864. Reviewed by Yury Semikhatsky.
  32865. Web Inspector: document runtime agent, share remote object definition between domains.
  32866. https://bugs.webkit.org/show_bug.cgi?id=58246
  32867. * inspector/Inspector.json:
  32868. 2011-04-12 Pavel Feldman <pfeldman@google.com>
  32869. Reviewed by Yury Semikhatsky.
  32870. Web Inspector: document console domain, support cross-domain type references.
  32871. https://bugs.webkit.org/show_bug.cgi?id=58240
  32872. * inspector/ConsoleMessage.cpp:
  32873. (WebCore::messageSourceValue):
  32874. (WebCore::messageTypeValue):
  32875. (WebCore::messageLevelValue):
  32876. (WebCore::ConsoleMessage::addToFrontend):
  32877. * inspector/Inspector.json:
  32878. * inspector/ScriptCallFrame.cpp:
  32879. (WebCore::ScriptCallFrame::buildInspectorObject):
  32880. * inspector/front-end/ConsoleView.js:
  32881. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
  32882. (WebInspector.ConsoleMessage):
  32883. (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
  32884. (WebInspector.ConsoleMessage.prototype.isEqual):
  32885. * inspector/front-end/NetworkManager.js:
  32886. (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
  32887. * inspector/generate-inspector-idl:
  32888. * page/Console.h:
  32889. 2011-04-06 Philippe Normand <pnormand@igalia.com>
  32890. Reviewed by Martin Robinson.
  32891. [GStreamer] RTSP playback broken
  32892. https://bugs.webkit.org/show_bug.cgi?id=56930
  32893. Rely on {audio,video}-changed playbin2 signals instead of the
  32894. -tags-changed signals because some media don't provide tags and
  32895. then can trick the media-player to not paint video, for instance.
  32896. Also trigger a video size calculation after the video sink
  32897. negotiated its caps. This is useful in the cases where
  32898. audio-changed signal is emitted but the video sink takes more time
  32899. to negociate caps with its peer.
  32900. This patch also fixes the rtsp manual-test with a new stream url
  32901. which seems to be more permanent than the previous WWDC keynote
  32902. stream.
  32903. * manual-tests/video-rtsp.html:
  32904. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  32905. (WebCore::mediaPlayerPrivateVideoChangedCallback):
  32906. (WebCore::mediaPlayerPrivateAudioChangedCallback):
  32907. (WebCore::mediaPlayerPrivateAudioChangeTimeoutCallback):
  32908. (WebCore::mediaPlayerPrivateVideoChangeTimeoutCallback):
  32909. (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
  32910. (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
  32911. (WebCore::MediaPlayerPrivateGStreamer::naturalSize):
  32912. (WebCore::MediaPlayerPrivateGStreamer::videoChanged):
  32913. (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
  32914. (WebCore::MediaPlayerPrivateGStreamer::audioChanged):
  32915. (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
  32916. (WebCore::MediaPlayerPrivateGStreamer::paint):
  32917. (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  32918. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  32919. 2011-04-12 Vsevolod Vlasov <vsevik@chromium.org>
  32920. Reviewed by Pavel Feldman.
  32921. Web Inspector: Failed/canceled resource requests kept showing as Pending in network panel.
  32922. https://bugs.webkit.org/show_bug.cgi?id=58135
  32923. Added statuses for failed/canceled resource loading.
  32924. * English.lproj/localizedStrings.js:
  32925. * inspector/Inspector.json:
  32926. * inspector/InspectorResourceAgent.cpp:
  32927. (WebCore::InspectorResourceAgent::didFailLoading):
  32928. * inspector/front-end/NetworkManager.js:
  32929. * inspector/front-end/NetworkPanel.js:
  32930. * inspector/front-end/Resource.js:
  32931. 2011-04-12 Steve Block <steveblock@google.com>
  32932. Reviewed by Oliver Hunt.
  32933. Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
  32934. https://bugs.webkit.org/show_bug.cgi?id=40012
  32935. Covered by fast/dom/Geolocation/argument-types.html
  32936. * bindings/js/CallbackFunction.cpp:
  32937. (WebCore::checkFunctionOnlyCallback):
  32938. 2011-04-07 Philippe Normand <pnormand@igalia.com>
  32939. Reviewed by Martin Robinson.
  32940. [GStreamer] report playback statistics
  32941. https://bugs.webkit.org/show_bug.cgi?id=58033
  32942. Provide media playback statistics using fpsdisplaysink and
  32943. position queries.
  32944. * manual-tests/video-statistics.html: Added.
  32945. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  32946. (WebCore::MediaPlayerPrivateGStreamer::decodedFrameCount):
  32947. (WebCore::MediaPlayerPrivateGStreamer::droppedFrameCount):
  32948. (WebCore::MediaPlayerPrivateGStreamer::audioDecodedByteCount):
  32949. (WebCore::MediaPlayerPrivateGStreamer::videoDecodedByteCount):
  32950. (WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
  32951. (WebCore::MediaPlayerPrivateGStreamer::updateStates):
  32952. (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  32953. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  32954. 2011-04-11 Philippe Normand <pnormand@igalia.com>
  32955. Reviewed by Martin Robinson.
  32956. [GStreamer] warnings in media/video-set-rate-from-pause.html
  32957. https://bugs.webkit.org/show_bug.cgi?id=58220
  32958. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  32959. (WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the
  32960. pipeline if new rate is zero, like advised in the GStreamer
  32961. documentation of gst_event_new_seek().
  32962. 2011-04-11 Vangelis Kokkevis <vangelis@chromium.org>
  32963. Reviewed by James Robinson.
  32964. [chromium] Properly invalidate the contents of ImageLayerChromium's
  32965. when the actual image contents change.
  32966. https://bugs.webkit.org/show_bug.cgi?id=58181
  32967. Test: compositing/images/content-image-change.html
  32968. * platform/graphics/chromium/ContentLayerChromium.cpp:
  32969. (WebCore::ContentLayerChromium::updateTexture):
  32970. * platform/graphics/chromium/ImageLayerChromium.cpp:
  32971. (WebCore::ImageLayerChromium::ImageLayerChromium):
  32972. (WebCore::ImageLayerChromium::setContents):
  32973. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  32974. * platform/graphics/chromium/ImageLayerChromium.h:
  32975. 2011-04-11 Simon Fraser <simon.fraser@apple.com>
  32976. Reviewed by Dan Bernstein.
  32977. -webkit-box-shadow:inset does not animate transform as an inset shadow
  32978. https://bugs.webkit.org/show_bug.cgi?id=45176
  32979. Two fixes:
  32980. 1. Don't run transitions between different shadow styles (normal vs. inset).
  32981. 2. When either source or destination is null, use a default shadow with a
  32982. matching style so that the transition runs.
  32983. Test: transitions/mismatched-shadow-styles.html
  32984. * page/animation/AnimationBase.cpp:
  32985. (WebCore::blendFunc):
  32986. (WebCore::PropertyWrapperShadow::blend):
  32987. 2011-04-11 John Bates <jbates@google.com>
  32988. Reviewed by Kenneth Russell.
  32989. chromium support for glSetLatch and glWaitLatch between 3D contexts
  32990. https://bugs.webkit.org/show_bug.cgi?id=58003
  32991. * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
  32992. (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
  32993. (WebCore::Canvas2DLayerChromium::setDrawingBuffer):
  32994. (WebCore::Canvas2DLayerChromium::setLayerRenderer):
  32995. * platform/graphics/chromium/Canvas2DLayerChromium.h:
  32996. * platform/graphics/chromium/Extensions3DChromium.h:
  32997. * platform/graphics/chromium/GLES2Canvas.cpp:
  32998. (WebCore::Cubic::Cubic):
  32999. * platform/graphics/chromium/LayerRendererChromium.cpp:
  33000. (WebCore::LayerRendererChromium::LayerRendererChromium):
  33001. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  33002. (WebCore::LayerRendererChromium::updateLayers):
  33003. (WebCore::LayerRendererChromium::addChildContext):
  33004. (WebCore::LayerRendererChromium::removeChildContext):
  33005. * platform/graphics/chromium/LayerRendererChromium.h:
  33006. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  33007. (WebCore::WebGLLayerChromium::~WebGLLayerChromium):
  33008. (WebCore::WebGLLayerChromium::updateCompositorResources):
  33009. (WebCore::WebGLLayerChromium::setContext):
  33010. (WebCore::WebGLLayerChromium::setLayerRenderer):
  33011. * platform/graphics/chromium/WebGLLayerChromium.h:
  33012. 2011-04-11 Alexey Marinichev <amarinichev@chromium.org>
  33013. Reviewed by James Robinson.
  33014. LayerChromium/CCLayerImpl ownership fix
  33015. https://bugs.webkit.org/show_bug.cgi?id=58283
  33016. CCLayerImpl's m_owner field lifetime should match the lifetime of the
  33017. corresponding LayerChromium. This change moves resetting of m_owner
  33018. into LayerChromium's destructor.
  33019. Tested similarly to bug 57577.
  33020. * platform/graphics/chromium/LayerChromium.cpp:
  33021. (WebCore::LayerChromium::~LayerChromium):
  33022. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  33023. (WebCore::CCLayerImpl::cleanupResources):
  33024. * platform/graphics/chromium/cc/CCLayerImpl.h:
  33025. (WebCore::CCLayerImpl::resetOwner):
  33026. 2011-04-11 Daniel Bates <dbates@rim.com>
  33027. Attempt to fix the GTK build after changeset 83527 <http://trac.webkit.org/changeset/83527>
  33028. (https://bugs.webkit.org/show_bug.cgi?id=53556).
  33029. * GNUmakefile.list.am: Append files HTMLTrackElement.{h, cpp} to the list webcore_sources.
  33030. 2011-04-11 Brady Eidson <beidson@apple.com>
  33031. Reviewed by Maciej Stachowiak.
  33032. <rdar://problem/9251515> and https://bugs.webkit.org/show_bug.cgi?id=58072
  33033. URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history
  33034. Test: fast/loader/stateobjects/state-url-sets-links-visited.html
  33035. * loader/HistoryController.cpp:
  33036. (WebCore::HistoryController::pushState): Notify the history client and add the visited link.
  33037. (WebCore::HistoryController::replaceState): Ditto.
  33038. 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
  33039. Reviewed by Eric Carlson.
  33040. Rename MediaControls to MediaControlRootElement.
  33041. https://bugs.webkit.org/show_bug.cgi?id=58250
  33042. Mechanical move using do-webcore-rename.
  33043. 2011-04-11 Dean Jackson <dino@apple.com>
  33044. Reviewed by Simon Fraser.
  33045. https://bugs.webkit.org/show_bug.cgi?id=58285
  33046. CompositeAnimation is cleared while an AnimationBase is waiting for notification
  33047. Occasionally hardware animations would trigger a state where
  33048. they would tell the AnimationControllerPrivate that it should notify
  33049. any waiting animations that they are ready to start, even though
  33050. the RenderObject had gone away and hence the CompositeAnimation
  33051. had been destroyed. The fix is to zero the pointer from AnimationBase
  33052. when the CompositeAnimation destructor runs (or its animations are
  33053. cleared) and test the validity of the CompositeAnimation before it
  33054. is used in AnimationBase.
  33055. * page/animation/AnimationBase.cpp:
  33056. (WebCore::AnimationBase::updateStateMachine):
  33057. (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  33058. (WebCore::AnimationBase::updatePlayState):
  33059. (WebCore::AnimationBase::freezeAtTime):
  33060. (WebCore::AnimationBase::beginAnimationUpdateTime):
  33061. - test that the CompositeAnimation exists
  33062. * page/animation/AnimationBase.h:
  33063. (WebCore::AnimationBase::clear):
  33064. - rename clearRenderer() to clear() as it now also clears the CompositeAnimation
  33065. * page/animation/CompositeAnimation.cpp:
  33066. (WebCore::CompositeAnimation::clearRenderer):
  33067. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  33068. - call clear() rather than clearRenderer()
  33069. 2011-04-11 Justin Novosad <junov@chromium.org>
  33070. Reviewed by Kenneth Russell.
  33071. [Chromium] Text anti-aliasing fails when rendering text with shadow
  33072. https://bugs.webkit.org/show_bug.cgi?id=57584
  33073. * platform/graphics/chromium/FontChromiumWin.cpp:
  33074. (WebCore::drawGlyphsWin): new static function, code factored-out
  33075. from WebCore::Font::drawGlyphs
  33076. (WebCore::Font::drawGlyphs): may separate font rendering into two
  33077. passes to allow foreground glyphs to be rendered with GDI when Skia
  33078. is required for rendering shadows
  33079. * platform/graphics/skia/SkiaFontWin.cpp:
  33080. (WebCore::windowsCanHandleDrawTextShadow):
  33081. Modified method so that it does not assume a shadow is present, and
  33082. returns true if there is no shadow (GDI can draw 'no shadow')
  33083. (WebCore::windowsCanHandleTextDrawing):
  33084. Factored out into sub methods so that the the shadow and foregound
  33085. glyph properties can be tested separately independently.
  33086. (WebCore::windowsCanHandleTextDrawingWithoutShadow):
  33087. New method returns true if the foreground glyph only has effect
  33088. that can be draw with GDI
  33089. (WebCore::paintSkiaText):
  33090. * platform/graphics/skia/SkiaFontWin.h:
  33091. 2011-04-11 Ryosuke Niwa <rniwa@webkit.org>
  33092. Unreviewed, rolling out r83515.
  33093. http://trac.webkit.org/changeset/83515
  33094. https://bugs.webkit.org/show_bug.cgi?id=57178
  33095. Broke GTK builds. nextOnLineExists and prevOnLineExists are still used in AccessibilityObjectWrapperAtk.cpp.
  33096. * rendering/InlineBox.cpp:
  33097. (WebCore::InlineBox::nextOnLineExists):
  33098. (WebCore::InlineBox::prevOnLineExists):
  33099. * rendering/InlineBox.h:
  33100. (WebCore::InlineBox::InlineBox):
  33101. 2011-04-11 Brady Eidson <beidson@apple.com>
  33102. Reverting, seeing something else still broken. Sorry.
  33103. * html/HTMLTrackElement.cpp:
  33104. 2011-04-11 Brady Eidson <beidson@apple.com>
  33105. Fix the build.
  33106. * html/HTMLTrackElement.cpp: Case-sensitive, please.
  33107. 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
  33108. Unreviewed build fix for Mac.
  33109. An idl file was added in the wrong place.
  33110. * WebCore.xcodeproj/project.pbxproj:
  33111. 2011-04-11 Chris Marrin <cmarrin@apple.com>
  33112. Rubberstamped by Dan Bernstein.
  33113. xhr.responseType = 'arraybuffer' works on Mac but not on Windows
  33114. https://bugs.webkit.org/show_bug.cgi?id=50334
  33115. Got rid of guards around arraybuffer logic in XHR. ArrayBuffer and friends
  33116. are always turned on now, so there's not need for the guard. I reenabled the
  33117. test that was Skipped on Windows and it works now.
  33118. * bindings/js/JSXMLHttpRequestCustom.cpp:
  33119. (WebCore::JSXMLHttpRequest::markChildren):
  33120. (WebCore::JSXMLHttpRequest::send):
  33121. (WebCore::JSXMLHttpRequest::response):
  33122. * xml/XMLHttpRequest.cpp:
  33123. (WebCore::XMLHttpRequest::responseArrayBuffer):
  33124. (WebCore::XMLHttpRequest::setResponseType):
  33125. (WebCore::XMLHttpRequest::send):
  33126. (WebCore::XMLHttpRequest::clearResponseBuffers):
  33127. (WebCore::XMLHttpRequest::didReceiveData):
  33128. * xml/XMLHttpRequest.h:
  33129. (WebCore::XMLHttpRequest::optionalResponseArrayBuffer):
  33130. 2011-04-11 Anna Cavender <annacc@chromium.org>
  33131. Reviewed by Eric Carlson.
  33132. Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
  33133. https://bugs.webkit.org/show_bug.cgi?id=53556
  33134. No new tests. No real functionality added just yet.
  33135. * CMakeLists.txt:
  33136. * CodeGenerators.pri:
  33137. * Configurations/FeatureDefines.xcconfig:
  33138. * DerivedSources.make:
  33139. * GNUmakefile.am:
  33140. * GNUmakefile.list.am:
  33141. * WebCore.gypi:
  33142. * WebCore.xcodeproj/project.pbxproj:
  33143. * features.pri:
  33144. * html/HTMLAttributeNames.in:
  33145. * html/HTMLTagNames.in:
  33146. * html/HTMLTrackElement.cpp: Added.
  33147. (WebCore::HTMLTrackElement::HTMLTrackElement):
  33148. (WebCore::HTMLTrackElement::create):
  33149. (WebCore::HTMLTrackElement::insertedIntoTree):
  33150. (WebCore::HTMLTrackElement::willRemove):
  33151. (WebCore::HTMLTrackElement::src):
  33152. (WebCore::HTMLTrackElement::setSrc):
  33153. (WebCore::HTMLTrackElement::kind):
  33154. (WebCore::HTMLTrackElement::setKind):
  33155. (WebCore::HTMLTrackElement::srclang):
  33156. (WebCore::HTMLTrackElement::setSrclang):
  33157. (WebCore::HTMLTrackElement::label):
  33158. (WebCore::HTMLTrackElement::setLabel):
  33159. (WebCore::HTMLTrackElement::isDefault):
  33160. (WebCore::HTMLTrackElement::setIsDefault):
  33161. (WebCore::HTMLTrackElement::isURLAttribute):
  33162. * html/HTMLTrackElement.h: Added.
  33163. * html/HTMLTrackElement.idl: Added.
  33164. 2011-04-11 Ben Taylor <bentaylor.solx86@gmail.com>
  33165. Reviewed by David Levin.
  33166. https://bugs.webkit.org/show_bug.cgi?id=57535
  33167. Better compile fix for Solaris 10/Sun Studio 12 CC
  33168. needing <sys/time.h>
  33169. * loader/icon/IconRecord.h:
  33170. * page/Page.h:
  33171. * platform/network/ResourceResponseBase.h:
  33172. 2011-04-11 Alexey Proskuryakov <ap@apple.com>
  33173. Reviewed by Maciej Stachowiak.
  33174. WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
  33175. https://bugs.webkit.org/show_bug.cgi?id=58265
  33176. <rdar://problem/9221468>
  33177. * page/EventHandler.cpp:
  33178. (WebCore::EventHandler::defaultKeyboardEventHandler): Handle Backspace.
  33179. (WebCore::EventHandler::defaultSpaceEventHandler): Enabled this on Mac, and added checks for
  33180. other modifiers - no one wants to scroll on Ctrl+Alt+Space and such.
  33181. (WebCore::EventHandler::defaultBackspaceEventHandler): Backspace goes back, Shift-backspace
  33182. goes forward. All browsers do it.
  33183. (WebCore::EventHandler::defaultArrowEventHandler): Assert that this function was called
  33184. for a correct event.
  33185. (WebCore::EventHandler::defaultTabEventHandler): Ditto.
  33186. * page/EventHandler.h: Added defaultBackspaceEventHandler.
  33187. 2011-04-11 Matthew Delaney <mdelaney@apple.com>
  33188. Reviewed by Dan Bernstein.
  33189. [CG] drawImage with a subimage bleeds pixel data at borders
  33190. https://bugs.webkit.org/show_bug.cgi?id=58267
  33191. Test: fast/canvas/DrawImageSinglePixelStretch.html
  33192. * platform/graphics/cg/ImageCG.cpp:
  33193. (WebCore::BitmapImage::draw): Any interpolation quality other than 'none' will graft out the subimage first now.
  33194. 2011-04-11 Chris Marrin <cmarrin@apple.com>
  33195. Reviewed by Simon Fraser.
  33196. iframe/compositing propagation should also work for <object> and framesets
  33197. https://bugs.webkit.org/show_bug.cgi?id=39037
  33198. Generalized the code that handles the parenting of composited <iframe> elements
  33199. to include <frame> and <object> elements. This includes forcing the parent
  33200. element to be composited and constructing the layer tree in the child document
  33201. and properly parenting it. Much of the change is giving the function calls more
  33202. generic names (from ...IFrame... to ...Frame...)
  33203. Compositing tests that were done in RenderIFrame have been moved to RenderPart
  33204. since this is the highest base class common to all 3 elements.
  33205. I also renamed several ...IFrame... functions to
  33206. ...Frame... and changed them so they work on a RenderPart for determining
  33207. if the renderer is composited. One other detail is that <iframe> and
  33208. <object> never share style since they might be composited. I had to add
  33209. <frame> to that list.
  33210. Tests: compositing/framesets/composited-frame-alignment.html
  33211. compositing/objects/composited-object-alignment.html
  33212. * css/CSSStyleSelector.cpp: Add <frame> to list of element types that should never share style since it might be composited.
  33213. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  33214. * page/FrameView.cpp:
  33215. (WebCore::FrameView::hasCompositedContentIncludingDescendants):
  33216. (WebCore::FrameView::setIsOverlapped):
  33217. * rendering/RenderIFrame.cpp: Moved methods to RenderPart
  33218. * rendering/RenderIFrame.h:
  33219. * rendering/RenderLayerBacking.cpp:
  33220. (WebCore::RenderLayerBacking::updateAfterWidgetResize):
  33221. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
  33222. (WebCore::RenderLayerBacking::paintingGoesToWindow):
  33223. * rendering/RenderLayerCompositor.cpp:
  33224. (WebCore::RenderLayerCompositor::updateBacking):
  33225. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  33226. (WebCore::RenderLayerCompositor::frameContentsCompositor):
  33227. (WebCore::RenderLayerCompositor::parentFrameContentLayers):
  33228. (WebCore::RenderLayerCompositor::didMoveOnscreen):
  33229. (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames):
  33230. (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
  33231. (WebCore::RenderLayerCompositor::enclosingFrameElement):
  33232. (WebCore::RenderLayerCompositor::requiresCompositingLayer):
  33233. (WebCore::RenderLayerCompositor::requiresCompositingForFrame):
  33234. (WebCore::RenderLayerCompositor::requiresScrollLayer):
  33235. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  33236. (WebCore::RenderLayerCompositor::attachRootPlatformLayer):
  33237. (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
  33238. * rendering/RenderLayerCompositor.h:
  33239. * rendering/RenderPart.cpp: Functions moved from RenderIFrame
  33240. (WebCore::RenderPart::requiresLayer):
  33241. (WebCore::RenderPart::requiresAcceleratedCompositing):
  33242. * rendering/RenderPart.h:
  33243. 2011-04-11 Yael Aharon <yael.aharon@nokia.com>
  33244. Reviewed by Eric Seidel.
  33245. InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed
  33246. https://bugs.webkit.org/show_bug.cgi?id=57178
  33247. Remove prevOnLineExists() and nextOnLineExists() as they are not used anymore.
  33248. No new tests needed because this is cleanup only.
  33249. * rendering/InlineBox.cpp:
  33250. * rendering/InlineBox.h:
  33251. (WebCore::InlineBox::InlineBox):
  33252. (WebCore::InlineBox::setPrevOnLine):
  33253. 2011-04-11 David Hyatt <hyatt@apple.com>
  33254. Reviewed by Dan Bernstein.
  33255. https://bugs.webkit.org/show_bug.cgi?id=58261
  33256. Fix for layout regression on marketwatch.com. When I converted TrailingFloatsRootInlineBox over
  33257. to the new overflow model, I messed up the math and passed a bottom value where I should have
  33258. passed a height value. This patch fixes the code to be logically equivalent to the way it
  33259. was prior to my changes.
  33260. Added fast/overflow/trailing-float-linebox.html.
  33261. * rendering/RenderBlockLineLayout.cpp:
  33262. (WebCore::RenderBlock::layoutInlineChildren):
  33263. 2011-04-11 Adrienne Walker <enne@google.com>
  33264. Unreviewed, rolling out r83500.
  33265. http://trac.webkit.org/changeset/83500
  33266. https://bugs.webkit.org/show_bug.cgi?id=57113
  33267. Regresses huge-layer-rotated test
  33268. * platform/graphics/chromium/ContentLayerChromium.cpp:
  33269. (WebCore::ContentLayerChromium::ContentLayerChromium):
  33270. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  33271. (WebCore::ContentLayerChromium::cleanupResources):
  33272. (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
  33273. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  33274. (WebCore::ContentLayerChromium::resizeUploadBuffer):
  33275. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  33276. (WebCore::ContentLayerChromium::updateTexture):
  33277. (WebCore::ContentLayerChromium::draw):
  33278. (WebCore::ContentLayerChromium::updateCompositorResources):
  33279. (WebCore::ContentLayerChromium::unreserveContentsTexture):
  33280. (WebCore::ContentLayerChromium::bindContentsTexture):
  33281. (WebCore::ContentLayerChromium::dumpLayerProperties):
  33282. * platform/graphics/chromium/ContentLayerChromium.h:
  33283. (WebCore::ContentLayerChromium::drawsContent):
  33284. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  33285. (WebCore::GraphicsLayerChromium::setMaskLayer):
  33286. * platform/graphics/chromium/ImageLayerChromium.cpp:
  33287. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  33288. (WebCore::ImageLayerChromium::updateTextureIfNeeded):
  33289. * platform/graphics/chromium/ImageLayerChromium.h:
  33290. * platform/graphics/chromium/LayerChromium.h:
  33291. (WebCore::LayerChromium::draw):
  33292. * platform/graphics/chromium/LayerRendererChromium.cpp:
  33293. (WebCore::LayerRendererChromium::drawRootLayer):
  33294. (WebCore::LayerRendererChromium::drawLayers):
  33295. (WebCore::LayerRendererChromium::paintContentsRecursive):
  33296. (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
  33297. (WebCore::LayerRendererChromium::drawLayer):
  33298. (WebCore::LayerRendererChromium::initializeSharedObjects):
  33299. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  33300. * platform/graphics/chromium/LayerRendererChromium.h:
  33301. (WebCore::LayerRendererChromium::contentLayerProgram):
  33302. * platform/graphics/chromium/LayerTilerChromium.cpp:
  33303. (WebCore::LayerTilerChromium::invalidateRect):
  33304. (WebCore::LayerTilerChromium::update):
  33305. (WebCore::LayerTilerChromium::updateFromPixels):
  33306. (WebCore::LayerTilerChromium::draw):
  33307. * platform/graphics/chromium/LayerTilerChromium.h:
  33308. * platform/graphics/chromium/PlatformCanvas.cpp:
  33309. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  33310. (WebCore::PlatformCanvas::Painter::Painter):
  33311. * platform/graphics/chromium/PlatformCanvas.h:
  33312. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  33313. (WebCore::RenderSurfaceChromium::draw):
  33314. * platform/graphics/chromium/RenderSurfaceChromium.h:
  33315. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  33316. (WebCore::CCCanvasLayerImpl::draw):
  33317. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  33318. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  33319. (WebCore::CCHeadsUpDisplay::draw):
  33320. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  33321. (WebCore::CCLayerImpl::draw):
  33322. * platform/graphics/chromium/cc/CCLayerImpl.h:
  33323. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
  33324. (WebCore::CCPluginLayerImpl::draw):
  33325. * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  33326. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
  33327. (WebCore::CCVideoLayerImpl::draw):
  33328. * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
  33329. 2011-04-11 Jon Honeycutt <jhoneycutt@apple.com>
  33330. <rdar://problem/9267042> Assertion failure on launch in
  33331. LayerChangesFlusher::setHook().
  33332. https://bugs.webkit.org/show_bug.cgi?id=58270
  33333. Reviewed by Adam Roben.
  33334. * platform/graphics/ca/win/LayerChangesFlusher.cpp:
  33335. (WebCore::LayerChangesFlusher::setHook):
  33336. MSDN says that the HINSTANCE passed in must be null if the thread ID
  33337. passed is a thread created by this process and the hook procedure is
  33338. within this process.
  33339. 2011-04-11 MORITA Hajime <morrita@google.com>
  33340. Unreviewed build fix.
  33341. Changeset 83492 broke Leopard build.
  33342. https://bugs.webkit.org/show_bug.cgi?id=58268
  33343. * editing/Editor.cpp:
  33344. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  33345. 2011-03-25 Adrienne Walker <enne@google.com>
  33346. Reviewed by James Robinson.
  33347. [chromium] Tile content and image layers
  33348. https://bugs.webkit.org/show_bug.cgi?id=57113
  33349. Layers tile by default if any dimension is larger than 512. Smaller
  33350. layers are contained within a single texture but still use the tiler
  33351. infrastructure so that there's only one code path.
  33352. Remove large layer support from content layers. Content layers no
  33353. longer own a platform canvas--they own a tiler. Refactor tiler to
  33354. allow for better separation of update/upload/paint. Add rect
  33355. parameter to update and draw functions on layers for the layer-space
  33356. rect of interest. This is necessary to know which tiles need to be
  33357. drawn.
  33358. * platform/graphics/chromium/ContentLayerChromium.cpp:
  33359. (WebCore::ContentLayerChromium::ContentLayerChromium):
  33360. (WebCore::ContentLayerChromium::~ContentLayerChromium):
  33361. (WebCore::ContentLayerPainter::ContentLayerPainter):
  33362. (WebCore::ContentLayerPainter::paint):
  33363. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  33364. (WebCore::ContentLayerChromium::setLayerRenderer):
  33365. (WebCore::ContentLayerChromium::tilingTransform):
  33366. (WebCore::ContentLayerChromium::visibleLayerRect):
  33367. (WebCore::ContentLayerChromium::layerBounds):
  33368. (WebCore::ContentLayerChromium::updateLayerSize):
  33369. (WebCore::ContentLayerChromium::draw):
  33370. (WebCore::ContentLayerChromium::createTilerIfNeeded):
  33371. (WebCore::ContentLayerChromium::updateCompositorResources):
  33372. (WebCore::ContentLayerChromium::setTilingOption):
  33373. (WebCore::ContentLayerChromium::bindContentsTexture):
  33374. (WebCore::ContentLayerChromium::unreserveContentsTexture):
  33375. (WebCore::ContentLayerChromium::setIsMask):
  33376. (WebCore::ContentLayerChromium::dumpLayerProperties):
  33377. * platform/graphics/chromium/ContentLayerChromium.h:
  33378. (WebCore::ContentLayerChromium::drawsContent):
  33379. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  33380. (WebCore::GraphicsLayerChromium::setMaskLayer):
  33381. * platform/graphics/chromium/ImageLayerChromium.cpp:
  33382. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  33383. (WebCore::ImageLayerChromium::updateCompositorResources):
  33384. (WebCore::ImageLayerChromium::layerBounds):
  33385. (WebCore::ImageLayerChromium::tilingTransform):
  33386. * platform/graphics/chromium/ImageLayerChromium.h:
  33387. * platform/graphics/chromium/LayerChromium.h:
  33388. (WebCore::LayerChromium::invalidateRect):
  33389. (WebCore::LayerChromium::paintContentsIfDirty):
  33390. (WebCore::LayerChromium::setIsMask):
  33391. (WebCore::LayerChromium::draw):
  33392. * platform/graphics/chromium/LayerRendererChromium.cpp:
  33393. (WebCore::LayerRendererChromium::drawRootLayer):
  33394. (WebCore::LayerRendererChromium::drawLayers):
  33395. (WebCore::LayerRendererChromium::paintContentsRecursive):
  33396. (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
  33397. (WebCore::LayerRendererChromium::drawLayer):
  33398. (WebCore::LayerRendererChromium::initializeSharedObjects):
  33399. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  33400. * platform/graphics/chromium/LayerRendererChromium.h:
  33401. * platform/graphics/chromium/LayerTilerChromium.cpp:
  33402. (WebCore::LayerTilerChromium::getSingleTexture):
  33403. (WebCore::LayerTilerChromium::invalidateRect):
  33404. (WebCore::LayerTilerChromium::update):
  33405. (WebCore::LayerTilerChromium::uploadCanvas):
  33406. (WebCore::LayerTilerChromium::updateFromPixels):
  33407. (WebCore::LayerTilerChromium::draw):
  33408. (WebCore::LayerTilerChromium::unreserveTextures):
  33409. * platform/graphics/chromium/LayerTilerChromium.h:
  33410. (WebCore::LayerTilerChromium::setLayerRenderer):
  33411. (WebCore::LayerTilerChromium::skipsDraw):
  33412. * platform/graphics/chromium/PlatformCanvas.cpp:
  33413. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  33414. (WebCore::PlatformCanvas::Painter::Painter):
  33415. * platform/graphics/chromium/PlatformCanvas.h:
  33416. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  33417. (WebCore::RenderSurfaceChromium::draw):
  33418. * platform/graphics/chromium/RenderSurfaceChromium.h:
  33419. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
  33420. (WebCore::CCCanvasLayerImpl::draw):
  33421. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  33422. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  33423. (WebCore::CCHeadsUpDisplay::draw):
  33424. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  33425. (WebCore::CCLayerImpl::draw):
  33426. * platform/graphics/chromium/cc/CCLayerImpl.h:
  33427. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
  33428. (WebCore::CCPluginLayerImpl::draw):
  33429. * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  33430. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
  33431. (WebCore::CCVideoLayerImpl::draw):
  33432. * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
  33433. 2011-04-11 Eric Carlson <eric.carlson@apple.com>
  33434. Reviewed by Simon Fraser.
  33435. Ignore context change callbacks when not on the main thread
  33436. https://bugs.webkit.org/show_bug.cgi?id=58256
  33437. <rdar://problem/9266090>
  33438. * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
  33439. (WebCore::WKCACFViewLayerTreeHost::contextDidChange): Do nothing when not called
  33440. on the main thread. This should only happen when no changes have actually
  33441. been committed to the context, eg. when a video frame has been added to an image
  33442. queue, so return without triggering animations etc.
  33443. 2011-04-11 Daniel Cheng <dcheng@chromium.org>
  33444. Reviewed by Dmitry Titov.
  33445. [chromium] Implement image/png support in DataTransferItems
  33446. https://bugs.webkit.org/show_bug.cgi?id=58106
  33447. This patch implements DataTransferItem::getAsFile() using Blobs. In
  33448. addition, plumbing for image/png has been added so image paste will be
  33449. supported as long as the renderer makes that data available.
  33450. Tests: editing/pasteboard/data-transfer-items-image-png.html
  33451. * dom/DataTransferItem.h:
  33452. * dom/DataTransferItem.idl:
  33453. * platform/chromium/ClipboardMimeTypes.cpp:
  33454. * platform/chromium/ClipboardMimeTypes.h:
  33455. * platform/chromium/DataTransferItemChromium.cpp:
  33456. (WebCore::DataTransferItemChromium::getAsString):
  33457. (WebCore::DataTransferItemChromium::getAsFile):
  33458. * platform/chromium/DataTransferItemChromium.h:
  33459. * platform/chromium/PlatformBridge.h:
  33460. 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
  33461. Reviewed by Chris Fleizach.
  33462. [Gtk] Implement support for Embedded Objects
  33463. https://bugs.webkit.org/show_bug.cgi?id=52148
  33464. Expose special OBJECT character for replaced elements, implementing
  33465. AtkText and AtkHyperlink when required.
  33466. * accessibility/AccessibilityRenderObject.cpp:
  33467. (WebCore::textIteratorBehaviorForTextRange): New helper function,
  33468. to return the right behavior, depending on the platform, so it
  33469. ensures that object replacement characters get emitted for GTK.
  33470. (WebCore::AccessibilityRenderObject::textUnderElement): Use the
  33471. new helper function textIteratorBehaviorForTextRange.
  33472. (WebCore::AccessibilityRenderObject::stringValue): Ditto.
  33473. (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  33474. Consider replaced elements when calculating range length in GTK.
  33475. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  33476. (textForRenderer): Ouput the 'object replacement character' for
  33477. replaced objects.
  33478. (getSelectionOffsetsForObject): Consider replaced elements when
  33479. calculating range length in GTK.
  33480. (webkitAccessibleHypertextGetLink): Remove wrong extra check that
  33481. were causing only links to be considered.
  33482. (webkitAccessibleHypertextGetNLinks): Replace wrong 'isLink()'
  33483. check with the right one, by checking that the right ATK interface
  33484. is being implemented by the AtkObject.
  33485. (getInterfaceMaskFromObject): Implement the Hyperlink interface
  33486. both for links and replaced objects.
  33487. (objectAndOffsetUnignored): Consider replaced elements when
  33488. calculating range length in GTK.
  33489. * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
  33490. (getRangeLengthForObject): Ensure spaces are used for replaced
  33491. elements when calling to TextIterator::rangeLength().
  33492. * editing/TextIterator.h: New value in the TextIteratorBehavior
  33493. enumeration (TextIteratorEmitsObjectReplacementCharacters) and new
  33494. private variable to consider that new option internally.
  33495. * editing/TextIterator.cpp:
  33496. (WebCore::TextIterator::TextIterator): Initialize the new private
  33497. attribute m_emitsObjectReplacementCharacters in constructors.
  33498. (WebCore::TextIterator::handleReplacedElement): Emit the 'object
  33499. replacement character' when m_emitsObjectReplacementCharacters.
  33500. 2011-04-11 Jia Pu <jpu@apple.com>
  33501. Reviewed by Adele Peterson.
  33502. Shouldn't carry out autocorrection when start typing a new word
  33503. https://bugs.webkit.org/show_bug.cgi?id=58241
  33504. <rdar://problem/9264736>
  33505. Tests: platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html
  33506. platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
  33507. In TypingCommand::markMisspellingsAfterTyping(), we want to call Editor::markMisspellingsAfterTypingToWord()
  33508. only when the typing command is an insertion command, and preceding word contains at least one non-whitespace
  33509. character.
  33510. * editing/Editor.cpp:
  33511. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  33512. * editing/Editor.h:
  33513. * editing/TypingCommand.cpp:
  33514. (WebCore::TypingCommand::markMisspellingsAfterTyping):
  33515. 2011-04-11 Vsevolod Vlasov <vsevik@chromium.org>
  33516. Reviewed by Pavel Feldman.
  33517. PerformanceTiming returns inconsistent values when timing is null.
  33518. https://bugs.webkit.org/show_bug.cgi?id=58143
  33519. Made PerformanceTiming returned values consistent when there is no timing object.
  33520. * page/PerformanceTiming.cpp:
  33521. (WebCore::PerformanceTiming::domainLookupStart):
  33522. (WebCore::PerformanceTiming::domainLookupEnd):
  33523. (WebCore::PerformanceTiming::connectStart):
  33524. (WebCore::PerformanceTiming::connectEnd):
  33525. (WebCore::PerformanceTiming::requestStart):
  33526. (WebCore::PerformanceTiming::responseStart):
  33527. (WebCore::PerformanceTiming::domLoading):
  33528. 2011-04-05 Stephen White <senorblanco@chromium.org>
  33529. Fix for jittering when animating a rotated image.
  33530. https://bugs.webkit.org/show_bug.cgi?id=50775
  33531. Make GraphicsContext::roundToDevicePixels a no-op on Chrome/Mac.
  33532. * platform/graphics/cg/GraphicsContextCG.cpp:
  33533. (WebCore::GraphicsContext::roundToDevicePixels):
  33534. 2011-04-06 Xiaomei Ji <xji@chromium.org>
  33535. Reviewed by Ryosuke Niwa.
  33536. Continue experiment with moving caret by word in visual order.
  33537. https://bugs.webkit.org/show_bug.cgi?id=57806
  33538. This is the 2nd patch, which adds implementation when caret is inside box
  33539. (not at boundaries). If the word break is inside the same box and not at the boundaries
  33540. either, the word break will be returned. If need to search the adjacent boxes for word
  33541. breaks, then, only the cases implemented in bug 57336 work.
  33542. * editing/visible_units.cpp:
  33543. (WebCore::leftmostPositionInRTLBoxInLTRBlock):
  33544. (WebCore::rightmostPositionInLTRBoxInRTLBlock):
  33545. (WebCore::lastWordBreakInBox):
  33546. (WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
  33547. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
  33548. (WebCore::WordBoundaryEntry::WordBoundaryEntry):
  33549. (WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
  33550. (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
  33551. (WebCore::greatestValueUnder):
  33552. (WebCore::smallestOffsetAbove):
  33553. (WebCore::positionIsInsideBox):
  33554. (WebCore::positionBeforeNextWord):
  33555. (WebCore::positionAfterPreviousWord):
  33556. (WebCore::leftWordPosition):
  33557. (WebCore::rightWordPosition):
  33558. 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
  33559. Reviewed by Chris Fleizach.
  33560. [GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html
  33561. https://bugs.webkit.org/show_bug.cgi?id=58040
  33562. Don't expose objects of role SliderThumbRoles in GTK.
  33563. * accessibility/AccessibilitySlider.cpp:
  33564. (WebCore::AccessibilitySlider::addChildren): Allow the platform
  33565. make a final decision before including children in the hierarchy.
  33566. (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
  33567. Implemented by relying on accessibilityPlatformIncludesObject().
  33568. * accessibility/gtk/AccessibilityObjectAtk.cpp:
  33569. (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
  33570. Ignore accessibility objects with role SliderThumbRole.
  33571. 2011-04-11 Simon Fraser <simon.fraser@apple.com>
  33572. Reviewed by Dan Bernstein.
  33573. Divide by zero in calcColumnWidth
  33574. https://bugs.webkit.org/show_bug.cgi?id=58230
  33575. Test: fast/multicol/huge-column-count.html
  33576. Make sure we have at least one column, to avoid divide by zero.
  33577. * rendering/RenderBlock.cpp:
  33578. (WebCore::RenderBlock::calcColumnWidth):
  33579. 2011-04-09 Gavin Barraclough <barraclough@apple.com>
  33580. Reviewed by Sam Weinig.
  33581. Bug 58198 - Clean up JSValue implementation for JSVALUE64
  33582. JSNumberCell.h has been deprecated.
  33583. * ForwardingHeaders/runtime/JSNumberCell.h: Removed.
  33584. * bindings/scripts/CodeGeneratorJS.pm:
  33585. * bridge/c/c_instance.cpp:
  33586. 2011-04-11 Dan Bernstein <mitz@apple.com>
  33587. Build fix.
  33588. * html/canvas/CanvasRenderingContext2D.cpp:
  33589. (WebCore::CanvasRenderingContext2D::State::State):
  33590. 2011-04-11 Antti Koivisto <antti@apple.com>
  33591. Reviewed by Tony Gentilcore.
  33592. Document source preload scanned repeatedly
  33593. https://bugs.webkit.org/show_bug.cgi?id=58123
  33594. Don't clear the preload scanner after execution resumes. This would lose the current
  33595. scanning point and lead to rescanning when the preload scanner would get reconstructed
  33596. due to main parser blocking again.
  33597. Instead clear the scanner only in the specific case of receiving new data while the main
  33598. parser has already reached the end of the current input.
  33599. Also switched to using isWaitingForScripts() instead of m_treeBuilder->isPaused() for consistency.
  33600. The case the clearing in resumeParsingAfterScriptExecution() was added for is covered by
  33601. http/tests/loading/preload-slow-loading.php.
  33602. * html/parser/HTMLDocumentParser.cpp:
  33603. (WebCore::HTMLDocumentParser::insert):
  33604. (WebCore::HTMLDocumentParser::append):
  33605. (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
  33606. 2011-04-11 Dan Bernstein <mitz@apple.com>
  33607. Build fix.
  33608. * html/canvas/CanvasRenderingContext2D.cpp:
  33609. (WebCore::CanvasRenderingContext2D::State::State):
  33610. 2011-04-11 Dan Bernstein <mitz@apple.com>
  33611. Reviewed by Alexey Proskuryakov.
  33612. Assertion failure in CanvasRenderingContext2D::State::fontsNeedUpdate when invalidating the font cache after opening canvas/philip/tests/initial.reset.2dstate.html (occurs on Qt debug test bot)
  33613. https://bugs.webkit.org/show_bug.cgi?id=58229
  33614. * html/canvas/CanvasRenderingContext2D.cpp:
  33615. (WebCore::CanvasRenderingContext2D::State::State): Added copy constructor, to register the copy with
  33616. the font selector if needed.
  33617. (WebCore::CanvasRenderingContext2D::State::operator=): Added assignment constructor, to handle
  33618. registration with the font selector as needed.
  33619. * html/canvas/CanvasRenderingContext2D.h:
  33620. 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
  33621. Reviewed by Chris Fleizach.
  33622. [GTK] ARIA tables not exposing cells as HTML tables do
  33623. https://bugs.webkit.org/show_bug.cgi?id=57463
  33624. Expose cells for ARIA grids consistently with HTML tables in GTK,
  33625. keeping the same behaviour for the other platforms.
  33626. * accessibility/AccessibilityARIAGrid.cpp:
  33627. (WebCore::AccessibilityARIAGrid::addChild): Add the row's children
  33628. to the accessibility hierarchy when accessibility objects for rows
  33629. are ignoring accessibility, otherwise add the row.
  33630. (WebCore::AccessibilityARIAGrid::addChildren): Do not check at
  33631. this point whether every child of the table ignores or not
  33632. accessibility, letting addChild() make the proper decision later.
  33633. * accessibility/AccessibilityARIAGridCell.cpp:
  33634. (WebCore::AccessibilityARIAGridCell::parentTable): Consider that
  33635. rows could be ignoring accessibility, hence the parent could be
  33636. retrieved in the first call to parentObjectUnignored().
  33637. (WebCore::AccessibilityARIAGridCell::rowIndexRange): Ditto.
  33638. (WebCore::AccessibilityARIAGridCell::columnIndexRange): Ditto..
  33639. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  33640. (atkRole): Map ColumnHeader and RowHeader to ATK_ROLE_TABLE_CELL.
  33641. 2011-04-11 Sergio Villar Senin <svillar@igalia.com>
  33642. Reviewed by Martin Robinson.
  33643. [GTK] Fix make distcheck
  33644. https://bugs.webkit.org/show_bug.cgi?id=58224
  33645. Removed a file that is no longer in the source tree.
  33646. * GNUmakefile.list.am:
  33647. 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
  33648. Reviewed by Martin Robinson.
  33649. REGRESSION(r83397): Most GTK media controls are hidden when no valid source is specified
  33650. https://bugs.webkit.org/show_bug.cgi?id=58204
  33651. Covered by existing tests.
  33652. * platform/gtk/RenderThemeGtk.h:
  33653. (WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor): Let GTK handle
  33654. the the state of media controls.
  33655. 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
  33656. Remove obsolete comment, which was mistakenly landed in r83397.
  33657. Though potentially a work of art, the comment lost its functional meaning a long time ago.
  33658. * html/shadow/MediaControls.cpp:
  33659. (WebCore::MediaControls::create): Removed comment.
  33660. 2011-04-05 Hans Wennborg <hans@chromium.org>
  33661. Reviewed by Steve Block.
  33662. IndexedDB: Introduce skeleton for LevelDB backend
  33663. https://bugs.webkit.org/show_bug.cgi?id=57827
  33664. No new tests: no new functionality (yet).
  33665. * WebCore.gyp/WebCore.gyp:
  33666. Add dependency on leveldb when ENABLE_LEVELDB=1 in feature_defines.
  33667. * WebCore.gypi:
  33668. Add new files.
  33669. * storage/IDBBackingStore.h:
  33670. (WebCore::IDBBackingStore::ObjectStoreRecordIdentifier::~ObjectStoreRecordIdentifier):
  33671. Introduce abstract type ObjectStoreRecordIdentifier. The SQLite
  33672. backend uses integers to refer to a specific row in a table, but
  33673. the LevelDB backend will use something else.
  33674. * storage/IDBDatabaseBackendImpl.cpp:
  33675. (WebCore::IDBDatabaseBackendImpl::createObjectStore):
  33676. (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
  33677. (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
  33678. (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  33679. Change functions to pass along the database id for operations that
  33680. concern object stores. We want to be able to group object stores
  33681. ids per database.
  33682. * storage/IDBFactoryBackendImpl.cpp:
  33683. (WebCore::IDBFactoryBackendImpl::open):
  33684. Decide which backend to use based on the backingStoreType
  33685. parameter.
  33686. * storage/IDBIndexBackendImpl.cpp:
  33687. (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
  33688. (WebCore::IDBIndexBackendImpl::openCursorInternal):
  33689. (WebCore::IDBIndexBackendImpl::getInternal):
  33690. (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  33691. * storage/IDBIndexBackendImpl.h:
  33692. (WebCore::IDBIndexBackendImpl::create):
  33693. Pass database and object store id to backend functions concerning
  33694. indexes.
  33695. * storage/IDBLevelDBBackingStore.cpp: Added.
  33696. (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
  33697. (WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
  33698. (WebCore::IDBLevelDBBackingStore::open):
  33699. (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
  33700. (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
  33701. (WebCore::IDBLevelDBBackingStore::getObjectStores):
  33702. (WebCore::IDBLevelDBBackingStore::createObjectStore):
  33703. (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
  33704. (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
  33705. (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
  33706. (WebCore::IDBLevelDBBackingStore::clearObjectStore):
  33707. (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
  33708. (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
  33709. (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
  33710. (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
  33711. (WebCore::IDBLevelDBBackingStore::getIndexes):
  33712. (WebCore::IDBLevelDBBackingStore::createIndex):
  33713. (WebCore::IDBLevelDBBackingStore::deleteIndex):
  33714. (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
  33715. (WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
  33716. (WebCore::IDBLevelDBBackingStore::getObjectViaIndex):
  33717. (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
  33718. (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
  33719. (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
  33720. (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
  33721. (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  33722. (WebCore::IDBLevelDBBackingStore::createTransaction):
  33723. * storage/IDBLevelDBBackingStore.h: Added.
  33724. Add an empty implementation of the LevelDB backend.
  33725. * storage/IDBObjectStoreBackendImpl.cpp:
  33726. Keep track of database id, use the new RecordIdentifier.
  33727. (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
  33728. (WebCore::IDBObjectStoreBackendImpl::getInternal):
  33729. (WebCore::IDBObjectStoreBackendImpl::putInternal):
  33730. (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
  33731. (WebCore::IDBObjectStoreBackendImpl::clearInternal):
  33732. (WebCore::populateIndex):
  33733. (WebCore::IDBObjectStoreBackendImpl::createIndex):
  33734. (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
  33735. (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
  33736. (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  33737. (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
  33738. (WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
  33739. * storage/IDBObjectStoreBackendImpl.h:
  33740. (WebCore::IDBObjectStoreBackendImpl::create):
  33741. (WebCore::IDBObjectStoreBackendImpl::databaseId):
  33742. * storage/IDBSQLiteBackingStore.cpp:
  33743. (WebCore::IDBSQLiteBackingStore::open):
  33744. (WebCore::IDBSQLiteBackingStore::createObjectStore):
  33745. (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
  33746. (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
  33747. (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
  33748. (WebCore::IDBSQLiteBackingStore::clearObjectStore):
  33749. (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
  33750. (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
  33751. (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
  33752. (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
  33753. (WebCore::IDBSQLiteBackingStore::getIndexes):
  33754. (WebCore::IDBSQLiteBackingStore::createIndex):
  33755. (WebCore::IDBSQLiteBackingStore::deleteIndex):
  33756. (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
  33757. (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
  33758. (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
  33759. (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
  33760. (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
  33761. (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
  33762. (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
  33763. (WebCore::IDBSQLiteBackingStore::openIndexCursor):
  33764. * storage/IDBSQLiteBackingStore.h:
  33765. 2011-04-11 Alexander Pavlov <apavlov@chromium.org>
  33766. Reviewed by Yury Semikhatsky.
  33767. Web Inspector: Duplicate CSS properties are reported for non-lowercase property names in the Styles sidebar
  33768. https://bugs.webkit.org/show_bug.cgi?id=58226
  33769. * inspector/InspectorStyleSheet.cpp:
  33770. (WebCore::InspectorStyle::populateAllProperties):
  33771. 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
  33772. Reviewed by Pavel Feldman.
  33773. Web Inspector: get rid of source frame delegates for resources panel.
  33774. https://bugs.webkit.org/show_bug.cgi?id=58041
  33775. Use TextViewer configured with a domain-specific delegate to show/edit resource contents in resources panel.
  33776. * inspector/front-end/ResourceView.js:
  33777. (WebInspector.ResourceView.createResourceView):
  33778. (WebInspector.ResourceView.resourceViewTypeMatchesResource):
  33779. (WebInspector.ResourceSourceFrame):
  33780. (WebInspector.ResourceSourceFrame.prototype.get resource):
  33781. (WebInspector.ResourceSourceFrame.prototype.contentEditable):
  33782. (WebInspector.ResourceSourceFrame.prototype._requestContent):
  33783. (WebInspector.CSSSourceFrame):
  33784. (WebInspector.CSSSourceFrame.prototype.contentEditable):
  33785. (WebInspector.CSSSourceFrame.prototype._editContent):
  33786. (WebInspector.CSSSourceFrame.prototype._editContent.handleInfos):
  33787. (WebInspector.CSSSourceFrame.prototype._saveStyleSheet):
  33788. * inspector/front-end/SourceFrame.js:
  33789. (WebInspector.SourceFrame.prototype._ensureContentLoaded):
  33790. (WebInspector.SourceFrame.prototype._requestContent):
  33791. (WebInspector.SourceFrame.prototype._handleSave):
  33792. (WebInspector.SourceFrame.prototype._editContent):
  33793. 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
  33794. Reviewed by Andreas Kling.
  33795. [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
  33796. https://bugs.webkit.org/show_bug.cgi?id=58076
  33797. State_Sunken is more generic than pressed. It is used by items such as frames or
  33798. line edits because they are "sunken" frames (e.g. QLineEdit). It can be required
  33799. by some style like Oxygen. Therefore only in the mobile theme we check if the object
  33800. is pressed.
  33801. * platform/qt/RenderThemeQt.cpp:
  33802. (WebCore::RenderThemeQt::paintTextField):
  33803. 2011-04-11 Pavel Feldman <pfeldman@chromium.org>
  33804. Reviewed by Yury Semikhatsky.
  33805. Web Inspector: add support for optional output parameters.
  33806. https://bugs.webkit.org/show_bug.cgi?id=58207
  33807. Output parameters such as "redirectResponse" are optional, but
  33808. do not allow specifying them as such.
  33809. * inspector/CodeGeneratorInspector.pm:
  33810. * inspector/Inspector.json:
  33811. * inspector/InspectorResourceAgent.cpp:
  33812. (WebCore::buildObjectForResourceResponse):
  33813. (WebCore::buildObjectForCachedResource):
  33814. * inspector/front-end/NetworkManager.js:
  33815. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  33816. * inspector/generate-inspector-idl:
  33817. 2011-04-11 Pavel Feldman <pfeldman@chromium.org>
  33818. Reviewed by Yury Semikhatsky.
  33819. Web Inspector: refactor / document call frames in debugger domain.
  33820. https://bugs.webkit.org/show_bug.cgi?id=58187
  33821. Note that we are not special casing with(element) and with(document) anymore
  33822. and do not tell user that it is "Event target" and "Event document". Strictly speaking,
  33823. we should not have done it for with(element) not necessarily being related to an event.
  33824. * English.lproj/localizedStrings.js:
  33825. * inspector/InjectedScriptSource.js:
  33826. * inspector/Inspector.json:
  33827. * inspector/front-end/ScopeChainSidebarPane.js:
  33828. (WebInspector.ScopeChainSidebarPane.prototype.update):
  33829. 2011-04-10 ChangSeok Oh <shivamidow@gmail.com>
  33830. Reviewed by Eric Seidel.
  33831. Make correspondence of file name related with event to other port.
  33832. https://bugs.webkit.org/show_bug.cgi?id=57416
  33833. Some file names are changed to make correspondence naming rule.
  33834. Keyboard, mouse and wheel event file names for GTK port have been different from other ports.
  33835. This has made user hard to find a specific file related with event for GTK port.
  33836. No test required. This patch just changes some file names.
  33837. * GNUmakefile.list.am:
  33838. * platform/gtk/KeyEventGtk.cpp: Removed.
  33839. * platform/gtk/MouseEventGtk.cpp: Removed.
  33840. * platform/gtk/PlatformKeyboardEventGtk.cpp: Added.
  33841. * platform/gtk/PlatformMouseEventGtk.cpp: Added.
  33842. * platform/gtk/PlatformWheelEventGtk.cpp: Added.
  33843. * platform/gtk/WheelEventGtk.cpp: Removed.
  33844. 2011-04-10 Simon Fraser <simon.fraser@apple.com>
  33845. Revert the FloatRect.cpp part of r83422, since
  33846. clampToInteger() is broken for some inputs. I filed
  33847. https://bugs.webkit.org/show_bug.cgi?id=58216
  33848. * platform/graphics/FloatRect.cpp:
  33849. (WebCore::safeFloatToInt):
  33850. (WebCore::enclosingIntRect):
  33851. 2011-04-10 Simon Fraser <simon.fraser@apple.com>
  33852. Reviewed by Maciej Stachowiak.
  33853. Car model dropdowns at audiusa.com lay out incorrectly with compositing enabled
  33854. https://bugs.webkit.org/show_bug.cgi?id=56660
  33855. When overflow on an element changes, we need to inform compositing
  33856. layers which create and position an "ancestor clipping" layer based
  33857. on that overflow. Do this by triggering a rebuild of compositing layers
  33858. when overflow changes on a layer whose stacking context has compositing
  33859. descendants. (We can't just check whether the layer itself has compositing
  33860. descendants, because overflow follows the render tree, but compositing
  33861. follows the z-order tree.)
  33862. Test: compositing/geometry/ancestor-overflow-change.html
  33863. * rendering/RenderLayer.cpp:
  33864. (WebCore::RenderLayer::styleChanged):
  33865. * rendering/RenderLayer.h:
  33866. * rendering/RenderLayerBacking.cpp:
  33867. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  33868. 2011-04-10 Simon Fraser <simon.fraser@apple.com>
  33869. Reviewed by Ariya Hidayat.
  33870. Allow ShadowBlur to re-use the last buffer if it already contains the correct shadow
  33871. https://bugs.webkit.org/show_bug.cgi?id=58161
  33872. ShadowBlur already has a singleton scratch buffer that is re-used
  33873. between shadows. Enhance use of this scratch buffer to avoid drawing
  33874. and blurring the shadow if the results will match what is already
  33875. in the buffer.
  33876. Cleaned up ShadowBlur code to remove beginShadowLayer() and endShadowLayer(),
  33877. which ended up with little reusable code after adding the re-use logic.
  33878. * platform/graphics/FloatRect.cpp:
  33879. (WebCore::enclosingIntRect): Replace safeFloatToInt() with the existing
  33880. clampToInteger() from MathExtras.h
  33881. * platform/graphics/FloatSize.h:
  33882. (WebCore::expandedIntSize): New method to safely ceil() the size.
  33883. * platform/graphics/RoundedIntRect.h:
  33884. Add operator== for Radii and RoundedIntRect.
  33885. * platform/graphics/ShadowBlur.cpp:
  33886. (WebCore::ScratchBuffer::ScratchBuffer):
  33887. (WebCore::ScratchBuffer::setLastShadowValues):
  33888. (WebCore::ScratchBuffer::setLastInsetShadowValues):
  33889. (WebCore::ScratchBuffer::matchesLastShadow):
  33890. (WebCore::ScratchBuffer::matchesLastInsetShadow):
  33891. (WebCore::ScratchBuffer::clearScratchBuffer):
  33892. Have the scratch buffer remember what shadow parameters were used
  33893. to render the buffer contents.
  33894. (WebCore::ShadowBlur::drawShadowBuffer):
  33895. Renamed from endShadowLayer(), and only contains the drawing
  33896. logic now.
  33897. (WebCore::ShadowBlur::drawRectShadow):
  33898. Promote some code from beginShadowLayer().
  33899. (WebCore::ShadowBlur::drawInsetShadow):
  33900. Promote some code from beginShadowLayer().
  33901. (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
  33902. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
  33903. (WebCore::ShadowBlur::drawInsetShadowWithTiling):
  33904. (WebCore::ShadowBlur::drawRectShadowWithTiling):
  33905. These methods now check to see if the buffer already matches
  33906. their required parameters, and avoid work if it does.
  33907. (WebCore::ShadowBlur::blurShadowBuffer):
  33908. Factored some code into this new method.
  33909. (WebCore::ShadowBlur::blurAndColorShadowBuffer):
  33910. Minor refactoring.
  33911. * platform/graphics/ShadowBlur.h:
  33912. 2011-04-10 Geoffrey Garen <ggaren@apple.com>
  33913. Build fix: Updated for file move.
  33914. * bindings/js/GCController.cpp:
  33915. * bindings/js/ScriptGCEvent.cpp:
  33916. 2011-04-10 Geoffrey Garen <ggaren@apple.com>
  33917. Rubber-stamped by Beth Dakin.
  33918. Moved Heap.h and Heap.cpp to the heap folder, because anything less
  33919. would be uncivilized.
  33920. * ForwardingHeaders/heap/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Heap.h.
  33921. * ForwardingHeaders/runtime/Heap.h: Removed.
  33922. 2011-04-10 Luke Macpherson <macpherson@chromium.org>
  33923. Reviewed by Simon Fraser.
  33924. Rename CSSStyleApplyProperty::inherit,initial,value applyInheritValue,applyInitialValue,applyValue
  33925. https://bugs.webkit.org/show_bug.cgi?id=58212
  33926. No new tests - function renaming only / no functionality changes.
  33927. * css/CSSStyleApplyProperty.cpp:
  33928. Rename all instances of inherit, initial and value.
  33929. * css/CSSStyleApplyProperty.h:
  33930. Rename all instances of inherit, initial and value.
  33931. * css/CSSStyleSelector.cpp:
  33932. Rename all instances of inherit, initial and value.
  33933. 2011-04-10 Mike Lawther <mikelawther@chromium.org>
  33934. Reviewed by Ojan Vafai.
  33935. flex/bison tokens and grammar for CSS calc
  33936. https://bugs.webkit.org/show_bug.cgi?id=54412
  33937. Tests: css3/calc/calc-errors.html
  33938. css3/calc/lexer-regression-57581-2.html
  33939. css3/calc/lexer-regression-57581-3.html
  33940. css3/calc/lexer-regression-57581.html
  33941. css3/calc/minmax-errors.html
  33942. css3/calc/nested-rounded-corners.html
  33943. css3/calc/simple-calcs.html
  33944. css3/calc/simple-minmax.html
  33945. * css/CSSGrammar.y:
  33946. * css/CSSParserValues.cpp:
  33947. (WebCore::CSSParserValueList::insertValueAt):
  33948. (WebCore::CSSParserValueList::extend):
  33949. * css/CSSParserValues.h:
  33950. * css/tokenizer.flex:
  33951. 2011-04-10 Alice Boxhall <aboxhall@chromium.org>
  33952. Reviewed by Ryosuke Niwa.
  33953. Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.
  33954. https://bugs.webkit.org/show_bug.cgi?id=57923
  33955. Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult
  33956. rather than a Node* and an IntPoint&, as the selection may actually not
  33957. extend into the Node found by the HitTest.
  33958. No new tests. Refactoring only.
  33959. * page/EventHandler.cpp:
  33960. (WebCore::EventHandler::handleMouseDraggedEvent):
  33961. (WebCore::EventHandler::updateSelectionForMouseDrag):
  33962. * page/EventHandler.h:
  33963. 2011-04-10 Kent Tamura <tkent@chromium.org>
  33964. Unreviewed, rolling out r83353.
  33965. http://trac.webkit.org/changeset/83353
  33966. https://bugs.webkit.org/show_bug.cgi?id=58106
  33967. The new test doesn't pass on all Chromium platforms.
  33968. * dom/DataTransferItem.h:
  33969. * dom/DataTransferItem.idl:
  33970. * platform/chromium/ClipboardMimeTypes.cpp:
  33971. * platform/chromium/ClipboardMimeTypes.h:
  33972. * platform/chromium/DataTransferItemChromium.cpp:
  33973. (WebCore::DataTransferItemChromium::getAsString):
  33974. * platform/chromium/DataTransferItemChromium.h:
  33975. * platform/chromium/PlatformBridge.h:
  33976. 2011-04-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  33977. Reviewed by Eric Carlson.
  33978. [EFL] Add seek forward / backward buttons to MediaControl UI.
  33979. https://bugs.webkit.org/show_bug.cgi?id=56810
  33980. Add seek forward / backward buttons to media control. And, change formType name
  33981. for media control.
  33982. * platform/efl/RenderThemeEfl.cpp:
  33983. (WebCore::RenderThemeEfl::edjeGroupFromFormType):
  33984. (WebCore::RenderThemeEfl::emitMediaButtonSignal):
  33985. (WebCore::RenderThemeEfl::paintMediaMuteButton):
  33986. (WebCore::RenderThemeEfl::paintMediaPlayButton):
  33987. (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
  33988. (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
  33989. * platform/efl/RenderThemeEfl.h:
  33990. 2011-04-10 Chris Guillory <chris.guillory@google.com>
  33991. Reviewed by Eric Seidel.
  33992. Remove unused function declaration in PlatformContextSkia.h.
  33993. https://bugs.webkit.org/show_bug.cgi?id=55983
  33994. * platform/graphics/skia/PlatformContextSkia.h:
  33995. 2011-04-10 Patrick Gansterer <paroga@webkit.org>
  33996. Unreviewed build fix for !ENABLE(XSLT) after r82562.
  33997. * dom/XMLDocumentParserLibxml2.cpp:
  33998. (WebCore::XMLDocumentParser::doEnd):
  33999. 2011-04-10 Patrick Gansterer <paroga@webkit.org>
  34000. Unreviewed build fix for !ENABLE(XSLT) after r82562.
  34001. * xml/XMLTreeViewer.cpp: Readded #if ENABLE(XSLT).
  34002. 2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
  34003. Reviewed by Anders Carlsson.
  34004. REGRESSION(r83256): Text-decoration bleeds into shadow DOM
  34005. https://bugs.webkit.org/show_bug.cgi?id=58205
  34006. Now that the shadow root is a never-styled element, we need to walk to
  34007. parent to find out if we're inside of a shadow DOM subtree.
  34008. Test: media/controls-styling.html
  34009. * css/CSSStyleSelector.cpp:
  34010. (WebCore::isAtShadowBoundary): Added helper function.
  34011. (WebCore::CSSStyleSelector::adjustRenderStyle): Changed to use the helper.
  34012. 2011-04-07 Dimitri Glazkov <dglazkov@chromium.org>
  34013. Reviewed by Eric Carlson.
  34014. [Meta] Convert HTMLMediaElement to use the new shadow DOM
  34015. https://bugs.webkit.org/show_bug.cgi?id=53020
  34016. This conversion is non-trivial, for several reasons:
  34017. 1) Since HTMLMediaElement now hosts the shadow DOM for controls, hiding
  34018. and showing controls does not result in destroying and re-creating the
  34019. shadow DOM tree. Instead, the tree is created as needed and shown/hidden
  34020. using inline styles.
  34021. 2) Instead of detaching/attaching on each style change, the control parts
  34022. are now using a set of higher fidelity callbacks that notify MediaControls
  34023. about changes to which it should react. Each reaction results in hiding,
  34024. showing, or changing the state of the control parts using inline styles
  34025. and DOM APIs.
  34026. 3) Hiding and showing controls is accomplished using inline styles, rather
  34027. than wiring rendererIsNeeded, because renderers are now re-created less
  34028. frequently.
  34029. 4) Instead of constantly querying RenderTheme about visibility of a particular
  34030. control part, we let the theme determine which parts are supported and
  34031. which parts are visible in certain conditions.
  34032. 5) Custom hit-testing, event forwarding, and style updates are completely
  34033. removed, since they are now unnecessary.
  34034. 6) Fading controls in/out is now done as CSS animation, since shadow DOM
  34035. supports it.
  34036. Test: manual-tests/media-controls.html
  34037. 2011-04-09 Dan Bernstein <mitz@apple.com>
  34038. Reviewed by Beth Dakin.
  34039. <rdar://problem/9215280> Detached canvas draws with incorrect font
  34040. Test: fast/canvas/font-update.html
  34041. The existing mechanism for updating the font in a canvas 2D context was lacking in at least
  34042. two ways: it neglected to update fonts in all but the topmost state in the stack, and since it
  34043. was based on HTMLCanvasElemen's attach() and recalcStyle(), it did not work when the element
  34044. was not attached.
  34045. This change takes the responsibility for font updates away from the canvas element and gives it
  34046. to the canvas context and its graphics state.
  34047. * css/CSSFontSelector.cpp:
  34048. (WebCore::CSSFontSelector::registerForInvalidationCallbacks): Added. Adds to the set of registered
  34049. font selector clients.
  34050. (WebCore::CSSFontSelector::unregisterForInvalidationCallbacks): Added. Removes from the set of
  34051. registered font selector clients.
  34052. (WebCore::CSSFontSelector::dispatchInvalidationCallbacks): Calls fontsNeedUpdate() on all registered
  34053. clients and forces a style recalc on the document.
  34054. (WebCore::CSSFontSelector::fontLoaded): Changed to call dispatchInvalidationCallbacks().
  34055. (WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.
  34056. * css/CSSFontSelector.h:
  34057. * html/HTMLCanvasElement.cpp: Removed overrides of attach() and recalcStyle().
  34058. * html/HTMLCanvasElement.h:
  34059. * html/canvas/CanvasRenderingContext2D.cpp:
  34060. (WebCore::CanvasRenderingContext2D::State::~State): Added. Unregisters with the font selector.
  34061. (WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Added. Called by the font selector
  34062. when its fonts need to be updated. Updates the font.
  34063. (WebCore::CanvasRenderingContext2D::setFont): Registers the state with the font selector.
  34064. * html/canvas/CanvasRenderingContext2D.h:
  34065. * platform/graphics/FontSelector.h:
  34066. (WebCore::FontSelectorClient::~FontSelectorClient):
  34067. 2011-04-09 Geoffrey Garen <ggaren@apple.com>
  34068. Not reviewed.
  34069. Try recommitting some things svn left out of my last commit.
  34070. * bridge/qt/qt_runtime.h:
  34071. 2011-04-09 Geoffrey Garen <ggaren@apple.com>
  34072. Not reviewed.
  34073. Try recommitting some things svn left out of my last commit.
  34074. * ForwardingHeaders/collector: Removed.
  34075. * ForwardingHeaders/collector/handles: Removed.
  34076. * ForwardingHeaders/collector/handles/Global.h: Removed.
  34077. 2011-04-08 Dimitri Glazkov <dglazkov@chromium.org>
  34078. Reviewed by Ojan Vafai.
  34079. Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
  34080. https://bugs.webkit.org/show_bug.cgi?id=55515
  34081. This implements XBL 2.0's specified handling of mouseover/mouseout events:
  34082. http://dev.w3.org/2006/xbl2/Overview.html#the-mouseover-and-mouseout-events
  34083. To do this, we:
  34084. 1) calculate lowest common ancestor between relatedTarget and target, and
  34085. the nearest boundaries around them: the outer (common) boundary, and the
  34086. inner (specific to relatedTarget) boundary. Then, we
  34087. 2) ensure that events only propagate up to the common boundary (or
  34088. all the way if boundary is not found), while
  34089. 3) updating relatedTarget be the inner boundary.
  34090. We also detect the most common case when no common boundary could exist
  34091. and provide a fast path to short-circuit most of the boundary detection
  34092. logic.
  34093. Test: fast/events/shadow-boundary-crossing.html
  34094. * dom/EventDispatcher.cpp:
  34095. (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a helper to determine lowest
  34096. common ancestor, the boundaries around it, and compute adjustments
  34097. to relatedTarget and event target ancestor chain.
  34098. (WebCore::ancestorsCrossShadowBoundaries): Added.
  34099. (WebCore::EventDispatcher::adjustRelatedTarget): Changed to calculate
  34100. inner/outer shadow DOM boundaries and adjust ancestors chain accordingly.
  34101. (WebCore::EventDispatcher::EventDispatcher): Added flag initializer
  34102. (WebCore::EventDispatcher::ensureEventAncestors): Renamed from getEventAncestors,
  34103. converted to use initialization flag, rather than testing for empty.
  34104. * dom/EventDispatcher.h: Adjusted decls.
  34105. * dom/MouseEvent.cpp:
  34106. (WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to send event
  34107. to adjustRelatedTarget.
  34108. 2011-04-08 Geoffrey Garen <ggaren@apple.com>
  34109. Reviewed by Oliver Hunt.
  34110. A few heap-related renames and file moves.
  34111. WeakGCPtr<T> => Weak<T>
  34112. Global<T> => Strong<T>
  34113. collector/ => heap/
  34114. collector/* => heap/*
  34115. runtime/WeakGCPtr.h => heap/Weak.h
  34116. (Eventually, even more files should move into the heap directory. Like
  34117. Heap.h and Heap.cpp, for example.)
  34118. * CMakeLists.txt:
  34119. * ForwardingHeaders/collector: Removed.
  34120. * ForwardingHeaders/heap: Copied from ForwardingHeaders/collector.
  34121. * ForwardingHeaders/heap/Strong.h: Copied from ForwardingHeaders/collector/handles/Global.h.
  34122. * ForwardingHeaders/heap/Weak.h: Copied from ForwardingHeaders/runtime/WeakGCPtr.h.
  34123. * ForwardingHeaders/runtime/WeakGCPtr.h: Removed.
  34124. * WebCore.vcproj/WebCore.vcproj:
  34125. * WebCore.vcproj/copyForwardingHeaders.cmd:
  34126. * bindings/js/JSCallbackData.h:
  34127. * bindings/js/JSCustomVoidCallback.h:
  34128. * bindings/js/JSDOMWindowBase.h:
  34129. * bindings/js/JSDOMWindowShell.cpp:
  34130. (WebCore::JSDOMWindowShell::setWindow):
  34131. * bindings/js/JSDataGridDataSource.h:
  34132. * bindings/js/JSEventListener.h:
  34133. * bindings/js/ScheduledAction.cpp:
  34134. (WebCore::ScheduledAction::ScheduledAction):
  34135. * bindings/js/ScheduledAction.h:
  34136. * bindings/js/ScriptCachedFrameData.cpp:
  34137. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
  34138. * bindings/js/ScriptCachedFrameData.h:
  34139. * bindings/js/ScriptController.cpp:
  34140. (WebCore::ScriptController::createWindowShell):
  34141. * bindings/js/ScriptController.h:
  34142. * bindings/js/ScriptObject.h:
  34143. * bindings/js/ScriptState.h:
  34144. * bindings/js/ScriptValue.cpp:
  34145. * bindings/js/ScriptValue.h:
  34146. * bindings/js/ScriptWrappable.h:
  34147. * bindings/js/WorkerScriptController.cpp:
  34148. (WebCore::WorkerScriptController::initScript):
  34149. * bindings/js/WorkerScriptController.h:
  34150. * bridge/jsc/BridgeJSC.h:
  34151. * bridge/qt/qt_runtime.h:
  34152. * bridge/runtime_root.h:
  34153. * xml/XMLHttpRequest.cpp:
  34154. 2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
  34155. Reviewed by Laszlo Gombos.
  34156. [Qt] Don't link against fontconfig or X11 if embedded
  34157. https://bugs.webkit.org/show_bug.cgi?id=58104
  34158. No functional change so no new tests.
  34159. * WebCore.pri: qpa=>embedded should be done very early so all cases of embedded are uniform.
  34160. 2011-04-09 Csaba Osztrogonác <ossy@webkit.org>
  34161. [Qt] Unreviewed trivial fix after r83344.
  34162. * WebCore.pro: Update HEADERS list.
  34163. 2011-04-09 Jon Lee <jonlee@apple.com>
  34164. Reviewed by Beth Dakin.
  34165. Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
  34166. https://bugs.webkit.org/show_bug.cgi?id=58180
  34167. <rdar://problem/9047984>
  34168. * platform/mac/ScrollAnimatorMac.mm:
  34169. (WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting
  34170. (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
  34171. (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
  34172. 2011-04-09 Sreeram Ramachandran <sreeram@google.com>
  34173. Reviewed by Ryosuke Niwa.
  34174. Gather data on modal dialogs shown during unload events
  34175. https://bugs.webkit.org/show_bug.cgi?id=58115
  34176. Add a new method to the ChromeClient API to allow clients to receive
  34177. notifications of modal dialogs dispatched during page dismissal events.
  34178. The new method has a default empty definition; only chromium overrides
  34179. it to keep track of histograms.
  34180. No tests because this is a no-op for all ports except chromium (and it's
  34181. not clear how to test chromium histograms from webkit).
  34182. * page/Chrome.cpp:
  34183. (WebCore::isDuringPageDismissal):
  34184. (WebCore::willRunModalDialog):
  34185. (WebCore::Chrome::runJavaScriptAlert):
  34186. (WebCore::Chrome::runJavaScriptConfirm):
  34187. (WebCore::Chrome::runJavaScriptPrompt):
  34188. (WebCore::Chrome::willRunModalHTMLDialog):
  34189. * page/Chrome.h:
  34190. * page/ChromeClient.h:
  34191. (WebCore::ChromeClient::willRunModalDialogDuringPageDismissal):
  34192. * page/DOMWindow.cpp:
  34193. (WebCore::DOMWindow::showModalDialog):
  34194. 2011-04-08 David Humphrey <david.humphrey@senecac.on.ca>
  34195. Reviewed by Eric Carlson.
  34196. Fix call order of media element muted and play(), such that setting muted before play() works.
  34197. https://bugs.webkit.org/show_bug.cgi?id=57673
  34198. https://code.google.com/p/chromium/issues/detail?id=70777
  34199. Manual test added: manual-tests/media-muted.html
  34200. * html/HTMLMediaElement.cpp:
  34201. (WebCore::HTMLMediaElement::updatePlayState):
  34202. * manual-tests/media-muted.html: Added.
  34203. 2011-04-08 Nat Duca <nduca@chromium.org>
  34204. Reviewed by David Levin.
  34205. [chromium] Fix windows assertion on ~CCThread
  34206. https://bugs.webkit.org/show_bug.cgi?id=58153
  34207. Because ~CCThread uses waitForThreadCompletion,
  34208. calling detachThread is not necessary.
  34209. * platform/graphics/chromium/cc/CCThread.cpp:
  34210. (WebCore::CCThread::runLoop):
  34211. 2011-04-08 Jian Li <jianli@chromium.org>
  34212. Unreviewed, rolling out r83348.
  34213. http://trac.webkit.org/changeset/83348
  34214. https://bugs.webkit.org/show_bug.cgi?id=49508
  34215. Breaks layout tests in QT, Win7 and Chromium.
  34216. * rendering/RenderText.cpp:
  34217. (WebCore::RenderText::localCaretRect):
  34218. 2011-04-08 MORITA Hajime <morrita@google.com>
  34219. Reviewed by Simon Fraser.
  34220. Negative spread should not make a sharp corner rounded
  34221. https://bugs.webkit.org/show_bug.cgi?id=58162
  34222. Handled inset shadow path for rounded and non-rounded rect
  34223. differently as normal shadow path is doing.
  34224. * rendering/RenderBoxModelObject.cpp:
  34225. (WebCore::RenderBoxModelObject::paintBoxShadow):
  34226. 2011-04-07 Simon Fraser <simon.fraser@apple.com>
  34227. Reviewed by Martin Robinson.
  34228. REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
  34229. https://bugs.webkit.org/show_bug.cgi?id=55180
  34230. The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
  34231. data we get back from ImageBuffer::getImageData() do not vary in
  34232. endianness.
  34233. * platform/graphics/ShadowBlur.cpp:
  34234. (WebCore::ShadowBlur::blurLayerImage):
  34235. 2011-04-08 Erik Arvidsson <arv@chromium.org>
  34236. Reviewed by Dimitri Glazkov.
  34237. IFrame is getting the focus even though it is hidden
  34238. https://bugs.webkit.org/show_bug.cgi?id=55861
  34239. Test: fast/dom/hidden-iframe-no-focus.html
  34240. * html/HTMLFrameOwnerElement.cpp:
  34241. (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
  34242. * html/HTMLFrameOwnerElement.h:
  34243. 2011-04-08 Jeff Timanus <twiz@chromium.org>
  34244. Reviewed by Kenneth Russell.
  34245. Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
  34246. https://bugs.webkit.org/show_bug.cgi?id=57768
  34247. * html/canvas/CanvasRenderingContext2D.cpp:
  34248. (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
  34249. (WebCore::CanvasRenderingContext2D::reset):
  34250. * platform/graphics/gpu/DrawingBuffer.cpp:
  34251. (WebCore::DrawingBuffer::reset):
  34252. * platform/graphics/gpu/DrawingBuffer.h:
  34253. 2011-04-08 Daniel Cheng <dcheng@chromium.org>
  34254. Reviewed by Dmitry Titov.
  34255. [chromium] Implement image/png support in DataTransferItems
  34256. https://bugs.webkit.org/show_bug.cgi?id=58106
  34257. This patch implements DataTransferItem::getAsFile() using Blobs. In
  34258. addition, plumbing for image/png has been added so image paste will be
  34259. supported as long as the renderer makes that data available.
  34260. Tests: editing/pasteboard/data-transfer-items-image-png.html
  34261. * dom/DataTransferItem.h:
  34262. * dom/DataTransferItem.idl:
  34263. * platform/chromium/ClipboardMimeTypes.cpp:
  34264. * platform/chromium/ClipboardMimeTypes.h:
  34265. * platform/chromium/DataTransferItemChromium.cpp:
  34266. (WebCore::DataTransferItemChromium::getAsString):
  34267. (WebCore::DataTransferItemChromium::getAsFile):
  34268. * platform/chromium/DataTransferItemChromium.h:
  34269. * platform/chromium/PlatformBridge.h:
  34270. 2011-04-08 MORITA Hajime <morrita@google.com>
  34271. Unreviewed windows build fix.
  34272. * editing/SpellingCorrectionController.h:
  34273. (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  34274. 2011-04-08 Enrica Casucci <enrica@apple.com>
  34275. Reviewed by Maciej Stachowiak.
  34276. Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
  34277. https://bugs.webkit.org/show_bug.cgi?id=57595
  34278. <rdar://problem/9222122>
  34279. Test: editing/style/bold-with-dom-changes.html
  34280. * editing/ReplaceNodeWithSpanCommand.cpp:
  34281. (WebCore::swapInNodePreservingAttributesAndChildren):
  34282. 2011-04-07 Roland Steiner <rolandsteiner@chromium.org>
  34283. Reviewed by Dimitri Glazkov.
  34284. Bug 58060 - Prepare access to TreeScope from Node, using NodeRareData
  34285. https://bugs.webkit.org/show_bug.cgi?id=58060
  34286. Add a TreeScope pointer to NodeRareData to allow direct access to the containing tree scope.
  34287. However, in case the containing scope is the document, this is not set, and the
  34288. document pointer within Node is used instead.
  34289. In an object derived from TreeScope (currently Document), the tree scope pointer
  34290. points to itself. Such objects also contain a parent tree scope pointer that
  34291. points to the containing scope. For Document, this is 0.
  34292. Add new functions setTreeScope[Recursively] that replace setDocument[Recursively]
  34293. in public usage. setDocument[Recursively] are now only used internally and are
  34294. thererfore protected.
  34295. No new tests. (no new functionality)
  34296. * dom/ContainerNode.cpp: change DOM manipulation methods to update scope of inserted nodes
  34297. (WebCore::ContainerNode::insertBefore):
  34298. (WebCore::ContainerNode::replaceChild):
  34299. (WebCore::ContainerNode::appendChild):
  34300. * dom/Document.cpp:
  34301. (WebCore::Document::~Document):
  34302. (WebCore::Document::setDocType): Ditto
  34303. (WebCore::Document::adoptNode): Ditto
  34304. * dom/Document.h:
  34305. * dom/Node.cpp:
  34306. (WebCore::Node::treeScope): use NodeRareData to check if a non-Document scope is set
  34307. (WebCore::Node::setTreeScope): update NodeRareData depending on whether scope is a document
  34308. (WebCore::Node::setTreeScopeRecursively):
  34309. (WebCore::Node::setDocumentRecursively):
  34310. * dom/Node.h:
  34311. * dom/NodeRareData.h: add scope pointer
  34312. (WebCore::NodeRareData::NodeRareData):
  34313. (WebCore::NodeRareData::treeScope):
  34314. (WebCore::NodeRareData::setTreeScope):
  34315. * dom/TreeScope.cpp: add parentTreeScope pointer
  34316. (WebCore::TreeScope::TreeScope):
  34317. (WebCore::TreeScope::setParentTreeScope):
  34318. * dom/TreeScope.h:
  34319. (WebCore::TreeScope::parentTreeScope):
  34320. 2011-04-08 Xiaomei Ji <xji@chromium.org>
  34321. Reviewed by David Hyatt.
  34322. Local caret rectangle calculation should be relative to its containing block.
  34323. https://bugs.webkit.org/show_bug.cgi?id=49508.
  34324. InlineBox and caret rectangle are positioned relative to its containing block.
  34325. So its left and right edge value should be relative to its containing block as well.
  34326. Test: fast/forms/cursor-at-editable-content-boundary.html
  34327. * rendering/RenderText.cpp:
  34328. (WebCore::RenderText::localCaretRect):
  34329. 2011-04-08 MORITA Hajime <morrita@google.com>
  34330. Unreviewed build fix.
  34331. * editing/Editor.cpp:
  34332. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  34333. 2011-04-08 David Hyatt <hyatt@apple.com>
  34334. Reviewed by Simon Fraser.
  34335. https://bugs.webkit.org/show_bug.cgi?id=57971
  34336. Rework visited/unvisited links for before/after content. Propagate the bits earlier so that we don't lose
  34337. them when we throw away the visited style. Don't throw away the visited link style for pseudo elements
  34338. either, so that the styles are consistent.
  34339. Added fast/history/visited-generated-content-test.html
  34340. * css/CSSStyleSelector.cpp:
  34341. (WebCore::CSSStyleSelector::styleForElement):
  34342. (WebCore::CSSStyleSelector::pseudoStyleForElement):
  34343. 2011-04-06 MORITA Hajime <morrita@google.com>
  34344. Reviewed by Darin Adler.
  34345. [Refactoring] Auto correction panel should be handled by its own class.
  34346. https://bugs.webkit.org/show_bug.cgi?id=55571
  34347. Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
  34348. SpellingCorrectionController class.
  34349. This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
  34350. code paths inside the never reached without autocorrection support.
  34351. Removing guards reduces unintentional build breakage.
  34352. No new tests, no behavior chagne.
  34353. * CMakeLists.txt:
  34354. * GNUmakefile.am:
  34355. * WebCore.gypi:
  34356. * WebCore.pro:
  34357. * WebCore.vcproj/WebCore.vcproj:
  34358. * WebCore.xcodeproj/project.pbxproj:
  34359. * editing/CorrectionPanelInfo.h: Removed.
  34360. * editing/EditingAllInOne.cpp:
  34361. * editing/Editor.cpp:
  34362. (WebCore::Editor::respondToChangedSelection):
  34363. (WebCore::Editor::respondToChangedContents):
  34364. (WebCore::Editor::appliedEditing):
  34365. (WebCore::Editor::Editor):
  34366. (WebCore::Editor::~Editor):
  34367. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  34368. (WebCore::Editor::insertLineBreak):
  34369. (WebCore::Editor::insertParagraphSeparator):
  34370. (WebCore::Editor::cut):
  34371. (WebCore::Editor::paste):
  34372. (WebCore::Editor::pasteAsPlainText):
  34373. (WebCore::Editor::isAutomaticSpellingCorrectionEnabled):
  34374. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  34375. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  34376. (WebCore::Editor::changeBackToReplacedString):
  34377. (WebCore::Editor::unappliedSpellCorrection):
  34378. (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
  34379. (WebCore::Editor::startCorrectionPanelTimer):
  34380. (WebCore::Editor::handleCorrectionPanelResult):
  34381. (WebCore::Editor::dismissCorrectionPanelAsIgnored):
  34382. * editing/Editor.h:
  34383. * editing/SpellingCorrectionCommand.cpp:
  34384. * editing/SpellingCorrectionController.cpp: Added.
  34385. (WebCore::markerTypesForAutocorrection):
  34386. (WebCore::markerTypesForReplacement):
  34387. (WebCore::markersHaveIdenticalDescription):
  34388. (WebCore::SpellingCorrectionController::SpellingCorrectionController):
  34389. (WebCore::SpellingCorrectionController::~SpellingCorrectionController):
  34390. (WebCore::SpellingCorrectionController::startCorrectionPanelTimer):
  34391. (WebCore::SpellingCorrectionController::stopCorrectionPanelTimer):
  34392. (WebCore::SpellingCorrectionController::stopPendingCorrection):
  34393. (WebCore::SpellingCorrectionController::applyPendingCorrection):
  34394. (WebCore::SpellingCorrectionController::hasPendingCorrection):
  34395. (WebCore::SpellingCorrectionController::isSpellingMarkerAllowed):
  34396. (WebCore::SpellingCorrectionController::show):
  34397. (WebCore::SpellingCorrectionController::handleCancelOperation):
  34398. (WebCore::SpellingCorrectionController::dismiss):
  34399. (WebCore::SpellingCorrectionController::dismissSoon):
  34400. (WebCore::SpellingCorrectionController::applyCorrectionPanelInfo):
  34401. (WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate):
  34402. (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
  34403. (WebCore::SpellingCorrectionController::correctionPanelTimerFired):
  34404. (WebCore::SpellingCorrectionController::handleCorrectionPanelResult):
  34405. (WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled):
  34406. (WebCore::SpellingCorrectionController::windowRectForRange):
  34407. (WebCore::SpellingCorrectionController::respondToChangedSelection):
  34408. (WebCore::SpellingCorrectionController::respondToAppliedEditing):
  34409. (WebCore::SpellingCorrectionController::client):
  34410. (WebCore::SpellingCorrectionController::textChecker):
  34411. (WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed):
  34412. (WebCore::SpellingCorrectionController::markReversed):
  34413. (WebCore::SpellingCorrectionController::markCorrection):
  34414. (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
  34415. * editing/SpellingCorrectionController.h: Added.
  34416. (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  34417. (WebCore::SpellingCorrectionController::shouldStartTimeFor):
  34418. (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  34419. * editing/TypingCommand.cpp:
  34420. (WebCore::TypingCommand::insertText):
  34421. (WebCore::TypingCommand::markMisspellingsAfterTyping):
  34422. (WebCore::TypingCommand::deleteKeyPressed):
  34423. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  34424. * editing/htmlediting.h:
  34425. (WebCore::isAmbiguousBoundaryCharacter):
  34426. * page/EditorClient.h:
  34427. * page/Frame.cpp:
  34428. (WebCore::Frame::setPageAndTextZoomFactors):
  34429. 2011-04-08 Alpha Lam <hclam@chromium.org>
  34430. Unreviewed, rolling out r83335.
  34431. http://trac.webkit.org/changeset/83335
  34432. https://bugs.webkit.org/show_bug.cgi?id=53556
  34433. GTK and QT bots are broken
  34434. * CMakeLists.txt:
  34435. * Configurations/FeatureDefines.xcconfig:
  34436. * DerivedSources.make:
  34437. * GNUmakefile.am:
  34438. * WebCore.gypi:
  34439. * WebCore.xcodeproj/project.pbxproj:
  34440. * features.pri:
  34441. * html/HTMLAttributeNames.in:
  34442. * html/HTMLTagNames.in:
  34443. * html/HTMLTrackElement.cpp: Removed.
  34444. * html/HTMLTrackElement.h: Removed.
  34445. * html/HTMLTrackElement.idl: Removed.
  34446. 2011-04-08 Brady Eidson <beidson@apple.com>
  34447. Reviewed by Adam Roben.
  34448. https://bugs.webkit.org/show_bug.cgi?id=58155 and part of <rdar://problem/9251767>
  34449. BitmapImage::getFirstCGImageRefOfSize fails if the frameCount hasn't been initialized from the image source.
  34450. * platform/graphics/cg/ImageCG.cpp:
  34451. (WebCore::BitmapImage::getFirstCGImageRefOfSize): Call frameCount() instead of accessing m_frames.size() to
  34452. make sure the frames are properly tallied first.
  34453. 2011-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
  34454. Reviewed by Andreas Kling.
  34455. [Qt] Dragging and dropping an image in edit mode does not work
  34456. https://bugs.webkit.org/show_bug.cgi?id=19385
  34457. When adding an image to the clipboard, we should also include the HTML code of that image so
  34458. it can be used for internal drag and drop.
  34459. This HTML is expected by all clients of drop events so a fragment can be moved from one browser to
  34460. another, or inside the same browser.
  34461. * platform/qt/ClipboardQt.cpp:
  34462. (WebCore::ClipboardQt::declareAndWriteDragImage):
  34463. 2011-04-07 Anna Cavender <annacc@chromium.org>
  34464. Reviewed by Eric Carlson.
  34465. Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
  34466. https://bugs.webkit.org/show_bug.cgi?id=53556
  34467. No new tests. No real functionality added just yet.
  34468. * CMakeLists.txt:
  34469. * Configurations/FeatureDefines.xcconfig:
  34470. * DerivedSources.make:
  34471. * GNUmakefile.am:
  34472. * WebCore.gypi:
  34473. * WebCore.xcodeproj/project.pbxproj:
  34474. * features.pri:
  34475. * html/HTMLAttributeNames.in:
  34476. * html/HTMLTagNames.in:
  34477. * html/HTMLTrackElement.cpp: Added.
  34478. (WebCore::HTMLTrackElement::HTMLTrackElement):
  34479. (WebCore::HTMLTrackElement::create):
  34480. (WebCore::HTMLTrackElement::insertedIntoTree):
  34481. (WebCore::HTMLTrackElement::willRemove):
  34482. (WebCore::HTMLTrackElement::src):
  34483. (WebCore::HTMLTrackElement::setSrc):
  34484. (WebCore::HTMLTrackElement::kind):
  34485. (WebCore::HTMLTrackElement::setKind):
  34486. (WebCore::HTMLTrackElement::srclang):
  34487. (WebCore::HTMLTrackElement::setSrclang):
  34488. (WebCore::HTMLTrackElement::label):
  34489. (WebCore::HTMLTrackElement::setLabel):
  34490. (WebCore::HTMLTrackElement::isDefault):
  34491. (WebCore::HTMLTrackElement::setIsDefault):
  34492. (WebCore::HTMLTrackElement::isURLAttribute):
  34493. * html/HTMLTrackElement.h: Added.
  34494. * html/HTMLTrackElement.idl: Added.
  34495. 2011-04-07 Jer Noble <jer.noble@apple.com>
  34496. Reviewed by Eric Carlson.
  34497. Logic error in HTMLMediaElement::exitFullscreen()
  34498. https://bugs.webkit.org/show_bug.cgi?id=58085
  34499. The new full screen API case could fall through to the legacy API case
  34500. unintentionally if a script calls exitFullscreen on an element which is
  34501. not the current full screen element.
  34502. * html/HTMLMediaElement.cpp:
  34503. (WebCore::HTMLMediaElement::enterFullscreen):
  34504. (WebCore::HTMLMediaElement::exitFullscreen):
  34505. 2011-04-08 Mike Reed <reed@google.com>
  34506. Reviewed by Eric Seidel.
  34507. Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work
  34508. https://bugs.webkit.org/show_bug.cgi?id=57782
  34509. No new tests. This change only affects print-preview and build option SKIA_GPU
  34510. * platform/graphics/skia/SkiaFontWin.cpp:
  34511. (WebCore::paintSkiaText):
  34512. 2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
  34513. Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
  34514. REGRESSION(r81887): Crash in SplitElement
  34515. https://bugs.webkit.org/show_bug.cgi?id=57743
  34516. The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
  34517. even when the position was after the last node in it container. Since all we are doing here is to splitting tree
  34518. up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
  34519. and highestEnclosingNodeOfType.
  34520. Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
  34521. which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
  34522. it incorrectly called deprecatedNode instead of containerNode.
  34523. Test: editing/inserting/insert-images-in-pre-x-crash.html
  34524. * editing/CompositeEditCommand.cpp:
  34525. (WebCore::CompositeEditCommand::splitTreeToNode):
  34526. * editing/ReplaceSelectionCommand.cpp:
  34527. (WebCore::ReplaceSelectionCommand::doApply):
  34528. * editing/htmlediting.cpp:
  34529. (WebCore::highestEnclosingNodeOfType):
  34530. 2011-04-08 Antti Koivisto <antti@apple.com>
  34531. Reviewed by Tony Gentilcore.
  34532. Incoming source should be preload scanned when the parser is blocked
  34533. https://bugs.webkit.org/show_bug.cgi?id=58117
  34534. Scan the appended source if parser is blocked.
  34535. Test: http/tests/loading/preload-append-scan.php
  34536. * html/parser/HTMLDocumentParser.cpp:
  34537. (WebCore::HTMLDocumentParser::append):
  34538. 2011-04-08 Martin Robinson <mrobinson@igalia.com>
  34539. Reviewed by Xan Lopez.
  34540. [GTK] Fix the WebKit2 build for older versions of GTK+
  34541. https://bugs.webkit.org/show_bug.cgi?id=58095
  34542. No new tests. This is just a build fix.
  34543. * platform/gtk/GtkVersioning.c:
  34544. (gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
  34545. * platform/gtk/GtkVersioning.h: Add the new method to the header.
  34546. 2011-04-08 Misha Tyutyunik <michael.tyutyunik@nokia.com>
  34547. Reviewed by Laszlo Gombos.
  34548. [Qt] Plugin is not scrolled together with page content or jumping
  34549. when content is rendered using cache (backing store).
  34550. https://bugs.webkit.org/show_bug.cgi?id=56130
  34551. This is a Symbian portion of the fix. For Linux it looks like
  34552. it's enough to call set geometry which should be addressed in
  34553. https://bugs.webkit.org/show_bug.cgi?id=57179
  34554. No new tests required. This can be tested with manual tests from
  34555. WebCore/manual-tests/qt and WebCore/manual-tests/plugins
  34556. * plugins/symbian/PluginViewSymbian.cpp:
  34557. (WebCore::PluginView::updatePluginWidget):
  34558. 2011-04-08 Abhishek Arya <inferno@chromium.org>
  34559. Unreviewed. Remove accidental printf added in r83306.
  34560. * page/EventHandler.cpp:
  34561. (WebCore::EventHandler::sendContextMenuEvent):
  34562. 2011-04-08 Enrica Casucci <enrica@apple.com>
  34563. Reviewed by Darin Adler.
  34564. Dragging text in a WebKit2 window results in a copy instead of a move.
  34565. https://bugs.webkit.org/show_bug.cgi?id=56772
  34566. <rdar://problem/9165140>
  34567. cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
  34568. the call to startDrag is asynchronous.
  34569. * page/mac/DragControllerMac.mm:
  34570. (WebCore::DragController::cleanupAfterSystemDrag):
  34571. 2011-04-05 Dimitri Glazkov <dglazkov@chromium.org>
  34572. Reviewed by Darin Adler.
  34573. Move WheelEvent-dispatching logic into WheelEventDispatchMediator.
  34574. https://bugs.webkit.org/show_bug.cgi?id=57642
  34575. Covered by existing tests, no functional change.
  34576. * dom/Event.cpp:
  34577. * dom/Event.h:
  34578. (WebCore::EventDispatchMediator::EventDispatchMediator): Added default
  34579. constructor.
  34580. (WebCore::EventDispatchMediator::event): Inlined.
  34581. (WebCore::EventDispatchMediator::setEvent): Added.
  34582. * dom/EventDispatcher.cpp: Removed dispatchWheelEvent.
  34583. * dom/EventDispatcher.h: Updated decls.
  34584. * dom/Node.cpp:
  34585. (WebCore::Node::dispatchWheelEvent): Changed to use the mediator and
  34586. return a bool, like other dispatch event functions.
  34587. * dom/Node.h: Changed decl.
  34588. * dom/WheelEvent.cpp:
  34589. (WebCore::granularity): Moved from EventDispatcher.
  34590. (WebCore::WheelEventDispatchMediator::WheelEventDisatchMediator): Added.
  34591. (WebCore::WheelEventDispatchMediator::event): Added.
  34592. (WebCore::WheelEventDispatchMediator::dispatchEvent): Added.
  34593. * dom/WheelEvent.h: Updated decls.
  34594. * page/EventHandler.cpp:
  34595. (WebCore::EventHandler::handleWheelEvent): Changed to receive and react
  34596. to the return value.
  34597. 2011-04-08 Jessie Berlin <jberlin@apple.com>
  34598. Windows build warning fix.
  34599. * WebCore.vcproj/WebCore.vcproj:
  34600. Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
  34601. the build.
  34602. 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
  34603. Reviewed by Pavel Feldman.
  34604. Web Inspector: update breakpoints according to source frame decorations after live edit.
  34605. https://bugs.webkit.org/show_bug.cgi?id=58029
  34606. * inspector/front-end/DebuggerPresentationModel.js:
  34607. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
  34608. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  34609. (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource):
  34610. (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
  34611. * inspector/front-end/SourceFile.js:
  34612. (WebInspector.SourceFile.prototype.set content):
  34613. * inspector/front-end/SourceFrame.js:
  34614. (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
  34615. (WebInspector.SourceFrame.prototype._handleSave):
  34616. 2011-04-08 Pavel Podivilov <podivilov@chromium.org>
  34617. Reviewed by Pavel Feldman.
  34618. Web Inspector: fix scripts concatenation in scripts panel.
  34619. https://bugs.webkit.org/show_bug.cgi?id=58138
  34620. When there is just one script starting at 0:0 it should not be surrounded by <script> framing.
  34621. * inspector/front-end/SourceFile.js:
  34622. (WebInspector.SourceFile.prototype._loadResourceContent):
  34623. (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
  34624. 2011-04-08 Pavel Feldman <pfeldman@chromium.org>
  34625. Reviewed by Yury Semikhatsky.
  34626. Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
  34627. https://bugs.webkit.org/show_bug.cgi?id=58118
  34628. This change reuses location for call frames in the protocol + structures script
  34629. location <-> source lines interaction better. When we need UI columns, we will add
  34630. them, but we should distinguish between script and UI terms on the type level, not naming.
  34631. * English.lproj/localizedStrings.js:
  34632. * bindings/v8/DebuggerScript.js:
  34633. * inspector/InjectedScriptSource.js:
  34634. * inspector/Inspector.json:
  34635. * inspector/front-end/CallStackSidebarPane.js:
  34636. (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
  34637. (WebInspector.CallStackSidebarPane.prototype.update):
  34638. * inspector/front-end/DebuggerPresentationModel.js:
  34639. (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping):
  34640. (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
  34641. (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
  34642. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
  34643. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
  34644. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
  34645. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  34646. (WebInspector.PresenationCallFrame):
  34647. (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping):
  34648. (WebInspector.PresenationCallFrame.prototype.sourceLine):
  34649. * inspector/front-end/ScriptFormatter.js:
  34650. (WebInspector.ScriptFormatter.locationToPosition):
  34651. (WebInspector.ScriptFormatter.lineToPosition):
  34652. * inspector/front-end/ScriptsPanel.js:
  34653. (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
  34654. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  34655. (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  34656. (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
  34657. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  34658. * inspector/front-end/SourceFile.js:
  34659. (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine):
  34660. (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
  34661. (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
  34662. (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
  34663. 2011-04-08 Pavel Podivilov <podivilov@chromium.org>
  34664. Reviewed by Pavel Feldman.
  34665. Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
  34666. https://bugs.webkit.org/show_bug.cgi?id=58133
  34667. * inspector/front-end/DebuggerPresentationModel.js:
  34668. (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
  34669. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  34670. (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
  34671. (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
  34672. (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
  34673. (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
  34674. (WebInspector.DebuggerPresentationModel.prototype._reset):
  34675. 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
  34676. Reviewed by Pavel Feldman.
  34677. Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
  34678. https://bugs.webkit.org/show_bug.cgi?id=58026
  34679. This is the first step of decoupling TextViewer from SourceFrame.
  34680. * inspector/front-end/SourceFrame.js:
  34681. (WebInspector.SourceFrame):
  34682. (WebInspector.SourceFrame.prototype.show):
  34683. (WebInspector.SourceFrame.prototype.hide):
  34684. (WebInspector.SourceFrame.prototype._ensureContentLoaded):
  34685. (WebInspector.SourceFrame.prototype.contentEditable):
  34686. (WebInspector.SourceFrame.prototype.startEditing):
  34687. (WebInspector.SourceFrame.prototype.endEditing):
  34688. (WebInspector.SourceFrame.prototype._createTextViewer):
  34689. (WebInspector.SourceFrame.prototype._handleSave):
  34690. (WebInspector.SourceFrame.prototype._handleRevertEditing):
  34691. * inspector/front-end/TextViewer.js:
  34692. (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
  34693. (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
  34694. (WebInspector.TextViewer.prototype._syncDecorationsForLine):
  34695. (WebInspector.TextViewer.prototype._doubleClick):
  34696. (WebInspector.TextViewerDelegate):
  34697. (WebInspector.TextViewerDelegate.prototype.contentEditable):
  34698. (WebInspector.TextViewerDelegate.prototype.startEditing):
  34699. (WebInspector.TextViewerDelegate.prototype.endEditing):
  34700. (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
  34701. (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
  34702. * inspector/front-end/inspector.html:
  34703. 2011-04-08 Leandro Gracia Gil <leandrogracia@chromium.org>
  34704. Reviewed by Steve Block.
  34705. Media Stream API: add the getUserMedia method and the Javascript bindings.
  34706. https://bugs.webkit.org/show_bug.cgi?id=56586
  34707. Add the getUserMedia method to the navigator and its new Javascript types.
  34708. Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
  34709. Tests: fast/dom/MediaStream/argument-types.html
  34710. fast/dom/MediaStream/enabled.html
  34711. fast/dom/MediaStream/no-interface-object.html
  34712. * Android.derived.jscbindings.mk:
  34713. * Android.derived.v8bindings.mk:
  34714. * Android.v8bindings.mk:
  34715. * CMakeLists.txt:
  34716. * CodeGenerators.pri:
  34717. * DerivedSources.cpp:
  34718. * DerivedSources.make:
  34719. * GNUmakefile.list.am:
  34720. * WebCore.gypi:
  34721. * WebCore.pro:
  34722. * WebCore.vcproj/WebCore.vcproj:
  34723. * WebCore.xcodeproj/project.pbxproj:
  34724. * bindings/js/JSNavigatorCustom.cpp:
  34725. (WebCore::JSNavigator::webkitGetUserMedia):
  34726. * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
  34727. (WebCore::V8Navigator::webkitGetUserMediaCallback):
  34728. * page/Navigator.cpp:
  34729. (WebCore::Navigator::webkitGetUserMedia):
  34730. * page/Navigator.h:
  34731. * page/Navigator.idl:
  34732. * page/NavigatorUserMediaError.h: Added.
  34733. (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
  34734. (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
  34735. (WebCore::NavigatorUserMediaError::code):
  34736. * page/NavigatorUserMediaError.idl: Added.
  34737. * page/NavigatorUserMediaErrorCallback.h: Added.
  34738. (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
  34739. * page/NavigatorUserMediaErrorCallback.idl: Added.
  34740. * page/NavigatorUserMediaSuccessCallback.h: Added.
  34741. (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
  34742. * page/NavigatorUserMediaSuccessCallback.idl: Added.
  34743. 2011-04-08 Mikhail Naganov <mnaganov@chromium.org>
  34744. Reviewed by Pavel Feldman.
  34745. Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
  34746. https://bugs.webkit.org/show_bug.cgi?id=58010
  34747. https://bugs.webkit.org/show_bug.cgi?id=58011
  34748. Added tests for "Containment" view. Minor refactorings, bugs fixed.
  34749. Split one large tests into smaller ones to avoid timing out in debug mode.
  34750. Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
  34751. inspector/profiler/detailed-heapshots-containment-show-all.html
  34752. inspector/profiler/detailed-heapshots-containment-show-next.html
  34753. inspector/profiler/detailed-heapshots-containment-sorting.html
  34754. inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
  34755. inspector/profiler/detailed-heapshots-summary-show-all.html
  34756. inspector/profiler/detailed-heapshots-summary-show-next.html
  34757. inspector/profiler/detailed-heapshots-summary-sorting.html
  34758. * inspector/front-end/DetailedHeapshotGridNodes.js:
  34759. (WebInspector.HeapSnapshotGridNode):
  34760. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  34761. (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
  34762. (WebInspector.HeapSnapshotGridNode.prototype.sort):
  34763. (WebInspector.HeapSnapshotGenericObjectNode):
  34764. (WebInspector.HeapSnapshotObjectNode):
  34765. (WebInspector.HeapSnapshotInstanceNode):
  34766. (WebInspector.HeapSnapshotConstructorNode):
  34767. (WebInspector.HeapSnapshotDiffNode):
  34768. (WebInspector.HeapSnapshotDominatorObjectNode):
  34769. * inspector/front-end/DetailedHeapshotView.js:
  34770. (WebInspector.HeapSnapshotContainmentDataGrid):
  34771. (WebInspector.HeapSnapshotDominatorsDataGrid):
  34772. 2011-04-08 Andrey Adaikin <aandrey@google.com>
  34773. Reviewed by Pavel Feldman.
  34774. Web Inspector: Bugs in some corner cases in the text editor
  34775. https://bugs.webkit.org/show_bug.cgi?id=58025
  34776. This solves the following bugs:
  34777. 1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
  34778. 2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.
  34779. * inspector/front-end/TextViewer.js:
  34780. (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
  34781. (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
  34782. (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
  34783. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  34784. (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
  34785. 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
  34786. Reviewed by Pavel Feldman.
  34787. Web Inspector: add test for script formatter worker.
  34788. https://bugs.webkit.org/show_bug.cgi?id=57447
  34789. Test: inspector/debugger/script-formatter.html
  34790. * GNUmakefile.am:
  34791. * WebCore.xcodeproj/project.pbxproj:
  34792. * gyp/streamline-inspector-source.sh:
  34793. * inspector/front-end/DebuggerPresentationModel.js:
  34794. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  34795. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  34796. (WebInspector.DebuggerPresentationModel.prototype._formatter):
  34797. * inspector/front-end/ScriptFormatterWorker.js:
  34798. 2011-04-08 Andrey Adaikin <aandrey@google.com>
  34799. Reviewed by Pavel Feldman.
  34800. Web Inspector: Tweak dynamically constants for the async highlighting in text editor
  34801. https://bugs.webkit.org/show_bug.cgi?id=58035
  34802. * inspector/front-end/TextViewer.js:
  34803. (WebInspector.TextEditorMainPanel.prototype._expandChunks):
  34804. (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
  34805. (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
  34806. (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
  34807. (WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):
  34808. 2011-04-08 Andrey Kosyakov <caseq@chromium.org>
  34809. Reviewed by Yury Semikhatsky.
  34810. Web Inspector: HAR compliance fixes
  34811. https://bugs.webkit.org/show_bug.cgi?id=58124
  34812. - Always provide some values for queryString and cookies, even though arrays may be empty
  34813. - Always provide an empty cache object
  34814. - Added entire HARLog to test
  34815. - Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)
  34816. * inspector/front-end/HAREntry.js:
  34817. (WebInspector.HAREntry.prototype.build):
  34818. (WebInspector.HAREntry.prototype._buildRequest):
  34819. (WebInspector.HAREntry.prototype._buildResponse):
  34820. 2011-04-08 Adam Barth <abarth@webkit.org>
  34821. Attempt to fix the Qt build.
  34822. * css/CSSStyleApplyProperty.cpp:
  34823. 2011-04-07 Adam Barth <abarth@webkit.org>
  34824. Reviewed by Eric Seidel.
  34825. Refactor WebCore/GNUMakefile.am to separate list of files
  34826. https://bugs.webkit.org/show_bug.cgi?id=58116
  34827. This change is similar to the cooresponding to change to
  34828. JavaScriptCore. We hope to generate GNUmakefile.list.am automatically
  34829. using GYP.
  34830. * GNUmakefile.am:
  34831. * GNUmakefile.list.am: Added.
  34832. 2011-04-07 Geoffrey Garen <ggaren@apple.com>
  34833. Not reviewed.
  34834. Rolled out some accidentally-committed changes in my last commit.
  34835. * dom/EventTarget.cpp:
  34836. (WebCore::EventTarget::addEventListener):
  34837. (WebCore::EventTarget::removeEventListener):
  34838. * dom/EventTarget.h:
  34839. 2011-04-07 Julien Chaffraix <jchaffraix@codeaurora.org>
  34840. Reviewed by Alexey Proskuryakov.
  34841. EventSource should only accept UTF-8 charset
  34842. https://bugs.webkit.org/show_bug.cgi?id=56942
  34843. Following the discussion on bug 45372, this change implements the recommended
  34844. way of handling "charset". We only accept UTF-8 but no other encoding. This matches
  34845. the encoding of the EventSource and also may fix TomCat that automatically send this
  34846. charset.
  34847. * page/EventSource.cpp:
  34848. (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is
  34849. not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type
  34850. is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
  34851. 2011-04-07 Geoffrey Garen <ggaren@apple.com>
  34852. Reviewed by Maciej Stachowiak.
  34853. Some Handle<T> cleanup
  34854. https://bugs.webkit.org/show_bug.cgi?id=58109
  34855. * bindings/js/ScriptValue.h:
  34856. (WebCore::ScriptValue::ScriptValue): Updated for new null constructor.
  34857. (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().
  34858. 2011-04-07 Dominic Cooney <dominicc@google.com>
  34859. Reviewed by Dimitri Glazkov.
  34860. Let shadow DOM have a list of nodes at the top level of a shadow.
  34861. https://bugs.webkit.org/show_bug.cgi?id=57813
  34862. Adds ShadowRoot, a list of nodes, to be a parent for top-level
  34863. shadow children. Forwards rendering through the root and into the
  34864. host's renderer.
  34865. Covered by existing tests of elements that use this style of shadow.
  34866. * Android.mk: add ShadowRoot.h/cpp
  34867. * CMakeLists.txt:
  34868. * GNUmakefile.am:
  34869. * WebCore.exp.in:
  34870. * WebCore.gypi:
  34871. * WebCore.pro:
  34872. * WebCore.vcproj/WebCore.vcproj:
  34873. * WebCore.xcodeproj/project.pbxproj:
  34874. * css/CSSStyleSelector.cpp:
  34875. (WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
  34876. * dom/ContainerNode.cpp: parent nodes that are shadow roots are alive
  34877. (WebCore::ContainerNode::insertBefore):
  34878. (WebCore::ContainerNode::replaceChild):
  34879. (WebCore::ContainerNode::removeChild):
  34880. (WebCore::ContainerNode::appendChild):
  34881. * dom/DocumentFragment.cpp:
  34882. (WebCore::DocumentFragment::DocumentFragment):
  34883. * dom/DocumentFragment.h:
  34884. * dom/Element.cpp:
  34885. (WebCore::Element::recalcStyle): look through ShadowRoots for host's style
  34886. (WebCore::Element::shadowRoot): should be const
  34887. (WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
  34888. * dom/Element.h:
  34889. * dom/ElementRareData.h:
  34890. * dom/Node.cpp:
  34891. (WebCore::Node::parentNodeForRenderingAndStyle): indirection so
  34892. ShadowRoot can forward to the host's renderer
  34893. (WebCore::Node::createRendererAndStyle):
  34894. (WebCore::Node::createRendererIfNeeded):
  34895. * dom/Node.h:
  34896. (WebCore::Node::isShadowBoundary): temporary, to differentiate
  34897. old- and new-style, until all roots are ShadowRoot instances
  34898. * dom/ShadowRoot.cpp: Added.
  34899. (WebCore::ShadowRoot::ShadowRoot):
  34900. (WebCore::ShadowRoot::recalcStyle): forward recalc to children
  34901. * dom/ShadowRoot.h: Added.
  34902. (WebCore::ShadowRoot::isShadowBoundary):
  34903. (WebCore::ShadowRoot::create):
  34904. * html/HTMLKeygenElement.cpp: use ensureShadowRoot
  34905. (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  34906. (WebCore::HTMLKeygenElement::parseMappedAttribute):
  34907. (WebCore::HTMLKeygenElement::appendFormData):
  34908. (WebCore::HTMLKeygenElement::reset):
  34909. (WebCore::HTMLKeygenElement::shadowSelect):
  34910. * html/HTMLKeygenElement.h:
  34911. * html/HTMLMeterElement.cpp: use ensureShadowRoot
  34912. (WebCore::HTMLMeterElement::createShadowSubtree):
  34913. * html/HTMLProgressElement.cpp: use ensureShadowRoot
  34914. (WebCore::HTMLProgressElement::createShadowSubtree):
  34915. * html/InputType.cpp: use ensureShadowRoot
  34916. (WebCore::InputType::destroyShadowSubtree):
  34917. * html/RangeInputType.cpp: use ensureShadowRoot
  34918. (WebCore::RangeInputType::handleMouseDownEvent):
  34919. (WebCore::RangeInputType::createShadowSubtree):
  34920. (WebCore::RangeInputType::valueChanged):
  34921. (WebCore::RangeInputType::shadowSliderThumb):
  34922. * html/RangeInputType.h:
  34923. * html/ValidationMessage.cpp: use ensureShadowRoot
  34924. (WebCore::ValidationMessage::buildBubbleTree):
  34925. (WebCore::ValidationMessage::deleteBubbleTree):
  34926. * html/shadow/SliderThumbElement.cpp:
  34927. (WebCore::SliderThumbElement::setPositionFromPoint):
  34928. (WebCore::SliderThumbElement::hostInput):
  34929. * html/shadow/SliderThumbElement.h:
  34930. * rendering/MediaControlElements.cpp: use ensureShadowRoot
  34931. (WebCore::MediaControlInputElement::attach):
  34932. (WebCore::MediaControlInputElement::updateStyle):
  34933. * rendering/RenderSlider.cpp: use ensureShadowRoot
  34934. (WebCore::RenderSlider::thumbRect):
  34935. (WebCore::RenderSlider::layout):
  34936. (WebCore::RenderSlider::shadowSliderThumb):
  34937. (WebCore::RenderSlider::inDragMode):
  34938. * rendering/RenderSlider.h:
  34939. 2011-04-07 Maciej Stachowiak <mjs@apple.com>
  34940. Reviewed by Simon Fraser.
  34941. REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
  34942. https://bugs.webkit.org/show_bug.cgi?id=56297
  34943. <rdar://problem/9131597>
  34944. Test: fast/css-generated-content/table-row-after-no-crash.html
  34945. * rendering/RenderTableRow.cpp:
  34946. (WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after
  34947. content, and only do it if the row already has a parent. For construction of
  34948. anonymous cells to work correctly, the row needs to already have a parent, so
  34949. in that case wait a bit.
  34950. (WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
  34951. * rendering/RenderTableRow.h:
  34952. * rendering/RenderTableSection.cpp:
  34953. (WebCore::RenderTableSection::addChild): When adding a row, update its
  34954. before/after content, in case it had any.
  34955. 2011-04-07 Beth Dakin <bdakin@apple.com>
  34956. Reviewed by Simon Fraser.
  34957. Probable fix for <rdar://problem/9251443> Crashing on exception: -
  34958. [ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized
  34959. selector sent to instance ADDRESS.
  34960. Need to implement new delegate method.
  34961. * platform/mac/ScrollAnimatorMac.mm:
  34962. (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
  34963. 2011-04-07 Ian Henderson <ianh@apple.com>
  34964. Reviewed by Simon Fraser.
  34965. Optimize filling rounded rects that are actually ellipses
  34966. https://bugs.webkit.org/show_bug.cgi?id=58098
  34967. In CG, drawing an ellipse directly is faster than constructing and
  34968. filling a rounded rect path. Detect when the given rounded rect is
  34969. actually an ellipse and draw it directly in this case.
  34970. * platform/graphics/cg/GraphicsContextCG.cpp:
  34971. (WebCore::GraphicsContext::fillRoundedRect):
  34972. 2011-04-07 Ned Holbrook <nholbrook@apple.com>
  34973. Reviewed by Dan Bernstein.
  34974. CTLine objects should outlive their CTRuns
  34975. https://bugs.webkit.org/show_bug.cgi?id=58063
  34976. * platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
  34977. * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  34978. (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun.
  34979. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.
  34980. 2011-04-07 Nat Duca <nduca@chromium.org>
  34981. Reviewed by David Levin.
  34982. [chromium] Compositor thread infrastructure
  34983. https://bugs.webkit.org/show_bug.cgi?id=56131
  34984. Introduce chrome compositor thread and related
  34985. infrastructure.
  34986. * WebCore.gypi:
  34987. * platform/graphics/chromium/cc/CCMainThread.cpp: Added.
  34988. (WebCore::CCMainThread::performTask):
  34989. (WebCore::CCMainThread::postTask):
  34990. * platform/graphics/chromium/cc/CCMainThread.h: Added.
  34991. (WebCore::CCMainThread::Task::~Task):
  34992. (WebCore::CCMainThread::Task::instance):
  34993. (WebCore::CCMainThread::Task::Task):
  34994. * platform/graphics/chromium/cc/CCMainThreadTask.h: Added.
  34995. (WebCore::MainThreadTask0::create):
  34996. (WebCore::MainThreadTask0::MainThreadTask0):
  34997. (WebCore::MainThreadTask0::performTask):
  34998. (WebCore::MainThreadTask1::create):
  34999. (WebCore::MainThreadTask1::MainThreadTask1):
  35000. (WebCore::MainThreadTask1::performTask):
  35001. (WebCore::MainThreadTask2::create):
  35002. (WebCore::MainThreadTask2::MainThreadTask2):
  35003. (WebCore::MainThreadTask2::performTask):
  35004. (WebCore::MainThreadTask3::create):
  35005. (WebCore::MainThreadTask3::MainThreadTask3):
  35006. (WebCore::MainThreadTask3::performTask):
  35007. (WebCore::createMainThreadTask):
  35008. * platform/graphics/chromium/cc/CCThread.cpp: Added.
  35009. (WebCore::CCThread::create):
  35010. (WebCore::CCThread::CCThread):
  35011. (WebCore::CCThread::~CCThread):
  35012. (WebCore::CCThread::postTask):
  35013. (WebCore::CCThread::compositorThreadStart):
  35014. (WebCore::CCThread::runLoop):
  35015. * platform/graphics/chromium/cc/CCThread.h: Added.
  35016. (WebCore::CCThread::Task::~Task):
  35017. (WebCore::CCThread::Task::instance):
  35018. (WebCore::CCThread::Task::Task):
  35019. (WebCore::CCThread::threadID):
  35020. (WebCore::CCCompletionEvent::CCCompletionEvent):
  35021. (WebCore::CCCompletionEvent::~CCCompletionEvent):
  35022. (WebCore::CCCompletionEvent::wait):
  35023. (WebCore::CCCompletionEvent::signal):
  35024. * platform/graphics/chromium/cc/CCThreadTask.h: Added.
  35025. (WebCore::CCThreadTask0::create):
  35026. (WebCore::CCThreadTask0::CCThreadTask0):
  35027. (WebCore::CCThreadTask0::performTask):
  35028. (WebCore::CCThreadTask1::create):
  35029. (WebCore::CCThreadTask1::CCThreadTask1):
  35030. (WebCore::CCThreadTask1::performTask):
  35031. (WebCore::CCThreadTask2::create):
  35032. (WebCore::CCThreadTask2::CCThreadTask2):
  35033. (WebCore::CCThreadTask2::performTask):
  35034. (WebCore::CCThreadTask3::create):
  35035. (WebCore::CCThreadTask3::CCThreadTask3):
  35036. (WebCore::CCThreadTask3::performTask):
  35037. (WebCore::createCCThreadTask):
  35038. 2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
  35039. Reviewed by Eric Seidel.
  35040. REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
  35041. https://bugs.webkit.org/show_bug.cgi?id=57872
  35042. r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
  35043. because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
  35044. r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
  35045. avoiding the tab span.
  35046. Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
  35047. Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
  35048. we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
  35049. before moving the nodes.
  35050. Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html
  35051. editing/inserting/insert-paragraph-separator-tab-span.html
  35052. * editing/DeleteSelectionCommand.cpp:
  35053. (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span,
  35054. no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
  35055. * editing/EditingStyle.cpp:
  35056. (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
  35057. * editing/InsertParagraphSeparatorCommand.cpp:
  35058. (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
  35059. separator into a paragraph separator.
  35060. * editing/htmlediting.cpp:
  35061. (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent
  35062. node after the tab span if the position was at the end of the tab span.
  35063. * editing/htmlediting.h:
  35064. 2011-04-07 Jia Pu <jpu@apple.com>
  35065. Reviewed by Darin Adler.
  35066. [Mac] Editor::setComposition() should not trigger correction panel timer.
  35067. https://bugs.webkit.org/show_bug.cgi?id=58049
  35068. <rdar://problem/9226305>
  35069. On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
  35070. should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
  35071. When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
  35072. m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().
  35073. No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
  35074. autocorrection panel timer, which can not be easily done in automated fashion.
  35075. * editing/Editor.cpp:
  35076. (WebCore::Editor::deleteWithDirection):
  35077. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  35078. (WebCore::Editor::confirmComposition):
  35079. (WebCore::Editor::setComposition):
  35080. * editing/EditorCommand.cpp:
  35081. (WebCore::executeDelete):
  35082. * editing/TypingCommand.cpp:
  35083. (WebCore::TypingCommand::TypingCommand):
  35084. (WebCore::TypingCommand::deleteSelection):
  35085. (WebCore::TypingCommand::deleteKeyPressed):
  35086. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  35087. (WebCore::TypingCommand::insertText):
  35088. (WebCore::TypingCommand::insertLineBreak):
  35089. (WebCore::TypingCommand::insertParagraphSeparator):
  35090. (WebCore::TypingCommand::typingAddedToOpenCommand):
  35091. * editing/TypingCommand.h:
  35092. (WebCore::TypingCommand::create):
  35093. (WebCore::TypingCommand::setShouldPreventSpellChecking):
  35094. 2011-04-07 John Bauman <jbauman@chromium.org>
  35095. Reviewed by Kenneth Russell.
  35096. clearIfComposited call is really slow
  35097. https://bugs.webkit.org/show_bug.cgi?id=57999
  35098. Move getContextAttributes call after the if, so it isn't called nearly as often.
  35099. No new tests.
  35100. * html/canvas/WebGLRenderingContext.cpp:
  35101. (WebCore::WebGLRenderingContext::clearIfComposited):
  35102. 2011-04-07 Luke Macpherson <macpherson@chromium.org>
  35103. Reviewed by Dimitri Glazkov.
  35104. Implement Backgroun and Mask properties in CSSStyleApplyProperty
  35105. https://bugs.webkit.org/show_bug.cgi?id=57922
  35106. No tests added as no behavioral changes.
  35107. * css/CSSStyleApplyProperty.cpp:
  35108. Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties.
  35109. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  35110. Added constructor calls to set up:
  35111. CSSPropertyBackgroundAttachment
  35112. CSSPropertyBackgroundClip
  35113. CSSPropertyWebkitBackgroundClip
  35114. CSSPropertyWebkitBackgroundComposite
  35115. CSSPropertyBackgroundOrigin
  35116. CSSPropertyWebkitBackgroundOrigin
  35117. CSSPropertyBackgroundSize
  35118. CSSPropertyWebkitBackgroundSize
  35119. CSSPropertyWebkitMaskAttachment
  35120. CSSPropertyWebkitMaskClip
  35121. CSSPropertyWebkitMaskComposite
  35122. CSSPropertyWebkitMaskOrigin
  35123. CSSPropertyWebkitMaskSize
  35124. * css/CSSStyleApplyProperty.h:
  35125. (WebCore::CSSStyleApplyProperty::setPropertyValue):
  35126. Add function to specify an equivalent property value in the lookup table.
  35127. * css/CSSStyleSelector.cpp:
  35128. (WebCore::CSSStyleSelector::applyProperty):
  35129. Remove sections now implemented by CSSStyleApplyProperty.
  35130. * css/CSSStyleSelector.h:
  35131. Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.
  35132. 2011-04-04 Eric Seidel <eric@webkit.org>
  35133. Reviewed by Ryosuke Niwa.
  35134. Split run storage out from BidiResolver into a new BidiRunList class
  35135. https://bugs.webkit.org/show_bug.cgi?id=57764
  35136. Part of what makes BidiResolver and InlineIterator so difficult to understand
  35137. (and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
  35138. for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
  35139. BidiRuns from the algorithm. This patch breaks the storage aspect off
  35140. into its own class BidiRunList.
  35141. This patch is only a start. It does not actually fix the problematic ownership
  35142. relationship, but it does make it possible to fix such in a second patch.
  35143. The run pointers and addRun/prependRun, etc. were already a tightly coupled
  35144. logical subset of the BidiResolver class, so moving them into their own class
  35145. was both obvious and easy. The only piece of logic I had to move was that
  35146. deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.
  35147. I believe this deleteRuns side-effect was only ever used for one place
  35148. (right after findNextLineBreak) and that it's only needed because
  35149. findNextLineBreak can sometimes create bidi runs. Run creation appears to be
  35150. an unintentional side-effect of how InlineIterator calls through to BidiResolver
  35151. as part of bidiNext and not a desired effect of the code. I have added the call
  35152. to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
  35153. could get re-used) as a safety precaution. We could replace both with ASSERTs
  35154. in a later patch.
  35155. I suspect there may be a small performance win from further refactoring so that
  35156. findNextLineBreak does not need to create BidiRuns.
  35157. As I commented in the code, callers should own their own BidiRunList which they
  35158. pass to BidiResolver::createBidiRunsForLine. I attempted to implement that in
  35159. an earlier version of this patch, but it was too complicated with the current
  35160. twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
  35161. raise/lowerExplicitEmbeddingLevel are called unconditionally
  35162. from commitExplicitEmbedding (which is called by bidiNext) and expect to have
  35163. access to a runs list even in cases where we don't want any runs (findNextLineBreak).
  35164. I also cleaned up some of the callers to pass around BidiRunList objects instead
  35165. of InlineBidiResolvers now that they're separate objects.
  35166. * GNUmakefile.am:
  35167. * WebCore.gypi:
  35168. * WebCore.pro:
  35169. * WebCore.vcproj/WebCore.vcproj:
  35170. * WebCore.xcodeproj/project.pbxproj:
  35171. * platform/graphics/GraphicsContext.cpp:
  35172. (WebCore::GraphicsContext::drawBidiText):
  35173. * platform/text/BidiResolver.h:
  35174. (WebCore::BidiResolver::BidiResolver):
  35175. (WebCore::BidiResolver::runs):
  35176. (WebCore::BidiResolver::markCurrentRunEmpty):
  35177. (WebCore::::appendRun):
  35178. (WebCore::::lowerExplicitEmbeddingLevel):
  35179. (WebCore::::raiseExplicitEmbeddingLevel):
  35180. (WebCore::::reorderRunsFromLevels):
  35181. (WebCore::::createBidiRunsForLine):
  35182. * rendering/InlineIterator.h:
  35183. (WebCore::InlineBidiResolver::appendRun):
  35184. * rendering/RenderBlock.h:
  35185. * rendering/RenderBlockLineLayout.cpp:
  35186. (WebCore::createRun):
  35187. (WebCore::RenderBlock::appendRunsForObject):
  35188. (WebCore::reachedEndOfTextRenderer):
  35189. (WebCore::RenderBlock::handleTrailingSpaces):
  35190. (WebCore::RenderBlock::layoutInlineChildren):
  35191. 2011-04-07 Naoki Takano <takano.naoki@gmail.com>
  35192. Reviewed by Adam Barth.
  35193. [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
  35194. https://bugs.webkit.org/show_bug.cgi?id=57911
  35195. http://code.google.com/p/chromium/issues/detail?id=78073
  35196. Manual test added: manual-tests/autofill-popup-location.html
  35197. Originally only height is checked so that it introduces the bug.
  35198. So I changed it to check both width and height as size.
  35199. * manual-tests/autofill-popup-location.html: Added.
  35200. * platform/chromium/PopupMenuChromium.cpp:
  35201. (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
  35202. 2011-04-07 Adam Barth <abarth@webkit.org>
  35203. Reviewed by Eric Seidel.
  35204. Implement img-src style-src and font-src
  35205. https://bugs.webkit.org/show_bug.cgi?id=58018
  35206. These are pretty straight forward given the rest of the infrastructure
  35207. we've built so far.
  35208. Tests: http/tests/security/contentSecurityPolicy/image-allowed.html
  35209. http/tests/security/contentSecurityPolicy/image-blocked.html
  35210. http/tests/security/contentSecurityPolicy/style-allowed.html
  35211. http/tests/security/contentSecurityPolicy/style-blocked.html
  35212. http/tests/security/contentSecurityPolicy/xsl-allowed.php
  35213. http/tests/security/contentSecurityPolicy/xsl-blocked.php
  35214. * loader/cache/CachedResourceLoader.cpp:
  35215. (WebCore::CachedResourceLoader::canRequest):
  35216. * page/ContentSecurityPolicy.cpp:
  35217. (WebCore::ContentSecurityPolicy::allowImageFromSource):
  35218. (WebCore::ContentSecurityPolicy::allowStyleFromSource):
  35219. (WebCore::ContentSecurityPolicy::allowFontFromSource):
  35220. (WebCore::ContentSecurityPolicy::addDirective):
  35221. * page/ContentSecurityPolicy.h:
  35222. 2011-04-07 David Levin <levin@chromium.org>
  35223. Reviewed by Darin Adler.
  35224. Make IconSnapshot and PageURLRecord member variables private.
  35225. https://bugs.webkit.org/show_bug.cgi?id=58080
  35226. No change in functionality so no new tests.
  35227. * loader/icon/IconDatabase.cpp:
  35228. (WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
  35229. (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.
  35230. * loader/icon/IconRecord.h:
  35231. (WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
  35232. (WebCore::IconSnapshot::iconURL): Expose the property.
  35233. (WebCore::IconSnapshot::timestamp): Ditto.
  35234. (WebCore::IconSnapshot::data): Ditto.
  35235. * loader/icon/PageURLRecord.h:
  35236. (WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
  35237. (WebCore::PageURLSnapshot::pageURL): Expose the property.
  35238. (WebCore::PageURLSnapshot::iconURL): Ditto.
  35239. 2011-04-07 Dan Bernstein <mitz@apple.com>
  35240. Build fix.
  35241. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  35242. (WebCore::GraphicsContext::roundToDevicePixels):
  35243. 2011-04-07 Eric Seidel <eric@webkit.org>
  35244. Reviewed by Adam Barth.
  35245. Add stub support for generating Gtk build system from gyp
  35246. https://bugs.webkit.org/show_bug.cgi?id=58086
  35247. This does not produce a buildable WebCore, but it
  35248. does allow running gyp/configure --port=gtk and having
  35249. it generate a gtk.Makefile which we can use for testing
  35250. the rest of the plumbing.
  35251. * gyp/gtk.gyp: Added.
  35252. 2011-04-07 David Hyatt <hyatt@apple.com>
  35253. Reviewed by Dan Bernstein.
  35254. https://bugs.webkit.org/show_bug.cgi?id=57736
  35255. Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
  35256. optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
  35257. layout finished. This would eventually lead to an inability to properly determine the correct layout root and
  35258. would cause a deleted root to be used later on.
  35259. Added fast/block/positioning/complex-positioned-movement.html.
  35260. * page/FrameView.cpp:
  35261. (WebCore::FrameView::scheduleRelayoutOfSubtree):
  35262. Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.
  35263. * rendering/RenderBlock.cpp:
  35264. (WebCore::RenderBlock::simplifiedLayout):
  35265. Change simplified layout so that the positioned movement optimization no longer clears the other layout
  35266. flags. This will ensure that we still lay out our descendants if they need it.
  35267. (WebCore::RenderBlock::layoutPositionedObjects):
  35268. Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
  35269. no longer does the clear.
  35270. * rendering/RenderBox.h:
  35271. (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  35272. tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure. On success it no longer
  35273. does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
  35274. the other flags in case other kinds of layout are still needed.
  35275. * rendering/RenderObject.h:
  35276. (WebCore::RenderObject::setNeedsPositionedMovementLayout):
  35277. (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
  35278. Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.
  35279. 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
  35280. Revert ENABLE_TRACK patch due to compile failures.
  35281. * CMakeLists.txt:
  35282. * Configurations/FeatureDefines.xcconfig:
  35283. * DerivedSources.make:
  35284. * GNUmakefile.am:
  35285. * WebCore.gypi:
  35286. * WebCore.xcodeproj/project.pbxproj:
  35287. * features.pri:
  35288. * html/HTMLAttributeNames.in:
  35289. * html/HTMLTagNames.in:
  35290. * html/HTMLTrackElement.cpp: Removed.
  35291. * html/HTMLTrackElement.h: Removed.
  35292. * html/HTMLTrackElement.idl: Removed.
  35293. 2011-04-07 Dan Bernstein <mitz@apple.com>
  35294. Reviewed by Simon Fraser.
  35295. <rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor
  35296. https://bugs.webkit.org/show_bug.cgi?id=58083
  35297. Test: fast/text/decorations-transformed.html
  35298. * platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides
  35299. is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
  35300. gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
  35301. the width and the height. In this new mode, translating a rectangle in user space never changes
  35302. its dimensions in device pixels.
  35303. * platform/graphics/cg/GraphicsContextCG.cpp:
  35304. (WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
  35305. (WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
  35306. all underlines have the same thickness in device pixels.
  35307. * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  35308. (WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.
  35309. * platform/graphics/qt/GraphicsContextQt.cpp:
  35310. (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
  35311. * platform/graphics/skia/GraphicsContextSkia.cpp:
  35312. (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
  35313. * platform/graphics/wince/GraphicsContextWinCE.cpp:
  35314. (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
  35315. * platform/graphics/wx/GraphicsContextWx.cpp:
  35316. (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
  35317. * rendering/InlineTextBox.cpp:
  35318. (WebCore::InlineTextBox::paintDecoration):
  35319. 2011-04-06 Vitaly Repeshko <vitalyr@chromium.org>
  35320. Reviewed by Nate Chapin.
  35321. [V8] Remove custom DOMImplementation getter on Document.
  35322. https://bugs.webkit.org/show_bug.cgi?id=57991
  35323. The custom getter is no longer required because DOMImplementation
  35324. objects are now created per document.
  35325. Test: fast/dom/DOMImplementation/implementation-identity.html
  35326. * bindings/scripts/CodeGeneratorV8.pm:
  35327. * bindings/v8/custom/V8DocumentCustom.cpp:
  35328. * dom/Document.idl:
  35329. 2011-04-07 Sergey Glazunov <serg.glazunov@gmail.com>
  35330. Reviewed by Dimitri Glazkov.
  35331. setHasID() is only called for styled elements
  35332. https://bugs.webkit.org/show_bug.cgi?id=57267
  35333. Test: fast/dom/non-styled-element-id-crash.html
  35334. * dom/Element.cpp:
  35335. (WebCore::Element::attributeChanged):
  35336. (WebCore::Element::idAttributeChanged):
  35337. * dom/Element.h:
  35338. * dom/StyledElement.cpp:
  35339. (WebCore::StyledElement::parseMappedAttribute):
  35340. 2011-04-07 Jer Noble <jer.noble@apple.com>
  35341. Reviewed by Eric Carlson.
  35342. HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
  35343. https://bugs.webkit.org/show_bug.cgi?id=58070
  35344. Make the HTMLMediaElement full screen functions call into the new Full Screen API when
  35345. FULLSCREEN_API is enabled.
  35346. * html/HTMLMediaElement.cpp:
  35347. (WebCore::HTMLMediaElement::enterFullscreen):
  35348. (WebCore::HTMLMediaElement::exitFullscreen):
  35349. 2011-04-07 Adam Barth <abarth@webkit.org>
  35350. Reviewed by Eric Seidel.
  35351. Implement CSP's options directive
  35352. https://bugs.webkit.org/show_bug.cgi?id=58014
  35353. This patch contains the full options parser, but we only have enough of
  35354. CSP implemented to see the effects of disable-xss-protection. Will
  35355. need to do some more work before we can see eval-script in action.
  35356. Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html
  35357. http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
  35358. * page/ContentSecurityPolicy.cpp:
  35359. (WebCore::CSPOptions::CSPOptions):
  35360. (WebCore::CSPOptions::disableXSSProtection):
  35361. (WebCore::CSPOptions::evalScript):
  35362. (WebCore::CSPOptions::parse):
  35363. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  35364. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  35365. (WebCore::ContentSecurityPolicy::allowInlineScript):
  35366. (WebCore::ContentSecurityPolicy::addDirective):
  35367. * page/ContentSecurityPolicy.h:
  35368. 2011-04-07 Alexey Proskuryakov <ap@apple.com>
  35369. Reviewed by Anders Carlsson.
  35370. REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
  35371. https://bugs.webkit.org/show_bug.cgi?id=58066
  35372. <rdar://problem/8965302>
  35373. * platform/mac/HTMLConverter.h:
  35374. * platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):
  35375. Changed editingAttributedStringFromRange: to use WebCore::Range instead of DOMRange, since
  35376. it's now used in WebKit2.
  35377. 2011-04-07 Andy Estes <aestes@apple.com>
  35378. Reviewed by Darin Adler.
  35379. REGRESSION (r64712): Microsoft Outlook 2011: original message contents
  35380. not included when replying to an email.
  35381. https://bugs.webkit.org/show_bug.cgi?id=57794
  35382. * WebCore.exp.in:
  35383. * loader/FrameLoader.cpp:
  35384. (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts()
  35385. before checking if the FrameLoader is parsing the initial empty document.
  35386. This allows user scripts to be injected at the end of document parsing
  35387. (if the setting is enabled).
  35388. * page/Frame.cpp:
  35389. (WebCore::Frame::injectUserScripts): Do not inject scripts if this
  35390. feature is disabled on the initial empty document.
  35391. * page/Settings.cpp:
  35392. (WebCore::Settings::Settings):
  35393. * page/Settings.h: Add a setting for injecting user scripts into the
  35394. initial empty document (defaults to false).
  35395. (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument):
  35396. (WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
  35397. * platform/mac/RuntimeApplicationChecks.h:
  35398. * platform/mac/RuntimeApplicationChecks.mm:
  35399. (WebCore::applicationIsMicrosoftOutlook): Check if the embedding
  35400. application is Microsoft Outlook.
  35401. 2011-04-06 Jer Noble <jer.noble@apple.com>
  35402. Reviewed by Maciej Stachowiak.
  35403. AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
  35404. https://bugs.webkit.org/show_bug.cgi?id=57962
  35405. Add support for a new AVPlayerItem API which will notify clients when their
  35406. seek completes. This requires a new Notification type to be passed to the main
  35407. thread in MediaPlayerPrivateAVFoundation.
  35408. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  35409. (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added.
  35410. (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new
  35411. overloaded functions which take a Notification; and a Notification::Type and boolean.
  35412. (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted
  35413. Notification type.
  35414. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  35415. (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor.
  35416. (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
  35417. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  35418. (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API.
  35419. (-[WebCoreAVFMovieObserver seekCompleted:]): Added.
  35420. 2011-04-07 Nancy Piedra <nancy.piedra@nokia.com>
  35421. Reviewed by Eric Carlson.
  35422. Parse quotes from content type parameters
  35423. https://bugs.webkit.org/show_bug.cgi?id=53275
  35424. This functionality is tested in video-can-play-type.html layout test
  35425. where I've added codecs parameter with good and bad formatting.
  35426. * platform/ContentType.cpp:
  35427. (WebCore::ContentType::parameter):
  35428. 2011-04-07 Pavel Feldman <pfeldman@google.com>
  35429. Reviewed by Yury Semikhatsky.
  35430. Web Inspector: remove "enabled" from the setBreakpoint protocol.
  35431. https://bugs.webkit.org/show_bug.cgi?id=58047
  35432. * bindings/js/ScriptDebugServer.cpp:
  35433. (WebCore::ScriptDebugServer::hasBreakpoint):
  35434. * bindings/v8/DebuggerScript.js:
  35435. ():
  35436. * bindings/v8/ScriptDebugServer.cpp:
  35437. (WebCore::ScriptDebugServer::setBreakpoint):
  35438. * inspector/Inspector.json:
  35439. * inspector/InspectorDebuggerAgent.cpp:
  35440. (WebCore::buildObjectForBreakpointCookie):
  35441. (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
  35442. (WebCore::InspectorDebuggerAgent::setBreakpoint):
  35443. (WebCore::InspectorDebuggerAgent::continueToLocation):
  35444. (WebCore::InspectorDebuggerAgent::didParseSource):
  35445. * inspector/InspectorDebuggerAgent.h:
  35446. * inspector/ScriptBreakpoint.h:
  35447. (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  35448. * inspector/front-end/DebuggerModel.js:
  35449. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  35450. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  35451. * inspector/front-end/DebuggerPresentationModel.js:
  35452. (WebInspector.DebuggerPresentationModel):
  35453. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  35454. (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
  35455. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback):
  35456. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  35457. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
  35458. (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
  35459. (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
  35460. (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate):
  35461. (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
  35462. (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
  35463. (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
  35464. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
  35465. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  35466. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  35467. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  35468. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings):
  35469. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  35470. (WebInspector.DebuggerPresentationModel.prototype._reset):
  35471. (WebInspector.PresentationBreakpoint):
  35472. 2011-04-07 Dan Bernstein <mitz@apple.com>
  35473. Reviewed by Adam Roben.
  35474. Removed a redundant line of code.
  35475. * rendering/RenderInline.cpp:
  35476. (WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
  35477. this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.
  35478. 2011-04-07 Liang Qi <liang.qi@nokia.com>
  35479. Reviewed by Laszlo Gombos.
  35480. [Qt][Symbian] Enable webkit build with GCCE on Symbian.
  35481. https://bugs.webkit.org/show_bug.cgi?id=57841
  35482. * WebCore.pri: Thanks for Norbert Leser <norbert.leser@nokia.com> who checked RVCT part.
  35483. --rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated
  35484. to 0x1000000 together. They need to be updated in the future when WebKit grows.
  35485. 2011-04-06 Pavel Feldman <pfeldman@google.com>
  35486. Reviewed by Yury Semikhatsky.
  35487. Web Inspector: get rid of Breakpoint.js.
  35488. https://bugs.webkit.org/show_bug.cgi?id=57949
  35489. * WebCore.gypi:
  35490. * WebCore.vcproj/WebCore.vcproj:
  35491. * inspector/front-end/Breakpoint.js: Removed.
  35492. * inspector/front-end/BreakpointsSidebarPane.js:
  35493. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
  35494. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet):
  35495. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint):
  35496. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
  35497. * inspector/front-end/DebuggerModel.js:
  35498. (WebInspector.DebuggerModel):
  35499. (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
  35500. (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
  35501. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  35502. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  35503. (WebInspector.DebuggerModel.prototype.removeBreakpoint):
  35504. (WebInspector.DebuggerModel.prototype._breakpointResolved):
  35505. (WebInspector.DebuggerModel.prototype.reset):
  35506. * inspector/front-end/DebuggerPresentationModel.js:
  35507. (WebInspector.DebuggerPresentationModel):
  35508. (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
  35509. (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
  35510. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  35511. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint):
  35512. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  35513. (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
  35514. (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
  35515. (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
  35516. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
  35517. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  35518. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  35519. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  35520. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  35521. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint):
  35522. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  35523. (WebInspector.DebuggerPresentationModel.prototype._reset):
  35524. (WebInspector.PresentationBreakpoint):
  35525. (WebInspector.PresentationBreakpoint.prototype.get sourceFile):
  35526. (WebInspector.PresentationBreakpoint.prototype.get url):
  35527. (WebInspector.PresentationBreakpoint.prototype.get resolved):
  35528. (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  35529. * inspector/front-end/ResourceTreeModel.js:
  35530. (WebInspector.ResourceTreeModel):
  35531. (WebInspector.ResourceTreeModel.prototype._onResourceStarted):
  35532. (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
  35533. * inspector/front-end/ScriptsPanel.js:
  35534. (WebInspector.ScriptsPanel):
  35535. (WebInspector.ScriptsPanel.prototype._breakpointUpdated):
  35536. (WebInspector.ScriptsPanel.prototype.reset):
  35537. * inspector/front-end/WebKit.qrc:
  35538. * inspector/front-end/inspector.html:
  35539. 2011-04-07 Yury Semikhatsky <yurys@chromium.org>
  35540. Reviewed by Pavel Feldman.
  35541. Web Inspector: console messages names should adhere to the common naming style
  35542. https://bugs.webkit.org/show_bug.cgi?id=58042
  35543. * inspector/ConsoleMessage.cpp:
  35544. (WebCore::ConsoleMessage::addToFrontend):
  35545. (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  35546. * inspector/Inspector.json:
  35547. * inspector/InspectorConsoleAgent.cpp:
  35548. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  35549. * inspector/front-end/ConsoleView.js:
  35550. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
  35551. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
  35552. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
  35553. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
  35554. 2011-04-06 Ilya Tikhonovsky <loislo@chromium.org>
  35555. Reviewed by Yury Semikhatsky.
  35556. Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
  35557. https://bugs.webkit.org/show_bug.cgi?id=57957
  35558. There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
  35559. Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
  35560. It was decided that we will use it.
  35561. the list of renames:
  35562. 1) type-> /dev/null
  35563. 2) domain + '.' + event => method // for events
  35564. 3) domain + '.' + command => method // for requests
  35565. 4) requestId => id // for responses
  35566. 5) arguments => params // for requests
  35567. 6) data => params // for events
  35568. 7) body => result // for responses
  35569. protocolErrors and error properties will be converted to JSON-RPC error format.
  35570. The order of properties in messages also will be adjusted.
  35571. The only thing that looks unnecessary is jsonrpc property.
  35572. * inspector/CodeGeneratorInspector.pm:
  35573. 2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
  35574. Reviewed by Eric Seidel.
  35575. Add functions to update left and right offsets to LineOffsets
  35576. https://bugs.webkit.org/show_bug.cgi?id=58028
  35577. Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
  35578. which are used to update m_left and m_right. Also added m_block and m_isFirstLine
  35579. member variables to LineOffsets so that users of LineOffsets don't have to pass them around.
  35580. * rendering/RenderBlock.h:
  35581. * rendering/RenderBlockLineLayout.cpp:
  35582. (WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine.
  35583. (WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets.
  35584. (WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine.
  35585. (WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine.
  35586. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
  35587. (WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and
  35588. no longer passes firstLine around.
  35589. 2011-04-06 Pavel Feldman <pfeldman@google.com>
  35590. Reviewed by Yury Semikhatsky.
  35591. Web Inspector: migrate debugger domain to the unified breakpoint location notion.
  35592. https://bugs.webkit.org/show_bug.cgi?id=57928
  35593. * inspector/Inspector.json:
  35594. * inspector/InspectorDebuggerAgent.cpp:
  35595. (WebCore::buildObjectForBreakpointCookie):
  35596. (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
  35597. (WebCore::InspectorDebuggerAgent::setBreakpoint):
  35598. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  35599. (WebCore::InspectorDebuggerAgent::didParseSource):
  35600. * inspector/InspectorDebuggerAgent.h:
  35601. * inspector/front-end/Breakpoint.js:
  35602. (WebInspector.Breakpoint):
  35603. * inspector/front-end/DebuggerModel.js:
  35604. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  35605. (WebInspector.DebuggerModel.prototype._breakpointResolved):
  35606. 2011-04-07 Andreas Kling <andreas.kling@nokia.com>
  35607. Reviewed by Benjamin Poulain.
  35608. [Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.
  35609. When initializing a QStyleOptionSlider from a widget, the State_Horizontal
  35610. hint may get set depending on how that widget is laid out in its parent.
  35611. If this happens when drawing a vertical scrollbar, the hint is never
  35612. cleared and we end up painting a vertical scrollbar with horizontal arrows.
  35613. Covered by pixel tests which should no longer paint silly scrollbars.
  35614. * platform/qt/ScrollbarThemeQt.cpp:
  35615. (WebCore::styleOptionSlider):
  35616. 2011-04-07 Adam Barth <abarth@webkit.org>
  35617. Reviewed by Eric Seidel.
  35618. script-src should block inline script
  35619. https://bugs.webkit.org/show_bug.cgi?id=58012
  35620. Block inline scripts at the ScriptElement layer. This should catch
  35621. exactly the scripts we want to catch.
  35622. Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html
  35623. * dom/Document.cpp:
  35624. (WebCore::Document::processHttpEquiv):
  35625. - This patch also adds the ability to supply a CSP policy via a
  35626. <meta> tag. We'll update the name of the header once we've
  35627. finished implementing the spec.
  35628. * dom/ScriptElement.cpp:
  35629. (WebCore::ScriptElement::executeScript):
  35630. * page/ContentSecurityPolicy.cpp:
  35631. (WebCore::ContentSecurityPolicy::allowInlineScript):
  35632. * page/ContentSecurityPolicy.h:
  35633. 2011-04-07 Alice Boxhall <aboxhall@chromium.org>
  35634. Reviewed by Ryosuke Niwa.
  35635. Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
  35636. https://bugs.webkit.org/show_bug.cgi?id=57921
  35637. Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
  35638. that the same logic can be used for a HitTestResult.
  35639. No visible changes, just cleanup, so no tests.
  35640. * page/EventHandler.cpp:
  35641. (WebCore::EventHandler::selectClosestWordFromMouseEvent):
  35642. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
  35643. (WebCore::EventHandler::handleMousePressEventTripleClick):
  35644. (WebCore::EventHandler::handleMousePressEventSingleClick):
  35645. (WebCore::EventHandler::handleMousePressEvent):
  35646. (WebCore::EventHandler::handleMouseDraggedEvent):
  35647. (WebCore::EventHandler::handleMouseReleaseEvent):
  35648. (WebCore::EventHandler::subframeForHitTestResult):
  35649. Made public static member, so that it can access targetNode(), and be accessed by
  35650. webkitwebview in gtk.
  35651. (WebCore::EventHandler::selectCursor):
  35652. (WebCore::EventHandler::targetNode):
  35653. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  35654. (WebCore::EventHandler::handleMouseMoveEvent):
  35655. (WebCore::EventHandler::updateDragAndDrop):
  35656. (WebCore::EventHandler::sendContextMenuEvent):
  35657. * page/EventHandler.h:
  35658. * page/MouseEventWithHitTestResults.cpp:
  35659. (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  35660. * page/MouseEventWithHitTestResults.h:
  35661. * page/android/EventHandlerAndroid.cpp:
  35662. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35663. * page/brew/EventHandlerBrew.cpp:
  35664. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35665. * page/chromium/EventHandlerChromium.cpp:
  35666. (WebCore::EventHandler::passMousePressEventToSubframe):
  35667. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35668. * page/efl/EventHandlerEfl.cpp:
  35669. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35670. * page/gtk/EventHandlerGtk.cpp:
  35671. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35672. * page/haiku/EventHandlerHaiku.cpp:
  35673. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35674. * page/mac/EventHandlerMac.mm:
  35675. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35676. (WebCore::EventHandler::passSubframeEventToSubframe):
  35677. * page/wx/EventHandlerWx.cpp:
  35678. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  35679. 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
  35680. Reviewed by Pavel Feldman.
  35681. Web Inspector: build mapping for formatted scripts based on keywords positions.
  35682. https://bugs.webkit.org/show_bug.cgi?id=57936
  35683. Mapping based on [\$\.\w]+ was not accurate because string literals representation
  35684. may be different in original and formatted scripts.
  35685. * inspector/front-end/ScriptFormatterWorker.js:
  35686. (buildMapping.regexp.b):
  35687. (buildMapping):
  35688. 2011-04-07 Kent Tamura <tkent@chromium.org>
  35689. Reviewed by Dimitri Glazkov.
  35690. Spinbuttons become unclickable if right padding is large.
  35691. https://bugs.webkit.org/show_bug.cgi?id=56298
  35692. An inner-spin-button is put on the right border and ignores right
  35693. padding in RenderTextControlSingleLine::layout(), but forwardEvent()
  35694. checks if a point is in an area just right of an internal text block.
  35695. This inconsistency caused a bug that an inner-spin-button with large
  35696. padding didn't receive mouse events.
  35697. To fix this bug, we render spin buttons as layers, and remove manual
  35698. event forwarding code.
  35699. Test: fast/forms/input-number-large-padding.html
  35700. * css/html.css: Add "position:relative" to make a spin-button a layer.
  35701. (input::-webkit-inner-spin-button):
  35702. (input::-webkit-outer-spin-button):
  35703. * rendering/RenderTextControlSingleLine.cpp:
  35704. (WebCore::RenderTextControlSingleLine::forwardEvent):
  35705. Remove manual event forwarding code.
  35706. 2011-04-06 Adam Barth <abarth@webkit.org>
  35707. Reviewed by Eric Seidel.
  35708. CSP object-src should block plugin loads
  35709. https://bugs.webkit.org/show_bug.cgi?id=57283
  35710. This change is pretty straight-forward. It's slighly unclear to me
  35711. whether this patch is correct w.r.t. the code in DocumentWriter. I've
  35712. added a FIXME comment, and I'll investigate that case more in the future.
  35713. Test: http/tests/security/contentSecurityPolicy/object-src-none.html
  35714. * loader/DocumentWriter.cpp:
  35715. (WebCore::DocumentWriter::begin):
  35716. * loader/SubframeLoader.cpp:
  35717. (WebCore::SubframeLoader::requestPlugin):
  35718. * page/ContentSecurityPolicy.cpp:
  35719. (WebCore::ContentSecurityPolicy::allowObjectFromSource):
  35720. (WebCore::ContentSecurityPolicy::addDirective):
  35721. * page/ContentSecurityPolicy.h:
  35722. 2011-04-06 Beth Dakin <bdakin@apple.com>
  35723. Reviewed by Dan Bernstein.
  35724. https://bugs.webkit.org/show_bug.cgi?id=58009
  35725. Frame::scalePage() results in visual artifacts with scale factors less than 1
  35726. -and corresponding-
  35727. <rdar://problem/8683230>
  35728. Fall into the case where we fill with a background base color when there is a page
  35729. scale factor that is less than 1.
  35730. * rendering/RenderView.cpp:
  35731. (WebCore::RenderView::paintBoxDecorations):
  35732. 2011-04-06 Jer Noble <jer.noble@apple.com>
  35733. Reviewed by Darin Adler.
  35734. AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
  35735. https://bugs.webkit.org/show_bug.cgi?id=57982
  35736. Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
  35737. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  35738. (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
  35739. 2011-04-06 Jer Noble <jer.noble@apple.com>
  35740. Reviewed by Eric Carlson.
  35741. MediaPlayerPrivateAVFoundation does not change rate due to setRate().
  35742. https://bugs.webkit.org/show_bug.cgi?id=57919
  35743. Test: media/video-set-rate-from-pause.html
  35744. The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
  35745. of the media; instead a subclass must do that work. So when setRate() is called,
  35746. inform a subclass through a new pure virtual updateRate() function that there's
  35747. work to be done.
  35748. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  35749. (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
  35750. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  35751. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  35752. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  35753. (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added. Set the requested rate.
  35754. 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
  35755. Reviewed by David Levin.
  35756. Add QUOTA build flag for unified quota API
  35757. https://bugs.webkit.org/show_bug.cgi?id=57918
  35758. * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
  35759. * GNUmakefile.am: Added QUOTA build flag
  35760. * WebCore.pri: Added QUOTA build flag
  35761. 2011-04-06 Stephanie Lewis <slewis@apple.com>
  35762. Reviewed by Darin Adler.
  35763. https://bugs.webkit.org/show_bug.cgi?id=57997
  35764. <rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
  35765. Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
  35766. Cancel all enqueued events when detaching the Document the events cannot keep the Document
  35767. alive.
  35768. No change in functionality so no new tests.
  35769. * dom/Document.cpp:
  35770. (WebCore::Document::detach):
  35771. * dom/EventQueue.cpp:
  35772. (WebCore::EventQueue::cancelQueuedEvents):
  35773. * dom/EventQueue.h:
  35774. 2011-04-06 Dan Bernstein <mitz@apple.com>
  35775. Reviewed by Darin Adler.
  35776. <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
  35777. https://bugs.webkit.org/show_bug.cgi?id=58002
  35778. * platform/graphics/mac/SimpleFontDataMac.mm:
  35779. (WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
  35780. does not require the vertical metrics tweaks that were needed in Leopard. That the
  35781. tweaks were being applied went mostly unnoticed until r73993, because until then it
  35782. only affected cases where Geeza Pro was specified, not when it occurred as a fallback
  35783. font.
  35784. 2011-04-06 Roland Steiner <rolandsteiner@chromium.org>
  35785. Reviewed by Dimitri Glazkov.
  35786. Bug 57994 - Move guardRef functionality back to Document
  35787. https://bugs.webkit.org/show_bug.cgi?id=57994
  35788. Move the relevant code parts from TreeScope back into Document.
  35789. No new tests. (no new functionality)
  35790. * dom/Document.cpp:
  35791. (WebCore::Document::removedLastRef):
  35792. * dom/Document.h:
  35793. * dom/TreeScope.cpp:
  35794. (WebCore::TreeScope::destroyTreeScopeData):
  35795. * dom/TreeScope.h:
  35796. 2011-04-06 Ian Henderson <ianh@apple.com>
  35797. Reviewed by Simon Fraser, Antti Koivisto.
  35798. Fast path for parsing simple CSS values
  35799. https://bugs.webkit.org/show_bug.cgi?id=57964
  35800. Add functions to parse simple color or dimension values, skipping the
  35801. overhead of full CSS parsing.
  35802. Change parseValue to a static method to avoid unnecessary allocation
  35803. of a CSSParser in the fast case.
  35804. * css/CSSMutableStyleDeclaration.cpp:
  35805. (WebCore::CSSMutableStyleDeclaration::setProperty):
  35806. Changed to use the new, static parseValue method.
  35807. * css/CSSParser.cpp:
  35808. (WebCore::isColorPropertyID):
  35809. (WebCore::parseColorValue):
  35810. Parses any color accepted by the existing parseColor() static method.
  35811. We must handle color identifiers separately, since parseColor() will
  35812. change 'red' into 'rgb(255, 0, 0)'.
  35813. (WebCore::isSimpleLengthPropertyID):
  35814. (WebCore::parseSimpleLengthValue):
  35815. Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
  35816. false, or 'NN' is '0'). Returns false to fall back to the slow path.
  35817. (WebCore::CSSParser::parseValue):
  35818. * css/CSSParser.h:
  35819. * css/WebKitCSSMatrix.cpp:
  35820. (WebCore::WebKitCSSMatrix::setMatrixValue):
  35821. Changed to use the new, static parseValue method.
  35822. 2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
  35823. Reviewed by Darin Adler.
  35824. Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
  35825. https://bugs.webkit.org/show_bug.cgi?id=27551
  35826. * config.h:
  35827. 2011-04-06 Simon Fraser <simon.fraser@apple.com>
  35828. Reviewed by Antti Koivisto.
  35829. Some minor style resolution optimizations
  35830. https://bugs.webkit.org/show_bug.cgi?id=57996
  35831. A couple of minor optimizations to style-related code.
  35832. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  35833. (WebCore::isCSSPropertyName):
  35834. (WebCore::JSCSSStyleDeclaration::putDelegate):
  35835. Avoid calling cssPropertyName() twice when setting style on an element.
  35836. * css/CSSStyleSelector.cpp:
  35837. (WebCore::useSVGZoomRules):
  35838. (WebCore::CSSStyleSelector::applyProperty):
  35839. Avoid calling isSVGElement() for every property, since only a two properties
  35840. care about it.
  35841. 2011-04-06 Ian Henderson <ianh@apple.com>
  35842. Reviewed by Antti Koivisto.
  35843. Unnecessary string allocation in CSSStyleDeclaration::setProperty
  35844. https://bugs.webkit.org/show_bug.cgi?id=57995
  35845. Pass the bool representing the property's importance directly instead
  35846. of constructing a string.
  35847. * css/CSSStyleDeclaration.cpp:
  35848. (WebCore::CSSStyleDeclaration::setProperty):
  35849. 2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
  35850. Reviewed by Steve Block.
  35851. Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
  35852. https://bugs.webkit.org/show_bug.cgi?id=57963
  35853. No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
  35854. * bindings/v8/V8Utilities.h:
  35855. (WebCore::createFunctionOnlyCallback):
  35856. * bindings/v8/custom/V8GeolocationCustom.cpp:
  35857. (WebCore::V8Geolocation::getCurrentPositionCallback):
  35858. (WebCore::V8Geolocation::watchPositionCallback):
  35859. 2011-04-06 Brian Weinstein <bweinstein@apple.com>
  35860. Reviewed by Adam Roben.
  35861. WebKit2: Support Windows 7 Gestures
  35862. https://bugs.webkit.org/show_bug.cgi?id=49824
  35863. <rdar://problem/8689728>
  35864. Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.
  35865. * WebCore.vcproj/WebCore.vcproj:
  35866. * platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.
  35867. 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
  35868. Reviewed by Andreas Kling.
  35869. [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
  35870. https://bugs.webkit.org/show_bug.cgi?id=57974
  35871. We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
  35872. No new tests needed, just a config flag rename.
  35873. * features.pri:
  35874. 2011-04-06 Tyler Close <tjclose@chromium.org>
  35875. Reviewed by Nate Chapin.
  35876. run-bindings-tests reference files out of sync with CodeGenerator*.pm
  35877. https://bugs.webkit.org/show_bug.cgi?id=57967
  35878. * bindings/scripts/test/V8/V8TestCallback.cpp:
  35879. 2011-04-06 Asanka Herath <asanka@chromium.org>
  35880. Reviewed by Darin Fisher.
  35881. Add new TargetType: TargetIsFavicon
  35882. https://bugs.webkit.org/show_bug.cgi?id=57659
  35883. No new functionality added, so no additional tests.
  35884. * platform/network/ResourceRequestBase.h:
  35885. 2011-04-06 David Hyatt <hyatt@apple.com>
  35886. Reviewed by Simon Fraser.
  35887. https://bugs.webkit.org/show_bug.cgi?id=57981
  35888. Update the column count and width computation algorithm for CSS3 multi-column layout
  35889. to match the revised pseudo-algorithm in the latest draft of the spec.
  35890. * rendering/RenderBlock.cpp:
  35891. (WebCore::RenderBlock::calcColumnWidth):
  35892. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  35893. Reviewed by Eric Seidel.
  35894. borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
  35895. https://bugs.webkit.org/show_bug.cgi?id=57965
  35896. Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
  35897. from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
  35898. instead of marginStartForChild and marginEndForChild respectively.
  35899. Calling these two functions on RenderInline is okay because writing-mode cannot differ
  35900. from that of the containing block.
  35901. * rendering/RenderBlockLineLayout.cpp:
  35902. (WebCore::borderPaddingMarginStart):
  35903. (WebCore::borderPaddingMarginEnd):
  35904. (WebCore::inlineLogicalWidth):
  35905. 2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
  35906. Unreviewed, rolling out r83039.
  35907. http://trac.webkit.org/changeset/83039
  35908. https://bugs.webkit.org/show_bug.cgi?id=57978
  35909. introduced a new regression in conjunction to
  35910. ReplaceSelectionCommand (Requested by rniwa on #webkit).
  35911. * editing/EditingStyle.cpp:
  35912. (WebCore::EditingStyle::init):
  35913. * editing/InsertParagraphSeparatorCommand.cpp:
  35914. (WebCore::InsertParagraphSeparatorCommand::doApply):
  35915. 2011-04-06 Naoki Takano <takano.naoki@gmail.com>
  35916. Reviewed by David Levin.
  35917. Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
  35918. https://bugs.webkit.org/show_bug.cgi?id=27658
  35919. Test: fast/events/select-element.html
  35920. * dom/SelectElement.cpp:
  35921. (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines.
  35922. (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index.
  35923. (WebCore::nextSelectableListIndex): Implemented with nextValidIndex.
  35924. And converted to a normal static function from a private function of SelectElement.
  35925. (WebCore::previousSelectableListIndex): Implemented with nextValidIndex.
  35926. And converted to a normal static function from a private function of SelectElement.
  35927. (WebCore::firstSelectableListIndex): Returns the first selectable index.
  35928. (WebCore::lastSelectableListIndex): Returns the last selectable index.
  35929. (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast.
  35930. (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.
  35931. * dom/SelectElement.h:
  35932. (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().
  35933. * rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML.
  35934. They can differ due to the minimum size imposed by RenderListBox.
  35935. 2011-04-06 David Hyatt <hyatt@apple.com>
  35936. Reviewed by Dan Bernstein.
  35937. https://bugs.webkit.org/show_bug.cgi?id=57975
  35938. The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
  35939. to just look at the style, so that it can find the InlineTextBox and not care that it's a child
  35940. of the link element and not the line box for the link element itself (since that line box got
  35941. culled).
  35942. * rendering/RenderFlexibleBox.cpp:
  35943. (WebCore::RenderFlexibleBox::applyLineClamp):
  35944. 2011-04-06 Brady Eidson <beidson@apple.com>
  35945. Reviewed by Anders Carlsson.
  35946. https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
  35947. WK2 icon database should be able to get a CGImage of a specific size
  35948. * platform/graphics/BitmapImage.h:
  35949. * platform/graphics/Image.h:
  35950. (WebCore::Image::getFirstCGImageRefOfSize):
  35951. * platform/graphics/cg/ImageCG.cpp:
  35952. (WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
  35953. first frame of the requested size.
  35954. 2011-04-06 Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
  35955. Reviewed by Kevin Ollivier.
  35956. [wx] Fix cursor handling so that we always call the chrome to set it.
  35957. https://bugs.webkit.org/show_bug.cgi?id=57972
  35958. * platform/wx/WidgetWx.cpp:
  35959. (WebCore::Widget::setCursor):
  35960. 2011-04-06 David Hyatt <hyatt@apple.com>
  35961. Reviewed by Dan Bernstein.
  35962. https://bugs.webkit.org/show_bug.cgi?id=41445
  35963. Visited links painting with black background. Make sure that if the visited style has
  35964. the initial background color (transparent) set that we just use the unvisited color.
  35965. Added fast/history/visited-link-background-color.html
  35966. * rendering/style/RenderStyle.cpp:
  35967. (WebCore::RenderStyle::visitedDependentColor):
  35968. 2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
  35969. Unreviewed Qt buildfix after r83079.
  35970. * WebCore.pro:
  35971. 2011-04-06 Dean Jackson <dino@apple.com>
  35972. Reviewed by Chris Marrin.
  35973. https://bugs.webkit.org/show_bug.cgi?id=56936
  35974. Crash in ImplicitAnimation::~ImplicitAnimation
  35975. Make sure the style and start time waiting lists
  35976. are cleared in the CompositeAnimation destructor. This
  35977. way, no running transitions can be left in a state
  35978. where they are destroyed as the AnimationControllerPrivate
  35979. cleans up.
  35980. * page/animation/CompositeAnimation.cpp:
  35981. (WebCore::CompositeAnimation::~CompositeAnimation):
  35982. 2011-04-06 Robert Sesek <rsesek@chromium.org>
  35983. Reviewed by Alexey Proskuryakov.
  35984. Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
  35985. https://bugs.webkit.org/show_bug.cgi?id=54969
  35986. No change in behavior; no new tests.
  35987. * editing/TextIterator.cpp:
  35988. (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
  35989. * editing/TextIterator.h:
  35990. * page/Frame.cpp:
  35991. (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
  35992. 2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
  35993. Reviewed by Steve Block.
  35994. Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
  35995. https://bugs.webkit.org/show_bug.cgi?id=57770
  35996. Create a template from an existing functionality in JSGeolocationCustom.cpp
  35997. to be used by the custom bindings of both Geolocation and the Media Stream API.
  35998. V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760
  35999. No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
  36000. * Android.jscbindings.mk:
  36001. * CMakeLists.txt:
  36002. * GNUmakefile.am:
  36003. * WebCore.gypi:
  36004. * WebCore.pro:
  36005. * WebCore.vcproj/WebCore.vcproj:
  36006. * WebCore.xcodeproj/project.pbxproj:
  36007. * bindings/js/CallbackFunction.cpp: Added.
  36008. (WebCore::checkFunctionOnlyCallback):
  36009. * bindings/js/CallbackFunction.h: Added.
  36010. (WebCore::createFunctionOnlyCallback):
  36011. * bindings/js/JSBindingsAllInOne.cpp:
  36012. * bindings/js/JSGeolocationCustom.cpp:
  36013. (WebCore::JSGeolocation::getCurrentPosition):
  36014. (WebCore::JSGeolocation::watchPosition):
  36015. 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
  36016. Reviewed by Andreas Kling.
  36017. [Qt] Implement fullscreen playback for the GStreamer backend.
  36018. https://bugs.webkit.org/show_bug.cgi?id=56826
  36019. Implement support for fullscreen playback when building the
  36020. Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
  36021. The implementation is done in FullScreenVideoQt alongside with
  36022. the Qt Multimedia support.
  36023. No new tests because layout tests cover it. They are not yet activated
  36024. but will be any time soon.
  36025. * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  36026. * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
  36027. (FullScreenVideoWindow::FullScreenVideoWindow):
  36028. (FullScreenVideoWindow::setVideoElement):
  36029. (FullScreenVideoWindow::closeEvent):
  36030. (FullScreenVideoWindow::keyPressEvent):
  36031. (FullScreenVideoWindow::event):
  36032. (FullScreenVideoWindow::showFullScreen):
  36033. (FullScreenVideoWindow::hideCursor):
  36034. (FullScreenVideoWindow::showCursor):
  36035. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  36036. Reviewed by Dimitri Glazkov.
  36037. Bundle lineLeftOffset and lineRightOffset as a class
  36038. https://bugs.webkit.org/show_bug.cgi?id=57851
  36039. Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
  36040. The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
  36041. and only the difference is used to compute the width.
  36042. * rendering/RenderBlock.h:
  36043. * rendering/RenderBlockLineLayout.cpp:
  36044. (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
  36045. (WebCore::LineOffsets::LineOffsets): Added.
  36046. (WebCore::LineOffsets::width): Added.
  36047. (WebCore::LineOffsets::setLeft): Added.
  36048. (WebCore::LineOffsets::setRight): Added.
  36049. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
  36050. (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.
  36051. 2011-04-06 David Hyatt <hyatt@apple.com>
  36052. Reviewed by Dan Bernstein.
  36053. https://bugs.webkit.org/show_bug.cgi?id=57916
  36054. Implement an optimization to the line box tree to cull out most of the intermediate
  36055. line boxes that can occur between the root line box and the leaves of the tree (images
  36056. and text).
  36057. RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
  36058. that starts off as false. Only if it gets flipped to true will there be any line boxes
  36059. created for that RenderInline.
  36060. * page/FocusController.cpp:
  36061. (WebCore::FocusController::advanceFocusDirectionally):
  36062. Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
  36063. is up to date.
  36064. * page/SpatialNavigation.cpp:
  36065. (WebCore::hasOffscreenRect):
  36066. (WebCore::nodeRectInAbsoluteCoordinates):
  36067. Add asserts in spatial navigation code to catch any future bad queries that might be made
  36068. for rectangles without layout being up to date.
  36069. * platform/graphics/FloatRect.cpp:
  36070. (WebCore::FloatRect::uniteIfNonZero):
  36071. * platform/graphics/FloatRect.h:
  36072. * platform/graphics/IntRect.cpp:
  36073. (WebCore::IntRect::uniteIfNonZero):
  36074. * platform/graphics/IntRect.h:
  36075. Add a new unite function that is useful for the render tree to FloatRect and IntRect. This
  36076. version allows rect unites to happen if either width or height is nonzero.
  36077. * rendering/HitTestResult.cpp:
  36078. (WebCore::HitTestResult::addNodeToRectBasedTestResult):
  36079. Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
  36080. if content inside those inlines is hit.
  36081. * rendering/InlineBox.h:
  36082. (WebCore::InlineBox::logicalFrameRect):
  36083. Fix a bug in this function for obtaining the logical frame rect of an inline box.
  36084. * rendering/InlineFlowBox.cpp:
  36085. (WebCore::InlineFlowBox::addToLine):
  36086. addToLine now also checks line gap in the line box tree optimization checks.
  36087. (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
  36088. (WebCore::InlineFlowBox::computeOverflow):
  36089. * rendering/InlineFlowBox.h:
  36090. Rewritten to add the text box overflow to the text box itself.
  36091. * rendering/InlineTextBox.cpp:
  36092. (WebCore::InlineTextBox::destroy):
  36093. Destroy has been changed to call a helper function to remove and destroy the line boxes that
  36094. is now called from one additional spot.
  36095. (WebCore::InlineTextBox::logicalOverflowRect):
  36096. (WebCore::InlineTextBox::setLogicalOverflowRect):
  36097. Text boxes now cache their own overflow in a global hash table.
  36098. (WebCore::InlineTextBox::baselinePosition):
  36099. (WebCore::InlineTextBox::lineHeight):
  36100. Changed to not assume that the parent line box's renderer is the RenderText's immediate
  36101. parent, since intermediate line boxes may have been culled.
  36102. (WebCore::InlineTextBox::paint):
  36103. Paint now properly checks only the text box overflow instead of the parent line box's overflow.
  36104. * rendering/InlineTextBox.h:
  36105. (WebCore::InlineTextBox::logicalTopVisualOverflow):
  36106. (WebCore::InlineTextBox::logicalBottomVisualOverflow):
  36107. (WebCore::InlineTextBox::logicalLeftVisualOverflow):
  36108. (WebCore::InlineTextBox::logicalRightVisualOverflow):
  36109. New accessors to obtain overflow for inline text boxes.
  36110. * rendering/RenderBlock.cpp:
  36111. (WebCore::RenderBlock::updateFirstLetter):
  36112. updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
  36113. text boxes may not have anything in between them and the block that contains the inline first letter
  36114. container.
  36115. * rendering/RenderBlockLineLayout.cpp:
  36116. (WebCore::RenderBlock::createLineBoxes):
  36117. The culling optimization is done here. Only if the RenderInline says that boxes are allowed will they
  36118. be created.
  36119. (WebCore::RenderBlock::layoutInlineChildren):
  36120. The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
  36121. This is done before any lines are built.
  36122. * rendering/RenderInline.cpp:
  36123. (WebCore::RenderInline::RenderInline):
  36124. The new m_alwaysCreateLineBoxes flag has been added to the constructor.
  36125. (WebCore::RenderInline::styleDidChange):
  36126. An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
  36127. (like having a layer, borders, padding, margins or backgrounds). Some checks that depend on examining
  36128. the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.
  36129. (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
  36130. The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
  36131. vertical alignment, line height, etc.).
  36132. (WebCore::RenderInline::absoluteRects):
  36133. (WebCore::RenderInline::culledInlineAbsoluteRects):
  36134. absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.
  36135. (WebCore::RenderInline::absoluteQuads):
  36136. (WebCore::RenderInline::culledInlineAbsoluteQuads):
  36137. absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.
  36138. (WebCore::RenderInline::offsetLeft):
  36139. (WebCore::RenderInline::offsetTop):
  36140. offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.
  36141. (WebCore::RenderInline::linesBoundingBox):
  36142. (WebCore::RenderInline::culledInlineBoundingBox):
  36143. lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.
  36144. (WebCore::RenderInline::culledInlineFirstLineBox):
  36145. (WebCore::RenderInline::culledInlineLastLineBox):
  36146. Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
  36147. lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).
  36148. (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
  36149. (WebCore::RenderInline::linesVisualOverflowBoundingBox):
  36150. linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.
  36151. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  36152. The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.
  36153. (WebCore::RenderInline::dirtyLineBoxes):
  36154. dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
  36155. m_alwaysCreateLineBoxes is false.
  36156. (WebCore::RenderInline::createAndAppendInlineFlowBox):
  36157. Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
  36158. when line-box-contain is set to an unusual value.
  36159. (WebCore::RenderInline::addFocusRingRects):
  36160. Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.
  36161. * rendering/RenderInline.h:
  36162. (WebCore::RenderInline::firstLineBoxIncludingCulling):
  36163. (WebCore::RenderInline::lastLineBoxIncludingCulling):
  36164. Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
  36165. is all that needs checking.
  36166. (WebCore::RenderInline::alwaysCreateLineBoxes):
  36167. (WebCore::RenderInline::setAlwaysCreateLineBoxes):
  36168. Functions for getting and setting the m_alwaysCreateLineBoxes flag.
  36169. * rendering/RenderLineBoxList.cpp:
  36170. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  36171. Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
  36172. lines get dirtied.
  36173. * rendering/RenderText.cpp:
  36174. (WebCore::RenderText::removeAndDestroyTextBoxes):
  36175. New helper invoked by destroy and also from updateFirstLetter.
  36176. (WebCore::RenderText::destroy):
  36177. Changed to call removeAndDestroyTextBoxes.
  36178. (WebCore::RenderText::absoluteRects):
  36179. Fixed to be properly physical instead of logical.
  36180. (WebCore::RenderText::linesVisualOverflowBoundingBox):
  36181. New implementation for RenderText that gives the bounding box of the text boxes including overflow from
  36182. shadows, glyphs, text-stroke, etc. Used by RenderInline::culledInlineVisualOverflowBoundingBox.
  36183. * rendering/RenderText.h:
  36184. * rendering/svg/RenderSVGInline.cpp:
  36185. (WebCore::RenderSVGInline::RenderSVGInline):
  36186. RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.
  36187. * rendering/svg/SVGRootInlineBox.cpp:
  36188. (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
  36189. (WebCore::SVGRootInlineBox::layoutChildBoxes):
  36190. Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
  36191. now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).
  36192. 2011-04-05 Enrica Casucci <enrica@apple.com>
  36193. Reviewed by Darin Adler.
  36194. REGRESSION: Drag & Drop Gmail Attachments doesn't work.
  36195. https://bugs.webkit.org/show_bug.cgi?id=57909
  36196. <rdar://problem/9103220>
  36197. In WebKit2 we cannot rely on the value returned by platformData() that
  36198. on Mac returns an NSDraggingInfo object. This is available only in the UI
  36199. process. Therefore we should use m_pasteboard instead.
  36200. We cannot change what platformData() returns on Mac, since there are
  36201. delegate methods that receive a NSDraggingInfo object (only in WebKit).
  36202. * platform/DragData.h:
  36203. (WebCore::DragData::pasteboard): Added.
  36204. * platform/mac/ClipboardMac.mm:
  36205. (WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
  36206. * platform/mac/DragDataMac.mm:
  36207. (WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
  36208. (WebCore::DragData::asURL): Same as above.
  36209. 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
  36210. Reviewed by Darin Adler.
  36211. ClipboardWin has unused variables "ExceptionCode ec"
  36212. https://bugs.webkit.org/show_bug.cgi?id=57952
  36213. Remove the unused variable.
  36214. * platform/win/ClipboardWin.cpp:
  36215. (WebCore::ClipboardWin::declareAndWriteDragImage):
  36216. (WebCore::ClipboardWin::writePlainText):
  36217. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  36218. Reviewed by Dimitri Glazkov.
  36219. Split getBorderPaddingMargin into two functions
  36220. https://bugs.webkit.org/show_bug.cgi?id=57947
  36221. * rendering/RenderBlockLineLayout.cpp:
  36222. (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
  36223. (WebCore::borderPaddingMarginEnd): Ditto.
  36224. (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
  36225. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  36226. 2011-04-06 MORITA Hajime <morrita@google.com>
  36227. Reviewed by Dimitri Glazkov.
  36228. [Refactoring] <progress> should not have manual layout code.
  36229. https://bugs.webkit.org/show_bug.cgi?id=57801
  36230. - Simplified RenderProgress, removing its custom layout code
  36231. - Introducing ProgressValueElement and ProgressBarElement, replacing
  36232. ProgressBarValueElement.
  36233. Now the structure is almost identical to <meter>,
  36234. other than:
  36235. - RenderProgress has animated painting, thus manages its own timer.
  36236. - Both ProgressValueElement and ProgressBarElement has pseudo classes
  36237. which don't changes during its lifetime.
  36238. * Android.mk:
  36239. * CMakeLists.txt:
  36240. * GNUmakefile.am:
  36241. * WebCore.gypi:
  36242. * WebCore.pro:
  36243. * WebCore.vcproj/WebCore.vcproj:
  36244. * WebCore.xcodeproj/project.pbxproj:
  36245. * css/html.css:
  36246. (progress):
  36247. (progress::-webkit-progress-bar):
  36248. (progress::-webkit-progress-value):
  36249. * html/HTMLProgressElement.cpp:
  36250. (WebCore::HTMLProgressElement::~HTMLProgressElement):
  36251. (WebCore::HTMLProgressElement::create):
  36252. (WebCore::HTMLProgressElement::attach):
  36253. (WebCore::HTMLProgressElement::didElementStateChange):
  36254. (WebCore::HTMLProgressElement::createShadowSubtree):
  36255. * html/HTMLProgressElement.h:
  36256. * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
  36257. (WebCore::ProgressShadowElement::ProgressShadowElement):
  36258. (WebCore::ProgressShadowElement::progressElement):
  36259. (WebCore::ProgressShadowElement::rendererIsNeeded):
  36260. (WebCore::ProgressBarElement::shadowPseudoId):
  36261. (WebCore::ProgressValueElement::shadowPseudoId):
  36262. (WebCore::ProgressValueElement::setWidthPercentage):
  36263. * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
  36264. (WebCore::ProgressBarElement::ProgressBarElement):
  36265. (WebCore::ProgressBarElement::create):
  36266. (WebCore::ProgressValueElement::ProgressValueElement):
  36267. (WebCore::ProgressValueElement::create):
  36268. * rendering/RenderProgress.cpp:
  36269. (WebCore::RenderProgress::RenderProgress):
  36270. (WebCore::RenderProgress::updateFromElement):
  36271. (WebCore::RenderProgress::animationTimerFired):
  36272. * rendering/RenderProgress.h:
  36273. (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
  36274. (WebCore::RenderProgress::canHaveChildren):
  36275. 2011-04-06 Mario Sanchez Prada <msanchez@igalia.com>
  36276. Reviewed by Chris Fleizach.
  36277. [GTK] Do not reference AccessibilityRenderObject from platform dependent code
  36278. https://bugs.webkit.org/show_bug.cgi?id=57955
  36279. Do not reference AccessibilityRenderObject from platform specific code
  36280. Added new virtual functions to AccessibilityObject.h and removed
  36281. explicit references to AccessibilityRenderObject from GTK code.
  36282. * accessibility/AccessibilityObject.h:
  36283. (WebCore::AccessibilityObject::renderer): New virtual method,
  36284. returning 0 by default. Overriden by AccessibilityRenderObject.
  36285. (WebCore::AccessibilityObject::correspondingLabelForControlElement):
  36286. New virtual method, returning 0 by default. It complements the
  36287. already present method correspondingControlForLabelElement().
  36288. * accessibility/AccessibilityRenderObject.h:
  36289. (WebCore::AccessibilityRenderObject::renderer): Made virtual.
  36290. * accessibility/gtk/AXObjectCacheAtk.cpp:
  36291. (WebCore::emitTextChanged): Reference AccessibilityObject,
  36292. instead of AccessibilityRenderObject.
  36293. (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
  36294. Ditto.
  36295. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  36296. (webkit_accessible_get_name): Do not reference
  36297. AccessibilityRenderObject.
  36298. (webkit_accessible_get_description): Ditto.
  36299. (setAtkRelationSetFromCoreObject): Ditto.
  36300. (optionFromList): Ditto.
  36301. (optionFromSelection): Ditto.
  36302. (webkit_accessible_selection_clear_selection): Ditto.
  36303. (webkit_accessible_selection_get_selection_count): Ditto.
  36304. (webkit_accessible_selection_select_all_selection): Ditto.
  36305. (textForObject): Ditto.
  36306. (webkit_accessible_text_get_text): Ditto.
  36307. (getPangoLayoutForAtk): Ditto.
  36308. (webkit_accessible_text_get_caret_offset): Ditto.
  36309. (baselinePositionForRenderObject): Ditto.
  36310. (getAttributeSetForAccessibilityObject): Ditto.
  36311. (accessibilityObjectLength): Ditto.
  36312. (getSelectionOffsetsForObject): Ditto.
  36313. (webkit_accessible_text_set_selection): Ditto.
  36314. (webkit_accessible_text_set_caret_offset): Ditto.
  36315. (webkit_accessible_table_get_caption): Ditto.
  36316. (getInterfaceMaskFromObject): Ditto.
  36317. * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
  36318. (getRangeLengthForObject): Ditto.
  36319. Removed unused renderer() method from AccessibilityMenuList.
  36320. * accessibility/AccessibilityMenuList.h: Removed unused method.
  36321. * accessibility/AccessibilityMenuList.cpp: Removed unused method.
  36322. 2011-04-06 Alexander Pavlov <apavlov@chromium.org>
  36323. Reviewed by Pavel Feldman.
  36324. Web Inspector: Javascipt warning link expand and overlap with icons in js console
  36325. https://bugs.webkit.org/show_bug.cgi?id=57939
  36326. * inspector/front-end/inspector.js:
  36327. (WebInspector.linkifyURLAsNode):
  36328. 2011-04-06 Alexander Pavlov <apavlov@chromium.org>
  36329. Reviewed by Pavel Feldman.
  36330. Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
  36331. https://bugs.webkit.org/show_bug.cgi?id=57931
  36332. * inspector/Inspector.json:
  36333. 2011-04-06 Jia Pu <jpu@apple.com>
  36334. Reviewed by Darin Adler.
  36335. [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
  36336. https://bugs.webkit.org/show_bug.cgi?id=57665
  36337. <rdar://problem/7350477>
  36338. We need to track how user modified an autocorrected word. If he changed it back to original
  36339. text, we want to record AutocorrectionReverted response. And if he changed it to something
  36340. else, we want to record AutocorrectionEdited response.
  36341. To achieve this, we need to distringuish between text replacement caused by autocorrection
  36342. from that due to other causes, such as reversion, text substitution, etc. So we added a new
  36343. marker type "Autocorrected". We also need to be able to check for correction, even when we
  36344. don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
  36345. value, "CheckForCorrection".
  36346. We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
  36347. specified range, and of specified type.
  36348. * dom/DocumentMarker.h:
  36349. * dom/DocumentMarkerController.cpp:
  36350. (WebCore::DocumentMarkerController::markersInRange):
  36351. (WebCore::DocumentMarkerController::hasMarkers):
  36352. * dom/DocumentMarkerController.h:
  36353. * editing/Editor.cpp:
  36354. (WebCore::markerTypesForAutocorrection):
  36355. (WebCore::markersHaveIdenticalDescription):
  36356. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  36357. (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
  36358. (WebCore::Editor::changeBackToReplacedString):
  36359. (WebCore::Editor::markMisspellingsAndBadGrammar):
  36360. (WebCore::Editor::applyCorrectionPanelInfo):
  36361. (WebCore::Editor::unappliedSpellCorrection):
  36362. (WebCore::Editor::textCheckingTypeMaskFor):
  36363. * editing/Editor.h:
  36364. * editing/SpellingCorrectionCommand.cpp:
  36365. (WebCore::SpellingCorrectionCommand::doApply):
  36366. 2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
  36367. Unreviewed, rolling out r83045.
  36368. http://trac.webkit.org/changeset/83045
  36369. https://bugs.webkit.org/show_bug.cgi?id=57953
  36370. Broke win layout tests (Requested by podivilov on #webkit).
  36371. * GNUmakefile.am:
  36372. * inspector/front-end/DebuggerPresentationModel.js:
  36373. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  36374. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  36375. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  36376. Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.
  36377. * rendering/RenderBlock.h:
  36378. 2011-03-27 Diego Gonzalez <diegohcg@webkit.org>
  36379. Reviewed by Kenneth Rohde Christiansen.
  36380. [Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
  36381. https://bugs.webkit.org/show_bug.cgi?id=57007
  36382. * CodeGenerators.pri:
  36383. * css/themeQtMobile.css: Removed.
  36384. * platform/qt/QtMobileWebStyle.cpp:
  36385. (drawRectangularControlBackground):
  36386. (QtMobileWebStyle::drawPrimitive):
  36387. (QtMobileWebStyle::drawComplexControl):
  36388. * platform/qt/QtMobileWebStyle.h:
  36389. * platform/qt/RenderThemeQt.cpp:
  36390. (WebCore::RenderThemeQt::isControlStyled):
  36391. (WebCore::RenderThemeQt::paintTextField):
  36392. 2011-04-06 Jia Pu <jpu@apple.com>
  36393. Reviewed by Darin Adler.
  36394. [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
  36395. https://bugs.webkit.org/show_bug.cgi?id=57800
  36396. <rdar://problem/9218223>
  36397. Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
  36398. now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.
  36399. * accessibility/AXObjectCache.h:
  36400. * accessibility/chromium/AXObjectCacheChromium.cpp:
  36401. (WebCore::AXObjectCache::postPlatformNotification):
  36402. * accessibility/mac/AXObjectCacheMac.mm:
  36403. (WebCore::AXObjectCache::postPlatformNotification):
  36404. * editing/Editor.cpp:
  36405. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  36406. 2011-04-06 Martin Robinson <mrobinson@igalia.com>
  36407. Build fix for debug Cairo builds.
  36408. * platform/graphics/cairo/PlatformContextCairo.cpp:
  36409. (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.
  36410. 2011-04-06 Diego Gonzalez <diegohcg@webkit.org>
  36411. Reviewed by Antonio Gomes.
  36412. [Qt] Style fix for QtMobileWebStyle.h
  36413. https://bugs.webkit.org/show_bug.cgi?id=57708
  36414. * platform/qt/QtMobileWebStyle.h:
  36415. 2011-04-06 Andras Becsi <abecsi@webkit.org>
  36416. Reviewed by Darin Adler.
  36417. Invalid color #{predefined colorName} is accepted by the CSS parser.
  36418. https://bugs.webkit.org/show_bug.cgi?id=15360
  36419. Test: fast/css/invalid-predefined-color.html
  36420. * css/CSSGrammar.y: Remove superfluous hexcolor production.
  36421. * css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).
  36422. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  36423. Reviewed by Pavel Feldman.
  36424. Web Inspector: add test for script formatter worker.
  36425. https://bugs.webkit.org/show_bug.cgi?id=57447
  36426. Test: inspector/debugger/script-formatter.html
  36427. * GNUmakefile.am:
  36428. * inspector/front-end/DebuggerPresentationModel.js:
  36429. (WebInspector.DebuggerPresentationModel):
  36430. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  36431. 2011-04-06 Martin Robinson <mrobinson@igalia.com>
  36432. Reviewed by Xan Lopez.
  36433. [Cairo] Hide the details of image masking in PlatformContextCairo
  36434. https://bugs.webkit.org/show_bug.cgi?id=57878
  36435. No new tests. This is just a refactor.
  36436. * platform/graphics/GraphicsContext.h:
  36437. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  36438. (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to
  36439. do the actual cairo_save. Remove information about image masking.
  36440. (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to
  36441. do the actual cairo_restore. Remove information about image masking.
  36442. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  36443. * platform/graphics/cairo/ImageBufferCairo.cpp:
  36444. (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
  36445. * platform/graphics/cairo/PlatformContextCairo.cpp:
  36446. (WebCore::PlatformContextCairo::restore): Added.
  36447. (WebCore::PlatformContextCairo::save): Added.
  36448. (WebCore::PlatformContextCairo::pushImageMask): Added.
  36449. * platform/graphics/cairo/PlatformContextCairo.h:
  36450. (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h.
  36451. (WebCore::ImageMaskInformation::isValid): Ditto.
  36452. (WebCore::ImageMaskInformation::maskSurface): Ditto.
  36453. (WebCore::ImageMaskInformation::maskRect): Ditto.
  36454. 2011-04-02 Diego Gonzalez <diegohcg@webkit.org>
  36455. Reviewed by Csaba Osztrogonác.
  36456. [Qt] Radio buttons are showing wrong with mobile theme
  36457. https://bugs.webkit.org/show_bug.cgi?id=57706
  36458. * platform/qt/QtMobileWebStyle.cpp:
  36459. (QtMobileWebStyle::drawRadio):
  36460. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  36461. Reviewed by Eric Seidel.
  36462. Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
  36463. https://bugs.webkit.org/show_bug.cgi?id=57943
  36464. * rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
  36465. * rendering/RenderBlockLineLayout.cpp:
  36466. (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp
  36467. 2011-04-05 Diego Gonzalez <diegohcg@webkit.org>
  36468. Buildfix after r82125.
  36469. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  36470. https://bugs.webkit.org/show_bug.cgi?id=57087
  36471. * platform/qt/QtMobileWebStyle.cpp:
  36472. (QtMobileWebStyle::findChecker):
  36473. (QtMobileWebStyle::findRadio):
  36474. (QtMobileWebStyle::findComboButton):
  36475. 2011-04-06 Pavel Podivilov <podivilov@chromium.org>
  36476. Reviewed by Yury Semikhatsky.
  36477. Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
  36478. https://bugs.webkit.org/show_bug.cgi?id=57641
  36479. * WebCore.xcodeproj/project.pbxproj:
  36480. * gyp/streamline-inspector-source.sh:
  36481. * inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
  36482. * inspector/inline-javascript-imports.py: Added.
  36483. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
  36484. Reviewed by Eric Seidel.
  36485. REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
  36486. https://bugs.webkit.org/show_bug.cgi?id=57872
  36487. r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
  36488. because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
  36489. r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
  36490. avoiding the tab span.
  36491. Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
  36492. Test: editing/inserting/insert-paragraph-separator-tab-span.html
  36493. * editing/EditingStyle.cpp:
  36494. (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
  36495. * editing/InsertParagraphSeparatorCommand.cpp:
  36496. (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
  36497. separator into a paragraph separator.
  36498. 2011-04-06 Levi Weintraub <leviw@chromium.org>
  36499. Reviewed by Ryosuke Niwa.
  36500. Add member functions for determining line/paragraph separation to InlineIterator
  36501. https://bugs.webkit.org/show_bug.cgi?id=57938
  36502. Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
  36503. InlineIterator, where it makes far more sense for them to be. Also moving
  36504. shouldPreserveNewline to RenderObject and renaming it preservesNewline.
  36505. No new tests as this provides no new functionality.
  36506. * rendering/InlineIterator.h:
  36507. (WebCore::InlineIterator::atTextParagraphSeparator):
  36508. (WebCore::InlineIterator::atParagraphSeparator):
  36509. * rendering/RenderBlockLineLayout.cpp:
  36510. (WebCore::RenderBlock::requiresLineBox):
  36511. (WebCore::RenderBlock::findNextLineBreak):
  36512. * rendering/RenderObject.h:
  36513. (WebCore::RenderObject::preservesNewline):
  36514. 2011-04-05 Alexander Pavlov <apavlov@chromium.org>
  36515. Reviewed by Pavel Feldman.
  36516. Web Inspector: Range insertNode function does not update content in the inspector
  36517. https://bugs.webkit.org/show_bug.cgi?id=57829
  36518. * inspector/InspectorDOMAgent.cpp:
  36519. (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
  36520. (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
  36521. 2011-04-06 Alejandro G. Castro <alex@igalia.com>
  36522. Fix GTK3 compilation after r82962.
  36523. * platform/gtk/RenderThemeGtk3.cpp:
  36524. (WebCore::paintToggle):
  36525. (WebCore::renderButton):
  36526. (WebCore::RenderThemeGtk::paintMenuList):
  36527. (WebCore::RenderThemeGtk::paintTextField):
  36528. (WebCore::RenderThemeGtk::paintSliderTrack):
  36529. (WebCore::RenderThemeGtk::paintSliderThumb):
  36530. (WebCore::RenderThemeGtk::paintProgressBar):
  36531. (WebCore::paintSpinArrowButton):
  36532. * platform/gtk/ScrollbarThemeGtk3.cpp:
  36533. (WebCore::ScrollbarThemeGtk::paintTrackBackground):
  36534. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
  36535. (WebCore::ScrollbarThemeGtk::paintThumb):
  36536. (WebCore::ScrollbarThemeGtk::paintButton):
  36537. 2011-04-06 Andrey Kosyakov <caseq@chromium.org>
  36538. Reviewed by Yury Semikhatsky.
  36539. Web Inspector: [Extensions API] remove inspectedPage.* events
  36540. https://bugs.webkit.org/show_bug.cgi?id=57763
  36541. - Removed webInspector.inspectedPage.* events
  36542. - moved onNavigated to webInspector.resources
  36543. * inspector/front-end/ExtensionAPI.js:
  36544. (WebInspector.injectedExtensionAPI):
  36545. (WebInspector.injectedExtensionAPI.InspectedWindow):
  36546. * inspector/front-end/ExtensionAPISchema.json:
  36547. * inspector/front-end/ExtensionServer.js:
  36548. (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
  36549. * inspector/front-end/inspector.js:
  36550. (WebInspector.domContentEventFired):
  36551. (WebInspector.loadEventFired):
  36552. (WebInspector.inspectedURLChanged):
  36553. 2011-04-06 Joseph Pecoraro <joepeck@webkit.org>
  36554. Reviewed by Antti Koivisto.
  36555. Add <head> to the simpleUserAgentStyleSheet
  36556. https://bugs.webkit.org/show_bug.cgi?id=57915
  36557. * css/CSSStyleSelector.cpp:
  36558. (WebCore::elementCanUseSimpleDefaultStyle): add head to the
  36559. simple stylesheet, display:none.
  36560. 2011-04-05 Mikhail Naganov <mnaganov@chromium.org>
  36561. Reviewed by Pavel Feldman.
  36562. Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
  36563. https://bugs.webkit.org/show_bug.cgi?id=57856
  36564. Test: inspector/profiler/detailed-heapshots-summary.html
  36565. * inspector/front-end/DataGrid.js:
  36566. (WebInspector.DataGrid):
  36567. * inspector/front-end/DetailedHeapshotGridNodes.js:
  36568. (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
  36569. (WebInspector.HeapSnapshotGridNode.prototype._populate):
  36570. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  36571. (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
  36572. (WebInspector.HeapSnapshotGridNode.prototype.sort):
  36573. (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
  36574. * inspector/front-end/DetailedHeapshotView.js:
  36575. (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
  36576. * inspector/front-end/ProfilesPanel.js:
  36577. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
  36578. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  36579. 2011-04-06 Anders Bakken <agbakken@gmail.com>
  36580. Reviewed by David Levin.
  36581. [Qt] SmartReplaceQt.cpp has coding-style errors
  36582. https://bugs.webkit.org/show_bug.cgi?id=40261
  36583. This patch does not require new test cases.
  36584. * editing/qt/SmartReplaceQt.cpp:
  36585. (WebCore::isCharacterSmartReplaceExempt):
  36586. 2011-04-06 Naoki Takano <takano.naoki@gmail.com>
  36587. Reviewed by Ryosuke Niwa.
  36588. REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
  36589. https://bugs.webkit.org/show_bug.cgi?id=57755
  36590. Test: editing/execCommand/insert-line-break-onload.html
  36591. * editing/TypingCommand.cpp:
  36592. (WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().
  36593. 2011-04-05 Antti Koivisto <antti@apple.com>
  36594. Reviewed by Cameron Zwarich.
  36595. Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
  36596. https://bugs.webkit.org/show_bug.cgi?id=57914
  36597. Don't call adjustedDeferredRepaintDelay unnecessarily.
  36598. * page/FrameView.cpp:
  36599. (WebCore::FrameView::repaintContentRectangle):
  36600. (WebCore::FrameView::adjustedDeferredRepaintDelay):
  36601. 2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
  36602. Reviewed by David Levin.
  36603. Update call to SkAdvancedTypefaceMetrics to new API.
  36604. https://bugs.webkit.org/show_bug.cgi?id=57887
  36605. * platform/graphics/chromium/FontPlatformDataLinux.cpp:
  36606. (WebCore::FontPlatformData::emSizeInFontUnits):
  36607. 2011-04-05 Alexey Proskuryakov <ap@apple.com>
  36608. Reviewed by Darin Adler.
  36609. Rename event dispatching functions after form event removal
  36610. https://bugs.webkit.org/show_bug.cgi?id=57908
  36611. * dom/InputElement.cpp:
  36612. (WebCore::InputElement::setValueFromRenderer):
  36613. * dom/Node.cpp:
  36614. (WebCore::Node::dispatchChangeEvent):
  36615. (WebCore::Node::dispatchInputEvent):
  36616. (WebCore::Node::defaultEventHandler):
  36617. * dom/Node.h:
  36618. * html/HTMLFormControlElement.cpp:
  36619. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
  36620. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
  36621. (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
  36622. Renamed "events" to "event", since there is only one event to dispatch now.
  36623. 2011-04-05 Anders Bakken <agbakken@gmail.com>
  36624. Reviewed by David Levin.
  36625. [Qt] DragControllerQt.cpp has coding-style errors
  36626. https://bugs.webkit.org/show_bug.cgi?id=40258
  36627. This patch does not require new test cases.
  36628. * page/qt/DragControllerQt.cpp:
  36629. (WebCore::DragController::dragOperation):
  36630. 2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
  36631. Reviewed by David Levin.
  36632. Update deprecated include: platform_canvas_win.h to platform_canvas.h.
  36633. https://bugs.webkit.org/show_bug.cgi?id=57896
  36634. * platform/graphics/chromium/FontChromiumWin.cpp:
  36635. 2011-04-05 Darin Adler <darin@apple.com>
  36636. Try to fix Leopard bots.
  36637. * platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems
  36638. to have intended it.
  36639. 2011-04-05 Darin Adler <darin@apple.com>
  36640. Try to fix Leopard bots.
  36641. * platform/mac/HTMLConverter.mm: Move declarations of new functions
  36642. inside the appropriate #if.
  36643. 2011-04-05 Adrienne Walker <enne@google.com>
  36644. Reviewed by Tony Chang.
  36645. Correctly set color when using skia's fillRoundedRect.
  36646. https://bugs.webkit.org/show_bug.cgi?id=57907
  36647. * platform/graphics/skia/GraphicsContextSkia.cpp:
  36648. (WebCore::GraphicsContext::fillRoundedRect):
  36649. 2011-04-05 Alexey Proskuryakov <ap@apple.com>
  36650. Reviewed by Darin Adler.
  36651. Move attributedStringFromRange down to WebCore
  36652. https://bugs.webkit.org/show_bug.cgi?id=57905
  36653. No change in behavior, so no new tests.
  36654. Also tweaked HTMLConverter to not use methods defined in WebKit.
  36655. * WebCore.exp.in:
  36656. * WebCore.xcodeproj/project.pbxproj:
  36657. * platform/mac/HTMLConverter.h:
  36658. * platform/mac/HTMLConverter.mm:
  36659. (-[WebHTMLConverter _newTabForElement:]):
  36660. (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
  36661. (+[WebHTMLConverter editingAttributedStringFromRange:]):
  36662. (fileWrapperForURL):
  36663. (fileWrapperForElement):
  36664. * platform/mac/PasteboardMac.mm:
  36665. (WebCore::Pasteboard::writeSelection):
  36666. * platform/mac/WebNSAttributedStringExtras.h: Copied from Source/WebKit/mac/Misc/WebNSAttributedStringExtras.h.
  36667. * platform/mac/WebNSAttributedStringExtras.mm: Copied from Source/WebKit/mac/Misc/WebNSAttributedStringExtras.mm.
  36668. (WebCore::attributedStringByStrippingAttachmentCharacters):
  36669. 2011-04-05 Simon Fraser <simon.fraser@apple.com>
  36670. Reviewed by Darin Adler.
  36671. Rename variables in border drawing code for readability
  36672. https://bugs.webkit.org/show_bug.cgi?id=57894
  36673. * rendering/RenderObject.cpp:
  36674. (WebCore::RenderObject::drawLineForBoxSide):
  36675. (WebCore::RenderObject::drawBoxSideFromPath):
  36676. (WebCore::RenderObject::drawArcForBoxSide):
  36677. 2011-04-05 Antti Koivisto <antti@apple.com>
  36678. Reviewed by Darin Adler.
  36679. Defer repaints during style recalc
  36680. https://bugs.webkit.org/show_bug.cgi?id=57886
  36681. This reduces the need to do (often expensive) platform surface invalidation.
  36682. We already do this during layout but style recalculation may trigger
  36683. invalidation as well.
  36684. * dom/Document.cpp:
  36685. (WebCore::Document::recalcStyle):
  36686. 2011-04-05 Jer Noble <jer.noble@apple.com>
  36687. Reviewed by Darin Adler.
  36688. HTML5 Player Has no Fullscreen Mode
  36689. https://bugs.webkit.org/show_bug.cgi?id=57795
  36690. * html/HTMLVideoElement.cpp:
  36691. (WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API
  36692. supportsFullScreenForElement() before the old supportsFullScreenForNode() API.
  36693. 2011-04-05 Vsevolod Vlasov <vsevik@chromium.org>
  36694. Reviewed by Pavel Feldman.
  36695. Web Inspector: fix data url's status and timing the network panel.
  36696. https://bugs.webkit.org/show_bug.cgi?id=53066
  36697. Added data url support for status of network resources.
  36698. * English.lproj/localizedStrings.js:
  36699. * inspector/front-end/NetworkPanel.js:
  36700. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  36701. * inspector/front-end/Resource.js:
  36702. (WebInspector.Resource.prototype.isDataURL):
  36703. 2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>
  36704. Reviewed by Adam Barth.
  36705. [V8] Keep dirty primitive CSS values alive.
  36706. https://bugs.webkit.org/show_bug.cgi?id=57810
  36707. * bindings/v8/V8GCController.cpp:
  36708. (WebCore::GrouperVisitor::visitDOMWrapper):
  36709. 2011-04-05 Simon Fraser <simon.fraser@apple.com>
  36710. Reviewed by Adele Peterson.
  36711. Add a fast path for simple color backgrounds
  36712. https://bugs.webkit.org/show_bug.cgi?id=57773
  36713. Add a fast path for drawing simple color backgrounds. It's
  36714. faster to fill a path or rect than it is to set up a clip,
  36715. and then paint the rect.
  36716. No visible behavior change so no new tests.
  36717. * rendering/RenderBoxModelObject.cpp:
  36718. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  36719. 2011-04-05 Patrick Gansterer <paroga@webkit.org>
  36720. Unreviewed EFL build fix for r82962.
  36721. * CMakeListsEfl.txt:
  36722. 2011-04-05 Chris Rogers <crogers@google.com>
  36723. Reviewed by Kenneth Russell.
  36724. Add support for offline audio rendering to AudioContext API
  36725. https://bugs.webkit.org/show_bug.cgi?id=57676
  36726. No new tests since audio API is not yet implemented.
  36727. * DerivedSources.make:
  36728. * WebCore.gypi:
  36729. * WebCore.xcodeproj/project.pbxproj:
  36730. * bindings/js/JSAudioContextCustom.cpp:
  36731. (WebCore::JSAudioContextConstructor::constructJSAudioContext):
  36732. * bindings/js/JSEventCustom.cpp:
  36733. (WebCore::toJS):
  36734. * bindings/js/JSEventTarget.cpp:
  36735. (WebCore::toJS):
  36736. * bindings/v8/V8DOMWrapper.cpp:
  36737. (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  36738. * bindings/v8/custom/V8AudioContextCustom.cpp:
  36739. (WebCore::V8AudioContext::constructorCallback):
  36740. * bindings/v8/custom/V8EventCustom.cpp:
  36741. (WebCore::toV8):
  36742. * dom/Event.cpp:
  36743. (WebCore::Event::isOfflineAudioCompletionEvent):
  36744. * dom/Event.h:
  36745. * dom/EventTarget.cpp:
  36746. (WebCore::EventTarget::toAudioContext):
  36747. * dom/EventTarget.h:
  36748. * platform/audio/HRTFDatabaseLoader.cpp:
  36749. (WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
  36750. * platform/audio/HRTFDatabaseLoader.h:
  36751. (WebCore::HRTFDatabaseLoader::loader):
  36752. * webaudio/AudioContext.cpp:
  36753. (WebCore::AudioContext::createOfflineContext):
  36754. (WebCore::AudioContext::AudioContext):
  36755. (WebCore::AudioContext::constructCommon):
  36756. (WebCore::AudioContext::document):
  36757. (WebCore::AudioContext::scriptExecutionContext):
  36758. (WebCore::AudioContext::toAudioContext):
  36759. (WebCore::AudioContext::startRendering):
  36760. (WebCore::AudioContext::fireCompletionEvent):
  36761. * webaudio/AudioContext.h:
  36762. (WebCore::AudioContext::isOfflineContext):
  36763. (WebCore::AudioContext::eventTargetData):
  36764. (WebCore::AudioContext::ensureEventTargetData):
  36765. (WebCore::AudioContext::refEventTarget):
  36766. (WebCore::AudioContext::derefEventTarget):
  36767. * webaudio/AudioContext.idl:
  36768. * webaudio/AudioDestinationNode.cpp:
  36769. (WebCore::AudioDestinationNode::AudioDestinationNode):
  36770. * webaudio/AudioDestinationNode.h:
  36771. (WebCore::AudioDestinationNode::reset):
  36772. (WebCore::AudioDestinationNode::numberOfChannels):
  36773. * webaudio/ConvolverNode.cpp:
  36774. (WebCore::ConvolverNode::setBuffer):
  36775. * webaudio/DefaultAudioDestinationNode.cpp: Added.
  36776. (WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
  36777. (WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode):
  36778. (WebCore::DefaultAudioDestinationNode::initialize):
  36779. (WebCore::DefaultAudioDestinationNode::uninitialize):
  36780. (WebCore::DefaultAudioDestinationNode::startRendering):
  36781. * webaudio/DefaultAudioDestinationNode.h: Added.
  36782. (WebCore::DefaultAudioDestinationNode::create):
  36783. (WebCore::DefaultAudioDestinationNode::sampleRate):
  36784. * webaudio/OfflineAudioCompletionEvent.cpp: Added.
  36785. (WebCore::OfflineAudioCompletionEvent::create):
  36786. (WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
  36787. (WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent):
  36788. (WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent):
  36789. * webaudio/OfflineAudioCompletionEvent.h: Added.
  36790. (WebCore::OfflineAudioCompletionEvent::renderedBuffer):
  36791. * webaudio/OfflineAudioCompletionEvent.idl: Added.
  36792. * webaudio/OfflineAudioDestinationNode.cpp: Added.
  36793. (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
  36794. (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
  36795. (WebCore::OfflineAudioDestinationNode::initialize):
  36796. (WebCore::OfflineAudioDestinationNode::uninitialize):
  36797. (WebCore::OfflineAudioDestinationNode::startRendering):
  36798. (WebCore::OfflineAudioDestinationNode::renderEntry):
  36799. (WebCore::OfflineAudioDestinationNode::render):
  36800. (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
  36801. (WebCore::OfflineAudioDestinationNode::notifyComplete):
  36802. * webaudio/OfflineAudioDestinationNode.h: Added.
  36803. (WebCore::OfflineAudioDestinationNode::create):
  36804. (WebCore::OfflineAudioDestinationNode::sampleRate):
  36805. 2011-04-05 Martin Robinson <mrobinson@igalia.com>
  36806. Reviewed by Eric Seidel.
  36807. [Cairo] Better separate the concerns of GraphicsContextCairo
  36808. https://bugs.webkit.org/show_bug.cgi?id=55150
  36809. Add a PlatformContextCairo which right now stores the cairo_t* for a
  36810. GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
  36811. and image masking layers into this PlatformContextCairo class.
  36812. No new tests. This patch is only a code cleanup.
  36813. * GNUmakefile.am:
  36814. * platform/graphics/GraphicsContext.h: The platform context is no longer a
  36815. cairo_t, but our new class the PlatformContextCairo.
  36816. * platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
  36817. * platform/graphics/cairo/FontCairo.cpp: Ditto.
  36818. * platform/graphics/cairo/GradientCairo.cpp: Ditto.
  36819. * platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical
  36820. changes which now reference platformContext()->cr() to get the cairo_t.
  36821. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the
  36822. PlatformContextCairo instead of the cairo_t.
  36823. * platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
  36824. * platform/graphics/cairo/ImageCairo.cpp: Ditto.
  36825. * platform/graphics/cairo/PathCairo.cpp: Ditto.
  36826. * platform/graphics/cairo/PlatformContextCairo.cpp: Added.
  36827. * platform/graphics/cairo/PlatformContextCairo.h: Added.
  36828. * platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
  36829. * platform/graphics/gtk/IconGtk.cpp: Ditto.
  36830. * platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out
  36831. m_data with a private section containing the platform context instead of
  36832. just a cairo_t.
  36833. * platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
  36834. * platform/gtk/WidgetRenderingContext.cpp: Ditto.
  36835. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
  36836. * plugins/gtk/PluginViewGtk.cpp: Ditto.
  36837. 2011-04-05 David Dorwin <ddorwin@chromium.org>
  36838. Reviewed by David Levin.
  36839. Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)
  36840. https://bugs.webkit.org/show_bug.cgi?id=57400
  36841. Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid.
  36842. Accelerated compositing may be compiled in but disabled at runtime or for some elements.
  36843. Tests: Fullscreen layout tests on Chromium.
  36844. * dom/Document.cpp:
  36845. (WebCore::Document::webkitWillEnterFullScreenForElement):
  36846. (WebCore::Document::webkitDidEnterFullScreenForElement):
  36847. (WebCore::Document::webkitWillExitFullScreenForElement):
  36848. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
  36849. Reviewed by Dirk Schulze.
  36850. Regression: Invalid write in SVGTextLayoutEngine
  36851. https://bugs.webkit.org/show_bug.cgi?id=57721
  36852. Properly stop layout if all metrics object refer to zero-width/height characters,
  36853. which can happen for instance when using <text font-size="0">.
  36854. Test: svg/text/font-size-null-assertion.svg
  36855. * rendering/svg/SVGTextLayoutEngine.cpp:
  36856. (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
  36857. (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
  36858. 2011-04-04 MORITA Hajime <morrita@google.com>
  36859. Reviewed by Ryosuke Niwa.
  36860. [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
  36861. https://bugs.webkit.org/show_bug.cgi?id=56085
  36862. Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
  36863. This change also added TextCheckerClient::requestCheckingOfString() should have
  36864. TextCheckingTypeMask as a parameter to control text checking type.
  36865. * WebCore.exp.in:
  36866. * editing/Editor.cpp:
  36867. (WebCore::Editor::replaceSelectionWithFragment):
  36868. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  36869. (WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
  36870. * editing/SpellChecker.cpp:
  36871. (WebCore::SpellChecker::requestCheckingFor): Added a parameter.
  36872. (WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object.
  36873. (WebCore::SpellChecker::didCheck):
  36874. * editing/SpellChecker.h:
  36875. * loader/EmptyClients.h:
  36876. (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
  36877. (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
  36878. * platform/text/TextCheckerClient.h:
  36879. 2011-04-04 Antti Koivisto <antti@apple.com>
  36880. Reviewed by Sam Weinig.
  36881. Print stylesheet on nytimes.com loads too early
  36882. https://bugs.webkit.org/show_bug.cgi?id=57814
  36883. Don't load resources with Very Low priority until there are no other resources to
  36884. load for the host (or until document is complete enough that we stop limiting requests).
  36885. No tests, this is difficult to observe reliably with our current testing infrastructure.
  36886. Verified working with Wireshark.
  36887. * loader/ResourceLoadScheduler.cpp:
  36888. (WebCore::ResourceLoadScheduler::servePendingRequests):
  36889. (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
  36890. * loader/ResourceLoadScheduler.h:
  36891. 2011-04-04 Steve Block <steveblock@google.com>
  36892. Reviewed by Dimitri Glazkov.
  36893. JavaInstance should be a pure interface
  36894. https://bugs.webkit.org/show_bug.cgi?id=55383
  36895. This patch fixes JavaInstance for V8 only.
  36896. It factors out a JavaInstance interface which does not use JNI
  36897. types. This will allow the Java bridge to be used with objects
  36898. that don't use JNI directly. The existing jobject-backed
  36899. implementation is moved to a new JavaInstanceJobject class which
  36900. implements the interface.
  36901. No new tests, refactoring only.
  36902. * Android.v8bindings.mk:
  36903. * WebCore.gypi:
  36904. * bridge/jni/JobjectWrapper.h:
  36905. * bridge/jni/v8/JNIUtilityPrivate.cpp:
  36906. (JSC::Bindings::jvalueToJavaValue):
  36907. (JSC::Bindings::javaValueToJvalue):
  36908. * bridge/jni/v8/JavaInstanceJobjectV8.cpp:
  36909. (JavaInstanceJobject::JavaInstanceJobject):
  36910. (JavaInstanceJobject::~JavaInstanceJobject):
  36911. (JavaInstanceJobject::begin):
  36912. (JavaInstanceJobject::end):
  36913. (JavaInstanceJobject::getClass):
  36914. (JavaInstanceJobject::invokeMethod):
  36915. (JavaInstanceJobject::getField):
  36916. * bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h.
  36917. (JSC::Bindings::JavaInstanceJobject::javaInstance):
  36918. * bridge/jni/v8/JavaInstanceV8.h:
  36919. (JSC::Bindings::JavaInstance::~JavaInstance):
  36920. 2011-04-05 Dimitri Glazkov <dglazkov@chromium.org>
  36921. Reviewed by Darin Adler.
  36922. Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
  36923. https://bugs.webkit.org/show_bug.cgi?id=57639
  36924. Refactoring, covered by existing tests.
  36925. * dom/EventDispatcher.cpp:
  36926. (WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here
  36927. from dispatchMouseEvent.
  36928. (WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method.
  36929. * dom/EventDispatcher.h: Adjusted decls.
  36930. (WebCore::EventDispatcher::node): Added.
  36931. * dom/MouseEvent.cpp:
  36932. (WebCore::MouseEvent::create): Moved useful assertion here from
  36933. dispatchMouseEvent.
  36934. (WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added.
  36935. (WebCore::MouseEventDispatchMediator::event): Added.
  36936. (WebCore::MouseEventDispatchMediator::dispatchEvent): Added.
  36937. * dom/MouseEvent.h:
  36938. (WebCore::MouseEvent::setRelatedTarget): Added.
  36939. * dom/Node.cpp:
  36940. (WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator.
  36941. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
  36942. Reviewed by Adam Roben & Dirk Schulze.
  36943. text-tspan-02-b.svg from SVG 1.1 2nd edition fails
  36944. https://bugs.webkit.org/show_bug.cgi?id=57831
  36945. We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering.
  36946. While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and
  36947. should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler
  36948. to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the
  36949. required memory.
  36950. Example:
  36951. <text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text>
  36952. text: A B C D E F G H
  36953. rotate="10 20 30 30 30 50 50 50"
  36954. Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
  36955. svg/text/text-midpoint-split-bug.svg
  36956. * rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an
  36957. (WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase.
  36958. * rendering/svg/SVGTextLayoutAttributes.cpp:
  36959. (WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization).
  36960. (WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder.
  36961. (WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto.
  36962. (WebCore::safeValueAtPosition): Ditto. (Inline helper)
  36963. (WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto.
  36964. * rendering/svg/SVGTextLayoutAttributes.h: Ditto.
  36965. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above.
  36966. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree):
  36967. (WebCore::processRenderSVGInlineText):
  36968. (WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
  36969. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters):
  36970. (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
  36971. (WebCore::fillListAtPosition):
  36972. (WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition):
  36973. * rendering/svg/SVGTextLayoutAttributesBuilder.h:
  36974. (WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition):
  36975. 2011-04-05 Levi Weintraub <leviw@chromium.org>
  36976. Reviewed by Ryosuke Niwa.
  36977. DeleteButtonController is given invalid style
  36978. https://bugs.webkit.org/show_bug.cgi?id=57853
  36979. DeleteButtonController was assigned an invalid style that can lead to assertions
  36980. in debug builds. This matches up the code with its intent.
  36981. No new tests as this changes nothing on release builds.
  36982. * editing/DeleteButtonController.cpp:
  36983. (WebCore::DeleteButtonController::createDeletionUI):
  36984. 2011-04-05 Anders Bakken <agbakken@gmail.com>
  36985. Reviewed by Laszlo Gombos.
  36986. [Qt] EditorQt.cpp has coding-style errors
  36987. https://bugs.webkit.org/show_bug.cgi?id=40260
  36988. This patch does not require new test cases.
  36989. * editing/qt/EditorQt.cpp:
  36990. 2011-04-05 Pavel Podivilov <podivilov@chromium.org>
  36991. Reviewed by Pavel Feldman.
  36992. Web Inspector: go to line dialog highlights wrong line.
  36993. https://bugs.webkit.org/show_bug.cgi?id=57845
  36994. * inspector/front-end/GoToLineDialog.js:
  36995. (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
  36996. 2011-04-05 Luke Macpherson <macpherson@chromium.org>
  36997. Reviewed by Dimitri Glazkov.
  36998. Implement CSSPropertyDirection in CSSStyleApplyProperty
  36999. https://bugs.webkit.org/show_bug.cgi?id=57608
  37000. No new tests required as no new functionality introduced.
  37001. * css/CSSStyleApplyProperty.cpp:
  37002. Add implementation class for CSSPropertyDirection
  37003. * css/CSSStyleSelector.cpp:
  37004. Remove existing implementation for CSSPropertyDirection
  37005. * css/CSSStyleSelector.h:
  37006. Add getter for element
  37007. 2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>
  37008. Reviewed by Steve Block.
  37009. Factoring the creation of 'FunctionOnly' callbacks in V8.
  37010. https://bugs.webkit.org/show_bug.cgi?id=57760
  37011. This method creates a template from an existing functionality in V8GeolocationCustom.cpp
  37012. to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.
  37013. No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
  37014. * bindings/v8/V8Utilities.cpp:
  37015. (WebCore::throwTypeMismatchException):
  37016. * bindings/v8/V8Utilities.h:
  37017. (WebCore::createFunctionOnlyCallback):
  37018. * bindings/v8/custom/V8GeolocationCustom.cpp:
  37019. (WebCore::V8Geolocation::getCurrentPositionCallback):
  37020. (WebCore::V8Geolocation::watchPositionCallback):
  37021. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
  37022. Reviewed by Andreas Kling.
  37023. Switch from Vector<UChar> to StringBuilder in bindings/
  37024. https://bugs.webkit.org/show_bug.cgi?id=57838
  37025. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  37026. (WebCore::cssPropertyName):
  37027. * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  37028. (WebCore::cssPropertyInfo):
  37029. 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
  37030. Reviewed by Andreas Kling.
  37031. Switch from Vector<UChar> to StringBuilder in accessibility/
  37032. https://bugs.webkit.org/show_bug.cgi?id=57837
  37033. * accessibility/AccessibilityObject.cpp:
  37034. (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
  37035. (WebCore::AccessibilityObject::stringForVisiblePositionRange):
  37036. * accessibility/AccessibilityRenderObject.cpp:
  37037. (WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
  37038. 2011-04-05 Andrey Adaikin <aandrey@google.com>
  37039. Reviewed by Pavel Feldman.
  37040. Web Inspector: Scripts with syntax errors are cropped in the UI
  37041. https://bugs.webkit.org/show_bug.cgi?id=57828
  37042. * inspector/front-end/SourceFrame.js:
  37043. (WebInspector.SourceFrame.prototype.addMessageToSource):
  37044. 2011-04-05 Alexey Proskuryakov <ap@apple.com>
  37045. Reviewed by Darin Adler.
  37046. Remove onformchange and onforminput events/event handlers
  37047. https://bugs.webkit.org/show_bug.cgi?id=55755
  37048. <rdar://problem/9087969>
  37049. Covered by existing tests.
  37050. * dom/Document.h:
  37051. * dom/Document.idl:
  37052. * dom/Element.h:
  37053. * dom/Element.idl:
  37054. * dom/Event.cpp:
  37055. (WebCore::Event::fromUserGesture):
  37056. * dom/EventNames.h:
  37057. * html/FormAssociatedElement.h:
  37058. * html/HTMLAttributeNames.in:
  37059. * html/HTMLElement.cpp:
  37060. (WebCore::HTMLElement::parseMappedAttribute):
  37061. * html/HTMLElement.h:
  37062. * html/HTMLFormControlElement.h:
  37063. (WebCore::HTMLFormControlElement::isEnumeratable):
  37064. * html/HTMLFormElement.cpp:
  37065. * html/HTMLFormElement.h:
  37066. * html/HTMLFormElement.idl:
  37067. * html/HTMLInputElement.h:
  37068. * html/HTMLKeygenElement.h:
  37069. * html/HTMLObjectElement.h:
  37070. (WebCore::HTMLObjectElement::isEnumeratable):
  37071. * html/HTMLOutputElement.h:
  37072. (WebCore::HTMLOutputElement::isEnumeratable):
  37073. * html/HTMLSelectElement.h:
  37074. (WebCore::HTMLSelectElement::isEnumeratable):
  37075. * html/HTMLTextAreaElement.h:
  37076. (WebCore::HTMLTextAreaElement::isEnumeratable):
  37077. * page/DOMWindow.h:
  37078. * page/DOMWindow.idl:
  37079. 2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
  37080. Unreviewed, rolling out r82915.
  37081. http://trac.webkit.org/changeset/82915
  37082. https://bugs.webkit.org/show_bug.cgi?id=57825
  37083. Broke 270 chromium tests on win and linux (Requested by
  37084. podivilov on #webkit).
  37085. * rendering/RenderThemeChromiumSkia.cpp:
  37086. (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
  37087. 2011-04-05 James Simonsen <simonjam@chromium.org>
  37088. Reviewed by Adam Barth.
  37089. Stop preload scanning CSS when it&apos;s impossible to have another @import.
  37090. https://bugs.webkit.org/show_bug.cgi?id=57664
  37091. @import statements are only allowed at the beginning of a CSS file.
  37092. Only comments or @charset can precede them. After seeing anything else,
  37093. abort early so that we:
  37094. - don't have to parse the rest of the CSS.
  37095. - don't preload something that the regular parser won't load.
  37096. * html/parser/CSSPreloadScanner.cpp:
  37097. (WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports.
  37098. (WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule.
  37099. (WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
  37100. * html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.
  37101. 2011-04-05 Takayoshi Kochi <kochi@chromium.org>
  37102. Reviewed by Tony Chang.
  37103. [chromium] Specify 'sans-serif' as a fallback to the default UI font
  37104. 'Arial' for non-latin UI scripts (e.g. CJK).
  37105. https://bugs.webkit.org/show_bug.cgi?id=55035
  37106. No new tests, because it may still fail if the system is not configured
  37107. properly to resolve 'sans-serif' to existing real font file, thus even
  37108. manual test is hard to systematically tell it is working properly.
  37109. * rendering/RenderThemeChromiumSkia.cpp
  37110. 2011-04-05 Kent Tamura <tkent@chromium.org>
  37111. Reviewed by Dimitri Glazkov.
  37112. Setting defaultValue on a textarea with a modified value still clobbers the value
  37113. https://bugs.webkit.org/show_bug.cgi?id=57636
  37114. If the dirty flag is true, we shouldn't update the value when the
  37115. defaultValue is updated
  37116. Test: fast/forms/textarea-set-defaultvalue-after-value.html
  37117. * html/HTMLTextAreaElement.cpp:
  37118. (WebCore::HTMLTextAreaElement::childrenChanged):
  37119. (WebCore::HTMLTextAreaElement::setDefaultValue):
  37120. 2011-04-04 Kent Tamura <tkent@chromium.org>
  37121. Add a case label which was unexpectedly removed in r82899.
  37122. https://bugs.webkit.org/show_bug.cgi?id=50661
  37123. * css/CSSSelector.cpp:
  37124. (WebCore::CSSSelector::extractPseudoType):
  37125. 2011-04-04 Dan Bernstein <mitz@apple.com>
  37126. Reviewed by Simon Fraser.
  37127. <rdar://problem/7709452> Implement Default Ruby Overhang Behavior
  37128. https://bugs.webkit.org/show_bug.cgi?id=49334
  37129. Tests: fast/ruby/overhang-horizontal.html
  37130. fast/ruby/overhang-vertical.html
  37131. This is a first cut at ruby overhang. It allows ruby text to hang over other
  37132. text of equal or smaller size. Two notable omissions are that max preferred
  37133. width computation was not patched, so it will overshoot, and that overhang
  37134. ignores the width of the adjoining text runs.
  37135. * rendering/RenderBlock.h:
  37136. * rendering/RenderBlockLineLayout.cpp:
  37137. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
  37138. of ruby runs for overhang.
  37139. (WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
  37140. compensate for overhang.
  37141. (WebCore::RenderBlock::findNextLineBreak): When encountering
  37142. a ruby run, increase the line width to account for the fact that overhang will be
  37143. collapsed.
  37144. * rendering/RenderRubyRun.cpp:
  37145. (WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
  37146. the adjoining renderer is text with equal or smaller font size.
  37147. * rendering/RenderRubyRun.h:
  37148. (WebCore::toRenderRubyRun):
  37149. 2011-04-04 David Kilzer <ddkilzer@apple.com>
  37150. <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
  37151. Reviewed by Alexey Proskuryakov.
  37152. * WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
  37153. * platform/mac/WebCoreSystemInterface.h:
  37154. (wkSetHTTPPipeliningMaximumPriority): Added function pointer
  37155. declaration.
  37156. * platform/mac/WebCoreSystemInterface.mm:
  37157. (wkSetHTTPPipeliningMaximumPriority): Added function pointer.
  37158. * platform/network/cf/ResourceRequestCFNet.cpp:
  37159. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
  37160. wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
  37161. pipelining priority.
  37162. * platform/network/cf/ResourceRequestCFNet.h:
  37163. (WebCore::toResourceLoadPriority): Renamed from
  37164. mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to
  37165. to handle Unresolved case.
  37166. (WebCore::toHTTPPipeliningPriority): Renamed from
  37167. mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to
  37168. handle Unresolved case.
  37169. * platform/network/mac/ResourceRequestMac.mm:
  37170. (WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
  37171. use toResourceLoadPriority().
  37172. (WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
  37173. use toHTTPPipeliningPriority(). Moved
  37174. shouldForceHTTPPipeliningPriorityHigh() check into the argument
  37175. of toHTTPPipeliningPriority() instead of hard-coding a
  37176. now-incorrect value.
  37177. 2011-04-04 MORITA Hajime <morrita@google.com>
  37178. Reviewed by Kent Tamura.
  37179. Convert <meter> shadow DOM to a DOM-based shadow.
  37180. https://bugs.webkit.org/show_bug.cgi?id=50661
  37181. Eliminated a large part of <meter> custom layout code,
  37182. which is replaced by a shadow tree.
  37183. Note that the shadow tree is created on construction time and
  37184. will remain during the host HTMLMeterElement lifecycle.
  37185. * Android.mk:
  37186. * CMakeLists.txt:
  37187. * GNUmakefile.am:
  37188. * WebCore.gypi:
  37189. * WebCore.pro:
  37190. * WebCore.vcproj/WebCore.vcproj:
  37191. * WebCore.xcodeproj/project.pbxproj:
  37192. * css/CSSMutableStyleDeclaration.cpp:
  37193. (WebCore::CSSMutableStyleDeclaration::setProperty):
  37194. * css/CSSMutableStyleDeclaration.h:
  37195. * css/CSSSelector.cpp:
  37196. (WebCore::CSSSelector::pseudoId):
  37197. (WebCore::nameToPseudoTypeMap):
  37198. (WebCore::CSSSelector::extractPseudoType):
  37199. * css/CSSSelector.h:
  37200. * css/html.css:
  37201. (meter):
  37202. (meter::-webkit-meter-bar):
  37203. (meter::-webkit-meter-optimum-value):
  37204. (meter::-webkit-meter-suboptimum-value):
  37205. (meter::-webkit-meter-even-less-good-value):
  37206. * html/HTMLMeterElement.cpp:
  37207. (WebCore::HTMLMeterElement::~HTMLMeterElement):
  37208. (WebCore::HTMLMeterElement::parseMappedAttribute):
  37209. (WebCore::HTMLMeterElement::attach):
  37210. (WebCore::HTMLMeterElement::valueRatio):
  37211. (WebCore::HTMLMeterElement::didElementStateChange):
  37212. (WebCore::HTMLMeterElement::createShadowSubtree):
  37213. * html/HTMLMeterElement.h:
  37214. * html/shadow/MeterShadowElement.cpp: Added.
  37215. (WebCore::MeterShadowElement::MeterShadowElement):
  37216. (WebCore::MeterShadowElement::meterElement):
  37217. (WebCore::MeterShadowElement::rendererIsNeeded):
  37218. (WebCore::MeterBarElement::shadowPseudoId):
  37219. (WebCore::MeterValueElement::shadowPseudoId):
  37220. (WebCore::MeterValueElement::setWidthPercentage):
  37221. * html/shadow/MeterShadowElement.h: Added.
  37222. (WebCore::MeterBarElement::MeterBarElement):
  37223. (WebCore::MeterBarElement::create):
  37224. (WebCore::MeterValueElement::MeterValueElement):
  37225. (WebCore::MeterValueElement::create):
  37226. * rendering/RenderMeter.cpp:
  37227. (WebCore::RenderMeter::RenderMeter):
  37228. (WebCore::RenderMeter::~RenderMeter):
  37229. (WebCore::RenderMeter::valueRatio):
  37230. * rendering/RenderMeter.h:
  37231. (WebCore::RenderMeter::renderName):
  37232. (WebCore::RenderMeter::isMeter):
  37233. (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
  37234. (WebCore::RenderMeter::canHaveChildren):
  37235. 2011-04-04 Dimitri Glazkov <dglazkov@chromium.org>
  37236. Reviewed by Adam Barth.
  37237. Introduce EventDispatchMediator abstraction, which encapsulate all
  37238. non-trivial logic around firing a specific type of an event.
  37239. https://bugs.webkit.org/show_bug.cgi?id=57562
  37240. Refactoring, covered by existing tests.
  37241. * dom/Event.cpp:
  37242. (WebCore::EventDispatchMediator::EventDispatchMediator): Added.
  37243. (WebCore::EventDispatchMediator::~EventDispatchMediator): Added.
  37244. (WebCore::EventDispatchMediator::dispatchEvent): Added.
  37245. (WebCore::EventDispatchMediator::event): Added.
  37246. * dom/Event.h: Added decl.
  37247. * dom/EventDispatcher.cpp:
  37248. (WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
  37249. * dom/EventDispatcher.h: Updated decls.
  37250. * dom/KeyboardEvent.cpp:
  37251. (WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added.
  37252. (WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
  37253. * dom/KeyboardEvent.h: Updated decls
  37254. * dom/Node.cpp:
  37255. (WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator.
  37256. (WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
  37257. 2011-04-04 Martin Robinson <mrobinson@igalia.com>
  37258. Reviewed by Xan Lopez.
  37259. [Cairo] Memory leak in RefPtrCairo
  37260. https://bugs.webkit.org/show_bug.cgi?id=57758
  37261. No new tests. This just fixes a memory leak.
  37262. * platform/graphics/cairo/RefPtrCairo.cpp:
  37263. (WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
  37264. 2011-04-04 Adrienne Walker <enne@google.com>
  37265. Unreviewed, rolling out r82880.
  37266. http://trac.webkit.org/changeset/82880
  37267. https://bugs.webkit.org/show_bug.cgi?id=50661
  37268. Meter elements not rendered in Chromium Linux layout tests
  37269. * Android.mk:
  37270. * CMakeLists.txt:
  37271. * GNUmakefile.am:
  37272. * WebCore.gypi:
  37273. * WebCore.pro:
  37274. * WebCore.vcproj/WebCore.vcproj:
  37275. * WebCore.xcodeproj/project.pbxproj:
  37276. * css/CSSMutableStyleDeclaration.cpp:
  37277. * css/CSSMutableStyleDeclaration.h:
  37278. * css/CSSSelector.cpp:
  37279. (WebCore::CSSSelector::pseudoId):
  37280. (WebCore::nameToPseudoTypeMap):
  37281. (WebCore::CSSSelector::extractPseudoType):
  37282. * css/CSSSelector.h:
  37283. * css/html.css:
  37284. (meter):
  37285. (meter::-webkit-meter):
  37286. (meter::-webkit-meter-bar):
  37287. (meter::-webkit-meter-optimum-value):
  37288. (meter::-webkit-meter-suboptimal-value):
  37289. (meter::-webkit-meter-even-less-good-value):
  37290. * html/HTMLMeterElement.cpp:
  37291. (WebCore::HTMLMeterElement::create):
  37292. (WebCore::HTMLMeterElement::parseMappedAttribute):
  37293. (WebCore::HTMLMeterElement::attach):
  37294. * html/HTMLMeterElement.h:
  37295. * html/shadow/MeterShadowElement.cpp: Removed.
  37296. * html/shadow/MeterShadowElement.h: Removed.
  37297. * rendering/RenderMeter.cpp:
  37298. (WebCore::RenderMeter::RenderMeter):
  37299. (WebCore::RenderMeter::~RenderMeter):
  37300. (WebCore::RenderMeter::createPart):
  37301. (WebCore::RenderMeter::updateFromElement):
  37302. (WebCore::RenderMeter::layoutParts):
  37303. (WebCore::RenderMeter::styleDidChange):
  37304. (WebCore::RenderMeter::shouldHaveParts):
  37305. (WebCore::RenderMeter::valueRatio):
  37306. (WebCore::RenderMeter::barPartRect):
  37307. (WebCore::RenderMeter::valuePartRect):
  37308. (WebCore::RenderMeter::valuePseudoId):
  37309. (WebCore::RenderMeter::barPseudoId):
  37310. (WebCore::RenderMeter::detachShadows):
  37311. (WebCore::RenderMeter::updateShadows):
  37312. * rendering/RenderMeter.h:
  37313. (WebCore::RenderMeter::renderName):
  37314. (WebCore::RenderMeter::isMeter):
  37315. (WebCore::RenderMeter::shadowAttached):
  37316. 2011-04-04 Chang Shu <cshu@webkit.org>
  37317. Reviewed by Ryosuke Niwa.
  37318. setContentEditable with true/false/inherit string is not working properly
  37319. https://bugs.webkit.org/show_bug.cgi?id=52058
  37320. Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
  37321. checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
  37322. which does NOT trigger layout and only checks the render style of usermodify. The latter
  37323. updates the layout first to make sure the render style syncs with DOM contenteditable
  37324. attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
  37325. are also updated in the patch. But a complete fix will follow up in bug 57244.
  37326. This patch fixes all the failed layout tests related to set contenteditable.
  37327. * accessibility/AccessibilityRenderObject.cpp:
  37328. (WebCore::AccessibilityRenderObject::isReadOnly):
  37329. * dom/Node.cpp:
  37330. (WebCore::Node::isContentEditable):
  37331. (WebCore::Node::shouldUseInputMethod):
  37332. * dom/Node.h:
  37333. * html/HTMLElement.cpp:
  37334. * html/HTMLElement.h:
  37335. 2011-04-04 Roland Steiner <rolandsteiner@chromium.org>
  37336. Reviewed by Dimitri Glazkov.
  37337. Bug 57689 - Extract scoping functionality from Document
  37338. https://bugs.webkit.org/show_bug.cgi?id=57689
  37339. Moved selfOnlyRef (renamed to guardRef), element ID, image map
  37340. and accesss key functionalities from Document to a new base
  37341. class TreeScope.
  37342. TreeShared: made removedLastRef protected
  37343. No new tests. (refactoring)
  37344. * Android.mk:
  37345. * CMakeLists.txt:
  37346. * GNUmakefile.am:
  37347. * WebCore.gypi:
  37348. * WebCore.pro:
  37349. * WebCore.vcproj/WebCore.vcproj:
  37350. * WebCore.xcodeproj/project.pbxproj:
  37351. * dom/Document.cpp:
  37352. (WebCore::Document::Document):
  37353. (WebCore::Document::destroyScope):
  37354. (WebCore::Document::getElementById):
  37355. (WebCore::Document::childrenChanged):
  37356. (WebCore::Document::scheduleStyleRecalc):
  37357. (WebCore::Document::attach):
  37358. (WebCore::Document::detach):
  37359. * dom/Document.h:
  37360. (WebCore::Node::Node):
  37361. * dom/DocumentOrderedMap.cpp:
  37362. (WebCore::DocumentOrderedMap::get):
  37363. (WebCore::DocumentOrderedMap::getElementById):
  37364. (WebCore::DocumentOrderedMap::getElementByMapName):
  37365. (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  37366. * dom/DocumentOrderedMap.h:
  37367. * dom/DOMAllInOne.cpp:
  37368. * dom/Node.cpp:
  37369. (WebCore::Node::~Node):
  37370. (WebCore::Node::setDocument):
  37371. * dom/Node.h:
  37372. * dom/TreeScope.cpp: Added.
  37373. * dom/TreeScope.h: Added.
  37374. * platform/TreeShared.h:
  37375. (WebCore::TreeShared::removedLastRef): made protected
  37376. 2011-04-04 MORITA Hajime <morrita@google.com>
  37377. Reviewed by Dimitri Glazkov.
  37378. Convert <meter> shadow DOM to a DOM-based shadow.
  37379. https://bugs.webkit.org/show_bug.cgi?id=50661
  37380. Eliminated a large part of <meter> custom layout code,
  37381. which is replaced by a shadow tree.
  37382. Note that the shadow tree is created on construction time and
  37383. will remain during the host HTMLMeterElement lifecycle.
  37384. * Android.mk:
  37385. * CMakeLists.txt:
  37386. * GNUmakefile.am:
  37387. * WebCore.gypi:
  37388. * WebCore.pro:
  37389. * WebCore.vcproj/WebCore.vcproj:
  37390. * WebCore.xcodeproj/project.pbxproj:
  37391. * css/CSSMutableStyleDeclaration.cpp:
  37392. (WebCore::CSSMutableStyleDeclaration::setProperty):
  37393. * css/CSSMutableStyleDeclaration.h:
  37394. * css/CSSSelector.cpp:
  37395. (WebCore::CSSSelector::pseudoId):
  37396. (WebCore::nameToPseudoTypeMap):
  37397. (WebCore::CSSSelector::extractPseudoType):
  37398. * css/CSSSelector.h:
  37399. * css/html.css:
  37400. (meter):
  37401. (meter::-webkit-meter-bar):
  37402. (meter::-webkit-meter-optimum-value):
  37403. (meter::-webkit-meter-suboptimum-value):
  37404. (meter::-webkit-meter-even-less-good-value):
  37405. * html/HTMLMeterElement.cpp:
  37406. (WebCore::HTMLMeterElement::~HTMLMeterElement):
  37407. (WebCore::HTMLMeterElement::parseMappedAttribute):
  37408. (WebCore::HTMLMeterElement::attach):
  37409. (WebCore::HTMLMeterElement::valueRatio):
  37410. (WebCore::HTMLMeterElement::didElementStateChange):
  37411. (WebCore::HTMLMeterElement::createShadowSubtree):
  37412. * html/HTMLMeterElement.h:
  37413. * html/shadow/MeterShadowElement.cpp: Added.
  37414. (WebCore::MeterShadowElement::MeterShadowElement):
  37415. (WebCore::MeterShadowElement::meterElement):
  37416. (WebCore::MeterShadowElement::rendererIsNeeded):
  37417. (WebCore::MeterBarElement::shadowPseudoId):
  37418. (WebCore::MeterValueElement::shadowPseudoId):
  37419. (WebCore::MeterValueElement::setWidthPercentage):
  37420. * html/shadow/MeterShadowElement.h: Added.
  37421. (WebCore::MeterBarElement::MeterBarElement):
  37422. (WebCore::MeterBarElement::create):
  37423. (WebCore::MeterValueElement::MeterValueElement):
  37424. (WebCore::MeterValueElement::create):
  37425. * rendering/RenderMeter.cpp:
  37426. (WebCore::RenderMeter::RenderMeter):
  37427. (WebCore::RenderMeter::~RenderMeter):
  37428. (WebCore::RenderMeter::valueRatio):
  37429. * rendering/RenderMeter.h:
  37430. (WebCore::RenderMeter::renderName):
  37431. (WebCore::RenderMeter::isMeter):
  37432. (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
  37433. (WebCore::RenderMeter::canHaveChildren):
  37434. 2011-04-04 Martin Robinson <mrobinson@igalia.com>
  37435. Reviewed by Gustavo Noronha Silva.
  37436. [GTK] WebGL support
  37437. https://bugs.webkit.org/show_bug.cgi?id=31517
  37438. Add WebGL support for the GTK+ bits of WebCore.
  37439. No new tests. This will be covered by the existing WebGL tests once
  37440. the bots are capable of running WebGL tests.
  37441. * GNUmakefile.am: Added new files required for WebGL support.
  37442. * html/HTMLCanvasElement.cpp:
  37443. (WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not
  37444. yet support accelerated compositing.
  37445. * platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as
  37446. a framework for GTK+.
  37447. * platform/graphics/GraphicsContext3D.h:
  37448. (WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo.
  37449. (WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
  37450. * platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added.
  37451. (WebCore::GraphicsContext3D::getImageData): Added.
  37452. (WebCore::GraphicsContext3D::paintToCanvas): Added.
  37453. * platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension
  37454. functions dynamically. They have different names across the different vendors' GL implementations.
  37455. (WebCore::lookupOpenGLFunctionAddress): Added
  37456. (WebCore::openGLFunctionTable): Added
  37457. (WebCore::initializeOpenGLShims): Added
  37458. * platform/graphics/cairo/OpenGLShims.h: Added.
  37459. * platform/graphics/gtk/DrawingBufferGtk.cpp: Added.
  37460. (WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo.
  37461. (WebCore::DrawingBuffer::~DrawingBuffer): Ditto.
  37462. (WebCore::DrawingBuffer::didReset): Ditto.
  37463. (WebCore::DrawingBuffer::platformColorBuffer): Ditto.
  37464. * platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added.
  37465. (WebCore::GraphicsContext3D::create): Initial implementation.
  37466. (WebCore::GraphicsContext3D::GraphicsContext3D): Ditto.
  37467. (WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto.
  37468. (WebCore::GraphicsContext3D::makeContextCurrent): Ditto.
  37469. (WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto.
  37470. (WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
  37471. * platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added.
  37472. (sharedDisplay): Added this shared display which is required by some
  37473. display drivers.
  37474. (WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D
  37475. contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers.
  37476. (WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto.
  37477. (WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto.
  37478. (WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto.
  37479. (WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL
  37480. context given the current environment.
  37481. (WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer.
  37482. (WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer.
  37483. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation.
  37484. (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto.
  37485. (WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
  37486. * platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
  37487. * platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation.
  37488. (WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
  37489. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  37490. (WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than
  37491. the private bits that are specific to the Apple port.
  37492. 2011-04-04 Alexey Proskuryakov <ap@apple.com>
  37493. Reviewed by Dan Bernstein.
  37494. REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
  37495. https://bugs.webkit.org/show_bug.cgi?id=51230
  37496. <rdar://problem/8780989>
  37497. <rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys
  37498. * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Moved Caps Lock handling from
  37499. WebKits to WebCore, because WebKit shouldn't be smart.
  37500. 2011-04-04 Steve Falkenburg <sfalken@apple.com>
  37501. Fix Windows build warning.
  37502. * WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
  37503. 2011-04-04 Adam Roben <aroben@apple.com>
  37504. Attempted Mac build fix, part III
  37505. * WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
  37506. 2011-04-04 Andy Estes <aestes@apple.com>
  37507. Fix the Mac build.
  37508. * WebCore.exp.in:
  37509. 2011-04-04 David Dorwin <ddorwin@chromium.org>
  37510. Reviewed by David Levin.
  37511. Chromium Mac crashes when entering fullscreen
  37512. https://bugs.webkit.org/show_bug.cgi?id=57483
  37513. Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.
  37514. * WebCore.gyp/WebCore.gyp:
  37515. * rendering/RenderThemeChromiumMac.h:
  37516. * rendering/RenderThemeChromiumMac.mm:
  37517. (WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
  37518. 2011-04-04 Adam Roben <aroben@apple.com>
  37519. Attempted Mac build fix, part II
  37520. * WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and
  37521. PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).
  37522. 2011-04-04 Steve Falkenburg <sfalken@apple.com>
  37523. Reviewed by Adam Roben.
  37524. Remove unused AnalyzeWithLargeStack code from Windows build files
  37525. https://bugs.webkit.org/show_bug.cgi?id=57771
  37526. This was used for us to build with prefast automatically,
  37527. but it is out-of-date and hasn't been used for some time.
  37528. Removing completely for now.
  37529. * WebCore.vcproj/WebCore.vcproj:
  37530. * WebCore.vcproj/WebCorePreBuild.cmd:
  37531. 2011-04-01 Matthew Delaney <mdelaney@apple.com>
  37532. Reviewed by Simon Fraser.
  37533. [CG] Do not accelerate small canvases
  37534. https://bugs.webkit.org/show_bug.cgi?id=57596
  37535. No new tests. No outward behavior changes.
  37536. * platform/graphics/cg/ImageBufferCG.cpp:
  37537. 2011-04-04 Adam Roben <aroben@apple.com>
  37538. Attempted Mac build fix
  37539. * WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private
  37540. so that WebKit can #include them.
  37541. 2011-04-04 Malcolm MacLeod <mmacleod@webmail.co.za>
  37542. Reviewed by Kevin Ollivier.
  37543. [wx] Implement support for temporary files.
  37544. https://bugs.webkit.org/show_bug.cgi?id=57772
  37545. * platform/FileSystem.h:
  37546. * platform/wx/FileSystemWx.cpp:
  37547. (WebCore::getFileModificationTime):
  37548. (WebCore::openTemporaryFile):
  37549. (WebCore::closeFile):
  37550. (WebCore::writeToFile):
  37551. 2011-04-01 Oliver Hunt <oliver@apple.com>
  37552. Reviewed by Geoffrey Garen.
  37553. Make StructureChain GC allocated
  37554. https://bugs.webkit.org/show_bug.cgi?id=56695
  37555. Update for new Structure marking function
  37556. * bindings/js/JSDOMGlobalObject.cpp:
  37557. (WebCore::JSDOMGlobalObject::markChildren):
  37558. 2011-04-04 Pavel Feldman <pfeldman@google.com>
  37559. Reviewed by Yury Semikhatsky.
  37560. Web Inspector: add support for the enumerated types in the protocol.
  37561. https://bugs.webkit.org/show_bug.cgi?id=57761
  37562. * inspector/Inspector.json:
  37563. * inspector/InspectorDebuggerAgent.cpp:
  37564. (WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
  37565. * inspector/InspectorDebuggerAgent.h:
  37566. * inspector/InspectorInstrumentation.cpp:
  37567. (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
  37568. (WebCore::InspectorInstrumentation::scriptImportedImpl):
  37569. * inspector/InspectorResourceAgent.cpp:
  37570. (WebCore::cachedResourceTypeString):
  37571. (WebCore::InspectorResourceAgent::didReceiveResponse):
  37572. (WebCore::InspectorResourceAgent::setInitialScriptContent):
  37573. (WebCore::InspectorResourceAgent::setInitialXHRContent):
  37574. * inspector/InspectorResourceAgent.h:
  37575. * inspector/front-end/ScriptsPanel.js:
  37576. * inspector/generate-inspector-idl:
  37577. 2011-04-04 Yury Semikhatsky <yurys@chromium.org>
  37578. Reviewed by Pavel Feldman.
  37579. Web Inspector: InspectorRuntimeAgent should not depend on Page
  37580. https://bugs.webkit.org/show_bug.cgi?id=57759
  37581. Descendants of InspectorRuntimeAgent should implement a method providing access to the default
  37582. inspected state used for console evaluations.
  37583. * inspector/InspectorAgent.cpp:
  37584. (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
  37585. (WebCore::InspectorAgent::setFrontend):
  37586. * inspector/InspectorAgent.h:
  37587. * inspector/InspectorRuntimeAgent.cpp:
  37588. (WebCore::InspectorRuntimeAgent::create):
  37589. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
  37590. (WebCore::InspectorRuntimeAgent::evaluate):
  37591. * inspector/InspectorRuntimeAgent.h:
  37592. (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
  37593. 2011-04-04 Yong Li <yoli@rim.com>
  37594. Reviewed by Antonio Gomes.
  37595. https://bugs.webkit.org/show_bug.cgi?id=55969
  37596. Fix the issue that document state is not saved when
  37597. going backward and ending up with error page.
  37598. Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
  37599. (For manual test, load a non-existent html first, then load
  37600. fast/history/resources/check-scroll-position.html, then go
  37601. back and go forward. If it doesn't show "SUCCESS" at the bottom
  37602. of the page, your browser has failed the test)
  37603. * loader/FrameLoader.cpp:
  37604. (WebCore::FrameLoader::load):
  37605. 2011-04-04 Sergio Villar Senin <svillar@igalia.com>
  37606. Reviewed by Martin Robinson.
  37607. [GTK] Fix make distcheck for 1.4.0
  37608. https://bugs.webkit.org/show_bug.cgi?id=57750
  37609. Added a missing header file to the Makefile
  37610. * GNUmakefile.am:
  37611. 2011-04-04 Martin Robinson <mrobinson@igalia.com>
  37612. Reviewed by Xan Lopez.
  37613. [GTK] http/tests/plugins/post-url-file.html fails on GTK+
  37614. https://bugs.webkit.org/show_bug.cgi?id=55826
  37615. Correct the implementation of handlePostReadFile which uses GIO APIs and
  37616. actually resizes the buffer to fit the entire size of the file data. This
  37617. was likely leading to memory corruption until now.
  37618. * plugins/gtk/PluginViewGtk.cpp:
  37619. (WebCore::PluginView::handlePostReadFile): Fix this method.
  37620. 2011-04-04 Andrey Kosyakov <caseq@chromium.org>
  37621. Reviewed by Yury Semikhatsky.
  37622. Web Inspector: [Extensions API] add notifications on panels shown/hidden
  37623. https://bugs.webkit.org/show_bug.cgi?id=57752
  37624. * inspector/front-end/ExtensionAPI.js:
  37625. (WebInspector.injectedExtensionAPI.PanelImpl):
  37626. * inspector/front-end/ExtensionServer.js:
  37627. (WebInspector.ExtensionServer.prototype.notifyPanelShown):
  37628. (WebInspector.ExtensionServer.prototype.notifyPanelHidden):
  37629. * inspector/front-end/Panel.js:
  37630. (WebInspector.Panel.prototype.show):
  37631. (WebInspector.Panel.prototype.hide):
  37632. 2011-04-04 Pavel Podivilov <podivilov@chromium.org>
  37633. Reviewed by Yury Semikhatsky.
  37634. Web Inspector: search in resources panel is broken.
  37635. https://bugs.webkit.org/show_bug.cgi?id=57631
  37636. Search in resources panel should trigger source frame content load.
  37637. * inspector/front-end/Panel.js:
  37638. (WebInspector.Panel.prototype.jumpToNextSearchResult):
  37639. (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
  37640. * inspector/front-end/ResourcesPanel.js:
  37641. * inspector/front-end/SearchController.js:
  37642. (WebInspector.SearchController.prototype.handleShortcut):
  37643. (WebInspector.SearchController.prototype.focusSearchField):
  37644. * inspector/front-end/SourceFrame.js:
  37645. (WebInspector.SourceFrame.prototype.show):
  37646. (WebInspector.SourceFrame.prototype._ensureContentLoaded):
  37647. (WebInspector.SourceFrame.prototype.performSearch):
  37648. 2011-04-03 Eric Seidel <eric@webkit.org>
  37649. Reviewed by Ryosuke Niwa.
  37650. Split out UnicodeBidi enum into its own header (to allow use in platform)
  37651. https://bugs.webkit.org/show_bug.cgi?id=57722
  37652. unicode-bidi is a CSS concept. However the same concept is really needed throughout
  37653. the bidi code in platform as well. So I'm moving the enum to platform.
  37654. The only part of the enum which doesn't make much sense to platform/ is "normal".
  37655. * WebCore.xcodeproj/project.pbxproj:
  37656. * css/CSSPrimitiveValueMappings.h:
  37657. * platform/text/UnicodeBidi.h: Added.
  37658. * rendering/style/RenderStyle.h:
  37659. * rendering/style/RenderStyleConstants.h:
  37660. 2011-04-04 Andrey Adaikin <aandrey@google.com>
  37661. Reviewed by Yury Semikhatsky.
  37662. Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
  37663. https://bugs.webkit.org/show_bug.cgi?id=57749
  37664. * inspector/front-end/TextViewer.js:
  37665. (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
  37666. (WebInspector.TextEditorMainPanel.prototype._paintLine):
  37667. 2011-04-04 Alexander Pavlov <apavlov@chromium.org>
  37668. Reviewed by Yury Semikhatsky.
  37669. Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
  37670. https://bugs.webkit.org/show_bug.cgi?id=48525
  37671. * inspector/front-end/Resource.js:
  37672. (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  37673. 2011-04-01 Alexander Pavlov <apavlov@chromium.org>
  37674. Reviewed by Yury Semikhatsky.
  37675. Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
  37676. https://bugs.webkit.org/show_bug.cgi?id=57632
  37677. Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".
  37678. * inspector/front-end/DOMAgent.js:
  37679. (WebInspector.DOMNode.prototype.appropriateSelectorFor):
  37680. * inspector/front-end/EventListenersSidebarPane.js:
  37681. ():
  37682. * inspector/front-end/StylesSidebarPane.js:
  37683. (WebInspector.StylesSidebarPane.prototype.addBlankSection):
  37684. * inspector/front-end/utilities.js:
  37685. 2011-04-04 Andrey Kosyakov <caseq@chromium.org>
  37686. Unreviewed. Followup to an incomplete commit in r82806.
  37687. * inspector/front-end/ExtensionAPI.js:
  37688. (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
  37689. (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
  37690. (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
  37691. (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
  37692. (WebInspector.injectedExtensionAPI):
  37693. * inspector/front-end/ExtensionPanel.js:
  37694. (WebInspector.ExtensionSidebarPane):
  37695. (WebInspector.ExtensionSidebarPane.prototype.setPage):
  37696. (WebInspector.ExtensionSidebarPane.prototype._setObject):
  37697. * inspector/front-end/ExtensionServer.js:
  37698. (WebInspector.ExtensionServer):
  37699. (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
  37700. (WebInspector.ExtensionServer.prototype._onCreatePanel):
  37701. (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
  37702. (WebInspector.ExtensionServer.prototype.createClientIframe):
  37703. (WebInspector.ExtensionServer.prototype._onSetSidebarContent):
  37704. 2011-04-04 Yury Semikhatsky <yurys@chromium.org>
  37705. Unreviewed. Fix Qt minimal build.
  37706. * inspector/InspectorFrontendChannel.h:
  37707. 2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com>
  37708. Reviewed by Yury Semikhatsky.
  37709. Web Inspector: Separate sendMessageToFrontend function
  37710. from InspectorClient to individual interface.
  37711. https://bugs.webkit.org/show_bug.cgi?id=57548
  37712. Refactoring - covered with existing inspector tests.
  37713. * GNUmakefile.am:
  37714. * WebCore.gypi:
  37715. * WebCore.vcproj/WebCore.vcproj:
  37716. * WebCore.xcodeproj/project.pbxproj:
  37717. * inspector/CodeGeneratorInspector.pm:
  37718. * inspector/InspectorClient.h:
  37719. * inspector/InspectorFrontendChannel.h: Added.
  37720. (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
  37721. 2011-04-04 Nico Weber <thakis@chromium.org>
  37722. Reviewed by Eric Seidel.
  37723. Prefer a using directive over qualified names in LocalizedNumberICU.cpp
  37724. https://bugs.webkit.org/show_bug.cgi?id=57742
  37725. Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715
  37726. * platform/text/LocalizedNumberICU.cpp:
  37727. (WebCore::createFormatterForCurrentLocale):
  37728. (WebCore::numberFormatter):
  37729. (WebCore::parseLocalizedNumber):
  37730. (WebCore::formatLocalizedNumber):
  37731. 2011-04-04 Andrey Adaikin <aandrey@google.com>
  37732. Reviewed by Yury Semikhatsky.
  37733. Web Inspector: Breakpoints in the gutter stay static while editing the text
  37734. https://bugs.webkit.org/show_bug.cgi?id=57616
  37735. * inspector/front-end/SourceFrame.js:
  37736. (WebInspector.SourceFrame):
  37737. (WebInspector.SourceFrame.prototype._saveViewerState):
  37738. (WebInspector.SourceFrame.prototype._restoreViewerState):
  37739. (WebInspector.SourceFrame.prototype._endEditing):
  37740. (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
  37741. (WebInspector.SourceFrame.prototype.addBreakpoint):
  37742. (WebInspector.SourceFrame.prototype.removeBreakpoint):
  37743. * inspector/front-end/TextViewer.js:
  37744. (WebInspector.TextViewer.prototype._syncDecorationsForLine):
  37745. (WebInspector):
  37746. (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
  37747. (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
  37748. (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
  37749. (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
  37750. 2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
  37751. Reviewed by Yury Semikhatsky.
  37752. Web Inspector: remove obsolete doc generating code from CodeGenerator.
  37753. https://bugs.webkit.org/show_bug.cgi?id=57748
  37754. * inspector/CodeGeneratorInspector.pm:
  37755. 2011-04-04 Andrey Kosyakov <caseq@chromium.org>
  37756. Reviewed by Yury Semikhatsky.
  37757. Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
  37758. https://bugs.webkit.org/show_bug.cgi?id=57622
  37759. Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
  37760. Fixed wrong getter in schema (scripts -> elements)
  37761. * inspector/front-end/ExtensionAPI.js:
  37762. (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
  37763. (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
  37764. * inspector/front-end/ExtensionAPISchema.json:
  37765. * inspector/front-end/ExtensionServer.js:
  37766. (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
  37767. 2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
  37768. Reviewed by Pavel Feldman.
  37769. Web Inspector: introduce support of 'optional' flag for command arguments.
  37770. https://bugs.webkit.org/show_bug.cgi?id=57698
  37771. * inspector/CodeGeneratorInspector.pm:
  37772. * inspector/Inspector.json:
  37773. * inspector/InspectorDebuggerAgent.cpp:
  37774. (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
  37775. (WebCore::InspectorDebuggerAgent::setBreakpoint):
  37776. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  37777. * inspector/InspectorDebuggerAgent.h:
  37778. * inspector/InspectorPageAgent.cpp:
  37779. (WebCore::InspectorPageAgent::reloadPage):
  37780. * inspector/InspectorPageAgent.h:
  37781. * inspector/InspectorResourceAgent.cpp:
  37782. (WebCore::InspectorResourceAgent::getResourceContent):
  37783. * inspector/InspectorResourceAgent.h:
  37784. * inspector/InspectorRuntimeAgent.cpp:
  37785. (WebCore::InspectorRuntimeAgent::evaluate):
  37786. * inspector/InspectorRuntimeAgent.h:
  37787. * inspector/generate-inspector-idl:
  37788. 2011-04-04 Yury Semikhatsky <yurys@chromium.org>
  37789. Reviewed by Pavel Feldman.
  37790. Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
  37791. https://bugs.webkit.org/show_bug.cgi?id=57637
  37792. * bindings/js/JSInjectedScriptManager.cpp:
  37793. (WebCore::InjectedScriptManager::injectedScriptFor):
  37794. * bindings/v8/custom/V8InjectedScriptManager.cpp:
  37795. (WebCore::InjectedScriptManager::injectedScriptFor):
  37796. * inspector/InjectedScript.cpp:
  37797. (WebCore::InjectedScript::InjectedScript):
  37798. (WebCore::InjectedScript::canAccessInspectedWindow):
  37799. * inspector/InjectedScript.h:
  37800. * inspector/InjectedScriptManager.cpp:
  37801. (WebCore::InjectedScriptManager::createForPage):
  37802. (WebCore::InjectedScriptManager::createForWorker):
  37803. (WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor
  37804. and it depends on which type of context we're inspecting(worker or page).
  37805. (WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
  37806. * inspector/InjectedScriptManager.h:
  37807. * inspector/InspectorController.cpp:
  37808. (WebCore::InspectorController::InspectorController):
  37809. 2011-04-04 Ryuan Choi <ryuan.choi@samsung.com>
  37810. Reviewed by Eric Seidel.
  37811. V8StringCallback.cpp requires V8Binding.h
  37812. https://bugs.webkit.org/show_bug.cgi?id=57699
  37813. No new tests required because of just adding header file.
  37814. * bindings/scripts/CodeGeneratorV8.pm:
  37815. 2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>
  37816. Reviewed by Eric Seidel.
  37817. [CMAKE] Clean duplicated files in WebCore_Sources
  37818. https://bugs.webkit.org/show_bug.cgi?id=57741
  37819. No new tests, Only duplicated files were removed.
  37820. * CMakeLists.txt:
  37821. 2011-04-03 Luke Macpherson <macpherson@chromium.org>
  37822. Reviewed by Darin Adler.
  37823. Fix 2-space indentation introduced in bug 54706.
  37824. https://bugs.webkit.org/show_bug.cgi?id=57740
  37825. No new tests - whitespace changes only.
  37826. * css/CSSStyleSelector.cpp:
  37827. (WebCore::CSSStyleSelector::applyProperty):
  37828. Convert 2-space indentation to 4-space indentation.
  37829. 2011-04-03 Luke Macpherson <macpherson@chromium.org>
  37830. Reviewed by Dimitri Glazkov.
  37831. Make CSSStyleApplyProperty non-copyable
  37832. https://bugs.webkit.org/show_bug.cgi?id=57738
  37833. No new functionality added so no new tests required.
  37834. * css/CSSStyleApplyProperty.h:
  37835. Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
  37836. 2011-04-03 Dan Bernstein <mitz@apple.com>
  37837. Reviewed by Maciej Stachowiak.
  37838. fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
  37839. https://bugs.webkit.org/show_bug.cgi?id=57733
  37840. The crash happens because resetting the page scale as part of preparing the WebView for the
  37841. next test triggered layout, which in turn caused a plug-in to make a resource request, and
  37842. DumpRenderTree's delegate to be dispatched. The delegate doesn’t expect to be called between
  37843. tests, and it references the layout test controller, which is null.
  37844. * page/Frame.cpp:
  37845. (WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn’t changing. This
  37846. is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
  37847. DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
  37848. I think there are currently no such tests, so I am not fixing DumpRenderTree.
  37849. 2011-04-03 Eric Seidel <eric@webkit.org>
  37850. Reviewed by Ryosuke Niwa.
  37851. Teach InlineIterator how to work from any root, not just a RenderBlock
  37852. https://bugs.webkit.org/show_bug.cgi?id=57726
  37853. For implementing bidi-unicode: isolate, we need to be able to run the
  37854. bidi algorithm over a subtree of inlines, not just from a block root.
  37855. This is the first step in making this possible.
  37856. * rendering/InlineIterator.h:
  37857. (WebCore::InlineIterator::InlineIterator):
  37858. (WebCore::InlineIterator::root):
  37859. (WebCore::bidiNext):
  37860. (WebCore::bidiFirst):
  37861. (WebCore::InlineIterator::increment):
  37862. (WebCore::InlineBidiResolver::appendRun):
  37863. * rendering/RenderBlockLineLayout.cpp:
  37864. (WebCore::RenderBlock::findNextLineBreak):
  37865. 2011-04-03 Eric Seidel <eric@webkit.org>
  37866. Reviewed by Dan Bernstein.
  37867. Split out handling of trailing spaces from layoutInlineChildren
  37868. https://bugs.webkit.org/show_bug.cgi?id=57432
  37869. There is much more we could split out from this function, but this is a start.
  37870. I suspect this is very hot code. Hopefully the compiler will do the right thing.
  37871. If it doesn't the Chromium PLT bots will tell us.
  37872. * rendering/RenderBlock.h:
  37873. * rendering/RenderBlockLineLayout.cpp:
  37874. (WebCore::RenderBlock::handleTrailingSpaces):
  37875. (WebCore::RenderBlock::layoutInlineChildren):
  37876. 2011-03-21 Ryosuke Niwa <rniwa@webkit.org>
  37877. Reviewed by Eric Seidel.
  37878. editing commands shouldn't run when there's no body
  37879. https://bugs.webkit.org/show_bug.cgi?id=56771
  37880. The bug was caused by WebKit's not checking the existence of root editable element
  37881. in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
  37882. we should not run editing commands in a document without a body element editable because
  37883. doing so results in appending a non-body element to the document node.
  37884. Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
  37885. New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
  37886. when there are no body element. Since StyleWithCSS is a document's state or property, we allow
  37887. execCommand('StyleWithCSS') even in a document without a body element.
  37888. WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
  37889. Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
  37890. the selection when document.write("x") is ran and successfully inserts image.
  37891. Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
  37892. while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.
  37893. Since Internet Explorer does not allow execCommand to run under design mode properly, we could
  37894. not test its behavior.
  37895. Tests: editing/editability/empty-document-delete.html
  37896. editing/editability/empty-document-justify-right.html
  37897. editing/editability/empty-document-stylewithcss.html
  37898. editing/execCommand/insert-image-with-selecting-document.html
  37899. * editing/Editor.cpp:
  37900. (WebCore::Editor::canEdit): Verify that the root editable element exists
  37901. instead of just checking that selection endpoints are editable because
  37902. selection endpoints could be document node without a body element in design mode
  37903. and we don't want to consider such a document editable.
  37904. (WebCore::Editor::canDelete): Ditto.
  37905. * editing/EditorCommand.cpp:
  37906. (WebCore::enabledInEditableText): Ditto.
  37907. (WebCore::enabledInRichlyEditableText): Ditto.
  37908. (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
  37909. of duplicating the code in order to fix the same bug.
  37910. 2011-04-02 Dan Bernstein <mitz@apple.com>
  37911. Reviewed by Maciej Stachowiak.
  37912. REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
  37913. https://bugs.webkit.org/show_bug.cgi?id=57719
  37914. r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
  37915. that the timeline container is the parent of the time display. This is not true
  37916. with the GTK media style, where the current time display is an inline box, and
  37917. thus wrapped in an anonymous flexible box. The code was incorrectly considering
  37918. the width of the anonymous box and deciding to hide the time display. Prior to
  37919. r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.
  37920. * rendering/MediaControlElements.cpp:
  37921. (WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.
  37922. 2011-04-02 Nico Weber <thakis@chromium.org>
  37923. Reviewed by Adam Barth.
  37924. Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
  37925. By default, ICU includes |using namespace icu;| in its header files
  37926. for backwards compatibility. Clients can define
  37927. U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
  37928. classes with |icu::| makes this file compile no matter what
  37929. U_USING_ICU_NAMESPACE is set to.
  37930. https://bugs.webkit.org/show_bug.cgi?id=57715
  37931. * platform/text/LocalizedNumberICU.cpp:
  37932. (WebCore::createFormatterForCurrentLocale):
  37933. (WebCore::numberFormatter):
  37934. (WebCore::parseLocalizedNumber):
  37935. (WebCore::formatLocalizedNumber):
  37936. 2011-04-02 Dan Bernstein <mitz@apple.com>
  37937. Reviewed by Dave Hyatt.
  37938. Remove an unnecessary extra computeLogicalWidth() from line layout
  37939. https://bugs.webkit.org/show_bug.cgi?id=57711
  37940. Changes in behavior (MathML progression) covered by existing layout tests.
  37941. * rendering/RenderBlockLineLayout.cpp:
  37942. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
  37943. call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
  37944. actually prevents MathML rows from reverting to an incorrect width.
  37945. 2011-04-02 Dan Bernstein <mitz@apple.com>
  37946. Reviewed by Beth Dakin.
  37947. <details> marker loses its margin
  37948. https://bugs.webkit.org/show_bug.cgi?id=57713
  37949. * rendering/RenderDetails.cpp:
  37950. (WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
  37951. the marker location.
  37952. * rendering/RenderDetails.h:
  37953. (WebCore::RenderDetails::renderName): Made private.
  37954. (WebCore::RenderDetails::isDetails): Ditto.
  37955. * rendering/RenderDetailsMarker.cpp:
  37956. (WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
  37957. in the style, like RenderListMarker does.
  37958. (WebCore::RenderDetailsMarker::layout): Set the margins from the style.
  37959. 2011-04-02 Andy Estes <aestes@apple.com>
  37960. Reviewed by Oliver Hunt.
  37961. REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
  37962. https://bugs.webkit.org/show_bug.cgi?id=52518
  37963. Test: fast/images/imagemap-focus-ring-zero-outline-width.html
  37964. * rendering/RenderImage.cpp:
  37965. (WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.
  37966. 2011-04-02 Beth Dakin <bdakin@apple.com>
  37967. Reviewed by Sam Weinig.
  37968. https://bugs.webkit.org/show_bug.cgi?id=57605
  37969. Frame::pageScaleFactor() should not affect getBoundingClientRect() or
  37970. getClientRects()
  37971. -and corresponding-
  37972. <rdar://problem/9194541>
  37973. New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
  37974. * dom/Element.cpp:
  37975. (WebCore::Element::getClientRects):
  37976. (WebCore::Element::getBoundingClientRect):
  37977. * dom/Range.cpp:
  37978. (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
  37979. (WebCore::Range::getBorderAndTextQuads):
  37980. * rendering/RenderObject.h:
  37981. (WebCore::adjustFloatPointForPageScale):
  37982. (WebCore::adjustFloatQuadForPageScale):
  37983. (WebCore::adjustFloatRectForPageScale):
  37984. 2011-04-02 Dan Bernstein <mitz@apple.com>
  37985. Reverted r82775 due to changes in <details> test results, which are
  37986. likely progressions.
  37987. * rendering/RenderBlockLineLayout.cpp:
  37988. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
  37989. 2011-04-02 Dan Bernstein <mitz@apple.com>
  37990. Reviewed by Dave Hyatt.
  37991. Remove an unnecessary extra computeLogicalWidth() from line layout
  37992. https://bugs.webkit.org/show_bug.cgi?id=57711
  37993. Changes in behavior (MathML progression) covered by existing layout tests.
  37994. * rendering/RenderBlockLineLayout.cpp:
  37995. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
  37996. call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
  37997. actually prevents MathML rows from reverting to an incorrect width.
  37998. 2011-04-02 Ryuan Choi <ryuan.choi@samsung.com>
  37999. Reviewed by Martin Robinson.
  38000. [GTK] Fix leaked pointer in FontGtk.cpp
  38001. https://bugs.webkit.org/show_bug.cgi?id=57307
  38002. Fix a memory leak.
  38003. No new functionality, so no new tests.
  38004. * platform/graphics/gtk/FontGtk.cpp:
  38005. (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
  38006. (WebCore::convertUniCharToUTF8):
  38007. 2011-04-02 Ilya Tikhonovsky <loislo@chromium.org>
  38008. Reviewed by Pavel Feldman.
  38009. Web Inspector: we should be able to have in and out arguments of a command with same name.
  38010. https://bugs.webkit.org/show_bug.cgi?id=57701
  38011. * inspector/CodeGeneratorInspector.pm:
  38012. * inspector/Inspector.json:
  38013. 2011-04-01 Ilya Tikhonovsky <loislo@chromium.org>
  38014. Not reviewed trivial change.
  38015. Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
  38016. Followup change for r82281.
  38017. https://bugs.webkit.org/show_bug.cgi?id=57327
  38018. * inspector/InspectorPageAgent.cpp:
  38019. * inspector/InspectorPageAgent.h:
  38020. 2011-04-01 Michael Saboff <msaboff@apple.com>
  38021. Reviewed by Darin Adler.
  38022. Cached Resource Overhead Space Usage and Accounting Inaccurate
  38023. https://bugs.webkit.org/show_bug.cgi?id=57488
  38024. Fixed windows test failures.
  38025. Changed the fixed overhead value for ResourceResponse to 3800 bytes.
  38026. Modified ResourceResponse::platformLazyInit() to handle "base" level
  38027. attributes or all attributes. The base attributes, like URL, status
  38028. code, mime type and a few header fields (mostly cache related) are
  38029. suitable for most resources. This reduces the per resource memory
  38030. needs by over 1K bytes per resource thus saving memory in the cache.
  38031. Collectively, these two changes bring the overhead memory calculation
  38032. in line with reality.
  38033. No new tests added due to existing tests cover areas of change and
  38034. there is no functional change. The change is limited to reducing
  38035. memory usage along existing paths.
  38036. * loader/cache/CachedResource.cpp:
  38037. (WebCore::CachedResource::canUseCacheValidator):
  38038. * platform/network/ResourceResponseBase.cpp:
  38039. (WebCore::ResourceResponseBase::adopt):
  38040. (WebCore::ResourceResponseBase::isHTTP):
  38041. (WebCore::ResourceResponseBase::url):
  38042. (WebCore::ResourceResponseBase::setURL):
  38043. (WebCore::ResourceResponseBase::mimeType):
  38044. (WebCore::ResourceResponseBase::setMimeType):
  38045. (WebCore::ResourceResponseBase::expectedContentLength):
  38046. (WebCore::ResourceResponseBase::setExpectedContentLength):
  38047. (WebCore::ResourceResponseBase::textEncodingName):
  38048. (WebCore::ResourceResponseBase::setTextEncodingName):
  38049. (WebCore::ResourceResponseBase::suggestedFilename):
  38050. (WebCore::ResourceResponseBase::setSuggestedFilename):
  38051. (WebCore::ResourceResponseBase::httpStatusCode):
  38052. (WebCore::ResourceResponseBase::setHTTPStatusCode):
  38053. (WebCore::ResourceResponseBase::httpStatusText):
  38054. (WebCore::ResourceResponseBase::setHTTPStatusText):
  38055. (WebCore::ResourceResponseBase::httpHeaderField):
  38056. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  38057. (WebCore::ResourceResponseBase::httpHeaderFields):
  38058. (WebCore::ResourceResponseBase::parseCacheControlDirectives):
  38059. (WebCore::ResourceResponseBase::hasCacheValidatorFields):
  38060. (WebCore::ResourceResponseBase::date):
  38061. (WebCore::ResourceResponseBase::age):
  38062. (WebCore::ResourceResponseBase::expires):
  38063. (WebCore::ResourceResponseBase::lastModified):
  38064. (WebCore::ResourceResponseBase::isAttachment):
  38065. (WebCore::ResourceResponseBase::setLastModifiedDate):
  38066. (WebCore::ResourceResponseBase::lastModifiedDate):
  38067. (WebCore::ResourceResponseBase::wasCached):
  38068. (WebCore::ResourceResponseBase::connectionReused):
  38069. (WebCore::ResourceResponseBase::setConnectionReused):
  38070. (WebCore::ResourceResponseBase::connectionID):
  38071. (WebCore::ResourceResponseBase::setConnectionID):
  38072. (WebCore::ResourceResponseBase::resourceLoadTiming):
  38073. (WebCore::ResourceResponseBase::setResourceLoadTiming):
  38074. (WebCore::ResourceResponseBase::resourceLoadInfo):
  38075. (WebCore::ResourceResponseBase::setResourceLoadInfo):
  38076. (WebCore::ResourceResponseBase::lazyInit):
  38077. * platform/network/ResourceResponseBase.h:
  38078. (WebCore::ResourceResponseBase::platformLazyInit):
  38079. * platform/network/cf/ResourceResponse.h:
  38080. (WebCore::ResourceResponse::ResourceResponse):
  38081. (WebCore::ResourceResponse::memoryUsage):
  38082. * platform/network/cf/ResourceResponseCFNet.cpp:
  38083. (WebCore::ResourceResponse::platformLazyInit):
  38084. * platform/network/mac/ResourceResponseMac.mm:
  38085. (WebCore::ResourceResponse::platformLazyInit):
  38086. 2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
  38087. Reviewed by Adam Barth.
  38088. https://bugs.webkit.org/show_bug.cgi?id=45855
  38089. Windowless plugins added dynamically to the DOM should receive paint events.
  38090. This is done by ensuring that the plugin widget is marked for painting when
  38091. it is added.
  38092. Test: plugins/windowless_plugin_paint_test.html
  38093. * rendering/RenderWidget.cpp:
  38094. (WebCore::RenderWidget::setWidget):
  38095. 2011-04-01 Mike Reed <reed@google.com>
  38096. Reviewed by James Robinson.
  38097. always use native font rendering on skia_gpu
  38098. fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
  38099. https://bugs.webkit.org/show_bug.cgi?id=57663
  38100. No new tests. existing rendering tests will exercise this
  38101. * platform/graphics/skia/PlatformContextSkia.cpp:
  38102. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  38103. 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
  38104. Unreviewed, rolling out r82712, r82729, and r82746.
  38105. http://trac.webkit.org/changeset/82712
  38106. http://trac.webkit.org/changeset/82729
  38107. http://trac.webkit.org/changeset/82746
  38108. https://bugs.webkit.org/show_bug.cgi?id=57682
  38109. fast/frames/frame-programmatic-noresize.html is failing on
  38110. Windows bots. Will look into this offline. (Requested by dydx
  38111. on #webkit).
  38112. * html/HTMLFrameElement.cpp:
  38113. (WebCore::HTMLFrameElement::HTMLFrameElement):
  38114. (WebCore::HTMLFrameElement::attach):
  38115. (WebCore::HTMLFrameElement::parseMappedAttribute):
  38116. * html/HTMLFrameElement.h:
  38117. (WebCore::HTMLFrameElement::noResize):
  38118. * rendering/RenderFrame.cpp:
  38119. * rendering/RenderFrame.h:
  38120. * rendering/RenderFrameSet.cpp:
  38121. * rendering/RenderFrameSet.h:
  38122. 2011-04-01 Adam Barth <abarth@webkit.org>
  38123. Reviewed by Tony Chang.
  38124. Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
  38125. https://bugs.webkit.org/show_bug.cgi?id=57656
  38126. We should initialize memory when constructing objects.
  38127. * platform/text/StringWithDirection.h:
  38128. (WebCore::StringWithDirection::StringWithDirection):
  38129. 2011-04-01 Jer Noble <jer.noble@apple.com>
  38130. Reviewed by Darin Adler.
  38131. WebKit2: Link from PDF opens in a new tab instead of in the same tab
  38132. https://bugs.webkit.org/show_bug.cgi?id=57528
  38133. * WebCore.exp.in: Export MouseEvent::create().
  38134. 2011-04-01 John Bauman <jbauman@chromium.org>
  38135. Reviewed by Kenneth Russell.
  38136. Avoid decoding images twice in texImage2D
  38137. https://bugs.webkit.org/show_bug.cgi?id=51498
  38138. Make sure to redecode the image only if it's not opaque and texImage2D
  38139. wouldn't premultiply it anyway.
  38140. * platform/graphics/BitmapImage.h:
  38141. * platform/graphics/cg/GraphicsContext3DCG.cpp:
  38142. (WebCore::GraphicsContext3D::getImageData):
  38143. * platform/graphics/skia/GraphicsContext3DSkia.cpp:
  38144. (WebCore::GraphicsContext3D::getImageData):
  38145. 2011-04-01 Alexey Proskuryakov <ap@apple.com>
  38146. 32-bit Mac build fix.
  38147. * dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String
  38148. to avoid ambiguity.
  38149. 2011-04-01 Alexey Proskuryakov <ap@apple.com>
  38150. Reviewed by Darin Adler.
  38151. Make WebKit2 text input handling more like WebKit1
  38152. https://bugs.webkit.org/show_bug.cgi?id=57649
  38153. * dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Put back the assertions
  38154. we used to have. It is dangerous to confuse editor commands and selector names - besides the
  38155. presence of a semicolon, they sometimes have different names, and WebKit2 failed to map those.
  38156. 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
  38157. Unreviewed, rolling out r82711.
  38158. http://trac.webkit.org/changeset/82711
  38159. https://bugs.webkit.org/show_bug.cgi?id=57657
  38160. Made every test crash on XP and Win7 (Requested by
  38161. abarth|gardening on #webkit).
  38162. * loader/cache/CachedResource.cpp:
  38163. (WebCore::CachedResource::canUseCacheValidator):
  38164. * platform/network/ResourceResponseBase.cpp:
  38165. (WebCore::ResourceResponseBase::adopt):
  38166. (WebCore::ResourceResponseBase::isHTTP):
  38167. (WebCore::ResourceResponseBase::url):
  38168. (WebCore::ResourceResponseBase::setURL):
  38169. (WebCore::ResourceResponseBase::mimeType):
  38170. (WebCore::ResourceResponseBase::setMimeType):
  38171. (WebCore::ResourceResponseBase::expectedContentLength):
  38172. (WebCore::ResourceResponseBase::setExpectedContentLength):
  38173. (WebCore::ResourceResponseBase::textEncodingName):
  38174. (WebCore::ResourceResponseBase::setTextEncodingName):
  38175. (WebCore::ResourceResponseBase::suggestedFilename):
  38176. (WebCore::ResourceResponseBase::setSuggestedFilename):
  38177. (WebCore::ResourceResponseBase::httpStatusCode):
  38178. (WebCore::ResourceResponseBase::setHTTPStatusCode):
  38179. (WebCore::ResourceResponseBase::httpStatusText):
  38180. (WebCore::ResourceResponseBase::setHTTPStatusText):
  38181. (WebCore::ResourceResponseBase::httpHeaderField):
  38182. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  38183. (WebCore::ResourceResponseBase::httpHeaderFields):
  38184. (WebCore::ResourceResponseBase::parseCacheControlDirectives):
  38185. (WebCore::ResourceResponseBase::date):
  38186. (WebCore::ResourceResponseBase::age):
  38187. (WebCore::ResourceResponseBase::expires):
  38188. (WebCore::ResourceResponseBase::lastModified):
  38189. (WebCore::ResourceResponseBase::isAttachment):
  38190. (WebCore::ResourceResponseBase::setLastModifiedDate):
  38191. (WebCore::ResourceResponseBase::lastModifiedDate):
  38192. (WebCore::ResourceResponseBase::wasCached):
  38193. (WebCore::ResourceResponseBase::connectionReused):
  38194. (WebCore::ResourceResponseBase::setConnectionReused):
  38195. (WebCore::ResourceResponseBase::connectionID):
  38196. (WebCore::ResourceResponseBase::setConnectionID):
  38197. (WebCore::ResourceResponseBase::resourceLoadTiming):
  38198. (WebCore::ResourceResponseBase::setResourceLoadTiming):
  38199. (WebCore::ResourceResponseBase::resourceLoadInfo):
  38200. (WebCore::ResourceResponseBase::setResourceLoadInfo):
  38201. (WebCore::ResourceResponseBase::lazyInit):
  38202. * platform/network/ResourceResponseBase.h:
  38203. (WebCore::ResourceResponseBase::platformLazyInit):
  38204. * platform/network/cf/ResourceResponse.h:
  38205. (WebCore::ResourceResponse::ResourceResponse):
  38206. (WebCore::ResourceResponse::memoryUsage):
  38207. * platform/network/cf/ResourceResponseCFNet.cpp:
  38208. (WebCore::ResourceResponse::platformLazyInit):
  38209. * platform/network/mac/ResourceResponseMac.mm:
  38210. (WebCore::ResourceResponse::platformLazyInit):
  38211. 2011-04-01 Matthew Delaney <mdelaney@apple.com>
  38212. Reviewed by Simon Fraser.
  38213. Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
  38214. https://bugs.webkit.org/show_bug.cgi?id=57651
  38215. No new tests. This patch does not affect outward behavior.
  38216. * html/canvas/CanvasRenderingContext2D.cpp:
  38217. (WebCore::CanvasRenderingContext2D::isAccelerated):
  38218. * platform/graphics/ImageBuffer.h:
  38219. (WebCore::ImageBuffer::isAccelerated):
  38220. 2011-04-01 Daniel Bates <dbates@rim.com>
  38221. Reviewed by Darin Adler.
  38222. Frame's noResize attribute can not be set by JavaScript
  38223. https://bugs.webkit.org/show_bug.cgi?id=14845
  38224. Tests: fast/frames/frame-inherit-noresize-from-frameset.html
  38225. fast/frames/frame-programmatic-noresize.html
  38226. fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
  38227. fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
  38228. Implements support to programmatically allow and disallow frame resizing.
  38229. Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
  38230. m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
  38231. point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
  38232. frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
  38233. attribute.
  38234. * html/HTMLFrameElement.cpp:
  38235. (WebCore::HTMLFrameElement::HTMLFrameElement):
  38236. (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
  38237. code path isn't performance critical.
  38238. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
  38239. parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
  38240. (WebCore::HTMLFrameElement::parseMappedAttribute):
  38241. * html/HTMLFrameElement.h:
  38242. * rendering/RenderFrame.cpp:
  38243. (WebCore::RenderFrame::updateFromElement): Added.
  38244. * rendering/RenderFrame.h:
  38245. * rendering/RenderFrameSet.cpp:
  38246. (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  38247. * rendering/RenderFrameSet.h:
  38248. 2011-04-01 Michael Saboff <msaboff@apple.com>
  38249. Reviewed by Darin Adler.
  38250. Cached Resource Overhead Space Usage and Accounting Inaccurate
  38251. https://bugs.webkit.org/show_bug.cgi?id=57488
  38252. Changed the fixed overhead value for ResourceResponse to 3800 bytes.
  38253. Modified ResourceResponse::platformLazyInit() to handle "base" level
  38254. attributes or all attributes. The base attributes, like URL, status
  38255. code, mime type and a few header fields (mostly cache related) are
  38256. suitable for most resources. This reduces the per resource memory
  38257. needs by over 1K bytes per resource thus saving memory in the cache.
  38258. Collectively, these two changes bring the overhead memory calculation
  38259. in line with reality.
  38260. No new tests added due to existing tests cover areas of change and
  38261. there is no functional change. The change is limited to reducing
  38262. memory usage along existing paths.
  38263. * loader/cache/CachedResource.cpp:
  38264. (WebCore::CachedResource::canUseCacheValidator):
  38265. * platform/network/ResourceResponseBase.cpp:
  38266. (WebCore::ResourceResponseBase::isHTTP):
  38267. (WebCore::ResourceResponseBase::url):
  38268. (WebCore::ResourceResponseBase::setURL):
  38269. (WebCore::ResourceResponseBase::mimeType):
  38270. (WebCore::ResourceResponseBase::setMimeType):
  38271. (WebCore::ResourceResponseBase::expectedContentLength):
  38272. (WebCore::ResourceResponseBase::setExpectedContentLength):
  38273. (WebCore::ResourceResponseBase::textEncodingName):
  38274. (WebCore::ResourceResponseBase::setTextEncodingName):
  38275. (WebCore::ResourceResponseBase::suggestedFilename):
  38276. (WebCore::ResourceResponseBase::setSuggestedFilename):
  38277. (WebCore::ResourceResponseBase::httpStatusCode):
  38278. (WebCore::ResourceResponseBase::setHTTPStatusCode):
  38279. (WebCore::ResourceResponseBase::httpHeaderField):
  38280. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  38281. (WebCore::ResourceResponseBase::parseCacheControlDirectives):
  38282. (WebCore::ResourceResponseBase::hasCacheValidatorFields):
  38283. (WebCore::ResourceResponseBase::date):
  38284. (WebCore::ResourceResponseBase::age):
  38285. (WebCore::ResourceResponseBase::expires):
  38286. (WebCore::ResourceResponseBase::lastModified):
  38287. (WebCore::ResourceResponseBase::lazyInit):
  38288. * platform/network/ResourceResponseBase.h:
  38289. (WebCore::ResourceResponseBase::platformLazyInit):
  38290. * platform/network/cf/ResourceResponse.h:
  38291. (WebCore::ResourceResponse::ResourceResponse):
  38292. (WebCore::ResourceResponse::memoryUsage):
  38293. * platform/network/cf/ResourceResponseCFNet.cpp:
  38294. * platform/network/mac/ResourceResponseMac.mm:
  38295. (WebCore::ResourceResponse::platformLazyInit):
  38296. 2011-04-01 Timothy Hatcher <timothy@apple.com>
  38297. Make momentum scroll event latching work in WebKit2 on Mac.
  38298. <rdar://problem/8751861>
  38299. Reviewed by Darin Adler.
  38300. * WebCore.exp.in: Remove _wkIsLatchingWheelEvent, add _wkGetNSEventMomentumPhase.
  38301. * page/EventHandler.cpp:
  38302. (WebCore::EventHandler::handleWheelEvent): Set m_useLatchedWheelEventNode based on the
  38303. event's momentumPhase.
  38304. * page/mac/EventHandlerMac.mm:
  38305. (WebCore::EventHandler::wheelEvent): Remove the setting of m_useLatchedWheelEventNode.
  38306. It is now done in EventHandler::handleWheelEvent.
  38307. * platform/mac/WebCoreSystemInterface.h: Remove wkIsLatchingWheelEvent, add wkGetNSEventMomentumPhase.
  38308. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  38309. * platform/mac/WheelEventMac.mm:
  38310. (WebCore::momentumPhaseForEvent): Return a phase on older Mac system by using wkGetNSEventMomentumPhase.
  38311. 2011-04-01 Steve Block <steveblock@google.com>
  38312. Reviewed by Jeremy Orlow.
  38313. JavaClass should be an interface and free of JNI types
  38314. https://bugs.webkit.org/show_bug.cgi?id=57533
  38315. This patch fixes JavaClass for V8 only.
  38316. It factors out a JavaClass interface which does not use JNI types.
  38317. This will allow the Java bridge to be used with objects that
  38318. don't use JNI directly. The existing jobject-backed
  38319. implementation is moved to a new JavaClassJobject class which
  38320. implements the interface.
  38321. No new tests, refactoring only.
  38322. * Android.v8bindings.mk:
  38323. * WebCore.gypi:
  38324. * bridge/jni/v8/JavaClassJobjectV8.cpp:
  38325. (JavaClassJobject::JavaClassJobject):
  38326. (JavaClassJobject::~JavaClassJobject):
  38327. (JavaClassJobject::methodsNamed):
  38328. (JavaClassJobject::fieldNamed):
  38329. * bridge/jni/v8/JavaClassJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaClassV8.h.
  38330. * bridge/jni/v8/JavaClassV8.h:
  38331. (JSC::Bindings::JavaClass::~JavaClass):
  38332. * bridge/jni/v8/JavaInstanceV8.cpp:
  38333. (JavaInstance::getClass):
  38334. 2011-04-01 Jaehun Lim <ljaehun.lim@samsung.com>
  38335. Unreviewed build fix.
  38336. Fix build break when font backend is Pango.
  38337. Pango is missed in changeset 80589.
  38338. https://bugs.webkit.org/show_bug.cgi?id=57609
  38339. * platform/graphics/pango/FontPlatformData.h:
  38340. (WebCore::FontPlatformData::setOrientation):
  38341. 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
  38342. Unreviewed, rolling out r82687.
  38343. http://trac.webkit.org/changeset/82687
  38344. https://bugs.webkit.org/show_bug.cgi?id=57643
  38345. This patch broke accessibility aria-treegrid test in Mac
  38346. (Requested by msanchez on #webkit).
  38347. * accessibility/AccessibilityARIAGrid.cpp:
  38348. * accessibility/AccessibilityARIAGrid.h:
  38349. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  38350. (atkRole):
  38351. * accessibility/mac/AccessibilityObjectWrapper.mm:
  38352. 2011-03-31 Abhishek Arya <inferno@chromium.org>
  38353. Reviewed by Andreas Kling.
  38354. Whenever a relayout is trigger for SVGPath, make sure
  38355. to clear its previous marker layout info. This helps
  38356. to prevent removed markers from being used.
  38357. https://bugs.webkit.org/show_bug.cgi?id=57492
  38358. Test: svg/dom/path-marker-removed-crash.svg
  38359. * rendering/svg/RenderSVGPath.cpp:
  38360. (WebCore::RenderSVGPath::layout):
  38361. * rendering/svg/SVGMarkerLayoutInfo.cpp:
  38362. (WebCore::SVGMarkerLayoutInfo::clear):
  38363. * rendering/svg/SVGMarkerLayoutInfo.h:
  38364. 2011-04-01 Rob Buis <rwlbuis@gmail.com>
  38365. Reviewed by Nikolas Zimmermann.
  38366. https://bugs.webkit.org/show_bug.cgi?id=55750
  38367. SVG <image> referenced by <use> is displayed incorrectly
  38368. Reintroduce old behaviour for valid base URI, for invalid
  38369. keep using document base URI.
  38370. Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.
  38371. Test: svg/custom/image-base-uri.svg
  38372. * svg/SVGImageLoader.cpp:
  38373. (WebCore::SVGImageLoader::sourceURI):
  38374. 2011-04-01 Mario Sanchez Prada <msanchez@igalia.com>
  38375. Reviewed by Chris Fleizach.
  38376. ARIA Grid tables should return GridRole in roleValue() method
  38377. https://bugs.webkit.org/show_bug.cgi?id=57614
  38378. This change does not need any test since it doesn't change anything
  38379. from the point of view of the consumers (Assistive Technoglogies).
  38380. It's just an internal change to simplify identifying HTML and ARIA
  38381. tables by calling to the AccessibilityObject::roleValue method.
  38382. * accessibility/AccessibilityARIAGrid.h:
  38383. * accessibility/AccessibilityARIAGrid.cpp:
  38384. (WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.
  38385. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  38386. (atkRole): Removed unneeded comment.
  38387. * accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to
  38388. NSAccessibilityTableRole, to keep the same behaviour.
  38389. 2011-04-01 MORITA Hajime <morrita@google.com>
  38390. Reviewed by Dimitri Glazkov.
  38391. <meter> can only support horizontal indicator
  38392. https://bugs.webkit.org/show_bug.cgi?id=56001
  38393. - Removed code which deals with the direction and
  38394. left the horizontal path.
  38395. - Removed "horizontal" from related names which is now
  38396. redundant.
  38397. * css/CSSSelector.cpp:
  38398. (WebCore::CSSSelector::pseudoId):
  38399. (WebCore::nameToPseudoTypeMap):
  38400. (WebCore::CSSSelector::extractPseudoType):
  38401. * css/CSSSelector.h:
  38402. * css/html.css:
  38403. (meter::-webkit-meter-bar):
  38404. (meter::-webkit-meter-optimum-value):
  38405. (meter::-webkit-meter-suboptimal-value):
  38406. (meter::-webkit-meter-even-less-good-value):
  38407. * rendering/RenderMeter.cpp:
  38408. (WebCore::RenderMeter::~RenderMeter):
  38409. (WebCore::RenderMeter::createPart):
  38410. (WebCore::RenderMeter::updateFromElement):
  38411. (WebCore::RenderMeter::layoutParts):
  38412. (WebCore::RenderMeter::styleDidChange):
  38413. (WebCore::RenderMeter::shouldHaveParts):
  38414. (WebCore::RenderMeter::valuePartRect):
  38415. (WebCore::RenderMeter::valuePseudoId):
  38416. (WebCore::RenderMeter::barPseudoId):
  38417. (WebCore::RenderMeter::detachShadows):
  38418. (WebCore::RenderMeter::updateShadows):
  38419. * rendering/RenderMeter.h:
  38420. (WebCore::RenderMeter::shadowAttached):
  38421. * rendering/RenderTheme.cpp:
  38422. (WebCore::RenderTheme::supportsMeter):
  38423. * rendering/RenderTheme.h:
  38424. * rendering/RenderThemeMac.h:
  38425. * rendering/RenderThemeMac.mm:
  38426. (WebCore::RenderThemeMac::paintMeter):
  38427. (WebCore::RenderThemeMac::supportsMeter):
  38428. * rendering/style/RenderStyleConstants.h:
  38429. 2011-03-23 Pavel Podivilov <podivilov@chromium.org>
  38430. Reviewed by Pavel Feldman.
  38431. Web Inspector: fix reveal line in formatted script.
  38432. https://bugs.webkit.org/show_bug.cgi?id=56941
  38433. * inspector/front-end/BreakpointsSidebarPane.js:
  38434. (WebInspector.JavaScriptBreakpointsSidebarPane):
  38435. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
  38436. * inspector/front-end/DebuggerPresentationModel.js:
  38437. (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
  38438. * inspector/front-end/NetworkPanel.js:
  38439. (WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
  38440. (WebInspector.NetworkPanel.prototype.showAnchorLocation):
  38441. * inspector/front-end/Panel.js:
  38442. (WebInspector.Panel.prototype.canShowAnchorLocation):
  38443. (WebInspector.Panel.prototype.showAnchorLocation):
  38444. * inspector/front-end/ResourcesPanel.js:
  38445. (WebInspector.ResourcesPanel.prototype.canShowAnchorLocation):
  38446. (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
  38447. (WebInspector.ResourcesPanel.prototype.showResource):
  38448. * inspector/front-end/ScriptsPanel.js:
  38449. (WebInspector.ScriptsPanel):
  38450. (WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
  38451. (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  38452. (WebInspector.ScriptsPanel.prototype._showSourceLine):
  38453. * inspector/front-end/SourceFrame.js:
  38454. (WebInspector.SourceFrame.prototype.highlightLine):
  38455. (WebInspector.SourceFrame.prototype._createTextViewer):
  38456. * inspector/front-end/inspector.js:
  38457. (WebInspector.documentClick.followLink):
  38458. (WebInspector.documentClick):
  38459. (WebInspector._showAnchorLocation):
  38460. 2011-04-01 Pavel Podivilov <podivilov@chromium.org>
  38461. Reviewed by Yury Semikhatsky.
  38462. Web Inspector: make editScriptSource a Script's method.
  38463. https://bugs.webkit.org/show_bug.cgi?id=57615
  38464. * inspector/front-end/DebuggerModel.js:
  38465. (WebInspector.DebuggerModel.prototype.editScriptSource):
  38466. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  38467. * inspector/front-end/Script.js:
  38468. (WebInspector.Script.prototype.requestSource):
  38469. (WebInspector.Script.prototype.editSource):
  38470. 2011-04-01 Pavel Feldman <pfeldman@google.com>
  38471. Reviewed by Yury Semikhatsky.
  38472. Web Inspector: event should have "data" attribute, not "body"
  38473. https://bugs.webkit.org/show_bug.cgi?id=57628
  38474. * inspector/CodeGeneratorInspector.pm:
  38475. 2011-04-01 Pavel Podivilov <podivilov@chromium.org>
  38476. Reviewed by Yury Semikhatsky.
  38477. Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
  38478. https://bugs.webkit.org/show_bug.cgi?id=57610
  38479. * inspector/front-end/BreakpointsSidebarPane.js:
  38480. (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
  38481. 2011-04-01 Alexander Pavlov <apavlov@chromium.org>
  38482. Reviewed by Yury Semikhatsky.
  38483. Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
  38484. https://bugs.webkit.org/show_bug.cgi?id=40522
  38485. Drive-by: fix inc/dec for numbers like ".5"
  38486. Test: inspector/styles/up-down-numerics-and-colors.html
  38487. * inspector/front-end/StylesSidebarPane.js:
  38488. (WebInspector.StylePropertyTreeElement.prototype):
  38489. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  38490. Reviewed by Pavel Feldman.
  38491. Web Inspector: remove dead code from Script.js.
  38492. https://bugs.webkit.org/show_bug.cgi?id=57454
  38493. * inspector/front-end/DebuggerModel.js:
  38494. (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  38495. (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
  38496. * inspector/front-end/Script.js:
  38497. (WebInspector.Script):
  38498. (WebInspector.Script.prototype.requestSource.didGetScriptSource):
  38499. (WebInspector.Script.prototype.requestSource):
  38500. 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
  38501. Unreviewed, rolling out r82667.
  38502. http://trac.webkit.org/changeset/82667
  38503. https://bugs.webkit.org/show_bug.cgi?id=57612
  38504. Breaks Leopard layout tests (Requested by podivilov on
  38505. #webkit).
  38506. * GNUmakefile.am:
  38507. * inspector/front-end/DebuggerPresentationModel.js:
  38508. (WebInspector.DebuggerPresentationModel):
  38509. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  38510. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  38511. Reviewed by Pavel Feldman.
  38512. Web Inspector: remove unused SourceFrameContent class.
  38513. https://bugs.webkit.org/show_bug.cgi?id=57453
  38514. * WebCore.gypi:
  38515. * WebCore.vcproj/WebCore.vcproj:
  38516. * inspector/front-end/ResourceView.js:
  38517. (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  38518. * inspector/front-end/ScriptsPanel.js:
  38519. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  38520. * inspector/front-end/SourceFrame.js:
  38521. (WebInspector.SourceFrame.prototype._createTextViewer):
  38522. * inspector/front-end/SourceFrameContent.js: Removed.
  38523. * inspector/front-end/WebKit.qrc:
  38524. * inspector/front-end/inspector.html:
  38525. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  38526. Reviewed by Pavel Feldman.
  38527. Web Inspector: add test for script formatter worker.
  38528. https://bugs.webkit.org/show_bug.cgi?id=57447
  38529. Test: inspector/debugger/script-formatter.html
  38530. * GNUmakefile.am:
  38531. * inspector/front-end/DebuggerPresentationModel.js:
  38532. (WebInspector.DebuggerPresentationModel):
  38533. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  38534. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  38535. Reviewed by Pavel Feldman.
  38536. Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
  38537. https://bugs.webkit.org/show_bug.cgi?id=57446
  38538. * inspector/front-end/ScriptFormatterWorker.js:
  38539. 2011-04-01 Pavel Podivilov <podivilov@chromium.org>
  38540. Reviewed by Pavel Feldman.
  38541. Web Inspector: allow file access from inspector page so inspector can use workers.
  38542. https://bugs.webkit.org/show_bug.cgi?id=57339
  38543. * inspector/InspectorFrontendClientLocal.cpp:
  38544. (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
  38545. 2011-03-31 Yury Semikhatsky <yurys@chromium.org>
  38546. Reviewed by Pavel Feldman.
  38547. Web Inspector: inspected page crashes on attempt to log object with broken .toString
  38548. https://bugs.webkit.org/show_bug.cgi?id=57557
  38549. If ScriptValue.toString causes a JavaScript exception, the exception is cleared
  38550. before returning from the toString method.
  38551. Test: inspector/console/console-log-toString-object.html
  38552. * bindings/js/ScriptValue.cpp:
  38553. (WebCore::ScriptValue::toString):
  38554. * bindings/js/ScriptValue.h:
  38555. * bindings/v8/ScriptValue.cpp:
  38556. (WebCore::ScriptValue::toString):
  38557. 2011-03-31 Andrey Kosyakov <caseq@chromium.org>
  38558. Reviewed by Pavel Feldman.
  38559. - removed documentWide parameter to querySelector[All]() (user document node id instead)
  38560. - factor out document request logic within DOMAgent into separate method
  38561. - add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
  38562. - use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
  38563. - minor style fixes in Inspector.json
  38564. - more error logging
  38565. Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
  38566. https://bugs.webkit.org/show_bug.cgi?id=57466
  38567. * inspector/Inspector.json:
  38568. * inspector/InspectorDOMAgent.cpp:
  38569. (WebCore::InspectorDOMAgent::querySelector):
  38570. (WebCore::InspectorDOMAgent::querySelectorAll):
  38571. * inspector/InspectorDOMAgent.h:
  38572. * inspector/front-end/AuditRules.js:
  38573. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  38574. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  38575. * inspector/front-end/CSSStyleModel.js:
  38576. (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
  38577. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  38578. (WebInspector.CSSStyleModel.prototype.addRule.callback):
  38579. (WebInspector.CSSStyleModel.prototype.addRule):
  38580. * inspector/front-end/DOMAgent.js:
  38581. (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
  38582. (WebInspector.DOMAgent.prototype.requestDocument):
  38583. (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
  38584. (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
  38585. (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
  38586. (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
  38587. (WebInspector.DOMAgent.prototype.cancelSearch):
  38588. (WebInspector.DOMAgent.prototype.querySelector):
  38589. (WebInspector.DOMAgent.prototype.querySelectorAll):
  38590. 2011-04-01 Kent Tamura <tkent@chromium.org>
  38591. Apply sort-Xcode-project-file.
  38592. * WebCore.xcodeproj/project.pbxproj:
  38593. 2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
  38594. Unreviewed, rolling out r82652.
  38595. http://trac.webkit.org/changeset/82652
  38596. https://bugs.webkit.org/show_bug.cgi?id=57603
  38597. Test still fails (Requested by abarth|gardener on #webkit).
  38598. * rendering/RenderWidget.cpp:
  38599. (WebCore::RenderWidget::setWidget):
  38600. 2011-03-31 Naoki Takano <takano.naoki@gmail.com>
  38601. Reviewed by Kent Tamura.
  38602. REGRESSION (r64712): Safari removes the first blank line in a textarea
  38603. https://bugs.webkit.org/show_bug.cgi?id=56434
  38604. Test: fast/forms/textarea-newline.html
  38605. A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
  38606. But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
  38607. And devalutValue() removal is not needed anymore.
  38608. * html/HTMLTextAreaElement.cpp:
  38609. (WebCore::HTMLTextAreaElement::setDefaultValue): Remove an extra linefeed insertion at the beginning.
  38610. (WebCore::HTMLTextAreaElement::defaultValue): Remove linefeed removal check in default value creation function.
  38611. 2011-03-31 Luke Macpherson <macpherson@chromium.org>
  38612. Reviewed by Dimitri Glazkov.
  38613. Remove refcounting of CSSStyleApplyProperty singleton
  38614. https://bugs.webkit.org/show_bug.cgi?id=57592
  38615. No new tests required as no functionality changes.
  38616. * css/CSSStyleApplyProperty.h:
  38617. 2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
  38618. Reviewed by Adam Barth.
  38619. https://bugs.webkit.org/show_bug.cgi?id=45855
  38620. Windowless plugins added dynamically to the DOM should receive paint events.
  38621. This is done by ensuring that the plugin widget is marked for painting when
  38622. it is added.
  38623. Test: plugins/windowless_plugin_paint_test.html
  38624. * rendering/RenderWidget.cpp:
  38625. (WebCore::RenderWidget::setWidget):
  38626. 2011-03-31 Adam Roben <aroben@apple.com>
  38627. Add a new AbstractCACFLayerTreeHost base class
  38628. This class exposes the interface that LayerChangesFlusher and PlatformCALayer rely on.
  38629. CACFLayerTreeHost now derives from AbstractCACFLayerTreeHost. In the future, WebKit2's
  38630. LayerTreeHostCA will also derive from it (on Windows).
  38631. This should cause no change in behavior.
  38632. Fixes <http://webkit.org/b/57598> Coupling between CACFLayerTreeHost and other CACF-related
  38633. code is too high
  38634. Reviewed by Anders Carlsson.
  38635. * WebCore.vcproj/WebCore.vcproj: Added AbstractCACFLayerTreeHost, and let VS reorder files.
  38636. * platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Added.
  38637. * platform/graphics/ca/win/CACFLayerTreeHost.h: Changed to derive from
  38638. AbstractCACFLayerTreeHost, and annotated the overrides of its functions.
  38639. AbstractCACFLayerTreeHost also allows us to get rid of the friend relationship with
  38640. PlatformCALayer.
  38641. * platform/graphics/ca/win/LayerChangesFlusher.cpp:
  38642. (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
  38643. (WebCore::LayerChangesFlusher::cancelPendingFlush):
  38644. (WebCore::LayerChangesFlusher::hookFired):
  38645. * platform/graphics/ca/win/LayerChangesFlusher.h:
  38646. * platform/graphics/ca/win/PlatformCALayerWin.cpp:
  38647. (layerTreeHostForLayer):
  38648. (PlatformCALayer::rootLayer):
  38649. (PlatformCALayer::setNeedsCommit):
  38650. (PlatformCALayer::addAnimationForKey):
  38651. (PlatformCALayer::removeAnimationForKey):
  38652. Changed to use AbstractCACFLayerTreeHost instead of using CACFLayerTreeHost directly.
  38653. 2011-03-31 Andy Estes <aestes@apple.com>
  38654. Reviewed by Alexey Proskuryakov.
  38655. REGRESSION: Java applet fails to load when <object> has a classid attribute.
  38656. https://bugs.webkit.org/show_bug.cgi?id=52703
  38657. Java applets embedded with the object element sometimes use classid to
  38658. specify their main resource. When this is done, the classid is prefixed
  38659. with "java:". Treat these as supported classids in WebKit.
  38660. Test: java/embedding-java-with-object.html
  38661. * html/HTMLObjectElement.cpp:
  38662. (WebCore::HTMLObjectElement::hasValidClassId): If the MIME type is a
  38663. Java Applet type and the classid starts with "java:", the classid
  38664. should be considered valid.
  38665. 2011-03-31 Brent Fulgham <bfulgham@webkit.org>
  38666. Reviewed Adam Roben.
  38667. [WinCairo] Implement Missing drawWindowsBitmap method.
  38668. https://bugs.webkit.org/show_bug.cgi?id=57409
  38669. * WebCore.vcproj/WebCore.vcproj: Add new DIBPixelData files.
  38670. * platform/graphics/GraphicsContext.h:
  38671. (WebCore::GraphicsContext::WindowsBitmap::buffer):
  38672. (WebCore::GraphicsContext::WindowsBitmap::bufferLength):
  38673. (WebCore::GraphicsContext::WindowsBitmap::size):
  38674. (WebCore::GraphicsContext::WindowsBitmap::bytesPerRow):
  38675. (WebCore::GraphicsContext::WindowsBitmap::bitsPerPixel):
  38676. (WebCore::GraphicsContext::WindowsBitmap::windowsDIB):
  38677. * platform/graphics/win/GraphicsContextCGWin.cpp:
  38678. (WebCore::CGContextWithHDC):
  38679. (WebCore::GraphicsContext::releaseWindowsContext): Modified to use
  38680. new common routines.
  38681. * platform/graphics/win/GraphicsContextCairoWin.cpp:
  38682. (WebCore::drawBitmapToContext): New common drawing implementation.
  38683. (WebCore::GraphicsContext::releaseWindowsContext): Modified to use
  38684. new common routines.
  38685. (WebCore::GraphicsContext::drawWindowsBitmap):
  38686. * platform/graphics/win/GraphicsContextWin.cpp:
  38687. (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): Modified
  38688. to use new DIBPixelData data type.
  38689. * platform/graphics/win/DIBPixelData.cpp: Added.
  38690. (WebCore::DIBPixelData::DIBPixelData):
  38691. (WebCore::DIBPixelData::initialize):
  38692. * platform/graphics/win/DIBPixelData.h: Added.
  38693. (WebCore::DIBPixelData::DIBPixelData):
  38694. (WebCore::DIBPixelData::buffer):
  38695. (WebCore::DIBPixelData::bufferLength):
  38696. (WebCore::DIBPixelData::size):
  38697. (WebCore::DIBPixelData::bytesPerRow):
  38698. (WebCore::DIBPixelData::bitsPerPixel):
  38699. 2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
  38700. Unreviewed, rolling out r81849.
  38701. http://trac.webkit.org/changeset/81849
  38702. https://bugs.webkit.org/show_bug.cgi?id=57588
  38703. CSS Parsing broke with -webkit-calc and introduced crashes
  38704. (Requested by inferno-sec on #webkit).
  38705. * css/CSSGrammar.y:
  38706. * css/CSSParserValues.cpp:
  38707. * css/CSSParserValues.h:
  38708. * css/tokenizer.flex:
  38709. 2011-03-31 Adam Roben <aroben@apple.com>
  38710. Don't ref CACFLayerTreeHosts when telling them to flush layer changes
  38711. LayerChangesFlusher was reffing CACFLayerTreeHosts before calling out to them. This would
  38712. have protected us if calling out to one CACFLayerTreeHost could cause a different
  38713. CACFLayerTreeHost to be destroyed. But that isn't possible; each CACFLayerTreeHost is
  38714. associated with its own page, and flushing layer changes doesn't touch any other page. So it
  38715. isn't possible for a CACFLayerTreeHost to be deleted while another one is flushing layer
  38716. changes.
  38717. One benefit of this change is that it will make it easier to make LayerChangesFlusher
  38718. interact with a forthcoming abstract base class, rather than with CACFLayerTreeHost itself.
  38719. This should cause no change in behavior.
  38720. Fixes <http://webkit.org/b/57590> LayerChangesFlusher unnecessarily refs CACFLayerTreeHost
  38721. before calling out to it
  38722. Reviewed by Darin Adler.
  38723. * platform/graphics/ca/win/LayerChangesFlusher.cpp:
  38724. (WebCore::LayerChangesFlusher::hookFired): Just store bare pointers to the
  38725. CACFLayerTreeHosts.
  38726. 2011-03-31 Antti Koivisto <antti@apple.com>
  38727. Reviewed by Oliver Hunt.
  38728. https://bugs.webkit.org/show_bug.cgi?id=57574
  38729. Preload scanner fails to pick up resources from document.write() output
  38730. - Scan script inserted source using a separate preload scanner.
  38731. - Make the main preload scanner correctly process the remaining source if script execution blocked the parser.
  38732. Tests: fast/preloader/document-write-2.html
  38733. fast/preloader/document-write.html
  38734. * html/parser/HTMLDocumentParser.cpp:
  38735. (WebCore::HTMLDocumentParser::insert):
  38736. (WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
  38737. * html/parser/HTMLDocumentParser.h:
  38738. (WebCore::HTMLDocumentParser::hasPreloadScanner):
  38739. * html/parser/HTMLScriptRunner.cpp:
  38740. (WebCore::HTMLScriptRunner::execute):
  38741. * html/parser/HTMLScriptRunnerHost.h:
  38742. 2011-03-31 Tony Gentilcore <tonyg@chromium.org>
  38743. Build fix: Add missing include
  38744. https://bugs.webkit.org/show_bug.cgi?id=57587
  38745. * loader/cache/CachedResourceLoader.cpp:
  38746. 2011-03-31 Tony Gentilcore <tonyg@chromium.org>
  38747. Reviewed by Antti Koivisto.
  38748. PreloadScanner doesn&apos;t find image while executing script in head
  38749. https://bugs.webkit.org/show_bug.cgi?id=45072
  38750. Previously, while parsing the head, no resources in the body would be
  38751. preloaded. After this patch, we will preload scripts and styles in the
  38752. body, although we continue to hold off on all images until the page is
  38753. first rendered.
  38754. To evaluate this change, I've recorded a sampling of 45 of alexa's top
  38755. sites and replayed them under simulated bandwidth conditions, loading
  38756. each 5-15 times until stddev is small enough.
  38757. Time to the load event improved at the overall average by 3%.
  38758. Most sites are unchanged, but sites with certain blocking patterns had
  38759. big wins -- ebay 19% (331ms), microsoft 15% (226ms), conduit 15% (277ms)
  38760. nytimes 7% (182ms).
  38761. Time to DOM content loaded event improved by 6% with some even bigger
  38762. individual wins.
  38763. First paint time held steady.
  38764. Note that I originally wanted to allow preloading of images while in the
  38765. head, but that regressed first paint time (even though it was better for
  38766. overall load time).
  38767. Test: fast/preloader/scan-body-from-head.html
  38768. * loader/cache/CachedResourceLoader.cpp:
  38769. (WebCore::CachedResourceLoader::preload):
  38770. 2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
  38771. Unreviewed, rolling out r82616.
  38772. http://trac.webkit.org/changeset/82616
  38773. https://bugs.webkit.org/show_bug.cgi?id=57585
  38774. New test does not pass on Gtk, chromium-mac, chromium-linux
  38775. and possibly elsewhere (Requested by abarth|gardener on
  38776. #webkit).
  38777. * rendering/RenderWidget.cpp:
  38778. (WebCore::RenderWidget::setWidget):
  38779. 2011-03-31 Adrienne Walker <enne@google.com>
  38780. Reviewed by James Robinson.
  38781. [chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
  38782. https://bugs.webkit.org/show_bug.cgi?id=57577
  38783. LayerRendererChromium now uses a RefPtr to preserve ownership of all
  38784. of the CCLayerImpl layers that it is using during the update/draw
  38785. pass. Addtionally, when a LayerChromium is destroyed, the weak
  38786. owner pointer from its CCLayerImpl is correctly unset.
  38787. * platform/graphics/chromium/LayerRendererChromium.cpp:
  38788. (WebCore::LayerRendererChromium::compareLayerZ):
  38789. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  38790. (WebCore::LayerRendererChromium::updateLayers):
  38791. (WebCore::LayerRendererChromium::drawLayers):
  38792. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  38793. (WebCore::LayerRendererChromium::drawLayer):
  38794. * platform/graphics/chromium/LayerRendererChromium.h:
  38795. * platform/graphics/chromium/RenderSurfaceChromium.h:
  38796. * platform/graphics/chromium/VideoLayerChromium.cpp:
  38797. (WebCore::VideoLayerChromium::updateCompositorResources):
  38798. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  38799. (WebCore::CCLayerImpl::drawsContent):
  38800. (WebCore::CCLayerImpl::cleanupResources):
  38801. 2011-03-31 Sam Weinig <sam@webkit.org>
  38802. Reviewed by Anders Carlsson.
  38803. Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
  38804. https://bugs.webkit.org/show_bug.cgi?id=57582
  38805. * platform/DefaultLocalizationStrategy.cpp:
  38806. * platform/LocalizedStrings.h:
  38807. 2011-03-31 Eric Seidel <eric@webkit.org>
  38808. Reviewed by Ryosuke Niwa.
  38809. Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
  38810. https://bugs.webkit.org/show_bug.cgi?id=57550
  38811. * platform/text/BidiResolver.h:
  38812. (WebCore::::createBidiRunsForLine):
  38813. 2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
  38814. Reviewed by James Robinson.
  38815. https://bugs.webkit.org/show_bug.cgi?id=45855
  38816. Windowless plugins added dynamically to the DOM should receive paint events.
  38817. This is done by ensuring that the plugin widget is marked for painting when
  38818. it is added.
  38819. Test: plugins/windowless_plugin_paint_test.html
  38820. * rendering/RenderWidget.cpp:
  38821. (WebCore::RenderWidget::setWidget):
  38822. 2011-03-31 Stephen White <senorblanco@chromium.org>
  38823. Reviewed by Kenneth Russell.
  38824. Speed up accelerated path drawing.
  38825. https://bugs.webkit.org/show_bug.cgi?id=57371
  38826. This CL does three things: re-uses the same vertex and index buffer
  38827. for all path draws, converts all vertex layouts from vec3 to vec2, and
  38828. does a convexity check for polygons before passing them to the
  38829. tesselator.
  38830. Covered by canvas/philip/tests/2d.path.bezierCurveTo.*, and others.
  38831. * platform/graphics/chromium/GLES2Canvas.cpp:
  38832. Replace the Vector<double> for interpolated curves with a
  38833. Vector<FloatPoint>.
  38834. (WebCore::Cubic::evaluate):
  38835. Inline the evaluation function (as Quadratic does).
  38836. (WebCore::GLES2Canvas::GLES2Canvas):
  38837. Initialize the m_pathIndexBuffer.
  38838. (WebCore::GLES2Canvas::~GLES2Canvas):
  38839. Delete the path vertex and index buffers on destruction.
  38840. (WebCore::interpolateQuadratic):
  38841. (WebCore::interpolateCubic):
  38842. Interpolate directly to a Vector<FloatPoint>, rather than
  38843. Vector<double>.
  38844. (WebCore::PolygonData::PolygonData):
  38845. (WebCore::combineData):
  38846. Replace the DoubleVector with a FloatPointVector.
  38847. (WebCore::GLES2Canvas::tesselateAndFillPath):
  38848. Move curve drawing into this function, and rename it to reflect the
  38849. new behaviour. Re-use the common vertex and index buffers. If the
  38850. curve consists of a single convex polygon, draw the curve as a single
  38851. triangle fan. Otherwise, convert it to doubles and pass it to the
  38852. tesselator.
  38853. (WebCore::GLES2Canvas::fillPathInternal):
  38854. * platform/graphics/chromium/GLES2Canvas.h:
  38855. Rename createVertexBufferFromPath() -> tesselateAndFillPath().
  38856. Add a persistent index buffer for all path draws.
  38857. * platform/graphics/gpu/BicubicShader.cpp:
  38858. (WebCore::BicubicShader::create):
  38859. (WebCore::BicubicShader::use):
  38860. * platform/graphics/gpu/ConvolutionShader.cpp:
  38861. (WebCore::ConvolutionShader::create):
  38862. (WebCore::ConvolutionShader::use):
  38863. Use vec2s instead of vec3s for all vertex data.
  38864. * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  38865. (WebCore::LoopBlinnMathUtils::convexCompare):
  38866. (WebCore::LoopBlinnMathUtils::convexCross):
  38867. (WebCore::LoopBlinnMathUtils::convexCheckTriple):
  38868. (WebCore::LoopBlinnMathUtils::isConvex):
  38869. * platform/graphics/gpu/LoopBlinnMathUtils.h:
  38870. Implement a convexity check, based on the code in Graphics Gems IV.
  38871. * platform/graphics/gpu/Shader.cpp:
  38872. (WebCore::Shader::generateVertex):
  38873. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  38874. (WebCore::SharedGraphicsContext3D::useQuadVertices):
  38875. * platform/graphics/gpu/SolidFillShader.cpp:
  38876. (WebCore::SolidFillShader::use):
  38877. * platform/graphics/gpu/TexShader.cpp:
  38878. (WebCore::TexShader::use):
  38879. Use vec2s instead of vec3s for all vertex data.
  38880. 2011-03-31 David Hyatt <hyatt@apple.com>
  38881. Reviewed by Simon Fraser.
  38882. https://bugs.webkit.org/show_bug.cgi?id=57565
  38883. Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
  38884. to check the line for overflow in the first place.
  38885. For the purposes of overflow computation, an inline object's default containment box for overflow is now assumed to extend
  38886. all the way from lineTop to lineBottom instead of snugly fitting the inline object's own block dimensions. This allows
  38887. replaced objects to be inside spans without triggering overflow allocation.
  38888. The overflow accessors on InlineFlowBox have been changed to require passing in the lineTop and lineBottom so that the block
  38889. dimensions can be forced to those values. Because these values are checked during painting and hit testing of lines, the
  38890. lineTop and lineBottom are now passed as arguments to the painting and hit testing functions to avoid repeatedly crawling
  38891. back up to the root box to fetch them.
  38892. Added a new boolean flag to all InlineBoxes, knownToHaveNoOverflow(), and optimized for common cases where no overflow can
  38893. possibly be present. When the bit is set, computeOverflow will just immediately return.
  38894. This change speeds up line layout by ~10%.
  38895. * rendering/EllipsisBox.cpp:
  38896. (WebCore::EllipsisBox::paint):
  38897. (WebCore::EllipsisBox::nodeAtPoint):
  38898. * rendering/EllipsisBox.h:
  38899. * rendering/InlineBox.cpp:
  38900. (WebCore::InlineBox::paint):
  38901. (WebCore::InlineBox::nodeAtPoint):
  38902. (WebCore::InlineBox::clearKnownToHaveNoOverflow):
  38903. * rendering/InlineBox.h:
  38904. (WebCore::InlineBox::InlineBox):
  38905. (WebCore::InlineBox::logicalFrameRect):
  38906. (WebCore::InlineBox::knownToHaveNoOverflow):
  38907. * rendering/InlineFlowBox.cpp:
  38908. (WebCore::InlineFlowBox::addToLine):
  38909. (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
  38910. (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  38911. (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
  38912. (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
  38913. (WebCore::InlineFlowBox::addReplacedChildOverflow):
  38914. (WebCore::InlineFlowBox::computeOverflow):
  38915. (WebCore::InlineFlowBox::setLayoutOverflow):
  38916. (WebCore::InlineFlowBox::setVisualOverflow):
  38917. (WebCore::InlineFlowBox::setOverflowFromLogicalRects):
  38918. (WebCore::InlineFlowBox::nodeAtPoint):
  38919. (WebCore::InlineFlowBox::paint):
  38920. * rendering/InlineFlowBox.h:
  38921. (WebCore::InlineFlowBox::layoutOverflowRect):
  38922. (WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
  38923. (WebCore::InlineFlowBox::logicalRightLayoutOverflow):
  38924. (WebCore::InlineFlowBox::logicalTopLayoutOverflow):
  38925. (WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
  38926. (WebCore::InlineFlowBox::logicalLayoutOverflowRect):
  38927. (WebCore::InlineFlowBox::visualOverflowRect):
  38928. (WebCore::InlineFlowBox::logicalLeftVisualOverflow):
  38929. (WebCore::InlineFlowBox::logicalRightVisualOverflow):
  38930. (WebCore::InlineFlowBox::logicalTopVisualOverflow):
  38931. (WebCore::InlineFlowBox::logicalBottomVisualOverflow):
  38932. (WebCore::InlineFlowBox::logicalVisualOverflowRect):
  38933. (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
  38934. (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
  38935. * rendering/InlineTextBox.cpp:
  38936. (WebCore::InlineTextBox::nodeAtPoint):
  38937. (WebCore::InlineTextBox::paint):
  38938. * rendering/InlineTextBox.h:
  38939. * rendering/RenderBlock.cpp:
  38940. (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  38941. (WebCore::RenderBlock::paintEllipsisBoxes):
  38942. (WebCore::RenderBlock::adjustLinePositionForPagination):
  38943. * rendering/RenderBlock.h:
  38944. * rendering/RenderBlockLineLayout.cpp:
  38945. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  38946. (WebCore::RenderBlock::layoutInlineChildren):
  38947. (WebCore::RenderBlock::determineStartPosition):
  38948. (WebCore::RenderBlock::matchedEndLine):
  38949. (WebCore::RenderBlock::addOverflowFromInlineChildren):
  38950. * rendering/RenderBox.h:
  38951. (WebCore::RenderBox::hasRenderOverflow):
  38952. * rendering/RenderBoxModelObject.cpp:
  38953. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  38954. * rendering/RenderInline.cpp:
  38955. (WebCore::RenderInline::linesVisualOverflowBoundingBox):
  38956. * rendering/RenderLineBoxList.cpp:
  38957. (WebCore::RenderLineBoxList::anyLineIntersectsRect):
  38958. (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
  38959. (WebCore::RenderLineBoxList::paint):
  38960. (WebCore::RenderLineBoxList::hitTest):
  38961. * rendering/RenderListItem.cpp:
  38962. (WebCore::RenderListItem::positionListMarker):
  38963. * rendering/RootInlineBox.cpp:
  38964. (WebCore::RootInlineBox::paintEllipsisBox):
  38965. (WebCore::RootInlineBox::addHighlightOverflow):
  38966. (WebCore::RootInlineBox::paint):
  38967. (WebCore::RootInlineBox::nodeAtPoint):
  38968. (WebCore::RootInlineBox::paddedLayoutOverflowRect):
  38969. * rendering/RootInlineBox.h:
  38970. (WebCore::RootInlineBox::logicalTopVisualOverflow):
  38971. (WebCore::RootInlineBox::logicalBottomVisualOverflow):
  38972. (WebCore::RootInlineBox::logicalTopLayoutOverflow):
  38973. (WebCore::RootInlineBox::logicalBottomLayoutOverflow):
  38974. * rendering/svg/SVGInlineFlowBox.cpp:
  38975. (WebCore::SVGInlineFlowBox::paint):
  38976. * rendering/svg/SVGInlineFlowBox.h:
  38977. * rendering/svg/SVGInlineTextBox.cpp:
  38978. (WebCore::SVGInlineTextBox::paint):
  38979. * rendering/svg/SVGInlineTextBox.h:
  38980. * rendering/svg/SVGRootInlineBox.cpp:
  38981. (WebCore::SVGRootInlineBox::paint):
  38982. * rendering/svg/SVGRootInlineBox.h:
  38983. 2011-03-31 Pavel Feldman <pfeldman@chromium.org>
  38984. Reviewed by Yury Semikhatsky.
  38985. Web Inspector: disable properties abbreviation.
  38986. https://bugs.webkit.org/show_bug.cgi?id=57525
  38987. * inspector/InjectedScript.cpp:
  38988. (WebCore::InjectedScript::getProperties):
  38989. * inspector/InjectedScript.h:
  38990. * inspector/InjectedScriptSource.js:
  38991. (.):
  38992. ():
  38993. * inspector/Inspector.json:
  38994. * inspector/InspectorRuntimeAgent.cpp:
  38995. (WebCore::InspectorRuntimeAgent::getProperties):
  38996. * inspector/InspectorRuntimeAgent.h:
  38997. * inspector/front-end/ConsoleView.js:
  38998. (WebInspector.ConsoleView.prototype.completions.evaluated):
  38999. (WebInspector.ConsoleView.prototype._formatarray):
  39000. * inspector/front-end/ObjectPropertiesSection.js:
  39001. (WebInspector.ObjectPropertiesSection.prototype.update.callback):
  39002. (WebInspector.ObjectPropertiesSection.prototype.update):
  39003. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
  39004. (WebInspector.ObjectPropertyTreeElement.prototype.update):
  39005. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
  39006. * inspector/front-end/PropertiesSidebarPane.js:
  39007. (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  39008. * inspector/front-end/RemoteObject.js:
  39009. (WebInspector.RemoteObject.prototype.getOwnProperties):
  39010. (WebInspector.RemoteObject.prototype.getAllProperties):
  39011. (WebInspector.RemoteObject.prototype._getProperties):
  39012. (WebInspector.LocalJSONObject.prototype.getOwnProperties):
  39013. (WebInspector.LocalJSONObject.prototype.getAllProperties):
  39014. * inspector/front-end/inspector.css:
  39015. (.console-formatted-string, .console-formatted-regexp):
  39016. 2011-03-31 Adam Roben <aroben@apple.com>
  39017. Update WKCACFViewLayerTreeHost for changes to WKCACFView API
  39018. This should not result in any change in behavior.
  39019. Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to
  39020. render
  39021. Reviewed by Darin Adler.
  39022. * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Updated API declarations.
  39023. (WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Tell WKCACFView it should
  39024. render into the window we give it.
  39025. 2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
  39026. Reviewed by Kenneth Rohde Christiansen.
  39027. [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
  39028. https://bugs.webkit.org/show_bug.cgi?id=57017
  39029. Build fix. No new tests.
  39030. * WebCore.pri:
  39031. 2011-03-31 Vsevolod Vlasov <vsevik@chromium.org>
  39032. Reviewed by Pavel Feldman.
  39033. XML viewer is not shown when frame has non-null opener
  39034. https://bugs.webkit.org/show_bug.cgi?id=56384
  39035. Removed opener check in XML viewer
  39036. Test: http/tests/xmlviewer/extensions-api.html
  39037. * xml/XMLTreeViewer.cpp:
  39038. (WebCore::XMLTreeViewer::hasNoStyleInformation):
  39039. * xml/XMLViewer.js:
  39040. 2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
  39041. Unreviewed, rolling out r82589.
  39042. http://trac.webkit.org/changeset/82589
  39043. https://bugs.webkit.org/show_bug.cgi?id=57564
  39044. This patch requires many more updated results than it contains
  39045. (Requested by abarth|gardener on #webkit).
  39046. * css/CSSSelector.cpp:
  39047. (WebCore::CSSSelector::pseudoId):
  39048. (WebCore::nameToPseudoTypeMap):
  39049. (WebCore::CSSSelector::extractPseudoType):
  39050. * css/CSSSelector.h:
  39051. * css/html.css:
  39052. (meter::-webkit-meter-horizontal-bar):
  39053. (meter::-webkit-meter-vertical-bar):
  39054. (meter::-webkit-meter-horizontal-optimum-value):
  39055. (meter::-webkit-meter-horizontal-suboptimal-value):
  39056. (meter::-webkit-meter-horizontal-even-less-good-value):
  39057. (meter::-webkit-meter-vertical-optimum-value):
  39058. (meter::-webkit-meter-vertical-suboptimal-value):
  39059. (meter::-webkit-meter-vertical-even-less-good-value):
  39060. * rendering/RenderMeter.cpp:
  39061. (WebCore::MeterPartElement::MeterPartElement):
  39062. (WebCore::MeterPartElement::createForPart):
  39063. (WebCore::MeterPartElement::hide):
  39064. (WebCore::MeterPartElement::restoreVisibility):
  39065. (WebCore::MeterPartElement::updateStyleForPart):
  39066. (WebCore::MeterPartElement::saveVisibility):
  39067. (WebCore::RenderMeter::~RenderMeter):
  39068. (WebCore::RenderMeter::createPart):
  39069. (WebCore::RenderMeter::updateFromElement):
  39070. (WebCore::RenderMeter::layoutParts):
  39071. (WebCore::RenderMeter::shouldHaveParts):
  39072. (WebCore::RenderMeter::valuePartRect):
  39073. (WebCore::RenderMeter::orientation):
  39074. (WebCore::RenderMeter::valuePseudoId):
  39075. (WebCore::RenderMeter::barPseudoId):
  39076. * rendering/RenderMeter.h:
  39077. (WebCore::RenderMeter::shadowAttached):
  39078. * rendering/RenderTheme.cpp:
  39079. (WebCore::RenderTheme::supportsMeter):
  39080. * rendering/RenderTheme.h:
  39081. * rendering/RenderThemeMac.h:
  39082. * rendering/RenderThemeMac.mm:
  39083. (WebCore::RenderThemeMac::paintMeter):
  39084. (WebCore::RenderThemeMac::supportsMeter):
  39085. * rendering/style/RenderStyleConstants.h:
  39086. 2011-03-31 Xan Lopez <xlopez@igalia.com>
  39087. Reviewed by Martin Robinson.
  39088. [GTK] Link explicitly with XRender on Linux/Unix
  39089. https://bugs.webkit.org/show_bug.cgi?id=57558
  39090. * GNUmakefile.am: add XRender CFLAGS.
  39091. 2011-03-31 Eric Seidel <eric@webkit.org>
  39092. Reviewed by Ryosuke Niwa.
  39093. Rename BidiResolver::emptyRun to m_emtpyRun to match modern style
  39094. https://bugs.webkit.org/show_bug.cgi?id=57549
  39095. * platform/text/BidiResolver.h:
  39096. (WebCore::BidiResolver::BidiResolver):
  39097. (WebCore::::appendRun):
  39098. (WebCore::::lowerExplicitEmbeddingLevel):
  39099. (WebCore::::raiseExplicitEmbeddingLevel):
  39100. (WebCore::::deleteRuns):
  39101. (WebCore::::createBidiRunsForLine):
  39102. * rendering/InlineIterator.h:
  39103. (WebCore::InlineBidiResolver::appendRun):
  39104. 2011-03-31 Tom Sepez <tsepez@chromium.org>
  39105. Reviewed by Eric Seidel.
  39106. Make ContainerNode::insertIntoDocument() collect all nodes before
  39107. operating on any of them. Add small helper function and use it
  39108. througout the file where this action is already taking place.
  39109. https://bugs.webkit.org/show_bug.cgi?id=57265
  39110. Test: svg/dom/range-delete.html
  39111. * dom/ContainerNode.cpp:
  39112. (WebCore::collectNodes):
  39113. (WebCore::collectTargetNodes):
  39114. (WebCore::ContainerNode::takeAllChildrenFrom):
  39115. (WebCore::willRemoveChildren):
  39116. (WebCore::ContainerNode::insertedIntoDocument):
  39117. 2011-03-31 Satish Sampath <satish@chromium.org>
  39118. Reviewed by Steve Block.
  39119. While drawing a speech input button, validate that the node is really a speech input button.
  39120. https://bugs.webkit.org/show_bug.cgi?id=57469
  39121. Test: fast/speech/speech-style-on-non-speech-elements.html
  39122. * dom/Element.h:
  39123. (WebCore::Element::isInputFieldSpeechButtonElement):
  39124. * html/shadow/TextControlInnerElements.h:
  39125. (WebCore::InputFieldSpeechButtonElement::isInputFieldSpeechButtonElement):
  39126. (WebCore::toInputFieldSpeechButtonElement):
  39127. * rendering/RenderInputSpeech.cpp:
  39128. (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  39129. 2011-03-31 Ryosuke Niwa <rniwa@webkit.org>
  39130. Build fix after r82588. Reverted unintentional change.
  39131. * editing/SelectionController.cpp:
  39132. (WebCore::SelectionController::modifyMovingLeft):
  39133. 2011-03-31 Mario Sanchez Prada <msanchez@igalia.com>
  39134. Reviewed by Xan Lopez.
  39135. [GTK] Warnings happening because of unhandled switch cases in AccessibilityObjectWrapperAtk
  39136. https://bugs.webkit.org/show_bug.cgi?id=57534
  39137. Fix compilation warnings.
  39138. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  39139. (getAttributeSetForAccessibilityObject): Add unhandled cases.
  39140. 2011-03-30 Pavel Podivilov <podivilov@chromium.org>
  39141. Reviewed by Pavel Feldman.
  39142. Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
  39143. https://bugs.webkit.org/show_bug.cgi?id=57444
  39144. * bindings/js/ScriptDebugServer.cpp:
  39145. (WebCore::ScriptDebugServer::editScriptSource):
  39146. * bindings/js/ScriptDebugServer.h:
  39147. * bindings/v8/ScriptDebugServer.cpp:
  39148. (WebCore::ScriptDebugServer::editScriptSource):
  39149. * bindings/v8/ScriptDebugServer.h:
  39150. * inspector/Inspector.json:
  39151. * inspector/InspectorDebuggerAgent.cpp:
  39152. (WebCore::InspectorDebuggerAgent::editScriptSource):
  39153. * inspector/InspectorDebuggerAgent.h:
  39154. * inspector/front-end/DebuggerModel.js:
  39155. (WebInspector.DebuggerModel.prototype.editScriptSource):
  39156. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  39157. * inspector/front-end/DebuggerPresentationModel.js:
  39158. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
  39159. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  39160. * inspector/front-end/SourceFrame.js:
  39161. (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
  39162. (WebInspector.SourceFrame.prototype._handleSave):
  39163. 2011-03-30 MORITA Hajime <morrita@google.com>
  39164. Reviewed by Dimitri Glazkov.
  39165. <meter> can only support horizontal indicator
  39166. https://bugs.webkit.org/show_bug.cgi?id=56001
  39167. - Removed code which deals with the direction and
  39168. left the horizontal path.
  39169. - Removed "horizontal" from related names which is now
  39170. redundant.
  39171. * css/CSSSelector.cpp:
  39172. (WebCore::CSSSelector::pseudoId):
  39173. (WebCore::nameToPseudoTypeMap):
  39174. (WebCore::CSSSelector::extractPseudoType):
  39175. * css/CSSSelector.h:
  39176. * css/html.css:
  39177. (meter::-webkit-meter-bar):
  39178. (meter::-webkit-meter-optimum-value):
  39179. (meter::-webkit-meter-suboptimal-value):
  39180. (meter::-webkit-meter-even-less-good-value):
  39181. * rendering/RenderMeter.cpp:
  39182. (WebCore::RenderMeter::~RenderMeter):
  39183. (WebCore::RenderMeter::createPart):
  39184. (WebCore::RenderMeter::updateFromElement):
  39185. (WebCore::RenderMeter::layoutParts):
  39186. (WebCore::RenderMeter::styleDidChange):
  39187. (WebCore::RenderMeter::shouldHaveParts):
  39188. (WebCore::RenderMeter::valuePartRect):
  39189. (WebCore::RenderMeter::valuePseudoId):
  39190. (WebCore::RenderMeter::barPseudoId):
  39191. (WebCore::RenderMeter::detachShadows):
  39192. (WebCore::RenderMeter::updateShadows):
  39193. * rendering/RenderMeter.h:
  39194. (WebCore::RenderMeter::shadowAttached):
  39195. * rendering/RenderTheme.cpp:
  39196. (WebCore::RenderTheme::supportsMeter):
  39197. * rendering/RenderTheme.h:
  39198. * rendering/RenderThemeMac.h:
  39199. * rendering/RenderThemeMac.mm:
  39200. (WebCore::RenderThemeMac::paintMeter):
  39201. (WebCore::RenderThemeMac::supportsMeter):
  39202. * rendering/style/RenderStyleConstants.h:
  39203. 2011-03-30 Xiaomei Ji <xji@chromium.org>
  39204. Reviewed by Ryosuke Niwa.
  39205. Experiment with moving caret by word in visual order.
  39206. https://bugs.webkit.org/show_bug.cgi?id=57336
  39207. Follow Firefox's convention in Windows,
  39208. In LTR block, word break visually moves cursor to the left boundary of words,
  39209. In RTL block, word break visually moves cursor to the right boundary of words.
  39210. This is the 1st version of implementing "move caret by word in visual order".
  39211. It only works in the following situation:
  39212. 1. For a LTR box in a LTR block or a RTL box in RTL block,
  39213. when caret is at the left boundary of the box and we are looking for
  39214. the word boundary in right.
  39215. 2. For a LTR or RTL box in a LTR block, when caret is at the left boundary
  39216. of the box and we are looking for the word boundary in left and
  39217. previous box is a LTR box.
  39218. 3. For a LTR or RTL box in a RTL block, when the caret is at the right
  39219. boundary of the box and we are looking for the word boundary in right and next box is RTL box.
  39220. An experimental granularity is introduced, as a side effect, functions having switch statements
  39221. to handle those granularities have to add more one case to handle this new granularity.
  39222. The experimental granularity is exposed though JS by '-webkit-visual-word".
  39223. The overall algorithm is looping through inline boxes visually and looking
  39224. for the visually nearest word break position.
  39225. Test: editing/selection/move-by-word-visually.html
  39226. * editing/SelectionController.cpp:
  39227. (WebCore::SelectionController::modifyExtendingRight):
  39228. (WebCore::SelectionController::modifyExtendingForward):
  39229. (WebCore::SelectionController::modifyMovingRight):
  39230. (WebCore::SelectionController::modifyMovingForward):
  39231. (WebCore::SelectionController::modifyExtendingLeft):
  39232. (WebCore::SelectionController::modifyExtendingBackward):
  39233. (WebCore::SelectionController::modifyMovingLeft):
  39234. (WebCore::SelectionController::modifyMovingBackward):
  39235. * editing/TextGranularity.h:
  39236. * editing/VisibleSelection.cpp:
  39237. (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  39238. * editing/visible_units.cpp:
  39239. (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
  39240. (WebCore::wordBoundaryInBox):
  39241. (WebCore::wordBoundaryInAdjacentBoxes):
  39242. (WebCore::leftWordBoundary):
  39243. (WebCore::rightWordBoundary):
  39244. (WebCore::leftWordPosition):
  39245. (WebCore::rightWordPosition):
  39246. * editing/visible_units.h:
  39247. * page/DOMSelection.cpp:
  39248. (WebCore::DOMSelection::modify):
  39249. 2011-03-31 Dimitri Glazkov <dglazkov@chromium.org>
  39250. Reviewed by Darin Adler.
  39251. Move coordinate-computing logic into MouseRelatedEvent.
  39252. https://bugs.webkit.org/show_bug.cgi?id=57521
  39253. Refactoring, covered by existing tests.
  39254. * dom/EventDispatcher.cpp:
  39255. (WebCore::EventDispatcher::dispatchWheelEvent): Yank calculation of
  39256. coordinates out.
  39257. (WebCore::EventDispatcher::dispatchMouseEvent): Ditto.
  39258. * dom/MouseEvent.cpp:
  39259. (WebCore::MouseEvent::create): Add coordinate-computing logic.
  39260. * dom/MouseEvent.h: Adjust decl to reflect new meaning of params.
  39261. * dom/MouseRelatedEvent.cpp:
  39262. (WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
  39263. * page/EventHandler.cpp:
  39264. (WebCore::EventHandler::dispatchDragEvent): Ditto.
  39265. 2011-03-30 Alexander Pavlov <apavlov@chromium.org>
  39266. Reviewed by Pavel Feldman.
  39267. Web Inspector: document CSS agent.
  39268. https://bugs.webkit.org/show_bug.cgi?id=57435
  39269. * inspector/Inspector.json:
  39270. 2011-03-31 Andrey Kosyakov <caseq@chromium.org>
  39271. Reviewed by Yury Semikhatsky.
  39272. Web Inspector: remove periods at the end of error messages
  39273. https://bugs.webkit.org/show_bug.cgi?id=57544
  39274. * inspector/InjectedScript.cpp:
  39275. (WebCore::InjectedScript::getProperties):
  39276. (WebCore::InjectedScript::makeObjectCall):
  39277. * inspector/InspectorCSSAgent.cpp:
  39278. (WebCore::InspectorCSSAgent::elementForId):
  39279. (WebCore::InspectorCSSAgent::styleSheetForId):
  39280. * inspector/InspectorDOMAgent.cpp:
  39281. (WebCore::InspectorDOMAgent::assertNode):
  39282. (WebCore::InspectorDOMAgent::assertElement):
  39283. (WebCore::InspectorDOMAgent::assertHTMLElement):
  39284. (WebCore::InspectorDOMAgent::querySelector):
  39285. (WebCore::InspectorDOMAgent::querySelectorAll):
  39286. (WebCore::InspectorDOMAgent::setAttribute):
  39287. (WebCore::InspectorDOMAgent::removeAttribute):
  39288. (WebCore::InspectorDOMAgent::removeNode):
  39289. (WebCore::InspectorDOMAgent::setNodeValue):
  39290. * inspector/InspectorDebuggerAgent.cpp:
  39291. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  39292. * inspector/InspectorResourceAgent.cpp:
  39293. (WebCore::InspectorResourceAgent::resourceContent):
  39294. (WebCore::InspectorResourceAgent::resourceContentBase64):
  39295. (WebCore::InspectorResourceAgent::getResourceContent):
  39296. * inspector/InspectorRuntimeAgent.cpp:
  39297. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  39298. 2011-03-31 Evan Martin <evan@chromium.org>
  39299. Reviewed by Eric Seidel.
  39300. <title> should support dir attribute
  39301. https://bugs.webkit.org/show_bug.cgi?id=50961
  39302. Introduce a new StringWithDirection object that carries a String along
  39303. with the TextDirection associated with the String. Use this object for
  39304. document titles used within WebCore, because in HTML the direction of
  39305. a title can be set with the 'dir' attribute.
  39306. Put FIXMEs at the WebKit level to expose the new direction information
  39307. to clients.
  39308. No behavioral change intended, so no new tests. A follow-up will expose
  39309. the title direction and hopefully can be accompanied by tests that
  39310. verify it is correct.
  39311. * dom/Document.cpp:
  39312. (WebCore::Document::Document):
  39313. (WebCore::Document::updateTitle):
  39314. (WebCore::Document::setTitle):
  39315. (WebCore::Document::removeTitle):
  39316. * dom/Document.h:
  39317. (WebCore::Document::title):
  39318. * html/HTMLTitleElement.cpp:
  39319. (WebCore::HTMLTitleElement::HTMLTitleElement):
  39320. (WebCore::HTMLTitleElement::childrenChanged):
  39321. (WebCore::HTMLTitleElement::text):
  39322. (WebCore::HTMLTitleElement::textWithDirection):
  39323. * html/HTMLTitleElement.h:
  39324. * loader/DocumentLoader.cpp:
  39325. (WebCore::DocumentLoader::setTitle):
  39326. * loader/DocumentLoader.h:
  39327. (WebCore::DocumentLoader::title):
  39328. * loader/EmptyClients.h:
  39329. (WebCore::EmptyFrameLoaderClient::dispatchDidReceiveTitle):
  39330. (WebCore::EmptyFrameLoaderClient::setTitle):
  39331. * loader/FrameLoader.cpp:
  39332. (WebCore::FrameLoader::receivedFirstData):
  39333. (WebCore::FrameLoader::commitProvisionalLoad):
  39334. (WebCore::FrameLoader::setTitle):
  39335. * loader/FrameLoader.h:
  39336. * loader/FrameLoaderClient.h:
  39337. * loader/HistoryController.cpp:
  39338. (WebCore::HistoryController::updateForBackForwardNavigation):
  39339. (WebCore::HistoryController::updateForReload):
  39340. (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
  39341. (WebCore::HistoryController::updateForClientRedirect):
  39342. (WebCore::HistoryController::updateForCommit):
  39343. (WebCore::HistoryController::setCurrentItemTitle):
  39344. (WebCore::HistoryController::initializeItem):
  39345. * loader/HistoryController.h:
  39346. * platform/text/StringWithDirection.h: Added.
  39347. (WebCore::StringWithDirection::StringWithDirection):
  39348. (WebCore::StringWithDirection::operator==):
  39349. (WebCore::StringWithDirection::operator!=):
  39350. * svg/SVGTitleElement.cpp:
  39351. (WebCore::SVGTitleElement::insertedIntoDocument):
  39352. (WebCore::SVGTitleElement::childrenChanged):
  39353. 2011-03-31 Alexander Pavlov <apavlov@chromium.org>
  39354. Reviewed by Yury Semikhatsky.
  39355. Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
  39356. https://bugs.webkit.org/show_bug.cgi?id=57538
  39357. * inspector/InspectorStyleSheet.cpp:
  39358. (WebCore::buildSourceRangeObject):
  39359. (WebCore::InspectorStyle::buildObjectForStyle):
  39360. (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  39361. * inspector/front-end/AuditRules.js:
  39362. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  39363. * inspector/front-end/CSSStyleModel.js:
  39364. (WebInspector.CSSStyleDeclaration):
  39365. 2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
  39366. Unreviewed, rolling out r82565.
  39367. http://trac.webkit.org/changeset/82565
  39368. https://bugs.webkit.org/show_bug.cgi?id=57541
  39369. Caused assertion failures. (Requested by bbandix on #webkit).
  39370. * platform/graphics/filters/FEFlood.cpp:
  39371. (WebCore::FEFlood::setFloodColor):
  39372. (WebCore::FEFlood::setFloodOpacity):
  39373. * platform/graphics/filters/FEFlood.h:
  39374. * platform/graphics/filters/FESpecularLighting.cpp:
  39375. (WebCore::FESpecularLighting::setLightingColor):
  39376. * platform/graphics/filters/FESpecularLighting.h:
  39377. * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  39378. * rendering/svg/RenderSVGResourceFilterPrimitive.h:
  39379. * rendering/svg/SVGResourcesCache.cpp:
  39380. (WebCore::SVGResourcesCache::clientStyleChanged):
  39381. * svg/SVGFEDiffuseLightingElement.cpp:
  39382. (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  39383. * svg/SVGFEFloodElement.cpp:
  39384. * svg/SVGFEFloodElement.h:
  39385. * svg/SVGFESpecularLightingElement.cpp:
  39386. (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
  39387. 2011-03-31 Renata Hodovan <reni@webkit.org>
  39388. Reviewed by Dirk Schulze.
  39389. CSS related SVG*Element changes doesn't require relayout
  39390. https://bugs.webkit.org/show_bug.cgi?id=56906
  39391. The changes of some CSS related SVGFilter properties e.g. lighting-color, flood-color, flood-opacity
  39392. need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
  39393. we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
  39394. via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
  39395. Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
  39396. svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
  39397. svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
  39398. svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
  39399. * platform/graphics/filters/FEFlood.cpp:
  39400. (WebCore::FEFlood::setFloodColor):
  39401. (WebCore::FEFlood::setFloodOpacity):
  39402. * platform/graphics/filters/FEFlood.h:
  39403. * platform/graphics/filters/FESpecularLighting.cpp:
  39404. (WebCore::FESpecularLighting::setLightingColor):
  39405. * platform/graphics/filters/FESpecularLighting.h:
  39406. * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
  39407. (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
  39408. * rendering/svg/RenderSVGResourceFilterPrimitive.h:
  39409. * rendering/svg/SVGResourcesCache.cpp:
  39410. (WebCore::SVGResourcesCache::clientStyleChanged):
  39411. * svg/SVGFEDiffuseLightingElement.cpp:
  39412. (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  39413. * svg/SVGFEFloodElement.cpp:
  39414. (WebCore::SVGFEFloodElement::setFilterEffectAttribute):
  39415. * svg/SVGFEFloodElement.h:
  39416. * svg/SVGFESpecularLightingElement.cpp:
  39417. (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
  39418. 2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
  39419. Reviewed by Pavel Feldman.
  39420. XML Viewer: declared namespaces are not rendered.
  39421. https://bugs.webkit.org/show_bug.cgi?id=56262
  39422. XML viewer rewritten on javascript.
  39423. * CMakeLists.txt:
  39424. * DerivedSources.make:
  39425. * GNUmakefile.am:
  39426. * WebCore.gyp/WebCore.gyp:
  39427. * WebCore.gypi:
  39428. * WebCore.vcproj/WebCore.vcproj:
  39429. * WebCore.xcodeproj/project.pbxproj:
  39430. * dom/XMLDocumentParserLibxml2.cpp:
  39431. (WebCore::XMLDocumentParser::doEnd):
  39432. * xml/XMLTreeViewer.cpp:
  39433. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  39434. * xml/XMLViewer.css: Added.
  39435. * xml/XMLViewer.js: Added.
  39436. * xml/XMLViewer.xsl: Removed.
  39437. * xml/XSLStyleSheet.h:
  39438. 2011-03-31 Jaehun Lim <ljaehun.lim@samsung.com>
  39439. Unreviewed build fix.
  39440. Fix build break after rolling out r82496
  39441. https://bugs.webkit.org/show_bug.cgi?id=57536
  39442. * platform/efl/RenderThemeEfl.cpp:
  39443. 2011-03-31 Andrey Adaikin <aandrey@google.com>
  39444. Reviewed by Pavel Feldman.
  39445. Web Inspector: execution line is displayed incorrectly after source editing.
  39446. https://bugs.webkit.org/show_bug.cgi?id=57229
  39447. * inspector/front-end/SourceFrame.js:
  39448. (WebInspector.SourceFrame.prototype._saveViewerState):
  39449. (WebInspector.SourceFrame.prototype._restoreViewerState):
  39450. (WebInspector.SourceFrame.prototype._startEditing):
  39451. (WebInspector.SourceFrame.prototype._endEditing):
  39452. (WebInspector.SourceFrame.prototype._createTextViewer):
  39453. (WebInspector.SourceFrame.prototype.setExecutionLine):
  39454. (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
  39455. (WebInspector.SourceFrame.prototype._handleSave):
  39456. (WebInspector.SourceFrame.prototype._handleRevertEditing):
  39457. * inspector/front-end/TextViewer.js:
  39458. (WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
  39459. (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
  39460. (WebInspector.TextEditorMainPanel.prototype.makeLineAChunk):
  39461. (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
  39462. 2011-03-30 Alexander Pavlov <apavlov@chromium.org>
  39463. Reviewed by Pavel Feldman.
  39464. Web Inspector: Make the CSStyle "shorthandValues" name-value map an array
  39465. https://bugs.webkit.org/show_bug.cgi?id=57452
  39466. No new tests, as this is a refactoring.
  39467. * inspector/InspectorCSSAgent.cpp:
  39468. * inspector/InspectorStyleSheet.cpp:
  39469. (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  39470. * inspector/front-end/CSSStyleModel.js:
  39471. (WebInspector.CSSStyleDeclaration):
  39472. (WebInspector.CSSStyleDeclaration.buildShorthandValueMap):
  39473. 2011-03-30 Steve Block <steveblock@google.com>
  39474. Reviewed by Jeremy Orlow.
  39475. JavaField should not expose JavaString in its API
  39476. https://bugs.webkit.org/show_bug.cgi?id=55766
  39477. This patch fixes JavaField for V8 only.
  39478. - Factors out a JavaField interface which does not use JNI types.
  39479. This will allow the Java bridge to be used with objects that
  39480. don't use JNI directly. The existing jobject-backed
  39481. implementation is moved to a new JavaFieldJobject class which
  39482. implements the interface.
  39483. - Use WTF::String in place of JavaString in the API, as JavaString
  39484. exposes JNI types in its interface.
  39485. No new tests, refactoring only.
  39486. * Android.v8bindings.mk:
  39487. * WebCore.gypi:
  39488. * bridge/jni/JavaMethod.h:
  39489. (JSC::Bindings::JavaMethod::~JavaMethod):
  39490. * bridge/jni/JobjectWrapper.h:
  39491. * bridge/jni/v8/JavaClassV8.cpp:
  39492. (JavaClass::JavaClass):
  39493. * bridge/jni/v8/JavaFieldJobjectV8.cpp:
  39494. (JavaFieldJobject::JavaFieldJobject):
  39495. * bridge/jni/v8/JavaFieldJobjectV8.h:
  39496. (JSC::Bindings::JavaFieldJobject::name):
  39497. (JSC::Bindings::JavaFieldJobject::typeClassName):
  39498. (JSC::Bindings::JavaFieldJobject::type):
  39499. * bridge/jni/v8/JavaFieldV8.h:
  39500. (JSC::Bindings::JavaField::~JavaField):
  39501. * bridge/jni/v8/JavaInstanceV8.cpp:
  39502. (JavaInstance::getField):
  39503. 2011-03-31 Levi Weintraub <leviw@chromium.org>
  39504. Reviewed by Ryosuke Niwa.
  39505. Clean up from r82447.
  39506. https://bugs.webkit.org/attachment.cgi?bugid=57532
  39507. No new tests since this doesn't change behavior.
  39508. * rendering/RenderBlock.cpp: Removing unnecessary visible_units.h include.
  39509. * rendering/RootInlineBox.cpp:
  39510. (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Making const.
  39511. (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
  39512. * rendering/RootInlineBox.h:
  39513. 2011-03-31 Benjamin Kalman <kalman@chromium.org>
  39514. Reviewed by Ojan Vafai.
  39515. DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
  39516. https://bugs.webkit.org/show_bug.cgi?id=57079
  39517. Test: editing/execCommand/delete-table-with-empty-contents.html
  39518. This bug results in an ASSERT fail in CompositeEditCommand::insertNodeAt, so is only observable in debug builds
  39519. of WebKit.
  39520. * editing/DeleteSelectionCommand.cpp:
  39521. (WebCore::firstEditablePositionInNode):
  39522. (WebCore::DeleteSelectionCommand::removeNode): Use firstEditablePositionInNode rather than firstPositionInNode
  39523. to find anchor node for the placeholder's position, if any.
  39524. 2011-03-30 Ojan Vafai <ojan@chromium.org>
  39525. Reviewed by Adam Roben.
  39526. REGRESSION (r82400): Leaks seen beneath CSSParser::createFloatingVectorSelector when parsing UA stylesheet
  39527. https://bugs.webkit.org/show_bug.cgi?id=57478
  39528. * css/CSSGrammar.y:
  39529. * css/CSSParser.cpp:
  39530. (WebCore::CSSParser::sinkFloatingSelectorVector):
  39531. * css/CSSParser.h:
  39532. 2011-03-30 Dominic Cooney <dominicc@google.com>
  39533. Reviewed by Dimitri Glazkov.
  39534. Adds layoutTestController.shadowRoot accessor to Mac DRT.
  39535. https://bugs.webkit.org/show_bug.cgi?id=57415
  39536. * WebCore.exp.in: DRT needs to link WebCore::Element::shadowRoot
  39537. 2011-03-30 Kent Tamura <tkent@chromium.org>
  39538. Reviewed by Dimitri Glazkov.
  39539. Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
  39540. https://bugs.webkit.org/show_bug.cgi?id=57424
  39541. r75555 made 'scroll' event asynchronous. So we don't need to worry about
  39542. deleting or moving a target node in scrollIntoViewIfNeeded().
  39543. * html/HTMLFormElement.cpp:
  39544. (WebCore::HTMLFormElement::validateInteractively): Remove unnecessary code.
  39545. 2011-03-30 Kent Tamura <tkent@chromium.org>
  39546. Reviewed by Darin Adler.
  39547. REGRESSION (r74895): Crash if input.type = 'file' twice
  39548. https://bugs.webkit.org/show_bug.cgi?id=57343
  39549. * html/HTMLInputElement.cpp:
  39550. (WebCore::HTMLInputElement::updateType):
  39551. Don't call setAttribute() if the type is not changed.
  39552. 2011-03-30 Jia Pu <jpu@apple.com>
  39553. Reviewed by Darin Adler.
  39554. Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
  39555. https://bugs.webkit.org/show_bug.cgi?id=57353
  39556. <rdar://problem/9163983>
  39557. We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
  39558. panel. The latter function compensates for zooming, which we don't need in this case. We also
  39559. dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().
  39560. * WebCore.exp.in:
  39561. * dom/Range.cpp:
  39562. (WebCore::Range::textQuads):
  39563. * dom/Range.h:
  39564. * editing/Editor.cpp:
  39565. (WebCore::Editor::windowRectForRange):
  39566. * editing/Editor.h:
  39567. * page/Frame.cpp:
  39568. (WebCore::Frame::setPageAndTextZoomFactors):
  39569. 2011-03-30 Chris Guillory <chris.guillory@google.com>
  39570. Reviewed by Dimitri Glazkov.
  39571. Render fonts using skia when requested by platform context.
  39572. https://bugs.webkit.org/show_bug.cgi?id=56441
  39573. * platform/graphics/skia/PlatformContextSkia.cpp:
  39574. (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  39575. * platform/graphics/skia/PlatformContextSkia.h:
  39576. * platform/graphics/skia/SkiaFontWin.cpp:
  39577. (WebCore::windowsCanHandleTextDrawing):
  39578. (WebCore::skiaDrawText):
  39579. (WebCore::setupPaintForFont):
  39580. (WebCore::paintSkiaText):
  39581. 2011-03-30 Dan Bernstein <mitz@apple.com>
  39582. Reviewed by Darin Adler.
  39583. <rdar://problem/9199518> Crash when focusing a styled editable element
  39584. Test: editing/deleting/delete-button-background-image-none.html
  39585. * editing/DeleteButtonController.cpp:
  39586. (WebCore::isDeletableElement): Check all background layers for background images.
  39587. * rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,
  39588. in the above function.
  39589. 2011-03-30 Martin Robinson <mrobinson@igalia.com>
  39590. Try once more to fix the EFL build.
  39591. * platform/efl/RenderThemeEfl.cpp:
  39592. 2011-03-30 Chris Fleizach <cfleizach@apple.com>
  39593. Reviewed by Darin Adler.
  39594. Regression: VO cursor doesn't follow KB focus back into HTML view
  39595. https://bugs.webkit.org/show_bug.cgi?id=57509
  39596. In WK2, because the web area never believes focus leave the area, sending the initial
  39597. focus change when moving back into the web area, does not trigger a notification.
  39598. That behavior needs to be overridden by explicitly posting a focused UI element change
  39599. at the appropriate time. This is only used in WK2, hence the absence of a layout test for now.
  39600. * page/FocusController.cpp:
  39601. (WebCore::FocusController::setInitialFocus):
  39602. 2011-03-30 MORITA Hajime <morrita@google.com>
  39603. Reviewed by Simon Fraser.
  39604. box-shadow radii stays the same regardless of any spread set
  39605. https://bugs.webkit.org/show_bug.cgi?id=49726
  39606. - Removed special shadowSpread handling path
  39607. - Fixed broken multple inset shadow border computation.
  39608. Test: fast/box-shadow/spread-multiple-inset.html
  39609. * rendering/RenderBoxModelObject.cpp:
  39610. (WebCore::RenderBoxModelObject::paintBoxShadow):
  39611. 2011-03-29 Matthew Delaney <mdelaney@apple.com>
  39612. Reviewed by Simon Fraser.
  39613. Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
  39614. https://bugs.webkit.org/show_bug.cgi?id=53134
  39615. Test: fast/canvas/getPutImageDataPairTest.html
  39616. * platform/graphics/cg/ImageBufferCG.cpp:
  39617. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  39618. Reviewed by Adam Roben.
  39619. Share most vsprops between Release and Production builds in releaseproduction.vsprops
  39620. https://bugs.webkit.org/show_bug.cgi?id=57508
  39621. * WebCore.vcproj/QTMovieWinProduction.vsprops:
  39622. * WebCore.vcproj/QTMovieWinRelease.vsprops:
  39623. * WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
  39624. * WebCore.vcproj/WebCoreProduction.vsprops:
  39625. * WebCore.vcproj/WebCoreRelease.vsprops:
  39626. * WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:
  39627. 2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
  39628. Reviewed by Alexey Proskuryakov.
  39629. Add some dynamic annotations to JavaScriptCore/wtf
  39630. https://bugs.webkit.org/show_bug.cgi?id=53747
  39631. By using these annotations we can improve the precision of finding
  39632. WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
  39633. These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
  39634. These files don't add new functionality, so don't need extra tests.
  39635. * ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
  39636. 2011-03-30 Abhishek Arya <inferno@chromium.org>
  39637. Reviewed by Simon Fraser.
  39638. Fix wrong type assumptions in editing code. Move code
  39639. from ASSERTs to hard checks.
  39640. https://bugs.webkit.org/show_bug.cgi?id=57348
  39641. Test: editing/execCommand/remove-format-non-html-element-crash.html
  39642. * css/CSSStyleSelector.cpp:
  39643. (WebCore::CSSStyleSelector::applyProperty):
  39644. * editing/ApplyStyleCommand.cpp:
  39645. (WebCore::getRGBAFontColor):
  39646. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
  39647. * editing/DeleteButtonController.cpp:
  39648. (WebCore::enclosingDeletableElement):
  39649. * editing/EditingStyle.cpp:
  39650. (WebCore::EditingStyle::textDirection):
  39651. (WebCore::EditingStyle::prepareToApplyAt):
  39652. * editing/Editor.cpp:
  39653. (WebCore::Editor::textDirectionForSelection):
  39654. * editing/FormatBlockCommand.cpp:
  39655. (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
  39656. 2011-03-30 Stephen White <senorblanco@chromium.org>
  39657. Reviewed by Kenneth Russell.
  39658. Speed up clipping in accelerated 2D canvas.
  39659. https://bugs.webkit.org/show_bug.cgi?id=57464
  39660. Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
  39661. Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.
  39662. * platform/graphics/chromium/GLES2Canvas.cpp:
  39663. (WebCore::PathAndTransform::PathAndTransform):
  39664. New structure to keep track of the CTM at the time the clipping path was added.
  39665. (WebCore::GLES2Canvas::State::State):
  39666. Replace m_clippingEnabled with a count of total clipping paths.
  39667. (WebCore::GLES2Canvas::clearRect):
  39668. Check the total clipping path count, instead of m_clippingEnabled.
  39669. (WebCore::GLES2Canvas::fillPath):
  39670. (WebCore::GLES2Canvas::fillRect):
  39671. Perform state application after doing shadows. This is necessary
  39672. since restore() may now leave clipping enabled.
  39673. (WebCore::GLES2Canvas::clipPath):
  39674. Explicitly specify the stencil operation as INCR. Store the current
  39675. transformation when saving clipping paths.
  39676. (WebCore::GLES2Canvas::restore):
  39677. Don't clear the stencil buffer and re-draw active paths on each restore.
  39678. Erase the old paths with DECR.
  39679. (WebCore::GLES2Canvas::drawTexturedRect):
  39680. Check m_numClippingPaths instead of m_clippingEnabled.
  39681. (WebCore::GLES2Canvas::beginShadowDraw):
  39682. Perform state application when drawing hard shadows.
  39683. (WebCore::GLES2Canvas::endShadowDraw):
  39684. Check m_numClippingPaths instead of m_clippingEnabled.
  39685. (WebCore::GLES2Canvas::beginStencilDraw):
  39686. Make the stencil op a parameter to beginShadowDraw().
  39687. (WebCore::GLES2Canvas::applyClipping):
  39688. Compare against the total number of stencil paths, not just the ones in
  39689. the current state.
  39690. * platform/graphics/chromium/GLES2Canvas.h:
  39691. Make the stencil op a parameter to beginShadowDraw().
  39692. 2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
  39693. Reviewed by Darin Adler.
  39694. Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
  39695. https://bugs.webkit.org/show_bug.cgi?id=57419
  39696. Refactoring, covered by existing tests.
  39697. * dom/EventDispatcher.cpp:
  39698. (WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
  39699. * dom/MouseEvent.cpp:
  39700. (WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
  39701. * dom/MouseEvent.h: Added decl.
  39702. 2011-03-30 Erik Arvidsson <arv@chromium.org>
  39703. Reviewed by Alexey Proskuryakov.
  39704. Missing DOM bindings for a ping
  39705. https://bugs.webkit.org/show_bug.cgi?id=51955
  39706. Test: fast/dom/ping-attribute-dom-binding.html
  39707. * html/HTMLAnchorElement.idl:
  39708. * html/HTMLAreaElement.idl:
  39709. 2011-03-30 Patrick Gansterer <paroga@webkit.org>
  39710. Unreviewed WinCE build fix for r82465.
  39711. * CMakeListsWinCE.txt:
  39712. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  39713. Reviewed by Adam Roben.
  39714. Update Windows production build logic for new production configurations
  39715. https://bugs.webkit.org/show_bug.cgi?id=57494
  39716. * WebCore.vcproj/QTMovieWinProduction.vsprops:
  39717. * WebCore.vcproj/WebCore.make:
  39718. * WebCore.vcproj/WebCoreProduction.vsprops:
  39719. 2011-03-30 Sam Weinig <sam@webkit.org>
  39720. Reviewed by Brady Eidson.
  39721. WebKit2: Attempting to view css file from url causes it to download
  39722. <rdar://problem/9102611>
  39723. https://bugs.webkit.org/show_bug.cgi?id=57501
  39724. * WebCore.exp.in:
  39725. * platform/MIMETypeRegistry.cpp:
  39726. (WebCore::initializeUnsupportedTextMIMETypes):
  39727. (WebCore::initializeMIMETypeRegistry):
  39728. (WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
  39729. (WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
  39730. * platform/MIMETypeRegistry.h:
  39731. Add set of unsupported text MIME types, taken from WebKit/mac.
  39732. 2011-03-30 Brian Weinstein <bweinstein@apple.com>
  39733. Reviewed by Darin Adler.
  39734. Crash when closing "Add Bookmark" dialog using the Enter Key
  39735. https://bugs.webkit.org/show_bug.cgi?id=57294
  39736. <rdar://problem/9044756>
  39737. Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
  39738. functions that could destroy the frame.
  39739. * page/EventHandler.cpp:
  39740. (WebCore::EventHandler::keyEvent):
  39741. 2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com>
  39742. Unreviewed, rolling out r82463.
  39743. http://trac.webkit.org/changeset/82463
  39744. https://bugs.webkit.org/show_bug.cgi?id=57482
  39745. Assertion failure in Node::rendererIsEditable on multiple
  39746. editing tests (Requested by aroben|meeting on #webkit).
  39747. * css/CSSParser.cpp:
  39748. (WebCore::CSSParser::parseValue):
  39749. * css/CSSPrimitiveValueMappings.h:
  39750. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  39751. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  39752. * css/CSSValueKeywords.in:
  39753. * rendering/style/RenderStyle.h:
  39754. * rendering/style/RenderStyleConstants.h:
  39755. 2011-03-24 Luiz Agostini <luiz.agostini@openbossa.org>
  39756. Reviewed by Kenneth Rohde Christiansen.
  39757. [Qt] QNetworkReplyHandler refactoring: signal sequence.
  39758. https://bugs.webkit.org/show_bug.cgi?id=57049
  39759. This is the first step in QNetworkReplyHandler. The main objective here is to create simple invariants:
  39760. 1 - that the signals metadatachanged, readyRead and finished will come in this order.
  39761. 2 - that signals metadatachanged and finished will be called exactly once.
  39762. Having these invariants further simplifications will be possible and will come in future patches.
  39763. Class QNetworkReplyWrapper was created to handle QNetworkReply object. To connect to the signals of it
  39764. instead of connecting to the signals of QNetworkReply is what guarantees the sequence of the signals.
  39765. QNetworkReplyWrapper will be used in future to perform mime type sniffing before sending
  39766. metadatachanged signal.
  39767. * platform/network/qt/QNetworkReplyHandler.cpp:
  39768. (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
  39769. (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
  39770. (WebCore::QNetworkReplyWrapper::release):
  39771. (WebCore::QNetworkReplyWrapper::resetConnections):
  39772. (WebCore::QNetworkReplyWrapper::receiveMetaData):
  39773. (WebCore::QNetworkReplyWrapper::didReceiveFinished):
  39774. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  39775. (WebCore::QNetworkReplyHandler::resetState):
  39776. (WebCore::QNetworkReplyHandler::release):
  39777. (WebCore::QNetworkReplyHandler::finish):
  39778. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  39779. (WebCore::QNetworkReplyHandler::redirect):
  39780. (WebCore::QNetworkReplyHandler::forwardData):
  39781. (WebCore::QNetworkReplyHandler::sendNetworkRequest):
  39782. (WebCore::QNetworkReplyHandler::start):
  39783. * platform/network/qt/QNetworkReplyHandler.h:
  39784. (WebCore::QNetworkReplyWrapper::reply):
  39785. (WebCore::QNetworkReplyWrapper::redirectionTargetUrl):
  39786. (WebCore::QNetworkReplyWrapper::encoding):
  39787. (WebCore::QNetworkReplyWrapper::advertisedMimeType):
  39788. (WebCore::QNetworkReplyHandler::reply):
  39789. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  39790. Reviewed by Adam Roben.
  39791. Rename Windows configuration Release_LTCG to Production for clarity
  39792. https://bugs.webkit.org/show_bug.cgi?id=57465
  39793. * WebCore.vcproj/QTMovieWin.vcproj:
  39794. * WebCore.vcproj/QTMovieWinProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops.
  39795. * WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Removed.
  39796. * WebCore.vcproj/WebCore.sln:
  39797. * WebCore.vcproj/WebCore.submit.sln:
  39798. * WebCore.vcproj/WebCore.vcproj:
  39799. * WebCore.vcproj/WebCoreGenerated.vcproj:
  39800. * WebCore.vcproj/WebCoreProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/WebCoreReleaseLTCG.vsprops.
  39801. * WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Removed.
  39802. 2011-03-30 Brian Weinstein <bweinstein@apple.com>
  39803. Reviewed by Anders Carlsson.
  39804. ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
  39805. https://bugs.webkit.org/show_bug.cgi?id=57477
  39806. <rdar://problem/9178751>
  39807. If someone has called startObservingCookieChanges, and the WebProcess crashes and restarts, the UIProcess
  39808. will call stopObservingCookieChanges when cookieStorageAdapter is nil.
  39809. The assert is wrong when the web process crashes, and there is no harm in dispatching a message to nil,
  39810. so remove the assert.
  39811. * platform/network/mac/CookieStorageMac.mm:
  39812. (WebCore::stopObservingCookieChanges):
  39813. 2011-03-30 Sam Weinig <sam@webkit.org>
  39814. Fix Leopard build.
  39815. * platform/DefaultLocalizationStrategy.cpp:
  39816. (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
  39817. 2011-03-30 Sam Weinig <sam@webkit.org>
  39818. Reviewed by Anders Carlsson.
  39819. Add default localization strategy that can be shared by WebKit1 and WebKit2
  39820. https://bugs.webkit.org/show_bug.cgi?id=57406
  39821. Currently, only WebKit2 uses this default strategy, but WebKit1 should be able
  39822. to adopt it soon.
  39823. * platform/DefaultLocalizationStrategy.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp.
  39824. (WebCore::DefaultLocalizationStrategy::DefaultLocalizationStrategy):
  39825. * platform/DefaultLocalizationStrategy.h: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h.
  39826. Copy the implementation of the Localization strategy from WebKit2 into a shared default strategy.
  39827. * platform/LocalizedStrings.cpp:
  39828. (WebCore::localizedString):
  39829. Add default implementation of localization bottleneck function.
  39830. * platform/LocalizedStrings.h:
  39831. Add localization macros here, instead of defining them in the above layer.
  39832. * platform/PlatformStrategies.cpp:
  39833. (WebCore::PlatformStrategies::createLocalizationStrategy):
  39834. * platform/PlatformStrategies.h:
  39835. Add default implementation of strategy creation function which creates the default strategy.
  39836. * platform/win/LocalizedStringsWin.cpp: Copied from Source/WebCore/platform/mac/LocalizedStringsMac.mm.
  39837. (WebCore::localizedString):
  39838. Add stub for windows, this will be update to pull from the bundle in a follow up patch.
  39839. * Android.mk:
  39840. * CMakeLists.txt:
  39841. * GNUmakefile.am:
  39842. * WebCore.exp.in:
  39843. * WebCore.gypi:
  39844. * WebCore.pro:
  39845. * WebCore.vcproj/WebCore.vcproj:
  39846. * WebCore.xcodeproj/project.pbxproj:
  39847. Add new files.
  39848. 2011-03-30 Andras Becsi <abecsi@webkit.org>
  39849. Reviewed by Darin Adler.
  39850. CSS: Slow parsing of rgb() with percent values
  39851. https://bugs.webkit.org/show_bug.cgi?id=16708
  39852. Implement fast-path parsing for percentage color values.
  39853. Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html
  39854. Relanding with rounding fix after it was rolled out in r82315.
  39855. * css/CSSParser.cpp:
  39856. (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
  39857. (WebCore::parseDouble): Function for parsing double values if they are valid.
  39858. (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
  39859. (WebCore::parseAlphaValue): Use the new functions.
  39860. (WebCore::CSSParser::parseColor): Ditto.
  39861. 2011-03-30 Ofri Wolfus <ofri@dhcp-172-28-40-178.tlv.corp.google.com>
  39862. Reviewed by Eric Seidel.
  39863. Add support for parsing unicode-bidi: -webkit-plaintext.
  39864. https://bugs.webkit.org/show_bug.cgi?id=57457
  39865. Test: css3/unicode-bidi-plaintext-parse.html
  39866. * css/CSSParser.cpp:
  39867. (WebCore::CSSParser::parseValue):
  39868. * css/CSSPrimitiveValueMappings.h:
  39869. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  39870. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  39871. * css/CSSValueKeywords.in:
  39872. * rendering/style/RenderStyle.h:
  39873. * rendering/style/RenderStyleConstants.h:
  39874. 2011-03-30 Andreas Kling <kling@webkit.org>
  39875. Reviewed by Benjamin Poulain.
  39876. [Qt] Remove unused variables in GraphicsContext::fillRect()
  39877. * platform/graphics/qt/GraphicsContextQt.cpp:
  39878. (WebCore::GraphicsContext::fillRect):
  39879. 2011-03-30 Yael Aharon <yael.aharon@nokia.com>
  39880. Reviewed by Eric Seidel.
  39881. REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
  39882. https://bugs.webkit.org/show_bug.cgi?id=57442
  39883. When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.
  39884. No new tests as existing test covers this case.
  39885. * rendering/RenderBlockLineLayout.cpp:
  39886. (WebCore::reachedEndOfTextRenderer):
  39887. 2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>
  39888. Reviewed by Chris Fleizach.
  39889. AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
  39890. https://bugs.webkit.org/show_bug.cgi?id=47636
  39891. Define new roles in WebCore and map them to ATK accordingly.
  39892. Test: platform/gtk/accessibility/aria-roles-unignored.html
  39893. * accessibility/AccessibilityObject.h: Added new roles to
  39894. represent paragraphs, labels, forms and div sections.
  39895. * accessibility/AccessibilityRenderObject.cpp:
  39896. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  39897. Return ParagraphRole, LabelRole, FormRole and DivRole when needed
  39898. for the GTK platform only.
  39899. * accessibility/gtk/AccessibilityObjectAtk.cpp:
  39900. (WebCore::AccessibilityObject::allowsTextRanges): Consider the new
  39901. roles now that those kind of nodes won't return true to isGroup().
  39902. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  39903. (atkRole): Map new WebCore roles to ATK Roles.
  39904. (webkit_accessible_get_role): Remove code to define roles for
  39905. paragraphs, labels, forms and divs based on node's tag name.
  39906. Update mappings for the Mac platform.
  39907. * accessibility/mac/AccessibilityObjectWrapper.mm:
  39908. (createAccessibilityRoleMap): Add explicit mappings from the new
  39909. roles introduced to NSAccessibilityGroupRole.
  39910. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  39911. Unreviewed. Build fix for Efl and Qt Win.
  39912. * inspector/PageDebuggerAgent.cpp: removed ENABLE(WORKERS) guard from code that has nothing to do with workers.
  39913. 2011-03-30 Andrey Kosyakov <caseq@chromium.org>
  39914. Reviewed by Pavel Feldman.
  39915. Web Inspector: audit run never completes, fails in DOMAgent.js
  39916. https://bugs.webkit.org/show_bug.cgi?id=57349
  39917. - assure document is present before calling DOMAgent.querySelectAll()
  39918. * inspector/front-end/AuditRules.js:
  39919. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  39920. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  39921. Unreviewed. Build fix.
  39922. * UseJSC.cmake: fix typo PageDebugServer -> PageScriptDebugServer
  39923. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  39924. Reviewed by Pavel Feldman.
  39925. Web Inspector: split debugger agent into Page and Worker-specific ones
  39926. https://bugs.webkit.org/show_bug.cgi?id=57345
  39927. ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
  39928. for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
  39929. and Page/WorkerDebuggerAgent.
  39930. * CMakeLists.txt:
  39931. * GNUmakefile.am:
  39932. * UseJSC.cmake:
  39933. * WebCore.gypi:
  39934. * WebCore.pro:
  39935. * WebCore.vcproj/WebCore.vcproj:
  39936. * WebCore.xcodeproj/project.pbxproj:
  39937. * bindings/js/JSBindingsAllInOne.cpp:
  39938. * bindings/js/JSInjectedScriptHostCustom.cpp:
  39939. (WebCore::JSInjectedScriptHost::currentCallFrame):
  39940. * bindings/js/PageScriptDebugServer.cpp: Added.
  39941. (WebCore::toPage):
  39942. (WebCore::PageScriptDebugServer::shared):
  39943. (WebCore::PageScriptDebugServer::PageScriptDebugServer):
  39944. (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  39945. (WebCore::PageScriptDebugServer::addListener):
  39946. (WebCore::PageScriptDebugServer::removeListener):
  39947. (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
  39948. (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
  39949. (WebCore::PageScriptDebugServer::didPause):
  39950. (WebCore::PageScriptDebugServer::didContinue):
  39951. (WebCore::PageScriptDebugServer::didRemoveLastListener):
  39952. (WebCore::PageScriptDebugServer::setJavaScriptPaused):
  39953. * bindings/js/PageScriptDebugServer.h: Added.
  39954. * bindings/js/ScriptDebugServer.cpp:
  39955. (WebCore::ScriptDebugServer::ScriptDebugServer):
  39956. (WebCore::ScriptDebugServer::sourceParsed):
  39957. (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
  39958. (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
  39959. (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  39960. (WebCore::ScriptDebugServer::pauseIfNeeded):
  39961. * bindings/js/ScriptDebugServer.h:
  39962. * bindings/js/WorkerScriptDebugServer.cpp: Added.
  39963. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
  39964. (WebCore::WorkerScriptDebugServer::addListener):
  39965. (WebCore::WorkerScriptDebugServer::removeListener):
  39966. * bindings/js/WorkerScriptDebugServer.h: Added.
  39967. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
  39968. (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
  39969. (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
  39970. (WebCore::WorkerScriptDebugServer::didPause):
  39971. (WebCore::WorkerScriptDebugServer::didContinue):
  39972. * bindings/v8/PageScriptDebugServer.cpp: Added.
  39973. (WebCore::retrieveFrame):
  39974. (WebCore::PageScriptDebugServer::shared):
  39975. (WebCore::PageScriptDebugServer::PageScriptDebugServer):
  39976. (WebCore::PageScriptDebugServer::addListener):
  39977. (WebCore::PageScriptDebugServer::removeListener):
  39978. (WebCore::PageScriptDebugServer::setClientMessageLoop):
  39979. (WebCore::PageScriptDebugServer::getDebugListenerForContext):
  39980. (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
  39981. (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
  39982. * bindings/v8/PageScriptDebugServer.h: Added.
  39983. (WebCore::PageScriptDebugServer::setEnabled):
  39984. (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
  39985. (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  39986. * bindings/v8/ScriptDebugServer.cpp:
  39987. (WebCore::ScriptDebugServer::ScriptDebugServer):
  39988. (WebCore::ScriptDebugServer::setPauseOnNextStatement):
  39989. (WebCore::ScriptDebugServer::breakProgram):
  39990. (WebCore::ScriptDebugServer::continueProgram):
  39991. (WebCore::ScriptDebugServer::stepIntoStatement):
  39992. (WebCore::ScriptDebugServer::stepOverStatement):
  39993. (WebCore::ScriptDebugServer::stepOutOfFunction):
  39994. (WebCore::ScriptDebugServer::editScriptSource):
  39995. (WebCore::toScriptDebugServer):
  39996. (WebCore::ScriptDebugServer::breakProgramCallback):
  39997. (WebCore::ScriptDebugServer::v8DebugEventCallback):
  39998. (WebCore::ScriptDebugServer::handleV8DebugEvent):
  39999. (WebCore::ScriptDebugServer::isPaused):
  40000. * bindings/v8/ScriptDebugServer.h:
  40001. * bindings/v8/WorkerScriptDebugServer.cpp: Added.
  40002. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
  40003. (WebCore::WorkerScriptDebugServer::addListener):
  40004. (WebCore::WorkerScriptDebugServer::removeListener):
  40005. * bindings/v8/WorkerScriptDebugServer.h: Added.
  40006. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
  40007. (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
  40008. (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
  40009. (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  40010. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  40011. (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  40012. * inspector/InjectedScriptHost.h:
  40013. (WebCore::InjectedScriptHost::init):
  40014. (WebCore::InjectedScriptHost::debuggerAgent):
  40015. * inspector/InspectorAgent.cpp:
  40016. (WebCore::InspectorAgent::InspectorAgent):
  40017. * inspector/InspectorDebuggerAgent.cpp:
  40018. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  40019. (WebCore::InspectorDebuggerAgent::enable):
  40020. (WebCore::InspectorDebuggerAgent::disable):
  40021. (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
  40022. (WebCore::InspectorDebuggerAgent::removeBreakpoint):
  40023. (WebCore::InspectorDebuggerAgent::continueToLocation):
  40024. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  40025. (WebCore::InspectorDebuggerAgent::editScriptSource):
  40026. (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
  40027. (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
  40028. (WebCore::InspectorDebuggerAgent::resume):
  40029. (WebCore::InspectorDebuggerAgent::stepOver):
  40030. (WebCore::InspectorDebuggerAgent::stepInto):
  40031. (WebCore::InspectorDebuggerAgent::stepOut):
  40032. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  40033. (WebCore::InspectorDebuggerAgent::didPause):
  40034. (WebCore::InspectorDebuggerAgent::breakProgram):
  40035. * inspector/InspectorDebuggerAgent.h:
  40036. * inspector/InspectorProfilerAgent.cpp:
  40037. (WebCore::InspectorProfilerAgent::disable):
  40038. (WebCore::InspectorProfilerAgent::enable):
  40039. (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  40040. * inspector/PageDebuggerAgent.cpp: Added.
  40041. (WebCore::PageDebuggerAgent::create):
  40042. (WebCore::PageDebuggerAgent::PageDebuggerAgent):
  40043. (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
  40044. (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
  40045. (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
  40046. (WebCore::PageDebuggerAgent::scriptDebugServer):
  40047. * inspector/PageDebuggerAgent.h: Added.
  40048. * inspector/WorkerDebuggerAgent.cpp: Added.
  40049. (WebCore::WorkerDebuggerAgent::create):
  40050. (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
  40051. (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
  40052. (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
  40053. (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
  40054. (WebCore::WorkerDebuggerAgent::scriptDebugServer):
  40055. * inspector/WorkerDebuggerAgent.h: Added.
  40056. 2011-03-30 Levi Weintraub <leviw@chromium.org>
  40057. Reviewed by Ryosuke Niwa.
  40058. Clicking below last line of right-to-left editable text that puts caret in the wrong place
  40059. https://bugs.webkit.org/show_bug.cgi?id=38087
  40060. Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
  40061. instead of lastLeafChild, which wasn't correct in the RTL case.
  40062. Test: editing/selection/click-below-rtl-text.html
  40063. * editing/visible_units.cpp:
  40064. (WebCore::logicalStartPositionForLine): Moved to RootInlineBox.
  40065. (WebCore::logicalEndPositionForLine): Ditto.
  40066. * editing/visible_units.h:
  40067. * rendering/RenderBlock.cpp:
  40068. (WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead
  40069. of lastLeafChild.
  40070. * rendering/RootInlineBox.cpp:
  40071. (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored.
  40072. (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
  40073. * rendering/RootInlineBox.h:
  40074. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  40075. Unreviewed. Rollout r82438 and r82436.
  40076. * CMakeLists.txt:
  40077. * GNUmakefile.am:
  40078. * UseJSC.cmake:
  40079. * WebCore.gypi:
  40080. * WebCore.pro:
  40081. * WebCore.vcproj/WebCore.vcproj:
  40082. * WebCore.xcodeproj/project.pbxproj:
  40083. * bindings/js/JSBindingsAllInOne.cpp:
  40084. * bindings/js/JSInjectedScriptHostCustom.cpp:
  40085. (WebCore::JSInjectedScriptHost::currentCallFrame):
  40086. * bindings/js/PageScriptDebugServer.cpp: Removed.
  40087. * bindings/js/PageScriptDebugServer.h: Removed.
  40088. * bindings/js/ScriptDebugServer.cpp:
  40089. (WebCore::ScriptDebugServer::shared):
  40090. (WebCore::ScriptDebugServer::ScriptDebugServer):
  40091. (WebCore::ScriptDebugServer::addListener):
  40092. (WebCore::ScriptDebugServer::removeListener):
  40093. (WebCore::ScriptDebugServer::hasListenersInterestedInPage):
  40094. (WebCore::toPage):
  40095. (WebCore::ScriptDebugServer::sourceParsed):
  40096. (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
  40097. (WebCore::ScriptDebugServer::setJavaScriptPaused):
  40098. (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
  40099. (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  40100. (WebCore::ScriptDebugServer::pauseIfNeeded):
  40101. (WebCore::ScriptDebugServer::recompileAllJSFunctions):
  40102. (WebCore::ScriptDebugServer::didAddListener):
  40103. (WebCore::ScriptDebugServer::didRemoveListener):
  40104. * bindings/js/ScriptDebugServer.h:
  40105. * bindings/js/WorkerScriptDebugServer.cpp: Removed.
  40106. * bindings/js/WorkerScriptDebugServer.h: Removed.
  40107. * bindings/v8/PageScriptDebugServer.cpp: Removed.
  40108. * bindings/v8/PageScriptDebugServer.h: Removed.
  40109. * bindings/v8/ScriptDebugServer.cpp:
  40110. (WebCore::retrieveFrame):
  40111. (WebCore::ScriptDebugServer::shared):
  40112. (WebCore::ScriptDebugServer::ScriptDebugServer):
  40113. (WebCore::ScriptDebugServer::addListener):
  40114. (WebCore::ScriptDebugServer::removeListener):
  40115. (WebCore::ScriptDebugServer::setPauseOnNextStatement):
  40116. (WebCore::ScriptDebugServer::breakProgram):
  40117. (WebCore::ScriptDebugServer::continueProgram):
  40118. (WebCore::ScriptDebugServer::stepIntoStatement):
  40119. (WebCore::ScriptDebugServer::stepOverStatement):
  40120. (WebCore::ScriptDebugServer::stepOutOfFunction):
  40121. (WebCore::ScriptDebugServer::editScriptSource):
  40122. (WebCore::ScriptDebugServer::setEnabled):
  40123. (WebCore::ScriptDebugServer::breakProgramCallback):
  40124. (WebCore::ScriptDebugServer::v8DebugEventCallback):
  40125. (WebCore::ScriptDebugServer::handleV8DebugEvent):
  40126. (WebCore::ScriptDebugServer::didResume):
  40127. * bindings/v8/ScriptDebugServer.h:
  40128. (WebCore::ScriptDebugServer::pageCreated):
  40129. (WebCore::ScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
  40130. (WebCore::ScriptDebugServer::setClientMessageLoop):
  40131. * bindings/v8/WorkerScriptDebugServer.cpp: Removed.
  40132. * bindings/v8/WorkerScriptDebugServer.h: Removed.
  40133. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  40134. (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  40135. * inspector/InjectedScriptHost.h:
  40136. (WebCore::InjectedScriptHost::init):
  40137. * inspector/InspectorAgent.cpp:
  40138. (WebCore::InspectorAgent::InspectorAgent):
  40139. * inspector/InspectorDebuggerAgent.cpp:
  40140. (WebCore::InspectorDebuggerAgent::create):
  40141. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  40142. (WebCore::InspectorDebuggerAgent::enable):
  40143. (WebCore::InspectorDebuggerAgent::disable):
  40144. (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
  40145. (WebCore::InspectorDebuggerAgent::removeBreakpoint):
  40146. (WebCore::InspectorDebuggerAgent::continueToLocation):
  40147. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  40148. (WebCore::InspectorDebuggerAgent::editScriptSource):
  40149. (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
  40150. (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
  40151. (WebCore::InspectorDebuggerAgent::resume):
  40152. (WebCore::InspectorDebuggerAgent::stepOver):
  40153. (WebCore::InspectorDebuggerAgent::stepInto):
  40154. (WebCore::InspectorDebuggerAgent::stepOut):
  40155. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  40156. (WebCore::InspectorDebuggerAgent::didPause):
  40157. (WebCore::InspectorDebuggerAgent::breakProgram):
  40158. * inspector/InspectorDebuggerAgent.h:
  40159. * inspector/InspectorProfilerAgent.cpp:
  40160. (WebCore::InspectorProfilerAgent::disable):
  40161. (WebCore::InspectorProfilerAgent::enable):
  40162. (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  40163. * inspector/PageDebuggerAgent.cpp: Removed.
  40164. * inspector/PageDebuggerAgent.h: Removed.
  40165. * inspector/WorkerDebuggerAgent.cpp: Removed.
  40166. * inspector/WorkerDebuggerAgent.h: Removed.
  40167. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  40168. Unreviewed. Fix compilation on Windows and EFL.
  40169. * CMakeLists.txt:
  40170. * bindings/js/JSBindingsAllInOne.cpp:
  40171. 2011-03-30 Yury Semikhatsky <yurys@chromium.org>
  40172. Reviewed by Pavel Feldman.
  40173. Web Inspector: split debugger agent into Page and Worker-specific ones
  40174. https://bugs.webkit.org/show_bug.cgi?id=57345
  40175. ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
  40176. for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
  40177. and Page/WorkerDebuggerAgent.
  40178. * GNUmakefile.am:
  40179. * UseJSC.cmake:
  40180. * WebCore.gypi:
  40181. * WebCore.pro:
  40182. * WebCore.vcproj/WebCore.vcproj:
  40183. * WebCore.xcodeproj/project.pbxproj:
  40184. * bindings/js/JSInjectedScriptHostCustom.cpp:
  40185. (WebCore::JSInjectedScriptHost::currentCallFrame):
  40186. * bindings/js/PageScriptDebugServer.cpp: Added.
  40187. (WebCore::toPage):
  40188. (WebCore::PageScriptDebugServer::shared):
  40189. (WebCore::PageScriptDebugServer::PageScriptDebugServer):
  40190. (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  40191. (WebCore::PageScriptDebugServer::addListener):
  40192. (WebCore::PageScriptDebugServer::removeListener):
  40193. (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
  40194. (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
  40195. (WebCore::PageScriptDebugServer::didPause):
  40196. (WebCore::PageScriptDebugServer::didContinue):
  40197. (WebCore::PageScriptDebugServer::didRemoveLastListener):
  40198. (WebCore::PageScriptDebugServer::setJavaScriptPaused):
  40199. * bindings/js/PageScriptDebugServer.h: Added.
  40200. * bindings/js/ScriptDebugServer.cpp:
  40201. (WebCore::ScriptDebugServer::ScriptDebugServer):
  40202. (WebCore::ScriptDebugServer::sourceParsed):
  40203. (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
  40204. (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
  40205. (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  40206. (WebCore::ScriptDebugServer::pauseIfNeeded):
  40207. * bindings/js/ScriptDebugServer.h:
  40208. * bindings/js/WorkerScriptDebugServer.cpp: Added.
  40209. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
  40210. (WebCore::WorkerScriptDebugServer::addListener):
  40211. (WebCore::WorkerScriptDebugServer::removeListener):
  40212. * bindings/js/WorkerScriptDebugServer.h: Added.
  40213. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
  40214. (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
  40215. (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
  40216. (WebCore::WorkerScriptDebugServer::didPause):
  40217. (WebCore::WorkerScriptDebugServer::didContinue):
  40218. * bindings/v8/PageScriptDebugServer.cpp: Added.
  40219. (WebCore::retrieveFrame):
  40220. (WebCore::PageScriptDebugServer::shared):
  40221. (WebCore::PageScriptDebugServer::PageScriptDebugServer):
  40222. (WebCore::PageScriptDebugServer::addListener):
  40223. (WebCore::PageScriptDebugServer::removeListener):
  40224. (WebCore::PageScriptDebugServer::setClientMessageLoop):
  40225. (WebCore::PageScriptDebugServer::getDebugListenerForContext):
  40226. (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
  40227. (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
  40228. * bindings/v8/PageScriptDebugServer.h: Added.
  40229. (WebCore::PageScriptDebugServer::setEnabled):
  40230. (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
  40231. (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  40232. * bindings/v8/ScriptDebugServer.cpp:
  40233. (WebCore::ScriptDebugServer::ScriptDebugServer):
  40234. (WebCore::ScriptDebugServer::setPauseOnNextStatement):
  40235. (WebCore::ScriptDebugServer::breakProgram):
  40236. (WebCore::ScriptDebugServer::continueProgram):
  40237. (WebCore::ScriptDebugServer::stepIntoStatement):
  40238. (WebCore::ScriptDebugServer::stepOverStatement):
  40239. (WebCore::ScriptDebugServer::stepOutOfFunction):
  40240. (WebCore::ScriptDebugServer::editScriptSource):
  40241. (WebCore::toScriptDebugServer):
  40242. (WebCore::ScriptDebugServer::breakProgramCallback):
  40243. (WebCore::ScriptDebugServer::v8DebugEventCallback):
  40244. (WebCore::ScriptDebugServer::handleV8DebugEvent):
  40245. (WebCore::ScriptDebugServer::isPaused):
  40246. * bindings/v8/ScriptDebugServer.h:
  40247. * bindings/v8/WorkerScriptDebugServer.cpp: Added.
  40248. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
  40249. (WebCore::WorkerScriptDebugServer::addListener):
  40250. (WebCore::WorkerScriptDebugServer::removeListener):
  40251. * bindings/v8/WorkerScriptDebugServer.h: Added.
  40252. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
  40253. (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
  40254. (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
  40255. (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  40256. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  40257. (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  40258. * inspector/InjectedScriptHost.h:
  40259. (WebCore::InjectedScriptHost::init):
  40260. (WebCore::InjectedScriptHost::debuggerAgent):
  40261. * inspector/InspectorAgent.cpp:
  40262. (WebCore::InspectorAgent::InspectorAgent):
  40263. * inspector/InspectorDebuggerAgent.cpp:
  40264. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  40265. (WebCore::InspectorDebuggerAgent::enable):
  40266. (WebCore::InspectorDebuggerAgent::disable):
  40267. (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
  40268. (WebCore::InspectorDebuggerAgent::removeBreakpoint):
  40269. (WebCore::InspectorDebuggerAgent::continueToLocation):
  40270. (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
  40271. (WebCore::InspectorDebuggerAgent::editScriptSource):
  40272. (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
  40273. (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
  40274. (WebCore::InspectorDebuggerAgent::resume):
  40275. (WebCore::InspectorDebuggerAgent::stepOver):
  40276. (WebCore::InspectorDebuggerAgent::stepInto):
  40277. (WebCore::InspectorDebuggerAgent::stepOut):
  40278. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  40279. (WebCore::InspectorDebuggerAgent::didPause):
  40280. (WebCore::InspectorDebuggerAgent::breakProgram):
  40281. * inspector/InspectorDebuggerAgent.h:
  40282. * inspector/InspectorProfilerAgent.cpp:
  40283. (WebCore::InspectorProfilerAgent::disable):
  40284. (WebCore::InspectorProfilerAgent::enable):
  40285. (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  40286. * inspector/PageDebuggerAgent.cpp: Added.
  40287. (WebCore::PageDebuggerAgent::create):
  40288. (WebCore::PageDebuggerAgent::PageDebuggerAgent):
  40289. (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
  40290. (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
  40291. (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
  40292. (WebCore::PageDebuggerAgent::scriptDebugServer):
  40293. * inspector/PageDebuggerAgent.h: Added.
  40294. * inspector/WorkerDebuggerAgent.cpp: Added.
  40295. (WebCore::WorkerDebuggerAgent::create):
  40296. (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
  40297. (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
  40298. (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
  40299. (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
  40300. (WebCore::WorkerDebuggerAgent::scriptDebugServer):
  40301. * inspector/WorkerDebuggerAgent.h: Added.
  40302. 2011-03-30 Alexander Pavlov <apavlov@chromium.org>
  40303. Reviewed by Pavel Feldman.
  40304. Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map
  40305. https://bugs.webkit.org/show_bug.cgi?id=57440
  40306. * inspector/InspectorCSSAgent.cpp:
  40307. (WebCore::InspectorCSSAgent::getStylesForNode):
  40308. (WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
  40309. * inspector/InspectorCSSAgent.h:
  40310. * inspector/front-end/CSSStyleModel.js:
  40311. (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  40312. 2011-03-30 Evan Martin <evan@chromium.org>
  40313. Reviewed by Ryosuke Niwa.
  40314. Fix a last-second ASSERT in previous change that was wrong.
  40315. * dom/Document.cpp:
  40316. (WebCore::Document::setTitle):
  40317. 2011-03-30 Levi Weintraub <leviw@chromium.org>
  40318. Reviewed by Eric Seidel.
  40319. RTL: Directionality always reset on hard line break
  40320. https://bugs.webkit.org/show_bug.cgi?id=23124
  40321. No longer clearing all BidiContexts when we hit a hard line break.
  40322. Instead, directionality applied by DOM elements is preserved by
  40323. reconstructing the context stack ignoring those that didn't come
  40324. from the DOM.
  40325. Test: fast/text/international/bidi-br-as-paragraph-separator.html
  40326. * platform/text/BidiContext.cpp:
  40327. (WebCore::BidiContext::createUncached):
  40328. (WebCore::BidiContext::create):
  40329. (WebCore::copyContextAndRebaselineLevel): Helper to make a copy of a context
  40330. and recalculate its bidi level.
  40331. (WebCore::BidiContext::copyStackRemovingUnicodeEmbeddingContexts): Returns the top of
  40332. a BidiContext stack that's equivalent but without contexts from Unicode directional
  40333. characters.
  40334. (WebCore::operator==): Now takes into account embedding source.
  40335. * platform/text/BidiContext.h:
  40336. (WebCore::BidiContext::source): Enum to specify whether an embedded
  40337. bidirectional control came from the DOM/Style or Unicode characters
  40338. (WebCore::BidiContext::BidiContext):
  40339. * platform/text/BidiResolver.h:
  40340. (WebCore::BidiEmbedding::BidiEmbedding): An embedding is now a direction
  40341. and a hint about where it came from so we can differentiate DOM directions
  40342. from unicode direction control characters.
  40343. (WebCore::BidiEmbedding::direction):
  40344. (WebCore::BidiEmbedding::source):
  40345. (WebCore::::embed): Now takes a source as well as a direction.
  40346. (WebCore::::commitExplicitEmbedding):
  40347. (WebCore::::createBidiRunsForLine):
  40348. * rendering/InlineIterator.h:
  40349. (WebCore::bidiNext):
  40350. (WebCore::bidiFirst):
  40351. * rendering/RenderBlockLineLayout.cpp:
  40352. (WebCore::RenderBlock::determineStartPosition):
  40353. 2011-03-30 Steve Block <steveblock@google.com>
  40354. Reviewed by Jeremy Orlow.
  40355. JavaMethod should not expose JavaString in its API
  40356. https://bugs.webkit.org/show_bug.cgi?id=55765
  40357. - Factors out a JavaMethod interface which does not use JNI types.
  40358. This will allow the Java bridge to be used with objects that
  40359. don't use JNI directly. The existing jobject-backed
  40360. implementation is moved to a new JavaMethodJobject class which
  40361. implements the interface.
  40362. - Use WTF::String in place of JavaString in the API, as JavaString
  40363. exposes JNI types in its interface.
  40364. - Remove the method ID as it uses JNI types.
  40365. No new tests, refactoring only.
  40366. * Android.jscbindings.mk:
  40367. * Android.v8bindings.mk:
  40368. * GNUmakefile.am:
  40369. * WebCore.gypi:
  40370. * WebCore.xcodeproj/project.pbxproj:
  40371. * bridge/jni/JavaMethod.h:
  40372. * bridge/jni/JavaMethodJobject.cpp:
  40373. (JavaMethodJobject::JavaMethodJobject):
  40374. (JavaMethodJobject::~JavaMethodJobject):
  40375. (appendClassName):
  40376. (JavaMethodJobject::signature):
  40377. * bridge/jni/JavaMethodJobject.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
  40378. (JSC::Bindings::JavaMethodJobject::name):
  40379. (JSC::Bindings::JavaMethodJobject::returnTypeClassName):
  40380. (JSC::Bindings::JavaMethodJobject::parameterAt):
  40381. (JSC::Bindings::JavaMethodJobject::returnType):
  40382. (JSC::Bindings::JavaMethodJobject::isStatic):
  40383. (JSC::Bindings::JavaMethodJobject::numParameters):
  40384. * bridge/jni/jsc/JavaClassJSC.cpp:
  40385. (JavaClass::JavaClass):
  40386. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  40387. (JavaInstance::invokeMethod):
  40388. * bridge/jni/v8/JavaClassV8.cpp:
  40389. (JavaClass::JavaClass):
  40390. * bridge/jni/v8/JavaInstanceV8.cpp:
  40391. (JavaInstance::invokeMethod):
  40392. 2011-03-30 Evan Martin <evan@chromium.org>
  40393. Reviewed by Ryosuke Niwa.
  40394. clean up Document's handling of title changes
  40395. https://bugs.webkit.org/show_bug.cgi?id=57433
  40396. Document::setTitle has two entry points:
  40397. 1) from DOM bindings, like document.title="foo"
  40398. 2) from title tags, like <title>foo</title> in HTML
  40399. Split these two code paths to make the code easier to follow.
  40400. Also, replace the repeated pattern of
  40401. m_rawTitle = "foo"; updateTitle();
  40402. with
  40403. updateTitle("foo");
  40404. * dom/Document.cpp:
  40405. (WebCore::Document::updateTitle):
  40406. (WebCore::Document::setTitle):
  40407. (WebCore::Document::setTitleElement):
  40408. (WebCore::Document::removeTitle):
  40409. * dom/Document.h:
  40410. * html/HTMLTitleElement.cpp:
  40411. (WebCore::HTMLTitleElement::insertedIntoDocument):
  40412. (WebCore::HTMLTitleElement::childrenChanged):
  40413. * svg/SVGTitleElement.cpp:
  40414. (WebCore::SVGTitleElement::insertedIntoDocument):
  40415. (WebCore::SVGTitleElement::childrenChanged):
  40416. 2011-03-30 Levi Weintraub <leviw@chromium.org>
  40417. Reviewed by Ryosuke Niwa.
  40418. BreakBlockQuoteCommand assumes all li tags have list item renderers
  40419. https://bugs.webkit.org/show_bug.cgi?id=57253
  40420. Checking that the renderers of li nodes are actually RenderListItems
  40421. before treating them as such.
  40422. Test: editing/execCommand/crash-breaking-blockquote-with-list.html
  40423. * editing/BreakBlockquoteCommand.cpp:
  40424. (WebCore::BreakBlockQuoteCommand::doApply):
  40425. 2011-03-30 Pavel Feldman <pfeldman@chromium.org>
  40426. Not reviewed: fixing typo in the inspector front-end.
  40427. Web Inspector: REGRESSION: Broken live edit errors handling
  40428. https://bugs.webkit.org/show_bug.cgi?id=57436
  40429. * inspector/front-end/DebuggerModel.js:
  40430. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  40431. 2011-03-30 Yael Aharon <yael.aharon@nokia.com>
  40432. Reviewed by Eric Seidel.
  40433. Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements
  40434. https://bugs.webkit.org/show_bug.cgi?id=9272
  40435. Also fixes https://bugs.webkit.org/show_bug.cgi?id=47210 and https://bugs.webkit.org/show_bug.cgi?id=8392.
  40436. Change how we decide if an InlineFlowBox is the last one for its renderer. Use the position of resolver's logicallyLastRun
  40437. to decide if there is more text in the next line.
  40438. Tests: fast/borders/rtl-border-01.html
  40439. fast/borders/rtl-border-02.html
  40440. fast/borders/rtl-border-03.html
  40441. fast/borders/rtl-border-04.html
  40442. fast/borders/rtl-border-05.html
  40443. * rendering/InlineFlowBox.cpp:
  40444. (WebCore::isAnsectorAndWithinBlock):
  40445. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  40446. * rendering/InlineFlowBox.h:
  40447. * rendering/RenderBlock.h:
  40448. * rendering/RenderBlockLineLayout.cpp:
  40449. (WebCore::RenderBlock::constructLine):
  40450. (WebCore::reachedEndOfTextRenderer):
  40451. (WebCore::RenderBlock::layoutInlineChildren):
  40452. 2011-03-29 Nikolas Zimmermann <nzimmermann@rim.com>
  40453. Reviewed by Eric Seidel.
  40454. REGRESSION (r68976): Incorrect bidi rendering in SVG text
  40455. https://bugs.webkit.org/show_bug.cgi?id=53980
  40456. Deconvolute SVGTextLayoutEngine code, which was confusing due to the simultaneous processing of the rendered text
  40457. in visual and logical order. Added several helper methods to make the code more readable.
  40458. Fix Unicode directional formatting characters support, now works as expected.
  40459. Test: svg/text/bidi-embedded-direction.svg
  40460. * editing/visible_units.cpp: Refactor getLeafBoxesInLogicalOrder(), move to InlineFlowBox.
  40461. (WebCore::getLogicalStartBoxAndNode): Use new collectLeafBoxesInLogicalOrder() method in InlineFlowBox.
  40462. (WebCore::getLogicalEndBoxAndNode): Ditto.
  40463. * rendering/InlineFlowBox.cpp: Add new helper function, that returns a list of all leaf boxes in logical order.
  40464. (WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):
  40465. * rendering/InlineFlowBox.h:
  40466. * rendering/svg/RenderSVGText.cpp: Actually trigger reordering the x/y/dx/dy/rotate value lists, if needed.
  40467. (WebCore::RenderSVGText::RenderSVGText):
  40468. (WebCore::RenderSVGText::layout):
  40469. * rendering/svg/RenderSVGText.h: Ditto.
  40470. (WebCore::RenderSVGText::layoutAttributes):
  40471. (WebCore::RenderSVGText::needsReordering):
  40472. * rendering/svg/SVGRootInlineBox.cpp: Use new InlineFlowBox::collectLeafBoxesINLogicalOrder(), with a custom "inline box reverse" implementation,
  40473. which not only reverses the order of InlineBoxes, but also the order of the x/y/dx/dy/rotate value lists, if needed.
  40474. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
  40475. (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
  40476. (WebCore::swapItems):
  40477. (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
  40478. (WebCore::SVGRootInlineBox::reorderValueLists):
  40479. * rendering/svg/SVGRootInlineBox.h:
  40480. * rendering/svg/SVGTextLayoutAttributes.cpp: Store RenderSVGInlineText* pointer, where we belong to.
  40481. (WebCore::SVGTextLayoutAttributes::SVGTextLayoutAttributes):
  40482. (WebCore::SVGTextLayoutAttributes::dump):
  40483. * rendering/svg/SVGTextLayoutAttributes.h:
  40484. (WebCore::SVGTextLayoutAttributes::context):
  40485. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Pass RenderSVGInlineText* object when creating SVGTextLayoutAttributes.
  40486. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree):
  40487. (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
  40488. * rendering/svg/SVGTextLayoutAttributesBuilder.h:
  40489. * rendering/svg/SVGTextLayoutEngine.cpp: Rewrite & cleanup the main layout algorithm, to be less confusing.
  40490. (WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
  40491. (WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
  40492. (WebCore::SVGTextLayoutEngine::recordTextFragment):
  40493. (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
  40494. (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
  40495. (WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics):
  40496. (WebCore::SVGTextLayoutEngine::advanceToNextLogicalCharacter):
  40497. (WebCore::SVGTextLayoutEngine::advanceToNextVisualCharacter):
  40498. (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  40499. * rendering/svg/SVGTextLayoutEngine.h:
  40500. 2011-03-30 Ilya Tikhonovsky <loislo@chromium.org>
  40501. Not reviewed trivial change.
  40502. Web Inspector: Remove unnecessary function arguments after r82281.
  40503. https://bugs.webkit.org/show_bug.cgi?id=57327
  40504. * inspector/InspectorAgent.cpp:
  40505. (WebCore::InspectorAgent::didCommitLoad):
  40506. (WebCore::InspectorAgent::domContentLoadedEventFired):
  40507. * inspector/InspectorAgent.h:
  40508. * inspector/InspectorInstrumentation.cpp:
  40509. (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
  40510. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  40511. 2011-03-30 Kent Tamura <tkent@chromium.org>
  40512. Reviewed by Ojan Vafai.
  40513. H1 element should have different default style if it is in HTML5 sectioning elements.
  40514. https://bugs.webkit.org/show_bug.cgi?id=52693
  40515. Test: fast/css/h1-in-section-elements.html
  40516. * css/html.css: Add font-size and margin declarations to follow HTML5 specification.
  40517. (:-webkit-any(article,aside,nav,section) h1):
  40518. (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
  40519. (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
  40520. (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
  40521. (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
  40522. 2011-03-29 Beth Dakin <bdakin@apple.com>
  40523. Reviewed by Maciej Stachowiak.
  40524. Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
  40525. webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
  40526. -and corresponding-
  40527. <rdar://problem/8665411>
  40528. * platform/mac/PlatformScreenMac.mm:
  40529. (WebCore::windowScaleFactor):
  40530. (WebCore::toUserSpace):
  40531. (WebCore::toDeviceSpace):
  40532. 2011-03-29 Eric Seidel <eric@webkit.org>
  40533. Reviewed by Dimitri Glazkov.
  40534. Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
  40535. https://bugs.webkit.org/show_bug.cgi?id=57369
  40536. I considered renaming these to m_endOfRun and m_startOfRun but decided
  40537. that was too verbose for now (given how often they're used). I suspect
  40538. with a bit more refactoring we'll find they're not used very often and can be renamed
  40539. if so desired.
  40540. * platform/text/BidiResolver.h:
  40541. (WebCore::::appendRun):
  40542. (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
  40543. (WebCore::::lowerExplicitEmbeddingLevel):
  40544. (WebCore::::raiseExplicitEmbeddingLevel):
  40545. (WebCore::::createBidiRunsForLine):
  40546. * rendering/InlineIterator.h:
  40547. (WebCore::InlineBidiResolver::appendRun):
  40548. 2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
  40549. Reviewed by Pavel Feldman.
  40550. Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
  40551. https://bugs.webkit.org/show_bug.cgi?id=57351
  40552. * bindings/js/ScriptHeapSnapshot.h:
  40553. * bindings/v8/ScriptHeapSnapshot.cpp:
  40554. * bindings/v8/ScriptHeapSnapshot.h:
  40555. * inspector/Inspector.json:
  40556. * inspector/InspectorProfilerAgent.cpp:
  40557. * inspector/InspectorProfilerAgent.h:
  40558. * inspector/front-end/DetailedHeapshotGridNodes.js:
  40559. (WebInspector.HeapSnapshotGenericObjectNode):
  40560. (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
  40561. * inspector/front-end/DetailedHeapshotView.js:
  40562. (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
  40563. 2011-03-29 Eric Seidel <eric@webkit.org>
  40564. Reviewed by Ryosuke Niwa.
  40565. Split more logic out from createBidiRunsForLine for readability
  40566. https://bugs.webkit.org/show_bug.cgi?id=57341
  40567. I marked reorderRunsFromLevels inline, but it probably doesn't actually need to (or want to) be.
  40568. This lops another large hunk off of reorderRunsFromLevels further reducing the size and complexity.
  40569. * platform/text/BidiResolver.h:
  40570. (WebCore::::reorderRunsFromLevels):
  40571. (WebCore::::createBidiRunsForLine):
  40572. 2011-03-29 Kent Tamura <tkent@chromium.org>
  40573. Reviewed by Dimitri Glazkov.
  40574. Make validation message bubble testable
  40575. https://bugs.webkit.org/show_bug.cgi?id=57290
  40576. Introduce a setting for validation message timer so that we can configure
  40577. how long we show a validation message bubble.
  40578. Test: fast/forms/validation-message-appearance.html
  40579. * html/ValidationMessage.cpp:
  40580. (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
  40581. Don't set a timer if the timer magnification value is 0 or negative.
  40582. Otherwise, hides the bubble length * magnification / 1000 seconds.
  40583. * page/Settings.cpp:
  40584. (WebCore::Settings::Settings): Initialize the timer magnification value.
  40585. * page/Settings.h:
  40586. (WebCore::Settings::setValidationMessageTimerMagnification): Added.
  40587. (WebCore::Settings::validationMessageTimerMaginification): Added.
  40588. 2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
  40589. Remove the extraneous declaration I accidentally added in r82376.
  40590. * dom/MouseEvent.h: Removed createSimulated decl.
  40591. 2011-03-29 James Robinson <jamesr@chromium.org>
  40592. Reviewed by Kenneth Russell.
  40593. [chromium] Compositor crash with show-layer-borders flag
  40594. https://bugs.webkit.org/show_bug.cgi?id=57292
  40595. Synchronize the debug border color/width with other properties to ensure the appropriate
  40596. CCLayerImpl exists. Code is only exercised with a debugging command line flag so no layout
  40597. test.
  40598. * platform/graphics/chromium/LayerChromium.cpp:
  40599. (WebCore::LayerChromium::pushPropertiesTo):
  40600. (WebCore::LayerChromium::setBorderColor):
  40601. (WebCore::LayerChromium::setBorderWidth):
  40602. * platform/graphics/chromium/LayerChromium.h:
  40603. 2011-03-29 Tony Gentilcore <tonyg@chromium.org>
  40604. Reviewed by Adam Barth.
  40605. Teach the preload scanner about &lt;input type=image&gt;
  40606. https://bugs.webkit.org/show_bug.cgi?id=57404
  40607. I did a very rough sample of the top 50 web pages to see how many of each
  40608. HTML resource type they include:
  40609. img src: 1,359
  40610. script src: 276
  40611. link href: 256
  40612. iframe src: 104
  40613. input src: 50
  40614. embed src: 37
  40615. @import: 13
  40616. object data: 11
  40617. Based on this, it seems worthwhile to preload inputs and iframes (possibly embed).
  40618. This patch only does inputs.
  40619. Test: fast/preloader/input.html
  40620. * html/parser/HTMLPreloadScanner.cpp:
  40621. (WebCore::HTMLNames::PreloadTask::PreloadTask):
  40622. (WebCore::HTMLNames::PreloadTask::processAttributes):
  40623. (WebCore::HTMLNames::PreloadTask::inputTypeAttributeIsImage):
  40624. (WebCore::HTMLNames::PreloadTask::preload):
  40625. 2011-03-29 Luke Macpherson <macpherson@chromium.org>
  40626. Reviewed by David Levin.
  40627. Improve the massive switch statement in CSSStyleSelector::applyProperty.
  40628. https://bugs.webkit.org/show_bug.cgi?id=56288
  40629. No new tests are needed because no new functionality exposed.
  40630. * css/CSSStyleSelector.cpp:
  40631. (WebCore::CSSStyleSelector::applyProperty):
  40632. Asserted that cases implemented in the CSSStyleApplyProperty lookup table are unreachable.
  40633. Updated comment.
  40634. 2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
  40635. Reviewed by Darin Adler.
  40636. Introduce SimulatedMouseEvent and teach EventDispatcher how to use it.
  40637. https://bugs.webkit.org/show_bug.cgi?id=57402
  40638. No functional changes, covered by existing tests.
  40639. * dom/EventDispatcher.cpp:
  40640. (WebCore::EventDispatcher::dispatchSimulatedClick): Changed to use SimulatedMouseEvent.
  40641. (WebCore::EventDispatcher::dispatchMouseEvent): Combined two dispatchMouseEvent methods
  40642. into one, now that simulated-click events don't need one.
  40643. * dom/EventDispatcher.h: Updated decls.
  40644. * dom/MouseEvent.cpp:
  40645. (WebCore::SimulatedMouseEvent::create): Added.
  40646. (WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Added.
  40647. (WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Added.
  40648. * dom/MouseEvent.h: Made constructor protected.
  40649. 2011-03-29 Anders Carlsson <andersca@apple.com>
  40650. Fix build.
  40651. * WebCore.exp.in:
  40652. 2011-03-29 Steve Block <steveblock@google.com>
  40653. Reviewed by Jeremy Orlow.
  40654. JavaInstance should not use jvalue in its API
  40655. https://bugs.webkit.org/show_bug.cgi?id=57019
  40656. This change updates JavaInstance for V8 to use JavaValue, rather than
  40657. jvalue, in its API. This will allow us to create an API for
  40658. JavaInstance that is independent of JNI, to allow it to be
  40659. implemented on platforms that do not use JNI directly.
  40660. Refactoring only, no new tests.
  40661. * bridge/jni/v8/JavaInstanceV8.cpp:
  40662. (JavaInstance::invokeMethod):
  40663. (JavaInstance::getField):
  40664. * bridge/jni/v8/JavaInstanceV8.h:
  40665. * bridge/jni/v8/JavaNPObjectV8.cpp:
  40666. (JSC::Bindings::JavaNPObjectInvoke):
  40667. (JSC::Bindings::JavaNPObjectGetProperty):
  40668. * bridge/jni/v8/JavaValueV8.h:
  40669. 2011-03-29 Eric Seidel <eric@webkit.org>
  40670. Reviewed by Dimitri Glazkov.
  40671. Rename BidiResolver::last to m_last to match modern style
  40672. https://bugs.webkit.org/show_bug.cgi?id=57367
  40673. * platform/text/BidiResolver.h:
  40674. (WebCore::::lowerExplicitEmbeddingLevel):
  40675. (WebCore::::raiseExplicitEmbeddingLevel):
  40676. (WebCore::::createBidiRunsForLine):
  40677. 2011-03-29 Justin Schuh <jschuh@chromium.org>
  40678. Reviewed by Maciej Stachowiak.
  40679. SVGComponentTransferFunctionElement should validate type
  40680. https://bugs.webkit.org/show_bug.cgi?id=56960
  40681. Test: svg/filters/feComponentTransfer-style-crash.xhtml
  40682. * svg/SVGComponentTransferFunctionElement.cpp:
  40683. (WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
  40684. * svg/SVGComponentTransferFunctionElement.h:
  40685. 2011-03-29 Thomas Klausner <tk@giga.or.at>
  40686. Reviewed by David Levin.
  40687. png-1.5 fixes
  40688. https://bugs.webkit.org/show_bug.cgi?id=54406
  40689. Fix compilation with png-1.5: struct members were hidden, and
  40690. a new API to terminate data processing was added (especially for
  40691. WebKit).
  40692. Compilation fixes, so no new tests.
  40693. * platform/image-decoders/png/PNGImageDecoder.cpp:
  40694. (WebCore::PNGImageDecoder::headerAvailable):
  40695. (WebCore::PNGImageDecoder::rowAvailable):
  40696. 2011-03-29 Gavin Peters <gavinp@chromium.org>
  40697. Reviewed by Tony Gentilcore.
  40698. Add beforeload to icon and prefetch link rel types
  40699. https://bugs.webkit.org/show_bug.cgi?id=56424
  40700. Over in https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html , a webkit-dev
  40701. thread, I've discussed my hopes for the link element, and adding the link header. This
  40702. change helps improve the link header by making it participate in the beforeload event in
  40703. two more important cases.
  40704. Tests: fast/dom/HTMLLinkElement/prefetch-beforeload.html
  40705. http/tests/misc/link-rel-icon-beforeload.html
  40706. webarchive/test-link-rel-icon-beforeload.html
  40707. * html/HTMLLinkElement.cpp:
  40708. (WebCore::HTMLLinkElement::checkBeforeLoadEvent):
  40709. (WebCore::HTMLLinkElement::process):
  40710. * html/HTMLLinkElement.h:
  40711. 2011-03-29 Eric Seidel <eric@webkit.org>
  40712. Reviewed by Dimitri Glazkov.
  40713. Rename BidiResolver::current to BidiResolver::m_current to match modern style
  40714. https://bugs.webkit.org/show_bug.cgi?id=57363
  40715. I was very confused by current until I realized it was a member variable.
  40716. I also did m_reachedEndOfLine since that was small.
  40717. * platform/text/BidiResolver.h:
  40718. (WebCore::BidiResolver::position):
  40719. (WebCore::BidiResolver::setPosition):
  40720. (WebCore::BidiResolver::increment):
  40721. (WebCore::::createBidiRunsForLine):
  40722. 2011-03-29 Geoff Pike <gpike@chromium.org>
  40723. Reviewed by Dimitri Glazkov.
  40724. In HitTestResult objects, initialize the ListHashSet<RefPtr<Node> >
  40725. lazily. In my informal testing it seems to be used hardly at all, so
  40726. it's wasteful to create it eagerly. Initializing a ListHashSet
  40727. is expensive because a ListHashSet initially has space for 256
  40728. elements, and that space is memset to 0.
  40729. This change should improve performance but have no impact on
  40730. correctness. On x86-64, for example, the change cuts the
  40731. cost of HitTestResult(IntPoint()) in EventHandler::mouseMoved()
  40732. from ~1700 cycles to ~300 cycles.
  40733. * rendering/HitTestResult.cpp:
  40734. (WebCore::HitTestResult::HitTestResult): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
  40735. (WebCore::HitTestResult::operator=): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
  40736. (WebCore::HitTestResult::addNodeToRectBasedTestResult): use mutableRectBasedTestResult() rather than m_rectBasedTestResult
  40737. (WebCore::HitTestResult::append): append *(other.m_rectBasedTestResult) if other.m_rectBasedTestResult isn't 0
  40738. * rendering/HitTestResult.h:
  40739. (WebCore::HitTestResult::rectBasedTestResult): Add a typedef for ListHashSet<RefPtr<Node> > to ease readability. Change m_rectBasedTestResult from ListHashSet<RefPtr<Node> > to an OwnPtr of same. Modify rectBasedTestResult() and add mutableRectBasedTestResult().
  40740. 2011-03-29 Timothy Hatcher <timothy@apple.com>
  40741. Update the order of the context menu to better match AppKit on Mac.
  40742. <rdar://problem/9054893>
  40743. Reviewed by John Sullivan.
  40744. * English.lproj/Localizable.strings: Updated.
  40745. * page/ContextMenuController.cpp:
  40746. (WebCore::ContextMenuController::populate): Update the order of items on Mac.
  40747. * platform/LocalizationStrategy.h:
  40748. * platform/LocalizedStrings.cpp:
  40749. (WebCore::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
  40750. * platform/LocalizedStrings.h:
  40751. * platform/android/LocalizedStringsAndroid.cpp:
  40752. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40753. * platform/brew/LocalizedStringsBrew.cpp:
  40754. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40755. * platform/efl/LocalizedStringsEfl.cpp:
  40756. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40757. * platform/gtk/LocalizedStringsGtk.cpp:
  40758. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40759. * platform/haiku/LocalizedStringsHaiku.cpp:
  40760. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40761. * platform/wx/LocalizedStringsWx.cpp:
  40762. (WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
  40763. 2011-03-29 Dean Jackson <dino@apple.com>
  40764. Reviewed by Chris Marrin and Ken Russell.
  40765. https://bugs.webkit.org/show_bug.cgi?id=57248
  40766. Occlusion issues with WebGL in Safari
  40767. The depth buffer on Safari ports was being set up with a
  40768. maximum of 16 bits. Now we use a combined 24/8 depth/stencil
  40769. buffer on Mac ports.
  40770. No new tests as this is the setting for a particular port. Other
  40771. ports may use different defaults.
  40772. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  40773. (WebCore::GraphicsContext3D::validateAttributes):
  40774. - use Extensions3D to test for depth and multisample extensions
  40775. rather than querying OpenGL directly.
  40776. (WebCore::GraphicsContext3D::reshape):
  40777. - use a 24bit depth buffer when the extension is enabled.
  40778. 2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
  40779. Sorted XCode project. It's gotten quite out of sorts.
  40780. * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
  40781. 2011-03-29 Emil A Eklund <eae@chromium.org>
  40782. Reviewed by Dimitri Glazkov.
  40783. DatasetDOMStringMap::item and ::contains copies attribute name string
  40784. https://bugs.webkit.org/show_bug.cgi?id=55645
  40785. Change propertyNameMatchesAttributeName to match without creating a copy
  40786. of the string.
  40787. * dom/DatasetDOMStringMap.cpp:
  40788. (WebCore::propertyNameMatchesAttributeName):
  40789. 2011-03-29 Csaba Osztrogonác <ossy@webkit.org>
  40790. Unreviewed rollout r82282, part of r82288, r82298.
  40791. * css/CSSParser.cpp:
  40792. (WebCore::parseColorInt):
  40793. (WebCore::isValidDouble):
  40794. (WebCore::parseAlphaValue):
  40795. (WebCore::CSSParser::parseColor):
  40796. 2011-03-25 Brent Fulgham <bfulgham@webkit.org>
  40797. Reviewed by Dave Hyatt.
  40798. https://bugs.webkit.org/show_bug.cgi?id=55981
  40799. Second round of clean-ups, aimed at supporting GTK with the
  40800. same unified FontPlatformData header. This version removes
  40801. some unneeded WinCairo code, and aligns the WinCairo and
  40802. GTK ports to reduce code duplication.
  40803. * WebCore.vcproj/WebCore.vcproj: Get rid of a dangling reference
  40804. to an old WinCairo file.
  40805. * platform/graphics/FontPlatformData.h: Remove unneeded member
  40806. for m_fontFace, which is a member of m_scaledFont. Switch to
  40807. standard Cairo hashing.
  40808. (WebCore::FontPlatformData::FontPlatformData):
  40809. (WebCore::FontPlatformData::font):
  40810. (WebCore::FontPlatformData::scaledFont):
  40811. (WebCore::FontPlatformData::hash):
  40812. (WebCore::FontPlatformData::isHashTableDeletedValue):
  40813. (WebCore::FontPlatformData::hashTableDeletedFontValue):
  40814. * platform/graphics/win/FontCacheWin.cpp: Update to no longer use
  40815. the unnecessary fontFace() accessor.
  40816. (WebCore::FontCache::createFontPlatformData):
  40817. * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  40818. * platform/graphics/win/FontPlatformDataCairoWin.cpp:
  40819. (WebCore::FontPlatformData::platformDataInit):
  40820. (WebCore::FontPlatformData::FontPlatformData):
  40821. (WebCore::FontPlatformData::~FontPlatformData):
  40822. (WebCore::FontPlatformData::platformDataAssign):
  40823. (WebCore::FontPlatformData::platformIsEqual):
  40824. * platform/graphics/win/FontPlatformDataWin.cpp:
  40825. (WebCore::FontPlatformData::FontPlatformData):
  40826. 2011-03-29 Jian Li <jianli@chromium.org>
  40827. Reviewed by Adam Barth.
  40828. Inline worker powered by blob URL does not work with files URL even if
  40829. allowFileAccessFromFileURLs is enabled
  40830. https://bugs.webkit.org/show_bug.cgi?id=56063
  40831. Test: fast/files/workers/inline-worker-via-blob-url.html
  40832. * fileapi/BlobURL.cpp: Removed unneeded getOrigin() method.
  40833. * fileapi/BlobURL.h: Removed unneeded getOrigin() method.
  40834. * page/SecurityOrigin.cpp:
  40835. (WebCore::SecurityOrigin::SecurityOrigin): Extended the logic to handle
  40836. filesystem URL also to blob URL. Also fixed the problem that m_isUnique
  40837. is incorrectly set for blob and filesystem URLs.
  40838. (WebCore::SecurityOrigin::create): Removed the special logic for blob URL
  40839. since we use the same logic in SecurityOrigin constructor as filesystem
  40840. URL.
  40841. (WebCore::SecurityOrigin::canRequest): Removed the special logic for blob
  40842. URL since it is not needed with the fix in SecurityOrigin constructor.
  40843. 2011-03-29 Timothy Hatcher <timothy@apple.com>
  40844. Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.
  40845. https://webkit.org/b/57354
  40846. Reviewed by Sam Weinig.
  40847. * English.lproj/Localizable.strings: Updated.
  40848. * StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
  40849. * platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
  40850. extract-localizable-strings does not complain about unbalanced single quotes.
  40851. 2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
  40852. Unreviewed, rolling out r82295 and r82300.
  40853. http://trac.webkit.org/changeset/82295
  40854. http://trac.webkit.org/changeset/82300
  40855. https://bugs.webkit.org/show_bug.cgi?id=57380
  40856. This patch breaks compile on Chromium (Requested by
  40857. abarth|gardener on #webkit).
  40858. * accessibility/AccessibilityObject.h:
  40859. * accessibility/AccessibilityRenderObject.cpp:
  40860. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  40861. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  40862. (atkRole):
  40863. (webkit_accessible_get_role):
  40864. * accessibility/mac/AccessibilityObjectWrapper.mm:
  40865. 2011-03-29 Anders Carlsson <andersca@apple.com>
  40866. Fix clang build.
  40867. * platform/text/BidiResolver.h:
  40868. (WebCore::::createBidiRunsForLine):
  40869. 2011-03-29 Steve Falkenburg <sfalken@apple.com>
  40870. Reviewed by Adam Roben.
  40871. Use per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
  40872. https://bugs.webkit.org/show_bug.cgi?id=57378
  40873. Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
  40874. InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
  40875. the IDE. To avoid this, add a separate vsprops file for each project configuration that
  40876. contains the required inherited property sheets.
  40877. * WebCore.vcproj/QTMovieWin.vcproj:
  40878. * WebCore.vcproj/QTMovieWinDebug.vsprops: Added.
  40879. * WebCore.vcproj/QTMovieWinDebugAll.vsprops: Added.
  40880. * WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops: Added.
  40881. * WebCore.vcproj/QTMovieWinRelease.vsprops: Added.
  40882. * WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops: Added.
  40883. * WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Added.
  40884. * WebCore.vcproj/WebCore.vcproj:
  40885. * WebCore.vcproj/WebCoreDebug.vsprops: Added.
  40886. * WebCore.vcproj/WebCoreDebugAll.vsprops: Added.
  40887. * WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Added.
  40888. * WebCore.vcproj/WebCoreRelease.vsprops: Added.
  40889. * WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops: Added.
  40890. * WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Added.
  40891. 2011-03-29 David Hyatt <hyatt@apple.com>
  40892. Reviewed by Simon Fraser.
  40893. <rdar://problem/9194927> REGRESSION (r81691): Page at www.mondaynote.com lays out incorrectly
  40894. Back out the optimization that stopped when it hit the first float. This was an incorrect optimization
  40895. and can't be done without more work.
  40896. Added fast/block/float/float-forced-below-other-floats.html
  40897. * rendering/RenderBlock.cpp:
  40898. (WebCore::RenderBlock::logicalLeftOffsetForLine):
  40899. (WebCore::RenderBlock::logicalRightOffsetForLine):
  40900. 2011-03-29 Eric Seidel <eric@webkit.org>
  40901. Reviewed by Ryosuke Niwa.
  40902. Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it
  40903. https://bugs.webkit.org/show_bug.cgi?id=57338
  40904. I'm attempting to break createBidiRunsForLine into understandable pieces
  40905. so that we can tell what it's actually doing. Our implementation of the
  40906. unicode bidi algorithm is slightly different from the spec in that we
  40907. run it per-line (instead of over the entire paragraph at once). This is
  40908. great for performance (our implementation is resumable), but it makes
  40909. things a bit tricky to understand. Splitting createBidiRunsForLine into
  40910. pieces should help make our UBA implementation more readable.
  40911. * platform/text/BidiResolver.h:
  40912. (WebCore::::updateStatusLastFromCurrentDirection):
  40913. (WebCore::::createBidiRunsForLine):
  40914. 2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
  40915. Reviewed by Martin Robinson.
  40916. [Gtk] Consistent crash from Google/ARIA combobox click
  40917. https://bugs.webkit.org/show_bug.cgi?id=55883
  40918. Do not call to firstChild() to avoid entering into infinite loops.
  40919. This would happen when current item is a WebCore Group and some of
  40920. its children have either role 'option' or 'menuitem'. Other than
  40921. that the logic behind that call to firstChild() seems to be no
  40922. longer needed so it's safe to remove it.
  40923. Test: platform/gtk/accessibility/aria-options-and-menuitems-crash.html
  40924. * accessibility/gtk/AccessibilityObjectAtk.cpp:
  40925. (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
  40926. Remove call to firsChild, which was leading to crashes sometimes.
  40927. 2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
  40928. Reviewed by Chris Fleizach.
  40929. AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
  40930. https://bugs.webkit.org/show_bug.cgi?id=47636
  40931. Define new roles in WebCore and map them to ATK accordingly.
  40932. Test: platform/gtk/accessibility/aria-roles-unignored.html
  40933. * accessibility/AccessibilityObject.h: Added new roles to
  40934. represent paragraphs, labels, forms and div sections.
  40935. * accessibility/AccessibilityRenderObject.cpp:
  40936. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  40937. Return ParagraphRole, LabelRole, FormRole and DivRole when needed.
  40938. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  40939. (atkRole): Map new WebCore roles to ATK Roles.
  40940. (webkit_accessible_get_role): Remove code to define roles for
  40941. paragraphs, labels, forms and divs based on node's tag name.
  40942. Update mappings for the Mac platform.
  40943. * accessibility/mac/AccessibilityObjectWrapper.mm:
  40944. (createAccessibilityRoleMap): Add explicit mappings from the new
  40945. roles introduced to NSAccessibilityGroupRole.
  40946. 2011-03-29 Philippe Normand <pnormand@igalia.com>
  40947. Unreviewed build fix. Remove ASSERT hitting consitently on GTK.
  40948. * rendering/InlineIterator.h:
  40949. (WebCore::InlineIterator::moveToStartOf):
  40950. 2011-03-29 Darin Adler <darin@apple.com>
  40951. Fix some just-introduced build failures.
  40952. * WebCore.pro: Correct spelling of filename.
  40953. * css/CSSParser.cpp:
  40954. (WebCore::parseColorIntOrPercentage): Fix double/int conversion that fails to compile
  40955. on Leopard. Also renamed one local variabel.
  40956. * inspector/InspectorAgent.cpp:
  40957. (WebCore::InspectorAgent::didCommitLoad): Removed unused argument names to avoid warning.
  40958. (WebCore::InspectorAgent::domContentLoadedEventFired): Ditto.
  40959. 2011-03-29 Andras Becsi <abecsi@webkit.org>
  40960. Reviewed by Darin Adler.
  40961. CSS: Slow parsing of rgb() with percent values
  40962. https://bugs.webkit.org/show_bug.cgi?id=16708
  40963. Implement fast-path parsing for percentage color values.
  40964. Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.
  40965. * css/CSSParser.cpp:
  40966. (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
  40967. (WebCore::parseDouble): Function for parsing double values if they are valid.
  40968. (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
  40969. (WebCore::parseAlphaValue): Use the new functions.
  40970. (WebCore::CSSParser::parseColor): Ditto.
  40971. 2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
  40972. Reviewed by Pavel Feldman.
  40973. Web Inspector: extract InspectorPageAgent from InspectorAgent.
  40974. https://bugs.webkit.org/show_bug.cgi?id=57327
  40975. There are page related methods and inspector related methods in InspectorAgent.
  40976. It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.
  40977. * GNUmakefile.am:
  40978. * WebCore.gypi:
  40979. * inspector/CodeGeneratorInspector.pm:
  40980. * inspector/Inspector.json:
  40981. * inspector/InspectorAgent.cpp:
  40982. (WebCore::InspectorAgent::InspectorAgent):
  40983. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  40984. (WebCore::InspectorAgent::didClearWindowObjectInWorld):
  40985. (WebCore::InspectorAgent::setFrontend):
  40986. (WebCore::InspectorAgent::disconnectFrontend):
  40987. (WebCore::InspectorAgent::didCommitLoad):
  40988. (WebCore::InspectorAgent::domContentLoadedEventFired):
  40989. * inspector/InspectorAgent.h:
  40990. (WebCore::InspectorAgent::pageAgent):
  40991. * inspector/InspectorPageAgent.cpp: Added.
  40992. (WebCore::InspectorPageAgent::create):
  40993. (WebCore::InspectorPageAgent::InspectorPageAgent):
  40994. (WebCore::InspectorPageAgent::setFrontend):
  40995. (WebCore::InspectorPageAgent::clearFrontend):
  40996. (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
  40997. (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
  40998. (WebCore::InspectorPageAgent::reloadPage):
  40999. (WebCore::InspectorPageAgent::openInInspectedWindow):
  41000. (WebCore::InspectorPageAgent::setUserAgentOverride):
  41001. (WebCore::buildObjectForCookie):
  41002. (WebCore::buildArrayForCookies):
  41003. (WebCore::InspectorPageAgent::getCookies):
  41004. (WebCore::InspectorPageAgent::deleteCookie):
  41005. (WebCore::InspectorPageAgent::inspectedURLChanged):
  41006. (WebCore::InspectorPageAgent::restore):
  41007. (WebCore::InspectorPageAgent::didCommitLoad):
  41008. (WebCore::InspectorPageAgent::domContentEventFired):
  41009. (WebCore::InspectorPageAgent::loadEventFired):
  41010. (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
  41011. (WebCore::InspectorPageAgent::applyUserAgentOverride):
  41012. * inspector/InspectorPageAgent.h: Added.
  41013. * inspector/InspectorController.cpp:
  41014. (WebCore::InspectorController::connectFrontend):
  41015. * inspector/InspectorInstrumentation.cpp:
  41016. (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
  41017. (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
  41018. (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
  41019. (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  41020. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  41021. (WebCore::InspectorInstrumentation::retrievePageAgent):
  41022. * inspector/InspectorInstrumentation.h:
  41023. * inspector/InstrumentingAgents.h:
  41024. (WebCore::InstrumentingAgents::InstrumentingAgents):
  41025. (WebCore::InstrumentingAgents::inspectorPageAgent):
  41026. (WebCore::InstrumentingAgents::setInspectorPageAgent):
  41027. * inspector/front-end/AuditsPanel.js:
  41028. (WebInspector.AuditsPanel.prototype._reloadResources):
  41029. * inspector/front-end/CookieItemsView.js:
  41030. (WebInspector.CookieItemsView.prototype._deleteCookie):
  41031. (WebInspector.Cookies.getCookiesAsync):
  41032. * inspector/front-end/ExtensionServer.js:
  41033. (WebInspector.ExtensionServer.prototype._onReload):
  41034. * inspector/front-end/NetworkPanel.js:
  41035. (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
  41036. * inspector/front-end/ResourcesPanel.js:
  41037. (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
  41038. * inspector/front-end/WorkersSidebarPane.js:
  41039. (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
  41040. * inspector/front-end/inspector.js:
  41041. (WebInspector.openResource):
  41042. (WebInspector.documentKeyDown):
  41043. 2011-03-29 David Hyatt <hyatt@apple.com>
  41044. Reviewed by Darin Adler.
  41045. https://bugs.webkit.org/show_bug.cgi?id=57276
  41046. Add optimizations to make the vertical placement of boxes much faster. Whenever a box is added
  41047. to a line, compare it with the parent box. If we can determine that the child box has the exact
  41048. same height and baseline position as the parent box, then we keep a boolean flag set called
  41049. descendantsHaveSameLineHeightAndBaseline(). If the box is different for any reason then we clear the
  41050. flag up the line box parent chain.
  41051. When it comes time to do computeLogicalboxHeights, we can avoid recurring into the children of
  41052. a box whose descendants all have the same position. When we do placeBoxesInBlockDirection, we
  41053. can do a simplified recursion that just calls adjustBlockDirectionPosition to offset the boxes
  41054. without doing anything else.
  41055. Because of the quirks mode rule of only shrinking boxes with no immediate text children, we need
  41056. to track whether a box has text descendants now as well. When we avoid doing the recursion
  41057. this flag tells us whether the collection of boxes should have an effect on the ascent and descent
  41058. of the line in quirks mode.
  41059. * rendering/InlineFlowBox.cpp:
  41060. (WebCore::InlineFlowBox::addToLine):
  41061. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  41062. (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  41063. (WebCore::InlineFlowBox::nodeAtPoint):
  41064. (WebCore::InlineFlowBox::paintBoxDecorations):
  41065. (WebCore::InlineFlowBox::paintMask):
  41066. * rendering/InlineFlowBox.h:
  41067. (WebCore::InlineFlowBox::InlineFlowBox):
  41068. (WebCore::InlineFlowBox::hasTextDescendants):
  41069. (WebCore::InlineFlowBox::descendantsHaveSameLineHeightAndBaseline):
  41070. (WebCore::InlineFlowBox::clearDescendantsHaveSameLineHeightAndBaseline):
  41071. * rendering/RenderBlock.h:
  41072. * rendering/RenderBlockLineLayout.cpp:
  41073. (WebCore::RenderBlock::createLineBoxes):
  41074. (WebCore::RenderBlock::constructLine):
  41075. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  41076. 2011-03-29 Eric Seidel <eric@webkit.org>
  41077. Reviewed by Ryosuke Niwa.
  41078. Remove a bunch of duplicate code by adding some InlineIterator helper methods
  41079. https://bugs.webkit.org/show_bug.cgi?id=57326
  41080. Once I started adding these it became clear how much crazy duplicated code
  41081. we had due to treating InlineIterator as a struct and accessing its
  41082. members directly. We can't quite make the members private yet since
  41083. findNextLineBreak still splits out the members. But this change
  41084. makes the code much cleaner.
  41085. * rendering/InlineIterator.h:
  41086. (WebCore::InlineIterator::clear):
  41087. (WebCore::InlineIterator::moveToStartOf):i
  41088. (WebCore::InlineIterator::moveTo):
  41089. (WebCore::InlineIterator::increment):
  41090. * rendering/RenderBlockLineLayout.cpp:
  41091. (WebCore::tryHyphenating):
  41092. (WebCore::RenderBlock::findNextLineBreak):
  41093. 2011-03-29 Eric Seidel <eric@webkit.org>
  41094. Reviewed by Ryosuke Niwa.
  41095. Clean up bidiNext by abstracting repeated code
  41096. https://bugs.webkit.org/show_bug.cgi?id=57335
  41097. I also added a comment to explain what bidiNext is actually doing.
  41098. This whole area of code is confusing but need not be.
  41099. * rendering/InlineIterator.h:
  41100. (WebCore::embedCharFromDirection):
  41101. (WebCore::notifyResolverEnteredObject):
  41102. (WebCore::notifyResolverWillExitObject):
  41103. (WebCore::bidiNext):
  41104. (WebCore::bidiFirst):
  41105. 2011-03-29 Alexander Pavlov <apavlov@chromium.org>
  41106. Reviewed by Yury Semikhatsky.
  41107. Web Inspector: Support external CSS stylesheet freeflow text editing
  41108. https://bugs.webkit.org/show_bug.cgi?id=54397
  41109. In this implementation, Ctrl/Cmd-S commits the current changes into the model.
  41110. * inspector/front-end/ResourceView.js:
  41111. (WebInspector.ResourceView.createResourceView):
  41112. (WebInspector.CSSSourceFrameDelegateForResourcesPanel):
  41113. (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.canEditScriptSource):
  41114. (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource):
  41115. (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource.handleInfos):
  41116. (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype._saveStyleSheet):
  41117. * inspector/front-end/ResourcesPanel.js:
  41118. (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
  41119. (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  41120. * inspector/front-end/SourceFrame.js:
  41121. (WebInspector.SourceFrame.prototype._createTextViewer):
  41122. 2011-03-29 Eric Carlson <eric.carlson@apple.com>
  41123. Reviewed by Dan Bernstein.
  41124. playbackRate should not be set to defaultPlaybackRate in play()
  41125. https://bugs.webkit.org/show_bug.cgi?id=55943
  41126. Test: media/video-playbackrate.html
  41127. * html/HTMLMediaElement.cpp:
  41128. (WebCore::HTMLMediaElement::playbackRate): No need to ask the media engine for the current
  41129. rate, we already have the current value cached.
  41130. (WebCore::HTMLMediaElement::playInternal): Don't reset the engine's playback rate to
  41131. the default rate.
  41132. (WebCore::HTMLMediaElement::togglePlayState): Do reset the engine's playback rate to
  41133. the default rate before triggering playback.
  41134. * manual-tests/media-default-playback-rate.html: Added.
  41135. 2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
  41136. Reviewed by Eric Seidel.
  41137. Remove specialization of EventDispatcher with inversion of control.
  41138. https://bugs.webkit.org/show_bug.cgi?id=57285
  41139. Since some events have extra logic around their dispatch, allow them
  41140. to dispatch themselves and specialize the logic. This change only
  41141. converts KeyboardEvent to this model.
  41142. No functional change, covered by existing tests.
  41143. * dom/Event.cpp:
  41144. (WebCore::Event::dispatch): Added.
  41145. * dom/Event.h: Updated decls.
  41146. * dom/EventDispatcher.cpp:
  41147. (WebCore::EventDispatcher::dispatchEvent): Changed to ask event to dispatch
  41148. itself.
  41149. * dom/EventDispatcher.h: Updated decls.
  41150. * dom/KeyboardEvent.cpp:
  41151. (WebCore::KeyboardEvent::dispatch): Added, moving code from EventDispatcher.
  41152. * dom/KeyboardEvent.h: Updated decls.
  41153. * dom/Node.cpp:
  41154. (WebCore::Node::dispatchKeyEvent): Changed to use the new ways.
  41155. 2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
  41156. Reviewed by Yury Semikhatsky.
  41157. Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
  41158. https://bugs.webkit.org/show_bug.cgi?id=57329
  41159. * inspector/InspectorAgent.cpp:
  41160. (WebCore::InspectorAgent::InspectorAgent):
  41161. (WebCore::InspectorAgent::setFrontend):
  41162. * inspector/InspectorAgent.h:
  41163. * inspector/InspectorController.cpp:
  41164. (WebCore::InspectorController::inspect):
  41165. * inspector/InspectorDOMAgent.cpp:
  41166. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  41167. (WebCore::InspectorDOMAgent::setFrontend):
  41168. (WebCore::InspectorDOMAgent::handleMousePress):
  41169. (WebCore::InspectorDOMAgent::inspect):
  41170. (WebCore::InspectorDOMAgent::focusNode):
  41171. (WebCore::InspectorDOMAgent::highlight):
  41172. (WebCore::InspectorDOMAgent::hideHighlight):
  41173. * inspector/InspectorDOMAgent.h:
  41174. (WebCore::InspectorDOMAgent::create):
  41175. 2011-03-29 Eric Seidel <eric@webkit.org>
  41176. Reviewed by Nikolas Zimmermann.
  41177. Rename InlineIterator::pos to m_pos to match modern style
  41178. https://bugs.webkit.org/show_bug.cgi?id=57342
  41179. Somehow I failed to upload this one earlier, no wonder later patches didn't apply.
  41180. * rendering/InlineIterator.h:
  41181. (WebCore::InlineIterator::InlineIterator):
  41182. (WebCore::operator==):
  41183. (WebCore::operator!=):
  41184. (WebCore::InlineIterator::increment):
  41185. (WebCore::InlineIterator::current):
  41186. (WebCore::InlineBidiResolver::appendRun):
  41187. * rendering/RenderBlockLineLayout.cpp:
  41188. (WebCore::checkMidpoints):
  41189. (WebCore::RenderBlock::appendRunsForObject):
  41190. (WebCore::RenderBlock::layoutInlineChildren):
  41191. (WebCore::RenderBlock::matchedEndLine):
  41192. (WebCore::tryHyphenating):
  41193. (WebCore::RenderBlock::findNextLineBreak):
  41194. 2011-03-29 Pavel Feldman <pfeldman@chromium.org>
  41195. Reviewed by Yury Semikhatsky.
  41196. Web Inspector: document BrowserDebugger agent.
  41197. https://bugs.webkit.org/show_bug.cgi?id=57331
  41198. * inspector/Inspector.json:
  41199. 2011-03-29 Alexander Pavlov <apavlov@chromium.org>
  41200. Reviewed by Pavel Feldman.
  41201. Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
  41202. https://bugs.webkit.org/show_bug.cgi?id=56310
  41203. Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
  41204. "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
  41205. by CSSAgent.getStyleSheet() anymore.
  41206. Test: inspector/styles/get-set-stylesheet-text.html
  41207. * inspector/Inspector.json:
  41208. * inspector/InspectorCSSAgent.cpp:
  41209. (WebCore::InspectorCSSAgent::getAllStyleSheets):
  41210. * inspector/InspectorCSSAgent.h:
  41211. * inspector/InspectorStyleSheet.cpp:
  41212. (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  41213. (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  41214. * inspector/InspectorStyleSheet.h:
  41215. * inspector/front-end/AuditRules.js:
  41216. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
  41217. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  41218. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  41219. * inspector/front-end/CSSStyleModel.js:
  41220. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  41221. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  41222. (WebInspector.CSSStyleModel.prototype._onRevert):
  41223. (WebInspector.CSSStyleSheet):
  41224. (WebInspector.CSSStyleSheet.prototype.setText):
  41225. 2011-03-29 Jeremy Moskovich <jeremy@chromium.org>
  41226. Reviewed by Eric Seidel.
  41227. Implement text-align:match-parent as -webkit-match-parent.
  41228. https://bugs.webkit.org/show_bug.cgi?id=50951
  41229. Add support to the CSS parser.
  41230. Tests: fast/css/text-align-webkit-match-parent-parse.html
  41231. fast/css/text-align-webkit-match-parent.html
  41232. * css/CSSParser.cpp:
  41233. (WebCore::CSSParser::parseValue):
  41234. * css/CSSStyleSelector.cpp:
  41235. (WebCore::CSSStyleSelector::applyProperty):
  41236. * css/CSSValueKeywords.in:
  41237. 2011-03-29 Eric Seidel <eric@webkit.org>
  41238. Reviewed by Ryosuke Niwa.
  41239. Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
  41240. https://bugs.webkit.org/show_bug.cgi?id=57323
  41241. All of these m_nextBreakablePosition = -1 could probably be replaced with
  41242. some new methods. But I'll do that in a separate change. Clearly
  41243. m_nextBreakablePosition is just a cached value which should be cleared
  41244. at the right times. I suspect we may even fail to clear it sometimes when
  41245. we should due to the current used of direct access instead of smarter functions.
  41246. * rendering/InlineIterator.h:
  41247. (WebCore::InlineIterator::InlineIterator):
  41248. (WebCore::InlineIterator::increment):
  41249. * rendering/RenderBlockLineLayout.cpp:
  41250. (WebCore::tryHyphenating):
  41251. (WebCore::RenderBlock::findNextLineBreak):
  41252. 2011-03-29 Jeff Miller <jeffm@apple.com>
  41253. Reviewed by Jon Honeycutt.
  41254. Add WebCore::copyCertificateToData() on Windows
  41255. https://bugs.webkit.org/show_bug.cgi?id=57296
  41256. Create a new win directory in platform/cf and add CertificateCFWin.cpp and CertificateCFWin.h to it.
  41257. * WebCore.vcproj/WebCore.vcproj: Added CertificateCFWin.cpp and CertificateCFWin.h.
  41258. * WebCore.vcproj/copyForwardingHeaders.cmd: Copy all header files in \platform\cf\win\.
  41259. * platform/cf/win: Added.
  41260. * platform/cf/win/CertificateCFWin.cpp: Added.
  41261. (WebCore::deallocCertContext): Added.
  41262. (WebCore::createCertContextDeallocator): Added.
  41263. (WebCore::copyCertificateToData): Added.
  41264. * platform/cf/win/CertificateCFWin.h: Added.
  41265. 2011-03-29 Eric Seidel <eric@webkit.org>
  41266. Reviewed by Ryosuke Niwa.
  41267. Rename InlineIterator::block to m_block to match modern style
  41268. https://bugs.webkit.org/show_bug.cgi?id=57321
  41269. I could have made m_block private, since it's only accessed in
  41270. one place outside of InlineIterator (for an ASSERT). But I chose
  41271. not to do so in this change.
  41272. * rendering/InlineIterator.h:
  41273. (WebCore::InlineIterator::InlineIterator):
  41274. (WebCore::InlineIterator::increment):
  41275. (WebCore::InlineBidiResolver::appendRun):
  41276. * rendering/RenderBlockLineLayout.cpp:
  41277. (WebCore::RenderBlock::findNextLineBreak):
  41278. 2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>
  41279. Reviewed by Nikolas Zimmermann.
  41280. Incorrect offset of svg <use> element which is in <symbol> element
  41281. https://bugs.webkit.org/show_bug.cgi?id=57318
  41282. When webkit expanded a svg <symbol> element in the shadow tree it
  41283. would clone the children of the <symbol>. The children may contain
  41284. SVGShadowTreeContainerElement which was expanded from svg <use>
  41285. element. But the clone operation would clone a
  41286. SVGShadowTreeContainerElement as a svg <g> element. This resulted
  41287. that updateContainerOffset wouldn't update offset for those elements
  41288. which were expand from <use> elements.
  41289. This patch implements cloneElementWithoutAttributesAndChildren for
  41290. SVGShadowTreeContainerElement to make the container clone itself
  41291. correctly.
  41292. Test: svg/custom/use-in-symbol-with-offset.svg
  41293. * rendering/svg/SVGShadowTreeElements.cpp:
  41294. (WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
  41295. * rendering/svg/SVGShadowTreeElements.h:
  41296. 2011-03-29 Eric Seidel <eric@webkit.org>
  41297. Reviewed by Ryosuke Niwa.
  41298. Rename InlineIterator::obj to m_obj to match modern style
  41299. https://bugs.webkit.org/show_bug.cgi?id=57319
  41300. I started this rename after confusion in InlineBidiResolver::appendRun.
  41301. (Which uses an "obj" local in InlineIterator.h. It's not actually
  41302. masking m_obj because it's a separate class, but I didn't realize
  41303. that at the time because it's in InlineIterator.h which is itself confusing!)
  41304. * rendering/InlineIterator.h:
  41305. (WebCore::InlineIterator::InlineIterator):
  41306. (WebCore::operator==):
  41307. (WebCore::operator!=):
  41308. (WebCore::InlineIterator::increment):
  41309. (WebCore::InlineIterator::atEnd):
  41310. (WebCore::InlineIterator::current):
  41311. (WebCore::InlineIterator::direction):
  41312. (WebCore::InlineBidiResolver::appendRun):
  41313. * rendering/RenderBlockLineLayout.cpp:
  41314. (WebCore::checkMidpoints):
  41315. (WebCore::RenderBlock::appendRunsForObject):
  41316. (WebCore::RenderBlock::layoutInlineChildren):
  41317. (WebCore::RenderBlock::matchedEndLine):
  41318. (WebCore::skipNonBreakingSpace):
  41319. (WebCore::RenderBlock::requiresLineBox):
  41320. (WebCore::RenderBlock::skipTrailingWhitespace):
  41321. (WebCore::RenderBlock::skipLeadingWhitespace):
  41322. (WebCore::tryHyphenating):
  41323. (WebCore::RenderBlock::findNextLineBreak):
  41324. 2011-03-29 Pavel Feldman <pfeldman@chromium.org>
  41325. Reviewed by Yury Semikhatsky.
  41326. Web Inspector: document Timeline domain, make timeline event types of type string.
  41327. https://bugs.webkit.org/show_bug.cgi?id=57299
  41328. * inspector/Inspector.json:
  41329. * inspector/InspectorTimelineAgent.cpp:
  41330. (WebCore::InspectorTimelineAgent::pushGCEventRecords):
  41331. (WebCore::InspectorTimelineAgent::start):
  41332. (WebCore::InspectorTimelineAgent::stop):
  41333. (WebCore::InspectorTimelineAgent::willCallFunction):
  41334. (WebCore::InspectorTimelineAgent::didCallFunction):
  41335. (WebCore::InspectorTimelineAgent::willDispatchEvent):
  41336. (WebCore::InspectorTimelineAgent::didDispatchEvent):
  41337. (WebCore::InspectorTimelineAgent::willLayout):
  41338. (WebCore::InspectorTimelineAgent::didLayout):
  41339. (WebCore::InspectorTimelineAgent::willRecalculateStyle):
  41340. (WebCore::InspectorTimelineAgent::didRecalculateStyle):
  41341. (WebCore::InspectorTimelineAgent::willPaint):
  41342. (WebCore::InspectorTimelineAgent::didPaint):
  41343. (WebCore::InspectorTimelineAgent::willWriteHTML):
  41344. (WebCore::InspectorTimelineAgent::didWriteHTML):
  41345. (WebCore::InspectorTimelineAgent::didInstallTimer):
  41346. (WebCore::InspectorTimelineAgent::didRemoveTimer):
  41347. (WebCore::InspectorTimelineAgent::willFireTimer):
  41348. (WebCore::InspectorTimelineAgent::didFireTimer):
  41349. (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
  41350. (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
  41351. (WebCore::InspectorTimelineAgent::willLoadXHR):
  41352. (WebCore::InspectorTimelineAgent::didLoadXHR):
  41353. (WebCore::InspectorTimelineAgent::willEvaluateScript):
  41354. (WebCore::InspectorTimelineAgent::didEvaluateScript):
  41355. (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
  41356. (WebCore::InspectorTimelineAgent::willSendResourceRequest):
  41357. (WebCore::InspectorTimelineAgent::willReceiveResourceData):
  41358. (WebCore::InspectorTimelineAgent::didReceiveResourceData):
  41359. (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
  41360. (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
  41361. (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  41362. (WebCore::InspectorTimelineAgent::didMarkTimeline):
  41363. (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
  41364. (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
  41365. (WebCore::InspectorTimelineAgent::addRecordToTimeline):
  41366. (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  41367. (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  41368. * inspector/InspectorTimelineAgent.h:
  41369. (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
  41370. * inspector/front-end/TimelineAgent.js:
  41371. * inspector/front-end/TimelinePanel.js:
  41372. (WebInspector.TimelinePanel.prototype.get _recordStyles):
  41373. (WebInspector.TimelinePanel.prototype._createEventDivider):
  41374. (WebInspector.TimelinePanel.prototype._findParentRecord):
  41375. (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
  41376. (WebInspector.TimelineDispatcher.prototype.started):
  41377. (WebInspector.TimelineDispatcher.prototype.stopped):
  41378. (WebInspector.TimelineDispatcher.prototype.eventRecorded):
  41379. (WebInspector.TimelinePanel.FormattedRecord):
  41380. (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
  41381. (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  41382. 2011-03-29 Andrey Adaikin <aandrey@google.com>
  41383. Reviewed by Pavel Feldman.
  41384. Web Inspector: Fixing live edits tests on chromium.
  41385. https://bugs.webkit.org/show_bug.cgi?id=57316
  41386. * inspector/front-end/ScriptsPanel.js:
  41387. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  41388. * inspector/front-end/SourceFrame.js:
  41389. (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
  41390. (WebInspector.SourceFrame.prototype._handleSave):
  41391. (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
  41392. 2011-03-29 Pavel Podivilov <podivilov@chromium.org>
  41393. Reviewed by Yury Semikhatsky.
  41394. Web Inspector: fix call frames positions in formatted scripts.
  41395. https://bugs.webkit.org/show_bug.cgi?id=57036
  41396. Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.
  41397. * inspector/front-end/CallStackSidebarPane.js:
  41398. (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation):
  41399. (WebInspector.CallStackSidebarPane.prototype.update):
  41400. (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
  41401. (WebInspector.CallStackSidebarPane.prototype._placardSelected):
  41402. (WebInspector.CallStackSidebarPane.prototype._contextMenu):
  41403. (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
  41404. * inspector/front-end/DebuggerModel.js:
  41405. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  41406. (WebInspector.DebuggerModel.prototype.get debuggerPausedDetails):
  41407. (WebInspector.DebuggerModel.prototype._pausedScript):
  41408. * inspector/front-end/DebuggerPresentationModel.js:
  41409. (WebInspector.DebuggerPresentationModel):
  41410. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
  41411. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  41412. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  41413. (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
  41414. (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
  41415. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  41416. (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
  41417. (WebInspector.DebuggerPresentationModel.prototype._reset):
  41418. (WebInspector.PresenationCallFrame): Call frame wrapper for UI.
  41419. * inspector/front-end/ScriptsPanel.js:
  41420. (WebInspector.ScriptsPanel):
  41421. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  41422. (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
  41423. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  41424. (WebInspector.ScriptsPanel.prototype._debuggerResumed):
  41425. (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  41426. (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
  41427. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  41428. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
  41429. * inspector/front-end/SourceFile.js:
  41430. (WebInspector.SourceFile.prototype.get content):
  41431. * inspector/front-end/SourceFrame.js:
  41432. (WebInspector.SourceFrame.prototype._createTextViewer):
  41433. (WebInspector.SourceFrame.prototype.setExecutionLine):
  41434. (WebInspector.SourceFrame.prototype.clearExecutionLine):
  41435. (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
  41436. (WebInspector.SourceFrame.prototype._showPopup):
  41437. 2011-03-29 Emil A Eklund <eae@chromium.org>
  41438. Reviewed by Darin Adler.
  41439. Fix for execCommand("Delete") with an empty selection.
  41440. https://bugs.webkit.org/show_bug.cgi?id=56652
  41441. Test: editing/execCommand/delete-empty-container.html
  41442. * editing/TypingCommand.cpp:
  41443. (WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.
  41444. 2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
  41445. Reviewed by Pavel Feldman.
  41446. Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
  41447. make sure we don't return big amounts of data to forms.
  41448. https://bugs.webkit.org/show_bug.cgi?id=57227
  41449. * inspector/front-end/DetailedHeapshotGridNodes.js:
  41450. (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  41451. (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
  41452. (WebInspector.HeapSnapshotObjectNode):
  41453. (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
  41454. (WebInspector.HeapSnapshotInstanceNode):
  41455. (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
  41456. (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  41457. (WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
  41458. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  41459. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  41460. (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  41461. * inspector/front-end/DetailedHeapshotView.js:
  41462. (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
  41463. (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
  41464. * inspector/front-end/HeapSnapshot.js:
  41465. (WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
  41466. (WebInspector.HeapSnapshotNode.prototype.get retainers):
  41467. (WebInspector.HeapSnapshot):
  41468. (WebInspector.HeapSnapshot.prototype.get _allNodes):
  41469. (WebInspector.HeapSnapshot.prototype.get nodeCount):
  41470. (WebInspector.HeapSnapshot.prototype.get rootNodeIndex):
  41471. (WebInspector.HeapSnapshot.prototype.hasId):
  41472. (WebInspector.HeapSnapshot.prototype.get nodeIds):
  41473. (WebInspector.HeapSnapshot.prototype._retainersForNode):
  41474. (WebInspector.HeapSnapshot.prototype._buildRetainers):
  41475. (WebInspector.HeapSnapshot.prototype._buildAggregates):
  41476. (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
  41477. (WebInspector.HeapSnapshot.prototype._buildIdsList):
  41478. (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
  41479. (WebInspector.HeapSnapshotFilteredOrderedIterator):
  41480. (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
  41481. (WebInspector.HeapSnapshotEdgesProvider):
  41482. (WebInspector.HeapSnapshotNodesProvider):
  41483. 2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
  41484. Reviewed by Pavel Feldman.
  41485. Web Inspector: [Chromium] Fix detailed heap snapshots UI.
  41486. https://bugs.webkit.org/show_bug.cgi?id=57235
  41487. Fix two problems:
  41488. 1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
  41489. 2. Long strings need to be truncated in grid, their contents can be shown on hover.
  41490. * inspector/front-end/DetailedHeapshotView.js:
  41491. (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
  41492. (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  41493. * inspector/front-end/heapProfiler.css:
  41494. (.detailed-heapshot-view .console-formatted-string):
  41495. (.detailed-heapshot-view .data-grid tr.selected *):
  41496. (.detailed-heapshot-view .data-grid:focus tr.selected *):
  41497. 2011-03-29 Andrey Adaikin <aandrey@google.com>
  41498. Reviewed by Yury Semikhatsky.
  41499. Web Inspector: Highlight visible lines first
  41500. https://bugs.webkit.org/show_bug.cgi?id=57013
  41501. * inspector/front-end/TextViewer.js:
  41502. (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleChunkNumber):
  41503. (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
  41504. (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
  41505. (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
  41506. (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
  41507. (WebInspector.TextEditorMainPanel.prototype._paintLines):
  41508. (WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
  41509. (WebInspector.TextEditorMainPanel.prototype._paintLine):
  41510. (WebInspector.TextEditorMainChunk.prototype.set expanded):
  41511. 2011-03-29 Emil A Eklund <eae@chromium.org>
  41512. Reviewed by Dimitri Glazkov.
  41513. Relative mouse coordinates recalculated for each target
  41514. https://bugs.webkit.org/show_bug.cgi?id=57130
  41515. Calculate relative coordinates lazily for mouse events instead of doing
  41516. it for each target. Speeds up dispatching of mouse events in deep dom
  41517. structures significantly, O(n^2) to O(n).
  41518. Also fixes https://bugs.webkit.org/show_bug.cgi?id=34973
  41519. Tests: fast/events/mouse-relative-position.html
  41520. perf/mouse-event.html
  41521. * dom/Event.cpp:
  41522. (WebCore::Event::setTarget):
  41523. * dom/MouseRelatedEvent.cpp:
  41524. (WebCore::MouseRelatedEvent::MouseRelatedEvent):
  41525. (WebCore::MouseRelatedEvent::initCoordinates):
  41526. (WebCore::pageZoomFactor):
  41527. (WebCore::MouseRelatedEvent::receivedTarget):
  41528. (WebCore::MouseRelatedEvent::computeRelativePosition):
  41529. (WebCore::MouseRelatedEvent::layerX):
  41530. (WebCore::MouseRelatedEvent::layerY):
  41531. (WebCore::MouseRelatedEvent::offsetX):
  41532. (WebCore::MouseRelatedEvent::offsetY):
  41533. * dom/MouseRelatedEvent.h:
  41534. * dom/UIEvent.cpp:
  41535. (WebCore::UIEvent::layerX):
  41536. (WebCore::UIEvent::layerY):
  41537. * dom/UIEvent.h:
  41538. 2011-03-29 Emil A Eklund <eae@chromium.org>
  41539. Reviewed by Darin Adler.
  41540. getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
  41541. https://bugs.webkit.org/show_bug.cgi?id=57266
  41542. Add null check to counterToCSSValue.
  41543. Test: fast/css/getComputedStyle/counterIncrement-without-counter.html
  41544. * css/CSSComputedStyleDeclaration.cpp:
  41545. (WebCore::counterToCSSValue):
  41546. 2011-03-29 Gavin Peters <gavinp@chromium.org>
  41547. Reviewed by Tony Gentilcore.
  41548. Implement onerror events for <link rel=prefetch>
  41549. https://bugs.webkit.org/show_bug.cgi?id=57182
  41550. These events are equired on link elements, see
  41551. http://dev.w3.org/html5/spec/Overview.html#the-link-element
  41552. After a discussion in WebKit-dev about the direction of prefetch in the loader, and about a path
  41553. to adding the Link header, we decided to look at making onerror, onload and onbeforeload events
  41554. more uniformly supported. See the thread at
  41555. https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html .
  41556. It turned out that part of adding onerror for link prefetch was to make the top CachedResource less
  41557. abstract. It was pure virtual until prefetch became the first consumer to use an unspecialised
  41558. implementation, and this CL continues that by adding a default checkNotify method to it. As it
  41559. happens there were already two subclasses using what amounted to the generic checkNotify, so I
  41560. also removed those, buying us some code cleanup with the change.
  41561. Test: fast/dom/HTMLLinkElement/prefetch-onerror.html
  41562. * html/HTMLLinkElement.cpp:
  41563. (WebCore::HTMLLinkElement::parseMappedAttribute):
  41564. (WebCore::HTMLLinkElement::onloadTimerFired):
  41565. (WebCore::HTMLLinkElement::notifyFinished):
  41566. * loader/cache/CachedImage.cpp:
  41567. * loader/cache/CachedImage.h:
  41568. * loader/cache/CachedResource.cpp:
  41569. (WebCore::CachedResource::checkNotify):
  41570. (WebCore::CachedResource::data):
  41571. (WebCore::CachedResource::error):
  41572. * loader/cache/CachedResource.h:
  41573. * loader/cache/CachedScript.cpp:
  41574. * loader/cache/CachedScript.h:
  41575. 2011-03-29 Eric Seidel <eric@webkit.org>
  41576. Reviewed by Ryosuke Niwa.
  41577. Add support for parsing unicode-bidi: -webkit-isolate
  41578. https://bugs.webkit.org/show_bug.cgi?id=57181
  41579. Test: css3/unicode-bidi-insolate-parse.html
  41580. * WebCore.xcodeproj/project.pbxproj:
  41581. * css/CSSParser.cpp:
  41582. (WebCore::CSSParser::parseValue):
  41583. * css/CSSPrimitiveValueMappings.h:
  41584. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  41585. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  41586. * css/CSSValueKeywords.in:
  41587. * rendering/style/RenderStyleConstants.h:
  41588. 2011-03-29 Patrick Gansterer <paroga@webkit.org>
  41589. Unreviewed WinCE build fix for r82193.
  41590. * platform/wince/FileSystemWinCE.cpp:
  41591. (WebCore::openTemporaryFile):
  41592. 2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
  41593. Unreviewed, rolling out r82198.
  41594. http://trac.webkit.org/changeset/82198
  41595. https://bugs.webkit.org/show_bug.cgi?id=57304
  41596. Broke Chromium Win build. (Requested by dave_levin on
  41597. #webkit).
  41598. * platform/image-decoders/png/PNGImageDecoder.cpp:
  41599. (WebCore::PNGImageDecoder::headerAvailable):
  41600. (WebCore::PNGImageDecoder::rowAvailable):
  41601. 2011-03-28 Ofri Wolfus <ofri@google.com>
  41602. Reviewed by Eric Seidel.
  41603. RTL: Select elements with a size attribute are always left aligned.
  41604. https://bugs.webkit.org/show_bug.cgi?id=50928
  41605. Added support for alignment in RenderListBox.
  41606. Test: fast/forms/listbox-bidi-align.html
  41607. * rendering/RenderListBox.cpp:
  41608. (WebCore::itemOffsetForAlignment):
  41609. (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
  41610. 2011-03-28 Kwang Yul Seo <skyul@company100.net>
  41611. Reviewed by Benjamin Poulain.
  41612. [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
  41613. https://bugs.webkit.org/show_bug.cgi?id=57142
  41614. TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
  41615. Remove ENABLE(VIDEO) guard.
  41616. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  41617. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  41618. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  41619. (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
  41620. * platform/graphics/texmap/TextureMapperNode.h:
  41621. * platform/graphics/texmap/TextureMapperPlatformLayer.h:
  41622. (WebCore::TextureMapperMediaLayer::layerType):
  41623. 2011-03-28 Thomas Klausner <tk@giga.or.at>
  41624. Reviewed by David Levin.
  41625. png-1.5 fixes
  41626. https://bugs.webkit.org/show_bug.cgi?id=54406
  41627. Fix compilation with png-1.5: struct members were hidden, and
  41628. a new API to terminate data processing was added (especially for
  41629. WebKit).
  41630. Compilation fixes, so no new tests.
  41631. * platform/image-decoders/png/PNGImageDecoder.cpp:
  41632. (WebCore::PNGImageDecoder::headerAvailable):
  41633. (WebCore::PNGImageDecoder::rowAvailable):
  41634. 2011-03-28 Kwang Yul Seo <skyul@company100.net>
  41635. Reviewed by Adam Barth.
  41636. Replace fprintf(stderr, ...) with LOG_ERROR
  41637. https://bugs.webkit.org/show_bug.cgi?id=57216
  41638. LOG_ERROR is a better choice here.
  41639. * bridge/jni/v8/JavaClassV8.cpp:
  41640. (JavaClass::JavaClass):
  41641. 2011-03-28 Steve Block <steveblock@google.com>
  41642. Reviewed by Jeremy Orlow.
  41643. Add a new JavaValue to type to represent a Java value in the Java bridge
  41644. https://bugs.webkit.org/show_bug.cgi?id=57022
  41645. This change introduces a new JavaValue type and uses it in place of jvalue
  41646. in the conversions to and from JavaNPObject used in the V8 Java bridge.
  41647. Refactoring only, no new tests.
  41648. * WebCore.gypi:
  41649. * bridge/jni/JNIUtility.cpp:
  41650. (JSC::Bindings::javaTypeFromClassName):
  41651. (JSC::Bindings::signatureFromJavaType):
  41652. (JSC::Bindings::getJNIField):
  41653. (JSC::Bindings::callJNIMethod):
  41654. * bridge/jni/JavaType.h:
  41655. * bridge/jni/v8/JNIUtilityPrivate.cpp:
  41656. (JSC::Bindings::convertNPVariantToJavaValue):
  41657. (JSC::Bindings::convertJavaValueToNPVariant):
  41658. (JSC::Bindings::jvalueToJavaValue):
  41659. (JSC::Bindings::javaValueToJvalue):
  41660. * bridge/jni/v8/JNIUtilityPrivate.h:
  41661. * bridge/jni/v8/JavaNPObjectV8.cpp:
  41662. (JSC::Bindings::JavaNPObjectInvoke):
  41663. (JSC::Bindings::JavaNPObjectGetProperty):
  41664. * bridge/jni/v8/JavaValueV8.h: Added.
  41665. (JSC::Bindings::JavaValue::JavaValue):
  41666. 2011-03-28 Patrick Gansterer <paroga@webkit.org>
  41667. Reviewed by Darin Adler.
  41668. Use String instead of CString as return value of openTemporaryFile
  41669. https://bugs.webkit.org/show_bug.cgi?id=55332
  41670. We usually store all paths as UTF-16. Do this for temporary files too.
  41671. * WebCore.exp.in
  41672. * platform/FileSystem.h:
  41673. * platform/android/FileSystemAndroid.cpp:
  41674. * platform/brew/FileSystemBrew.cpp:
  41675. * platform/efl/FileSystemEfl.cpp:
  41676. * platform/gtk/FileSystemGtk.cpp:
  41677. * platform/haiku/FileSystemHaiku.cpp:
  41678. * platform/mac/FileSystemMac.mm:
  41679. * platform/qt/FileSystemQt.cpp:
  41680. * platform/win/FileSystemWin.cpp:
  41681. * platform/wince/FileSystemWinCE.cpp:
  41682. * platform/wx/FileSystemWx.cpp:
  41683. * plugins/PluginStream.cpp:
  41684. (WebCore::PluginStream::destroyStream):
  41685. * plugins/PluginStream.h:
  41686. 2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>
  41687. Reviewed by Pavel Feldman.
  41688. Web Inspector: empty, non-functional window
  41689. https://bugs.webkit.org/show_bug.cgi?id=56354
  41690. Check whether DOM local storage is enabled
  41691. before attempting to access window.localStorage.
  41692. No new tests.
  41693. * inspector/front-end/Settings.js:
  41694. (WebInspector.Settings.prototype.findSettingForAllProjects):
  41695. (WebInspector.Settings.prototype._get):
  41696. (WebInspector.Settings.prototype._set):
  41697. 2011-03-28 Beth Dakin <bdakin@apple.com>
  41698. Reviewed by Darin Adler.
  41699. Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
  41700. Horizontal scroller stops appearing after going Forward
  41701. -and corresponding-
  41702. <rdar://problem/9026946>
  41703. This patch rolls out revision 79053 and fixes the same bug in a better way.
  41704. New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
  41705. sets the contents size to 0. This is called when a document is going into the page
  41706. cache.
  41707. * dom/Document.cpp:
  41708. (WebCore::Document::setInPageCache):
  41709. (WebCore::FrameView::resetScrollbarsAndClearContentsSize):
  41710. Roll-out of 79053.
  41711. * history/CachedFrame.cpp:
  41712. (WebCore::CachedFrameBase::restore):
  41713. * page/FrameView.cpp:
  41714. (WebCore::FrameView::FrameView):
  41715. (WebCore::FrameView::reset):
  41716. (WebCore::FrameView::layout):
  41717. * page/FrameView.h:
  41718. 2011-03-28 Ojan Vafai <ojan@chromium.org>
  41719. Reviewed by Antti Koivisto.
  41720. fix style sharing with :any and sibling selectors
  41721. https://bugs.webkit.org/show_bug.cgi?id=57211
  41722. Test: fast/css/sibling-selectors.html
  41723. * css/CSSStyleSelector.cpp:
  41724. (WebCore::collectFeaturesFromList):
  41725. 2011-03-27 Ojan Vafai <ojan@chromium.org>
  41726. Reviewed by Antti Koivisto.
  41727. fix :-webkit-any(:last-child)
  41728. https://bugs.webkit.org/show_bug.cgi?id=57207
  41729. We were passing the wrong arguments to checkSelector. Also, we were not
  41730. passing through the encounteredLink bool.
  41731. * css/CSSStyleSelector.cpp:
  41732. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  41733. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  41734. * css/CSSStyleSelector.h:
  41735. 2011-03-27 Ojan Vafai <ojan@chromium.org>
  41736. Reviewed by Antti Koivisto.
  41737. fix :-webkit-any(:last-child)
  41738. https://bugs.webkit.org/show_bug.cgi?id=57207
  41739. We were passing the wrong arguments to checkSelector. Also, we were not
  41740. passing through the encounteredLink bool.
  41741. * css/CSSStyleSelector.cpp:
  41742. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  41743. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  41744. * css/CSSStyleSelector.h:
  41745. 2011-03-28 Maciej Stachowiak <mjs@apple.com>
  41746. Reviewed by Darin Adler.
  41747. REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
  41748. https://bugs.webkit.org/show_bug.cgi?id=57291
  41749. * platform/KURL.cpp:
  41750. (WebCore::KURL::parse): Instead of considering URLs with
  41751. credentials but no host invalid, consider them to have a host
  41752. ending in @ (which fails down the line)/
  41753. 2011-03-28 Kent Tamura <tkent@chromium.org>
  41754. Reviewed by Dimitri Glazkov.
  41755. Fix some problems of the appearance of form validation message bubble.
  41756. https://bugs.webkit.org/show_bug.cgi?id=57208
  41757. No new tests. Validation message bubble appearance is not testable
  41758. because it depends on a timer.
  41759. * css/html.css:
  41760. (::-webkit-validation-bubble):
  41761. (::-webkit-validation-bubble-message):
  41762. (::-webkit-validation-bubble-arrow):
  41763. (::-webkit-validation-bubble-arrow-clipper):
  41764. - Explicitly set margin, padding, and color.
  41765. - Make the shadow darker.
  41766. - Make the background color darker.
  41767. - Make opacity larger.
  41768. - Make the border color lighter.
  41769. - Add inset shadows
  41770. - Change the implementation of an arrow.
  41771. Stop making a right triangle by the border trick.
  41772. Use -webkit-transform instead.
  41773. - Make min-width workable by changing display property of
  41774. -webkit-validation-bubble to "inline-block".
  41775. * html/ValidationMessage.cpp:
  41776. (WebCore::ValidationMessage::buildBubbleTree):
  41777. Change the node structure. Before this change, -webkit-validation-bubble
  41778. had three DIVs inside. After this change, it has two DIVs;
  41779. -webkit-validation-bubble-arrow-clipper and
  41780. -webkit-validation-bubble-message, and
  41781. -webkit-validation-bubble-arrow-clipper contains
  41782. -webkit-validation-bubble-arrow.
  41783. 2011-03-28 Enrica Casucci <enrica@apple.com>
  41784. Reviewed by Sam Weinig.
  41785. REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
  41786. https://bugs.webkit.org/show_bug.cgi?id=57275
  41787. <rdar://problem/8246691>
  41788. We need to classify cut and paste actions as user typing actions even when
  41789. the action is triggered by a context menu selection to
  41790. allow the propagation of the textDidChangeInTextField event.
  41791. * editing/EditorCommand.cpp:
  41792. The following methods have been modified to properly set up
  41793. the UserTypingGestureAction when the command source is the
  41794. menu or a key binding sequence.
  41795. (WebCore::executeCut):
  41796. (WebCore::executePaste):
  41797. (WebCore::executePasteAndMatchStyle):
  41798. (WebCore::executePasteAsPlainText):
  41799. (WebCore::executeDelete):
  41800. * page/ContextMenuController.cpp:
  41801. (WebCore::ContextMenuController::contextMenuItemSelected): Changed to
  41802. call execute command instead of referring to the specific method in
  41803. the editor class.
  41804. 2011-03-28 Oliver Hunt <oliver@apple.com>
  41805. Reviewed by Geoffrey Garen.
  41806. instanceof Array test fails when using iframes
  41807. https://bugs.webkit.org/show_bug.cgi?id=17250
  41808. Update for new function and date apis
  41809. Test: fast/js/js-constructors-use-correct-global.html
  41810. * WebCore.xcodeproj/project.pbxproj:
  41811. * bindings/js/JSDOMBinding.cpp:
  41812. (WebCore::jsDateOrNull):
  41813. * bindings/js/JSLazyEventListener.cpp:
  41814. (WebCore::JSLazyEventListener::initializeJSFunction):
  41815. 2011-03-28 Beth Dakin <bdakin@apple.com>
  41816. Reviewed by Darin Adler.
  41817. Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
  41818. changed via delegate method, the page needs a full relayout and repaint
  41819. -and corresponding-
  41820. <rdar://problem/9059129>
  41821. Call into WebKitSystemInterface to associate the new painter with the existing
  41822. painter controller. Reset the scrollbar frame rects to the new thickness -- normally
  41823. this only happens when a scrollbar is created, so we have to reset the thickness
  41824. here to pick up the new theme thickness. Finally, force a full relayout and style
  41825. recall with setNeedsRecalcStyleInAllFrames()
  41826. * platform/mac/ScrollAnimatorMac.mm:
  41827. (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
  41828. setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
  41829. patch moves it to be a member function on Page so that it can be called from
  41830. FrameView when the scrollbar style changes.
  41831. * page/FrameView.cpp:
  41832. (WebCore::FrameView::setNeedsRecalcStyleInAllFrames):
  41833. * page/FrameView.h:
  41834. * page/Page.cpp:
  41835. (WebCore::Page::setNeedsRecalcStyleInAllFrames):
  41836. * page/Page.h:
  41837. * page/Settings.cpp:
  41838. (WebCore::Settings::setStandardFontFamily):
  41839. (WebCore::Settings::setFixedFontFamily):
  41840. (WebCore::Settings::setSerifFontFamily):
  41841. (WebCore::Settings::setSansSerifFontFamily):
  41842. (WebCore::Settings::setCursiveFontFamily):
  41843. (WebCore::Settings::setFantasyFontFamily):
  41844. (WebCore::Settings::setMinimumFontSize):
  41845. (WebCore::Settings::setMinimumLogicalFontSize):
  41846. (WebCore::Settings::setDefaultFontSize):
  41847. (WebCore::Settings::setDefaultFixedFontSize):
  41848. (WebCore::Settings::setTextAreasAreResizable):
  41849. (WebCore::Settings::setAuthorAndUserStylesEnabled):
  41850. (WebCore::Settings::setFontRenderingMode):
  41851. (WebCore::Settings::setAcceleratedCompositingEnabled):
  41852. (WebCore::Settings::setShowDebugBorders):
  41853. (WebCore::Settings::setShowRepaintCounter):
  41854. * platform/ScrollableArea.h:
  41855. (WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):
  41856. 2011-03-28 Dirk Pranke <dpranke@chromium.org>
  41857. RS=Tony Chang.
  41858. r81977 moved FontPlatformData.h from
  41859. WebCore/platform/graphics/cocoa to platform/graphics. This
  41860. change updates the chromium build accordingly.
  41861. https://bugs.webkit.org/show_bug.cgi?id=57281
  41862. * platform/graphics/chromium/CrossProcessFontLoading.mm:
  41863. 2011-03-28 Jer Noble <jer.noble@apple.com>
  41864. Reviewed by Darin Adler.
  41865. MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
  41866. https://bugs.webkit.org/show_bug.cgi?id=57249
  41867. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  41868. (WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
  41869. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  41870. 2011-03-28 Jer Noble <jer.noble@apple.com>
  41871. Reviewed by Darin Adler.
  41872. AVFoundation can indeed support full screen.
  41873. MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
  41874. https://bugs.webkit.org/show_bug.cgi?id=57249
  41875. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  41876. (WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen): Return true if using
  41877. the new full screen APIs.
  41878. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  41879. 2011-03-28 Eric Carlson <eric.carlson@apple.com>
  41880. Reviewed by Darin Adler.
  41881. http streams don't always display video with AVFoundation backend
  41882. https://bugs.webkit.org/show_bug.cgi?id=57203
  41883. No new tests, we don't currently have tests for http live streams. Changes verified manually.
  41884. * platform/graphics/MediaPlayer.cpp:
  41885. (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender.
  41886. (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine
  41887. if m_shouldPrepareToRender is set.
  41888. (WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.
  41889. * platform/graphics/MediaPlayer.h:
  41890. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  41891. (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until
  41892. m_isAllowedToRender has been set.
  41893. (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,
  41894. it has logic to figure out when setup is required.
  41895. (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't
  41896. using the preferred rendering mode because if we get a file's metadata between the
  41897. time supportsAcceleratedRendering() and paint() are called, we will allocate a software
  41898. renderer even when we prefer a layer backed renderer.
  41899. (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.
  41900. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  41901. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  41902. (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of
  41903. an explicit list of key path names.
  41904. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
  41905. (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed
  41906. to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
  41907. callers need.
  41908. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the
  41909. player item, not the asset, because AVAsset.duration always returns an indefinite time
  41910. for all streaming files.
  41911. (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed
  41912. to assetMetadataKeyNames.
  41913. (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until
  41914. metadata is available.
  41915. (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
  41916. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off
  41917. into sizeChanged().
  41918. (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize
  41919. until tracks is non-NULL so we have a size as early as possible.
  41920. (WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
  41921. (WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of
  41922. KVO observable properties.
  41923. (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to
  41924. presentationSize change.
  41925. 2011-03-28 Anders Carlsson <andersca@apple.com>
  41926. Reviewed by Sam Weinig.
  41927. Search field focus ring is missing
  41928. https://bugs.webkit.org/show_bug.cgi?id=57270
  41929. <rdar://problem/8765555>
  41930. Add an _automaticFocusRingDisabled method which returns YES.
  41931. * platform/mac/ThemeMac.mm:
  41932. (-[WebCoreFlippedView _automaticFocusRingDisabled]):
  41933. 2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
  41934. Reviewed by Darin Adler.
  41935. Move more events to EventDispatcher.
  41936. https://bugs.webkit.org/show_bug.cgi?id=57247
  41937. No functional changes, covered by existing tests.
  41938. * dom/EventDispatcher.cpp:
  41939. (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,
  41940. since it's not used anywhere outside of the EventDispatcher.
  41941. (WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
  41942. (WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
  41943. (WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
  41944. (WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules
  41945. as a static function.
  41946. * dom/EventDispatcher.h: Updated decls.
  41947. * dom/Node.cpp:
  41948. (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher.
  41949. (WebCore::Node::dispatchKeyEvent): Ditto.
  41950. (WebCore::Node::dispatchWheelEvent): Ditto.
  41951. 2011-03-28 Adele Peterson <adele@apple.com>
  41952. Reviewed by Eric Seidel.
  41953. Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
  41954. https://bugs.webkit.org/show_bug.cgi?id=57173
  41955. Test: editing/spelling/grammar.html
  41956. * WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
  41957. * editing/Editor.cpp:
  41958. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,
  41959. so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph. In the case of this bug,
  41960. when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
  41961. in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
  41962. is the only one operated on when this information is used.
  41963. (WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
  41964. * editing/Editor.h:
  41965. 2011-03-28 Dan Bernstein <mitz@apple.com>
  41966. Reviewed by Darin Adler.
  41967. <rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
  41968. https://bugs.webkit.org/show_bug.cgi?id=48983
  41969. Test: fast/multicol/paginated-layer-crash.html
  41970. * rendering/RenderLayer.cpp:
  41971. (WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
  41972. into sync with updatePagination() after r68069.
  41973. (WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.
  41974. 2011-03-28 Maciej Stachowiak <mjs@apple.com>
  41975. Reviewed by Darin Adler' .
  41976. URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
  41977. https://bugs.webkit.org/show_bug.cgi?id=57220
  41978. Test: http/tests/uri/username-with-no-hostname.html
  41979. * platform/KURL.cpp:
  41980. (WebCore::hostPortIsEmptyButUserPassIsNot):
  41981. (WebCore::KURL::parse):
  41982. 2011-03-28 Adam Barth <abarth@webkit.org>
  41983. Reviewed by Eric Seidel.
  41984. script-src should block inline event handlers
  41985. https://bugs.webkit.org/show_bug.cgi?id=57212
  41986. I considered wrapping this into the canExecute check, but that approach
  41987. would require passing that function a bunch of context information to
  41988. behave correctly once we add support for the "options" directive that
  41989. re-enables these features.
  41990. Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html
  41991. * bindings/js/JSLazyEventListener.cpp:
  41992. (WebCore::JSLazyEventListener::initializeJSFunction):
  41993. - This function was a mess. I couldn't resist cleaning it up a
  41994. bunch. Notice that we ASSERT at the beginning of the function
  41995. that scriptExecutionContext is a document and that both ways of
  41996. getting the global object are the same when document->frame() is
  41997. non-zero because the document must be active and there is a
  41998. one-to-one relation between Frames and active Documents.
  41999. * bindings/v8/V8LazyEventListener.cpp:
  42000. (WebCore::V8LazyEventListener::prepareListenerObject):
  42001. * page/ContentSecurityPolicy.cpp:
  42002. (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  42003. * page/ContentSecurityPolicy.h:
  42004. 2011-03-28 Jeff Miller <jeffm@apple.com>
  42005. Reviewed by Adam Roben.
  42006. ResourceError::certificate() should return a PCCERT_CONTEXT
  42007. https://bugs.webkit.org/show_bug.cgi?id=57262
  42008. * platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
  42009. * platform/network/cf/ResourceErrorCF.cpp:
  42010. (WebCore::ResourceError::certificate): Added.
  42011. 2011-03-28 David Hyatt <hyatt@apple.com>
  42012. Reviewed by Simon Fraser and Darin Adler.
  42013. https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
  42014. occur at the end of a line.
  42015. The old code and new code for dealing with a trailing space object midpoint manipulated a raw
  42016. array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.
  42017. I have patched the code to only go through the Vector and to make it handle the case that led to
  42018. the corruption. Trailing positioned objects can occur both prior to and following the trailing space
  42019. object's midpoint, so we have to be prepared to deal with both cases.
  42020. This is already tested by fast/block/positioning/052.html, and that test now properly progresses
  42021. like the other positioning tests did.
  42022. * rendering/RenderBlockLineLayout.cpp:
  42023. (WebCore::RenderBlock::findNextLineBreak):
  42024. 2011-03-28 Andrei Popescu <andreip@google.com>
  42025. Reviewed by Steve Block.
  42026. V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
  42027. https://bugs.webkit.org/show_bug.cgi?id=57100
  42028. Close the ENABLE guard and the namespace in the right order.
  42029. No new tests, just cleanup.
  42030. * bindings/v8/custom/V8IDBAnyCustom.cpp:
  42031. * bindings/v8/custom/V8IDBKeyCustom.cpp:
  42032. 2011-03-28 Jeff Miller <jeffm@apple.com>
  42033. Reviewed by Adam Roben.
  42034. Include certificate when sending a WebCore::ResourceError to UI process on Windows
  42035. https://bugs.webkit.org/show_bug.cgi?id=57195
  42036. Add support for tracking the certificate in WebCore::ResourceError.
  42037. * platform/network/ResourceErrorBase.cpp:
  42038. (WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
  42039. * platform/network/ResourceErrorBase.h:
  42040. (WebCore::ResourceErrorBase::platformCopy): Added.
  42041. * platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate.
  42042. (WebCore::ResourceError::certificate): Added.
  42043. * platform/network/cf/ResourceErrorCF.cpp:
  42044. (WebCore::ResourceError::ResourceError): Added constructor that takes certificate data.
  42045. (WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary.
  42046. (WebCore::ResourceError::platformCopy): Copy m_certificate.
  42047. (WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.
  42048. 2011-03-28 Jessie Berlin <jberlin@apple.com>
  42049. Rubber-stamped by Adam Roben.
  42050. Add an extra newline to the end of the generated Inspector.idl file so that it does not
  42051. trigger the Windows "no newline at at end of file" warning.
  42052. * inspector/generate-inspector-idl:
  42053. 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
  42054. Buildfix after r82125.
  42055. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  42056. https://bugs.webkit.org/show_bug.cgi?id=57087
  42057. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.
  42058. (WebCore::MediaPlayerPrivateQt::getSupportedTypes):
  42059. (WebCore::MediaPlayerPrivateQt::commitLoad):
  42060. 2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
  42061. Unreviewed, rolling out r82099.
  42062. http://trac.webkit.org/changeset/82099
  42063. https://bugs.webkit.org/show_bug.cgi?id=57245
  42064. Breaks live edits tests on chromium. (Requested by pfeldman on
  42065. #webkit).
  42066. * inspector/front-end/ScriptsPanel.js:
  42067. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  42068. * inspector/front-end/SourceFrame.js:
  42069. (WebInspector.SourceFrame.prototype._handleSave):
  42070. (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
  42071. 2011-03-28 Pavel Feldman <pfeldman@chromium.org>
  42072. Reviewed by Yury Semikhatsky.
  42073. Web Inspector: brush up and rename debugger domain functions.
  42074. https://bugs.webkit.org/show_bug.cgi?id=57240
  42075. * inspector/Inspector.json:
  42076. * inspector/InspectorAgent.cpp:
  42077. (WebCore::InspectorAgent::setFrontend):
  42078. (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
  42079. * inspector/InspectorDebuggerAgent.cpp:
  42080. (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
  42081. (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
  42082. (WebCore::InspectorDebuggerAgent::setBreakpoint):
  42083. (WebCore::InspectorDebuggerAgent::removeBreakpoint):
  42084. (WebCore::InspectorDebuggerAgent::editScriptSource):
  42085. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  42086. (WebCore::InspectorDebuggerAgent::didParseSource):
  42087. (WebCore::InspectorDebuggerAgent::failedToParseSource):
  42088. (WebCore::InspectorDebuggerAgent::didPause):
  42089. (WebCore::InspectorDebuggerAgent::didContinue):
  42090. * inspector/InspectorDebuggerAgent.h:
  42091. * inspector/front-end/DebuggerModel.js:
  42092. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  42093. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  42094. (WebInspector.DebuggerModel.prototype.removeBreakpoint):
  42095. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  42096. (WebInspector.DebuggerDispatcher.prototype.paused):
  42097. (WebInspector.DebuggerDispatcher.prototype.resumed):
  42098. (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  42099. (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
  42100. (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  42101. * inspector/front-end/ScriptsPanel.js:
  42102. (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  42103. * inspector/front-end/inspector.js:
  42104. (WebInspector.didCreateWorker):
  42105. (WebInspector.didDestroyWorker):
  42106. 2011-03-28 David Kilzer <ddkilzer@apple.com>
  42107. <http://webkit.org/b/57239> Use forward class declaration instead of including header
  42108. Reviewed by Dan Bernstein.
  42109. Adding a "using namespace WebCore;" statement in a header may
  42110. cause issues when <WebCore/Length.h> is included before
  42111. <CoreText/CoreText.h>.
  42112. Length.h defines the LengthType enum with a 'Fixed' value.
  42113. CoreText.h includes MacTypes.h, which has a
  42114. "typedef SInt32 Fixed;" statement, and then CoreText.h includes
  42115. other headers that also use 'Fixed', but expect the typedef to
  42116. be defined, not the enum. If another header includes
  42117. "using namespace WebCore;" before CoreText.h, the
  42118. following compiler errors result (paths abbreviated):
  42119. CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
  42120. MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
  42121. Length.h:37: error: WebCore::LengthType WebCore::Fixed
  42122. SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type
  42123. * platform/mac/HTMLConverter.h: Use forward declaration of
  42124. DocumentLoader class instead of including header. Remove the
  42125. unused "using namespace WebCore;" statement.
  42126. 2011-03-26 Dimitri Glazkov <dglazkov@chromium.org>
  42127. Reviewed by Eric Seidel.
  42128. Introduce EventDispatcher, the new common way to fire events.
  42129. https://bugs.webkit.org/show_bug.cgi?id=57168
  42130. The goal here is two-fold:
  42131. 1) reduce the need to randomly sprinkle guards around the dispatch code
  42132. by creating a well-scoped abstraction for dispatching events.
  42133. 2) create a place where fiddly event-related things like creating event
  42134. contexts for ancestors can be done lazily.
  42135. Additionally, with all the free-standing static functions, this code was
  42136. just begging to come out of Node.cpp.
  42137. The first step is a near-mechanical extraction of mouse-related events
  42138. from Node.cpp to EventDispatcher. For now, the call sites are just
  42139. replaced with invoking EventDispatcher. Later, we can remove these methods
  42140. from Node.
  42141. Refactoring, no functional changes.
  42142. * Android.mk: Added EventDispatcher to build system.
  42143. * CMakeLists.txt: Ditto.
  42144. * GNUmakefile.am: Ditto.
  42145. * WebCore.gypi: Ditto.
  42146. * WebCore.pro: Ditto.
  42147. * WebCore.vcproj/WebCore.vcproj: Ditto.
  42148. * WebCore.xcodeproj/project.pbxproj: Ditto.
  42149. * dom/DOMAllInOne.cpp: Ditto.
  42150. * dom/EventDispatcher.cpp: Added.
  42151. * dom/EventDispatcher.h: Added.
  42152. * dom/Node.cpp:
  42153. (WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher.
  42154. (WebCore::Node::dispatchEvent): Ditto.
  42155. (WebCore::Node::dispatchMouseEvent): Ditto.
  42156. (WebCore::Node::dispatchSimulatedClick): Ditto.
  42157. * dom/Node.h: Updated decls.
  42158. 2011-03-28 Dan Bernstein <mitz@apple.com>
  42159. Reviewed by Maciej Stachowiak.
  42160. <rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
  42161. https://bugs.webkit.org/show_bug.cgi?id=57197
  42162. Tests: fast/repaint/overflow-flipped-writing-mode-block.html
  42163. fast/repaint/overflow-flipped-writing-mode-table.html
  42164. * rendering/RenderBlock.cpp:
  42165. (WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
  42166. with the damage rect.
  42167. * rendering/RenderTable.cpp:
  42168. (WebCore::RenderTable::paint): Made the intersection check more like the one in
  42169. RenderBlock::paint().
  42170. 2011-03-28 Xiaomei Ji <xji@chromium.org>
  42171. Reviewed by Ryosuke Niwa.
  42172. move directionOfEnclosingBlock() to be global so that it could be reused.
  42173. https://bugs.webkit.org/show_bug.cgi?id=57233.
  42174. Provide global function directionOfEnclosingBlock(Node*) so that it could be
  42175. reused in SelectionController and other functionalities that need enclosing
  42176. block's direcionality, such as moving caret by word in visual order.
  42177. No new functionality, so no new tests.
  42178. * editing/SelectionController.cpp:
  42179. (WebCore::SelectionController::directionOfEnclosingBlock):
  42180. * editing/htmlediting.cpp:
  42181. (WebCore::directionOfEnclosingBlock):
  42182. * editing/htmlediting.h:
  42183. 2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  42184. Reviewed by Benjamin Poulain.
  42185. [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
  42186. https://bugs.webkit.org/show_bug.cgi?id=56825
  42187. Fixes for context attribute handling:
  42188. - Initialize depth and stencil buffer depending on whether they
  42189. are enabled in context attributes.
  42190. - Always enable depth buffer when stencil buffer is enabled.
  42191. - Disable stencil buffer on OpenGL ES 2.0
  42192. - Cleaned up clutter code from initialization. Made code paths
  42193. more sane.
  42194. - Clear mask is now set correctly in reshape().
  42195. Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
  42196. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  42197. (WebCore::GraphicsContext3DInternal::isValid):
  42198. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
  42199. (WebCore::GraphicsContext3DInternal::reshape):
  42200. (WebCore::GraphicsContext3DInternal::paint):
  42201. (WebCore::GraphicsContext3DInternal::getProcAddress):
  42202. (WebCore::GraphicsContext3D::GraphicsContext3D):
  42203. (WebCore::GraphicsContext3D::reshape):
  42204. (WebCore::GraphicsContext3D::bindFramebuffer):
  42205. 2011-03-28 Pavel Feldman <pfeldman@chromium.org>
  42206. Reviewed by Yury Semikhatsky.
  42207. Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
  42208. https://bugs.webkit.org/show_bug.cgi?id=57226
  42209. * inspector/Inspector.json:
  42210. * inspector/InspectorResourceAgent.cpp:
  42211. (WebCore::InspectorResourceAgent::willSendRequest):
  42212. (WebCore::InspectorResourceAgent::markResourceAsCached):
  42213. (WebCore::InspectorResourceAgent::didReceiveResponse):
  42214. (WebCore::InspectorResourceAgent::didReceiveContentLength):
  42215. (WebCore::InspectorResourceAgent::didFinishLoading):
  42216. (WebCore::InspectorResourceAgent::didFailLoading):
  42217. (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
  42218. (WebCore::InspectorResourceAgent::setInitialContent):
  42219. (WebCore::InspectorResourceAgent::didCommitLoad):
  42220. (WebCore::InspectorResourceAgent::frameDetachedFromParent):
  42221. (WebCore::InspectorResourceAgent::didCreateWebSocket):
  42222. (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
  42223. (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
  42224. (WebCore::InspectorResourceAgent::didCloseWebSocket):
  42225. * inspector/front-end/NetworkManager.js:
  42226. (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
  42227. (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
  42228. (WebInspector.NetworkDispatcher.prototype.responseReceived):
  42229. (WebInspector.NetworkDispatcher.prototype.dataReceived):
  42230. (WebInspector.NetworkDispatcher.prototype.loadingFinished):
  42231. (WebInspector.NetworkDispatcher.prototype.loadingFailed):
  42232. (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
  42233. (WebInspector.NetworkDispatcher.prototype.frameDetached):
  42234. (WebInspector.NetworkDispatcher.prototype.initialContentSet):
  42235. (WebInspector.NetworkDispatcher.prototype.frameNavigated):
  42236. (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
  42237. (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
  42238. (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
  42239. (WebInspector.NetworkDispatcher.prototype.webSocketClosed):
  42240. 2011-03-28 Mikhail Naganov <mnaganov@chromium.org>
  42241. Reviewed by Pavel Feldman.
  42242. WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
  42243. https://bugs.webkit.org/show_bug.cgi?id=57099
  42244. * bindings/v8/ScriptHeapSnapshot.cpp:
  42245. (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
  42246. * bindings/v8/ScriptHeapSnapshot.h:
  42247. * bindings/v8/ScriptProfile.cpp:
  42248. (WebCore::ScriptProfile::~ScriptProfile):
  42249. * bindings/v8/ScriptProfile.h:
  42250. * inspector/InspectorProfilerAgent.cpp:
  42251. (WebCore::InspectorProfilerAgent::resetState):
  42252. 2011-03-24 Pavel Podivilov <podivilov@chromium.org>
  42253. Reviewed by Yury Semikhatsky.
  42254. Web Inspector: fix console messages positions in formatted scripts.
  42255. https://bugs.webkit.org/show_bug.cgi?id=57010
  42256. * inspector/front-end/DebuggerPresentationModel.js:
  42257. (WebInspector.DebuggerPresentationModel):
  42258. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  42259. (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping):
  42260. (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
  42261. (WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages):
  42262. (WebInspector.DebuggerPresentationModel.prototype._reset):
  42263. * inspector/front-end/ResourceTreeModel.js:
  42264. (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
  42265. * inspector/front-end/ScriptsPanel.js:
  42266. (WebInspector.ScriptsPanel):
  42267. (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
  42268. (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
  42269. (WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
  42270. (WebInspector.ScriptsPanel.prototype.reset):
  42271. (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  42272. * inspector/front-end/SourceFile.js:
  42273. (WebInspector.SourceFile):
  42274. * inspector/front-end/SourceFrame.js:
  42275. (WebInspector.SourceFrame.prototype.addMessage):
  42276. (WebInspector.SourceFrame.prototype._addExistingMessagesToSource):
  42277. (WebInspector.SourceFrame.prototype.addMessageToSource):
  42278. 2011-03-27 Pavel Feldman <pfeldman@chromium.org>
  42279. Reviewed by Yury Semikhatsky.
  42280. Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
  42281. https://bugs.webkit.org/show_bug.cgi?id=57186
  42282. - ResourceTreeModel is now event target (Object)
  42283. - There is no ResourceTreeModel -> UI dependencies
  42284. - NetworkManager -> ResourceTreeModel dependencies has been removed
  42285. - NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
  42286. - ResourceTreeModel requests tree structure from the backend separately
  42287. - Cached resources tree payload is now limited to url and type (no headers involved)
  42288. - Resources tree is being rendered lazily upon request from the panel.
  42289. * inspector/Inspector.json:
  42290. * inspector/InspectorResourceAgent.cpp:
  42291. (WebCore::InspectorResourceAgent::resourceContent):
  42292. (WebCore::InspectorResourceAgent::resourceContentBase64):
  42293. (WebCore::buildObjectForFrameTree):
  42294. (WebCore::InspectorResourceAgent::enable):
  42295. (WebCore::InspectorResourceAgent::getCachedResources):
  42296. (WebCore::InspectorResourceAgent::getResourceContent):
  42297. * inspector/InspectorResourceAgent.h:
  42298. * inspector/InspectorStyleSheet.cpp:
  42299. (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  42300. * inspector/front-end/InspectorFrontendHostStub.js:
  42301. (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
  42302. (.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
  42303. * inspector/front-end/NetworkManager.js:
  42304. (WebInspector.NetworkManager):
  42305. (WebInspector.NetworkManager.prototype.frontendReused):
  42306. (WebInspector.NetworkManager.prototype.requestContent):
  42307. (WebInspector.NetworkDispatcher):
  42308. (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
  42309. (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
  42310. (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
  42311. (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
  42312. * inspector/front-end/NetworkPanel.js:
  42313. (WebInspector.NetworkPanel):
  42314. (WebInspector.NetworkPanel.prototype._updateSummaryBar):
  42315. (WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
  42316. * inspector/front-end/ResourceTreeModel.js:
  42317. (WebInspector.ResourceTreeModel):
  42318. (WebInspector.ResourceTreeModel.prototype.frontendReused):
  42319. (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  42320. (WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame):
  42321. (WebInspector.ResourceTreeModel.prototype.frames):
  42322. (WebInspector.ResourceTreeModel.prototype.subframes):
  42323. (WebInspector.ResourceTreeModel.prototype.resources):
  42324. (WebInspector.ResourceTreeModel.prototype._onCommitLoad):
  42325. (WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent):
  42326. (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
  42327. (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
  42328. (WebInspector.ResourceTreeModel.prototype.resourceForURL):
  42329. (WebInspector.ResourceTreeModel.prototype._bindResourceURL):
  42330. (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
  42331. (WebInspector.ResourceTreeModel.prototype._clearResources):
  42332. (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
  42333. (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
  42334. (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  42335. (WebInspector.ResourceTreeModel.prototype._createResource):
  42336. * inspector/front-end/ResourcesPanel.js:
  42337. (WebInspector.ResourcesPanel):
  42338. (WebInspector.ResourcesPanel.prototype.show):
  42339. (WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
  42340. (WebInspector.ResourcesPanel.prototype._populateResourceTree):
  42341. (WebInspector.ResourcesPanel.prototype._frameAdded):
  42342. (WebInspector.ResourcesPanel.prototype._frameDetached):
  42343. (WebInspector.ResourcesPanel.prototype._resourceAdded):
  42344. (WebInspector.ResourcesPanel.prototype._frameNavigated):
  42345. (WebInspector.FrameTreeElement.prototype.setTitles):
  42346. * inspector/front-end/inspector.js:
  42347. (WebInspector.frontendReused):
  42348. 2011-03-27 Ryosuke Niwa <rniwa@webkit.org>
  42349. Reviewed by Eric Seidel.
  42350. WebKit's behavior for text-align inherit differs from other browsers
  42351. https://bugs.webkit.org/show_bug.cgi?id=56377
  42352. The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
  42353. As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
  42354. the alignment of the text in those nodes should be determined based on the directionality of the text,
  42355. not by the directionality of the ancestor node from which text-align property is inherited.
  42356. Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
  42357. align text to the left in a LTR context and to the right in a RTL context respectively.
  42358. * css/CSSPrimitiveValueMappings.h:
  42359. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND.
  42360. (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
  42361. * css/CSSStyleSelector.cpp:
  42362. (WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
  42363. * rendering/RenderBlock.cpp:
  42364. (WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
  42365. * rendering/RenderBlockLineLayout.cpp:
  42366. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
  42367. * rendering/RenderText.cpp:
  42368. (WebCore::RenderText::localCaretRect): Ditto.
  42369. * rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
  42370. * rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.
  42371. 2011-03-28 Pavel Podivilov <podivilov@chromium.org>
  42372. Reviewed by Yury Semikhatsky.
  42373. Web Inspector: fix breakpoints positions in formatted scripts.
  42374. https://bugs.webkit.org/show_bug.cgi?id=56931
  42375. Add async requestMapping method to SourceFile interface as required for populating
  42376. breakpoints sidebar pane when in "format all scripts" mode.
  42377. * inspector/front-end/DebuggerPresentationModel.js:
  42378. (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
  42379. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping):
  42380. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  42381. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
  42382. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  42383. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping):
  42384. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  42385. (WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI.
  42386. (WebInspector.PresentationBreakpoint.prototype.get sourceFileId):
  42387. (WebInspector.PresentationBreakpoint.prototype.get lineNumber):
  42388. (WebInspector.PresentationBreakpoint.prototype.get condition):
  42389. (WebInspector.PresentationBreakpoint.prototype.get enabled):
  42390. (WebInspector.PresentationBreakpoint.prototype.get url):
  42391. (WebInspector.PresentationBreakpoint.prototype.get resolved):
  42392. (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  42393. * inspector/front-end/ScriptFormatter.js:
  42394. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
  42395. (WebInspector.ScriptFormatter.prototype.formatContent):
  42396. * inspector/front-end/SourceFile.js:
  42397. (WebInspector.SourceFile.prototype.requestSourceMapping):
  42398. (WebInspector.FormattedSourceFile.prototype.requestSourceMapping):
  42399. (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  42400. (WebInspector.SourceMapping):
  42401. (WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation):
  42402. (WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation):
  42403. (WebInspector.FormattedSourceMapping):
  42404. (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation):
  42405. (WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation):
  42406. (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  42407. 2011-03-28 Nancy Piedra <nancy.piedra@nokia.com>
  42408. Reviewed by Csaba Osztrogonác.
  42409. This patch fixes linking errors on Qt Webkit Windows MinGW builds.
  42410. This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
  42411. QWEBKIT_EXPORT is defined as follows:
  42412. #define QWEBKIT_EXPORT Q_DECL_EXPORT
  42413. No new tests needed since only changing .pro file.
  42414. * WebCore.pro:
  42415. 2011-03-28 Andrey Adaikin <aandrey@google.com>
  42416. Reviewed by Yury Semikhatsky.
  42417. Web Inspector: source frame should show the error to user when live edit is failed
  42418. https://bugs.webkit.org/show_bug.cgi?id=57002
  42419. * inspector/front-end/ScriptsPanel.js:
  42420. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  42421. * inspector/front-end/SourceFrame.js:
  42422. (WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource):
  42423. (WebInspector.SourceFrame.prototype._handleSave):
  42424. (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
  42425. 2011-03-26 Mario Sanchez Prada <msanchez@igalia.com>
  42426. Reviewed by Martin Robinson.
  42427. [GTK] Expose the AtkValue interface for WAI-ARIA sliders
  42428. https://bugs.webkit.org/show_bug.cgi?id=56655
  42429. Implement AtkValue interface for WAI-ARIA sliders.
  42430. Test: platform/gtk/accessibility/aria-slider-required-attributes.html
  42431. * accessibility/gtk/AXObjectCacheAtk.cpp:
  42432. (WebCore::AXObjectCache::postPlatformNotification): Emit the
  42433. 'property-change::accessible-value' signal when needed.
  42434. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  42435. (core): New, returns a core object from an AtkValue.
  42436. (webkitAccessibleValueGetCurrentValue): New, implements AtkValue.
  42437. (webkitAccessibleValueGetMaximumValue): Ditto.
  42438. (webkitAccessibleValueGetMinimumValue): Ditto.
  42439. (webkitAccessibleValueSetCurrentValue): Ditto.
  42440. (webkitAccessibleValueGetMinimumIncrement): Ditto.
  42441. (atkValueInterfaceInit): Ditto.
  42442. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE.
  42443. (getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.
  42444. 2011-03-28 Maciej Stachowiak <mjs@apple.com>
  42445. Reviewed by Dan Bernstein.
  42446. Assigning location.path to something that doesn't start with / mangles the authority
  42447. https://bugs.webkit.org/show_bug.cgi?id=57209
  42448. <rdar://problem/9195132>
  42449. Tests: http/tests/uri/assign-path-with-leading-slash.html
  42450. http/tests/uri/assign-path-without-leading-slash.html
  42451. * platform/KURL.cpp:
  42452. (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.
  42453. 2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
  42454. Reviewed by Eric Seidel.
  42455. Extract functions to update logical width from computeInlineDirectionPositionsForLine
  42456. https://bugs.webkit.org/show_bug.cgi?id=57213
  42457. Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
  42458. and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.
  42459. They are used to update logical widths, logical left, and total logical width for left,
  42460. right, and center aligned blocks.
  42461. * rendering/RenderBlockLineLayout.cpp:
  42462. (WebCore::updateLogicalWidthForLeftAlignedBlock):
  42463. (WebCore::updateLogicalWidthForRightAlignedBlock):
  42464. (WebCore::updateLogicalWidthForCenterAlignedBlock):
  42465. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  42466. 2011-03-28 Evan Martin <evan@chromium.org>
  42467. Reviewed by Ryosuke Niwa.
  42468. Refactor duplicate code in HTMLTextElement
  42469. https://bugs.webkit.org/show_bug.cgi?id=57215
  42470. * html/HTMLTitleElement.cpp:
  42471. (WebCore::HTMLTitleElement::childrenChanged):
  42472. This method did an equivalent loop to the text() method on
  42473. the same object.
  42474. 2011-03-27 Fumitoshi Ukai <ukai@chromium.org>
  42475. Reviewed by Alexey Proskuryakov.
  42476. Don't call WebSocket::didClose() more than once.
  42477. https://bugs.webkit.org/show_bug.cgi?id=57081
  42478. If WebSocket close() is called, and connection is established, then
  42479. it will call didClose() that resets m_channel to 0.
  42480. After that, when connection is closed, WebSocketChannel will call
  42481. didClose for the WebSocket instance.
  42482. Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
  42483. WebSocketChannel suppress the second didClose().
  42484. Test: http/tests/websocket/tests/close-unref-websocket.html
  42485. * websockets/WebSocket.cpp:
  42486. (WebCore::WebSocket::didClose):
  42487. 2011-03-27 Adam Barth <abarth@webkit.org>
  42488. Reviewed by Eric Seidel.
  42489. Fix script-src redirect handling
  42490. https://bugs.webkit.org/show_bug.cgi?id=57196
  42491. Resource-loading requirements in CSP apply to each hop in the redirect
  42492. chain. To make that work properly, we need to move enforcement into
  42493. the loader. Fortunately, we already have a choke-point in the loader
  42494. for enforcing this kind of policy.
  42495. * dom/ScriptElement.cpp:
  42496. (WebCore::ScriptElement::requestScript):
  42497. * html/parser/HTMLDocumentParser.cpp:
  42498. * html/parser/HTMLDocumentParser.h:
  42499. * html/parser/HTMLScriptRunnerHost.h:
  42500. * loader/cache/CachedResourceLoader.cpp:
  42501. (WebCore::CachedResourceLoader::canRequest):
  42502. * page/ContentSecurityPolicy.cpp:
  42503. (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  42504. * page/ContentSecurityPolicy.h:
  42505. 2011-03-27 Jer Noble <jer.noble@apple.com>
  42506. Reviewed by Maciej Stachowiak.
  42507. Full Screen: disable keyboard access by default
  42508. https://bugs.webkit.org/show_bug.cgi?id=56684
  42509. Pass whether keyboard access was requested up to ChromeClient when asking
  42510. if fullscreen mode is supported.
  42511. * dom/Document.cpp:
  42512. (WebCore::Document::webkitRequestFullScreenForElement):
  42513. * page/ChromeClient.h:
  42514. (WebCore::ChromeClient::supportsFullscreenForElement):
  42515. 2011-03-27 Patrick Gansterer <paroga@webkit.org>
  42516. Reviewed by Andreas Kling.
  42517. [CMake] Generate WebKitVersion.h
  42518. https://bugs.webkit.org/show_bug.cgi?id=57128
  42519. This file will be used for the user agent string by the CMake based ports.
  42520. * CMakeLists.txt:
  42521. 2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
  42522. Reviewed by Alexey Proskuryakov.
  42523. https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
  42524. in an enum to remove a trailing comma. Sun Studio 12 CC errors out.
  42525. Compile fix only, no actual code change.
  42526. * dom/ExceptionCode.h:
  42527. * editing/EditorInsertAction.h:
  42528. * loader/FrameLoaderTypes.h:
  42529. * platform/PlatformKeyboardEvent.h:
  42530. * platform/ScrollTypes.h:
  42531. * platform/graphics/BitmapImage.h:
  42532. * platform/image-decoders/ImageDecoder.h:
  42533. * platform/network/ProtectionSpace.h:
  42534. * platform/network/ResourceHandleClient.h:
  42535. * platform/network/ResourceRequestBase.h:
  42536. * platform/text/TextCodec.h:
  42537. 2011-03-27 Rob Buis <rwlbuis@gmail.com>
  42538. Reviewed by Nikolas Zimmermann.
  42539. Text on path positioning at zero startOffset
  42540. https://bugs.webkit.org/show_bug.cgi?id=56245
  42541. Since for length 0 no previous point is set, choose epsilon
  42542. length to get normal at starting point of the path.
  42543. Test: svg/text/text-path-middle-align.svg
  42544. * platform/graphics/Path.cpp:
  42545. (WebCore::Path::normalAngleAtLength):
  42546. 2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
  42547. Reviewed by Oliver Hunt.
  42548. https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
  42549. created by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932
  42550. Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions
  42551. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  42552. (WebCore::JSJavaScriptCallFrame::thisObject):
  42553. 2011-03-26 Jer Noble <jer.noble@apple.com>
  42554. Unreviewed build fix.
  42555. Fix a bug which was causing the "skip back" button to be missing, causing
  42556. the media layout tests to fail.
  42557. * rendering/RenderThemeMac.mm:
  42558. (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
  42559. 2011-03-26 Dan Bernstein <mitz@apple.com>
  42560. Reviewed by Maciej Stachowiak.
  42561. <rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
  42562. https://bugs.webkit.org/show_bug.cgi?id=57169
  42563. Test: fast/blockflow/fallback-orientation.html
  42564. * platform/graphics/FontFastPath.cpp:
  42565. (WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
  42566. than continuing down the fallback list.
  42567. 2011-03-26 Maciej Stachowiak <mjs@apple.com>
  42568. Reviewed by Darin Adler.
  42569. Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
  42570. https://bugs.webkit.org/show_bug.cgi?id=56150
  42571. Test: fast/css/giant-stylesheet-crash.html
  42572. * dom/StyleElement.cpp:
  42573. (WebCore::StyleElement::process):
  42574. 2011-03-22 Jer Noble <jer.noble@apple.com>
  42575. Reviewed by Eric Carlson.
  42576. Media controls must use full screen style when in new full screen mode.
  42577. https://bugs.webkit.org/show_bug.cgi?id=56851
  42578. Add new full screen styles for the full screen media elements.
  42579. * DerivedSources.make: Add fullScreenQuickTime.css.
  42580. * WebCore.xcodeproj/project.pbxproj: Ditto.
  42581. * css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded().
  42582. (WebCore::CSSStyleSelector::CSSStyleSelector): Ditto.
  42583. (WebCore::CSSStyleSelector::styleForElement): Load full screen rules
  42584. if needed.
  42585. * css/fullscreenQuickTime.css: Added.
  42586. * css/mediaControls.css:
  42587. * html/shadow/MediaControls.cpp:
  42588. (WebCore::isFullScreen): Added.
  42589. (WebCore::MediaControls::create): Add new full screen volume controls.
  42590. (WebCore::MediaControls::updateStyle): Ditto.
  42591. (WebCore::MediaControls::update): Ditto.
  42592. (WebCore::MediaControls::updateVolumeSliderContainer): Ditto.
  42593. (WebCore::MediaControls::forwardEvent): Ditto.
  42594. * rendering/MediaControlElements.cpp:
  42595. (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added.
  42596. (WebCore::MediaControlFullscreenVolumeSliderElement::create): Added.
  42597. (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added.
  42598. (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet
  42599. (WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added.
  42600. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added.
  42601. (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added.
  42602. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added.
  42603. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added.
  42604. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added.
  42605. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
  42606. * rendering/MediaControlElements.h:
  42607. Added m_overridePosition.
  42608. (WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.
  42609. * rendering/MediaControlElements.h:
  42610. (WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
  42611. * rendering/RenderTheme.h:
  42612. (WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
  42613. * rendering/RenderThemeMac.h:
  42614. * rendering/RenderThemeMac.mm:
  42615. (WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added.
  42616. (WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward
  42617. buttons.
  42618. 2011-03-26 Jer Noble <jer.noble@apple.com>
  42619. Reviewed by Dan Bernstein.
  42620. RenderMedia should obey the view's flattening bit.
  42621. https://bugs.webkit.org/show_bug.cgi?id=57156
  42622. Paint the current frame in software when the associated FrameView
  42623. has its flattening bit set.
  42624. * rendering/RenderVideo.cpp:
  42625. (WebCore::RenderVideo::paintReplaced):
  42626. 2011-03-26 Patrick Gansterer <paroga@webkit.org>
  42627. Unreviewed build fix for !ENABLE(DOM_STORAGE).
  42628. * storage/StorageTracker.cpp:
  42629. Added #if ENABLE(DOM_STORAGE) like in the other storage files.
  42630. 2011-03-26 Kwang Yul Seo <skyul@company100.net>
  42631. Reviewed by Benjamin Poulain.
  42632. [Qt] Remove GraphicsLayerTextureMapper::nativeLayer
  42633. https://bugs.webkit.org/show_bug.cgi?id=57141
  42634. GraphicsLayer::nativeLayer was removed in r73380.
  42635. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  42636. * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  42637. 2011-03-26 Adam Barth <abarth@webkit.org>
  42638. Reviewed by Eric Seidel.
  42639. Teach Content Security Policy how to parse source-list
  42640. https://bugs.webkit.org/show_bug.cgi?id=54799
  42641. This patch is larger than I would like, but I wasn't sure how to make
  42642. it any smaller while still being reasonably testable. I've left out
  42643. some features (such as host wildcarding and 'self') so I can add them
  42644. in later patches with tests.
  42645. Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html
  42646. * bindings/ScriptControllerBase.cpp:
  42647. * dom/ScriptElement.cpp:
  42648. * html/parser/HTMLDocumentParser.cpp:
  42649. * loader/FrameLoader.cpp:
  42650. - Add include explicitly now that we're not spamming the include
  42651. everywhere.
  42652. * dom/Document.cpp:
  42653. (WebCore::Document::initSecurityContext):
  42654. - We need to pass the SecurityOrigin object to
  42655. ContentSecurityPolicy so that it can resolve implicit parts of
  42656. source patterns, such as the scheme.
  42657. * dom/Document.h:
  42658. - Forward declare ContentSecurityPolicy rather than including the
  42659. header. Technically this could be a separate change, but I was
  42660. getting annoyed at the world re-builds.
  42661. * page/ContentSecurityPolicy.cpp:
  42662. (WebCore::skipExactly):
  42663. (WebCore::skipUtil):
  42664. (WebCore::skipWhile):
  42665. - Clean up these parser helper functions. We might consider moving
  42666. them to a more general location. They're very helpful for
  42667. writing secure HTTP header parsers.
  42668. (WebCore::CSPSource::CSPSource):
  42669. - New class to represent one source in a source-list.
  42670. (WebCore::CSPSource::matches):
  42671. (WebCore::CSPSource::schemeMatches):
  42672. (WebCore::CSPSource::hostMatches):
  42673. (WebCore::CSPSource::portMatches):
  42674. (WebCore::CSPSource::isSchemeOnly):
  42675. - Currently we represent scheme-only sources using with an empty
  42676. m_host. Another approach I considered was using another bool,
  42677. but that seemed slighly messier.
  42678. (WebCore::CSPSourceList::CSPSourceList):
  42679. - CSPSourceList doesn't need to ref SecurityOrigin because
  42680. CSPSourceList is owned by ContentSecurityPolicy, which holds a
  42681. ref.
  42682. (WebCore::CSPSourceList::parse):
  42683. (WebCore::CSPSourceList::matches):
  42684. (WebCore::CSPSourceList::parseSource):
  42685. (WebCore::CSPSourceList::parseScheme):
  42686. (WebCore::CSPSourceList::parseHost):
  42687. (WebCore::CSPSourceList::parsePort):
  42688. - A basic "segment and recurse" parser. This parser causes us to
  42689. take more branches than we need, but I don't think we need to
  42690. squeeze every last ouch of performance out of this parser. This
  42691. approach is more simple than some of the other approaches I
  42692. tried.
  42693. (WebCore::CSPSourceList::addSourceSelf):
  42694. (WebCore::CSPDirective::CSPDirective):
  42695. (WebCore::CSPDirective::allows):
  42696. (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
  42697. (WebCore::ContentSecurityPolicy::parse):
  42698. (WebCore::ContentSecurityPolicy::parseDirective):
  42699. (WebCore::ContentSecurityPolicy::addDirective):
  42700. - I couldn't resist re-writing this parser to use the helper
  42701. functions and to match the style of the source-list parser.
  42702. * page/ContentSecurityPolicy.h:
  42703. (WebCore::ContentSecurityPolicy::create):
  42704. - Accept a SecurityOrigin context object.
  42705. 2011-03-26 Patrick Gansterer <paroga@webkit.org>
  42706. Unreviewed EFL and WinCE build fix for r81977.
  42707. * platform/graphics/FontPlatformData.h:
  42708. 2011-03-26 Patrick Gansterer <paroga@webkit.org>
  42709. Unreviewed WinCE build fix for r82000.
  42710. * platform/wince/FileSystemWinCE.cpp:
  42711. (WebCore::openFile): Added missing function.
  42712. 2011-03-25 Kevin Ollivier <kevino@theolliviers.com>
  42713. [wx] Build fix, don't use the new FPD implementation yet, until we can merge ours with it.
  42714. * platform/graphics/FontPlatformData.h:
  42715. 2011-03-25 Jer Noble <jer.noble@apple.com>
  42716. Reviewed by Eric Carlson.
  42717. MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
  42718. https://bugs.webkit.org/show_bug.cgi?id=57047
  42719. No new tests.
  42720. When loading a URL, checkk osee if the Appplication Cache has a version of that URL
  42721. stored; if so, use the local path to that cached media instead of the remote URL.
  42722. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  42723. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal):
  42724. * platform/graphics/win/QTMovie.cpp:
  42725. (QTMovie::loadPath):
  42726. * platform/graphics/win/QTMovie.h:
  42727. 2011-03-25 Dan Bernstein <mitz@apple.com>
  42728. Reviewed by Darin Adler.
  42729. <rdar://problem/9134330> Missing expansion before ideograph at the beginning or end of a text run
  42730. https://bugs.webkit.org/show_bug.cgi?id=57106
  42731. Test: fast/text/justify-ideograph-leading-expansion.html
  42732. * platform/graphics/TextRun.h:
  42733. Replaced TrailingExpansionBehavior enum with ExpansionBehavior flags.
  42734. (WebCore::TextRun::TextRun): Constructors now take an expansionBehavior parameter.
  42735. (WebCore::TextRun::allowsLeadingExpansion): Added this accessor.
  42736. (WebCore::TextRun::allowsTrailingExpansion): Changed to use the m_expansionBehavior member.
  42737. * platform/graphics/WidthIterator.cpp:
  42738. (WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion from the TextRun, allowing
  42739. leading expansion when appropriate.
  42740. (WebCore::WidthIterator::advance): Moved the last-glyph-in-run check to only apply to expansion
  42741. after the glyph, not expansion before the glyph, since that is not trailing expansion. Added code
  42742. to handle expansion before the first glyph.
  42743. * platform/graphics/mac/ComplexTextController.cpp:
  42744. (WebCore::ComplexTextController::ComplexTextController): Initialize m_afterExpansion from the
  42745. TextRun, allowing leading expansion when appropriate. Set m_runWidthSoFar to the leading expansion.
  42746. (WebCore::ComplexTextController::offsetForPosition): Account for leading expansion.
  42747. (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Similar to WidthIterator::advance()
  42748. * platform/graphics/mac/ComplexTextController.h: Added m_leadingExpansion member variable.
  42749. * rendering/InlineBox.h:
  42750. (WebCore::InlineBox::InlineBox): Renamed m_hasSelectedChildren to m_hasSelectedChildrenOrCanHaveLeadingExpansion
  42751. to reflect the use of this bit by InlineTextBox.
  42752. * rendering/InlineTextBox.cpp:
  42753. (WebCore::InlineTextBox::selectionRect): Replaced calls to trailingExpansionBehavior() with expansionBehavior().
  42754. (WebCore::InlineTextBox::paint): Ditto.
  42755. (WebCore::InlineTextBox::paintSelection): Ditto.
  42756. (WebCore::InlineTextBox::paintCompositionBackground): Ditto.
  42757. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
  42758. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
  42759. (WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
  42760. (WebCore::InlineTextBox::offsetForPosition): Ditto.
  42761. (WebCore::InlineTextBox::positionForOffset): Ditto.
  42762. * rendering/InlineTextBox.h:
  42763. (WebCore::InlineTextBox::canHaveLeadingExpansion): Added this accessor.
  42764. (WebCore::InlineTextBox::setCanHaveLeadingExpansion): Ditto.
  42765. (WebCore::InlineTextBox::expansionBehavior): Replaced trailingExpansionBehavior() with this function,
  42766. which also considers canHaveLeadingExpansion().
  42767. * rendering/RenderBlockLineLayout.cpp:
  42768. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Call setCanHaveLeadingExpansion() on
  42769. text boxes that can have leading expansion. Avoid negative expansion.
  42770. * rendering/RootInlineBox.cpp:
  42771. * rendering/RootInlineBox.h:
  42772. (WebCore::RootInlineBox::hasSelectedChildren): Updated for renaming of the flag.
  42773. (WebCore::RootInlineBox::setHasSelectedChildren): Ditto.
  42774. 2011-03-23 Jer Noble <jer.noble@apple.com>
  42775. Reviewed by Maciej Stachowiak.
  42776. MediaPlayerPrivateAVFoundation should use the Application Cache during load.
  42777. https://bugs.webkit.org/show_bug.cgi?id=56997
  42778. No new tests.
  42779. When loading a URL, check to see if the Application Cache has a version of that URL
  42780. stored; if so, use the local path to that cached media instead of the remote URL.
  42781. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  42782. (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Check to see if the media should be loaded
  42783. from the application cache.
  42784. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  42785. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  42786. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  42787. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
  42788. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): Added.
  42789. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Split out from createAVPlayerForURL.
  42790. 2011-03-25 Ben Taylor <bentaylor.solx86@gmail.com>
  42791. Reviewed by Darin Adler.
  42792. https://bugs.webkit.org/show_bug.cgi?id=57122. Solaris 10/SunStudio 12 expect
  42793. both sides of a ?: operation to have the same types. Extracted from original
  42794. https://bugs.webkit.org/show_bug.cgi?id=24932, patch 13 of 17, and originally
  42795. created by Thiago Macieira.
  42796. fixes a compile issue on Solaris 10/SunStudio 12
  42797. * loader/DocumentLoader.h:
  42798. (WebCore::DocumentLoader::serverRedirectSourceForHistory):
  42799. * loader/FrameLoader.cpp:
  42800. (WebCore::FrameLoader::load):
  42801. (WebCore::FrameLoader::loadWithNavigationAction):
  42802. 2011-02-03 Jer Noble <jer.noble@apple.com>
  42803. Reviewed by Maciej Stachowiak.
  42804. MediaPlayerPrivateQTKit should use the Application Cache during load.
  42805. https://bugs.webkit.org/show_bug.cgi?id=53818
  42806. No new tests.
  42807. When loading a URL, check to see if the Application Cache has a version of that URL
  42808. stored; if so, use that data instead of the remote URL.
  42809. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  42810. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  42811. (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
  42812. (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
  42813. (WebCore::MediaPlayerPrivateQTKit::loadInternal):
  42814. 2011-03-25 James Robinson <jamesr@chromium.org>
  42815. Reviewed by Kenneth Russell.
  42816. [chromium] Move draw implementations to CCLayerImpl for everything except content layers
  42817. https://bugs.webkit.org/show_bug.cgi?id=56793
  42818. Moves the implementation of the layer's draw() function from LayerChromium subclasses to CCLayerImpl subclasses for
  42819. all layer types except content layers. This gets us closer to decoupling the composite step itself from updating the layers.
  42820. The biggest change in this patch is adding a set of CCLayerImpl subclasses to implement the different drawing routines
  42821. and moving the code from each XXXLayerChromium to CCXXXLayerImpl. In order to render from the CCLayerImpl side all state
  42822. needed at draw time also has to be synchronized, which is performed in pushPropertiesTo().
  42823. On the LayerRendererChromium side there are a few changes. I've split the updateContents calls on LayerChromiums into two operations
  42824. tentatively named 'paintContentsIfNeeded' and 'updateCompositorResources'. paintContents() is used for any code that calls into WebKit in order to generate
  42825. new pixel data. It's expected that this call may take a long period of time and may involve "odd" side effects. updateCompositorResources() is used for
  42826. code that needs to update the compositor's texture data or other state. It is not expected that this callback will take long (since it's just inserting
  42827. commands into the GL command stream, ideally) and this call is expected to have access to the compositor's context, unlike paintContents().
  42828. The updateAndDrawLayers cycle now looks like this:
  42829. 1.) update the root content layer
  42830. 2.) update the root layer scrollbars
  42831. 3.) for each LayerChromium in tree order:
  42832. a.) ensure a CCLayerImpl of the correct type exists for this layer
  42833. b.) push all draw time properties from the LayerChromium to the CCLayerImpl
  42834. c.) construct the appropriate draw transforms, render surfaces and render surface z-order sublayer lists
  42835. 4.) for each LayerChromium in tree order, paint the layer's contents
  42836. 5.) for each LayerChromium in tree order, update the associate compositor resources (textures, etc)
  42837. 6.) draw the root layer and its scrollbars
  42838. 7.) for each CCLayerImpl in render surface order, draw it
  42839. Step 3 should really happen after step 5, but right now painting a content layer requires knowledge of the render surface properties and draw transforms
  42840. in order to paint. We also currently push layer properties from LayerChromium->CCLayerImpls twice now - once at 3.b and once after 5 so we can pick
  42841. up any texture updates. This will also get fixed when the paint dependency on render surfaces is resolved.
  42842. I haven't modified the root layer or content layers in order to minimize conflicts with the other pending work in that area.
  42843. Tests: compositing/
  42844. * WebCore.gypi:
  42845. * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
  42846. (WebCore::Canvas2DLayerChromium::updateCompositorResources):
  42847. * platform/graphics/chromium/Canvas2DLayerChromium.h:
  42848. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  42849. (WebCore::CanvasLayerChromium::createCCLayerImpl):
  42850. (WebCore::CanvasLayerChromium::pushPropertiesTo):
  42851. * platform/graphics/chromium/CanvasLayerChromium.h:
  42852. * platform/graphics/chromium/ContentLayerChromium.cpp:
  42853. (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
  42854. (WebCore::ContentLayerChromium::paintContentsIfDirty):
  42855. (WebCore::ContentLayerChromium::updateCompositorResources):
  42856. (WebCore::ContentLayerChromium::bindContentsTexture):
  42857. * platform/graphics/chromium/ContentLayerChromium.h:
  42858. * platform/graphics/chromium/ImageLayerChromium.cpp:
  42859. (WebCore::ImageLayerChromium::paintContentsIfDirty):
  42860. * platform/graphics/chromium/ImageLayerChromium.h:
  42861. * platform/graphics/chromium/LayerChromium.cpp:
  42862. (WebCore::LayerChromium::LayerChromium):
  42863. (WebCore::LayerChromium::cleanupResources):
  42864. (WebCore::LayerChromium::setLayerRenderer):
  42865. (WebCore::LayerChromium::setName):
  42866. (WebCore::LayerChromium::pushPropertiesTo):
  42867. (WebCore::LayerChromium::dumpLayer):
  42868. (WebCore::LayerChromium::createCCLayerImpl):
  42869. (WebCore::LayerChromium::createCCLayerImplIfNeeded):
  42870. (WebCore::LayerChromium::ccLayerImpl):
  42871. (WebCore::LayerChromium::layerRenderer):
  42872. * platform/graphics/chromium/LayerChromium.h:
  42873. (WebCore::LayerChromium::paintContentsIfDirty):
  42874. (WebCore::LayerChromium::updateCompositorResources):
  42875. * platform/graphics/chromium/LayerRendererChromium.cpp:
  42876. (WebCore::LayerRendererChromium::updateLayers):
  42877. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  42878. (WebCore::LayerRendererChromium::paintContentsRecursive):
  42879. (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  42880. (WebCore::LayerRendererChromium::drawLayer):
  42881. (WebCore::LayerRendererChromium::initializeSharedObjects):
  42882. * platform/graphics/chromium/LayerRendererChromium.h:
  42883. (WebCore::LayerRendererChromium::canvasLayerProgram):
  42884. (WebCore::LayerRendererChromium::pluginLayerProgram):
  42885. (WebCore::LayerRendererChromium::videoLayerRGBAProgram):
  42886. (WebCore::LayerRendererChromium::videoLayerYUVProgram):
  42887. * platform/graphics/chromium/PluginLayerChromium.cpp:
  42888. (WebCore::PluginLayerChromium::createCCLayerImpl):
  42889. (WebCore::PluginLayerChromium::setTextureId):
  42890. (WebCore::PluginLayerChromium::pushPropertiesTo):
  42891. * platform/graphics/chromium/PluginLayerChromium.h:
  42892. (WebCore::PluginLayerChromium::textureId):
  42893. * platform/graphics/chromium/VideoLayerChromium.cpp:
  42894. (WebCore::VideoLayerChromium::createCCLayerImpl):
  42895. (WebCore::VideoLayerChromium::updateCompositorResources):
  42896. (WebCore::VideoLayerChromium::pushPropertiesTo):
  42897. * platform/graphics/chromium/VideoLayerChromium.h:
  42898. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  42899. (WebCore::WebGLLayerChromium::updateCompositorResources):
  42900. * platform/graphics/chromium/WebGLLayerChromium.h:
  42901. * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
  42902. (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  42903. (WebCore::CCCanvasLayerImpl::~CCCanvasLayerImpl):
  42904. (WebCore::CCCanvasLayerImpl::draw):
  42905. (WebCore::CCCanvasLayerImpl::dumpLayerProperties):
  42906. * platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
  42907. (WebCore::CCCanvasLayerImpl::create):
  42908. (WebCore::CCCanvasLayerImpl::setTextureId):
  42909. (WebCore::CCCanvasLayerImpl::setPremultipliedAlpha):
  42910. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  42911. (WebCore::CCLayerImpl::descendantsDrawsContent):
  42912. (WebCore::CCLayerImpl::updateCompositorResources):
  42913. (WebCore::CCLayerImpl::writeIndent):
  42914. * platform/graphics/chromium/cc/CCLayerImpl.h:
  42915. (WebCore::CCLayerImpl::setAnchorPoint):
  42916. (WebCore::CCLayerImpl::setAnchorPointZ):
  42917. (WebCore::CCLayerImpl::setMasksToBounds):
  42918. (WebCore::CCLayerImpl::setOpacity):
  42919. (WebCore::CCLayerImpl::setPosition):
  42920. (WebCore::CCLayerImpl::setPreserves3D):
  42921. (WebCore::CCLayerImpl::setSublayerTransform):
  42922. (WebCore::CCLayerImpl::setTransform):
  42923. * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
  42924. (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
  42925. (WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
  42926. (WebCore::CCPluginLayerImpl::draw):
  42927. (WebCore::CCPluginLayerImpl::dumpLayerProperties):
  42928. * platform/graphics/chromium/cc/CCPluginLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
  42929. (WebCore::CCPluginLayerImpl::create):
  42930. (WebCore::CCPluginLayerImpl::setTextureId):
  42931. * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Added.
  42932. (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
  42933. (WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
  42934. (WebCore::CCVideoLayerImpl::setTexture):
  42935. (WebCore::CCVideoLayerImpl::draw):
  42936. (WebCore::CCVideoLayerImpl::drawYUV):
  42937. (WebCore::CCVideoLayerImpl::drawRGBA):
  42938. (WebCore::CCVideoLayerImpl::dumpLayerProperties):
  42939. * platform/graphics/chromium/cc/CCVideoLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
  42940. (WebCore::CCVideoLayerImpl::create):
  42941. (WebCore::CCVideoLayerImpl::setSkipsDraw):
  42942. (WebCore::CCVideoLayerImpl::setFrameFormat):
  42943. 2011-03-25 Oliver Hunt <oliver@apple.com>
  42944. Reviewed by Darin Adler.
  42945. Allow defineOwnProperty to work on DOMObjects
  42946. https://bugs.webkit.org/show_bug.cgi?id=57129
  42947. As other engines are allowing defineOwnProperty to be applied
  42948. to host objects there's no reason for us to retain this
  42949. restriction.
  42950. * bindings/js/JSDOMWrapper.cpp:
  42951. * bindings/js/JSDOMWrapper.h:
  42952. 2011-03-25 Andy Estes <aestes@apple.com>
  42953. Reviewed by Adele Peterson.
  42954. REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
  42955. https://bugs.webkit.org/show_bug.cgi?id=49016
  42956. AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
  42957. QuickTime plug-in in web pages. r70748 removed our mapping of classids
  42958. to MIME types, which causes WebKit to fall back from the object to the
  42959. embed tag when QuickTime is embedded by this script. The script emits
  42960. the following embed tag to embed a QuickTime movie with a poster frame:
  42961. <embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">
  42962. The expectation is that a QuickTime plug-in is instantiated to display the
  42963. poster frame, since QuickTime registers for many common image MIME
  42964. types. This is how Gecko behaves for embed. However, WebKit prefers to
  42965. use its native image rendering for image embeds, in which case no movie
  42966. is played when the poster frame is clicked.
  42967. Fix this by changing embed to check for a plug-in that can handle the
  42968. image type before rendering the image natively. This matches Gecko.
  42969. Test: plugins/embed-prefers-plugins-for-images.html
  42970. * html/HTMLEmbedElement.cpp:
  42971. (WebCore::HTMLEmbedElement::HTMLEmbedElement):
  42972. * html/HTMLObjectElement.cpp:
  42973. (WebCore::HTMLObjectElement::HTMLObjectElement):
  42974. (WebCore::HTMLObjectElement::parametersForPlugin):
  42975. * html/HTMLPlugInImageElement.cpp:
  42976. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
  42977. (WebCore::HTMLPlugInImageElement::isImageType):
  42978. (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
  42979. * html/HTMLPlugInImageElement.h:
  42980. (WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages):
  42981. * loader/EmptyClients.h:
  42982. (WebCore::EmptyFrameLoaderClient::objectContentType):
  42983. * loader/FrameLoader.cpp:
  42984. (WebCore::FrameLoader::defaultObjectContentType):
  42985. * loader/FrameLoader.h:
  42986. * loader/FrameLoaderClient.h:
  42987. * loader/SubframeLoader.cpp:
  42988. (WebCore::SubframeLoader::resourceWillUsePlugin):
  42989. (WebCore::SubframeLoader::requestPlugin):
  42990. (WebCore::SubframeLoader::requestObject):
  42991. (WebCore::SubframeLoader::shouldUsePlugin):
  42992. * loader/SubframeLoader.h:
  42993. 2011-03-23 Jer Noble <jer.noble@apple.com>
  42994. Reviewed by Eric Carlson.
  42995. Application Cache should save audio/ and video/ mime types as flat files
  42996. https://bugs.webkit.org/show_bug.cgi?id=53784
  42997. <rdar://problem/8932473>
  42998. No new tests, as this behavior is not possible to test without changes to the MediaPlayer engines.
  42999. Store certain mime types as flat files alongside the Application Cache database.
  43000. This requires plumbing the saved file path from ApplicationCacheStorage through
  43001. to ApplicationCacheResource.
  43002. (WebCore::ApplicationCacheStorage::openDatabase): Modify the CacheResourceData schema and
  43003. add a new DeletedCacheResources table, add a new CacheResourceDataDeleted trigger.
  43004. (WebCore::ApplicationCacheStorage::store): Add the new path data when adding new rows in
  43005. CacheResourceData, and store media resources as flat files.
  43006. (WebCore::ApplicationCacheStorage::loadCache): Pull the "path" column from CacheResourceData
  43007. when loading cache items.
  43008. (WebCore::ApplicationCacheStorage::remove): Call checkForDeletedResources.
  43009. (WebCore::ApplicationCacheStorage::empty): Ditto.
  43010. (WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
  43011. (WebCore::ApplicationCacheStorage::deleteCacheGroup): Ditto.
  43012. (WebCore::ApplicationCacheStorage::checkForDeletedResources): Walk through DeletedCacheResourceData
  43013. looking for entries with non-empty "path" columns; if found, delete.
  43014. (WebCore::ApplicationCacheStorage::flatFileAreaSize): Walk through CacheResourceData rows
  43015. and sum the file size of those rows with flat file storage.
  43016. (WebCore::ApplicationCacheStorage::verifySchemaVersion): Call deleteTables() instead of
  43017. clearAllTables() directly.
  43018. (WebCore::ApplicationCacheStorage::deleteTables): Call empty() before deleting the tables,
  43019. so that flat files get deleted.
  43020. (WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile): Added.
  43021. (WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Added.
  43022. * loader/appcache/ApplicationCacheStorage.h:
  43023. * platform/win/FileSystemWin.cpp:
  43024. (WebCore::openFile): Implement openFile on Windows.
  43025. 2011-03-24 David Hyatt <hyatt@apple.com>
  43026. Reviewed by Dan Bernstein.
  43027. https://bugs.webkit.org/show_bug.cgi?id=56909
  43028. Add a simplified normal flow layout path optimization for overflow recomputation
  43029. and for positioned objects inside relative positioned containers.
  43030. Currently there is an optimized code path for positioned objects, but as soon as
  43031. we encounter a normal flow object in the containing block chain, we lose the
  43032. optimization.
  43033. This patch adds a new type of style difference called SimplifiedLayout that is
  43034. returned when only overflow needs to be recomputed. Whenever a transform changes,
  43035. this is the hint returned now instead of a full layout.
  43036. In addition, when positioned objects need layout and start marking up the
  43037. containing block chain, we now propagate the fact that the layout is simplified
  43038. all the way up to the root, even when we encounter normal flow containing
  43039. blocks.
  43040. The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
  43041. and is now used for all of these cases (in addition to what it handled before).
  43042. The simplified layout optimization (even in ToT) did not work correctly when
  43043. static distances needed to be recomputed. In order to make static distance
  43044. computations work with simplified layout, positioned objects now always compute
  43045. their static offsets, even if they explicitly specify left/top. That way normal
  43046. flow layout never has to re-run when the positioned object moves. This makes
  43047. movement of a positioned object along a single non-auto axis much faster when the
  43048. other axis is auto. Because this code kicked in more often for absolutely positioned
  43049. objects whose original display was inline, I went ahead and fixed the trailing space
  43050. issue with those objects. This causes a bunch of layout tests to progress.
  43051. Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.
  43052. * rendering/RenderBlock.cpp:
  43053. (WebCore::RenderBlock::layoutBlock):
  43054. (WebCore::RenderBlock::adjustPositionedBlock):
  43055. (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  43056. (WebCore::RenderBlock::simplifiedLayout):
  43057. * rendering/RenderBlock.h:
  43058. * rendering/RenderBlockLineLayout.cpp:
  43059. (WebCore::setStaticPositions):
  43060. (WebCore::RenderBlock::findNextLineBreak):
  43061. * rendering/RenderBox.cpp:
  43062. (WebCore::RenderBox::styleDidChange):
  43063. (WebCore::RenderBox::positionLineBox):
  43064. * rendering/RenderBoxModelObject.cpp:
  43065. (WebCore::RenderBoxModelObject::styleWillChange):
  43066. * rendering/RenderFlexibleBox.cpp:
  43067. (WebCore::RenderFlexibleBox::layoutBlock):
  43068. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  43069. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  43070. * rendering/RenderObject.cpp:
  43071. (WebCore::RenderObject::RenderObject):
  43072. (WebCore::RenderObject::adjustStyleDifference):
  43073. (WebCore::RenderObject::setStyle):
  43074. (WebCore::RenderObject::styleDidChange):
  43075. * rendering/RenderObject.h:
  43076. (WebCore::RenderObject::needsLayout):
  43077. (WebCore::RenderObject::needsPositionedMovementLayoutOnly):
  43078. (WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
  43079. (WebCore::RenderObject::setNeedsLayout):
  43080. (WebCore::RenderObject::setChildNeedsLayout):
  43081. (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
  43082. (WebCore::RenderObject::markContainingBlocksForLayout):
  43083. * rendering/RenderTable.cpp:
  43084. (WebCore::RenderTable::layout):
  43085. * rendering/style/RenderStyle.cpp:
  43086. (WebCore::RenderStyle::diff):
  43087. * rendering/style/RenderStyleConstants.h:
  43088. * rendering/svg/RenderSVGText.cpp:
  43089. (WebCore::RenderSVGText::layout):
  43090. 2011-03-25 Martin Robinson <mrobinson@igalia.com>
  43091. Fix the GTK+ build until we can implement the new cross-platform
  43092. FontPlatformData.h bits.
  43093. * platform/graphics/FontPlatformData.h: Include the proper old font headers.
  43094. (WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file
  43095. which reference our obsolete font implementation.
  43096. (WebCore::FontPlatformData::hash): Ditto.
  43097. 2011-03-25 Steve Falkenburg <sfalken@apple.com>
  43098. Reviewed by Brian Weinstein.
  43099. Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
  43100. https://bugs.webkit.org/show_bug.cgi?id=57119
  43101. <rdar://problem/9054148>
  43102. This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
  43103. not available in WebKit. The plug-in is fairly widespread, since it was included in
  43104. a Windows Update push at one point.
  43105. * plugins/win/PluginPackageWin.cpp:
  43106. (WebCore::PluginPackage::isPluginBlacklisted): Blacklist npwpf.dll.
  43107. 2011-03-25 Tony Chang <tony@chromium.org>
  43108. Try to fix the chromium mac build.
  43109. We used the mac FontPlatformData on chromium mac.
  43110. * WebCore.gyp/WebCore.gyp:
  43111. * WebCore.gypi:
  43112. * platform/graphics/FontPlatformData.h:
  43113. 2011-03-25 Tony Chang <tony@chromium.org>
  43114. Build fix:
  43115. have chromium and qt use the correct FontPlatformData.h
  43116. https://bugs.webkit.org/show_bug.cgi?id=57115
  43117. * platform/graphics/FontPlatformData.h:
  43118. 2011-03-25 Beth Dakin <bdakin@apple.com>
  43119. Reviewed by Dave Hyatt.
  43120. Fix for https://bugs.webkit.org/show_bug.cgi?id=57057 Overlay scrollbars in overflow
  43121. areas paint behind positive z-index content
  43122. -and corresponding-
  43123. <rdar://problem/9070500>
  43124. Since overlay scrollbars don't clip the scrollable content like other scrollbars do,
  43125. the only way to get them to paint on top of all possible scrollable content is to
  43126. make them paint on top of everything. To do this, this patch adds a second trip
  43127. through the layer tree if it contains overlay scrollbars that need painting.
  43128. After calling paint() on the rootLayer, call paintOverlayScrollers() if
  43129. containsDirtyOverlayScrollbars() is true.
  43130. * page/FrameView.cpp:
  43131. (WebCore::FrameView::paintContents):
  43132. RenderLayer has two new member variable. m_containsDirtyOverlayScrollbars is a bool
  43133. that is set on the root layer when it has child layers that need overlay scrollbars
  43134. to be painted. m_cachedOverlayScrollbarOffset is an IntPoint to cache the tx and ty
  43135. of the overlay scrollbars on the first (normal) pass through the layer tree. This
  43136. prevents us from having to re-enter the render tree during the second (overlay-only)
  43137. pass. Finally, there is also a new paint flag: PaintLayerPaintingOverlayScrollbars.
  43138. * rendering/RenderLayer.h:
  43139. (WebCore::RenderLayer::containsDirtyOverlayScrollbars):
  43140. (WebCore::RenderLayer::setContainsDirtyOverlayScrollbars):
  43141. * rendering/RenderLayer.cpp:
  43142. (WebCore::RenderLayer::RenderLayer):
  43143. (WebCore::RenderLayer::paintOverflowControls):
  43144. (WebCore::RenderLayer::paintOverlayScrollbars):
  43145. (WebCore::RenderLayer::paintLayer):
  43146. 2011-03-25 Jessie Berlin <jberlin@apple.com>
  43147. Reviewed by Sam Weinig.
  43148. WebKit2: Need to be able to set and get the Cookie Storage Policy.
  43149. https://bugs.webkit.org/show_bug.cgi?id=50780
  43150. * platform/network/cf/CookieStorageCFNet.cpp:
  43151. (WebCore::privateCookieStorage):
  43152. Rename privateBrowsingCookieStorage to privateCookieStorage.
  43153. (WebCore::currentCookieStorage):
  43154. Ditto.
  43155. (WebCore::setCurrentCookieStorage):
  43156. Ditto.
  43157. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  43158. Ditto.
  43159. (WebCore::defaultCookieStorage):
  43160. Return the default cookie storage.
  43161. (WebCore::privateBrowsingCookieStorage):
  43162. Return privateCookieStorage().get()
  43163. * platform/network/cf/CookieStorageCFNet.h:
  43164. 2011-03-25 Emil A Eklund <eae@chromium.org>
  43165. Reviewed by Dimitri Glazkov.
  43166. Text field "onchange" event is triggered if actual value unchanged
  43167. https://bugs.webkit.org/show_bug.cgi?id=36314
  43168. Change RenderTextControl::subtreeHasChanged to only return true if the
  43169. subtree has changed since the last event was triggered.
  43170. * html/HTMLFormControlElement.cpp:
  43171. (WebCore::HTMLTextFormControlElement::insertedIntoDocument):
  43172. (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
  43173. * html/HTMLFormControlElement.h:
  43174. (WebCore::HTMLTextFormControlElement::setTextAsOfLastFormControlChangeEvent):
  43175. * html/HTMLInputElement.cpp:
  43176. (WebCore::HTMLInputElement::setChecked):
  43177. (WebCore::HTMLInputElement::setValue):
  43178. * html/HTMLTextAreaElement.cpp:
  43179. (WebCore::HTMLTextAreaElement::setValue):
  43180. (WebCore::HTMLTextAreaElement::setNonDirtyValue):
  43181. 2011-03-25 Brent Fulgham <bfulgham@webkit.org>
  43182. Reviewed by David Hyatt.
  43183. Clean up FontPlatformData structure so that a single implementation
  43184. is used across all ports. This first patch works for the Windows
  43185. build (both CG and WinCairo), and Cocoa.
  43186. * WebCore.vcproj/WebCore.vcproj:
  43187. * platform/graphics/FontPlatformData.cpp: Added.
  43188. (WebCore::FontPlatformData::FontPlatformData):
  43189. (WebCore::FontPlatformData::operator=):
  43190. * platform/graphics/FontPlatformData.h: Added.
  43191. (WebCore::toCTFontRef):
  43192. (WebCore::FontPlatformData::FontPlatformData):
  43193. (WebCore::FontPlatformData::hfont):
  43194. (WebCore::FontPlatformData::useGDI):
  43195. (WebCore::FontPlatformData::font):
  43196. (WebCore::FontPlatformData::cgFont):
  43197. (WebCore::FontPlatformData::size):
  43198. (WebCore::FontPlatformData::setSize):
  43199. (WebCore::FontPlatformData::syntheticBold):
  43200. (WebCore::FontPlatformData::syntheticOblique):
  43201. (WebCore::FontPlatformData::isColorBitmapFont):
  43202. (WebCore::FontPlatformData::orientation):
  43203. (WebCore::FontPlatformData::textOrientation):
  43204. (WebCore::FontPlatformData::widthVariant):
  43205. (WebCore::FontPlatformData::setOrientation):
  43206. (WebCore::FontPlatformData::scaledFont):
  43207. (WebCore::FontPlatformData::fontFace):
  43208. (WebCore::FontPlatformData::hash):
  43209. (WebCore::FontPlatformData::operator==):
  43210. (WebCore::FontPlatformData::isHashTableDeletedValue):
  43211. (WebCore::FontPlatformData::hashTableDeletedFontValue):
  43212. * platform/graphics/cg/FontPlatformData.h: Removed.
  43213. * platform/graphics/cocoa/FontPlatformData.h: Removed.
  43214. * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  43215. (WebCore::~FontPlatformData):
  43216. (WebCore::FontPlatformData::platformDataInit):
  43217. (WebCore::FontPlatformData::platformDataAssign):
  43218. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  43219. (WebCore::FontPlatformData::FontPlatformData):
  43220. (WebCore::FontPlatformData::~FontPlatformData):
  43221. (WebCore::FontPlatformData::platformDataInit):
  43222. (WebCore::FontPlatformData::platformDataAssign):
  43223. * platform/graphics/win/FontPlatformDataCairoWin.cpp:
  43224. (WebCore::FontPlatformData::FontPlatformData):
  43225. (WebCore::FontPlatformData::~FontPlatformData):
  43226. (WebCore::FontPlatformData::platformDataInit):
  43227. (WebCore::FontPlatformData::platformDataAssign):
  43228. * platform/graphics/win/FontPlatformDataWin.cpp:
  43229. (WebCore::FontPlatformData::FontPlatformData):
  43230. * platform/graphics/win/cairo/FontPlatformData.h: Removed.
  43231. 2011-03-25 Enrica Casucci <enrica@apple.com>
  43232. Reviewed by Oliver Hunt.
  43233. Pasteboard data's RTF data doesn't always include URLs via NSLinkAttributeName.
  43234. https://bugs.webkit.org/show_bug.cgi?id=57107
  43235. <rdar://problem/9084267>
  43236. If the selection is at the beginning of content inside an anchor tag
  43237. we move the selection start to include the anchor.
  43238. * platform/mac/PasteboardMac.mm:
  43239. (WebCore::Pasteboard::writeSelection): Modified to change the selection
  43240. start according to the new rule.
  43241. 2011-03-25 Pavel Feldman <pfeldman@chromium.org>
  43242. Reviewed by Yury Semikhatsky.
  43243. Web Inspector: refactor Network domain's frame tree API
  43244. https://bugs.webkit.org/show_bug.cgi?id=57103
  43245. * inspector/Inspector.json:
  43246. * inspector/InspectorResourceAgent.cpp:
  43247. (WebCore::buildObjectForFrameResource):
  43248. (WebCore::buildObjectForCachedResource):
  43249. (WebCore::InspectorResourceAgent::willSendRequest):
  43250. (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
  43251. (WebCore::buildObjectForFrame):
  43252. (WebCore::buildObjectForFrameTree):
  43253. (WebCore::InspectorResourceAgent::didCommitLoad):
  43254. (WebCore::InspectorResourceAgent::enable):
  43255. * inspector/front-end/NetworkManager.js:
  43256. (WebInspector.NetworkManager.prototype.requestContent):
  43257. (WebInspector.NetworkDispatcher):
  43258. (WebInspector.NetworkDispatcher.prototype.willSendRequest):
  43259. (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
  43260. (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
  43261. (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
  43262. (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
  43263. (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
  43264. (WebInspector.NetworkDispatcher.prototype._appendRedirect):
  43265. (WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
  43266. (WebInspector.NetworkDispatcher.prototype._createResource):
  43267. * inspector/front-end/ResourceTreeModel.js:
  43268. (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
  43269. (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
  43270. (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
  43271. (WebInspector.ResourceTreeModel.prototype._clearResources):
  43272. * inspector/front-end/ResourcesPanel.js:
  43273. (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
  43274. (WebInspector.ResourcesPanel.prototype.addResourceToFrame):
  43275. 2011-03-25 Dave Hyatt <hyatt@apple.com>
  43276. Reviewed by Adele Peterson.
  43277. REGRESSION(r77257): Only first page of a document is printed
  43278. https://bugs.webkit.org/show_bug.cgi?id=56958
  43279. Test: printing/page-count-layout-overflow.html
  43280. * page/FrameView.cpp:
  43281. (WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow
  43282. to the right place.
  43283. 2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
  43284. Reviewed by Andreas Kling.
  43285. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  43286. https://bugs.webkit.org/show_bug.cgi?id=57087
  43287. Use explicit conversion for string to avoid depending on the default codec
  43288. installed by the user code.
  43289. * bridge/qt/qt_pixmapruntime.cpp:
  43290. (JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
  43291. (JSC::Bindings::QtPixmapInstance::valueOf):
  43292. * platform/qt/LanguageQt.cpp:
  43293. (WebCore::platformDefaultLanguage):
  43294. * platform/qt/PasteboardQt.cpp:
  43295. (WebCore::Pasteboard::writeSelection):
  43296. * plugins/qt/PluginPackageQt.cpp:
  43297. (WebCore::initializeGtk):
  43298. * plugins/qt/PluginViewQt.cpp:
  43299. (WebCore::getPluginDisplay):
  43300. 2011-03-25 Chang Shu <cshu@webkit.org>
  43301. Reviewed by Ryosuke Niwa.
  43302. rename Node::isContentEditable and all call sites to rendererIsEditable
  43303. https://bugs.webkit.org/show_bug.cgi?id=54290
  43304. This is part of the effort to separate JS API HTMLElement isContentEditable from
  43305. internal Node::rendererIsEditable.
  43306. Code refactoring. No new tests.
  43307. * accessibility/AccessibilityRenderObject.cpp:
  43308. (WebCore::AccessibilityRenderObject::isReadOnly):
  43309. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  43310. * dom/Document.cpp:
  43311. (WebCore::acceptsEditingFocus):
  43312. * dom/Node.cpp:
  43313. (WebCore::Node::rendererIsEditable):
  43314. (WebCore::Node::shouldUseInputMethod):
  43315. (WebCore::Node::canStartSelection):
  43316. (WebCore::Node::rootEditableElement):
  43317. * dom/Node.h:
  43318. (WebCore::Node::isContentEditable):
  43319. (WebCore::Node::rendererIsEditable):
  43320. (WebCore::Node::rendererIsRichlyEditable):
  43321. * dom/Position.cpp:
  43322. (WebCore::nextRenderedEditable):
  43323. (WebCore::previousRenderedEditable):
  43324. (WebCore::Position::atEditingBoundary):
  43325. (WebCore::Position::parentEditingBoundary):
  43326. (WebCore::Position::upstream):
  43327. (WebCore::Position::downstream):
  43328. (WebCore::Position::isCandidate):
  43329. * dom/PositionIterator.cpp:
  43330. (WebCore::PositionIterator::isCandidate):
  43331. * editing/AppendNodeCommand.cpp:
  43332. (WebCore::AppendNodeCommand::AppendNodeCommand):
  43333. (WebCore::AppendNodeCommand::doApply):
  43334. (WebCore::AppendNodeCommand::doUnapply):
  43335. * editing/ApplyStyleCommand.cpp:
  43336. (WebCore::containsNonEditableRegion):
  43337. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
  43338. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
  43339. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  43340. * editing/CompositeEditCommand.cpp:
  43341. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
  43342. * editing/DeleteButtonController.cpp:
  43343. (WebCore::isDeletableElement):
  43344. (WebCore::enclosingDeletableElement):
  43345. * editing/DeleteFromTextNodeCommand.cpp:
  43346. (WebCore::DeleteFromTextNodeCommand::doApply):
  43347. (WebCore::DeleteFromTextNodeCommand::doUnapply):
  43348. * editing/DeleteSelectionCommand.cpp:
  43349. (WebCore::DeleteSelectionCommand::removeNode):
  43350. * editing/Editor.cpp:
  43351. (WebCore::Editor::canDeleteRange):
  43352. (WebCore::Editor::markMisspellingsOrBadGrammar):
  43353. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  43354. * editing/EditorCommand.cpp:
  43355. (WebCore::verticalScrollDistance):
  43356. * editing/FormatBlockCommand.cpp:
  43357. (WebCore::enclosingBlockToSplitTreeTo):
  43358. * editing/IndentOutdentCommand.cpp:
  43359. (WebCore::IndentOutdentCommand::outdentParagraph):
  43360. * editing/InsertIntoTextNodeCommand.cpp:
  43361. (WebCore::InsertIntoTextNodeCommand::doApply):
  43362. (WebCore::InsertIntoTextNodeCommand::doUnapply):
  43363. * editing/InsertNodeBeforeCommand.cpp:
  43364. (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
  43365. (WebCore::InsertNodeBeforeCommand::doApply):
  43366. (WebCore::InsertNodeBeforeCommand::doUnapply):
  43367. * editing/JoinTextNodesCommand.cpp:
  43368. (WebCore::JoinTextNodesCommand::doApply):
  43369. (WebCore::JoinTextNodesCommand::doUnapply):
  43370. * editing/MergeIdenticalElementsCommand.cpp:
  43371. (WebCore::MergeIdenticalElementsCommand::doApply):
  43372. (WebCore::MergeIdenticalElementsCommand::doUnapply):
  43373. * editing/RemoveNodeCommand.cpp:
  43374. (WebCore::RemoveNodeCommand::doApply):
  43375. (WebCore::RemoveNodeCommand::doUnapply):
  43376. * editing/ReplaceSelectionCommand.cpp:
  43377. (WebCore::ReplacementFragment::ReplacementFragment):
  43378. * editing/SelectionController.cpp:
  43379. (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  43380. (WebCore::SelectionController::setSelectionFromNone):
  43381. * editing/SplitElementCommand.cpp:
  43382. (WebCore::SplitElementCommand::executeApply):
  43383. (WebCore::SplitElementCommand::doUnapply):
  43384. * editing/SplitTextNodeCommand.cpp:
  43385. (WebCore::SplitTextNodeCommand::doApply):
  43386. (WebCore::SplitTextNodeCommand::doUnapply):
  43387. (WebCore::SplitTextNodeCommand::doReapply):
  43388. * editing/SplitTextNodeContainingElementCommand.cpp:
  43389. (WebCore::SplitTextNodeContainingElementCommand::doApply):
  43390. * editing/VisiblePosition.cpp:
  43391. (WebCore::VisiblePosition::canonicalPosition):
  43392. * editing/WrapContentsInDummySpanCommand.cpp:
  43393. (WebCore::WrapContentsInDummySpanCommand::doUnapply):
  43394. (WebCore::WrapContentsInDummySpanCommand::doReapply):
  43395. * editing/htmlediting.cpp:
  43396. (WebCore::highestEditableRoot):
  43397. (WebCore::lowestEditableAncestor):
  43398. (WebCore::isEditablePosition):
  43399. (WebCore::isRichlyEditablePosition):
  43400. (WebCore::firstEditablePositionAfterPositionInRoot):
  43401. (WebCore::extendRangeToWrappingNodes):
  43402. (WebCore::enclosingNodeWithTag):
  43403. (WebCore::enclosingNodeOfType):
  43404. (WebCore::highestEnclosingNodeOfType):
  43405. (WebCore::canMergeLists):
  43406. * editing/visible_units.cpp:
  43407. (WebCore::previousLeafWithSameEditability):
  43408. (WebCore::previousLinePosition):
  43409. (WebCore::nextLeafWithSameEditability):
  43410. (WebCore::nextLinePosition):
  43411. (WebCore::startOfParagraph):
  43412. (WebCore::endOfParagraph):
  43413. * html/HTMLAnchorElement.cpp:
  43414. (WebCore::HTMLAnchorElement::supportsFocus):
  43415. (WebCore::HTMLAnchorElement::defaultEventHandler):
  43416. (WebCore::HTMLAnchorElement::setActive):
  43417. (WebCore::HTMLAnchorElement::canStartSelection):
  43418. (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
  43419. * html/HTMLBodyElement.cpp:
  43420. (WebCore::HTMLBodyElement::supportsFocus):
  43421. * html/HTMLElement.cpp:
  43422. (WebCore::HTMLElement::supportsFocus):
  43423. (WebCore::HTMLElement::isContentEditable):
  43424. (WebCore::HTMLElement::contentEditable):
  43425. * html/HTMLElement.h:
  43426. * page/DragController.cpp:
  43427. (WebCore::DragController::operationForLoad):
  43428. (WebCore::DragController::canProcessDrag):
  43429. * page/EventHandler.cpp:
  43430. (WebCore::EventHandler::handleMouseReleaseEvent):
  43431. (WebCore::EventHandler::selectCursor):
  43432. * page/FocusController.cpp:
  43433. (WebCore::relinquishesEditingFocus):
  43434. * rendering/HitTestResult.cpp:
  43435. (WebCore::HitTestResult::isContentEditable):
  43436. * rendering/RenderBlock.cpp:
  43437. (WebCore::positionForPointRespectingEditingBoundaries):
  43438. (WebCore::RenderBlock::hasLineIfEmpty):
  43439. * rendering/RenderBlockLineLayout.cpp:
  43440. (WebCore::RenderBlock::addOverflowFromInlineChildren):
  43441. * rendering/RenderBox.cpp:
  43442. (WebCore::RenderBox::canBeProgramaticallyScrolled):
  43443. * rendering/RenderObject.cpp:
  43444. (WebCore::RenderObject::createVisiblePosition):
  43445. * rendering/RootInlineBox.cpp:
  43446. (WebCore::isEditableLeaf):
  43447. * svg/SVGAElement.cpp:
  43448. (WebCore::SVGAElement::supportsFocus):
  43449. 2011-03-25 Maciej Stachowiak <mjs@apple.com>
  43450. Reviewed by Antti Koivisto.
  43451. Crash when a wbr element is inserted inside mroot
  43452. https://bugs.webkit.org/show_bug.cgi?id=56352
  43453. Test: mathml/wbr-in-mroot-crash.html
  43454. * rendering/mathml/RenderMathMLRoot.cpp:
  43455. (WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first
  43456. child, instead of just assuming.
  43457. 2011-03-25 Vsevolod Vlasov <vsevik@chromium.org>
  43458. Reviewed by Pavel Feldman.
  43459. XML Viewer: extensions can't render original XML
  43460. https://bugs.webkit.org/show_bug.cgi?id=56263
  43461. Added source xml to transformed document, renamed onload function.
  43462. * xml/XMLTreeViewer.cpp:
  43463. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  43464. * xml/XMLViewer.xsl:
  43465. 2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
  43466. Reviewed by Andreas Kling.
  43467. [Qt] Get rid of the invalid string conversion with ::fromAscii()
  43468. https://bugs.webkit.org/show_bug.cgi?id=57102
  43469. Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code.
  43470. * platform/network/qt/QNetworkReplyHandler.cpp:
  43471. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  43472. * platform/qt/CookieJarQt.cpp:
  43473. (WebCore::cookies):
  43474. (WebCore::cookieRequestHeaderFieldValue):
  43475. 2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>
  43476. Unreviewed, rolling out r81953.
  43477. http://trac.webkit.org/changeset/81953
  43478. https://bugs.webkit.org/show_bug.cgi?id=57096
  43479. "inspector test breakage: part 2/2" (Requested by apavlov on
  43480. #webkit).
  43481. * inspector/Inspector.json:
  43482. * inspector/InspectorCSSAgent.cpp:
  43483. (WebCore::InspectorCSSAgent::getAllStyles):
  43484. * inspector/InspectorCSSAgent.h:
  43485. * inspector/InspectorStyleSheet.cpp:
  43486. (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  43487. * inspector/InspectorStyleSheet.h:
  43488. * inspector/front-end/AuditRules.js:
  43489. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
  43490. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  43491. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  43492. * inspector/front-end/CSSStyleModel.js:
  43493. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  43494. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  43495. (WebInspector.CSSStyleModel.prototype._onRevert):
  43496. (WebInspector.CSSStyleSheet):
  43497. (WebInspector.CSSStyleSheet.prototype.setText):
  43498. 2011-03-15 Alexander Pavlov <apavlov@chromium.org>
  43499. Reviewed by Pavel Feldman.
  43500. Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
  43501. https://bugs.webkit.org/show_bug.cgi?id=56310
  43502. Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
  43503. "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
  43504. by CSSAgent.getStyleSheet() anymore.
  43505. Test: inspector/styles/get-set-stylesheet-text.html
  43506. * inspector/Inspector.json:
  43507. * inspector/InspectorCSSAgent.cpp:
  43508. (WebCore::InspectorCSSAgent::getAllStyleSheets):
  43509. * inspector/InspectorCSSAgent.h:
  43510. * inspector/InspectorStyleSheet.cpp:
  43511. (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  43512. (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  43513. * inspector/InspectorStyleSheet.h:
  43514. * inspector/front-end/AuditRules.js:
  43515. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
  43516. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  43517. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  43518. * inspector/front-end/CSSStyleModel.js:
  43519. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  43520. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  43521. (WebInspector.CSSStyleModel.prototype._onRevert):
  43522. (WebInspector.CSSStyleSheet):
  43523. (WebInspector.CSSStyleSheet.prototype.setText):
  43524. 2011-03-25 Pavel Feldman <pfeldman@chromium.org>
  43525. Reviewed by Yury Semikhatsky.
  43526. Web Inspector: extension server should not convert all resources to HAR when there are no extensions.
  43527. https://bugs.webkit.org/show_bug.cgi?id=57044
  43528. * inspector/front-end/ExtensionServer.js:
  43529. (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
  43530. (WebInspector.ExtensionServer.prototype._hasSubscribers):
  43531. 2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>
  43532. Reviewed by Nikolas Zimmermann.
  43533. SVG <use> element performance improvement
  43534. https://bugs.webkit.org/show_bug.cgi?id=57077
  43535. SVG <use> element was expanding nesting <use> and <symbol> elements
  43536. in an inefficient way. After it expanded an <use> or a <symbol>
  43537. element it would restart expanding from the shadow tree root.
  43538. This behavior was leading about 160 millions of calls to
  43539. expandUseElementInShadowTree or expandSymbolElementInShadowTree for
  43540. a single shadow tree which is illustrated by
  43541. http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg.
  43542. But the effective calls, which really expand <use> or <symbol>
  43543. elements, were about 5200; others were passing-by calls, which are
  43544. recursively down to the children.
  43545. This patch is altering the expanding path to reduce the passing-by
  43546. calls. It will expand elements in sibling chain where there is an
  43547. effective call, because the effective call replaces element which is
  43548. expanded and the replacement results lose of the sibling chain of
  43549. the replaced on the upper recursion stack. With this patch the
  43550. passing-by calls are reduced from about 160 millions to about 30
  43551. thousands.
  43552. No functionality change, no new tests.
  43553. * svg/SVGUseElement.cpp:
  43554. (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  43555. (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
  43556. * svg/SVGUseElement.h:
  43557. 2011-03-25 Dominic Cooney <dominicc@google.com>
  43558. Reviewed by Kent Tamura.
  43559. Makes keygen support autofocus attribute.
  43560. https://bugs.webkit.org/show_bug.cgi?id=57091
  43561. Test: fast/forms/autofocus-keygen.html
  43562. * html/HTMLFormControlElement.cpp:
  43563. (WebCore::HTMLFormControlElement::attach):
  43564. 2011-03-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  43565. Reviewed by Antonio Gomes.
  43566. [EFL] Add sound / mute button to MediaControl UI
  43567. https://bugs.webkit.org/show_bug.cgi?id=56726
  43568. Add sound / mute button to MediaControl UI.
  43569. * platform/efl/RenderThemeEfl.cpp:
  43570. (WebCore::RenderThemeEfl::edjeGroupFromFormType):
  43571. (WebCore::RenderThemeEfl::emitMediaButtonSignal):
  43572. (WebCore::RenderThemeEfl::paintMediaMuteButton):
  43573. * platform/efl/RenderThemeEfl.h:
  43574. 2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>
  43575. Reviewed by Darin Adler.
  43576. Introduce WTF HexNumber.h
  43577. https://bugs.webkit.org/show_bug.cgi?id=56099
  43578. Introduce a set of functions that ease converting from a bye or a number to a hex string,
  43579. replacing several of these conversions and String::format("%x") usages all over WebCore.
  43580. * ForwardingHeaders/wtf/HexNumber.h: Added.
  43581. * css/CSSOMUtils.cpp:
  43582. (WebCore::serializeCharacterAsCodePoint):
  43583. * css/CSSParser.cpp:
  43584. (WebCore::quoteCSSString):
  43585. * inspector/InspectorResourceAgent.cpp:
  43586. (WebCore::createReadableStringFromBinary):
  43587. * platform/FileSystem.cpp:
  43588. (WebCore::encodeForFileName):
  43589. * platform/KURL.cpp:
  43590. (WebCore::appendEscapedChar):
  43591. * platform/UUID.cpp:
  43592. (WebCore::createCanonicalUUIDString):
  43593. * platform/graphics/Color.cpp:
  43594. (WebCore::Color::serialized):
  43595. * platform/network/FormDataBuilder.cpp:
  43596. (WebCore::FormDataBuilder::encodeStringAsFormData):
  43597. * rendering/RenderTreeAsText.cpp:
  43598. (WebCore::quoteAndEscapeNonPrintables):
  43599. 2011-03-24 Stephanie Lewis <slewis@apple.com>
  43600. Reviewed by Geoff Garen.
  43601. <rdar://problem/9146716> REGRESSION: ~10 MB increase in memory under CachedScripts
  43602. Add back a call to destroy decoded data after access. Keep the SourceProviderCache
  43603. around as long as their are still clients to use it.
  43604. No new tests because there is no change in behavior. Current tests pass.
  43605. * loader/cache/CachedScript.cpp:
  43606. (WebCore::CachedScript::script):
  43607. (WebCore::CachedScript::destroyDecodedData):
  43608. 2011-03-24 Stephanie Lewis <slewis@apple.com>
  43609. Reviewed by Geoff Garen.
  43610. https://bugs.webkit.org/show_bug.cgi?id=57073
  43611. Rework the AtomicHTMLConstructor to reserve space for attributes based on the size of the attribute list.
  43612. Saves 1.5 MB on Membuster.
  43613. No new tests because there was no change in behavior. Current tests pass.
  43614. * html/parser/HTMLToken.h:
  43615. (WebCore::AtomicHTMLToken::AtomicHTMLToken):
  43616. (WebCore::AtomicHTMLToken::initializeAttributes):
  43617. 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
  43618. Unreviewed, rolling out r81916 and r81917.
  43619. http://trac.webkit.org/changeset/81916
  43620. http://trac.webkit.org/changeset/81917
  43621. https://bugs.webkit.org/show_bug.cgi?id=57071
  43622. broke a test on platforms that do not have QuickTime installed
  43623. (Requested by estes on #webkit).
  43624. * html/HTMLEmbedElement.cpp:
  43625. (WebCore::HTMLEmbedElement::HTMLEmbedElement):
  43626. * html/HTMLObjectElement.cpp:
  43627. (WebCore::HTMLObjectElement::HTMLObjectElement):
  43628. (WebCore::HTMLObjectElement::parametersForPlugin):
  43629. * html/HTMLPlugInImageElement.cpp:
  43630. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
  43631. (WebCore::HTMLPlugInImageElement::isImageType):
  43632. (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
  43633. * html/HTMLPlugInImageElement.h:
  43634. * loader/EmptyClients.h:
  43635. (WebCore::EmptyFrameLoaderClient::objectContentType):
  43636. * loader/FrameLoader.cpp:
  43637. (WebCore::FrameLoader::defaultObjectContentType):
  43638. * loader/FrameLoader.h:
  43639. * loader/FrameLoaderClient.h:
  43640. * loader/SubframeLoader.cpp:
  43641. (WebCore::SubframeLoader::resourceWillUsePlugin):
  43642. (WebCore::SubframeLoader::requestObject):
  43643. (WebCore::SubframeLoader::shouldUsePlugin):
  43644. * loader/SubframeLoader.h:
  43645. 2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
  43646. Reviewed by Darin Adler.
  43647. Eliminate Node::dispatchGenericEvent.
  43648. https://bugs.webkit.org/show_bug.cgi?id=57045
  43649. No functional change, covered by existing tests.
  43650. * dom/Node.cpp:
  43651. (WebCore::Node::dispatchEvent): Combined with the body of dispatchGenericEvent,
  43652. removed unnecessary extra refs and a stale comment.
  43653. * dom/Node.h:
  43654. * page/DOMWindow.cpp:
  43655. (WebCore::DOMWindow::dispatchLoadEvent): Changed to use dispatchEvent.
  43656. * svg/SVGElement.cpp:
  43657. (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
  43658. * svg/SVGElementInstance.cpp:
  43659. (WebCore::SVGElementInstance::dispatchEvent): Ditto. The code here still
  43660. works thanks to SVG-aware retargeting in Node.
  43661. 2011-03-24 Chris Rogers <crogers@google.com>
  43662. Reviewed by Kenneth Russell.
  43663. web audio: Properly sample-rate convert audio assets in chromium port
  43664. https://bugs.webkit.org/show_bug.cgi?id=56980
  43665. No new tests since audio API is not yet implemented.
  43666. * WebCore.gypi:
  43667. * platform/audio/AudioBus.cpp:
  43668. (WebCore::AudioBus::createBySampleRateConverting):
  43669. (WebCore::AudioBus::createByMixingToMono):
  43670. * platform/audio/AudioBus.h:
  43671. * platform/audio/HRTFKernel.cpp:
  43672. (WebCore::extractAverageGroupDelay):
  43673. (WebCore::HRTFKernel::HRTFKernel):
  43674. * platform/audio/SincResampler.cpp:
  43675. * platform/audio/chromium/AudioBusChromium.cpp:
  43676. (WebCore::AudioBus::loadPlatformResource):
  43677. (WebCore::createBusFromInMemoryAudioFile):
  43678. 2011-03-24 Rik Cabanier <cabanier@adobe.com>
  43679. Reviewed by David Hyatt.
  43680. REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
  43681. https://bugs.webkit.org/show_bug.cgi?id=56829
  43682. Test: fast/css/percentage-non-integer.html
  43683. * platform/Length.h:
  43684. (WebCore::Length::calcValue):
  43685. (WebCore::Length::calcMinValue):
  43686. (WebCore::Length::calcFloatValue):
  43687. 2011-03-24 Mihai Parparita <mihaip@chromium.org>
  43688. Reviewed by James Robinson.
  43689. [Chromium] Vertical Japanese text is not displayed on Snow Leopard
  43690. https://bugs.webkit.org/show_bug.cgi?id=56962
  43691. Make Snow Leopard check added by r80740 into a runtime check for
  43692. Chromium, since it uses the same binary on both Leopard and Snow Leopard.
  43693. * platform/graphics/mac/FontMac.mm:
  43694. (WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
  43695. (WebCore::showGlyphsWithAdvances):
  43696. 2011-03-24 Brady Eidson <beidson@apple.com>
  43697. Reviewed by Sam Weinig.
  43698. https://bugs.webkit.org/show_bug.cgi?id=57058
  43699. Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation
  43700. * loader/icon/IconDatabase.cpp:
  43701. (WebCore::IconDatabase::synchronousLoadDecisionForIconURL): Only add the DocumentLoader to the set if it's non-zero.
  43702. (WebCore::IconDatabase::IconDatabase): Add more logging.
  43703. (WebCore::IconDatabase::performURLImport): Dispatch the "didFinishURLImport" client callback using the following 3 methods.
  43704. (WebCore::FinishedURLImport::FinishedURLImport):
  43705. (WebCore::FinishedURLImport::performWork):
  43706. (WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):
  43707. * loader/icon/IconDatabase.h:
  43708. (WebCore::IconDatabase::create): Expose a PassOwnPtr<> creator.
  43709. * WebCore.exp.in:
  43710. 2011-03-23 Jer Noble <jer.noble@apple.com>
  43711. Reviewed by Maciej Stachowiak.
  43712. Application Cache should save audio/ and video/ mime types as flat files
  43713. https://bugs.webkit.org/show_bug.cgi?id=53784
  43714. <rdar://problem/8932473>
  43715. No new tests.
  43716. ApplicationCacheResource::create() now takes an additional "path" parameter. To facilitate
  43717. extracting this path information, two functions in ApplicationCacheHost have been made public.
  43718. * loader/appcache/ApplicationCacheGroup.cpp:
  43719. (WebCore::ApplicationCacheGroup::didReceiveResponse): Pass along new "path" parameter.
  43720. (WebCore::ApplicationCacheGroup::didFail): Ditto.
  43721. * loader/appcache/ApplicationCacheHost.h:
  43722. (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Made public.
  43723. (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource): Made public.
  43724. * loader/appcache/ApplicationCacheResource.cpp:
  43725. (WebCore::ApplicationCacheResource::ApplicationCacheResource): Add new "path" parameter.
  43726. * loader/appcache/ApplicationCacheResource.h:
  43727. (WebCore::ApplicationCacheResource::create): Ditto.
  43728. (WebCore::ApplicationCacheResource::path): New accessor.
  43729. 2011-03-24 Andy Estes <aestes@apple.com>
  43730. Reviewed by Darin Adler.
  43731. REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
  43732. https://bugs.webkit.org/show_bug.cgi?id=49016
  43733. AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
  43734. QuickTime plug-in in web pages. r70748 removed our mapping of classids
  43735. to MIME types, which causes WebKit to fall back from the object to the
  43736. embed tag when QuickTime is embedded by this script. The script emits
  43737. the following embed tag to embed a QuickTime movie with a poster frame:
  43738. <embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">
  43739. The expectation is that a QuickTime plug-in is instantiated to display the
  43740. poster frame, since QuickTime registers for many common image MIME
  43741. types. This is how Gecko behaves for embed. However, WebKit prefers to
  43742. use its native image rendering for image embeds, in which case no movie
  43743. is played when the poster frame is clicked.
  43744. Fix this by changing embed to check for a plug-in that can handle the
  43745. image type before rendering the image natively. This matches Gecko.
  43746. Test: fast/images/embed-image-plugins-disabled.html
  43747. * html/HTMLObjectElement.cpp:
  43748. (WebCore::HTMLObjectElement::parametersForPlugin):
  43749. * html/HTMLPlugInImageElement.cpp:
  43750. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
  43751. (WebCore::HTMLPlugInImageElement::isImageType):
  43752. (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
  43753. * html/HTMLPlugInImageElement.h:
  43754. (WebCore::HTMLPlugInImageElement::preferPluginsForImages):
  43755. * loader/EmptyClients.h:
  43756. (WebCore::EmptyFrameLoaderClient::objectContentType):
  43757. * loader/FrameLoader.cpp:
  43758. (WebCore::FrameLoader::defaultObjectContentType):
  43759. * loader/FrameLoader.h:
  43760. * loader/FrameLoaderClient.h:
  43761. * loader/SubframeLoader.cpp:
  43762. (WebCore::SubframeLoader::resourceWillUsePlugin):
  43763. (WebCore::SubframeLoader::requestPlugin):
  43764. (WebCore::SubframeLoader::requestObject):
  43765. (WebCore::SubframeLoader::shouldUsePlugin):
  43766. * loader/SubframeLoader.h:
  43767. 2011-03-24 Mike Reed <reed@google.com>
  43768. Reviewed by James Robinson.
  43769. Move lifetime management of grContext from a global to being
  43770. per-SharedGraphicsContext3D, which correctly is 1:1 with the
  43771. underlying opengl context.
  43772. https://bugs.webkit.org/show_bug.cgi?id=54330
  43773. No new tests. Existing <canvas> tests exercise this:
  43774. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  43775. (WebCore::DrawingBuffer::DrawingBuffer):
  43776. (WebCore::DrawingBuffer::~DrawingBuffer):
  43777. (WebCore::DrawingBuffer::publishToPlatformLayer):
  43778. (WebCore::DrawingBuffer::setGrContext):
  43779. * platform/graphics/gpu/DrawingBuffer.h:
  43780. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  43781. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  43782. (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
  43783. (WebCore::SharedGraphicsContext3D::getGrContext):
  43784. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  43785. * platform/graphics/skia/PlatformContextSkia.cpp:
  43786. (WebCore::PlatformContextSkia::~PlatformContextSkia):
  43787. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  43788. 2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
  43789. Reviewed by Darin Adler.
  43790. Untangle dependency between event ancestor chain computation and InspectorDOMAgent.
  43791. https://bugs.webkit.org/show_bug.cgi?id=57050
  43792. Inspector's list of event listeners does not need to invoke Node::getEventListeners,
  43793. because it simply wants to collect all ancestors and never uses EventContext bits.
  43794. No functional change, covered by existing tests.
  43795. * dom/Node.cpp:
  43796. (WebCore::getEventAncestors): Converted into a static function.
  43797. (WebCore::Node::dispatchGenericEvent): Changed to pass node to getEventAncestors.
  43798. * dom/Node.h: Removed decl, moved EventDispatchBehavior enum inside.
  43799. * inspector/InspectorDOMAgent.cpp:
  43800. (WebCore::InspectorDOMAgent::getEventListenersForNode): Replaced the call
  43801. to getEventAncestors with a simple ancestor traversal loop.
  43802. 2011-03-24 Adam Klein <adamk@chromium.org>
  43803. Reviewed by David Levin.
  43804. [fileapi] Make FileError and FileException accessible from WorkerContext
  43805. https://bugs.webkit.org/show_bug.cgi?id=57041
  43806. * workers/WorkerContext.idl:
  43807. 2011-03-24 Sam Weinig <sam@webkit.org>
  43808. Reviewed by Anders Carlsson.
  43809. Remove legacy version of findPlainText.
  43810. https://bugs.webkit.org/show_bug.cgi?id=57056
  43811. * editing/TextIterator.cpp:
  43812. * editing/TextIterator.h:
  43813. Remove legacy overload of findPlainText that doesn't
  43814. take an options parameter.
  43815. 2011-03-24 Geoffrey Garen <ggaren@apple.com>
  43816. Reviewed by Oliver Hunt.
  43817. Ensure that all compilation takes place within a dynamic global object scope
  43818. https://bugs.webkit.org/show_bug.cgi?id=57054
  43819. * bindings/js/JSErrorHandler.cpp:
  43820. (WebCore::JSErrorHandler::handleEvent):
  43821. * bindings/js/JSEventListener.cpp:
  43822. (WebCore::JSEventListener::handleEvent): Updated for signature change.
  43823. 2011-03-24 John Bauman <jbauman@chromium.org>
  43824. Reviewed by Kenneth Russell.
  43825. preserveDrawingBuffer=true is ignored
  43826. https://bugs.webkit.org/show_bug.cgi?id=56987
  43827. Add code to the V8 and JSC bindings to support grabbing the value of
  43828. preserveDrawingBuffer from the input context attributes. Also, in
  43829. WebGLRenderingContext use the WebGLContextAttributes that were input
  43830. directly, not those from the GraphicsContext3D which could have been
  43831. changed.
  43832. No new tests, as this can't be tested with DRT. However, this works
  43833. when tested manually.
  43834. * bindings/js/JSHTMLCanvasElementCustom.cpp:
  43835. (WebCore::JSHTMLCanvasElement::getContext):
  43836. * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  43837. (WebCore::V8HTMLCanvasElement::getContextCallback):
  43838. * html/canvas/WebGLRenderingContext.cpp:
  43839. (WebCore::WebGLRenderingContext::clearIfComposited):
  43840. (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
  43841. 2011-03-24 Enrica Casucci <enrica@apple.com>
  43842. Reviewed by Alexey Proskuryakov.
  43843. WebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
  43844. https://bugs.webkit.org/show_bug.cgi?id=56975
  43845. <rdar://problem/8915066>
  43846. Adding support in WebCore to implement readSelectionFromPasteboard
  43847. to support Mac OS X services from WebKit2.
  43848. * WebCore.exp.in:
  43849. * editing/Editor.h:
  43850. * editing/mac/EditorMac.mm:
  43851. (WebCore::Editor::readSelectionFromPasteboard): Added entry point
  43852. to call the paste functions with the specified pasteboard.
  43853. 2011-03-24 Vsevolod Vlasov <vsevik@chromium.org>
  43854. Reviewed by Pavel Feldman.
  43855. Web Inspector: Inspector does not show correct transfer size for synchronous requests
  43856. https://bugs.webkit.org/show_bug.cgi?id=56951
  43857. Fixed transfer size for synchronous load.
  43858. Test: http/tests/inspector/network/network-size-sync.html
  43859. * loader/FrameLoader.cpp:
  43860. (WebCore::FrameLoader::willLoadMediaElementURL):
  43861. (WebCore::FrameLoader::commitProvisionalLoad):
  43862. (WebCore::FrameLoader::loadResourceSynchronously):
  43863. (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  43864. * loader/ResourceLoadNotifier.cpp:
  43865. (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  43866. * loader/ResourceLoadNotifier.h:
  43867. 2011-03-24 Brady Eidson <beidson@apple.com>
  43868. Reviewed by Adam Roben.
  43869. https://bugs.webkit.org/show_bug.cgi?id=57030
  43870. REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's
  43871. web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message
  43872. The callback objects had some bogus ASSERTs and missed a relevant null check. If a callback was waiting on
  43873. a message back from the UIProcess, but was invalidated from within the WebProcess in the meantime, it's
  43874. perfectly valid to attempt to performCallback() after the callback function pointer has been cleared.
  43875. * loader/icon/IconDatabaseBase.h:
  43876. (WebCore::EnumCallback::performCallback):
  43877. (WebCore::EnumCallback::invalidate):
  43878. (WebCore::EnumCallback::EnumCallback):
  43879. (WebCore::ObjectCallback::performCallback):
  43880. (WebCore::ObjectCallback::invalidate):
  43881. (WebCore::ObjectCallback::ObjectCallback):
  43882. 2011-03-24 Sam Weinig <sam@webkit.org>
  43883. Reviewed by Darin Adler.
  43884. Dictionary text extraction is not correctly detecting word boundaries on bing.com
  43885. <rdar://problem/9078569>
  43886. https://bugs.webkit.org/show_bug.cgi?id=56995
  43887. * WebCore.exp.in:
  43888. Add some editing related exports needed by WebKit2.
  43889. 2011-03-24 Andy Estes <aestes@apple.com>
  43890. Reviewed by Eric Seidel.
  43891. REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
  43892. https://bugs.webkit.org/show_bug.cgi?id=56836
  43893. During fragment parsing, HTMLConstructionSite holds a reference to the
  43894. fragment context's closest form ancestor. If a misnested form end tag is
  43895. then encountered as the first node of the fragment, we will check to see
  43896. if a corresponding form start tag is in scope even though no such tag
  43897. exists. This led to isScope() walking the HTMLElementStack all the way
  43898. to the root DocumentFragment and attempting to cast it to Element*.
  43899. Fix this by ensuring that the inScope() family of functions operate in
  43900. terms of ContainerNodes to account for the fragment case.
  43901. Test: fast/parser/fragment-closest-form-ancestor.html
  43902. * html/parser/HTMLElementStack.cpp:
  43903. (WebCore::HTMLNames::isRootNode):
  43904. (WebCore::HTMLNames::isScopeMarker):
  43905. (WebCore::HTMLNames::isTableScopeMarker):
  43906. (WebCore::HTMLNames::isTableBodyScopeMarker):
  43907. (WebCore::HTMLNames::isTableRowScopeMarker):
  43908. (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
  43909. (WebCore::HTMLElementStack::inScope):
  43910. 2011-03-24 Enrica Casucci <enrica@apple.com>
  43911. Reviewed by Darin Adler.
  43912. Repeated copy and paste-in-place operation results in increasingly verbose HTML.
  43913. <rdar://problem/8690506>
  43914. https://bugs.webkit.org/show_bug.cgi?id=56874
  43915. When we calculate the style to apply at the insertion point we compare the initial
  43916. style at the insertion point against the style calculated at the span we wrap the
  43917. copied markup fragment with. We could end up with a series of unnecessary spans
  43918. to remove the initial style that simply grow our markup.
  43919. The consists in moving the insertion point outside any inline element that could
  43920. affect the fragment being inserted when we are not pasting and matching the style.
  43921. Test: editing/pasteboard/paste-text-with-style.html
  43922. * editing/ReplaceSelectionCommand.cpp:
  43923. (WebCore::isInlineNodeWithStyle): Added.
  43924. (WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
  43925. point according to the new rules.
  43926. 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
  43927. Reviewed by Kenneth Rohde Christiansen.
  43928. [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
  43929. https://bugs.webkit.org/show_bug.cgi?id=40884
  43930. The software fallback is now only needed for corner cases like a manual rendering
  43931. of the page to QImage.
  43932. Keeping the image with the last pixel values is no longer needed. Removing it reduce the
  43933. performance for real-time rendering on software surface, but this case should no longer be
  43934. supported.
  43935. The conversion from OpenGL color space and coordinates is done manually for performance. This
  43936. also fix the bug of the inverted X axis due to the transformation.
  43937. The tests and benchmarks are done through Qt API tests.
  43938. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  43939. (WebCore::swapBgrToRgb):
  43940. (WebCore::GraphicsContext3DInternal::paint):
  43941. (WebCore::GraphicsContext3D::reshape):
  43942. 2011-03-24 Nat Duca <nduca@chromium.org>
  43943. Reviewed by James Robinson.
  43944. [chromium] Remove bool that forces compositor HUD to always be enabled
  43945. https://bugs.webkit.org/show_bug.cgi?id=57034
  43946. * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
  43947. (WebCore::CCHeadsUpDisplay::enabled):
  43948. 2011-03-24 Nat Duca <nduca@chromium.org>
  43949. Reviewed by Kenneth Russell.
  43950. [chromium] Add traceEvents to compositor
  43951. https://bugs.webkit.org/show_bug.cgi?id=56965
  43952. * WebCore.gypi:
  43953. * platform/chromium/TraceEvent.h: Added.
  43954. (WebCore::internal::ScopeTracer::ScopeTracer):
  43955. (WebCore::internal::ScopeTracer::~ScopeTracer):
  43956. * platform/graphics/chromium/LayerRendererChromium.cpp:
  43957. (WebCore::LayerRendererChromium::updateRootLayerContents):
  43958. (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
  43959. (WebCore::LayerRendererChromium::updateLayers):
  43960. (WebCore::LayerRendererChromium::drawLayers):
  43961. (WebCore::LayerRendererChromium::finish):
  43962. (WebCore::LayerRendererChromium::present):
  43963. * platform/graphics/chromium/LayerTilerChromium.cpp:
  43964. (WebCore::LayerTilerChromium::update):
  43965. 2011-03-24 Pavel Feldman <pfeldman@chromium.org>
  43966. Reviewed by Yury Semikhatsky.
  43967. Web Inspector: render XHRs matching JSON regex as JSON.
  43968. https://bugs.webkit.org/show_bug.cgi?id=57035
  43969. * English.lproj/localizedStrings.js:
  43970. * WebCore.gypi:
  43971. * WebCore.vcproj/WebCore.vcproj:
  43972. * inspector/front-end/NetworkItemView.js:
  43973. (WebInspector.NetworkItemView):
  43974. * inspector/front-end/RemoteObject.js:
  43975. (WebInspector.LocalJSONObject.prototype.get description.switch.case):
  43976. (WebInspector.LocalJSONObject.prototype.get description):
  43977. (WebInspector.LocalJSONObject.prototype._concatenate):
  43978. (WebInspector.LocalJSONObject.prototype.getProperties):
  43979. (WebInspector.LocalJSONObject.prototype._children):
  43980. * inspector/front-end/ResourceJSONView.js: Added.
  43981. (WebInspector.ResourceJSONView):
  43982. (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.hasContent):
  43983. (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.show):
  43984. (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
  43985. * inspector/front-end/WebKit.qrc:
  43986. * inspector/front-end/inspector.css:
  43987. (.resource-view.json):
  43988. * inspector/front-end/inspector.html:
  43989. 2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
  43990. Reviewed by Darin Adler.
  43991. Move media controls subtree creation into one method.
  43992. https://bugs.webkit.org/show_bug.cgi?id=56969
  43993. Mechanical move, no changes in functionality.
  43994. The purpose of this patch is to align existing code closer with its
  43995. future version, when MediaControls is an element whose tree is created
  43996. at the instantiation.
  43997. * html/shadow/MediaControls.cpp:
  43998. (WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place.
  43999. (WebCore::MediaControls::update): Replaced methods with one call.
  44000. * html/shadow/MediaControls.h: Updated decls.
  44001. * rendering/MediaControlElements.cpp:
  44002. (WebCore::MediaControlTimelineElement::create): Moved setting of attributes here.
  44003. (WebCore::MediaControlVolumeSliderElement::create): Ditto.
  44004. 2011-03-24 Steve Falkenburg <sfalken@apple.com>
  44005. Reviewed by Darin Adler.
  44006. Use proper string method to generate webloc string.
  44007. https://bugs.webkit.org/show_bug.cgi?id=57028
  44008. <rdar://problem/9181955>
  44009. * platform/win/ClipboardUtilitiesWin.cpp:
  44010. (WebCore::getWebLocData):
  44011. 2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>
  44012. Reviewed by Alexey Proskuryakov.
  44013. https://bugs.webkit.org/show_bug.cgi?id=32821
  44014. Fix conditionals which had an int for one case and a pointer for another.
  44015. Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198
  44016. No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
  44017. * css/CSSComputedStyleDeclaration.cpp:
  44018. (WebCore::CSSComputedStyleDeclaration::valueForShadow):
  44019. 2011-03-24 Pavel Podivilov <podivilov@chromium.org>
  44020. Reviewed by Yury Semikhatsky.
  44021. Web Inspector: provide live edit callback to source frame delegate.
  44022. https://bugs.webkit.org/show_bug.cgi?id=57003
  44023. * inspector/front-end/DebuggerModel.js:
  44024. (WebInspector.DebuggerModel.prototype.editScriptSource):
  44025. (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  44026. * inspector/front-end/DebuggerPresentationModel.js:
  44027. (WebInspector.DebuggerPresentationModel):
  44028. (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
  44029. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
  44030. (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
  44031. (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
  44032. (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
  44033. * inspector/front-end/ScriptsPanel.js:
  44034. (WebInspector.ScriptsPanel.prototype._createSourceFrame):
  44035. (WebInspector.SourceFrameDelegateForScriptsPanel):
  44036. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
  44037. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  44038. 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
  44039. Reviewed by Andreas Kling.
  44040. Regression: WebKit does not build with Python 3 following 56807
  44041. https://bugs.webkit.org/show_bug.cgi?id=56923
  44042. The module string does not have the function replace in Python 3. The str.replace function
  44043. can do the same operation in this case and works with the versions 2 and 3.
  44044. * inspector/generate-inspector-idl:
  44045. 2011-03-24 Pavel Feldman <pfeldman@chromium.org>
  44046. Reviewed by Yury Semikhatsky.
  44047. Web Inspector: brush up Network agent API.
  44048. https://bugs.webkit.org/show_bug.cgi?id=57001
  44049. * inspector/Inspector.json:
  44050. * inspector/InspectorInstrumentation.cpp:
  44051. (WebCore::InspectorInstrumentation::willSendRequestImpl):
  44052. * inspector/InspectorInstrumentation.h:
  44053. (WebCore::InspectorInstrumentation::willSendRequest):
  44054. * inspector/InspectorResourceAgent.cpp:
  44055. (WebCore::buildObjectForResourceRequest):
  44056. (WebCore::buildObjectForResourceResponse):
  44057. (WebCore::buildObjectForCachedResource):
  44058. (WebCore::InspectorResourceAgent::willSendRequest):
  44059. (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
  44060. (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
  44061. (WebCore::InspectorResourceAgent::setExtraHeaders):
  44062. * inspector/InspectorResourceAgent.h:
  44063. * inspector/TimelineRecordFactory.cpp:
  44064. (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
  44065. * inspector/front-end/NetworkManager.js:
  44066. (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
  44067. (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  44068. (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
  44069. (WebInspector.NetworkDispatcher.prototype.willSendRequest):
  44070. (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
  44071. (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
  44072. * inspector/front-end/Resource.js:
  44073. * inspector/front-end/TimelinePanel.js:
  44074. (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
  44075. * loader/ResourceLoadNotifier.cpp:
  44076. (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
  44077. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
  44078. * loader/appcache/ApplicationCacheGroup.cpp:
  44079. (WebCore::ApplicationCacheGroup::createResourceHandle):
  44080. 2011-03-11 Steve Block <steveblock@google.com>
  44081. Reviewed by Jeremy Orlow.
  44082. JNIType is not specific to JNI so should be renamed
  44083. https://bugs.webkit.org/show_bug.cgi?id=56197
  44084. This patch renames JNIType to JavaType, renames the values of
  44085. the enum, and moves it out of JNIUtility.h to its own file.
  44086. Also renames the corresponding JavaField and JavaMethod getters.
  44087. No new tests, refactoring only.
  44088. * GNUmakefile.am:
  44089. * WebCore.gypi:
  44090. * WebCore.xcodeproj/project.pbxproj:
  44091. * bridge/jni/JNIUtility.cpp:
  44092. (JSC::Bindings::javaTypeFromClassName):
  44093. (JSC::Bindings::signatureFromJavaType):
  44094. (JSC::Bindings::javaTypeFromPrimitiveType):
  44095. (JSC::Bindings::getJNIField):
  44096. (JSC::Bindings::callJNIMethod):
  44097. * bridge/jni/JNIUtility.h:
  44098. * bridge/jni/JavaMethod.cpp:
  44099. (JavaMethod::JavaMethod):
  44100. (JavaMethod::signature):
  44101. * bridge/jni/JavaMethod.h:
  44102. (JSC::Bindings::JavaMethod::returnTypeClassName):
  44103. (JSC::Bindings::JavaMethod::returnType):
  44104. * bridge/jni/JavaType.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
  44105. * bridge/jni/jni_jsobject.mm:
  44106. (JavaJSObject::toString):
  44107. * bridge/jni/jni_objc.mm:
  44108. (JSC::Bindings::dispatchJNICall):
  44109. * bridge/jni/jsc/JNIUtilityPrivate.cpp:
  44110. (JSC::Bindings::convertArrayInstanceToJavaArray):
  44111. (JSC::Bindings::convertValueToJValue):
  44112. * bridge/jni/jsc/JNIUtilityPrivate.h:
  44113. * bridge/jni/jsc/JavaArrayJSC.cpp:
  44114. (JavaArray::setValueAt):
  44115. (JavaArray::valueAt):
  44116. * bridge/jni/jsc/JavaClassJSC.cpp:
  44117. * bridge/jni/jsc/JavaFieldJSC.cpp:
  44118. (JavaField::JavaField):
  44119. (JavaField::dispatchValueFromInstance):
  44120. (JavaField::valueFromInstance):
  44121. (JavaField::dispatchSetValueToInstance):
  44122. (JavaField::setValueToInstance):
  44123. * bridge/jni/jsc/JavaFieldJSC.h:
  44124. (JSC::Bindings::JavaField::typeClassName):
  44125. (JSC::Bindings::JavaField::type):
  44126. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  44127. (JavaInstance::invokeMethod):
  44128. * bridge/jni/v8/JNIUtilityPrivate.cpp:
  44129. (JSC::Bindings::convertNPVariantToJValue):
  44130. (JSC::Bindings::convertJValueToNPVariant):
  44131. * bridge/jni/v8/JNIUtilityPrivate.h:
  44132. * bridge/jni/v8/JavaFieldV8.cpp:
  44133. (JavaField::JavaField):
  44134. * bridge/jni/v8/JavaFieldV8.h:
  44135. (JSC::Bindings::JavaField::typeClassName):
  44136. (JSC::Bindings::JavaField::type):
  44137. * bridge/jni/v8/JavaInstanceV8.cpp:
  44138. (JavaInstance::invokeMethod):
  44139. (JavaInstance::getField):
  44140. * bridge/jni/v8/JavaNPObjectV8.cpp:
  44141. (JSC::Bindings::JavaNPObjectInvoke):
  44142. (JSC::Bindings::JavaNPObjectGetProperty):
  44143. 2011-03-24 Ojan Vafai <ojan@chromium.org>
  44144. Was being a little braindead when I committed this.
  44145. Only simple selectors are allowed, but sibling selectors
  44146. are sibling selectors.
  44147. * css/CSSStyleSelector.cpp:
  44148. (WebCore::collectFeaturesFromList):
  44149. 2011-03-23 MORITA Hajime <morrita@google.com>
  44150. Reviewed by Kent Tamura.
  44151. Spellcheck feature specific symbols should be defined.
  44152. https://bugs.webkit.org/show_bug.cgi?id=56818
  44153. * Introduced USE(UNIFIED_TEXT_CHECKING), USE(GRAMMAR_CHECKING) and USE(AUTOMATIC_TEXT_REPLACEMENT)
  44154. * Replaced a part of of BUILDING_ON_* conditionals with them.
  44155. Note that small amount of code path on Editor.cpp is now compiled under USE(GRAMMAR_CHECKING)
  44156. because these code path is already built under non-Mac ports and
  44157. Keeping them buildable for such platforms reduces the build breakage risk.
  44158. These path is guarded by Settings thus should never get reached.
  44159. No new tests. No behavioral change.
  44160. * WebCore.gypi:
  44161. * WebCore.pro:
  44162. * WebCore.vcproj/WebCore.vcproj:
  44163. * WebCore.xcodeproj/project.pbxproj:
  44164. * editing/Editor.cpp:
  44165. (WebCore::Editor::advanceToNextMisspelling):
  44166. (WebCore::Editor::isSelectionUngrammatical):
  44167. (WebCore::Editor::guessesForUngrammaticalSelection):
  44168. (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
  44169. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  44170. (WebCore::Editor::markMisspellingsOrBadGrammar):
  44171. (WebCore::Editor::markBadGrammar):
  44172. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  44173. (WebCore::Editor::changeBackToReplacedString):
  44174. (WebCore::Editor::markMisspellingsAndBadGrammar):
  44175. * editing/Editor.h:
  44176. * editing/TextCheckingHelper.cpp:
  44177. (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
  44178. (WebCore::TextCheckingHelper::findFirstGrammarDetail):
  44179. (WebCore::TextCheckingHelper::findFirstBadGrammar):
  44180. (WebCore::TextCheckingHelper::isUngrammatical):
  44181. (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
  44182. (WebCore::TextCheckingHelper::markAllBadGrammar):
  44183. * loader/EmptyClients.h:
  44184. * platform/text/TextCheckerClient.h:
  44185. * platform/text/TextChecking.h: Added.
  44186. 2011-03-23 Kent Tamura <tkent@chromium.org>
  44187. Reviewed by Dimitri Glazkov.
  44188. [Chromium] Force to make validation bubble DIV position:absolute
  44189. https://bugs.webkit.org/show_bug.cgi?id=56901
  44190. Test: fast/forms/interactive-validation-crash-by-style-override.html
  44191. * html/ValidationMessage.cpp:
  44192. (WebCore::ValidationMessage::buildBubbleTree): Add position:absolute
  44193. because we need to move the validation message to a good position.
  44194. * rendering/RenderMenuList.cpp:
  44195. (WebCore::RenderMenuList::addChild):
  44196. 2011-03-23 Mike Lawther <mikelawther@chromium.org>
  44197. Reviewed by Ojan Vafai.
  44198. flex/bison tokens and grammar for CSS calc
  44199. https://bugs.webkit.org/show_bug.cgi?id=54412
  44200. Tests: css3/calc/calc-errors.html
  44201. css3/calc/minmax-errors.html
  44202. css3/calc/simple-calcs.html
  44203. css3/calc/simple-minmax.html
  44204. * css/CSSGrammar.y:
  44205. * css/CSSParserValues.cpp:
  44206. (WebCore::CSSParserValueList::insertValueAt):
  44207. (WebCore::CSSParserValueList::extend):
  44208. * css/CSSParserValues.h:
  44209. * css/tokenizer.flex:
  44210. 2011-03-23 Adam Klein <adamk@chromium.org>
  44211. Reviewed by David Levin.
  44212. Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
  44213. https://bugs.webkit.org/show_bug.cgi?id=56961
  44214. See error code listing in the Files & Directories spec:
  44215. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-LocalFileSystemSync-resolveLocalFileSystemSyncURL
  44216. Note that the spec currently only specifies errors for the sync
  44217. version; I've used the same codes for the async version.
  44218. * page/DOMWindow.cpp:
  44219. (WebCore::DOMWindow::resolveLocalFileSystemURL):
  44220. * workers/WorkerContext.cpp:
  44221. (WebCore::WorkerContext::resolveLocalFileSystemURL):
  44222. (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
  44223. 2011-03-23 Jia Pu <jpu@apple.com>
  44224. Reviewed by Darin Adler.
  44225. Hook up new AppKit autocorrection UI with WK2.
  44226. https://bugs.webkit.org/show_bug.cgi?id=56055
  44227. <rdar://problem/8947463>
  44228. This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
  44229. major changes:
  44230. 1. All but one autocorrection related message is synchronous. Since dismissing autocorrection
  44231. panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function
  44232. is introduced to ensure all editing commands occur in correct order.
  44233. 2. Additional condition variable is needed to implement dismissCorrectionPanelSoon().
  44234. To improve maintainability, CorrectionPanel class is introduced to manage the
  44235. internal state related to correction panel. This change is applied to both WK1 and WK2.
  44236. 3. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow
  44237. editor to know when to handle ESC key event. Now this is handled internally in AppKit, so
  44238. EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
  44239. 4. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can
  44240. access object via WebView or WKView.
  44241. * editing/Editor.cpp:
  44242. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  44243. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  44244. (WebCore::Editor::correctionPanelTimerFired):
  44245. (WebCore::Editor::dismissCorrectionPanel):
  44246. (WebCore::Editor::dismissCorrectionPanelSoon):
  44247. (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
  44248. * editing/Editor.h:
  44249. * editing/EditorCommand.cpp:
  44250. (WebCore::createCommandMap):
  44251. * loader/EmptyClients.h:
  44252. (WebCore::EmptyEditorClient::showCorrectionPanel):
  44253. (WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
  44254. * manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
  44255. * page/EditorClient.h:
  44256. 2011-03-22 Ojan Vafai <ojan@chromium.org>
  44257. Reviewed by Antti Koivisto.
  44258. move :not over to using selectorList instead of simpleSelector
  44259. https://bugs.webkit.org/show_bug.cgi?id=56894
  44260. Saves memory and simplifies code.
  44261. No new tests since existing tests cover this code.
  44262. * css/CSSGrammar.y:
  44263. Also removed extranenous calls to updateLastSelectorLineAndPosition in
  44264. simple_selector_list. These happened to work, but are only actually
  44265. needed in selector_list.
  44266. * css/CSSParserValues.h:
  44267. * css/CSSSelector.cpp:
  44268. (WebCore::CSSSelector::specificityForOneSelector):
  44269. Removed null-check. The parser null-checks, I don't see why we need to here.
  44270. (WebCore::CSSSelector::selectorText):
  44271. Ditto.
  44272. (WebCore::CSSSelector::setArgument):
  44273. (WebCore::CSSSelector::isSimple):
  44274. * css/CSSSelector.h:
  44275. * css/CSSSelectorList.cpp:
  44276. (WebCore::forEachTagSelector):
  44277. * css/CSSStyleSelector.cpp:
  44278. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  44279. (WebCore::collectFeaturesFromSelector):
  44280. (WebCore::collectFeaturesFromList):
  44281. 2011-03-23 Carol Szabo <carol.szabo@nokia.com>
  44282. Reviewed by David Hyatt.
  44283. Made sure that renderers displaying counters are invalidated upon
  44284. counter destruction.
  44285. Assertion and incorrect rendering of counters.
  44286. https://bugs.webkit.org/show_bug.cgi?id=56896
  44287. Test: fast/css/counters/2displays.html
  44288. * rendering/CounterNode.cpp:
  44289. (WebCore::CounterNode::~CounterNode):
  44290. Added to make sure that its display renderers are always reset when
  44291. the node is deleted.
  44292. (WebCore::CounterNode::resetRenderers):
  44293. Fixed bug that would prevent reset of second and subsequent
  44294. display renderers.
  44295. * rendering/CounterNode.h:
  44296. * rendering/RenderCounter.cpp:
  44297. (WebCore::destroyCounterNodeWithoutMapRemoval):
  44298. removed unnecessary calls to resetRenderers() as the CounterNode
  44299. destructor takes care of that now.
  44300. 2011-03-23 Brian Weinstein <bweinstein@apple.com>
  44301. Reviewed by Maciej Stachowiak.
  44302. WebKit2: Need API to manage the Media Cache
  44303. https://bugs.webkit.org/show_bug.cgi?id=56878
  44304. <rdar://problem/9082503>
  44305. Add functions that need to be exported.
  44306. * WebCore.exp.in:
  44307. 2011-03-23 Robert Kroeger <rjkroege@chromium.org>
  44308. Reviewed by James Robinson.
  44309. Correct use of ENABLE() Macro
  44310. In http://trac.webkit.org/changeset/81618, I mis-used the ENABLE()
  44311. macro. This patch corrects.
  44312. https://bugs.webkit.org/show_bug.cgi?id=56964
  44313. * page/EventHandler.cpp:
  44314. (WebCore::EventHandler::EventHandler):
  44315. (WebCore::EventHandler::handleTouchEvent):
  44316. * page/EventHandler.h:
  44317. 2011-03-23 Jer Noble <jer.noble@apple.com>
  44318. Reviewed by Simon Fraser.
  44319. Scrubbing <video> with HTTP Live Stream resizes element to 0x0
  44320. https://bugs.webkit.org/show_bug.cgi?id=55702
  44321. QTKit will occasionally set the natural size of a QTMovie to 0x0 while scrubbing
  44322. an HTTP Live Stream. So we will cache the last valid value returned by QTKit
  44323. and use that as our naturalSize until a new valid value is returned.
  44324. Unfortunately, QTKit will also fail to generate a notification when the natural size
  44325. changes, so we are forced to cache the natural size from within naturalSize(), which
  44326. is a const function, necessitating a const_cast to set m_cachedNaturalSize.
  44327. * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Added m_cachedNaturalSize.
  44328. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  44329. (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_cachedNaturalSize.
  44330. (WebCore::MediaPlayerPrivateQTKit::naturalSize):
  44331. 2011-03-23 Alexey Proskuryakov <ap@apple.com>
  44332. Build fix.
  44333. * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  44334. Removed a stray parenthesis.
  44335. 2011-03-23 Alexey Proskuryakov <ap@apple.com>
  44336. Reviewed by Maciej Stachowiak.
  44337. REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading()
  44338. https://bugs.webkit.org/show_bug.cgi?id=56978
  44339. <rdar://problem/9041670>
  44340. No new tests, because there is no known way to reproduce.
  44341. Removed strange code that was trying to stop a non-loading provisional document loader and
  44342. even its subframes (?!). Added assertions to catch it if we can actually be loading here in
  44343. some sense.
  44344. Rewrote a condition for clarity - starting with r43148, it was acting as an opposite of a
  44345. recursion guard (but that didn't cause immediate problems then).
  44346. * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  44347. 2011-03-23 Brady Eidson <beidson@apple.com>
  44348. Attempt to fix the build for platforms that have the icon database
  44349. disabled but still provide settings API for it...?
  44350. * loader/icon/IconDatabase.h:
  44351. (WebCore::IconDatabase::defaultDatabaseFilename):
  44352. 2011-03-23 Mark Rowe <mrowe@apple.com>
  44353. Fix the build.
  44354. * WebCore.exp.in: Export the new version of IconDatabase::open.
  44355. 2011-03-23 Brady Eidson <beidson@apple.com>
  44356. Reviewed by Sam Weinig.
  44357. Change IconDatabase opening to allow for arbitrary filenames
  44358. https://bugs.webkit.org/show_bug.cgi?id=56977
  44359. * WebCore.exp.in:
  44360. * loader/icon/IconDatabase.cpp:
  44361. (WebCore::IconDatabase::open):
  44362. * loader/icon/IconDatabase.h:
  44363. * loader/icon/IconDatabaseBase.cpp:
  44364. (WebCore::IconDatabaseBase::open):
  44365. * loader/icon/IconDatabaseBase.h:
  44366. * loader/icon/IconDatabaseClient.h:
  44367. 2011-03-23 Kenneth Russell <kbr@google.com>
  44368. Reviewed by James Robinson.
  44369. [chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
  44370. https://bugs.webkit.org/show_bug.cgi?id=56947
  44371. Removed the RuntimeEnabledFeatures setting for WebGL and the
  44372. EnabledAtRuntime extended attribute from the WebGL-related
  44373. properties on the DOMWindow. WebGL support is now controlled
  44374. exclusively through the page's Settings.
  44375. No new tests; tested manually in Chromium with --disable-webgl
  44376. command line argument and blacklist.
  44377. * bindings/generic/RuntimeEnabledFeatures.cpp:
  44378. * bindings/generic/RuntimeEnabledFeatures.h:
  44379. * page/DOMWindow.idl:
  44380. 2011-03-23 Sheriff Bot <webkit.review.bot@gmail.com>
  44381. Unreviewed, rolling out r81802.
  44382. http://trac.webkit.org/changeset/81802
  44383. https://bugs.webkit.org/show_bug.cgi?id=56963
  44384. Broke a layout test, and this fix is not trivial. (Requested
  44385. by dhyatt on #webkit).
  44386. * rendering/RenderBlock.cpp:
  44387. (WebCore::RenderBlock::layoutBlock):
  44388. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  44389. * rendering/RenderBlock.h:
  44390. * rendering/RenderBox.cpp:
  44391. (WebCore::RenderBox::styleDidChange):
  44392. * rendering/RenderBoxModelObject.cpp:
  44393. (WebCore::RenderBoxModelObject::styleWillChange):
  44394. * rendering/RenderFlexibleBox.cpp:
  44395. (WebCore::RenderFlexibleBox::layoutBlock):
  44396. * rendering/RenderObject.cpp:
  44397. (WebCore::RenderObject::RenderObject):
  44398. (WebCore::RenderObject::adjustStyleDifference):
  44399. (WebCore::RenderObject::setStyle):
  44400. (WebCore::RenderObject::styleDidChange):
  44401. * rendering/RenderObject.h:
  44402. (WebCore::RenderObject::needsLayout):
  44403. (WebCore::RenderObject::needsPositionedMovementLayoutOnly):
  44404. (WebCore::RenderObject::setNeedsLayout):
  44405. (WebCore::RenderObject::setChildNeedsLayout):
  44406. (WebCore::RenderObject::markContainingBlocksForLayout):
  44407. * rendering/RenderTable.cpp:
  44408. (WebCore::RenderTable::layout):
  44409. * rendering/style/RenderStyle.cpp:
  44410. (WebCore::RenderStyle::diff):
  44411. * rendering/style/RenderStyleConstants.h:
  44412. * rendering/svg/RenderSVGText.cpp:
  44413. (WebCore::RenderSVGText::layout):
  44414. 2011-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
  44415. Reviewed by David Hyatt.
  44416. REGRESSION(81035): crash in RenderDetails::removeChild
  44417. https://bugs.webkit.org/show_bug.cgi?id=56773
  44418. Test: fast/html/details-children-merge-crash.html
  44419. Preventing merging of RenderDetails's anonymous children.
  44420. * rendering/RenderBlock.cpp:
  44421. (WebCore::canMergeContiguousAnonymousBlocks):
  44422. Fixing RenderDetails::removeChild and cleaning m_marker in RenderDetails::destroy.
  44423. * rendering/RenderDetails.cpp:
  44424. (WebCore::RenderDetails::destroy):
  44425. (WebCore::RenderDetails::removeChild):
  44426. 2011-03-23 Xiaomei Ji <xji@chromium.org>
  44427. Reviewed by David Hyatt.
  44428. Preserve unicode-bidi:bidi-override in anonymous block.
  44429. https://bugs.webkit.org/show_bug.cgi?id=21440
  44430. unicode-bidi:bidi-override should be preserved in anonymous block
  44431. according to http://www.w3.org/TR/CSS21/visuren.html#propdef-unicode-bidi.
  44432. Introduce a helper function RenderStyle()::createAnonymousStyle() which
  44433. creates a default RenderStyle, inherits the inherited style from parent,
  44434. and inherit unicode-bidi:bidi-override from parent.
  44435. And replace the style creation when anonymous block is created.
  44436. Note: the TABLE releated anonymous blocks are untouched, including:
  44437. TABLE, TABLE_CELL, TABLE_ROW, TABLE_ROW_GROUP anonymous blocks created in
  44438. RenderObject, RenderTable, RenderTableRow, and RenderTableSection,
  44439. due to the expected behavior is not clear.
  44440. Please refer to https://bugs.webkit.org/show_bug.cgi?id=56594.
  44441. Test: fast/css/bidi-override-in-anonymous-block.html
  44442. * rendering/RenderBlock.cpp:
  44443. (WebCore::RenderBlock::styleDidChange):
  44444. (WebCore::RenderBlock::removeChild):
  44445. (WebCore::RenderBlock::createAnonymousBlock):
  44446. (WebCore::RenderBlock::createAnonymousColumnsBlock):
  44447. (WebCore::RenderBlock::createAnonymousColumnSpanBlock):
  44448. * rendering/RenderInline.cpp:
  44449. (WebCore::RenderInline::addChildIgnoringContinuation):
  44450. * rendering/RenderRubyRun.cpp:
  44451. (WebCore::RenderRubyRun::createRubyBase):
  44452. (WebCore::RenderRubyRun::staticCreateRubyRun):
  44453. * rendering/style/RenderStyle.cpp:
  44454. (WebCore::RenderStyle::createAnonymousStyle):
  44455. * rendering/style/RenderStyle.h:
  44456. 2011-03-23 David Hyatt <hyatt@apple.com>
  44457. Reviewed by Dan Bernstein.
  44458. https://bugs.webkit.org/show_bug.cgi?id=56909
  44459. Add a simplified normal flow layout path optimization for overflow recomputation
  44460. and for positioned objects inside relative positioned containers.
  44461. Currently there is an optimized code path for positioned objects, but as soon as
  44462. we encounter a normal flow object in the containing block chain, we lose the
  44463. optimization.
  44464. This patch adds a new type of style difference called SimplifiedLayout that is
  44465. returned when only overflow needs to be recomputed. Whenever opacity changes or
  44466. a transform changes, this is the hint returned now instead of a full layout.
  44467. In addition, when positioned objects need layout and start marking up the
  44468. containing block chain, we now propagate the fact that the layout is simplified
  44469. all the way up to the root, even when we encounter normal flow containing
  44470. blocks.
  44471. The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
  44472. and is now used for all of these cases (in addition to what it handled before).
  44473. No new tests, since existing tests covered this very well (especially the opacity
  44474. and transforms repaint tests in fast/repaint).
  44475. * rendering/RenderBlock.cpp:
  44476. (WebCore::RenderBlock::layoutBlock):
  44477. (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  44478. (WebCore::RenderBlock::simplifiedLayout):
  44479. * rendering/RenderBlock.h:
  44480. * rendering/RenderBox.cpp:
  44481. (WebCore::RenderBox::styleDidChange):
  44482. * rendering/RenderBoxModelObject.cpp:
  44483. (WebCore::RenderBoxModelObject::styleWillChange):
  44484. * rendering/RenderFlexibleBox.cpp:
  44485. (WebCore::RenderFlexibleBox::layoutBlock):
  44486. * rendering/RenderObject.cpp:
  44487. (WebCore::RenderObject::RenderObject):
  44488. (WebCore::RenderObject::adjustStyleDifference):
  44489. (WebCore::RenderObject::setStyle):
  44490. (WebCore::RenderObject::styleDidChange):
  44491. * rendering/RenderObject.h:
  44492. (WebCore::RenderObject::needsLayout):
  44493. (WebCore::RenderObject::needsPositionedMovementLayoutOnly):
  44494. (WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
  44495. (WebCore::RenderObject::setNeedsLayout):
  44496. (WebCore::RenderObject::setChildNeedsLayout):
  44497. (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
  44498. (WebCore::RenderObject::markContainingBlocksForLayout):
  44499. * rendering/RenderTable.cpp:
  44500. (WebCore::RenderTable::layout):
  44501. * rendering/style/RenderStyle.cpp:
  44502. (WebCore::RenderStyle::diff):
  44503. * rendering/style/RenderStyleConstants.h:
  44504. * rendering/svg/RenderSVGText.cpp:
  44505. (WebCore::RenderSVGText::layout):
  44506. 2011-03-23 Tyler Close <tjclose@chromium.org>
  44507. Reviewed by Jeremy Orlow.
  44508. Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
  44509. https://bugs.webkit.org/show_bug.cgi?id=56950
  44510. * bindings/scripts/CodeGeneratorV8.pm:
  44511. * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
  44512. (WebDOMTestCallback::callbackWithStringList):
  44513. * bindings/scripts/test/CPP/WebDOMTestCallback.h:
  44514. * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  44515. (webkit_dom_test_callback_callback_with_string_list):
  44516. * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  44517. * bindings/scripts/test/JS/JSTestCallback.cpp:
  44518. (WebCore::JSTestCallback::callbackWithStringList):
  44519. * bindings/scripts/test/JS/JSTestCallback.h:
  44520. * bindings/scripts/test/ObjC/DOMTestCallback.h:
  44521. * bindings/scripts/test/ObjC/DOMTestCallback.mm:
  44522. (-[DOMTestCallback callbackWithStringList:]):
  44523. * bindings/scripts/test/TestCallback.idl:
  44524. * bindings/scripts/test/V8/V8TestCallback.cpp:
  44525. (WebCore::V8TestCallback::callbackWithStringList):
  44526. * bindings/scripts/test/V8/V8TestCallback.h:
  44527. 2011-03-23 Cris Neckar <cdn@chromium.org>
  44528. Reviewed by Eric Seidel.
  44529. Add refptr for widget. Mutations can happen within the event handler.
  44530. https://bugs.webkit.org/show_bug.cgi?id=56774
  44531. Test: plugins/change-widget-and-click-crash.html
  44532. * html/HTMLPlugInElement.cpp:
  44533. (WebCore::HTMLPlugInElement::defaultEventHandler):
  44534. 2011-03-23 Abhishek Arya <inferno@chromium.org>
  44535. Reviewed by Dave Hyatt.
  44536. Add combine text cast checks since style property is insufficient
  44537. in telling object types.
  44538. https://bugs.webkit.org/show_bug.cgi?id=56358
  44539. Test: fast/text/input-box-text-fragment-combine-text-crash.html
  44540. * rendering/InlineTextBox.cpp:
  44541. (WebCore::InlineTextBox::paint):
  44542. * rendering/RenderBlock.cpp:
  44543. (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
  44544. * rendering/RenderBlockLineLayout.cpp:
  44545. (WebCore::RenderBlock::findNextLineBreak):
  44546. * rendering/RenderText.cpp:
  44547. (WebCore::RenderText::widthFromCache):
  44548. 2011-03-23 Andreas Kling <kling@webkit.org>
  44549. Reviewed by Kenneth Rohde Christiansen.
  44550. [Qt] "Unwavering" HTML5 game freezes the web page.
  44551. https://bugs.webkit.org/show_bug.cgi?id=56944
  44552. For canvas's getImageData() API, we don't want to make a deep-copy of
  44553. the pixels, which is the case on Qt's "raster" graphics system.
  44554. To work around this, we trick QPixmap::toImage() into giving us the
  44555. QPixmap's backing QImage by temporarily pointing the paint engine to
  44556. a null paint device.
  44557. * platform/graphics/qt/ImageBufferData.h:
  44558. * platform/graphics/qt/ImageBufferQt.cpp:
  44559. (WebCore::ImageBufferData::toQImage): Added, returns the
  44560. ImageBufferData as a QImage, avoiding a backend deep-copy if possible.
  44561. (WebCore::ImageBuffer::platformTransformColorSpace):
  44562. (WebCore::getImageData):
  44563. 2011-03-23 Viet-Trung Luu <viettrungluu@chromium.org>
  44564. Reviewed by Tony Chang.
  44565. [chromium] Add FormatPlainText to WebClipboard::Format enumeration.
  44566. https://bugs.webkit.org/show_bug.cgi?id=56868
  44567. Chromium's WebClipboard::isFormatAvailable() will be correspondingly
  44568. extended.
  44569. * platform/chromium/PasteboardPrivate.h: Add corresponding enum entry.
  44570. This part of the change is inert and should have no effect.
  44571. 2011-03-23 Tyler Close <tjclose@chromium.org>
  44572. Reviewed by Jeremy Orlow.
  44573. run-bindings-tests reference files are out of sync with CodeGenerator*.pm
  44574. https://bugs.webkit.org/show_bug.cgi?id=56934
  44575. * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  44576. * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  44577. * bindings/scripts/test/JS/JSTestInterface.cpp:
  44578. (WebCore::JSTestInterfaceConstructor::createStructure):
  44579. (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
  44580. (WebCore::JSTestInterface::createPrototype):
  44581. * bindings/scripts/test/JS/JSTestInterface.h:
  44582. (WebCore::JSTestInterface::createStructure):
  44583. (WebCore::JSTestInterfacePrototype::createStructure):
  44584. * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  44585. (WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
  44586. (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
  44587. (WebCore::JSTestMediaQueryListListener::createPrototype):
  44588. * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  44589. (WebCore::JSTestMediaQueryListListener::createStructure):
  44590. (WebCore::JSTestMediaQueryListListenerPrototype::createStructure):
  44591. * bindings/scripts/test/JS/JSTestObj.cpp:
  44592. (WebCore::JSTestObjConstructor::createStructure):
  44593. (WebCore::JSTestObjConstructor::JSTestObjConstructor):
  44594. (WebCore::JSTestObj::createPrototype):
  44595. * bindings/scripts/test/JS/JSTestObj.h:
  44596. (WebCore::JSTestObj::createStructure):
  44597. (WebCore::JSTestObjPrototype::createStructure):
  44598. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  44599. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
  44600. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
  44601. (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
  44602. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  44603. (WebCore::JSTestSerializedScriptValueInterface::createStructure):
  44604. (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
  44605. * bindings/scripts/test/V8/V8TestCallback.cpp:
  44606. * bindings/scripts/test/V8/V8TestInterface.cpp:
  44607. (WebCore::V8TestInterface::wrapSlow):
  44608. * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  44609. (WebCore::V8TestMediaQueryListListener::wrapSlow):
  44610. * bindings/scripts/test/V8/V8TestObj.cpp:
  44611. (WebCore::V8TestObj::wrapSlow):
  44612. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
  44613. (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
  44614. 2011-03-23 Daniel Bates <dbates@rim.com>
  44615. Reviewed by Antonio Gomes.
  44616. Clean up: Rename HTMLFrameSetElement::{noresize, frameborder, and frameBorderSet}
  44617. to conform to the WebKit Code style guidelines
  44618. https://bugs.webkit.org/show_bug.cgi?id=56871
  44619. No functionality changed. So, no new tests.
  44620. * html/HTMLFrameSetElement.cpp:
  44621. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  44622. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  44623. (WebCore::HTMLFrameSetElement::attach):
  44624. (WebCore::HTMLFrameSetElement::defaultEventHandler):
  44625. * html/HTMLFrameSetElement.h:
  44626. (WebCore::HTMLFrameSetElement::hasFrameBorder):
  44627. (WebCore::HTMLFrameSetElement::noResize):
  44628. 2011-03-23 Abhishek Arya <inferno@chromium.org>
  44629. Reviewed by Dan Bernstein.
  44630. Replace height with logicalHeight when removing items from
  44631. gPercentHeightDescendantMap so that it is writing mode aware.
  44632. https://bugs.webkit.org/show_bug.cgi?id=56902
  44633. Test: fast/block/percent-height-descendant-not-removed-crash.html
  44634. * rendering/RenderBox.cpp:
  44635. (WebCore::RenderBox::destroy):
  44636. (WebCore::RenderBox::styleDidChange):
  44637. * rendering/RenderWidget.cpp:
  44638. (WebCore::RenderWidget::destroy):
  44639. 2011-03-23 Anders Carlsson <andersca@apple.com>
  44640. Fix clang build.
  44641. * inspector/DOMNodeHighlighter.cpp:
  44642. Remove an unused function.
  44643. 2011-03-22 Brady Eidson <beidson@apple.com>
  44644. Reviewed by Sam Weinig.
  44645. Add asynchronous load decision call to WebKit2 IconDatabase
  44646. https://bugs.webkit.org/show_bug.cgi?id=56887
  44647. Clear the callback when it's made:
  44648. * loader/DocumentLoader.cpp:
  44649. (WebCore::DocumentLoader::continueIconLoadWithDecision):
  44650. Don't load icons when using new-style icon database if in private browsing:
  44651. * loader/FrameLoader.cpp:
  44652. (WebCore::FrameLoader::continueIconLoadWithDecision):
  44653. Enhance the IconDatabase callbacks to have an ID and inherit from a common base:
  44654. * loader/icon/IconDatabaseBase.h:
  44655. (WebCore::CallbackBase::~CallbackBase):
  44656. (WebCore::CallbackBase::callbackID):
  44657. (WebCore::CallbackBase::CallbackBase):
  44658. (WebCore::CallbackBase::context):
  44659. (WebCore::CallbackBase::generateCallbackID):
  44660. (WebCore::EnumCallback::performCallback):
  44661. (WebCore::EnumCallback::EnumCallback):
  44662. (WebCore::ObjectCallback::performCallback):
  44663. (WebCore::ObjectCallback::ObjectCallback):
  44664. 2011-03-21 Pavel Podivilov <podivilov@chromium.org>
  44665. Reviewed by Yury Semikhatsky.
  44666. Web Inspector: move scripts concatenation logic to SourceFile.
  44667. https://bugs.webkit.org/show_bug.cgi?id=56756
  44668. * inspector/front-end/ScriptsPanel.js:
  44669. * inspector/front-end/SourceFile.js:
  44670. (WebInspector.SourceFile.prototype._requestContent):
  44671. (WebInspector.SourceFile.prototype._loadResourceContent):
  44672. (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
  44673. (WebInspector.SourceFile.prototype._concatenateScriptsContent):
  44674. 2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>
  44675. Reviewed by Steve Block.
  44676. Media Stream API: add a flag to RuntimeEnabledFeatures.
  44677. https://bugs.webkit.org/show_bug.cgi?id=56921
  44678. Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.
  44679. Tests for the Media Stream API will be provided by the bug 56587.
  44680. * bindings/generic/RuntimeEnabledFeatures.cpp:
  44681. * bindings/generic/RuntimeEnabledFeatures.h:
  44682. (WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
  44683. (WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
  44684. (WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
  44685. 2011-03-23 Carol Szabo <carol.szabo@nokia.com>
  44686. Reviewed by David Hyatt.
  44687. Modified RenderCounter::originalText() to correctly attach
  44688. the created counter to the before/after container even when
  44689. that is not the RenderCounter's direct parent.
  44690. CSS 2.1 failure: various before-after-* tests fail
  44691. https://bugs.webkit.org/show_bug.cgi?id=47207
  44692. Test: fast/css/counters/complex-before.html
  44693. * rendering/RenderCounter.cpp:
  44694. (WebCore::RenderCounter::originalText):
  44695. 2011-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  44696. Reviewed by Antonio Gomes.
  44697. [EFL] Add play / pause button to media control
  44698. https://bugs.webkit.org/show_bug.cgi?id=55463
  44699. Add play|pause button to media control.
  44700. * platform/efl/RenderThemeEfl.cpp:
  44701. (WebCore::RenderThemeEfl::edjeGroupFromFormType):
  44702. (WebCore::RenderThemeEfl::emitMediaButtonSignal): Added.
  44703. (WebCore::RenderThemeEfl::paintMediaPlayButton):
  44704. * platform/efl/RenderThemeEfl.h:
  44705. 2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
  44706. Reviewed by Andreas Kling.
  44707. [Qt] QtWebKit rendering problem when maximizing and doing a back
  44708. https://bugs.webkit.org/show_bug.cgi?id=56669
  44709. Contents of the page are not re-sized on going back after
  44710. maximizing. ContentsResized() is not getting called. Hence old
  44711. document width and height are used. Corrected this behaviour by
  44712. calling setBoundsSize() which calls contentsSize().
  44713. * loader/FrameLoader.cpp:
  44714. (WebCore::FrameLoader::open):
  44715. 2011-03-21 Pavel Podivilov <podivilov@chromium.org>
  44716. Reviewed by Yury Semikhatsky.
  44717. Web Inspector: add support for formating source files in debugger presentation model.
  44718. https://bugs.webkit.org/show_bug.cgi?id=56558
  44719. * inspector/front-end/DebuggerModel.js:
  44720. (WebInspector.DebuggerModel.prototype.reset):
  44721. (WebInspector.DebuggerModel.prototype.get scripts):
  44722. * inspector/front-end/DebuggerPresentationModel.js:
  44723. (WebInspector.DebuggerPresentationModel):
  44724. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  44725. (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
  44726. (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
  44727. (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
  44728. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  44729. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  44730. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  44731. (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
  44732. (WebInspector.DebuggerPresentationModel.prototype._reset):
  44733. * inspector/front-end/ScriptFormatter.js:
  44734. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
  44735. (WebInspector.ScriptFormatter.prototype.formatContent):
  44736. * inspector/front-end/ScriptsPanel.js:
  44737. (WebInspector.ScriptsPanel):
  44738. (WebInspector.ScriptsPanel.prototype.reset):
  44739. (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  44740. * inspector/front-end/Settings.js:
  44741. * inspector/front-end/SourceFile.js:
  44742. (WebInspector.SourceFile.prototype.scriptLocationToSourceLocation):
  44743. (WebInspector.SourceFile.prototype.sourceLocationToScriptLocation):
  44744. (WebInspector.FormattedSourceFile):
  44745. (WebInspector.FormattedSourceFile.prototype.scriptLocationToSourceLocation):
  44746. (WebInspector.FormattedSourceFile.prototype.sourceLocationToScriptLocation):
  44747. (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  44748. 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
  44749. Reviewed by Pavel Feldman.
  44750. Web Inspector: use unsigned char instead of char when storing script source
  44751. https://bugs.webkit.org/show_bug.cgi?id=56920
  44752. * bindings/v8/DebuggerScript.js:
  44753. * bindings/v8/ScriptDebugServer.cpp:
  44754. (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  44755. * inspector/InjectedScriptManager.cpp:
  44756. (WebCore::InjectedScriptManager::injectedScriptSource):
  44757. * inspector/InjectedScriptSource.js: whitespace change to trigger compilation
  44758. * inspector/xxd.pl:
  44759. * xml/XMLViewer.xsl:
  44760. 2011-03-23 Ilya Tikhonovsky <loislo@chromium.org>
  44761. Reviewed by Yury Semikhatsky.
  44762. Web Inspector: move node searching and node highlight related methods from InspectorAgent to InspectorDOMAgent.
  44763. https://bugs.webkit.org/show_bug.cgi?id=56912
  44764. The next functions were moved:
  44765. setSearchingForNode
  44766. highlightDOMNode
  44767. hideDOMNodeHighlight
  44768. highlightFrame
  44769. hideFrameHighlight
  44770. mouseDidMoveOverElement
  44771. handleMousePress
  44772. The code which does real highlight in Graphic context was moved to new files DOMNodeHighlighter.*
  44773. * CMakeLists.txt:
  44774. * GNUmakefile.am:
  44775. * WebCore.gypi:
  44776. * WebCore.pro:
  44777. * WebCore.vcproj/WebCore.vcproj:
  44778. * WebCore.xcodeproj/project.pbxproj:
  44779. * inspector/DOMNodeHighlighter.cpp: Added.
  44780. (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  44781. * inspector/DOMNodeHighlighter.h: Added.
  44782. * inspector/Inspector.json:
  44783. * inspector/InspectorAgent.cpp:
  44784. (WebCore::InspectorAgent::InspectorAgent):
  44785. (WebCore::InspectorAgent::~InspectorAgent):
  44786. (WebCore::InspectorAgent::inspectedPageDestroyed):
  44787. (WebCore::InspectorAgent::disconnectFrontend):
  44788. * inspector/InspectorAgent.h:
  44789. * inspector/InspectorController.cpp:
  44790. (WebCore::InspectorController::drawNodeHighlight):
  44791. (WebCore::InspectorController::hideHighlight):
  44792. * inspector/InspectorDOMAgent.cpp:
  44793. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  44794. (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
  44795. (WebCore::InspectorDOMAgent::clearFrontend):
  44796. (WebCore::InspectorDOMAgent::handleMousePress):
  44797. (WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
  44798. (WebCore::InspectorDOMAgent::searchingForNodeInPage):
  44799. (WebCore::InspectorDOMAgent::setSearchingForNode):
  44800. (WebCore::InspectorDOMAgent::highlight):
  44801. (WebCore::InspectorDOMAgent::highlightDOMNode):
  44802. (WebCore::InspectorDOMAgent::highlightFrame):
  44803. (WebCore::InspectorDOMAgent::hideHighlight):
  44804. (WebCore::InspectorDOMAgent::drawNodeHighlight):
  44805. * inspector/InspectorDOMAgent.h:
  44806. (WebCore::InspectorDOMAgent::hideDOMNodeHighlight):
  44807. (WebCore::InspectorDOMAgent::hideFrameHighlight):
  44808. * inspector/InspectorInstrumentation.cpp:
  44809. (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
  44810. (WebCore::InspectorInstrumentation::handleMousePressImpl):
  44811. * inspector/InstrumentingAgents.h:
  44812. (WebCore::InstrumentingAgents::InstrumentingAgents):
  44813. (WebCore::InstrumentingAgents::inspectorAgent):
  44814. (WebCore::InstrumentingAgents::setInspectorAgent):
  44815. * inspector/front-end/ElementsPanel.js:
  44816. (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  44817. * inspector/front-end/ResourcesPanel.js:
  44818. (WebInspector.FrameTreeElement.prototype.onselect):
  44819. (WebInspector.FrameTreeElement.prototype.set hovered):
  44820. * inspector/front-end/inspector.js:
  44821. (WebInspector.highlightDOMNode):
  44822. 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
  44823. Unreviewed. Rollout r81768 which broke compilation on Win.
  44824. * xml/XMLTreeViewer.cpp:
  44825. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  44826. * xml/XMLViewer.xsl:
  44827. 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
  44828. Reviewed by Pavel Feldman.
  44829. Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer
  44830. https://bugs.webkit.org/show_bug.cgi?id=56919
  44831. * xml/XMLTreeViewer.cpp:
  44832. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  44833. * xml/XMLViewer.xsl: whitespace change to trigger compilation.
  44834. 2011-03-21 Pavel Podivilov <podivilov@chromium.org>
  44835. Reviewed by Yury Semikhatsky.
  44836. Web Inspector: move content loading logic to a new SourceFile class.
  44837. https://bugs.webkit.org/show_bug.cgi?id=56748
  44838. * WebCore.gypi:
  44839. * WebCore.vcproj/WebCore.vcproj:
  44840. * inspector/front-end/DebuggerPresentationModel.js:
  44841. (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
  44842. (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged):
  44843. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  44844. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  44845. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  44846. * inspector/front-end/SourceFile.js: Added.
  44847. (WebInspector.SourceFile):
  44848. (WebInspector.SourceFile.prototype.addScript):
  44849. (WebInspector.SourceFile.prototype.requestContent):
  44850. (WebInspector.SourceFile.prototype.forceLoadContent):
  44851. (WebInspector.SourceFile.prototype.reload):
  44852. (WebInspector.SourceFile.prototype._requestContent):
  44853. (WebInspector.SourceFile.prototype._loadResourceContent):
  44854. (WebInspector.SourceFile.prototype._loadScriptContent):
  44855. (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
  44856. (WebInspector.SourceFile.prototype._didRequestContent):
  44857. (WebInspector.SourceFile.prototype._hasPendingResource):
  44858. * inspector/front-end/WebKit.qrc:
  44859. * inspector/front-end/inspector.html:
  44860. 2011-03-23 Pavel Podivilov <podivilov@chromium.org>
  44861. Unreviewed, fix compilation broken by r81758.
  44862. * xml/XMLTreeViewer.cpp:
  44863. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  44864. 2011-03-23 Pavel Feldman <pfeldman@chromium.org>
  44865. Reviewed by Yury Semikhatsky.
  44866. Web Inspector: define array types properly in the Inspector.json
  44867. https://bugs.webkit.org/show_bug.cgi?id=56915
  44868. * inspector/Inspector.json:
  44869. * inspector/generate-inspector-idl:
  44870. 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
  44871. Reviewed by Pavel Feldman.
  44872. [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
  44873. https://bugs.webkit.org/show_bug.cgi?id=56843
  44874. * inspector/front-end/WebKit.qrc:
  44875. 2011-03-23 Andrey Adaikin <aandrey@google.com>
  44876. Reviewed by Yury Semikhatsky.
  44877. Web Inspector: Add a star while editing a source code
  44878. https://bugs.webkit.org/show_bug.cgi?id=56743
  44879. * inspector/front-end/ScriptsPanel.js:
  44880. (WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
  44881. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
  44882. * inspector/front-end/SourceFrame.js:
  44883. (WebInspector.SourceFrame.prototype._startEditing):
  44884. (WebInspector.SourceFrame.prototype._registerShortcuts):
  44885. (WebInspector.SourceFrame.prototype._handleSave):
  44886. (WebInspector.SourceFrame.prototype._handleRevertEditing):
  44887. (WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
  44888. 2011-03-23 Andrey Adaikin <aandrey@google.com>
  44889. Reviewed by Yury Semikhatsky.
  44890. Web Inspector: Scrolling and navigation is not smooth on a script with many long lines
  44891. https://bugs.webkit.org/show_bug.cgi?id=56559
  44892. * inspector/front-end/TextViewer.js:
  44893. (WebInspector.TextEditorChunkedPanel.prototype._expandChunks):
  44894. (WebInspector.TextEditorMainPanel.prototype._expandChunks):
  44895. (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
  44896. (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
  44897. (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
  44898. (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
  44899. (WebInspector.TextEditorMainPanel.prototype._paintLines):
  44900. (WebInspector.TextEditorMainPanel.prototype._paintLine):
  44901. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  44902. 2011-03-22 Yury Semikhatsky <yurys@chromium.org>
  44903. Reviewed by Pavel Feldman.
  44904. [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
  44905. https://bugs.webkit.org/show_bug.cgi?id=56843
  44906. DebuggerScript.js is now translated into a char[] array before inspector compilation.
  44907. * WebCore.gyp/WebCore.gyp:
  44908. * WebCore.gypi:
  44909. * bindings/v8/ScriptDebugServer.cpp:
  44910. (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  44911. * bindings/v8/ScriptDebugServer.h:
  44912. * inspector/InjectedScriptManager.cpp:
  44913. (WebCore::InjectedScriptManager::injectedScriptSource):
  44914. * inspector/InjectedScriptSource.js: whitespace change to trigger InjectedScriptSource.h generation.
  44915. * inspector/xxd.pl:
  44916. 2011-03-23 Mark Rowe <mrowe@apple.com>
  44917. Fix the 32-bit build.
  44918. * html/canvas/WebGLRenderingContext.cpp:
  44919. (WebCore::WebGLRenderingContext::initializeNewContext):
  44920. 2011-03-22 Noel Gordon <noel.gordon@gmail.com>
  44921. Reviewed by Ojan Vafai.
  44922. [chromium] skia image encoders should use <wtf/Vector.h>
  44923. https://bugs.webkit.org/show_bug.cgi?id=56893
  44924. No new tests. Covered by existing canvas.toDataURL tests.
  44925. * platform/image-encoders/skia/JPEGImageEncoder.h:
  44926. * platform/image-encoders/skia/PNGImageEncoder.h:
  44927. 2011-03-22 David Hyatt <hyatt@apple.com>
  44928. Reviewed by Beth Dakin.
  44929. Move the cellWidthChanged bit out of RenderObject and back down into RenderTableCell in order to
  44930. free up a bit for another performance optimization I have planned.
  44931. * rendering/RenderObject.cpp:
  44932. (WebCore::RenderObject::RenderObject):
  44933. * rendering/RenderObject.h:
  44934. (WebCore::RenderObject::setHasColumns):
  44935. * rendering/RenderTableCell.cpp:
  44936. (WebCore::RenderTableCell::RenderTableCell):
  44937. * rendering/RenderTableCell.h:
  44938. (WebCore::RenderTableCell::cellWidthChanged):
  44939. (WebCore::RenderTableCell::setCellWidthChanged):
  44940. 2011-03-22 David Hyatt <hyatt@apple.com>
  44941. Reviewed by Dan Bernstein.
  44942. https://bugs.webkit.org/show_bug.cgi?id=56892
  44943. Adding floats to an empty block is O(n^2).
  44944. If you just add floats back to back to an empty block, the addition is essentially O(n^2)
  44945. once the floats move below your current line position. This is because we repeatedly ask for the
  44946. available width for the line from scratch every time we add a float, regardless of whether the
  44947. float even vertically intersected our current line position.
  44948. Change positionNewFloatOnLine to update left and right line offsets intelligently and to only
  44949. do it based off the single new float that just got added.
  44950. This fix cuts the IE MazeSolver time in half.
  44951. * rendering/RenderBlock.cpp:
  44952. (WebCore::RenderBlock::positionNewFloatOnLine):
  44953. * rendering/RenderBlock.h:
  44954. * rendering/RenderBlockLineLayout.cpp:
  44955. (WebCore::RenderBlock::skipLeadingWhitespace):
  44956. (WebCore::RenderBlock::findNextLineBreak):
  44957. 2011-03-22 Beth Dakin <bdakin@apple.com>
  44958. Reviewed by Sam Weinig.
  44959. Fix for https://bugs.webkit.org/show_bug.cgi?id=56890 It is possible to calculate a
  44960. NaN value for "value" in ScrollbarThemeMac::paint()
  44961. -and corresponding-
  44962. <rdar://problem/9160621>
  44963. * platform/mac/ScrollbarThemeMac.mm:
  44964. (WebCore::ScrollbarThemeMac::paint):
  44965. 2011-03-17 Ojan Vafai <ojan@chromium.org>
  44966. Reviewed by Antti Koivisto.
  44967. webkit should implement -moz-any selector (as -webkit-any obviously)
  44968. https://bugs.webkit.org/show_bug.cgi?id=38095
  44969. For now, match the Mozilla implementation with respect to specificity
  44970. and only allowing simple selectors. Both of these are likely to change
  44971. pending discussion on www-style@.
  44972. Tests: fast/css/pseudo-any.html
  44973. fast/dom/SelectorAPI/unknown-pseudo.html
  44974. * css/CSSGrammar.y:
  44975. Create simple_selector_list. This is exactly like selector_list
  44976. except it only allows simple selectors and creates a new vector
  44977. instead of a reusable one since there can be multiple in one rule.
  44978. * css/CSSParser.cpp:
  44979. (WebCore::CSSParser::~CSSParser):
  44980. (WebCore::CSSParser::lex):
  44981. (WebCore::CSSParser::createFloatingSelectorVector):
  44982. (WebCore::CSSParser::sinkFloatingSelectorVector):
  44983. * css/CSSParser.h:
  44984. * css/CSSParserValues.cpp:
  44985. (WebCore::CSSParserSelector::adoptSelectorVector):
  44986. * css/CSSParserValues.h:
  44987. * css/CSSSelector.cpp:
  44988. (WebCore::CSSSelector::specificityForOneSelector):
  44989. (WebCore::CSSSelector::pseudoId):
  44990. (WebCore::nameToPseudoTypeMap):
  44991. (WebCore::CSSSelector::extractPseudoType):
  44992. (WebCore::CSSSelector::selectorText):
  44993. (WebCore::CSSSelector::setSelectorList):
  44994. (WebCore::CSSSelector::RareData::RareData):
  44995. (WebCore::CSSSelector::RareData::~RareData):
  44996. These need to be moved into the cpp file so that we can
  44997. have an OwnPtr<CSSSelectorList> in CSSSelector::RareData.
  44998. * css/CSSSelector.h:
  44999. (WebCore::CSSSelector::selectorList):
  45000. * css/CSSSelectorList.cpp:
  45001. (WebCore::forEachTagSelector):
  45002. * css/CSSStyleSelector.cpp:
  45003. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  45004. (WebCore::collectFeaturesFromSelector):
  45005. * css/tokenizer.flex:
  45006. 2011-03-22 John Bauman <jbauman@chromium.org>
  45007. Reviewed by Kenneth Russell.
  45008. Add support for preserveDrawingBuffer context creation attribute
  45009. https://bugs.webkit.org/show_bug.cgi?id=56431
  45010. For the accelerated compositing case, only prepare the texture if it
  45011. has been updated since the last composite. For the non-accelerated case, make sure to
  45012. grab a copy of the image buffer and paint from that if the backbuffer
  45013. would be cleared.
  45014. In both cases, make sure to clear the context's backbuffer before the
  45015. first operation that uses it.
  45016. No new tests. It seems to be difficult/impossible to trigger an early
  45017. compositing operation in DumpRenderTree, making this hard to
  45018. test automatically. However, Chromium and Safari (Mac) have been
  45019. tested manually on the webgl conformance test for this.
  45020. * html/HTMLCanvasElement.cpp:
  45021. (WebCore::HTMLCanvasElement::paint):
  45022. (WebCore::HTMLCanvasElement::makePresentationCopy):
  45023. (WebCore::HTMLCanvasElement::clearPresentationCopy):
  45024. * html/HTMLCanvasElement.h:
  45025. * html/canvas/WebGLContextAttributes.cpp:
  45026. (WebCore::WebGLContextAttributes::preserveDrawingBuffer):
  45027. (WebCore::WebGLContextAttributes::setPreserveDrawingBuffer):
  45028. * html/canvas/WebGLContextAttributes.h:
  45029. * html/canvas/WebGLContextAttributes.idl:
  45030. * html/canvas/WebGLRenderingContext.cpp:
  45031. (WebCore::WebGLRenderingContext::initializeNewContext):
  45032. (WebCore::WebGLRenderingContext::markContextChanged):
  45033. (WebCore::WebGLRenderingContext::clearIfComposited):
  45034. (WebCore::WebGLRenderingContext::markLayerComposited):
  45035. (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
  45036. (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
  45037. (WebCore::WebGLRenderingContext::clear):
  45038. (WebCore::WebGLRenderingContext::clearColor):
  45039. (WebCore::WebGLRenderingContext::clearDepth):
  45040. (WebCore::WebGLRenderingContext::clearStencil):
  45041. (WebCore::WebGLRenderingContext::colorMask):
  45042. (WebCore::WebGLRenderingContext::disable):
  45043. (WebCore::WebGLRenderingContext::drawArrays):
  45044. (WebCore::WebGLRenderingContext::drawElements):
  45045. (WebCore::WebGLRenderingContext::enable):
  45046. (WebCore::WebGLRenderingContext::readPixels):
  45047. * html/canvas/WebGLRenderingContext.h:
  45048. * platform/graphics/GraphicsContext3D.h:
  45049. (WebCore::GraphicsContext3D::Attributes::Attributes):
  45050. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  45051. (WebCore::WebGLLayerChromium::updateContentsIfDirty):
  45052. (WebCore::WebGLLayerChromium::textureUpdated):
  45053. (WebCore::WebGLLayerChromium::setContext):
  45054. * platform/graphics/chromium/WebGLLayerChromium.h:
  45055. * platform/graphics/mac/GraphicsContext3DMac.mm
  45056. (WebCore::GraphicsContext3D::GraphicsContext3D):
  45057. (WebCore::GraphicsContext3D::~GraphicsContext3D):
  45058. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  45059. (WebCore::GraphicsContext3D::reshape):
  45060. (WebCore::GraphicsContext3D::prepareTexture):
  45061. (WebCore::GraphicsContext3D::activeTexture):
  45062. (WebCore::GraphicsContext3D::bindTexture):
  45063. (WebCore::GraphicsContext3D::markContextChanged):
  45064. (WebCore::GraphicsContext3D::markLayerComposited):
  45065. (WebCore::GraphicsContext3D::layerComposited):
  45066. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  45067. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
  45068. (WebCore::GraphicsContext3D::markLayerComposited):
  45069. (WebCore::GraphicsContext3D::markContextChanged):
  45070. (WebCore::GraphicsContext3D::layerComposited):
  45071. 2011-03-22 Sam Weinig <sam@webkit.org>
  45072. Reviewed by Mark Rowe.
  45073. Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
  45074. <rdar://problem/8944718>
  45075. * DerivedSources.make:
  45076. Remove generation of HeaderDetection.h.
  45077. * WebCore.xcodeproj/project.pbxproj:
  45078. Remove HeaderDetection.h.
  45079. * platform/mac/ScrollAnimatorMac.h:
  45080. * platform/mac/ScrollAnimatorMac.mm:
  45081. * platform/mac/ScrollbarThemeMac.h:
  45082. * platform/mac/ScrollbarThemeMac.mm:
  45083. Replace use of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER with USE(WK_SCROLLBAR_PAINTER).
  45084. 2011-03-22 Victoria Kirst <vrk@google.com>
  45085. Reviewed by Kenneth Russell.
  45086. [chromium] Properly reset VideoLayerChromium textures after lost renderer context
  45087. https://bugs.webkit.org/show_bug.cgi?id=56514
  45088. The VideoLayerChromium textures were still mapped to the old
  45089. renderer's context when LayerRendererChromium was being recreated
  45090. i.e. when GPU process is killed. This patch allows VideoLayerChromium
  45091. it recreate textures in the new context when the old renderer is lost.
  45092. Patch also does a bit of refactoring and code clean-up.
  45093. * platform/graphics/chromium/VideoLayerChromium.cpp:
  45094. (WebCore::VideoLayerChromium::~VideoLayerChromium):
  45095. (WebCore::VideoLayerChromium::cleanupResources):
  45096. (WebCore::VideoLayerChromium::updateContentsIfDirty):
  45097. (WebCore::VideoLayerChromium::allocateTexturesIfNeeded):
  45098. (WebCore::VideoLayerChromium::computeVisibleSize):
  45099. (WebCore::VideoLayerChromium::drawYUV):
  45100. (WebCore::VideoLayerChromium::drawRGBA):
  45101. (WebCore::VideoLayerChromium::resetFrameParameters):
  45102. (WebCore::VideoLayerChromium::saveCurrentFrame):
  45103. * platform/graphics/chromium/VideoLayerChromium.h:
  45104. 2011-03-22 Adam Barth <abarth@webkit.org>
  45105. Reviewed by Eric Seidel.
  45106. WebCore GYP build should export the headers needed by WebKit
  45107. https://bugs.webkit.org/show_bug.cgi?id=56883
  45108. * WebCore.gypi:
  45109. * gyp/WebCore.gyp:
  45110. - Export a couple more headers.
  45111. - Remove FIXME comments for things we've already fixed.
  45112. 2011-03-22 Anton D'Auria <adauria@apple.com>
  45113. Reviewed by Alexey Proskuryakov.
  45114. Add +[WebApplicationCache getOriginsWithCache]
  45115. https://bugs.webkit.org/show_bug.cgi?id=56722
  45116. Added test that exercises WebCore API to get origins with application cache.
  45117. Test: http/tests/appcache/origins-with-appcache.html
  45118. * loader/appcache/ApplicationCacheStorage.cpp:
  45119. (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  45120. * loader/appcache/ApplicationCacheStorage.h:
  45121. 2011-03-22 Carol Szabo <carol.szabo@nokia.com>
  45122. Reviewed by David Hyatt.
  45123. Introduced double linkage between a CounterNode and its display renderer.
  45124. use of freed pointer in WebCore::RenderCounter::originalText()
  45125. https://bugs.webkit.org/show_bug.cgi?id=56065
  45126. No new tests. This bug could only be reproduced manually by
  45127. refreshing the page during load at a critical point.
  45128. See bug attachment for testing.
  45129. * rendering/CounterNode.cpp:
  45130. Introduced new member "m_owner" to store the renderer that has the
  45131. style directives that produce the CounterNode.
  45132. Repurposed m_renderer to reffer to the RenderCounter that shows the
  45133. CounterNode.
  45134. (WebCore::CounterNode::CounterNode):
  45135. Updated member initialization.
  45136. (WebCore::CounterNode::create):
  45137. (WebCore::CounterNode::addRenderer):
  45138. (WebCore::CounterNode::removeRenderer):
  45139. Introduced to manage the renderer list associated wit this CounterNode.
  45140. (WebCore::CounterNode::resetRenderers):
  45141. This is the old resetRenderer. Renamed to take into account that there may be
  45142. more than one renderer to a CounterNode.
  45143. (WebCore::CounterNode::resetThisAndDescendantsRenderers):
  45144. This is the old resetRenderers renamed for clarity.
  45145. (WebCore::CounterNode::recount):
  45146. (WebCore::CounterNode::insertAfter):
  45147. (WebCore::CounterNode::removeChild):
  45148. No functional changes.
  45149. (WebCore::showTreeAndMark):
  45150. Added flushing to ensure that the output is complete.
  45151. * rendering/CounterNode.h:
  45152. (WebCore::CounterNode::owner):
  45153. Renamed from renderer()
  45154. * rendering/RenderCounter.cpp:
  45155. (WebCore::findPlaceForCounter):
  45156. Fixed comments. No functional changes.
  45157. (WebCore::RenderCounter::~RenderCounter):
  45158. Made sure that the CounterNode that this renderers displays is
  45159. detached from this.
  45160. (WebCore::RenderCounter::originalText):
  45161. (WebCore::RenderCounter::invalidate):
  45162. Changed to maintain the bidirectional relationship with the displayed CounterNode.
  45163. Also made "invalidate" private as it should be used only by CounterNode.
  45164. (WebCore::destroyCounterNodeWithoutMapRemoval):
  45165. (WebCore::RenderCounter::destroyCounterNodes):
  45166. (WebCore::RenderCounter::destroyCounterNode):
  45167. (WebCore::updateCounters):
  45168. No change, just kept code in line with the changes above.
  45169. (showCounterRendererTree):
  45170. Added fflush to ensure complete display.
  45171. * rendering/RenderCounter.h:
  45172. * rendering/RenderObjectChildList.cpp:
  45173. * rendering/RenderObjectChildList.h:
  45174. Removed unneeded invalidateCounters related functions.
  45175. 2011-03-22 Dean Jackson <dino@apple.com>
  45176. Reviewed by Simon Fraser.
  45177. https://bugs.webkit.org/show_bug.cgi?id=56242
  45178. Interrupted accelerated animations/transitions were causing
  45179. subsequent animations to not start (because they were stuck
  45180. waiting for a response from the compositing layer). I renamed
  45181. the instance variable that indicates whether or not to
  45182. notify animations of start time, from m_waitingForStartTimeResponse
  45183. to m_waitingForAsyncStartNotification, so that it makes more sense.
  45184. The actual bug fix was changing the logic so that the flag is reset
  45185. when the list of waiting animations becomes empty. I mistakenly committed
  45186. the bad logic in r81613.
  45187. * page/animation/AnimationBase.cpp:
  45188. (WebCore::AnimationBase::updateStateMachine):
  45189. - Always set paused time as we enter the paused state
  45190. * page/animation/AnimationController.cpp:
  45191. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  45192. (WebCore::AnimationControllerPrivate::endAnimationUpdate):
  45193. (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
  45194. (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
  45195. (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
  45196. - reset the waiting flag when the list is empty (rather than not empty)
  45197. (WebCore::AnimationControllerPrivate::startTimeResponse):
  45198. * page/animation/AnimationControllerPrivate.h:
  45199. - rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification
  45200. 2011-03-22 Brady Eidson <beidson@apple.com>
  45201. Reviewed by Sam Weinig.
  45202. <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
  45203. WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
  45204. * loader/icon/IconDatabase.cpp:
  45205. Add a dummy client implementation for non-Mac, non-Win ports:
  45206. (WebCore::DefaultIconDatabaseClient::performImport):
  45207. (WebCore::DefaultIconDatabaseClient::didImportIconURLForPageURL):
  45208. (WebCore::DefaultIconDatabaseClient::didImportIconDataForPageURL):
  45209. (WebCore::DefaultIconDatabaseClient::didChangeIconForPageURL):
  45210. (WebCore::DefaultIconDatabaseClient::didRemoveAllIcons):
  45211. (WebCore::DefaultIconDatabaseClient::didFinishURLImport):
  45212. (WebCore::defaultClient):
  45213. Either call the client directly when on the main thread, or use the dispatch functions below
  45214. if on the background thread:
  45215. (WebCore::IconDatabase::setIconDataForIconURL):
  45216. (WebCore::IconDatabase::setIconURLForPageURL):
  45217. (WebCore::IconDatabase::performURLImport):
  45218. (WebCore::IconDatabase::readFromDatabase):
  45219. (WebCore::IconDatabase::removeAllIconsOnThread):
  45220. Add a very targeted WorkItem interface for dispatching client calls on the main thread:
  45221. (WebCore::ClientWorkItem::ClientWorkItem):
  45222. (WebCore::ClientWorkItem::~ClientWorkItem):
  45223. (WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
  45224. (WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem):
  45225. (WebCore::ImportedIconURLForPageURLWorkItem::performWork):
  45226. (WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
  45227. (WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem):
  45228. (WebCore::ImportedIconDataForPageURLWorkItem::performWork):
  45229. (WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem):
  45230. (WebCore::RemovedAllIconsWorkItem::performWork):
  45231. (WebCore::performWorkItem):
  45232. Use the client WorkItem interface to perform these callbacks on the main thread:
  45233. (WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
  45234. (WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
  45235. (WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):
  45236. * loader/icon/IconDatabase.h:
  45237. * loader/icon/IconDatabaseClient.h:
  45238. 2011-03-22 David Hyatt <hyatt@apple.com>
  45239. Reviewed by Simon Fraser.
  45240. https://bugs.webkit.org/show_bug.cgi?id=56869
  45241. Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
  45242. a little faster than having to access the information from the RenderStyle's sub-structure.
  45243. * rendering/RenderBlock.cpp:
  45244. (WebCore::RenderBlock::layoutBlock):
  45245. (WebCore::RenderBlock::addOverflowFromChildren):
  45246. (WebCore::RenderBlock::computeOverflow):
  45247. (WebCore::RenderBlock::adjustPositionedBlock):
  45248. (WebCore::RenderBlock::setLogicalLeftForChild):
  45249. (WebCore::RenderBlock::setLogicalTopForChild):
  45250. (WebCore::RenderBlock::layoutPositionedObjects):
  45251. (WebCore::RenderBlock::paintColumnRules):
  45252. (WebCore::RenderBlock::paintColumnContents):
  45253. (WebCore::RenderBlock::flipFloatForWritingMode):
  45254. (WebCore::blockDirectionOffset):
  45255. (WebCore::inlineDirectionOffset):
  45256. (WebCore::RenderBlock::logicalRectToPhysicalRect):
  45257. (WebCore::RenderBlock::inlineSelectionGaps):
  45258. (WebCore::RenderBlock::addOverhangingFloats):
  45259. (WebCore::RenderBlock::addIntrudingFloats):
  45260. (WebCore::RenderBlock::hitTestColumns):
  45261. (WebCore::positionForPointRespectingEditingBoundaries):
  45262. (WebCore::RenderBlock::positionForPointWithInlineChildren):
  45263. (WebCore::RenderBlock::positionForPoint):
  45264. (WebCore::RenderBlock::columnRectAt):
  45265. (WebCore::RenderBlock::adjustPointToColumnContents):
  45266. (WebCore::RenderBlock::adjustRectForColumns):
  45267. (WebCore::RenderBlock::flipForWritingModeIncludingColumns):
  45268. (WebCore::RenderBlock::adjustForColumns):
  45269. (WebCore::RenderBlock::lastLineBoxBaseline):
  45270. (WebCore::RenderBlock::nextPageLogicalTop):
  45271. (WebCore::RenderBlock::adjustForUnsplittableChild):
  45272. (WebCore::RenderBlock::adjustLinePositionForPagination):
  45273. (WebCore::RenderBlock::collapsedMarginBeforeForChild):
  45274. (WebCore::RenderBlock::collapsedMarginAfterForChild):
  45275. (WebCore::RenderBlock::marginStartForChild):
  45276. (WebCore::RenderBlock::marginEndForChild):
  45277. (WebCore::RenderBlock::setMarginStartForChild):
  45278. (WebCore::RenderBlock::setMarginEndForChild):
  45279. (WebCore::RenderBlock::marginValuesForChild):
  45280. * rendering/RenderBlock.h:
  45281. (WebCore::RenderBlock::logicalWidthForChild):
  45282. (WebCore::RenderBlock::logicalHeightForChild):
  45283. (WebCore::RenderBlock::logicalTopForChild):
  45284. (WebCore::RenderBlock::logicalRightOffsetForContent):
  45285. (WebCore::RenderBlock::logicalLeftOffsetForContent):
  45286. (WebCore::RenderBlock::logicalTopForFloat):
  45287. (WebCore::RenderBlock::logicalBottomForFloat):
  45288. (WebCore::RenderBlock::logicalLeftForFloat):
  45289. (WebCore::RenderBlock::logicalRightForFloat):
  45290. (WebCore::RenderBlock::logicalWidthForFloat):
  45291. (WebCore::RenderBlock::setLogicalTopForFloat):
  45292. (WebCore::RenderBlock::setLogicalLeftForFloat):
  45293. (WebCore::RenderBlock::setLogicalHeightForFloat):
  45294. (WebCore::RenderBlock::setLogicalWidthForFloat):
  45295. (WebCore::RenderBlock::xPositionForFloatIncludingMargin):
  45296. (WebCore::RenderBlock::yPositionForFloatIncludingMargin):
  45297. * rendering/RenderBlockLineLayout.cpp:
  45298. (WebCore::RenderBlock::createLineBoxes):
  45299. (WebCore::RenderBlock::layoutInlineChildren):
  45300. (WebCore::RenderBlock::checkFloatsInCleanLine):
  45301. (WebCore::setStaticPositions):
  45302. (WebCore::RenderBlock::findNextLineBreak):
  45303. (WebCore::RenderBlock::beforeSideVisualOverflowForLine):
  45304. (WebCore::RenderBlock::afterSideVisualOverflowForLine):
  45305. (WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
  45306. (WebCore::RenderBlock::afterSideLayoutOverflowForLine):
  45307. * rendering/RenderBox.cpp:
  45308. (WebCore::RenderBox::marginStart):
  45309. (WebCore::RenderBox::marginEnd):
  45310. (WebCore::RenderBox::setMarginStart):
  45311. (WebCore::RenderBox::setMarginEnd):
  45312. (WebCore::RenderBox::styleDidChange):
  45313. (WebCore::RenderBox::logicalScroll):
  45314. (WebCore::RenderBox::computeLogicalWidth):
  45315. (WebCore::RenderBox::computeLogicalHeight):
  45316. (WebCore::RenderBox::availableLogicalHeightUsing):
  45317. (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
  45318. (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
  45319. (WebCore::RenderBox::computePositionedLogicalWidth):
  45320. (WebCore::computeLogicalLeftPositionedOffset):
  45321. (WebCore::RenderBox::computePositionedLogicalHeight):
  45322. (WebCore::computeLogicalTopPositionedOffset):
  45323. (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
  45324. (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
  45325. (WebCore::RenderBox::addLayoutOverflow):
  45326. (WebCore::RenderBox::flipForWritingMode):
  45327. * rendering/RenderBoxModelObject.cpp:
  45328. (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
  45329. * rendering/RenderObject.cpp:
  45330. (WebCore::RenderObject::RenderObject):
  45331. (WebCore::RenderObject::styleWillChange):
  45332. * rendering/RenderObject.h:
  45333. (WebCore::RenderObject::isHorizontalWritingMode):
  45334. (WebCore::RenderObject::setHorizontalWritingMode):
  45335. * rendering/RenderTableCell.cpp:
  45336. (WebCore::RenderTableCell::paddingTop):
  45337. (WebCore::RenderTableCell::paddingBottom):
  45338. (WebCore::RenderTableCell::paddingLeft):
  45339. (WebCore::RenderTableCell::paddingRight):
  45340. (WebCore::RenderTableCell::scrollbarsChanged):
  45341. * rendering/RootInlineBox.cpp:
  45342. (WebCore::RootInlineBox::RootInlineBox):
  45343. (WebCore::RootInlineBox::lineSelectionGap):
  45344. (WebCore::RootInlineBox::verticalPositionForBox):
  45345. 2011-03-22 Simon Fraser <simon.fraser@apple.com>
  45346. Reviewed by Beth Dakin.
  45347. Incorrect rendering of composited element with negative z-index child
  45348. https://bugs.webkit.org/show_bug.cgi?id=56846
  45349. When a composited element has a child with negative z-index, we make
  45350. a separate layer for that element's foreground content. This layer
  45351. was positioned incorrectly (but the content happened to paint at
  45352. the right location), resulting in right/bottom clipping.
  45353. Fix this, remove the little-used graphicsLayerToContentsCoordinates()
  45354. contentsToGraphicsLayerCoordinates() methods, and optimize incremental
  45355. repaints in the foreground and mask layers.
  45356. Tests: compositing/geometry/foreground-layer.html
  45357. compositing/geometry/repaint-foreground-layer.html
  45358. * platform/graphics/ca/GraphicsLayerCA.cpp:
  45359. (WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints
  45360. which fall outside the layer bounds, so callers don't have to,
  45361. and to avoid unnecessary layer commits.
  45362. * rendering/RenderLayerBacking.cpp:
  45363. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If
  45364. we have a foreground layer inside a clipping layer, the foreground
  45365. layer's offset is zero, since the clipping layer is its parent.
  45366. (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
  45367. offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
  45368. Also do incremental repaints of the foreground and mask layers.
  45369. (WebCore::RenderLayerBacking::paintContents): It was incorrect to always
  45370. use compositedBounds() to compute the painting offset, since that's
  45371. per-RenderLayerBacking, but a single RenderLayerBacking can have different
  45372. GraphicsLayers with different offsets (e.g. the foreground layer).
  45373. Instead, use offsetFromRenderer(), which gives has the correct offset.
  45374. * rendering/RenderLayerBacking.h: Remove unused methods.
  45375. 2011-03-22 Chris Rogers <crogers@google.com>
  45376. Reviewed by Kenneth Russell.
  45377. Use default-output instead of default-input to get hardware sample-rate
  45378. https://bugs.webkit.org/show_bug.cgi?id=56858
  45379. No new tests since audio API is not yet implemented.
  45380. * platform/audio/mac/AudioDestinationMac.cpp:
  45381. (WebCore::AudioDestination::hardwareSampleRate):
  45382. 2011-03-22 Pratik Solanki <psolanki@apple.com>
  45383. Reviewed by David Kilzer.
  45384. Implement -connection:didReceiveDataArray: NSURLConnection delegate method
  45385. https://bugs.webkit.org/show_bug.cgi?id=56838
  45386. Add experimental support for the didReceiveDataArray callback on
  45387. NSURLConnection. A RessourceHandleClient indicates its ability to
  45388. handle this callback by returning true from supportsDataArray() method.
  45389. Currently only SubresourceLoader uses this so we get the benefit for
  45390. CSS, JS and image loads. For other clients we call didReceiveData with
  45391. the CFData contents as before.
  45392. * WebCore.xcodeproj/project.pbxproj:
  45393. * loader/ResourceLoader.h:
  45394. * loader/SubresourceLoader.h:
  45395. (WebCore::SubresourceLoader::supportsDataArray):
  45396. * loader/cf/SubresourceLoaderCF.cpp: Added.
  45397. (WebCore::SubresourceLoader::didReceiveDataArray):
  45398. * loader/mac/ResourceLoaderMac.mm:
  45399. (WebCore::ResourceLoader::didReceiveDataArray):
  45400. * platform/SharedBuffer.cpp:
  45401. (WebCore::SharedBuffer::clear):
  45402. (WebCore::SharedBuffer::buffer):
  45403. * platform/SharedBuffer.h:
  45404. * platform/cf/SharedBufferCF.cpp:
  45405. (WebCore::SharedBuffer::append):
  45406. (WebCore::SharedBuffer::copyDataArrayAndClear):
  45407. * platform/network/ResourceHandleClient.h:
  45408. (WebCore::ResourceHandleClient::supportsDataArray):
  45409. (WebCore::ResourceHandleClient::didReceiveDataArray):
  45410. * platform/network/mac/ResourceHandleMac.mm:
  45411. (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
  45412. 2011-03-22 Eric Seidel <eric@webkit.org>
  45413. Reviewed by Adam Barth.
  45414. Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
  45415. https://bugs.webkit.org/show_bug.cgi?id=56867
  45416. This should make it possible to build the gyp-generated WebCore.xcodeproj
  45417. from a WebCore directory outside of Source.
  45418. * gyp/WebCore.gyp:
  45419. * gyp/run-if-exists.sh: Added.
  45420. * gyp/update-info-plist.sh: Added.
  45421. 2011-03-22 Anders Carlsson <andersca@apple.com>
  45422. Fix WebKit2 build.
  45423. * WebCore.exp.in:
  45424. Export a symbol needed by WebKit2.
  45425. 2011-03-22 Adam Barth <abarth@webkit.org>
  45426. Reviewed by Eric Seidel.
  45427. Add the remaining steps to WebCore GYP build
  45428. https://bugs.webkit.org/show_bug.cgi?id=56864
  45429. These steps match the normal build. After this patch, I believe the
  45430. WebCore GYP build is complete.
  45431. * WebCore.gypi:
  45432. * gyp/WebCore.gyp:
  45433. * gyp/copy-inspector-resources.sh: Added.
  45434. 2011-03-22 Beth Dakin <bdakin@apple.com>
  45435. Reviewed by Simon Fraser.
  45436. Fix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
  45437. added to Page::scrollableAreaSet()
  45438. * rendering/RenderListBox.cpp:
  45439. (WebCore::RenderListBox::RenderListBox):
  45440. (WebCore::RenderListBox::~RenderListBox):
  45441. * rendering/RenderListBox.h:
  45442. (WebCore::RenderListBox::disconnectFromPage):
  45443. 2011-03-22 Chris Rogers <crogers@google.com>
  45444. Reviewed by Kenneth Russell.
  45445. Add high-quality band-limited audio resampling algorithm
  45446. https://bugs.webkit.org/show_bug.cgi?id=56692
  45447. No new tests since audio API is not yet implemented.
  45448. * platform/audio/SincResampler.cpp: Added.
  45449. (WebCore::SincResampler::SincResampler):
  45450. (WebCore::SincResampler::initializeKernel):
  45451. (WebCore::SincResampler::consumeSource):
  45452. (WebCore::SincResampler::process):
  45453. * platform/audio/SincResampler.h: Added.
  45454. 2011-03-22 Adam Barth <abarth@webkit.org>
  45455. Reviewed by Eric Seidel.
  45456. WebCore GYP build should build without help from normal WebCore build
  45457. https://bugs.webkit.org/show_bug.cgi?id=56860
  45458. Before this patch, the WebCore GYP build wasn't generating the derived
  45459. sources quite right because the ENABLE macros were not being
  45460. communicated to the "Derived Sources" target.
  45461. This patch also adds the "Copy Forwarding and ICU Headers" as well as
  45462. the "Streamline Inspector Source" steps, which are present in the
  45463. normal build. Unlike the normal build, these steps occur in a new
  45464. target, called "WebCore Support", which is less than aesthetically
  45465. beautiful. Hopefully we'll be able to move them into the WebCore
  45466. target proper in the future, but that will likely require some GYP
  45467. changes.
  45468. This patch probably could have been broken down into a couple smaller
  45469. patches, but that doesn't seem necessary.
  45470. * WebCore.gypi:
  45471. - This file appears to no longer exist.
  45472. * gyp/WebCore.gyp:
  45473. * gyp/copy-forwarding-and-icu-headers.sh: Added.
  45474. * gyp/streamline-inspector-source.sh: Added.
  45475. 2011-03-22 David Hyatt <hyatt@apple.com>
  45476. Reviewed by Simon Fraser.
  45477. https://bugs.webkit.org/show_bug.cgi?id=56859
  45478. Floats in the floating object list occur in the order that they are positioned. This means
  45479. that for a given vertical offset, the last left object in the list that intersects that offset
  45480. will be the rightmost float. There is no need to check any previous floats, since they have to be
  45481. further left than that rightmost float. The same rules hold true for right-aligned floats.
  45482. Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
  45483. they encounter a float that intersects the vertical range.
  45484. This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.
  45485. * rendering/RenderBlock.cpp:
  45486. (WebCore::RenderBlock::logicalLeftOffsetForLine):
  45487. (WebCore::RenderBlock::logicalRightOffsetForLine):
  45488. 2011-03-22 Justin Schuh <jschuh@chromium.org>
  45489. Reviewed by Dirk Schulze.
  45490. SVG displacement map should validate channel selections
  45491. https://bugs.webkit.org/show_bug.cgi?id=56794
  45492. Test: svg/filters/feDisplacementMap-crash-test.xhtml
  45493. * svg/SVGFEDisplacementMapElement.cpp:
  45494. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
  45495. 2011-03-22 Huahui Wu <mediadependent@gmail.com>
  45496. Reviewed by Steve Block.
  45497. [Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
  45498. https://bugs.webkit.org/show_bug.cgi?id=56763
  45499. No new tests as no new functionality is exposed.
  45500. * platform/PlatformTouchEvent.h:
  45501. * platform/android/PlatformTouchEventAndroid.cpp:
  45502. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  45503. 2011-03-22 David Hyatt <hyatt@apple.com>
  45504. Reviewed by Simon Fraser.
  45505. Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
  45506. you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
  45507. fit to the font size. You can ignore replaced elements, etc.
  45508. Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
  45509. so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
  45510. height based off the block's line-box-contain value.
  45511. GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.
  45512. RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.
  45513. Added new tests in fast/block/lineboxcontain
  45514. * GNUmakefile.am:
  45515. * WebCore.gypi:
  45516. * WebCore.pro:
  45517. * WebCore.vcproj/WebCore.vcproj:
  45518. * WebCore.xcodeproj/project.pbxproj:
  45519. * css/CSSComputedStyleDeclaration.cpp:
  45520. (WebCore::createLineBoxContainValue):
  45521. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  45522. * css/CSSLineBoxContainValue.cpp: Added.
  45523. (WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
  45524. (WebCore::CSSLineBoxContainValue::cssText):
  45525. * css/CSSLineBoxContainValue.h: Added.
  45526. (WebCore::CSSLineBoxContainValue::create):
  45527. (WebCore::CSSLineBoxContainValue::value):
  45528. (WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):
  45529. * css/CSSParser.cpp:
  45530. (WebCore::CSSParser::parseValue):
  45531. (WebCore::CSSParser::parseLineBoxContain):
  45532. * css/CSSParser.h:
  45533. * css/CSSPropertyNames.in:
  45534. * css/CSSStyleSelector.cpp:
  45535. (WebCore::CSSStyleSelector::applyProperty):
  45536. * css/CSSValue.h:
  45537. (WebCore::CSSValue::isCSSLineBoxContainValue):
  45538. * css/CSSValueKeywords.in:
  45539. * platform/graphics/Font.cpp:
  45540. (WebCore::Font::width):
  45541. * platform/graphics/Font.h:
  45542. (WebCore::GlyphOverflow::GlyphOverflow):
  45543. * platform/graphics/FontFastPath.cpp:
  45544. (WebCore::Font::floatWidthForSimpleText):
  45545. * platform/graphics/mac/FontComplexTextMac.cpp:
  45546. (WebCore::Font::floatWidthForComplexText):
  45547. * platform/graphics/win/FontWin.cpp:
  45548. (WebCore::Font::floatWidthForComplexText):
  45549. * rendering/InlineFlowBox.cpp:
  45550. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  45551. * rendering/InlineFlowBox.h:
  45552. * rendering/RenderBlock.h:
  45553. * rendering/RenderBlockLineLayout.cpp:
  45554. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  45555. (WebCore::RenderBlock::layoutInlineChildren):
  45556. * rendering/RenderInline.cpp:
  45557. (WebCore::RenderInline::marginLeft):
  45558. (WebCore::RenderInline::marginRight):
  45559. (WebCore::RenderInline::marginTop):
  45560. (WebCore::RenderInline::marginBottom):
  45561. (WebCore::RenderInline::marginBefore):
  45562. (WebCore::RenderInline::marginAfter):
  45563. * rendering/RenderInline.h:
  45564. * rendering/RenderText.cpp:
  45565. (WebCore::RenderText::widthFromCache):
  45566. (WebCore::RenderText::width):
  45567. * rendering/RootInlineBox.cpp:
  45568. (WebCore::RootInlineBox::alignBoxesInBlockDirection):
  45569. (WebCore::setAscentAndDescent):
  45570. (WebCore::RootInlineBox::ascentAndDescentForBox):
  45571. (WebCore::RootInlineBox::verticalPositionForBox):
  45572. (WebCore::RootInlineBox::includeLeadingForBox):
  45573. (WebCore::RootInlineBox::includeFontForBox):
  45574. (WebCore::RootInlineBox::includeGlyphsForBox):
  45575. (WebCore::RootInlineBox::includeMarginForBox):
  45576. (WebCore::RootInlineBox::fitsToGlyphs):
  45577. (WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):
  45578. * rendering/RootInlineBox.h:
  45579. * rendering/style/RenderStyle.cpp:
  45580. (WebCore::RenderStyle::diff):
  45581. * rendering/style/RenderStyle.h:
  45582. (WebCore::InheritedFlags::lineBoxContain):
  45583. (WebCore::InheritedFlags::setLineBoxContain):
  45584. (WebCore::InheritedFlags::initialLineBoxContain):
  45585. * rendering/style/StyleRareInheritedData.cpp:
  45586. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  45587. (WebCore::StyleRareInheritedData::operator==):
  45588. * rendering/style/StyleRareInheritedData.h:
  45589. 2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>
  45590. Unreviewed, rolling out r81653.
  45591. http://trac.webkit.org/changeset/81653
  45592. https://bugs.webkit.org/show_bug.cgi?id=56839
  45593. Breaks fast/text/drawBidiText.html on Chromium. (Requested by
  45594. pfeldman on #webkit).
  45595. * rendering/RenderListBox.cpp:
  45596. (WebCore::RenderListBox::paintItemForeground):
  45597. 2011-03-22 Pavel Feldman <pfeldman@chromium.org>
  45598. Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.
  45599. * inspector/Inspector.json:
  45600. * inspector/InspectorDatabaseResource.cpp:
  45601. (WebCore::InspectorDatabaseResource::bind):
  45602. * inspector/front-end/Database.js:
  45603. (WebInspector.DatabaseDispatcher.prototype.addDatabase):
  45604. 2011-03-21 Pavel Podivilov <podivilov@chromium.org>
  45605. Reviewed by Yury Semikhatsky.
  45606. Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
  45607. https://bugs.webkit.org/show_bug.cgi?id=56747
  45608. Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).
  45609. * inspector/Inspector.json:
  45610. * inspector/InspectorAgent.cpp:
  45611. (WebCore::InspectorAgent::showProfilesPanel):
  45612. * inspector/InspectorAgent.h:
  45613. * inspector/InspectorController.cpp:
  45614. (WebCore::InspectorController::InspectorController):
  45615. (WebCore::InspectorController::connectFrontend):
  45616. (WebCore::InspectorController::showAndEnableDebugger):
  45617. * inspector/InspectorController.h:
  45618. * inspector/InspectorDebuggerAgent.cpp:
  45619. (WebCore::InspectorDebuggerAgent::setFrontend):
  45620. (WebCore::InspectorDebuggerAgent::clearFrontend):
  45621. * inspector/InspectorDebuggerAgent.h:
  45622. 2011-03-22 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  45623. Reviewed by Benjamin Poulain.
  45624. [Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
  45625. https://bugs.webkit.org/show_bug.cgi?id=56824
  45626. On desktop OpenGL substitute in renderbufferStorage:
  45627. - GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
  45628. - GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
  45629. - GL_RGBA for GL_RGBA4 and GL_RGBA565
  45630. - GL_RGB for RGB5_A1.
  45631. Tests: fast/canvas/webgl/uninitialized-test.html
  45632. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  45633. (WebCore::GraphicsContext3D::renderbufferStorage):
  45634. 2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
  45635. Reviewed by Eric Seidel.
  45636. Move volume slider positioning logic to a custom renderer.
  45637. https://bugs.webkit.org/show_bug.cgi?id=56498
  45638. No functional change, covered by existing tests.
  45639. * html/shadow/MediaControls.cpp:
  45640. (WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
  45641. * rendering/MediaControlElements.cpp:
  45642. (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added.
  45643. (WebCore::RenderMediaVolumeSliderContainer::layout): Added.
  45644. (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates.
  45645. (WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added.
  45646. (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
  45647. * rendering/MediaControlElements.h: Changed corresponding decls.
  45648. 2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
  45649. Reviewed by Benjamin Poulain.
  45650. [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
  45651. https://bugs.webkit.org/show_bug.cgi?id=54138
  45652. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  45653. (WebCore::GraphicsContext3DInternal::getViewportGLWidget):
  45654. Check if we actually have a QWebPageClient before dereferencing it.
  45655. 2011-03-22 Pavel Feldman <pfeldman@chromium.org>
  45656. Reviewed by Yury Semikhatsky.
  45657. Web Inspector: document DOM domain types and protocol methods.
  45658. https://bugs.webkit.org/show_bug.cgi?id=56807
  45659. * inspector/InjectedScript.cpp:
  45660. (WebCore::InjectedScript::wrapNode):
  45661. * inspector/InjectedScript.h:
  45662. * inspector/Inspector.json:
  45663. * inspector/InspectorBrowserDebuggerAgent.cpp:
  45664. (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  45665. * inspector/InspectorDOMAgent.cpp:
  45666. (WebCore::InspectorDOMAgent::removeNode):
  45667. (WebCore::InspectorDOMAgent::setNodeValue):
  45668. * inspector/InspectorDOMAgent.h:
  45669. * inspector/front-end/ElementsTreeOutline.js:
  45670. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
  45671. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  45672. * inspector/front-end/EventListenersSidebarPane.js:
  45673. * inspector/front-end/PropertiesSidebarPane.js:
  45674. (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  45675. * inspector/front-end/RemoteObject.js:
  45676. (WebInspector.RemoteObject.resolveNode):
  45677. 2011-03-22 Adam Barth <abarth@webkit.org>
  45678. Reviewed by Eric Seidel.
  45679. Production configuration in GYP isn&apos;t set up correctly
  45680. https://bugs.webkit.org/show_bug.cgi?id=56786
  45681. Update WebCore.gyp with information mined from WebCore.xcodeproj.
  45682. * WebCore.gypi:
  45683. * gyp/WebCore.gyp:
  45684. 2011-03-22 Ofri Wolfus <ofri@google.com>
  45685. Reviewed by Eric Seidel.
  45686. RTL: Select elements with a size attribute are always left aligned.
  45687. https://bugs.webkit.org/show_bug.cgi?id=50928
  45688. Added support for alignment in RenderListBox.
  45689. Test: fast/forms/listbox-bidi-align.html
  45690. * rendering/RenderListBox.cpp:
  45691. (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
  45692. 2011-03-22 Ilya Sherman <isherman@chromium.org>
  45693. Reviewed by Kent Tamura.
  45694. Clear autofilled flag when reseting a form
  45695. In service of https://code.google.com/p/chromium/issues/detail?id=70037
  45696. https://bugs.webkit.org/show_bug.cgi?id=56802
  45697. Test: fast/forms/reset-autofilled.html
  45698. * html/HTMLInputElement.cpp:
  45699. (WebCore::HTMLInputElement::reset): Clear the autofilled flag.
  45700. 2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
  45701. Reviewed by Yury Semikhatsky.
  45702. Web Inspector: protocol cleanup. DatabaseAgent.
  45703. https://bugs.webkit.org/show_bug.cgi?id=56815
  45704. see protocol metabug:
  45705. - All events should use notification wording, not command wording:
  45706. addDatabase was renamed to DatabaseOpened.
  45707. Test: inspector/protocol/database-agent.html
  45708. * inspector/Inspector.json:
  45709. * inspector/InspectorDatabaseResource.cpp:
  45710. (WebCore::InspectorDatabaseResource::bind):
  45711. * inspector/front-end/Database.js:
  45712. (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):
  45713. 2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
  45714. Reviewed by Yury Semikhatsky.
  45715. Web Inspector: protocol cleanup. ConsoleAgent.
  45716. https://bugs.webkit.org/show_bug.cgi?id=56806
  45717. renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
  45718. new method: disable()
  45719. deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.
  45720. * inspector/ConsoleMessage.cpp:
  45721. (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  45722. * inspector/Inspector.json:
  45723. * inspector/InspectorConsoleAgent.cpp:
  45724. (WebCore::InspectorConsoleAgent::enable):
  45725. (WebCore::InspectorConsoleAgent::disable):
  45726. * inspector/InspectorConsoleAgent.h:
  45727. * inspector/front-end/ConsoleView.js:
  45728. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated):
  45729. (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
  45730. * inspector/front-end/inspector.js:
  45731. 2011-03-22 Kent Tamura <tkent@chromium.org>
  45732. Reviewed by Eric Seidel.
  45733. REGRESSION(r80096): Number type input unexpectedly rounds fractional values
  45734. https://bugs.webkit.org/show_bug.cgi?id=56367
  45735. Because the default value of the maximum fractional digits of NSNumberFormatter
  45736. and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
  45737. localized representation. This bug affects only in Mac and Chromium.
  45738. To fix this bug,
  45739. - Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
  45740. - NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces()
  45741. instead of parseToDoubleForNumberType().
  45742. No automated tests because the behavior is locale-dependent. This change
  45743. updates a manual test.
  45744. * html/NumberInputType.cpp:
  45745. (WebCore::NumberInputType::visibleValue):
  45746. Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional
  45747. part length to formatLocalizedNumber().
  45748. * manual-tests/input-number-localization.html:
  45749. Update the test to cover this change.
  45750. * platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
  45751. * platform/text/LocalizedNumberICU.cpp:
  45752. (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
  45753. * platform/text/LocalizedNumberNone.cpp:
  45754. (WebCore::formatLocalizedNumber):
  45755. * platform/text/mac/LocalizedNumberMac.mm:
  45756. (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
  45757. 2011-03-21 Abhishek Arya <inferno@chromium.org>
  45758. Reviewed by Eric Seidel.
  45759. Anonymous blocks need isRenderBlock cast check. Also, need
  45760. to allow display BOX for flexible boxes.
  45761. https://bugs.webkit.org/show_bug.cgi?id=56709
  45762. Test: accessibility/anchor-linked-anonymous-block-crash.html
  45763. * rendering/RenderBlock.cpp:
  45764. (WebCore::canMergeContiguousAnonymousBlocks): remove specific
  45765. fix in r81088 which is no longer needed.
  45766. * rendering/RenderObject.h:
  45767. (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast
  45768. check.
  45769. 2011-03-21 Abhishek Arya <inferno@chromium.org>
  45770. Reviewed by Eric Seidel.
  45771. Revert small change made in r78846 of replacing move with positionLineBox
  45772. in the adjusting position function for inline box.
  45773. https://bugs.webkit.org/show_bug.cgi?id=56300
  45774. The change in r78846 caused positioning line boxes during the step of adjusting
  45775. position for inline box, thereby causing line boxes to be nuked. This happens as
  45776. part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
  45777. Later on, we do the positioning of line boxes again later in that function. This
  45778. causes use of removed inline box leading to crash. Also, it is unnecessary to do
  45779. this twice.
  45780. Tests: fast/inline/inline-box-adjust-position-crash.html
  45781. fast/inline/inline-box-adjust-position-crash2.html
  45782. * rendering/InlineBox.cpp:
  45783. (WebCore::InlineBox::adjustPosition):
  45784. 2011-03-21 Adam Klein <adamk@chromium.org>
  45785. Reviewed by David Levin.
  45786. [fileapi] Add URI resolution support to WorkerContext
  45787. https://bugs.webkit.org/show_bug.cgi?id=55644
  45788. Tests: http/tests/filesystem/workers/resolve-url-sync.html
  45789. http/tests/filesystem/workers/resolve-url.html
  45790. * fileapi/LocalFileSystem.cpp:
  45791. (WebCore::LocalFileSystem::readFileSystem):
  45792. Add support for workers.
  45793. * fileapi/LocalFileSystem.h:
  45794. * workers/WorkerContext.cpp:
  45795. (WebCore::WorkerContext::resolveLocalFileSystemURL):
  45796. (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
  45797. * workers/WorkerContext.h:
  45798. * workers/WorkerContext.idl:
  45799. 2011-03-21 David Levin <levin@chromium.org>
  45800. Reviewed by Adam Barth.
  45801. XHR in Workers doesn't set the referrer correctly.
  45802. https://bugs.webkit.org/show_bug.cgi?id=24683
  45803. Tests: http/tests/xmlhttprequest/workers/referer.html
  45804. http/tests/xmlhttprequest/workers/shared-worker-referer.html
  45805. * loader/DocumentThreadableLoader.cpp:
  45806. (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer.
  45807. (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer.
  45808. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
  45809. (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
  45810. * loader/DocumentThreadableLoader.h: Ditto.
  45811. * loader/ResourceLoadScheduler.cpp:
  45812. (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
  45813. * loader/ResourceLoadScheduler.h: Ditto.
  45814. * loader/SubresourceLoader.cpp:
  45815. (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
  45816. * loader/WorkerThreadableLoader.cpp:
  45817. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer.
  45818. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer.
  45819. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
  45820. * loader/WorkerThreadableLoader.h:
  45821. 2011-03-21 Nate Chapin <japhet@chromium.org>
  45822. Reviewed by Brady Eidson.
  45823. Do not check the DocumentLoader's request cache policy
  45824. in determining whether we should force revalidation of a cached
  45825. subresource. If the main resource received headers telling it not
  45826. to cache, that policy will be propagated to subresources.
  45827. The previous behavior is left in behind a flag in Settings, since
  45828. QuickLook depends on it.
  45829. https://bugs.webkit.org/show_bug.cgi?id=38690
  45830. Tests: http/tests/cache/post-redirect-get.php
  45831. http/tests/cache/post-with-cached-subresources.php
  45832. * loader/FrameLoader.cpp:
  45833. (WebCore::FrameLoader::subresourceCachePolicy):
  45834. (WebCore::FrameLoader::loadPostRequest):
  45835. * page/Settings.cpp:
  45836. (WebCore::Settings::Settings):
  45837. * page/Settings.h:
  45838. (WebCore::Settings::setUseQuickLookResourceCachingQuirks):
  45839. (WebCore::Settings::useQuickLookResourceCachingQuirks):
  45840. 2011-03-21 Rik Cabanier <cabanier@adobe.com>
  45841. Reviewed by James Robinson.
  45842. bug 56052: percentages are incorrectly rounded in WebKit
  45843. https://bugs.webkit.org/show_bug.cgi?id=56052
  45844. test: fast/css/percentage-non-integer.html
  45845. * css/CSSStyleSelector.cpp:
  45846. (WebCore::CSSStyleSelector::applyProperty):
  45847. * page/PrintContext.cpp:
  45848. (WebCore::PrintContext::pageProperty):
  45849. * platform/Length.h:
  45850. (WebCore::Length::Length):
  45851. (WebCore::Length::operator*=):
  45852. (WebCore::Length::value):
  45853. (WebCore::Length::percent):
  45854. (WebCore::Length::setValue):
  45855. (WebCore::Length::calcValue):
  45856. (WebCore::Length::calcMinValue):
  45857. (WebCore::Length::isUndefined):
  45858. (WebCore::Length::isZero):
  45859. (WebCore::Length::isPositive):
  45860. (WebCore::Length::isNegative):
  45861. * rendering/AutoTableLayout.cpp:
  45862. (WebCore::AutoTableLayout::recalcColumn):
  45863. (WebCore::AutoTableLayout::computePreferredLogicalWidths):
  45864. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  45865. (WebCore::AutoTableLayout::layout):
  45866. * rendering/FixedTableLayout.cpp:
  45867. (WebCore::FixedTableLayout::calcWidthArray):
  45868. (WebCore::FixedTableLayout::layout):
  45869. * rendering/RenderTableSection.cpp:
  45870. (WebCore::RenderTableSection::addCell):
  45871. (WebCore::RenderTableSection::layoutRows):
  45872. * rendering/style/BorderData.h:
  45873. (WebCore::BorderData::hasBorderRadius):
  45874. 2011-03-21 Adam Barth <abarth@webkit.org>
  45875. Reviewed by Eric Seidel.
  45876. Add WebCoreExportFileGenerator to WebCore GYP build
  45877. https://bugs.webkit.org/show_bug.cgi?id=56778
  45878. This target mirrors the eponymous target from WebCore.xcodeproj.
  45879. * WebCore.gypi:
  45880. * gyp/WebCore.gyp:
  45881. * generate-webcore-export-file-generator.sh: Added.
  45882. 2011-03-21 Adam Barth <abarth@webkit.org>
  45883. Reviewed by Dimitri Glazkov.
  45884. WebCore GYP build shouldn&apos;t crash on startup
  45885. https://bugs.webkit.org/show_bug.cgi?id=56776
  45886. Debug builds shouldn't define NDEBUG. This same logic exists in the
  45887. project.pbxproj file.
  45888. * gyp/WebCore.gyp:
  45889. 2011-03-21 Daniel Cheng <dcheng@chromium.org>
  45890. Reviewed by Tony Chang.
  45891. [chromium] Implement glue between DataTransferItems and the pasteboard.
  45892. https://bugs.webkit.org/show_bug.cgi?id=56330
  45893. Support retrieving clipboard data in a paste through DataTransferItems.
  45894. Test: editing/pasteboard/data-transfer-items.html
  45895. * platform/chromium/ClipboardChromium.cpp:
  45896. (WebCore::ClipboardChromium::items):
  45897. * platform/chromium/DataTransferItemChromium.cpp:
  45898. (WebCore::DataTransferItemChromium::createFromPasteboard):
  45899. (WebCore::DataTransferItemChromium::create):
  45900. (WebCore::DataTransferItemChromium::DataTransferItemChromium):
  45901. (WebCore::DataTransferItemChromium::getAsString):
  45902. * platform/chromium/DataTransferItemChromium.h:
  45903. * platform/chromium/DataTransferItemsChromium.cpp:
  45904. (WebCore::DataTransferItemsChromium::addPasteboardItem):
  45905. * platform/chromium/DataTransferItemsChromium.h:
  45906. 2011-03-21 Chris Fleizach <cfleizach@apple.com>
  45907. Reviewed by Darin Adler.
  45908. AX: showContextMenu not working in WK2
  45909. https://bugs.webkit.org/show_bug.cgi?id=56734
  45910. WebKit2 is not able to directly open a context menu because the UI is in the other process.
  45911. Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
  45912. code.
  45913. * accessibility/mac/AccessibilityObjectWrapper.mm:
  45914. (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
  45915. 2011-03-21 Robert Kroeger <rjkroege@chromium.org>
  45916. Reviewed by Antonio Gomes.
  45917. Add Support to WebCore to optionally call a platform-specific gesture recognizer
  45918. https://bugs.webkit.org/show_bug.cgi?id=49345
  45919. Added an ability for the EventHandler to invoke an optional platform
  45920. specific gesture recognizer.
  45921. No tests added because the change should be functionally invisible.
  45922. * WebCore.gypi:
  45923. * page/EventHandler.cpp:
  45924. (WebCore::EventHandler::EventHandler):
  45925. (WebCore::EventHandler::handleTouchEvent):
  45926. * page/EventHandler.h:
  45927. * platform/PlatformGestureRecognizer.cpp: Added.
  45928. (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
  45929. (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
  45930. (WebCore::PlatformGestureRecognizer::create):
  45931. * platform/PlatformGestureRecognizer.h: Added.
  45932. 2011-03-21 Dean Jackson <dino@apple.com>
  45933. Reviewed by Chris Marrin and Simon Fraser.
  45934. https://bugs.webkit.org/show_bug.cgi?id=56325
  45935. ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()
  45936. AnimationBase had a custom linked-list/self-pointer for keeping
  45937. track of animations that needed to be notified of style updates
  45938. and start progress. This caused problems when AnimationBase was
  45939. destroyed, since the pointer wasn't managed in any way. I replaced
  45940. these pointers with HashSets and moved the code that removes animations
  45941. from the sets into AnimationControllerPrivate, where it belongs.
  45942. CompositeAnimation is also more careful to tell AnimationControllerPrivate
  45943. when it no longer needs to keep track of waiting animations.
  45944. This should stop the style updates being called on non-active animations
  45945. (which was the cause of the state machine error here) and should also
  45946. stop a few of the related flakey test failures and occasional crashes.
  45947. Test: animations/body-removal-crash.html
  45948. * page/animation/AnimationBase.cpp:
  45949. (WebCore::AnimationBase::AnimationBase):
  45950. (WebCore::AnimationBase::updateStateMachine):
  45951. * page/animation/AnimationBase.h:
  45952. (WebCore::AnimationBase::~AnimationBase):
  45953. - Remove the linked-list
  45954. * page/animation/AnimationController.cpp:
  45955. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  45956. (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle):
  45957. (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle):
  45958. (WebCore::AnimationControllerPrivate::styleAvailable):
  45959. (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
  45960. (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
  45961. (WebCore::AnimationControllerPrivate::startTimeResponse):
  45962. (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
  45963. - New method to remove animations from the waiting lists
  45964. * page/animation/AnimationControllerPrivate.h:
  45965. - use a HashSet rather than an AnimationBase* pointer.
  45966. * page/animation/CompositeAnimation.cpp:
  45967. (WebCore::CompositeAnimation::~CompositeAnimation):
  45968. (WebCore::CompositeAnimation::clearRenderer):
  45969. (WebCore::CompositeAnimation::updateTransitions):
  45970. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  45971. - remove the animations and transitions from the lists when we know
  45972. they are no longer active (rather than waiting for the AnimationBase
  45973. to do it when destructing)
  45974. 2011-03-21 Justin Schuh <jschuh@chromium.org>
  45975. Reviewed by James Robinson.
  45976. Stop inserting when the parent is removed
  45977. https://bugs.webkit.org/show_bug.cgi?id=56690
  45978. Tests: fast/dom/insertedIntoDocument-child.html
  45979. fast/dom/insertedIntoDocument-iframe.html
  45980. fast/dom/insertedIntoDocument-sibling.html
  45981. * dom/ContainerNode.cpp:
  45982. (WebCore::ContainerNode::insertedIntoDocument):
  45983. * html/HTMLEmbedElement.cpp:
  45984. (WebCore::HTMLEmbedElement::insertedIntoDocument):
  45985. * html/HTMLObjectElement.cpp:
  45986. (WebCore::HTMLObjectElement::insertedIntoDocument):
  45987. 2011-03-07 David Levin <levin@chromium.org>
  45988. Reviewed by Adam Barth.
  45989. SubresourceLoader should expose a way to set the outgoing referer/origin
  45990. https://bugs.webkit.org/show_bug.cgi?id=55903
  45991. No new tests as no new functionality is exposed.
  45992. * loader/SubresourceLoader.cpp:
  45993. (WebCore::SubresourceLoader::create):
  45994. * loader/SubresourceLoader.h:
  45995. 2011-03-21 Daniel Sievers <sievers@google.com>
  45996. Reviewed by Simon Fraser.
  45997. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
  45998. https://bugs.webkit.org/show_bug.cgi?id=56139
  45999. * WebCore.exp.in:
  46000. * WebCore.order:
  46001. * page/Frame.cpp:
  46002. (WebCore::Frame::layerTreeAsText):
  46003. * page/Frame.h:
  46004. * rendering/RenderLayerCompositor.cpp:
  46005. (WebCore::RenderLayerCompositor::layerTreeAsText):
  46006. * rendering/RenderLayerCompositor.h:
  46007. 2011-03-21 Chang Shu <cshu@webkit.org>
  46008. Reviewed by Alexey Proskuryakov.
  46009. REGRESSION (r79953): Can't type in MS Outlook 2011
  46010. https://bugs.webkit.org/show_bug.cgi?id=56665
  46011. r79953 removed the WebView level editablity which is persistent no matter whether
  46012. underlying document itself is changed and editability gets lost. The resolution is to
  46013. set this WebView editable value to WebCore. This avoids the callback from WebCore to
  46014. WebKit which was the main goal in r79953 to improve performance.
  46015. * WebCore.exp.in:
  46016. * accessibility/AccessibilityRenderObject.cpp:
  46017. (WebCore::AccessibilityRenderObject::isReadOnly):
  46018. * dom/Node.cpp:
  46019. (WebCore::Node::isContentEditable):
  46020. * editing/SelectionController.cpp:
  46021. (WebCore::SelectionController::setSelectionFromNone):
  46022. * page/DragController.cpp:
  46023. (WebCore::DragController::operationForLoad):
  46024. * page/Page.cpp:
  46025. (WebCore::Page::Page):
  46026. * page/Page.h:
  46027. (WebCore::Page::setEditable):
  46028. (WebCore::Page::isEditable):
  46029. 2011-03-21 Eric Uhrhane <ericu@chromium.org>
  46030. Reviewed by David Levin.
  46031. [fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
  46032. https://bugs.webkit.org/show_bug.cgi?id=56704
  46033. * fileapi/DOMFileSystemSync.cpp
  46034. (DOMFileSystemSync::createFile)
  46035. (class GetPathHelper): Added, to look up path before creating File.
  46036. * fileapi/DOMFileSystem.cpp
  46037. (DOMFileSystem::createFile)
  46038. (GetPathCallback): Added, to look up path before creating File.
  46039. * platform/FileMetadata.h
  46040. (struct FileMetadata): Added new field platformPath.
  46041. 2011-03-21 Dominic Cooney <dominicc@google.com>
  46042. Reviewed by Jeremy Orlow.
  46043. Establishes a V8 context before executing MediaQueryList callbacks.
  46044. https://bugs.webkit.org/show_bug.cgi?id=56166
  46045. MediaQueryList listener callbacks didn't establish a V8 context
  46046. before running script, causing crashes on C++-only
  46047. callstacks (such as user resizing, printing, etc.) I believe this
  46048. could also be contrived to execute media query list listener
  46049. callbacks across domain.
  46050. Test: fast/media/media-query-list-callback.html
  46051. * css/MediaQueryListListener.cpp:
  46052. (WebCore::MediaQueryListListener::queryChanged):
  46053. 2011-03-21 Andreas Kling <kling@webkit.org>
  46054. Reviewed by Tor Arne Vestbø.
  46055. [Qt] Add QNetworkReplyHandler::wasAborted()
  46056. Instead of checking if the ResourceHandle is null everywhere,
  46057. use a wasAborted() method to make the code readable.
  46058. * platform/network/qt/QNetworkReplyHandler.h:
  46059. (WebCore::QNetworkReplyHandler::wasAborted):
  46060. * platform/network/qt/QNetworkReplyHandler.cpp:
  46061. (WebCore::QNetworkReplyHandler::finish):
  46062. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  46063. (WebCore::QNetworkReplyHandler::redirect):
  46064. (WebCore::QNetworkReplyHandler::forwardData):
  46065. (WebCore::QNetworkReplyHandler::uploadProgress):
  46066. 2011-03-21 Christian Dywan <christian@lanedo.com>
  46067. Reviewed by Martin Robinson.
  46068. WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
  46069. https://bugs.webkit.org/show_bug.cgi?id=56201
  46070. * platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf
  46071. if there is no image.
  46072. 2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>
  46073. Reviewed by Martin Robinson.
  46074. [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
  46075. https://bugs.webkit.org/show_bug.cgi?id=56737
  46076. Only consider parent objects not ignoring accessibility.
  46077. * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
  46078. (webkitAccessibleHyperlinkGetStartIndex): Look for the parent
  46079. object not ignoring accessibility for the current hyperlink.
  46080. (webkitAccessibleHyperlinkGetEndIndex): Ditto.
  46081. 2011-03-21 Andreas Kling <kling@webkit.org>
  46082. Reviewed by Benjamin Poulain.
  46083. [Qt] Remove handling of QNetworkAccessManager::UnknownOperation
  46084. Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
  46085. Custom verb requests are using CustomOperation already, so this was dead code.
  46086. * platform/network/qt/QNetworkReplyHandler.cpp:
  46087. (WebCore::QNetworkReplyHandler::start):
  46088. 2011-03-21 Adam Roben <aroben@apple.com>
  46089. Fix multiple-definition linker warnings on Windows
  46090. * WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is
  46091. already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
  46092. file.
  46093. 2011-03-21 Andreas Kling <kling@webkit.org>
  46094. Reviewed by Benjamin Poulain.
  46095. [Qt] Clean up QNetworkReplyHandler::release()
  46096. Since QNetworkReplyHandler no longer uses queued connections to
  46097. the QNetworkReply, it's not necessary to mess with the event
  46098. queue when releasing a reply.
  46099. * platform/network/qt/QNetworkReplyHandler.cpp:
  46100. (WebCore::QNetworkReplyHandler::abort):
  46101. (WebCore::QNetworkReplyHandler::release):
  46102. 2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>
  46103. Reviewed by Pavel Feldman.
  46104. Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
  46105. https://bugs.webkit.org/show_bug.cgi?id=56691
  46106. Added transfer size support in inspector for compressed data.
  46107. Test: http/tests/inspector/network/network-size-chunked.html
  46108. * inspector/Inspector.idl:
  46109. * inspector/InspectorInstrumentation.cpp:
  46110. (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  46111. * inspector/InspectorInstrumentation.h:
  46112. (WebCore::InspectorInstrumentation::didReceiveContentLength):
  46113. * inspector/InspectorResourceAgent.cpp:
  46114. (WebCore::InspectorResourceAgent::didReceiveResponse):
  46115. (WebCore::InspectorResourceAgent::didReceiveContentLength):
  46116. * inspector/InspectorResourceAgent.h:
  46117. * inspector/front-end/NetworkManager.js:
  46118. (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
  46119. * inspector/front-end/Resource.js:
  46120. (WebInspector.Resource.prototype.get transferSize):
  46121. (WebInspector.Resource.prototype.increaseTransferSize):
  46122. * loader/ResourceLoadNotifier.cpp:
  46123. (WebCore::ResourceLoadNotifier::didReceiveData):
  46124. (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
  46125. (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  46126. * loader/ResourceLoadNotifier.h:
  46127. * loader/appcache/ApplicationCacheGroup.cpp:
  46128. (WebCore::ApplicationCacheGroup::didReceiveData):
  46129. * platform/network/mac/ResourceHandleMac.mm:
  46130. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  46131. * platform/network/qt/QNetworkReplyHandler.cpp:
  46132. (WebCore::QNetworkReplyHandler::forwardData):
  46133. * platform/network/soup/ResourceHandleSoup.cpp:
  46134. (WebCore::gotChunkCallback):
  46135. * platform/network/win/ResourceHandleWin.cpp:
  46136. (WebCore::ResourceHandle::onRequestComplete):
  46137. (WebCore::ResourceHandle::fileLoadTimer):
  46138. 2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>
  46139. Reviewed by Dirk Schulze.
  46140. symbol display <use> at wrong scale
  46141. https://bugs.webkit.org/show_bug.cgi?id=54538
  46142. SVG spec: http://www.w3.org/TR/SVG/struct.html#UseElement
  46143. Quotation for referenced <symbol>: "If attributes 'width'
  46144. and/or 'height' are provided on the 'use' element, then
  46145. these attributes will be transferred to the generated 'svg'."
  46146. Quotation for referenced <svg>: "If attributes 'width'
  46147. and/or 'height' are provided on the 'use' element, then
  46148. these values will override the corresponding attributes
  46149. on the 'svg' in the generated tree."
  46150. For above quotations, we should treat 'use' element as referencing
  46151. 'use' element, just like Firefox 3.6 and Opera 11, instead of
  46152. corrensponding 'use' element.
  46153. Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg
  46154. svg/custom/use-transfer-width-height-properties-to-svg1.svg
  46155. svg/custom/use-transfer-width-height-properties-to-svg2.svg
  46156. svg/custom/use-transfer-width-height-properties-to-symbol.svg
  46157. svg/custom/use-transfer-width-height-properties-to-symbol1.svg
  46158. svg/custom/use-transfer-width-height-properties-to-symbol2.svg
  46159. * svg/SVGElementInstance.cpp:
  46160. (WebCore::SVGElementInstance::SVGElementInstance):
  46161. * svg/SVGElementInstance.h:
  46162. (WebCore::SVGElementInstance::create):
  46163. (WebCore::SVGElementInstance::correspondingUseElement):
  46164. (WebCore::SVGElementInstance::directUseElement):
  46165. (WebCore::SVGElementInstance::clearUseElements):
  46166. * svg/SVGUseElement.cpp:
  46167. (WebCore::updateContainerSize):
  46168. (WebCore::SVGUseElement::updateContainerSizes):
  46169. (WebCore::dumpInstanceTree):
  46170. (WebCore::SVGUseElement::detachInstance):
  46171. (WebCore::SVGUseElement::buildInstanceTree):
  46172. 2011-03-21 Jaehun Lim <ljaehun.lim@samsung.com>
  46173. Reviewed by Pavel Feldman.
  46174. Fix build break when inspector is enabled.
  46175. https://bugs.webkit.org/show_bug.cgi?id=56735
  46176. * loader/FrameLoader.cpp:
  46177. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).
  46178. 2011-03-21 Philippe Normand <pnormand@igalia.com>
  46179. Unreviewed, GTK distcheck build fix.
  46180. * GNUmakefile.am:
  46181. 2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>
  46182. Reviewed by Eric Seidel.
  46183. Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
  46184. ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)
  46185. Test: fast/css/webkit-empty-transform-preserve3d-crash.html
  46186. * rendering/RenderBox.cpp:
  46187. (WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the
  46188. rest of the code and check that the RenderBox has a layer to avoid
  46189. crashing on the layer() call.
  46190. 2011-03-21 Pavel Feldman <pfeldman@chromium.org>
  46191. Reviewed by Yury Semikhatsky.
  46192. Web Inspector: move cookie processing and appcache from DOMAgent.js
  46193. https://bugs.webkit.org/show_bug.cgi?id=56713
  46194. * inspector/front-end/ApplicationCacheItemsView.js:
  46195. (WebInspector.ApplicationCacheDispatcher):
  46196. (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
  46197. (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
  46198. (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  46199. * inspector/front-end/CookieItemsView.js:
  46200. (WebInspector.Cookies.getCookiesAsync):
  46201. (WebInspector.Cookies.buildCookiesFromString):
  46202. (WebInspector.Cookies.cookieMatchesResourceURL):
  46203. (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  46204. * inspector/front-end/DOMAgent.js:
  46205. (WebInspector.DOMNode.prototype.eventListeners):
  46206. * inspector/front-end/EventListenersSidebarPane.js:
  46207. (WebInspector.EventListenersSidebarPane.prototype.update):
  46208. 2011-03-21 Pavel Feldman <pfeldman@chromium.org>
  46209. Reviewed by Yury Semikhatsky.
  46210. Web Inspector: migrate Inspector.json to valid JSON types.
  46211. https://bugs.webkit.org/show_bug.cgi?id=56651
  46212. This change migrates inspector from long to int as
  46213. dom, storage, database and other id types.
  46214. * inspector/InjectedScriptHost.cpp:
  46215. (WebCore::InjectedScriptHost::inspectedNode):
  46216. (WebCore::InjectedScriptHost::databaseIdImpl):
  46217. (WebCore::InjectedScriptHost::storageIdImpl):
  46218. (WebCore::InjectedScriptHost::didCreateWorker):
  46219. (WebCore::InjectedScriptHost::didDestroyWorker):
  46220. * inspector/InjectedScriptHost.h:
  46221. * inspector/InjectedScriptHost.idl:
  46222. * inspector/Inspector.json:
  46223. * inspector/InspectorAgent.cpp:
  46224. (WebCore::InspectorAgent::highlightDOMNode):
  46225. * inspector/InspectorAgent.h:
  46226. * inspector/InspectorBrowserDebuggerAgent.cpp:
  46227. (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
  46228. (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
  46229. (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  46230. (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
  46231. * inspector/InspectorBrowserDebuggerAgent.h:
  46232. * inspector/InspectorCSSAgent.cpp:
  46233. (WebCore::InspectorCSSAgent::getStylesForNode):
  46234. (WebCore::InspectorCSSAgent::getInlineStyleForNode):
  46235. (WebCore::InspectorCSSAgent::getComputedStyleForNode):
  46236. (WebCore::InspectorCSSAgent::setPropertyText):
  46237. (WebCore::InspectorCSSAgent::toggleProperty):
  46238. (WebCore::InspectorCSSAgent::addRule):
  46239. (WebCore::InspectorCSSAgent::elementForId):
  46240. * inspector/InspectorCSSAgent.h:
  46241. * inspector/InspectorConsoleAgent.cpp:
  46242. (WebCore::InspectorConsoleAgent::count):
  46243. (WebCore::InspectorConsoleAgent::addInspectedNode):
  46244. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  46245. * inspector/InspectorConsoleAgent.h:
  46246. * inspector/InspectorDOMAgent.cpp:
  46247. (WebCore::InspectorDOMAgent::bind):
  46248. (WebCore::InspectorDOMAgent::unbind):
  46249. (WebCore::InspectorDOMAgent::assertNode):
  46250. (WebCore::InspectorDOMAgent::assertElement):
  46251. (WebCore::InspectorDOMAgent::assertHTMLElement):
  46252. (WebCore::InspectorDOMAgent::nodeToSelectOn):
  46253. (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
  46254. (WebCore::InspectorDOMAgent::nodeForId):
  46255. (WebCore::InspectorDOMAgent::getChildNodes):
  46256. (WebCore::InspectorDOMAgent::querySelector):
  46257. (WebCore::InspectorDOMAgent::querySelectorAll):
  46258. (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
  46259. (WebCore::InspectorDOMAgent::boundNodeId):
  46260. (WebCore::InspectorDOMAgent::setAttribute):
  46261. (WebCore::InspectorDOMAgent::removeAttribute):
  46262. (WebCore::InspectorDOMAgent::removeNode):
  46263. (WebCore::InspectorDOMAgent::setNodeName):
  46264. (WebCore::InspectorDOMAgent::getOuterHTML):
  46265. (WebCore::InspectorDOMAgent::setOuterHTML):
  46266. (WebCore::InspectorDOMAgent::setNodeValue):
  46267. (WebCore::InspectorDOMAgent::getEventListenersForNode):
  46268. (WebCore::InspectorDOMAgent::resolveNode):
  46269. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  46270. (WebCore::InspectorDOMAgent::buildObjectForNode):
  46271. (WebCore::InspectorDOMAgent::loadEventFired):
  46272. (WebCore::InspectorDOMAgent::didInsertDOMNode):
  46273. (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  46274. (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  46275. (WebCore::InspectorDOMAgent::characterDataModified):
  46276. (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
  46277. (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
  46278. (WebCore::InspectorDOMAgent::copyNode):
  46279. (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  46280. * inspector/InspectorDOMAgent.h:
  46281. * inspector/InspectorDOMStorageAgent.cpp:
  46282. (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
  46283. (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
  46284. (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
  46285. (WebCore::InspectorDOMStorageAgent::storageId):
  46286. (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  46287. * inspector/InspectorDOMStorageAgent.h:
  46288. * inspector/InspectorDOMStorageResource.cpp:
  46289. * inspector/InspectorDOMStorageResource.h:
  46290. (WebCore::InspectorDOMStorageResource::id):
  46291. * inspector/InspectorDatabaseAgent.cpp:
  46292. (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
  46293. (WebCore::InspectorDatabaseAgent::executeSQL):
  46294. (WebCore::InspectorDatabaseAgent::databaseId):
  46295. (WebCore::InspectorDatabaseAgent::databaseForId):
  46296. * inspector/InspectorDatabaseAgent.h:
  46297. * inspector/InspectorDatabaseResource.cpp:
  46298. * inspector/InspectorDatabaseResource.h:
  46299. (WebCore::InspectorDatabaseResource::id):
  46300. * inspector/InspectorDebuggerAgent.cpp:
  46301. (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  46302. * inspector/InspectorDebuggerAgent.h:
  46303. * inspector/InspectorProfilerAgent.cpp:
  46304. (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  46305. * inspector/InspectorProfilerAgent.h:
  46306. * inspector/InspectorResourceAgent.cpp:
  46307. (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  46308. (WebCore::InspectorResourceAgent::willSendRequest):
  46309. (WebCore::InspectorResourceAgent::markResourceAsCached):
  46310. (WebCore::InspectorResourceAgent::didReceiveResponse):
  46311. (WebCore::InspectorResourceAgent::didReceiveContentLength):
  46312. (WebCore::InspectorResourceAgent::didFinishLoading):
  46313. (WebCore::InspectorResourceAgent::didFailLoading):
  46314. (WebCore::InspectorResourceAgent::setInitialContent):
  46315. (WebCore::InspectorResourceAgent::didCreateWebSocket):
  46316. (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
  46317. (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
  46318. (WebCore::InspectorResourceAgent::didCloseWebSocket):
  46319. * inspector/generate-inspector-idl:
  46320. 2011-03-21 Pavel Feldman <pfeldman@chromium.org>
  46321. Reviewed by Yury Semikhatsky.
  46322. Web Inspector: make frameId in network agent of type string, not unsigned long.
  46323. https://bugs.webkit.org/show_bug.cgi?id=56708
  46324. * inspector/Inspector.json:
  46325. * inspector/InspectorAgent.cpp:
  46326. (WebCore::InspectorAgent::highlightFrame):
  46327. * inspector/InspectorAgent.h:
  46328. * inspector/InspectorResourceAgent.cpp:
  46329. (WebCore::pointerAsId):
  46330. (WebCore::buildObjectForDocumentLoader):
  46331. (WebCore::buildObjectForFrame):
  46332. (WebCore::InspectorResourceAgent::frameDetachedFromParent):
  46333. (WebCore::InspectorResourceAgent::frameForId):
  46334. (WebCore::InspectorResourceAgent::resourceContent):
  46335. * inspector/InspectorResourceAgent.h:
  46336. * inspector/front-end/ResourcesPanel.js:
  46337. (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
  46338. 2011-03-21 Pavel Feldman <pfeldman@chromium.org>
  46339. Reviewed by Yury Semikhatsky.
  46340. Web Inspector: expose object id as string, not JSON struct in the protocol.
  46341. https://bugs.webkit.org/show_bug.cgi?id=56681
  46342. * bindings/js/JSInjectedScriptHostCustom.cpp:
  46343. (WebCore::JSInjectedScriptHost::inspect):
  46344. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  46345. (WebCore::V8InjectedScriptHost::inspectCallback):
  46346. * inspector/InjectedScript.cpp:
  46347. (WebCore::InjectedScript::evaluateOn):
  46348. (WebCore::InjectedScript::evaluateOnCallFrame):
  46349. (WebCore::InjectedScript::getProperties):
  46350. (WebCore::InjectedScript::nodeForObjectId):
  46351. (WebCore::InjectedScript::setPropertyValue):
  46352. (WebCore::InjectedScript::releaseObject):
  46353. * inspector/InjectedScript.h:
  46354. * inspector/InjectedScriptHost.cpp:
  46355. (WebCore::InjectedScriptHost::inspectImpl):
  46356. * inspector/InjectedScriptHost.h:
  46357. * inspector/InjectedScriptManager.cpp:
  46358. (WebCore::InjectedScriptManager::injectedScriptForObjectId):
  46359. (WebCore::InjectedScriptManager::releaseObjectGroup):
  46360. * inspector/InjectedScriptManager.h:
  46361. * inspector/InjectedScriptSource.js:
  46362. * inspector/Inspector.json:
  46363. * inspector/InspectorConsoleAgent.cpp:
  46364. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  46365. * inspector/InspectorDOMAgent.cpp:
  46366. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  46367. * inspector/InspectorDOMAgent.h:
  46368. * inspector/InspectorDebuggerAgent.cpp:
  46369. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  46370. * inspector/InspectorDebuggerAgent.h:
  46371. * inspector/InspectorRuntimeAgent.cpp:
  46372. (WebCore::InspectorRuntimeAgent::evaluateOn):
  46373. (WebCore::InspectorRuntimeAgent::getProperties):
  46374. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  46375. (WebCore::InspectorRuntimeAgent::releaseObject):
  46376. (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  46377. * inspector/InspectorRuntimeAgent.h:
  46378. * inspector/front-end/ConsoleView.js:
  46379. (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
  46380. (WebInspector.ConsoleView.prototype.completions):
  46381. * inspector/front-end/PropertiesSidebarPane.js:
  46382. * inspector/front-end/ScriptsPanel.js:
  46383. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
  46384. * inspector/front-end/WatchExpressionsSidebarPane.js:
  46385. (WebInspector.WatchExpressionsSection.prototype.update):
  46386. * inspector/front-end/inspector.js:
  46387. (WebInspector.inspect):
  46388. 2011-03-20 Bill Budge <bbudge@chromium.org>
  46389. Reviewed by Adam Barth.
  46390. Rename ThreadSafeShared to ThreadSafeRefCounted
  46391. https://bugs.webkit.org/show_bug.cgi?id=56714
  46392. No new tests. Exposes no new functionality.
  46393. * ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  46394. * ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  46395. * bindings/v8/SerializedScriptValue.h:
  46396. * dom/Document.cpp:
  46397. * dom/default/PlatformMessagePortChannel.h:
  46398. * fileapi/FileThread.h:
  46399. * loader/ThreadableLoaderClientWrapper.h:
  46400. (WebCore::ThreadableLoaderClientWrapper::create):
  46401. (WebCore::ThreadableLoaderClientWrapper::clearClient):
  46402. (WebCore::ThreadableLoaderClientWrapper::done):
  46403. (WebCore::ThreadableLoaderClientWrapper::didSendData):
  46404. (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
  46405. (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
  46406. (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata):
  46407. (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  46408. (WebCore::ThreadableLoaderClientWrapper::didFail):
  46409. (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
  46410. (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
  46411. (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  46412. * page/SecurityOrigin.h:
  46413. * platform/CrossThreadCopier.h:
  46414. * platform/network/BlobData.h:
  46415. * platform/network/cf/SocketStreamHandle.h:
  46416. * storage/AbstractDatabase.h:
  46417. * storage/DatabaseAuthorizer.h:
  46418. * storage/DatabaseCallback.h:
  46419. * storage/DatabaseThread.h:
  46420. * storage/IDBCallbacks.h:
  46421. * storage/IDBCursorBackendInterface.h:
  46422. * storage/IDBDatabaseBackendInterface.h:
  46423. * storage/IDBFactoryBackendInterface.h:
  46424. * storage/IDBIndexBackendInterface.h:
  46425. * storage/IDBKey.h:
  46426. * storage/IDBKeyRange.h:
  46427. * storage/IDBObjectStoreBackendInterface.h:
  46428. * storage/IDBRequest.h:
  46429. * storage/IDBTransactionBackendInterface.h:
  46430. * storage/SQLError.h:
  46431. * storage/SQLResultSet.h:
  46432. * storage/SQLStatement.h:
  46433. * storage/SQLStatementCallback.h:
  46434. * storage/SQLStatementErrorCallback.h:
  46435. * storage/SQLTransaction.h:
  46436. * storage/SQLTransactionCallback.h:
  46437. * storage/SQLTransactionErrorCallback.h:
  46438. * websockets/ThreadableWebSocketChannelClientWrapper.h:
  46439. * workers/DefaultSharedWorkerRepository.cpp:
  46440. 2011-03-20 Andreas Kling <kling@webkit.org>
  46441. Reviewed by Kenneth Rohde Christiansen.
  46442. [Qt] Clean up redirection logic in QNetworkReplyHandler
  46443. https://bugs.webkit.org/show_bug.cgi?id=56717
  46444. * platform/network/qt/QNetworkReplyHandler.cpp:
  46445. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  46446. Use resetState() when constructing QNRH as well.
  46447. (WebCore::QNetworkReplyHandler::resetState):
  46448. Delete (deferred) the m_reply if one exists (only when redirecting.)
  46449. (WebCore::QNetworkReplyHandler::finish):
  46450. Return early when redirecting.
  46451. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  46452. (WebCore::QNetworkReplyHandler::redirect):
  46453. Move the redirection logic from sendResponseIfNeeded() into a
  46454. separate redirect() method.
  46455. 2011-03-19 Andreas Kling <kling@webkit.org>
  46456. Reviewed by Benjamin Poulain.
  46457. [Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()
  46458. The function doesn't ignore anything, thus it shouldn't have an imperative name.
  46459. * platform/network/qt/QNetworkReplyHandler.cpp:
  46460. (WebCore::shouldIgnoreHttpError):
  46461. (WebCore::QNetworkReplyHandler::finish):
  46462. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  46463. 2011-03-19 Andreas Kling <kling@webkit.org>
  46464. Reviewed by Benjamin Poulain.
  46465. [Qt] Kill layer violation FIXME in ResourceHandleQt.
  46466. We were including qwebframe_p.h from WebKit/qt for no reason.
  46467. * platform/network/qt/ResourceHandleQt.cpp:
  46468. 2011-03-19 Andreas Kling <kling@webkit.org>
  46469. Reviewed by Benjamin Poulain.
  46470. [Qt] Refactor handling of deferred loads
  46471. https://bugs.webkit.org/show_bug.cgi?id=56715
  46472. Split QNetworkReplyHandler's "load mode" into two parameters
  46473. instead of trying to fit the deferral mechanism into it.
  46474. Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)
  46475. * platform/network/qt/QNetworkReplyHandler.cpp:
  46476. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  46477. (WebCore::QNetworkReplyHandler::setLoadingDeferred):
  46478. (WebCore::QNetworkReplyHandler::resumeDeferredLoad):
  46479. (WebCore::QNetworkReplyHandler::finish):
  46480. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  46481. (WebCore::QNetworkReplyHandler::forwardData):
  46482. (WebCore::QNetworkReplyHandler::start):
  46483. (WebCore::QNetworkReplyHandler::resetState):
  46484. * platform/network/qt/QNetworkReplyHandler.h:
  46485. * platform/network/qt/ResourceHandleQt.cpp:
  46486. (WebCore::ResourceHandle::start):
  46487. (WebCore::ResourceHandle::loadResourceSynchronously):
  46488. (WebCore::ResourceHandle::platformSetDefersLoading):
  46489. 2011-03-19 Anton D'Auria <adauria@apple.com>
  46490. Reviewed by Alexey Proskuryakov.
  46491. ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
  46492. https://bugs.webkit.org/show_bug.cgi?id=56415
  46493. To delete all Application Cache for an origin, we must obsolete all
  46494. in-memory cache groups for that origin. If a cache group isn't in memory,
  46495. then it must be deleted from disk. The previous implementation correctly
  46496. removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
  46497. This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
  46498. when the DocumentLoader was destroyed.
  46499. Test: http/tests/appcache/origin-delete.html
  46500. * WebCore.exp.in:
  46501. * WebCore.xcodeproj/project.pbxproj:
  46502. * loader/appcache/ApplicationCache.cpp:
  46503. (WebCore::ApplicationCache::clearStorageID):
  46504. (WebCore::ApplicationCache::deleteCacheForOrigin):
  46505. * loader/appcache/ApplicationCache.h:
  46506. * loader/appcache/ApplicationCacheStorage.cpp:
  46507. (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
  46508. * loader/appcache/ApplicationCacheStorage.h:
  46509. 2011-03-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  46510. Reviewed by Antonio Gomes.
  46511. [EFL] Add dummy GeolocationServiceEfl. cpp | h
  46512. https://bugs.webkit.org/show_bug.cgi?id=56710
  46513. Add dummy GeolocationServiceEfl.cpp | h to platform/efl.
  46514. * CMakeListsEfl.txt:
  46515. * platform/efl/GeolocationServiceEfl.cpp: Added.
  46516. (WebCore::GeolocationServiceEfl::create):
  46517. (WebCore::GeolocationServiceEfl::GeolocationServiceEfl):
  46518. (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl):
  46519. (WebCore::GeolocationServiceEfl::startUpdating):
  46520. (WebCore::GeolocationServiceEfl::stopUpdating):
  46521. (WebCore::GeolocationServiceEfl::suspend):
  46522. (WebCore::GeolocationServiceEfl::resume):
  46523. (WebCore::GeolocationServiceEfl::lastPosition):
  46524. (WebCore::GeolocationServiceEfl::lastError):
  46525. * platform/efl/GeolocationServiceEfl.h: Added.
  46526. 2011-03-19 Patrick Gansterer <paroga@webkit.org>
  46527. Unreviewed, rolling out r81551.
  46528. http://trac.webkit.org/changeset/81551
  46529. https://bugs.webkit.org/show_bug.cgi?id=55336
  46530. Broke some storage tests on Win32.
  46531. * platform/win/FileSystemWin.cpp:
  46532. (WebCore::statFile):
  46533. (WebCore::getFileSize):
  46534. (WebCore::getFileModificationTime):
  46535. (WebCore::fileExists):
  46536. 2011-03-19 Andreas Kling <kling@webkit.org>
  46537. Reviewed by Benjamin Poulain.
  46538. [Qt] Remove support for Qt 4.6
  46539. https://bugs.webkit.org/show_bug.cgi?id=56712
  46540. * platform/graphics/qt/FontPlatformDataQt.cpp:
  46541. (WebCore::FontPlatformData::FontPlatformData):
  46542. * platform/graphics/qt/FontQt.cpp:
  46543. (WebCore::drawTextCommon):
  46544. (WebCore::Font::drawSimpleText):
  46545. (WebCore::Font::floatWidthForSimpleText):
  46546. (WebCore::Font::offsetForPositionForSimpleText):
  46547. (WebCore::Font::selectionRectForSimpleText):
  46548. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  46549. (WebCore::GraphicsContext3DInternal::paint):
  46550. * platform/graphics/qt/ImageBufferQt.cpp:
  46551. (WebCore::getImageData):
  46552. * platform/graphics/qt/ImageDecoderQt.cpp:
  46553. (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  46554. * platform/graphics/qt/PathQt.cpp:
  46555. (WebCore::Path::transform):
  46556. * platform/network/qt/DnsPrefetchHelper.h:
  46557. (WebCore::DnsPrefetchHelper::DnsPrefetchHelper):
  46558. (WebCore::DnsPrefetchHelper::lookup):
  46559. * platform/network/qt/NetworkStateNotifierPrivate.h:
  46560. * platform/network/qt/NetworkStateNotifierQt.cpp:
  46561. * platform/network/qt/QNetworkReplyHandler.cpp:
  46562. (WebCore::QNetworkReplyHandler::httpMethod):
  46563. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  46564. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  46565. (WebCore::QNetworkReplyHandler::start):
  46566. * platform/network/qt/ResourceRequestQt.cpp:
  46567. (WebCore::ResourceRequest::toNetworkRequest):
  46568. * platform/qt/RenderThemeQt.cpp:
  46569. (WebCore::RenderThemeQt::paintMediaSliderTrack):
  46570. 2011-03-19 Patrick Gansterer <paroga@webkit.org>
  46571. Reviewed by Adam Roben.
  46572. Use Win32 API to get file information
  46573. https://bugs.webkit.org/show_bug.cgi?id=55336
  46574. Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
  46575. and GetFileAttributesEx() so we can share the code with WinCE.
  46576. * platform/win/FileSystemWin.cpp:
  46577. (WebCore::createFileHandle):
  46578. (WebCore::getFileInformation):
  46579. (WebCore::getFileSize):
  46580. (WebCore::getFileModificationTime):
  46581. (WebCore::fileExists):
  46582. 2011-03-19 Xan Lopez <xlopez@igalia.com>
  46583. Reviewed by Martin Robinson.
  46584. [GTK] Simplify GObjectEventListener
  46585. https://bugs.webkit.org/show_bug.cgi?id=56698
  46586. Get rid of special case for DOMWindow, since it's also an
  46587. EventTarget.
  46588. * bindings/gobject/GObjectEventListener.cpp:
  46589. (WebCore::GObjectEventListener::GObjectEventListener): remove
  46590. DOMWindow special casing.
  46591. (WebCore::GObjectEventListener::~GObjectEventListener): ditto.
  46592. (WebCore::GObjectEventListener::gobjectDestroyed):
  46593. * bindings/gobject/GObjectEventListener.h:
  46594. (WebCore::GObjectEventListener::addEventListener): ditto.
  46595. (WebCore::GObjectEventListener::removeEventListener): ditto.
  46596. 2011-03-19 Ben Taylor <bentaylor.solx86@gmail.com>
  46597. Reviewed by Nikolas Zimmermann.
  46598. https://bugs.webkit.org/show_bug.cgi?id=56195
  46599. Fix conditional which had an int for one case and a pointer for another.
  46600. Similar fix as https://bugs.webkit.org/show_bug.cgi?id=56198
  46601. No new tests. Fix compilation on Solaris 10 with Sun Studio C++
  46602. * svg/SVGElement.cpp:
  46603. (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  46604. 2011-03-19 Patrick Gansterer <paroga@webkit.org>
  46605. Reviewed by Darin Adler.
  46606. Rename WTF::StringHasher methods
  46607. https://bugs.webkit.org/show_bug.cgi?id=53532
  46608. Rename createHash to computeHash and createBlobHash to hashMemory.
  46609. Also add a using WTF::StringHasher in the header file.
  46610. * dom/Document.cpp:
  46611. (WebCore::FormElementKeyHash::hash):
  46612. * dom/QualifiedName.h:
  46613. (WebCore::hashComponents):
  46614. * dom/StyledElement.cpp:
  46615. (WebCore::MappedAttributeHash::hash):
  46616. * loader/appcache/ApplicationCacheStorage.cpp:
  46617. (WebCore::urlHostHash):
  46618. * page/SecurityOriginHash.h:
  46619. (WebCore::SecurityOriginHash::hash):
  46620. * platform/LinkHash.cpp:
  46621. (WebCore::visitedLinkHashInline):
  46622. * platform/cf/BinaryPropertyList.cpp:
  46623. (WebCore::IntegerArrayHash::hash):
  46624. * platform/cf/SchedulePair.h:
  46625. (WebCore::SchedulePairHash::hash):
  46626. * platform/graphics/FontCache.cpp:
  46627. (WebCore::computeHash):
  46628. * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  46629. (WebCore::FontPlatformData::RefCountedHFONT::hash):
  46630. * platform/graphics/cocoa/FontPlatformData.h:
  46631. (WebCore::FontPlatformData::hash):
  46632. * platform/graphics/pango/FontPlatformData.h:
  46633. (WebCore::FontPlatformData::hash):
  46634. * platform/graphics/wince/FontPlatformData.cpp:
  46635. (WebCore::FixedSizeFontDataKeyHash::hash):
  46636. * platform/graphics/wx/FontPlatformDataWx.cpp:
  46637. (WebCore::FontPlatformData::computeHash):
  46638. * platform/network/ProtectionSpaceHash.h:
  46639. (WebCore::ProtectionSpaceHash::hash):
  46640. * plugins/PluginPackage.cpp:
  46641. (WebCore::PluginPackage::hash):
  46642. * plugins/win/PluginPackageWin.cpp:
  46643. (WebCore::PluginPackage::hash):
  46644. * svg/properties/SVGAnimatedPropertyDescription.h:
  46645. (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
  46646. 2011-03-18 David Kilzer <ddkilzer@apple.com>
  46647. <http://webkit.org/b/56688> Fix clang static analyzer warning in WebCoreViewFactory.m
  46648. Reviewed by Anders Carlsson.
  46649. Fixes the following static analyzer warning:
  46650. Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]'
  46651. return self;
  46652. ^
  46653. * page/mac/WebCoreViewFactory.m:
  46654. (-[WebCoreViewFactory init]): Assign the result of [super init]
  46655. to self.
  46656. 2011-03-18 Adam Barth <abarth@webkit.org>
  46657. Reviewed by Dimitri Glazkov.
  46658. WebCore GYP build should build
  46659. https://bugs.webkit.org/show_bug.cgi?id=56696
  46660. After this patch, the WebCore GYP build successfully compiles and
  46661. links. I haven't trying executing it yet.
  46662. * WebCore.gypi:
  46663. - DOMMouseEvent should be included as part of the Objective-C bindings.
  46664. * WebCore.xcodeproj/project.pbxproj:
  46665. - RenderSVGPath.cpp was mistakenly included directly in the project
  46666. instead of being built by RenderSVGAllInOne.
  46667. * gyp/WebCore.gyp:
  46668. - Exclude some more files from the build. These files are absent
  46669. in the normal build. I didn't see them earlier because the dead
  46670. code stripping was hiding them. (They're probably unreferenced.)
  46671. - Switch to using RenderSVGAllInOne. I'm not entirely sure if this
  46672. part of the patch is necessary, but it matches the normal build
  46673. more closely.
  46674. * platform/mac/WebCoreObjCExtras.mm:
  46675. - The normal build passes the -Wdeprecated-declarations flag when
  46676. compiling this file. The GYP folks explicitly do not want to add
  46677. that feature to GYP, and there does not appear to be a way to
  46678. remove the deprecated call from this file.
  46679. * rendering/svg/RenderSVGAllInOne.cpp:
  46680. - Add RenderSVGPath.cpp, which was missing previously.
  46681. 2011-03-18 Adam Barth <abarth@webkit.org>
  46682. Reviewed by Dimitri Glazkov.
  46683. WebCore GYP build should (almost!) link
  46684. https://bugs.webkit.org/show_bug.cgi?id=56689
  46685. This patch is a grab-bag of small changes to bring the WebCore GYP
  46686. build down to two link errors or one compile error (take your pick).
  46687. We might need a GYP change to get this last file to compile, however.
  46688. * WebCore.gypi:
  46689. * gyp/WebCore.gyp:
  46690. 2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
  46691. Reviewed by Ojan Vafai.
  46692. Add a test for r81266 and fix HTML Editing for fallback contents in object element
  46693. https://bugs.webkit.org/show_bug.cgi?id=56505
  46694. The bug was caused by canHaveChildrenForEditing's always returning false even when
  46695. object element used fallback content. Fixed the bug by adding a check.
  46696. Test: editing/editability/ignored-content.html
  46697. * editing/htmlediting.cpp:
  46698. (WebCore::canHaveChildrenForEditing):
  46699. 2011-03-18 Andy Estes <aestes@apple.com>
  46700. Reviewed by Eric Seidel.
  46701. REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
  46702. https://bugs.webkit.org/show_bug.cgi?id=56380
  46703. Fix two issues with parsing a fragment that has a foreign content
  46704. element as its context element. The first issue is that the parser will
  46705. initially be in the InForeignContentMode insertion mode when processing
  46706. the first tag in the fragment in this case so one call site needs to
  46707. change from currentElement() to currentNode(). The second issue is that
  46708. when we changed fragments from using a fake HTML root element to a
  46709. DocumentFragment we broke checks that assumed the root element was in
  46710. the HTML namespace. Fix this by claiming that the DocumentFragment is
  46711. also in the HTML namespace.
  46712. Test: fast/parser/fragment-foreign-content-context.html
  46713. * html/parser/HTMLElementStack.cpp:
  46714. (WebCore::HTMLNames::isForeignContentScopeMarker):
  46715. (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
  46716. * html/parser/HTMLElementStack.h:
  46717. (WebCore::isInHTMLNamespace):
  46718. * html/parser/HTMLTreeBuilder.cpp:
  46719. (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
  46720. (WebCore::HTMLTreeBuilder::processStartTag):
  46721. (WebCore::HTMLTreeBuilder::processEndTag):
  46722. 2011-03-18 James Robinson <jamesr@chromium.org>
  46723. Reviewed by Dimitri Glazkov.
  46724. REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
  46725. https://bugs.webkit.org/show_bug.cgi?id=56629
  46726. Preserves offsets as absolute floating point offsets and rounds to
  46727. advances at the last possible second. I can't prove to myself that
  46728. this is sound but it seems to work on the test cases I've constructed.
  46729. Will probably change the pixel tests on chromium windows given that we
  46730. were horribly broken before this patch.
  46731. * platform/graphics/chromium/FontChromiumWin.cpp:
  46732. (WebCore::Font::drawGlyphs):
  46733. (WebCore::Font::drawComplexText):
  46734. 2011-03-18 Ryosuke Niwa <rniwa@webkit.org>
  46735. Reviewed by Eric Seidel.
  46736. REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
  46737. https://bugs.webkit.org/show_bug.cgi?id=56599
  46738. Debug build fix.
  46739. * dom/Position.cpp:
  46740. (WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node,
  46741. then we can't necessarily instantiate a position inside the node.
  46742. * editing/VisibleSelection.cpp:
  46743. (WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e
  46744. could be null. Exit early in those cases as well.
  46745. 2011-03-18 Adam Barth <abarth@webkit.org>
  46746. Reviewed by Eric Seidel.
  46747. Add ObjC bindings to the WebCore GYP build
  46748. https://bugs.webkit.org/show_bug.cgi?id=56671
  46749. It turns out we generate a bunch of ObjC bindings files that we don't
  46750. actually build. I've manually synced the list of ObjC derived source
  46751. files to match the existing list. This brings us down to 19 link
  46752. errors.
  46753. * WebCore.gypi:
  46754. * gyp/WebCore.gyp:
  46755. 2011-03-18 Ryuan Choi <ryuan.choi@samsung.com>
  46756. Reviewed by Eric Seidel.
  46757. [CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
  46758. https://bugs.webkit.org/show_bug.cgi?id=56624
  46759. No new tests, just splitting jsc related configuration.
  46760. * CMakeLists.txt:
  46761. * UseJSC.cmake: Added.
  46762. 2011-03-16 Stephen White <senorblanco@chromium.org>
  46763. Reviewed by Kenneth Russell.
  46764. Implement GPU-accelerated shadows.
  46765. https://bugs.webkit.org/show_bug.cgi?id=56476
  46766. For hard shadows, we simply offset the CTM and draw in the shadow
  46767. color. For soft shadows, we use a separable Gaussian convolution,
  46768. with a bilinear downsample and Mitchell-Netravali upsample in order to
  46769. preserve quality.
  46770. * WebCore.gypi:
  46771. Add BicubicShader and ConvolutionShader to the build.
  46772. * platform/graphics/chromium/GLES2Canvas.cpp:
  46773. (WebCore::GLES2Canvas::State::State):
  46774. Add shadow-related members to the GLES2Canvas::State
  46775. (WebCore::GLES2Canvas::State::shadowActive):
  46776. Add a helper function to know if shadows are active.
  46777. (WebCore::GLES2Canvas::clearRect):
  46778. (WebCore::GLES2Canvas::scissorClear):
  46779. Refactor the scissor clearing function out of clearRect().
  46780. (WebCore::GLES2Canvas::fillPath):
  46781. Add hook for shadow rendering in paths. Bind framebuffer at this level.
  46782. (WebCore::GLES2Canvas::fillRect):
  46783. Add hook for shadow rendering in rects. Bind framebuffer at this level.
  46784. (WebCore::GLES2Canvas::fillRectInternal):
  46785. Rename fillRect() -> fillRectInternal(), which does bind its vertex
  46786. buffer, but does not bind the framebuffer.
  46787. (WebCore::GLES2Canvas::setShadowColor):
  46788. (WebCore::GLES2Canvas::setShadowOffset):
  46789. (WebCore::GLES2Canvas::setShadowBlur):
  46790. (WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
  46791. Implement graphicsContext-style setters for shadow parameters.
  46792. (WebCore::GLES2Canvas::clipPath):
  46793. Call fillPathInternal(), not fillPath().
  46794. (WebCore::GLES2Canvas::restore):
  46795. (WebCore::GLES2Canvas::drawTexturedRect):
  46796. Bind the framebuffer at this level. Do not bind vertices here (will
  46797. be done in drawTexturedQuad).
  46798. (WebCore::GLES2Canvas::drawTexturedRectTile):
  46799. drawQuad() -> drawTexturedQuad().
  46800. (WebCore::GLES2Canvas::convolveRect):
  46801. Implement one pass of a convolution filter (X or Y).
  46802. (WebCore::gauss):
  46803. (WebCore::buildKernel):
  46804. Some helper functions to build a Gaussian convolution kernel.
  46805. (WebCore::GLES2Canvas::drawTexturedQuad):
  46806. Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not
  46807. bind the framebuffer at this level (it will be done higher).
  46808. (WebCore::GLES2Canvas::drawTexturedQuadMitchell):
  46809. Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
  46810. (WebCore::GLES2Canvas::fillPathInternal):
  46811. Rename fillPath() -> fillPathInternal(), which does use quad vertices,
  46812. but does not bind the framebuffer or set the compositing mode.
  46813. (WebCore::GLES2Canvas::flipRect):
  46814. Implement a helper function to flip a rectangle in Y within the canvas.
  46815. (WebCore::GLES2Canvas::clearBorders):
  46816. Implement a helper function to clear an n-pixel border around a rect.
  46817. (WebCore::GLES2Canvas::beginShadowDraw):
  46818. Setup before drawing a primitive's shadow: for hard shadows, just
  46819. offset the CTM by the shadow offset. For soft shadows, bind to an
  46820. offscreen DrawingBuffer.
  46821. (WebCore::GLES2Canvas::endShadowDraw):
  46822. Tear-down after drawing a primitive's shadow: for hard shadows, just
  46823. restore the CTM. For soft shadows, downsample (if necessary), then
  46824. blur in X, blur in Y, upsample if necessary).
  46825. * platform/graphics/chromium/GLES2Canvas.h:
  46826. * platform/graphics/gpu/BicubicShader.cpp: Added.
  46827. (WebCore::BicubicShader::BicubicShader):
  46828. (WebCore::BicubicShader::create):
  46829. (WebCore::BicubicShader::use):
  46830. * platform/graphics/gpu/BicubicShader.h: Added.
  46831. Implement a bicubic image filtering shader.
  46832. * platform/graphics/gpu/ConvolutionShader.cpp: Added.
  46833. (WebCore::ConvolutionShader::ConvolutionShader):
  46834. (WebCore::ConvolutionShader::create):
  46835. (WebCore::ConvolutionShader::use):
  46836. * platform/graphics/gpu/ConvolutionShader.h: Added.
  46837. Implement a 1-dimensional convolution shader. In order to minimize
  46838. texture samples, this shader is parameterized at compile time by the
  46839. width of the convolution kernel.
  46840. * platform/graphics/gpu/DrawingBuffer.h:
  46841. (WebCore::DrawingBuffer::colorBuffer):
  46842. Add an accessor to retrieve a DrawingBuffer's texture ID.
  46843. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  46844. (WebCore::SharedGraphicsContext3D::create):
  46845. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  46846. (WebCore::SharedGraphicsContext3D::useBicubicProgram):
  46847. (WebCore::SharedGraphicsContext3D::useConvolutionProgram):
  46848. Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
  46849. each possible kernel width).
  46850. (WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
  46851. Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
  46852. This is done to minimize the VRAM usage: only 2 buffers are used for
  46853. all canvases.
  46854. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  46855. Add bicubic and convolution shader members, and useXXX() functions.
  46856. * platform/graphics/skia/GraphicsContextSkia.cpp:
  46857. (WebCore::GraphicsContext::setPlatformShadow):
  46858. Hook into GraphicsContextSkia's platform shadow setters to set
  46859. parameters on GLES2Canvas.
  46860. * platform/graphics/skia/PlatformContextSkia.cpp:
  46861. (WebCore::PlatformContextSkia::canAccelerate):
  46862. Remove shadows (loopers) from the list of things we can't accelerate.
  46863. 2011-03-18 Andreas Kling <kling@webkit.org>
  46864. Reviewed by Darin Adler.
  46865. Remove unused method FontFallbackList::fontDataForCharacters()
  46866. https://bugs.webkit.org/show_bug.cgi?id=56657
  46867. * platform/graphics/Font.h:
  46868. * platform/graphics/FontFallbackList.cpp:
  46869. * platform/graphics/FontFallbackList.h:
  46870. 2011-03-18 Andreas Kling <kling@webkit.org>
  46871. Reverting accidental changes in r81498.
  46872. 2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
  46873. Reviewed by Yury Semikhatsky.
  46874. Web Inspector: rename console agent events.
  46875. https://bugs.webkit.org/show_bug.cgi?id=56646
  46876. addConsoleMessage -> consoleMessage
  46877. updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
  46878. updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
  46879. * inspector/ConsoleMessage.cpp:
  46880. (WebCore::ConsoleMessage::addToFrontend):
  46881. (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  46882. * inspector/Inspector.json:
  46883. * inspector/InspectorConsoleAgent.cpp:
  46884. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  46885. * inspector/front-end/ConsoleView.js:
  46886. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage):
  46887. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate):
  46888. (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):
  46889. 2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>
  46890. Unreviewed, rolling out r81487.
  46891. http://trac.webkit.org/changeset/81487
  46892. https://bugs.webkit.org/show_bug.cgi?id=56662
  46893. "Breaks inspector/styles/styles-add-blank-property.html"
  46894. (Requested by apavlov on #webkit).
  46895. * inspector/Inspector.json:
  46896. * inspector/InspectorCSSAgent.cpp:
  46897. (WebCore::InspectorCSSAgent::getAllStyles):
  46898. * inspector/InspectorCSSAgent.h:
  46899. * inspector/InspectorStyleSheet.cpp:
  46900. (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  46901. * inspector/InspectorStyleSheet.h:
  46902. * inspector/front-end/AuditRules.js:
  46903. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
  46904. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  46905. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  46906. * inspector/front-end/CSSStyleModel.js:
  46907. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  46908. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  46909. (WebInspector.CSSStyleModel.prototype._onRevert):
  46910. (WebInspector.CSSStyleSheet):
  46911. (WebInspector.CSSStyleSheet.prototype.setText):
  46912. 2011-03-18 Justin Novosad <junov@chromium.org>
  46913. Reviewed by Kenneth Russell.
  46914. [Chromium] Canvas shadow is not working with drawImage
  46915. https://bugs.webkit.org/show_bug.cgi?id=55506
  46916. Patch also fixes shadow blur quality and color.
  46917. Affects Chromium win/linux. Also fixes the following bugs:
  46918. https://bugs.webkit.org/show_bug.cgi?id=50112
  46919. https://bugs.webkit.org/show_bug.cgi?id=51989
  46920. https://bugs.webkit.org/show_bug.cgi?id=55410
  46921. No tests were added, impact is already covered by multiple layout tests.
  46922. * platform/graphics/skia/GraphicsContextSkia.cpp:
  46923. (WebCore::GraphicsContext::setPlatformShadow):
  46924. * platform/graphics/skia/ImageSkia.cpp:
  46925. (WebCore::paintSkBitmap):
  46926. 2011-03-15 Alexander Pavlov <apavlov@chromium.org>
  46927. Reviewed by Pavel Feldman.
  46928. Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
  46929. https://bugs.webkit.org/show_bug.cgi?id=56310
  46930. Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
  46931. "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
  46932. by CSSAgent.getStyleSheet() anymore.
  46933. Test: inspector/styles/get-set-stylesheet-text.html
  46934. * inspector/Inspector.json:
  46935. * inspector/InspectorCSSAgent.cpp:
  46936. (WebCore::InspectorCSSAgent::getAllStyleSheets):
  46937. * inspector/InspectorCSSAgent.h:
  46938. * inspector/InspectorStyleSheet.cpp:
  46939. (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  46940. (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  46941. * inspector/InspectorStyleSheet.h:
  46942. * inspector/front-end/AuditRules.js:
  46943. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
  46944. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  46945. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  46946. * inspector/front-end/CSSStyleModel.js:
  46947. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  46948. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  46949. (WebInspector.CSSStyleModel.prototype._onRevert):
  46950. (WebInspector.CSSStyleSheet):
  46951. (WebInspector.CSSStyleSheet.prototype.setText):
  46952. 2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
  46953. Reviewed by Martin Robinson.
  46954. [GTK] On-demand event-listeners for DOM event signals
  46955. https://bugs.webkit.org/show_bug.cgi?id=49649
  46956. Add explicit EventTarget API to add/remove event listeners instead
  46957. of using GSignal, which due to internal limitations in glib makes
  46958. us preemptively add listeners for all event types.
  46959. * bindings/gobject/GObjectEventListener.cpp: add new
  46960. addEventListener/removeEventListener methods, and small
  46961. refactoring to store an EventTarget internally instead of a DOM
  46962. node, which is more generic and can be reused in more cases.
  46963. * bindings/gobject/GObjectEventListener.h: ditto.
  46964. * bindings/gobject/WebKitDOMEventTarget.cpp:
  46965. (webkit_dom_event_target_add_event_listener): new iface method to
  46966. add an event listener.
  46967. (webkit_dom_event_target_remove_event_listener): new iface method
  46968. to remove an event listener.
  46969. * bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
  46970. * bindings/scripts/CodeGeneratorGObject.pm: change code generation
  46971. accordingly.
  46972. 2011-03-18 Brady Eidson <beidson@apple.com>
  46973. Reviewed by Sam Weinig.
  46974. https://bugs.webkit.org/show_bug.cgi?id=56425
  46975. More groundwork for WebKit2 IconDatabase
  46976. -Update the synchronous method names to be prefixed with "synchronous."
  46977. -Call asynchronous versions of the appropriate methods if the IconDatabase supports them.
  46978. Update icon database calls to be prefixed with "synchronous":
  46979. * loader/archive/cf/LegacyWebArchive.cpp:
  46980. (WebCore::LegacyWebArchive::create):
  46981. * loader/icon/IconDatabaseBase.h:
  46982. (WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
  46983. (WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
  46984. (WebCore::IconDatabaseBase::synchronousIconForPageURL):
  46985. * loader/icon/IconDatabase.cpp:
  46986. (WebCore::IconDatabase::synchronousIconForPageURL):
  46987. (WebCore::IconDatabase::readIconForPageURLFromDisk):
  46988. (WebCore::IconDatabase::synchronousIconURLForPageURL):
  46989. (WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
  46990. (WebCore::IconDatabase::synchronousIconDataKnownForIconURL):
  46991. * loader/icon/IconDatabase.h:
  46992. * loader/icon/IconDatabaseBase.cpp:
  46993. (WebCore::IconDatabaseBase::synchronousIconURLForPageURL):
  46994. Add nascent support for an asynchronous icon database mode:
  46995. * loader/icon/IconDatabaseBase.h:
  46996. (WebCore::EnumCallback::create):
  46997. (WebCore::EnumCallback::~EnumCallback):
  46998. (WebCore::EnumCallback::performCallback):
  46999. (WebCore::EnumCallback::invalidate):
  47000. (WebCore::EnumCallback::EnumCallback):
  47001. (WebCore::ObjectCallback::create):
  47002. (WebCore::ObjectCallback::~ObjectCallback):
  47003. (WebCore::ObjectCallback::performCallback):
  47004. (WebCore::ObjectCallback::invalidate):
  47005. (WebCore::ObjectCallback::ObjectCallback):
  47006. (WebCore::IconDatabaseBase::supportsAsynchronousMode):
  47007. (WebCore::IconDatabaseBase::loadDecisionForIconURL):
  47008. (WebCore::IconDatabaseBase::iconDataForIconURL):
  47009. Add interfaces to use the asynchronous versions of certain IconDatabase calls:
  47010. * loader/DocumentLoader.cpp:
  47011. (WebCore::DocumentLoader::~DocumentLoader):
  47012. (WebCore::DocumentLoader::iconLoadDecisionAvailable):
  47013. (WebCore::iconLoadDecisionCallback):
  47014. (WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
  47015. (WebCore::DocumentLoader::continueIconLoadWithDecision):
  47016. (WebCore::iconDataCallback):
  47017. (WebCore::DocumentLoader::getIconDataForIconURL):
  47018. * loader/DocumentLoader.h:
  47019. Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
  47020. icon database modes:
  47021. * loader/FrameLoader.cpp:
  47022. (WebCore::FrameLoader::iconLoadDecisionReceived):
  47023. (WebCore::FrameLoader::startIconLoader):
  47024. (WebCore::FrameLoader::continueIconLoadWithDecision):
  47025. * loader/FrameLoader.h:
  47026. * WebCore.exp.in:
  47027. 2011-03-18 Pavel Feldman <pfeldman@chromium.org>
  47028. Not reviewed: add missing brace to the generated Inspector.idl.
  47029. * inspector/generate-inspector-idl:
  47030. 2011-03-18 Pavel Feldman <pfeldman@chromium.org>
  47031. Reviewed by Yury Semikhatsky.
  47032. Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
  47033. https://bugs.webkit.org/show_bug.cgi?id=56294
  47034. * CMakeLists.txt:
  47035. * CodeGenerators.pri:
  47036. * DerivedSources.make:
  47037. * GNUmakefile.am:
  47038. * WebCore.gyp/WebCore.gyp:
  47039. * inspector/Inspector.idl: Removed.
  47040. * inspector/Inspector.json: Added.
  47041. * inspector/generate-inspector-idl: Added.
  47042. 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
  47043. Reviewed by Yury Semikhatsky.
  47044. Web Inspector: implement inspector session storage.
  47045. https://bugs.webkit.org/show_bug.cgi?id=56643
  47046. We would like to enable debugger/profiler from frontend side only.
  47047. However, when user clicks "Start Debugging JavaScript" in Safari, we
  47048. need to enable debugger when frontend is opened or re-opened for the
  47049. same page. The idea is to store debugger-enabled setting in session
  47050. storage and check it on frontend load.
  47051. * inspector/InspectorFrontendClient.h:
  47052. (WebCore::InspectorFrontendClient::saveSessionSetting):
  47053. (WebCore::InspectorFrontendClient::loadSessionSetting):
  47054. * inspector/InspectorFrontendHost.cpp:
  47055. (WebCore::InspectorFrontendHost::saveSessionSetting):
  47056. (WebCore::InspectorFrontendHost::loadSessionSetting):
  47057. * inspector/InspectorFrontendHost.h:
  47058. * inspector/InspectorFrontendHost.idl:
  47059. 2011-03-18 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  47060. Reviewed by Kenneth Rohde Christiansen.
  47061. [Qt] Enable GraphicsContext3D only when the window surface support OpenGL
  47062. https://bugs.webkit.org/show_bug.cgi?id=56555
  47063. Allow creation of WebGLRenderingContext in the HTMLCanvasElement
  47064. only if accelerated compositing is enabled. In GraphicsContext3D,
  47065. while blitting the surface check that viewport hasn't changed from
  47066. creation and painter is associated to the viewport.
  47067. * html/HTMLCanvasElement.cpp:
  47068. (WebCore::HTMLCanvasElement::getContext):
  47069. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  47070. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
  47071. (WebCore::GraphicsContext3DInternal::getViewportGLWidget):
  47072. (WebCore::GraphicsContext3DInternal::paint):
  47073. 2011-03-17 Pavel Podivilov <podivilov@chromium.org>
  47074. Reviewed by Pavel Feldman.
  47075. Web Inspector: extract content loading logic from scripts panel.
  47076. https://bugs.webkit.org/show_bug.cgi?id=55237
  47077. Encapsulate source files creation logic in debugger presentation model
  47078. to support source mappings in a pluggable way.
  47079. * inspector/front-end/DebuggerPresentationModel.js:
  47080. (WebInspector.DebuggerPresentationModel.prototype.sourceFile):
  47081. (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
  47082. (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
  47083. (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
  47084. (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
  47085. (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
  47086. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  47087. (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
  47088. (WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
  47089. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  47090. (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
  47091. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
  47092. (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
  47093. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  47094. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  47095. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  47096. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  47097. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  47098. (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  47099. (WebInspector.DebuggerPresentationModel.prototype.reset):
  47100. * inspector/front-end/ScriptsPanel.js:
  47101. (WebInspector.ScriptsPanel):
  47102. (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
  47103. (WebInspector.ScriptsPanel.prototype._showSourceFrame):
  47104. (WebInspector.ScriptsPanel.prototype._sourceFileChanged):
  47105. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  47106. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  47107. 2011-03-18 Yury Semikhatsky <yurys@chromium.org>
  47108. Reviewed by Pavel Feldman.
  47109. Web Inspector: console doesn&apos;t scroll when multiline expression is being evaluated
  47110. https://bugs.webkit.org/show_bug.cgi?id=56639
  47111. Always scoll in the console when command result is received.
  47112. * inspector/front-end/ConsoleView.js:
  47113. (WebInspector.ConsoleView.prototype.addMessage):
  47114. 2011-03-18 Adam Roben <aroben@apple.com>
  47115. Fix a CFNumber leak seen on the leaks bot
  47116. Reviewed by Gavin Barraclough.
  47117. * platform/network/mac/FormDataStreamMac.mm:
  47118. (WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
  47119. released.
  47120. 2011-03-17 Adam Barth <abarth@webkit.org>
  47121. Reviewed by Eric Seidel.
  47122. Add some of the remaining platform/mac files to WebCore GYP build
  47123. https://bugs.webkit.org/show_bug.cgi?id=56616
  47124. These files used to be hard, but are now magically easy. 76 link errors.
  47125. * gyp/WebCore.gyp:
  47126. 2011-03-17 Adam Klein <adamk@chromium.org>
  47127. Reviewed by Adam Barth.
  47128. [filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
  47129. https://bugs.webkit.org/show_bug.cgi?id=56502
  47130. * fileapi/Entry.idl:
  47131. * fileapi/EntryBase.cpp:
  47132. (WebCore::EntryBase::toURL):
  47133. * fileapi/EntryBase.h:
  47134. * fileapi/EntrySync.idl:
  47135. * page/DOMWindow.cpp:
  47136. (WebCore::DOMWindow::resolveLocalFileSystemURL):
  47137. * page/DOMWindow.h:
  47138. * page/DOMWindow.idl:
  47139. 2011-03-17 Adam Barth <abarth@webkit.org>
  47140. Reviewed by Eric Seidel.
  47141. Update CSP directive parser to match spec
  47142. https://bugs.webkit.org/show_bug.cgi?id=56582
  47143. Brandon updated the CSP spec. I've updated our implementation to
  47144. match. In the process, I found a couple bugs in the spec, which I've
  47145. sent to the working group. This patch assumes that the bugs will be
  47146. fixed in the way I suggested. If they get fixed a different way, we
  47147. might need to update the parser again.
  47148. Test: http/tests/security/contentSecurityPolicy/directive-parsing.html
  47149. * page/ContentSecurityPolicy.cpp:
  47150. (WebCore::isDirectiveNameCharacter):
  47151. (WebCore::isDirectiveValueCharacter):
  47152. (WebCore::advanceUntil):
  47153. (WebCore::ContentSecurityPolicy::parse):
  47154. (WebCore::ContentSecurityPolicy::parseDirective):
  47155. * page/ContentSecurityPolicy.h:
  47156. 2011-03-17 Adam Barth <abarth@webkit.org>
  47157. Reviewed by Eric Seidel.
  47158. WebCore GYP build should have PrivateHeaders
  47159. https://bugs.webkit.org/show_bug.cgi?id=56604
  47160. I've manually verified that this produces the correct set of
  47161. PrivateHeaders (modulo the ForwardingHeaders and icu issue).
  47162. Unforunately, this patch breakes compile slightly, but I'll fix that
  47163. in a followup patch.
  47164. * WebCore.gyp/WebCore.gyp:
  47165. * WebCore.gypi:
  47166. * gyp/WebCore.gyp:
  47167. 2011-03-17 Victoria Kirst <vrk@google.com>
  47168. Reviewed by Kenneth Russell.
  47169. [chromium] Video colors have wrong brightness/contrast
  47170. https://bugs.webkit.org/show_bug.cgi?id=56598
  47171. This patch changes the YUV to RGB color conversion matrix
  47172. to have brighter whites and darker blacks in accordance to
  47173. the BT.601 standard.
  47174. * platform/graphics/chromium/ShaderChromium.cpp:
  47175. (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
  47176. (WebCore::FragmentShaderYUVVideo::init):
  47177. (WebCore::FragmentShaderYUVVideo::getShaderString):
  47178. * platform/graphics/chromium/ShaderChromium.h:
  47179. (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
  47180. * platform/graphics/chromium/VideoLayerChromium.cpp:
  47181. (WebCore::VideoLayerChromium::drawYUV):
  47182. * platform/graphics/chromium/VideoLayerChromium.h:
  47183. 2011-03-17 Zhenyao Mo <zmo@google.com>
  47184. Reviewed by Adam Barth.
  47185. RequestAnimationFrame callbacks prevent Document from being released on detach
  47186. https://bugs.webkit.org/show_bug.cgi?id=56607
  47187. * dom/Document.cpp:
  47188. (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks.
  47189. (WebCore::Document::detach): Ditto.
  47190. 2011-03-17 Beth Dakin <bdakin@apple.com>
  47191. Reviewed by Darin Adler.
  47192. Fix for https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
  47193. fail to appear
  47194. -and corresponding-
  47195. <rdar://problem/8953779>
  47196. * platform/mac/ScrollAnimatorMac.mm:
  47197. (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
  47198. 2011-03-17 Dan Bernstein <mitz@apple.com>
  47199. Reviewed by Beth Dakin.
  47200. <rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
  47201. https://bugs.webkit.org/show_bug.cgi?id=56480
  47202. Test: fast/text/emphasis-combined-text.html
  47203. * rendering/InlineTextBox.cpp:
  47204. (WebCore::rotation): Added this helper.
  47205. (WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
  47206. centered vertically.
  47207. 2011-03-17 Jian Li <jianli@chromium.org>
  47208. Reviewed by Adam Barth.
  47209. Blob URL should not be allow to get created from the code running from data URI
  47210. https://bugs.webkit.org/show_bug.cgi?id=56600
  47211. Test: http/tests/fileapi/create-blob-url-from-data-url.html
  47212. * dom/ScriptExecutionContext.cpp:
  47213. (WebCore::ScriptExecutionContext::createPublicBlobURL):
  47214. * fileapi/BlobURL.cpp:
  47215. (WebCore::BlobURL::createBlobURL):
  47216. * fileapi/EntryBase.cpp:
  47217. (WebCore::EntryBase::toURI):
  47218. * fileapi/FileReaderLoader.cpp:
  47219. (WebCore::FileReaderLoader::start):
  47220. 2011-03-17 Jeff Miller <jeffm@apple.com>
  47221. Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
  47222. *.mode*
  47223. *.pbxuser
  47224. *.perspective*
  47225. project.xcworkspace
  47226. xcuserdata
  47227. * WebCore.xcodeproj: Modified property svn:ignore.
  47228. * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
  47229. 2011-03-17 Sam Weinig <sam@webkit.org>
  47230. Fix Mac build.
  47231. * WebCore.exp.in:
  47232. Add missing symbol.
  47233. 2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
  47234. Reviewed by Adele Peterson and Enrica Casucci.
  47235. Assert that editing does not ignore position's anchorNode if position is an offset in anchor
  47236. https://bugs.webkit.org/show_bug.cgi?id=56027
  47237. Debug build fix.
  47238. * dom/Element.cpp:
  47239. (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate
  47240. a position inside the node. Call firstPositionInOrBeforeNode instead.
  47241. * editing/ReplaceSelectionCommand.cpp:
  47242. (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead
  47243. of just when the node is br.
  47244. * editing/htmlediting.cpp:
  47245. (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element
  47246. so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.
  47247. 2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
  47248. Unreviewed, rolling out r81369.
  47249. http://trac.webkit.org/changeset/81369
  47250. https://bugs.webkit.org/show_bug.cgi?id=56579
  47251. breaks debugger test (Requested by podivilov on #webkit).
  47252. * inspector/front-end/DebuggerPresentationModel.js:
  47253. (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
  47254. (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
  47255. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  47256. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
  47257. (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
  47258. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  47259. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  47260. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  47261. (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
  47262. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  47263. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  47264. (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  47265. (WebInspector.DebuggerPresentationModel.prototype.reset):
  47266. * inspector/front-end/ScriptsPanel.js:
  47267. (WebInspector.ScriptsPanel):
  47268. (WebInspector.ScriptsPanel.prototype._parsedScriptSource):
  47269. (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource):
  47270. (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  47271. (WebInspector.ScriptsPanel.prototype._addScript):
  47272. (WebInspector.ScriptsPanel.prototype._resourceForURL):
  47273. (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
  47274. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
  47275. (WebInspector.ScriptsPanel.prototype._showSourceFrame):
  47276. (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
  47277. (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript):
  47278. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  47279. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  47280. 2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
  47281. Reviewed by Justin Garcia.
  47282. Assert that editing does not ignore position's anchorNode if position is an offset in anchor
  47283. https://bugs.webkit.org/show_bug.cgi?id=56027
  47284. Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
  47285. places where we instantiate positions inside a node on which editingIgnoresContent returns true.
  47286. Test: editing/execCommand/button.html
  47287. * dom/Position.cpp:
  47288. (WebCore::Position::Position): Added an assertion.
  47289. (WebCore::Position::moveToPosition): Ditto.
  47290. * dom/PositionIterator.cpp:
  47291. (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below
  47292. a node whose content is ignored by editing. While this does not avoid creation of positions
  47293. inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve
  47294. the underlying problem. Without this change, the assertion hits in existing layout tests.
  47295. cannot be tested directly.
  47296. * editing/ApplyStyleCommand.cpp:
  47297. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode
  47298. instead of firstPositionInNode because startNode may as well be a br element. Without this change,
  47299. the assertion hits in existing layout tests.
  47300. * editing/htmlediting.cpp:
  47301. (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test
  47302. for this.
  47303. * editing/visible_units.cpp:
  47304. (WebCore::previousBoundary): Added a FIXME.
  47305. (WebCore::startPositionForLine): Because br can also have an inline text box, checking that
  47306. startBox is an inline text box isn't an adequate to instantiate a position inside startNode.
  47307. Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout
  47308. tests.
  47309. 2011-03-17 Pavel Podivilov <podivilov@chromium.org>
  47310. Reviewed by Pavel Feldman.
  47311. Web Inspector: extract content loading logic from scripts panel.
  47312. https://bugs.webkit.org/show_bug.cgi?id=55237
  47313. Encapsulate source files creation logic in debugger presentation model
  47314. to support source mappings in a pluggable way.
  47315. * inspector/front-end/DebuggerPresentationModel.js:
  47316. (WebInspector.DebuggerPresentationModel.prototype.sourceFile):
  47317. (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
  47318. (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
  47319. (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
  47320. (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
  47321. (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
  47322. (WebInspector.DebuggerPresentationModel.prototype._addScript):
  47323. (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
  47324. (WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
  47325. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  47326. (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
  47327. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
  47328. (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
  47329. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  47330. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  47331. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  47332. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  47333. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  47334. (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  47335. (WebInspector.DebuggerPresentationModel.prototype.reset):
  47336. * inspector/front-end/ScriptsPanel.js:
  47337. (WebInspector.ScriptsPanel):
  47338. (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
  47339. (WebInspector.ScriptsPanel.prototype._showSourceFrame):
  47340. (WebInspector.ScriptsPanel.prototype._sourceFileChanged):
  47341. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  47342. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  47343. 2011-03-17 Pavel Feldman <pfeldman@chromium.org>
  47344. Reviewed by Yury Semikhatsky.
  47345. Web Inspector: add types markup to the IDL, remove Value types from the protocol.
  47346. https://bugs.webkit.org/show_bug.cgi?id=56562
  47347. * inspector/ConsoleMessage.cpp:
  47348. (WebCore::ConsoleMessage::addToFrontend):
  47349. * inspector/InjectedScript.cpp:
  47350. (WebCore::InjectedScript::evaluate):
  47351. (WebCore::InjectedScript::evaluateOn):
  47352. (WebCore::InjectedScript::evaluateOnCallFrame):
  47353. (WebCore::InjectedScript::getProperties):
  47354. (WebCore::InjectedScript::setPropertyValue):
  47355. (WebCore::InjectedScript::callFrames):
  47356. (WebCore::InjectedScript::makeCall):
  47357. (WebCore::InjectedScript::makeObjectCall):
  47358. * inspector/InjectedScript.h:
  47359. * inspector/InjectedScriptSource.js:
  47360. (.):
  47361. * inspector/Inspector.idl:
  47362. * inspector/InspectorApplicationCacheAgent.cpp:
  47363. (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  47364. * inspector/InspectorApplicationCacheAgent.h:
  47365. * inspector/InspectorCSSAgent.cpp:
  47366. (WebCore::InspectorCSSAgent::getStylesForNode):
  47367. (WebCore::InspectorCSSAgent::getInlineStyleForNode):
  47368. (WebCore::InspectorCSSAgent::getComputedStyleForNode):
  47369. (WebCore::InspectorCSSAgent::getStyleSheet):
  47370. (WebCore::InspectorCSSAgent::setPropertyText):
  47371. (WebCore::InspectorCSSAgent::toggleProperty):
  47372. (WebCore::InspectorCSSAgent::setRuleSelector):
  47373. (WebCore::InspectorCSSAgent::addRule):
  47374. * inspector/InspectorCSSAgent.h:
  47375. * inspector/InspectorDOMAgent.cpp:
  47376. (WebCore::InspectorDOMAgent::resolveNode):
  47377. * inspector/InspectorDOMAgent.h:
  47378. * inspector/InspectorDebuggerAgent.cpp:
  47379. (WebCore::InspectorDebuggerAgent::editScriptSource):
  47380. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  47381. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  47382. * inspector/InspectorDebuggerAgent.h:
  47383. * inspector/InspectorResourceAgent.cpp:
  47384. (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  47385. * inspector/InspectorRuntimeAgent.cpp:
  47386. (WebCore::InspectorRuntimeAgent::evaluate):
  47387. (WebCore::InspectorRuntimeAgent::evaluateOn):
  47388. (WebCore::InspectorRuntimeAgent::getProperties):
  47389. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  47390. * inspector/InspectorRuntimeAgent.h:
  47391. * inspector/ScriptCallStack.cpp:
  47392. (WebCore::ScriptCallStack::buildInspectorArray):
  47393. * inspector/ScriptCallStack.h:
  47394. * inspector/TimelineRecordFactory.cpp:
  47395. (WebCore::TimelineRecordFactory::createGenericRecord):
  47396. * inspector/front-end/NetworkManager.js:
  47397. (WebInspector.NetworkDispatcher.prototype._createResource):
  47398. 2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
  47399. Unreviewed, rolling out r81350.
  47400. http://trac.webkit.org/changeset/81350
  47401. https://bugs.webkit.org/show_bug.cgi?id=56560
  47402. "Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
  47403. (Requested by apavlov on #webkit).
  47404. * WebCore.gypi:
  47405. * platform/graphics/chromium/GLES2Canvas.cpp:
  47406. (WebCore::GLES2Canvas::State::State):
  47407. (WebCore::GLES2Canvas::clearRect):
  47408. (WebCore::GLES2Canvas::fillPath):
  47409. (WebCore::GLES2Canvas::fillRect):
  47410. (WebCore::GLES2Canvas::clipPath):
  47411. (WebCore::GLES2Canvas::restore):
  47412. (WebCore::GLES2Canvas::drawTexturedRect):
  47413. (WebCore::GLES2Canvas::drawTexturedRectTile):
  47414. (WebCore::GLES2Canvas::drawQuad):
  47415. * platform/graphics/chromium/GLES2Canvas.h:
  47416. * platform/graphics/gpu/BicubicShader.cpp: Removed.
  47417. * platform/graphics/gpu/BicubicShader.h: Removed.
  47418. * platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  47419. * platform/graphics/gpu/ConvolutionShader.h: Removed.
  47420. * platform/graphics/gpu/DrawingBuffer.h:
  47421. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  47422. (WebCore::SharedGraphicsContext3D::create):
  47423. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  47424. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  47425. * platform/graphics/skia/GraphicsContextSkia.cpp:
  47426. (WebCore::GraphicsContext::setPlatformShadow):
  47427. * platform/graphics/skia/PlatformContextSkia.cpp:
  47428. (WebCore::PlatformContextSkia::canAccelerate):
  47429. 2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
  47430. Reviewed by Yury Semikhatsky.
  47431. Web Inspector: Clean up Inspector strings.
  47432. https://bugs.webkit.org/show_bug.cgi?id=56557
  47433. * English.lproj/localizedStrings.js:
  47434. 2011-03-14 Pavel Podivilov <podivilov@chromium.org>
  47435. Reviewed by Yury Semikhatsky.
  47436. Web Inspector: refactor event listener breakpoints.
  47437. https://bugs.webkit.org/show_bug.cgi?id=56305
  47438. - restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  47439. - store event listener breakpoints in a separate separate setting
  47440. - move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
  47441. Test: inspector/debugger/event-listener-breakpoints.html
  47442. * inspector/Inspector.idl:
  47443. * inspector/InspectorAgent.cpp:
  47444. (WebCore::InspectorAgent::setFrontend):
  47445. * inspector/InspectorBrowserDebuggerAgent.cpp:
  47446. (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
  47447. (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
  47448. (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
  47449. (WebCore::InspectorBrowserDebuggerAgent::clear):
  47450. * inspector/InspectorBrowserDebuggerAgent.h:
  47451. * inspector/InspectorInstrumentation.cpp:
  47452. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  47453. * inspector/front-end/BreakpointManager.js:
  47454. (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
  47455. (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
  47456. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  47457. (WebInspector.BreakpointManager.prototype._projectChanged):
  47458. (WebInspector.BreakpointManager.prototype._saveBreakpoints):
  47459. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  47460. (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  47461. * inspector/front-end/BreakpointsSidebarPane.js:
  47462. (WebInspector.EventListenerBreakpointsSidebarPane):
  47463. (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
  47464. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  47465. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
  47466. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
  47467. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
  47468. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  47469. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
  47470. (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
  47471. (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  47472. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
  47473. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  47474. * inspector/front-end/CallStackSidebarPane.js:
  47475. (WebInspector.CallStackSidebarPane.prototype.update):
  47476. (WebInspector.CallStackSidebarPane.prototype.setStatus):
  47477. (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  47478. * inspector/front-end/ScriptsPanel.js:
  47479. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  47480. (WebInspector.ScriptsPanel.prototype._clearInterface):
  47481. * inspector/front-end/Settings.js:
  47482. (WebInspector.Settings):
  47483. 2011-03-16 Stephen White <senorblanco@chromium.org>
  47484. Reviewed by Kenneth Russell.
  47485. Implement GPU-accelerated shadows.
  47486. https://bugs.webkit.org/show_bug.cgi?id=56476
  47487. For hard shadows, we simply offset the CTM and draw in the shadow
  47488. color. For soft shadows, we use a separable Gaussian convolution,
  47489. with a bilinear downsample and Mitchell-Netravali upsample in order to
  47490. preserve quality.
  47491. * WebCore.gypi:
  47492. Add BicubicShader and ConvolutionShader to the build.
  47493. * platform/graphics/chromium/GLES2Canvas.cpp:
  47494. (WebCore::GLES2Canvas::State::State):
  47495. Add shadow-related members to the GLES2Canvas::State
  47496. (WebCore::GLES2Canvas::State::shadowActive):
  47497. Add a helper function to know if shadows are active.
  47498. (WebCore::GLES2Canvas::clearRect):
  47499. (WebCore::GLES2Canvas::scissorClear):
  47500. Refactor the scissor clearing function out of clearRect().
  47501. (WebCore::GLES2Canvas::fillPath):
  47502. Add hook for shadow rendering in paths. Bind framebuffer at this level.
  47503. (WebCore::GLES2Canvas::fillRect):
  47504. Add hook for shadow rendering in rects. Bind framebuffer at this level.
  47505. (WebCore::GLES2Canvas::fillRectInternal):
  47506. Rename fillRect() -> fillRectInternal(), which does bind its vertex
  47507. buffer, but does not bind the framebuffer.
  47508. (WebCore::GLES2Canvas::setShadowColor):
  47509. (WebCore::GLES2Canvas::setShadowOffset):
  47510. (WebCore::GLES2Canvas::setShadowBlur):
  47511. (WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
  47512. Implement graphicsContext-style setters for shadow parameters.
  47513. (WebCore::GLES2Canvas::clipPath):
  47514. Call fillPathInternal(), not fillPath().
  47515. (WebCore::GLES2Canvas::restore):
  47516. (WebCore::GLES2Canvas::drawTexturedRect):
  47517. Bind the framebuffer at this level. Do not bind vertices here (will
  47518. be done in drawTexturedQuad).
  47519. (WebCore::GLES2Canvas::drawTexturedRectTile):
  47520. drawQuad() -> drawTexturedQuad().
  47521. (WebCore::GLES2Canvas::convolveRect):
  47522. Implement one pass of a convolution filter (X or Y).
  47523. (WebCore::gauss):
  47524. (WebCore::buildKernel):
  47525. Some helper functions to build a Gaussian convolution kernel.
  47526. (WebCore::GLES2Canvas::drawTexturedQuad):
  47527. Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not
  47528. bind the framebuffer at this level (it will be done higher).
  47529. (WebCore::GLES2Canvas::drawTexturedQuadMitchell):
  47530. Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
  47531. (WebCore::GLES2Canvas::fillPathInternal):
  47532. Rename fillPath() -> fillPathInternal(), which does use quad vertices,
  47533. but does not bind the framebuffer or set the compositing mode.
  47534. (WebCore::GLES2Canvas::flipRect):
  47535. Implement a helper function to flip a rectangle in Y within the canvas.
  47536. (WebCore::GLES2Canvas::clearBorders):
  47537. Implement a helper function to clear an n-pixel border around a rect.
  47538. (WebCore::GLES2Canvas::beginShadowDraw):
  47539. Setup before drawing a primitive's shadow: for hard shadows, just
  47540. offset the CTM by the shadow offset. For soft shadows, bind to an
  47541. offscreen DrawingBuffer.
  47542. (WebCore::GLES2Canvas::endShadowDraw):
  47543. Tear-down after drawing a primitive's shadow: for hard shadows, just
  47544. restore the CTM. For soft shadows, downsample (if necessary), then
  47545. blur in X, blur in Y, upsample if necessary).
  47546. * platform/graphics/chromium/GLES2Canvas.h:
  47547. * platform/graphics/gpu/BicubicShader.cpp: Added.
  47548. (WebCore::BicubicShader::BicubicShader):
  47549. (WebCore::BicubicShader::create):
  47550. (WebCore::BicubicShader::use):
  47551. * platform/graphics/gpu/BicubicShader.h: Added.
  47552. Implement a bicubic image filtering shader.
  47553. * platform/graphics/gpu/ConvolutionShader.cpp: Added.
  47554. (WebCore::ConvolutionShader::ConvolutionShader):
  47555. (WebCore::ConvolutionShader::create):
  47556. (WebCore::ConvolutionShader::use):
  47557. * platform/graphics/gpu/ConvolutionShader.h: Added.
  47558. Implement a 1-dimensional convolution shader. In order to minimize
  47559. texture samples, this shader is parameterized at compile time by the
  47560. width of the convolution kernel.
  47561. * platform/graphics/gpu/DrawingBuffer.h:
  47562. (WebCore::DrawingBuffer::colorBuffer):
  47563. Add an accessor to retrieve a DrawingBuffer's texture ID.
  47564. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  47565. (WebCore::SharedGraphicsContext3D::create):
  47566. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  47567. (WebCore::SharedGraphicsContext3D::useBicubicProgram):
  47568. (WebCore::SharedGraphicsContext3D::useConvolutionProgram):
  47569. Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
  47570. each possible kernel width).
  47571. (WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
  47572. Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
  47573. This is done to minimize the VRAM usage: only 2 buffers are used for
  47574. all canvases.
  47575. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  47576. Add bicubic and convolution shader members, and useXXX() functions.
  47577. * platform/graphics/skia/GraphicsContextSkia.cpp:
  47578. (WebCore::GraphicsContext::setPlatformShadow):
  47579. Hook into GraphicsContextSkia's platform shadow setters to set
  47580. parameters on GLES2Canvas.
  47581. * platform/graphics/skia/PlatformContextSkia.cpp:
  47582. (WebCore::PlatformContextSkia::canAccelerate):
  47583. Remove shadows (loopers) from the list of things we can't accelerate.
  47584. 2011-03-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  47585. Reviewed by Andreas Kling.
  47586. Tiled backing store should only request repaint for updated areas
  47587. https://bugs.webkit.org/show_bug.cgi?id=56464
  47588. Reuse updateBackBuffer's dirty rectangle calculations to only
  47589. invalidate the necessary parts of the window.
  47590. * platform/graphics/Tile.h:
  47591. * platform/graphics/TiledBackingStore.cpp:
  47592. (WebCore::TiledBackingStore::updateTileBuffers):
  47593. * platform/graphics/qt/TileQt.cpp:
  47594. (WebCore::Tile::updateBackBuffer):
  47595. 2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
  47596. Reviewed by Pavel Feldman.
  47597. Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
  47598. https://bugs.webkit.org/show_bug.cgi?id=56395
  47599. * inspector/front-end/DetailedHeapshotGridNodes.js:
  47600. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  47601. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  47602. * inspector/front-end/HeapSnapshot.js:
  47603. (WebInspector.HeapSnapshotRetainerEdge): Added
  47604. (WebInspector.HeapSnapshotRetainerEdgeIterator): Added
  47605. (WebInspector.HeapSnapshotNode.prototype.get retainers):
  47606. (WebInspector.HeapSnapshot.prototype.dispose):
  47607. (WebInspector.HeapSnapshot.prototype.hasId):
  47608. (WebInspector.HeapSnapshot.prototype.retainers):
  47609. (WebInspector.HeapSnapshot.prototype._buildRetainers):
  47610. (WebInspector.HeapSnapshot.prototype._buildIdsList):
  47611. (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
  47612. (WebInspector.HeapSnapshot.prototype._findNodePositionInIndex):
  47613. (WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
  47614. (WebInspector.HeapSnapshot.prototype._getRetainerIndex):
  47615. (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
  47616. (WebInspector.HeapSnapshot.prototype._numbersComparator):
  47617. (WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge):
  47618. (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
  47619. (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
  47620. (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
  47621. 2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
  47622. Unreviewed, rolling out r81243.
  47623. http://trac.webkit.org/changeset/81243
  47624. https://bugs.webkit.org/show_bug.cgi?id=56471
  47625. Breaks GTK 64-bit Debug tests (Requested by podivilov on
  47626. #webkit).
  47627. * inspector/Inspector.idl:
  47628. * inspector/InspectorAgent.cpp:
  47629. (WebCore::InspectorAgent::setFrontend):
  47630. * inspector/InspectorBrowserDebuggerAgent.cpp:
  47631. (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
  47632. (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
  47633. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  47634. (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  47635. (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
  47636. (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
  47637. (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
  47638. (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
  47639. (WebCore::InspectorBrowserDebuggerAgent::clear):
  47640. * inspector/InspectorBrowserDebuggerAgent.h:
  47641. * inspector/InspectorInstrumentation.cpp:
  47642. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  47643. * inspector/front-end/BreakpointManager.js:
  47644. (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
  47645. (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
  47646. (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
  47647. (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
  47648. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  47649. (WebInspector.BreakpointManager.prototype._projectChanged):
  47650. (WebInspector.BreakpointManager.prototype._saveBreakpoints):
  47651. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  47652. (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  47653. (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  47654. (WebInspector.EventListenerBreakpoint):
  47655. (WebInspector.EventListenerBreakpoint.prototype._enable):
  47656. (WebInspector.EventListenerBreakpoint.prototype._disable):
  47657. (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
  47658. (WebInspector.EventListenerBreakpointView):
  47659. (WebInspector.EventListenerBreakpointView.eventNameForUI):
  47660. (WebInspector.EventListenerBreakpointView.prototype.get eventName):
  47661. (WebInspector.EventListenerBreakpointView.prototype.compareTo):
  47662. (WebInspector.EventListenerBreakpointView.prototype.populateLabelElement):
  47663. (WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement):
  47664. (WebInspector.EventListenerBreakpointView.prototype._uiEventName):
  47665. * inspector/front-end/BreakpointsSidebarPane.js:
  47666. (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
  47667. (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
  47668. (WebInspector.EventListenerBreakpointsSidebarPane):
  47669. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  47670. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
  47671. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
  47672. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded):
  47673. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged):
  47674. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved):
  47675. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
  47676. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
  47677. * inspector/front-end/CallStackSidebarPane.js:
  47678. (WebInspector.CallStackSidebarPane.prototype.update):
  47679. (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
  47680. (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  47681. (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
  47682. * inspector/front-end/ScriptsPanel.js:
  47683. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  47684. (WebInspector.ScriptsPanel.prototype._clearInterface):
  47685. * inspector/front-end/Settings.js:
  47686. (WebInspector.Settings):
  47687. 2011-03-17 Adam Barth <abarth@webkit.org>
  47688. Reviewed by Eric Seidel.
  47689. Add more ObjC++ files to the build
  47690. https://bugs.webkit.org/show_bug.cgi?id=56548
  47691. 96 link errors.
  47692. * WebCore.gypi:
  47693. * gyp/WebCore.gyp:
  47694. 2011-03-17 Adam Barth <abarth@webkit.org>
  47695. Reviewed by Eric Seidel.
  47696. Add a few Objective-C++ files to the WebCore GYP build
  47697. https://bugs.webkit.org/show_bug.cgi?id=56547
  47698. 464 link errors.
  47699. * gyp/WebCore.gyp:
  47700. 2011-03-17 Yuta Kitamura <yutak@chromium.org>
  47701. Unreviewed build fix.
  47702. Non-ASCII characters in XMLTreeViewer.{cpp,h}
  47703. https://bugs.webkit.org/show_bug.cgi?id=56549
  47704. * xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
  47705. * xml/XMLTreeViewer.h: Ditto.
  47706. 2011-03-17 Adam Barth <abarth@webkit.org>
  47707. Reviewed by Eric Seidel.
  47708. Add plugins and bridge to the WebCore GYP build
  47709. https://bugs.webkit.org/show_bug.cgi?id=56546
  47710. 506 link errors.
  47711. * gyp/WebCore.gyp:
  47712. 2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
  47713. Reviewed by Alexey Proskuryakov.
  47714. Logic error in -[WebHTMLView close]
  47715. https://bugs.webkit.org/show_bug.cgi?id=56445
  47716. The function setDraggingImageURL() is no longer called and can be deleted.
  47717. No new tests. Deleting dead code.
  47718. * page/DragController.h:
  47719. 2011-03-16 Naoki Takano <takano.naoki@gmail.com>
  47720. Reviewed by Ryosuke Niwa.
  47721. Textarea maxlength doesn't account for newlines
  47722. https://bugs.webkit.org/show_bug.cgi?id=54443
  47723. When a user presses a return key, TypingCommand::insertLineBreak() is called.
  47724. So before append a new line, check if we can add the new line.
  47725. * editing/TypingCommand.cpp:
  47726. (WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line.
  47727. (WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line.
  47728. (WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.
  47729. 2011-03-16 Adam Barth <abarth@webkit.org>
  47730. Reviewed by Eric Seidel.
  47731. WebCore GYP build should build more derived sources
  47732. https://bugs.webkit.org/show_bug.cgi?id=56529
  47733. This patch brings us down to 597 link errors.
  47734. * gyp/WebCore.gyp:
  47735. 2011-03-16 Adam Barth <abarth@webkit.org>
  47736. Reviewed by Eric Seidel.
  47737. WebCore GYP should build (most) remaining source files
  47738. https://bugs.webkit.org/show_bug.cgi?id=56515
  47739. We're still not building all the files and we have 1305 link errors,
  47740. but this patch is progress.
  47741. * WebCore.gypi:
  47742. * gyp/WebCore.gyp:
  47743. * plugins/PluginStream.cpp:
  47744. 2011-03-16 Dan Bernstein <mitz@apple.com>
  47745. Reviewed by Alexey Proskuryakov.
  47746. Update the default navigator.vendor value
  47747. https://bugs.webkit.org/show_bug.cgi?id=56449
  47748. * page/NavigatorBase.cpp: Updated the default value of
  47749. WEBCORE_NAVIGATOR_VENDOR.
  47750. 2011-03-16 John Bauman <jbauman@chromium.org>
  47751. Reviewed by James Robinson.
  47752. texImage2D gets old contents of canvas
  47753. https://bugs.webkit.org/show_bug.cgi?id=56414
  47754. Always update the canvas contents in copiedImage, as there's no reason
  47755. to ask for an out-of-date image.
  47756. * html/HTMLCanvasElement.cpp:
  47757. (WebCore::HTMLCanvasElement::copiedImage):
  47758. 2011-03-16 Adam Barth <abarth@webkit.org>
  47759. Reviewed by James Robinson.
  47760. Remove USE(BUILTIN_UTF8_CODEC)
  47761. https://bugs.webkit.org/show_bug.cgi?id=56508
  47762. * platform/text/TextCodecICU.cpp:
  47763. (WebCore::TextCodecICU::registerEncodingNames):
  47764. * platform/text/TextEncodingRegistry.cpp:
  47765. (WebCore::buildBaseTextCodecMaps):
  47766. 2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
  47767. Reviewed by Kenneth Rohde Christiansen.
  47768. Viewport no longer allows an auto value for "user-scalable"
  47769. https://bugs.webkit.org/show_bug.cgi?id=55416
  47770. This restores our behavior before r67376 the default "user-scalable"
  47771. behavior can be defined by a WebKit client if a value was not
  47772. explicitly provided in web content (via the viewport <meta> tag).
  47773. Here, all WebKit ports default to "yes" after computing
  47774. viewport arguments. However, in the future they may consider
  47775. changing the default user-scalable value based on the type
  47776. of the document being viewed, a user preference, or other reasons.
  47777. Covered by existing tests. Should be no changes.
  47778. * dom/ViewportArguments.cpp:
  47779. (WebCore::computeViewportAttributes): be explicit about 0.
  47780. (WebCore::findUserScalableValue): convert to return a float, the instance variable type.
  47781. * dom/ViewportArguments.h:
  47782. (WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to
  47783. allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the
  47784. WebKit client.
  47785. 2011-03-16 David Levin <levin@chromium.org>
  47786. Reviewed by Dmitry Titov.
  47787. REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".
  47788. Conditional jump or move depends on uninitialised value(s)
  47789. WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)
  47790. * page/Settings.cpp:
  47791. (WebCore::Settings::Settings):
  47792. 2011-03-16 Beth Dakin <bdakin@apple.com>
  47793. Reviewed by Darin Adler.
  47794. Fix for https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
  47795. scrollbars thumb in overflow regions does not work
  47796. -and corresponding-
  47797. <rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
  47798. regions does not work
  47799. Up until now, overlay scrollbars have always been treated in the Render Tree as if
  47800. they have a thickness of 0 because they should not affect layout. However, it is
  47801. important to consider their size when hit-testing because otherwise, we have this
  47802. bug! This patch adds a boolean parameter to overflowClipRect(),
  47803. RenderLayer::verticalScrollbarWidth(), and
  47804. RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
  47805. the actual overlay scrollbar thickness. It defaults to false and is only sent is
  47806. as true from RenderBloc::nodeAtPoint().
  47807. * rendering/RenderBlock.cpp:
  47808. (WebCore::RenderBlock::nodeAtPoint):
  47809. * rendering/RenderBox.cpp:
  47810. (WebCore::RenderBox::overflowClipRect):
  47811. * rendering/RenderBox.h:
  47812. * rendering/RenderLayer.cpp:
  47813. (WebCore::RenderLayer::verticalScrollbarWidth):
  47814. (WebCore::RenderLayer::horizontalScrollbarHeight):
  47815. * rendering/RenderLayer.h:
  47816. * rendering/RenderTable.cpp:
  47817. (WebCore::RenderTable::overflowClipRect):
  47818. * rendering/RenderTable.h:
  47819. 2011-03-16 Keith Kyzivat <keith.kyzivat@nokia.com>
  47820. Reviewed by Andreas Kling.
  47821. [Qt] Fix std::swap not found issue on mobile Qt devices.
  47822. https://bugs.webkit.org/show_bug.cgi?id=56463
  47823. Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
  47824. on some Qt mobile devices.
  47825. No new tests: No tests needed - compilation verified manually.
  47826. * platform/text/qt/TextBreakIteratorQt.cpp:
  47827. (WebCore::acquireLineBreakIterator):
  47828. 2011-03-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  47829. Reviewed by Kenneth Rohde Christiansen.
  47830. [Qt] WebGL content not shown when accelerated compositing is enabled
  47831. https://bugs.webkit.org/show_bug.cgi?id=56339
  47832. Removed all previously implemented WebGL code from GraphicsLayerQt
  47833. because API has changed. GraphicsContext3D provides PlatformLayer
  47834. that is added as a child of GraphicsLayer and is therefore painted
  47835. through QGraphicsView pipeline.
  47836. * platform/graphics/GraphicsContext3D.h:
  47837. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  47838. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
  47839. (WebCore::GraphicsContext3DInternal::paint):
  47840. (WebCore::GraphicsContext3DInternal::boundingRect):
  47841. (WebCore::GraphicsContext3D::platformLayer):
  47842. (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
  47843. (WebCore::GraphicsContext3D::reshape):
  47844. * platform/graphics/qt/GraphicsLayerQt.cpp:
  47845. (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
  47846. (WebCore::GraphicsLayerQtImpl::paint):
  47847. (WebCore::GraphicsLayerQtImpl::flushChanges):
  47848. (WebCore::GraphicsLayerQt::setContentsToCanvas):
  47849. * platform/graphics/qt/GraphicsLayerQt.h:
  47850. 2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
  47851. Reviewed by Tony Chang.
  47852. Get rid of nearestMailBlockquote
  47853. https://bugs.webkit.org/show_bug.cgi?id=56439
  47854. Removed nearestMailBlockquote and replaced the calls to the function by calls
  47855. to enclosingNodeOfType and highestEnclosingNodeOfType.
  47856. Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
  47857. respect editing boundaries. Added a test for the former command.
  47858. Test: editing/execCommand/break-non-editable-blockquote.html
  47859. * editing/BreakBlockquoteCommand.cpp:
  47860. (WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary
  47861. when looking for a Mail blockquote.
  47862. * editing/DeleteSelectionCommand.cpp:
  47863. (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto.
  47864. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  47865. * editing/ReplaceSelectionCommand.cpp:
  47866. (WebCore::hasMatchingQuoteLevel):
  47867. (WebCore::handleStyleSpansBeforeInsertion):
  47868. (WebCore::ReplaceSelectionCommand::handleStyleSpans):
  47869. (WebCore::ReplaceSelectionCommand::doApply):
  47870. * editing/htmlediting.cpp:
  47871. (WebCore::enclosingNodeOfType): Check rule upfront to improve the performance.
  47872. (WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
  47873. * editing/htmlediting.h:
  47874. (WebCore::firstPositionInOrBeforeNode): Added a null pointer check.
  47875. (WebCore::lastPositionInOrAfterNode): Ditto.
  47876. * editing/markup.cpp:
  47877. (WebCore::highestAncestorToWrapMarkup):
  47878. (WebCore::createMarkup):
  47879. 2011-03-16 Jer Noble <jer.noble@apple.com>
  47880. Reviewed by Beth Dakin.
  47881. RenderFullScreen::createFullScreenStyle() leaks
  47882. https://bugs.webkit.org/show_bug.cgi?id=53384
  47883. Two problems: a) not calling release() on the style returned in setFullScreenRenderer
  47884. causes an unnecessary ref/deref, and b) the fullscreen renderer needs to be destroyed,
  47885. not just detached, when it is no longer needed.
  47886. * dom/Document.cpp:
  47887. (WebCore::Document::setFullScreenRenderer): Destroy the current renderer when a new one is set.
  47888. * rendering/RenderFullScreen.cpp:
  47889. (RenderFullScreen::createFullScreenStyle): release() the return value.
  47890. 2011-03-16 Mike Reed <reed@google.com>
  47891. Reviewed by James Robinson.
  47892. Reestablish typeface/size/encoding when drawing stroked text
  47893. https://bugs.webkit.org/show_bug.cgi?id=56481
  47894. No new tests. LayoutTests/svg/css/composite-shadow-text.svg
  47895. * platform/graphics/skia/SkiaFontWin.cpp:
  47896. (WebCore::paintSkiaText):
  47897. 2011-03-16 Daniel Sievers <sievers@google.com>
  47898. Reviewed by James Robinson.
  47899. Add setting to always force compositing mode
  47900. https://bugs.webkit.org/show_bug.cgi?id=56156
  47901. No new tests needed as this defaults to disabled (and is unfeasible
  47902. to be tested through property overriding at runtime).
  47903. * page/Settings.h:
  47904. (WebCore::Settings::setForceCompositingMode):
  47905. (WebCore::Settings::forceCompositingMode):
  47906. * rendering/RenderLayerCompositor.cpp:
  47907. (WebCore::RenderLayerCompositor::RenderLayerCompositor):
  47908. (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  47909. * rendering/RenderLayerCompositor.h:
  47910. 2011-03-16 Vangelis Kokkevis <vangelis@chromium.org>
  47911. Reviewed by Kenneth Russell.
  47912. [chromium] Fixing backface visibility for transformed layers.
  47913. https://bugs.webkit.org/show_bug.cgi?id=56237
  47914. Test: platform/chromium/compositing/backface-visibility-transformed.html
  47915. * platform/graphics/chromium/LayerRendererChromium.cpp:
  47916. (WebCore::LayerRendererChromium::drawLayer):
  47917. 2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
  47918. Reviewed by Darin Adler.
  47919. REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
  47920. https://bugs.webkit.org/show_bug.cgi?id=56469
  47921. Technically, this is not a regression, but rather uncovering of an old
  47922. problem. When the RenderSlider::layout was written, the layout state was
  47923. pushed with a wrong offset. However, since the whole slider track was
  47924. always repainted, the problem didn't manifest itself until we actually
  47925. started being more precise in our repaints.
  47926. Test: fast/repaint/slider-thumb-float.html
  47927. * rendering/RenderSlider.cpp:
  47928. (WebCore::RenderSlider::layout): Changed to pass actual thumb offset
  47929. to the LayoutStateMaintainer, rather than thumb size.
  47930. 2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
  47931. Reviewed by Eric Carlson.
  47932. Add play state callbacks to MediaControls, kill timeUpdate timer.
  47933. https://bugs.webkit.org/show_bug.cgi?id=56473
  47934. No change in behavior, covered by existing tests.
  47935. * html/HTMLMediaElement.cpp:
  47936. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Added a call to
  47937. media controls.
  47938. (WebCore::HTMLMediaElement::updatePlayState): Ditto.
  47939. * html/shadow/MediaControls.cpp:
  47940. (WebCore::MediaControls::MediaControls): Removed initialization of the timer.
  47941. (WebCore::MediaControls::playbackProgressed): Added.
  47942. (WebCore::MediaControls::playbackStarted): Added, for now routing to just
  47943. call playbackProgressed.
  47944. (WebCore::MediaControls::playbackStopped): Ditto.
  47945. (WebCore::MediaControls::update): Removed the code to start/stop the
  47946. timer that's now gone.
  47947. * html/shadow/MediaControls.h: Removed timer decls.
  47948. 2011-03-16 Bill Budge <bbudge@chromium.org>
  47949. Reviewed by David Levin.
  47950. DocumentThreadableLoaderClient needs a protected default Constructor
  47951. https://bugs.webkit.org/show_bug.cgi?id=56479
  47952. No new tests. Exposes no new functionality.
  47953. * loader/DocumentThreadableLoaderClient.h:
  47954. (WebCore::DocumentThreadableLoaderClient::DocumentThreadableLoaderClient):
  47955. 2011-03-16 David Levin <levin@chromium.org>
  47956. Chromium Leopard build fix attempt #2.
  47957. Same error as before.
  47958. * bindings/v8/V8GCController.cpp:
  47959. 2011-03-16 David Levin <levin@chromium.org>
  47960. Chromium Leopard build fix attempt.
  47961. The error was 'WebCore::GrouperVisitor' has a field 'WebCore::GrouperVisitor::m_grouper' whose type uses the anonymous namespace.
  47962. * bindings/v8/V8GCController.cpp:
  47963. 2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
  47964. Reviewed by Dimitri Glazkov and Darin Adler.
  47965. Node::isContentEditable should always call parentNode() instead of parentOrHostNode()
  47966. https://bugs.webkit.org/show_bug.cgi?id=56472
  47967. Replaced the call to parentOrHostNode() in Node::isContentEditable by a call to parentNode().
  47968. Node::isContentEditable now calls parentNode() on all nodes.
  47969. No tests are added since this behavior change is not visible to scripts at the moment.
  47970. * dom/Node.cpp:
  47971. (WebCore::Node::isContentEditable):
  47972. 2011-03-16 Chris Fleizach <cfleizach@apple.com>
  47973. Reviewed by Darin Adler.
  47974. WK2: Need to propagate enhanced accessibility flag from UI -> web process
  47975. https://bugs.webkit.org/show_bug.cgi?id=56379
  47976. Allow the enhanced accessibility flag to be toggleable.
  47977. * accessibility/AXObjectCache.h:
  47978. (WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
  47979. 2011-03-16 Csaba Osztrogonác <ossy@webkit.org>
  47980. [Qt] Buildfix after r81230.
  47981. * WebCore.pri: Missing include path added.
  47982. 2011-03-15 Oliver Hunt <oliver@apple.com>
  47983. Reviewed by Geoffrey Garen.
  47984. Make Structure creation require a JSGlobalData
  47985. https://bugs.webkit.org/show_bug.cgi?id=56438
  47986. Mechanical change to make all structure creation use GlobalData
  47987. * bindings/js/JSAudioConstructor.cpp:
  47988. (WebCore::JSAudioConstructor::JSAudioConstructor):
  47989. * bindings/js/JSAudioConstructor.h:
  47990. (WebCore::JSAudioConstructor::createStructure):
  47991. * bindings/js/JSDOMBinding.h:
  47992. (WebCore::DOMObjectWithGlobalPointer::createStructure):
  47993. (WebCore::DOMConstructorObject::createStructure):
  47994. (WebCore::getDOMStructure):
  47995. * bindings/js/JSDOMGlobalObject.h:
  47996. (WebCore::JSDOMGlobalObject::createStructure):
  47997. * bindings/js/JSDOMWindowBase.h:
  47998. (WebCore::JSDOMWindowBase::createStructure):
  47999. * bindings/js/JSDOMWindowShell.cpp:
  48000. (WebCore::JSDOMWindowShell::JSDOMWindowShell):
  48001. (WebCore::JSDOMWindowShell::setWindow):
  48002. * bindings/js/JSDOMWindowShell.h:
  48003. (WebCore::JSDOMWindowShell::createStructure):
  48004. * bindings/js/JSImageConstructor.cpp:
  48005. (WebCore::JSImageConstructor::JSImageConstructor):
  48006. * bindings/js/JSImageConstructor.h:
  48007. (WebCore::JSImageConstructor::createStructure):
  48008. * bindings/js/JSImageDataCustom.cpp:
  48009. (WebCore::toJS):
  48010. * bindings/js/JSOptionConstructor.cpp:
  48011. (WebCore::JSOptionConstructor::JSOptionConstructor):
  48012. * bindings/js/JSOptionConstructor.h:
  48013. (WebCore::JSOptionConstructor::createStructure):
  48014. * bindings/js/JSWorkerContextBase.h:
  48015. (WebCore::JSWorkerContextBase::createStructure):
  48016. * bindings/js/WorkerScriptController.cpp:
  48017. (WebCore::WorkerScriptController::initScript):
  48018. * bindings/scripts/CodeGeneratorJS.pm:
  48019. * bridge/c/CRuntimeObject.h:
  48020. (JSC::Bindings::CRuntimeObject::createStructure):
  48021. * bridge/c/c_instance.cpp:
  48022. (JSC::Bindings::CRuntimeMethod::createStructure):
  48023. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  48024. (JavaRuntimeMethod::createStructure):
  48025. * bridge/jni/jsc/JavaRuntimeObject.h:
  48026. (JSC::Bindings::JavaRuntimeObject::createStructure):
  48027. * bridge/objc/ObjCRuntimeObject.h:
  48028. (JSC::Bindings::ObjCRuntimeObject::createStructure):
  48029. * bridge/objc/objc_instance.mm:
  48030. (ObjCRuntimeMethod::createStructure):
  48031. * bridge/objc/objc_runtime.h:
  48032. (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  48033. * bridge/runtime_array.h:
  48034. (JSC::RuntimeArray::createStructure):
  48035. * bridge/runtime_method.h:
  48036. (JSC::RuntimeMethod::createStructure):
  48037. * bridge/runtime_object.h:
  48038. (JSC::Bindings::RuntimeObject::createStructure):
  48039. 2011-03-16 Pratik Solanki <psolanki@apple.com>
  48040. Reviewed by Alexey Proskuryakov.
  48041. REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
  48042. https://bugs.webkit.org/show_bug.cgi?id=56345
  48043. Add NULL check for Content-Type header field.
  48044. Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html
  48045. * platform/network/mac/WebCoreURLResponse.mm:
  48046. (WebCore::adjustMIMETypeIfNecessary):
  48047. 2011-03-15 Levi Weintraub <leviw@chromium.org>
  48048. Reviewed by Ryosuke Niwa.
  48049. REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
  48050. https://bugs.webkit.org/show_bug.cgi?id=56407
  48051. Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
  48052. weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
  48053. have had children appended to them that editing wouldn't normally allow.
  48054. Tests: editing/style/iframe-onload-crash-mac.html
  48055. editing/style/iframe-onload-crash-unix.html
  48056. editing/style/iframe-onload-crash-win.html
  48057. * editing/TextIterator.cpp:
  48058. (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
  48059. * editing/htmlediting.cpp:
  48060. (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children
  48061. for hr and datagrid, as you can append any node to another using javascript.
  48062. 2011-03-16 Mikhail Naganov <mnaganov@chromium.org>
  48063. Reviewed by Pavel Feldman.
  48064. [Chromium] Report object groups and single DOM-related objects
  48065. to the new heap profiler.
  48066. https://bugs.webkit.org/show_bug.cgi?id=53659
  48067. * Android.v8bindings.mk:
  48068. * WebCore.gypi:
  48069. * WebCore.pro:
  48070. * bindings/scripts/CodeGeneratorV8.pm:
  48071. * bindings/v8/RetainedDOMInfo.cpp: Added.
  48072. (WebCore::RetainedDOMInfo::RetainedDOMInfo):
  48073. * bindings/v8/RetainedDOMInfo.h: Added.
  48074. * bindings/v8/RetainedObjectInfo.h: Added.
  48075. * bindings/v8/ScriptProfiler.cpp:
  48076. (WebCore::retainedDOMInfo):
  48077. (WebCore::ScriptProfiler::initialize):
  48078. * bindings/v8/ScriptProfiler.h:
  48079. * bindings/v8/V8DOMWindowShell.cpp:
  48080. (WebCore::V8DOMWindowShell::initContextIfNeeded):
  48081. * bindings/v8/V8GCController.cpp:
  48082. (WebCore::GroupId::GrouperItem::GrouperItem):
  48083. (WebCore::GroupId::GrouperItem::groupId):
  48084. (WebCore::GroupId::GrouperItem::createRetainedObjectInfo):
  48085. (WebCore::calculateGroupId):
  48086. (WebCore::GrouperVisitor::visitDOMWrapper):
  48087. (WebCore::GrouperVisitor::applyGrouping):
  48088. * bindings/v8/WrapperTypeInfo.h:
  48089. * inspector/front-end/DetailedHeapshotGridNodes.js:
  48090. (WebInspector.HeapSnapshotConstructorNode):
  48091. (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  48092. (WebInspector.HeapSnapshotDiffNode):
  48093. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
  48094. (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  48095. * inspector/front-end/DetailedHeapshotView.js:
  48096. (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
  48097. (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
  48098. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
  48099. (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
  48100. (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
  48101. (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot):
  48102. (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
  48103. * inspector/front-end/HeapSnapshot.js:
  48104. (WebInspector.HeapSnapshotNode.prototype.get className):
  48105. (WebInspector.HeapSnapshot.prototype._buildAggregates):
  48106. (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
  48107. (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
  48108. * inspector/front-end/heapProfiler.css:
  48109. (.detailed-heapshot-view .retaining-paths-view .title > span):
  48110. (.detailed-heapshot-view .retaining-paths-to-windows):
  48111. 2011-03-16 Sam Weinig <sam@webkit.org>
  48112. Reviewed by Adam Roben.
  48113. Add WebKit2 API to figure out if an input or textarea was edited
  48114. https://bugs.webkit.org/show_bug.cgi?id=56474
  48115. Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
  48116. and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
  48117. as well as API in WebKit2.
  48118. * WebCore.exp.in:
  48119. * bindings/objc/DOMHTML.mm:
  48120. (-[DOMHTMLInputElement _isEdited]):
  48121. (-[DOMHTMLTextAreaElement _isEdited]):
  48122. * html/HTMLInputElement.cpp:
  48123. (WebCore::HTMLInputElement::lastChangeWasUserEdit):
  48124. * html/HTMLInputElement.h:
  48125. * html/HTMLTextAreaElement.cpp:
  48126. (WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):
  48127. * html/HTMLTextAreaElement.h:
  48128. 2011-03-15 Pavel Feldman <pfeldman@chromium.org>
  48129. Reviewed by Yury Semikhatsky.
  48130. Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
  48131. https://bugs.webkit.org/show_bug.cgi?id=56376
  48132. * inspector/InspectorBrowserDebuggerAgent.cpp:
  48133. (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
  48134. * inspector/front-end/DOMAgent.js:
  48135. (WebInspector.DOMAgent.prototype._setDocument):
  48136. 2011-03-16 Dan Bernstein <mitz@apple.com>
  48137. Reviewed by Simon Fraser.
  48138. text-combine text retains compressed font after adding characters to it
  48139. https://bugs.webkit.org/show_bug.cgi?id=56448
  48140. Test: fast/dynamic/text-combine.html
  48141. * css/CSSStyleSelector.cpp:
  48142. (WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
  48143. only the clones on the RenderCombineText will be mutated.
  48144. * rendering/RenderCombineText.cpp:
  48145. (WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
  48146. style.
  48147. (WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
  48148. the text cannot be combined.
  48149. * rendering/RenderCombineText.h:
  48150. (WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.
  48151. 2011-03-14 Pavel Podivilov <podivilov@chromium.org>
  48152. Reviewed by Yury Semikhatsky.
  48153. Web Inspector: refactor event listener breakpoints.
  48154. https://bugs.webkit.org/show_bug.cgi?id=56305
  48155. - restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  48156. - store event listener breakpoints in a separate separate setting
  48157. - move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
  48158. Test: inspector/debugger/event-listener-breakpoints.html
  48159. * inspector/Inspector.idl:
  48160. * inspector/InspectorAgent.cpp:
  48161. (WebCore::InspectorAgent::setFrontend):
  48162. * inspector/InspectorBrowserDebuggerAgent.cpp:
  48163. (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
  48164. (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
  48165. (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
  48166. (WebCore::InspectorBrowserDebuggerAgent::clear):
  48167. * inspector/InspectorBrowserDebuggerAgent.h:
  48168. * inspector/InspectorInstrumentation.cpp:
  48169. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  48170. * inspector/front-end/BreakpointManager.js:
  48171. (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
  48172. (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
  48173. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  48174. (WebInspector.BreakpointManager.prototype._projectChanged):
  48175. (WebInspector.BreakpointManager.prototype._saveBreakpoints):
  48176. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  48177. (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  48178. * inspector/front-end/BreakpointsSidebarPane.js:
  48179. (WebInspector.EventListenerBreakpointsSidebarPane):
  48180. (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
  48181. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  48182. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
  48183. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
  48184. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
  48185. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  48186. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
  48187. (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
  48188. (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  48189. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
  48190. (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  48191. * inspector/front-end/CallStackSidebarPane.js:
  48192. (WebInspector.CallStackSidebarPane.prototype.update):
  48193. (WebInspector.CallStackSidebarPane.prototype.setStatus):
  48194. (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  48195. * inspector/front-end/ScriptsPanel.js:
  48196. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  48197. (WebInspector.ScriptsPanel.prototype._clearInterface):
  48198. * inspector/front-end/Settings.js:
  48199. (WebInspector.Settings):
  48200. 2011-03-16 David Kilzer <ddkilzer@apple.com>
  48201. Minor clean-up after r81156, r81172
  48202. Follow-up for:
  48203. <http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
  48204. * platform/graphics/GraphicsLayer.h: Removed unused @class
  48205. WebLayer declaration.
  48206. * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
  48207. struct CAPropertyAnimation to class declaration.
  48208. 2011-03-16 Andrey Adaikin <aandrey@google.com>
  48209. Reviewed by Yury Semikhatsky.
  48210. Web Inspector: Remove live-edit code
  48211. https://bugs.webkit.org/show_bug.cgi?id=56177
  48212. * inspector/front-end/Settings.js:
  48213. * inspector/front-end/SourceFrame.js:
  48214. (WebInspector.SourceFrame):
  48215. (WebInspector.SourceFrame.prototype._doubleClick):
  48216. * inspector/front-end/TextViewer.js:
  48217. (WebInspector.TextEditorMainPanel):
  48218. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  48219. 2011-03-16 Alexis Menard <alexis.menard@openbossa.org>
  48220. Reviewed by Martin Robinson.
  48221. [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
  48222. https://bugs.webkit.org/show_bug.cgi?id=56403
  48223. In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
  48224. As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
  48225. i.e the pause() made when beginScrubbing is done is just internal.
  48226. No new tests: Verified manually.
  48227. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  48228. (WebCore::MediaPlayerPrivateGStreamer::updateStates):
  48229. 2011-03-16 Adam Barth <abarth@webkit.org>
  48230. Reviewed by Eric Seidel.
  48231. WebCore GYP build should build platform/
  48232. https://bugs.webkit.org/show_bug.cgi?id=56430
  48233. Adding platform/ to the GYP build required disabling
  48234. ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent
  48235. style issues. I suspect we'll end up excluding some of these files
  48236. from the build in the final analysis, but we might as well fix the
  48237. style errors while we're here.
  48238. * bindings/js/JSMainThreadExecState.h:
  48239. * bindings/js/ScheduledAction.h:
  48240. * css/CSSPrimitiveValueCache.cpp:
  48241. * gyp/WebCore.gyp:
  48242. * platform/KillRingNone.cpp:
  48243. (WebCore::KillRing::append):
  48244. (WebCore::KillRing::prepend):
  48245. * platform/graphics/ContextShadow.h:
  48246. * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
  48247. (WebCore::LoopBlinnPathProcessor::buildContours):
  48248. (WebCore::TessellationState::combineCallback):
  48249. * platform/graphics/gpu/PODRedBlackTree.h:
  48250. (WebCore::PODRedBlackTree::updateNode):
  48251. (WebCore::PODRedBlackTree::logIfVerbose):
  48252. * platform/graphics/opengl/TextureMapperGL.cpp:
  48253. * platform/graphics/opengl/TextureMapperGL.h:
  48254. * platform/graphics/texmap/TextureMapper.h:
  48255. (WebCore::BitmapTexture::save):
  48256. (WebCore::TextureMapper::paintToTarget):
  48257. * platform/graphics/texmap/TextureMapperNode.h:
  48258. 2011-03-15 Philippe Normand <pnormand@igalia.com>
  48259. Reviewed by Eric Carlson.
  48260. [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
  48261. https://bugs.webkit.org/show_bug.cgi?id=56370
  48262. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  48263. (WebCore::mediaPlayerPrivateMessageCallback): Let the
  48264. mediaPlayerClient handle the stream error, in this case the
  48265. HTMLMediaElement will emit a stalled event.
  48266. 2011-03-10 Philippe Normand <pnormand@igalia.com>
  48267. Reviewed by Martin Robinson.
  48268. [GStreamer] Frame accurate seeking isn't always accurate
  48269. https://bugs.webkit.org/show_bug.cgi?id=55217
  48270. Attempt to build the seek GstClockTime position by converting the
  48271. float time value to a GTimeVal value rounded at microsecond
  48272. precision. Additionally perform the seek with the ACCURATE seek
  48273. flag. These modifications at least fix this manual-test:
  48274. http://www.massive-interactive.nl/html5_video/smpte_test_universal.html
  48275. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  48276. (WebCore::MediaPlayerPrivateGStreamer::currentTime):
  48277. (WebCore::MediaPlayerPrivateGStreamer::seek):
  48278. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  48279. 2011-03-15 Yury Semikhatsky <yurys@chromium.org>
  48280. Reviewed by Pavel Feldman.
  48281. Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests
  48282. https://bugs.webkit.org/show_bug.cgi?id=56389
  48283. Instead of sending one big request populateScriptObjects each agent requests
  48284. for initial data in its constructor.
  48285. * inspector/Inspector.idl:
  48286. * inspector/InspectorAgent.cpp:
  48287. (WebCore::InspectorAgent::InspectorAgent):
  48288. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  48289. (WebCore::InspectorAgent::setFrontend):
  48290. (WebCore::InspectorAgent::pushDataCollectedOffline):
  48291. (WebCore::InspectorAgent::getPreferredPanel):
  48292. * inspector/InspectorAgent.h:
  48293. * inspector/InspectorDOMAgent.cpp:
  48294. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  48295. (WebCore::InspectorDOMAgent::setFrontend):
  48296. (WebCore::InspectorDOMAgent::restore):
  48297. * inspector/InspectorDOMAgent.h:
  48298. (WebCore::InspectorDOMAgent::create):
  48299. * inspector/InspectorDebuggerAgent.cpp:
  48300. (WebCore::InspectorDebuggerAgent::setFrontend):
  48301. * inspector/InspectorDebuggerAgent.h:
  48302. * inspector/InspectorProfilerAgent.h:
  48303. (WebCore::InspectorProfilerAgent::isEnabled):
  48304. * inspector/front-end/ProfilesPanel.js:
  48305. (WebInspector.ProfilesPanel):
  48306. * inspector/front-end/ScriptsPanel.js:
  48307. (WebInspector.ScriptsPanel):
  48308. * inspector/front-end/inspector.js:
  48309. 2011-03-15 Ryosuke Niwa <rniwa@webkit.org>
  48310. Reviewed by Darin Adler.
  48311. Devirtualize isContentEditable and isRichlyContentEditable
  48312. https://bugs.webkit.org/show_bug.cgi?id=56421
  48313. Rewrote Node::isContentEditable as a non-recursive non-virtual function.
  48314. * dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable.
  48315. * dom/Document.h: Ditto.
  48316. * dom/Node.cpp:
  48317. (WebCore::Node::isContentEditable): Rewritten.
  48318. * dom/Node.h:
  48319. (WebCore::Node::isContentEditable): Calls isContentEditable(Editable).
  48320. (WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable).
  48321. * html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable.
  48322. * html/HTMLElement.h: Ditto.
  48323. 2011-03-15 Adam Barth <abarth@webkit.org>
  48324. Reviewed by Eric Seidel.
  48325. WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/
  48326. https://bugs.webkit.org/show_bug.cgi?id=56412
  48327. Yay for smooth sailing.
  48328. * gyp/WebCore.gyp:
  48329. 2011-03-15 Dimitri Glazkov <dglazkov@chromium.org>
  48330. Reviewed by Kent Tamura.
  48331. REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
  48332. https://bugs.webkit.org/show_bug.cgi?id=56059
  48333. Test: fast/dom/HTMLInputElement/input-slider-update-styled.html
  48334. * html/RangeInputType.cpp:
  48335. (WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue.
  48336. * html/shadow/SliderThumbElement.cpp:
  48337. (WebCore::SliderThumbElement::setPositionFromValue): Added.
  48338. (WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint.
  48339. (WebCore::SliderThumbElement::setPositionFromPoint): Ditto.
  48340. (WebCore::SliderThumbElement::defaultEventHandler): Ditto.
  48341. * html/shadow/SliderThumbElement.h: Added decls.
  48342. 2011-03-15 David Levin <levin@chromium.org>
  48343. Attempted build fix following r81213. Same song second verse.
  48344. * platform/image-encoders/skia/PNGImageEncoder.cpp:
  48345. (WebCore::encodePixels):
  48346. 2011-03-15 David Levin <levin@chromium.org>
  48347. Attempted build fix for Chromium OSX release build following r81213.
  48348. * platform/image-encoders/skia/JPEGImageEncoder.cpp:
  48349. (WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call.
  48350. 2011-03-15 John Bauman <jbauman@chromium.org>
  48351. Reviewed by Kenneth Russell.
  48352. Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
  48353. https://bugs.webkit.org/show_bug.cgi?id=56238
  48354. Attempt to get an ImageData (non-premultiplied) from a WebGL canvas
  48355. instead of getting an ImageBuffer, so there's a chance the data can be
  48356. passed straight through to the consumer with no premultiplication
  48357. necessary. Fixes Chromium and Safari.
  48358. Test: fast/canvas/webgl/premultiplyalpha-test.html
  48359. * html/HTMLCanvasElement.cpp:
  48360. (WebCore::HTMLCanvasElement::toDataURL):
  48361. (WebCore::HTMLCanvasElement::getImageData):
  48362. * html/HTMLCanvasElement.h:
  48363. * html/canvas/WebGLRenderingContext.cpp:
  48364. (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
  48365. (WebCore::WebGLRenderingContext::texImage2D):
  48366. (WebCore::WebGLRenderingContext::texSubImage2D):
  48367. * html/canvas/WebGLRenderingContext.h:
  48368. * platform/graphics/GraphicsContext3D.h:
  48369. * platform/graphics/ImageBuffer.h:
  48370. * platform/graphics/cg/ImageBufferCG.cpp:
  48371. (WebCore::CGImageToDataURL):
  48372. (WebCore::ImageBuffer::toDataURL):
  48373. (WebCore::ImageDataToDataURL):
  48374. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  48375. (WebCore::GraphicsContext3D::validateAttributes):
  48376. (WebCore::GraphicsContext3D::readRenderingResults):
  48377. (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
  48378. (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  48379. * platform/graphics/qt/GraphicsContext3DQt.cpp:
  48380. (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  48381. * platform/graphics/skia/ImageBufferSkia.cpp:
  48382. (WebCore::ImageToDataURL):
  48383. (WebCore::ImageBuffer::toDataURL):
  48384. (WebCore::ImageDataToDataURL):
  48385. * platform/image-encoders/skia/JPEGImageEncoder.cpp:
  48386. (WebCore::preMultipliedBGRAtoRGB):
  48387. (WebCore::RGBAtoRGB):
  48388. (WebCore::encodePixels):
  48389. (WebCore::JPEGImageEncoder::encode):
  48390. * platform/image-encoders/skia/JPEGImageEncoder.h:
  48391. * platform/image-encoders/skia/PNGImageEncoder.cpp:
  48392. (WebCore::preMultipliedBGRAtoRGBA):
  48393. (WebCore::encodePixels):
  48394. (WebCore::PNGImageEncoder::encode):
  48395. * platform/image-encoders/skia/PNGImageEncoder.h:
  48396. 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
  48397. [wx] Build fix, only compile the methods when the INDEXED_DATABASE feature is enabled.
  48398. * storage/IDBDatabaseCallbacksImpl.cpp:
  48399. 2011-03-15 Brady Eidson <beidson@apple.com>
  48400. Build fix after r81208 for https://bugs.webkit.org/show_bug.cgi?id=56425
  48401. * loader/icon/IconDatabaseBase.h: #include instead of forward declare.
  48402. 2011-03-15 Beth Dakin <bdakin@apple.com>
  48403. Reviewed by Darin Adler.
  48404. Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
  48405. send notifications appropriate times (showing up, resizing)
  48406. -and corresponding-
  48407. https://bugs.webkit.org/show_bug.cgi?id=56067
  48408. The general strategy here is to add a HashSet of ScrollableAreas to the page that
  48409. can be accessed when necessary to send notifications to all ScrollableAreas. In
  48410. turn, all of the ScrollableArea classes that add themselves to the HashSet must
  48411. keep a weak pointer to Page so that they can remove themselves without relying on
  48412. Frames or Renderers to still have references.
  48413. Find layers for relevant node and if the layers are in the Page's ScrollableArea
  48414. set, then send the relevant notification.
  48415. * page/EventHandler.cpp:
  48416. (WebCore::layerForNode):
  48417. (WebCore::EventHandler::mouseMoved):
  48418. (WebCore::EventHandler::updateMouseEventTargetNode):
  48419. When the page is set active or not active, iterate through the Page's
  48420. ScrollableAreas to send hide/show notifications.
  48421. * page/FocusController.cpp:
  48422. (WebCore::FocusController::setActive):
  48423. When a FrameView is created, add it to the ScrollableArea set. When it's
  48424. destroyed, remove it.
  48425. * page/FrameView.cpp:
  48426. (WebCore::FrameView::FrameView):
  48427. (WebCore::FrameView::~FrameView):
  48428. Iterate through the Page's ScrollableAreas to send the paint notification.
  48429. (WebCore::FrameView::notifyPageThatContentAreaWillPaint):
  48430. * page/FrameView.h:
  48431. (WebCore::FrameView::disconnectFromPage):
  48432. Add the new ScrollableArea set.
  48433. * page/Page.cpp:
  48434. (WebCore::Page::~Page):
  48435. (WebCore::Page::addScrollableArea):
  48436. (WebCore::Page::removeScrollableArea):
  48437. (WebCore::Page::containsScrollableArea):
  48438. * page/Page.h:
  48439. (WebCore::Page::scrollableAreaSet):
  48440. notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
  48441. * platform/ScrollView.cpp:
  48442. (WebCore::ScrollView::notifyPageThatContentAreaWillPaint):
  48443. Call notifyPageThatContentAreaWillPaint() instead of calling
  48444. contentAreaWillPaint() just for the ScrollView.
  48445. (WebCore::ScrollView::paint):
  48446. * platform/ScrollView.h:
  48447. Add/remove ScrollableAreas to the set. Add new disconnectFromPage().
  48448. * platform/ScrollableArea.h:
  48449. (WebCore::ScrollableArea::disconnectFromPage):
  48450. * rendering/RenderDataGrid.cpp:
  48451. (WebCore::RenderDataGrid::RenderDataGrid):
  48452. (WebCore::RenderDataGrid::~RenderDataGrid):
  48453. * rendering/RenderDataGrid.h:
  48454. (WebCore::RenderDataGrid::disconnectFromPage):
  48455. * rendering/RenderLayer.cpp:
  48456. (WebCore::RenderLayer::RenderLayer):
  48457. (WebCore::RenderLayer::~RenderLayer):
  48458. * rendering/RenderLayer.h:
  48459. (WebCore::RenderLayer::disconnectFromPage):
  48460. * rendering/RenderListBox.cpp:
  48461. (WebCore::RenderListBox::RenderListBox):
  48462. (WebCore::RenderListBox::~RenderListBox):
  48463. * rendering/RenderListBox.h:
  48464. (WebCore::RenderListBox::disconnectFromPage):
  48465. Should have implemented this ScrollableArea-interface function a while ago.
  48466. (WebCore::RenderLayer::currentMousePosition):
  48467. 2011-03-15 Brady Eidson <beidson@apple.com>
  48468. Reviewed by Sam Weinig.
  48469. https://bugs.webkit.org/show_bug.cgi?id=56425
  48470. WebKit2 icon database.
  48471. * WebCore.exp.in:
  48472. 2011-03-15 Adam Barth <abarth@webkit.org>
  48473. Reviewed by Dimitri Glazkov.
  48474. WebCore GYP build should build editing, fileapi, history, and html
  48475. https://bugs.webkit.org/show_bug.cgi?id=56411
  48476. These all went smoothly.
  48477. * gyp/WebCore.gyp:
  48478. 2011-03-15 Adam Barth <abarth@webkit.org>
  48479. Reviewed by Eric Seidel.
  48480. WebCore GYP build should build dom/
  48481. https://bugs.webkit.org/show_bug.cgi?id=56409
  48482. * gyp/WebCore.gyp:
  48483. 2011-03-15 Adam Barth <abarth@webkit.org>
  48484. Reviewed by Eric Seidel.
  48485. WebCore GYP build should build css/
  48486. https://bugs.webkit.org/show_bug.cgi?id=56408
  48487. CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the
  48488. build yet. I've punted on that problem for now, but we'll come back to
  48489. it.
  48490. * gyp/WebCore.gyp:
  48491. 2011-03-15 Adam Barth <abarth@webkit.org>
  48492. Reviewed by Dimitri Glazkov.
  48493. WebCore GYP build should build bindings/
  48494. https://bugs.webkit.org/show_bug.cgi?id=56406
  48495. I wanted to include bindings/objc in this patch, but they were somewhat
  48496. complicated. It looks like they include headers from the output
  48497. directory (via PrivateHeaders), but we haven't wired up the
  48498. PrivateHeaders yet.
  48499. * gyp/WebCore.gyp:
  48500. 2011-03-15 James Simonsen <simonjam@chromium.org>
  48501. Reviewed by Tony Gentilcore.
  48502. Need different behavior for ensuring execution order of dynamically loaded scripts
  48503. https://bugs.webkit.org/show_bug.cgi?id=50115
  48504. Dynamically added scripts with async=false will load in parallel, but execute in order.
  48505. See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async
  48506. Tests: fast/dom/HTMLScriptElement/script-async-attr.html
  48507. http/tests/misc/script-async-load-execute-in-order.html
  48508. * Android.mk: Rename AsyncScriptRunner -> ScriptRunner.
  48509. * CMakeLists.txt: Ditto.
  48510. * GNUmakefile.am: Ditto.
  48511. * WebCore.gypi: Ditto.
  48512. * WebCore.pro: Ditto.
  48513. * WebCore.vcproj/WebCore.vcproj: Ditto.
  48514. * WebCore.xcodeproj/project.pbxproj: Ditto.
  48515. * dom/DOMAllInOne.cpp: Ditto.
  48516. * dom/Document.cpp:
  48517. (WebCore::Document::Document): Ditto.
  48518. (WebCore::Document::~Document): Ditto.
  48519. * dom/Document.h:
  48520. (WebCore::Document::scriptRunner): Ditto.
  48521. * dom/ScriptElement.cpp:
  48522. (WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder.
  48523. (WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes.
  48524. (WebCore::ScriptElement::prepareScript): Added support for forceAsync.
  48525. (WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed.
  48526. * dom/ScriptElement.h:
  48527. (WebCore::ScriptElement::forceAsync): Added.
  48528. * dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp.
  48529. (WebCore::ScriptRunner::ScriptRunner): Added in-order script queue.
  48530. (WebCore::ScriptRunner::~ScriptRunner): Ditto.
  48531. (WebCore::ScriptRunner::executeScriptSoon):
  48532. (WebCore::ScriptRunner::queueScriptForInOrderExecution): Added.
  48533. (WebCore::ScriptRunner::suspend):
  48534. (WebCore::ScriptRunner::resume):
  48535. (WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready.
  48536. * dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h.
  48537. (WebCore::ScriptRunner::create):
  48538. (WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too.
  48539. * html/HTMLScriptElement.cpp:
  48540. (WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes.
  48541. (WebCore::HTMLScriptElement::setAsync): Ditto.
  48542. (WebCore::HTMLScriptElement::async): Include forceAsync in calculation.
  48543. * html/HTMLScriptElement.h:
  48544. * html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior.
  48545. * page/PageGroupLoadDeferrer.cpp:
  48546. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner.
  48547. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto.
  48548. 2011-03-15 Tony Chang <tony@chromium.org>
  48549. Reviewed by Adam Barth.
  48550. pngcrush images used by inspector
  48551. https://bugs.webkit.org/show_bug.cgi?id=56426
  48552. This saves 120k in WebCore and 8k in WebKit/chromium. I ran
  48553. pngcrush -brute, so none of the meta data (ancillary chunks)
  48554. are modified.
  48555. No new tests, just compressing png files.
  48556. * inspector/front-end/Images/applicationCache.png:
  48557. * inspector/front-end/Images/auditsIcon.png:
  48558. * inspector/front-end/Images/back.png:
  48559. * inspector/front-end/Images/breakpointBorder.png:
  48560. * inspector/front-end/Images/breakpointConditionalBorder.png:
  48561. * inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  48562. * inspector/front-end/Images/breakpointCounterBorder.png:
  48563. * inspector/front-end/Images/breakpointsActivateButtonGlyph.png:
  48564. * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png:
  48565. * inspector/front-end/Images/checker.png:
  48566. * inspector/front-end/Images/clearConsoleButtonGlyph.png:
  48567. * inspector/front-end/Images/closeButtons.png:
  48568. * inspector/front-end/Images/consoleButtonGlyph.png:
  48569. * inspector/front-end/Images/consoleIcon.png:
  48570. * inspector/front-end/Images/cookie.png:
  48571. * inspector/front-end/Images/database.png:
  48572. * inspector/front-end/Images/databaseTable.png:
  48573. * inspector/front-end/Images/debuggerContinue.png:
  48574. * inspector/front-end/Images/debuggerPause.png:
  48575. * inspector/front-end/Images/debuggerStepInto.png:
  48576. * inspector/front-end/Images/debuggerStepOut.png:
  48577. * inspector/front-end/Images/debuggerStepOver.png:
  48578. * inspector/front-end/Images/disclosureTriangleSmallDown.png:
  48579. * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png:
  48580. * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png:
  48581. * inspector/front-end/Images/disclosureTriangleSmallRight.png:
  48582. * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png:
  48583. * inspector/front-end/Images/disclosureTriangleSmallRightDown.png:
  48584. * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png:
  48585. * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png:
  48586. * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png:
  48587. * inspector/front-end/Images/dockButtonGlyph.png:
  48588. * inspector/front-end/Images/elementsIcon.png:
  48589. * inspector/front-end/Images/enableOutlineButtonGlyph.png:
  48590. * inspector/front-end/Images/enableSolidButtonGlyph.png:
  48591. * inspector/front-end/Images/errorIcon.png:
  48592. * inspector/front-end/Images/errorMediumIcon.png:
  48593. * inspector/front-end/Images/errorRedDot.png:
  48594. * inspector/front-end/Images/excludeButtonGlyph.png:
  48595. * inspector/front-end/Images/focusButtonGlyph.png:
  48596. * inspector/front-end/Images/forward.png:
  48597. * inspector/front-end/Images/frame.png:
  48598. * inspector/front-end/Images/garbageCollectButtonGlyph.png:
  48599. * inspector/front-end/Images/gearButtonGlyph.png:
  48600. * inspector/front-end/Images/glossyHeader.png:
  48601. * inspector/front-end/Images/glossyHeaderPressed.png:
  48602. * inspector/front-end/Images/glossyHeaderSelected.png:
  48603. * inspector/front-end/Images/glossyHeaderSelectedPressed.png:
  48604. * inspector/front-end/Images/goArrow.png:
  48605. * inspector/front-end/Images/graphLabelCalloutLeft.png:
  48606. * inspector/front-end/Images/graphLabelCalloutRight.png:
  48607. * inspector/front-end/Images/helpButtonGlyph.png:
  48608. * inspector/front-end/Images/largerResourcesButtonGlyph.png:
  48609. * inspector/front-end/Images/localStorage.png:
  48610. * inspector/front-end/Images/networkIcon.png:
  48611. * inspector/front-end/Images/nodeSearchButtonGlyph.png:
  48612. * inspector/front-end/Images/paneAddButtons.png:
  48613. * inspector/front-end/Images/paneBottomGrow.png:
  48614. * inspector/front-end/Images/paneBottomGrowActive.png:
  48615. * inspector/front-end/Images/paneGrowHandleLine.png:
  48616. * inspector/front-end/Images/paneSettingsButtons.png:
  48617. * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png:
  48618. * inspector/front-end/Images/percentButtonGlyph.png:
  48619. * inspector/front-end/Images/popoverArrows.png:
  48620. * inspector/front-end/Images/popoverBackground.png:
  48621. * inspector/front-end/Images/profileGroupIcon.png:
  48622. * inspector/front-end/Images/profileIcon.png:
  48623. * inspector/front-end/Images/profileSmallIcon.png:
  48624. * inspector/front-end/Images/profilesIcon.png:
  48625. * inspector/front-end/Images/profilesSilhouette.png:
  48626. * inspector/front-end/Images/programCounterBorder.png:
  48627. * inspector/front-end/Images/radioDot.png:
  48628. * inspector/front-end/Images/recordButtonGlyph.png:
  48629. * inspector/front-end/Images/recordToggledButtonGlyph.png:
  48630. * inspector/front-end/Images/reloadButtonGlyph.png:
  48631. * inspector/front-end/Images/resourceCSSIcon.png:
  48632. * inspector/front-end/Images/resourceDocumentIcon.png:
  48633. * inspector/front-end/Images/resourceDocumentIconSmall.png:
  48634. * inspector/front-end/Images/resourceJSIcon.png:
  48635. * inspector/front-end/Images/resourcePlainIcon.png:
  48636. * inspector/front-end/Images/resourcePlainIconSmall.png:
  48637. * inspector/front-end/Images/resourcesIcon.png:
  48638. * inspector/front-end/Images/resourcesSizeGraphIcon.png:
  48639. * inspector/front-end/Images/resourcesTimeGraphIcon.png:
  48640. * inspector/front-end/Images/scriptsIcon.png:
  48641. * inspector/front-end/Images/scriptsSilhouette.png:
  48642. * inspector/front-end/Images/searchSmallBlue.png:
  48643. * inspector/front-end/Images/searchSmallBrightBlue.png:
  48644. * inspector/front-end/Images/searchSmallGray.png:
  48645. * inspector/front-end/Images/searchSmallWhite.png:
  48646. * inspector/front-end/Images/segment.png:
  48647. * inspector/front-end/Images/segmentEnd.png:
  48648. * inspector/front-end/Images/segmentHover.png:
  48649. * inspector/front-end/Images/segmentHoverEnd.png:
  48650. * inspector/front-end/Images/segmentSelected.png:
  48651. * inspector/front-end/Images/segmentSelectedEnd.png:
  48652. * inspector/front-end/Images/sessionStorage.png:
  48653. * inspector/front-end/Images/splitviewDimple.png:
  48654. * inspector/front-end/Images/splitviewDividerBackground.png:
  48655. * inspector/front-end/Images/statusbarButtons.png:
  48656. * inspector/front-end/Images/statusbarMenuButton.png:
  48657. * inspector/front-end/Images/statusbarMenuButtonSelected.png:
  48658. * inspector/front-end/Images/statusbarResizerHorizontal.png:
  48659. * inspector/front-end/Images/statusbarResizerVertical.png:
  48660. * inspector/front-end/Images/successGreenDot.png:
  48661. * inspector/front-end/Images/thumbActiveHoriz.png:
  48662. * inspector/front-end/Images/thumbActiveVert.png:
  48663. * inspector/front-end/Images/thumbHoriz.png:
  48664. * inspector/front-end/Images/thumbHoverHoriz.png:
  48665. * inspector/front-end/Images/thumbHoverVert.png:
  48666. * inspector/front-end/Images/thumbVert.png:
  48667. * inspector/front-end/Images/timelineBarBlue.png:
  48668. * inspector/front-end/Images/timelineBarGray.png:
  48669. * inspector/front-end/Images/timelineBarGreen.png:
  48670. * inspector/front-end/Images/timelineBarOrange.png:
  48671. * inspector/front-end/Images/timelineBarPurple.png:
  48672. * inspector/front-end/Images/timelineBarRed.png:
  48673. * inspector/front-end/Images/timelineBarYellow.png:
  48674. * inspector/front-end/Images/timelineCheckmarks.png:
  48675. * inspector/front-end/Images/timelineDots.png:
  48676. * inspector/front-end/Images/timelineHollowPillBlue.png:
  48677. * inspector/front-end/Images/timelineHollowPillGray.png:
  48678. * inspector/front-end/Images/timelineHollowPillGreen.png:
  48679. * inspector/front-end/Images/timelineHollowPillOrange.png:
  48680. * inspector/front-end/Images/timelineHollowPillPurple.png:
  48681. * inspector/front-end/Images/timelineHollowPillRed.png:
  48682. * inspector/front-end/Images/timelineHollowPillYellow.png:
  48683. * inspector/front-end/Images/timelineIcon.png:
  48684. * inspector/front-end/Images/timelinePillBlue.png:
  48685. * inspector/front-end/Images/timelinePillGray.png:
  48686. * inspector/front-end/Images/timelinePillGreen.png:
  48687. * inspector/front-end/Images/timelinePillOrange.png:
  48688. * inspector/front-end/Images/timelinePillPurple.png:
  48689. * inspector/front-end/Images/timelinePillRed.png:
  48690. * inspector/front-end/Images/timelinePillYellow.png:
  48691. * inspector/front-end/Images/toolbarItemSelected.png:
  48692. * inspector/front-end/Images/trackHoriz.png:
  48693. * inspector/front-end/Images/trackVert.png:
  48694. * inspector/front-end/Images/treeDownTriangleBlack.png:
  48695. * inspector/front-end/Images/treeDownTriangleWhite.png:
  48696. * inspector/front-end/Images/treeRightTriangleBlack.png:
  48697. * inspector/front-end/Images/treeRightTriangleWhite.png:
  48698. * inspector/front-end/Images/treeUpTriangleBlack.png:
  48699. * inspector/front-end/Images/treeUpTriangleWhite.png:
  48700. * inspector/front-end/Images/undockButtonGlyph.png:
  48701. * inspector/front-end/Images/userInputIcon.png:
  48702. * inspector/front-end/Images/userInputPreviousIcon.png:
  48703. * inspector/front-end/Images/userInputResultIcon.png:
  48704. * inspector/front-end/Images/warningIcon.png:
  48705. * inspector/front-end/Images/warningMediumIcon.png:
  48706. * inspector/front-end/Images/warningOrangeDot.png:
  48707. * inspector/front-end/Images/warningsErrors.png:
  48708. 2011-03-15 Ryosuke Niwa <rniwa@webkit.org>
  48709. Reviewed by Tony Chang.
  48710. Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
  48711. https://bugs.webkit.org/show_bug.cgi?id=56372
  48712. The bug was caused by insertNodeAfter's calling parentElement on document's child.
  48713. Fixed this by changing the node that AppendNodeCommand takes.
  48714. There was also a bug that document node always returned false for isContentEditable
  48715. and isContentRichlyEditable because they never overrode Node's default implementation.
  48716. Fixed this by overriding them in Document.
  48717. Test: editing/execCommand/append-node-under-document.html
  48718. * dom/Document.cpp:
  48719. (WebCore::Document::isContentEditable): Added.
  48720. (WebCore::Document::isContentRichlyEditable): Added.
  48721. * dom/Document.h:
  48722. * editing/AppendNodeCommand.cpp:
  48723. (WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
  48724. * editing/AppendNodeCommand.h:
  48725. (WebCore::AppendNodeCommand::create): Ditto.
  48726. * editing/CompositeEditCommand.cpp:
  48727. (WebCore::CompositeEditCommand::appendNode): Ditto.
  48728. (WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
  48729. * editing/CompositeEditCommand.h:
  48730. 2011-03-15 David Grogan <dgrogan@chromium.org>
  48731. Reviewed by Jeremy Orlow.
  48732. Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
  48733. https://bugs.webkit.org/show_bug.cgi?id=56350
  48734. When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
  48735. calls stop() on each ActiveDOMObject.
  48736. Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:
  48737. * IDBDatabase::stop() causes the chrome message dispatcher to remove
  48738. its reference to IDBDatabase, which it has as type
  48739. IDBDatabaseCallbacks.
  48740. * If that reference is the last one, the IDBDatabase is destroyed.
  48741. * Destroying an ActiveDOMObject while they are being iterated over causes
  48742. a defensive crash.
  48743. This change creates a separate IDBDatabaseCallbacks object that is not
  48744. an ActiveDOMObject, so it can be destroyed by
  48745. ScriptExecutionContext::stopActiveDOMObjects.
  48746. Because the chrome message dispatcher is only used in multi-process
  48747. chromium, that's the only platform affected. Chromium browser tests
  48748. forthcoming.
  48749. * WebCore.gypi:
  48750. * storage/IDBDatabase.cpp:
  48751. (WebCore::IDBDatabase::IDBDatabase):
  48752. (WebCore::IDBDatabase::~IDBDatabase):
  48753. (WebCore::IDBDatabase::setVersion):
  48754. (WebCore::IDBDatabase::close):
  48755. (WebCore::IDBDatabase::open):
  48756. * storage/IDBDatabase.h:
  48757. * storage/IDBDatabaseCallbacks.h:
  48758. (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  48759. * storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
  48760. (WebCore::IDBDatabaseCallbacksImpl::create):
  48761. (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
  48762. (WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
  48763. (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  48764. * storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
  48765. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
  48766. 2011-03-15 Adam Barth <abarth@webkit.org>
  48767. Reviewed by Dimitri Glazkov.
  48768. accessibility should build in WebCore GYP build
  48769. https://bugs.webkit.org/show_bug.cgi?id=56405
  48770. This patch changes our include/exclude strategy to more closely match
  48771. the strategy used by the Chromium GYP build system. Ideally, we'd find
  48772. a way to share more of these patterns. In the meantime, I'm going to
  48773. slowly increase the number of translation units in the project and
  48774. adjust the include/exclude filters appropriately.
  48775. * gyp/WebCore.gyp:
  48776. 2011-03-15 Alexey Proskuryakov <ap@apple.com>
  48777. Reviewed by Darin Adler.
  48778. REGRESSION (WebKit2): keygen element doesn't work
  48779. https://bugs.webkit.org/show_bug.cgi?id=56402
  48780. <rdar://problem/9006545>
  48781. Covered by existing regresison tests.
  48782. * English.lproj/Localizable.strings:
  48783. * WebCore.exp.in: Removed WebCoreKeyGenerator, which no longer exists. Added
  48784. _wkSignedPublicKeyAndChallengeString, so that this WKSI function could be used in WebCore.
  48785. * platform/mac/SSLKeyGeneratorMac.mm: Removed.
  48786. * platform/mac/WebCoreKeyGenerator.h: Removed.
  48787. * platform/mac/WebCoreKeyGenerator.m: Removed.
  48788. * platform/mac/WebCoreSystemInterface.h:
  48789. * platform/mac/WebCoreSystemInterface.mm:
  48790. * WebCore.xcodeproj/project.pbxproj:
  48791. Renamed SSLKeyGeneratorMac.mm to .cpp, as it doesn't use any Objective C any more.
  48792. Removed WebCoreKeyGenerator, as we no longer need an interface to WebKit.
  48793. * platform/LocalizationStrategy.h:
  48794. * platform/LocalizedStrings.cpp:
  48795. (WebCore::keygenMenuItem512):
  48796. (WebCore::keygenMenuItem1024):
  48797. (WebCore::keygenMenuItem2048):
  48798. (WebCore::keygenKeychainItemName):
  48799. * platform/LocalizedStrings.h:
  48800. Added strings used by keygen element, now that the code using them is in WebCore.
  48801. * platform/mac/SSLKeyGeneratorMac.cpp: Copied from Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm.
  48802. (WebCore::getSupportedKeySizes):
  48803. (WebCore::signedPublicKeyAndChallengeString):
  48804. Moved the code from WebKit. There is never any need to provide implementation at runtime,
  48805. like old code was doing.
  48806. * platform/win/SSLKeyGeneratorWin.cpp: (WebCore::WebCore::getSupportedKeySizes):
  48807. Added a FIXME about localization. Note that Safari for Windows doesn't support keygen.
  48808. 2011-03-15 Anders Carlsson <andersca@apple.com>
  48809. Fix clang build.
  48810. * platform/graphics/GraphicsContext3D.h:
  48811. * platform/graphics/GraphicsLayer.h:
  48812. 2011-03-15 Simon Fraser <simon.fraser@apple.com>
  48813. Fix Lion build after r81161.
  48814. Pass the PlatformCALayer down into drawLayerContents()
  48815. so we can use its acceleratesDrawing() method.
  48816. * platform/graphics/mac/WebLayer.h:
  48817. * platform/graphics/mac/WebLayer.mm:
  48818. (drawLayerContents):
  48819. (-[WebLayer drawInContext:]):
  48820. * platform/graphics/mac/WebTiledLayer.mm:
  48821. (-[WebTiledLayer drawInContext:]):
  48822. 2011-03-15 Alok priyadarshi <alokp@chromium.org>
  48823. Reviewed by James Robinson.
  48824. Valgrind error due to uninitialized PluginLayerChromium::m_textureId
  48825. https://bugs.webkit.org/show_bug.cgi?id=56390
  48826. * platform/graphics/chromium/PluginLayerChromium.cpp:
  48827. (WebCore::PluginLayerChromium::PluginLayerChromium):
  48828. * platform/graphics/chromium/PluginLayerChromium.h:
  48829. (WebCore::PluginLayerChromium::textureId):
  48830. 2011-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
  48831. Reviewed by Dirk Schulze.
  48832. REGRESSION (r68976): Incorrect bidi rendering in SVG text
  48833. https://bugs.webkit.org/show_bug.cgi?id=53980
  48834. rework the test engine or SVG "text-intro" tests so we can turn them back on
  48835. https://bugs.webkit.org/show_bug.cgi?id=6524
  48836. svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
  48837. https://bugs.webkit.org/show_bug.cgi?id=11662
  48838. svg/batik/text/textBiDi.svg failing
  48839. https://bugs.webkit.org/show_bug.cgi?id=17392
  48840. SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
  48841. https://bugs.webkit.org/show_bug.cgi?id=24374
  48842. Implement proper bidirectionality support for SVG text.
  48843. BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in
  48844. the order the characters appear in the markup), and when laying out bidi text, we associated the current character
  48845. in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout.
  48846. The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct.
  48847. Long story:
  48848. Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics>
  48849. for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in
  48850. the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with
  48851. "abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6
  48852. width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class).
  48853. The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands
  48854. that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10").
  48855. To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all
  48856. characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to
  48857. determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the
  48858. inline box tree, in _visual order_, as it will appear on screen.
  48859. After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the
  48860. found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout
  48861. rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position
  48862. in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order,
  48863. the x/y/.. lists are all in logical order.
  48864. Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction:
  48865. the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20".
  48866. Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine,
  48867. before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now
  48868. process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order.
  48869. Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated,
  48870. which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of
  48871. shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by
  48872. dozens of new tests.
  48873. Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg
  48874. svg/W3C-I18N/g-dirLTR-ubOverride.svg
  48875. svg/W3C-I18N/g-dirRTL-ubNone.svg
  48876. svg/W3C-I18N/g-dirRTL-ubOverride.svg
  48877. svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg
  48878. svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg
  48879. svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg
  48880. svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg
  48881. svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg
  48882. svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg
  48883. svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg
  48884. svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg
  48885. svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg
  48886. svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg
  48887. svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg
  48888. svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg
  48889. svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg
  48890. svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg
  48891. svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg
  48892. svg/W3C-I18N/text-anchor-no-markup.svg
  48893. svg/W3C-I18N/text-dirLTR-ubNone.svg
  48894. svg/W3C-I18N/text-dirLTR-ubOverride.svg
  48895. svg/W3C-I18N/text-dirRTL-ubNone.svg
  48896. svg/W3C-I18N/text-dirRTL-ubOverride.svg
  48897. svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg
  48898. svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg
  48899. svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg
  48900. svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg
  48901. svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg
  48902. svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg
  48903. svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg
  48904. svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg
  48905. svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg
  48906. svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg
  48907. svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg
  48908. svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg
  48909. svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg
  48910. svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg
  48911. svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg
  48912. svg/W3C-I18N/tspan-direction-ltr.svg
  48913. svg/W3C-I18N/tspan-direction-rtl.svg
  48914. svg/W3C-SVG-1.1-SE/text-intro-02-b.svg
  48915. svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
  48916. svg/W3C-SVG-1.1-SE/text-intro-09-b.svg
  48917. svg/W3C-SVG-1.1/text-align-08-b.svg
  48918. svg/W3C-SVG-1.1/text-fonts-03-t.svg
  48919. svg/W3C-SVG-1.1/text-intro-01-t.svg
  48920. svg/W3C-SVG-1.1/text-intro-02-b.svg
  48921. svg/W3C-SVG-1.1/text-intro-03-b.svg
  48922. svg/W3C-SVG-1.1/text-intro-04-t.svg
  48923. svg/text/bidi-reorder-value-lists.svg
  48924. svg/text/bidi-text-anchor-direction.svg
  48925. svg/text/bidi-text-query.svg
  48926. svg/text/bidi-tspans.svg
  48927. * rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text.
  48928. (WebCore::RenderBlock::determineStartPosition):
  48929. * rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/
  48930. (WebCore::SVGInlineTextBox::offsetForPositionInFragment):
  48931. (WebCore::SVGInlineTextBox::constructTextRun):
  48932. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
  48933. * rendering/svg/SVGRenderTreeAsText.cpp: Ditto.
  48934. (WebCore::writeSVGInlineTextBox):
  48935. * rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup).
  48936. This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual
  48937. order as the characters are presented on screen.
  48938. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
  48939. (WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder):
  48940. (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
  48941. * rendering/svg/SVGRootInlineBox.h:
  48942. * rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption.
  48943. (WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left.
  48944. (WebCore::SVGTextChunk::calculateLength):
  48945. (WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl).
  48946. * rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield.
  48947. (WebCore::SVGTextChunk::isVerticalText):
  48948. (WebCore::SVGTextChunk::hasDesiredTextLength):
  48949. (WebCore::SVGTextChunk::hasTextAnchor):
  48950. (WebCore::SVGTextChunk::hasLengthAdjustSpacing):
  48951. (WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs):
  48952. * rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes.
  48953. (WebCore::SVGTextChunkBuilder::addTextChunk):
  48954. (WebCore::SVGTextChunkBuilder::processTextChunk):
  48955. * rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text.
  48956. (WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array.
  48957. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp
  48958. (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object
  48959. that we cache, refers to the _rendered_ character. For Arabic text that means, that we're
  48960. measuring the shaped width of the glyph, not the glyph in its isolated form. Without that
  48961. fix reordering boxes containing Arabic is wrong.
  48962. * rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm
  48963. has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have
  48964. to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine,
  48965. to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog.
  48966. (WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
  48967. (WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph.
  48968. The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for
  48969. Arabic until now.)
  48970. (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
  48971. (WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list.
  48972. (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  48973. * rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct.
  48974. (WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange):
  48975. * rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method.
  48976. (WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed.
  48977. * rendering/svg/SVGTextMetrics.h:
  48978. (WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic).
  48979. * rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/
  48980. (WebCore::SVGTextQuery::subStringLengthCallback):
  48981. (WebCore::SVGTextQuery::startPositionOfCharacterCallback):
  48982. (WebCore::SVGTextQuery::endPositionOfCharacterCallback):
  48983. (WebCore::calculateGlyphBoundaries):
  48984. 2011-03-15 Sergio Villar Senin <svillar@igalia.com>
  48985. Reviewed by Xan Lopez.
  48986. [GTK] Fix make distcheck for 1.3.13 release
  48987. https://bugs.webkit.org/show_bug.cgi?id=56371
  48988. No new tests as this is a build fix.
  48989. * GNUmakefile.am: added a couple of missing files.
  48990. 2011-03-08 Levi Weintraub <leviw@chromium.org>
  48991. Reviewed by Ryosuke Niwa.
  48992. Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode
  48993. https://bugs.webkit.org/show_bug.cgi?id=52642
  48994. Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous
  48995. functions that create new positions. Also fixing various parts of editing code that
  48996. incorrectly handled the new positions now being created.
  48997. No new tests as this is refactoring/cleanup.
  48998. * accessibility/AccessibilityRenderObject.cpp:
  48999. (WebCore::AccessibilityRenderObject::visiblePositionRange):
  49000. * dom/Position.cpp:
  49001. (WebCore::Position::parentAnchoredEquivalent):
  49002. (WebCore::Position::previous):
  49003. (WebCore::Position::next):
  49004. (WebCore::Position::atFirstEditingPositionForNode):
  49005. (WebCore::Position::atLastEditingPositionForNode):
  49006. (WebCore::Position::upstream):
  49007. (WebCore::Position::isCandidate):
  49008. (WebCore::Position::getInlineBoxAndOffset):
  49009. * dom/Position.h:
  49010. (WebCore::operator==):
  49011. * dom/PositionIterator.cpp:
  49012. (WebCore::PositionIterator::operator Position):
  49013. * editing/ApplyBlockElementCommand.cpp:
  49014. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
  49015. * editing/CompositeEditCommand.cpp:
  49016. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  49017. * editing/DeleteSelectionCommand.cpp:
  49018. (WebCore::isTableCellEmpty):
  49019. (WebCore::DeleteSelectionCommand::removeNode):
  49020. * editing/InsertLineBreakCommand.cpp:
  49021. (WebCore::InsertLineBreakCommand::doApply):
  49022. * editing/InsertListCommand.cpp:
  49023. (WebCore::InsertListCommand::unlistifyParagraph):
  49024. * editing/ReplaceSelectionCommand.cpp:
  49025. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
  49026. * editing/TypingCommand.cpp:
  49027. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  49028. * editing/VisibleSelection.cpp:
  49029. (WebCore::VisibleSelection::selectionFromContentsOfNode):
  49030. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  49031. * editing/htmlediting.cpp:
  49032. (WebCore::firstEditablePositionAfterPositionInRoot):
  49033. (WebCore::lastEditablePositionBeforePositionInRoot):
  49034. (WebCore::enclosingEmptyListItem):
  49035. * editing/htmlediting.h:
  49036. * editing/visible_units.cpp:
  49037. (WebCore::startOfParagraph):
  49038. (WebCore::endOfParagraph):
  49039. (WebCore::startOfEditableContent):
  49040. (WebCore::endOfEditableContent):
  49041. * rendering/RenderBox.cpp:
  49042. (WebCore::RenderBox::positionForPoint):
  49043. 2011-03-15 Beth Dakin <bdakin@apple.com>
  49044. Attempted build fix.
  49045. * platform/mac/ScrollAnimatorMac.mm:
  49046. (WebCore::ScrollAnimatorMac::cancelAnimations):
  49047. 2011-03-15 David Hyatt <hyatt@apple.com>
  49048. Reviewed by Dave Levin.
  49049. https://bugs.webkit.org/show_bug.cgi?id=56329
  49050. Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's
  49051. constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of
  49052. mutating orientation.
  49053. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  49054. (WebCore::SimpleFontData::platformInit):
  49055. 2011-03-15 Simon Fraser <simon.fraser@apple.com>
  49056. Reviewed by Dan Bernstein.
  49057. Disable ShadowBlur shadow drawing in accelerated contexts
  49058. https://bugs.webkit.org/show_bug.cgi?id=56392
  49059. When drawing into a graphics context that is accelerated, don't use
  49060. ShadowBlur, because it may be slower.
  49061. * platform/graphics/GraphicsContext.h:
  49062. * platform/graphics/cg/GraphicsContextCG.cpp:
  49063. (WebCore::GraphicsContext::fillRect):
  49064. (WebCore::GraphicsContext::fillRoundedRect):
  49065. (WebCore::GraphicsContext::fillRectWithRoundedHole):
  49066. (WebCore::GraphicsContext::setIsCALayerContext):
  49067. (WebCore::GraphicsContext::isCALayerContext):
  49068. (WebCore::GraphicsContext::setIsAcceleratedContext):
  49069. (WebCore::GraphicsContext::isAcceleratedContext):
  49070. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  49071. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  49072. * platform/graphics/mac/WebLayer.mm:
  49073. (drawLayerContents):
  49074. 2011-03-15 Beth Dakin <bdakin@apple.com>
  49075. Reviewed by Simon Fraser.
  49076. Fix for <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
  49077. Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new
  49078. page.
  49079. * loader/FrameLoader.cpp:
  49080. (WebCore::FrameLoader::transitionToCommitted):
  49081. Scroll animations should be suspended if the FrameLoadState is anything but
  49082. complete.
  49083. * page/FrameView.cpp:
  49084. (WebCore::FrameView::shouldSuspendScrollAnimations):
  49085. * page/FrameView.h:
  49086. * platform/ScrollableArea.h:
  49087. (WebCore::ScrollableArea::shouldSuspendScrollAnimations):
  49088. * rendering/RenderDataGrid.cpp:
  49089. (WebCore::RenderDataGrid::shouldSuspendScrollAnimations):
  49090. * rendering/RenderDataGrid.h:
  49091. * rendering/RenderLayer.cpp:
  49092. (WebCore::RenderLayer::shouldSuspendScrollAnimations):
  49093. * rendering/RenderLayer.h:
  49094. * rendering/RenderListBox.cpp:
  49095. (WebCore::RenderListBox::shouldSuspendScrollAnimations):
  49096. * rendering/RenderListBox.h:
  49097. New virtual function cancelAnimations() is only needed on the Mac, so the base
  49098. class is empty.
  49099. * platform/ScrollAnimator.h:
  49100. (WebCore::ScrollAnimator::cancelAnimations):
  49101. ScrollAnimatorMac needs to keep track of whether the page has been scrolled since
  49102. it started loading. If so, we will override optimizations that wait for the
  49103. FrameLoadState to be complete before animating scrollbars.
  49104. * platform/mac/ScrollAnimatorMac.h:
  49105. (WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad):
  49106. If the scrollbar animations should be suspended, we start a timer to make sure
  49107. that we do flash the scrollbars. Animating the scrollbars is expensive, so this is
  49108. both a performance optimization and a UI enhancement since the scrollbar won't
  49109. jump around nearly as much on a page load.
  49110. * platform/mac/ScrollAnimatorMac.mm:
  49111. (-[ScrollbarPainterDelegate cancelAnimations]):
  49112. (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
  49113. (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
  49114. (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
  49115. (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
  49116. (WebCore::ScrollAnimatorMac::scroll):
  49117. (WebCore::ScrollAnimatorMac::handleWheelEvent):
  49118. (WebCore::ScrollAnimatorMac::cancelAnimations):
  49119. (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
  49120. (WebCore::ScrollAnimatorMac::beginScrollGesture):
  49121. (WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):
  49122. (WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive):
  49123. (WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer):
  49124. (WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
  49125. New WebCoreSystemInterface function to force the scrollbars to flash
  49126. * WebCore.exp.in:
  49127. * platform/mac/WebCoreSystemInterface.h:
  49128. * platform/mac/WebCoreSystemInterface.mm:
  49129. 2011-03-15 Dimitri Glazkov <dglazkov@chromium.org>
  49130. Reviewed by Adam Barth.
  49131. Remove stale comment at RenderStyle::diff.
  49132. https://bugs.webkit.org/show_bug.cgi?id=56387
  49133. * rendering/style/RenderStyle.cpp: Removed comment.
  49134. 2011-03-15 David Kilzer <ddkilzer@apple.com>
  49135. <http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
  49136. Reviewed by Simon Fraser.
  49137. Typedef-ing Objective-C classes as void* for pure C++ makes it
  49138. easier for bugs to creep in because compilers can't do any type
  49139. checking for void pointers.
  49140. * platform/graphics/GraphicsContext3D.h: Changed typedef
  49141. declarations for CALayer and WebGLLayer from void* to structs.
  49142. (WebCore::GraphicsContext3D::platformLayer): Changed
  49143. static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
  49144. CALayer and WebGLLayer are not void pointers.
  49145. * platform/graphics/GraphicsLayer.h: Changed typedef declaration
  49146. for PlatformLayer from void* to struct CALayer.
  49147. * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
  49148. declaration for CAPropertyAnimation from void* to a struct.
  49149. Extracted typdef for PlatformAnimationRef.
  49150. 2011-03-15 Ilya Sherman <isherman@chromium.org>
  49151. Reviewed by Tony Chang.
  49152. Autofilled form elements are assigned fixed background color but not text color
  49153. https://bugs.webkit.org/show_bug.cgi?id=48382
  49154. Test: fast/forms/input-autofilled.html
  49155. * css/html.css:
  49156. (input:-webkit-autofill): Added foreground color: #000000
  49157. * css/wml.css:
  49158. (input:-webkit-autofill): Added foreground color: #000000
  49159. 2011-03-15 Alexis Menard <alexis.menard@openbossa.org>
  49160. Reviewed by Eric Carlson.
  49161. HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
  49162. if it's an internal pause for example.
  49163. https://bugs.webkit.org/show_bug.cgi?id=56374
  49164. In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
  49165. change into the DOM.
  49166. No new tests: Verified manually.
  49167. * html/HTMLMediaElement.cpp:
  49168. (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
  49169. 2011-03-12 Pavel Podivilov <podivilov@chromium.org>
  49170. Reviewed by Yury Semikhatsky.
  49171. Web Inspector: re-implement xhr breakpoints.
  49172. https://bugs.webkit.org/show_bug.cgi?id=56252
  49173. - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  49174. - store xhr breakpoints in a separate setting
  49175. - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
  49176. Test: inspector/debugger/xhr-breakpoints.html
  49177. * inspector/InspectorBrowserDebuggerAgent.cpp:
  49178. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
  49179. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  49180. (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  49181. (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
  49182. (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
  49183. (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  49184. (WebCore::InspectorBrowserDebuggerAgent::clear):
  49185. * inspector/InspectorBrowserDebuggerAgent.h:
  49186. * inspector/front-end/BreakpointManager.js:
  49187. (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
  49188. (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
  49189. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  49190. (WebInspector.BreakpointManager.prototype._projectChanged):
  49191. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  49192. (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  49193. * inspector/front-end/BreakpointsSidebarPane.js:
  49194. (WebInspector.XHRBreakpointsSidebarPane):
  49195. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
  49196. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
  49197. (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
  49198. (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
  49199. (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
  49200. (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
  49201. (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
  49202. (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
  49203. (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
  49204. (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
  49205. (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  49206. (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
  49207. (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
  49208. (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  49209. * inspector/front-end/CallStackSidebarPane.js:
  49210. (WebInspector.CallStackSidebarPane.prototype.update):
  49211. (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  49212. * inspector/front-end/ScriptsPanel.js:
  49213. (WebInspector.ScriptsPanel):
  49214. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  49215. (WebInspector.ScriptsPanel.prototype._clearInterface):
  49216. * inspector/front-end/Settings.js:
  49217. (WebInspector.Settings):
  49218. * inspector/front-end/inspector.js:
  49219. (WebInspector.resetFocusElement):
  49220. (WebInspector.set attached):
  49221. 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
  49222. Reviewed by Darin Adler.
  49223. Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
  49224. info into the headers rather than in export symbol definition files, but disable it on
  49225. all platforms initially so we can deal with port build issues one port at a time.
  49226. https://bugs.webkit.org/show_bug.cgi?id=27551
  49227. * config.h:
  49228. * platform/mac/LoggingMac.mm:
  49229. 2011-03-15 Ilya Tikhonovsky <loislo@chromium.org>
  49230. Unreviewed build fix.
  49231. Chromium: shared lib linux build are failing.
  49232. Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
  49233. It was webcore_remaining instead of webcore_platform.
  49234. * WebCore.gyp/WebCore.gyp:
  49235. 2011-03-15 Yury Semikhatsky <yurys@chromium.org>
  49236. Reviewed by Pavel Feldman.
  49237. Web Inspector: expanding/collapsing object shouldn&apos;t affect outer console.group expansion state
  49238. https://bugs.webkit.org/show_bug.cgi?id=56373
  49239. * inspector/front-end/Section.js:
  49240. (WebInspector.Section):
  49241. (WebInspector.Section.prototype.toggleExpanded):
  49242. (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
  49243. 2011-03-15 Pavel Feldman <pfeldman@chromium.org>
  49244. Reviewed by Yury Semikhatsky.
  49245. Web Inspector: crash upon "//html//@id" search in elements panel.
  49246. https://bugs.webkit.org/show_bug.cgi?id=56334
  49247. * inspector/InspectorDOMAgent.cpp:
  49248. * inspector/front-end/ElementsTreeOutline.js:
  49249. 2011-03-15 Andrey Kosyakov <caseq@chromium.org>
  49250. Reviewed by Yury Semikhatsky.
  49251. Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
  49252. https://bugs.webkit.org/show_bug.cgi?id=56327
  49253. * inspector/front-end/ExtensionAPI.js:
  49254. (WebInspector.injectedExtensionAPI):
  49255. * inspector/front-end/ExtensionAPISchema.json:
  49256. 2011-03-15 Yury Semikhatsky <yurys@chromium.org>
  49257. Reviewed by Pavel Feldman.
  49258. Web Inspector: when console.groupEnd calls twice
  49259. https://bugs.webkit.org/show_bug.cgi?id=56114
  49260. Test: inspector/console/console-nested-group.html
  49261. * inspector/ConsoleMessage.h:
  49262. (WebCore::ConsoleMessage::type):
  49263. * inspector/InspectorConsoleAgent.cpp:
  49264. (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
  49265. 2011-03-15 Chris Mumford <chris.mumford@palm.com>
  49266. Reviewed by Adam Barth.
  49267. Initializing several member variables that were not initialized in
  49268. their constructors. These values were all read prior to initialization
  49269. as reported by Valgrind.
  49270. No new tests: No feature additions/removals.
  49271. * accessibility/AccessibilityImageMapLink.cpp:
  49272. (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
  49273. * editing/DeleteSelectionCommand.cpp:
  49274. (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  49275. * html/HTMLCanvasElement.cpp:
  49276. (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  49277. * xml/XPathResult.cpp:
  49278. (WebCore::XPathResult::XPathResult):
  49279. 2011-03-15 Ben Taylor <bentaylor.solx86@gmail.com>
  49280. Reviewed by Adam Barth.
  49281. https://bugs.webkit.org/show_bug.cgi?id=56255
  49282. Fix build on Solaris 10/Sun Studio 12 C++
  49283. No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++
  49284. * bridge/runtime_array.h:
  49285. (JSC::RuntimeArray::getConcreteArray):
  49286. 2011-03-14 Sam Weinig <sam@webkit.org>
  49287. Reviewed by Adam Roben
  49288. about:blank fake responses don't get serialized when sent the UIProcess
  49289. <rdar://problem/9108119>
  49290. https://bugs.webkit.org/show_bug.cgi?id=56357
  49291. Test: AboutBlankLoad
  49292. * platform/network/cf/ResourceResponse.h:
  49293. * platform/network/cf/ResourceResponseCFNet.cpp:
  49294. (WebCore::ResourceResponse::cfURLResponse):
  49295. Create a CFURLResponseRef if one does not exist yet as we do for
  49296. NSURLResponses on the mac.
  49297. 2011-03-14 Alexis Menard <alexis.menard@openbossa.org>
  49298. Reviewed by Kenneth Rohde Christiansen.
  49299. [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
  49300. https://bugs.webkit.org/show_bug.cgi?id=56145
  49301. We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
  49302. positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
  49303. of a bug in QtMultimedia.
  49304. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  49305. (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
  49306. (WebCore::MediaPlayerPrivateQt::seek):
  49307. (WebCore::MediaPlayerPrivateQt::stateChanged):
  49308. (WebCore::MediaPlayerPrivateQt::positionChanged):
  49309. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  49310. 2011-03-14 Alexey Proskuryakov <ap@apple.com>
  49311. Reviewed by Adam Roben.
  49312. https://bugs.webkit.org/show_bug.cgi?id=44138
  49313. Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html
  49314. https://bugs.webkit.org/show_bug.cgi?id=55375
  49315. http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
  49316. https://bugs.webkit.org/show_bug.cgi?id=56185
  49317. http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
  49318. * platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that
  49319. a pointer can be passed across threads when wrapped in a RefPtr.
  49320. * platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists
  49321. when executing a method on main thread by using RefPtr.
  49322. 2011-03-14 Sam Weinig <sam@webkit.org>
  49323. Mac build fix. Part 1 of N.
  49324. * WebCore.exp.in:
  49325. 2011-03-14 Joseph Pecoraro <joepeck@webkit.org>
  49326. Reviewed by Eric Carlson.
  49327. Stalled media elements don't stop delaying the load event
  49328. https://bugs.webkit.org/show_bug.cgi?id=56316
  49329. We should stop delaying the load event when the load has
  49330. stalled naturally, or if we require a user gesture to
  49331. continue the load.
  49332. Test: http/tests/media/video-play-stall-before-meta-data.html
  49333. * html/HTMLMediaElement.cpp:
  49334. (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying.
  49335. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
  49336. 2011-03-13 MORITA Hajime <morrita@google.com>
  49337. Reviewed by Tony Chang.
  49338. Crash when dragging and dropping in a document with an invalid XHTML header
  49339. https://bugs.webkit.org/show_bug.cgi?id=48799
  49340. DragController tried to dispatch textInput event even when the
  49341. drag destination is not the editable area.
  49342. This change skips the event dispatching on that case.
  49343. Test: editing/pasteboard/drop-file-svg.html
  49344. * page/DragController.cpp:
  49345. (WebCore::DragController::dispatchTextInputEventFor):
  49346. (WebCore::DragController::concludeEditDrag):
  49347. 2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
  49348. Unreviewed, rolling out r81094.
  49349. http://trac.webkit.org/changeset/81094
  49350. https://bugs.webkit.org/show_bug.cgi?id=56355
  49351. Broke the chromium DRT related build. (Requested by dave_levin
  49352. on #webkit).
  49353. * WebCore.exp.in:
  49354. * WebCore.order:
  49355. * page/Frame.cpp:
  49356. (WebCore::Frame::layerTreeAsText):
  49357. * page/Frame.h:
  49358. * rendering/RenderLayerCompositor.cpp:
  49359. (WebCore::RenderLayerCompositor::layerTreeAsText):
  49360. * rendering/RenderLayerCompositor.h:
  49361. 2011-03-14 Adam Barth <abarth@webkit.org>
  49362. Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
  49363. the Chromium build, otherwise the objects visible in the global scope
  49364. change.
  49365. * WebCore.gyp/WebCore.gyp:
  49366. 2011-03-14 Adam Barth <abarth@webkit.org>
  49367. Attempted Chromium build fix. Exclude AllInOne harder.
  49368. * WebCore.gyp/WebCore.gyp:
  49369. 2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
  49370. Reviewed by Darin Adler.
  49371. EventHandler calls shouldChangeSelection needlessly
  49372. https://bugs.webkit.org/show_bug.cgi?id=56324
  49373. Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
  49374. avoided calling shouldChangeSelection and setSelection when the existing
  49375. selection is identical to that of new selection.
  49376. * page/EventHandler.cpp:
  49377. (WebCore::setSelectionIfNeeded): Extracted.
  49378. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
  49379. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
  49380. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
  49381. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
  49382. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
  49383. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
  49384. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
  49385. 2011-03-14 Daniel Sievers <sievers@google.com>
  49386. Reviewed by Simon Fraser.
  49387. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
  49388. https://bugs.webkit.org/show_bug.cgi?id=56139
  49389. * WebCore.exp.in:
  49390. * WebCore.order:
  49391. * page/Frame.cpp:
  49392. (WebCore::Frame::layerTreeAsText):
  49393. * page/Frame.h:
  49394. * rendering/RenderLayerCompositor.cpp:
  49395. (WebCore::RenderLayerCompositor::layerTreeAsText):
  49396. * rendering/RenderLayerCompositor.h:
  49397. 2011-03-14 Adam Barth <abarth@webkit.org>
  49398. Reviewed by Dimitri Glazkov.
  49399. Add remaining files to WebCore.gypi
  49400. https://bugs.webkit.org/show_bug.cgi?id=56351
  49401. Adding the remaining files to WebCore.gypi required updating the
  49402. include/exclude lists in WebCore.gyp. These lists aren't overly
  49403. elegant, but we can try to improve them in the future.
  49404. * WebCore.gyp/WebCore.gyp:
  49405. * WebCore.gypi:
  49406. * bindings/v8/ScriptCachedFrameData.cpp:
  49407. - Added ifdefs to this file to match the header.
  49408. * platform/graphics/WOFFFileFormat.cpp:
  49409. - Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
  49410. 2011-03-14 Anton Muhin <antonm@chromium.org>
  49411. Reviewed by Adam Barth.
  49412. [v8] Rework object group building.
  49413. https://bugs.webkit.org/show_bug.cgi?id=55399
  49414. Instead of going top-down (from owner to owned elements), go up---from objects
  49415. to their group ids. That fits better to v8's object grouping model and guarantees
  49416. that each wrapper belongs to the single group.
  49417. Alas, this cannot be implemented for one kind of objects---CSSProperties.
  49418. Part of core GC algorithm and tested extensively by exisiting layout tests.
  49419. * bindings/scripts/CodeGeneratorV8.pm:
  49420. * bindings/scripts/test/V8/V8TestInterface.cpp:
  49421. * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  49422. * bindings/scripts/test/V8/V8TestObj.cpp:
  49423. * bindings/v8/V8GCController.cpp:
  49424. (WebCore::calculateGroupId):
  49425. (WebCore::calculateRootStyleSheet):
  49426. (WebCore::GrouperVisitor::visitDOMWrapper):
  49427. (WebCore::GrouperVisitor::applyGrouping):
  49428. (WebCore::V8GCController::gcPrologue):
  49429. * bindings/v8/WrapperTypeInfo.h:
  49430. (WebCore::WrapperTypeInfo::isSubclass):
  49431. * css/CSSRuleList.h:
  49432. (WebCore::CSSRuleList::styleList):
  49433. * css/StyleSheetList.h:
  49434. (WebCore::StyleSheetList::document):
  49435. 2011-03-14 Kent Tamura <tkent@chromium.org>
  49436. Reviewed by James Robinson.
  49437. Assertion failure by form validation message for <select required> with float:left
  49438. https://bugs.webkit.org/show_bug.cgi?id=55995
  49439. Test: fast/forms/interactive-validation-select-crash.html
  49440. * rendering/RenderBlock.cpp:
  49441. (WebCore::canMergeContiguousAnonymousBlocks):
  49442. isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
  49443. 2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
  49444. Reviewed by Adam Roben.
  49445. [Qt][WK2]Unbreak InjectedBundle on Qt
  49446. https://bugs.webkit.org/show_bug.cgi?id=54109
  49447. No code changes so no new tests.
  49448. Revert the changes that were needed to use KURL
  49449. in WebKitTestRunner.
  49450. * Configurations/WebCore.xcconfig:
  49451. * WebCore.exp.in:
  49452. 2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  49453. Reviewed by Kenneth Rohde Christiansen.
  49454. [Qt] Compilation fails with --3d-canvas
  49455. https://bugs.webkit.org/show_bug.cgi?id=55964
  49456. * WebCore.pro:
  49457. * platform/graphics/qt/Extensions3DQt.cpp:
  49458. 2011-03-14 Brian Weinstein <bweinstein@apple.com>
  49459. Reviewed by Adam Roben and Gavin Barraclough.
  49460. FileSystemWin.cpp needs listDirectory() implementation
  49461. https://bugs.webkit.org/show_bug.cgi?id=56331
  49462. <rdar://problem/9126635>
  49463. Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
  49464. so it can be used from both WebCore and WebKit2.
  49465. Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
  49466. of paths matching the passed in pattern.
  49467. * WebCore.vcproj/WebCore.vcproj:
  49468. * platform/win/FileSystemWin.cpp:
  49469. (WebCore::listDirectory): Call through to PathWalker.
  49470. * platform/win/PathWalker.cpp: Added.
  49471. (WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument
  49472. for the pattern to pass to the Windows File APIs.
  49473. (WebCore::PathWalker::~PathWalker): Moved from WebKit2.
  49474. (WebCore::PathWalker::isValid): Ditto.
  49475. (WebCore::PathWalker::data): Ditto.
  49476. (WebCore::PathWalker::step): Ditto.
  49477. * platform/win/PathWalker.h: Added.
  49478. 2011-03-14 Brady Eidson <beidson@apple.com>
  49479. Reviewed by Anders Carlsson.
  49480. https://bugs.webkit.org/show_bug.cgi?id=56320
  49481. Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
  49482. Remove HistoryItem::icon():
  49483. * history/HistoryItem.cpp:
  49484. * history/HistoryItem.h:
  49485. * WebCore.exp.in:
  49486. * loader/icon/IconDatabaseBase.h:
  49487. (WebCore::IconDatabaseBase::defaultIcon):
  49488. 2011-03-14 Andy Estes <aestes@apple.com>
  49489. Reviewed by Darin Adler.
  49490. Timer-based events should inherit the user gesture state of their
  49491. originating event in certain cases.
  49492. https://bugs.webkit.org/show_bug.cgi?id=55104
  49493. If a timer is installed by a gesture-originated event and will fire
  49494. within one second, the timer-initiated event should behave as if it
  49495. were also initiated by a user gesture. Multi-shot timers should only
  49496. get this behavior on their first execution. Nested timers should not
  49497. get this behavior. This makes us compatible with Gecko when handling
  49498. popups and file chooser dialogs created from timer events.
  49499. Test: fast/events/popup-blocking-timers.html
  49500. * page/DOMTimer.cpp:
  49501. (WebCore::timeoutId): Create a helper function so that m_timeoutId can
  49502. be initialized in the data member initialization list.
  49503. (WebCore::shouldForwardUserGesture): Ditto, but for
  49504. m_shouldForwardUserGesture.
  49505. (WebCore::DOMTimer::DOMTimer): Move initialization of data members from
  49506. the ctor body to the data member initialization list. Also rename the
  49507. argument 'timeout' to 'interval'.
  49508. (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
  49509. state based on the value of m_shouldForwardUserGesture.
  49510. (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
  49511. renamed to m_originalInterval.
  49512. * page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
  49513. m_originalTimeout to m_originalInterval.
  49514. 2011-03-09 Levi Weintraub <leviw@chromium.org>
  49515. Reviewed by Ryosuke Niwa.
  49516. Deleting content directly following a button inserts an unnecessary placeholder
  49517. https://bugs.webkit.org/show_bug.cgi?id=56053
  49518. Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
  49519. enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
  49520. DeleteSelectionCommand treating them as blockflow.
  49521. Test: editing/deleting/delete-inserts-br-after-button.html
  49522. * editing/DeleteSelectionCommand.cpp:
  49523. (WebCore::DeleteSelectionCommand::mergeParagraphs):
  49524. 2011-03-14 David Hyatt <hyatt@apple.com>
  49525. Reviewed by Dan Bernstein.
  49526. https://bugs.webkit.org/show_bug.cgi?id=45164
  49527. REGRESSION: <a><img align=top></a> Clickable area too large
  49528. Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
  49529. painting.
  49530. * rendering/InlineFlowBox.cpp:
  49531. (WebCore::InlineFlowBox::nodeAtPoint):
  49532. 2011-03-14 Chris Marrin <cmarrin@apple.com>
  49533. Reviewed by Adam Roben.
  49534. REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
  49535. https://bugs.webkit.org/show_bug.cgi?id=52845
  49536. The lastCommitTime() value in CACFLayerTreeHost was returning as the time
  49537. the render previous to this one happened. That often made it seem like
  49538. animations started more in the past than they did, breaking many animations.
  49539. The startAnimations() call actually fires from a CACF callback after all the
  49540. WebKit content has been rendered. So sending currentTime as the start time
  49541. to the animations is close enough for proper synchronization.
  49542. * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  49543. (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
  49544. 2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
  49545. Reviewed by Tony Chang.
  49546. Selection uses first mousemove's localRect instead of that of mousedown
  49547. https://bugs.webkit.org/show_bug.cgi?id=56213
  49548. Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
  49549. using the mouse coordinates of the mousedown event that started the drag.
  49550. Test: editing/selection/drag-select-rapidly.html
  49551. * page/EventHandler.cpp:
  49552. (WebCore::EventHandler::handleMouseDraggedEvent):
  49553. 2011-03-14 Mark Rowe <mrowe@apple.com>
  49554. Reviewed by Timothy Hatcher.
  49555. Apply a large, blunt object directly to the skull of the Leopard build.
  49556. * Configurations/Base.xcconfig: Disable the generation of debugging symbols when
  49557. building the Debug configuration on Leopard. This should cut the size of the object
  49558. files that the linker needs to process by over 85%. This will hopefully allow them
  49559. to fit in to the 32-bit address space of the Leopard linker.
  49560. 2011-03-14 David Hyatt <hyatt@apple.com>
  49561. Reviewed by Beth Dakin.
  49562. https://bugs.webkit.org/show_bug.cgi?id=56246
  49563. Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
  49564. for offsetLeft, and add new tests to demonstrate that relative positioning works.
  49565. * css/CSSStyleSelector.cpp:
  49566. (WebCore::CSSStyleSelector::adjustRenderStyle):
  49567. * rendering/RenderObject.cpp:
  49568. (WebCore::RenderObject::offsetParent):
  49569. * rendering/RenderObject.h:
  49570. (WebCore::RenderObject::isRelPositioned):
  49571. * rendering/RenderTableCell.h:
  49572. * rendering/style/RenderStyle.h:
  49573. * rendering/style/StyleRareNonInheritedData.cpp:
  49574. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  49575. (WebCore::StyleRareNonInheritedData::operator==):
  49576. * rendering/style/StyleRareNonInheritedData.h:
  49577. 2011-03-14 David Hyatt <hyatt@apple.com>
  49578. Reviewed by Beth Dakin.
  49579. Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
  49580. layer, since first layouts and printing mess up otherwise.
  49581. * page/FrameView.cpp:
  49582. (WebCore::FrameView::layout):
  49583. 2011-03-11 David Hyatt <hyatt@apple.com>
  49584. Reviewed by Simon Fraser.
  49585. Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
  49586. size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
  49587. for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
  49588. all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
  49589. and limited that overflow only to content that the layer painted.
  49590. Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
  49591. m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
  49592. own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
  49593. the other ports.
  49594. Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
  49595. I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
  49596. but the behavior should be the same.
  49597. No new tests, since this is untestable on ports that invalidate on a resize.
  49598. * page/FrameView.cpp:
  49599. (WebCore::FrameView::layout):
  49600. * rendering/RenderBoxModelObject.cpp:
  49601. (WebCore::RenderBoxModelObject::styleDidChange):
  49602. * rendering/RenderLayer.cpp:
  49603. (WebCore::RenderLayer::updateLayerPositions):
  49604. (WebCore::RenderLayer::removeOnlyThisLayer):
  49605. * rendering/RenderLayer.h:
  49606. 2011-03-11 Oliver Hunt <oliver@apple.com>
  49607. Reviewed by Gavin Barraclough.
  49608. Ensure all values are correctly tagged in the registerfile
  49609. https://bugs.webkit.org/show_bug.cgi?id=56214
  49610. Make sure everything builds still.
  49611. * bridge/c/c_class.cpp:
  49612. * bridge/c/c_runtime.cpp:
  49613. * bridge/jni/JavaMethod.cpp:
  49614. * plugins/PluginViewNone.cpp:
  49615. 2011-03-14 Luiz Agostini <luiz.agostini@openbossa.org>
  49616. Unreviewed build fix for r81035.
  49617. * html/HTMLDetailsElement.cpp:
  49618. (WebCore::HTMLDetailsElement::defaultEventHandler):
  49619. * rendering/RenderDetailsMarker.cpp:
  49620. (WebCore::createDownArrowPath):
  49621. (WebCore::createUpArrowPath):
  49622. (WebCore::createLeftArrowPath):
  49623. (WebCore::createRightArrowPath):
  49624. 2011-03-13 Jer Noble <jer.noble@apple.com>
  49625. FullScreen: Handle entering full screen security restrictions
  49626. https://bugs.webkit.org/show_bug.cgi?id=56264
  49627. Tests: fullscreen/full-screen-iframe-allowed.html
  49628. fullscreen/full-screen-iframe-not-allowed.html
  49629. Disable full screen documents in the following conditions:
  49630. 1) requesting element is in an iframe which does not have a
  49631. webkitallowfullscreen attribute.
  49632. 2) page is not processing a user gesture.
  49633. * dom/Document.cpp:
  49634. (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks
  49635. to see if elements contained in IFRAMES are allowed to
  49636. enter full screen.
  49637. (WebCore::Document::webkitRequestFullScreenForElement): Checks
  49638. if page is currently processing a user gesture.
  49639. * dom/Document.h:
  49640. * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
  49641. * html/HTMLFrameElementBase.cpp:
  49642. (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
  49643. * html/HTMLFrameElementBase.h:
  49644. 2011-03-14 Anton D'Auria <adauria@apple.com>
  49645. Reviewed by David Levin.
  49646. REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
  49647. https://bugs.webkit.org/show_bug.cgi?id=56303
  49648. Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.
  49649. * storage/StorageAreaSync.cpp:
  49650. (WebCore::StorageAreaSync::StorageAreaSync):
  49651. 2011-03-14 Steve Block <steveblock@google.com>
  49652. Reviewed by Oliver Hunt.
  49653. JavaMethod.cpp does not compile with V8
  49654. https://bugs.webkit.org/show_bug.cgi?id=56306
  49655. Moved the ScopeChain.h include to JavaStringJSC.
  49656. No new tests, build fix only.
  49657. * bridge/jni/JavaMethod.cpp:
  49658. * bridge/jni/jsc/JavaStringJSC.h
  49659. 2011-02-28 Luiz Agostini <luiz.agostini@openbossa.org>
  49660. Reviewed by Dave Hyatt.
  49661. HTML5 <details> and <summary>: rendering
  49662. https://bugs.webkit.org/show_bug.cgi?id=51071
  49663. Tests: fast/html/details-add-summary-1-and-click.html
  49664. fast/html/details-add-summary-1.html
  49665. fast/html/details-add-summary-10-and-click.html
  49666. fast/html/details-add-summary-10.html
  49667. fast/html/details-add-summary-2-and-click.html
  49668. fast/html/details-add-summary-2.html
  49669. fast/html/details-add-summary-3-and-click.html
  49670. fast/html/details-add-summary-3.html
  49671. fast/html/details-add-summary-4-and-click.html
  49672. fast/html/details-add-summary-4.html
  49673. fast/html/details-add-summary-5-and-click.html
  49674. fast/html/details-add-summary-5.html
  49675. fast/html/details-add-summary-6-and-click.html
  49676. fast/html/details-add-summary-6.html
  49677. fast/html/details-add-summary-7-and-click.html
  49678. fast/html/details-add-summary-7.html
  49679. fast/html/details-add-summary-8-and-click.html
  49680. fast/html/details-add-summary-8.html
  49681. fast/html/details-add-summary-9-and-click.html
  49682. fast/html/details-add-summary-9.html
  49683. fast/html/details-mouse-click.html
  49684. fast/html/details-no-summary1.html
  49685. fast/html/details-no-summary2.html
  49686. fast/html/details-no-summary3.html
  49687. fast/html/details-no-summary4.html
  49688. fast/html/details-open-javascript.html
  49689. fast/html/details-open1.html
  49690. fast/html/details-open2.html
  49691. fast/html/details-open3.html
  49692. fast/html/details-open4.html
  49693. fast/html/details-open5.html
  49694. fast/html/details-open6.html
  49695. fast/html/details-position.html
  49696. fast/html/details-remove-summary-1-and-click.html
  49697. fast/html/details-remove-summary-1.html
  49698. fast/html/details-remove-summary-2-and-click.html
  49699. fast/html/details-remove-summary-2.html
  49700. fast/html/details-remove-summary-3-and-click.html
  49701. fast/html/details-remove-summary-3.html
  49702. fast/html/details-remove-summary-4-and-click.html
  49703. fast/html/details-remove-summary-4.html
  49704. fast/html/details-remove-summary-5-and-click.html
  49705. fast/html/details-remove-summary-5.html
  49706. fast/html/details-remove-summary-6-and-click.html
  49707. fast/html/details-remove-summary-6.html
  49708. fast/html/details-writing-mode.html
  49709. http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
  49710. The main <summary> element is the first <summary> element of a <details> element.
  49711. All other childs of the <details> element are rendered only if the attribute 'open' is set.
  49712. Click event toggles the 'open' attribute.
  49713. * html/HTMLDetailsElement.cpp:
  49714. (WebCore::HTMLDetailsElement::HTMLDetailsElement):
  49715. (WebCore::HTMLDetailsElement::findMainSummary):
  49716. (WebCore::HTMLDetailsElement::childrenChanged):
  49717. (WebCore::HTMLDetailsElement::finishParsingChildren):
  49718. (WebCore::HTMLDetailsElement::parseMappedAttribute):
  49719. (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
  49720. (WebCore::HTMLDetailsElement::defaultEventHandler):
  49721. * html/HTMLDetailsElement.h:
  49722. (WebCore::HTMLDetailsElement::mainSummary):
  49723. Method createRenderer added to class HTMLSummaryElement.
  49724. * html/HTMLSummaryElement.cpp:
  49725. (WebCore::HTMLSummaryElement::createRenderer):
  49726. * html/HTMLSummaryElement.h:
  49727. The first <summary> element is positioned at the top of its <details> parent.
  49728. The area occupied by this main <summary> element is the interactive area of the
  49729. <details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
  49730. is created and added to the corresponding RenderDetails object.
  49731. * rendering/RenderDetails.cpp:
  49732. (WebCore::RenderDetails::RenderDetails):
  49733. (WebCore::RenderDetails::destroy):
  49734. (WebCore::RenderDetails::summaryBlock):
  49735. (WebCore::RenderDetails::contentBlock):
  49736. (WebCore::RenderDetails::addChild):
  49737. (WebCore::RenderDetails::removeChild):
  49738. (WebCore::RenderDetails::setMarkerStyle):
  49739. (WebCore::RenderDetails::styleDidChange):
  49740. (WebCore::RenderDetails::getRenderPosition):
  49741. (WebCore::RenderDetails::markerDestroyed):
  49742. (WebCore::RenderDetails::summaryDestroyed):
  49743. (WebCore::RenderDetails::moveSummaryToContents):
  49744. (WebCore::RenderDetails::createSummaryStyle):
  49745. (WebCore::RenderDetails::replaceMainSummary):
  49746. (WebCore::RenderDetails::createDefaultSummary):
  49747. (WebCore::RenderDetails::checkMainSummary):
  49748. (WebCore::RenderDetails::layout):
  49749. (WebCore::RenderDetails::isOpen):
  49750. (WebCore::RenderDetails::getParentOfFirstLineBox):
  49751. (WebCore::RenderDetails::firstNonMarkerChild):
  49752. (WebCore::RenderDetails::updateMarkerLocation):
  49753. * rendering/RenderDetails.h:
  49754. (WebCore::RenderDetails::interactiveArea):
  49755. (WebCore::RenderDetails::removeLeftoverAnonymousBlock):
  49756. (WebCore::RenderDetails::createsAnonymousWrapper):
  49757. (WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):
  49758. A marker is added to the main <summary> element to indicate the current value of the 'open'
  49759. attribute of the <details> element.
  49760. * rendering/RenderDetailsMarker.cpp:
  49761. (WebCore::RenderDetailsMarker::RenderDetailsMarker):
  49762. (WebCore::RenderDetailsMarker::destroy):
  49763. (WebCore::RenderDetailsMarker::lineHeight):
  49764. (WebCore::RenderDetailsMarker::baselinePosition):
  49765. (WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
  49766. (WebCore::RenderDetailsMarker::layout):
  49767. (WebCore::RenderDetailsMarker::getRelativeMarkerRect):
  49768. (WebCore::RenderDetailsMarker::isOpen):
  49769. (WebCore::createPath):
  49770. (WebCore::createDownArrowPath):
  49771. (WebCore::createUpArrowPath):
  49772. (WebCore::createLeftArrowPath):
  49773. (WebCore::createRightArrowPath):
  49774. (WebCore::RenderDetailsMarker::orientation):
  49775. (WebCore::RenderDetailsMarker::getCanonicalPath):
  49776. (WebCore::RenderDetailsMarker::getPath):
  49777. (WebCore::RenderDetailsMarker::paint):
  49778. * rendering/RenderDetailsMarker.h:
  49779. (WebCore::toRenderDetailsMarker):
  49780. * rendering/RenderSummary.cpp:
  49781. (WebCore::RenderSummary::RenderSummary):
  49782. (WebCore::RenderSummary::destroy):
  49783. (WebCore::RenderSummary::parentDetails):
  49784. (WebCore::RenderSummary::styleDidChange):
  49785. * rendering/RenderSummary.h:
  49786. * rendering/RenderTreeAsText.cpp:
  49787. (WebCore::RenderTreeAsText::writeRenderObject):
  49788. 2011-03-14 Brady Eidson <beidson@apple.com>
  49789. Reviewed by Sam Weinig.
  49790. https://bugs.webkit.org/show_bug.cgi?id=56296
  49791. Clean up IconDatabaseBase header.
  49792. -Get rid of the "PlatformString.h" include and replace it with a forward declaration.
  49793. -Group methods by which are used in WebCore directly and which are used in WebKit ports.
  49794. This'll make it easier to use in external frameworks (like WebKit2).
  49795. * loader/icon/IconDatabase.h:
  49796. * loader/icon/IconDatabaseBase.h:
  49797. (WebCore::IconDatabaseBase::retainIconForPageURL):
  49798. (WebCore::IconDatabaseBase::releaseIconForPageURL):
  49799. (WebCore::IconDatabaseBase::iconForPageURL):
  49800. (WebCore::IconDatabaseBase::setIconURLForPageURL):
  49801. (WebCore::IconDatabaseBase::setIconDataForIconURL):
  49802. (WebCore::IconDatabaseBase::iconDataKnownForIconURL):
  49803. (WebCore::IconDatabaseBase::loadDecisionForIconURL):
  49804. (WebCore::IconDatabaseBase::importIconURLForPageURL):
  49805. (WebCore::IconDatabaseBase::importIconDataForIconURL):
  49806. (WebCore::IconDatabaseBase::open):
  49807. 2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
  49808. Unreviewed, rolling out r81026.
  49809. http://trac.webkit.org/changeset/81026
  49810. https://bugs.webkit.org/show_bug.cgi?id=56313
  49811. Breaks gtk 64-bit tests (Requested by podivilov on #webkit).
  49812. * inspector/InspectorBrowserDebuggerAgent.cpp:
  49813. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
  49814. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  49815. (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  49816. (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
  49817. (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
  49818. (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  49819. (WebCore::InspectorBrowserDebuggerAgent::clear):
  49820. * inspector/InspectorBrowserDebuggerAgent.h:
  49821. * inspector/front-end/BreakpointManager.js:
  49822. (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
  49823. (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
  49824. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  49825. (WebInspector.BreakpointManager.prototype._projectChanged):
  49826. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  49827. (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  49828. (WebInspector.BreakpointManager.prototype._createXHRBreakpointId):
  49829. (WebInspector.XHRBreakpoint):
  49830. (WebInspector.XHRBreakpoint.prototype._enable):
  49831. (WebInspector.XHRBreakpoint.prototype._disable):
  49832. (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
  49833. (WebInspector.XHRBreakpointView):
  49834. (WebInspector.XHRBreakpointView.prototype.compareTo):
  49835. (WebInspector.XHRBreakpointView.prototype.populateEditElement):
  49836. (WebInspector.XHRBreakpointView.prototype.populateLabelElement):
  49837. (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
  49838. * inspector/front-end/BreakpointsSidebarPane.js:
  49839. (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
  49840. (WebInspector.XHRBreakpointsSidebarPane):
  49841. (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
  49842. (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
  49843. (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
  49844. * inspector/front-end/CallStackSidebarPane.js:
  49845. (WebInspector.CallStackSidebarPane.prototype.update):
  49846. * inspector/front-end/ScriptsPanel.js:
  49847. (WebInspector.ScriptsPanel):
  49848. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  49849. (WebInspector.ScriptsPanel.prototype._clearInterface):
  49850. * inspector/front-end/Settings.js:
  49851. (WebInspector.Settings):
  49852. * inspector/front-end/inspector.js:
  49853. (WebInspector.resetFocusElement):
  49854. (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
  49855. (WebInspector.createXHRBreakpointsSidebarPane):
  49856. (WebInspector.set attached):
  49857. 2011-03-14 Mikhail Naganov <mnaganov@chromium.org>
  49858. Reviewed by Pavel Feldman.
  49859. Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
  49860. https://bugs.webkit.org/show_bug.cgi?id=56312
  49861. Test: inspector/utilities.html
  49862. * inspector/front-end/utilities.js:
  49863. 2011-03-12 Pavel Podivilov <podivilov@chromium.org>
  49864. Reviewed by Yury Semikhatsky.
  49865. Web Inspector: re-implement xhr breakpoints.
  49866. https://bugs.webkit.org/show_bug.cgi?id=56252
  49867. - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  49868. - store xhr breakpoints in a separate setting
  49869. - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
  49870. Test: inspector/debugger/xhr-breakpoints.html
  49871. * inspector/InspectorBrowserDebuggerAgent.cpp:
  49872. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
  49873. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  49874. (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  49875. (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
  49876. (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
  49877. (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  49878. (WebCore::InspectorBrowserDebuggerAgent::clear):
  49879. * inspector/InspectorBrowserDebuggerAgent.h:
  49880. * inspector/front-end/BreakpointManager.js:
  49881. (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
  49882. (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
  49883. (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
  49884. (WebInspector.BreakpointManager.prototype._projectChanged):
  49885. (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  49886. (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  49887. * inspector/front-end/BreakpointsSidebarPane.js:
  49888. (WebInspector.XHRBreakpointsSidebarPane):
  49889. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
  49890. (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
  49891. (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
  49892. (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
  49893. (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
  49894. (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
  49895. (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
  49896. (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
  49897. (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
  49898. (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
  49899. (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  49900. (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
  49901. (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
  49902. (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  49903. * inspector/front-end/CallStackSidebarPane.js:
  49904. (WebInspector.CallStackSidebarPane.prototype.update):
  49905. (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  49906. * inspector/front-end/ScriptsPanel.js:
  49907. (WebInspector.ScriptsPanel):
  49908. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  49909. (WebInspector.ScriptsPanel.prototype._clearInterface):
  49910. * inspector/front-end/Settings.js:
  49911. (WebInspector.Settings):
  49912. * inspector/front-end/inspector.js:
  49913. (WebInspector.resetFocusElement):
  49914. (WebInspector.set attached):
  49915. 2011-03-14 Pavel Podivilov <podivilov@chromium.org>
  49916. Reviewed by Pavel Feldman.
  49917. Web Inspector: move breakpoints restoring to debugger presentation model.
  49918. https://bugs.webkit.org/show_bug.cgi?id=56123
  49919. DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
  49920. setBreakpoint/removeBreakpoint are now called from DPM only.
  49921. * inspector/InspectorDebuggerAgent.cpp:
  49922. (WebCore::InspectorDebuggerAgent::disable):
  49923. (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
  49924. * inspector/front-end/DebuggerModel.js:
  49925. (WebInspector.DebuggerModel.prototype.enableDebugger):
  49926. (WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
  49927. (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
  49928. (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
  49929. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  49930. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  49931. (WebInspector.DebuggerModel.prototype.removeBreakpoint):
  49932. (WebInspector.DebuggerModel.prototype._breakpointResolved):
  49933. (WebInspector.DebuggerModel.prototype.reset):
  49934. (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
  49935. (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
  49936. * inspector/front-end/DebuggerPresentationModel.js:
  49937. (WebInspector.DebuggerPresentationModel):
  49938. (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
  49939. (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
  49940. (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
  49941. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  49942. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
  49943. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  49944. (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
  49945. (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
  49946. (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
  49947. (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
  49948. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  49949. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  49950. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  49951. (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
  49952. (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
  49953. (WebInspector.DebuggerPresentationModel.prototype.reset):
  49954. * inspector/front-end/ScriptsPanel.js:
  49955. (WebInspector.ScriptsPanel):
  49956. (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
  49957. (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
  49958. 2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
  49959. Unreviewed, rolling out r81015.
  49960. http://trac.webkit.org/changeset/81015
  49961. https://bugs.webkit.org/show_bug.cgi?id=56308
  49962. A Similar patch landed in r76960 (Requested by philn-tp on
  49963. #webkit).
  49964. * GNUmakefile.am:
  49965. 2011-03-14 Pavel Feldman <pfeldman@chromium.org>
  49966. Reviewed by Yury Semikhatsky.
  49967. Web Inspector: don't use innerText, use textContent instead.
  49968. https://bugs.webkit.org/show_bug.cgi?id=56307
  49969. * inspector/front-end/AuditFormatters.js:
  49970. (WebInspector.AuditFormatters.snippet):
  49971. * inspector/front-end/ElementsTreeOutline.js:
  49972. * inspector/front-end/GoToLineDialog.js:
  49973. * inspector/front-end/HelpScreen.js:
  49974. (WebInspector.HelpScreen):
  49975. * inspector/front-end/ShortcutsHelp.js:
  49976. (WebInspector.ShortcutsSection.prototype.renderSection):
  49977. (WebInspector.ShortcutsSection.prototype._renderHeader):
  49978. 2011-03-14 Andrey Adaikin <aandrey@google.com>
  49979. Reviewed by Pavel Feldman.
  49980. Web Inspector: [Text editor] Disable live-edit in favor of the text editor
  49981. https://bugs.webkit.org/show_bug.cgi?id=56176
  49982. * inspector/front-end/Settings.js:
  49983. 2011-03-14 Andrey Adaikin <aandrey@google.com>
  49984. Reviewed by Pavel Feldman.
  49985. Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
  49986. https://bugs.webkit.org/show_bug.cgi?id=56095
  49987. * inspector/front-end/TextViewer.js:
  49988. (WebInspector.TextViewer):
  49989. 2011-03-11 Pavel Podivilov <podivilov@chromium.org>
  49990. Reviewed by Pavel Feldman.
  49991. Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
  49992. https://bugs.webkit.org/show_bug.cgi?id=56179
  49993. Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.
  49994. * inspector/front-end/DebuggerModel.js:
  49995. (WebInspector.DebuggerModel):
  49996. (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
  49997. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  49998. (WebInspector.DebuggerModel.prototype.reset):
  49999. (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource):
  50000. (WebInspector.DebuggerModel.prototype.editScriptSource):
  50001. (WebInspector.DebuggerModel.prototype.get callFrames):
  50002. (WebInspector.DebuggerModel.prototype._pausedScript):
  50003. (WebInspector.DebuggerModel.prototype._resumedScript):
  50004. * inspector/front-end/DebuggerPresentationModel.js:
  50005. (WebInspector.DebuggerPresentationModel):
  50006. (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  50007. * inspector/front-end/ScriptsPanel.js:
  50008. (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  50009. 2011-03-10 Alexander Pavlov <apavlov@chromium.org>
  50010. Reviewed by Pavel Feldman.
  50011. Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
  50012. https://bugs.webkit.org/show_bug.cgi?id=56111
  50013. This change reduces the getStylesForNode() payload more than twice for BODY elements.
  50014. * inspector/InspectorStyleSheet.cpp:
  50015. (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  50016. * inspector/front-end/CSSStyleModel.js:
  50017. (WebInspector.CSSProperty.parsePayload):
  50018. 2011-03-14 John Knottenbelt <jknotten@chromium.org>
  50019. Reviewed by Steve Block.
  50020. Detach Geolocation from Frame when Page destroyed.
  50021. https://bugs.webkit.org/show_bug.cgi?id=52877
  50022. On Page destruction, any outstanding Geolocation permission
  50023. requests should be cancelled, because the Geolocation can only
  50024. access the client indirectly via m_frame->page().
  50025. Page destruction is signalled by a call to the
  50026. Frame::pageDestroyed() method. This explictly calls
  50027. DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
  50028. Geolocation::reset() detaches from the GeolocationController,
  50029. cancels requests, watches and single shots, and sets the
  50030. permission state back to Unknown.
  50031. Frame::pageDestroyed() is also called by FrameLoader even though
  50032. the page is not destroyed. We should still cancel permission
  50033. requests, because the GeolocationClient will become inaccessible
  50034. to the Geolocation object after this call.
  50035. Frame::transferChildFrameToNewDocument also indirectly calls
  50036. Geolocation::reset when the frame is reparented between
  50037. pages. Ideally we would like the Geolocation's activities to
  50038. continue after reparenting, see bug
  50039. https://bugs.webkit.org/show_bug.cgi?id=55577
  50040. Since GeolocationController is owned by Page, and all Geolocation
  50041. objects will now unsubscribe from the GeolocationController on
  50042. pageDetached(), we no longer need to call stopUpdating() from the
  50043. GeolocationController's destructor. Instead we can simply assert
  50044. that there should be no no observers. See related bug
  50045. https://bugs.webkit.org/show_bug.cgi?id=52216 .
  50046. Introduced new method 'numberOfPendingPermissionRequests' on
  50047. GeolocationClientMock to count the number of outstanding pending
  50048. permission requests. This provides a reusable implementation for
  50049. client-based implementations of the LayoutTestController's
  50050. numberOfPendingGeolocationPermissionRequests method.
  50051. Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
  50052. * page/DOMWindow.cpp:
  50053. (WebCore::DOMWindow::resetGeolocation):
  50054. * page/DOMWindow.h:
  50055. * page/Frame.cpp:
  50056. (WebCore::Frame::pageDestroyed):
  50057. (WebCore::Frame::transferChildFrameToNewDocument):
  50058. * page/Geolocation.cpp:
  50059. (WebCore::Geolocation::~Geolocation):
  50060. (WebCore::Geolocation::page):
  50061. (WebCore::Geolocation::reset):
  50062. (WebCore::Geolocation::disconnectFrame):
  50063. (WebCore::Geolocation::lastPosition):
  50064. (WebCore::Geolocation::requestPermission):
  50065. (WebCore::Geolocation::startUpdating):
  50066. (WebCore::Geolocation::stopUpdating):
  50067. * page/Geolocation.h:
  50068. * page/GeolocationController.cpp:
  50069. (WebCore::GeolocationController::~GeolocationController):
  50070. * page/Navigator.cpp:
  50071. (WebCore::Navigator::resetGeolocation):
  50072. * page/Navigator.h:
  50073. * platform/mock/GeolocationClientMock.cpp:
  50074. (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  50075. * platform/mock/GeolocationClientMock.h:
  50076. 2011-03-14 Andrey Adaikin <aandrey@google.com>
  50077. Reviewed by Pavel Feldman.
  50078. Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
  50079. https://bugs.webkit.org/show_bug.cgi?id=56183
  50080. * inspector/front-end/SourceFrame.js:
  50081. (WebInspector.SourceFrame.prototype._handleKeyDown):
  50082. (WebInspector.SourceFrame.prototype._handleSave):
  50083. (WebInspector.SourceFrame.prototype._handleRevertEditing):
  50084. * inspector/front-end/TextViewer.js:
  50085. (WebInspector.TextEditorMainPanel):
  50086. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  50087. 2011-03-14 Chris Rogers <crogers@google.com>
  50088. Reviewed by Xan Lopez.
  50089. Add all web audio auto-generated files to GTK make system
  50090. https://bugs.webkit.org/show_bug.cgi?id=50497
  50091. No new tests since these are build-system tweaks.
  50092. * GNUmakefile.am:
  50093. 2011-03-14 Pavel Feldman <pfeldman@chromium.org>
  50094. Reviewed by Yury Semikhatsky.
  50095. Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
  50096. https://bugs.webkit.org/show_bug.cgi?id=56268
  50097. * inspector/Inspector.idl:
  50098. * inspector/InspectorDOMAgent.cpp:
  50099. (WebCore::InspectorDOMAgent::reset):
  50100. (WebCore::InspectorDOMAgent::performSearch):
  50101. (WebCore::InspectorDOMAgent::cancelSearch):
  50102. (WebCore::InspectorDOMAgent::onMatchJobsTimer):
  50103. (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
  50104. * inspector/InspectorDOMAgent.h:
  50105. * inspector/front-end/DOMAgent.js:
  50106. (WebInspector.DOMAgent.prototype.requestDocument.mycallback):
  50107. (WebInspector.DOMAgent.prototype.requestDocument):
  50108. (WebInspector.DOMAgent.prototype._attributesUpdated):
  50109. (WebInspector.DOMAgent.prototype._characterDataModified):
  50110. (WebInspector.DOMAgent.prototype._documentUpdated):
  50111. (WebInspector.DOMAgent.prototype._setDocument):
  50112. (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
  50113. (WebInspector.DOMAgent.prototype._childNodeInserted):
  50114. (WebInspector.DOMAgent.prototype._childNodeRemoved):
  50115. (WebInspector.DOMAgent.prototype._removeBreakpoints):
  50116. (WebInspector.DOMAgent.prototype.performSearch):
  50117. (WebInspector.DOMAgent.prototype.cancelSearch):
  50118. (WebInspector.DOMDispatcher.prototype.searchResults):
  50119. * inspector/front-end/ElementsPanel.js:
  50120. (WebInspector.ElementsPanel):
  50121. (WebInspector.ElementsPanel.prototype._reset):
  50122. (WebInspector.ElementsPanel.prototype._documentUpdated):
  50123. (WebInspector.ElementsPanel.prototype.searchCanceled):
  50124. (WebInspector.ElementsPanel.prototype.performSearch):
  50125. (WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
  50126. (WebInspector.ElementsPanel.prototype._attributesUpdated):
  50127. (WebInspector.ElementsPanel.prototype._characterDataModified):
  50128. (WebInspector.ElementsPanel.prototype._nodeInserted):
  50129. (WebInspector.ElementsPanel.prototype._nodeRemoved):
  50130. (WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
  50131. (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  50132. 2011-03-14 Pavel Feldman <pfeldman@chromium.org>
  50133. Reviewed by Yury Semikhatsky.
  50134. Web Inspector: add tests for edit dom operations.
  50135. https://bugs.webkit.org/show_bug.cgi?id=56248
  50136. Test: inspector/elements/edit-dom-actions.html
  50137. * inspector/Inspector.idl:
  50138. * inspector/InspectorDOMAgent.cpp:
  50139. (WebCore::InspectorDOMAgent::assertNode):
  50140. (WebCore::InspectorDOMAgent::assertElement):
  50141. (WebCore::InspectorDOMAgent::assertHTMLElement):
  50142. (WebCore::InspectorDOMAgent::nodeToSelectOn):
  50143. (WebCore::InspectorDOMAgent::querySelector):
  50144. (WebCore::InspectorDOMAgent::querySelectorAll):
  50145. (WebCore::InspectorDOMAgent::setAttribute):
  50146. (WebCore::InspectorDOMAgent::removeAttribute):
  50147. (WebCore::InspectorDOMAgent::getOuterHTML):
  50148. (WebCore::InspectorDOMAgent::setOuterHTML):
  50149. * inspector/InspectorDOMAgent.h:
  50150. * inspector/front-end/DOMAgent.js:
  50151. (WebInspector.DOMNode.prototype.setAttribute):
  50152. (WebInspector.DOMNode.prototype.removeAttribute):
  50153. * inspector/front-end/inspector.js:
  50154. (WebInspector.startEditing.defaultFinishHandler):
  50155. 2011-03-14 Brady Eidson <beidson@apple.com>
  50156. Reviewed by Dan Bernstein.
  50157. <rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
  50158. Need WK2 API to view/manage origins with LocalStorage
  50159. * storage/StorageTracker.cpp:
  50160. (WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
  50161. before the StorageTracker thread can do it on the background thread.
  50162. 2011-03-13 Anton D'Auria <adauria@apple.com>
  50163. Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.
  50164. Fixed lock-taking order to prevent deadlock, added lock for m_client,
  50165. removed premature return in syncImportOriginIdentifiers when tracker
  50166. db does not exist because that prevented syncFileSystemAndTrackerDatabase()
  50167. from running until next LocalStorage db creation, cleaned up
  50168. StorageTracker::scheduleTask() code for readability.
  50169. https://bugs.webkit.org/show_bug.cgi?id=56285
  50170. * storage/StorageTracker.cpp:
  50171. (WebCore::StorageTracker::trackerDatabasePath):
  50172. (WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
  50173. optionally opened (as in the case when it doesn't exist on disk), don't
  50174. exit early and call syncFileSystemAndTrackerDatabase(), which will create
  50175. a tracker db if localstorage db files are found on disk by calling setOriginDetails.
  50176. (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
  50177. (WebCore::StorageTracker::setOriginDetails):
  50178. (WebCore::StorageTracker::scheduleTask): readability changes.
  50179. (WebCore::StorageTracker::syncSetOriginDetails):
  50180. (WebCore::StorageTracker::syncDeleteAllOrigins):
  50181. (WebCore::StorageTracker::syncDeleteOrigin):
  50182. (WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
  50183. (WebCore::StorageTracker::setClient):
  50184. * storage/StorageTracker.h:
  50185. 2011-03-13 Anton D'Auria <adauria@apple.com>
  50186. Reviewed and landed by Brady Eidson.
  50187. Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
  50188. https://bugs.webkit.org/show_bug.cgi?id=56240
  50189. This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.
  50190. * storage/StorageTracker.cpp:
  50191. (WebCore::StorageTracker::origins):
  50192. (WebCore::StorageTracker::deleteAllOrigins):
  50193. (WebCore::StorageTracker::deleteOrigin):
  50194. 2011-03-13 Pratik Solanki <psolanki@apple.com>
  50195. Reviewed by Dan Bernstein.
  50196. Make adjustMIMETypeIfNecessary use CFNetwork directly
  50197. https://bugs.webkit.org/show_bug.cgi?id=55912
  50198. Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.
  50199. * platform/network/mac/WebCoreURLResponse.mm:
  50200. (WebCore::adjustMIMETypeIfNecessary):
  50201. 2011-03-13 Dan Bernstein <mitz@apple.com>
  50202. Reviewed by Sam Weinig.
  50203. Include hyphenation information in text representation of render tree
  50204. https://bugs.webkit.org/show_bug.cgi?id=56287
  50205. (WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
  50206. string.
  50207. 2011-03-13 David Levin <levin@chromium.org>
  50208. Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
  50209. above addressing this FIXME.
  50210. * css/CSSStyleSelector.cpp:
  50211. (WebCore::CSSStyleSelector::applyProperty):
  50212. 2011-03-13 David Levin <levin@chromium.org>
  50213. Build fix adding remaining enum values to switch statement.
  50214. * css/CSSStyleSelector.cpp:
  50215. (WebCore::CSSStyleSelector::applyProperty):
  50216. 2011-03-13 Sam Weinig <sam@webkit.org>
  50217. Fix windows build.
  50218. * platform/network/cf/ResourceErrorCF.cpp:
  50219. (WebCore::ResourceError::ResourceError):
  50220. Add missing constructor.
  50221. 2011-03-13 David Sosby <dsosby@rim.com>
  50222. Reviewed by Dan Bernstein.
  50223. REGRESSION: Soft hyphen is not always rendered
  50224. https://bugs.webkit.org/show_bug.cgi?id=56017
  50225. The check to flag a text block as hyphenated was only
  50226. occurring at break points in the line. If no break points
  50227. were found after the soft hyphen then the line would not
  50228. be flagged hyphenated. Adding a check for soft hyphen at
  50229. the end of the text run resolves the issue.
  50230. Test: fast/text/soft-hyphen-4.html
  50231. * rendering/RenderBlockLineLayout.cpp:
  50232. (WebCore::RenderBlock::findNextLineBreak):
  50233. 2011-03-13 Dan Bernstein <mitz@apple.com>
  50234. Reviewed by Mark Rowe.
  50235. REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
  50236. https://bugs.webkit.org/show_bug.cgi?id=56280
  50237. * rendering/RenderBlockLineLayout.cpp:
  50238. (WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.
  50239. 2011-03-13 Sam Weinig <sam@webkit.org>
  50240. Reviewed by Anders Carlsson.
  50241. Add ability to create a WKErrorRef
  50242. <rdar://problem/9115768>
  50243. https://bugs.webkit.org/show_bug.cgi?id=56279
  50244. * WebCore.exp.in:
  50245. Add new exports.
  50246. * platform/network/cf/ResourceError.h:
  50247. * platform/network/cf/ResourceErrorCF.cpp:
  50248. (WebCore::ResourceError::platformCompare):
  50249. (WebCore::ResourceError::cfError):
  50250. (WebCore::ResourceError::operator CFErrorRef):
  50251. (WebCore::ResourceError::ResourceError):
  50252. (WebCore::ResourceError::cfStreamError):
  50253. (WebCore::ResourceError::operator CFStreamError):
  50254. * platform/network/mac/ResourceErrorMac.mm:
  50255. (WebCore::ResourceError::ResourceError):
  50256. (WebCore::ResourceError::platformCompare):
  50257. (WebCore::ResourceError::nsError):
  50258. (WebCore::ResourceError::operator NSError *):
  50259. (WebCore::ResourceError::cfError):
  50260. (WebCore::ResourceError::operator CFErrorRef):
  50261. Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
  50262. regardless of whether CFNetwork is being used.
  50263. 2011-03-13 Pratik Solanki <psolanki@apple.com>
  50264. Reviewed by Brady Eidson.
  50265. Make adjustMIMETypeIfNecessary use CFNetwork directly
  50266. https://bugs.webkit.org/show_bug.cgi?id=55912
  50267. Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
  50268. WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
  50269. identical.
  50270. Testing is covered by existing LayoutTests.
  50271. * WebCore.exp.in:
  50272. * platform/mac/WebCoreSystemInterface.h:
  50273. * platform/mac/WebCoreSystemInterface.mm:
  50274. * platform/network/mac/ResourceHandleMac.mm:
  50275. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  50276. * platform/network/mac/WebCoreURLResponse.h:
  50277. * platform/network/mac/WebCoreURLResponse.mm:
  50278. (WebCore::createBinaryExtensionsSet):
  50279. (WebCore::createExtensionToMIMETypeMap):
  50280. (WebCore::mimeTypeFromUTITree):
  50281. (WebCore::adjustMIMETypeIfNecessary):
  50282. 2011-03-13 Jeremy Moskovich <jeremy@chromium.org>
  50283. Reviewed by Dimitri Glazkov.
  50284. Update comment in CSSValueKeywords.in
  50285. https://bugs.webkit.org/show_bug.cgi?id=56266
  50286. The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
  50287. in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.
  50288. No tests - just updating a comment.
  50289. * css/CSSValueKeywords.in:
  50290. 2011-03-13 Anton D'Auria <adauria@apple.com>
  50291. Reviewed by Alice Liu.
  50292. StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
  50293. https://bugs.webkit.org/show_bug.cgi?id=56259
  50294. Move all StorageTracker initialization to
  50295. StorageTracker::initializeTracker. This also removes the
  50296. requirement that the StorageTracker constructor isn't run
  50297. on the main thread.
  50298. * storage/StorageTracker.cpp:
  50299. (WebCore::StorageTracker::initializeTracker):
  50300. (WebCore::StorageTracker::tracker):
  50301. (WebCore::StorageTracker::StorageTracker):
  50302. 2011-03-13 Rob Buis <rwlbuis@gmail.com>
  50303. Reviewed by Dave Hyatt.
  50304. REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
  50305. https://bugs.webkit.org/show_bug.cgi?id=53470
  50306. Prefer !important over normal properties when dealing with duplicate properties in style rules.
  50307. Test: fast/css/duplicate-property-in-rule-important.html
  50308. * css/CSSMutableStyleDeclaration.cpp:
  50309. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  50310. 2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
  50311. Unreviewed, rolling out r80895.
  50312. http://trac.webkit.org/changeset/80895
  50313. https://bugs.webkit.org/show_bug.cgi?id=56261
  50314. Causing crashes in several tests including
  50315. t1202-counters-16-c.html (see
  50316. http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
  50317. (Requested by dave_levin on #webkit).
  50318. * rendering/CounterNode.cpp:
  50319. (WebCore::CounterNode::CounterNode):
  50320. (WebCore::CounterNode::create):
  50321. (WebCore::CounterNode::resetRenderer):
  50322. (WebCore::CounterNode::resetRenderers):
  50323. (WebCore::CounterNode::recount):
  50324. (WebCore::CounterNode::insertAfter):
  50325. (WebCore::CounterNode::removeChild):
  50326. (WebCore::showTreeAndMark):
  50327. * rendering/CounterNode.h:
  50328. (WebCore::CounterNode::renderer):
  50329. * rendering/RenderCounter.cpp:
  50330. (WebCore::findPlaceForCounter):
  50331. (WebCore::RenderCounter::~RenderCounter):
  50332. (WebCore::RenderCounter::originalText):
  50333. (WebCore::RenderCounter::invalidate):
  50334. (WebCore::destroyCounterNodeWithoutMapRemoval):
  50335. (WebCore::RenderCounter::destroyCounterNodes):
  50336. (WebCore::RenderCounter::destroyCounterNode):
  50337. (WebCore::updateCounters):
  50338. (showCounterRendererTree):
  50339. * rendering/RenderCounter.h:
  50340. * rendering/RenderObjectChildList.cpp:
  50341. (WebCore::invalidateCountersInContainer):
  50342. (WebCore::RenderObjectChildList::invalidateCounters):
  50343. * rendering/RenderObjectChildList.h:
  50344. 2011-03-12 Darin Adler <darin@apple.com>
  50345. Reviewed by Dan Bernstein.
  50346. REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
  50347. https://bugs.webkit.org/show_bug.cgi?id=56258
  50348. No tests because the wrong hashing is mostly harmless. The only symptom
  50349. we have seen is an occasional assertion in debug builds about the size
  50350. not being a multiple of two. But a worse hash is worse for performance too.
  50351. * platform/cf/BinaryPropertyList.cpp:
  50352. (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
  50353. than the number of array entries.
  50354. 2011-03-12 Cameron Zwarich <zwarich@apple.com>
  50355. Not reviewed.
  50356. Fix the build with newer GCCs and remove some extra whitespae.
  50357. * bindings/js/SerializedScriptValue.cpp:
  50358. (WebCore::uint8_t):
  50359. 2011-03-12 Cameron Zwarich <zwarich@apple.com>
  50360. Rubber-stamped by Oliver Hunt.
  50361. Removed unused ARMv5 code. The ARMv5 case now falls under the general
  50362. unaligned accessed case.
  50363. * bindings/js/SerializedScriptValue.cpp:
  50364. (WebCore::CloneDeserializer::readLittleEndian):
  50365. (WebCore::CloneDeserializer::readString):
  50366. 2011-03-12 Cameron Zwarich <zwarich@apple.com>
  50367. Reviewed by Oliver Hunt.
  50368. WebCore fails to build with Clang on ARM
  50369. https://bugs.webkit.org/show_bug.cgi?id=56257
  50370. Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
  50371. namespace scope, since explicit specializations are not allowed at class scope.
  50372. * bindings/js/SerializedScriptValue.cpp:
  50373. (WebCore::writeLittleEndian):
  50374. 2011-03-11 Darin Adler <darin@apple.com>
  50375. Reviewed by Sam Weinig.
  50376. Dragging image to desktop gives webloc instead of image file in WebKit2
  50377. https://bugs.webkit.org/show_bug.cgi?id=56193
  50378. * WebCore.exp.in: Added some additional exports. Re-sorted.
  50379. 2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
  50380. Unreviewed, rolling out r80919.
  50381. http://trac.webkit.org/changeset/80919
  50382. https://bugs.webkit.org/show_bug.cgi?id=56251
  50383. all windows bots failed to compile this change (Requested by
  50384. loislo on #webkit).
  50385. * bridge/c/c_class.cpp:
  50386. * bridge/c/c_runtime.cpp:
  50387. * bridge/jni/JavaMethod.cpp:
  50388. * plugins/PluginViewNone.cpp:
  50389. 2011-03-12 Patrick Gansterer <paroga@webkit.org>
  50390. Unreviewed WinCE build fix for r80900.
  50391. * CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
  50392. 2011-03-12 Andras Becsi <abecsi@webkit.org>
  50393. Unreviewed typo fix.
  50394. No new tests needed.
  50395. * WebCore.pro: Fix typo in header name.
  50396. 2011-03-12 Pavel Feldman <pfeldman@chromium.org>
  50397. Not reviewed: Inspect Element action regression fix.
  50398. * inspector/front-end/inspector.js:
  50399. (WebInspector.inspect):
  50400. 2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
  50401. Unreviewed. One line fix for inspector/dom-breakpoints.html
  50402. * inspector/front-end/BreakpointManager.js:
  50403. (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
  50404. 2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
  50405. Unreviewed build fix.
  50406. Almost all inspector tests are crashing after r80928.
  50407. * inspector/front-end/inspector.js:
  50408. 2011-03-11 Pavel Feldman <pfeldman@chromium.org>
  50409. Reviewed by Yury Semikhatsky.
  50410. Web Inspector: follow up to error reporting, fixing multiple regressions.
  50411. https://bugs.webkit.org/show_bug.cgi?id=56243
  50412. * inspector/InjectedScript.cpp:
  50413. (WebCore::InjectedScript::setPropertyValue):
  50414. * inspector/InjectedScript.h:
  50415. * inspector/Inspector.idl:
  50416. * inspector/InspectorDOMAgent.cpp:
  50417. (WebCore::InspectorDOMAgent::getChildNodes):
  50418. (WebCore::InspectorDOMAgent::getOuterHTML):
  50419. (WebCore::InspectorDOMAgent::getEventListenersForNode):
  50420. * inspector/InspectorDOMAgent.h:
  50421. * inspector/InspectorRuntimeAgent.cpp:
  50422. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  50423. * inspector/InspectorRuntimeAgent.h:
  50424. * inspector/front-end/DOMAgent.js:
  50425. (WebInspector.DOMNode.prototype.setNodeName):
  50426. (WebInspector.DOMNode.prototype.setNodeValue):
  50427. (WebInspector.DOMNode.prototype.getChildNodes):
  50428. (WebInspector.DOMNode.prototype.getOuterHTML):
  50429. (WebInspector.DOMNode.prototype.setOuterHTML):
  50430. (WebInspector.DOMNode.prototype.removeNode):
  50431. (WebInspector.DOMNode.prototype.copyNode):
  50432. (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
  50433. (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
  50434. (WebInspector.EventListeners.getEventListenersForNode):
  50435. * inspector/front-end/DOMStorage.js:
  50436. (WebInspector.DOMStorage.prototype.getEntries):
  50437. (WebInspector.DOMStorage.prototype.setItem):
  50438. (WebInspector.DOMStorage.prototype.removeItem):
  50439. * inspector/front-end/DOMStorageItemsView.js:
  50440. (WebInspector.DOMStorageItemsView.prototype.update):
  50441. (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
  50442. * inspector/front-end/ElementsTreeOutline.js:
  50443. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  50444. (WebInspector.ElementsTreeElement.prototype.updateChildren):
  50445. ():
  50446. * inspector/front-end/EventListenersSidebarPane.js:
  50447. (WebInspector.EventListenersSidebarPane.prototype.update.callback):
  50448. (WebInspector.EventListenersSidebarPane.prototype.update):
  50449. * inspector/front-end/ObjectPropertiesSection.js:
  50450. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
  50451. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  50452. * inspector/front-end/PropertiesSidebarPane.js:
  50453. (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  50454. * inspector/front-end/RemoteObject.js:
  50455. (WebInspector.RemoteObject.prototype.setPropertyValue):
  50456. (WebInspector.RemoteObject.prototype.evaluate):
  50457. * inspector/front-end/inspector.js:
  50458. 2011-03-12 Jer Noble <jer.noble@apple.com>
  50459. Unreviewed build fix.
  50460. Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
  50461. checks.
  50462. * dom/Document.cpp:
  50463. (WebCore::Document::webkitWillEnterFullScreenForElement):
  50464. (WebCore::Document::webkitDidEnterFullScreenForElement):
  50465. (WebCore::Document::webkitWillExitFullScreenForElement):
  50466. (WebCore::Document::webkitDidExitFullScreenForElement):
  50467. 2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
  50468. Unreviewed build fix.
  50469. [EFL] Fix build break because of several reason.
  50470. https://bugs.webkit.org/show_bug.cgi?id=56244
  50471. * CMakeLists.txt: Add missing files.
  50472. * platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
  50473. 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
  50474. Reviewed by Pavel Feldman.
  50475. Web Inspector: move profiler related methods from inspector agent to profiler agent
  50476. https://bugs.webkit.org/show_bug.cgi?id=56204
  50477. * inspector/Inspector.idl:
  50478. * inspector/InspectorAgent.cpp:
  50479. (WebCore::InspectorAgent::InspectorAgent):
  50480. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  50481. (WebCore::InspectorAgent::setFrontend):
  50482. (WebCore::InspectorAgent::disconnectFrontend):
  50483. (WebCore::InspectorAgent::populateScriptObjects):
  50484. (WebCore::InspectorAgent::showProfilesPanel):
  50485. * inspector/InspectorAgent.h:
  50486. * inspector/InspectorController.cpp:
  50487. (WebCore::InspectorController::enableProfiler):
  50488. (WebCore::InspectorController::disableProfiler):
  50489. (WebCore::InspectorController::profilerEnabled):
  50490. (WebCore::InspectorController::startUserInitiatedProfiling):
  50491. (WebCore::InspectorController::stopUserInitiatedProfiling):
  50492. (WebCore::InspectorController::isRecordingUserInitiatedProfile):
  50493. * inspector/InspectorInstrumentation.cpp:
  50494. (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  50495. * inspector/InspectorProfilerAgent.cpp:
  50496. (WebCore::InspectorProfilerAgent::create):
  50497. (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
  50498. (WebCore::InspectorProfilerAgent::enable):
  50499. (WebCore::InspectorProfilerAgent::disable):
  50500. (WebCore::InspectorProfilerAgent::setFrontend):
  50501. (WebCore::InspectorProfilerAgent::clearFrontend):
  50502. (WebCore::InspectorProfilerAgent::restore):
  50503. (WebCore::InspectorProfilerAgent::restoreEnablement):
  50504. (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  50505. (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  50506. * inspector/InspectorProfilerAgent.h:
  50507. (WebCore::InspectorProfilerAgent::start):
  50508. (WebCore::InspectorProfilerAgent::stop):
  50509. * inspector/front-end/ProfileView.js:
  50510. (WebInspector.CPUProfileType.prototype.buttonClicked):
  50511. * inspector/front-end/ProfilesPanel.js:
  50512. (WebInspector.ProfilesPanel):
  50513. (WebInspector.ProfilesPanel.prototype._registerProfileType):
  50514. (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  50515. * inspector/front-end/inspector.js:
  50516. (WebInspector._createPanels):
  50517. 2011-03-11 Jer Noble <jer.noble@apple.com>
  50518. Reviewed by Anders Carlsson.
  50519. WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
  50520. https://bugs.webkit.org/show_bug.cgi?id=56226
  50521. * dom/Document.cpp:
  50522. (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
  50523. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
  50524. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
  50525. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
  50526. (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
  50527. 2011-03-11 Jer Noble <jer.noble@apple.com>
  50528. Reviewed by Anders Carlsson.
  50529. Create new interface stubs to support full screen mode in WebKit2.
  50530. WebKit2: Plumb new full screen animation APIs through WebKit2.
  50531. https://bugs.webkit.org/show_bug.cgi?id=55993
  50532. * page/ChromeClient.h:
  50533. (WebCore::ChromeClient::setRootFullScreenLayer): Added.
  50534. 2011-03-11 Oliver Hunt <oliver@apple.com>
  50535. Reviewed by Gavin Barraclough.
  50536. Ensure all values are correctly tagged in the registerfile
  50537. https://bugs.webkit.org/show_bug.cgi?id=56214
  50538. Make sure everything builds still.
  50539. * bridge/c/c_class.cpp:
  50540. * bridge/c/c_runtime.cpp:
  50541. * bridge/jni/JavaMethod.cpp:
  50542. * plugins/PluginViewNone.cpp:
  50543. 2011-03-11 Mark Rowe <mrowe@apple.com>
  50544. Fix the 32-bit build.
  50545. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  50546. (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
  50547. 2011-03-11 Mark Rowe <mrowe@apple.com>
  50548. Rubber-stamped by Eric Carlsson.
  50549. <rdar://problem/9124537> Crashes during layout tests due to overrelease of AVFoundation objects.
  50550. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
  50551. (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
  50552. (WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
  50553. 2011-03-11 Chris Marrin <cmarrin@apple.com>
  50554. Unreviewed.
  50555. Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468
  50556. * platform/graphics/ca/GraphicsLayerCA.cpp:
  50557. (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
  50558. 2011-03-11 Brady Eidson <beidson@apple.com>
  50559. Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
  50560. * loader/icon/IconDatabase.h: Make this guy public.
  50561. 2011-03-11 Brady Eidson <beidson@apple.com>
  50562. Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
  50563. * loader/icon/IconDatabase.h:
  50564. (WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?
  50565. 2011-03-11 Brady Eidson <beidson@apple.com>
  50566. https://bugs.webkit.org/show_bug.cgi?id=56216
  50567. Fix the Qt build following the same pattern of the patch.
  50568. * loader/icon/IconDatabase.h:
  50569. * loader/icon/IconDatabaseBase.cpp:
  50570. (WebCore::IconDatabaseBase::databasePath): Added to the virtual base.
  50571. * loader/icon/IconDatabaseBase.h:
  50572. (WebCore::IconDatabaseBase::isOpen): Ditto.
  50573. 2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>
  50574. Reviewed by Alexey Proskuryakov.
  50575. https://bugs.webkit.org/show_bug.cgi?id=56198
  50576. Fix conditional which had an int for one case and a pointer for another.
  50577. No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
  50578. * loader/appcache/ApplicationCacheGroup.cpp:
  50579. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
  50580. 2011-03-11 Brady Eidson <beidson@apple.com>
  50581. Windows build fix.
  50582. * history/HistoryItem.cpp:
  50583. * loader/icon/IconDatabaseBase.cpp:
  50584. 2011-03-11 Brady Eidson <beidson@apple.com>
  50585. Reviewed by Sam Weinig.
  50586. <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
  50587. Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
  50588. Project file stuff:
  50589. * Android.mk:
  50590. * CMakeLists.txt:
  50591. * GNUmakefile.am:
  50592. * WebCore.gyp/WebCore.gyp:
  50593. * WebCore.gypi:
  50594. * WebCore.pro:
  50595. * WebCore.xcodeproj/project.pbxproj:
  50596. * WebCore.vcproj/WebCore.vcproj:
  50597. * loader/icon/IconDatabase.cpp:
  50598. * loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
  50599. * loader/icon/IconDatabaseBase.cpp: Added.
  50600. (WebCore::IconDatabaseBase::iconURLForPageURL):
  50601. (WebCore::iconDatabase):
  50602. (WebCore::setGlobalIconDatabase):
  50603. * loader/icon/IconDatabaseBase.h: Added.
  50604. (WebCore::IconDatabaseBase::IconDatabaseBase):
  50605. (WebCore::IconDatabaseBase::~IconDatabaseBase):
  50606. (WebCore::IconDatabaseBase::setEnabled):
  50607. (WebCore::IconDatabaseBase::isEnabled):
  50608. (WebCore::IconDatabaseBase::defaultIcon):
  50609. (WebCore::IconDatabaseBase::retainIconForPageURL):
  50610. (WebCore::IconDatabaseBase::releaseIconForPageURL):
  50611. (WebCore::IconDatabaseBase::iconForPageURL):
  50612. (WebCore::IconDatabaseBase::setIconURLForPageURL):
  50613. (WebCore::IconDatabaseBase::setIconDataForIconURL):
  50614. (WebCore::IconDatabaseBase::iconDataKnownForIconURL):
  50615. (WebCore::IconDatabaseBase::loadDecisionForIconURL):
  50616. (WebCore::IconDatabaseBase::pageURLMappingCount):
  50617. (WebCore::IconDatabaseBase::retainedPageURLCount):
  50618. (WebCore::IconDatabaseBase::iconRecordCount):
  50619. (WebCore::IconDatabaseBase::iconRecordCountWithData):
  50620. (WebCore::IconDatabaseBase::importIconURLForPageURL):
  50621. (WebCore::IconDatabaseBase::importIconDataForIconURL):
  50622. (WebCore::IconDatabaseBase::shouldStopThreadActivity):
  50623. (WebCore::IconDatabaseBase::open):
  50624. (WebCore::IconDatabaseBase::close):
  50625. (WebCore::IconDatabaseBase::removeAllIcons):
  50626. (WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
  50627. (WebCore::IconDatabaseBase::setClient):
  50628. * loader/icon/IconDatabaseNone.cpp: Removed.
  50629. 2011-03-11 Brady Eidson <beidson@apple.com>
  50630. Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878
  50631. * page/PageGroup.h: Declare this method, even if the definition will end up being empty.
  50632. 2011-03-11 Michael Nordman <michaeln@google.com>
  50633. Reviewed by Dmitry Titov.
  50634. Adding the '~' to the dtor (duh).
  50635. No new tests.
  50636. * storage/SQLCallbackWrapper.h:
  50637. (WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
  50638. 2011-03-11 Carol Szabo <carol.szabo@nokia.com>
  50639. Reviewed by David Hyatt.
  50640. Introduced double linkage between a CounterNode and its display renderer.
  50641. use of freed pointer in WebCore::RenderCounter::originalText()
  50642. https://bugs.webkit.org/show_bug.cgi?id=56065
  50643. No new tests. This bug could only be reproduced manually by
  50644. refreshing the page during load at a critical point.
  50645. See bug attachment for testing.
  50646. * rendering/CounterNode.cpp:
  50647. Introduced new member "m_owner" to store the renderer that has the
  50648. style directives that produce the CounterNode.
  50649. Repurposed m_renderer to reffer to the RenderCounter that shows the
  50650. CounterNode.
  50651. (WebCore::CounterNode::CounterNode):
  50652. Updated member initialization.
  50653. (WebCore::CounterNode::create):
  50654. (WebCore::CounterNode::resetRenderer):
  50655. (WebCore::CounterNode::resetRenderers):
  50656. (WebCore::CounterNode::recount):
  50657. (WebCore::CounterNode::removeChild):
  50658. (WebCore::CounterNode::insertAfter):
  50659. No functional changes.
  50660. (WebCore::showTreeAndMark):
  50661. Added flushing to ensure that the output is complete.
  50662. * rendering/CounterNode.h:
  50663. (WebCore::CounterNode::owner):
  50664. Renamed from renderer()
  50665. (WebCore::CounterNode::renderer):
  50666. (WebCore::CounterNode::setRenderer):
  50667. Added new accessors for the display renderer.
  50668. * rendering/RenderCounter.cpp:
  50669. (WebCore::findPlaceForCounter):
  50670. Fixed comments. No functional changes.
  50671. (WebCore::RenderCounter::~RenderCounter):
  50672. Made sure that the CounterNode that this renderers displays is
  50673. detached from this.
  50674. (WebCore::RenderCounter::originalText):
  50675. (WebCore::RenderCounter::invalidate):
  50676. Added code to update m_renderer on the displayed CounterNode.
  50677. (WebCore::destroyCounterNodeWithoutMapRemoval):
  50678. (WebCore::RenderCounter::destroyCounterNodes):
  50679. (WebCore::RenderCounter::destroyCounterNode):
  50680. (WebCore::updateCounters):
  50681. No change, just kept code in line with the changes above.
  50682. (showCounterRendererTree):
  50683. Added fflush to ensure complete display.
  50684. * rendering/RenderCounter.h:
  50685. * rendering/RenderObjectChildList.cpp:
  50686. * rendering/RenderObjectChildList.h:
  50687. Removed unneeded invalidateCounters related functions.
  50688. 2011-03-11 Luke Macpherson <macpherson@chromium.org>
  50689. Reviewed by Eric Seidel.
  50690. Introduce lookup-table based approach for applying CSS properties.
  50691. The aim is to be a starting point for refactoring
  50692. CSSStyleSelector::applyProperty() into more readable, maintainable code.
  50693. https://bugs.webkit.org/show_bug.cgi?id=54707
  50694. No new behavior / covered by existing tests.
  50695. * css/CSSStyleApplyProperty.cpp: Added.
  50696. (WebCore::ApplyPropertyNull):
  50697. Class that provides empty implementations of inherit, initial, value.
  50698. (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
  50699. Class that calls the appropriate RenderStyle setters directly.
  50700. (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
  50701. Class for handling CSSProperty*Color.
  50702. (WebCore::ApplyPropertyColor::ApplyPropertyColor):
  50703. Class for handling CSSPropertyColor.
  50704. (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
  50705. Singleton initializer.
  50706. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  50707. Constructor that bulds up the map from property id to apply-er objects.
  50708. * css/CSSStyleApplyProperty.h: Added.
  50709. (WebCore::CSSStyleApplyProperty::inherit):
  50710. Handle the inherit case for a given property.
  50711. (WebCore::CSSStyleApplyProperty::initial):
  50712. Handle the initial case for a given property.
  50713. (WebCore::CSSStyleApplyProperty::value):
  50714. Apply a value to a given property.
  50715. (WebCore::CSSStyleApplyProperty::implements):
  50716. Returns true if the provided property id is implemented.
  50717. (WebCore::CSSStyleApplyProperty::index):
  50718. Private function to determine the index of a property the property map.
  50719. (WebCore::CSSStyleApplyProperty::valid):
  50720. Function to determine that a given property id is valid.
  50721. (WebCore::CSSStyleApplyProperty::setPropertyValue):
  50722. (WebCore::CSSStyleApplyProperty::propertyValue):
  50723. * css/CSSStyleSelector.cpp:
  50724. (WebCore::CSSStyleSelector::CSSStyleSelector):
  50725. Get reference to the CSSStyleApplyProperty singleton.
  50726. (WebCore::CSSStyleSelector::applyProperty):
  50727. Now calls into CSSStyleApplyProperty for implemented property ids.
  50728. Deleted color-related methods from the property id switch.
  50729. * css/CSSStyleSelector.h:
  50730. (WebCore::CSSStyleSelector::style):
  50731. Made public to allow access from CSSStyleApplyProperty.
  50732. (WebCore::CSSStyleSelector::parentStyle):
  50733. Made public to allow access from CSSStyleApplyProperty.
  50734. * rendering/style/RenderStyle.h:
  50735. Made CSSStyleApplyProperty a friend class. Necessary because it needs
  50736. to access the private getters and setters on this clsass.
  50737. 2011-03-11 Anton D'Auria <adauria@apple.com>
  50738. Reviewed and landed by Brady Eidson.
  50739. Add WebKit1 API to view and delete local storage
  50740. https://bugs.webkit.org/show_bug.cgi?id=51878
  50741. Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
  50742. StorageTracker maintains its own database of origin identifiers and backing db paths,
  50743. and this allows it to contain more relational data in the future, like variable quotas per origin.
  50744. On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
  50745. an origin entry when StorageAreaSync performs a first sync for an origin.
  50746. All StorageTracker file operations are performed on one background thread with a task queue.
  50747. Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
  50748. storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
  50749. storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
  50750. storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
  50751. storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html
  50752. * GNUmakefile.am:
  50753. * WebCore.exp.in:
  50754. * WebCore.gypi:
  50755. * WebCore.pro:
  50756. * WebCore.vcproj/WebCore.vcproj:
  50757. * WebCore.xcodeproj/project.pbxproj:
  50758. * page/PageGroup.cpp:
  50759. (WebCore::PageGroup::clearLocalStorageForAllOrigins):
  50760. (WebCore::PageGroup::clearLocalStorageForOrigin):
  50761. (WebCore::PageGroup::syncLocalStorage):
  50762. (WebCore::PageGroup::numberOfPageGroups):
  50763. * page/PageGroup.h:
  50764. * platform/chromium/FileSystemChromium.cpp:
  50765. (WebCore::listDirectory):
  50766. * platform/posix/FileSystemPOSIX.cpp:
  50767. (WebCore::listDirectory):
  50768. * storage/LocalStorageTask.cpp:
  50769. (WebCore::LocalStorageTask::LocalStorageTask):
  50770. (WebCore::LocalStorageTask::performTask):
  50771. * storage/LocalStorageTask.h:
  50772. (WebCore::LocalStorageTask::createOriginIdentifiersImport):
  50773. (WebCore::LocalStorageTask::createSetOriginDetails):
  50774. (WebCore::LocalStorageTask::createDeleteOrigin):
  50775. (WebCore::LocalStorageTask::createDeleteAllOrigins):
  50776. * storage/StorageAreaImpl.cpp:
  50777. (WebCore::StorageAreaImpl::clearForOriginDeletion):
  50778. (WebCore::StorageAreaImpl::sync):
  50779. * storage/StorageAreaImpl.h:
  50780. * storage/StorageAreaSync.cpp:
  50781. (WebCore::StorageAreaSync::scheduleCloseDatabase):
  50782. (WebCore::StorageAreaSync::openDatabase):
  50783. (WebCore::StorageAreaSync::sync):
  50784. (WebCore::StorageAreaSync::deleteEmptyDatabase):
  50785. (WebCore::StorageAreaSync::scheduleSync):
  50786. * storage/StorageAreaSync.h:
  50787. * storage/StorageNamespace.h:
  50788. * storage/StorageNamespaceImpl.cpp:
  50789. (WebCore::StorageNamespaceImpl::clearOriginForDeletion):
  50790. (WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
  50791. (WebCore::StorageNamespaceImpl::sync):
  50792. * storage/StorageNamespaceImpl.h:
  50793. * storage/StorageTracker.cpp: Added.
  50794. (WebCore::StorageTracker::initializeTracker):
  50795. (WebCore::StorageTracker::tracker):
  50796. (WebCore::StorageTracker::StorageTracker):
  50797. (WebCore::StorageTracker::setStorageDirectoryPath):
  50798. (WebCore::StorageTracker::trackerDatabasePath):
  50799. (WebCore::StorageTracker::openTrackerDatabase):
  50800. (WebCore::StorageTracker::importOriginIdentifiers):
  50801. (WebCore::StorageTracker::syncImportOriginIdentifiers):
  50802. (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
  50803. (WebCore::StorageTracker::setOriginDetails):
  50804. (WebCore::StorageTracker::scheduleTask):
  50805. (WebCore::StorageTracker::syncSetOriginDetails):
  50806. (WebCore::StorageTracker::origins):
  50807. (WebCore::StorageTracker::deleteAllOrigins):
  50808. (WebCore::StorageTracker::syncDeleteAllOrigins):
  50809. (WebCore::StorageTracker::deleteOrigin):
  50810. (WebCore::StorageTracker::syncDeleteOrigin):
  50811. (WebCore::StorageTracker::willDeleteAllOrigins):
  50812. (WebCore::StorageTracker::willDeleteOrigin):
  50813. (WebCore::StorageTracker::canDeleteOrigin):
  50814. (WebCore::StorageTracker::cancelDeletingOrigin):
  50815. (WebCore::StorageTracker::setClient):
  50816. (WebCore::StorageTracker::syncLocalStorage):
  50817. * storage/StorageTracker.h: Added.
  50818. * storage/StorageTrackerClient.h: Added.
  50819. (WebCore::StorageTrackerClient::~StorageTrackerClient):
  50820. 2011-03-11 Steve Block <steveblock@google.com>
  50821. Reviewed by Jeremy Orlow.
  50822. JavaMethod does not correctly check for a null jstring for the method name
  50823. https://bugs.webkit.org/show_bug.cgi?id=56187
  50824. No new tests, simple typo fix.
  50825. * bridge/jni/JavaMethod.cpp:
  50826. (JavaMethod::JavaMethod):
  50827. 2011-03-11 Adrienne Walker <enne@google.com>
  50828. Reviewed by James Robinson.
  50829. [chromium] Compositor uses too much texture memory for scrollbars
  50830. https://bugs.webkit.org/show_bug.cgi?id=56212
  50831. Compositor invalidations can be off the page (and very large), but
  50832. scrollbars only need to care about the invalidation that's visible.
  50833. The large invalidation was causing the tiler layer size to grow
  50834. needlessly larger than the scrollbar.
  50835. * platform/graphics/chromium/LayerRendererChromium.cpp:
  50836. (WebCore::LayerRendererChromium::invalidateRootLayerRect):
  50837. 2011-03-11 David Hyatt <hyatt@apple.com>
  50838. Reviewed by Simon Fraser.
  50839. https://bugs.webkit.org/show_bug.cgi?id=52987
  50840. REGRESSION: Overflowing columns not repainted correctly
  50841. Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not
  50842. sufficient, since blocks paint their own columns.
  50843. Added fast/multicol/scrolling-overflow.html
  50844. * rendering/RenderBlock.cpp:
  50845. (WebCore::RenderBlock::addOverflowFromChildren):
  50846. 2011-03-11 Matthew Delaney <mdelaney@apple.com>
  50847. Reviewed by Simon Fraser.
  50848. Set canvasUsesAcceleratedDrawing setting to be off(false) by default
  50849. https://bugs.webkit.org/show_bug.cgi?id=56215
  50850. No new tests. Does not affect behavior. Just keeping the setting off by default.
  50851. * page/Settings.cpp:
  50852. (WebCore::Settings::Settings):
  50853. 2011-03-11 Andy Estes <aestes@apple.com>
  50854. Reviewed by David Hyatt.
  50855. Table cells with dynamically added percentage height descendants do not
  50856. grow in size if the table has already been laid out.
  50857. https://bugs.webkit.org/show_bug.cgi?id=56174
  50858. Table cells ignore their specified size and collapse to fit their
  50859. children. When a descendent with percentage height is present before
  50860. the table is first laid out, the descendent is sized based on the
  50861. specified size of the table cell. However, when the child isn't present
  50862. when the table is first laid out, the table cell ignores its specified
  50863. size and collapses down to 0. Then, when the child div is added in a
  50864. separate run loop iteration, it is sized to be 100% of the collapsed
  50865. cell height instead of 100% of the cell's specified height. We should
  50866. not get different layouts depending on the timing of tree construction.
  50867. Fix this by clearing intrinsic padding before calculating the table
  50868. cell's override height when we detect a child that should flex the
  50869. table cell.
  50870. Test: fast/table/dynamic-descendant-percentage-height.html
  50871. * rendering/RenderTableCell.cpp:
  50872. (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear
  50873. intrinsic padding before setting the override size.
  50874. * rendering/RenderTableCell.h:
  50875. * rendering/RenderTableSection.cpp:
  50876. (WebCore::RenderTableSection::layoutRows): Call
  50877. setOverrideSizeFromRowHeight() instead of setOverrideSize().
  50878. 2011-03-11 Michael Nordman <michaeln@google.com>
  50879. Reviewed by David Levin.
  50880. Add SQLCallbackWrapper
  50881. Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
  50882. which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
  50883. https://bugs.webkit.org/show_bug.cgi?id=55919
  50884. No new tests, existing tests apply.
  50885. * GNUmakefile.am:
  50886. * WebCore.gypi:
  50887. * WebCore.pro:
  50888. * WebCore.vcproj/WebCore.vcproj:
  50889. * WebCore.xcodeproj/project.pbxproj:
  50890. * storage/SQLCallbackWrapper.h: Added.
  50891. (WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
  50892. (WebCore::SQLCallbackWrapper::clear):
  50893. (WebCore::SQLCallbackWrapper::unwrap):
  50894. (WebCore::SQLCallbackWrapper::hasCallback):
  50895. (WebCore::SQLCallbackWrapper::safeRelease):
  50896. * storage/SQLStatement.cpp:
  50897. (WebCore::SQLStatement::create):
  50898. (WebCore::SQLStatement::SQLStatement):
  50899. (WebCore::SQLStatement::performCallback):
  50900. * storage/SQLStatement.h:
  50901. (WebCore::SQLStatement::hasStatementCallback):
  50902. (WebCore::SQLStatement::hasStatementErrorCallback):
  50903. * storage/SQLTransaction.cpp:
  50904. (WebCore::SQLTransaction::SQLTransaction):
  50905. (WebCore::SQLTransaction::executeSQL):
  50906. (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
  50907. (WebCore::SQLTransaction::deliverTransactionCallback):
  50908. (WebCore::SQLTransaction::deliverStatementCallback):
  50909. (WebCore::SQLTransaction::postflightAndCommit):
  50910. (WebCore::SQLTransaction::deliverSuccessCallback):
  50911. (WebCore::SQLTransaction::handleTransactionError):
  50912. (WebCore::SQLTransaction::deliverTransactionErrorCallback):
  50913. * storage/SQLTransaction.h:
  50914. 2011-03-11 Eric Carlson <eric.carlson@apple.com>
  50915. Reviewed by Sam Weinig.
  50916. <rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
  50917. No new tests, existing media tests cover this.
  50918. * WebCore.xcodeproj/project.pbxproj:
  50919. * platform/graphics/MediaPlayer.cpp:
  50920. (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC.
  50921. (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace.
  50922. (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
  50923. (WebCore::MediaPlayer::inMediaDocument): Ditto.
  50924. * platform/graphics/MediaPlayer.h:
  50925. * platform/graphics/avfoundation: Added.
  50926. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
  50927. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
  50928. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
  50929. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.
  50930. 2011-03-11 Dean Jackson <dino@apple.com>
  50931. Reviewed by Simon Fraser.
  50932. https://bugs.webkit.org/show_bug.cgi?id=56205
  50933. m_restrictions needs to allow multiple values (a bitfield)
  50934. HTMLMediaElement::m_restrictions needs to hold multiple values, so
  50935. change BehaviorRestrictions to an unsigned typedef and rename the
  50936. existing enum BehaviorRestrictionFlags.
  50937. * html/HTMLMediaElement.h:
  50938. (WebCore::HTMLMediaElement::setBehaviorRestrictions):
  50939. 2011-03-11 David Hyatt <hyatt@apple.com>
  50940. Reviewed by Dan Bernstein.
  50941. https://bugs.webkit.org/show_bug.cgi?id=47206
  50942. Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
  50943. properly constructed.
  50944. Added fast/css-generated-content/table-row-before-after.html
  50945. * rendering/RenderTableRow.cpp:
  50946. (WebCore::RenderTableRow::styleDidChange):
  50947. * rendering/RenderTableRow.h:
  50948. 2011-03-11 James Robinson <jamesr@chromium.org>
  50949. Reviewed by Kenneth Russell.
  50950. [chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
  50951. https://bugs.webkit.org/show_bug.cgi?id=56209
  50952. This matches the behavior prior to r80482. No test since the only changes in
  50953. behavior are avoiding work on invisible layers, which is unobservable,
  50954. and fixing a crash due to bug 56153.
  50955. * platform/graphics/chromium/LayerRendererChromium.cpp:
  50956. (WebCore::LayerRendererChromium::updateContentsRecursive):
  50957. 2011-03-11 David Hyatt <hyatt@apple.com>
  50958. Reviewed by Simon Fraser.
  50959. https://bugs.webkit.org/show_bug.cgi?id=47159
  50960. CSS2.1 failures in background position parsing.
  50961. Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid
  50962. when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
  50963. it to understand what the first component was.
  50964. For individual property parsing using background-position-x/y, I added new functions that just handle that without
  50965. worrying about the other component.
  50966. In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple
  50967. backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers
  50968. has been changed to always consider a layer empty if it has no image set, even if other properties are set.
  50969. A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position
  50970. parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style
  50971. should actually include the additional values when no image is set though, so that should perhaps be the subject of a
  50972. follow-up bug.
  50973. Added fast/backgrounds/background-position-parsing.html
  50974. * css/CSSParser.cpp:
  50975. (WebCore::CSSParser::parseFillPositionX):
  50976. (WebCore::CSSParser::parseFillPositionY):
  50977. (WebCore::CSSParser::parseFillPositionComponent):
  50978. (WebCore::CSSParser::parseFillPosition):
  50979. (WebCore::CSSParser::parseFillProperty):
  50980. (WebCore::CSSParser::parseTransformOrigin):
  50981. (WebCore::CSSParser::parsePerspectiveOrigin):
  50982. * css/CSSParser.h:
  50983. * rendering/style/FillLayer.cpp:
  50984. (WebCore::FillLayer::fillUnsetProperties):
  50985. (WebCore::FillLayer::cullEmptyLayers):
  50986. 2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>
  50987. Reviewed by James Robinson.
  50988. [chromium] Allow large layers with non-identity transforms to be drawn
  50989. as long as their visible portion is smaller than the largest supported
  50990. texture size. This code will soon be replaced by tiled layers.
  50991. https://bugs.webkit.org/show_bug.cgi?id=55984
  50992. Test: platform/chromium/compositing/huge-layer-rotated.html
  50993. * platform/graphics/chromium/ContentLayerChromium.cpp:
  50994. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  50995. (WebCore::ContentLayerChromium::draw):
  50996. * platform/graphics/chromium/ContentLayerChromium.h:
  50997. 2011-03-09 Chris Marrin <cmarrin@apple.com>
  50998. Reviewed by Adam Roben.
  50999. REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
  51000. https://bugs.webkit.org/show_bug.cgi?id=52468
  51001. Added WIN32 to the ifdef controlling whether animations are applied in normal or
  51002. reverse order. On Mac, animations used to be applied in reverse, but
  51003. <rdar://problem/7095638> fixed this in the release after Snow Leopard.
  51004. But that patch has not be applied to the Safari Windows SDK yet. For now
  51005. I've made Windows use the reverse order logig. <rdar://problem/9112233> is
  51006. tracking the inclusion of the patch on Windows.
  51007. * platform/graphics/ca/GraphicsLayerCA.cpp:
  51008. (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
  51009. 2011-03-11 Tony Gentilcore <tonyg@chromium.org>
  51010. Reviewed by Eric Seidel.
  51011. Let the parser yield for layout before running scripts
  51012. https://bugs.webkit.org/show_bug.cgi?id=54355
  51013. Prior to this patch, the parser would yield to perform a layout/paint before running a
  51014. script only if the script or a stylesheet blocking the script is not loaded yet. Since we
  51015. don't preload scan into the body while parsing the head, typically we'll block on a script
  51016. early in the body that causes us to yield to do the first paint within a reasonable time.
  51017. However, I'm planning to change the PreloadScanner to scan into the body from the head.
  51018. That significantly improves overall load time, but would hurt first paint time because
  51019. fewer scripts would be blocked during parsing and thus wouldn't yield.
  51020. This change causes us to yield before running scripts if we haven't painted yet (regardless
  51021. of whether or not the script is loaded). In addition to allowing the above mentioned
  51022. PreloadScanner change to be implemented without regressing first paint time, this also
  51023. improves first paint time by itself.
  51024. I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
  51025. bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
  51026. 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
  51027. signifcant change in page load time.
  51028. Within the pages tested, 33 had no statistically significant change in time to first paint,
  51029. 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
  51030. are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
  51031. * html/parser/HTMLDocumentParser.cpp:
  51032. (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
  51033. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
  51034. means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
  51035. the right thing whether we are just before a token or waiting for a script. Now that we may
  51036. yield before a token or before a script, this may be called while paused.
  51037. * html/parser/HTMLParserScheduler.cpp:
  51038. (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  51039. * page/FrameView.h:
  51040. (WebCore::FrameView::hasEverPainted): Added.
  51041. 2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
  51042. Fix crashes in dom/html/level2/html/HTMLInputElement*.
  51043. * css/CSSStyleSelector.cpp:
  51044. (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,
  51045. because e can certainly be a null.
  51046. 2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
  51047. Reviewed by David Hyatt.
  51048. Choke text-decoration when entering shadow DOM subtree.
  51049. https://bugs.webkit.org/show_bug.cgi?id=56044
  51050. No new tests, because the functionality can't be tested yet.
  51051. * css/CSSStyleSelector.cpp:
  51052. (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
  51053. 2011-03-08 Dimitri Glazkov <dglazkov@chromium.org>
  51054. Reviewed by Eric Carlson.
  51055. Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
  51056. https://bugs.webkit.org/show_bug.cgi?id=55972
  51057. Instead of poking at the time display elements all the way from RenderMedia,
  51058. let the standard layout cycle take care of things. Move the logic of calculating
  51059. when to collapse the time display elements into a custom renderer, since
  51060. this is not something that can be accomplished with CSS.
  51061. Also, the logic of keeping the timeline slider at least 100px needed refreshing,
  51062. since it didn't actually keep it at 100px.
  51063. * html/shadow/MediaControls.cpp: Moved the logic of determining visibility
  51064. of time display elements to RenderMediaControlTimeDisplay, eliminating
  51065. updateTimeDisplayVisibility method.
  51066. * html/shadow/MediaControls.h: Removed decl.
  51067. * rendering/MediaControlElements.cpp:
  51068. (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
  51069. Added new renderer class.
  51070. (WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
  51071. size-sensing logic, still using hard-coded values.
  51072. (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
  51073. Removed m_isVisible member, which is no longer necessary.
  51074. (WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
  51075. return the new renderer.
  51076. * rendering/MediaControlElements.h: Adjusted decls.
  51077. * rendering/RenderMedia.cpp:
  51078. (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
  51079. media controls in layout.
  51080. 2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
  51081. Reviewed by Eric Carlson.
  51082. Start focusing updates to media controls, away from always updating everything.
  51083. https://bugs.webkit.org/show_bug.cgi?id=56038
  51084. For now, the new methods just call generic MediaControls::update.
  51085. Covered by existing tests.
  51086. * html/HTMLMediaElement.cpp:
  51087. (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
  51088. (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
  51089. (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
  51090. (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
  51091. accessor.
  51092. (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
  51093. MediaControls::changedClosedCaptionsVisibility.
  51094. (WebCore::HTMLMediaElement::mediaControls): Added.
  51095. (WebCore::HTMLMediaElement::hasMediaControls): Added.
  51096. * html/HTMLMediaElement.h: Added decls.
  51097. * html/shadow/MediaControls.cpp:
  51098. (WebCore::MediaControls::reset): Added.
  51099. (WebCore::MediaControls::changedMute): Added.
  51100. (WebCore::MediaControls::changedVolume): Added.
  51101. (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
  51102. * html/shadow/MediaControls.h: Added decls.
  51103. 2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
  51104. Reviewed by Martin Robinson.
  51105. [GStreamer] When seeking webKitWebSrcStop release the frame but should not.
  51106. https://bugs.webkit.org/show_bug.cgi?id=55703
  51107. When calling webKitWebSrcStop in case of a seeking, the frame should not
  51108. be reset (the source hasn't change). The frame may be used to get the network
  51109. context. Some network stack (like Qt) are relaying on the network context
  51110. to work.
  51111. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  51112. (webKitWebSrcStop):
  51113. 2011-03-11 Dean Jackson <dino@apple.com>
  51114. Unreviewed.
  51115. Build fixes for GTK and Leopard.
  51116. * bindings/gobject/GNUmakefile.am:
  51117. - add missing WebKitAnimation* generated bindings
  51118. * page/WebKitAnimation.idl:
  51119. - use double in place of float (the core values are double anyway)
  51120. 2011-03-11 Dean Jackson <dino@apple.com>
  51121. Unreviewed build fix for QT.
  51122. * WebCore.pro:
  51123. 2011-03-11 Dean Jackson <dino@apple.com>
  51124. Reviewed by Simon Fraser and Chris Marrin.
  51125. https://bugs.webkit.org/show_bug.cgi?id=54151
  51126. Implement an API to play/pause/scrub animations
  51127. This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
  51128. APIs, exposed via Element.getWebKitAnimations(). This first pass
  51129. is a read-only API - a subsequent commit will add the ability
  51130. to scrub animations.
  51131. Test: animations/animation-api-1.html
  51132. * Android.derived.jscbindings.mk:
  51133. * Android.derived.v8bindings.mk:
  51134. * Android.mk:
  51135. * Android.v8bindings.mk:
  51136. * CMakeLists.txt:
  51137. * CodeGenerators.pri:
  51138. * DerivedSources.cpp:
  51139. * DerivedSources.make:
  51140. * GNUmakefile.am:
  51141. * WebCore.gypi:
  51142. * WebCore.pro:
  51143. * WebCore.vcproj/WebCore.vcproj:
  51144. * WebCore.xcodeproj/project.pbxproj:
  51145. - All build settings updated for new files
  51146. * bindings/js/JSBindingsAllInOne.cpp:
  51147. - Include new custom files
  51148. * bindings/js/JSWebKitAnimationCustom.cpp: Added.
  51149. (WebCore::JSWebKitAnimation::iterationCount):
  51150. - Custom property getter so that we can return INFINITY
  51151. * bindings/js/JSWebKitAnimationListCustom.cpp: Added.
  51152. (WebCore::JSWebKitAnimationList::markChildren):
  51153. - Make sure WebKitAnimations are marked
  51154. * bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
  51155. (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
  51156. - Custom property getter so that we can return INFINITY
  51157. * dom/Element.cpp:
  51158. (WebCore::Element::webkitGetAnimations):
  51159. * dom/Element.h:
  51160. * dom/Element.idl:
  51161. - New API entry point
  51162. * page/DOMWindow.idl:
  51163. - Constructor definitions for WebKitAnimation and WebKitAnimationList
  51164. * page/animation/AnimationBase.cpp:
  51165. (WebCore::AnimationBase::~AnimationBase):
  51166. - Since AnimationBase can now live longer (if a WebKitAnimation is
  51167. held in Javascript) we need to guard for the renderer having disappeared.
  51168. (WebCore::AnimationBase::setElapsedTime):
  51169. (WebCore::AnimationBase::play):
  51170. (WebCore::AnimationBase::pause):
  51171. - Stub implementations at present
  51172. * page/animation/AnimationBase.h:
  51173. (WebCore::AnimationBase::animation):
  51174. - Expose the Animation properties
  51175. * page/animation/AnimationController.cpp:
  51176. (WebCore::AnimationControllerPrivate::animationsForRenderer):
  51177. (WebCore::AnimationController::animationsForRenderer):
  51178. - Builds the list of WebKitAnimations
  51179. * page/animation/AnimationController.h:
  51180. * page/animation/AnimationControllerPrivate.h:
  51181. * page/animation/CompositeAnimation.cpp:
  51182. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  51183. - Make sure we clear the renderer if we are removing the animation
  51184. (WebCore::CompositeAnimation::animations):
  51185. * page/animation/CompositeAnimation.h:
  51186. * page/WebKitAnimation.cpp: Added.
  51187. (WebCore::WebKitAnimation::WebKitAnimation):
  51188. (WebCore::WebKitAnimation::name):
  51189. (WebCore::WebKitAnimation::duration):
  51190. (WebCore::WebKitAnimation::elapsedTime):
  51191. (WebCore::WebKitAnimation::setElapsedTime):
  51192. (WebCore::WebKitAnimation::delay):
  51193. (WebCore::WebKitAnimation::iterationCount):
  51194. (WebCore::WebKitAnimation::paused):
  51195. (WebCore::WebKitAnimation::ended):
  51196. (WebCore::WebKitAnimation::direction):
  51197. (WebCore::WebKitAnimation::fillMode):
  51198. (WebCore::WebKitAnimation::pause):
  51199. (WebCore::WebKitAnimation::play):
  51200. - The implementation of the new API. All the read-only parts are
  51201. done, but elapsedTime, play() and pause() are stubs.
  51202. * page/WebKitAnimation.h: Added.
  51203. (WebCore::WebKitAnimation::create):
  51204. (WebCore::WebKitAnimation::~WebKitAnimation):
  51205. * page/WebKitAnimation.idl: Added.
  51206. * page/WebKitAnimationList.cpp: Added.
  51207. * page/WebKitAnimationList.h: Added.
  51208. * page/WebKitAnimationList.idl: Added.
  51209. - Copies NodeList implementation
  51210. 2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>
  51211. Reviewed by Yury Semikhatsky.
  51212. Web Inspector: introduce error argument for all the callbacks on frontend.
  51213. https://bugs.webkit.org/show_bug.cgi?id=56100
  51214. * inspector/CodeGeneratorInspector.pm:
  51215. * inspector/front-end/AuditRules.js:
  51216. (WebInspector.AuditRules.evaluateInTargetWindow):
  51217. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
  51218. (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  51219. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  51220. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  51221. * inspector/front-end/CSSStyleModel.js:
  51222. (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  51223. (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
  51224. (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
  51225. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  51226. (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
  51227. (WebInspector.CSSStyleModel.prototype.addRule):
  51228. (WebInspector.CSSStyleModel.prototype.addRule.callback):
  51229. (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
  51230. (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  51231. (WebInspector.CSSStyleModel.prototype._onRevert):
  51232. (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
  51233. (WebInspector.CSSProperty.prototype.setText.callback):
  51234. (WebInspector.CSSProperty.prototype.setText):
  51235. (WebInspector.CSSProperty.prototype.setDisabled.callback):
  51236. (WebInspector.CSSProperty.prototype.setDisabled):
  51237. (WebInspector.CSSStyleSheet.createForId):
  51238. (WebInspector.CSSStyleSheet.prototype.setText):
  51239. * inspector/front-end/ConsoleView.js:
  51240. (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
  51241. * inspector/front-end/DOMAgent.js:
  51242. (WebInspector.DOMNode.prototype.setNodeName):
  51243. (WebInspector.DOMNode.prototype.setNodeValue):
  51244. (WebInspector.DOMNode.prototype.setAttribute):
  51245. (WebInspector.DOMNode.prototype.removeAttribute):
  51246. (WebInspector.DOMNode.prototype.childNodes.mycallback):
  51247. (WebInspector.DOMNode.prototype.childNodes):
  51248. (WebInspector.DOMNode.prototype.outerHTML):
  51249. (WebInspector.DOMNode.prototype.setOuterHTML):
  51250. (WebInspector.DOMNode.prototype.removeNode):
  51251. (WebInspector.DOMNode.prototype.copyNode):
  51252. (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
  51253. (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
  51254. (WebInspector.DOMAgent.prototype._documentUpdated):
  51255. (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
  51256. (WebInspector.Cookies.getCookiesAsync):
  51257. (WebInspector.EventListeners.getEventListenersForNodeAsync):
  51258. * inspector/front-end/DOMStorage.js:
  51259. (WebInspector.DOMStorage.prototype.getEntries):
  51260. (WebInspector.DOMStorage.prototype.setItem):
  51261. (WebInspector.DOMStorage.prototype.removeItem):
  51262. * inspector/front-end/Database.js:
  51263. (WebInspector.Database.prototype.getTableNames):
  51264. (WebInspector.Database.prototype.executeSql):
  51265. * inspector/front-end/DebuggerModel.js:
  51266. (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
  51267. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  51268. (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
  51269. (WebInspector.DebuggerModel.prototype.editScriptSource):
  51270. * inspector/front-end/ElementsPanel.js:
  51271. (WebInspector.ElementsPanel.prototype._setSearchingForNode):
  51272. * inspector/front-end/ElementsTreeOutline.js:
  51273. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
  51274. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  51275. (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
  51276. (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
  51277. ():
  51278. * inspector/front-end/ExtensionPanel.js:
  51279. (WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate):
  51280. * inspector/front-end/ExtensionServer.js:
  51281. (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  51282. * inspector/front-end/NetworkManager.js:
  51283. (WebInspector.NetworkManager.prototype.requestContent):
  51284. (WebInspector.NetworkManager.prototype._processCachedResources):
  51285. * inspector/front-end/ProfileView.js:
  51286. (WebInspector.CPUProfileView.profileCallback):
  51287. (WebInspector.CPUProfileView):
  51288. * inspector/front-end/ProfilesPanel.js:
  51289. * inspector/front-end/RemoteObject.js:
  51290. (WebInspector.RemoteObject.resolveNode):
  51291. (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder):
  51292. (WebInspector.RemoteObject.prototype.getProperties):
  51293. (WebInspector.RemoteObject.prototype.setPropertyValue):
  51294. (WebInspector.RemoteObject.prototype.evaluate):
  51295. * inspector/front-end/Script.js:
  51296. (WebInspector.Script.prototype.requestSource.didGetScriptSource):
  51297. (WebInspector.Script.prototype.requestSource):
  51298. * inspector/front-end/ScriptsPanel.js:
  51299. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
  51300. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  51301. (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  51302. * inspector/front-end/inspector.js:
  51303. ():
  51304. (WebInspector.doLoadedDone.onPopulateScriptObjects):
  51305. (WebInspector.doLoadedDone.propertyNamesCallback):
  51306. (WebInspector.doLoadedDone):
  51307. 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
  51308. Reviewed by Pavel Feldman.
  51309. Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
  51310. https://bugs.webkit.org/show_bug.cgi?id=56173
  51311. Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
  51312. * CMakeLists.txt:
  51313. * GNUmakefile.am:
  51314. * WebCore.gypi:
  51315. * WebCore.pro:
  51316. * WebCore.vcproj/WebCore.vcproj:
  51317. * WebCore.xcodeproj/project.pbxproj:
  51318. * bindings/js/JSInjectedScriptHostCustom.cpp:
  51319. * bindings/js/JSInjectedScriptManager.cpp: Added.
  51320. (WebCore::InjectedScriptManager::createInjectedScript):
  51321. (WebCore::InjectedScriptManager::discardInjectedScript):
  51322. (WebCore::InjectedScriptManager::injectedScriptFor):
  51323. (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  51324. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  51325. * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
  51326. (WebCore::WeakReferenceCallback):
  51327. (WebCore::createInjectedScriptHostV8Wrapper):
  51328. (WebCore::InjectedScriptManager::createInjectedScript):
  51329. (WebCore::InjectedScriptManager::discardInjectedScript):
  51330. (WebCore::InjectedScriptManager::injectedScriptFor):
  51331. (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  51332. * inspector/ConsoleMessage.cpp:
  51333. (WebCore::ConsoleMessage::addToFrontend):
  51334. * inspector/ConsoleMessage.h:
  51335. * inspector/InjectedScript.cpp:
  51336. (WebCore::InjectedScript::canAccessInspectedWindow):
  51337. * inspector/InjectedScript.h:
  51338. * inspector/InjectedScriptHost.cpp:
  51339. (WebCore::InjectedScriptHost::create):
  51340. (WebCore::InjectedScriptHost::InjectedScriptHost):
  51341. (WebCore::InjectedScriptHost::~InjectedScriptHost):
  51342. (WebCore::InjectedScriptHost::disconnect):
  51343. (WebCore::InjectedScriptHost::inspectImpl):
  51344. (WebCore::InjectedScriptHost::clearConsoleMessages):
  51345. (WebCore::InjectedScriptHost::databaseIdImpl):
  51346. (WebCore::InjectedScriptHost::storageIdImpl):
  51347. * inspector/InjectedScriptHost.h:
  51348. (WebCore::InjectedScriptHost::init):
  51349. (WebCore::InjectedScriptHost::setFrontend):
  51350. (WebCore::InjectedScriptHost::clearFrontend):
  51351. * inspector/InjectedScriptManager.cpp: Added.
  51352. (WebCore::InjectedScriptManager::create):
  51353. (WebCore::InjectedScriptManager::InjectedScriptManager):
  51354. (WebCore::InjectedScriptManager::~InjectedScriptManager):
  51355. (WebCore::InjectedScriptManager::disconnect):
  51356. (WebCore::InjectedScriptManager::injectedScriptHost):
  51357. (WebCore::InjectedScriptManager::injectedScriptForId):
  51358. (WebCore::InjectedScriptManager::injectedScriptForObjectId):
  51359. (WebCore::InjectedScriptManager::discardInjectedScripts):
  51360. (WebCore::InjectedScriptManager::releaseObjectGroup):
  51361. (WebCore::InjectedScriptManager::injectedScriptSource):
  51362. (WebCore::InjectedScriptManager::injectScript):
  51363. * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  51364. * inspector/Inspector.idl:
  51365. * inspector/InspectorAgent.cpp:
  51366. (WebCore::InspectorAgent::InspectorAgent):
  51367. (WebCore::InspectorAgent::inspectedPageDestroyed):
  51368. (WebCore::InspectorAgent::focusNode):
  51369. (WebCore::InspectorAgent::didClearWindowObjectInWorld):
  51370. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  51371. (WebCore::InspectorAgent::didCommitLoad):
  51372. (WebCore::InspectorAgent::domContentLoadedEventFired):
  51373. * inspector/InspectorAgent.h:
  51374. * inspector/InspectorBrowserDebuggerAgent.cpp:
  51375. * inspector/InspectorConsoleAgent.cpp:
  51376. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
  51377. (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
  51378. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  51379. (WebCore::InspectorConsoleAgent::addInspectedNode):
  51380. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  51381. (WebCore::InspectorConsoleAgent::addConsoleMessage):
  51382. * inspector/InspectorConsoleAgent.h:
  51383. * inspector/InspectorController.cpp:
  51384. (WebCore::InspectorController::InspectorController):
  51385. (WebCore::InspectorController::connectFrontend):
  51386. (WebCore::InspectorController::disconnectFrontend):
  51387. * inspector/InspectorController.h:
  51388. * inspector/InspectorDOMAgent.cpp:
  51389. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  51390. (WebCore::InspectorDOMAgent::discardBindings):
  51391. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  51392. (WebCore::InspectorDOMAgent::resolveNode):
  51393. * inspector/InspectorDOMAgent.h:
  51394. (WebCore::InspectorDOMAgent::create):
  51395. * inspector/InspectorDebuggerAgent.cpp:
  51396. (WebCore::InspectorDebuggerAgent::create):
  51397. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  51398. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  51399. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  51400. * inspector/InspectorDebuggerAgent.h:
  51401. * inspector/InspectorRuntimeAgent.cpp:
  51402. (WebCore::InspectorRuntimeAgent::create):
  51403. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
  51404. (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
  51405. (WebCore::InspectorRuntimeAgent::evaluate):
  51406. (WebCore::InspectorRuntimeAgent::evaluateOn):
  51407. (WebCore::InspectorRuntimeAgent::getProperties):
  51408. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  51409. (WebCore::InspectorRuntimeAgent::releaseObject):
  51410. (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  51411. * inspector/InspectorRuntimeAgent.h:
  51412. * inspector/front-end/ElementsPanel.js:
  51413. (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
  51414. (WebInspector.ElementsPanel):
  51415. 2011-03-11 Anton Muhin <antonm@chromium.org>
  51416. Reviewed by Adam Barth.
  51417. [v8] Change the way group id for CSS objects is calculated
  51418. https://bugs.webkit.org/show_bug.cgi?id=56117
  51419. Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
  51420. as they should not be reachable in JavaScript.
  51421. Covered by existing layout tests. Fact of absence of retention is not trivial to prove.
  51422. * bindings/v8/V8GCController.cpp:
  51423. (WebCore::calculateGroupId):
  51424. (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
  51425. 2011-03-11 Alexander Pavlov <apavlov@chromium.org>
  51426. Reviewed by Yury Semikhatsky.
  51427. Web Inspector: hover over elements in Elements panel does not highlight nodes
  51428. https://bugs.webkit.org/show_bug.cgi?id=56121
  51429. In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
  51430. is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
  51431. for these 16px when computing the test point coordinates.
  51432. * inspector/front-end/ElementsTreeOutline.js:
  51433. (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
  51434. 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
  51435. Unreviewed. Roll out r80837.
  51436. * CMakeLists.txt:
  51437. * GNUmakefile.am:
  51438. * WebCore.gypi:
  51439. * WebCore.pro:
  51440. * WebCore.vcproj/WebCore.vcproj:
  51441. * WebCore.xcodeproj/project.pbxproj:
  51442. * bindings/js/JSInjectedScriptHostCustom.cpp:
  51443. (WebCore::InjectedScriptHost::createInjectedScript):
  51444. (WebCore::InjectedScriptHost::discardInjectedScript):
  51445. (WebCore::InjectedScriptHost::injectedScriptFor):
  51446. (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  51447. * bindings/js/JSInjectedScriptManager.cpp: Removed.
  51448. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  51449. (WebCore::WeakReferenceCallback):
  51450. (WebCore::createInjectedScriptHostV8Wrapper):
  51451. (WebCore::InjectedScriptHost::createInjectedScript):
  51452. (WebCore::InjectedScriptHost::discardInjectedScript):
  51453. (WebCore::InjectedScriptHost::injectedScriptFor):
  51454. (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  51455. * bindings/v8/custom/V8InjectedScriptManager.cpp: Removed.
  51456. * inspector/ConsoleMessage.cpp:
  51457. (WebCore::ConsoleMessage::addToFrontend):
  51458. * inspector/ConsoleMessage.h:
  51459. * inspector/InjectedScript.cpp:
  51460. (WebCore::InjectedScript::canAccessInspectedWindow):
  51461. * inspector/InjectedScript.h:
  51462. * inspector/InjectedScriptHost.cpp:
  51463. (WebCore::InjectedScriptHost::InjectedScriptHost):
  51464. (WebCore::InjectedScriptHost::~InjectedScriptHost):
  51465. (WebCore::InjectedScriptHost::inspectImpl):
  51466. (WebCore::InjectedScriptHost::clearConsoleMessages):
  51467. (WebCore::InjectedScriptHost::databaseIdImpl):
  51468. (WebCore::InjectedScriptHost::storageIdImpl):
  51469. (WebCore::InjectedScriptHost::injectedScriptForId):
  51470. (WebCore::InjectedScriptHost::injectedScriptForObjectId):
  51471. (WebCore::InjectedScriptHost::injectedScriptForMainFrame):
  51472. (WebCore::InjectedScriptHost::discardInjectedScripts):
  51473. (WebCore::InjectedScriptHost::releaseObjectGroup):
  51474. (WebCore::InjectedScriptHost::frontend):
  51475. (WebCore::InjectedScriptHost::injectedScriptSource):
  51476. (WebCore::InjectedScriptHost::injectScript):
  51477. * inspector/InjectedScriptHost.h:
  51478. (WebCore::InjectedScriptHost::create):
  51479. (WebCore::InjectedScriptHost::inspectorAgent):
  51480. (WebCore::InjectedScriptHost::disconnectController):
  51481. * inspector/InjectedScriptManager.cpp: Removed.
  51482. * inspector/InjectedScriptManager.h: Removed.
  51483. * inspector/Inspector.idl:
  51484. * inspector/InspectorAgent.cpp:
  51485. (WebCore::InspectorAgent::InspectorAgent):
  51486. (WebCore::InspectorAgent::inspectedPageDestroyed):
  51487. (WebCore::InspectorAgent::focusNode):
  51488. (WebCore::InspectorAgent::didClearWindowObjectInWorld):
  51489. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  51490. (WebCore::InspectorAgent::didCommitLoad):
  51491. (WebCore::InspectorAgent::domContentLoadedEventFired):
  51492. * inspector/InspectorAgent.h:
  51493. (WebCore::InspectorAgent::injectedScriptHost):
  51494. * inspector/InspectorBrowserDebuggerAgent.cpp:
  51495. * inspector/InspectorConsoleAgent.cpp:
  51496. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
  51497. (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
  51498. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  51499. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  51500. (WebCore::InspectorConsoleAgent::addConsoleMessage):
  51501. * inspector/InspectorConsoleAgent.h:
  51502. * inspector/InspectorController.cpp:
  51503. (WebCore::InspectorController::InspectorController):
  51504. (WebCore::InspectorController::connectFrontend):
  51505. (WebCore::InspectorController::disconnectFrontend):
  51506. * inspector/InspectorController.h:
  51507. * inspector/InspectorDOMAgent.cpp:
  51508. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  51509. (WebCore::InspectorDOMAgent::discardBindings):
  51510. (WebCore::InspectorDOMAgent::addInspectedNode):
  51511. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  51512. (WebCore::InspectorDOMAgent::resolveNode):
  51513. * inspector/InspectorDOMAgent.h:
  51514. (WebCore::InspectorDOMAgent::create):
  51515. * inspector/InspectorDebuggerAgent.cpp:
  51516. (WebCore::InspectorDebuggerAgent::create):
  51517. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  51518. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  51519. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  51520. * inspector/InspectorDebuggerAgent.h:
  51521. * inspector/InspectorRuntimeAgent.cpp:
  51522. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
  51523. (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
  51524. (WebCore::InspectorRuntimeAgent::evaluate):
  51525. (WebCore::InspectorRuntimeAgent::evaluateOn):
  51526. (WebCore::InspectorRuntimeAgent::getProperties):
  51527. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  51528. (WebCore::InspectorRuntimeAgent::releaseObject):
  51529. (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  51530. * inspector/InspectorRuntimeAgent.h:
  51531. (WebCore::InspectorRuntimeAgent::create):
  51532. * inspector/front-end/ElementsPanel.js:
  51533. (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
  51534. (WebInspector.ElementsPanel):
  51535. 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
  51536. Reviewed by Pavel Feldman.
  51537. Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
  51538. https://bugs.webkit.org/show_bug.cgi?id=56173
  51539. Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
  51540. * CMakeLists.txt:
  51541. * GNUmakefile.am:
  51542. * WebCore.gypi:
  51543. * WebCore.pro:
  51544. * WebCore.vcproj/WebCore.vcproj:
  51545. * WebCore.xcodeproj/project.pbxproj:
  51546. * bindings/js/JSInjectedScriptHostCustom.cpp:
  51547. * bindings/js/JSInjectedScriptManager.cpp: Added.
  51548. (WebCore::InjectedScriptManager::createInjectedScript):
  51549. (WebCore::InjectedScriptManager::discardInjectedScript):
  51550. (WebCore::InjectedScriptManager::injectedScriptFor):
  51551. (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  51552. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  51553. * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
  51554. (WebCore::WeakReferenceCallback):
  51555. (WebCore::createInjectedScriptHostV8Wrapper):
  51556. (WebCore::InjectedScriptManager::createInjectedScript):
  51557. (WebCore::InjectedScriptManager::discardInjectedScript):
  51558. (WebCore::InjectedScriptManager::injectedScriptFor):
  51559. (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  51560. * inspector/ConsoleMessage.cpp:
  51561. (WebCore::ConsoleMessage::addToFrontend):
  51562. * inspector/ConsoleMessage.h:
  51563. * inspector/InjectedScript.cpp:
  51564. (WebCore::InjectedScript::canAccessInspectedWindow):
  51565. * inspector/InjectedScript.h:
  51566. * inspector/InjectedScriptHost.cpp:
  51567. (WebCore::InjectedScriptHost::create):
  51568. (WebCore::InjectedScriptHost::InjectedScriptHost):
  51569. (WebCore::InjectedScriptHost::~InjectedScriptHost):
  51570. (WebCore::InjectedScriptHost::disconnect):
  51571. (WebCore::InjectedScriptHost::inspectImpl):
  51572. (WebCore::InjectedScriptHost::clearConsoleMessages):
  51573. (WebCore::InjectedScriptHost::databaseIdImpl):
  51574. (WebCore::InjectedScriptHost::storageIdImpl):
  51575. * inspector/InjectedScriptHost.h:
  51576. (WebCore::InjectedScriptHost::init):
  51577. (WebCore::InjectedScriptHost::setFrontend):
  51578. (WebCore::InjectedScriptHost::clearFrontend):
  51579. * inspector/InjectedScriptManager.cpp: Added.
  51580. (WebCore::InjectedScriptManager::create):
  51581. (WebCore::InjectedScriptManager::InjectedScriptManager):
  51582. (WebCore::InjectedScriptManager::~InjectedScriptManager):
  51583. (WebCore::InjectedScriptManager::disconnect):
  51584. (WebCore::InjectedScriptManager::injectedScriptHost):
  51585. (WebCore::InjectedScriptManager::injectedScriptForId):
  51586. (WebCore::InjectedScriptManager::injectedScriptForObjectId):
  51587. (WebCore::InjectedScriptManager::discardInjectedScripts):
  51588. (WebCore::InjectedScriptManager::releaseObjectGroup):
  51589. (WebCore::InjectedScriptManager::injectedScriptSource):
  51590. (WebCore::InjectedScriptManager::injectScript):
  51591. * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  51592. * inspector/Inspector.idl:
  51593. * inspector/InspectorAgent.cpp:
  51594. (WebCore::InspectorAgent::InspectorAgent):
  51595. (WebCore::InspectorAgent::inspectedPageDestroyed):
  51596. (WebCore::InspectorAgent::focusNode):
  51597. (WebCore::InspectorAgent::didClearWindowObjectInWorld):
  51598. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  51599. (WebCore::InspectorAgent::didCommitLoad):
  51600. (WebCore::InspectorAgent::domContentLoadedEventFired):
  51601. * inspector/InspectorAgent.h:
  51602. * inspector/InspectorBrowserDebuggerAgent.cpp:
  51603. * inspector/InspectorConsoleAgent.cpp:
  51604. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
  51605. (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
  51606. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  51607. (WebCore::InspectorConsoleAgent::addInspectedNode):
  51608. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  51609. (WebCore::InspectorConsoleAgent::addConsoleMessage):
  51610. * inspector/InspectorConsoleAgent.h:
  51611. * inspector/InspectorController.cpp:
  51612. (WebCore::InspectorController::InspectorController):
  51613. (WebCore::InspectorController::connectFrontend):
  51614. (WebCore::InspectorController::disconnectFrontend):
  51615. * inspector/InspectorController.h:
  51616. * inspector/InspectorDOMAgent.cpp:
  51617. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  51618. (WebCore::InspectorDOMAgent::discardBindings):
  51619. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  51620. (WebCore::InspectorDOMAgent::resolveNode):
  51621. * inspector/InspectorDOMAgent.h:
  51622. (WebCore::InspectorDOMAgent::create):
  51623. * inspector/InspectorDebuggerAgent.cpp:
  51624. (WebCore::InspectorDebuggerAgent::create):
  51625. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  51626. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  51627. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  51628. * inspector/InspectorDebuggerAgent.h:
  51629. * inspector/InspectorRuntimeAgent.cpp:
  51630. (WebCore::InspectorRuntimeAgent::create):
  51631. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
  51632. (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
  51633. (WebCore::InspectorRuntimeAgent::evaluate):
  51634. (WebCore::InspectorRuntimeAgent::evaluateOn):
  51635. (WebCore::InspectorRuntimeAgent::getProperties):
  51636. (WebCore::InspectorRuntimeAgent::setPropertyValue):
  51637. (WebCore::InspectorRuntimeAgent::releaseObject):
  51638. (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  51639. * inspector/InspectorRuntimeAgent.h:
  51640. * inspector/front-end/ElementsPanel.js:
  51641. (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
  51642. (WebInspector.ElementsPanel):
  51643. 2011-03-09 Hans Wennborg <hans@chromium.org>
  51644. Reviewed by Jeremy Orlow.
  51645. IndexedDB: Make IDBBackingStore abstract
  51646. https://bugs.webkit.org/show_bug.cgi?id=56013
  51647. Make IDBBackingStore abstract to allow for multiple implementations.
  51648. Move the SQLite implementation to IDBSQLiteBackingStore.
  51649. No new tests: refactoring only.
  51650. * WebCore.gypi:
  51651. * storage/IDBBackingStore.h:
  51652. (WebCore::IDBBackingStore::~IDBBackingStore):
  51653. * storage/IDBFactoryBackendImpl.cpp:
  51654. (WebCore::IDBFactoryBackendImpl::open):
  51655. * storage/IDBSQLiteBackingStore.cpp:
  51656. (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
  51657. (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
  51658. (WebCore::runCommands):
  51659. (WebCore::createTables):
  51660. (WebCore::createMetaDataTable):
  51661. (WebCore::getDatabaseSchemaVersion):
  51662. (WebCore::migrateDatabase):
  51663. (WebCore::IDBSQLiteBackingStore::open):
  51664. (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
  51665. (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
  51666. (WebCore::IDBSQLiteBackingStore::getObjectStores):
  51667. (WebCore::IDBSQLiteBackingStore::createObjectStore):
  51668. (WebCore::doDelete):
  51669. (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
  51670. (WebCore::whereSyntaxForKey):
  51671. (WebCore::bindKeyToQuery):
  51672. (WebCore::lowerCursorWhereFragment):
  51673. (WebCore::upperCursorWhereFragment):
  51674. (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
  51675. (WebCore::bindKeyToQueryWithNulls):
  51676. (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
  51677. (WebCore::IDBSQLiteBackingStore::clearObjectStore):
  51678. (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
  51679. (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
  51680. (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
  51681. (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
  51682. (WebCore::IDBSQLiteBackingStore::getIndexes):
  51683. (WebCore::IDBSQLiteBackingStore::createIndex):
  51684. (WebCore::IDBSQLiteBackingStore::deleteIndex):
  51685. (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
  51686. (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
  51687. (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
  51688. (WebCore::keyFromQuery):
  51689. (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
  51690. (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
  51691. (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
  51692. (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
  51693. (WebCore::IDBSQLiteBackingStore::openIndexCursor):
  51694. (WebCore::IDBSQLiteBackingStore::createTransaction):
  51695. * storage/IDBSQLiteBackingStore.h: Added.
  51696. 2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  51697. Unreviewed build error fix.
  51698. [EFL] Fix build break when SHARED_CORE is ON
  51699. https://bugs.webkit.org/show_bug.cgi?id=56155
  51700. * platform/efl/ContextMenuEfl.cpp:
  51701. (WebCore::ContextMenu::ContextMenu):
  51702. * platform/efl/ContextMenuItemEfl.cpp:
  51703. (WebCore::ContextMenuItem::nativeMenuItem):
  51704. (WebCore::ContextMenuItem::ContextMenuItem):
  51705. (WebCore::ContextMenuItem::~ContextMenuItem):
  51706. 2011-03-11 Andrey Kosyakov <caseq@chromium.org>
  51707. Reviewed by Pavel Feldman.
  51708. Web Inspector: resource load cancellation is reported to console as an error
  51709. https://bugs.webkit.org/show_bug.cgi?id=55764
  51710. - mark interruptionForPolicyChangeError as cancellation
  51711. - do not log resource cancelation as an error
  51712. - always push resource to front-end before console message, so front-end can use resource info while formatting message.
  51713. * inspector/InspectorConsoleAgent.cpp:
  51714. (WebCore::InspectorConsoleAgent::didFailLoading):
  51715. * inspector/InspectorInstrumentation.cpp:
  51716. (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  51717. (WebCore::InspectorInstrumentation::didFailLoadingImpl):
  51718. * loader/MainResourceLoader.cpp:
  51719. (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
  51720. 2011-03-10 Alexander Pavlov <apavlov@chromium.org>
  51721. Reviewed by Yury Semikhatsky.
  51722. Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
  51723. https://bugs.webkit.org/show_bug.cgi?id=56096
  51724. No new tests, as this is a refactoring.
  51725. * inspector/front-end/BreakpointsSidebarPane.js:
  51726. (WebInspector.EventListenerBreakpointsSidebarPane):
  51727. * inspector/front-end/DetailedHeapshotView.js:
  51728. * inspector/front-end/ResourcesPanel.js:
  51729. (WebInspector.ResourcesPanel):
  51730. (WebInspector.BaseStorageTreeElement):
  51731. (WebInspector.BaseStorageTreeElement.prototype.onattach):
  51732. (WebInspector.StorageCategoryTreeElement):
  51733. (WebInspector.FrameTreeElement):
  51734. (WebInspector.FrameResourceTreeElement):
  51735. (WebInspector.DatabaseTreeElement):
  51736. (WebInspector.DatabaseTableTreeElement):
  51737. (WebInspector.DOMStorageTreeElement):
  51738. (WebInspector.CookieTreeElement):
  51739. (WebInspector.ApplicationCacheTreeElement):
  51740. (WebInspector.ResourceRevisionTreeElement):
  51741. * inspector/front-end/utilities.js:
  51742. (Element.prototype.removeStyleClass):
  51743. (Element.prototype.addStyleClass):
  51744. (Element.prototype.hasStyleClass):
  51745. 2011-03-11 Brian Salomon <bsalomon@google.com>
  51746. Reviewed by Kenneth Russell.
  51747. Adds GrContext flush call to PlatformContextSkia destructor.
  51748. Calls GrContext flush with int parameter instead of bool due to skia
  51749. revision.
  51750. No new tests needed.
  51751. * platform/graphics/chromium/DrawingBufferChromium.cpp:
  51752. (WebCore::DrawingBuffer::publishToPlatformLayer):
  51753. * platform/graphics/skia/PlatformContextSkia.cpp:
  51754. (WebCore::PlatformContextSkia::~PlatformContextSkia):
  51755. (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  51756. 2011-03-10 Chris Guillory <chris.guillory@google.com>
  51757. Reviewed by James Robinson.
  51758. Fix for Coverity discovered NO_EFFECT (self-assign) defect.
  51759. https://bugs.webkit.org/show_bug.cgi?id=54143
  51760. * platform/graphics/gpu/TilingData.cpp:
  51761. (WebCore::TilingData::setMaxTextureSize):
  51762. 2011-03-10 Emil A Eklund <eae@chromium.org>
  51763. Reviewed by Alexey Proskuryakov.
  51764. The web colours palevioletred and mediumpurple are incorrect
  51765. https://bugs.webkit.org/show_bug.cgi?id=46658
  51766. Changed value for the palevioletred and mediumpurple colors to match
  51767. the css3 specification.
  51768. Test: fast/css/named-colors.html
  51769. * inspector/front-end/Color.js:
  51770. * platform/ColorData.gperf:
  51771. 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  51772. Unreviewed build fix.
  51773. [WML] Fix build error
  51774. https://bugs.webkit.org/show_bug.cgi?id=56078
  51775. * wml/WMLInputElement.cpp:
  51776. (WebCore::WMLInputElement::defaultEventHandler):
  51777. 2011-03-10 Jeremy Moskovich <jeremy@chromium.org>
  51778. Reviewed by Darin Adler.
  51779. Fix navigation menus on a bunch of sites in WebKit.
  51780. https://bugs.webkit.org/show_bug.cgi?id=52535
  51781. WebKit doesn't support position:relative for several table elements and
  51782. overwrites the style internally when position:relative is encountered.
  51783. Unfortunately position:relative affects the choice of nodes returned by
  51784. offsetParent.
  51785. This CL adds a bit to RenderStyle to track whether position:relative was
  51786. overwritten. The value is then consulted in offsetParent which makes us
  51787. match FF/IE.
  51788. Tests: fast/block/positioning/offsetLeft-relative-iframe.html
  51789. fast/block/positioning/offsetLeft-relative-td.html
  51790. * css/CSSStyleSelector.cpp:
  51791. (WebCore::CSSStyleSelector::adjustRenderStyle):
  51792. * rendering/RenderObject.cpp:
  51793. (WebCore::RenderObject::isOriginallyRelPositioned):
  51794. (WebCore::RenderObject::offsetParent):
  51795. * rendering/RenderObject.h:
  51796. * rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative.
  51797. (WebCore::InheritedFlags::positionWasRelative):
  51798. (WebCore::InheritedFlags::setPositionWasRelative):
  51799. * rendering/style/StyleRareNonInheritedData.cpp:
  51800. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  51801. (WebCore::StyleRareNonInheritedData::operator==):
  51802. * rendering/style/StyleRareNonInheritedData.h:
  51803. 2011-03-10 Adam Barth <abarth@webkit.org>
  51804. Reviewed by Darin Adler.
  51805. REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
  51806. https://bugs.webkit.org/show_bug.cgi?id=51357
  51807. Previously, we would try to print from a callstack that didn't want a
  51808. nested event loop, leading to re-entrancy problems. In this patch, we
  51809. complete the print call asynchronously, giving us a clean stack on
  51810. which to run the nested event loop.
  51811. Test: printing/print-close-crash.html
  51812. * page/DOMWindow.cpp:
  51813. (WebCore::DOMWindow::DOMWindow):
  51814. (WebCore::DOMWindow::print):
  51815. (WebCore::DOMWindow::printTimerFired):
  51816. * page/DOMWindow.h:
  51817. 2011-03-11 Roland Steiner <rolandsteiner@chromium.org>
  51818. Reviewed by Ryosuke Niwa.
  51819. Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
  51820. https://bugs.webkit.org/show_bug.cgi?id=55570
  51821. Add a virtual function toInputElement() to Node that has a default
  51822. implementation of returning 0.
  51823. For HTMLInputElement and WMLInputElement (which derive from InputElement)
  51824. override this to return the object.
  51825. Change all calling sites of the old toInputElement to use the new member
  51826. function. This also allows us to save some casts.
  51827. No new tests. (refactoring)
  51828. * WebCore.exp.in:
  51829. * accessibility/AXObjectCache.cpp:
  51830. (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
  51831. * accessibility/AccessibilityRenderObject.cpp:
  51832. (WebCore::AccessibilityRenderObject::isPasswordField):
  51833. (WebCore::AccessibilityRenderObject::isIndeterminate):
  51834. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
  51835. (WebCore::AccessibilityRenderObject::isChecked):
  51836. * css/CSSStyleSelector.cpp:
  51837. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  51838. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  51839. * dom/CheckedRadioButtons.cpp:
  51840. (WebCore::CheckedRadioButtons::removeButton):
  51841. * dom/InputElement.cpp:
  51842. * dom/InputElement.h:
  51843. * dom/Node.cpp:
  51844. (WebCore::Node::toInputElement):
  51845. * dom/Node.h:
  51846. * html/HTMLInputElement.h:
  51847. (WebCore::HTMLInputElement::toInputElement):
  51848. * rendering/RenderTextControlSingleLine.cpp:
  51849. (WebCore::RenderTextControlSingleLine::inputElement):
  51850. * rendering/RenderTheme.cpp:
  51851. (WebCore::RenderTheme::isChecked):
  51852. (WebCore::RenderTheme::isIndeterminate):
  51853. * wml/WMLInputElement.h:
  51854. (WebCore::WMLInputElement::toInputElement):
  51855. 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  51856. Reviewed by Kenneth Rohde Christiansen.
  51857. [EFL] New mediaControl css file for EFL
  51858. https://bugs.webkit.org/show_bug.cgi?id=55460
  51859. Add new mediaControl css file for html5 video UI.
  51860. * CMakeLists.txt:
  51861. * CMakeListsEfl.txt:
  51862. * css/mediaControlsEfl.css: Added.
  51863. (audio):
  51864. (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
  51865. (video:-webkit-full-page-media::-webkit-media-controls-panel):
  51866. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
  51867. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
  51868. (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
  51869. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  51870. (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
  51871. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
  51872. (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
  51873. (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
  51874. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
  51875. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
  51876. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
  51877. (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
  51878. (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
  51879. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  51880. (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
  51881. * platform/efl/RenderThemeEfl.cpp:
  51882. (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
  51883. 2011-03-10 Emil A Eklund <eae@chromium.org>
  51884. Reviewed by Dimitri Glazkov.
  51885. style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
  51886. https://bugs.webkit.org/show_bug.cgi?id=53860
  51887. Preserve selection when changing between multi-select and single-select
  51888. for <select> boxes even if it has not yet been rendered.
  51889. Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html
  51890. * html/HTMLSelectElement.cpp:
  51891. (WebCore::HTMLSelectElement::setMultiple):
  51892. 2011-03-10 Ojan Vafai <ojan@chromium.org>
  51893. Reviewed by Tony Chang.
  51894. update comment to reference new DOM Core spec
  51895. https://bugs.webkit.org/show_bug.cgi?id=56079
  51896. I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit.
  51897. This is the only one that's actually specified to fire
  51898. in the latest DOM Core spec.
  51899. * dom/DOMImplementation.cpp:
  51900. (WebCore::DOMImplementation::createDocument):
  51901. 2011-03-10 Rik Cabanier <cabanier@gmail.com>
  51902. Reviewed by Tony Gentilcore.
  51903. Fix that allows fixed length values to be floating point
  51904. https://bugs.webkit.org/show_bug.cgi?id=52699
  51905. * WebCore.xcodeproj/project.pbxproj:
  51906. * css/CSSStyleSelector.cpp:
  51907. (WebCore::convertToLength):
  51908. (WebCore::convertToIntLength):
  51909. (WebCore::convertToFloatLength):
  51910. (WebCore::CSSStyleSelector::applyProperty):
  51911. (WebCore::CSSStyleSelector::createTransformOperations):
  51912. * platform/Length.h:
  51913. (WebCore::Length::Length):
  51914. (WebCore::Length::operator==):
  51915. (WebCore::Length::operator!=):
  51916. (WebCore::Length::rawValue):
  51917. (WebCore::Length::type):
  51918. (WebCore::Length::quirk):
  51919. (WebCore::Length::setValue):
  51920. (WebCore::Length::calcFloatValue):
  51921. (WebCore::Length::isZero):
  51922. (WebCore::Length::blend):
  51923. (WebCore::Length::getIntValue):
  51924. (WebCore::Length::getFloatValue):
  51925. * rendering/AutoTableLayout.cpp:
  51926. (WebCore::AutoTableLayout::recalcColumn):
  51927. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  51928. * rendering/FixedTableLayout.cpp:
  51929. (WebCore::FixedTableLayout::calcWidthArray):
  51930. 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
  51931. Unreviewed, rolling out r80800.
  51932. http://trac.webkit.org/changeset/80800
  51933. https://bugs.webkit.org/show_bug.cgi?id=56163
  51934. Caused hundreds of tests to crash on Windows 7 (Requested by
  51935. rniwa on #webkit).
  51936. * page/EventHandler.cpp:
  51937. (WebCore::EventHandler::mouseMoved):
  51938. (WebCore::EventHandler::updateMouseEventTargetNode):
  51939. * page/FocusController.cpp:
  51940. (WebCore::FocusController::setActive):
  51941. * page/FrameView.cpp:
  51942. (WebCore::FrameView::FrameView):
  51943. (WebCore::FrameView::~FrameView):
  51944. * page/FrameView.h:
  51945. * page/Page.cpp:
  51946. * page/Page.h:
  51947. * platform/ScrollView.cpp:
  51948. (WebCore::ScrollView::wheelEvent):
  51949. * platform/ScrollView.h:
  51950. * rendering/RenderDataGrid.cpp:
  51951. (WebCore::RenderDataGrid::RenderDataGrid):
  51952. (WebCore::RenderDataGrid::~RenderDataGrid):
  51953. * rendering/RenderLayer.cpp:
  51954. (WebCore::RenderLayer::RenderLayer):
  51955. (WebCore::RenderLayer::~RenderLayer):
  51956. * rendering/RenderLayer.h:
  51957. * rendering/RenderListBox.cpp:
  51958. (WebCore::RenderListBox::RenderListBox):
  51959. (WebCore::RenderListBox::~RenderListBox):
  51960. 2011-03-10 Alice Boxhall <aboxhall@chromium.org>
  51961. Reviewed by Dimitri Glazkov.
  51962. NULL pointer crash when using :empty and :first-line pseudoclass selectors together
  51963. https://bugs.webkit.org/show_bug.cgi?id=53316
  51964. :empty is calculated for each element during parsing, but then not
  51965. recalculated after any child elements are attached. Force style
  51966. re-calculation on elements which have :empty in their style when
  51967. their children are changed.
  51968. Test: fast/css/empty-first-line-crash.html
  51969. * dom/Element.cpp:
  51970. (WebCore::checkForEmptyStyleChange): Pull out empty style checking
  51971. logic from checkForSiblingStyleChanges().
  51972. (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges()
  51973. method.
  51974. (WebCore::Element::childrenChanged): Call checkForEmptyStyleChanges() when
  51975. called with changedByParser = true.
  51976. 2011-03-10 Emil A Eklund <eae@chromium.org>
  51977. Unreviewed build fix.
  51978. Fix Leopard Release build broken by r80797.
  51979. * html/CollectionCache.h:
  51980. 2011-03-10 Beth Dakin <bdakin@apple.com>
  51981. Reviewed by Darin Adler.
  51982. Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
  51983. send notifications appropriate times (showing up, resizing)
  51984. -and corresponding-
  51985. https://bugs.webkit.org/show_bug.cgi?id=56067
  51986. The general strategy here is to add a HashSet of ScrollableAreas to the page that
  51987. can be accessed when necessary to send notifications to all ScrollableAreas.
  51988. Find layers for relevant node and if the layers are in the Page's ScrollableArea
  51989. set, then send the relevant notification.
  51990. * page/EventHandler.cpp:
  51991. (WebCore::EventHandler::mouseMoved):
  51992. (WebCore::EventHandler::updateMouseEventTargetNode):
  51993. When the page is set active or not active, iterate through the Page's
  51994. ScrollableAreas to send hide/show notifications.
  51995. * page/FocusController.cpp:
  51996. (WebCore::FocusController::setActive):
  51997. When a FrameView is created, add it to the ScrollableArea set. When it's
  51998. destroyed, remove it.
  51999. * page/FrameView.cpp:
  52000. (WebCore::FrameView::FrameView):
  52001. (WebCore::FrameView::~FrameView):
  52002. Iterate through the Page's ScrollableAreas to send the paint notification.
  52003. (WebCore::FrameView::notifyPageThatContentAreaWillPaint):
  52004. * page/FrameView.h:
  52005. Add the new ScrollableArea set.
  52006. * page/Page.cpp:
  52007. (WebCore::Page::addScrollableArea):
  52008. (WebCore::Page::removeScrollableArea):
  52009. (WebCore::Page::pageContainsScrollableArea):
  52010. * page/Page.h:
  52011. (WebCore::Page::scrollableAreaSet):
  52012. notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
  52013. * platform/ScrollView.cpp:
  52014. (WebCore::ScrollView::notifyPageThatContentAreaWillPaint):
  52015. Call notifyPageThatContentAreaWillPaint() instead of calling
  52016. contentAreaWillPaint() just for the ScrollView.
  52017. (WebCore::ScrollView::paint):
  52018. * platform/ScrollView.h:
  52019. Add/remove ScrollableAreas to the set.
  52020. * rendering/RenderDataGrid.cpp:
  52021. (WebCore::RenderDataGrid::RenderDataGrid):
  52022. (WebCore::RenderDataGrid::~RenderDataGrid):
  52023. * rendering/RenderListBox.cpp:
  52024. (WebCore::RenderListBox::RenderListBox):
  52025. (WebCore::RenderListBox::~RenderListBox):
  52026. * rendering/RenderLayer.cpp:
  52027. (WebCore::RenderLayer::RenderLayer):
  52028. (WebCore::RenderLayer::~RenderLayer):
  52029. Should have implemented this ScrollableArea-interface function a while ago.
  52030. (WebCore::RenderLayer::currentMousePosition):
  52031. * rendering/RenderLayer.h:
  52032. 2011-03-10 takano takumi <takano@apple.com>
  52033. Reviewed by David Hyatt.
  52034. Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
  52035. https://bugs.webkit.org/show_bug.cgi?id=55069
  52036. No new tests. If the test above runs without crash, the fix should be okay.
  52037. * dom/Node.cpp:
  52038. (WebCore::Node::diff):
  52039. - Changed to return Detach when textCombine style was changed.
  52040. * rendering/RenderCombineText.cpp:
  52041. (WebCore::RenderCombineText::styleDidChange):
  52042. (WebCore::RenderCombineText::setTextInternal):
  52043. (WebCore::RenderCombineText::width):
  52044. (WebCore::RenderCombineText::adjustTextOrigin):
  52045. (WebCore::RenderCombineText::charactersToRender):
  52046. (WebCore::RenderCombineText::combineText):
  52047. - Added assertions to ensure the passed object is RenderCombineText.
  52048. * rendering/RenderCombineText.h:
  52049. (WebCore::RenderCombineText::isCombineText):
  52050. - Added to distinguish plain RenderText and RenderCombineText.
  52051. (WebCore::toRenderCombineText):
  52052. - Added assertions to ensure the passed object is RenderCombineText.
  52053. * rendering/RenderObject.h:
  52054. (WebCore::RenderObject::isCombineText):
  52055. - Added to distinguish plain RenderText and RenderCombineText.
  52056. 2011-03-10 Emil A Eklund <eae@chromium.org>
  52057. Reviewed by Darin Adler.
  52058. Collection cache not reset when moving base node between documents
  52059. https://bugs.webkit.org/show_bug.cgi?id=55446
  52060. Fix bug where HTMLCollection::resetCollectionInfo does not reset the
  52061. cache when the base node is moved to a different document by making sure
  52062. that the DOMVersion is updated and that it's unique across documents.
  52063. Tests: fast/dom/HTMLFormElement/invalid-form-field.html
  52064. fast/dom/HTMLFormElement/move-option-between-documents.html
  52065. fast/dom/collection-nameditem-move-between-documents.html
  52066. * dom/Document.cpp:
  52067. (WebCore::Document::Document):
  52068. * dom/Document.h:
  52069. (WebCore::Document::incDOMTreeVersion):
  52070. (WebCore::Document::domTreeVersion):
  52071. * dom/Node.cpp:
  52072. (WebCore::Node::setDocumentRecursively):
  52073. * html/FormAssociatedElement.cpp:
  52074. (WebCore::FormAssociatedElement::resetFormOwner):
  52075. * html/HTMLCollection.cpp:
  52076. (WebCore::HTMLCollection::resetCollectionInfo):
  52077. * xml/XPathResult.h:
  52078. 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  52079. Unreviewed build fix.
  52080. [EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
  52081. https://bugs.webkit.org/show_bug.cgi?id=56005
  52082. There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
  52083. * platform/efl/ContextMenuEfl.cpp:
  52084. (WebCore::ContextMenu::ContextMenu):
  52085. * platform/efl/ContextMenuItemEfl.cpp:
  52086. 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
  52087. Reviewed by Tony Chang.
  52088. startOfBlock and endOfBlock may return a position inside hr
  52089. https://bugs.webkit.org/show_bug.cgi?id=56025
  52090. Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlock by
  52091. calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argument lists
  52092. of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
  52093. argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.
  52094. Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
  52095. enclosingBlock to be consitent with startOfBlock and endOfBlock.
  52096. This patch also replaced calls to deprecatedNode in startOfBlock, endOfBlock,
  52097. and inSameBlock by calls to containerNode because the enclosing block of a position
  52098. should never be before or after the position.
  52099. No tests are added because this change only affects WebCore internally.
  52100. * editing/DeleteSelectionCommand.cpp:
  52101. (WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosingNodeOfType.
  52102. Pass CanCrossEditingBoundary instead of false.
  52103. * editing/htmlediting.cpp:
  52104. (WebCore::unsplittableElementForPosition): Ditto.
  52105. (WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to
  52106. enclosingNodeOfType.
  52107. (WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instead of boolean.
  52108. Fixed a bug that it stops walking the tree when it reached the root editable node
  52109. even when the editing boundary crossing rule is CanCrossEditingBoundary.
  52110. * editing/htmlediting.h: Prototype changes.
  52111. * editing/visible_units.cpp:
  52112. (WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
  52113. Also added an early exit when there's no enclosing block.
  52114. (WebCore::endOfBlock): Ditto. The early exist in this case prevents crash in
  52115. lastPositionInNode.
  52116. (WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
  52117. (WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBoundary because
  52118. we don't care where the start of block is when we're comparing against the given position.
  52119. (WebCore::isEndOfBlock): Ditto.
  52120. * editing/visible_units.h:
  52121. 2011-03-10 Alexey Proskuryakov <ap@apple.com>
  52122. Reviewed by Dan Bernstein.
  52123. Backspace deletes all non-BMP symbols at once, and then some
  52124. https://bugs.webkit.org/show_bug.cgi?id=55971
  52125. <rdar://problem/8725312>
  52126. Test: platform/mac/editing/input/insert-delete-smp-symbol.html
  52127. * rendering/RenderText.cpp:
  52128. (WebCore::isMark): This matches what Core Foundation does for all characters that I tested.
  52129. (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().
  52130. 2011-03-10 Chris Evans <cevans@chromium.org>
  52131. Reviewed by Adam Barth.
  52132. Error in StyleElement::process with large nodesets
  52133. https://bugs.webkit.org/show_bug.cgi?id=56150
  52134. Test: none due to excessive runtime and CRASH() vs. real crash.
  52135. * dom/StyleElement.cpp:
  52136. (WebCore::StyleElement::process): Handle large node sets better.
  52137. 2011-03-10 David Hyatt <hyatt@apple.com>
  52138. Reviewed by Simon Fraser.
  52139. https://bugs.webkit.org/show_bug.cgi?id=47151
  52140. Percentage heights should skip anonymous containing blocks when computing the used value.
  52141. Added fast/block/basic/percentage-height-inside-anonymous-block.html
  52142. * rendering/RenderBox.cpp:
  52143. (WebCore::RenderBox::computePercentageLogicalHeight):
  52144. 2011-03-10 Nat Duca <nduca@chromium.org>
  52145. Reviewed by James Robinson.
  52146. [chromium] Make updateAndDrawLayers argumentless.
  52147. https://bugs.webkit.org/show_bug.cgi?id=55985
  52148. Made the TilePainters and viewport parameters for
  52149. LayerRendererChromium member variables instead of arguments on
  52150. updateAndDrawLayers. In a future change, this will allows us to
  52151. draw the layer tree without the WebView's assistance.
  52152. * platform/graphics/chromium/LayerRendererChromium.cpp:
  52153. (WebCore::LayerRendererChromium::create):
  52154. (WebCore::LayerRendererChromium::LayerRendererChromium):
  52155. (WebCore::LayerRendererChromium::verticalScrollbarRect):
  52156. (WebCore::LayerRendererChromium::horizontalScrollbarRect):
  52157. (WebCore::LayerRendererChromium::invalidateRootLayerRect):
  52158. (WebCore::LayerRendererChromium::updateRootLayerContents):
  52159. (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
  52160. (WebCore::LayerRendererChromium::drawRootLayer):
  52161. (WebCore::LayerRendererChromium::setViewport):
  52162. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  52163. (WebCore::LayerRendererChromium::updateLayers):
  52164. (WebCore::LayerRendererChromium::drawLayers):
  52165. (WebCore::LayerRendererChromium::setRootLayer):
  52166. (WebCore::LayerRendererChromium::getFramebufferPixels):
  52167. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  52168. * platform/graphics/chromium/LayerRendererChromium.h:
  52169. (WebCore::LayerRendererChromium::viewportSize):
  52170. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  52171. (WebCore::CCHeadsUpDisplay::draw):
  52172. 2011-01-25 Martin Robinson <mrobinson@igalia.com>
  52173. Reviewed by Xan Lopez.
  52174. [GTK] Implement spin buttons for GTK+ 2.x
  52175. https://bugs.webkit.org/show_bug.cgi?id=53098
  52176. Implement spin buttons for GTK+ 2.x. This allows proper render and functioning
  52177. for input type=number. The implementation is based on the one in gtkspinbutton.c
  52178. from the GTK+ sources.
  52179. * platform/gtk/RenderThemeGtk.h: Added new members and getters.
  52180. * platform/gtk/RenderThemeGtk2.cpp:
  52181. (WebCore::RenderThemeGtk::platformInit): Initialize spin button widget.
  52182. (WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside the
  52183. spin button area to have proper rendering. There doesn't seem to be any other
  52184. clean way of having spin buttons that are the size of the text input frame.
  52185. (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementation.
  52186. (WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto.
  52187. (WebCore::RenderThemeGtk::gtkSpinButton): Added.
  52188. 2011-03-10 Levi Weintraub <leviw@chromium.org>
  52189. Reviewed by Ryosuke Niwa.
  52190. InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
  52191. https://bugs.webkit.org/show_bug.cgi?id=53409
  52192. Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
  52193. spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
  52194. didn't skip the editable boundary.
  52195. Test: editing/execCommand/insert-list-with-noneditable-content.html
  52196. * editing/CompositeEditCommand.cpp:
  52197. (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
  52198. position for the active editing command. Without this, there are cases when the destination happens
  52199. to be a placeholder, and we remove it.
  52200. (WebCore::CompositeEditCommand::moveParagraphs):
  52201. * editing/CompositeEditCommand.h:
  52202. * editing/InsertListCommand.cpp:
  52203. (WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of
  52204. non-editable content in an editable context. Previously, this could cause an infinite loop.
  52205. * editing/visible_units.cpp:
  52206. (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
  52207. content in the same paragraph to reach the actual editable paragraph start.
  52208. (WebCore::endOfParagraph): Ditto.
  52209. (WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of
  52210. endOfParagraph.
  52211. 2011-03-10 Berend-Jan Wever <skylined@chromium.org>
  52212. Reviewed by Darin Adler.
  52213. Calling focus() on an area element not in a document should not cause a NULL ptr crash
  52214. https://bugs.webkit.org/show_bug.cgi?id=54877
  52215. Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html
  52216. * dom/Element.cpp:
  52217. (WebCore::Element::focus): Check element is in the document before allowing focus
  52218. * html/HTMLAreaElement.cpp:
  52219. (WebCore::HTMLAreaElement::imageElement): Check element has a parent before checking if its parent is a map
  52220. 2011-03-10 Xiyuan Xia <xiyuan@chromium.org>
  52221. Reviewed by Tony Chang.
  52222. [Chromium] Fix default single selection select's popup background on chromium/linux
  52223. https://bugs.webkit.org/show_bug.cgi?id=56023
  52224. Test: fast/html/select-dropdown-consistent-background-color.html
  52225. * css/themeChromiumLinux.css:
  52226. 2011-03-10 Kris Jordan <krisjordan@gmail.com>
  52227. Reviewed by Alexey Proskuryakov.
  52228. Improve default Accept header to give preference to HTML over XML.
  52229. https://bugs.webkit.org/show_bug.cgi?id=27267
  52230. * loader/FrameLoader.cpp:Changed default accept header to match
  52231. FireFox' as per bug 27267.
  52232. 2011-03-10 Martin Robinson <mrobinson@igalia.com>
  52233. Reviewed by Xan Lopez.
  52234. [GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
  52235. https://bugs.webkit.org/show_bug.cgi?id=56125
  52236. No new tests. This functionality will be tested once we have TestRunner
  52237. implementation for WebKit2 with pixel dumping support.
  52238. * GNUmakefile.am: Add a new define with tracks whether or not we are using
  52239. our specialized GTK+ ScrollView.
  52240. * platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we are compiling
  52241. WebKit1.
  52242. (WebCore::ScrollView::wheelEvent):
  52243. * platform/gtk/ScrollViewGtk.cpp: Ditto.
  52244. 2011-03-10 Kent Tamura <tkent@chromium.org>
  52245. Reviewed by Dimitri Glazkov.
  52246. Assertion fails by validating a form twice very quickly
  52247. https://bugs.webkit.org/show_bug.cgi?id=56069
  52248. If the interactive validation is invoked when a form control is in
  52249. needsLayout() state, an assertion in isFocusable() fails. To avoid it,
  52250. Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable().
  52251. Test: fast/forms/interactive-validation-assertion-by-validate-twice.html
  52252. * html/HTMLFormElement.cpp:
  52253. (WebCore::HTMLFormElement::validateInteractively):
  52254. Calls updateLayoutIgnorePendingStylesheets().
  52255. 2011-03-10 David Hyatt <hyatt@apple.com>
  52256. Reviewed by Beth Dakin.
  52257. https://bugs.webkit.org/show_bug.cgi?id=47143
  52258. Static distance computation is wrong when an ancestor is also positioned. We need to go up the container()
  52259. chain (after initially starting with the parent()) when doing this computation, so that we properly skip
  52260. intermediate boxes between two positioned blocks.
  52261. Added fast/block/positioning/static-distance-with-positioned-ancestor.html.
  52262. * rendering/RenderBox.cpp:
  52263. (WebCore::computeInlineStaticDistance):
  52264. (WebCore::computeBlockStaticDistance):
  52265. 2011-03-10 Adrienne Walker <enne@google.com>
  52266. Reviewed by Kenneth Russell.
  52267. [chromium] Make tiled compositor data structure more efficient.
  52268. https://bugs.webkit.org/show_bug.cgi?id=54133
  52269. Previously, the compositor had a sparse 2D array of tiles for the
  52270. whole page, most of which were null. The tiles were implicitly
  52271. located based on their position in the array. This was inefficient
  52272. when the page grew (e.g. infinite scrolling) and caused some bugs
  52273. (e.g. width * height > MAX_INT). This change modifies tiles to have
  52274. explicit positions so they can be stored in a hash map.
  52275. Tests: LayoutTests/compositing/
  52276. * platform/graphics/chromium/LayerTilerChromium.cpp:
  52277. (WebCore::LayerTilerChromium::reset):
  52278. (WebCore::LayerTilerChromium::createTile):
  52279. (WebCore::LayerTilerChromium::invalidateTiles):
  52280. (WebCore::LayerTilerChromium::contentRectToTileIndices):
  52281. (WebCore::LayerTilerChromium::tileAt):
  52282. (WebCore::LayerTilerChromium::tileContentRect):
  52283. (WebCore::LayerTilerChromium::tileLayerRect):
  52284. (WebCore::LayerTilerChromium::invalidateRect):
  52285. (WebCore::LayerTilerChromium::invalidateEntireLayer):
  52286. (WebCore::LayerTilerChromium::update):
  52287. (WebCore::LayerTilerChromium::updateFromPixels):
  52288. (WebCore::LayerTilerChromium::draw):
  52289. (WebCore::LayerTilerChromium::growLayerToContain):
  52290. * platform/graphics/chromium/LayerTilerChromium.h:
  52291. (WebCore::LayerTilerChromium::Tile::Tile):
  52292. (WebCore::LayerTilerChromium::Tile::i):
  52293. (WebCore::LayerTilerChromium::Tile::j):
  52294. (WebCore::LayerTilerChromium::Tile::moveTo):
  52295. (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue):
  52296. (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue):
  52297. (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):
  52298. 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
  52299. Unreviewed build fix for r80752; Negated the boolean logic.
  52300. * editing/VisiblePosition.cpp:
  52301. (WebCore::VisiblePosition::next):
  52302. (WebCore::VisiblePosition::previous):
  52303. 2011-03-10 David Hyatt <hyatt@apple.com>
  52304. Reviewed by Adam Roben.
  52305. Make the same change to xheight on Windows for CG.
  52306. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  52307. (WebCore::SimpleFontData::platformInit):
  52308. 2011-03-10 David Hyatt <hyatt@apple.com>
  52309. Reviewed by Simon Fraser.
  52310. https://bugs.webkit.org/show_bug.cgi?id=47147
  52311. Fix for repaint issues when the root element is a table and needs to paint a background that
  52312. covers the entire canvas. Remove paintRootBoxDecorations and replace with paintRootBoxFillLayers,
  52313. so that it can be called only for fill layer painting. Make tables and normal boxes both
  52314. call this new method. Fix the dirty check at the start of RenderTable paint to not happen if
  52315. the table is the root of the document (this same check exists in RenderBlock painting already).
  52316. * rendering/RenderBox.cpp:
  52317. (WebCore::RenderBox::paintRootBoxFillLayers):
  52318. (WebCore::RenderBox::paintBoxDecorations):
  52319. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  52320. * rendering/RenderBox.h:
  52321. * rendering/RenderLayerCompositor.cpp:
  52322. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  52323. * rendering/RenderTable.cpp:
  52324. (WebCore::RenderTable::paint):
  52325. (WebCore::RenderTable::paintBoxDecorations):
  52326. 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
  52327. Unreviewed, rolling out r80749.
  52328. http://trac.webkit.org/changeset/80749
  52329. https://bugs.webkit.org/show_bug.cgi?id=56143
  52330. "Caused at least 3 media tests to be flaky" (Requested by
  52331. tonyg-cr on #webkit).
  52332. * html/parser/HTMLDocumentParser.cpp:
  52333. (WebCore::HTMLDocumentParser::canTakeNextToken):
  52334. (WebCore::HTMLDocumentParser::pumpTokenizer):
  52335. * html/parser/HTMLParserScheduler.cpp:
  52336. * html/parser/HTMLParserScheduler.h:
  52337. (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  52338. * page/FrameView.h:
  52339. 2011-03-10 Sam Weinig <sam@webkit.org>
  52340. Reviewed by David Hyatt.
  52341. Regression: Content not drawn when scrolling horizontally in an RTL page
  52342. https://bugs.webkit.org/show_bug.cgi?id=55077
  52343. * platform/ScrollView.cpp:
  52344. (WebCore::ScrollView::overhangAmount):
  52345. (WebCore::ScrollView::calculateOverhangAreasForPainting):
  52346. Take the scroll origin into account when calculating overhang.
  52347. * platform/ScrollView.h:
  52348. * rendering/RenderLayer.h:
  52349. * platform/ScrollableArea.h:
  52350. (WebCore::ScrollableArea::scrollOrigin):
  52351. Move identical scroll origin member from ScrollView and RenderLayer
  52352. to shared base ScrollableArea. This is also needed so that the animator
  52353. can access it.
  52354. * platform/mac/ScrollAnimatorMac.mm:
  52355. (WebCore::ScrollAnimatorMac::pinnedInDirection):
  52356. (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
  52357. (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
  52358. Account for a scroll origin when doing calculating scroll offsets.
  52359. 2011-03-09 Matthew Delaney <mdelaney@apple.com>
  52360. Reviewed by Simon Fraser.
  52361. Plumb through settings for accelerated drawing for canvas
  52362. https://bugs.webkit.org/show_bug.cgi?id=56039
  52363. No new tests. Doesn't affect behavior, just adding a switch to toggle canvas backends.
  52364. * WebCore.exp.in:
  52365. * html/HTMLCanvasElement.cpp:
  52366. * html/canvas/CanvasRenderingContext2D.cpp:
  52367. * page/Settings.cpp:
  52368. * page/Settings.h:
  52369. 2011-03-10 David Hyatt <hyatt@apple.com>
  52370. Reviewed by Simon Fraser.
  52371. https://bugs.webkit.org/show_bug.cgi?id=47157
  52372. CSS2.1 test suite failures because the ex unit is broken with the Ahem font.
  52373. Remove the code that tries to also include the maxX of the glyph bounds for the
  52374. 'x' glyph, since it just causes the x-height to be way too large in cases where the 'x' glyph extends
  52375. below the baseline.
  52376. Remove the Apple Symbol hack for ex units, since the person who added that was confused by another
  52377. issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize. That's why
  52378. the value was too small. Patched the code to just multiply by pointSize and took out the hack.
  52379. Fix causes many tests in the css2.1 directory to progress, so no new tests required. Many other
  52380. layout tests change because the xHeight for Lucida Grande gets smaller by a little bit, and radio
  52381. buttons use ex horizontal margins by default.
  52382. * platform/graphics/mac/SimpleFontDataMac.mm:
  52383. (WebCore::SimpleFontData::platformInit):
  52384. 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
  52385. Reviewed by Tony Chang.
  52386. VisiblePosition's next and previous should take an enum instead of a boolean
  52387. https://bugs.webkit.org/show_bug.cgi?id=56135
  52388. Changed the argument type of VisiblePosition::next and VisiblePosition::previous
  52389. from bool to EditingBoundaryCrossingRule. Also got rid of StayInEditableContent enum
  52390. in VisibleSelection and replaced it by EditingBoundaryCrossingRule because the enum
  52391. was only used in VisiblePosition::isAll and subsequently in SelectionController::isAll
  52392. to call VisiblePosition::next and VisiblePosition::previous.
  52393. * WebCore.exp.in:
  52394. * dom/Position.cpp:
  52395. (WebCore::Position::trailingWhitespacePosition):
  52396. * editing/ApplyBlockElementCommand.cpp:
  52397. (WebCore::ApplyBlockElementCommand::doApply):
  52398. * editing/CompositeEditCommand.cpp:
  52399. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  52400. * editing/InsertListCommand.cpp:
  52401. (WebCore::InsertListCommand::doApply):
  52402. (WebCore::InsertListCommand::listifyParagraph):
  52403. * editing/ReplaceSelectionCommand.cpp:
  52404. (WebCore::ReplaceSelectionCommand::shouldMergeStart):
  52405. (WebCore::ReplaceSelectionCommand::shouldMergeEnd):
  52406. (WebCore::ReplaceSelectionCommand::doApply):
  52407. * editing/SelectionController.cpp:
  52408. (WebCore::SelectionController::modifyExtendingRight):
  52409. (WebCore::SelectionController::modifyExtendingForward):
  52410. (WebCore::SelectionController::modifyMovingForward):
  52411. (WebCore::SelectionController::modifyExtendingLeft):
  52412. (WebCore::SelectionController::modifyExtendingBackward):
  52413. (WebCore::SelectionController::modifyMovingBackward):
  52414. * editing/SelectionController.h:
  52415. (WebCore::SelectionController::isAll):
  52416. * editing/TypingCommand.cpp:
  52417. (WebCore::TypingCommand::deleteKeyPressed):
  52418. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  52419. * editing/VisiblePosition.cpp:
  52420. (WebCore::VisiblePosition::next):
  52421. (WebCore::VisiblePosition::previous):
  52422. * editing/VisiblePosition.h:
  52423. * editing/VisibleSelection.cpp:
  52424. (WebCore::VisibleSelection::isAll):
  52425. (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  52426. * editing/VisibleSelection.h:
  52427. * editing/htmlediting.cpp:
  52428. (WebCore::selectionForParagraphIteration):
  52429. * editing/visible_units.cpp:
  52430. (WebCore::startOfNextParagraph):
  52431. 2011-03-10 Mihai Parparita <mihaip@chromium.org>
  52432. Reviewed by Tony Gentilcore.
  52433. Remove CRASH() calls added to track down bug 53045
  52434. https://bugs.webkit.org/show_bug.cgi?id=56137
  52435. Remove CRASH() calls added by r76575 and re-label ones added by r80155
  52436. and r80269 as being associated with bug 56124 (which may still be
  52437. happening).
  52438. * css/CSSImageValue.cpp:
  52439. (WebCore::CSSImageValue::cachedImage):
  52440. * css/CSSSelector.h:
  52441. * css/CSSSelectorList.cpp:
  52442. (WebCore::CSSSelectorList::deleteSelectors):
  52443. * loader/cache/CachedResource.cpp:
  52444. (WebCore::CachedResource::CachedResource):
  52445. (WebCore::CachedResource::~CachedResource):
  52446. * loader/cache/CachedResource.h:
  52447. 2011-03-10 Tony Gentilcore <tonyg@chromium.org>
  52448. Reviewed by Eric Seidel.
  52449. Let the parser yield for layout before running scripts
  52450. https://bugs.webkit.org/show_bug.cgi?id=54355
  52451. Prior to this patch, the parser would yield to perform a layout/paint before running a
  52452. script only if the script or a stylesheet blocking the script is not loaded yet. Since we
  52453. don't preload scan into the body while parsing the head, typically we'll block on a script
  52454. early in the body that causes us to yield to do the first paint within a reasonable time.
  52455. However, I'm planning to change the PreloadScanner to scan into the body from the head.
  52456. That significantly improves overall load time, but would hurt first paint time because
  52457. fewer scripts would be blocked during parsing and thus wouldn't yield.
  52458. This change causes us to yield before running scripts if we haven't painted yet (regardless
  52459. of whether or not the script is loaded). In addition to allowing the above mentioned
  52460. PreloadScanner change to be implemented without regressing first paint time, this also
  52461. improves first paint time by itself.
  52462. I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
  52463. bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
  52464. 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
  52465. signifcant change in page load time.
  52466. Within the pages tested, 33 had no statistically significant change in time to first paint,
  52467. 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
  52468. are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
  52469. * html/parser/HTMLDocumentParser.cpp:
  52470. (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
  52471. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
  52472. means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
  52473. the right thing whether we are just before a token or waiting for a script. Now that we may
  52474. yield before a token or before a script, this may be called while paused.
  52475. * html/parser/HTMLParserScheduler.cpp:
  52476. (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  52477. * page/FrameView.h:
  52478. (WebCore::FrameView::hasEverPainted): Added.
  52479. 2011-03-10 Alejandro G. Castro <alex@igalia.com>
  52480. Reviewed by Martin Robinson.
  52481. Some Gtk code uses defined(USE_FREETYPE) instead of just USE(FREETYPE)
  52482. https://bugs.webkit.org/show_bug.cgi?id=55996
  52483. Use the macre USE instead of defined fro WTF_USE_FREETYPE and
  52484. WTF_USE_PANGO.
  52485. * GNUmakefile.am:
  52486. * platform/graphics/cairo/OwnPtrCairo.cpp:
  52487. * platform/graphics/cairo/OwnPtrCairo.h:
  52488. * platform/graphics/cairo/RefPtrCairo.cpp:
  52489. * platform/graphics/cairo/RefPtrCairo.h:
  52490. * platform/graphics/gtk/FontGtk.cpp:
  52491. (WebCore::setPangoAttributes):
  52492. (WebCore::Font::drawComplexText):
  52493. (WebCore::Font::floatWidthForComplexText):
  52494. (WebCore::Font::offsetForPositionForComplexText):
  52495. (WebCore::Font::selectionRectForComplexText):
  52496. 2011-03-10 Geoffrey Garen <ggaren@apple.com>
  52497. Reviewed by Oliver Hunt.
  52498. Rolled back in 80277 and 80280 with event handler layout test failures fixed.
  52499. https://bugs.webkit.org/show_bug.cgi?id=55653
  52500. The failures were caused by a last minute typo: assigning to currentEvent
  52501. instead of m_currentEvent.
  52502. * WebCore.xcodeproj/project.pbxproj:
  52503. * bindings/js/JSDOMGlobalObject.cpp:
  52504. * bindings/js/JSDOMGlobalObject.h:
  52505. * bindings/js/JSDOMWindowBase.cpp:
  52506. * bindings/js/JSDOMWindowBase.h:
  52507. * bindings/js/JSDOMWindowCustom.h:
  52508. * bindings/js/JSWorkerContextBase.cpp:
  52509. 2011-03-10 David Hyatt <hyatt@apple.com>
  52510. Reviewed by Dan Bernstein.
  52511. https://bugs.webkit.org/show_bug.cgi?id=56129, vertical text broken on Lion and Leopard.
  52512. Add Snow Leopard ifdefs for the scaling by point size and then the division by unitsPerEm to the
  52513. translationsTransform applied to the results from CTFontGetVerticalTranslationsForGlyphs, since
  52514. this is done already on Lion and Leopard.
  52515. * platform/graphics/mac/FontMac.mm:
  52516. (WebCore::showGlyphsWithAdvances):
  52517. 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
  52518. Unreviewed, rolling out r80701.
  52519. http://trac.webkit.org/changeset/80701
  52520. https://bugs.webkit.org/show_bug.cgi?id=56126
  52521. fast/dom/Geolocation/window-close-crash.html fails on Snow
  52522. Leopard release builds (Requested by mihaip on #webkit).
  52523. * page/DOMWindow.cpp:
  52524. * page/DOMWindow.h:
  52525. * page/Frame.cpp:
  52526. (WebCore::Frame::pageDestroyed):
  52527. (WebCore::Frame::transferChildFrameToNewDocument):
  52528. * page/Geolocation.cpp:
  52529. (WebCore::Geolocation::~Geolocation):
  52530. (WebCore::Geolocation::disconnectFrame):
  52531. (WebCore::Geolocation::lastPosition):
  52532. (WebCore::Geolocation::requestPermission):
  52533. (WebCore::Geolocation::startUpdating):
  52534. (WebCore::Geolocation::stopUpdating):
  52535. * page/Geolocation.h:
  52536. * page/GeolocationController.cpp:
  52537. (WebCore::GeolocationController::~GeolocationController):
  52538. * page/Navigator.cpp:
  52539. * page/Navigator.h:
  52540. * platform/mock/GeolocationClientMock.cpp:
  52541. * platform/mock/GeolocationClientMock.h:
  52542. 2011-03-10 Pratik Solanki <psolanki@apple.com>
  52543. Reviewed by Alexey Proskuryakov.
  52544. ASSERT_NOT_REACHED triggered in WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority
  52545. https://bugs.webkit.org/show_bug.cgi?id=56075
  52546. Map priority value 3, which means no priority, to ResourceLoadPriorityUnresolved.
  52547. * platform/network/cf/ResourceRequestCFNet.h:
  52548. (WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority):
  52549. (WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority):
  52550. 2011-03-10 Andrey Adaikin <aandrey@google.com>
  52551. Reviewed by Pavel Feldman.
  52552. Web Inspector: [Text editor] Substitute live-edit mode activation by double-click
  52553. https://bugs.webkit.org/show_bug.cgi?id=56084
  52554. Also fixed a regression: console was not opening/closing on ESC key press because tabIndex="0" attribute was preserved for a readOnly viewer.
  52555. * inspector/front-end/SourceFrame.js:
  52556. (WebInspector.SourceFrame):
  52557. (WebInspector.SourceFrame.prototype._startEditing):
  52558. (WebInspector.SourceFrame.prototype._registerShortcuts):
  52559. (WebInspector.SourceFrame.prototype._handleKeyDown):
  52560. (WebInspector.SourceFrame.prototype._handleSave):
  52561. (WebInspector.SourceFrame.prototype._handleRevertEditing):
  52562. (WebInspector.SourceFrame.prototype._doubleClick):
  52563. * inspector/front-end/TextEditorModel.js:
  52564. (WebInspector.TextEditorModel.prototype.get text):
  52565. * inspector/front-end/TextViewer.js:
  52566. (WebInspector.TextViewer.prototype.get readOnly):
  52567. (WebInspector.TextEditorMainPanel):
  52568. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  52569. (WebInspector.TextEditorMainPanel.prototype.get readOnly):
  52570. 2011-03-10 Greg Simon <gregsimon@chromium.org>
  52571. Reviewed by Pavel Feldman.
  52572. Web Inspector: Need new graphic icon for garbage collect button.
  52573. https://bugs.webkit.org/show_bug.cgi?id=55794
  52574. No new tests: gc tests are flaky due to non-determinisic
  52575. behavior of collection APIs (more notes in bug)
  52576. * English.lproj/localizedStrings.js:
  52577. * WebCore.gypi:
  52578. * bindings/js/ScriptProfiler.cpp:
  52579. (WebCore::ScriptProfiler::collectGarbage):
  52580. * bindings/js/ScriptProfiler.h:
  52581. * bindings/v8/ScriptProfiler.cpp:
  52582. (WebCore::ScriptProfiler::collectGarbage):
  52583. * bindings/v8/ScriptProfiler.h:
  52584. * inspector/Inspector.idl:
  52585. * inspector/InspectorProfilerAgent.cpp:
  52586. (WebCore::InspectorProfilerAgent::collectGarbage):
  52587. * inspector/InspectorProfilerAgent.h:
  52588. * inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
  52589. * inspector/front-end/TimelinePanel.js:
  52590. (WebInspector.TimelinePanel.prototype.get statusBarItems):
  52591. (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
  52592. (WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
  52593. * inspector/front-end/inspector.css:
  52594. (.garbage-collect-status-bar-item .glyph):
  52595. 2011-03-10 Andrey Kosyakov <caseq@chromium.org>
  52596. Web Inspector: better names for HAR export commands
  52597. https://bugs.webkit.org/show_bug.cgi?id=56097
  52598. Rename Export to HAR to Copy entry/network log as HAR
  52599. Expose Copy as HAR unconditionally, remove related settings entry.
  52600. * English.lproj/localizedStrings.js:
  52601. * inspector/front-end/NetworkPanel.js:
  52602. (WebInspector.NetworkPanel.prototype._contextMenu):
  52603. * inspector/front-end/Settings.js:
  52604. 2011-03-10 Qi Zhang <qi.2.zhang@nokia.com>
  52605. Reviewed by Laszlo Gombos.
  52606. [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
  52607. https://bugs.webkit.org/show_bug.cgi?id=48636
  52608. Fix a typo in features.pri that turns on this feature on mobile
  52609. devices by default.
  52610. * features.pri:
  52611. 2011-03-10 Alexander Pavlov <apavlov@chromium.org>
  52612. Reviewed by Pavel Feldman.
  52613. Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
  52614. https://bugs.webkit.org/show_bug.cgi?id=56092
  52615. * inspector/front-end/CSSStyleModel.js:
  52616. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  52617. 2011-03-10 Pavel Feldman <pfeldman@chromium.org>
  52618. Not reviewed: rolling out r80478 and its follow ups for breaking
  52619. inspector and engadget.com.
  52620. https://bugs.webkit.org/show_bug.cgi?id=49401
  52621. * dom/Document.cpp:
  52622. (WebCore::Document::Document):
  52623. (WebCore::performTask):
  52624. (WebCore::Document::postTask):
  52625. * dom/Document.h:
  52626. * loader/FrameLoader.cpp:
  52627. (WebCore::FrameLoader::setDefersLoading):
  52628. * manual-tests/database-callback-deferred.html: Removed.
  52629. * page/PageGroupLoadDeferrer.cpp:
  52630. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  52631. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  52632. 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  52633. Reviewed by Kenneth Rohde Christiansen.
  52634. Tiled backing store's delegated scroll request uses incorrect convention
  52635. https://bugs.webkit.org/show_bug.cgi?id=56011
  52636. Use a point instead of delta, when relaying the scroll request from
  52637. ScrollView::setScrollPosition.
  52638. * loader/EmptyClients.h:
  52639. (WebCore::EmptyChromeClient::delegatedScrollRequested):
  52640. * page/Chrome.cpp:
  52641. (WebCore::Chrome::delegatedScrollRequested):
  52642. * page/Chrome.h:
  52643. * page/ChromeClient.h:
  52644. * platform/HostWindow.h:
  52645. * platform/ScrollView.cpp:
  52646. (WebCore::ScrollView::setScrollPosition):
  52647. 2011-03-10 Pavel Feldman <pfeldman@chromium.org>
  52648. Reviewed by Yury Semikhatsky.
  52649. Web Inspector: brush up DOM agent API.
  52650. https://bugs.webkit.org/show_bug.cgi?id=56093
  52651. * inspector/Inspector.idl:
  52652. * inspector/InspectorDOMAgent.cpp:
  52653. (WebCore::InspectorDOMAgent::childNodes):
  52654. (WebCore::InspectorDOMAgent::setNodeName):
  52655. (WebCore::InspectorDOMAgent::outerHTML):
  52656. (WebCore::InspectorDOMAgent::setNodeValue):
  52657. * inspector/InspectorDOMAgent.h:
  52658. * inspector/front-end/DOMAgent.js:
  52659. (WebInspector.DOMNode):
  52660. (WebInspector.DOMNode.prototype.hasAttributes):
  52661. (WebInspector.DOMNode.prototype.nodeType):
  52662. (WebInspector.DOMNode.prototype.nodeName):
  52663. (WebInspector.DOMNode.prototype.setNodeName):
  52664. (WebInspector.DOMNode.prototype.localName):
  52665. (WebInspector.DOMNode.prototype.nodeValue):
  52666. (WebInspector.DOMNode.prototype.setNodeValue):
  52667. (WebInspector.DOMNode.prototype.setAttribute):
  52668. (WebInspector.DOMNode.prototype.attributes):
  52669. (WebInspector.DOMNode.prototype.removeAttribute):
  52670. (WebInspector.DOMNode.prototype.childNodes.mycallback):
  52671. (WebInspector.DOMNode.prototype.childNodes):
  52672. (WebInspector.DOMNode.prototype.outerHTML):
  52673. (WebInspector.DOMNode.prototype.setOuterHTML):
  52674. (WebInspector.DOMNode.prototype.removeNode):
  52675. (WebInspector.DOMNode.prototype.copyNode):
  52676. (WebInspector.DOMNode.prototype.path):
  52677. (WebInspector.DOMNode.prototype._setAttributesPayload):
  52678. (WebInspector.DOMNode.prototype._addAttribute):
  52679. (WebInspector.DOMAgent.prototype._characterDataModified):
  52680. * inspector/front-end/ElementsPanel.js:
  52681. (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  52682. (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
  52683. (WebInspector.ElementsPanel.prototype.handleCopyEvent):
  52684. * inspector/front-end/ElementsTreeOutline.js:
  52685. (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
  52686. (WebInspector.ElementsTreeElement):
  52687. (WebInspector.ElementsTreeElement.prototype.updateChildren):
  52688. (WebInspector.ElementsTreeElement.prototype._updateChildren):
  52689. (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
  52690. (WebInspector.ElementsTreeElement.prototype._startEditing):
  52691. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  52692. (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
  52693. (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
  52694. (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
  52695. (WebInspector.ElementsTreeElement.prototype._attributeHTML):
  52696. ():
  52697. * inspector/front-end/EventListenersSidebarPane.js:
  52698. ():
  52699. * inspector/front-end/MetricsSidebarPane.js:
  52700. * inspector/front-end/StylesSidebarPane.js:
  52701. * inspector/front-end/utilities.js:
  52702. 2011-03-09 Alexander Pavlov <apavlov@chromium.org>
  52703. Reviewed by Pavel Feldman.
  52704. Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
  52705. https://bugs.webkit.org/show_bug.cgi?id=56002
  52706. * inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
  52707. 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
  52708. Reviewed by Pavel Feldman.
  52709. Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
  52710. https://bugs.webkit.org/show_bug.cgi?id=56034
  52711. * inspector/front-end/DebuggerPresentationModel.js:
  52712. (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
  52713. (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
  52714. (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
  52715. (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
  52716. (WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
  52717. * inspector/front-end/ScriptsPanel.js:
  52718. (WebInspector.ScriptsPanel.prototype._createSourceFrame):
  52719. (WebInspector.SourceFrameDelegateForScriptsPanel):
  52720. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
  52721. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
  52722. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
  52723. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
  52724. (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
  52725. * inspector/front-end/SourceFrame.js:
  52726. (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
  52727. (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
  52728. (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
  52729. (WebInspector.SourceFrame.prototype._contextMenu):
  52730. (WebInspector.SourceFrame.prototype._mouseDown):
  52731. (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
  52732. (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
  52733. 2011-03-09 Alexander Pavlov <apavlov@chromium.org>
  52734. Reviewed by Pavel Feldman.
  52735. Web Inspector: elements dom tree - word wrap toggle
  52736. https://bugs.webkit.org/show_bug.cgi?id=44311
  52737. A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
  52738. and persisted into application settings.
  52739. * English.lproj/localizedStrings.js:
  52740. * inspector/front-end/ElementsPanel.js:
  52741. (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
  52742. (WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
  52743. * inspector/front-end/ElementsTreeOutline.js:
  52744. (WebInspector.ElementsTreeOutline):
  52745. (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
  52746. (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
  52747. (WebInspector.ElementsTreeElement.prototype.onreveal):
  52748. * inspector/front-end/Settings.js:
  52749. (WebInspector.Settings):
  52750. * inspector/front-end/inspector.css:
  52751. (#elements-content.nowrap):
  52752. (#elements-content > ol):
  52753. 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
  52754. Reviewed by Pavel Feldman.
  52755. Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
  52756. https://bugs.webkit.org/show_bug.cgi?id=55823
  52757. * inspector/front-end/BreakpointsSidebarPane.js:
  52758. (WebInspector.JavaScriptBreakpointsSidebarPane):
  52759. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet):
  52760. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
  52761. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
  52762. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
  52763. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
  52764. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
  52765. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
  52766. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
  52767. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
  52768. (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
  52769. * inspector/front-end/DebuggerPresentationModel.js:
  52770. (WebInspector.DebuggerPresentationModel):
  52771. (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
  52772. (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
  52773. (WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints):
  52774. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
  52775. (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
  52776. (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
  52777. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  52778. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  52779. (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  52780. (WebInspector.DebuggerPresentationModel.prototype.reset):
  52781. * inspector/front-end/ScriptsPanel.js:
  52782. (WebInspector.ScriptsPanel):
  52783. (WebInspector.ScriptsPanel.prototype._breakpointAdded):
  52784. (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
  52785. (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  52786. (WebInspector.ScriptsPanel.prototype.reset):
  52787. (WebInspector.ScriptsPanel.prototype._clearInterface):
  52788. 2011-03-10 Andrey Adaikin <aandrey@google.com>
  52789. Reviewed by Pavel Feldman.
  52790. Web Inspector: Highlighter refactoring
  52791. https://bugs.webkit.org/show_bug.cgi?id=56015
  52792. * inspector/front-end/TextEditorHighlighter.js:
  52793. (WebInspector.TextEditorHighlighter):
  52794. (WebInspector.TextEditorHighlighter.prototype.set mimeType):
  52795. (WebInspector.TextEditorHighlighter.prototype.highlight):
  52796. (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
  52797. (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
  52798. (WebInspector.TextEditorHighlighter.prototype._highlightLines):
  52799. (WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
  52800. (WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
  52801. * inspector/front-end/TextViewer.js:
  52802. (WebInspector.TextEditorMainPanel.prototype._buildChunks):
  52803. (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
  52804. 2011-03-05 Pavel Podivilov <podivilov@chromium.org>
  52805. Reviewed by Pavel Feldman.
  52806. Web Inspector: move breakpoint column adjustment to debugger model.
  52807. https://bugs.webkit.org/show_bug.cgi?id=55821
  52808. Test: inspector/debugger/debug-inlined-scripts.html
  52809. * inspector/front-end/DebuggerModel.js:
  52810. (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
  52811. (WebInspector.DebuggerModel.prototype.setBreakpoint):
  52812. * inspector/front-end/SourceFrameContent.js:
  52813. (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
  52814. 2011-01-21 John Knottenbelt <jknotten@chromium.org>
  52815. Reviewed by Dmitry Titov.
  52816. Detach Geolocation from Frame when Page destroyed.
  52817. https://bugs.webkit.org/show_bug.cgi?id=52877
  52818. On Page destruction, any outstanding Geolocation permission
  52819. requests should be cancelled, because the Geolocation can only
  52820. access the client indirectly via m_frame->page().
  52821. Page destruction is signalled by a call to the
  52822. Frame::pageDestroyed() method. This explictly calls
  52823. DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
  52824. Geolocation::reset() detaches from the GeolocationController,
  52825. cancels requests, watches and single shots, and sets the
  52826. permission state back to Unknown.
  52827. Frame::pageDestroyed() is also called by FrameLoader even though
  52828. the page is not destroyed. We should still cancel permission
  52829. requests, because the GeolocationClient will become inaccessible
  52830. to the Geolocation object after this call.
  52831. Frame::transferChildFrameToNewDocument also indirectly calls
  52832. Geolocation::reset when the frame is reparented between
  52833. pages. Ideally we would like the Geolocation's activities to
  52834. continue after reparenting, see bug
  52835. https://bugs.webkit.org/show_bug.cgi?id=55577
  52836. Since GeolocationController is owned by Page, and all Geolocation
  52837. objects will now unsubscribe from the GeolocationController on
  52838. pageDetached(), we no longer need to call stopUpdating() from the
  52839. GeolocationController's destructor. Instead we can simply assert
  52840. that there should be no no observers. See related bug
  52841. https://bugs.webkit.org/show_bug.cgi?id=52216 .
  52842. Introduced new method 'numberOfPendingPermissionRequests' on
  52843. GeolocationClientMock to count the number of outstanding pending
  52844. permission requests. This provides a reusable implementation for
  52845. client-based implementations of the LayoutTestController's
  52846. numberOfPendingGeolocationPermissionRequests method.
  52847. Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
  52848. * page/DOMWindow.cpp:
  52849. (WebCore::DOMWindow::resetGeolocation):
  52850. * page/DOMWindow.h:
  52851. * page/Frame.cpp:
  52852. (WebCore::Frame::pageDestroyed):
  52853. (WebCore::Frame::transferChildFrameToNewDocument):
  52854. * page/Geolocation.cpp:
  52855. (WebCore::Geolocation::~Geolocation):
  52856. (WebCore::Geolocation::page):
  52857. (WebCore::Geolocation::reset):
  52858. (WebCore::Geolocation::disconnectFrame):
  52859. (WebCore::Geolocation::lastPosition):
  52860. (WebCore::Geolocation::requestPermission):
  52861. (WebCore::Geolocation::startUpdating):
  52862. (WebCore::Geolocation::stopUpdating):
  52863. * page/Geolocation.h:
  52864. * page/GeolocationController.cpp:
  52865. (WebCore::GeolocationController::~GeolocationController):
  52866. * page/Navigator.cpp:
  52867. (WebCore::Navigator::resetGeolocation):
  52868. * page/Navigator.h:
  52869. * platform/mock/GeolocationClientMock.cpp:
  52870. (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  52871. * platform/mock/GeolocationClientMock.h:
  52872. 2011-03-10 Ojan Vafai <ojan@chromium.org>
  52873. Reviewed by Darin Adler.
  52874. Able to move nodes across documents
  52875. https://bugs.webkit.org/show_bug.cgi?id=19524
  52876. Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
  52877. This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
  52878. match Gecko or the spec that will need to be updated in a following patch.
  52879. Test: fast/dom/move-nodes-across-documents.html
  52880. * dom/Element.cpp:
  52881. (WebCore::Element::removeAttributeNode):
  52882. * dom/NamedNodeMap.cpp:
  52883. (WebCore::NamedNodeMap::setNamedItem):
  52884. * dom/Node.cpp:
  52885. (WebCore::Node::setDocumentRecursively):
  52886. (WebCore::checkAcceptChild):
  52887. (WebCore::Node::checkReplaceChild):
  52888. * dom/Range.cpp:
  52889. (WebCore::Range::insertNode):
  52890. (WebCore::Range::surroundContents):
  52891. 2011-03-09 Antti Koivisto <antti@apple.com>
  52892. Not reviewed.
  52893. Reverting crash catching code, the bug being hunted was fixed by
  52894. http://trac.webkit.org/changeset/80686
  52895. * loader/cache/CachedResourceLoader.cpp:
  52896. (WebCore::CachedResourceLoader::CachedResourceLoader):
  52897. (WebCore::CachedResourceLoader::~CachedResourceLoader):
  52898. (WebCore::CachedResourceLoader::requestImage):
  52899. (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
  52900. (WebCore::CachedResourceLoader::requestResource):
  52901. (WebCore::CachedResourceLoader::setAutoLoadImages):
  52902. (WebCore::CachedResourceLoader::load):
  52903. (WebCore::CachedResourceLoader::loadDone):
  52904. (WebCore::CachedResourceLoader::preload):
  52905. (WebCore::CachedResourceLoader::requestPreload):
  52906. * loader/cache/CachedResourceLoader.h:
  52907. 2011-03-09 Peter Kasting <pkasting@google.com>
  52908. Unreviewed, build fix.
  52909. * StringsNotToBeLocalized.txt: Add function names I forgot.
  52910. * platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE,
  52911. since they don't compile anyway. Use ZeroMemory() instead of "= {0}"
  52912. since Qt is stupid and (sometimes?!) warns about it.
  52913. (WebCore::windowsVersion):
  52914. (WebCore::processorArchitecture):
  52915. 2011-03-09 Peter Kasting <pkasting@google.com>
  52916. Reviewed by Ryosuke Niwa.
  52917. Add UA string tags for Windows 64.
  52918. https://bugs.webkit.org/show_bug.cgi?id=55226
  52919. * StringsNotToBeLocalized.txt:
  52920. * platform/win/SystemInfo.cpp:
  52921. (WebCore::osVersionForUAString):
  52922. (WebCore::isWOW64):
  52923. (WebCore::processorArchitecture):
  52924. (WebCore::architectureTokenForUAString):
  52925. (WebCore::windowsVersionForUAString):
  52926. 2011-03-09 Peter Kasting <pkasting@google.com>
  52927. Unreviewed, attempted build fix.
  52928. * WebCore.pri: Try to update include path for Qt Windows build.
  52929. 2011-03-09 Peter Kasting <pkasting@google.com>
  52930. Unreviewed, build fix.
  52931. * platform/win/SystemInfo.cpp:
  52932. (WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.
  52933. 2011-03-09 Peter Kasting <pkasting@google.com>
  52934. Reviewed by Mihai Parparita.
  52935. Unify Windows version checks.
  52936. https://bugs.webkit.org/show_bug.cgi?id=55979
  52937. * GNUmakefile.am: Fix spaces -> tabs.
  52938. * StringsNotToBeLocalized.txt:
  52939. * WebCore.pro: Add SystemInfo.* to Qt build.
  52940. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  52941. (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
  52942. (WebCore::ScrollbarThemeChromiumWin::getThemeState):
  52943. (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
  52944. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  52945. (WebCore::fillBMPGlyphs):
  52946. * platform/win/CursorWin.cpp:
  52947. (WebCore::createSharedCursor):
  52948. * platform/win/ScrollbarThemeWin.cpp:
  52949. (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
  52950. * platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
  52951. (WebCore::windowsVersion):
  52952. (WebCore::windowsVersionForUAString):
  52953. * platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
  52954. * rendering/RenderThemeChromiumWin.cpp:
  52955. (WebCore::getNonClientMetrics):
  52956. * rendering/RenderThemeWin.cpp:
  52957. (WebCore::RenderThemeWin::getThemeData):
  52958. (WebCore::RenderThemeWin::paintMenuList):
  52959. (WebCore::RenderThemeWin::paintMenuListButton):
  52960. 2011-03-09 Mihai Parparita <mihaip@chromium.org>
  52961. Reviewed by Tony Gentilcore.
  52962. REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
  52963. https://bugs.webkit.org/show_bug.cgi?id=53045
  52964. Copy the URL out of the CachedResource that is being revalidated, so
  52965. that we can still use it (in m_validatedURLs) after removing the
  52966. resource from the memory cache, which may delete it.
  52967. No new tests, since I was not able to trigger this locally (in a layout
  52968. test or otherwise).
  52969. * loader/cache/CachedResourceLoader.cpp:
  52970. (WebCore::CachedResourceLoader::revalidateResource):
  52971. 2011-03-09 Chris Fleizach <cfleizach@apple.com>
  52972. Reviewed by Beth Dakin.
  52973. VO reporting incorrect list count for http://www.macworld.com/news.html
  52974. https://bugs.webkit.org/show_bug.cgi?id=56064
  52975. <li> tags should not be ignored, because they provide valuable information
  52976. to screen readers.
  52977. Test: platform/mac/accessibility/list-items-ignored.html
  52978. * accessibility/AccessibilityRenderObject.cpp:
  52979. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  52980. 2011-03-09 Dan Bernstein <mitz@apple.com>
  52981. Reviewed by Dave Hyatt.
  52982. <rdar://problem/8733254> Float disappears after incremental layout
  52983. Fixed the original bug and a copule more issues noticed while doing so.
  52984. Tests: fast/dynamic/dirty-float-in-clean-line.html
  52985. fast/dynamic/float-at-line-break.html
  52986. fast/dynamic/float-from-empty-line.html
  52987. * rendering/RenderBlock.h:
  52988. * rendering/RenderBlockLineLayout.cpp:
  52989. (WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
  52990. update the line break info of the last line with the new line break position. This is tested
  52991. by float-from-empty-line.html.
  52992. (WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
  52993. into this new function.
  52994. (WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
  52995. (WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
  52996. floats, as they may yet become dirty because of the floats. This is tested by
  52997. dirty-float-in-clean-line.html.
  52998. (WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
  52999. break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
  53000. next one does not, the float will not make it into any line. This is tested by
  53001. float-at-line-break.html.
  53002. 2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
  53003. Reviewed by Kent Tamura.
  53004. selectionStart reports wrong caret position when the last characters are newlines
  53005. https://bugs.webkit.org/show_bug.cgi?id=56061
  53006. The bug was caused by SelectionController::setSelection's not calling
  53007. notifyRendererOfSelectionChange when old selection was equal to new selection.
  53008. Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
  53009. this condition holds after the command is executed. However, the values of
  53010. selectionStart and selectionEnd still need to be updated in this case because
  53011. the offsets counted from the beginning of textarea have been increased by 1.
  53012. * editing/SelectionController.cpp:
  53013. (WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange
  53014. when m_selection = s.
  53015. * manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
  53016. 2011-03-09 Andy Estes <aestes@apple.com>
  53017. Reviewed by Adam Barth.
  53018. Bad cast in HTMLTreeBuilder::processStartTag
  53019. https://bugs.webkit.org/show_bug.cgi?id=55955
  53020. Test: fast/parser/self-closing-foreign-content.html
  53021. When the parser encounters an svg or mathml root element, it places the
  53022. insertion mode into InForeignContentMode. However, if the root element
  53023. is self-closing (e.g. <svg />) then the element is never placed on the
  53024. open elements stack. This leaves the parser in an inconsistent state
  53025. where it is in InForeignContentMode but no foreign content is in the
  53026. open element stack.
  53027. * html/parser/HTMLTreeBuilder.cpp:
  53028. (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
  53029. foreign element is inserted into the tree, do not set the insertion
  53030. mode to InForeignContentMode.
  53031. 2011-03-09 Gavin Barraclough <barraclough@apple.com>
  53032. Qt build fix.
  53033. * bridge/qt/qt_runtime.cpp:
  53034. (JSC::Bindings::convertQVariantToValue):
  53035. 2011-03-09 Andy Estes <aestes@apple.com>
  53036. Reviewed by Adam Barth.
  53037. REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
  53038. https://bugs.webkit.org/show_bug.cgi?id=55982
  53039. Test: fast/parser/fragment-foreign-content-misnested.html
  53040. It is a parse error to encounter certain start tags while the parser's
  53041. insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
  53042. are to pop open elements off the HTMLElementStack until a foreign
  53043. content scope marker is encountered. Before the change in r80320 to not
  53044. insert a fake HTML element during fragment parsing, said fake HTML
  53045. element counted as a foreign content scope marker.
  53046. With r80320, no fake HTML element is inserted and the stack is popped
  53047. until empty in cases where no other element claims to be a foreign
  53048. content scope marker. Fix this by treating the DocumentFragment as a
  53049. foreign content scope marker.
  53050. * html/parser/HTMLElementStack.cpp:
  53051. (WebCore::HTMLNames::isForeignContentScopeMarker): Take a
  53052. ContainerNode* instead of a Element*.
  53053. (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
  53054. topNode() to isForeignContentScopeMarker() instead of top().
  53055. 2011-03-09 Gavin Barraclough <barraclough@apple.com>
  53056. Reviewed by Darin Adler.
  53057. Bug 56041 - RexExp constructor should only accept flags "gim"
  53058. We also should be passing the flags around as a bitfield rather than a string,
  53059. and should not have redundant, incompatible code for converting the string to a bitfield!
  53060. * bindings/js/SerializedScriptValue.cpp:
  53061. (WebCore::CloneDeserializer::readTerminal):
  53062. - Need to parse flags string back to enum.
  53063. 2011-03-09 James Robinson <jamesr@chromium.org>
  53064. Reviewed by Kenneth Russell.
  53065. [chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
  53066. https://bugs.webkit.org/show_bug.cgi?id=56021
  53067. Initializes the m_doubleSided flag of LayerChromiums to the default
  53068. value of true so the back sides of layers without
  53069. backface-visibility:hidden are rendered.
  53070. Test: compositing/backface-visibility.html
  53071. * platform/graphics/chromium/LayerChromium.cpp:
  53072. (WebCore::LayerChromium::LayerChromium):
  53073. 2011-03-09 David Hyatt <hyatt@apple.com>
  53074. Reviewed by Dan Bernstein.
  53075. <rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
  53076. Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
  53077. text. That way we use the same metrics as for horizontal.
  53078. This fixes regressions in fast/lists and fast/overflow vertical text tests.
  53079. * platform/graphics/mac/SimpleFontDataMac.mm:
  53080. (WebCore::SimpleFontData::platformInit):
  53081. (WebCore::SimpleFontData::platformBoundsForGlyph):
  53082. 2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
  53083. Reviewed by Tony Chang.
  53084. REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
  53085. https://bugs.webkit.org/show_bug.cgi?id=56004
  53086. The crash was caused by the false assumption that rootEditableElement() or documentElement()
  53087. always return non-null pointer. Fixed the bug by adding an early exit.
  53088. Test: editing/selection/extend-by-line-in-empty-document.html
  53089. * editing/visible_units.cpp:
  53090. (WebCore::previousLinePosition):
  53091. (WebCore::nextLinePosition):
  53092. 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
  53093. Reviewed by Pavel Feldman.
  53094. Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
  53095. https://bugs.webkit.org/show_bug.cgi?id=56024
  53096. * English.lproj/localizedStrings.js:
  53097. * inspector/front-end/CallStackSidebarPane.js:
  53098. (WebInspector.CallStackSidebarPane):
  53099. (WebInspector.CallStackSidebarPane.prototype.update):
  53100. (WebInspector.CallStackSidebarPane.prototype._contextMenu):
  53101. 2011-03-09 David Hyatt <hyatt@apple.com>
  53102. Reviewed by Darin Adler.
  53103. Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
  53104. places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
  53105. and FontCache.
  53106. * platform/graphics/chromium/FontPlatformDataLinux.cpp:
  53107. (WebCore::FontPlatformData::FontPlatformData):
  53108. * platform/graphics/chromium/FontPlatformDataLinux.h:
  53109. (WebCore::FontPlatformData::FontPlatformData):
  53110. 2011-03-09 Steve Block <steveblock@google.com>
  53111. Reviewed by Jeremy Orlow.
  53112. JavaNPObject should not use JNI directly
  53113. https://bugs.webkit.org/show_bug.cgi?id=56009
  53114. We move the JNI code to access a Java object's fields into
  53115. a new JavaInstance::getField() method.
  53116. No new tests, refactoring only.
  53117. * bridge/jni/v8/JavaInstanceV8.cpp:
  53118. (JavaInstance::getField):
  53119. * bridge/jni/v8/JavaInstanceV8.h:
  53120. * bridge/jni/v8/JavaNPObjectV8.cpp:
  53121. (JSC::Bindings::JavaNPObjectGetProperty):
  53122. 2011-03-09 Steve Block <steveblock@google.com>
  53123. Reviewed by Jeremy Orlow.
  53124. NPAPI - jvalue conversion should not be in JavaInstance
  53125. https://bugs.webkit.org/show_bug.cgi?id=55967
  53126. No new tests, refactoring only.
  53127. * bridge/jni/v8/JavaInstanceV8.cpp:
  53128. (JavaInstance::invokeMethod):
  53129. * bridge/jni/v8/JavaInstanceV8.h:
  53130. * bridge/jni/v8/JavaNPObjectV8.cpp:
  53131. (JSC::Bindings::JavaNPObjectInvoke):
  53132. 2011-03-09 Jessie Berlin <jberlin@apple.com>
  53133. Reviewed by Adam Roben.
  53134. Use the Cookie Storage from the Private Browsing Storage Session directly
  53135. https://bugs.webkit.org/show_bug.cgi?id=55986
  53136. * WebCore.exp.in:
  53137. * platform/mac/WebCoreSystemInterface.h:
  53138. * platform/mac/WebCoreSystemInterface.mm:
  53139. * platform/network/mac/CookieStorageMac.mm:
  53140. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  53141. Just copy the cookie storage from the private browsing storage session.
  53142. * platform/network/cf/CookieStorageCFNet.cpp:
  53143. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  53144. Ditto.
  53145. 2011-03-09 Andrey Kosyakov <caseq@chromium.org>
  53146. Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)
  53147. * inspector/InspectorInstrumentation.cpp:
  53148. (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  53149. 2011-03-09 Yury Semikhatsky <yurys@chromium.org>
  53150. Reviewed by Pavel Feldman.
  53151. Web Inspector: pass explicit agent references to InspectorBackendDispatcher
  53152. https://bugs.webkit.org/show_bug.cgi?id=55820
  53153. * inspector/CodeGeneratorInspector.pm:
  53154. * inspector/InspectorController.cpp:
  53155. (WebCore::InspectorController::InspectorController):
  53156. (WebCore::InspectorController::connectFrontend):
  53157. (WebCore::InspectorController::disconnectFrontend):
  53158. (WebCore::InspectorController::dispatchMessageFromFrontend):
  53159. 2011-03-09 Andrey Kosyakov <caseq@chromium.org>
  53160. Reviewed by Pavel Feldman.
  53161. Web Inspector: resource errors are not reported before front-end is opened
  53162. https://bugs.webkit.org/show_bug.cgi?id=55939
  53163. * inspector/InspectorInstrumentation.cpp:
  53164. (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  53165. * inspector/InspectorInstrumentation.h:
  53166. (WebCore::InspectorInstrumentation::didReceiveResourceResponse):
  53167. (WebCore::InspectorInstrumentation::didFailLoading):
  53168. 2011-03-08 Hans Wennborg <hans@chromium.org>
  53169. Reviewed by Jeremy Orlow.
  53170. IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
  53171. https://bugs.webkit.org/show_bug.cgi?id=55948
  53172. Add a parameter that allows for selection of alternative backing store
  53173. implementations.
  53174. No new tests: no new functionality.
  53175. * storage/IDBFactory.cpp:
  53176. (WebCore::IDBFactory::open):
  53177. * storage/IDBFactoryBackendImpl.cpp:
  53178. (WebCore::IDBFactoryBackendImpl::open):
  53179. * storage/IDBFactoryBackendImpl.h:
  53180. * storage/IDBFactoryBackendInterface.h:
  53181. 2011-03-08 Steve Block <steveblock@google.com>
  53182. Reviewed by Jeremy Orlow.
  53183. Factor out JNI method call to be used by both JSC and V8
  53184. https://bugs.webkit.org/show_bug.cgi?id=55966
  53185. No new tests, refactoring only.
  53186. * bridge/jni/JNIUtility.cpp:
  53187. (JSC::Bindings::callJNIMethod):
  53188. * bridge/jni/JNIUtility.h:
  53189. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  53190. (JavaInstance::invokeMethod):
  53191. * bridge/jni/v8/JavaInstanceV8.cpp:
  53192. (JavaInstance::invokeMethod):
  53193. 2011-03-09 Andrey Adaikin <aandrey@google.com>
  53194. Reviewed by Pavel Feldman.
  53195. Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
  53196. https://bugs.webkit.org/show_bug.cgi?id=55818
  53197. * inspector/front-end/TextViewer.js:
  53198. (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
  53199. 2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
  53200. Reviewed by Yury Semikhatsky.
  53201. Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
  53202. https://bugs.webkit.org/show_bug.cgi?id=55998
  53203. * inspector/InjectedScriptSource.js:
  53204. 2011-03-09 Pavel Feldman <pfeldman@chromium.org>
  53205. Reviewed by Yury Semikhatsky.
  53206. Web Inspector: watch expressions should show string values in quotes.
  53207. https://bugs.webkit.org/show_bug.cgi?id=55846
  53208. * inspector/InjectedScriptSource.js:
  53209. * inspector/front-end/ObjectPropertiesSection.js:
  53210. (WebInspector.ObjectPropertyTreeElement.prototype.update):
  53211. * inspector/front-end/RemoteObject.js:
  53212. (WebInspector.LocalJSONObject.prototype.get description):
  53213. * inspector/front-end/WatchExpressionsSidebarPane.js:
  53214. (WebInspector.WatchExpressionsSection.prototype.update):
  53215. * inspector/front-end/inspector.css:
  53216. (.console-formatted-string, .console-formatted-regexp):
  53217. 2011-03-09 Pavel Feldman <pfeldman@chromium.org>
  53218. Reviewed by Yury Semikhatsky.
  53219. Web Inspector: "length" getter is invoked upon console object formatting.
  53220. https://bugs.webkit.org/show_bug.cgi?id=55220
  53221. * inspector/InjectedScriptSource.js:
  53222. 2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
  53223. Reviewed by Pavel Feldman.
  53224. Web Inspector: remove groupName from objectId.
  53225. https://bugs.webkit.org/show_bug.cgi?id=55825
  53226. * inspector/InjectedScriptSource.js:
  53227. 2011-03-08 Xiaomei Ji <xji@chromium.org>
  53228. Reviewed by David Hyatt.
  53229. Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
  53230. https://bugs.webkit.org/show_bug.cgi?id=55077.
  53231. Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
  53232. is negative, should include the position value into overhang rectangle's
  53233. starting position.
  53234. Tests: fast/dom/scroll-reveal-left-overflow.html
  53235. fast/dom/scroll-reveal-top-overflow.html
  53236. * platform/ScrollView.cpp:
  53237. (WebCore::ScrollView::calculateOverhangAreasForPainting):
  53238. 2011-03-08 Daniel Bates <dbates@rim.com>
  53239. Reviewed by Darin Adler.
  53240. Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
  53241. https://bugs.webkit.org/show_bug.cgi?id=55351
  53242. By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
  53243. can be called on an array A without the caller explicitly specifying the size of A.
  53244. No functionality was changed. So no new tests.
  53245. * css/CSSMutableStyleDeclaration.cpp:
  53246. (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
  53247. CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
  53248. (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
  53249. to better reflect its purpose - to be the size of the passed array.
  53250. (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
  53251. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
  53252. (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
  53253. * css/CSSMutableStyleDeclaration.h:
  53254. (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
  53255. the size of a passed array. Changed type of second argument to size_t since it represents the size of
  53256. an array.
  53257. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
  53258. (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
  53259. 2011-03-08 Enrica Casucci <enrica@apple.com>
  53260. Reviewed by Darin Adler.
  53261. REGRESSION: Copied content loses formatting on paste to external apps.
  53262. https://bugs.webkit.org/show_bug.cgi?id=47615
  53263. <rdar://problem/9001214>
  53264. This is a resubmission of a patch that was landed a while ago then rolled
  53265. back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
  53266. This patch adds a way for WebKit2 to create NSAttributedStrings from
  53267. a DOM range without using the AppKit api initWithDOMRange that internally
  53268. needs to access the WebView. The NSAttributedString is needed to create
  53269. RTF formats in the pasteboard.
  53270. This is to be considered a first step, since in the future we want to have
  53271. an implementation based on the TextIterator.
  53272. * WebCore.xcodeproj/project.pbxproj:
  53273. * platform/mac/HTMLConverter.h: Added.
  53274. * platform/mac/HTMLConverter.mm: Added.
  53275. * platform/mac/PasteboardMac.mm:
  53276. (WebCore::Pasteboard::writeSelection):
  53277. 2011-03-08 James Robinson <jamesr@chromium.org>
  53278. Reviewed by Kenneth Russell.
  53279. [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
  53280. https://bugs.webkit.org/show_bug.cgi?id=55900
  53281. This adds an explicit step to synchronize properties from
  53282. LayerChromiums to their corresponding CCLayerImpls.
  53283. * platform/graphics/chromium/LayerChromium.cpp:
  53284. (WebCore::LayerChromium::setBounds):
  53285. * platform/graphics/chromium/LayerChromium.h:
  53286. (WebCore::LayerChromium::bounds):
  53287. (WebCore::LayerChromium::doubleSided):
  53288. (WebCore::LayerChromium::setDoubleSided):
  53289. * platform/graphics/chromium/LayerRendererChromium.cpp:
  53290. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  53291. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  53292. (WebCore::CCLayerImpl::CCLayerImpl):
  53293. (WebCore::CCLayerImpl::updateFromLayer):
  53294. (WebCore::CCLayerImpl::descendantsDrawsContent):
  53295. * platform/graphics/chromium/cc/CCLayerImpl.h:
  53296. (WebCore::CCLayerImpl::anchorPoint):
  53297. (WebCore::CCLayerImpl::anchorPointZ):
  53298. (WebCore::CCLayerImpl::masksToBounds):
  53299. (WebCore::CCLayerImpl::opacity):
  53300. (WebCore::CCLayerImpl::position):
  53301. (WebCore::CCLayerImpl::preserves3D):
  53302. (WebCore::CCLayerImpl::sublayerTransform):
  53303. (WebCore::CCLayerImpl::transform):
  53304. 2011-03-08 James Robinson <jamesr@chromium.org>
  53305. Chromium compile fix.
  53306. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  53307. (WebCore::SimpleFontData::platformInit):
  53308. 2011-03-08 Peter Kasting <pkasting@google.com>
  53309. Reviewed by James Robinson.
  53310. Unify Windows version checks, part 1.
  53311. https://bugs.webkit.org/show_bug.cgi?id=55979
  53312. Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
  53313. now-unnecessary WindowsVersion.cpp from Chromium.
  53314. * GNUmakefile.am:
  53315. * WebCore.gyp/WebCore.gyp:
  53316. * WebCore.gypi:
  53317. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  53318. (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
  53319. (WebCore::ScrollbarThemeChromiumWin::getThemeState):
  53320. (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
  53321. * platform/chromium/WindowsVersion.cpp: Removed.
  53322. * platform/chromium/WindowsVersion.h: Removed.
  53323. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  53324. (WebCore::fillBMPGlyphs):
  53325. * rendering/RenderThemeChromiumWin.cpp:
  53326. (WebCore::getNonClientMetrics):
  53327. 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
  53328. Chromium Linux build fix attempt after r80582.
  53329. * platform/graphics/chromium/FontLinux.cpp:
  53330. (WebCore::Font::drawGlyphs):
  53331. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  53332. (WebCore::SimpleFontData::platformInit):
  53333. * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
  53334. (WebCore::GlyphPage::fill):
  53335. 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
  53336. Mac build fix attempt for r80582.
  53337. * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  53338. (WebCore::disableLigatures):
  53339. 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
  53340. Reviewed by Kent Tamura.
  53341. Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
  53342. https://bugs.webkit.org/show_bug.cgi?id=54937
  53343. * editing/SelectionController.cpp:
  53344. (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
  53345. the document. Also restrained the lifetime of document variable.
  53346. (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
  53347. to determine whether or not position becomes null after removing a node.
  53348. (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
  53349. so call containerNode() instead of deprecatedNode().
  53350. (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
  53351. instead of deprecatedNode() and deprecatedEditingOffset() respectively.
  53352. (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
  53353. instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
  53354. that the specified position is not before or after the shadow root as it violates our assumption.
  53355. * editing/VisibleSelection.cpp:
  53356. (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
  53357. and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
  53358. guaranteed to be an offset inside an anchor node.
  53359. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
  53360. instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
  53361. an editable element isn't editable.
  53362. * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
  53363. and deprecatedEditingOffset() respectively in the following functions because they are exposed to
  53364. DOM, which doesn't have before/after concept.
  53365. (WebCore::DOMSelection::anchorNode):
  53366. (WebCore::DOMSelection::anchorOffset):
  53367. (WebCore::DOMSelection::focusNode):
  53368. (WebCore::DOMSelection::focusOffset):
  53369. (WebCore::DOMSelection::baseNode):
  53370. (WebCore::DOMSelection::baseOffset):
  53371. (WebCore::DOMSelection::extentNode):
  53372. (WebCore::DOMSelection::extentOffset):
  53373. 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
  53374. Reviewed by Adam Roben.
  53375. Correct uninitialized variable in PolicyCallback found while
  53376. running WebKit in BoundsChecker.
  53377. https://bugs.webkit.org/show_bug.cgi?id=45199.
  53378. * loader/PolicyCallback.cpp:
  53379. (WebCore::PolicyCallback::PolicyCallback): Initialize
  53380. m_argument.
  53381. 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
  53382. More build bustage fix.
  53383. * platform/graphics/win/cairo/FontPlatformData.h:
  53384. (WebCore::FontPlatformData::setOrientation): Duplicate accessor
  53385. in WinCairo-local header. This is such a mess!
  53386. 2011-03-08 David Hyatt <hyatt@apple.com>
  53387. Fix build bustage. Hide orientation setting behind a setter and stub it out in all
  53388. FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
  53389. * platform/graphics/SimpleFontData.cpp:
  53390. (WebCore::SimpleFontData::verticalRightOrientationFontData):
  53391. * platform/graphics/cg/FontPlatformData.h:
  53392. (WebCore::FontPlatformData::setOrientation):
  53393. * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  53394. (WebCore::FontPlatformData::setOrientation):
  53395. * platform/graphics/chromium/FontPlatformDataLinux.h:
  53396. (WebCore::FontPlatformData::setOrientation):
  53397. * platform/graphics/cocoa/FontPlatformData.h:
  53398. (WebCore::FontPlatformData::setOrientation):
  53399. * platform/graphics/freetype/FontPlatformData.h:
  53400. (WebCore::FontPlatformData::setOrientation):
  53401. * platform/graphics/qt/FontPlatformData.h:
  53402. (WebCore::FontPlatformData::setOrientation):
  53403. * platform/graphics/wince/FontPlatformData.h:
  53404. (WebCore::FontPlatformData::setOrientation):
  53405. * platform/graphics/wx/FontPlatformData.h:
  53406. (WebCore::FontPlatformData::setOrientation):
  53407. 2011-03-08 Joe Wild <joseph.wild@nokia.com>
  53408. Reviewed by Csaba Osztrogonác.
  53409. [Qt] Missing SVG variables
  53410. https://bugs.webkit.org/show_bug.cgi?id=32941
  53411. Basically, this patch just modifies features.pri to the Qt build to
  53412. pass on the ENABLE_SVG_* flags to the IDL binding generator.
  53413. Also I had remove global-construtors.html from the skip list and
  53414. updated the associated expected results files.
  53415. * features.pri:
  53416. * page/DOMWindow.idl:
  53417. 2011-03-08 Alok priyadarshi <alokp@chromium.org>
  53418. Reviewed by Dimitri Glazkov.
  53419. Plugins needs a way to trigger style recalc
  53420. https://bugs.webkit.org/show_bug.cgi?id=55242
  53421. No test needed. A simple get function is added.
  53422. * platform/graphics/chromium/PluginLayerChromium.h:
  53423. (WebCore::PluginLayerChromium::getTextureId):
  53424. 2011-03-08 David Hyatt <hyatt@apple.com>
  53425. Reviewed by Dan Bernstein.
  53426. https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
  53427. This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
  53428. The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
  53429. Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
  53430. uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
  53431. vertically oriented font that rotates all glyphs.
  53432. The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
  53433. a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
  53434. fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
  53435. work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
  53436. simple or complex code paths, although the simple code path at least gets close.
  53437. Added fast/blockflow/text-orientation-basic.html
  53438. * WebCore.exp.in:
  53439. * WebCore.xcodeproj/project.pbxproj:
  53440. * css/CSSComputedStyleDeclaration.cpp:
  53441. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  53442. * css/CSSFontFaceSource.cpp:
  53443. (WebCore::CSSFontFaceSource::getFontData):
  53444. * css/CSSParser.cpp:
  53445. (WebCore::CSSParser::parseValue):
  53446. * css/CSSPrimitiveValueMappings.h:
  53447. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  53448. (WebCore::CSSPrimitiveValue::operator TextOrientation):
  53449. * css/CSSPropertyNames.in:
  53450. * css/CSSStyleSelector.cpp:
  53451. (WebCore::CSSStyleSelector::applyDeclarations):
  53452. (WebCore::CSSStyleSelector::applyProperty):
  53453. * css/CSSValueKeywords.in:
  53454. * loader/cache/CachedFont.cpp:
  53455. (WebCore::CachedFont::platformDataFromCustomData):
  53456. * loader/cache/CachedFont.h:
  53457. * platform/graphics/FontCache.cpp:
  53458. (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  53459. (WebCore::FontPlatformDataCacheKey::operator==):
  53460. (WebCore::computeHash):
  53461. (WebCore::FontCache::getCachedFontPlatformData):
  53462. * platform/graphics/FontDescription.h:
  53463. (WebCore::FontDescription::FontDescription):
  53464. (WebCore::FontDescription::textOrientation):
  53465. (WebCore::FontDescription::setTextOrientation):
  53466. (WebCore::FontDescription::operator==):
  53467. * platform/graphics/FontFastPath.cpp:
  53468. (WebCore::Font::glyphDataForCharacter):
  53469. (WebCore::offsetToMiddleOfGlyph):
  53470. * platform/graphics/SimpleFontData.cpp:
  53471. (WebCore::SimpleFontData::SimpleFontData):
  53472. (WebCore::SimpleFontData::verticalRightOrientationFontData):
  53473. (WebCore::SimpleFontData::uprightOrientationFontData):
  53474. (WebCore::SimpleFontData::brokenIdeographFontData):
  53475. (WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
  53476. * platform/graphics/SimpleFontData.h:
  53477. (WebCore::SimpleFontData::hasVerticalGlyphs):
  53478. (WebCore::SimpleFontData::isTextOrientationFallback):
  53479. * platform/graphics/cairo/FontCustomPlatformData.h:
  53480. * platform/graphics/cocoa/FontPlatformData.h:
  53481. (WebCore::FontPlatformData::FontPlatformData):
  53482. (WebCore::FontPlatformData::textOrientation):
  53483. (WebCore::FontPlatformData::hash):
  53484. (WebCore::FontPlatformData::operator==):
  53485. * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  53486. (WebCore::FontPlatformData::FontPlatformData):
  53487. (WebCore::FontPlatformData::operator=):
  53488. * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
  53489. (WebCore::FontCustomPlatformData::fontPlatformData):
  53490. * platform/graphics/haiku/FontCustomPlatformData.cpp:
  53491. (WebCore::FontCustomPlatformData::fontPlatformData):
  53492. * platform/graphics/haiku/FontCustomPlatformData.h:
  53493. * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  53494. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  53495. * platform/graphics/mac/FontCacheMac.mm:
  53496. (WebCore::FontCache::createFontPlatformData):
  53497. * platform/graphics/mac/FontCustomPlatformData.cpp:
  53498. (WebCore::FontCustomPlatformData::fontPlatformData):
  53499. * platform/graphics/mac/FontCustomPlatformData.h:
  53500. * platform/graphics/mac/FontMac.mm:
  53501. (WebCore::showGlyphsWithAdvances):
  53502. (WebCore::Font::drawGlyphs):
  53503. * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  53504. (WebCore::shouldUseCoreText):
  53505. (WebCore::GlyphPage::fill):
  53506. * platform/graphics/mac/SimpleFontDataCoreText.cpp:
  53507. (WebCore::SimpleFontData::getCFStringAttributes):
  53508. * platform/graphics/mac/SimpleFontDataMac.mm:
  53509. (WebCore::SimpleFontData::platformInit):
  53510. (WebCore::SimpleFontData::platformBoundsForGlyph):
  53511. (WebCore::SimpleFontData::platformWidthForGlyph):
  53512. * platform/graphics/pango/FontCustomPlatformDataPango.cpp:
  53513. (WebCore::FontCustomPlatformData::fontPlatformData):
  53514. * platform/graphics/qt/FontCustomPlatformData.h:
  53515. * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
  53516. (WebCore::FontCustomPlatformData::fontPlatformData):
  53517. * platform/graphics/skia/FontCustomPlatformData.cpp:
  53518. (WebCore::FontCustomPlatformData::fontPlatformData):
  53519. * platform/graphics/skia/FontCustomPlatformData.h:
  53520. * platform/graphics/win/FontCustomPlatformData.cpp:
  53521. (WebCore::FontCustomPlatformData::fontPlatformData):
  53522. * platform/graphics/win/FontCustomPlatformData.h:
  53523. * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  53524. (WebCore::FontCustomPlatformData::fontPlatformData):
  53525. * platform/graphics/win/FontCustomPlatformDataCairo.h:
  53526. * platform/graphics/wince/FontCustomPlatformData.cpp:
  53527. (WebCore::FontCustomPlatformData::fontPlatformData):
  53528. * platform/graphics/wince/FontCustomPlatformData.h:
  53529. * platform/text/TextOrientation.h: Added.
  53530. * rendering/InlineFlowBox.cpp:
  53531. (WebCore::InlineFlowBox::requiresIdeographicBaseline):
  53532. * rendering/style/RenderStyle.h:
  53533. (WebCore::InheritedFlags::initialTextOrientation):
  53534. 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
  53535. Reviewed by Darin Adler.
  53536. addInlineStyleIfNeeded should take EditingStyle
  53537. https://bugs.webkit.org/show_bug.cgi?id=55950
  53538. Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
  53539. Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
  53540. * editing/ApplyStyleCommand.cpp:
  53541. (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
  53542. (WebCore::StyleChange::init): Ditto.
  53543. (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
  53544. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
  53545. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
  53546. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
  53547. instead of manually merging styles.
  53548. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
  53549. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
  53550. * editing/ApplyStyleCommand.h:
  53551. * editing/CompositeEditCommand.h:
  53552. * editing/EditingStyle.cpp:
  53553. (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
  53554. * editing/EditingStyle.h:
  53555. 2011-03-08 Nico Weber <thakis@chromium.org>
  53556. Reviewed by James Robinson.
  53557. Crash on big blur radius with canvas
  53558. https://bugs.webkit.org/show_bug.cgi?id=55951
  53559. Move the clamping code out of an if branch, so that it happens in the
  53560. canvas case as well.
  53561. Test: fast/canvas/shadow-huge-blur.html
  53562. * platform/graphics/cg/GraphicsContextCG.cpp:
  53563. (WebCore::GraphicsContext::setPlatformShadow):
  53564. 2011-03-08 Chris Fleizach <cfleizach@apple.com>
  53565. Reviewed by Sam Weinig.
  53566. WK2: Cannot set focus on an element when focus is outside of WKView
  53567. https://bugs.webkit.org/show_bug.cgi?id=55281
  53568. In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
  53569. Instead, the focus/unfocus messages need to be sent to the UIProcess side.
  53570. * platform/mac/WidgetMac.mm:
  53571. (WebCore::Widget::setFocus):
  53572. 2011-03-08 Sam Weinig <sam@webkit.org>
  53573. Reviewed by Anders Carlsson.
  53574. Overflow: scroll areas should not paint white in scroll corner if the
  53575. scrollbars are overlay.
  53576. <rdar://problem/9082871>
  53577. * rendering/RenderLayer.cpp:
  53578. (WebCore::RenderLayer::paintScrollCorner):
  53579. Don't paint the scroll corner white if we have overlay scrollbars.
  53580. 2011-03-08 Chris Marrin <cmarrin@apple.com>
  53581. Reviewed by Darin Adler.
  53582. The first time animations are committed they have a bad start time
  53583. https://bugs.webkit.org/show_bug.cgi?id=55947
  53584. Do a check for a returned lastCommitTime of <=0 and replace it
  53585. with the mediaTime.
  53586. * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  53587. (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
  53588. 2011-03-08 James Kozianski <koz@chromium.org>
  53589. Reviewed by David Levin.
  53590. Expose isValidProtocol() in KURL.h.
  53591. https://bugs.webkit.org/show_bug.cgi?id=54594
  53592. This is needed to validate protocols used in calls to
  53593. navigator.registerProtocolHandler().
  53594. * platform/KURL.cpp:
  53595. * platform/KURL.h:
  53596. * platform/KURLGoogle.cpp:
  53597. (WebCore::isValidProtocol):
  53598. 2011-03-08 Adam Roben <aroben@apple.com>
  53599. Set svn:mime-type to text/css for all Inspector CSS files
  53600. This will cause them to be served with the correct MIME type from svn.webkit.org's web
  53601. interface.
  53602. Rubber-stamped by Tim Hatcher.
  53603. * inspector/front-end/audits.css: Added property svn:mime-type.
  53604. * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
  53605. * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
  53606. * inspector/front-end/helpScreen.css: Added property svn:mime-type.
  53607. * inspector/front-end/inspector.css: Added property svn:mime-type.
  53608. * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
  53609. * inspector/front-end/networkPanel.css: Added property svn:mime-type.
  53610. * inspector/front-end/popover.css: Added property svn:mime-type.
  53611. * inspector/front-end/textViewer.css: Added property svn:mime-type.
  53612. 2011-03-08 Andrei Popescu <andreip@google.com>
  53613. Reviewed by Steve Block.
  53614. IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
  53615. https://bugs.webkit.org/show_bug.cgi?id=55938
  53616. The IndexedDatabase specification changed and IDBIndex objects are no
  53617. longer created asynchronously. We therefore no longer need this method.
  53618. No new tests, just cleanup.
  53619. * storage/IDBCallbacks.h:
  53620. * storage/IDBRequest.cpp:
  53621. * storage/IDBRequest.h:
  53622. 2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
  53623. Unreviewed, rolling out r80551.
  53624. http://trac.webkit.org/changeset/80551
  53625. https://bugs.webkit.org/show_bug.cgi?id=55933
  53626. It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
  53627. * WebCore.pro:
  53628. * platform/SharedBuffer.cpp:
  53629. * platform/SharedBuffer.h:
  53630. * platform/network/qt/QNetworkReplyHandler.cpp:
  53631. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  53632. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  53633. (WebCore::QNetworkReplyHandler::forwardData):
  53634. (WebCore::QNetworkReplyHandler::start):
  53635. * platform/network/qt/QNetworkReplyHandler.h:
  53636. * platform/network/qt/ResourceHandleQt.cpp:
  53637. (WebCore::ResourceHandle::supportsBufferedData):
  53638. (WebCore::ResourceHandle::bufferedData):
  53639. * platform/qt/QtByteBlock.cpp: Removed.
  53640. * platform/qt/QtByteBlock.h: Removed.
  53641. * platform/qt/SharedBufferQt.cpp:
  53642. 2011-03-08 Andreas Kling <kling@webkit.org>
  53643. Reviewed by Benjamin Poulain.
  53644. RenderObject: Pass complex type arguments as const-references.
  53645. * WebCore.exp.in:
  53646. * rendering/RenderObject.h:
  53647. * rendering/RenderObject.cpp:
  53648. (WebCore::RenderObject::drawBoxSideFromPath):
  53649. (WebCore::RenderObject::drawArcForBoxSide):
  53650. (WebCore::RenderObject::localToAbsolute):
  53651. (WebCore::RenderObject::absoluteToLocal):
  53652. 2011-03-08 Andreas Kling <kling@webkit.org>
  53653. Reviewed by Antonio Gomes.
  53654. Path: Make measurement functions const
  53655. https://bugs.webkit.org/show_bug.cgi?id=55914
  53656. * platform/graphics/Path.cpp:
  53657. (WebCore::Path::length):
  53658. (WebCore::Path::pointAtLength):
  53659. (WebCore::Path::normalAngleAtLength):
  53660. * platform/graphics/Path.h:
  53661. * platform/graphics/cairo/PathCairo.cpp:
  53662. (WebCore::Path::strokeBoundingRect):
  53663. * platform/graphics/cg/PathCG.cpp:
  53664. (WebCore::Path::strokeBoundingRect):
  53665. * platform/graphics/openvg/PathOpenVG.cpp:
  53666. (WebCore::Path::strokeBoundingRect):
  53667. (WebCore::Path::length):
  53668. (WebCore::Path::pointAtLength):
  53669. (WebCore::Path::normalAngleAtLength):
  53670. * platform/graphics/qt/PathQt.cpp:
  53671. (WebCore::Path::strokeBoundingRect):
  53672. (WebCore::Path::length):
  53673. (WebCore::Path::pointAtLength):
  53674. (WebCore::Path::normalAngleAtLength):
  53675. * platform/graphics/skia/PathSkia.cpp:
  53676. (WebCore::Path::strokeBoundingRect):
  53677. * platform/graphics/wince/PathWinCE.cpp:
  53678. (WebCore::Path::strokeBoundingRect):
  53679. * platform/graphics/wx/PathWx.cpp:
  53680. (WebCore::Path::strokeBoundingRect):
  53681. 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
  53682. Reviewed by Martin Robinson.
  53683. [GTK] Do not set juntion sides on scrollbar stepper buttons
  53684. https://bugs.webkit.org/show_bug.cgi?id=55868
  53685. Fixes rendering of steppers for themes using rounded stepper
  53686. buttons on scrollbars like Adwaita.
  53687. * platform/gtk/ScrollbarThemeGtk3.cpp:
  53688. (WebCore::ScrollbarThemeGtk::paintButton):
  53689. 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
  53690. Reviewed by Martin Robinson.
  53691. [GTK] Use doubles instead of integers for coordinates when rendering arrows
  53692. https://bugs.webkit.org/show_bug.cgi?id=55866
  53693. To prevent off-by-one rounding errors.
  53694. * platform/gtk/RenderThemeGtk3.cpp:
  53695. (WebCore::RenderThemeGtk::paintMenuList):
  53696. * platform/gtk/ScrollbarThemeGtk3.cpp:
  53697. (WebCore::ScrollbarThemeGtk::paintButton):
  53698. 2011-03-08 Markus Goetz <guruz@guruz.de>
  53699. Reviewed by Kenneth Rohde Christiansen.
  53700. [Qt] Use the QNetworkAccessManager zerocopy feature
  53701. https://bugs.webkit.org/show_bug.cgi?id=50082
  53702. The feature will be introduced in Qt 4.8.
  53703. This patch is backwards compatible with Qt 4.7.
  53704. * WebCore.pro:
  53705. * platform/SharedBuffer.cpp:
  53706. * platform/SharedBuffer.h:
  53707. * platform/network/qt/QNetworkReplyHandler.cpp:
  53708. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  53709. (WebCore::QNetworkReplyHandler::bufferedData):
  53710. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  53711. (WebCore::QNetworkReplyHandler::downloadProgress):
  53712. (WebCore::QNetworkReplyHandler::forwardData):
  53713. (WebCore::QNetworkReplyHandler::start):
  53714. * platform/network/qt/QNetworkReplyHandler.h:
  53715. * platform/network/qt/ResourceHandleQt.cpp:
  53716. (WebCore::ResourceHandle::supportsBufferedData):
  53717. (WebCore::ResourceHandle::bufferedData):
  53718. * platform/qt/SharedBufferQt.cpp:
  53719. (WebCore::SharedBuffer::wrapQtByteBlock):
  53720. (WebCore::SharedBuffer::hasPlatformData):
  53721. (WebCore::SharedBuffer::platformData):
  53722. (WebCore::SharedBuffer::platformDataSize):
  53723. (WebCore::SharedBuffer::maybeTransferPlatformData):
  53724. (WebCore::SharedBuffer::clearPlatformData):
  53725. 2011-03-08 Alejandro G. Castro <alex@igalia.com>
  53726. Reviewed by Martin Robinson.
  53727. [GTK] Fix compilation warnings after r80429
  53728. https://bugs.webkit.org/show_bug.cgi?id=55864
  53729. * platform/gtk/WidgetGtk.cpp:
  53730. 2011-03-08 Philippe Normand <pnormand@igalia.com>
  53731. Unreviewed, GTK build fix after r80536
  53732. * GNUmakefile.am:
  53733. 2011-03-08 Zan Dobersek <zandobersek@gmail.com>
  53734. Reviewed by Martin Robinson.
  53735. [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
  53736. https://bugs.webkit.org/show_bug.cgi?id=55878
  53737. Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
  53738. when saving GdkPixbuf to a buffer.
  53739. * platform/graphics/gtk/ImageBufferGtk.cpp:
  53740. (WebCore::ImageBuffer::toDataURL):
  53741. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  53742. Unreviewed.
  53743. Final build fix for r80536.
  53744. * DerivedSources.make:
  53745. 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  53746. Reviewed by Kent Tamura.
  53747. [EFL] Adjust functions of WebCore's efl port to WebKit coding style
  53748. https://bugs.webkit.org/show_bug.cgi?id=55924
  53749. Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
  53750. * platform/efl/PlatformKeyboardEventEfl.cpp:
  53751. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  53752. * platform/efl/PlatformMouseEventEfl.cpp:
  53753. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  53754. * platform/efl/WidgetEfl.cpp:
  53755. (WebCore::Widget::frameRectsChanged):
  53756. (WebCore::Widget::setEvasObject):
  53757. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  53758. Unreviewed.
  53759. More build fixes for r80536.
  53760. * CMakeLists.txt:
  53761. * platform/chromium/ClipboardChromium.cpp:
  53762. * platform/chromium/ClipboardChromium.h:
  53763. 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  53764. Reviewed by Antonio Gomes.
  53765. [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
  53766. https://bugs.webkit.org/show_bug.cgi?id=55917
  53767. Adjust webkit style to ScrollbarEfl files.
  53768. * platform/efl/ScrollbarEfl.cpp:
  53769. (scrollbarEflEdjeMessage):
  53770. (ScrollbarEfl::setParent):
  53771. (ScrollbarEfl::updateThumbPositionAndProportion):
  53772. (ScrollbarEfl::frameRectsChanged):
  53773. (ScrollbarEfl::paint):
  53774. * platform/efl/ScrollbarEfl.h:
  53775. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  53776. Unreviewed.
  53777. Build fix for Chromium after r80536.
  53778. * platform/chromium/DataTransferItemChromium.cpp:
  53779. * platform/chromium/DataTransferItemsChromium.cpp:
  53780. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  53781. Unreviewed.
  53782. More build fixes for r80536.
  53783. * CMakeLists.txt:
  53784. * platform/chromium/ClipboardChromium.cpp:
  53785. * platform/chromium/ClipboardChromium.h:
  53786. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  53787. Reviewed by David Levin.
  53788. Add support for DataTransferItems
  53789. https://bugs.webkit.org/show_bug.cgi?id=55115
  53790. This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
  53791. basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
  53792. all functionality on the DataTransferItems collection has been implemented.
  53793. This change does not actually hook up DataTransferItems to reflect the actual contents of a
  53794. drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
  53795. enabled via several followup patches.
  53796. Test: editing/pasteboard/data-transfer-items.html
  53797. * Android.mk:
  53798. * CMakeLists.txt:
  53799. * CodeGenerators.pri:
  53800. * DerivedSources.cpp:
  53801. * DerivedSources.make:
  53802. * GNUmakefile.am:
  53803. * WebCore.gypi:
  53804. * WebCore.pro:
  53805. * WebCore.vcproj/WebCore.vcproj:
  53806. * WebCore.xcodeproj/project.pbxproj:
  53807. * bindings/generic/RuntimeEnabledFeatures.cpp:
  53808. * bindings/generic/RuntimeEnabledFeatures.h:
  53809. (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
  53810. (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
  53811. * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
  53812. * dom/Clipboard.h:
  53813. (WebCore::Clipboard::policy):
  53814. * dom/Clipboard.idl:
  53815. * dom/DataTransferItem.cpp: Added.
  53816. * dom/DataTransferItem.h: Added.
  53817. (WebCore::DataTransferItem::~DataTransferItem):
  53818. * dom/DataTransferItem.idl: Added.
  53819. * dom/DataTransferItems.h: Added.
  53820. (WebCore::DataTransferItems::~DataTransferItems):
  53821. * dom/DataTransferItems.idl: Added.
  53822. * dom/StringCallback.cpp: Added.
  53823. (WebCore::StringCallback::scheduleCallback):
  53824. * dom/StringCallback.h: Added.
  53825. (WebCore::StringCallback::~StringCallback):
  53826. * dom/StringCallback.idl: Added.
  53827. * platform/chromium/ClipboardChromium.cpp:
  53828. (WebCore::ClipboardChromium::items):
  53829. * platform/chromium/ClipboardChromium.h:
  53830. * platform/chromium/DataTransferItemChromium.cpp: Added.
  53831. (WebCore::DataTransferItemChromium::create):
  53832. (WebCore::DataTransferItemChromium::DataTransferItemChromium):
  53833. (WebCore::DataTransferItemChromium::kind):
  53834. (WebCore::DataTransferItemChromium::type):
  53835. (WebCore::DataTransferItemChromium::getAsString):
  53836. * platform/chromium/DataTransferItemChromium.h: Added.
  53837. * platform/chromium/DataTransferItemsChromium.cpp: Added.
  53838. (WebCore::DataTransferItemsChromium::create):
  53839. (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
  53840. (WebCore::DataTransferItemsChromium::length):
  53841. (WebCore::DataTransferItemsChromium::item):
  53842. (WebCore::DataTransferItemsChromium::deleteItem):
  53843. (WebCore::DataTransferItemsChromium::clear):
  53844. (WebCore::DataTransferItemsChromium::add):
  53845. * platform/chromium/DataTransferItemsChromium.h: Added.
  53846. 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
  53847. Reviewed by Darin Adler.
  53848. selectionHasStyle and selectionStartHasStyle should use EditingStyle
  53849. https://bugs.webkit.org/show_bug.cgi?id=55902
  53850. Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
  53851. This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
  53852. Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
  53853. to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
  53854. call sites of these two functions.
  53855. * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
  53856. selectionStartHasStyle because it's not called anywhere outside of WebCore.
  53857. * WebCore.order: Ditto.
  53858. * editing/EditingStyle.cpp:
  53859. (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
  53860. and a property value.
  53861. (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
  53862. * editing/EditingStyle.h:
  53863. (WebCore::EditingStyle::create): Added.
  53864. * editing/Editor.cpp:
  53865. (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
  53866. a CSSStyleDeclaration.
  53867. (WebCore::Editor::selectionHasStyle): Ditto.
  53868. * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
  53869. * editing/EditorCommand.cpp:
  53870. (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
  53871. (WebCore::stateStyle): Ditto.
  53872. * page/ContextMenuController.cpp:
  53873. (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
  53874. 2011-03-07 Alexey Proskuryakov <ap@apple.com>
  53875. Reviewed by Darin Adler.
  53876. REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
  53877. https://bugs.webkit.org/show_bug.cgi?id=55898
  53878. <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
  53879. linkifying e-mail addresses in in -[DOMCharacterData setData:]
  53880. Changes render tree of fast/text/large-text-composed-char.html, but not image results.
  53881. * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
  53882. Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
  53883. * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
  53884. * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  53885. * dom/Text.h:
  53886. This function was unused in ToT. Moved code around to share with CharacterData.
  53887. * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
  53888. Chnaged to split large text nodes while parsing again.
  53889. 2011-03-07 Alice Boxhall <aboxhall@chromium.org>
  53890. Reviewed by Adam Barth.
  53891. Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
  53892. https://bugs.webkit.org/show_bug.cgi?id=54522
  53893. Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
  53894. No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
  53895. * platform/image-encoders/JPEGImageEncoder.cpp:
  53896. (WebCore::jpegEmptyOutputBuffer):
  53897. 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
  53898. Reviewed by Eric Seidel.
  53899. Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
  53900. https://bugs.webkit.org/show_bug.cgi?id=55896
  53901. Test: svg/dom/vkern-element-crash.html
  53902. * svg/SVGHKernElement.cpp:
  53903. (WebCore::SVGHKernElement::insertedIntoDocument):
  53904. * svg/SVGVKernElement.cpp:
  53905. (WebCore::SVGVKernElement::insertedIntoDocument):
  53906. 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
  53907. Unreviewed, rolling out r80514.
  53908. http://trac.webkit.org/changeset/80514
  53909. https://bugs.webkit.org/show_bug.cgi?id=55915
  53910. Caused assertion failures (Requested by ukai on #webkit).
  53911. * platform/graphics/skia/GraphicsContextSkia.cpp:
  53912. (WebCore::GraphicsContext::setPlatformShadow):
  53913. * platform/graphics/skia/ImageSkia.cpp:
  53914. (WebCore::paintSkBitmap):
  53915. 2011-03-07 Cosmin Truta <ctruta@chromium.org>
  53916. Reviewed by Adam Barth.
  53917. SVG <image> referenced by <use> is displayed incorrectly
  53918. https://bugs.webkit.org/show_bug.cgi?id=55750
  53919. The result of sourceURI must use the URL of the enclosing document as base.
  53920. Otherwise, the base may sometimes be empty, and, as a consequence,
  53921. the intermediate KURL object may be invalid.
  53922. Test: svg/custom/use-image-in-g.svg
  53923. * svg/SVGImageLoader.cpp:
  53924. (WebCore::SVGImageLoader::sourceURI):
  53925. 2011-03-07 Helder Correia <helder@sencha.com>
  53926. Reviewed by Simon Fraser.
  53927. Shadow is not shown when using strokeRect with a gradient strokeStyle
  53928. https://bugs.webkit.org/show_bug.cgi?id=52509
  53929. This happens in CG and is related to bug 51869, this time to be fixed
  53930. in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
  53931. We need to draw the gradient clipped to the stroke on a CGLayer first,
  53932. and then draw the layer on the GraphicsContext.
  53933. Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
  53934. svg/css/rect-gradient-stroke-shadow.svg
  53935. * platform/graphics/cg/GraphicsContextCG.cpp:
  53936. (WebCore::GraphicsContext::strokeRect):
  53937. 2011-03-07 Justin Novosad <junov@chromium.org>
  53938. Reviewed by Kenneth Russell.
  53939. Fix for blurs behind bitmap images in Chromium, and boosting
  53940. shadow blur quality
  53941. Bug URLs:
  53942. https://bugs.webkit.org/show_bug.cgi?id=55410
  53943. https://bugs.webkit.org/show_bug.cgi?id=55506
  53944. No new tests. Covered by existing layout tests.
  53945. * platform/graphics/skia/GraphicsContextSkia.cpp:
  53946. (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
  53947. * platform/graphics/skia/ImageSkia.cpp:
  53948. (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
  53949. 2011-03-07 Andreas Kling <kling@webkit.org>
  53950. Unreviewed Mac build fix after r80508.
  53951. * WebCore.exp.in:
  53952. 2011-03-07 Enrica Casucci <enrica@apple.com>
  53953. Unreviewed build fix.
  53954. Rolling back http://trac.webkit.org/changeset/80497 due to the
  53955. 32-bit build failures.
  53956. * WebCore.xcodeproj/project.pbxproj:
  53957. * platform/mac/HTMLConverter.h: Removed.
  53958. * platform/mac/HTMLConverter.mm: Removed.
  53959. * platform/mac/PasteboardMac.mm:
  53960. (WebCore::Pasteboard::writeSelection):
  53961. 2011-03-07 Andreas Kling <kling@webkit.org>
  53962. Reviewed by Benjamin Poulain.
  53963. FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
  53964. * page/FrameView.cpp:
  53965. (WebCore::FrameView::setBaseBackgroundColor):
  53966. * page/FrameView.h:
  53967. 2011-03-07 Adam Barth <abarth@webkit.org>
  53968. Reviewed by Dimitri Glazkov.
  53969. REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
  53970. https://bugs.webkit.org/show_bug.cgi?id=55894
  53971. The m_frame can disappear out from under us, and there's no point in
  53972. checking whether the load is complete in a non-existant frame.
  53973. Test: fast/parser/document-write-into-initial-document.html
  53974. * dom/Document.cpp:
  53975. (WebCore::Document::explicitClose):
  53976. 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
  53977. Unreviewed, rolling out r80500.
  53978. http://trac.webkit.org/changeset/80500
  53979. https://bugs.webkit.org/show_bug.cgi?id=55908
  53980. Caused mysterious GYP error (Requested by abarth on #webkit).
  53981. * WebCore.gyp/WebCore.gyp:
  53982. * WebCore.gypi:
  53983. 2011-03-07 Adam Barth <abarth@webkit.org>
  53984. Fix Chromium Mac build. This header should only be included when the
  53985. feature is enabled.
  53986. * platform/cf/RunLoopTimerCF.cpp:
  53987. 2011-03-07 Adam Barth <abarth@webkit.org>
  53988. Reviewed by Dimitri Glazkov.
  53989. Add WML files to WebCore.gypi
  53990. https://bugs.webkit.org/show_bug.cgi?id=55905
  53991. * WebCore.gyp/WebCore.gyp:
  53992. * WebCore.gypi:
  53993. 2011-03-07 Adrienne Walker <enne@google.com>
  53994. Reviewed by James Robinson.
  53995. [chromium] Add missing include to #define Skia parameter
  53996. https://bugs.webkit.org/show_bug.cgi?id=55885
  53997. * platform/graphics/chromium/ShaderChromium.h:
  53998. 2011-03-07 Chris Fleizach <cfleizach@apple.com>
  53999. Reviewed by Beth Dakin.
  54000. AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
  54001. https://bugs.webkit.org/show_bug.cgi?id=55706
  54002. * WebCore.exp.in:
  54003. * accessibility/AXObjectCache.cpp:
  54004. (WebCore::AXObjectCache::rootObjectForFrame):
  54005. * accessibility/AXObjectCache.h:
  54006. * accessibility/AccessibilityScrollView.cpp:
  54007. (WebCore::AccessibilityScrollView::isAttachment):
  54008. (WebCore::AccessibilityScrollView::widgetForAttachmentView):
  54009. * accessibility/AccessibilityScrollView.h:
  54010. (WebCore::AccessibilityScrollView::firstChild):
  54011. * accessibility/mac/AccessibilityObjectWrapper.mm:
  54012. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  54013. 2011-03-07 Enrica Casucci <enrica@apple.com>
  54014. Reviewed by Darin Adler.
  54015. REGRESSION: Copied content loses formatting on paste to external apps.
  54016. https://bugs.webkit.org/show_bug.cgi?id=47615
  54017. <rdar://problem/9001214>
  54018. This is a resubmission of a patch that was landed a while ago then rolled
  54019. back because of a build failure on SnowLeopard and Leopard.
  54020. This patch adds a way for WebKit2 to create NSAttributedStrings from
  54021. a DOM range without using the AppKit api initWithDOMRange that internally
  54022. needs to access the WebView. The NSAttributedString is needed to create
  54023. RTF formats in the pasteboard.
  54024. This is to be considered a first step, since in the future we want to have
  54025. an implementation based on the TextIterator.
  54026. * WebCore.xcodeproj/project.pbxproj: Added new file.
  54027. * platform/mac/HTMLConverter.h: Added.
  54028. * platform/mac/HTMLConverter.mm: Added.
  54029. * platform/mac/PasteboardMac.mm:
  54030. (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
  54031. class for WebKit2 to create the NSAttributedString from the DOM range.
  54032. 2011-03-07 Adam Barth <abarth@webkit.org>
  54033. Reviewed by Dimitri Glazkov.
  54034. Add some missing platform files to WebCore.gypi
  54035. https://bugs.webkit.org/show_bug.cgi?id=55897
  54036. There are a bunch more, but this is a start.
  54037. * WebCore.gyp/WebCore.gyp:
  54038. * WebCore.gypi:
  54039. 2011-03-07 Steve Block <steveblock@google.com>
  54040. Reviewed by Jeremy Orlow.
  54041. Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
  54042. https://bugs.webkit.org/show_bug.cgi?id=55879
  54043. No new tests, refactoring only.
  54044. * Android.v8bindings.mk:
  54045. * WebCore.gypi:
  54046. * bridge/jni/v8/JavaClassV8.cpp:
  54047. * bridge/jni/v8/JavaClassV8.h:
  54048. * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
  54049. (JavaField::JavaField):
  54050. * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
  54051. (JSC::Bindings::JavaField::name):
  54052. (JSC::Bindings::JavaField::type):
  54053. (JSC::Bindings::JavaField::getJNIType):
  54054. * bridge/jni/v8/JavaInstanceV8.cpp:
  54055. * bridge/jni/v8/JavaNPObjectV8.cpp:
  54056. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  54057. Reviewed by Tony Chang.
  54058. Add plumbing for paste support to ChromiumDataObject::types()
  54059. https://bugs.webkit.org/show_bug.cgi?id=55792
  54060. This is a preliminary patch to support event.dataTransfer.items. This
  54061. adds plumbing to support retrieving the types in a paste event. It also
  54062. moves the check for files in a drag/paste up to ClipboardChromium, since
  54063. internal code needs to be able to differentiate between actual files in
  54064. a drag and someone that simply decided to use "Files" as a custom type
  54065. string.
  54066. Test: editing/pasteboard/onpaste-text-html-types.html
  54067. * platform/chromium/ChromiumDataObject.cpp:
  54068. (WebCore::ChromiumDataObject::types):
  54069. (WebCore::ChromiumDataObject::containsFilenames):
  54070. * platform/chromium/ChromiumDataObject.h:
  54071. * platform/chromium/ClipboardChromium.cpp:
  54072. (WebCore::ClipboardChromium::types):
  54073. * platform/chromium/ClipboardMimeTypes.cpp:
  54074. * platform/chromium/ClipboardMimeTypes.h:
  54075. 2011-03-07 Takayoshi Kochi <kochi@chromium.org>
  54076. Reviewed by Tony Chang.
  54077. [chromium] Use preferred locale information when choosing fallback
  54078. font using fontconfig on Linux platform.
  54079. http://bugs.webkit.org/show_bug.cgi?id=55453
  54080. No new tests, as it depends on ICU and locale setting, so it will be
  54081. covered by Chromium side.
  54082. * platform/chromium/PlatformBridge.h:
  54083. * platform/graphics/chromium/FontCacheLinux.cpp:
  54084. 2011-03-07 Adam Barth <abarth@webkit.org>
  54085. Reviewed by Eric Seidel.
  54086. Add gobject, cpp, and objc bindings to WebCore.gypi
  54087. https://bugs.webkit.org/show_bug.cgi?id=55892
  54088. These are also excluded from the Chromium build but needed for various
  54089. other ports.
  54090. * WebCore.gyp/WebCore.gyp:
  54091. * WebCore.gypi:
  54092. 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
  54093. Reviewed by Dimitri Glazkov.
  54094. Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
  54095. https://bugs.webkit.org/show_bug.cgi?id=55803
  54096. Test: fast/dom/dom-method-document-change.html
  54097. * dom/ContainerNode.cpp:
  54098. (WebCore::ContainerNode::insertBefore):
  54099. (WebCore::ContainerNode::replaceChild):
  54100. (WebCore::ContainerNode::appendChild):
  54101. * dom/Node.cpp:
  54102. (WebCore::Node::checkReplaceChild):
  54103. (WebCore::Node::checkAddChild):
  54104. * dom/Node.h:
  54105. 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
  54106. Unreviewed, rolling out r80484.
  54107. http://trac.webkit.org/changeset/80484
  54108. https://bugs.webkit.org/show_bug.cgi?id=55891
  54109. requires Chromium DEPS roll (Requested by dcheng on #webkit).
  54110. * platform/chromium/ChromiumDataObject.cpp:
  54111. (WebCore::ChromiumDataObject::types):
  54112. * platform/chromium/ChromiumDataObject.h:
  54113. (WebCore::ChromiumDataObject::containsFilenames):
  54114. * platform/chromium/ClipboardChromium.cpp:
  54115. (WebCore::ClipboardChromium::types):
  54116. * platform/chromium/ClipboardMimeTypes.cpp:
  54117. * platform/chromium/ClipboardMimeTypes.h:
  54118. 2011-03-07 Adam Barth <abarth@webkit.org>
  54119. Reviewed by Dimitri Glazkov.
  54120. Add missing bindings/js files to WebCore.gypi
  54121. https://bugs.webkit.org/show_bug.cgi?id=55888
  54122. These files are excluded from the Chromium build but needed for the Mac
  54123. build.
  54124. * WebCore.gypi:
  54125. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  54126. Reviewed by Tony Chang.
  54127. Add plumbing for paste support to ChromiumDataObject::types()
  54128. https://bugs.webkit.org/show_bug.cgi?id=55792
  54129. This is a preliminary patch to support event.dataTransfer.items. This
  54130. adds plumbing to support retrieving the types in a paste event. It also
  54131. moves the check for files in a drag/paste up to ClipboardChromium, since
  54132. internal code needs to be able to differentiate between actual files in
  54133. a drag and someone that simply decided to use "Files" as a custom type
  54134. string.
  54135. Test: editing/pasteboard/onpaste-text-html-types.html
  54136. * platform/chromium/ChromiumDataObject.cpp:
  54137. (WebCore::ChromiumDataObject::types):
  54138. (WebCore::ChromiumDataObject::containsFilenames):
  54139. * platform/chromium/ChromiumDataObject.h:
  54140. * platform/chromium/ClipboardChromium.cpp:
  54141. (WebCore::ClipboardChromium::types):
  54142. * platform/chromium/ClipboardMimeTypes.cpp:
  54143. * platform/chromium/ClipboardMimeTypes.h:
  54144. 2011-03-07 Joseph Pecoraro <joepeck@webkit.org>
  54145. Reviewed by Kenneth Rohde Christiansen.
  54146. Viewport Warning/Error Messages Are Now Inaccurate
  54147. https://bugs.webkit.org/show_bug.cgi?id=53707
  54148. Correct and improve the error messages for viewport parsing.
  54149. Tests: fast/viewport/viewport-warnings-1.html
  54150. fast/viewport/viewport-warnings-2.html
  54151. fast/viewport/viewport-warnings-3.html
  54152. fast/viewport/viewport-warnings-4.html
  54153. fast/viewport/viewport-warnings-5.html
  54154. fast/viewport/viewport-warnings-6.html
  54155. * dom/ViewportArguments.cpp:
  54156. (WebCore::numericPrefix):
  54157. (WebCore::findSizeValue): remove incorrect device-width / height tips.
  54158. (WebCore::setViewportFeature): report a warning for an unrecognized key.
  54159. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
  54160. (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
  54161. * dom/ViewportArguments.h: removed no longer used warnings.
  54162. 2011-03-07 James Robinson <jamesr@chromium.org>
  54163. Reviewed by Kenneth Russell.
  54164. [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
  54165. https://bugs.webkit.org/show_bug.cgi?id=54047
  54166. This splits up LayerRendererChromium::drawLayers() into two phases,
  54167. one that updates layers and one that actually draws them. Most of the
  54168. patch is moving the bodies of drawLayers() and updateLayersRecursive()
  54169. into smaller helper functions.
  54170. The main entry point is renamed updateAndDrawLayers(), but otherwise
  54171. has the same signature as drawLayers() did. Internally it does the
  54172. following:
  54173. 1.) Updates the root layer's contents
  54174. 2.) Updates the root layer's scrollbars
  54175. 3.) Updates the RenderSurface tree and the contents of all child
  54176. layers
  54177. 4.) Draws the root layer and root layer scrollbars
  54178. 5.) Draws all child layers using the previously updated
  54179. CCLayerImpl/RenderSurface data.
  54180. A few things still need to be done after this patch to complete the separation
  54181. of the update and draw step, but they can happen in later patches:
  54182. *) The root layer and root layer scrollbars contents should be
  54183. uploaded to textures at draw time, not update time.
  54184. *) The RenderSurface tree should be updated at draw time, not update
  54185. time.
  54186. Covered by the compositing/ tests.
  54187. * platform/graphics/chromium/LayerRendererChromium.cpp:
  54188. (WebCore::LayerRendererChromium::LayerRendererChromium):
  54189. (WebCore::LayerRendererChromium::updateRootLayerContents):
  54190. (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
  54191. (WebCore::LayerRendererChromium::drawRootLayer):
  54192. (WebCore::LayerRendererChromium::updateAndDrawLayers):
  54193. (WebCore::LayerRendererChromium::updateLayers):
  54194. (WebCore::LayerRendererChromium::drawLayers):
  54195. (WebCore::LayerRendererChromium::getFramebufferPixels):
  54196. (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  54197. (WebCore::LayerRendererChromium::updateContentsRecursive):
  54198. (WebCore::LayerRendererChromium::drawLayer):
  54199. * platform/graphics/chromium/LayerRendererChromium.h:
  54200. (WebCore::LayerRendererChromium::visibleRectSize):
  54201. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  54202. (WebCore::RenderSurfaceChromium::drawSurface):
  54203. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  54204. * platform/graphics/chromium/cc/CCLayerImpl.h:
  54205. 2011-03-07 Adam Barth <abarth@webkit.org>
  54206. Reviewed by Eric Seidel.
  54207. Sort WebCore.gypi
  54208. https://bugs.webkit.org/show_bug.cgi?id=55887
  54209. These files should be in order. This is preparation for adding in the
  54210. missing files.
  54211. * WebCore.gypi:
  54212. 2011-03-07 Csaba Osztrogonác <ossy@webkit.org>
  54213. Unreviewed buildfix after r80478.
  54214. * dom/Document.cpp: Add suggested parentheses to make GCC happy.
  54215. (WebCore::Document::didReceiveTask):
  54216. 2011-03-07 Yong Li <yoli@rim.com>
  54217. Reviewed by Darin Adler.
  54218. Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
  54219. Schedule them with timer when page loading is resumed. The tasks will be performed
  54220. in the original order. This fixes the problem that database callbacks could be missed
  54221. when page loading was deferred.
  54222. https://bugs.webkit.org/show_bug.cgi?id=49401
  54223. Manual test added: manual-tests/database-callback-deferred.html.
  54224. * dom/Document.cpp:
  54225. (WebCore::Document::Document):
  54226. (WebCore::Document::~Document):
  54227. (WebCore::Document::didReceiveTask):
  54228. (WebCore::Document::postTask):
  54229. (WebCore::Document::pendingTasksTimerFired):
  54230. (WebCore::Document::willDeferLoading):
  54231. (WebCore::Document::didResumeLoading):
  54232. * dom/Document.h:
  54233. * manual-tests/database-callback-deferred.html: Added.
  54234. * page/PageGroupLoadDeferrer.cpp:
  54235. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  54236. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  54237. 2011-03-07 Antti Koivisto <antti@apple.com>
  54238. Reviewed by Sam Weinig.
  54239. Use HashMaps for caching primitive values
  54240. https://bugs.webkit.org/show_bug.cgi?id=55873
  54241. Most documents use only small subset of cacheable primitive values. By replacing
  54242. fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
  54243. expanding the range of cacheable values.
  54244. * css/CSSPrimitiveValueCache.cpp:
  54245. (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
  54246. (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
  54247. (WebCore::CSSPrimitiveValueCache::createColorValue):
  54248. (WebCore::CSSPrimitiveValueCache::createValue):
  54249. * css/CSSPrimitiveValueCache.h:
  54250. 2011-03-07 Steve Block <steveblock@google.com>
  54251. Reviewed by Jeremy Orlow.
  54252. Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
  54253. https://bugs.webkit.org/show_bug.cgi?id=55881
  54254. No new tests, refactoring only.
  54255. * Android.jscbindings.mk:
  54256. * GNUmakefile.am:
  54257. * WebCore.xcodeproj/project.pbxproj:
  54258. * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
  54259. * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
  54260. * bridge/jni/jsc/JNIUtilityPrivate.cpp:
  54261. * bridge/jni/jsc/JavaClassJSC.cpp:
  54262. * bridge/jni/jsc/JavaClassJSC.h:
  54263. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  54264. 2011-03-07 Sam Weinig <sam@webkit.org>
  54265. Reviewed by Anders Carlsson.
  54266. Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
  54267. https://bugs.webkit.org/show_bug.cgi?id=55827
  54268. * loader/EmptyClients.h:
  54269. (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
  54270. * loader/FrameLoaderClient.h:
  54271. * loader/MainResourceLoader.cpp:
  54272. (WebCore::MainResourceLoader::didReceiveResponse):
  54273. * loader/PolicyChecker.cpp:
  54274. (WebCore::PolicyChecker::checkContentPolicy):
  54275. * loader/PolicyChecker.h:
  54276. Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
  54277. and pass the entire response, instead of just the MIMEType.
  54278. 2011-03-07 Eric Carlson <eric.carlson@apple.com>
  54279. Reviewed by Darin Adler.
  54280. Add API to enumerate/delete files downloaded for <audio> and <video>
  54281. https://bugs.webkit.org/show_bug.cgi?id=55267
  54282. <rdar://problem/9049280>
  54283. No new tests, this is just more plumbing.
  54284. * html/HTMLMediaElement.cpp:
  54285. (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
  54286. (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
  54287. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  54288. * html/HTMLMediaElement.h:
  54289. * platform/graphics/MediaPlayer.cpp:
  54290. (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
  54291. (WebCore::addMediaEngine): Ditto.
  54292. (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
  54293. (WebCore::MediaPlayer::clearMediaCache): Ditto.
  54294. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  54295. * platform/graphics/MediaPlayer.h:
  54296. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  54297. (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
  54298. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  54299. (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
  54300. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  54301. (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
  54302. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  54303. (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
  54304. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  54305. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
  54306. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  54307. (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
  54308. 2011-03-07 Steve Block <steveblock@google.com>
  54309. Reviewed by Jeremy Orlow.
  54310. Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
  54311. https://bugs.webkit.org/show_bug.cgi?id=55774
  54312. No new tests, refactoring only.
  54313. * Android.jscbindings.mk:
  54314. * Android.v8bindings.mk:
  54315. * GNUmakefile.am:
  54316. * WebCore.gypi:
  54317. * WebCore.xcodeproj/project.pbxproj:
  54318. * bridge/jni/JavaMethod.cpp:
  54319. (JavaMethod::JavaMethod):
  54320. (JavaMethod::~JavaMethod):
  54321. (appendClassName):
  54322. (JavaMethod::signature):
  54323. (JavaMethod::JNIReturnType):
  54324. (JavaMethod::methodID):
  54325. * bridge/jni/JavaMethod.h:
  54326. (JSC::Bindings::JavaMethod::name):
  54327. (JSC::Bindings::JavaMethod::returnType):
  54328. (JSC::Bindings::JavaMethod::parameterAt):
  54329. (JSC::Bindings::JavaMethod::numParameters):
  54330. (JSC::Bindings::JavaMethod::isStatic):
  54331. * bridge/jni/JavaString.h:
  54332. (JSC::Bindings::JavaString::JavaString):
  54333. (JSC::Bindings::JavaString::utf8):
  54334. (JSC::Bindings::JavaString::length):
  54335. (JSC::Bindings::JavaString::impl):
  54336. * bridge/jni/jni_jsobject.mm:
  54337. * bridge/jni/jsc/JNIBridgeJSC.h:
  54338. * bridge/jni/v8/JNIBridgeV8.h:
  54339. * bridge/jni/v8/JavaClassV8.cpp:
  54340. * bridge/jni/v8/JavaClassV8.h:
  54341. * bridge/jni/v8/JavaInstanceV8.cpp:
  54342. 2011-03-07 Jeremy Orlow <jorlow@chromium.org>
  54343. Reviewed by Steve Block.
  54344. Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
  54345. https://bugs.webkit.org/show_bug.cgi?id=55812
  54346. This brings us in line with what's in the spec:
  54347. http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
  54348. * storage/IDBCursor.cpp:
  54349. (WebCore::IDBCursor::create):
  54350. (WebCore::IDBCursor::IDBCursor):
  54351. (WebCore::IDBCursor::source):
  54352. * storage/IDBCursor.h:
  54353. * storage/IDBCursor.idl:
  54354. * storage/IDBCursorWithValue.cpp:
  54355. (WebCore::IDBCursorWithValue::create):
  54356. (WebCore::IDBCursorWithValue::IDBCursorWithValue):
  54357. * storage/IDBCursorWithValue.h:
  54358. * storage/IDBIndex.cpp:
  54359. (WebCore::IDBIndex::IDBIndex):
  54360. * storage/IDBIndex.h:
  54361. (WebCore::IDBIndex::create):
  54362. (WebCore::IDBIndex::objectStore):
  54363. * storage/IDBIndex.idl:
  54364. * storage/IDBObjectStore.cpp:
  54365. (WebCore::IDBObjectStore::createIndex):
  54366. (WebCore::IDBObjectStore::index):
  54367. * storage/IDBRequest.cpp:
  54368. (WebCore::IDBRequest::onSuccess):
  54369. 2011-03-07 Chris Fleizach <cfleizach@apple.com>
  54370. Reviewed by Beth Dakin.
  54371. AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
  54372. https://bugs.webkit.org/show_bug.cgi?id=55735
  54373. The ARIA grid implementation needed to verify the row/column range of a cell instead of
  54374. assuming a 1-1 mapping between children and row/column.
  54375. Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
  54376. * accessibility/AccessibilityARIAGrid.cpp:
  54377. (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
  54378. 2011-03-07 Andrei Popescu <andreip@google.com>
  54379. Reviewed by Steve Block.
  54380. IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
  54381. IDBObjectStore objects used to be created asynchronously, so we needed
  54382. this method to be invoked, with the new object store as the parameter,
  54383. whenever the creation succeeded. The spec has changed so that IDBObjectStore
  54384. objects are created synchronously, so this method is no longer needed.
  54385. https://bugs.webkit.org/show_bug.cgi?id=55777
  54386. No new tests, just refactoring.
  54387. * storage/IDBCallbacks.h:
  54388. * storage/IDBRequest.cpp:
  54389. * storage/IDBRequest.h:
  54390. 2011-03-04 Steve Block <steveblock@google.com>
  54391. Reviewed by Jeremy Orlow.
  54392. JavaParameter should be removed
  54393. https://bugs.webkit.org/show_bug.cgi?id=55772
  54394. No new tests, refactoring only.
  54395. * bridge/jni/JNIBridge.cpp:
  54396. (JavaMethod::JavaMethod):
  54397. (JavaMethod::~JavaMethod):
  54398. (JavaMethod::signature):
  54399. * bridge/jni/JNIBridge.h:
  54400. (JSC::Bindings::JavaMethod::parameterAt):
  54401. (JSC::Bindings::JavaMethod::numParameters):
  54402. * bridge/jni/JNIUtility.h:
  54403. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  54404. (JavaInstance::invokeMethod):
  54405. * bridge/jni/v8/JNIUtilityPrivate.cpp:
  54406. (JSC::Bindings::convertNPVariantToJValue):
  54407. * bridge/jni/v8/JNIUtilityPrivate.h:
  54408. * bridge/jni/v8/JavaInstanceV8.cpp:
  54409. (JavaInstance::invokeMethod):
  54410. 2011-03-07 Antti Koivisto <antti@apple.com>
  54411. Reviewed by Oliver Hunt.
  54412. REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
  54413. https://bugs.webkit.org/show_bug.cgi?id=55166
  54414. <rdar://problem/9050430>
  54415. Make CSS primitive value cache per-document.
  54416. Test: http/tests/security/cross-origin-css-primitive.html
  54417. * Android.mk:
  54418. * CMakeLists.txt:
  54419. * GNUmakefile.am:
  54420. * WebCore.gypi:
  54421. * WebCore.pro:
  54422. * WebCore.vcproj/WebCore.vcproj:
  54423. * WebCore.xcodeproj/project.pbxproj:
  54424. * css/CSSComputedStyleDeclaration.cpp:
  54425. (WebCore::valueForNinePieceImage):
  54426. (WebCore::zoomAdjustedPixelValue):
  54427. (WebCore::zoomAdjustedNumberValue):
  54428. (WebCore::zoomAdjustedPixelValueForLength):
  54429. (WebCore::valueForReflection):
  54430. (WebCore::getPositionOffsetValue):
  54431. (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
  54432. (WebCore::getBorderRadiusCornerValue):
  54433. (WebCore::computedTransform):
  54434. (WebCore::getDelayValue):
  54435. (WebCore::getDurationValue):
  54436. (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
  54437. (WebCore::CSSComputedStyleDeclaration::valueForShadow):
  54438. (WebCore::valueForFamily):
  54439. (WebCore::renderTextDecorationFlagsToCSSValue):
  54440. (WebCore::fillRepeatToCSSValue):
  54441. (WebCore::fillSizeToCSSValue):
  54442. (WebCore::contentToCSSValue):
  54443. (WebCore::counterToCSSValue):
  54444. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  54445. * css/CSSParser.cpp:
  54446. (WebCore::CSSParser::parseSheet):
  54447. (WebCore::CSSParser::parseRule):
  54448. (WebCore::CSSParser::parseKeyframeRule):
  54449. (WebCore::CSSParser::parseValue):
  54450. (WebCore::CSSParser::parseColor):
  54451. (WebCore::CSSParser::parseSelector):
  54452. (WebCore::CSSParser::parseDeclaration):
  54453. (WebCore::CSSParser::setStyleSheet):
  54454. (WebCore::CSSParser::parseWCSSInputProperty):
  54455. (WebCore::parseBackgroundClip):
  54456. (WebCore::CSSParser::parseFillShorthand):
  54457. (WebCore::CSSParser::parsePage):
  54458. (WebCore::CSSParser::parseSizeParameter):
  54459. (WebCore::CSSParser::parseContent):
  54460. (WebCore::CSSParser::parseAttr):
  54461. (WebCore::CSSParser::parseBackgroundColor):
  54462. (WebCore::CSSParser::parseFillPositionXY):
  54463. (WebCore::CSSParser::parseFillPosition):
  54464. (WebCore::CSSParser::parseFillRepeat):
  54465. (WebCore::CSSParser::parseFillSize):
  54466. (WebCore::CSSParser::parseFillProperty):
  54467. (WebCore::CSSParser::parseAnimationDelay):
  54468. (WebCore::CSSParser::parseAnimationDirection):
  54469. (WebCore::CSSParser::parseAnimationDuration):
  54470. (WebCore::CSSParser::parseAnimationFillMode):
  54471. (WebCore::CSSParser::parseAnimationIterationCount):
  54472. (WebCore::CSSParser::parseAnimationName):
  54473. (WebCore::CSSParser::parseAnimationPlayState):
  54474. (WebCore::CSSParser::parseAnimationProperty):
  54475. (WebCore::CSSParser::parseTransformOriginShorthand):
  54476. (WebCore::CSSParser::parseAnimationTimingFunction):
  54477. (WebCore::CSSParser::parseDashboardRegions):
  54478. (WebCore::CSSParser::parseCounterContent):
  54479. (WebCore::CSSParser::parseShape):
  54480. (WebCore::CSSParser::parseFont):
  54481. (WebCore::CSSParser::parseFontFamily):
  54482. (WebCore::CSSParser::parseFontStyle):
  54483. (WebCore::CSSParser::parseFontVariant):
  54484. (WebCore::CSSParser::parseFontWeight):
  54485. (WebCore::ShadowParseContext::ShadowParseContext):
  54486. (WebCore::ShadowParseContext::commitLength):
  54487. (WebCore::ShadowParseContext::commitStyle):
  54488. (WebCore::CSSParser::parseShadow):
  54489. (WebCore::CSSParser::parseReflect):
  54490. (WebCore::BorderImageParseContext::BorderImageParseContext):
  54491. (WebCore::BorderImageParseContext::commitNumber):
  54492. (WebCore::BorderImageParseContext::commitBorderImage):
  54493. (WebCore::CSSParser::parseBorderImage):
  54494. (WebCore::CSSParser::parseBorderRadius):
  54495. (WebCore::CSSParser::parseCounter):
  54496. (WebCore::parseDeprecatedGradientPoint):
  54497. (WebCore::parseDeprecatedGradientColorStop):
  54498. (WebCore::CSSParser::parseDeprecatedGradient):
  54499. (WebCore::valueFromSideKeyword):
  54500. (WebCore::parseGradientColorOrKeyword):
  54501. (WebCore::CSSParser::parseLinearGradient):
  54502. (WebCore::CSSParser::parseRadialGradient):
  54503. (WebCore::CSSParser::parseGradientColorStops):
  54504. (WebCore::CSSParser::parseTransform):
  54505. (WebCore::CSSParser::parseTransformOrigin):
  54506. (WebCore::CSSParser::parseTextEmphasisStyle):
  54507. * css/CSSParser.h:
  54508. (WebCore::CSSParser::primitiveValueCache):
  54509. * css/CSSPrimitiveValue.cpp:
  54510. * css/CSSPrimitiveValue.h:
  54511. (WebCore::CSSPrimitiveValue::createIdentifier):
  54512. (WebCore::CSSPrimitiveValue::createColor):
  54513. (WebCore::CSSPrimitiveValue::create):
  54514. * css/CSSPrimitiveValueCache.cpp: Added.
  54515. (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
  54516. (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
  54517. (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
  54518. (WebCore::CSSPrimitiveValueCache::createColorValue):
  54519. (WebCore::CSSPrimitiveValueCache::createValue):
  54520. * css/CSSPrimitiveValueCache.h: Added.
  54521. (WebCore::CSSPrimitiveValueCache::create):
  54522. (WebCore::CSSPrimitiveValueCache::createValue):
  54523. * dom/Document.cpp:
  54524. (WebCore::Document::cssPrimitiveValueCache):
  54525. * dom/Document.h:
  54526. 2011-03-06 Adam Barth <abarth@webkit.org>
  54527. Reviewed by Eric Seidel.
  54528. Filter sources in WebCore GYP build for Mac
  54529. https://bugs.webkit.org/show_bug.cgi?id=55857
  54530. This patch removes a large number of files that do not build as part of
  54531. the Mac build. I'm not fully sold on this method of
  54532. including/excluding files, but it's the "gyp way" so we should probably
  54533. try it first.
  54534. This patch also sets xcode_list_excluded_files to 0, which removes the
  54535. excluded files from the Xcode project file, which is necessary in order
  54536. to prevent the header map feature from including the wrong header file.
  54537. * gyp/WebCore.gyp:
  54538. 2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>
  54539. Unreviewed EFL build fix.
  54540. [EFL] Build break on Debug build.
  54541. https://bugs.webkit.org/show_bug.cgi?id=55858
  54542. * platform/efl/RenderThemeEfl.cpp:
  54543. (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
  54544. 2011-03-06 Adam Barth <abarth@webkit.org>
  54545. Reviewed by Eric Seidel.
  54546. Add webcore_derived_source_files to WebCore.gypi
  54547. https://bugs.webkit.org/show_bug.cgi?id=55856
  54548. This is the list of files generated by the Mac port. It's possible
  54549. other ports generate a different list of files.
  54550. * WebCore.gypi:
  54551. * gyp/WebCore.gyp:
  54552. 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
  54553. Reviewed by Kent Tamura.
  54554. Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
  54555. https://bugs.webkit.org/show_bug.cgi?id=55839
  54556. http://crbug.com/73866
  54557. http://crbug.com/62527
  54558. We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
  54559. Test: fast/forms/input-appearance-spinbutton-visibility.html
  54560. * rendering/RenderTextControlSingleLine.cpp:
  54561. (WebCore::RenderTextControlSingleLine::styleDidChange):
  54562. 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
  54563. Reviewed by Kent Tamura.
  54564. [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
  54565. https://bugs.webkit.org/show_bug.cgi?id=54795
  54566. Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
  54567. Test: manual-tests/popup-width-restriction-within-screen.html
  54568. * manual-tests/popup-width-restriction-within-screen.html: Added.
  54569. * platform/chromium/PopupMenuChromium.cpp:
  54570. (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
  54571. 2011-03-06 Yuta Kitamura <yutak@chromium.org>
  54572. Reviewed by Kent Tamura.
  54573. Add SHA-1 for new WebSocket protocol
  54574. https://bugs.webkit.org/show_bug.cgi?id=55039
  54575. * ForwardingHeaders/wtf/SHA1.h: Added.
  54576. 2011-03-06 Eric Carlson <eric.carlson@apple.com>
  54577. Reviewed by Antti Koivisto.
  54578. QuickTime based media engines should respect private browsing mode
  54579. https://bugs.webkit.org/show_bug.cgi?id=55848
  54580. No new tests, it is only possible to test this by manually deleting and monitoring the
  54581. the Quicktime caches.
  54582. * html/HTMLMediaElement.cpp:
  54583. (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
  54584. * platform/graphics/MediaPlayer.cpp:
  54585. (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
  54586. (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
  54587. (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
  54588. * platform/graphics/MediaPlayer.h:
  54589. * platform/graphics/MediaPlayerPrivate.h:
  54590. (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
  54591. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  54592. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  54593. (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
  54594. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
  54595. creating new movie.
  54596. (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
  54597. m_privateBrowsing and set movie attribute.
  54598. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  54599. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
  54600. Initialize m_privateBrowsing.
  54601. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store
  54602. privacy setting in m_privateBrowsing and call QTMovie.
  54603. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  54604. * platform/graphics/win/QTMovie.cpp:
  54605. (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
  54606. (QTMovie::load):Pass private browsing property when creating new movie.
  54607. (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and
  54608. set movie property.
  54609. * platform/graphics/win/QTMovie.h:
  54610. 2011-03-06 Daniel Bates <dbates@rim.com>
  54611. Reviewed by Darin Adler.
  54612. style.borderSpacing always returns empty string
  54613. https://bugs.webkit.org/show_bug.cgi?id=54816
  54614. Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
  54615. the value for border-spacing from the value of the WebKit internal CSS
  54616. property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
  54617. The CSS property border-spacing describes the horizontal and vertical border
  54618. spacing for an HTML Table element. Notice, WebKit internally represents the value
  54619. of this property as two properties: -webkit-border-horizontal-spacing and
  54620. -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
  54621. respectively. And WebKit doesn't know to reconstitute these internal properties.
  54622. Therefore style.borderSpacing always returns the empty string.
  54623. Test: fast/css/table-border-spacing.html
  54624. * css/CSSMutableStyleDeclaration.cpp:
  54625. (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  54626. (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
  54627. * css/CSSMutableStyleDeclaration.h:
  54628. 2011-03-06 Dan Bernstein <mitz@apple.com>
  54629. Reviewed by Oliver Hunt.
  54630. <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
  54631. https://bugs.webkit.org/show_bug.cgi?id=55850
  54632. Tests: fast/css/parsing-hyphenate-limit.html
  54633. fast/text/hyphenate-limit-before-after.html
  54634. * css/CSSComputedStyleDeclaration.cpp:
  54635. (WebCore::computedProperties) Updated this array with the new properties and some old properties
  54636. that it was missing.
  54637. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
  54638. CSSPropertyWebkitHyphenateLimit{Before,After}.
  54639. * css/CSSParser.cpp:
  54640. (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
  54641. 'auto' and non-negative integers.
  54642. * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
  54643. * css/CSSStyleSelector.cpp:
  54644. (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
  54645. * rendering/RenderBlockLineLayout.cpp:
  54646. (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
  54647. allow hyphenation if the prefix and the suffix are sufficiently long.
  54648. (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
  54649. * rendering/style/RenderStyle.cpp:
  54650. (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
  54651. * rendering/style/RenderStyle.h:
  54652. (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
  54653. (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
  54654. (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
  54655. (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
  54656. (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
  54657. representation of 'auto'.
  54658. (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
  54659. * rendering/style/StyleRareInheritedData.cpp:
  54660. (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
  54661. (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
  54662. * rendering/style/StyleRareInheritedData.h:
  54663. 2011-03-06 Jessie Berlin <jberlin@apple.com>
  54664. Reviewed by Sam Weinig.
  54665. WebKit2: Use CFNetwork Sessions API.
  54666. https://bugs.webkit.org/show_bug.cgi?id=55435.
  54667. When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
  54668. Private Browsing Storage Session.
  54669. * WebCore.exp.in:
  54670. Add the new WKSI functions.
  54671. * platform/mac/WebCoreSystemInterface.h:
  54672. Ditto.
  54673. * platform/mac/WebCoreSystemInterface.mm:
  54674. Ditto.
  54675. * platform/mac/CookieJar.mm:
  54676. (WebCore::cookies):
  54677. If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
  54678. Otherwise, behave the same as before.
  54679. (WebCore::cookieRequestHeaderFieldValue):
  54680. Ditto.
  54681. (WebCore::setCookies):
  54682. Ditto.
  54683. (WebCore::cookiesEnabled):
  54684. Ditto
  54685. (WebCore::getRawCookies):
  54686. Ditto.
  54687. (WebCore::deleteCookie):
  54688. Ditto.
  54689. * platform/network/CookieStorage.h:
  54690. * platform/network/cf/CookieStorageCFNet.cpp:
  54691. (WebCore::privateBrowsingCookieStorage):
  54692. Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
  54693. function instead of at the global scope.
  54694. (WebCore::currentCookieStorage):
  54695. Use privateBrowsingCookieStorage.
  54696. (WebCore::setCurrentCookieStorage):
  54697. Ditto.
  54698. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  54699. If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
  54700. wkCreatePrivateInMemoryHTTPCookieStorage.
  54701. * platform/network/mac/CookieStorageMac.mm:
  54702. (WebCore::privateBrowsingCookieStorage):
  54703. Keep track of the Private Browsing Cookie Storage.
  54704. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  54705. If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
  54706. Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
  54707. * platform/network/mac/ResourceHandleMac.mm:
  54708. (WebCore::shouldRelaxThirdPartyCookiePolicy):
  54709. Refactor the logic to determine whether or not to relax the third party cookie policy here.
  54710. If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
  54711. (WebCore::ResourceHandle::createNSURLConnection):
  54712. Use shouldRelaxThirdPartyCookiePolicy.
  54713. (WebCore::ResourceHandle::loadResourceSynchronously):
  54714. Ditto.
  54715. 2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
  54716. Unreviewed, rolling out r80428.
  54717. http://trac.webkit.org/changeset/80428
  54718. https://bugs.webkit.org/show_bug.cgi?id=55833
  54719. Broke SnowLeopard (Requested by xan_ on #webkit).
  54720. * plugins/gtk/PluginViewGtk.cpp:
  54721. (WebCore::PluginView::handlePostReadFile):
  54722. 2011-03-01 Martin Robinson <mrobinson@igalia.com>
  54723. Reviewed by Xan Lopez.
  54724. [GTK] Windowless plugins override the view cursor
  54725. https://bugs.webkit.org/show_bug.cgi?id=55531
  54726. manual test: manual-tests/plugins/windowless.html
  54727. * platform/gtk/WidgetGtk.cpp:
  54728. (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
  54729. * plugins/gtk/PluginViewGtk.cpp:
  54730. (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
  54731. plugin events, set the window value to none. This method is also used to send
  54732. focus in / focus out events to windowed plugins, but this is not one of the plugin
  54733. types where the window parameter matters. This matches what Mozilla does. Also
  54734. pass in the display of the widget itself, not the default display.
  54735. (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
  54736. reset the cursor.
  54737. (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
  54738. widget the top-level window explicitly. This matches Mozilla.
  54739. 2011-03-05 Martin Robinson <mrobinson@igalia.com>
  54740. Reviewed by Xan Lopez.
  54741. [GTK] http/tests/plugins/post-url-file.html fails on GTK+
  54742. https://bugs.webkit.org/show_bug.cgi?id=55826
  54743. Correct the implementation of handlePostReadFile which uses GIO APIs and
  54744. actually resizes the buffer to fit the entire size of the file data. This
  54745. was likely leading to memory corruption until now.
  54746. * plugins/gtk/PluginViewGtk.cpp:
  54747. (WebCore::PluginView::handlePostReadFile): Fix this method.
  54748. 2011-03-05 Mikhail Naganov <mnaganov@chromium.org>
  54749. Reviewed by Pavel Feldman.
  54750. Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
  54751. https://bugs.webkit.org/show_bug.cgi?id=55824
  54752. Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
  54753. * inspector/front-end/DetailedHeapshotView.js:
  54754. (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
  54755. * inspector/front-end/ProfilesPanel.js:
  54756. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
  54757. (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  54758. (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
  54759. (WebInspector.ProfilesPanel.prototype.handleShortcut):
  54760. (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
  54761. (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
  54762. (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
  54763. (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
  54764. 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
  54765. Reviewed by Laszlo Gombos.
  54766. [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
  54767. https://bugs.webkit.org/show_bug.cgi?id=48636
  54768. Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
  54769. * WebCore.pri:
  54770. * features.pri:
  54771. 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
  54772. Not reviewed: adding null check to prevent inspector tests from failing.
  54773. * inspector/front-end/TextViewer.js:
  54774. (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
  54775. (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
  54776. 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
  54777. Not reviewed: chromium rebaseline, flaky test fix.
  54778. * inspector/front-end/BreakpointManager.js:
  54779. (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
  54780. (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
  54781. (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
  54782. (WebInspector.DOMBreakpointView.prototype._format.append):
  54783. (WebInspector.DOMBreakpointView.prototype._format):
  54784. 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
  54785. Reviewed by Yury Semikhatsky.
  54786. Web Inspector: [chromium] pause when script is running is broken.
  54787. https://bugs.webkit.org/show_bug.cgi?id=55762
  54788. * inspector/CodeGeneratorInspector.pm:
  54789. 2011-03-05 Adam Barth <abarth@webkit.org>
  54790. Reviewed by Dimitri Glazkov.
  54791. Add Derived Sources to WebCore GYP build
  54792. https://bugs.webkit.org/show_bug.cgi?id=55813
  54793. Adding the derived source action to the GYP file required tweaking
  54794. DerivedSources.make. I'm not sure how DerivedSources.make worked
  54795. before beause these paths were incorrectly based.
  54796. * DerivedSources.make:
  54797. * gyp/generate-derived-sources.sh: Added.
  54798. * gyp/WebCore.gyp:
  54799. 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
  54800. Reviewed by Yury Semikhatsky.
  54801. Web Inspector: fix layout tests flakiness.
  54802. https://bugs.webkit.org/show_bug.cgi?id=55816
  54803. - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
  54804. - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
  54805. * inspector/CodeGeneratorInspector.pm:
  54806. * inspector/InspectorAgent.cpp:
  54807. (WebCore::InspectorAgent::InspectorAgent):
  54808. (WebCore::InspectorAgent::disconnectFrontend):
  54809. (WebCore::InspectorAgent::populateScriptObjects):
  54810. (WebCore::InspectorAgent::evaluateForTestInFrontend):
  54811. (WebCore::InspectorAgent::issueEvaluateForTestCommands):
  54812. * inspector/InspectorAgent.h:
  54813. * inspector/front-end/TimelinePanel.js:
  54814. (WebInspector.TimelinePanel.FormattedRecord):
  54815. * inspector/front-end/inspector.js:
  54816. (WebInspector.dispatch):
  54817. 2011-03-05 Adam Barth <abarth@webkit.org>
  54818. Reviewed by Dimitri Glazkov.
  54819. WebCore GYP build should generate fewer than 10,000 compile errors per file
  54820. https://bugs.webkit.org/show_bug.cgi?id=55810
  54821. This patch adds some missing include paths. We need to figure out how
  54822. to handle separate include paths per port. It's clear that
  54823. ForwardingHeaders are only useful for Mac, but it's less clear how to
  54824. handle the others.
  54825. * WebCore.gypi:
  54826. * gyp/WebCore.gyp:
  54827. 2011-03-05 Dan Bernstein <mitz@apple.com>
  54828. Reviewed by Cameron Zwarich.
  54829. <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
  54830. https://bugs.webkit.org/show_bug.cgi?id=55817
  54831. * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  54832. (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
  54833. a CGFont obtained from Core Text for the primary font. This CGFont may be different from
  54834. the CGFont stored in the FontPlatformData.
  54835. 2011-03-05 Ilya Sherman <isherman@chromium.org>
  54836. Reviewed by Darin Adler.
  54837. HTMLInputElement::setValue() should schedule change event when the element is focused.
  54838. Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
  54839. In service of https://code.google.com/p/chromium/issues/detail?id=42716
  54840. https://bugs.webkit.org/show_bug.cgi?id=53160
  54841. Test: fast/forms/onchange-change-type.html
  54842. Test: fast/forms/onchange-setvalueforuser.html
  54843. * WebCore.exp.in:
  54844. * dom/Document.cpp:
  54845. (WebCore::Document::setFocusedNode):
  54846. * dom/Element.h:
  54847. (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
  54848. (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
  54849. * html/HTMLFormControlElement.cpp:
  54850. (WebCore::HTMLFormControlElement::HTMLFormControlElement):
  54851. (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
  54852. (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
  54853. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
  54854. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
  54855. * html/HTMLFormControlElement.h:
  54856. * html/HTMLInputElement.cpp:
  54857. (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
  54858. (WebCore::HTMLInputElement::setValue):
  54859. For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
  54860. (WebCore::HTMLInputElement::defaultEventHandler):
  54861. (WebCore::HTMLInputElement::stepUpFromRenderer):
  54862. * html/shadow/TextControlInnerElements.cpp:
  54863. (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  54864. * rendering/RenderTextControl.cpp:
  54865. (WebCore::RenderTextControl::RenderTextControl):
  54866. (WebCore::RenderTextControl::subtreeHasChanged):
  54867. * rendering/RenderTextControl.h:
  54868. * rendering/RenderTextControlMultiLine.cpp:
  54869. (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  54870. * rendering/RenderTextControlSingleLine.cpp:
  54871. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  54872. * wml/WMLInputElement.cpp:
  54873. (WebCore::WMLInputElement::WMLInputElement):
  54874. (WebCore::WMLInputElement::defaultEventHandler):
  54875. * wml/WMLInputElement.h:
  54876. (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
  54877. (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
  54878. 2011-03-04 Xianzhu Wang <wangxianzhu@google.com>
  54879. Reviewed by Adam Barth.
  54880. Remove fake request loading of SVGImage to avoid MainResourceLoader
  54881. leak. The frame->init() already ensures initialization of the
  54882. document loader.
  54883. https://bugs.webkit.org/show_bug.cgi?id=55017
  54884. Test: fast/images/svg-image-leak-loader.html
  54885. * svg/graphics/SVGImage.cpp:
  54886. (WebCore::SVGImage::dataChanged):
  54887. 2011-03-04 Mike Reed <reed@google.com>
  54888. Reviewed by Mihai Parparita.
  54889. [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
  54890. https://bugs.webkit.org/show_bug.cgi?id=49477
  54891. * platform/graphics/skia/PathSkia.cpp:
  54892. (WebCore::Path::addArc):
  54893. 2011-03-04 Jia Pu <jpu@apple.com>
  54894. Reviewed by Darin Adler.
  54895. On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
  54896. https://bugs.webkit.org/show_bug.cgi?id=55717
  54897. <rdar://problem/9018127>
  54898. manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
  54899. Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
  54900. coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
  54901. to convert the bounding box to window coordinate using ScrollView::contentToWindow().
  54902. * dom/Range.cpp:
  54903. (WebCore::Range::getBoundingClientRect):
  54904. (WebCore::Range::boundingRect):
  54905. * dom/Range.h:
  54906. * editing/Editor.cpp:
  54907. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  54908. (WebCore::Editor::correctionPanelTimerFired):
  54909. (WebCore::Editor::windowRectForRange):
  54910. * editing/Editor.h:
  54911. * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
  54912. * manual-tests/autocorrection/document-for-iframe-test.html: Added.
  54913. 2011-03-04 Jia Pu <jpu@apple.com>
  54914. Reviewed by Darin Adler.
  54915. Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
  54916. https://bugs.webkit.org/show_bug.cgi?id=55731
  54917. No new tests. There's no behavioral change.
  54918. This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
  54919. * editing/Editor.cpp:
  54920. (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
  54921. 2011-03-04 John Bauman <jbauman@chromium.org>
  54922. Reviewed by Kenneth Russell.
  54923. [chromium] premultipliedAlpha WebGL context attribute is ignored.
  54924. https://bugs.webkit.org/show_bug.cgi?id=55411
  54925. Update compositor to set the blending of each layer correctly.
  54926. Test: compositing/webgl/webgl-nonpremultiplied-blend.html
  54927. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  54928. (WebCore::CanvasLayerChromium::CanvasLayerChromium):
  54929. (WebCore::CanvasLayerChromium::draw):
  54930. * platform/graphics/chromium/CanvasLayerChromium.h:
  54931. * platform/graphics/chromium/ContentLayerChromium.cpp:
  54932. (WebCore::ContentLayerChromium::draw):
  54933. * platform/graphics/chromium/LayerRendererChromium.cpp:
  54934. (WebCore::LayerRendererChromium::drawLayers):
  54935. * platform/graphics/chromium/WebGLLayerChromium.cpp:
  54936. (WebCore::WebGLLayerChromium::setContext):
  54937. 2011-03-04 Adam Barth <abarth@webkit.org>
  54938. Reviewed by Eric Seidel.
  54939. WebCore GYP build should link with the correct frameworks
  54940. https://bugs.webkit.org/show_bug.cgi?id=55804
  54941. * gyp/WebCore.gyp:
  54942. 2011-03-04 Adam Barth <abarth@webkit.org>
  54943. Reviewed by Eric Seidel.
  54944. WebCore GYP build should Check For Inappropriate Files in Framework
  54945. https://bugs.webkit.org/show_bug.cgi?id=55806
  54946. * gyp/WebCore.gyp:
  54947. 2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>
  54948. Reviewed by Adam Barth.
  54949. Add skeletal WebCore.gyp
  54950. https://bugs.webkit.org/show_bug.cgi?id=55802
  54951. This doesn't yet build, but the basic structure is there.
  54952. * WebCore.gypi: Added headers and include directories variables.
  54953. * gyp/WebCore.gyp: Added.
  54954. 2011-03-04 Adam Barth <abarth@webkit.org>
  54955. Reviewed by Dimitri Glazkov.
  54956. Remove unneeded round-trips through ../Source in the Chromium GYP build
  54957. https://bugs.webkit.org/show_bug.cgi?id=55795
  54958. This is just cleanup work, but it was bugging me.
  54959. * WebCore.gyp/WebCore.gyp:
  54960. 2011-03-04 Mike Reed <reed@google.com>
  54961. Reviewed by James Robinson.
  54962. Option to use skia's native text drawing APIs when drawing text
  54963. on Windows, rather than from outlines using drawPath(). This will
  54964. only have a significant effect when the skia-gpu backend is enabled.
  54965. https://bugs.webkit.org/show_bug.cgi?id=55609
  54966. No new tests. This is disabled by default. When enabled, it will draw
  54967. essentially the same, but with slightly different antialiased edges, due
  54968. to differences between the current scanconverter and GDI's font scaler.
  54969. When enabled, we will have to recalibrate layouttest image results.
  54970. * platform/graphics/skia/SkiaFontWin.cpp:
  54971. (WebCore::skiaDrawText):
  54972. (WebCore::setupPaintForFont):
  54973. (WebCore::paintSkiaText):
  54974. 2011-03-04 Adrienne Walker <enne@google.com>
  54975. Reviewed by James Robinson.
  54976. [chromium] Fix texture stride issues on large content and image layers.
  54977. https://bugs.webkit.org/show_bug.cgi?id=55679
  54978. This was an error caused during the refactoring in r80081.
  54979. Tests: LayoutTests/compositing/tiling/huge-layer-img.html
  54980. * platform/graphics/chromium/ContentLayerChromium.cpp:
  54981. (WebCore::ContentLayerChromium::updateTexture):
  54982. * platform/graphics/chromium/ImageLayerChromium.cpp:
  54983. (WebCore::ImageLayerChromium::updateTextureIfNeeded):
  54984. 2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>
  54985. Unreviewed, rolling out r80379.
  54986. http://trac.webkit.org/changeset/80379
  54987. https://bugs.webkit.org/show_bug.cgi?id=55799
  54988. "Breaks leopard compile (implicit conversion)" (Requested by
  54989. tonyg-cr on #webkit).
  54990. * css/CSSStyleSelector.cpp:
  54991. (WebCore::convertToLength):
  54992. (WebCore::CSSStyleSelector::applyProperty):
  54993. (WebCore::CSSStyleSelector::createTransformOperations):
  54994. * platform/Length.h:
  54995. (WebCore::Length::Length):
  54996. (WebCore::Length::operator==):
  54997. (WebCore::Length::operator!=):
  54998. (WebCore::Length::rawValue):
  54999. (WebCore::Length::type):
  55000. (WebCore::Length::quirk):
  55001. (WebCore::Length::setValue):
  55002. (WebCore::Length::setRawValue):
  55003. (WebCore::Length::calcFloatValue):
  55004. (WebCore::Length::isZero):
  55005. (WebCore::Length::blend):
  55006. * rendering/AutoTableLayout.cpp:
  55007. (WebCore::AutoTableLayout::recalcColumn):
  55008. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  55009. * rendering/FixedTableLayout.cpp:
  55010. (WebCore::FixedTableLayout::calcWidthArray):
  55011. 2011-03-04 Jessie Berlin <jberlin@apple.com>
  55012. Reviewed by Darin Adler.
  55013. WebKit2: Use CFNetwork Sessions API.
  55014. https://bugs.webkit.org/show_bug.cgi?id=55435.
  55015. Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
  55016. contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
  55017. * platform/network/cf/ResourceHandleCFNet.cpp:
  55018. (WebCore::makeFinalRequest):
  55019. (WebCore::ResourceHandle::willSendRequest):
  55020. * platform/network/cf/ResourceRequestCFNet.cpp:
  55021. * platform/network/mac/ResourceHandleMac.mm:
  55022. (WebCore::ResourceHandle::createNSURLConnection):
  55023. (WebCore::ResourceHandle::willSendRequest):
  55024. * platform/network/mac/ResourceRequestMac.mm:
  55025. 2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>
  55026. Reviewed by Darin Adler.
  55027. improve layout performance by reducing the traversal time of the floating objects
  55028. https://bugs.webkit.org/show_bug.cgi?id=55440
  55029. We observered large overhead on traversing the floating objects list
  55030. in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
  55031. when the list becomes enormous, for example in the default 30x30 maze test
  55032. from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
  55033. there're >3700 floating objects. When placing a new floating object the
  55034. entire list (from begin to end) is traversed for multiple times.
  55035. There's a low hanging fruit to reduce the chances to do the traversal
  55036. which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
  55037. As the two routines either cares about FloatLeft objects or FloatRight objects only,
  55038. if we know there's no corresponding type floating objects in the list
  55039. we can avoid the traversal actually. One thing we could do is to record
  55040. the number of FloatLeft objects and the number of FloatRight objects and
  55041. add a check before doing the traversal. This can reduce the time by 45%
  55042. to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
  55043. Chromium browser 11 (from 503s to 269s).
  55044. No new tests, relying on existing layout tests.
  55045. * rendering/RenderBlock.cpp:
  55046. (WebCore::RenderBlock::~RenderBlock):
  55047. (WebCore::RenderBlock::addOverflowFromFloats):
  55048. (WebCore::RenderBlock::repaintOverhangingFloats):
  55049. (WebCore::RenderBlock::paintFloats):
  55050. (WebCore::RenderBlock::selectionGaps):
  55051. (WebCore::RenderBlock::insertFloatingObject):
  55052. (WebCore::RenderBlock::removeFloatingObject):
  55053. (WebCore::RenderBlock::removeFloatingObjectsBelow):
  55054. (WebCore::RenderBlock::positionNewFloats):
  55055. (WebCore::RenderBlock::positionNewFloatOnLine):
  55056. (WebCore::RenderBlock::logicalLeftOffsetForLine):
  55057. (WebCore::RenderBlock::logicalRightOffsetForLine):
  55058. (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
  55059. (WebCore::RenderBlock::lowestFloatLogicalBottom):
  55060. (WebCore::RenderBlock::clearFloats):
  55061. (WebCore::RenderBlock::addOverhangingFloats):
  55062. (WebCore::RenderBlock::addIntrudingFloats):
  55063. (WebCore::RenderBlock::containsFloat):
  55064. (WebCore::RenderBlock::hitTestFloats):
  55065. (WebCore::RenderBlock::adjustForBorderFit):
  55066. (WebCore::RenderBlock::FloatingObjects::clear):
  55067. (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
  55068. (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
  55069. * rendering/RenderBlock.h:
  55070. (WebCore::RenderBlock::containsFloats):
  55071. (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
  55072. (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
  55073. (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
  55074. (WebCore::RenderBlock::FloatingObjects::set):
  55075. * rendering/RenderBlockLineLayout.cpp:
  55076. (WebCore::RenderBlock::layoutInlineChildren):
  55077. (WebCore::RenderBlock::matchedEndLine):
  55078. 2011-03-04 Rik Cabanier <cabanier@gmail.com>
  55079. Reviewed by David Hyatt.
  55080. Fix that allows fixed length values to be floating point
  55081. https://bugs.webkit.org/show_bug.cgi?id=52699
  55082. * WebCore.xcodeproj/project.pbxproj:
  55083. * css/CSSStyleSelector.cpp:
  55084. (WebCore::convertToLength):
  55085. (WebCore::convertToIntLength):
  55086. (WebCore::convertToFloatLength):
  55087. (WebCore::CSSStyleSelector::applyProperty):
  55088. (WebCore::CSSStyleSelector::createTransformOperations):
  55089. * platform/Length.h:
  55090. (WebCore::Length::Length):
  55091. (WebCore::Length::operator==):
  55092. (WebCore::Length::operator!=):
  55093. (WebCore::Length::rawValue):
  55094. (WebCore::Length::type):
  55095. (WebCore::Length::quirk):
  55096. (WebCore::Length::setValue):
  55097. (WebCore::Length::calcFloatValue):
  55098. (WebCore::Length::isZero):
  55099. (WebCore::Length::blend):
  55100. (WebCore::Length::getIntValue):
  55101. (WebCore::Length::getFloatValue):
  55102. * rendering/AutoTableLayout.cpp:
  55103. (WebCore::AutoTableLayout::recalcColumn):
  55104. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  55105. * rendering/FixedTableLayout.cpp:
  55106. (WebCore::FixedTableLayout::calcWidthArray):
  55107. 2011-03-04 Steve Falkenburg <sfalken@apple.com>
  55108. Reviewed by Jon Honeycutt.
  55109. Adopt VersionStamper tool for Windows WebKit DLLs
  55110. https://bugs.webkit.org/show_bug.cgi?id=55784
  55111. We now use a tool to stamp the version number onto the Apple WebKit DLLs
  55112. during the post-build step.
  55113. * WebCore.vcproj/QTMovieWin.rc: Removed.
  55114. * WebCore.vcproj/QTMovieWin.vcproj:
  55115. * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
  55116. * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
  55117. * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
  55118. 2011-03-04 Cosmin Truta <ctruta@chromium.org>
  55119. Reviewed by Adam Barth.
  55120. Clarify comment about potential memory leak in SVGImage
  55121. https://bugs.webkit.org/show_bug.cgi?id=55362
  55122. No functionality change. No new tests.
  55123. * svg/graphics/SVGImage.cpp:
  55124. (WebCore::SVGImage::dataChanged):
  55125. 2011-03-04 Jessie Berlin <jberlin@apple.com>
  55126. Reviewed by Maciej Stachowiak.
  55127. WebKit2: Use CFNetwork Sessions API.
  55128. https://bugs.webkit.org/show_bug.cgi?id=55435.
  55129. When Private Browsing is enabled, get the cached url response from the cache associated with
  55130. the Private Browsing Storage Session.
  55131. * WebCore.exp.in:
  55132. Export the symbol for ResourceHandle::privateBrowsingStorageSession.
  55133. 2011-03-04 Steve Block <steveblock@google.com>
  55134. Reviewed by Jeremy Orlow.
  55135. JSC and V8 versions of Java bridge should share JobjectWrapper
  55136. https://bugs.webkit.org/show_bug.cgi?id=55763
  55137. No new tests, refactoring only.
  55138. * Android.jscbindings.mk:
  55139. * Android.v8bindings.mk:
  55140. * WebCore.gypi:
  55141. * WebCore.order:
  55142. * WebCore.xcodeproj/project.pbxproj:
  55143. * bridge/jni/JobjectWrapper.cpp:
  55144. (JobjectWrapper::JobjectWrapper):
  55145. (JobjectWrapper::~JobjectWrapper):
  55146. * bridge/jni/JobjectWrapper.h:
  55147. (JSC::Bindings::JobjectWrapper::instance):
  55148. (JSC::Bindings::JobjectWrapper::setInstance):
  55149. (JSC::Bindings::JobjectWrapper::ref):
  55150. (JSC::Bindings::JobjectWrapper::deref):
  55151. * bridge/jni/jsc/JNIBridgeJSC.cpp:
  55152. (JavaField::JavaField):
  55153. (JavaArray::JavaArray):
  55154. * bridge/jni/jsc/JNIBridgeJSC.h:
  55155. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  55156. (JavaInstance::JavaInstance):
  55157. * bridge/jni/jsc/JavaInstanceJSC.h:
  55158. 2011-03-04 Patrick Gansterer <paroga@webkit.org>
  55159. Reviewed by Nikolas Zimmermann.
  55160. Move shared code into SVGStyledTransformableElement::svgAttributeChanged
  55161. https://bugs.webkit.org/show_bug.cgi?id=55771
  55162. All sub classes of SVGStyledTransformableElement request a relayout
  55163. the same way. So move that code into the common base class.
  55164. * svg/SVGCircleElement.cpp:
  55165. (WebCore::SVGCircleElement::svgAttributeChanged):
  55166. * svg/SVGEllipseElement.cpp:
  55167. (WebCore::SVGEllipseElement::svgAttributeChanged):
  55168. * svg/SVGForeignObjectElement.cpp:
  55169. (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  55170. * svg/SVGGElement.cpp:
  55171. (WebCore::SVGGElement::svgAttributeChanged):
  55172. * svg/SVGImageElement.cpp:
  55173. (WebCore::SVGImageElement::svgAttributeChanged):
  55174. * svg/SVGLineElement.cpp:
  55175. (WebCore::SVGLineElement::svgAttributeChanged):
  55176. * svg/SVGPathElement.cpp:
  55177. (WebCore::SVGPathElement::svgAttributeChanged):
  55178. * svg/SVGPolyElement.cpp:
  55179. (WebCore::SVGPolyElement::svgAttributeChanged):
  55180. * svg/SVGRectElement.cpp:
  55181. (WebCore::SVGRectElement::svgAttributeChanged):
  55182. * svg/SVGStyledTransformableElement.cpp:
  55183. (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
  55184. * svg/SVGStyledTransformableElement.h:
  55185. * svg/SVGUseElement.cpp:
  55186. (WebCore::SVGUseElement::svgAttributeChanged):
  55187. 2011-03-03 John Abd-El-Malek <jam@chromium.org>
  55188. Reviewed by Dimitri Glazkov.
  55189. [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
  55190. https://bugs.webkit.org/show_bug.cgi?id=55748
  55191. * platform/network/chromium/ResourceResponse.cpp:
  55192. (WebCore::ResourceResponse::doPlatformCopyData):
  55193. (WebCore::ResourceResponse::doPlatformAdopt):
  55194. * platform/network/chromium/ResourceResponse.h:
  55195. (WebCore::ResourceResponse::ResourceResponse):
  55196. 2011-03-03 Timothy Hatcher <timothy@apple.com>
  55197. Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
  55198. Reviewed by Darin Adler.
  55199. * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
  55200. 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
  55201. Reviewed by Yury Semikhatsky.
  55202. Web Inspector: extract all code that depends on source mapping from SourceFrame.
  55203. https://bugs.webkit.org/show_bug.cgi?id=55464
  55204. Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
  55205. to encapsulate source mapping aspects from SourceFrame.
  55206. * inspector/front-end/ResourceView.js:
  55207. (WebInspector.ResourceView.createResourceView):
  55208. (WebInspector.SourceFrameDelegateForResourcesPanel):
  55209. (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  55210. * inspector/front-end/ScriptsPanel.js:
  55211. (WebInspector.ScriptsPanel.prototype._createSourceFrame):
  55212. (WebInspector.SourceFrameDelegateForScriptsPanel):
  55213. * inspector/front-end/SourceFrame.js:
  55214. (WebInspector.SourceFrame):
  55215. (WebInspector.SourceFrame.prototype.show):
  55216. (WebInspector.SourceFrame.prototype._createTextViewer):
  55217. (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
  55218. (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
  55219. (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
  55220. (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
  55221. (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
  55222. (WebInspector.SourceFrame.prototype._contextMenu):
  55223. (WebInspector.SourceFrame.prototype._mouseDown):
  55224. (WebInspector.SourceFrame.prototype._mouseMove):
  55225. (WebInspector.SourceFrame.prototype._hidePopup):
  55226. (WebInspector.SourceFrame.prototype._mouseHover):
  55227. (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
  55228. (WebInspector.SourceFrame.prototype._showPopup):
  55229. (WebInspector.SourceFrame.prototype._doubleClick):
  55230. (WebInspector.SourceFrame.prototype._didEditLine):
  55231. (WebInspector.SourceFrameDelegate):
  55232. (WebInspector.SourceFrameDelegate.prototype.requestContent):
  55233. (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
  55234. (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
  55235. (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
  55236. (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
  55237. (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
  55238. (WebInspector.SourceFrameDelegate.prototype.continueToLine):
  55239. (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
  55240. (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
  55241. (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
  55242. (WebInspector.SourceFrameDelegate.prototype.evaluate):
  55243. (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
  55244. 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
  55245. Reviewed by Pavel Feldman.
  55246. Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
  55247. https://bugs.webkit.org/show_bug.cgi?id=55686
  55248. - Use internal ids for resources in extension server.
  55249. - Log errors in inspector tests.
  55250. * inspector/front-end/ExtensionServer.js:
  55251. (WebInspector.ExtensionServer):
  55252. (WebInspector.ExtensionServer.prototype.resetResources):
  55253. (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
  55254. (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  55255. (WebInspector.ExtensionServer.prototype._onGetHAR):
  55256. (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  55257. (WebInspector.ExtensionServer.prototype._resourceId):
  55258. (WebInspector.ExtensionServer.prototype._resourceById):
  55259. * inspector/front-end/HAREntry.js:
  55260. (WebInspector.HARLog):
  55261. (WebInspector.HARLog.prototype._convertResource):
  55262. * inspector/front-end/NetworkPanel.js:
  55263. (WebInspector.NetworkPanel.prototype._reset):
  55264. 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
  55265. Reviewed by Pavel Feldman.
  55266. Web Inspector: exceptions when building context menu in network panel
  55267. https://bugs.webkit.org/show_bug.cgi?id=55678
  55268. * inspector/front-end/DataGrid.js:
  55269. (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
  55270. (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
  55271. * inspector/front-end/NetworkPanel.js:
  55272. (WebInspector.NetworkPanel.prototype._contextMenu):
  55273. 2011-03-04 Ilya Sherman <isherman@chromium.org>
  55274. Reviewed by James Robinson.
  55275. Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
  55276. This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
  55277. is a FramelessScrollView -- which is mostly just for Autofill.
  55278. In service of http://crbug.com/73772 (crash)
  55279. https://bugs.webkit.org/show_bug.cgi?id=55557
  55280. No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
  55281. In particular, DRT crashes when trying to render a FramelessScrollView.
  55282. * platform/ScrollbarTheme.h:
  55283. (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
  55284. (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
  55285. * platform/chromium/FramelessScrollView.cpp:
  55286. (WebCore::FramelessScrollView::paintContents):
  55287. (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
  55288. * platform/chromium/FramelessScrollView.h:
  55289. * platform/chromium/ScrollbarThemeChromium.cpp:
  55290. * platform/chromium/ScrollbarThemeChromium.h:
  55291. 2011-03-04 Yury Semikhatsky <yurys@chromium.org>
  55292. Reviewed by Pavel Feldman.
  55293. Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
  55294. https://bugs.webkit.org/show_bug.cgi?id=55770
  55295. * inspector/InspectorAgent.cpp:
  55296. (WebCore::InspectorAgent::InspectorAgent):
  55297. (WebCore::InspectorAgent::didCommitLoad):
  55298. * inspector/InspectorCSSAgent.cpp:
  55299. (WebCore::InspectorCSSAgent::InspectorCSSAgent):
  55300. (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  55301. * inspector/InspectorCSSAgent.h:
  55302. * inspector/InspectorDatabaseAgent.cpp:
  55303. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
  55304. * inspector/InspectorInstrumentation.cpp:
  55305. (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  55306. * inspector/InspectorInstrumentation.h:
  55307. (WebCore::InspectorInstrumentation::didCommitLoad):
  55308. * inspector/InspectorProfilerAgent.cpp:
  55309. (WebCore::InspectorProfilerAgent::create):
  55310. (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
  55311. (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
  55312. (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
  55313. (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
  55314. (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  55315. (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  55316. * inspector/InspectorProfilerAgent.h:
  55317. * inspector/InstrumentingAgents.h:
  55318. (WebCore::InstrumentingAgents::InstrumentingAgents):
  55319. (WebCore::InstrumentingAgents::inspectorCSSAgent):
  55320. (WebCore::InstrumentingAgents::setInspectorCSSAgent):
  55321. (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
  55322. (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
  55323. (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
  55324. (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
  55325. (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
  55326. (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
  55327. (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
  55328. (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
  55329. (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
  55330. (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
  55331. (WebCore::InstrumentingAgents::inspectorProfilerAgent):
  55332. (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
  55333. 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
  55334. Reviewed by Yury Semikhatsky.
  55335. Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
  55336. https://bugs.webkit.org/show_bug.cgi?id=55773
  55337. * inspector/CodeGeneratorInspector.pm:
  55338. * inspector/InjectedScript.cpp:
  55339. (WebCore::InjectedScript::releaseObjectGroup):
  55340. * inspector/InjectedScript.h:
  55341. * inspector/InjectedScriptHost.cpp:
  55342. (WebCore::InjectedScriptHost::releaseObjectGroup):
  55343. * inspector/InjectedScriptHost.h:
  55344. * inspector/InjectedScriptSource.js:
  55345. (.):
  55346. * inspector/Inspector.idl:
  55347. * inspector/InspectorConsoleAgent.cpp:
  55348. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  55349. * inspector/InspectorRuntimeAgent.cpp:
  55350. (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  55351. * inspector/InspectorRuntimeAgent.h:
  55352. * inspector/front-end/ConsoleView.js:
  55353. (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
  55354. (WebInspector.ConsoleView.prototype.completions):
  55355. * inspector/front-end/PropertiesSidebarPane.js:
  55356. * inspector/front-end/SourceFrame.js:
  55357. (WebInspector.SourceFrame.prototype._hidePopup):
  55358. * inspector/front-end/WatchExpressionsSidebarPane.js:
  55359. (WebInspector.WatchExpressionsSection.prototype.update):
  55360. 2011-03-02 Andrey Adaikin <aandrey@google.com>
  55361. Reviewed by Pavel Feldman.
  55362. Web Inspector: Gutter height should be 100% when few lines are displayed
  55363. https://bugs.webkit.org/show_bug.cgi?id=55574
  55364. * inspector/front-end/SourceFrame.js:
  55365. (WebInspector.SourceFrame.prototype._startEditing):
  55366. * inspector/front-end/TextViewer.js:
  55367. (WebInspector.TextViewer.prototype._syncScroll):
  55368. (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
  55369. (WebInspector.TextEditorGutterPanel.prototype.textChanged):
  55370. (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
  55371. * inspector/front-end/textViewer.css:
  55372. (.text-editor-lines):
  55373. (.text-editor-contents .inner-container):
  55374. (.webkit-line-number):
  55375. 2011-03-04 Andrey Adaikin <aandrey@google.com>
  55376. Reviewed by Pavel Feldman.
  55377. Web Inspector: [Text editor] Do bisect to find visible chunks
  55378. https://bugs.webkit.org/show_bug.cgi?id=55685
  55379. * inspector/front-end/TextViewer.js:
  55380. (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
  55381. (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
  55382. (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
  55383. (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
  55384. (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
  55385. (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
  55386. 2011-03-04 Andrey Adaikin <aandrey@google.com>
  55387. Reviewed by Pavel Feldman.
  55388. Web Inspector: [Text editor] DOMNodeRemoved events are missing
  55389. https://bugs.webkit.org/show_bug.cgi?id=55769
  55390. * inspector/front-end/TextViewer.js:
  55391. (WebInspector.TextEditorMainPanel):
  55392. (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
  55393. (WebInspector.TextEditorMainChunk):
  55394. (WebInspector.TextEditorMainChunk.prototype._createRow):
  55395. 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
  55396. Reviewed by Yury Semikhatsky.
  55397. Web Inspector: Remove unnecessary domain and success flags from the response messages.
  55398. https://bugs.webkit.org/show_bug.cgi?id=55768
  55399. We have domain property in the response messages but it is not used because we dispatch
  55400. the responses on the callback associated with seq.
  55401. If we have property 'errors' in the response then success eq false and true in the other case.
  55402. * inspector/CodeGeneratorInspector.pm:
  55403. 2011-03-04 Christian Dywan <christian@lanedo.com>
  55404. Reviewed by Gustavo Noronha Silva.
  55405. Enable Copy Image Address context menu item in the Gtk port
  55406. https://bugs.webkit.org/show_bug.cgi?id=55136
  55407. * page/ContextMenuController.cpp:
  55408. * platform/ContextMenuItem.h:
  55409. * platform/LocalizationStrategy.h:
  55410. * platform/LocalizedStrings.cpp:
  55411. * platform/LocalizedStrings.h:
  55412. * platform/gtk/ContextMenuItemGtk.cpp:
  55413. * platform/gtk/LocalizedStringsGtk.cpp:
  55414. 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
  55415. Reviewed by Yury Semikhatsky.
  55416. Web Inspector: implement getCompletions via evaluate.
  55417. https://bugs.webkit.org/show_bug.cgi?id=55759
  55418. * inspector/InjectedScript.cpp:
  55419. * inspector/InjectedScript.h:
  55420. * inspector/InjectedScriptSource.js:
  55421. * inspector/Inspector.idl:
  55422. * inspector/InspectorDebuggerAgent.cpp:
  55423. * inspector/InspectorDebuggerAgent.h:
  55424. * inspector/InspectorRuntimeAgent.cpp:
  55425. * inspector/InspectorRuntimeAgent.h:
  55426. * inspector/front-end/ConsoleView.js:
  55427. (WebInspector.ConsoleView.prototype.completions.evaluated):
  55428. (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
  55429. (WebInspector.ConsoleView.prototype.completions):
  55430. (WebInspector.ConsoleView.prototype._reportCompletions):
  55431. * inspector/front-end/ScriptsPanel.js:
  55432. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
  55433. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  55434. * inspector/front-end/SourceFrame.js:
  55435. (WebInspector.SourceFrame.prototype._showPopup):
  55436. (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
  55437. 2011-03-04 Steve Block <steveblock@google.com>
  55438. Reviewed by Jeremy Orlow.
  55439. V8 version of JavaString should obtain string from JNI in UTF-16 encoding
  55440. https://bugs.webkit.org/show_bug.cgi?id=55566
  55441. We obtain the string from JNI in UTF-16 encoding and convert
  55442. to UTF-8 using our own routines as required. This matches the
  55443. behaviour of the JSC version of JavaString.
  55444. No new tests, no change in behaviour.
  55445. * bridge/jni/v8/JavaStringV8.h:
  55446. (JSC::Bindings::JavaStringImpl::init):
  55447. (JSC::Bindings::JavaStringImpl::utf8):
  55448. (JSC::Bindings::JavaStringImpl::impl):
  55449. 2011-03-03 Pavel Feldman <pfeldman@chromium.org>
  55450. Reviewed by Yury Semikhatsky.
  55451. Web Inspector: do not push document into front-end, make it request one.
  55452. https://bugs.webkit.org/show_bug.cgi?id=55664
  55453. * inspector/Inspector.idl:
  55454. * inspector/InspectorAgent.cpp:
  55455. (WebCore::InspectorAgent::InspectorAgent):
  55456. * inspector/InspectorAgent.h:
  55457. * inspector/InspectorBrowserDebuggerAgent.cpp:
  55458. (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  55459. * inspector/InspectorDOMAgent.cpp:
  55460. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  55461. (WebCore::InspectorDOMAgent::clearFrontend):
  55462. (WebCore::InspectorDOMAgent::setDocument):
  55463. (WebCore::InspectorDOMAgent::getDocument):
  55464. (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
  55465. (WebCore::InspectorDOMAgent::boundNodeId):
  55466. (WebCore::InspectorDOMAgent::resolveNode):
  55467. (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
  55468. * inspector/InspectorDOMAgent.h:
  55469. (WebCore::InspectorDOMAgent::create):
  55470. * inspector/front-end/BreakpointManager.js:
  55471. (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
  55472. (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
  55473. (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
  55474. * inspector/front-end/DOMAgent.js:
  55475. (WebInspector.DOMDocument):
  55476. (WebInspector.DOMAgent):
  55477. (WebInspector.DOMAgent.prototype.requestDocument):
  55478. (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
  55479. (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
  55480. (WebInspector.DOMAgent.prototype._attributesUpdated):
  55481. (WebInspector.DOMAgent.prototype._characterDataModified):
  55482. (WebInspector.DOMAgent.prototype._documentUpdated):
  55483. (WebInspector.DOMAgent.prototype._setDocument):
  55484. (WebInspector.DOMAgent.prototype._setDetachedRoot):
  55485. (WebInspector.DOMAgent.prototype._setChildNodes):
  55486. (WebInspector.DOMAgent.prototype._childNodeInserted):
  55487. (WebInspector.DOMAgent.prototype._childNodeRemoved):
  55488. (WebInspector.DOMDispatcher.prototype.documentUpdated):
  55489. * inspector/front-end/ElementsPanel.js:
  55490. (WebInspector.ElementsPanel.prototype.show):
  55491. (WebInspector.ElementsPanel.prototype.setDocument):
  55492. * inspector/front-end/MetricsSidebarPane.js:
  55493. * inspector/front-end/RemoteObject.js:
  55494. (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  55495. 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
  55496. Reviewed by Pavel Feldman.
  55497. Web Inspector: summary bar may overlap content of the network item view
  55498. https://bugs.webkit.org/show_bug.cgi?id=55656
  55499. - drop custom summary bar placement logic, do it with CSS instead.
  55500. * inspector/front-end/NetworkPanel.js:
  55501. (WebInspector.NetworkPanel.prototype.resize):
  55502. (WebInspector.NetworkPanel.prototype._createSummaryBar):
  55503. (WebInspector.NetworkPanel.prototype._updateSummaryBar):
  55504. (WebInspector.NetworkPanel.prototype._updateFilter):
  55505. (WebInspector.NetworkPanel.prototype.show):
  55506. (WebInspector.NetworkPanel.prototype.refresh):
  55507. (WebInspector.NetworkPanel.prototype._reset):
  55508. (WebInspector.NetworkPanel.prototype._setLargerResources):
  55509. (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
  55510. * inspector/front-end/networkPanel.css:
  55511. (.network-sidebar .data-grid td):
  55512. (.network-sidebar tr.filler td):
  55513. (.network-summary-bar):
  55514. (.network-sidebar .data-grid .network-summary-bar td):
  55515. (.network-summary-bar img):
  55516. 2011-03-04 James Su <suzhe@chromium.org>
  55517. Reviewed by Dimitri Glazkov.
  55518. [Chromium] keycode is always 0 when using non-Latin keyboard layout.
  55519. https://bugs.webkit.org/show_bug.cgi?id=54939
  55520. Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
  55521. No intended functionality change.
  55522. * WebCore.gyp/WebCore.gyp:
  55523. * WebCore.gypi:
  55524. 2011-03-04 Patrick Gansterer <paroga@webkit.org>
  55525. Unreviewed EFL build fix for r80324.
  55526. * platform/efl/RenderThemeEfl.cpp:
  55527. (WebCore::RenderThemeEfl::paintThemePart):
  55528. 2011-03-04 Patrick Gansterer <paroga@webkit.org>
  55529. Unreviewed EFL build fix for r80324.
  55530. * platform/efl/RenderThemeEfl.cpp:
  55531. (WebCore::RenderThemeEfl::paintThemePart):
  55532. 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
  55533. Reviewed by Pavel Feldman.
  55534. Web Inspector: AppCache agent should have same lifetime as InspectorAgent
  55535. https://bugs.webkit.org/show_bug.cgi?id=55673
  55536. * inspector/InspectorAgent.cpp:
  55537. (WebCore::InspectorAgent::InspectorAgent):
  55538. (WebCore::InspectorAgent::setFrontend):
  55539. (WebCore::InspectorAgent::disconnectFrontend):
  55540. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  55541. (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
  55542. (WebCore::InspectorAgent::didCommitLoad):
  55543. * inspector/InspectorApplicationCacheAgent.cpp:
  55544. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
  55545. (WebCore::InspectorApplicationCacheAgent::setFrontend):
  55546. (WebCore::InspectorApplicationCacheAgent::clearFrontend):
  55547. * inspector/InspectorApplicationCacheAgent.h:
  55548. * inspector/InspectorInstrumentation.cpp:
  55549. (WebCore::InspectorInstrumentation::networkStateChangedImpl):
  55550. (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  55551. * inspector/InstrumentingAgents.h:
  55552. (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
  55553. (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
  55554. 2011-03-03 Brian Weinstein <bweinstein@apple.com>
  55555. Reviewed by Adam Roben.
  55556. Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
  55557. Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
  55558. on all platforms, and stub the functions on platforms that don't implement them.
  55559. Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
  55560. for platforms that don't implement them.
  55561. * platform/android/TemporaryLinkStubs.cpp:
  55562. * platform/brew/TemporaryLinkStubs.cpp:
  55563. * platform/chromium/TemporaryLinkStubs.cpp:
  55564. * platform/efl/TemporaryLinkStubs.cpp:
  55565. * platform/gtk/TemporaryLinkStubs.cpp:
  55566. * platform/haiku/TemporaryLinkStubs.cpp:
  55567. * platform/qt/TemporaryLinkStubsQt.cpp:
  55568. * platform/win/TemporaryLinkStubs.cpp:
  55569. 2011-03-03 Eric Seidel <eric@webkit.org>
  55570. Reviewed by Dimitri Glazkov.
  55571. Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
  55572. https://bugs.webkit.org/show_bug.cgi?id=55720
  55573. There are two thing going on here:
  55574. 1. Delaying nextRenderer calculation until we actually use it,
  55575. previously we would always compute nextRenderer (expensive!)
  55576. even if no renderer insertion was to occur.
  55577. 2. Fix fullscreen elements to be inserted into the right place
  55578. in the rendering tree. Previously they would always be the last
  55579. child in their parent's list, even if that wasn't the right place.
  55580. I don't know of any way to trigger the fullscreen bug,
  55581. but I tested this with peacekeeper and saw no performance change.
  55582. Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
  55583. but I don't really trust the stability of peacekeeper to begin with.
  55584. This paves the way for further improvement in our nextRenderer calculation.
  55585. * dom/Node.cpp:
  55586. (WebCore::Node::attach):
  55587. (WebCore::Node::previousRenderer):
  55588. (WebCore::Node::nextRenderer):
  55589. (WebCore::Node::createRendererAndStyle):
  55590. (WebCore::wrapWithRenderFullScreen):
  55591. (WebCore::Node::createRendererIfNeeded):
  55592. * dom/Node.h:
  55593. 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
  55594. Reviewed by Darin Adler.
  55595. Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
  55596. https://bugs.webkit.org/show_bug.cgi?id=55554
  55597. * platform/Length.cpp:
  55598. (WebCore::newLengthArray): Pass nullptr instead of 0.
  55599. 2011-03-03 Nat Duca <nduca@chromium.org>
  55600. Reviewed by James Robinson.
  55601. [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
  55602. LayerRendererChromium that draws compositor FPS and, optionally,
  55603. the layer tree.
  55604. https://bugs.webkit.org/show_bug.cgi?id=54710
  55605. * WebCore.gypi:
  55606. * platform/graphics/chromium/Canvas2DLayerChromium.h:
  55607. (WebCore::Canvas2DLayerChromium::drawsContent):
  55608. * platform/graphics/chromium/CanvasLayerChromium.h:
  55609. (WebCore::CanvasLayerChromium::layerTypeAsString):
  55610. * platform/graphics/chromium/ContentLayerChromium.cpp:
  55611. (WebCore::writeIndent):
  55612. (WebCore::ContentLayerChromium::dumpLayerProperties):
  55613. * platform/graphics/chromium/ContentLayerChromium.h:
  55614. (WebCore::ContentLayerChromium::drawsContent):
  55615. (WebCore::ContentLayerChromium::layerTypeAsString):
  55616. * platform/graphics/chromium/GraphicsLayerChromium.cpp:
  55617. (WebCore::GraphicsLayerChromium::setName):
  55618. (WebCore::GraphicsLayerChromium::updateNames):
  55619. (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  55620. (WebCore::GraphicsLayerChromium::setupContentsLayer):
  55621. * platform/graphics/chromium/GraphicsLayerChromium.h:
  55622. * platform/graphics/chromium/ImageLayerChromium.h:
  55623. (WebCore::ImageLayerChromium::drawsContent):
  55624. (WebCore::ImageLayerChromium::layerTypeAsString):
  55625. * platform/graphics/chromium/LayerChromium.cpp:
  55626. (WebCore::LayerChromium::LayerChromium):
  55627. (WebCore::LayerChromium::setName):
  55628. (WebCore::LayerChromium::layerTreeAsText):
  55629. (WebCore::writeIndent):
  55630. (WebCore::LayerChromium::dumpLayer):
  55631. (WebCore::LayerChromium::dumpLayerProperties):
  55632. * platform/graphics/chromium/LayerChromium.h:
  55633. (WebCore::LayerChromium::name):
  55634. (WebCore::LayerChromium::drawsContent):
  55635. (WebCore::LayerChromium::debugID):
  55636. (WebCore::LayerChromium::layerTypeAsString):
  55637. * platform/graphics/chromium/LayerRendererChromium.cpp:
  55638. (WebCore::LayerRendererChromium::LayerRendererChromium):
  55639. (WebCore::LayerRendererChromium::~LayerRendererChromium):
  55640. (WebCore::LayerRendererChromium::drawLayers):
  55641. (WebCore::LayerRendererChromium::present):
  55642. (WebCore::LayerRendererChromium::layerTreeAsText):
  55643. (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  55644. * platform/graphics/chromium/LayerRendererChromium.h:
  55645. (WebCore::LayerRendererChromium::getHeadsUpDisplay):
  55646. (WebCore::LayerRendererChromium::rootVisibleRect):
  55647. * platform/graphics/chromium/PluginLayerChromium.h:
  55648. (WebCore::PluginLayerChromium::drawsContent):
  55649. (WebCore::PluginLayerChromium::layerTypeAsString):
  55650. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  55651. (WebCore::RenderSurfaceChromium::name):
  55652. (WebCore::writeIndent):
  55653. (WebCore::RenderSurfaceChromium::dumpSurface):
  55654. * platform/graphics/chromium/RenderSurfaceChromium.h:
  55655. * platform/graphics/chromium/VideoLayerChromium.h:
  55656. (WebCore::VideoLayerChromium::drawsContent):
  55657. (WebCore::VideoLayerChromium::layerTypeAsString):
  55658. * platform/graphics/chromium/WebGLLayerChromium.h:
  55659. (WebCore::WebGLLayerChromium::drawsContent):
  55660. (WebCore::WebGLLayerChromium::layerTypeAsString):
  55661. * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
  55662. (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
  55663. (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
  55664. (WebCore::CCHeadsUpDisplay::draw):
  55665. (WebCore::CCHeadsUpDisplay::drawHudContents):
  55666. (WebCore::CCHeadsUpDisplay::onPresent):
  55667. * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
  55668. (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
  55669. (WebCore::CCHeadsUpDisplay::showFPSCounter):
  55670. (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  55671. (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
  55672. (WebCore::CCHeadsUpDisplay::enabled):
  55673. * platform/graphics/chromium/cc/CCLayerImpl.cpp:
  55674. (WebCore::CCLayerImpl::CCLayerImpl):
  55675. (WebCore::writeIndent):
  55676. (WebCore::CCLayerImpl::dumpLayerProperties):
  55677. * platform/graphics/chromium/cc/CCLayerImpl.h:
  55678. (WebCore::CCLayerImpl::debugID):
  55679. (WebCore::CCLayerImpl::setName):
  55680. (WebCore::CCLayerImpl::name):
  55681. 2011-03-02 Ojan Vafai <ojan@chromium.org>
  55682. Reviewed by Darin Adler.
  55683. crash in adoptNode with mutation events
  55684. https://bugs.webkit.org/show_bug.cgi?id=50046
  55685. If the DOM is modified during the removeChild call in adoptNode,
  55686. then the setDocument call that follows can leave the DOM in an
  55687. inconsistent state.
  55688. * dom/Document.cpp:
  55689. (WebCore::Document::adoptNode):
  55690. 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  55691. Reviewed by Darin Adler.
  55692. Add audio tag tests to the media controls manual test suite.
  55693. https://bugs.webkit.org/show_bug.cgi?id=55722
  55694. * manual-tests/media-controls.html: Added 4 audio tests.
  55695. 2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  55696. Reviewed by Eric Seidel.
  55697. [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
  55698. https://bugs.webkit.org/show_bug.cgi?id=54392
  55699. Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
  55700. WebCore's functions should adhere WebKit coding style.
  55701. * platform/efl/RenderThemeEfl.cpp:
  55702. (WebCore::RenderThemeEfl::themePartCacheEntryReset):
  55703. (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
  55704. (WebCore::RenderThemeEfl::cacheThemePartNew):
  55705. (WebCore::RenderThemeEfl::cacheThemePartReset):
  55706. (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
  55707. (WebCore::RenderThemeEfl::cacheThemePartGet):
  55708. (WebCore::RenderThemeEfl::cacheThemePartFlush):
  55709. (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
  55710. (WebCore::RenderThemeEfl::paintThemePart):
  55711. (WebCore::renderThemeEflColorClassSelectionActive):
  55712. (WebCore::renderThemeEflColorClassSelectionInactive):
  55713. (WebCore::renderThemeEflColorClassFocusRing):
  55714. (WebCore::renderThemeEflColorClassButtonText):
  55715. (WebCore::renderThemeEflColorClassComboText):
  55716. (WebCore::renderThemeEflColorClassEntryText):
  55717. (WebCore::renderThemeEflColorClassSearchText):
  55718. (WebCore::RenderThemeEfl::applyPartDescription):
  55719. (WebCore::RenderThemeEfl::applyPartDescriptions):
  55720. (WebCore::RenderThemeEfl::controlSupportsTints):
  55721. (WebCore::RenderThemeEfl::baselinePosition):
  55722. (WebCore::RenderThemeEfl::paintSliderTrack):
  55723. (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
  55724. (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
  55725. (WebCore::RenderThemeEfl::paintSliderThumb):
  55726. (WebCore::RenderThemeEfl::adjustCheckboxStyle):
  55727. (WebCore::RenderThemeEfl::paintCheckbox):
  55728. (WebCore::RenderThemeEfl::adjustRadioStyle):
  55729. (WebCore::RenderThemeEfl::paintRadio):
  55730. (WebCore::RenderThemeEfl::adjustButtonStyle):
  55731. (WebCore::RenderThemeEfl::paintButton):
  55732. (WebCore::RenderThemeEfl::adjustMenuListStyle):
  55733. (WebCore::RenderThemeEfl::paintMenuList):
  55734. (WebCore::RenderThemeEfl::adjustTextFieldStyle):
  55735. (WebCore::RenderThemeEfl::paintTextField):
  55736. (WebCore::RenderThemeEfl::adjustTextAreaStyle):
  55737. (WebCore::RenderThemeEfl::paintTextArea):
  55738. (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
  55739. (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
  55740. (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
  55741. (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
  55742. (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
  55743. (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
  55744. (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
  55745. (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
  55746. (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
  55747. (WebCore::RenderThemeEfl::paintSearchField):
  55748. (WebCore::RenderThemeEfl::adjustProgressBarStyle):
  55749. (WebCore::RenderThemeEfl::paintProgressBar):
  55750. (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
  55751. (WebCore::RenderThemeEfl::paintMediaMuteButton):
  55752. (WebCore::RenderThemeEfl::paintMediaPlayButton):
  55753. (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
  55754. (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
  55755. (WebCore::RenderThemeEfl::paintMediaSliderTrack):
  55756. (WebCore::RenderThemeEfl::paintMediaSliderThumb):
  55757. (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
  55758. (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
  55759. (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
  55760. (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  55761. 2011-03-03 Andy Estes <aestes@apple.com>
  55762. Reviewed by Adam Barth.
  55763. Assertion failure in toElement(WebCore::Node*)
  55764. https://bugs.webkit.org/show_bug.cgi?id=55697
  55765. Test: fast/parser/fragment-foreign-content.html
  55766. * html/parser/HTMLTreeBuilder.cpp:
  55767. (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
  55768. element in the HTMLElementStack might be a DocumentFragment if a
  55769. fragment is being parsed who's first node is foreign content.
  55770. 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  55771. Reviewed by Kenneth Rohde Christiansen.
  55772. [QT] Implement mock client-based geolocation for layout testing
  55773. https://bugs.webkit.org/show_bug.cgi?id=54334
  55774. Implements client() to GeolocationController to re-use geolocationClientMock class
  55775. for layout testing purpose.
  55776. * page/GeolocationController.h:
  55777. (WebCore::GeolocationController::client):
  55778. 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
  55779. Reviewed by Kent Tamura.
  55780. Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
  55781. https://bugs.webkit.org/show_bug.cgi?id=55352
  55782. Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
  55783. * editing/CompositeEditCommand.cpp:
  55784. (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
  55785. no longer calls deprecated functions.
  55786. * editing/InsertTextCommand.cpp:
  55787. (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
  55788. Check if the text node inside a tab span before checking if the container node is a text node
  55789. because the position before or after a text node can still be inside a tab span.
  55790. (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
  55791. * editing/InsertTextCommand.h:
  55792. * editing/ModifySelectionListLevel.cpp:
  55793. (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
  55794. or the end of selection could be an immediate child of a list node (e.g. br inside ul)
  55795. 2011-03-03 Hans Wennborg <hans@chromium.org>
  55796. Reviewed by Jeremy Orlow.
  55797. IndexedDB: Move last bits of SQL into IDBBackingStore
  55798. https://bugs.webkit.org/show_bug.cgi?id=55668
  55799. After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
  55800. No new tests: refactoring only.
  55801. * storage/IDBBackingStore.cpp:
  55802. (WebCore::IDBBackingStore::createTransaction):
  55803. * storage/IDBBackingStore.h:
  55804. * storage/IDBCursorBackendImpl.h:
  55805. * storage/IDBDatabaseBackendImpl.cpp:
  55806. (WebCore::IDBDatabaseBackendImpl::backingStore):
  55807. * storage/IDBDatabaseBackendImpl.h:
  55808. * storage/IDBIndexBackendImpl.h:
  55809. * storage/IDBKey.h:
  55810. * storage/IDBObjectStoreBackendImpl.h:
  55811. * storage/IDBTransactionBackendImpl.cpp:
  55812. (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
  55813. * storage/IDBTransactionBackendImpl.h:
  55814. * storage/IDBTransactionBackendInterface.h:
  55815. * storage/IDBTransactionCoordinator.cpp:
  55816. 2011-03-03 Adam Klein <adamk@chromium.org>
  55817. Reviewed by David Levin.
  55818. [fileapi] Tighten up ResolveURICallbacks
  55819. https://bugs.webkit.org/show_bug.cgi?id=55638
  55820. Two changes:
  55821. - Retry only on TYPE_MISMATCH_ERR now that Chromium
  55822. properly sets that error code.
  55823. - Call DirectoryEntry instead of DOMFileSystem methods.
  55824. No change in behavior, so no new tests.
  55825. * fileapi/FileSystemCallbacks.cpp:
  55826. (WebCore::ResolveURICallbacks::didOpenFileSystem):
  55827. 2011-03-03 Anders Carlsson <andersca@apple.com>
  55828. Reviewed by Sam Weinig.
  55829. Get rid of Page::globalHistoryItem
  55830. https://bugs.webkit.org/show_bug.cgi?id=55738
  55831. The m_globalHistoryItem is only used by Mac and Windows WebKit1.
  55832. Instead of having WebCore updating this member variable, just call out
  55833. to a FrameLoaderClient member function and let WebKit keep it up to date.
  55834. * loader/EmptyClients.h:
  55835. (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
  55836. (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
  55837. * loader/FrameLoader.cpp:
  55838. (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  55839. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  55840. * loader/FrameLoaderClient.h:
  55841. (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
  55842. * loader/HistoryController.cpp:
  55843. (WebCore::HistoryController::goToItem):
  55844. (WebCore::HistoryController::updateForStandardLoad):
  55845. (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
  55846. * page/Page.cpp:
  55847. * page/Page.h:
  55848. 2011-03-02 Jeremy Orlow <jorlow@chromium.org>
  55849. Reviewed by Steve Block.
  55850. Cursor.continue with a key param should test less than, not equal to
  55851. https://bugs.webkit.org/show_bug.cgi?id=55640
  55852. If you supply a param to cursor.continue, we sould guarantee that
  55853. the item we continue to is greater than or equal to the parameter.
  55854. Right now, we only test equality.
  55855. http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
  55856. http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
  55857. Test: storage/indexeddb/cursor-continue.html
  55858. * storage/IDBCursorBackendImpl.cpp:
  55859. (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  55860. * storage/IDBKey.cpp:
  55861. (WebCore::IDBKey::isLessThan):
  55862. (WebCore::IDBKey::isEqual):
  55863. * storage/IDBKey.h:
  55864. 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
  55865. Build fix. Need win/cURL DownloadBundle stub.
  55866. * platform/network/curl/DownloadBundle.h: Added.
  55867. 2011-03-03 Geoffrey Garen <ggaren@apple.com>
  55868. Rolled out 80277 and 80280 because they caused event handler layout test
  55869. failures.
  55870. * WebCore.xcodeproj/project.pbxproj:
  55871. * bindings/js/JSDOMGlobalObject.cpp:
  55872. * bindings/js/JSDOMGlobalObject.h:
  55873. * bindings/js/JSDOMWindowBase.cpp:
  55874. * bindings/js/JSDOMWindowBase.h:
  55875. * bindings/js/JSDOMWindowCustom.h:
  55876. * bindings/js/JSWorkerContextBase.cpp:
  55877. 2011-03-03 Brady Eidson <beidson@apple.com>
  55878. Reviewed by Darin Adler.
  55879. https://bugs.webkit.org/show_bug.cgi?id=55721
  55880. Global IconDatabase should be returned by reference, not as a pointer
  55881. * history/HistoryItem.cpp:
  55882. (WebCore::HistoryItem::HistoryItem):
  55883. (WebCore::HistoryItem::~HistoryItem):
  55884. (WebCore::HistoryItem::reset):
  55885. (WebCore::HistoryItem::icon):
  55886. (WebCore::HistoryItem::setURLString):
  55887. * loader/FrameLoader.cpp:
  55888. (WebCore::FrameLoader::startIconLoader):
  55889. (WebCore::FrameLoader::commitIconURLToIconDatabase):
  55890. * loader/archive/cf/LegacyWebArchive.cpp:
  55891. (WebCore::LegacyWebArchive::create):
  55892. * loader/icon/IconDatabase.cpp:
  55893. (WebCore::iconDatabase):
  55894. * loader/icon/IconDatabase.h:
  55895. * loader/icon/IconDatabaseNone.cpp:
  55896. (WebCore::iconDatabase):
  55897. * loader/icon/wince/IconDatabaseWinCE.cpp:
  55898. (WebCore::iconDatabase):
  55899. * loader/icon/IconLoader.cpp:
  55900. (WebCore::IconLoader::finishLoading):
  55901. 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
  55902. Reviewed by Martin Robinson.
  55903. Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
  55904. https://bugs.webkit.org/show_bug.cgi?id=52742
  55905. Use firstPositionInOrBeforeNode to instantiate appropriate position.
  55906. * page/FocusController.cpp:
  55907. (WebCore::FocusController::advanceFocusInDocumentOrder):
  55908. 2011-03-03 Andy Estes <aestes@apple.com>
  55909. Reviewed by Darin Adler.
  55910. When displaying the missing plug-in sheet, pass the 'pluginspage'
  55911. attribute to the UI process.
  55912. https://bugs.webkit.org/show_bug.cgi?id=55553
  55913. * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
  55914. * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
  55915. attribute.
  55916. 2011-03-03 Jessie Berlin <jberlin@apple.com>
  55917. Reviewed by Adam Roben.
  55918. WebKit2: Use CFNetwork Sessions API.
  55919. https://bugs.webkit.org/show_bug.cgi?id=55435
  55920. Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
  55921. * WebCore.exp.in:
  55922. Support using WKCopyRequestWithStorageSession in WebCore.
  55923. * platform/mac/WebCoreSystemInterface.h:
  55924. Ditto.
  55925. * platform/mac/WebCoreSystemInterface.mm:
  55926. Ditto.
  55927. * platform/network/cf/ResourceHandleCFNet.cpp:
  55928. (WebCore::makeFinalRequest):
  55929. If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
  55930. (WebCore::ResourceHandle::willSendRequest):
  55931. Ditto.
  55932. * platform/network/mac/ResourceHandleMac.mm:
  55933. (WebCore::ResourceHandle::createNSURLConnection):
  55934. Ditto.
  55935. (WebCore::ResourceHandle::willSendRequest):
  55936. Ditto.
  55937. * platform/network/cf/ResourceRequest.h:
  55938. * platform/network/cf/ResourceRequestCFNet.cpp:
  55939. (WebCore::ResourceRequest::setStorageSession):
  55940. Call through to WKSI.
  55941. * platform/network/mac/ResourceRequestMac.mm:
  55942. (WebCore::ResourceRequest::setStorageSession):
  55943. Ditto.
  55944. 2011-03-03 Chris Marrin <cmarrin@apple.com>
  55945. Reviewed by Simon Fraser.
  55946. REGRESSION: Accelerated transitions are jumpy
  55947. https://bugs.webkit.org/show_bug.cgi?id=55022
  55948. Changed the way default TimingFunction is stored according to Adam Roben's
  55949. suggestion.
  55950. * platform/animation/TimingFunction.h:
  55951. (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
  55952. 2011-03-03 Dan Bernstein <mitz@apple.com>
  55953. Reviewed by Sam Weinig.
  55954. Rename -webkit-hyphenate-locale to -webkit-locale
  55955. https://bugs.webkit.org/show_bug.cgi?id=55709
  55956. * css/CSSComputedStyleDeclaration.cpp:
  55957. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  55958. * css/CSSParser.cpp:
  55959. (WebCore::CSSParser::parseValue):
  55960. (WebCore::cssPropertyID):
  55961. * css/CSSPropertyNames.in:
  55962. * css/CSSStyleSelector.cpp:
  55963. (WebCore::CSSStyleSelector::applyProperty):
  55964. * rendering/RenderBlockLineLayout.cpp:
  55965. (WebCore::RenderBlock::findNextLineBreak):
  55966. * rendering/style/RenderStyle.cpp:
  55967. (WebCore::RenderStyle::diff):
  55968. * rendering/style/RenderStyle.h:
  55969. (WebCore::InheritedFlags::locale):
  55970. (WebCore::InheritedFlags::setLocale):
  55971. (WebCore::InheritedFlags::initialLocale):
  55972. * rendering/style/StyleRareInheritedData.cpp:
  55973. (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  55974. (WebCore::StyleRareInheritedData::operator==):
  55975. * rendering/style/StyleRareInheritedData.h:
  55976. 2011-03-03 Kevin Ollivier <kevino@theolliviers.com>
  55977. [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
  55978. * platform/wx/DragDataWx.cpp:
  55979. * platform/wx/wxcode/win/non-kerned-drawing.cpp:
  55980. (WebCore::drawTextWithSpacing):
  55981. 2011-03-03 Oliver Hunt <oliver@apple.com>
  55982. Reviewed by Geoffrey Garen.
  55983. JSVariableObject needs to use WriteBarrier for symboltable property storage
  55984. https://bugs.webkit.org/show_bug.cgi?id=55698
  55985. Update to pass JSGlobalData for the symbol table write used
  55986. to set the document property.
  55987. * bindings/js/JSDOMWindowBase.cpp:
  55988. (WebCore::JSDOMWindowBase::updateDocument):
  55989. 2011-03-03 Alexey Proskuryakov <ap@apple.com>
  55990. More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
  55991. * WebCore.xcodeproj/project.pbxproj:
  55992. * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
  55993. * page/mac/WebCoreKeyboardUIMode.h: Removed.
  55994. 2011-03-03 Alexey Proskuryakov <ap@apple.com>
  55995. Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
  55996. * page/ChromeClient.h:
  55997. 2011-03-02 Alexey Proskuryakov <ap@apple.com>
  55998. Reviewed by Darin Adler.
  55999. REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
  56000. https://bugs.webkit.org/show_bug.cgi?id=55633
  56001. <rdar://problem/8963023>
  56002. * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
  56003. * page/ChromeClient.h:
  56004. * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
  56005. Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
  56006. returned by former.
  56007. 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  56008. Fix Win compile break, caused by r80276.
  56009. * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
  56010. to match RenderTheme.h.
  56011. 2011-03-02 Geoffrey Garen <ggaren@apple.com>
  56012. Reviewed by Darin Adler.
  56013. Moved all variable object storage inline -- upping the object size limit to 1K
  56014. https://bugs.webkit.org/show_bug.cgi?id=55653
  56015. * bindings/js/JSDOMGlobalObject.cpp:
  56016. * bindings/js/JSDOMGlobalObject.h:
  56017. * bindings/js/JSDOMWindowBase.cpp:
  56018. * bindings/js/JSDOMWindowBase.h:
  56019. * bindings/js/JSDOMWindowCustom.h:
  56020. * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
  56021. 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  56022. Reviewed by Darin Adler.
  56023. Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
  56024. https://bugs.webkit.org/show_bug.cgi?id=55099
  56025. Cleanup, no behavior change.
  56026. * html/shadow/MediaControls.cpp:
  56027. (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
  56028. instead of Node.
  56029. * rendering/RenderMediaControls.cpp:
  56030. (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
  56031. to use RenderBox as argument.
  56032. * rendering/RenderMediaControls.h: Ditto.
  56033. * rendering/RenderTheme.cpp:
  56034. (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
  56035. * rendering/RenderTheme.h: Ditto.
  56036. * rendering/RenderThemeChromiumMac.h: Ditto.
  56037. * rendering/RenderThemeChromiumMac.mm:
  56038. (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
  56039. * rendering/RenderThemeMac.h: Ditto.
  56040. * rendering/RenderThemeMac.mm:
  56041. (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
  56042. * rendering/RenderThemeWin.cpp:
  56043. (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
  56044. 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
  56045. Reviewed by Andreas Kling.
  56046. When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
  56047. Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
  56048. for GstElement.
  56049. * WebCore.pro:
  56050. * features.pri:
  56051. 2011-03-03 Anders Carlsson <andersca@apple.com>
  56052. Try to fix the Windows build again.
  56053. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  56054. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  56055. 2011-03-03 Mihai Parparita <mihaip@chromium.org>
  56056. Reviewed by Dimitri Glazkov.
  56057. Add another CRASH() for CSSSelector double frees
  56058. https://bugs.webkit.org/show_bug.cgi?id=55693
  56059. To help track down bug 53045, add a CRASH call when the the array and/or
  56060. CSSSelector member in CSSSelectorList is disposed of more than once.
  56061. Just a check, no new tests necessary.
  56062. * css/CSSSelectorList.cpp:
  56063. (WebCore::CSSSelectorList::deleteSelectors):
  56064. 2011-03-03 Anders Carlsson <andersca@apple.com>
  56065. Yet another attempt at fixing the Windows build.
  56066. * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  56067. * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
  56068. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  56069. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  56070. 2011-03-02 Chris Marrin <cmarrin@apple.com>
  56071. Reviewed by Simon Fraser.
  56072. REGRESSION: Accelerated transitions are jumpy
  56073. https://bugs.webkit.org/show_bug.cgi?id=55022
  56074. Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
  56075. is now always passed in. The TimingFunction class now has a static method to get
  56076. a default object which has the 'ease' values in it. I now assert in both Mac and
  56077. Win implementations if a null TimingFunction pointer is seen.
  56078. * platform/animation/TimingFunction.h:
  56079. (WebCore::CubicBezierTimingFunction::create):
  56080. (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
  56081. (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
  56082. * platform/graphics/ca/GraphicsLayerCA.cpp:
  56083. (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
  56084. * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  56085. (toCAMediaTimingFunction):
  56086. * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
  56087. (toCACFTimingFunction):
  56088. 2011-03-03 Tony Gentilcore <tonyg@chromium.org>
  56089. Unreviewed build fix.
  56090. Fix clang compile after r80220
  56091. https://bugs.webkit.org/show_bug.cgi?id=55692
  56092. * storage/IDBBackingStore.cpp:
  56093. (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
  56094. 2011-03-03 Anders Carlsson <andersca@apple.com>
  56095. Attempt to fix the Windows build.
  56096. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  56097. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  56098. 2011-03-02 Brian Weinstein <bweinstein@apple.com>
  56099. Reviewed by Adam Roben.
  56100. Rest of WebKit2: Need a way to send notifications to client when cookies change
  56101. https://bugs.webkit.org/show_bug.cgi?id=55427
  56102. <rdar://problem/9056027>
  56103. Add functions to be exported.
  56104. * WebCore.exp.in:
  56105. 2011-03-03 Anders Carlsson <andersca@apple.com>
  56106. Reviewed by Darin Adler.
  56107. Improve WebCore build time by ~5%
  56108. https://bugs.webkit.org/show_bug.cgi?id=55688
  56109. Forward declare the CATransform3D and CGAffineTransform structs instead of including
  56110. large chunks of QuartzCore and Core Graphics.
  56111. On an 8 core Mac Pro, this sped up building WebCore by about 5%.
  56112. * platform/graphics/ca/GraphicsLayerCA.cpp:
  56113. * platform/graphics/ca/TransformationMatrixCA.cpp:
  56114. * platform/graphics/transforms/TransformationMatrix.h:
  56115. 2011-03-03 Andrey Kosyakov <caseq@chromium.org>
  56116. Unreviewed. Adjusted call to a method renamed in r80102.
  56117. * inspector/front-end/SourceFrame.js:
  56118. (WebInspector.SourceFrame.prototype._startEditing):
  56119. 2011-03-03 Timothy Hatcher <timothy@apple.com>
  56120. Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
  56121. by contexts not created by WebCore.
  56122. https://webkit.org/b/55642
  56123. Reviewed by Oliver Hunt.
  56124. * bindings/js/SerializedScriptValue.cpp:
  56125. (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
  56126. (WebCore::SerializedScriptValue::deserialize): Ditto.
  56127. 2011-03-03 Alexey Proskuryakov <ap@apple.com>
  56128. Reviewed by Darin Adler.
  56129. WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
  56130. https://bugs.webkit.org/show_bug.cgi?id=55498
  56131. <rdar://problem/8752706>
  56132. Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
  56133. http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
  56134. * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
  56135. header fields. Removed separate member variables for those, as they were duplicating data
  56136. available in response, and there is no reason to squeeze microsecods here.
  56137. * websockets/WebSocketHandshake.cpp:
  56138. (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
  56139. values to reset here.
  56140. (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
  56141. (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
  56142. (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
  56143. (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
  56144. (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
  56145. (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
  56146. (WebCore::WebSocketHandshake::serverUpgrade): Added.
  56147. (WebCore::WebSocketHandshake::serverConnection): Added.
  56148. (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
  56149. header field presence and values.
  56150. 2011-03-03 Helder Correia <helder@sencha.com>
  56151. Reviewed by Andreas Kling.
  56152. [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
  56153. https://bugs.webkit.org/show_bug.cgi?id=55651
  56154. When relying on ContextShadow and using a gradient stroke for a path,
  56155. the alpha of the shadow is incorrect.
  56156. * platform/graphics/qt/GraphicsContextQt.cpp:
  56157. (WebCore::GraphicsContext::strokePath):
  56158. 2011-03-03 Martin Robinson <mrobinson@igalia.com>
  56159. XHTMLMP build broken after r78342
  56160. https://bugs.webkit.org/show_bug.cgi?id=55286
  56161. Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
  56162. instead of FrameLoader.
  56163. No new tests. This is a build fix.
  56164. * dom/Document.cpp:
  56165. (WebCore::Document::isXHTMLMPDocument):
  56166. 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  56167. Reviewed by Eric Carlson.
  56168. Tweak MediaControlMuteButtonElement class hierarchy.
  56169. https://bugs.webkit.org/show_bug.cgi?id=55614
  56170. This allows the mute button on the panel to have event handlers that are
  56171. different from the mute button in the volume slider.
  56172. No change in behavior, covered by existing tests.
  56173. * html/shadow/MediaControls.cpp:
  56174. (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
  56175. * rendering/MediaControlElements.cpp:
  56176. (WebCore::MediaControlMuteButtonElement::updateDisplayType):
  56177. (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
  56178. (WebCore::MediaControlPanelMuteButtonElement::create): Added.
  56179. (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
  56180. * rendering/MediaControlElements.h: Added defs.
  56181. 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
  56182. Reviewed by Pavel Feldman.
  56183. Web Inspector: Resource agent should have same lifetime as Inspector agent
  56184. https://bugs.webkit.org/show_bug.cgi?id=55461
  56185. * inspector/Inspector.idl:
  56186. * inspector/InspectorAgent.cpp:
  56187. (WebCore::InspectorAgent::InspectorAgent):
  56188. (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
  56189. to clear frontend reference in all agents.
  56190. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  56191. (WebCore::InspectorAgent::setFrontend):
  56192. (WebCore::InspectorAgent::disconnectFrontend):
  56193. (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
  56194. (WebCore::InspectorAgent::didCommitLoad):
  56195. * inspector/InspectorAgent.h:
  56196. (WebCore::InspectorAgent::resourceAgent):
  56197. * inspector/InspectorBrowserDebuggerAgent.cpp:
  56198. (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
  56199. * inspector/InspectorDebuggerAgent.cpp:
  56200. (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
  56201. * inspector/InspectorInstrumentation.cpp:
  56202. (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
  56203. (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
  56204. (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
  56205. (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
  56206. (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  56207. * inspector/InspectorResourceAgent.cpp:
  56208. (WebCore::InspectorResourceAgent::setFrontend):
  56209. (WebCore::InspectorResourceAgent::clearFrontend):
  56210. (WebCore::InspectorResourceAgent::restore):
  56211. (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
  56212. (WebCore::InspectorResourceAgent::enable):
  56213. (WebCore::InspectorResourceAgent::disable):
  56214. (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  56215. * inspector/InspectorResourceAgent.h:
  56216. (WebCore::InspectorResourceAgent::create):
  56217. * inspector/InspectorTimelineAgent.cpp:
  56218. (WebCore::InspectorTimelineAgent::restore):
  56219. * inspector/InspectorTimelineAgent.h:
  56220. * inspector/front-end/NetworkManager.js:
  56221. (WebInspector.NetworkManager):
  56222. (WebInspector.NetworkManager.prototype.frontendReused):
  56223. * inspector/front-end/inspector.js:
  56224. (WebInspector.frontendReused):
  56225. 2011-03-03 Andras Becsi <abecsi@webkit.org>
  56226. Reviewed by Andreas Kling.
  56227. CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
  56228. https://bugs.webkit.org/show_bug.cgi?id=55661
  56229. Test case originally written by Andreas Kling <andreas.kling@nokia.com>
  56230. Test: fast/canvas/rgba-parsing.html
  56231. * css/CSSParser.cpp:
  56232. (WebCore::isValidDouble): Check whether the given string is a valid double.
  56233. (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
  56234. 2011-03-03 David Holloway <dhollowa@chromium.org>
  56235. Reviewed by Dimitri Glazkov.
  56236. Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
  56237. for non-empty suggestion text. The visibility of the placeholder text
  56238. now turned off when suggestion text is set.
  56239. https://bugs.webkit.org/show_bug.cgi?id=55245
  56240. No new tests because, by design, the suggestion text is not accessible
  56241. through the DOM.
  56242. * html/HTMLFormControlElement.cpp:
  56243. (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
  56244. * html/HTMLFormControlElement.h:
  56245. (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
  56246. * html/HTMLInputElement.h:
  56247. (WebCore::HTMLInputElement::isEmptySuggestedValue):
  56248. 2011-03-03 Andy Estes <aestes@apple.com>
  56249. Reviewed by Eric Seidel.
  56250. HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
  56251. https://bugs.webkit.org/show_bug.cgi?id=48719
  56252. Instead of pushing a fake HTMLHtmlElement onto the open element stack
  56253. during fragment parsing only to later remove it and reparent its
  56254. children to the DocumentFragment, push the DocumentFragment directly
  56255. onto the open element stack as the root node. This requires refactoring
  56256. HTMLElementStack to hold ContainerNode pointers rather than Element
  56257. pointers, which has implications for HTMLConstructionSite and
  56258. HTMLTreeBuilder as well.
  56259. With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
  56260. is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
  56261. test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
  56262. regression no longer lies in fragment parsing.
  56263. No new tests. No change in behavior.
  56264. * dom/Element.h:
  56265. (WebCore::Node::hasLocalName):
  56266. * dom/Node.h:
  56267. * html/parser/HTMLConstructionSite.cpp:
  56268. (WebCore::HTMLNames::hasImpliedEndTag):
  56269. (WebCore::HTMLConstructionSite::HTMLConstructionSite):
  56270. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
  56271. (WebCore::HTMLConstructionSite::insertComment):
  56272. (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
  56273. (WebCore::HTMLConstructionSite::attachToCurrent):
  56274. (WebCore::HTMLConstructionSite::insertScriptElement):
  56275. (WebCore::HTMLConstructionSite::insertTextNode):
  56276. (WebCore::HTMLConstructionSite::createElement):
  56277. (WebCore::HTMLConstructionSite::createHTMLElement):
  56278. (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
  56279. (WebCore::HTMLConstructionSite::generateImpliedEndTags):
  56280. (WebCore::HTMLConstructionSite::findFosterSite):
  56281. (WebCore::HTMLConstructionSite::shouldFosterParent):
  56282. * html/parser/HTMLConstructionSite.h:
  56283. (WebCore::HTMLConstructionSite::currentNode):
  56284. * html/parser/HTMLElementStack.cpp:
  56285. (WebCore::HTMLNames::isNumberedHeaderElement):
  56286. (WebCore::HTMLNames::isScopeMarker):
  56287. (WebCore::HTMLNames::isListItemScopeMarker):
  56288. (WebCore::HTMLNames::isTableScopeMarker):
  56289. (WebCore::HTMLNames::isTableBodyScopeMarker):
  56290. (WebCore::HTMLNames::isTableRowScopeMarker):
  56291. (WebCore::HTMLNames::isButtonScopeMarker):
  56292. (WebCore::HTMLNames::isSelectScopeMarker):
  56293. (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
  56294. (WebCore::HTMLElementStack::ElementRecord::replaceElement):
  56295. (WebCore::HTMLElementStack::HTMLElementStack):
  56296. (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
  56297. (WebCore::HTMLElementStack::popAll):
  56298. (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
  56299. (WebCore::HTMLElementStack::popUntil):
  56300. (WebCore::HTMLElementStack::popUntilPopped):
  56301. (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  56302. (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  56303. (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  56304. (WebCore::HTMLElementStack::pushHTMLHtmlElement):
  56305. (WebCore::HTMLElementStack::push):
  56306. (WebCore::HTMLElementStack::insertAbove):
  56307. (WebCore::HTMLElementStack::find):
  56308. (WebCore::HTMLElementStack::topmost):
  56309. (WebCore::HTMLElementStack::contains):
  56310. (WebCore::inScopeCommon):
  56311. (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
  56312. (WebCore::HTMLElementStack::htmlElement):
  56313. (WebCore::HTMLElementStack::rootNode):
  56314. (WebCore::HTMLElementStack::pushCommon):
  56315. * html/parser/HTMLElementStack.h:
  56316. (WebCore::HTMLElementStack::ElementRecord::element):
  56317. (WebCore::HTMLElementStack::ElementRecord::node):
  56318. (WebCore::HTMLElementStack::topNode):
  56319. * html/parser/HTMLTreeBuilder.cpp:
  56320. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  56321. (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
  56322. (WebCore::HTMLTreeBuilder::processStartTagForInBody):
  56323. (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
  56324. (WebCore::HTMLTreeBuilder::processStartTag):
  56325. (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
  56326. (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
  56327. (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  56328. (WebCore::HTMLTreeBuilder::processEndTagForInCell):
  56329. (WebCore::HTMLTreeBuilder::processEndTagForInBody):
  56330. (WebCore::HTMLTreeBuilder::processEndTag):
  56331. (WebCore::HTMLTreeBuilder::processEndOfFile):
  56332. (WebCore::HTMLTreeBuilder::finished):
  56333. * html/parser/HTMLTreeBuilder.h:
  56334. 2011-03-02 Yury Semikhatsky <yurys@chromium.org>
  56335. Reviewed by Pavel Feldman.
  56336. Web Inspector: inspector protocol should allow different domains to have methods with same name
  56337. https://bugs.webkit.org/show_bug.cgi?id=55558
  56338. * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
  56339. 2011-03-02 Pavel Podivilov <podivilov@chromium.org>
  56340. Reviewed by Yury Semikhatsky.
  56341. Web Inspector: make selected call frame debugger presentation model property.
  56342. https://bugs.webkit.org/show_bug.cgi?id=55582
  56343. * inspector/front-end/CallStackSidebarPane.js:
  56344. (WebInspector.CallStackSidebarPane):
  56345. (WebInspector.CallStackSidebarPane.prototype.update):
  56346. (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
  56347. (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
  56348. * inspector/front-end/ConsoleView.js:
  56349. (WebInspector.ConsoleView.prototype.completions):
  56350. * inspector/front-end/DebuggerPresentationModel.js:
  56351. (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  56352. (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
  56353. * inspector/front-end/ScriptsPanel.js:
  56354. (WebInspector.ScriptsPanel):
  56355. (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
  56356. (WebInspector.ScriptsPanel.prototype._debuggerResumed):
  56357. (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  56358. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  56359. 2011-03-03 Jia Pu <jpu@apple.com>
  56360. Reviewed by Darin Adler.
  56361. On Mac OS X, spelling suggestion panel stops showing up after change set 80121
  56362. https://bugs.webkit.org/show_bug.cgi?id=55628
  56363. Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
  56364. * editing/Editor.cpp:
  56365. (WebCore::Editor::appliedEditing):
  56366. * manual-tests/autocorrection/autocorrection-contraction.html:
  56367. 2011-03-03 Pavel Podivilov <podivilov@chromium.org>
  56368. Reviewed by Pavel Feldman.
  56369. Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
  56370. https://bugs.webkit.org/show_bug.cgi?id=55569
  56371. sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
  56372. * inspector/front-end/DebuggerPresentationModel.js:
  56373. * inspector/front-end/ScriptsPanel.js:
  56374. 2011-03-03 Steve Block <steveblock@google.com>
  56375. Reviewed by David Levin.
  56376. JavaString API should be implementable by both JSC and V8
  56377. https://bugs.webkit.org/show_bug.cgi?id=55567
  56378. Remove JavaString's UString operator and replace it with a
  56379. script-engine-independent impl() method, which returns a
  56380. StringImpl and can be implemented with both JSC and V8.
  56381. No new tests, refactoring only.
  56382. * bridge/jni/JNIBridge.h:
  56383. (JSC::Bindings::JavaString::impl):
  56384. * bridge/jni/jni_jsobject.mm:
  56385. (JavaJSObject::call):
  56386. (JavaJSObject::eval):
  56387. (JavaJSObject::getMember):
  56388. (JavaJSObject::setMember):
  56389. (JavaJSObject::removeMember):
  56390. * bridge/jni/jsc/JNIBridgeJSC.cpp:
  56391. (JavaField::valueFromInstance):
  56392. (JavaField::setValueToInstance):
  56393. * bridge/jni/jsc/JavaClassJSC.cpp:
  56394. (JavaClass::JavaClass):
  56395. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  56396. (JavaInstance::invokeMethod):
  56397. * bridge/jni/jsc/JavaStringJSC.h:
  56398. (JSC::Bindings::JavaStringImpl::impl):
  56399. * bridge/jni/v8/JavaStringV8.h:
  56400. (JSC::Bindings::JavaStringImpl::impl):
  56401. 2011-03-03 Benjamin Poulain <ikipou@gmail.com>
  56402. Reviewed by Adam Roben.
  56403. REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
  56404. https://bugs.webkit.org/show_bug.cgi?id=55602
  56405. Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
  56406. The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
  56407. objects need to be deleted manually with ListHashSet.
  56408. * rendering/RenderBlock.cpp:
  56409. (WebCore::RenderBlock::clearFloats):
  56410. 2011-03-03 Hans Wennborg <hans@chromium.org>
  56411. Reviewed by Jeremy Orlow.
  56412. IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
  56413. https://bugs.webkit.org/show_bug.cgi?id=55376
  56414. Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
  56415. IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
  56416. No new functionality, so no new tests.
  56417. * storage/IDBBackingStore.cpp:
  56418. (WebCore::lowerCursorWhereFragment):
  56419. (WebCore::upperCursorWhereFragment):
  56420. (WebCore::IDBBackingStore::deleteObjectStoreRecord):
  56421. (WebCore::IDBBackingStore::keyExistsInObjectStore):
  56422. (WebCore::IDBBackingStore::getObjectViaIndex):
  56423. (WebCore::keyFromQuery):
  56424. (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
  56425. (WebCore::IDBBackingStore::keyExistsInIndex):
  56426. (WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
  56427. (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
  56428. (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
  56429. (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
  56430. (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
  56431. (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
  56432. (WebCore::IDBBackingStore::openObjectStoreCursor):
  56433. (WebCore::ObjectStoreCursorImpl::loadCurrentRow):
  56434. (WebCore::ObjectStoreCursorImpl::currentRowExists):
  56435. (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
  56436. (WebCore::IndexKeyCursorImpl::indexDataId):
  56437. (WebCore::IndexKeyCursorImpl::key):
  56438. (WebCore::IndexKeyCursorImpl::primaryKey):
  56439. (WebCore::IndexKeyCursorImpl::continueFunction):
  56440. (WebCore::IDBBackingStore::openIndexKeyCursor):
  56441. (WebCore::IndexKeyCursorImpl::loadCurrentRow):
  56442. (WebCore::IndexKeyCursorImpl::currentRowExists):
  56443. (WebCore::IndexCursorImpl::IndexCursorImpl):
  56444. (WebCore::IndexCursorImpl::indexDataId):
  56445. (WebCore::IndexCursorImpl::key):
  56446. (WebCore::IndexCursorImpl::primaryKey):
  56447. (WebCore::IndexCursorImpl::value):
  56448. (WebCore::IndexCursorImpl::continueFunction):
  56449. (WebCore::IDBBackingStore::openIndexCursor):
  56450. (WebCore::IndexCursorImpl::loadCurrentRow):
  56451. (WebCore::IndexCursorImpl::currentRowExists):
  56452. * storage/IDBBackingStore.h:
  56453. (WebCore::IDBBackingStore::Cursor::~Cursor):
  56454. * storage/IDBCursorBackendImpl.cpp:
  56455. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
  56456. (WebCore::IDBCursorBackendImpl::key):
  56457. (WebCore::IDBCursorBackendImpl::value):
  56458. (WebCore::IDBCursorBackendImpl::update):
  56459. (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  56460. (WebCore::IDBCursorBackendImpl::deleteFunction):
  56461. * storage/IDBCursorBackendImpl.h:
  56462. (WebCore::IDBCursorBackendImpl::create):
  56463. * storage/IDBIndexBackendImpl.cpp:
  56464. (WebCore::IDBIndexBackendImpl::openCursorInternal):
  56465. (WebCore::IDBIndexBackendImpl::getInternal):
  56466. (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  56467. * storage/IDBIndexBackendImpl.h:
  56468. * storage/IDBKey.cpp:
  56469. (WebCore::IDBKey::isEqual):
  56470. * storage/IDBKey.h:
  56471. * storage/IDBKeyRange.cpp:
  56472. * storage/IDBKeyRange.h:
  56473. * storage/IDBObjectStoreBackendImpl.cpp:
  56474. (WebCore::IDBObjectStoreBackendImpl::putInternal):
  56475. (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
  56476. (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  56477. * storage/IDBObjectStoreBackendImpl.h:
  56478. 2011-03-03 Peter Kasting <pkasting@google.com>
  56479. Reviewed by James Robinson.
  56480. Drop redundant "Windows; " from the Windows-specific User Agent string.
  56481. https://bugs.webkit.org/show_bug.cgi?id=54567
  56482. * StringsNotToBeLocalized.txt:
  56483. 2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>
  56484. Reviewed by Martin Robinson.
  56485. [GTK] Combo boxes should emit object:selection-changed even when collapsed
  56486. https://bugs.webkit.org/show_bug.cgi?id=53146
  56487. Emit the selection-changed signals when the menu list value has changed
  56488. Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
  56489. * accessibility/gtk/AXObjectCacheAtk.cpp:
  56490. (WebCore::getListObject): New, return the right list object for
  56491. menu lists and list boxes.
  56492. (WebCore::notifyChildrenSelectionChange): Support menu lists.
  56493. (WebCore::AXObjectCache::postPlatformNotification): Call function
  56494. notifyChildrenSelectionChange for AXMenuListValueChanged.
  56495. 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
  56496. Reviewed by Tony Chang.
  56497. applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
  56498. https://bugs.webkit.org/show_bug.cgi?id=55338
  56499. Include wtf/Forward.h instead of wtf/text/String.h
  56500. * editing/EditingStyle.h:
  56501. 2011-03-03 Csaba Osztrogonác <ossy@webkit.org>
  56502. Unreviewed trivial fix after r80169.
  56503. [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
  56504. https://bugs.webkit.org/show_bug.cgi?id=55484
  56505. * WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
  56506. 2011-03-02 MORITA Hajime <morrita@google.com>
  56507. Reviewed by Kent Tamura.
  56508. [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
  56509. https://bugs.webkit.org/show_bug.cgi?id=54440
  56510. - Extracted FrameActionScheduler from FrameView
  56511. - Extracted FrameAction abstract class from ScheduledEvent,
  56512. which has fire() virtual method.
  56513. - Renamed ScheduledEvent EventFrameAction
  56514. With this change, Any action can be hooked up to the end of the layout.
  56515. No new tests. No behavioral change.
  56516. * Android.mk:
  56517. * CMakeLists.txt:
  56518. * GNUmakefile.am:
  56519. * WebCore.gypi:
  56520. * WebCore.pro:
  56521. * WebCore.vcproj/WebCore.vcproj:
  56522. * WebCore.xcodeproj/project.pbxproj:
  56523. * page/FrameActionScheduler.cpp: Added.
  56524. (WebCore::EventFrameAction::EventFrameAction):
  56525. (WebCore::EventFrameAction::fire):
  56526. (WebCore::FrameActionScheduler::FrameActionScheduler):
  56527. (WebCore::FrameActionScheduler::~FrameActionScheduler):
  56528. (WebCore::FrameActionScheduler::isEmpty):
  56529. (WebCore::FrameActionScheduler::clear):
  56530. (WebCore::FrameActionScheduler::pause):
  56531. (WebCore::FrameActionScheduler::resume):
  56532. (WebCore::FrameActionScheduler::dispatch):
  56533. (WebCore::FrameActionScheduler::scheduleAction):
  56534. (WebCore::FrameActionScheduler::scheduleEvent):
  56535. * page/FrameActionScheduler.h: Added.
  56536. (WebCore::FrameAction::FrameAction):
  56537. (WebCore::FrameAction::~FrameAction):
  56538. (WebCore::FrameActionScheduler::isScheduled):
  56539. * page/FrameView.cpp:
  56540. (WebCore::FrameView::FrameView):
  56541. (WebCore::FrameView::~FrameView):
  56542. (WebCore::FrameView::layout):
  56543. (WebCore::FrameView::scheduleEvent):
  56544. (WebCore::FrameView::pauseScheduledEvents):
  56545. (WebCore::FrameView::resumeScheduledEvents):
  56546. (WebCore::FrameView::performPostLayoutTasks):
  56547. (WebCore::FrameView::updateOverflowStatus):
  56548. * page/FrameView.h:
  56549. 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
  56550. Unreviewed, rolling out r80201.
  56551. http://trac.webkit.org/changeset/80201
  56552. https://bugs.webkit.org/show_bug.cgi?id=55648
  56553. "caused tests to crash on several bots" (Requested by rniwa on
  56554. #webkit).
  56555. * dom/Element.h:
  56556. (WebCore::Node::hasTagName):
  56557. * dom/Node.h:
  56558. * html/parser/HTMLConstructionSite.cpp:
  56559. (WebCore::HTMLNames::hasImpliedEndTag):
  56560. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
  56561. (WebCore::HTMLConstructionSite::insertComment):
  56562. (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
  56563. (WebCore::HTMLConstructionSite::attachToCurrent):
  56564. (WebCore::HTMLConstructionSite::insertScriptElement):
  56565. (WebCore::HTMLConstructionSite::insertTextNode):
  56566. (WebCore::HTMLConstructionSite::createElement):
  56567. (WebCore::HTMLConstructionSite::createHTMLElement):
  56568. (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
  56569. (WebCore::HTMLConstructionSite::generateImpliedEndTags):
  56570. (WebCore::HTMLConstructionSite::findFosterSite):
  56571. (WebCore::HTMLConstructionSite::shouldFosterParent):
  56572. * html/parser/HTMLConstructionSite.h:
  56573. * html/parser/HTMLElementStack.cpp:
  56574. (WebCore::HTMLNames::isNumberedHeaderElement):
  56575. (WebCore::HTMLNames::isScopeMarker):
  56576. (WebCore::HTMLNames::isListItemScopeMarker):
  56577. (WebCore::HTMLNames::isTableScopeMarker):
  56578. (WebCore::HTMLNames::isTableBodyScopeMarker):
  56579. (WebCore::HTMLNames::isTableRowScopeMarker):
  56580. (WebCore::HTMLNames::isButtonScopeMarker):
  56581. (WebCore::HTMLNames::isSelectScopeMarker):
  56582. (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
  56583. (WebCore::HTMLElementStack::ElementRecord::replaceElement):
  56584. (WebCore::HTMLElementStack::HTMLElementStack):
  56585. (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
  56586. (WebCore::HTMLElementStack::popAll):
  56587. (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  56588. (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  56589. (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  56590. (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
  56591. (WebCore::HTMLElementStack::pushHTMLHtmlElement):
  56592. (WebCore::HTMLElementStack::push):
  56593. (WebCore::HTMLElementStack::insertAbove):
  56594. (WebCore::HTMLElementStack::find):
  56595. (WebCore::HTMLElementStack::topmost):
  56596. (WebCore::inScopeCommon):
  56597. (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
  56598. (WebCore::HTMLElementStack::htmlElement):
  56599. (WebCore::HTMLElementStack::bodyElement):
  56600. (WebCore::HTMLElementStack::pushCommon):
  56601. * html/parser/HTMLElementStack.h:
  56602. (WebCore::HTMLElementStack::ElementRecord::element):
  56603. (WebCore::HTMLElementStack::top):
  56604. * html/parser/HTMLTreeBuilder.cpp:
  56605. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  56606. (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  56607. (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
  56608. (WebCore::HTMLTreeBuilder::processStartTagForInBody):
  56609. (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
  56610. (WebCore::HTMLTreeBuilder::processStartTag):
  56611. (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
  56612. (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
  56613. (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  56614. (WebCore::HTMLTreeBuilder::processEndTagForInCell):
  56615. (WebCore::HTMLTreeBuilder::processEndTagForInBody):
  56616. (WebCore::HTMLTreeBuilder::processEndTag):
  56617. (WebCore::HTMLTreeBuilder::processEndOfFile):
  56618. (WebCore::HTMLTreeBuilder::finished):
  56619. * html/parser/HTMLTreeBuilder.h:
  56620. 2011-03-02 Yury Semikhatsky <yurys@chromium.org>
  56621. Reviewed by Pavel Feldman.
  56622. Web Inspector: break down InspectorFrontend into domain-specific classes
  56623. https://bugs.webkit.org/show_bug.cgi?id=55584
  56624. * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
  56625. all domains that have event notifications.
  56626. * inspector/ConsoleMessage.cpp:
  56627. (WebCore::ConsoleMessage::addToFrontend):
  56628. (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  56629. * inspector/ConsoleMessage.h:
  56630. * inspector/InjectedScriptHost.cpp:
  56631. (WebCore::InjectedScriptHost::inspectImpl):
  56632. * inspector/Inspector.idl:
  56633. * inspector/InspectorAgent.cpp:
  56634. (WebCore::InspectorAgent::inspectedPageDestroyed):
  56635. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  56636. (WebCore::InspectorAgent::setFrontend):
  56637. (WebCore::InspectorAgent::disconnectFrontend):
  56638. (WebCore::InspectorAgent::populateScriptObjects):
  56639. (WebCore::InspectorAgent::pushDataCollectedOffline):
  56640. (WebCore::InspectorAgent::didCommitLoad):
  56641. (WebCore::InspectorAgent::domContentLoadedEventFired):
  56642. (WebCore::InspectorAgent::loadEventFired):
  56643. (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
  56644. (WebCore::InspectorAgent::evaluateForTestInFrontend):
  56645. (WebCore::InspectorAgent::showPanel):
  56646. * inspector/InspectorApplicationCacheAgent.cpp:
  56647. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
  56648. * inspector/InspectorApplicationCacheAgent.h:
  56649. * inspector/InspectorConsoleAgent.cpp:
  56650. (WebCore::InspectorConsoleAgent::setFrontend):
  56651. * inspector/InspectorConsoleAgent.h:
  56652. * inspector/InspectorController.cpp:
  56653. (WebCore::InspectorController::show):
  56654. (WebCore::InspectorController::close):
  56655. * inspector/InspectorDOMAgent.cpp:
  56656. (WebCore::InspectorDOMAgent::setFrontend):
  56657. * inspector/InspectorDOMAgent.h:
  56658. * inspector/InspectorDOMStorageResource.cpp:
  56659. (WebCore::InspectorDOMStorageResource::bind):
  56660. * inspector/InspectorDOMStorageResource.h:
  56661. * inspector/InspectorDatabaseAgent.cpp:
  56662. (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
  56663. (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
  56664. (WebCore::InspectorDatabaseAgent::setFrontend):
  56665. * inspector/InspectorDatabaseResource.cpp:
  56666. (WebCore::InspectorDatabaseResource::bind):
  56667. * inspector/InspectorDatabaseResource.h:
  56668. * inspector/InspectorDebuggerAgent.cpp:
  56669. (WebCore::InspectorDebuggerAgent::setFrontend):
  56670. * inspector/InspectorDebuggerAgent.h:
  56671. * inspector/InspectorProfilerAgent.cpp:
  56672. * inspector/InspectorProfilerAgent.h:
  56673. (WebCore::InspectorProfilerAgent::setFrontend):
  56674. (WebCore::InspectorProfilerAgent::clearFrontend):
  56675. * inspector/InspectorResourceAgent.cpp:
  56676. (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  56677. * inspector/InspectorResourceAgent.h:
  56678. * inspector/InspectorTimelineAgent.cpp:
  56679. (WebCore::InspectorTimelineAgent::setFrontend):
  56680. * inspector/InspectorTimelineAgent.h:
  56681. * inspector/front-end/DOMAgent.js:
  56682. (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
  56683. (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
  56684. * inspector/front-end/inspector.js:
  56685. 2011-03-02 Kent Tamura <tkent@chromium.org>
  56686. Unreviewed, a trivial regression fix.
  56687. Fix LocalizedNumberICU regression by r80198 and r80199.
  56688. https://bugs.webkit.org/show_bug.cgi?id=55629
  56689. * platform/text/LocalizedNumberICU.cpp:
  56690. We should use U_SUCCESS().
  56691. (WebCore::createFormatterForCurrentLocale):
  56692. (WebCore::parseLocalizedNumber):
  56693. 2011-03-02 Dan Bernstein <mitz@apple.com>
  56694. Let Xcode know that Localizable.strings is UTF-16-encoded.
  56695. * WebCore.xcodeproj/project.pbxproj:
  56696. 2011-03-02 Andy Estes <aestes@apple.com>
  56697. Reviewed by Eric Seidel.
  56698. HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
  56699. https://bugs.webkit.org/show_bug.cgi?id=48719
  56700. Instead of pushing a fake HTMLHtmlElement onto the open element stack
  56701. during fragment parsing only to later remove it and reparent its
  56702. children to the DocumentFragment, push the DocumentFragment directly
  56703. onto the open element stack as the root node. This requires refactoring
  56704. HTMLElementStack to hold ContainerNode pointers rather than Element
  56705. pointers, which has implications for HTMLConstructionSite and
  56706. HTMLTreeBuilder as well.
  56707. With this patch, the regression in Peacekeeper due to the introduction
  56708. of the HTML5 fragment parsing algorithm is ~14%. The regression from
  56709. Safari 5.0.3 is ~24%.
  56710. No new tests. No change in behavior.
  56711. * dom/Element.h:
  56712. (WebCore::Node::hasLocalName):
  56713. * dom/Node.h:
  56714. * html/parser/HTMLConstructionSite.cpp:
  56715. (WebCore::HTMLNames::hasImpliedEndTag):
  56716. (WebCore::HTMLConstructionSite::HTMLConstructionSite):
  56717. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
  56718. (WebCore::HTMLConstructionSite::insertComment):
  56719. (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
  56720. (WebCore::HTMLConstructionSite::attachToCurrent):
  56721. (WebCore::HTMLConstructionSite::insertScriptElement):
  56722. (WebCore::HTMLConstructionSite::insertTextNode):
  56723. (WebCore::HTMLConstructionSite::createElement):
  56724. (WebCore::HTMLConstructionSite::createHTMLElement):
  56725. (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
  56726. (WebCore::HTMLConstructionSite::generateImpliedEndTags):
  56727. (WebCore::HTMLConstructionSite::findFosterSite):
  56728. (WebCore::HTMLConstructionSite::shouldFosterParent):
  56729. * html/parser/HTMLConstructionSite.h:
  56730. (WebCore::HTMLConstructionSite::currentNode):
  56731. * html/parser/HTMLElementStack.cpp:
  56732. (WebCore::HTMLNames::isNumberedHeaderElement):
  56733. (WebCore::HTMLNames::isScopeMarker):
  56734. (WebCore::HTMLNames::isListItemScopeMarker):
  56735. (WebCore::HTMLNames::isTableScopeMarker):
  56736. (WebCore::HTMLNames::isTableBodyScopeMarker):
  56737. (WebCore::HTMLNames::isTableRowScopeMarker):
  56738. (WebCore::HTMLNames::isButtonScopeMarker):
  56739. (WebCore::HTMLNames::isSelectScopeMarker):
  56740. (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
  56741. (WebCore::HTMLElementStack::ElementRecord::replaceElement):
  56742. (WebCore::HTMLElementStack::HTMLElementStack):
  56743. (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
  56744. (WebCore::HTMLElementStack::popAll):
  56745. (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
  56746. (WebCore::HTMLElementStack::popUntil):
  56747. (WebCore::HTMLElementStack::popUntilPopped):
  56748. (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  56749. (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  56750. (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  56751. (WebCore::HTMLElementStack::pushHTMLHtmlElement):
  56752. (WebCore::HTMLElementStack::push):
  56753. (WebCore::HTMLElementStack::insertAbove):
  56754. (WebCore::HTMLElementStack::find):
  56755. (WebCore::HTMLElementStack::topmost):
  56756. (WebCore::HTMLElementStack::contains):
  56757. (WebCore::inScopeCommon):
  56758. (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
  56759. (WebCore::HTMLElementStack::htmlElement):
  56760. (WebCore::HTMLElementStack::rootNode):
  56761. (WebCore::HTMLElementStack::pushCommon):
  56762. * html/parser/HTMLElementStack.h:
  56763. (WebCore::HTMLElementStack::ElementRecord::element):
  56764. (WebCore::HTMLElementStack::ElementRecord::node):
  56765. (WebCore::HTMLElementStack::topNode):
  56766. * html/parser/HTMLTreeBuilder.cpp:
  56767. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  56768. (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
  56769. (WebCore::HTMLTreeBuilder::processStartTagForInBody):
  56770. (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
  56771. (WebCore::HTMLTreeBuilder::processStartTag):
  56772. (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
  56773. (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
  56774. (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  56775. (WebCore::HTMLTreeBuilder::processEndTagForInCell):
  56776. (WebCore::HTMLTreeBuilder::processEndTagForInBody):
  56777. (WebCore::HTMLTreeBuilder::processEndTag):
  56778. (WebCore::HTMLTreeBuilder::processEndOfFile):
  56779. (WebCore::HTMLTreeBuilder::finished):
  56780. * html/parser/HTMLTreeBuilder.h:
  56781. 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
  56782. Unreviewed, rolling out r80188.
  56783. http://trac.webkit.org/changeset/80188
  56784. https://bugs.webkit.org/show_bug.cgi?id=55647
  56785. Broke the WebKit API tests. (Requested by xenon on #webkit).
  56786. * WebCore.exp.in:
  56787. 2011-03-02 Kent Tamura <tkent@chromium.org>
  56788. Unreviewed, build fix.
  56789. * platform/text/LocalizedNumberICU.cpp:
  56790. (WebCore::createFormatterForCurrentLocale): Fix a typo.
  56791. 2011-03-02 Kent Tamura <tkent@chromium.org>
  56792. Reviewed by Darin Adler.
  56793. Caching number formatter instances in LocalizedNumber* implementations
  56794. https://bugs.webkit.org/show_bug.cgi?id=55629
  56795. No new tests. This change doesn't change existing behavior, and is
  56796. covered by existing tests.
  56797. * platform/text/LocalizedNumberICU.cpp:
  56798. (WebCore::createFormatterForCurrentLocale):
  56799. (WebCore::numberFormatter): Introduce a function to return a static
  56800. instance of NumberFormat.
  56801. (WebCore::parseLocalizedNumber): Use numberFormatter().
  56802. (WebCore::formatLocalizedNumber): Use numberFormatter().
  56803. * platform/text/mac/LocalizedNumberMac.mm:
  56804. (WebCore::createFormatterForCurrentLocale):
  56805. (WebCore::numberFormatter): Introduce a function to return a static
  56806. instance of NSNumberFormatter.
  56807. (WebCore::parseLocalizedNumber): Use numberFormatter().
  56808. (WebCore::formatLocalizedNumber): Use numberFormatter().
  56809. 2011-03-02 Levi Weintraub <leviw@chromium.org>
  56810. Reviewed by Ryosuke Niwa.
  56811. deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
  56812. https://bugs.webkit.org/show_bug.cgi?id=54986
  56813. Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
  56814. until we can update all the call sites to consider the new position types.
  56815. No tests. This is intended to simplify the transition to new Positions, not to change behavior.
  56816. * dom/Position.cpp:
  56817. (WebCore::Position::deprecatedEditingOffset):
  56818. (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
  56819. inline-speed for most calls to deprecatedEditingOffset.
  56820. * dom/Position.h:
  56821. 2011-03-02 Timothy Hatcher <timothy@apple.com>
  56822. Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
  56823. Reviewed by Darin Adler.
  56824. * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
  56825. 2011-03-02 Daniel Cheng <dcheng@chromium.org>
  56826. Reviewed by David Levin.
  56827. Manually revert ChromiumDataObject changes.
  56828. https://bugs.webkit.org/show_bug.cgi?id=55627
  56829. No new tests since no functionality should change.
  56830. * WebCore.gypi:
  56831. * editing/chromium/EditorChromium.cpp:
  56832. (WebCore::Editor::newGeneralClipboard):
  56833. * page/chromium/EventHandlerChromium.cpp:
  56834. (WebCore::EventHandler::createDraggingClipboard):
  56835. * platform/chromium/ChromiumDataObject.cpp:
  56836. (WebCore::ChromiumDataObject::clearData):
  56837. (WebCore::ChromiumDataObject::clearAll):
  56838. (WebCore::ChromiumDataObject::clearAllExceptFiles):
  56839. (WebCore::ChromiumDataObject::hasData):
  56840. (WebCore::ChromiumDataObject::types):
  56841. (WebCore::ChromiumDataObject::getData):
  56842. (WebCore::ChromiumDataObject::setData):
  56843. (WebCore::ChromiumDataObject::ChromiumDataObject):
  56844. * platform/chromium/ChromiumDataObject.h:
  56845. (WebCore::ChromiumDataObject::create):
  56846. (WebCore::ChromiumDataObject::copy):
  56847. (WebCore::ChromiumDataObject::urlTitle):
  56848. (WebCore::ChromiumDataObject::setUrlTitle):
  56849. (WebCore::ChromiumDataObject::htmlBaseUrl):
  56850. (WebCore::ChromiumDataObject::setHtmlBaseUrl):
  56851. (WebCore::ChromiumDataObject::containsFilenames):
  56852. (WebCore::ChromiumDataObject::filenames):
  56853. (WebCore::ChromiumDataObject::setFilenames):
  56854. (WebCore::ChromiumDataObject::fileExtension):
  56855. (WebCore::ChromiumDataObject::setFileExtension):
  56856. (WebCore::ChromiumDataObject::fileContentFilename):
  56857. (WebCore::ChromiumDataObject::setFileContentFilename):
  56858. (WebCore::ChromiumDataObject::fileContent):
  56859. (WebCore::ChromiumDataObject::setFileContent):
  56860. * platform/chromium/ClipboardChromium.cpp:
  56861. * platform/chromium/ClipboardChromium.h:
  56862. 2011-03-02 David Grogan <dgrogan@chromium.org>
  56863. Reviewed by Jeremy Orlow.
  56864. IndexedDB: fire versionchange events when calling setVersion
  56865. https://bugs.webkit.org/show_bug.cgi?id=55095
  56866. * dom/EventNames.h:
  56867. * storage/IDBDatabase.cpp:
  56868. (WebCore::IDBDatabase::setVersion):
  56869. (WebCore::IDBDatabase::close):
  56870. (WebCore::IDBDatabase::onVersionChange):
  56871. (WebCore::IDBDatabase::open):
  56872. (WebCore::IDBDatabase::enqueueEvent):
  56873. (WebCore::IDBDatabase::dispatchEvent):
  56874. * storage/IDBDatabase.h:
  56875. (WebCore::IDBDatabase::dispatchEvent):
  56876. * storage/IDBDatabase.idl:
  56877. * storage/IDBDatabaseBackendImpl.cpp:
  56878. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
  56879. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks):
  56880. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
  56881. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  56882. (WebCore::IDBDatabaseBackendImpl::setVersion):
  56883. (WebCore::IDBDatabaseBackendImpl::open):
  56884. (WebCore::IDBDatabaseBackendImpl::close):
  56885. * storage/IDBDatabaseBackendImpl.h:
  56886. * storage/IDBDatabaseBackendInterface.h:
  56887. * storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
  56888. (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
  56889. * storage/IDBFactoryBackendImpl.cpp:
  56890. (WebCore::IDBFactoryBackendImpl::open):
  56891. * storage/IDBRequest.cpp:
  56892. (WebCore::IDBRequest::onSuccess):
  56893. * storage/IDBVersionChangeEvent.cpp:
  56894. (WebCore::IDBVersionChangeEvent::create):
  56895. (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
  56896. * storage/IDBVersionChangeEvent.h:
  56897. * storage/IDBVersionChangeRequest.cpp:
  56898. (WebCore::IDBVersionChangeRequest::onBlocked):
  56899. 2011-03-02 Alexey Proskuryakov <ap@apple.com>
  56900. Fix assertion failures on Gtk bot.
  56901. * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous
  56902. assertion. We can get here with non-Tab key events when spatial navigation is enabled.
  56903. 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
  56904. Unreviewed, rolling out r80139.
  56905. http://trac.webkit.org/changeset/80139
  56906. https://bugs.webkit.org/show_bug.cgi?id=55620
  56907. failing and crashing tests on Snow Leopard bot (Requested by
  56908. mihaip1 on #webkit).
  56909. * page/DOMWindow.cpp:
  56910. * page/DOMWindow.h:
  56911. * page/Frame.cpp:
  56912. (WebCore::Frame::pageDestroyed):
  56913. (WebCore::Frame::transferChildFrameToNewDocument):
  56914. * page/Frame.h:
  56915. (WebCore::Frame::detachFromPage):
  56916. * page/Geolocation.cpp:
  56917. (WebCore::Geolocation::~Geolocation):
  56918. (WebCore::Geolocation::disconnectFrame):
  56919. (WebCore::Geolocation::lastPosition):
  56920. (WebCore::Geolocation::requestPermission):
  56921. (WebCore::Geolocation::startUpdating):
  56922. (WebCore::Geolocation::stopUpdating):
  56923. * page/Geolocation.h:
  56924. * page/GeolocationController.cpp:
  56925. (WebCore::GeolocationController::~GeolocationController):
  56926. * page/Navigator.cpp:
  56927. * page/Navigator.h:
  56928. * platform/mock/GeolocationClientMock.cpp:
  56929. * platform/mock/GeolocationClientMock.h:
  56930. 2011-03-02 Jessie Berlin <jberlin@apple.com>
  56931. Reviewed by Adam Roben.
  56932. WebKit2: Use CFNetwork Sessions API.
  56933. https://bugs.webkit.org/show_bug.cgi?id=55435
  56934. Add the ability to create a Private Browsing Storage Session.
  56935. * WebCore.exp.in:
  56936. Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.
  56937. * page/Settings.cpp:
  56938. (WebCore::Settings::setPrivateBrowsingEnabled):
  56939. Propagate the private browsing state to the ResourceHandle.
  56940. * platform/mac/WebCoreSystemInterface.h:
  56941. Add the function declaration for wkCreatePrivateStorageSession.
  56942. * platform/mac/WebCoreSystemInterface.mm:
  56943. * platform/network/ResourceHandle.cpp:
  56944. (WebCore::privateStorageSession):
  56945. Since the same Private Browsing Storage Session will need to be accessed throughout the loading
  56946. code and will need to be used by all web pages and page groups, make it a global static.
  56947. (WebCore::privateBrowsingStorageSessionIdentifierBase):
  56948. Ditto, since the identifier is needed to create the Private Browsing Storage Session.
  56949. (WebCore::ResourceHandle::setPrivateBrowsingEnabled):
  56950. If enabled, create and store the Private Browsing Storage Session.
  56951. (WebCore::ResourceHandle::privateBrowsingStorageSession):
  56952. (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):
  56953. * platform/network/ResourceHandle.h:
  56954. * platform/network/cf/ResourceHandleCFNet.cpp:
  56955. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
  56956. The call to wkCreatePrivateStorageSession needs to be in a file including the correct
  56957. version of WKSI.
  56958. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
  56959. Return the bundle identifier.
  56960. * platform/network/mac/ResourceHandleMac.mm:
  56961. (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
  56962. The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
  56963. version of WKSI.
  56964. (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
  56965. Return the bundle identifier.
  56966. 2011-03-02 Daniel Cheng <dcheng@chromium.org>
  56967. Revert frame-specific WebClipboard changes
  56968. https://bugs.webkit.org/show_bug.cgi?id=55617
  56969. This code is no longer needed since we've decided to use the original
  56970. approach to copy/paste drag/drop handling in ClipboardChromium.
  56971. No new tests because no functionality changes.
  56972. * platform/chromium/ChromiumDataObject.cpp:
  56973. (WebCore::ChromiumDataObject::createReadable):
  56974. * platform/chromium/ChromiumDataObject.h:
  56975. * platform/chromium/ClipboardChromium.cpp:
  56976. (WebCore::ClipboardChromium::create):
  56977. * platform/chromium/PlatformBridge.h:
  56978. * platform/chromium/ReadableDataObject.cpp:
  56979. (WebCore::ReadableDataObject::create):
  56980. (WebCore::ReadableDataObject::ReadableDataObject):
  56981. (WebCore::ReadableDataObject::getData):
  56982. (WebCore::ReadableDataObject::urlTitle):
  56983. (WebCore::ReadableDataObject::htmlBaseUrl):
  56984. (WebCore::ReadableDataObject::filenames):
  56985. (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  56986. * platform/chromium/ReadableDataObject.h:
  56987. 2011-03-02 Tony Chang <tony@chromium.org>
  56988. Unreviewed, rolling chromium DEPS to r76362.
  56989. https://bugs.webkit.org/show_bug.cgi?id=55564
  56990. * WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium
  56991. 2011-03-02 Alexey Proskuryakov <ap@apple.com>
  56992. Build fix.
  56993. * page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these
  56994. changes yet.
  56995. 2011-03-02 Alexey Proskuryakov <ap@apple.com>
  56996. Reviewed by John Sullivan.
  56997. Clean up WebCore tabsToLinks code a little
  56998. https://bugs.webkit.org/show_bug.cgi?id=55606
  56999. No change in behavior, so no tests.
  57000. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable):
  57001. This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
  57002. * page/EventHandler.cpp:
  57003. (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This
  57004. function cannot be file static, because EventHandlerMac.mm uses it.
  57005. (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform
  57006. specific files. We can just as well have #if here. Renamed for clarity.
  57007. (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert"
  57008. works.
  57009. * page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used
  57010. in EventHandler.cpp.
  57011. * page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57012. * page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57013. * page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57014. * page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57015. * page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57016. * page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57017. * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
  57018. * page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57019. * page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57020. * page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  57021. Updating all port files.
  57022. 2011-02-28 Jeremy Orlow <jorlow@chromium.org>
  57023. Reviewed by James Robinson.
  57024. Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
  57025. https://bugs.webkit.org/show_bug.cgi?id=55443
  57026. Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948
  57027. The idea is to have an IDBCursor and an IDBCursorWithValue interface which
  57028. inherits from the former. index.openKeyCursor will return the former and
  57029. index/objectStore.openCursor will return the latter. We'll add a primaryKey
  57030. attribute to IDBCursor. It will always be the key of the associated object
  57031. store entry. For index.openCursor cursors, the key attribute will be the key
  57032. of the index. For objectStore.openCursors, it'll be the same as the
  57033. primaryKey. The value will be the value of the objectStore entry.
  57034. * WebCore.gypi:
  57035. * bindings/scripts/CodeGeneratorV8.pm:
  57036. * bindings/v8/SerializedScriptValue.cpp:
  57037. (WebCore::SerializedScriptValue::deserializeAndSetProperty):
  57038. * bindings/v8/SerializedScriptValue.h:
  57039. * bindings/v8/custom/V8IDBAnyCustom.cpp:
  57040. (WebCore::toV8):
  57041. * storage/IDBAny.cpp:
  57042. (WebCore::IDBAny::idbCursorWithValue):
  57043. (WebCore::IDBAny::set):
  57044. * storage/IDBAny.h:
  57045. * storage/IDBCursor.cpp:
  57046. (WebCore::IDBCursor::create):
  57047. (WebCore::IDBCursor::primaryKey):
  57048. (WebCore::IDBCursor::value):
  57049. * storage/IDBCursor.h:
  57050. * storage/IDBCursor.idl:
  57051. * storage/IDBCursorBackendImpl.cpp:
  57052. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
  57053. (WebCore::IDBCursorBackendImpl::primaryKey):
  57054. (WebCore::IDBCursorBackendImpl::value):
  57055. (WebCore::IDBCursorBackendImpl::update):
  57056. (WebCore::IDBCursorBackendImpl::currentRowExists):
  57057. (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  57058. (WebCore::IDBCursorBackendImpl::deleteFunction):
  57059. (WebCore::IDBCursorBackendImpl::loadCurrentRow):
  57060. * storage/IDBCursorBackendImpl.h:
  57061. (WebCore::IDBCursorBackendImpl::create):
  57062. * storage/IDBCursorBackendInterface.h:
  57063. * storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl.
  57064. (WebCore::IDBCursorWithValue::create):
  57065. (WebCore::IDBCursorWithValue::IDBCursorWithValue):
  57066. (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
  57067. * storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
  57068. * storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
  57069. * storage/IDBIndex.cpp:
  57070. (WebCore::IDBIndex::openCursor):
  57071. (WebCore::IDBIndex::openKeyCursor):
  57072. * storage/IDBIndexBackendImpl.cpp:
  57073. (WebCore::IDBIndexBackendImpl::openCursorInternal):
  57074. (WebCore::IDBIndexBackendImpl::openCursor):
  57075. (WebCore::IDBIndexBackendImpl::openKeyCursor):
  57076. * storage/IDBIndexBackendImpl.h:
  57077. * storage/IDBObjectStore.cpp:
  57078. (WebCore::IDBObjectStore::openCursor):
  57079. * storage/IDBObjectStoreBackendImpl.cpp:
  57080. (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  57081. * storage/IDBRequest.cpp:
  57082. (WebCore::IDBRequest::IDBRequest):
  57083. (WebCore::IDBRequest::setCursorType):
  57084. (WebCore::IDBRequest::onSuccess):
  57085. (WebCore::IDBRequest::dispatchEvent):
  57086. * storage/IDBRequest.h:
  57087. 2011-03-02 Aravind Akella <aravind.akella@nokia.com>
  57088. Reviewed by Csaba Osztrogonác.
  57089. [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
  57090. https://bugs.webkit.org/show_bug.cgi?id=55484
  57091. Using AllInOne files to avoid memory exhaustion for debug
  57092. builds on 32 bit linux machines.
  57093. No new tests. Fixing a build issue.
  57094. * WebCore.pro:
  57095. 2011-03-02 Daniel Cheng <dcheng@chromium.org>
  57096. Reviewed by David Levin.
  57097. Add feature define for data transfer items
  57098. https://bugs.webkit.org/show_bug.cgi?id=55510
  57099. * Configurations/FeatureDefines.xcconfig:
  57100. * GNUmakefile.am:
  57101. * features.pri:
  57102. 2011-03-02 Dimitri Glazkov <dglazkov@chromium.org>
  57103. Update location of media-file.js, which was moved in r79630.
  57104. * manual-tests/media-controls.html: Updated location.
  57105. 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
  57106. Unreviewed, rolling out r80156.
  57107. http://trac.webkit.org/changeset/80156
  57108. https://bugs.webkit.org/show_bug.cgi?id=55604
  57109. "Broke SL compile" (Requested by tonyg-cr on #webkit).
  57110. * bridge/jni/JNIBridge.h:
  57111. (JSC::Bindings::JavaString::operator UString):
  57112. * bridge/jni/jni_jsobject.mm:
  57113. (JavaJSObject::call):
  57114. (JavaJSObject::eval):
  57115. (JavaJSObject::getMember):
  57116. (JavaJSObject::setMember):
  57117. (JavaJSObject::removeMember):
  57118. * bridge/jni/jsc/JavaClassJSC.cpp:
  57119. (JavaClass::JavaClass):
  57120. * bridge/jni/jsc/JavaStringJSC.h:
  57121. (JSC::Bindings::JavaStringImpl::uString):
  57122. * bridge/jni/v8/JavaStringV8.h:
  57123. 2011-03-02 Steve Block <steveblock@google.com>
  57124. Reviewed by Jeremy Orlow.
  57125. JavaString API should be implementable by both JSC and V8
  57126. https://bugs.webkit.org/show_bug.cgi?id=55567
  57127. Remove JavaString's UString operator and replace it with a
  57128. script-engine-independent impl() method, which returns a
  57129. StringImpl and can be implemented with both JSC and V8.
  57130. No new tests, refactoring only.
  57131. * bridge/jni/JNIBridge.h:
  57132. (JSC::Bindings::JavaString::impl):
  57133. * bridge/jni/jni_jsobject.mm:
  57134. (JavaJSObject::call):
  57135. (JavaJSObject::eval):
  57136. (JavaJSObject::getMember):
  57137. (JavaJSObject::setMember):
  57138. (JavaJSObject::removeMember):
  57139. * bridge/jni/jsc/JavaClassJSC.cpp:
  57140. (JavaClass::JavaClass):
  57141. * bridge/jni/jsc/JavaStringJSC.h:
  57142. (JSC::Bindings::JavaStringImpl::impl):
  57143. * bridge/jni/v8/JavaStringV8.h:
  57144. (JSC::Bindings::JavaStringImpl::impl):
  57145. 2011-03-02 Mihai Parparita <mihaip@chromium.org>
  57146. Reviewed by Dimitri Glazkov.
  57147. Add CRASH() for CSSSelector double frees
  57148. https://bugs.webkit.org/show_bug.cgi?id=55596
  57149. To help track down bug 53045, add a CRASH call when the CSSSelector
  57150. destructor is invoked more than once.
  57151. Just a check, no new tests necessary.
  57152. * css/CSSSelector.h:
  57153. (WebCore::CSSSelector::CSSSelector):
  57154. (WebCore::CSSSelector::~CSSSelector):
  57155. 2011-03-02 Carol Szabo <carol.szabo@nokia.com>
  57156. Reviewed by David Hyatt <hyatt@apple.com>
  57157. content property doesn't support quotes
  57158. https://bugs.webkit.org/show_bug.cgi?id=6503
  57159. Added full support for quotes as defined by CSS 2.1.
  57160. Tests: fast/css/content/content-quotes-01.html
  57161. fast/css/content/content-quotes-02.html
  57162. fast/css/content/content-quotes-03.html
  57163. fast/css/content/content-quotes-04.html
  57164. fast/css/content/content-quotes-05.html
  57165. fast/css/content/content-quotes-06.html
  57166. * Android.mk:
  57167. * CMakeLists.txt:
  57168. * GNUmakefile.am:
  57169. * WebCore.gypi:
  57170. * WebCore.pro:
  57171. * WebCore.vcproj/WebCore.vcproj:
  57172. * WebCore.xcodeproj/project.pbxproj:
  57173. Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
  57174. * css/CSSParser.cpp:
  57175. (WebCore::CSSParser::parseValue):
  57176. (WebCore::CSSParser::parseQuotes):
  57177. * css/CSSParser.h:
  57178. Added needed stylesheet parsing support for quotes,
  57179. (no-)open-quote and (no-)close-quote
  57180. * css/CSSStyleSelector.cpp:
  57181. (WebCore::CSSStyleSelector::applyProperty):
  57182. Handled setting of the new quotes RenderStyle property and added
  57183. handling of quotes for the content property.
  57184. * css/html.css:
  57185. (q:before):
  57186. (q:after):
  57187. replaced the '"' workaround with open/close-quote
  57188. * rendering/RenderBlockLineLayout.cpp:
  57189. (WebCore::dirtyLineBoxesForRenderer):
  57190. Made RenderQuote behave like RenderCounter.
  57191. Needed to ensure that the Quote text is calculated before layout,
  57192. just as it is for RenderCounter.
  57193. * rendering/RenderObject.h:
  57194. (WebCore::RenderObject::isQuote):
  57195. * rendering/RenderObjectChildList.cpp:
  57196. (WebCore::RenderObjectChildList::removeChildNode):
  57197. (WebCore::RenderObjectChildList::appendChildNode):
  57198. (WebCore::RenderObjectChildList::insertChildNode):
  57199. Handled updating of quote depth when renderers are added and removed
  57200. from the tree.
  57201. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  57202. Added support for Quote content.
  57203. * rendering/RenderQuote.cpp: Added.
  57204. (WebCore::adjustDepth):
  57205. (WebCore::RenderQuote::RenderQuote):
  57206. (WebCore::RenderQuote::~RenderQuote):
  57207. (WebCore::RenderQuote::renderName):
  57208. (WebCore::RenderQuote::placeQuote):
  57209. (WebCore::LanguageData::operator<):
  57210. (WebCore::defaultLanguageQuotes):
  57211. (WebCore::quotesMap):
  57212. (WebCore::quotesForLanguage):
  57213. (WebCore::defaultQuotes):
  57214. (WebCore::RenderQuote::originalText):
  57215. (WebCore::RenderQuote::computePreferredLogicalWidths):
  57216. (WebCore::RenderQuote::rendererSubtreeAttached):
  57217. (WebCore::RenderQuote::rendererRemovedFromTree):
  57218. (WebCore::RenderQuote::styleDidChange):
  57219. * rendering/RenderQuote.h: Added.
  57220. (WebCore::RenderQuote::isQuote):
  57221. (WebCore::toRenderQuote):
  57222. * rendering/RenderingAllInOne.cpp:
  57223. Included RenderQuote.cpp
  57224. * rendering/style/StyleAllInOne.cpp:
  57225. Included QuotesData.cpp
  57226. * rendering/style/ContentData.cpp:
  57227. (WebCore::ContentData::dataEquivalent):
  57228. Checked for quotetype identity.
  57229. (WebCore::ContentData::deleteContent):
  57230. Accounted for the new QUOTE_TYPE.
  57231. * rendering/style/ContentData.h:
  57232. (WebCore::ContentData::isQuote):
  57233. (WebCore::ContentData::quote):
  57234. (WebCore::ContentData::setQuote):
  57235. * rendering/style/QuotesData.cpp: Added.
  57236. (WebCore::QuotesData::create):
  57237. (WebCore::QuotesData::operator==):
  57238. (WebCore::QuotesData::~QuotesData):
  57239. * rendering/style/QuotesData.h: Added.
  57240. (WebCore::QuotesData::data):
  57241. (WebCore::QuotesData::operator delete):
  57242. (WebCore::QuotesData::QuotesData):
  57243. * rendering/style/RenderStyle.cpp:
  57244. (WebCore::RenderStyle::setContent):
  57245. (WebCore::RenderStyle::setQuotes):
  57246. * rendering/style/RenderStyle.h:
  57247. (WebCore::InheritedFlags::quotes):
  57248. (WebCore::InheritedFlags::setQuotes):
  57249. * rendering/style/RenderStyleConstants.h:
  57250. * rendering/style/StyleAllInOne.cpp:
  57251. Added QuotesData.cpp to the included files list.
  57252. * rendering/style/StyleRareInheritedData.cpp:
  57253. (WebCore::StyleRareInheritedData::operator==):
  57254. Included quotes in equality check.
  57255. * rendering/style/StyleRareInheritedData.h:
  57256. Added quotes
  57257. 2011-03-02 Antti Koivisto <antti@apple.com>
  57258. Reviewed by Dave Hyatt.
  57259. Selector usage flags should not be set by the CSS parser
  57260. https://bugs.webkit.org/show_bug.cgi?id=55573
  57261. Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
  57262. we may parse stylesheets that are not actually used for document rendering. This is especially bad when
  57263. the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
  57264. triggered by complex selectors for no good reason.
  57265. - Use the selector traversal in style selector constructor to figure out which flags
  57266. are actually needed for the currently active style sheets.
  57267. - Remove the selector flag related code from the CSS parser/grammar.
  57268. - Remove the usesDescendantRules flag completely. We have descendant rules in the default
  57269. style sheet, every document uses them.
  57270. * css/CSSGrammar.y:
  57271. * css/CSSParser.cpp:
  57272. (WebCore::CSSParser::updateSpecifiersWithElementName):
  57273. * css/CSSStyleSelector.cpp:
  57274. (WebCore::collectSiblingRulesInDefaultStyle):
  57275. (WebCore::CSSStyleSelector::CSSStyleSelector):
  57276. (WebCore::CSSStyleSelector::Features::Features):
  57277. (WebCore::CSSStyleSelector::Features::~Features):
  57278. (WebCore::CSSStyleSelector::locateCousinList):
  57279. (WebCore::CSSStyleSelector::matchesSiblingRules):
  57280. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  57281. (WebCore::CSSStyleSelector::locateSharedStyle):
  57282. (WebCore::collectFeaturesFromSelector):
  57283. (WebCore::collectFeaturesFromList):
  57284. (WebCore::RuleSet::collectFeatures):
  57285. * css/CSSStyleSelector.h:
  57286. (WebCore::CSSStyleSelector::usesSiblingRules):
  57287. (WebCore::CSSStyleSelector::usesFirstLineRules):
  57288. (WebCore::CSSStyleSelector::usesBeforeAfterRules):
  57289. (WebCore::CSSStyleSelector::usesLinkRules):
  57290. * dom/Document.cpp:
  57291. (WebCore::Document::Document):
  57292. (WebCore::Document::recalcStyle):
  57293. (WebCore::Document::createStyleSelector):
  57294. * dom/Document.h:
  57295. (WebCore::Document::usesSiblingRules):
  57296. (WebCore::Document::setUsesSiblingRules):
  57297. (WebCore::Document::usesFirstLineRules):
  57298. (WebCore::Document::usesBeforeAfterRules):
  57299. (WebCore::Document::setUsesBeforeAfterRules):
  57300. * dom/Element.cpp:
  57301. (WebCore::Element::recalcStyle):
  57302. 2011-03-02 Brian Weinstein <bweinstein@apple.com>
  57303. Fix fallout from a last minute renaming.
  57304. * platform/network/cf/CookieStorageCFNet.cpp:
  57305. (WebCore::startObservingCookieChanges):
  57306. (WebCore::stopObservingCookieChanges):
  57307. 2011-03-01 Brian Weinstein <bweinstein@apple.com>
  57308. Reviewed by Adam Roben.
  57309. Part of WebKit2: Need a way to send notifications to client when cookies change
  57310. https://bugs.webkit.org/show_bug.cgi?id=55427
  57311. <rdar://problem/9056027>
  57312. Add functions on CookieStorage that allow listening for changes in cookies. When
  57313. the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.
  57314. No change in behavior requiring tests.
  57315. * platform/CookiesStrategy.h: Added.
  57316. (WebCore::CookiesStrategy::~CookiesStrategy):
  57317. * platform/PlatformStrategies.h:
  57318. (WebCore::PlatformStrategies::cookiesStrategy):
  57319. (WebCore::PlatformStrategies::PlatformStrategies):
  57320. * platform/network/CookieStorage.h: Add new function declarations.
  57321. * platform/network/cf/CookieStorageCFNet.cpp:
  57322. (WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
  57323. (WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
  57324. (WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
  57325. (WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.
  57326. * platform/network/mac/CookieStorageMac.mm:
  57327. (-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
  57328. (-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on
  57329. the main thread.
  57330. (-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
  57331. (-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
  57332. (WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
  57333. (WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.
  57334. Add new file.
  57335. * WebCore.vcproj/WebCore.vcproj:
  57336. * WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.
  57337. 2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>
  57338. Reviewed by Dimitri Glazkov.
  57339. A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
  57340. https://bugs.webkit.org/show_bug.cgi?id=55488
  57341. Test: fast/css/css-keyframe-parent.html
  57342. * css/WebKitCSSKeyframesRule.cpp:
  57343. (WebCore::WebKitCSSKeyframesRule::append):
  57344. 2011-03-02 Sergio Villar Senin <svillar@igalia.com>
  57345. Reviewed by Martin Robinson.
  57346. [GTK] Add support for external protocol handlers
  57347. https://bugs.webkit.org/show_bug.cgi?id=55473
  57348. Do not unconditionally create and replace the SoupRequester of the
  57349. SoupSession if there is already one. No new tests needed as we
  57350. just allow clients to create their our SoupRequesters.
  57351. * platform/network/soup/ResourceHandleSoup.cpp:
  57352. (WebCore::ensureSessionIsInitialized):
  57353. 2011-03-02 John Knottenbelt <jknotten@chromium.org>
  57354. Reviewed by jknotten@chromium.org.
  57355. Fix build-breakage when GEOLOCATION not enabled.
  57356. https://bugs.webkit.org/show_bug.cgi?id=55586
  57357. Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
  57358. is not true.
  57359. * page/Geolocation.cpp:
  57360. (WebCore::Geolocation::reset):
  57361. 2011-03-02 Pavel Feldman <pfeldman@chromium.org>
  57362. Reviewed by Yury Semikhatsky.
  57363. Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
  57364. https://bugs.webkit.org/show_bug.cgi?id=55575
  57365. * bindings/js/JSInjectedScriptHostCustom.cpp:
  57366. (WebCore::JSInjectedScriptHost::inspectedNode):
  57367. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  57368. (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  57369. * inspector/ConsoleMessage.cpp:
  57370. (WebCore::ConsoleMessage::addToFrontend):
  57371. * inspector/InjectedScript.cpp:
  57372. (WebCore::InjectedScript::evaluateOn):
  57373. (WebCore::InjectedScript::wrapObject):
  57374. (WebCore::InjectedScript::wrapNode):
  57375. (WebCore::InjectedScript::inspectNode):
  57376. (WebCore::InjectedScript::nodeAsScriptValue):
  57377. * inspector/InjectedScript.h:
  57378. * inspector/InjectedScriptHost.cpp:
  57379. (WebCore::InjectedScriptHost::addInspectedNode):
  57380. (WebCore::InjectedScriptHost::clearInspectedNodes):
  57381. (WebCore::InjectedScriptHost::copyText):
  57382. (WebCore::InjectedScriptHost::inspectedNode):
  57383. * inspector/InjectedScriptHost.h:
  57384. * inspector/InjectedScriptHost.idl:
  57385. * inspector/InjectedScriptSource.js:
  57386. * inspector/Inspector.idl:
  57387. * inspector/InspectorDOMAgent.cpp:
  57388. (WebCore::InspectorDOMAgent::discardBindings):
  57389. (WebCore::InspectorDOMAgent::addInspectedNode):
  57390. (WebCore::InspectorDOMAgent::resolveNode):
  57391. (WebCore::InspectorDOMAgent::injectedScriptForNode):
  57392. * inspector/InspectorDOMAgent.h:
  57393. * inspector/InspectorRuntimeAgent.cpp:
  57394. (WebCore::InspectorRuntimeAgent::evaluateOn):
  57395. * inspector/InspectorRuntimeAgent.h:
  57396. * inspector/front-end/ElementsTreeOutline.js:
  57397. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  57398. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
  57399. (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  57400. * inspector/front-end/PropertiesSidebarPane.js:
  57401. (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  57402. (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  57403. (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
  57404. (WebInspector.PropertiesSidebarPane.prototype.update):
  57405. * inspector/front-end/RemoteObject.js:
  57406. (WebInspector.RemoteObject.resolveNode):
  57407. (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  57408. (WebInspector.RemoteObject.prototype.evaluate):
  57409. 2011-01-21 John Knottenbelt <jknotten@chromium.org>
  57410. Reviewed by Dmitry Titov.
  57411. Detach Geolocation from Frame when Page destroyed.
  57412. https://bugs.webkit.org/show_bug.cgi?id=52877
  57413. On Page destruction, any outstanding Geolocation permission
  57414. requests should be cancelled, because the Geolocation can only
  57415. access the client indirectly via m_frame->page().
  57416. Additionally, if the Frame is reparented to another page, the
  57417. Geolocation should cancel watches, single-shots and requests on
  57418. the old page.
  57419. Page destruction is signalled by a call to the
  57420. Frame::pageDestroyed() method. This calls Frame::detachFromPage,
  57421. where we extend the call chain to Geolocation::detachFromPage()
  57422. where we call Geolocation::reset() which detaches from the
  57423. GeolocationController, cancels requests, watches and single shots,
  57424. and sets the permission state back to Unknown.
  57425. We also now call detachFromPage when the frame reparented in
  57426. Frame::transferChildFrameToNewDocument.
  57427. Frame::pageDestroyed() is also called by FrameLoader even though
  57428. the page is not destroyed. We should still cancel permission
  57429. requests, because the GeolocationClient will become inaccessible
  57430. to the Geolocation object after this call.
  57431. Since GeolocationController is owned by Page, and all Geolocation
  57432. objects will now unsubscribe from the GeolocationController on
  57433. pageDetached(), we no longer need to call stopUpdating() from the
  57434. GeolocationController's destructor. Instead we can simply assert
  57435. that there should be no no observers. See related bug
  57436. https://bugs.webkit.org/show_bug.cgi?id=52216 .
  57437. Introduced new method 'numberOfPendingPermissionRequests' on
  57438. GeolocationClientMock to count the number of outstanding pending
  57439. permission requests. This provides a reusable implementation for
  57440. client-based implementations of the LayoutTestController's
  57441. numberOfPendingGeolocationPermissionRequests method.
  57442. Tests: fast/dom/Geolocation/iframe-reparent.html
  57443. fast/dom/Geolocation/page-reload-cancel-permission-requests.html
  57444. * page/DOMWindow.cpp:
  57445. (WebCore::DOMWindow::resetGeolocationPermissions):
  57446. * page/DOMWindow.h:
  57447. * page/Frame.cpp:
  57448. (WebCore::Frame::detachFromPage):
  57449. (WebCore::Frame::pageDestroyed):
  57450. (WebCore::Frame::transferChildFrameToNewDocument):
  57451. * page/Frame.h:
  57452. * page/Geolocation.cpp:
  57453. (WebCore::Geolocation::~Geolocation):
  57454. (WebCore::Geolocation::page):
  57455. (WebCore::Geolocation::reset):
  57456. (WebCore::Geolocation::disconnectFrame):
  57457. (WebCore::Geolocation::lastPosition):
  57458. (WebCore::Geolocation::requestPermission):
  57459. (WebCore::Geolocation::startUpdating):
  57460. (WebCore::Geolocation::stopUpdating):
  57461. * page/Geolocation.h:
  57462. * page/GeolocationController.cpp:
  57463. (WebCore::GeolocationController::~GeolocationController):
  57464. * page/Navigator.cpp:
  57465. (WebCore::Navigator::resetGeolocationPermissions):
  57466. * page/Navigator.h:
  57467. * platform/mock/GeolocationClientMock.cpp:
  57468. (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  57469. * platform/mock/GeolocationClientMock.h:
  57470. 2011-03-02 Mikhail Naganov <mnaganov@chromium.org>
  57471. Reviewed by Pavel Feldman.
  57472. Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
  57473. https://bugs.webkit.org/show_bug.cgi?id=55563
  57474. This part adds implementations for data grids used to display
  57475. different heap snapshots projections. We are almost done.
  57476. * English.lproj/localizedStrings.js:
  57477. * WebCore.gypi:
  57478. * bindings/v8/ScriptHeapSnapshot.cpp:
  57479. (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
  57480. * bindings/v8/ScriptHeapSnapshot.h:
  57481. * inspector/Inspector.idl:
  57482. * inspector/InspectorProfilerAgent.cpp:
  57483. (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  57484. * inspector/InspectorProfilerAgent.h:
  57485. * inspector/front-end/DetailedHeapshotGridNodes.js:
  57486. (WebInspector.HeapSnapshotObjectNode):
  57487. (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
  57488. (WebInspector.HeapSnapshotInstanceNode):
  57489. (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
  57490. (WebInspector.HeapSnapshotDominatorObjectNode):
  57491. (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  57492. (MixInSnapshotNodeFunctions):
  57493. * inspector/front-end/DetailedHeapshotView.js:
  57494. (WebInspector.HeapSnapshotContainmentDataGrid):
  57495. (WebInspector.HeapSnapshotSortableDataGrid):
  57496. (WebInspector.HeapSnapshotConstructorsDataGrid):
  57497. (WebInspector.HeapSnapshotDiffDataGrid):
  57498. (WebInspector.HeapSnapshotDominatorsDataGrid):
  57499. (WebInspector.HeapSnapshotRetainingPathsList):
  57500. (WebInspector.DetailedHeapshotView.profileCallback):
  57501. (WebInspector.DetailedHeapshotView):
  57502. * inspector/front-end/HeapSnapshot.js:
  57503. (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
  57504. (WebInspector.HeapSnapshotEdge.prototype.toString):
  57505. (WebInspector.HeapSnapshot.prototype._init):
  57506. (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
  57507. (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
  57508. (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
  57509. * inspector/front-end/Images/helpButtonGlyph.png: Added.
  57510. * inspector/front-end/Panel.js:
  57511. (WebInspector.Panel.prototype.reset):
  57512. * inspector/front-end/Popover.js:
  57513. (WebInspector.Popover):
  57514. (WebInspector.Popover.prototype.show):
  57515. (WebInspector.Popover.prototype.hide):
  57516. (WebInspector.Popover.prototype.get visible):
  57517. * inspector/front-end/ProfilesPanel.js:
  57518. (WebInspector.ProfilesPanel.prototype._reset):
  57519. (WebInspector.ProfilesPanel.prototype.getProfile):
  57520. * inspector/front-end/heapProfiler.css:
  57521. * inspector/front-end/inspector.js:
  57522. (WebInspector.resetFocusElement):
  57523. 2011-03-02 David Kilzer <ddkilzer@apple.com>
  57524. <http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp
  57525. Reviewed by Darin Adler.
  57526. Change "#if GL_APPLE_vertex_array_object" macros to check that
  57527. GL_APPLE_vertex_array_object is both defined and non-zero.
  57528. * platform/graphics/opengl/Extensions3DOpenGL.cpp:
  57529. (WebCore::Extensions3DOpenGL::createVertexArrayOES):
  57530. (WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
  57531. empty #else clause.
  57532. (WebCore::Extensions3DOpenGL::isVertexArrayOES):
  57533. (WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
  57534. return check. Remove #else clause that would never have
  57535. compiled (since array is not a WTF::String).
  57536. 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
  57537. Reviewed by Darin Adler.
  57538. Assertion failure after removing a selection in keydown handler
  57539. https://bugs.webkit.org/show_bug.cgi?id=51389
  57540. The bug was caused by textWillBeReplaced's not always updating selection, and
  57541. shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
  57542. at the end of replaced data.
  57543. Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
  57544. to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
  57545. to setSelection instead of directly modifying m_selection to notify all the clients.
  57546. Namely, the call to EditorClient::respondToChangedSelection is required for
  57547. setting-input-value-cancel-ime-composition.html.
  57548. Note that we must update layout before calling setSelection because setSelection calls
  57549. setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
  57550. such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.
  57551. Test: editing/input/setting-input-value-cancel-ime-composition.html
  57552. * editing/SelectionController.cpp:
  57553. (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset
  57554. of the selection end must be updated even if it was at the end of the replaced text.
  57555. e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
  57556. "hello WebK[it". Note we don't move the offset if no text is removed because appending
  57557. "world" to "hello ]" should result in "hello ]world" not "hello world]".
  57558. (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update
  57559. the selection instead of modifying m_selection directly.
  57560. 2011-03-02 Andrey Adaikin <aandrey@google.com>
  57561. Reviewed by Pavel Feldman.
  57562. Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
  57563. https://bugs.webkit.org/show_bug.cgi?id=54675
  57564. * inspector/front-end/TextViewer.js:
  57565. (WebInspector.TextViewer.prototype._syncScroll):
  57566. (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
  57567. (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
  57568. (WebInspector.TextEditorGutterPanel):
  57569. (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
  57570. (WebInspector.TextEditorGutterPanel.prototype.textChanged):
  57571. (WebInspector.TextEditorMainPanel):
  57572. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  57573. (WebInspector.TextEditorMainPanel.prototype._getSelection):
  57574. (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
  57575. (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
  57576. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  57577. (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  57578. * inspector/front-end/textViewer.css:
  57579. (.inner-container):
  57580. 2011-03-02 Oleg Romashin <romaxa@gmail.com>
  57581. Reviewed by Andreas Kling.
  57582. Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
  57583. https://bugs.webkit.org/show_bug.cgi?id=55477
  57584. * inspector/InspectorAgent.cpp:
  57585. (WebCore::InspectorAgent::populateScriptObjects):
  57586. 2011-03-02 Kent Tamura <tkent@chromium.org>
  57587. Unreviewed, a trivial fix for r80096.
  57588. REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
  57589. https://bugs.webkit.org/show_bug.cgi?id=55562
  57590. * platform/text/LocalizedNumberICU.cpp:
  57591. (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse()
  57592. to reject strings with a valid number + extra letters.
  57593. 2011-03-02 Steve Block <steveblock@google.com>
  57594. Reviewed by Jeremy Orlow.
  57595. JObjectWrapper should be moved to its own file
  57596. https://bugs.webkit.org/show_bug.cgi?id=55384
  57597. No new tests, refactoring only.
  57598. * Android.v8bindings.mk:
  57599. * WebCore.gypi:
  57600. * bridge/jni/v8/JNIBridgeV8.cpp:
  57601. (JavaField::JavaField):
  57602. * bridge/jni/v8/JNIBridgeV8.h:
  57603. * bridge/jni/v8/JavaInstanceV8.cpp:
  57604. (JavaInstance::JavaInstance):
  57605. * bridge/jni/v8/JavaInstanceV8.h:
  57606. * bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
  57607. (JobjectWrapper::JobjectWrapper):
  57608. (JobjectWrapper::~JobjectWrapper):
  57609. * bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
  57610. (JSC::Bindings::JobjectWrapper::instance):
  57611. (JSC::Bindings::JobjectWrapper::setInstance):
  57612. (JSC::Bindings::JobjectWrapper::ref):
  57613. (JSC::Bindings::JobjectWrapper::deref):
  57614. 2011-02-25 Andrey Kosyakov <caseq@chromium.org>
  57615. Reviewed by Pavel Feldman.
  57616. Web Inspector: factor search logic out of inspector.js
  57617. https://bugs.webkit.org/show_bug.cgi?id=54965
  57618. * WebCore.gypi:
  57619. * WebCore.vcproj/WebCore.vcproj:
  57620. * inspector/front-end/ElementsPanel.js:
  57621. (WebInspector.ElementsPanel.prototype.searchCanceled):
  57622. (WebInspector.ElementsPanel.prototype.switchToAndFocus):
  57623. (WebInspector.ElementsPanel.prototype._updateMatchesCount):
  57624. * inspector/front-end/Panel.js:
  57625. (WebInspector.Panel.prototype.searchCanceled):
  57626. (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
  57627. * inspector/front-end/ScriptsPanel.js:
  57628. (WebInspector.ScriptsPanel.prototype.searchCanceled):
  57629. (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
  57630. (WebInspector.ScriptsPanel.prototype.performSearch):
  57631. * inspector/front-end/SearchController.js: Added.
  57632. (WebInspector.SearchController):
  57633. (WebInspector.SearchController.prototype.updateSearchMatchesCount):
  57634. (WebInspector.SearchController.prototype.updateSearchLabel):
  57635. (WebInspector.SearchController.prototype.cancelSearch):
  57636. (WebInspector.SearchController.prototype.handleShortcut):
  57637. (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
  57638. (WebInspector.SearchController.prototype.activePanelChanged):
  57639. (WebInspector.SearchController.prototype._updateSearchMatchesCount):
  57640. (WebInspector.SearchController.prototype._focusSearchField):
  57641. (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
  57642. (WebInspector.SearchController.prototype._onKeyDown):
  57643. (WebInspector.SearchController.prototype._onSearch):
  57644. (WebInspector.SearchController.prototype._performSearch):
  57645. * inspector/front-end/WebKit.qrc:
  57646. * inspector/front-end/inspector.html:
  57647. * inspector/front-end/inspector.js:
  57648. (WebInspector.set currentPanel):
  57649. (WebInspector.set attached):
  57650. (WebInspector.doLoadedDone):
  57651. (WebInspector.documentKeyDown):
  57652. 2011-03-02 Renata Hodovan <reni@webkit.org>
  57653. Reviewed by Andreas Kling.
  57654. FEMorphologyElement changes doesn't require relayout
  57655. https://bugs.webkit.org/show_bug.cgi?id=55462
  57656. When the FEMorphologyElement receives an update message but the given value remains the same we don't need
  57657. to relayout the filter.
  57658. No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.
  57659. * platform/graphics/filters/FEMorphology.cpp:
  57660. (WebCore::FEMorphology::setMorphologyOperator):
  57661. (WebCore::FEMorphology::setRadiusX):
  57662. (WebCore::FEMorphology::setRadiusY):
  57663. * platform/graphics/filters/FEMorphology.h:
  57664. * svg/SVGFEMorphologyElement.cpp:
  57665. (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
  57666. (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  57667. * svg/SVGFEMorphologyElement.h:
  57668. 2011-03-01 Kent Tamura <tkent@chromium.org>
  57669. Reviewed by Dimitri Glazkov.
  57670. Assertion fails when a form validation bubble appears
  57671. https://bugs.webkit.org/show_bug.cgi?id=55550
  57672. Test: fast/forms/interactive-validation-attach-assertion.html
  57673. * html/ValidationMessage.cpp:
  57674. (WebCore::ValidationMessage::buildBubbleTree):
  57675. Just remove unnecessary attach().
  57676. 2011-03-01 Kent Tamura <tkent@chromium.org>
  57677. Reviewed by Dimitri Glazkov.
  57678. Support localized numbers in <input type=number>
  57679. https://bugs.webkit.org/show_bug.cgi?id=42484
  57680. This change adds support of localized numbers in <input type=number>.
  57681. This affects only the UI, and not HTMLInputElement::value.
  57682. - Remove the keyboard input restriction feature because it is hard to
  57683. retrieve characters usable for localized numbers in ICU.
  57684. - Separate convertFromVisibleValue() from sanitizeValue().
  57685. sanitizeValue() is used for not only converting a renderer value to a
  57686. DOM value.
  57687. - Implement LocalizedNumber functions for ICU and NSNumberFormatter.
  57688. It is used only in Chromium for now.
  57689. Test: manual-tests/input-number-localization.html
  57690. * WebCore.gypi: Use LocalizedNumberICU.cpp.
  57691. * WebCore.xcodeproj/project.pbxproj:
  57692. Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
  57693. * dom/InputElement.h: Introduce convertFromVisibleValue().
  57694. * html/HTMLInputElement.cpp:
  57695. (WebCore::HTMLInputElement::convertFromVisibleValue):
  57696. * html/HTMLInputElement.h:
  57697. * html/InputType.cpp:
  57698. (WebCore::InputType::convertFromVisibleValue):
  57699. * html/InputType.h:
  57700. * html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
  57701. isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
  57702. remove the keyboard input restriction feature for type=number.
  57703. (WebCore::NumberInputType::convertFromVisibleValue):
  57704. (WebCore::NumberInputType::sanitizeValue):
  57705. * html/NumberInputType.h:
  57706. * manual-tests/input-number-localization.html: Add a manual test because
  57707. the behavior depends on the current locale.
  57708. * platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
  57709. * platform/text/LocalizedNumberICU.cpp:
  57710. Implement LocalizedNumber functions with ICU NumberFormat.
  57711. (WebCore::createFormatterForCurrentLocale):
  57712. (WebCore::parseLocalizedNumber):
  57713. (WebCore::formatLocalizedNumber):
  57714. * platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
  57715. * platform/text/mac/LocalizedNumberMac.mm:
  57716. Implement LocalizedNumber functions with NSNumberFormatter.
  57717. (WebCore::parseLocalizedNumber):
  57718. (WebCore::formatLocalizedNumber):
  57719. * rendering/RenderTextControlSingleLine.cpp:
  57720. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  57721. * wml/WMLInputElement.h:
  57722. (WebCore::WMLInputElement::convertFromVisibleValue):
  57723. Implemented as a function doing nothing.
  57724. 2011-03-01 Yuta Kitamura <yutak@chromium.org>
  57725. Reviewed by Darin Adler.
  57726. REGRESSION(r78383): Failure to connect on websocketstest.com
  57727. https://bugs.webkit.org/show_bug.cgi?id=54811
  57728. After r78383, KURL::setPort() no longer appends ":port" part
  57729. if that port is the default port for URL scheme. This broke
  57730. SocketStreamHandleCFNet, whose code was based on an assumption
  57731. that KURL::setPort() always inserts ":port" part.
  57732. To fix this, KURL::port() call is removed from SocketStreamHandle
  57733. and the port number is calculated on-the-fly.
  57734. Unfortunately it is impossible to write a test; this bug only
  57735. affects WebSockets connecting to the default port (port 80
  57736. for ws, port 443 for wss), while we use different ports to test
  57737. WebSockets in LayoutTests.
  57738. * platform/network/cf/SocketStreamHandle.h:
  57739. * platform/network/cf/SocketStreamHandleCFNet.cpp:
  57740. (WebCore::SocketStreamHandle::SocketStreamHandle):
  57741. (WebCore::SocketStreamHandle::createStreams):
  57742. (WebCore::SocketStreamHandle::port):
  57743. 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
  57744. Unreviewed, rolling out r80079.
  57745. http://trac.webkit.org/changeset/80079
  57746. https://bugs.webkit.org/show_bug.cgi?id=55547
  57747. "Broke the Win debug build?" (Requested by dcheng on #webkit).
  57748. * Configurations/FeatureDefines.xcconfig:
  57749. * GNUmakefile.am:
  57750. * features.pri:
  57751. 2011-02-25 Adrienne Walker <enne@google.com>
  57752. Reviewed by James Robinson.
  57753. [chromium] Abstract "pixels with a graphics context" into its own class
  57754. https://bugs.webkit.org/show_bug.cgi?id=55259
  57755. This creates new PlatformCanvas/PlatformImage classes which wrap
  57756. all of the #ifdef Skia/Cg warts from the compositor. All classes
  57757. (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
  57758. modified to use these abstractions.
  57759. Tests: LayoutTests/compositing
  57760. * WebCore.gypi:
  57761. * platform/graphics/chromium/ContentLayerChromium.cpp:
  57762. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  57763. (WebCore::ContentLayerChromium::resizeUploadBuffer):
  57764. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  57765. (WebCore::ContentLayerChromium::updateTexture):
  57766. (WebCore::ContentLayerChromium::draw):
  57767. * platform/graphics/chromium/ContentLayerChromium.h:
  57768. * platform/graphics/chromium/ImageLayerChromium.cpp:
  57769. (WebCore::ImageLayerChromium::updateContentsIfDirty):
  57770. (WebCore::ImageLayerChromium::updateTextureIfNeeded):
  57771. * platform/graphics/chromium/ImageLayerChromium.h:
  57772. * platform/graphics/chromium/LayerTilerChromium.cpp:
  57773. (WebCore::LayerTilerChromium::contentRectToTileIndices):
  57774. (WebCore::LayerTilerChromium::update):
  57775. (WebCore::LayerTilerChromium::updateFromPixels):
  57776. * platform/graphics/chromium/LayerTilerChromium.h:
  57777. * platform/graphics/chromium/PlatformCanvas.cpp: Added.
  57778. (WebCore::PlatformCanvas::PlatformCanvas):
  57779. (WebCore::PlatformCanvas::~PlatformCanvas):
  57780. (WebCore::PlatformCanvas::resize):
  57781. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  57782. (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
  57783. (WebCore::PlatformCanvas::Painter::Painter):
  57784. (WebCore::PlatformCanvas::Painter::~Painter):
  57785. * platform/graphics/chromium/PlatformCanvas.h: Added.
  57786. (WebCore::PlatformCanvas::AutoLocker::pixels):
  57787. (WebCore::PlatformCanvas::Painter::context):
  57788. (WebCore::PlatformCanvas::size):
  57789. * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
  57790. (WebCore::PlatformImage::PlatformImage):
  57791. (WebCore::PlatformImage::updateFromImage):
  57792. * platform/graphics/chromium/PlatformImage.h: Added.
  57793. (WebCore::PlatformImage::pixels):
  57794. (WebCore::PlatformImage::size):
  57795. 2011-03-01 Daniel Cheng <dcheng@chromium.org>
  57796. Reviewed by David Levin.
  57797. Add feature define for data transfer items
  57798. https://bugs.webkit.org/show_bug.cgi?id=55510
  57799. * Configurations/FeatureDefines.xcconfig:
  57800. * GNUmakefile.am:
  57801. * features.pri:
  57802. 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
  57803. Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
  57804. * dom/ViewportArguments.cpp:
  57805. (WebCore::computeViewportAttributes):
  57806. (WebCore::numericPrefix):
  57807. (WebCore::findSizeValue):
  57808. (WebCore::setViewportFeature):
  57809. (WebCore::viewportErrorMessageTemplate):
  57810. (WebCore::viewportErrorMessageLevel):
  57811. * dom/ViewportArguments.h:
  57812. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  57813. Reviewed by James Robinson.
  57814. IDBKeyRange.bound() should not use the optional options object
  57815. https://bugs.webkit.org/show_bug.cgi?id=55419
  57816. http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
  57817. Added some code to existing tests to cover these cases.
  57818. * storage/IDBKeyRange.cpp:
  57819. (WebCore::IDBKeyRange::bound):
  57820. * storage/IDBKeyRange.h:
  57821. * storage/IDBKeyRange.idl:
  57822. 2011-03-01 Dan Bernstein <mitz@apple.com>
  57823. Build fix.
  57824. * dom/DocumentMarkerController.cpp:
  57825. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  57826. 2011-03-01 Kent Tamura <tkent@chromium.org>
  57827. Unreviewed. Apply sort-Xcode-project-file.
  57828. * WebCore.xcodeproj/project.pbxproj:
  57829. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  57830. Reviewed by James Robinson.
  57831. V8 code generator doesn't properly support a single SerializedScriptValue attribute
  57832. https://bugs.webkit.org/show_bug.cgi?id=55530
  57833. This is tested by the bindings tests changes.
  57834. * bindings/scripts/CodeGeneratorV8.pm:
  57835. * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
  57836. (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
  57837. (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
  57838. (WebDOMTestSerializedScriptValueInterface::operator=):
  57839. (WebDOMTestSerializedScriptValueInterface::impl):
  57840. (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
  57841. (WebDOMTestSerializedScriptValueInterface::value):
  57842. (toWebCore):
  57843. (toWebKit):
  57844. * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
  57845. * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
  57846. (WebKit::kit):
  57847. (webkit_dom_test_serialized_script_value_interface_get_value):
  57848. (WebKit::core):
  57849. (webkit_dom_test_serialized_script_value_interface_finalize):
  57850. (webkit_dom_test_serialized_script_value_interface_set_property):
  57851. (webkit_dom_test_serialized_script_value_interface_get_property):
  57852. (webkit_dom_test_serialized_script_value_interface_constructed):
  57853. (webkit_dom_test_serialized_script_value_interface_class_init):
  57854. (webkit_dom_test_serialized_script_value_interface_init):
  57855. (WebKit::wrapTestSerializedScriptValueInterface):
  57856. * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
  57857. * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
  57858. * bindings/scripts/test/JS/JSTestInterface.cpp:
  57859. (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
  57860. (WebCore::JSTestInterface::JSTestInterface):
  57861. * bindings/scripts/test/JS/JSTestInterface.h:
  57862. * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  57863. (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
  57864. (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
  57865. (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
  57866. * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  57867. * bindings/scripts/test/JS/JSTestObj.cpp:
  57868. (WebCore::JSTestObjConstructor::JSTestObjConstructor):
  57869. (WebCore::JSTestObj::JSTestObj):
  57870. (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
  57871. (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
  57872. (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
  57873. (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
  57874. (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
  57875. (WebCore::jsTestObjPrototypeFunctionSerializedValue):
  57876. (WebCore::jsTestObjPrototypeFunctionIdbKey):
  57877. (WebCore::jsTestObjPrototypeFunctionOptionsObject):
  57878. (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
  57879. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
  57880. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
  57881. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
  57882. (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  57883. (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
  57884. (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
  57885. (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
  57886. (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
  57887. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
  57888. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
  57889. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
  57890. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
  57891. (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
  57892. * bindings/scripts/test/JS/JSTestObj.h:
  57893. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
  57894. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
  57895. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
  57896. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
  57897. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
  57898. (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
  57899. (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
  57900. (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
  57901. (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
  57902. (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
  57903. (WebCore::jsTestSerializedScriptValueInterfaceValue):
  57904. (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
  57905. (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
  57906. (WebCore::toJS):
  57907. (WebCore::toTestSerializedScriptValueInterface):
  57908. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
  57909. (WebCore::JSTestSerializedScriptValueInterface::createStructure):
  57910. (WebCore::JSTestSerializedScriptValueInterface::impl):
  57911. (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
  57912. (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
  57913. * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
  57914. * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
  57915. (-[DOMTestSerializedScriptValueInterface dealloc]):
  57916. (-[DOMTestSerializedScriptValueInterface finalize]):
  57917. (-[DOMTestSerializedScriptValueInterface value]):
  57918. (core):
  57919. (kit):
  57920. * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
  57921. * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
  57922. * bindings/scripts/test/V8/V8TestInterface.cpp:
  57923. (WebCore::ConfigureV8TestInterfaceTemplate):
  57924. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
  57925. (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
  57926. (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
  57927. (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
  57928. (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
  57929. (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
  57930. (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
  57931. (WebCore::V8TestSerializedScriptValueInterface::derefObject):
  57932. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
  57933. (WebCore::V8TestSerializedScriptValueInterface::toNative):
  57934. (WebCore::V8TestSerializedScriptValueInterface::wrap):
  57935. (WebCore::toV8):
  57936. 2011-03-01 Oliver Hunt <oliver@apple.com>
  57937. Reviewed by Joseph Pecoraro.
  57938. Misaligned memory access in CloneDeserializer on all ARM arch.
  57939. https://bugs.webkit.org/show_bug.cgi?id=48742
  57940. Push platforms that need aligned memory access down the
  57941. endian independent serialization and deserialization
  57942. paths.
  57943. * bindings/js/SerializedScriptValue.cpp:
  57944. 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
  57945. Reviewed by Kenneth Rohde Christiansen.
  57946. Viewport Warning/Error Messages Are Now Inaccurate
  57947. https://bugs.webkit.org/show_bug.cgi?id=53707
  57948. Correct and improve the error messages for viewport
  57949. parsing. Clarify the difference between incorrect
  57950. keys, values, and when to use the device-width or
  57951. device-height constants.
  57952. * dom/ViewportArguments.cpp:
  57953. (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
  57954. (WebCore::numericPrefix):
  57955. (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
  57956. (WebCore::setViewportFeature): report a warning for an unrecognized key.
  57957. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
  57958. (WebCore::viewportErrorMessageLevel):
  57959. * dom/ViewportArguments.h:
  57960. 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
  57961. Reviewed by Darin Adler.
  57962. WebKit does not merge text decorations in the typing style and the selected element properly
  57963. https://bugs.webkit.org/show_bug.cgi?id=55349
  57964. The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
  57965. Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
  57966. calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
  57967. Test: editing/execCommand/merge-text-decoration-with-typing-style.html
  57968. * editing/ApplyStyleCommand.cpp:
  57969. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
  57970. calls mergeInlineStyleOfElement.
  57971. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
  57972. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
  57973. * editing/ApplyStyleCommand.h:
  57974. * editing/EditingStyle.cpp:
  57975. (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
  57976. (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
  57977. (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
  57978. * editing/EditingStyle.h:
  57979. 2011-03-01 Levi Weintraub <leviw@chromium.org>
  57980. Reviewed by Ryosuke Niwa.
  57981. Stop instantiating legacy editing Positions in VisiblePosition
  57982. https://bugs.webkit.org/show_bug.cgi?id=52919
  57983. Changing VisiblePosition completely away from legacy positions.
  57984. No new tests since this is functionaly equivalent.
  57985. * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
  57986. adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
  57987. outside of WebCore, they should be parent anchored.
  57988. * accessibility/AXObjectCache.cpp:
  57989. (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
  57990. * accessibility/AccessibilityObject.cpp:
  57991. (WebCore::startOfStyleRange):
  57992. (WebCore::endOfStyleRange):
  57993. * accessibility/AccessibilityRenderObject.cpp:
  57994. (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  57995. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  57996. (objectAndOffsetUnignored):
  57997. * dom/Position.cpp:
  57998. (WebCore::Position::document): Added this inline function to avoid the necessity
  57999. of calling anchorNode to assure a document from a Position.
  58000. (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
  58001. (WebCore::Position::downstream): ditto
  58002. * dom/Range.cpp:
  58003. (WebCore::Range::editingStartPosition):
  58004. * editing/Editor.cpp:
  58005. (WebCore::Editor::canDeleteRange):
  58006. * editing/ReplaceSelectionCommand.cpp:
  58007. (WebCore::ReplaceSelectionCommand::doApply):
  58008. * editing/SelectionController.cpp:
  58009. (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  58010. (WebCore::SelectionController::setSelectedRange):
  58011. * editing/TextIterator.cpp:
  58012. (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  58013. * editing/TypingCommand.cpp:
  58014. (WebCore::TypingCommand::deleteKeyPressed):
  58015. * editing/VisiblePosition.cpp:
  58016. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  58017. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  58018. (WebCore::VisiblePosition::canonicalPosition):
  58019. (WebCore::VisiblePosition::characterAfter):
  58020. (WebCore::VisiblePosition::localCaretRect):
  58021. (WebCore::makeRange):
  58022. (WebCore::startVisiblePosition):
  58023. (WebCore::endVisiblePosition):
  58024. (WebCore::setStart):
  58025. (WebCore::setEnd):
  58026. (WebCore::isFirstVisiblePositionInNode):
  58027. (WebCore::isLastVisiblePositionInNode):
  58028. * editing/VisiblePosition.h:
  58029. (WebCore::VisiblePosition::VisiblePosition):
  58030. * editing/htmlediting.cpp:
  58031. (WebCore::firstInSpecialElement):
  58032. (WebCore::lastInSpecialElement):
  58033. (WebCore::visiblePositionBeforeNode):
  58034. (WebCore::visiblePositionAfterNode):
  58035. * editing/visible_units.cpp:
  58036. (WebCore::startPositionForLine):
  58037. (WebCore::endPositionForLine):
  58038. (WebCore::previousLinePosition):
  58039. (WebCore::nextLinePosition):
  58040. (WebCore::startOfParagraph):
  58041. (WebCore::endOfParagraph):
  58042. (WebCore::endOfBlock):
  58043. (WebCore::startOfDocument):
  58044. (WebCore::endOfDocument):
  58045. (WebCore::logicalStartPositionForLine):
  58046. (WebCore::logicalEndPositionForLine):
  58047. * page/DOMSelection.cpp:
  58048. (WebCore::DOMSelection::collapse):
  58049. (WebCore::DOMSelection::setBaseAndExtent):
  58050. (WebCore::DOMSelection::setPosition):
  58051. (WebCore::DOMSelection::extend):
  58052. * page/EventHandler.cpp:
  58053. (WebCore::EventHandler::handleMousePressEventSingleClick):
  58054. * rendering/RenderObject.cpp:
  58055. (WebCore::RenderObject::createVisiblePosition):
  58056. * rendering/RenderTextControl.cpp:
  58057. (WebCore::RenderTextControl::visiblePositionForIndex):
  58058. * svg/SVGTextContentElement.cpp:
  58059. (WebCore::SVGTextContentElement::selectSubString):
  58060. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  58061. Reviewed by Steve Block.
  58062. When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
  58063. https://bugs.webkit.org/show_bug.cgi?id=54785
  58064. This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
  58065. the right thing and continue to do the right thing. It also modifies EventQueue
  58066. so that we can cancel an event. To do this efficiently, the vector is now a
  58067. ListHashSet.
  58068. Cancelling the event is harder/messier, but the most deterministic thing to do.
  58069. To the user, the work isn't done until we fire the onsuccess/onerror handler.
  58070. So the event (which does fire that) needs to be cancelable.
  58071. transaction-abort.html tests this.
  58072. * dom/EventQueue.cpp:
  58073. (WebCore::EventQueue::enqueueEvent):
  58074. (WebCore::EventQueue::cancelEvent):
  58075. (WebCore::EventQueue::pendingEventTimerFired):
  58076. (WebCore::EventQueue::dispatchEvent):
  58077. * dom/EventQueue.h:
  58078. * dom/ExceptionCode.cpp:
  58079. * storage/IDBCursor.cpp:
  58080. (WebCore::IDBCursor::update):
  58081. (WebCore::IDBCursor::deleteFunction):
  58082. * storage/IDBDatabaseBackendImpl.cpp:
  58083. (WebCore::IDBDatabaseBackendImpl::close):
  58084. * storage/IDBDatabaseException.h:
  58085. * storage/IDBIndex.cpp:
  58086. (WebCore::IDBIndex::openCursor):
  58087. (WebCore::IDBIndex::openKeyCursor):
  58088. (WebCore::IDBIndex::get):
  58089. (WebCore::IDBIndex::getKey):
  58090. * storage/IDBObjectStore.cpp:
  58091. (WebCore::IDBObjectStore::get):
  58092. (WebCore::IDBObjectStore::add):
  58093. (WebCore::IDBObjectStore::put):
  58094. (WebCore::IDBObjectStore::deleteFunction):
  58095. (WebCore::IDBObjectStore::clear):
  58096. (WebCore::IDBObjectStore::openCursor):
  58097. * storage/IDBRequest.cpp:
  58098. (WebCore::IDBRequest::IDBRequest):
  58099. (WebCore::IDBRequest::~IDBRequest):
  58100. (WebCore::IDBRequest::readyState):
  58101. (WebCore::IDBRequest::markEarlyDeath):
  58102. (WebCore::IDBRequest::source):
  58103. (WebCore::IDBRequest::abort):
  58104. (WebCore::IDBRequest::onSuccess):
  58105. (WebCore::IDBRequest::dispatchEvent):
  58106. (WebCore::IDBRequest::enqueueEvent):
  58107. * storage/IDBRequest.h:
  58108. * storage/IDBTransaction.cpp:
  58109. (WebCore::IDBTransaction::registerRequest):
  58110. (WebCore::IDBTransaction::unregisterRequest):
  58111. (WebCore::IDBTransaction::onAbort):
  58112. * storage/IDBTransaction.h:
  58113. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  58114. Reviewed by Mihai Parparita.
  58115. EventQueue needs to be ref counted
  58116. https://bugs.webkit.org/show_bug.cgi?id=55512
  58117. EventQueue needs to be ref counted because it's possible for its instance
  58118. to be deleted while it's dispatching events. This is the reason why
  58119. https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
  58120. No change of behavior, so no tests.
  58121. * dom/Document.h:
  58122. * dom/EventQueue.cpp:
  58123. (WebCore::EventQueue::create):
  58124. * dom/EventQueue.h:
  58125. 2011-03-01 Helder Correia <helder@sencha.com>
  58126. Reviewed by Simon Fraser.
  58127. No shadow when stroking a path with a gradient
  58128. https://bugs.webkit.org/show_bug.cgi?id=55436
  58129. This happens in CG and is related to bug 52509, this time to be fixed
  58130. in GraphicsContext::strokePath(). The gradient needs to be drawn
  58131. clipped to the stroke on a CGLayer first, then the layer drawn on the
  58132. GraphicsContext.
  58133. Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
  58134. svg/css/path-gradient-stroke-shadow.svg
  58135. * platform/graphics/cg/GraphicsContextCG.cpp:
  58136. (WebCore::GraphicsContext::strokePath):
  58137. 2011-03-01 David Hyatt <hyatt@apple.com>
  58138. Reviewed by Dan Bernstein.
  58139. Fix Font::spaceWidth() to be a float instead of an int.
  58140. * platform/graphics/Font.h:
  58141. (WebCore::Font::spaceWidth):
  58142. 2011-02-28 Steve Block <steveblock@google.com>
  58143. Reviewed by Jeremy Orlow.
  58144. Chromium gypi file should include Java bridge files from WebCore/bridge
  58145. https://bugs.webkit.org/show_bug.cgi?id=55387
  58146. No new tests, no code changes.
  58147. * WebCore.gyp/WebCore.gyp:
  58148. * WebCore.gypi:
  58149. 2011-03-01 James Simonsen <simonjam@chromium.org>
  58150. Reviewed by Tony Gentilcore.
  58151. [Web Timing] Handle the case where no responseEnd time is available.
  58152. https://bugs.webkit.org/show_bug.cgi?id=55444
  58153. * loader/MainResourceLoader.cpp:
  58154. (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
  58155. (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.
  58156. 2011-03-01 Patrick Gansterer <paroga@webkit.org>
  58157. Unreviewed, adding missing change for r80034.
  58158. Add a handler class for Win32 HANDLE
  58159. https://bugs.webkit.org/show_bug.cgi?id=55334
  58160. * platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
  58161. 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
  58162. Unreviewed, rolling out r80037.
  58163. http://trac.webkit.org/changeset/80037
  58164. https://bugs.webkit.org/show_bug.cgi?id=55508
  58165. broke compile on SL (Requested by tonyg-cr on #webkit).
  58166. * Android.mk:
  58167. * CMakeLists.txt:
  58168. * GNUmakefile.am:
  58169. * WebCore.gypi:
  58170. * WebCore.pro:
  58171. * WebCore.vcproj/WebCore.vcproj:
  58172. * WebCore.xcodeproj/project.pbxproj:
  58173. * css/CSSParser.cpp:
  58174. (WebCore::CSSParser::parseValue):
  58175. * css/CSSParser.h:
  58176. * css/CSSStyleSelector.cpp:
  58177. (WebCore::CSSStyleSelector::applyProperty):
  58178. * css/html.css:
  58179. (q:before):
  58180. (q:after):
  58181. * rendering/RenderBlockLineLayout.cpp:
  58182. (WebCore::dirtyLineBoxesForRenderer):
  58183. * rendering/RenderObject.h:
  58184. * rendering/RenderObjectChildList.cpp:
  58185. (WebCore::RenderObjectChildList::removeChildNode):
  58186. (WebCore::RenderObjectChildList::appendChildNode):
  58187. (WebCore::RenderObjectChildList::insertChildNode):
  58188. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  58189. * rendering/RenderQuote.cpp: Removed.
  58190. * rendering/RenderQuote.h: Removed.
  58191. * rendering/RenderingAllInOne.cpp:
  58192. * rendering/style/ContentData.cpp:
  58193. (WebCore::ContentData::dataEquivalent):
  58194. (WebCore::ContentData::deleteContent):
  58195. * rendering/style/ContentData.h:
  58196. * rendering/style/QuotesData.cpp: Removed.
  58197. * rendering/style/QuotesData.h: Removed.
  58198. * rendering/style/RenderStyle.cpp:
  58199. * rendering/style/RenderStyle.h:
  58200. * rendering/style/RenderStyleConstants.h:
  58201. * rendering/style/StyleAllInOne.cpp:
  58202. * rendering/style/StyleRareInheritedData.cpp:
  58203. (WebCore::StyleRareInheritedData::operator==):
  58204. * rendering/style/StyleRareInheritedData.h:
  58205. 2011-03-01 Abhishek Arya <inferno@chromium.org>
  58206. Reviewed by Dave Hyatt.
  58207. Paint outline for tables.
  58208. https://bugs.webkit.org/show_bug.cgi?id=55474
  58209. Test: fast/table/table-and-parts-outline.html
  58210. * rendering/RenderTable.cpp:
  58211. (WebCore::RenderTable::paintObject):
  58212. 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
  58213. Unreviewed, rolling out r80028.
  58214. http://trac.webkit.org/changeset/80028
  58215. https://bugs.webkit.org/show_bug.cgi?id=55502
  58216. 'caused crashes; rolling out while investigating' (Requested
  58217. by jorlow on #webkit).
  58218. * dom/EventQueue.cpp:
  58219. (WebCore::EventQueue::enqueueEvent):
  58220. (WebCore::EventQueue::pendingEventTimerFired):
  58221. (WebCore::EventQueue::dispatchEvent):
  58222. * dom/EventQueue.h:
  58223. * dom/ExceptionCode.cpp:
  58224. * storage/IDBCursor.cpp:
  58225. (WebCore::IDBCursor::update):
  58226. (WebCore::IDBCursor::deleteFunction):
  58227. * storage/IDBDatabaseException.h:
  58228. * storage/IDBDatabaseException.idl:
  58229. * storage/IDBIndex.cpp:
  58230. (WebCore::IDBIndex::openCursor):
  58231. (WebCore::IDBIndex::openKeyCursor):
  58232. (WebCore::IDBIndex::get):
  58233. (WebCore::IDBIndex::getKey):
  58234. * storage/IDBObjectStore.cpp:
  58235. (WebCore::IDBObjectStore::get):
  58236. (WebCore::IDBObjectStore::add):
  58237. (WebCore::IDBObjectStore::put):
  58238. (WebCore::IDBObjectStore::deleteFunction):
  58239. (WebCore::IDBObjectStore::clear):
  58240. (WebCore::IDBObjectStore::openCursor):
  58241. * storage/IDBRequest.cpp:
  58242. (WebCore::IDBRequest::IDBRequest):
  58243. (WebCore::IDBRequest::~IDBRequest):
  58244. (WebCore::IDBRequest::readyState):
  58245. (WebCore::IDBRequest::dispatchEvent):
  58246. (WebCore::IDBRequest::enqueueEvent):
  58247. (WebCore::IDBRequest::source):
  58248. * storage/IDBRequest.h:
  58249. * storage/IDBTransaction.cpp:
  58250. (WebCore::IDBTransaction::onAbort):
  58251. * storage/IDBTransaction.h:
  58252. 2011-03-01 Carol Szabo <carol.szabo@nokia.com>
  58253. Reviewed by David Hyatt <hyatt@apple.com>
  58254. content property doesn't support quotes
  58255. https://bugs.webkit.org/show_bug.cgi?id=6503
  58256. Added full support for quotes as defined by CSS 2.1.
  58257. Tests: fast/css/content/content-quotes-01.html
  58258. fast/css/content/content-quotes-02.html
  58259. fast/css/content/content-quotes-03.html
  58260. fast/css/content/content-quotes-04.html
  58261. fast/css/content/content-quotes-05.html
  58262. * Android.mk:
  58263. * CMakeLists.txt:
  58264. * GNUmakefile.am:
  58265. * WebCore.pro:
  58266. * WebCore.vcproj/WebCore.vcproj:
  58267. * WebCore.xcodeproj/project.pbxproj:
  58268. Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
  58269. * css/CSSParser.cpp:
  58270. (WebCore::CSSParser::parseValue):
  58271. (WebCore::CSSParser::parseQuotes):
  58272. * css/CSSParser.h:
  58273. Added needed stylesheet parsing support for quotes,
  58274. (no-)open-quote and (no-)close-quote
  58275. * css/CSSStyleSelector.cpp:
  58276. (WebCore::CSSStyleSelector::applyProperty):
  58277. Handled setting of the new quotes RenderStyle property and added
  58278. handling of quotes for the content property.
  58279. * css/html.css:
  58280. (q:before):
  58281. (q:after):
  58282. replaced the '"' workaround with open/close-quote
  58283. * rendering/RenderBlockLineLayout.cpp:
  58284. (WebCore::dirtyLineBoxesForRenderer):
  58285. Made RenderQuote behave like RenderCounter.
  58286. Needed to ensure that the Quote text is calculated before layout,
  58287. just as it is for RenderCounter.
  58288. * rendering/RenderObject.h:
  58289. (WebCore::RenderObject::isQuote):
  58290. * rendering/RenderObjectChildList.cpp:
  58291. (WebCore::RenderObjectChildList::removeChildNode):
  58292. (WebCore::RenderObjectChildList::appendChildNode):
  58293. (WebCore::RenderObjectChildList::insertChildNode):
  58294. Handled updating of quote depth when renderers are added and removed
  58295. from the tree.
  58296. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  58297. * rendering/RenderQuote.cpp: Added.
  58298. (WebCore::adjustDepth):
  58299. (WebCore::RenderQuote::RenderQuote):
  58300. (WebCore::RenderQuote::~RenderQuote):
  58301. (WebCore::RenderQuote::renderName):
  58302. (WebCore::RenderQuote::placeQuote):
  58303. (WebCore::RenderQuote::originalText):
  58304. (WebCore::RenderQuote::computePreferredLogicalWidths):
  58305. (WebCore::RenderQuote::rendererSubtreeAttached):
  58306. (WebCore::RenderQuote::rendererRemovedFromTree):
  58307. (WebCore::RenderQuote::styleDidChange):
  58308. * rendering/RenderQuote.h: Added.
  58309. (WebCore::RenderQuote::isQuote):
  58310. (WebCore::toRenderQuote):
  58311. * rendering/RenderingAllInOne.cpp:
  58312. Included RenderQuote.cpp
  58313. * rendering/style/StyleAllInOne.cpp:
  58314. Included QuotesData.cpp
  58315. * rendering/style/ContentData.cpp:
  58316. (WebCore::ContentData::dataEquivalent):
  58317. Checked for quotetype identity.
  58318. (WebCore::ContentData::deleteContent):
  58319. Accounted for the new QUOTE_TYPE.
  58320. * rendering/style/ContentData.h:
  58321. (WebCore::ContentData::isQuote):
  58322. (WebCore::ContentData::quote):
  58323. (WebCore::ContentData::setQuote):
  58324. * rendering/style/RenderStyle.cpp:
  58325. (WebCore::RenderStyle::setContent):
  58326. * rendering/style/RenderStyle.h:
  58327. (WebCore::InheritedFlags::quotes):
  58328. (WebCore::InheritedFlags::setQuotes):
  58329. * rendering/style/RenderStyleConstants.h:
  58330. * rendering/style/StyleRareInheritedData.cpp:
  58331. (WebCore::StyleRareInheritedData::operator==):
  58332. Included quotes in equality check.
  58333. * rendering/style/StyleRareInheritedData.h:
  58334. Added quotes
  58335. 2011-03-01 Michael Nordman <michaeln@google.com>
  58336. Reviewed by Alexey Proskuryakov.
  58337. Alter the relative priorities of network vs fallback namespaces in the appcache.
  58338. If a resource url is in an appcache's network namespace and fallback namespace, the network
  58339. namespace wins (with the exception of the special '*' network namespace which does not take
  58340. priority over the fallback namespace.
  58341. https://bugs.webkit.org/show_bug.cgi?id=49292
  58342. Test: http/tests/appcache/online-fallback-layering.html
  58343. * loader/appcache/ApplicationCache.cpp:
  58344. (WebCore::ApplicationCache::isURLInOnlineWhitelist):
  58345. * loader/appcache/ApplicationCacheHost.cpp:
  58346. (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
  58347. (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
  58348. * loader/appcache/ApplicationCacheStorage.cpp:
  58349. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
  58350. 2011-03-01 Patrick Gansterer <paroga@webkit.org>
  58351. Reviewed by Adam Roben.
  58352. Add a handler class for Win32 HANDLE
  58353. https://bugs.webkit.org/show_bug.cgi?id=55334
  58354. This class will call CloseHandle in the destructor for valid handles.
  58355. * platform/win/Win32Handle.h: Added.
  58356. 2011-03-01 Eric Carlson <eric.carlson@apple.com>
  58357. Reviewed by Chris Marrin.
  58358. <audio> and <video> should respect private browsing mode
  58359. https://bugs.webkit.org/show_bug.cgi?id=55287
  58360. <rdar://problem/9057699>
  58361. No new tests, this is just the plumbing.
  58362. * dom/Document.cpp:
  58363. (WebCore::Document::privateBrowsingStateDidChange): New.
  58364. (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto.
  58365. (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
  58366. * dom/Document.h:
  58367. * dom/Element.h:
  58368. (WebCore::Element::privateBrowsingStateDidChange): New.
  58369. * html/HTMLMediaElement.cpp:
  58370. (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
  58371. (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes.
  58372. (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode.
  58373. (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call through to MediaPlayer.
  58374. * html/HTMLMediaElement.h:
  58375. * page/Page.cpp:
  58376. (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.
  58377. * platform/graphics/MediaPlayer.cpp:
  58378. (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
  58379. * platform/graphics/MediaPlayer.h:
  58380. * platform/graphics/MediaPlayerPrivate.h:
  58381. (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.
  58382. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  58383. Reviewed by Steve Block.
  58384. When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
  58385. https://bugs.webkit.org/show_bug.cgi?id=54785
  58386. This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
  58387. the right thing and continue to do the right thing. It also modifies EventQueue
  58388. so that we can cancel an event. To do this efficiently, the vector is now a
  58389. ListHashSet.
  58390. Canelling the event is harder/messier, but the most deterministic thing to do.
  58391. To the user, the work isn't done until we fire the onsuccess/onerror handler.
  58392. So the event (which does fire that) needs to be cancelable.
  58393. transaction-abort.html tests this.
  58394. * dom/EventQueue.cpp:
  58395. (WebCore::EventQueue::enqueueEvent):
  58396. (WebCore::EventQueue::cancelEvent):
  58397. (WebCore::EventQueue::pendingEventTimerFired):
  58398. (WebCore::EventQueue::dispatchEvent):
  58399. * dom/EventQueue.h:
  58400. * dom/ExceptionCode.cpp:
  58401. * storage/IDBCursor.cpp:
  58402. (WebCore::IDBCursor::update):
  58403. (WebCore::IDBCursor::deleteFunction):
  58404. * storage/IDBDatabaseBackendImpl.cpp:
  58405. (WebCore::IDBDatabaseBackendImpl::close):
  58406. * storage/IDBDatabaseException.h:
  58407. * storage/IDBIndex.cpp:
  58408. (WebCore::IDBIndex::openCursor):
  58409. (WebCore::IDBIndex::openKeyCursor):
  58410. (WebCore::IDBIndex::get):
  58411. (WebCore::IDBIndex::getKey):
  58412. * storage/IDBObjectStore.cpp:
  58413. (WebCore::IDBObjectStore::get):
  58414. (WebCore::IDBObjectStore::add):
  58415. (WebCore::IDBObjectStore::put):
  58416. (WebCore::IDBObjectStore::deleteFunction):
  58417. (WebCore::IDBObjectStore::clear):
  58418. (WebCore::IDBObjectStore::openCursor):
  58419. * storage/IDBRequest.cpp:
  58420. (WebCore::IDBRequest::IDBRequest):
  58421. (WebCore::IDBRequest::~IDBRequest):
  58422. (WebCore::IDBRequest::readyState):
  58423. (WebCore::IDBRequest::markEarlyDeath):
  58424. (WebCore::IDBRequest::source):
  58425. (WebCore::IDBRequest::abort):
  58426. (WebCore::IDBRequest::onSuccess):
  58427. (WebCore::IDBRequest::dispatchEvent):
  58428. (WebCore::IDBRequest::enqueueEvent):
  58429. * storage/IDBRequest.h:
  58430. * storage/IDBTransaction.cpp:
  58431. (WebCore::IDBTransaction::registerRequest):
  58432. (WebCore::IDBTransaction::unregisterRequest):
  58433. (WebCore::IDBTransaction::onAbort):
  58434. * storage/IDBTransaction.h:
  58435. 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
  58436. Reviewed by Steve Block.
  58437. Only IndexedDB's error event should be cancelable
  58438. https://bugs.webkit.org/show_bug.cgi?id=55413
  58439. * storage/IDBRequest.cpp:
  58440. (WebCore::createSuccessEvent):
  58441. * storage/IDBTransaction.cpp:
  58442. (WebCore::IDBTransaction::onAbort):
  58443. (WebCore::IDBTransaction::onComplete):
  58444. 2011-03-01 Jia Pu <jpu@apple.com>
  58445. Reviewed by Darin Adler.
  58446. Remove CorrectionIndicator markers sooner.
  58447. https://bugs.webkit.org/show_bug.cgi?id=54893
  58448. <rdar://problem/8997524>
  58449. Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
  58450. This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
  58451. marker after any editing command if the command:
  58452. 1. is not a SpellingCorrectionCommand itself.
  58453. 2. is not the command that triggers the autocorrection.
  58454. This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
  58455. false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
  58456. always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
  58457. variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
  58458. public functions.
  58459. To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
  58460. to cache whether there is any marker of a particular type.
  58461. This patch also fixes two minor existing bugs.
  58462. 1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
  58463. CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
  58464. marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
  58465. marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
  58466. if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
  58467. This works as following:
  58468. When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
  58469. as the marker's description. If the user edited the corrected word afterward, we set description to null.
  58470. So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
  58471. marker, but also check if description is null.
  58472. 2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
  58473. occur when deleting the first character in an editable area.
  58474. * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
  58475. completely in from the document.
  58476. * dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
  58477. the return value of possiblyHasMarkers() at beginning.
  58478. (WebCore::DocumentMarkerController::possiblyHasMarkers):
  58479. (WebCore::DocumentMarkerController::DocumentMarkerController):
  58480. (WebCore::DocumentMarkerController::detach):
  58481. (WebCore::DocumentMarkerController::removeMarkers):
  58482. (WebCore::DocumentMarkerController::addMarker):
  58483. (WebCore::DocumentMarkerController::copyMarkers):
  58484. (WebCore::DocumentMarkerController::markerContainingPoint):
  58485. (WebCore::DocumentMarkerController::renderedRectsForMarkers):
  58486. (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
  58487. (WebCore::DocumentMarkerController::repaintMarkers):
  58488. (WebCore::DocumentMarkerController::shiftMarkers):
  58489. (WebCore::DocumentMarkerController::setMarkersActive):
  58490. (WebCore::DocumentMarkerController::hasMarkers):
  58491. (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  58492. * dom/DocumentMarkerController.h:
  58493. * editing/EditCommand.cpp:
  58494. (WebCore::EditCommand::apply):
  58495. (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
  58496. (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
  58497. * editing/EditCommand.h:
  58498. * editing/Editor.cpp:
  58499. (WebCore::Editor::respondToChangedSelection):
  58500. (WebCore::Editor::appliedEditing):
  58501. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  58502. (WebCore::Editor::insertLineBreak):
  58503. (WebCore::Editor::insertParagraphSeparator):
  58504. (WebCore::Editor::markMisspellingsAfterTypingToWord):
  58505. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  58506. (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
  58507. (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
  58508. * editing/Editor.h:
  58509. * editing/EditorCommand.cpp:
  58510. (WebCore::executeInsertLineBreak):
  58511. (WebCore::executeInsertParagraph):
  58512. (WebCore::executeInsertText):
  58513. * editing/SpellingCorrectionCommand.cpp:
  58514. (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
  58515. * editing/SpellingCorrectionCommand.h:
  58516. * editing/TypingCommand.cpp:
  58517. (WebCore::TypingCommand::TypingCommand):
  58518. (WebCore::TypingCommand::deleteSelection):
  58519. (WebCore::TypingCommand::deleteKeyPressed):
  58520. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  58521. (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
  58522. (WebCore::TypingCommand::insertText):
  58523. (WebCore::TypingCommand::insertLineBreak):
  58524. (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
  58525. (WebCore::TypingCommand::insertParagraphSeparator):
  58526. * editing/TypingCommand.h:
  58527. (WebCore::TypingCommand::create):
  58528. (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
  58529. (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
  58530. * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
  58531. 2011-03-01 Renata Hodovan <reni@webkit.org>
  58532. Reviewed by Andreas Kling.
  58533. FEDisplacementMapElement changes doesn't require relayout
  58534. https://bugs.webkit.org/show_bug.cgi?id=55454
  58535. When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
  58536. to relayout the filter.
  58537. No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.
  58538. * platform/graphics/filters/FEDisplacementMap.cpp:
  58539. (WebCore::FEDisplacementMap::setXChannelSelector):
  58540. (WebCore::FEDisplacementMap::setYChannelSelector):
  58541. (WebCore::FEDisplacementMap::setScale):
  58542. * platform/graphics/filters/FEDisplacementMap.h:
  58543. * svg/SVGFEDisplacementMapElement.cpp:
  58544. (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
  58545. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
  58546. * svg/SVGFEDisplacementMapElement.h:
  58547. 2011-03-01 Dan Bernstein <mitz@apple.com>
  58548. Reviewed by Darin Adler.
  58549. <rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
  58550. https://bugs.webkit.org/show_bug.cgi?id=55487
  58551. * css/html.css:
  58552. (ruby > rt): Changed the default text-align value to -webkit-auto to signal
  58553. the default expansion behavior.
  58554. * rendering/RenderBlock.h:
  58555. (WebCore::RenderRubyText::textAlignmentForLine): Made protected.
  58556. (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
  58557. * rendering/RenderRubyText.cpp:
  58558. (WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
  58559. -webkit-auto, returns JUSTIFY to allow expansion.
  58560. (WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
  58561. text-align is -webkit-auto, insets the line such that the inset on each side
  58562. is the half the inter-ideograph expansion, or one ruby character wide,
  58563. whichever is smaller.
  58564. * rendering/RenderRubyText.h:
  58565. 2011-03-01 Sam Weinig <sam@webkit.org>
  58566. Reviewed by Timothy Hatcher.
  58567. WebKit2 needs to be made localizable
  58568. https://bugs.webkit.org/show_bug.cgi?id=55483
  58569. * English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
  58570. * WebCore.xcodeproj/project.pbxproj:
  58571. Move Localizable.strings to WebCore.
  58572. * WebCore.exp.in:
  58573. Add export for localizedString function.
  58574. * platform/LocalizedStrings.h:
  58575. * platform/mac/LocalizedStringsMac.mm: Added.
  58576. Add function to get localized version of a string from the WebCore bundle.
  58577. 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
  58578. Reviewed by Timothy Hatcher.
  58579. All Console Messages should be passed to ChromeClients.
  58580. https://bugs.webkit.org/show_bug.cgi?id=54926
  58581. Do not filter the message type here, allow clients
  58582. to filter and deal with the different message types.
  58583. * page/Console.cpp:
  58584. (WebCore::Console::addMessage):
  58585. 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
  58586. Reviewed by Kenneth Rohde Christiansen.
  58587. Viewport parsing no longer accepts "1.0;" value as valid.
  58588. https://bugs.webkit.org/show_bug.cgi?id=53705
  58589. When parsing numeric values, the "css-viewport" spec says
  58590. to use the number prefix, and the non numeric part of the
  58591. string can be ignored. This matches our behavior before
  58592. r67376. The change was that checking the error out condition
  58593. of String::toFloat doesn't necessarily mean that there
  58594. was a non-numeric prefix. This patch checks if there was
  58595. or wasn't a non-numeric prefix.
  58596. There is a console warning in any case where a numeric
  58597. value is not parsed cleanly. There is an error warning
  58598. when it is not a number at all, and a tip warning when
  58599. it has been truncated.
  58600. Error messages are slightly improved to provide more
  58601. context, both the key and value, when an error happens.
  58602. Test: fast/viewport/viewport-129.html
  58603. * dom/ViewportArguments.cpp:
  58604. (WebCore::numericPrefix):
  58605. (WebCore::findSizeValue):
  58606. (WebCore::findScaleValue):
  58607. (WebCore::findUserScalableValue):
  58608. (WebCore::findTargetDensityDPIValue):
  58609. (WebCore::viewportErrorMessageTemplate):
  58610. (WebCore::viewportErrorMessageLevel):
  58611. (WebCore::reportViewportWarning):
  58612. * dom/ViewportArguments.h:
  58613. 2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
  58614. Reviewed by Pavel Feldman.
  58615. Web Inspector: InjectedScript.setPropertyValue doesn't work.
  58616. https://bugs.webkit.org/show_bug.cgi?id=55475
  58617. * inspector/InjectedScript.cpp:
  58618. (WebCore::InjectedScript::setPropertyValue):
  58619. 2011-03-01 Steve Block <steveblock@google.com>
  58620. Reviewed by Jeremy Orlow.
  58621. Remove unused JavaString::uchars()
  58622. https://bugs.webkit.org/show_bug.cgi?id=55465
  58623. No new tests, removing dead code only.
  58624. * bridge/jni/JNIBridge.h:
  58625. * bridge/jni/jsc/JavaStringJSC.h:
  58626. (JSC::Bindings::JavaStringImpl::utf8):
  58627. * bridge/jni/v8/JavaStringV8.h:
  58628. 2011-03-01 Alexander Pavlov <apavlov@chromium.org>
  58629. Reviewed by Yury Semikhatsky.
  58630. Web Inspector: Extremely slow DOM search in GMail
  58631. https://bugs.webkit.org/show_bug.cgi?id=55456
  58632. The solution comprises three major parts:
  58633. - avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
  58634. - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
  58635. - replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.
  58636. * inspector/front-end/ElementsPanel.js:
  58637. (WebInspector.ElementsPanel.prototype.searchCanceled):
  58638. (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
  58639. * inspector/front-end/ElementsTreeOutline.js:
  58640. (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
  58641. (WebInspector.ElementsTreeElement.prototype.updateTitle):
  58642. ():
  58643. * inspector/front-end/utilities.js:
  58644. ():
  58645. 2011-03-01 Adam Roben <aroben@apple.com>
  58646. Fix multiple-definition linker warnings introduced by r79978 on Windows
  58647. * rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
  58648. compiled separately.
  58649. 2011-03-01 Andras Becsi <abecsi@webkit.org>
  58650. Reviewed by Csaba Osztrogonác.
  58651. [Qt] Clean up the project files and move common options to WebKit.pri.
  58652. No new tests needed.
  58653. * WebCore.pri: Move common options to WebKit.pri.
  58654. * WebCore.pro: Ditto.
  58655. 2011-03-01 Steve Block <steveblock@google.com>
  58656. Reviewed by Pavel Feldman.
  58657. JNI code in Java bridge is not correctly guarded
  58658. https://bugs.webkit.org/show_bug.cgi?id=55459
  58659. No new tests, build fix only.
  58660. * bridge/jni/v8/JNIBridgeV8.cpp:
  58661. * bridge/jni/v8/JNIBridgeV8.h:
  58662. * bridge/jni/v8/JNIUtilityPrivate.cpp:
  58663. * bridge/jni/v8/JNIUtilityPrivate.h:
  58664. * bridge/jni/v8/JavaClassV8.cpp:
  58665. * bridge/jni/v8/JavaClassV8.h:
  58666. * bridge/jni/v8/JavaInstanceV8.cpp:
  58667. * bridge/jni/v8/JavaInstanceV8.h:
  58668. * bridge/jni/v8/JavaNPObjectV8.cpp:
  58669. * bridge/jni/v8/JavaNPObjectV8.h:
  58670. 2011-03-01 Steve Block <steveblock@google.com>
  58671. Reviewed by Jeremy Orlow.
  58672. Bridge.h should not include BridgeJSC.h
  58673. https://bugs.webkit.org/show_bug.cgi?id=55212
  58674. Instead, BridgeJSC.h should include Bridge.h and code should include
  58675. BridgeJSC.h as appropriate.
  58676. This prevents ports that use V8 from having to include JSC-specific
  58677. files, even if the contents of those files are guarded.
  58678. No new tests, cleanup only.
  58679. * bindings/js/JSPluginElementFunctions.cpp:
  58680. * bindings/js/ScriptControllerBrew.cpp:
  58681. * bindings/js/ScriptControllerGtk.cpp:
  58682. * bindings/js/ScriptControllerHaiku.cpp:
  58683. * bindings/js/ScriptControllerQt.cpp:
  58684. * bindings/js/ScriptControllerMac.mm:
  58685. * bindings/js/ScriptControllerWin.cpp:
  58686. * bindings/js/ScriptControllerWx.cpp:
  58687. * bindings/js/ScriptInstance.h:
  58688. * bindings/objc/WebScriptObject.mm:
  58689. * bridge/Bridge.h:
  58690. * bridge/c/c_class.h:
  58691. * bridge/c/c_instance.h:
  58692. * bridge/c/c_runtime.h:
  58693. * bridge/jni/jsc/JNIBridgeJSC.h:
  58694. * bridge/jni/jsc/JavaInstanceJSC.h:
  58695. * bridge/jsc/BridgeJSC.h:
  58696. * bridge/objc/objc_runtime.h:
  58697. * bridge/qt/qt_class.h:
  58698. * bridge/qt/qt_instance.h:
  58699. * bridge/qt/qt_pixmapruntime.h:
  58700. * bridge/qt/qt_runtime.h:
  58701. * bridge/runtime_array.h:
  58702. * bridge/runtime_method.h:
  58703. * bridge/runtime_object.h:
  58704. * bridge/runtime_root.cpp:
  58705. * bridge/testbindings.cpp:
  58706. * bridge/testbindings.mm:
  58707. * bridge/testqtbindings.cpp:
  58708. * page/win/FrameWin.cpp:
  58709. * platform/graphics/wince/MediaPlayerProxy.cpp:
  58710. * plugins/PluginView.cpp:
  58711. * plugins/PluginViewNone.cpp:
  58712. * plugins/gtk/PluginViewGtk.cpp:
  58713. * plugins/mac/PluginViewMac.mm:
  58714. * plugins/qt/PluginViewQt.cpp:
  58715. * plugins/symbian/PluginViewSymbian.cpp:
  58716. * plugins/win/PluginViewWin.cpp:
  58717. 2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
  58718. Reviewed by Antti Koivisto.
  58719. SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
  58720. https://bugs.webkit.org/show_bug.cgi?id=54800
  58721. Wrong handling of currentColor on inherit
  58722. https://bugs.webkit.org/show_bug.cgi?id=38102
  58723. Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
  58724. two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
  58725. It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
  58726. once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
  58727. accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
  58728. type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).
  58729. <g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
  58730. <g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
  58731. In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
  58732. as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
  58733. when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
  58734. available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
  58735. exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
  58736. A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
  58737. CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
  58738. Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
  58739. (Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
  58740. Add several new tests covering the patch.
  58741. Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
  58742. svg/animations/animate-color-fill-currentColor.html
  58743. svg/custom/SVGPaint-mutate-attribute.svg
  58744. svg/custom/SVGPaint-mutate-inline-style.svg
  58745. * GNUMakefile.am: Add CSSMutableValue.h
  58746. * WebCore.gypi: Ditto.
  58747. * WebCore.xcodeproj/project.pbxproj: Ditto.
  58748. * css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration.
  58749. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
  58750. * css/CSSMutableStyleDeclaration.h: Add destructor.
  58751. * css/CSSMutableValue.h: Added.
  58752. (WebCore::CSSMutableValue::CSSMutableValue):
  58753. (WebCore::CSSMutableValue::~CSSMutableValue):
  58754. (WebCore::CSSMutableValue::isMutableValue):
  58755. (WebCore::CSSMutableValue::node):
  58756. (WebCore::CSSMutableValue::setNode):
  58757. (WebCore::CSSMutableValue::setNeedsStyleRecalc):
  58758. * css/CSSStyleDeclaration.cpp:
  58759. (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
  58760. * css/CSSValue.h:
  58761. (WebCore::CSSValue::isMutableValue): Return false, default.
  58762. * css/SVGCSSComputedStyleDeclaration.cpp:
  58763. (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects.
  58764. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
  58765. * css/SVGCSSStyleSelector.cpp:
  58766. (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
  58767. * rendering/style/SVGRenderStyle.cpp:
  58768. (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
  58769. * rendering/style/SVGRenderStyle.h: Ditto.
  58770. (WebCore::SVGRenderStyle::initialFillOpacity):
  58771. (WebCore::SVGRenderStyle::initialFillPaintType):
  58772. (WebCore::SVGRenderStyle::initialFillPaintColor):
  58773. (WebCore::SVGRenderStyle::initialFillPaintUri):
  58774. (WebCore::SVGRenderStyle::initialStrokeOpacity):
  58775. (WebCore::SVGRenderStyle::initialStrokePaintType):
  58776. (WebCore::SVGRenderStyle::initialStrokePaintColor):
  58777. (WebCore::SVGRenderStyle::initialStrokePaintUri):
  58778. (WebCore::SVGRenderStyle::initialStrokeMiterLimit):
  58779. (WebCore::SVGRenderStyle::initialStopOpacity):
  58780. (WebCore::SVGRenderStyle::initialFloodOpacity):
  58781. (WebCore::SVGRenderStyle::setFillPaint):
  58782. (WebCore::SVGRenderStyle::setStrokePaint):
  58783. (WebCore::SVGRenderStyle::fillPaintType):
  58784. (WebCore::SVGRenderStyle::fillPaintColor):
  58785. (WebCore::SVGRenderStyle::fillPaintUri):
  58786. (WebCore::SVGRenderStyle::strokePaintType):
  58787. (WebCore::SVGRenderStyle::strokePaintColor):
  58788. (WebCore::SVGRenderStyle::strokePaintUri):
  58789. (WebCore::SVGRenderStyle::hasStroke):
  58790. (WebCore::SVGRenderStyle::hasFill):
  58791. * rendering/style/SVGRenderStyleDefs.cpp: Ditto.
  58792. (WebCore::StyleFillData::StyleFillData):
  58793. (WebCore::StyleFillData::operator==):
  58794. (WebCore::StyleStrokeData::StyleStrokeData):
  58795. (WebCore::StyleStrokeData::operator==):
  58796. * rendering/style/SVGRenderStyleDefs.h: Ditto.
  58797. * rendering/svg/RenderSVGResource.cpp: Ditto.
  58798. (WebCore::requestPaintingResource):
  58799. * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
  58800. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
  58801. * rendering/svg/SVGResources.cpp: Ditto.
  58802. (WebCore::paintingResourceFromSVGPaint):
  58803. (WebCore::SVGResources::buildCachedResources):
  58804. * svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object.
  58805. (WebCore::SVGColor::setRGBColor):
  58806. (WebCore::SVGColor::setRGBColorICCColor):
  58807. (WebCore::SVGColor::setColor):
  58808. * svg/SVGColor.h:
  58809. * svg/SVGPaint.cpp: Ditto.
  58810. (WebCore::SVGPaint::setUri):
  58811. (WebCore::SVGPaint::setPaint):
  58812. * svg/SVGPaint.h:
  58813. 2011-03-01 Andrey Adaikin <aandrey@google.com>
  58814. Reviewed by Pavel Feldman.
  58815. Web Inspector: [Text editor] Handle decorated lines in the editor
  58816. https://bugs.webkit.org/show_bug.cgi?id=55373
  58817. * inspector/front-end/SourceFrame.js:
  58818. (WebInspector.SourceFrame.prototype._startEditing):
  58819. (WebInspector.SourceFrame.prototype._endEditing):
  58820. (WebInspector.SourceFrame.prototype._createTextViewer):
  58821. * inspector/front-end/TextViewer.js:
  58822. (WebInspector.TextEditorGutterPanel.prototype.textChanged):
  58823. (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
  58824. (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
  58825. (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  58826. (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
  58827. (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
  58828. (WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
  58829. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  58830. (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
  58831. (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  58832. (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
  58833. (WebInspector.TextEditorMainChunk.prototype.addDecoration):
  58834. (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
  58835. (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
  58836. (WebInspector.TextEditorMainChunk.prototype.get decorated):
  58837. 2011-03-01 Philippe Normand <pnormand@igalia.com>
  58838. Unreviewed GTK build fix after r79978
  58839. * GNUmakefile.am:
  58840. 2011-03-01 Andras Becsi <abecsi@webkit.org>
  58841. Unreviewed build fix.
  58842. [Qt] Fix minimal build.
  58843. No new tests needed.
  58844. * WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
  58845. 2011-03-01 anthony taranto <anthony.taranto@gmail.com>
  58846. Return undefined value from ScriptController::evaluate(), allowing the
  58847. caller to distinguish between an error and an undefined return value.
  58848. https://bugs.webkit.org/show_bug.cgi?id=51528
  58849. * bindings/v8/ScriptController.cpp:
  58850. 2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
  58851. Reviewed by Kent Tamura.
  58852. Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
  58853. https://bugs.webkit.org/show_bug.cgi?id=54853
  58854. Moving the files from rendering to html/shadow, with the exception of
  58855. the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
  58856. (this place is not ideal, but only a temporary state during the larger refactoring
  58857. for <input>).
  58858. No new tests. (refactoring)
  58859. * Android.mk:
  58860. * CMakeLists.txt:
  58861. * WebCore.gypi:
  58862. * WebCore.pro:
  58863. * WebCore.vcproj/WebCore.vcproj:
  58864. * WebCore.xcodeproj/project.pbxproj:
  58865. * html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
  58866. * html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
  58867. * rendering/RenderTextControlSingleLine.cpp:
  58868. (WebCore::RenderTextControlInnerBlock::positionForPoint):
  58869. * rendering/RenderTextControlSingleLine.h:
  58870. (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
  58871. (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
  58872. * rendering/TextControlInnerElements.cpp: Removed.
  58873. * rendering/TextControlInnerElements.h: Removed.
  58874. 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
  58875. Reviewed by Tony Chang.
  58876. applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
  58877. https://bugs.webkit.org/show_bug.cgi?id=55338
  58878. Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
  58879. Also added a convenience function EditingStyle::setProperty, which lazily instantiates
  58880. new CSSMutableStyleDeclaration for m_mutableStyle.
  58881. * editing/ApplyStyleCommand.cpp:
  58882. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
  58883. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
  58884. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
  58885. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
  58886. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
  58887. * editing/ApplyStyleCommand.h:
  58888. * editing/EditingStyle.cpp:
  58889. (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
  58890. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
  58891. (WebCore::EditingStyle::setProperty): Added. This member function lazily instantiates
  58892. new CSSMutableStyleDeclaration for m_mutableStyle.
  58893. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
  58894. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
  58895. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
  58896. * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
  58897. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
  58898. * editing/InsertTextCommand.cpp: Removed unnecessary includes.
  58899. * editing/RemoveCSSPropertyCommand.h: Ditto.
  58900. 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
  58901. Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
  58902. * WebCore.gyp/WebCore.gyp:
  58903. 2011-02-28 David Levin <levin@chromium.org>
  58904. Reviewed by Darin Adler.
  58905. KURL should expose a referrer property.
  58906. https://bugs.webkit.org/show_bug.cgi?id=55415
  58907. No change in functionality so no new tests.
  58908. * loader/FrameLoader.cpp:
  58909. (WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
  58910. of functionality in KURL::strippedForUseAsReferrer() so that this code can
  58911. be more easily reused.
  58912. * platform/KURL.cpp:
  58913. (WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
  58914. which is suitable for use as a referrer.
  58915. * platform/KURL.h:
  58916. 2011-02-28 Chang Shu <cshu@webkit.org>
  58917. Reviewed by Ryosuke Niwa.
  58918. Remove the support of Frame::isContentEditable and its dependencies.
  58919. https://bugs.webkit.org/show_bug.cgi?id=54292
  58920. Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
  58921. Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
  58922. Editor::clientIsEditable and its client-side implementation can be removed.
  58923. * WebCore.exp.in:
  58924. * accessibility/AccessibilityRenderObject.cpp:
  58925. (WebCore::AccessibilityRenderObject::isReadOnly):
  58926. * editing/Editor.cpp:
  58927. * editing/Editor.h:
  58928. * editing/SelectionController.cpp:
  58929. (WebCore::SelectionController::setSelectionFromNone):
  58930. * html/HTMLElement.cpp:
  58931. (WebCore::HTMLElement::isContentEditable):
  58932. (WebCore::HTMLElement::isContentRichlyEditable):
  58933. * page/DragController.cpp:
  58934. (WebCore::DragController::operationForLoad):
  58935. * page/EditorClient.h:
  58936. * page/Frame.cpp:
  58937. * page/Frame.h:
  58938. 2011-02-28 Kent Tamura <tkent@chromium.org>
  58939. Reviewed by Darin Adler.
  58940. Number type input cannot be set to empty string if it has an initial value
  58941. https://bugs.webkit.org/show_bug.cgi?id=53744
  58942. We need to distinguish null strings and empty strings for
  58943. InputElementData::value. So InputType::sanitizeValue() also needs to
  58944. take care of it.
  58945. * dom/InputElement.h: Add a comment to InputElementData::value and
  58946. setValue about null strings.
  58947. * html/InputType.h: Add a comment to sanitizeValue about null strings.
  58948. * html/NumberInputType.cpp:
  58949. (WebCore::NumberInputType::sanitizeValue): Returns a null string if the
  58950. proposed value is a null string. Returning an empty string if the
  58951. proposed value is not a number.
  58952. 2011-02-28 Kent Tamura <tkent@chromium.org>
  58953. Reviewed by Darin Adler.
  58954. Number type input should not handle mouse wheel events if it has no focus.
  58955. https://bugs.webkit.org/show_bug.cgi?id=53638
  58956. * html/TextFieldInputType.cpp:
  58957. (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().
  58958. 2011-02-28 Noel Gordon <noel.gordon@gmail.com>
  58959. Reviewed by James Robinson.
  58960. [chromium] GradientSkia: use the common Gradient stop sorting methods.
  58961. https://bugs.webkit.org/show_bug.cgi?id=54625
  58962. Remove a FIXME: call the Gradient.cpp stop storting routines, no need
  58963. to duplicate that code herein.
  58964. No change in behavior, so no new tests.
  58965. * platform/graphics/skia/GradientSkia.cpp:
  58966. (WebCore::Gradient::platformGradient):
  58967. 2011-02-28 Steve Block <steveblock@google.com>
  58968. Reviewed by Jeremy Orlow.
  58969. JNI code should include <jni.h> on non-OSX platforms.
  58970. https://bugs.webkit.org/show_bug.cgi?id=55219
  58971. On Mac we need to include <JavaVM/jni.h> as this is a framework
  58972. include. We include jni.h through JNIUtility.h to minimize the
  58973. number of ifdefs.
  58974. No new tests, build fix only.
  58975. * WebCore.xcodeproj/project.pbxproj
  58976. * bridge/jni/JNIUtility.h:
  58977. * bridge/jni/jni_jsobject.h:
  58978. * bridge/jni/jsc/JNIBridgeJSC.h:
  58979. * bridge/jni/jsc/JavaInstanceJSC.h:
  58980. * bridge/jni/v8/JavaInstanceV8.h:
  58981. 2011-02-28 Nebojsa Sabovic <neb@chromium.org>
  58982. Reviewed by James Robinson.
  58983. [chromium] Pepper plugins render upside down
  58984. https://bugs.webkit.org/show_bug.cgi?id=55101
  58985. No layout tests for pepper plugins (yet).
  58986. * platform/graphics/chromium/PluginLayerChromium.h:
  58987. 2011-02-28 Tony Gentilcore <tonyg@chromium.org>
  58988. Reviewed by Adam Barth.
  58989. Follow HTML5 spec for document.open() a little more closely
  58990. https://bugs.webkit.org/show_bug.cgi?id=55392
  58991. See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.
  58992. The second return check matches the spec. The first return check (isExecutingScript())
  58993. was left in place because without it, fast/tokenizer/write-external-script-open.html
  58994. would fail. It also possible there is a spec bug because FF4 crashes on that test and
  58995. IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
  58996. resource is always loading while parser->isParsing().
  58997. Test: fast/parser/double-write-from-closed-iframe.html
  58998. * dom/Document.cpp:
  58999. (WebCore::Document::open):
  59000. 2011-02-28 Avi Drissman <avi@google.com>
  59001. Reviewed by James Robinson.
  59002. WebCursorInfo needs to match enums in platform/Cursor.h
  59003. https://bugs.webkit.org/show_bug.cgi?id=55094
  59004. * platform/chromium/CursorChromium.cpp:
  59005. (WebCore::grabCursor):
  59006. (WebCore::grabbingCursor):
  59007. * platform/chromium/PlatformCursor.h:
  59008. 2011-02-28 Jia Pu <jpu@apple.com>
  59009. Reviewed by Darin Adler.
  59010. [Mac] Make "Change back to …" contextual menu item work with new autocorrection.
  59011. https://bugs.webkit.org/show_bug.cgi?id=55396
  59012. <rdar://problem/8836093>
  59013. The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
  59014. calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
  59015. contextual menu.
  59016. The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
  59017. back to ..." is clicked.
  59018. * editing/Editor.cpp:
  59019. (WebCore::Editor::changeBackToReplacedString):
  59020. * rendering/InlineTextBox.cpp:
  59021. (WebCore::InlineTextBox::paintDocumentMarkers):
  59022. 2011-02-28 Victoria Kirst <vrk@google.com>
  59023. Reviewed by Kenneth Russell.
  59024. [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
  59025. https://bugs.webkit.org/show_bug.cgi?id=55269
  59026. Mesa does not support mapTexSubImage2D, so this change lets
  59027. GPU-accelerated video work with DRT layout tests.
  59028. * platform/graphics/chromium/VideoLayerChromium.cpp:
  59029. (WebCore::VideoLayerChromium::updateTexture):
  59030. 2011-02-28 David Hyatt <hyatt@apple.com>
  59031. Reviewed by Dan Bernstein.
  59032. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text. Change staticX and staticY
  59033. to be staticInlinePosition and staticBlockPosition. Patch all of the computations involving these variables to be writing
  59034. mode aware. Mixed writing modes are not yet supported.
  59035. Added new tests in fast/block/positioning/auto.
  59036. * rendering/RenderBlock.cpp:
  59037. (WebCore::RenderBlock::adjustPositionedBlock):
  59038. (WebCore::RenderBlock::layoutPositionedObjects):
  59039. * rendering/RenderBlock.h:
  59040. (WebCore::RenderBlock::startOffsetForLine):
  59041. * rendering/RenderBlockLineLayout.cpp:
  59042. (WebCore::RenderBlock::appendRunsForObject):
  59043. (WebCore::setStaticPositions):
  59044. (WebCore::RenderBlock::skipTrailingWhitespace):
  59045. (WebCore::RenderBlock::skipLeadingWhitespace):
  59046. (WebCore::RenderBlock::findNextLineBreak):
  59047. * rendering/RenderBox.cpp:
  59048. (WebCore::RenderBox::positionLineBox):
  59049. (WebCore::computeInlineStaticDistance):
  59050. (WebCore::RenderBox::computePositionedLogicalWidth):
  59051. (WebCore::computeBlockStaticDistance):
  59052. (WebCore::RenderBox::computePositionedLogicalHeight):
  59053. (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
  59054. (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
  59055. * rendering/RenderBoxModelObject.h:
  59056. (WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
  59057. (WebCore::RenderBoxModelObject::borderAndPaddingStart):
  59058. (WebCore::RenderBoxModelObject::borderLogicalLeft):
  59059. (WebCore::RenderBoxModelObject::borderLogicalRight):
  59060. * rendering/RenderFlexibleBox.cpp:
  59061. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  59062. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  59063. * rendering/RenderInline.cpp:
  59064. (WebCore::RenderInline::relativePositionedInlineOffset):
  59065. * rendering/RenderLayer.cpp:
  59066. (WebCore::RenderLayer::RenderLayer):
  59067. * rendering/RenderLayer.h:
  59068. (WebCore::RenderLayer::staticInlinePosition):
  59069. (WebCore::RenderLayer::staticBlockPosition):
  59070. (WebCore::RenderLayer::setStaticInlinePosition):
  59071. (WebCore::RenderLayer::setStaticBlockPosition):
  59072. * rendering/style/RenderStyle.h:
  59073. (WebCore::InheritedFlags::hasAutoLeftAndRight):
  59074. (WebCore::InheritedFlags::hasAutoTopAndBottom):
  59075. (WebCore::InheritedFlags::hasStaticInlinePosition):
  59076. (WebCore::InheritedFlags::hasStaticBlockPosition):
  59077. 2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
  59078. Reviewed by Anders Carlsson.
  59079. [Qt][WK2] Plugin initialization
  59080. https://bugs.webkit.org/show_bug.cgi?id=48127
  59081. No function change so no new tests.
  59082. * WebCore.pri: Lift the definition of the XP_UNIX macro
  59083. from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
  59084. 2011-02-28 Dean Jackson <dino@apple.com>
  59085. Reviewed by Eric Carlson.
  59086. https://bugs.webkit.org/show_bug.cgi?id=55239
  59087. Allow webkitEnterFullScreen to be called from outside
  59088. a user gesture, but only when the correct restrictions
  59089. have been lifted in WebCore. Add a new restriction type
  59090. for this situation. Meanwhile, expose the current
  59091. restrictions externally from HTMLMediaElement, so that
  59092. clients can easily set restrictions on their port.
  59093. No new tests. This doesn't change existing behavior. Some
  59094. WebKit clients may lift the restriction.
  59095. * html/HTMLMediaElement.cpp:
  59096. (WebCore::HTMLMediaElement::HTMLMediaElement):
  59097. - ensure restrictions initialize with fullscreen restricted
  59098. * html/HTMLMediaElement.h:
  59099. (WebCore::HTMLMediaElement::requireUserGestureForLoad):
  59100. (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
  59101. (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
  59102. (WebCore::HTMLMediaElement::setBehaviorRestrictions):
  59103. - new methods to expose the current restrictions
  59104. * html/HTMLVideoElement.cpp:
  59105. (WebCore::HTMLVideoElement::webkitEnterFullscreen):
  59106. 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
  59107. Unreviewed, rolling out r78789.
  59108. http://trac.webkit.org/changeset/78789
  59109. https://bugs.webkit.org/show_bug.cgi?id=55409
  59110. Incorrect canvas fallback implementation (Requested by
  59111. inferno-sec on #webkit).
  59112. * accessibility/AccessibilityObject.h:
  59113. * accessibility/AccessibilityRenderObject.cpp:
  59114. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  59115. (WebCore::AccessibilityRenderObject::canHaveChildren):
  59116. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  59117. (atkRole):
  59118. * accessibility/mac/AccessibilityObjectWrapper.mm:
  59119. * html/HTMLFormControlElement.cpp:
  59120. (WebCore::HTMLFormControlElement::isFocusable):
  59121. * rendering/RenderHTMLCanvas.cpp:
  59122. * rendering/RenderHTMLCanvas.h:
  59123. * rendering/RenderObject.cpp:
  59124. (WebCore::RenderObject::repaint):
  59125. * rendering/RenderTreeAsText.cpp:
  59126. (WebCore::write):
  59127. 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
  59128. Unreviewed, rolling out r79425.
  59129. http://trac.webkit.org/changeset/79425
  59130. https://bugs.webkit.org/show_bug.cgi?id=55406
  59131. Incorrect canvas fallback implementation. (Requested by
  59132. inferno-sec on #webkit).
  59133. * rendering/RenderHTMLCanvas.cpp:
  59134. (WebCore::RenderHTMLCanvas::nodeAtPoint):
  59135. 2011-02-28 Adam Klein <adamk@chromium.org>
  59136. Reviewed by Adam Barth.
  59137. [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
  59138. https://bugs.webkit.org/show_bug.cgi?id=54774
  59139. See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
  59140. for the spec implemented by this patch.
  59141. Test: fast/filesystem/resolve-uri.html
  59142. * fileapi/DOMFileSystemBase.cpp:
  59143. (WebCore::DOMFileSystemBase::crackFileSystemURL):
  59144. * fileapi/DOMFileSystemBase.h:
  59145. Added constants for "temporary" and "persistent".
  59146. * fileapi/EntryBase.cpp:
  59147. Replace hardcoded strings with aforementioned constants.
  59148. * fileapi/FileSystemCallbacks.cpp:
  59149. (WebCore::ResolveURICallbacks::create):
  59150. (WebCore::ResolveURICallbacks::ResolveURICallbacks):
  59151. (WebCore::ResolveURICallbacks::didOpenFileSystem):
  59152. Chains a call of openFileSystem to calls to getDirectory/getFile.
  59153. * fileapi/FileSystemCallbacks.h:
  59154. * fileapi/LocalFileSystem.cpp:
  59155. (WebCore::LocalFileSystem::readFileSystem):
  59156. * fileapi/LocalFileSystem.h:
  59157. Remove size argument from readFileSystem()
  59158. * page/DOMWindow.cpp:
  59159. (WebCore::DOMWindow::resolveLocalFileSystemURI):
  59160. * page/DOMWindow.h:
  59161. * page/DOMWindow.idl:
  59162. 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
  59163. Reviewed by Oliver Hunt.
  59164. Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
  59165. * bridge/qt/qt_runtime.cpp:
  59166. (JSC::Bindings::QtConnectionObject::execute):
  59167. 2011-02-25 David Levin <levin@chromium.org>
  59168. Reviewed by Darin Adler.
  59169. Remove some duplicate code from KURLGoogle.cpp
  59170. https://bugs.webkit.org/show_bug.cgi?id=55266
  59171. No change in functionality so no new tests.
  59172. * WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
  59173. * platform/KURL.cpp:
  59174. Simply moved #include's and some code that was identical (i.e.
  59175. had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
  59176. to reduce duplication.
  59177. * platform/KURLGoogle.cpp:
  59178. Removed the duplicate code.
  59179. 2011-02-28 Oliver Hunt <oliver@apple.com>
  59180. Reviewed by Gavin Barraclough.
  59181. Make ScopeChainNode GC allocated
  59182. https://bugs.webkit.org/show_bug.cgi?id=55283
  59183. Update WebCore to deal with the absence of the ScopeChain
  59184. class.
  59185. * ForwardingHeaders/runtime/ScopeChain.h: Added.
  59186. * bindings/js/JSHTMLElementCustom.cpp:
  59187. (WebCore::JSHTMLElement::pushEventHandlerScope):
  59188. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  59189. (WebCore::JSJavaScriptCallFrame::scopeChain):
  59190. (WebCore::JSJavaScriptCallFrame::scopeType):
  59191. * bindings/js/JSLazyEventListener.cpp:
  59192. (WebCore::JSLazyEventListener::initializeJSFunction):
  59193. * bindings/js/JSMainThreadExecState.h:
  59194. (WebCore::JSMainThreadExecState::evaluate):
  59195. * bindings/js/JSNodeCustom.cpp:
  59196. (WebCore::JSNode::pushEventHandlerScope):
  59197. * bindings/js/JavaScriptCallFrame.cpp:
  59198. (WebCore::JavaScriptCallFrame::scopeChain):
  59199. * bindings/js/JavaScriptCallFrame.h:
  59200. * bindings/scripts/CodeGeneratorJS.pm:
  59201. * bridge/c/c_class.cpp:
  59202. * bridge/c/c_runtime.cpp:
  59203. * bridge/jni/JNIBridge.cpp:
  59204. * bridge/qt/qt_runtime.cpp:
  59205. (JSC::Bindings::QtConnectionObject::execute):
  59206. * plugins/PluginViewNone.cpp:
  59207. 2011-02-28 Chang Shu <cshu@webkit.org>
  59208. Reviewed by Adele Peterson.
  59209. REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
  59210. https://bugs.webkit.org/show_bug.cgi?id=55323
  59211. Draw focus ring on selected items only if spatial navigation is enabled.
  59212. Test: fast/forms/select-listbox-multiple-no-focusring.html
  59213. * rendering/RenderBlock.h:
  59214. * rendering/RenderListBox.cpp:
  59215. (WebCore::RenderListBox::addFocusRingRects):
  59216. 2011-02-28 Abhishek Arya <inferno@chromium.org>
  59217. Reviewed by Anders Carlsson.
  59218. We can cancel the plugin load and fail with error before m_manualStream
  59219. got a chance to initialize in PluginView::didReceiveResponse. This can
  59220. happen when we run pending document onload events during plugin load that
  59221. remove the frame from underneath. So, change the assert into a null check.
  59222. https://bugs.webkit.org/show_bug.cgi?id=55307
  59223. * plugins/PluginView.cpp:
  59224. (WebCore::PluginView::didFail):
  59225. 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
  59226. Reviewed by Alexey Proskuryakov.
  59227. Build fix for Intel ICC Compiler.
  59228. https://bugs.webkit.org/show_bug.cgi?id=55221
  59229. The virtual inheritance seems to confuse ICC.
  59230. Anything that links with webkit has an undefined reference otherwise.
  59231. * svg/SVGTransformable.cpp:
  59232. (WebCore::SVGTransformable::~SVGTransformable):
  59233. * svg/SVGTransformable.h:
  59234. 2011-02-28 Sergio Villar Senin <svillar@igalia.com>
  59235. Reviewed by Martin Robinson.
  59236. [Gtk] Resource size is incorrectly reported to WebCore
  59237. https://bugs.webkit.org/show_bug.cgi?id=53228
  59238. When calling didReceiveData we are sending an invalid value for
  59239. lengthReceived. Sometimes we were even passing a boolean value instead of the
  59240. expected integer. We should pass the size of the received data instead of the
  59241. total amount of data received.
  59242. * platform/network/ResourceHandleInternal.h:
  59243. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  59244. * platform/network/soup/ResourceHandleSoup.cpp:
  59245. (WebCore::gotChunkCallback):
  59246. (WebCore::sendRequestCallback):
  59247. (WebCore::readCallback):
  59248. 2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  59249. Reviewed by Dan Bernstein.
  59250. Cleanup the include guard form an Objective-C files
  59251. https://bugs.webkit.org/show_bug.cgi?id=55379
  59252. Normally Objective-C files do not need include guard.
  59253. r76916 introduced an include guard in EmptyProtocolDefinitions.h.
  59254. The guard is no longer needed after r76991.
  59255. No new tests as there is no new functionality.
  59256. * platform/mac/EmptyProtocolDefinitions.h:
  59257. 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
  59258. Reviewed by Pavel Feldman.
  59259. Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
  59260. https://bugs.webkit.org/show_bug.cgi?id=55389
  59261. * inspector/InspectorAgent.cpp:
  59262. (WebCore::InspectorAgent::populateScriptObjects):
  59263. * inspector/InspectorDebuggerAgent.cpp:
  59264. (WebCore::InspectorDebuggerAgent::setFrontend):
  59265. (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
  59266. * inspector/InspectorDebuggerAgent.h:
  59267. 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
  59268. Unreviewed, rolling out r79877.
  59269. http://trac.webkit.org/changeset/79877
  59270. https://bugs.webkit.org/show_bug.cgi?id=55388
  59271. Breaks chromium build (Requested by antonm_ on #webkit).
  59272. * WebCore.gypi:
  59273. * platform/graphics/chromium/ContentLayerChromium.cpp:
  59274. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  59275. (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
  59276. (WebCore::ContentLayerChromium::resizeUploadBuffer):
  59277. (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
  59278. (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
  59279. (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
  59280. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  59281. (WebCore::ContentLayerChromium::draw):
  59282. * platform/graphics/chromium/ContentLayerChromium.h:
  59283. * platform/graphics/chromium/ImageLayerChromium.cpp:
  59284. (WebCore::ImageLayerChromium::updateContentsIfDirty):
  59285. * platform/graphics/chromium/ImageLayerChromium.h:
  59286. * platform/graphics/chromium/LayerTilerChromium.cpp:
  59287. (WebCore::LayerTilerChromium::contentRectToTileIndices):
  59288. (WebCore::LayerTilerChromium::update):
  59289. * platform/graphics/chromium/LayerTilerChromium.h:
  59290. * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
  59291. * platform/graphics/chromium/PlatformCanvas.h: Removed.
  59292. * platform/graphics/chromium/PlatformImage.cpp: Removed.
  59293. * platform/graphics/chromium/PlatformImage.h: Removed.
  59294. 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
  59295. Reviewed by Pavel Feldman.
  59296. Web Inspector: add live edit test.
  59297. https://bugs.webkit.org/show_bug.cgi?id=55360
  59298. Test: inspector/debugger/live-edit.html
  59299. * inspector/front-end/SourceFrame.js:
  59300. (WebInspector.SourceFrame.prototype._doubleClick):
  59301. (WebInspector.SourceFrame.prototype._didEditLine):
  59302. 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
  59303. Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.
  59304. * inspector/InspectorBrowserDebuggerAgent.cpp:
  59305. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  59306. 2011-02-25 Adrienne Walker <enne@google.com>
  59307. Reviewed by James Robinson.
  59308. [chromium] Abstract "pixels with a graphics context" into its own class
  59309. https://bugs.webkit.org/show_bug.cgi?id=55259
  59310. This creates new PlatformCanvas/PlatformImage classes which wrap
  59311. all of the #ifdef Skia/Cg warts from the compositor. All classes
  59312. (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
  59313. modified to use these abstractions.
  59314. Tests: LayoutTests/compositing
  59315. * WebCore.gypi:
  59316. * platform/graphics/chromium/ContentLayerChromium.cpp:
  59317. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  59318. (WebCore::ContentLayerChromium::resizeUploadBuffer):
  59319. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  59320. (WebCore::ContentLayerChromium::updateTexture):
  59321. (WebCore::ContentLayerChromium::draw):
  59322. * platform/graphics/chromium/ContentLayerChromium.h:
  59323. * platform/graphics/chromium/ImageLayerChromium.cpp:
  59324. (WebCore::ImageLayerChromium::updateContentsIfDirty):
  59325. (WebCore::ImageLayerChromium::updateTextureIfNeeded):
  59326. * platform/graphics/chromium/ImageLayerChromium.h:
  59327. * platform/graphics/chromium/LayerTilerChromium.cpp:
  59328. (WebCore::LayerTilerChromium::contentRectToTileIndices):
  59329. (WebCore::LayerTilerChromium::update):
  59330. (WebCore::LayerTilerChromium::updateFromPixels):
  59331. * platform/graphics/chromium/LayerTilerChromium.h:
  59332. * platform/graphics/chromium/PlatformCanvas.cpp: Added.
  59333. (WebCore::PlatformCanvas::PlatformCanvas):
  59334. (WebCore::PlatformCanvas::~PlatformCanvas):
  59335. (WebCore::PlatformCanvas::resize):
  59336. (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
  59337. (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
  59338. (WebCore::PlatformCanvas::Painter::Painter):
  59339. (WebCore::PlatformCanvas::Painter::~Painter):
  59340. * platform/graphics/chromium/PlatformCanvas.h: Added.
  59341. (WebCore::PlatformCanvas::AutoLocker::pixels):
  59342. (WebCore::PlatformCanvas::Painter::context):
  59343. (WebCore::PlatformCanvas::size):
  59344. * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
  59345. (WebCore::PlatformImage::PlatformImage):
  59346. (WebCore::PlatformImage::updateFromImage):
  59347. * platform/graphics/chromium/PlatformImage.h: Added.
  59348. (WebCore::PlatformImage::pixels):
  59349. (WebCore::PlatformImage::size):
  59350. 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
  59351. Unreviewed, rolling out r79784.
  59352. http://trac.webkit.org/changeset/79784
  59353. https://bugs.webkit.org/show_bug.cgi?id=55386
  59354. This change causes lots of assertion failures in Debug builds
  59355. (Requested by aroben on #webkit).
  59356. * css/CSSStyleSelector.cpp:
  59357. (WebCore::convertToLength):
  59358. (WebCore::CSSStyleSelector::applyProperty):
  59359. (WebCore::CSSStyleSelector::createTransformOperations):
  59360. * platform/Length.h:
  59361. (WebCore::Length::Length):
  59362. (WebCore::Length::operator==):
  59363. (WebCore::Length::operator!=):
  59364. (WebCore::Length::rawValue):
  59365. (WebCore::Length::type):
  59366. (WebCore::Length::quirk):
  59367. (WebCore::Length::setValue):
  59368. (WebCore::Length::setRawValue):
  59369. (WebCore::Length::calcFloatValue):
  59370. (WebCore::Length::isZero):
  59371. (WebCore::Length::blend):
  59372. * rendering/AutoTableLayout.cpp:
  59373. (WebCore::AutoTableLayout::recalcColumn):
  59374. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  59375. * rendering/FixedTableLayout.cpp:
  59376. (WebCore::FixedTableLayout::calcWidthArray):
  59377. 2011-02-28 Andreas Kling <kling@webkit.org>
  59378. Reviewed by Darin Adler.
  59379. Use Frame::ownerElement() directly where appropriate.
  59380. https://bugs.webkit.org/show_bug.cgi?id=55385
  59381. Don't take the roundabout way through frame->document->ownerElement
  59382. which just checks that the document->frame is non-null.
  59383. No new test, refactoring only.
  59384. * editing/SelectionController.cpp:
  59385. (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  59386. * loader/FrameLoader.cpp:
  59387. (WebCore::FrameLoader::loadWithDocumentLoader):
  59388. * page/DOMWindow.cpp:
  59389. (WebCore::DOMWindow::dispatchLoadEvent):
  59390. * page/EventHandler.cpp:
  59391. (WebCore::EventHandler::scrollRecursively):
  59392. (WebCore::EventHandler::logicalScrollRecursively):
  59393. * page/FrameView.cpp:
  59394. (WebCore::FrameView::init):
  59395. (WebCore::FrameView::layout):
  59396. (WebCore::FrameView::repaintContentRectangle):
  59397. (WebCore::FrameView::windowClipRect):
  59398. (WebCore::FrameView::paintContents):
  59399. 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
  59400. Reviewed by Pavel Feldman.
  59401. Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
  59402. https://bugs.webkit.org/show_bug.cgi?id=55377
  59403. * inspector/front-end/ScriptsPanel.js:
  59404. (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
  59405. (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
  59406. (WebInspector.ScriptsPanel.prototype._createSourceFrame):
  59407. (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
  59408. 2011-02-28 Patrick Gansterer <paroga@webkit.org>
  59409. Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
  59410. * svg/SVGDocumentExtensions.cpp:
  59411. (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
  59412. 2011-02-28 Renata Hodovan <reni@webkit.org>
  59413. Reviewed by Andreas Kling.
  59414. Optimize parameter transmissions in FEConvolveMatrix.
  59415. https://bugs.webkit.org/show_bug.cgi?id=55381
  59416. Parameter transmission via reference is more efficient than with copy. So they are substituted.
  59417. No new tests are needed since this is a refactoring.
  59418. * platform/graphics/filters/FEConvolveMatrix.cpp:
  59419. (WebCore::FEConvolveMatrix::setKernelSize):
  59420. (WebCore::FEConvolveMatrix::setTargetOffset):
  59421. (WebCore::FEConvolveMatrix::setKernelUnitLength):
  59422. * platform/graphics/filters/FEConvolveMatrix.h:
  59423. 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
  59424. Unreviewed. Fix Chromium tests failures due to r79858.
  59425. * inspector/InspectorAgent.cpp:
  59426. (WebCore::InspectorAgent::inspectedPageDestroyed):
  59427. 2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
  59428. Reviewed by Pavel Feldman.
  59429. XML without style should render as syntax-highlighted source.
  59430. https://bugs.webkit.org/show_bug.cgi?id=13807
  59431. XML tree view mode implemented. If XML does not have any style
  59432. information, it is rendered as highlighted source with collapsable
  59433. elements.
  59434. Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
  59435. fast/encoding/dumpAsText/utf-16-no-bom.xml
  59436. http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
  59437. http/tests/xmlviewer/dumpAsText/frames.html
  59438. http/tests/xmlviewer/dumpAsText/mathml.xml
  59439. http/tests/xmlviewer/dumpAsText/svg.xml
  59440. http/tests/xmlviewer/dumpAsText/wml.xml
  59441. http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
  59442. http/tests/xmlviewer/dumpAsText/xlink.xml
  59443. http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
  59444. http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
  59445. http/tests/xmlviewer/dumpAsText/xmlviewer.xml
  59446. http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
  59447. http/tests/xmlviewer/dumpAsText/xul.xml
  59448. svg/hixie/error/dumpAsText/004.xml
  59449. svg/hixie/error/dumpAsText/005.xml
  59450. * CMakeLists.txt:
  59451. * DerivedSources.make:
  59452. * GNUmakefile.am:
  59453. * WebCore.gyp/WebCore.gyp:
  59454. * WebCore.gypi:
  59455. * WebCore.vcproj/WebCore.vcproj:
  59456. * WebCore.xcodeproj/project.pbxproj:
  59457. * css/CSSStyleSelector.cpp:
  59458. (WebCore::CSSStyleSelector::matchUARules):
  59459. * dom/Document.cpp:
  59460. (WebCore::Document::Document):
  59461. (WebCore::Document::createElement):
  59462. * dom/Document.h:
  59463. (WebCore::Document::usesViewSourceStyles):
  59464. (WebCore::Document::setUsesViewSourceStyles):
  59465. (WebCore::Document::sawElementsInKnownNamespaces):
  59466. * dom/XMLDocumentParser.h:
  59467. * dom/XMLDocumentParserLibxml2.cpp:
  59468. (WebCore::XMLDocumentParser::XMLDocumentParser):
  59469. (WebCore::XMLDocumentParser::processingInstruction):
  59470. (WebCore::XMLDocumentParser::initializeParserContext):
  59471. (WebCore::XMLDocumentParser::doEnd):
  59472. * dom/XMLDocumentParserQt.cpp:
  59473. (WebCore::XMLDocumentParser::XMLDocumentParser):
  59474. (WebCore::XMLDocumentParser::initializeParserContext):
  59475. (WebCore::XMLDocumentParser::parseProcessingInstruction):
  59476. * html/HTMLViewSourceDocument.cpp:
  59477. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  59478. * xml/XMLTreeViewer.cpp: Added.
  59479. (WebCore::XMLTreeViewer::XMLTreeViewer):
  59480. (WebCore::XMLTreeViewer::hasNoStyleInformation):
  59481. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  59482. * xml/XMLTreeViewer.h: Added.
  59483. (WebCore::XMLTreeViewer::~XMLTreeViewer):
  59484. * xml/XMLViewer.xsl: Added.
  59485. * xml/XSLStyleSheet.h:
  59486. (WebCore::XSLStyleSheet::createForXMLTreeViewer):
  59487. 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
  59488. Reviewed by Pavel Feldman.
  59489. Web Inspector: debugger agents should have same livetime as InspectorAgent
  59490. https://bugs.webkit.org/show_bug.cgi?id=55369
  59491. DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
  59492. by the agent. Debugger state is cleared on frontend disconnect.
  59493. * inspector/Inspector.idl:
  59494. * inspector/InspectorAgent.cpp:
  59495. (WebCore::InspectorAgent::InspectorAgent):
  59496. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  59497. (WebCore::InspectorAgent::setFrontend):
  59498. (WebCore::InspectorAgent::disconnectFrontend):
  59499. (WebCore::InspectorAgent::populateScriptObjects):
  59500. (WebCore::InspectorAgent::didCommitLoad):
  59501. (WebCore::InspectorAgent::showScriptsPanel):
  59502. * inspector/InspectorAgent.h:
  59503. * inspector/InspectorBrowserDebuggerAgent.cpp:
  59504. (WebCore::InspectorBrowserDebuggerAgent::create):
  59505. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
  59506. (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
  59507. (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
  59508. (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
  59509. (WebCore::InspectorBrowserDebuggerAgent::disable):
  59510. (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
  59511. (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
  59512. (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
  59513. (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
  59514. (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
  59515. (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
  59516. (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
  59517. (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
  59518. (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
  59519. (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  59520. (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
  59521. (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  59522. (WebCore::InspectorBrowserDebuggerAgent::clear):
  59523. * inspector/InspectorBrowserDebuggerAgent.h:
  59524. * inspector/InspectorController.cpp:
  59525. (WebCore::InspectorController::debuggerEnabled):
  59526. (WebCore::InspectorController::showAndEnableDebugger):
  59527. (WebCore::InspectorController::disableDebugger):
  59528. * inspector/InspectorDebuggerAgent.cpp:
  59529. (WebCore::InspectorDebuggerAgent::create):
  59530. (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
  59531. (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
  59532. (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
  59533. (WebCore::InspectorDebuggerAgent::enable):
  59534. (WebCore::InspectorDebuggerAgent::disable):
  59535. (WebCore::InspectorDebuggerAgent::enabled):
  59536. (WebCore::InspectorDebuggerAgent::restore):
  59537. (WebCore::InspectorDebuggerAgent::setFrontend):
  59538. (WebCore::InspectorDebuggerAgent::clearFrontend):
  59539. (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
  59540. (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
  59541. (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  59542. (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
  59543. (WebCore::InspectorDebuggerAgent::currentCallFrames):
  59544. (WebCore::InspectorDebuggerAgent::didParseSource):
  59545. (WebCore::InspectorDebuggerAgent::clear):
  59546. * inspector/InspectorDebuggerAgent.h:
  59547. (WebCore::InspectorDebuggerAgent::enable):
  59548. (WebCore::InspectorDebuggerAgent::disable):
  59549. (WebCore::InspectorDebuggerAgent::Listener::~Listener):
  59550. (WebCore::InspectorDebuggerAgent::setListener):
  59551. * inspector/InspectorInstrumentation.cpp:
  59552. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
  59553. (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
  59554. (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
  59555. (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
  59556. (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
  59557. (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
  59558. (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  59559. * inspector/front-end/DebuggerModel.js:
  59560. (WebInspector.DebuggerModel.prototype.enableDebugger):
  59561. (WebInspector.DebuggerModel.prototype.disableDebugger):
  59562. 2011-02-28 Renata Hodovan <reni@webkit.org>
  59563. Reviewed by Andreas Kling.
  59564. FECompositeElement changes doesn't require relayout.
  59565. https://bugs.webkit.org/show_bug.cgi?id=55367
  59566. When the FECompositeElement receives an update message but the given value remains the same we don't need
  59567. to relayout the filter.
  59568. No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.
  59569. * platform/graphics/filters/FEComposite.cpp:
  59570. (WebCore::FEComposite::setOperation):
  59571. (WebCore::FEComposite::setK1):
  59572. (WebCore::FEComposite::setK2):
  59573. (WebCore::FEComposite::setK3):
  59574. (WebCore::FEComposite::setK4):
  59575. * platform/graphics/filters/FEComposite.h:
  59576. * svg/SVGFECompositeElement.cpp:
  59577. (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
  59578. (WebCore::SVGFECompositeElement::svgAttributeChanged):
  59579. * svg/SVGFECompositeElement.h:
  59580. 2011-02-28 Andreas Kling <kling@webkit.org>
  59581. Reviewed by Kenneth Rohde Christiansen.
  59582. FrameLoader: Reorder early-returns in checkCompleted()
  59583. https://bugs.webkit.org/show_bug.cgi?id=55366
  59584. Check allChildrenAreComplete() last, since it's the most expensive.
  59585. * loader/FrameLoader.cpp:
  59586. (WebCore::FrameLoader::checkCompleted):
  59587. 2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
  59588. Reviewed by Kent Tamura.
  59589. Range::processContents needs cleanup
  59590. https://bugs.webkit.org/show_bug.cgi?id=51006
  59591. Refactored Range::processContents. Extracted childOfCommonRootBeforeOffset from processContents
  59592. which is used to find processStart and processEnd respectively. In the case of processStart,
  59593. we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
  59594. the common root because copying m_start's ancestors will result in processing too much contents.
  59595. Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
  59596. In addition, lengthOfContentsInNode was modified to return the correct length instead of
  59597. numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
  59598. corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
  59599. having two switch statements that need to be consistent.
  59600. Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
  59601. LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
  59602. other ports.
  59603. * dom/Range.cpp:
  59604. (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
  59605. (WebCore::lengthOfContentsInNode): Added.
  59606. (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
  59607. and processNodes.
  59608. (WebCore::deleteCharacterData): Added.
  59609. (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
  59610. (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
  59611. (WebCore::Range::processAncestorsAndTheirSiblings):
  59612. * dom/Range.h:
  59613. 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
  59614. Not reviewed. Test harness change follow up.
  59615. Consider missing localized string a warning, not an error in the front-end.
  59616. * inspector/front-end/inspector.js:
  59617. (WebInspector.UIString):
  59618. 2011-02-28 Steve Block <steveblock@google.com>
  59619. Reviewed by Jeremy Orlow.
  59620. getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
  59621. https://bugs.webkit.org/show_bug.cgi?id=55218
  59622. AttachCurrentThread() in Android's JVM takes a JINEnv**
  59623. argument.
  59624. No new tests, build fix only.
  59625. * bridge/jni/JNIUtility.cpp:
  59626. (JSC::Bindings::getJNIEnv):
  59627. 2011-02-28 Renata Hodovan <reni@webkit.org>
  59628. Reviewed by Andreas Kling.
  59629. FETurbulenceElement changes doesn't require relayout
  59630. https://bugs.webkit.org/show_bug.cgi?id=55141
  59631. When the FETurbulenceElement receives an update message but the given value remains the same we don't need
  59632. to relayout the filter.
  59633. Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
  59634. to int according to the spec.
  59635. No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.
  59636. * platform/graphics/filters/FETurbulence.cpp:
  59637. (WebCore::FETurbulence::FETurbulence):
  59638. (WebCore::FETurbulence::create):
  59639. (WebCore::FETurbulence::type):
  59640. (WebCore::FETurbulence::setType):
  59641. (WebCore::FETurbulence::setBaseFrequencyY):
  59642. (WebCore::FETurbulence::setBaseFrequencyX):
  59643. (WebCore::FETurbulence::setSeed):
  59644. (WebCore::FETurbulence::setNumOctaves):
  59645. (WebCore::FETurbulence::setStitchTiles):
  59646. (WebCore::operator<<):
  59647. * platform/graphics/filters/FETurbulence.h:
  59648. * svg/SVGFETurbulenceElement.cpp:
  59649. (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
  59650. (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
  59651. (WebCore::SVGFETurbulenceElement::build):
  59652. * svg/SVGFETurbulenceElement.h:
  59653. 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
  59654. Reviewed by Yury Semikhatsky.
  59655. WebInspector: InspectorAgent calls offsetWidth in the middle of painting
  59656. https://bugs.webkit.org/show_bug.cgi?id=54597
  59657. * inspector/InspectorAgent.cpp:
  59658. (WebCore::InspectorAgent::drawElementTitle):
  59659. 2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
  59660. Reviewed by Kent Tamura.
  59661. Bug 55355 - TextIterator should not be a friend of RenderTextControl
  59662. https://bugs.webkit.org/show_bug.cgi?id=55355
  59663. Remove need for 'friend' clause by making innerTextElement() public.
  59664. No new tests. (simple refactoring)
  59665. * rendering/RenderTextControl.h:
  59666. 2011-02-27 Patrick Gansterer <paroga@webkit.org>
  59667. Reviewed by Darin Adler.
  59668. Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
  59669. https://bugs.webkit.org/show_bug.cgi?id=55317
  59670. This functions are obsolete, since r78499 added TextCodecUTF8.
  59671. Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.
  59672. * platform/text/TextEncodingRegistry.cpp:
  59673. (WebCore::buildBaseTextCodecMaps):
  59674. * platform/text/wince/TextCodecWinCE.cpp:
  59675. * platform/text/wince/TextCodecWinCE.h:
  59676. 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
  59677. Reviewed by Sam Weinig.
  59678. Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
  59679. https://bugs.webkit.org/show_bug.cgi?id=55327
  59680. Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
  59681. to release the memory manually.
  59682. * rendering/RenderBlock.cpp:
  59683. (WebCore::RenderBlock::~RenderBlock):
  59684. (WebCore::RenderBlock::selectionGaps):
  59685. (WebCore::RenderBlock::insertPositionedObject):
  59686. (WebCore::RenderBlock::insertFloatingObject):
  59687. (WebCore::RenderBlock::addOverhangingFloats):
  59688. (WebCore::RenderBlock::addIntrudingFloats):
  59689. * rendering/RenderBlock.h:
  59690. (WebCore::RenderBlock::positionedObjects):
  59691. 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
  59692. Reviewed by Andreas Kling.
  59693. Eliminate DeprecatedPtrList
  59694. https://bugs.webkit.org/show_bug.cgi?id=17425
  59695. Remove the implementation of DeprecatedPtrList and all its references
  59696. from the build systems.
  59697. * Android.mk:
  59698. * CMakeLists.txt:
  59699. * GNUmakefile.am:
  59700. * WebCore.gypi:
  59701. * WebCore.order:
  59702. * WebCore.pro:
  59703. * WebCore.vcproj/WebCore.vcproj:
  59704. * WebCore.xcodeproj/project.pbxproj:
  59705. * platform/DeprecatedPtrList.h: Removed.
  59706. * platform/DeprecatedPtrListImpl.cpp: Removed.
  59707. * platform/DeprecatedPtrListImpl.h: Removed.
  59708. 2011-02-27 Andreas Kling <kling@webkit.org>
  59709. Reviewed by Kenneth Rohde Christiansen.
  59710. [Qt] Use WTF ref counting for FontPlatformDataPrivate
  59711. https://bugs.webkit.org/show_bug.cgi?id=55303
  59712. Make FontPlatformDataPrivate a RefCounted<FPDP>.
  59713. Incidentally fixes an uninitialized member bug in FontPlatformData().
  59714. * platform/graphics/qt/FontPlatformData.h:
  59715. (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
  59716. (WebCore::FontPlatformData::FontPlatformData):
  59717. (WebCore::FontPlatformData::isHashTableDeletedValue):
  59718. (WebCore::FontPlatformData::font):
  59719. (WebCore::FontPlatformData::size):
  59720. (WebCore::FontPlatformData::family):
  59721. (WebCore::FontPlatformData::bold):
  59722. (WebCore::FontPlatformData::italic):
  59723. (WebCore::FontPlatformData::smallCaps):
  59724. (WebCore::FontPlatformData::pixelSize):
  59725. * platform/graphics/qt/FontPlatformDataQt.cpp:
  59726. (WebCore::toQFontWeight):
  59727. (WebCore::FontPlatformData::operator==):
  59728. (WebCore::FontPlatformData::hash):
  59729. 2011-02-27 Benjamin Poulain <ikipou@gmail.com>
  59730. Reviewed by Darin Adler.
  59731. Eliminate DeprecatedPtrList from RenderBlock
  59732. https://bugs.webkit.org/show_bug.cgi?id=54972
  59733. Refactor RenderBlock to get rid of the DeprecatedPtrList.
  59734. The floating objects are stored in a ListHashSet.
  59735. Refactoring covered by existing test.
  59736. * rendering/RenderBlock.cpp:
  59737. (WebCore::RenderBlock::~RenderBlock):
  59738. (WebCore::RenderBlock::addOverflowFromFloats):
  59739. (WebCore::RenderBlock::repaintOverhangingFloats):
  59740. (WebCore::RenderBlock::paintFloats):
  59741. (WebCore::RenderBlock::selectionGaps):
  59742. (WebCore::RenderBlock::insertFloatingObject):
  59743. (WebCore::RenderBlock::removeFloatingObject):
  59744. (WebCore::RenderBlock::removeFloatingObjectsBelow):
  59745. (WebCore::RenderBlock::positionNewFloats):
  59746. (WebCore::RenderBlock::positionNewFloatOnLine):
  59747. (WebCore::RenderBlock::logicalLeftOffsetForLine):
  59748. (WebCore::RenderBlock::logicalRightOffsetForLine):
  59749. (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
  59750. (WebCore::RenderBlock::lowestFloatLogicalBottom):
  59751. (WebCore::RenderBlock::clearFloats):
  59752. (WebCore::RenderBlock::addOverhangingFloats):
  59753. (WebCore::RenderBlock::addIntrudingFloats):
  59754. (WebCore::RenderBlock::containsFloat):
  59755. (WebCore::RenderBlock::hitTestFloats):
  59756. (WebCore::RenderBlock::adjustForBorderFit):
  59757. * rendering/RenderBlock.h:
  59758. (WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
  59759. (WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
  59760. (WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
  59761. (WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
  59762. * rendering/RenderBlockLineLayout.cpp:
  59763. (WebCore::RenderBlock::layoutInlineChildren):
  59764. (WebCore::RenderBlock::matchedEndLine):
  59765. 2011-02-26 Adam Barth <abarth@webkit.org>
  59766. Reviewed by Eric Seidel.
  59767. <input value="type=submit"> throws a warning (“HTML parse error”)
  59768. https://bugs.webkit.org/show_bug.cgi?id=55120
  59769. This patch removes parse error messages from the HTML parser. These
  59770. messages are displayed at the wrong times, aren't tested, and aren't
  59771. helpful. We'll try again with some more informative messages and
  59772. better testing.
  59773. * html/parser/HTMLTreeBuilder.cpp:
  59774. (WebCore::HTMLTreeBuilder::parseError):
  59775. 2011-02-26 Patrick Gansterer <paroga@webkit.org>
  59776. Reviewed by Alexey Proskuryakov.
  59777. Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
  59778. https://bugs.webkit.org/show_bug.cgi?id=55309
  59779. This functions are obsolete, since r78499 added TextCodecUTF8.
  59780. * platform/text/TextEncodingRegistry.cpp:
  59781. (WebCore::buildBaseTextCodecMaps):
  59782. * platform/text/brew/TextCodecBrew.cpp:
  59783. * platform/text/brew/TextCodecBrew.h:
  59784. 2011-02-26 Justin Schuh <jschuh@chromium.org>
  59785. Reviewed by Darin Adler.
  59786. Delay firing of mutation events while setting attribute values
  59787. https://bugs.webkit.org/show_bug.cgi?id=55199
  59788. Test: fast/dom/attribute-change-on-mutate.html
  59789. * dom/Attr.cpp:
  59790. (WebCore::Attr::setValue):
  59791. 2011-02-26 Yi Shen <yi.4.shen@nokia.com>
  59792. Reviewed by Andreas Kling.
  59793. [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
  59794. https://bugs.webkit.org/show_bug.cgi?id=55252
  59795. Need to invoke a callback function to notify the HTMLMediaElement
  59796. when MediaPlayerPrivateQt's playback state gets changed.
  59797. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  59798. (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
  59799. (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
  59800. (WebCore::MediaPlayerPrivateQt::stateChanged):
  59801. * platform/graphics/qt/MediaPlayerPrivateQt.h:
  59802. 2011-02-25 Abhishek Arya <inferno@chromium.org>
  59803. Reviewed by Adam Barth.
  59804. When plugin document parser finishes parsing, it runs the raw
  59805. document's parser finish functions which call the pending document
  59806. onload events that removes the frame from underneath. So, we protect
  59807. frame (and hence frameloader) in DocumentLoader::commitLoad.
  59808. https://bugs.webkit.org/show_bug.cgi?id=55289
  59809. Test: fast/frames/iframe-plugin-load-remove-document-crash.html
  59810. * loader/DocumentLoader.cpp:
  59811. (WebCore::DocumentLoader::commitLoad):
  59812. 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
  59813. Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
  59814. 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
  59815. Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
  59816. https://bugs.webkit.org/show_bug.cgi?id=55302
  59817. * CMakeLists.txt:
  59818. 2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
  59819. Reviewed by Pavel Feldman.
  59820. XML without style should render as syntax-highlighted source.
  59821. https://bugs.webkit.org/show_bug.cgi?id=13807
  59822. XML tree view mode implemented. If XML does not have any style
  59823. information, it is rendered as highlighted source with collapsable
  59824. elements.
  59825. Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
  59826. http/tests/xmlviewer/dumpAsText/frames.html
  59827. http/tests/xmlviewer/dumpAsText/mathml.xml
  59828. http/tests/xmlviewer/dumpAsText/svg.xml
  59829. http/tests/xmlviewer/dumpAsText/wml.xml
  59830. http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
  59831. http/tests/xmlviewer/dumpAsText/xlink.xml
  59832. http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
  59833. http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
  59834. http/tests/xmlviewer/dumpAsText/xmlviewer.xml
  59835. http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
  59836. http/tests/xmlviewer/dumpAsText/xul.xml
  59837. * CMakeLists.txt:
  59838. * DerivedSources.make:
  59839. * GNUmakefile.am:
  59840. * WebCore.gyp/WebCore.gyp:
  59841. * WebCore.gypi:
  59842. * WebCore.vcproj/WebCore.vcproj:
  59843. * WebCore.xcodeproj/project.pbxproj:
  59844. * css/CSSStyleSelector.cpp:
  59845. (WebCore::CSSStyleSelector::matchUARules):
  59846. * dom/Document.cpp:
  59847. (WebCore::Document::Document):
  59848. (WebCore::Document::createElement):
  59849. * dom/Document.h:
  59850. (WebCore::Document::usesViewSourceStyles):
  59851. (WebCore::Document::setUsesViewSourceStyles):
  59852. (WebCore::Document::sawElementsInKnownNamespaces):
  59853. * dom/XMLDocumentParser.h:
  59854. * dom/XMLDocumentParserLibxml2.cpp:
  59855. (WebCore::XMLDocumentParser::XMLDocumentParser):
  59856. (WebCore::XMLDocumentParser::processingInstruction):
  59857. (WebCore::XMLDocumentParser::initializeParserContext):
  59858. (WebCore::XMLDocumentParser::doEnd):
  59859. * dom/XMLDocumentParserQt.cpp:
  59860. (WebCore::XMLDocumentParser::XMLDocumentParser):
  59861. (WebCore::XMLDocumentParser::initializeParserContext):
  59862. (WebCore::XMLDocumentParser::parseProcessingInstruction):
  59863. * html/HTMLViewSourceDocument.cpp:
  59864. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  59865. * xml/XMLTreeViewer.cpp: Added.
  59866. (WebCore::XMLTreeViewer::XMLTreeViewer):
  59867. (WebCore::XMLTreeViewer::hasNoStyleInformation):
  59868. (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  59869. * xml/XMLTreeViewer.h: Added.
  59870. (WebCore::XMLTreeViewer::~XMLTreeViewer):
  59871. * xml/XMLViewer.xsl: Added.
  59872. * xml/XSLStyleSheet.h:
  59873. (WebCore::XSLStyleSheet::createFromString):
  59874. 2011-02-26 Andreas Kling <kling@webkit.org>
  59875. Reviewed by Kenneth Rohde Christiansen.
  59876. [Qt] Enable usage of synchronous HTTP feature in Qt
  59877. https://bugs.webkit.org/show_bug.cgi?id=37191
  59878. Currently, we spin an event loop when doing synchronous calls to
  59879. wait for completion. This patch uses synchronous requests in Qt,
  59880. if available, and spins the event loop as a fallback solution.
  59881. Based on work by Simon Hausmann and Peter Hartmann.
  59882. * platform/network/qt/QNetworkReplyHandler.cpp:
  59883. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  59884. (WebCore::QNetworkReplyHandler::start):
  59885. * platform/network/qt/QNetworkReplyHandler.h:
  59886. * platform/network/qt/ResourceHandleQt.cpp:
  59887. (WebCore::WebCoreSynchronousLoader::setReplyFinished):
  59888. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  59889. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  59890. (WebCore::WebCoreSynchronousLoader::didFail):
  59891. (WebCore::ResourceHandle::loadResourceSynchronously):
  59892. 2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
  59893. Reviewed by Kent Tamura.
  59894. REGRESSION(r79398): Webkit crash on dojo theme tester page
  59895. https://bugs.webkit.org/show_bug.cgi?id=55290
  59896. The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
  59897. of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.
  59898. Test: editing/execCommand/value-without-selection-crash.html
  59899. * editing/Editor.cpp:
  59900. (WebCore::Editor::selectionStartCSSPropertyValue):
  59901. 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
  59902. Reviewed by Pavel Feldman.
  59903. DumpRenderTree should reset frame opener between tests.
  59904. https://bugs.webkit.org/show_bug.cgi?id=54874
  59905. No new tests. (no code affected, just exporting a method for DumpRenderTree use)
  59906. * WebCore.exp.in:
  59907. 2011-02-26 Jia Pu <jpu@apple.com>
  59908. Reviewed by Dan Bernstein.
  59909. On Mac, need to remove misspell underline in Editor::learnSpelling().
  59910. https://bugs.webkit.org/show_bug.cgi?id=55251
  59911. This change makes sure that the misspelling markers are removed after the word is learned.
  59912. * editing/Editor.cpp:
  59913. (WebCore::Editor::learnSpelling):
  59914. 2011-02-26 Rik Cabanier <cabanier@adobe.com>
  59915. Reviewed by David Hyatt.
  59916. Fix that allows fixed length values to be floating point
  59917. https://bugs.webkit.org/show_bug.cgi?id=52699
  59918. Transitions now return matrices in floating point. 2 of the transition tests were failing
  59919. because they expected integer values.
  59920. * WebCore.xcodeproj/project.pbxproj:
  59921. * css/CSSStyleSelector.cpp:
  59922. (WebCore::convertToLength):
  59923. (WebCore::convertToIntLength):
  59924. (WebCore::convertToFloatLength):
  59925. (WebCore::CSSStyleSelector::applyProperty):
  59926. (WebCore::CSSStyleSelector::createTransformOperations):
  59927. * platform/Length.h:
  59928. (WebCore::Length::Length):
  59929. (WebCore::Length::operator==):
  59930. (WebCore::Length::operator!=):
  59931. (WebCore::Length::rawValue):
  59932. (WebCore::Length::type):
  59933. (WebCore::Length::quirk):
  59934. (WebCore::Length::setValue):
  59935. (WebCore::Length::calcFloatValue):
  59936. (WebCore::Length::isZero):
  59937. (WebCore::Length::blend):
  59938. (WebCore::Length::getIntValue):
  59939. (WebCore::Length::getFloatValue):
  59940. * rendering/AutoTableLayout.cpp:
  59941. (WebCore::AutoTableLayout::recalcColumn):
  59942. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  59943. * rendering/FixedTableLayout.cpp:
  59944. (WebCore::FixedTableLayout::calcWidthArray):
  59945. 2011-02-26 Eric Seidel <eric@webkit.org>
  59946. Reviewed by Maciej Stachowiak.
  59947. malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
  59948. https://bugs.webkit.org/show_bug.cgi?id=55204
  59949. * dom/ContainerNode.cpp:
  59950. (WebCore::ContainerNode::removeChildren):
  59951. - Using an inlineCapacity of 10 for now. We may want to tweak it later.
  59952. - This removes yet another malloc from code which removes nodes (which is rather common).
  59953. 2011-02-26 Eric Seidel <eric@webkit.org>
  59954. Reviewed by Maciej Stachowiak.
  59955. HashSet<T>::end() creation is expensive and should be avoided
  59956. https://bugs.webkit.org/show_bug.cgi?id=55205
  59957. In the common case, m_ranges is an empty set. When that's
  59958. the case, we spend all our time in skipEmptyBuckets, walking
  59959. the hash storage skipping over empty buckets.
  59960. This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.
  59961. Before:
  59962. avg 383.6666666666667
  59963. median 386
  59964. stdev 7.152311203768722
  59965. min 360
  59966. max 391
  59967. After:
  59968. avg 366.3333333333333
  59969. median 366
  59970. stdev 2.712112747574399
  59971. min 362
  59972. max 377
  59973. * dom/Document.cpp:
  59974. (WebCore::Document::nodeChildrenChanged):
  59975. (WebCore::Document::nodeChildrenWillBeRemoved):
  59976. (WebCore::Document::nodeWillBeRemoved):
  59977. (WebCore::Document::textInserted):
  59978. (WebCore::Document::textRemoved):
  59979. (WebCore::Document::textNodesMerged):
  59980. (WebCore::Document::textNodeSplit):
  59981. 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
  59982. Unreviewed, rolling out r79764.
  59983. http://trac.webkit.org/changeset/79764
  59984. https://bugs.webkit.org/show_bug.cgi?id=55295
  59985. "broke Chromium builds" (Requested by rniwa on #webkit).
  59986. * WebCore.exp.in:
  59987. 2011-02-26 Adam Klein <adamk@chromium.org>
  59988. Reviewed by Adam Barth.
  59989. [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
  59990. https://bugs.webkit.org/show_bug.cgi?id=54585
  59991. In order to move toURI to EntryBase, it needed access to
  59992. SecurityOrigin. Most of the changes below were to pass a
  59993. ScriptExecutionContext to DOMFileSystemBase to enable this.
  59994. Test: fast/filesystem/workers/file-entry-to-uri-sync.html
  59995. * WebCore.gypi:
  59996. * WebCore.xcodeproj/project.pbxproj:
  59997. * fileapi/DOMFileSystem.cpp:
  59998. (WebCore::DOMFileSystem::DOMFileSystem):
  59999. * fileapi/DOMFileSystemBase.cpp:
  60000. (WebCore::DOMFileSystemBase::DOMFileSystemBase):
  60001. (WebCore::DOMFileSystemBase::securityOrigin):
  60002. * fileapi/DOMFileSystemBase.h:
  60003. (WebCore::DOMFileSystemBase::create):
  60004. * fileapi/DOMFileSystemSync.cpp:
  60005. (WebCore::DOMFileSystemSync::create):
  60006. (WebCore::DOMFileSystemSync::DOMFileSystemSync):
  60007. * fileapi/DOMFileSystemSync.h:
  60008. (WebCore::DOMFileSystemSync::create):
  60009. * fileapi/Entry.cpp:
  60010. * fileapi/Entry.h:
  60011. * fileapi/EntryBase.cpp: Added.
  60012. (WebCore::EntryBase::EntryBase):
  60013. (WebCore::EntryBase::~EntryBase):
  60014. (WebCore::EntryBase::toURI):
  60015. * fileapi/EntryBase.h:
  60016. * fileapi/EntrySync.idl:
  60017. 2011-02-26 Alice Boxhall <aboxhall@chromium.org>
  60018. Reviewed by Ojan Vafai.
  60019. typing enter in the input element should not fire textInput
  60020. https://bugs.webkit.org/show_bug.cgi?id=54152
  60021. Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.
  60022. Test: fast/forms/textinput-not-fired-on-enter-in-input.html
  60023. * html/HTMLInputElement.cpp:
  60024. (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
  60025. 2011-02-26 James Simonsen <simonjam@chromium.org>
  60026. Reviewed by Tony Gentilcore.
  60027. [Web Timing] loadEvent timing should refer to first load event if there are many
  60028. https://bugs.webkit.org/show_bug.cgi?id=55201
  60029. Test: fast/dom/webtiming-document-open.html
  60030. * page/DOMWindow.cpp:
  60031. (WebCore::DOMWindow::dispatchLoadEvent):
  60032. 2011-02-26 Tony Gentilcore <tonyg@chromium.org>
  60033. Reviewed by Adam Barth.
  60034. Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
  60035. https://bugs.webkit.org/show_bug.cgi?id=54810
  60036. No new tests because no new functionality.
  60037. * dom/Document.cpp:
  60038. (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
  60039. minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
  60040. broken by r52919. The effect would be that ports that set an extra layout delay can't yield
  60041. between tokens. Note: can't be const because minimumLayoutDelay sets a member.
  60042. * dom/Document.h:
  60043. * html/parser/HTMLParserScheduler.cpp:
  60044. (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
  60045. (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
  60046. 2011-02-26 David Dorwin <ddorwin@chromium.org>
  60047. Reviewed by Darin Fisher.
  60048. Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
  60049. fullscreen javascript bindings not implemented for v8
  60050. https://bugs.webkit.org/show_bug.cgi?id=44797
  60051. Tested by the existing fullscreen Layout Tests.
  60052. * WebCore.gyp/WebCore.gyp:
  60053. * WebCore.gypi:
  60054. 2011-02-26 Tony Gentilcore <tonyg@chromium.org>
  60055. Reviewed by Adam Barth.
  60056. Prevent parser yields from triggering early dumpAsText()
  60057. https://bugs.webkit.org/show_bug.cgi?id=55187
  60058. DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
  60059. indicates the page is done. isLoadingInAPISense depends on
  60060. HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
  60061. insert() or append().
  60062. This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
  60063. resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
  60064. fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
  60065. incrementing it in pumpTokenizer().
  60066. When I locally cause the parser to yield after every token, a lot of tests fail
  60067. because DRT snapshots too early. This patch fixes those tests, however I'm having
  60068. trouble writing a test case that reliably reproduces the problem without this patch
  60069. and passes with it (without changing yield constants). This is because it requires
  60070. 4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
  60071. doesn't always happen).
  60072. * html/parser/HTMLDocumentParser.cpp:
  60073. (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  60074. (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
  60075. (WebCore::HTMLDocumentParser::processingData):
  60076. (WebCore::HTMLDocumentParser::pumpTokenizer):
  60077. (WebCore::HTMLDocumentParser::insert):
  60078. (WebCore::HTMLDocumentParser::append):
  60079. * html/parser/HTMLDocumentParser.h:
  60080. (WebCore::HTMLDocumentParser::inPumpSession):
  60081. (WebCore::HTMLDocumentParser::shouldDelayEnd):
  60082. * html/parser/HTMLParserScheduler.h:
  60083. (WebCore::PumpSession::PumpSession):
  60084. * html/parser/NestingLevelIncrementer.h:
  60085. 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
  60086. Reviewed by David Kilzer.
  60087. https://bugs.webkit.org/show_bug.cgi?id=48781
  60088. Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
  60089. Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
  60090. should paint the default broken image when an image fails to load or decode. The method also passes the
  60091. URL of the failed image.
  60092. Test: fast/images/support-broken-image-delegate.html
  60093. * loader/FrameLoaderClient.h:
  60094. (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
  60095. * loader/cache/CachedImage.cpp:
  60096. (WebCore::CachedImage::CachedImage):
  60097. (WebCore::CachedImage::image):
  60098. (WebCore::CachedImage::checkShouldPaintBrokenImage):
  60099. (WebCore::CachedImage::error):
  60100. * loader/cache/CachedImage.h:
  60101. 2011-02-26 Chris Evans <cevans@chromium.org>
  60102. Reviewed by Adam Barth.
  60103. Database: Data race: should only touch the transaction queue inside the
  60104. lock.
  60105. https://bugs.webkit.org/show_bug.cgi?id=55031
  60106. * storage/Database.cpp:
  60107. (WebCore::Database::changeVersion): only touch queue inside lock.
  60108. (WebCore::Database::runTransaction): only touch queue inside lock.
  60109. 2011-02-26 Yi Shen <yi.4.shen@nokia.com>
  60110. Reviewed by Eric Carlson.
  60111. Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
  60112. https://bugs.webkit.org/show_bug.cgi?id=55147
  60113. When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
  60114. a volumechangeEvent event should be fired if the volume gets changed.
  60115. Test: media/event-attributes.html
  60116. * html/HTMLMediaElement.cpp:
  60117. (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
  60118. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
  60119. 2011-02-26 Eric Seidel <eric@webkit.org>
  60120. Reviewed by Maciej Stachowiak.
  60121. disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
  60122. https://bugs.webkit.org/show_bug.cgi?id=55127
  60123. Before:
  60124. avg 513.4
  60125. median 515
  60126. stdev 7.234638899074368
  60127. min 490
  60128. max 528
  60129. After:
  60130. avg 508.15
  60131. median 510
  60132. stdev 6.966168243733426
  60133. min 485
  60134. max 515
  60135. Yes, the stdev is a bit high to actually support my conclusions. But looking
  60136. at the profile, this change makes a lot of sense. I'll up the iterations
  60137. for future testing.
  60138. * dom/Document.cpp:
  60139. (WebCore::disableRangeMutation):
  60140. - This check should only be compiled in if we're planning to run on Tiger or Leopard.
  60141. 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
  60142. Reviewed by Pavel Feldman.
  60143. DumpRenderTree should reset frame opener between tests.
  60144. https://bugs.webkit.org/show_bug.cgi?id=54874
  60145. No new tests. (no code affected, just exporting a method for DumpRenderTree use)
  60146. * WebCore.exp.in:
  60147. 2011-02-26 Chang Shu <chang.shu@nokia.com>
  60148. Reviewed by Antonio Gomes.
  60149. Based on patch by Carlos Garcia Campos <cgarcia@igalia.com>.
  60150. Spatial Navigation: Add support for <select> element in multiple selection mode
  60151. https://bugs.webkit.org/show_bug.cgi?id=49261
  60152. When spatial navigation is enabled, use space key to toggle select
  60153. items. And the up and down keys should not affect selection but just
  60154. navigate through items, which is indicated visually by a focus ring.
  60155. New Test: fast/spatial-navigation/snav-single-select-list.html
  60156. Enhanced Test: fast/spatial-navigation/snav-multiple-select.html
  60157. * dom/SelectElement.cpp:
  60158. (WebCore::SelectElement::listBoxDefaultEventHandler):
  60159. * rendering/RenderListBox.cpp:
  60160. (WebCore::RenderListBox::addFocusRingRects):
  60161. * rendering/RenderListBox.h:
  60162. 2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
  60163. Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
  60164. * editing/EditingStyle.cpp:
  60165. 2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
  60166. Reviewed by Darin Adler.
  60167. Move HTMLEquivalent and its subclasses to EditingStyle
  60168. https://bugs.webkit.org/show_bug.cgi?id=55207
  60169. Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
  60170. and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
  60171. and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
  60172. HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
  60173. Also extracted the logic to determine which element and attribute are removed
  60174. as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
  60175. and extractConflictingImplicitStyleOfAttributes.
  60176. * editing/ApplyStyleCommand.cpp:
  60177. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
  60178. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  60179. * editing/ApplyStyleCommand.h:
  60180. * editing/EditingStyle.cpp:
  60181. (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
  60182. (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
  60183. (WebCore::HTMLElementEquivalent::matches): Ditto.
  60184. (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
  60185. (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
  60186. (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
  60187. (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
  60188. (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
  60189. (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
  60190. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
  60191. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
  60192. (WebCore::HTMLAttributeEquivalent::create): Ditto.
  60193. (WebCore::HTMLAttributeEquivalent::matches): Ditto.
  60194. (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
  60195. (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
  60196. (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
  60197. (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
  60198. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
  60199. (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
  60200. (WebCore::HTMLFontSizeEquivalent::create): Ditto.
  60201. (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
  60202. (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
  60203. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
  60204. (WebCore::htmlAttributeEquivalents): Added.
  60205. (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
  60206. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
  60207. * editing/EditingStyle.h:
  60208. 2011-02-25 Chris Fleizach <cfleizach@apple.com>
  60209. Reviewed by Anders Carlsson.
  60210. AX: Add Xcode entries back to the navigator list for Accessibility cpp files
  60211. https://bugs.webkit.org/show_bug.cgi?id=55280
  60212. * WebCore.xcodeproj/project.pbxproj:
  60213. 2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
  60214. Reviewed by Adam Barth.
  60215. WebSocket uses insecure random numbers
  60216. https://bugs.webkit.org/show_bug.cgi?id=54714
  60217. * websockets/WebSocketHandshake.cpp:
  60218. (WebCore::randomNumberLessThan):
  60219. (WebCore::generateSecWebSocketKey):
  60220. (WebCore::generateKey3):
  60221. 2011-02-25 Eric Carlson <eric.carlson@apple.com>
  60222. Reviewed by Darin Adler.
  60223. Add API to enumerate/delete files downloaded for <audio> and <video>
  60224. https://bugs.webkit.org/show_bug.cgi?id=55267
  60225. Add review changes missed in r79737.
  60226. * html/HTMLMediaElement.cpp:
  60227. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
  60228. * html/HTMLMediaElement.h:
  60229. * platform/graphics/MediaPlayer.cpp:
  60230. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  60231. * platform/graphics/MediaPlayer.h:
  60232. * platform/graphics/MediaPlayerPrivate.h:
  60233. (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
  60234. 2011-02-25 Eric Carlson <eric.carlson@apple.com>
  60235. Reviewed by Darin Adler.
  60236. Add API to enumerate/delete files downloaded for <audio> and <video>
  60237. https://bugs.webkit.org/show_bug.cgi?id=55267
  60238. <rdar://problem/9049280>
  60239. No new tests, this is just the plumbing.
  60240. * html/HTMLMediaElement.cpp:
  60241. (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer.
  60242. (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
  60243. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  60244. * html/HTMLMediaElement.h:
  60245. * platform/graphics/MediaPlayer.cpp:
  60246. (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine.
  60247. (WebCore::MediaPlayer::clearMediaCache): Ditto.
  60248. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  60249. * platform/graphics/MediaPlayer.h:
  60250. * platform/graphics/MediaPlayerPrivate.h:
  60251. (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface.
  60252. (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto.
  60253. (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
  60254. 2011-02-25 Abhishek Arya <inferno@chromium.org>
  60255. Reviewed by Dave Hyatt.
  60256. Don't add inline continuation outline to the containing block's
  60257. continuationOutlineTable list if it is not enclosed by an anonymous block.
  60258. https://bugs.webkit.org/show_bug.cgi?id=54690
  60259. We currently don't reconnect inline continuations after a child removal.
  60260. As a result, those merged inlines do not get seperated and hence not get enclosed
  60261. by anonymous blocks. In this case, it is better to bail out and paint it ourself.
  60262. Test: fast/table/table-continuation-outline-paint-crash.html
  60263. * rendering/InlineFlowBox.cpp:
  60264. (WebCore::InlineFlowBox::paint):
  60265. * rendering/RenderBlock.cpp:
  60266. (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell
  60267. if this containing block has the continuation flow in its continuations list.
  60268. * rendering/RenderBlock.h: helper function definition.
  60269. * rendering/RenderInline.cpp:
  60270. (WebCore::RenderInline::destroy): debug only code that asserts if we leave
  60271. behind a continuation in the containing block's continuation list when it is
  60272. getting destroyed.
  60273. 2011-02-25 David Hyatt <hyatt@apple.com>
  60274. Reviewed by Adam Roben.
  60275. https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
  60276. from Length.
  60277. * css/CSSPrimitiveValue.cpp:
  60278. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  60279. * platform/Length.h:
  60280. (WebCore::Length::isFixed):
  60281. * rendering/AutoTableLayout.cpp:
  60282. (WebCore::AutoTableLayout::layout):
  60283. * rendering/RenderImage.cpp:
  60284. (WebCore::RenderImage::isLogicalWidthSpecified):
  60285. (WebCore::RenderImage::isLogicalHeightSpecified):
  60286. * rendering/RenderObject.h:
  60287. (WebCore::RenderObject::markContainingBlocksForLayout):
  60288. * rendering/style/RenderStyle.h:
  60289. (WebCore::InheritedFlags::hasStaticX):
  60290. (WebCore::InheritedFlags::hasStaticY):
  60291. 2011-02-25 Brian Weinstein <bweinstein@apple.com>
  60292. Windows build fix.
  60293. * platform/network/cf/CookieJarCFNet.cpp:
  60294. (WebCore::getHostnamesWithCookies): Add a const_cast.
  60295. (WebCore::deleteCookiesForHostname): Ditto.
  60296. 2011-02-25 Pavel Feldman <pfeldman@chromium.org>
  60297. Reviewed by Timothy Hatcher.
  60298. Web Inspector: Empty Elements panel after closing and reopening Inspector
  60299. https://bugs.webkit.org/show_bug.cgi?id=55248
  60300. Fixing regression real quick. Test to follow.
  60301. * inspector/InspectorDOMAgent.cpp:
  60302. (WebCore::InspectorDOMAgent::reset):
  60303. 2011-02-25 Pavel Feldman <pfeldman@chromium.org>
  60304. Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
  60305. https://bugs.webkit.org/show_bug.cgi?id=55256
  60306. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  60307. (WebCore::InjectedScriptHost::nodeAsScriptValue):
  60308. (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  60309. 2011-02-25 David Hyatt <hyatt@apple.com>
  60310. Reviewed by Sam Weinig.
  60311. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  60312. Make positioned objects work with all possible crazy combinations of mixed writing modes. Added new helper
  60313. functions that flip around the padding box of the containing block and then add in the appropriate border
  60314. side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
  60315. local coordinate space.
  60316. Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.
  60317. * rendering/RenderBox.cpp:
  60318. (WebCore::computeLogicalLeftPositionedOffset):
  60319. (WebCore::RenderBox::computePositionedLogicalWidthUsing):
  60320. (WebCore::computeLogicalTopPositionedOffset):
  60321. (WebCore::RenderBox::computePositionedLogicalHeightUsing):
  60322. (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
  60323. (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
  60324. 2011-02-25 Brian Weinstein <bweinstein@apple.com>
  60325. Reviewed by Brady Eidson and looked over by Jessie Berlin.
  60326. WebKit2: Need a way to manage cookies from the web process
  60327. https://bugs.webkit.org/show_bug.cgi?id=55086
  60328. Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
  60329. deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
  60330. and call them from WebKit2's WebCookieManager.
  60331. No change in behavior needing tests.
  60332. * WebCore.exp.in: Added needed functions to export.
  60333. * platform/CookieJar.h:
  60334. * platform/mac/CookieJar.mm:
  60335. (WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
  60336. (WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from
  60337. NSHTTPCookieStorage.
  60338. (WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.
  60339. * platform/network/cf/CookieJarCFNet.cpp:
  60340. (WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
  60341. (WebCore::deleteCookiesForHostname): Ditto.
  60342. (WebCore::deleteAllCookies): Ditto.
  60343. * platform/efl/CookieJarEfl.cpp: Added stub functions.
  60344. * platform/haiku/CookieJarHaiku.cpp: Ditto.
  60345. * platform/network/android/CookieJarAndroid.cpp: Ditto.
  60346. * platform/network/chromium/CookieJarChromium.cpp: Ditto.
  60347. * platform/network/curl/CookieJarCurl.cpp: Ditto.
  60348. * platform/network/soup/CookieJarSoup.cpp: Ditto.
  60349. * platform/network/win/CookieJarWin.cpp: Ditto.
  60350. * platform/qt/CookieJarQt.cpp: Ditto.
  60351. 2011-02-25 Eric Carlson <eric.carlson@apple.com>
  60352. Reviewed by Eric Seidel.
  60353. 'load' and 'error' events fired for @poster
  60354. https://bugs.webkit.org/show_bug.cgi?id=54908
  60355. * html/HTMLImageLoader.cpp:
  60356. (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used
  60357. by a video element.
  60358. 2011-02-25 David Hyatt <hyatt@apple.com>
  60359. Reviewed by Sam Weinig.
  60360. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  60361. Patch computePositionedLogicalHeightReplaced to be writing-mode aware.
  60362. Added six new tests in fast/replaced.
  60363. * rendering/RenderBox.cpp:
  60364. (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
  60365. 2011-02-25 Patrick Gansterer <paroga@webkit.org>
  60366. Unreviewed build fix.
  60367. * platform/text/brew/TextBreakIteratorBrew.cpp:
  60368. (WebCore::acquireLineBreakIterator):
  60369. * platform/text/wince/TextBreakIteratorWinCE.cpp:
  60370. (WebCore::acquireLineBreakIterator):
  60371. 2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
  60372. Reviewed by Simon Fraser.
  60373. Update the clip layer size whenever the root layer's size and position
  60374. is updated. This only affects the accelerated compositing path.
  60375. https://bugs.webkit.org/show_bug.cgi?id=55103
  60376. * rendering/RenderLayerCompositor.cpp:
  60377. (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  60378. Test: platform/chromium/compositing/layout-width-change.html
  60379. * rendering/RenderLayerCompositor.cpp:
  60380. (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  60381. 2011-02-25 Ned Holbrook <nholbrook@apple.com>
  60382. Reviewed by Dan Bernstein.
  60383. Minimize calls to ubrk_setText()
  60384. https://bugs.webkit.org/show_bug.cgi?id=54912
  60385. <rdar://problem/9032774>
  60386. Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
  60387. break iterator creation until needed. This requires replacing the global line break iterator primitive with a
  60388. version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
  60389. layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
  60390. In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
  60391. * platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
  60392. (WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
  60393. (WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
  60394. (WebCore::LazyLineBreakIterator::string):
  60395. (WebCore::LazyLineBreakIterator::length):
  60396. (WebCore::LazyLineBreakIterator::get):
  60397. (WebCore::LazyLineBreakIterator::reset):
  60398. * platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
  60399. (WebCore::acquireLineBreakIterator):
  60400. (WebCore::releaseLineBreakIterator):
  60401. * platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.
  60402. (WebCore::acquireLineBreakIterator):
  60403. (WebCore::releaseLineBreakIterator):
  60404. * platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.
  60405. (WebCore::acquireLineBreakIterator):
  60406. (WebCore::releaseLineBreakIterator):
  60407. * platform/text/qt/TextBreakIteratorQt.cpp: Ditto.
  60408. (WebCore::acquireLineBreakIterator):
  60409. (WebCore::releaseLineBreakIterator):
  60410. * platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.
  60411. (WebCore::acquireLineBreakIterator):
  60412. (WebCore::releaseLineBreakIterator):
  60413. * rendering/RenderBlock.h:
  60414. * rendering/RenderBlockLineLayout.cpp:
  60415. (WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
  60416. (WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
  60417. * rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
  60418. (WebCore::RenderText::computePreferredLogicalWidths):
  60419. * rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.
  60420. (WebCore::nextBreakablePosition):
  60421. * rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.
  60422. (WebCore::isBreakable):
  60423. 2011-02-25 David Hyatt <hyatt@apple.com>
  60424. Reviewed by Sam Weinig.
  60425. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  60426. Patch computePositionedLogicalWidthReplaced to be writing-mode aware. Not testable yet, since the height function overwrites the values
  60427. in a vertical text environment.
  60428. * rendering/RenderBox.cpp:
  60429. (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
  60430. 2011-02-25 Abhishek Arya <inferno@chromium.org>
  60431. Reviewed by Dave Hyatt.
  60432. When trying to find which lines to dirty for a changed child, make sure
  60433. that we do test if the adjacent next linebox contains that changed child
  60434. and if yes, dirty it. This can happen in cases when we have a word break
  60435. between text nodes.
  60436. https://bugs.webkit.org/show_bug.cgi?id=55206
  60437. Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html
  60438. * rendering/RenderLineBoxList.cpp:
  60439. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  60440. 2011-02-25 Andrey Adaikin <aandrey@google.com>
  60441. Reviewed by Pavel Feldman.
  60442. Web Inspector: [Text editor] Add basic layout tests for the highlighter
  60443. https://bugs.webkit.org/show_bug.cgi?id=54751
  60444. Test: inspector/editor/highlighter-basics.html
  60445. * inspector/front-end/TextEditorHighlighter.js:
  60446. (WebInspector.TextEditorHighlighter.prototype.highlight):
  60447. 2011-02-24 Alexander Pavlov <apavlov@chromium.org>
  60448. Reviewed by Pavel Feldman.
  60449. Web Inspector: Huge fonts in font preview
  60450. https://bugs.webkit.org/show_bug.cgi?id=55143
  60451. * inspector/front-end/FontView.js:
  60452. (WebInspector.FontView.prototype._createContentIfNeeded):
  60453. (WebInspector.FontView.prototype.show):
  60454. (WebInspector.FontView.prototype.resize):
  60455. (WebInspector.FontView.prototype._measureElement):
  60456. (WebInspector.FontView.prototype.updateFontPreviewSize):
  60457. 2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
  60458. Reviewed by Dirk Schulze.
  60459. Implement SVGColor/SVGPaint API
  60460. https://bugs.webkit.org/show_bug.cgi?id=55119
  60461. SVGColor::cssText() shouldn't return #RRGGBBAA colors
  60462. https://bugs.webkit.org/show_bug.cgi?id=48120
  60463. Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/setColor/setURI APIs.
  60464. SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
  60465. That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. That means changes to
  60466. their CSSValues should be reflected in the elements style as well as in the computed style.
  60467. This patch doesn't yet implement that, the stubbed-out method valueChanged() is what
  60468. needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
  60469. and manipulate it, in every possible way (SVPaint.uri/paintType/colorType/color attributes are all sync'ed).
  60470. Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChecking) for both objects.
  60471. Enable proper serialization of colors through Color::serialized(), affects some testcases (#FF.. -> #ff..)
  60472. Add extensive tests of all SVGColor/SVGPaint API, currently shows some FAIL messages, as element style
  60473. <-> computed style is not live, after mutating SVGColor/SVGPaint. That will be implemented in a follow-up patch.
  60474. Tests: svg/dom/SVGColor.html
  60475. svg/dom/SVGPaint.html
  60476. * bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPaintType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
  60477. * bindings/scripts/CodeGeneratorJS.pm: Ditto.
  60478. * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  60479. * bindings/scripts/CodeGeneratorV8.pm: Ditto.
  60480. * css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming convention changes.
  60481. (WebCore::CSSParser::parseSVGValue):
  60482. (WebCore::CSSParser::parseSVGPaint):
  60483. (WebCore::CSSParser::parseSVGColor):
  60484. * svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge all constructors into one, use more descriptable create() naming convention.
  60485. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch.
  60486. (WebCore::SVGColor::SVGColor):
  60487. (WebCore::SVGColor::setRGBColor):
  60488. (WebCore::SVGColor::colorFromRGBColorString):
  60489. (WebCore::SVGColor::setRGBColorICCColor):
  60490. (WebCore::SVGColor::setColor):
  60491. (WebCore::SVGColor::cssText):
  60492. * svg/SVGColor.h:
  60493. (WebCore::SVGColor::createFromString):
  60494. (WebCore::SVGColor::createFromColor):
  60495. (WebCore::SVGColor::color):
  60496. (WebCore::SVGColor::colorType):
  60497. (WebCore::SVGColor::~SVGColor):
  60498. (WebCore::SVGColor::setColor):
  60499. (WebCore::SVGColor::setColorType):
  60500. * svg/SVGColor.idl: Enable strict type checking.
  60501. * svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge all constructors into one, use more descriptable create() naming convention.
  60502. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch.
  60503. (WebCore::colorTypeForPaintType):
  60504. (WebCore::SVGPaint::SVGPaint):
  60505. (WebCore::SVGPaint::setUri):
  60506. (WebCore::SVGPaint::defaultFill):
  60507. (WebCore::SVGPaint::defaultStroke):
  60508. (WebCore::SVGPaint::setPaint):
  60509. (WebCore::SVGPaint::cssText):
  60510. (WebCore::SVGPaint::matchesTargetURI):
  60511. * svg/SVGPaint.h:
  60512. (WebCore::SVGPaint::createUnknown):
  60513. (WebCore::SVGPaint::createNone):
  60514. (WebCore::SVGPaint::createCurrentColor):
  60515. (WebCore::SVGPaint::createColor):
  60516. (WebCore::SVGPaint::createURI):
  60517. (WebCore::SVGPaint::createURIAndColor):
  60518. (WebCore::SVGPaint::paintType):
  60519. (WebCore::SVGPaint::uri):
  60520. (WebCore::SVGPaint::create):
  60521. (WebCore::SVGPaint::isSVGPaint):
  60522. * svg/SVGPaint.idl: Enable strict type checking.
  60523. 2011-02-25 Renata Hodovan <reni@webkit.org>
  60524. Reviewed by Nikolas Zimmermann.
  60525. FESpecularLightingElement changes doesn't require relayout.
  60526. https://bugs.webkit.org/show_bug.cgi?id=54451
  60527. When the FESpecularLightingElement receives an update message but the given value remains the same we don't need
  60528. to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter.
  60529. Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.
  60530. No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting.
  60531. We only test what happens if we remove the light source of specularLight.
  60532. Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html
  60533. * platform/graphics/filters/FESpecularLighting.cpp:
  60534. (WebCore::FESpecularLighting::setSurfaceScale):
  60535. (WebCore::FESpecularLighting::setSpecularConstant):
  60536. (WebCore::FESpecularLighting::setSpecularExponent):
  60537. (WebCore::FESpecularLighting::setKernelUnitLengthX):
  60538. (WebCore::FESpecularLighting::setKernelUnitLengthY):
  60539. * platform/graphics/filters/FESpecularLighting.h:
  60540. * rendering/svg/RenderSVGResourceFilter.cpp:
  60541. (WebCore::RenderSVGResourceFilter::postApplyResource):
  60542. * svg/SVGFEDiffuseLightingElement.cpp:
  60543. (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  60544. (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
  60545. (WebCore::SVGFEDiffuseLightingElement::build):
  60546. * svg/SVGFEDiffuseLightingElement.h:
  60547. * svg/SVGFELightElement.cpp:
  60548. (WebCore::SVGFELightElement::findLightElement):
  60549. (WebCore::SVGFELightElement::findLight):
  60550. (WebCore::SVGFELightElement::svgAttributeChanged):
  60551. * svg/SVGFELightElement.h:
  60552. * svg/SVGFESpecularLightingElement.cpp:
  60553. (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
  60554. (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
  60555. (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged):
  60556. (WebCore::SVGFESpecularLightingElement::build):
  60557. * svg/SVGFESpecularLightingElement.h:
  60558. 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  60559. Reviewed by Andreas Kling.
  60560. [Qt] Revert the support for QNAM affined to a different thread.
  60561. https://bugs.webkit.org/show_bug.cgi?id=55149
  60562. Qt 4.8 will have QNAM use its own thread internally by default,
  60563. no need to keep this complexity in WebKit.
  60564. This mainly reverts:
  60565. http://trac.webkit.org/changeset/73710
  60566. http://trac.webkit.org/changeset/73712
  60567. * WebCore.pro:
  60568. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  60569. (WebCore::MediaPlayerPrivateQt::commitLoad):
  60570. * platform/network/qt/QNetworkReplyHandler.cpp:
  60571. (WebCore::FormDataIODevice::FormDataIODevice):
  60572. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  60573. (WebCore::QNetworkReplyHandler::setLoadMode):
  60574. (WebCore::QNetworkReplyHandler::abort):
  60575. (WebCore::QNetworkReplyHandler::release):
  60576. (WebCore::ignoreHttpError):
  60577. (WebCore::QNetworkReplyHandler::finish):
  60578. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  60579. (WebCore::QNetworkReplyHandler::forwardData):
  60580. (WebCore::QNetworkReplyHandler::start):
  60581. (WebCore::QNetworkReplyHandler::sendQueuedItems):
  60582. * platform/network/qt/QNetworkReplyHandler.h:
  60583. (WebCore::QNetworkReplyHandler::reply):
  60584. * platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
  60585. * platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
  60586. * platform/network/qt/ResourceHandleQt.cpp:
  60587. (WebCore::ResourceHandle::willLoadFromCache):
  60588. * platform/qt/CookieJarQt.cpp:
  60589. (WebCore::cookieJar):
  60590. (WebCore::setCookies):
  60591. (WebCore::cookies):
  60592. (WebCore::cookieRequestHeaderFieldValue):
  60593. (WebCore::cookiesEnabled):
  60594. 2011-02-25 Renata Hodovan <reni@webkit.org>
  60595. Reviewed by Andreas Kling.
  60596. FEBlendElement changes doesn't require relayout
  60597. https://bugs.webkit.org/show_bug.cgi?id=55138
  60598. When the FEBlendElement receives an update message but the given value remains the same we don't need
  60599. to relayout the filter.
  60600. No new tests are needed because this modificiation is covered by the dynamic update tests of FEBlend.
  60601. * platform/graphics/filters/FEBlend.cpp:
  60602. (WebCore::FEBlend::setBlendMode):
  60603. * platform/graphics/filters/FEBlend.h:
  60604. * svg/SVGFEBlendElement.cpp:
  60605. (WebCore::SVGFEBlendElement::setFilterEffectAttribute):
  60606. (WebCore::SVGFEBlendElement::svgAttributeChanged):
  60607. (WebCore::SVGFEBlendElement::synchronizeProperty):
  60608. * svg/SVGFEBlendElement.h:
  60609. 2011-02-24 Daniel Bates <dbates@rim.com>
  60610. Reviewed by Antonio Gomes.
  60611. Clean up: Extract table height adjustment for <caption> into common function
  60612. https://bugs.webkit.org/show_bug.cgi?id=54936
  60613. We use similar logic for adjusting the height of a table with respect
  60614. to a top- and bottom-positioned <caption>. Instead, we should extract
  60615. the common code into a shared function.
  60616. No functionality changed. So no new tests.
  60617. * rendering/RenderTable.cpp:
  60618. (WebCore::RenderTable::adjustLogicalHeightForCaption): Added.
  60619. (WebCore::RenderTable::layout): Extracted common code to adjust table height
  60620. with respect to the <caption> into RenderTable::adjustLogicalHeightForCaption().
  60621. * rendering/RenderTable.h:
  60622. 2011-02-24 James Robinson <jamesr@chromium.org>
  60623. Reviewed by Kenneth Russell.
  60624. [chromium] Move draw time properties out of *LayerChromium to CCLayerImpl
  60625. https://bugs.webkit.org/show_bug.cgi?id=55013
  60626. This adds a new type (tentatively named CCLayerImpl) responsible for drawing/compositing layers.
  60627. Currently LayerChromiums know about their CCLayerImpls and CCLayerImpls rely on the LayerChromium
  60628. tree for structure. In theory updates are a LayerChromium-only concept and draw is a CCLayerImpl-only
  60629. concept, but this patch doesn't go all there yet in the interest of keeping the patch small-ish.
  60630. RenderSurfaces are a CCLayerImpl-only concepts and no longer have any direct LayerChromium dependencies.
  60631. Note: I've put CCLayerImpl into a new 'cc' directory under platform/graphics/chromium/ and intentionally
  60632. not added it to the include path. We plan to add more compositor implementation details to this directory
  60633. and we want to keep accidental dependencies on these files to a minimum.
  60634. See https://bugs.webkit.org/show_bug.cgi?id=54047 for the big picture.
  60635. Refactor only, compositing/ tests cover these codepaths.
  60636. * WebCore.gypi:
  60637. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  60638. (WebCore::CanvasLayerChromium::draw):
  60639. * platform/graphics/chromium/ContentLayerChromium.cpp:
  60640. (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
  60641. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  60642. (WebCore::ContentLayerChromium::draw):
  60643. * platform/graphics/chromium/LayerChromium.cpp:
  60644. (WebCore::LayerChromium::LayerChromium):
  60645. (WebCore::LayerChromium::cleanupResources):
  60646. (WebCore::LayerChromium::setLayerRenderer):
  60647. (WebCore::LayerChromium::setBounds):
  60648. (WebCore::LayerChromium::setFrame):
  60649. (WebCore::LayerChromium::setNeedsDisplay):
  60650. (WebCore::LayerChromium::setBorderColor):
  60651. (WebCore::LayerChromium::borderColor):
  60652. (WebCore::LayerChromium::setBorderWidth):
  60653. (WebCore::LayerChromium::borderWidth):
  60654. (WebCore::LayerChromium::layerRenderer):
  60655. (WebCore::LayerChromium::setDoubleSided):
  60656. (WebCore::LayerChromium::bounds):
  60657. * platform/graphics/chromium/LayerChromium.h:
  60658. (WebCore::LayerChromium::maskDrawLayer):
  60659. (WebCore::LayerChromium::ccLayerImpl):
  60660. * platform/graphics/chromium/LayerRendererChromium.cpp:
  60661. (WebCore::LayerRendererChromium::compareLayerZ):
  60662. (WebCore::LayerRendererChromium::drawLayers):
  60663. (WebCore::LayerRendererChromium::updateLayersRecursive):
  60664. (WebCore::LayerRendererChromium::setCompositeOffscreen):
  60665. (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
  60666. (WebCore::LayerRendererChromium::drawLayer):
  60667. * platform/graphics/chromium/LayerRendererChromium.h:
  60668. * platform/graphics/chromium/PluginLayerChromium.cpp:
  60669. (WebCore::PluginLayerChromium::draw):
  60670. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  60671. (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
  60672. (WebCore::RenderSurfaceChromium::drawSurface):
  60673. (WebCore::RenderSurfaceChromium::draw):
  60674. * platform/graphics/chromium/RenderSurfaceChromium.h:
  60675. * platform/graphics/chromium/VideoLayerChromium.cpp:
  60676. (WebCore::VideoLayerChromium::drawYUV):
  60677. (WebCore::VideoLayerChromium::drawRGBA):
  60678. * platform/graphics/chromium/cc/CCLayerImpl.cpp: Added.
  60679. (WebCore::CCLayerImpl::CCLayerImpl):
  60680. (WebCore::CCLayerImpl::~CCLayerImpl):
  60681. (WebCore::CCLayerImpl::superlayer):
  60682. (WebCore::CCLayerImpl::maskLayer):
  60683. (WebCore::CCLayerImpl::replicaLayer):
  60684. (WebCore::CCLayerImpl::setLayerRenderer):
  60685. (WebCore::CCLayerImpl::createRenderSurface):
  60686. (WebCore::CCLayerImpl::updateContentsIfDirty):
  60687. (WebCore::CCLayerImpl::drawsContent):
  60688. (WebCore::CCLayerImpl::draw):
  60689. (WebCore::CCLayerImpl::unreserveContentsTexture):
  60690. (WebCore::CCLayerImpl::bindContentsTexture):
  60691. (WebCore::CCLayerImpl::cleanupResources):
  60692. (WebCore::CCLayerImpl::getDrawRect):
  60693. (WebCore::CCLayerImpl::drawDebugBorder):
  60694. * platform/graphics/chromium/cc/CCLayerImpl.h: Added.
  60695. (WebCore::CCLayerImpl::create):
  60696. (WebCore::CCLayerImpl::setDebugBorderColor):
  60697. (WebCore::CCLayerImpl::debugBorderColor):
  60698. (WebCore::CCLayerImpl::setDebugBorderWidth):
  60699. (WebCore::CCLayerImpl::debugBorderWidth):
  60700. (WebCore::CCLayerImpl::layerRenderer):
  60701. (WebCore::CCLayerImpl::renderSurface):
  60702. (WebCore::CCLayerImpl::clearRenderSurface):
  60703. (WebCore::CCLayerImpl::drawDepth):
  60704. (WebCore::CCLayerImpl::setDrawDepth):
  60705. (WebCore::CCLayerImpl::drawOpacity):
  60706. (WebCore::CCLayerImpl::setDrawOpacity):
  60707. (WebCore::CCLayerImpl::scissorRect):
  60708. (WebCore::CCLayerImpl::setScissorRect):
  60709. (WebCore::CCLayerImpl::targetRenderSurface):
  60710. (WebCore::CCLayerImpl::setTargetRenderSurface):
  60711. (WebCore::CCLayerImpl::doubleSided):
  60712. (WebCore::CCLayerImpl::setDoubleSided):
  60713. (WebCore::CCLayerImpl::bounds):
  60714. (WebCore::CCLayerImpl::setBounds):
  60715. (WebCore::CCLayerImpl::drawTransform):
  60716. (WebCore::CCLayerImpl::setDrawTransform):
  60717. (WebCore::CCLayerImpl::drawableContentRect):
  60718. (WebCore::CCLayerImpl::setDrawableContentRect):
  60719. 2011-02-24 Dan Bernstein <mitz@apple.com>
  60720. Reviewed by Simon Fraser.
  60721. REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
  60722. https://bugs.webkit.org/show_bug.cgi?id=55197
  60723. * rendering/RenderBlockLineLayout.cpp:
  60724. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
  60725. if there are no expansion opportunities. This allows RenderRubyBase to center itself.
  60726. 2011-02-24 Darin Adler <darin@apple.com>
  60727. Reviewed by Alexey Proskuryakov.
  60728. REGRESSION (r79466): http/tests/incremental/slow-utf8-html.pl flaky due to incorrect assertions
  60729. https://bugs.webkit.org/show_bug.cgi?id=55135
  60730. * platform/text/TextCodecUTF8.cpp:
  60731. (WebCore::TextCodecUTF8::decode): Removed incorrect assertions.
  60732. 2011-02-24 Darin Adler <darin@apple.com>
  60733. Reviewed by Anders Carlsson.
  60734. WebKit2: Image-based cursors do not work
  60735. https://bugs.webkit.org/show_bug.cgi?id=55184
  60736. * WebCore.exp.in: Exported new entry points now used by WebKit2.
  60737. 2011-02-24 Matthew Delaney <mdelaney@apple.com>
  60738. Reviewed by Simon Fraser.
  60739. ImageBuffer::clip creates an image of the incorrect context in IOSurface case
  60740. https://bugs.webkit.org/show_bug.cgi?id=55170
  60741. Test: fast/canvas/2d.fillText.gradient.html
  60742. * platform/graphics/cg/ImageBufferCG.cpp: Clipping against ImageBuffer's context
  60743. instead of ourself (the passed in context).
  60744. 2011-02-24 Simon Fraser <simon.fraser@apple.com>
  60745. Reviewed by Dan Bernstein.
  60746. RenderBoxModelObject::paintBoxShadow should bail earlier
  60747. https://bugs.webkit.org/show_bug.cgi?id=55186
  60748. Make paintBoxShadow() bail early if there is no shadow, and make
  60749. callers consistent in not checking for box-shadow before calling it.
  60750. * rendering/InlineFlowBox.cpp:
  60751. (WebCore::InlineFlowBox::paintBoxDecorations):
  60752. * rendering/RenderBoxModelObject.cpp:
  60753. (WebCore::RenderBoxModelObject::paintBoxShadow):
  60754. * rendering/RenderTableCell.cpp:
  60755. (WebCore::RenderTableCell::paintBoxDecorations):
  60756. 2011-02-24 James Robinson <jamesr@chromium.org>
  60757. Reviewed by Darin Fisher.
  60758. Add a USE() macro to control use of the built-in UTF8 codec
  60759. https://bugs.webkit.org/show_bug.cgi?id=55189
  60760. Guards the built in UTF8 codec registration with USE(BUILTIN_UTF8_CODEC). ICU is used if the USE() is not set.
  60761. * platform/text/TextCodecICU.cpp:
  60762. (WebCore::TextCodecICU::registerEncodingNames):
  60763. * platform/text/TextEncodingRegistry.cpp:
  60764. (WebCore::buildBaseTextCodecMaps):
  60765. 2011-02-24 Dan Bernstein <mitz@apple.com>
  60766. Reviewed by Dave Hyatt.
  60767. <rdar://problem/8902740> Expand ruby base when it is shorter than the ruby text
  60768. https://bugs.webkit.org/show_bug.cgi?id=55183
  60769. Test: fast/ruby/base-shorter-than-text.html
  60770. * rendering/RenderBlock.cpp:
  60771. (WebCore::RenderBlock::availableLogicalWidthForLine):
  60772. * rendering/RenderBlock.h:
  60773. (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Added. The base clase implementation does nothing.
  60774. * rendering/RenderBlockLineLayout.cpp:
  60775. (WebCore::RenderBlock::textAlignmentForLine): Added. Implements the logic that changes "justify" to "auto" for
  60776. the last line or a line that ends with a hard break.
  60777. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Use textAlignmentForLine(), compute the available
  60778. width more efficiently, and call adjustInlineDirectionLineBounds() for justified lines.
  60779. * rendering/RenderRubyBase.cpp:
  60780. (WebCore::RenderRubyBase::rubyRun): Added.
  60781. (WebCore::RenderRubyBase::textAlignmentForLine): Added. Alwyas returns "justify".
  60782. (WebCore::RenderRubyBase::adjustInlineDirectionLineBounds): Added. Insets the line such that the inset is
  60783. half the width of a single intra-line expansion.
  60784. * rendering/RenderRubyBase.h:
  60785. * rendering/RenderRubyRun.cpp:
  60786. (WebCore::RenderRubyRun::addChild):
  60787. 2011-02-24 James Robinson <jamesr@chromium.org>
  60788. Unreviewed, rolling out r79604.
  60789. http://trac.webkit.org/changeset/79604
  60790. https://bugs.webkit.org/show_bug.cgi?id=55017
  60791. Causes assertions to fail on some SVG tests
  60792. * svg/graphics/SVGImage.cpp:
  60793. (WebCore::SVGImage::dataChanged):
  60794. 2011-02-24 Oliver Hunt <oliver@apple.com>
  60795. Build fix
  60796. * bindings/js/JSBindingsAllInOne.cpp:
  60797. 2011-02-24 David Hyatt <hyatt@apple.com>
  60798. Reviewed by Simon Fraser.
  60799. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  60800. Rework the logical height computation for positioned elements to work in terms of before and after. That way the offset is determined from
  60801. the correct container side in flipped block writing modes (e.g., vertical-rl).
  60802. Patch locationOffsetIncludingFlipping to use the containing block to flip so that it will behave correctly with absolute/fixed positioned
  60803. elements.
  60804. Patch offsetFromContainer to use the flipped location offset for absolute/fixed positioned elements so that localToAbsolute works properly.
  60805. Added twelve tests in fast/block/positioning/vertical-rl and fast/block/positioning/vertical-lr.
  60806. * rendering/RenderBox.cpp:
  60807. (WebCore::RenderBox::offsetFromContainer):
  60808. (WebCore::RenderBox::computePositionedLogicalHeight):
  60809. (WebCore::RenderBox::computePositionedLogicalHeightUsing):
  60810. (WebCore::RenderBox::locationOffsetIncludingFlipping):
  60811. * rendering/style/RenderStyle.h:
  60812. (WebCore::InheritedFlags::logicalTop):
  60813. (WebCore::InheritedFlags::logicalBottom):
  60814. 2011-02-23 Oliver Hunt <oliver@apple.com>
  60815. Reviewed by Geoffrey Garen.
  60816. Make WeakGCMap use new handle infrastructure
  60817. https://bugs.webkit.org/show_bug.cgi?id=55100
  60818. Update to new WeakGCMap APIs, this requires threading global
  60819. data to a few functions that did not need it in the past, but
  60820. also gets rid of a large number of destructors, as well as the
  60821. forgetDOMNode, etc APIs.
  60822. We can also drop the JSDebugWrapperSet as its only purpose was
  60823. to ensure that we retained correct semantics in the old WeakGCMap,
  60824. but happilly these semantics are now guaranteed by the map itself.
  60825. * CMakeLists.txt:
  60826. * GNUmakefile.am:
  60827. * WebCore.gypi:
  60828. * WebCore.pro:
  60829. * WebCore.vcproj/WebCore.vcproj:
  60830. * WebCore.xcodeproj/project.pbxproj:
  60831. * bindings/js/JSDOMBinding.cpp:
  60832. (WebCore::hasCachedDOMObjectWrapperUnchecked):
  60833. (WebCore::cacheDOMObjectWrapper):
  60834. (WebCore::hasCachedDOMNodeWrapperUnchecked):
  60835. (WebCore::cacheDOMNodeWrapper):
  60836. (WebCore::isObservableThroughDOM):
  60837. (WebCore::markDOMNodesForDocument):
  60838. (WebCore::takeWrappers):
  60839. (WebCore::updateDOMNodeDocument):
  60840. (WebCore::markDOMObjectWrapper):
  60841. (WebCore::markDOMNodeWrapper):
  60842. (WebCore::stringWrapperDestroyed):
  60843. (WebCore::jsStringSlowCase):
  60844. * bindings/js/JSDOMBinding.h:
  60845. * bindings/js/JSDOMWrapper.cpp:
  60846. (WebCore::DOMObject::~DOMObject):
  60847. * bindings/js/JSDebugWrapperSet.cpp: Removed.
  60848. * bindings/js/JSDebugWrapperSet.h: Removed.
  60849. * bindings/scripts/CodeGeneratorJS.pm:
  60850. * bridge/jsc/BridgeJSC.cpp:
  60851. (JSC::Bindings::Instance::createRuntimeObject):
  60852. * bridge/jsc/BridgeJSC.h:
  60853. * bridge/runtime_object.cpp:
  60854. (JSC::Bindings::RuntimeObject::~RuntimeObject):
  60855. * bridge/runtime_root.cpp:
  60856. (JSC::Bindings::RootObject::invalidate):
  60857. (JSC::Bindings::RootObject::addRuntimeObject):
  60858. (JSC::Bindings::RootObject::removeRuntimeObject):
  60859. * bridge/runtime_root.h:
  60860. 2011-02-24 James Robinson <jamesr@chromium.org>
  60861. Fix chromium compile.
  60862. * bindings/v8/custom/V8LocationCustom.cpp:
  60863. (WebCore::V8Location::toStringCallback):
  60864. 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  60865. Unreviewed, rolling out r79607.
  60866. http://trac.webkit.org/changeset/79607
  60867. https://bugs.webkit.org/show_bug.cgi?id=55157
  60868. Broke Chromium layout tests.
  60869. * html/shadow/MediaControls.cpp:
  60870. (WebCore::MediaControls::updateVolumeSliderContainer):
  60871. * rendering/RenderMediaControls.cpp:
  60872. (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
  60873. * rendering/RenderMediaControls.h:
  60874. * rendering/RenderTheme.cpp:
  60875. (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
  60876. * rendering/RenderTheme.h:
  60877. * rendering/RenderThemeChromiumMac.h:
  60878. * rendering/RenderThemeChromiumMac.mm:
  60879. (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
  60880. * rendering/RenderThemeMac.h:
  60881. * rendering/RenderThemeMac.mm:
  60882. (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
  60883. * rendering/RenderThemeWin.cpp:
  60884. (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
  60885. * rendering/RenderThemeWin.h:
  60886. 2011-02-24 Anders Carlsson <andersca@apple.com>
  60887. Reviewed by Sam Weinig.
  60888. Fix the clang -Woverloaded-virtual build.
  60889. JSLocation has a toString function which conflicts with the virtual JSObject::toString member function.
  60890. Fix this by renaming the implementation function from JSLocation::toString to JSLocation::toStringFunction.
  60891. * bindings/js/JSLocationCustom.cpp:
  60892. (WebCore::JSLocation::toStringFunction):
  60893. * bindings/v8/custom/V8LocationCustom.cpp:
  60894. (WebCore::V8Location::toStringFunctionCallback):
  60895. * page/Location.idl:
  60896. 2011-02-24 Anders Carlsson <andersca@apple.com>
  60897. Fix clang build.
  60898. * bindings/objc/WebScriptObject.mm:
  60899. (-[WebUndefined release]):
  60900. Release should be "oneway void".
  60901. (-[WebUndefined retainCount]):
  60902. Return NSUIntegerMax instead of UINT_MAX.
  60903. 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  60904. Reviewed by Darin Adler.
  60905. Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.
  60906. https://bugs.webkit.org/show_bug.cgi?id=55157
  60907. Refactoring, no functional changes. Covered by existing tests.
  60908. RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
  60909. logic for all platforms. This patch:
  60910. a) moves the common logic of determining absolute positioning to a
  60911. platform-agnostic place;
  60912. b) simplifies the method to return constant offset.
  60913. * html/shadow/MediaControls.cpp:
  60914. (WebCore::volumeSliderOffset): Added new helper function,
  60915. capturing common logic of finding the absolute position of the volume slider.
  60916. (WebCore::MediaControls::updateVolumeSliderContainer): Changed to use the
  60917. new helper.
  60918. * rendering/RenderMediaControls.cpp:
  60919. (WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
  60920. * rendering/RenderMediaControls.h: Ditto.
  60921. * rendering/RenderTheme.cpp:
  60922. (WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
  60923. * rendering/RenderTheme.h: Ditto.
  60924. * rendering/RenderThemeChromiumMac.h: Ditto.
  60925. * rendering/RenderThemeChromiumMac.mm: Ditto.
  60926. (WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  60927. * rendering/RenderThemeMac.h: Ditto.
  60928. * rendering/RenderThemeMac.mm: Ditto.
  60929. (WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  60930. * rendering/RenderThemeWin.cpp: Ditto.
  60931. (WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto.
  60932. * rendering/RenderThemeWin.h: Ditto.
  60933. 2011-02-24 Tom Sepez <tsepez@chromium.org>
  60934. Reviewed by Darin Fisher.
  60935. Make frameview resized event dispatch async so that it occurs
  60936. after layout has completed.
  60937. https://bugs.webkit.org/show_bug.cgi?id=54467
  60938. Test: fast/replaced/frame-removed-during-resize-smaller.html
  60939. * page/EventHandler.cpp:
  60940. (WebCore::EventHandler::sendResizeEvent):
  60941. 2011-02-24 Xianzhu Wang <wangxianzhu@google.com>
  60942. Reviewed by Adam Barth.
  60943. Use loader->init() instead of loader->load() to avoid complex fake
  60944. request loading and cleanup logic, and also avoid ResourceLoader leaks.
  60945. https://bugs.webkit.org/show_bug.cgi?id=55017
  60946. Test: svg/misc/SVGImage-leak-ResourceLoader.html
  60947. * svg/graphics/SVGImage.cpp:
  60948. (WebCore::SVGImage::dataChanged):
  60949. 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  60950. Chromium Mac build fix after r79591.
  60951. * WebCore.gypi: Added RenderMediaControls to WebCore.gypi.
  60952. 2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>
  60953. Reviewed by Andreas Kling.
  60954. [Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
  60955. (2048Kb for now).
  60956. https://bugs.webkit.org/show_bug.cgi?id=54887
  60957. No new tests required.
  60958. * platform/graphics/qt/GraphicsLayerQt.cpp:
  60959. (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache):
  60960. (WebCore::GraphicsLayerQtImpl::drawLayerContent):
  60961. (WebCore::GraphicsLayerQtImpl::paint):
  60962. (WebCore::GraphicsLayerQtImpl::flushChanges):
  60963. 2011-02-20 Martin Robinson <mrobinson@igalia.com>
  60964. Reviewed by Nikolas Zimmermann.
  60965. [CAIRO] Support ImageBuffers clip operation on all Cairo ports
  60966. https://bugs.webkit.org/show_bug.cgi?id=23526
  60967. Add support for ImageBuffer clipping on Cairo by emulating them with image
  60968. masks. Since masking is immediate on Cairo, we must store the mask surfaces
  60969. on a stack and apply them during restorePlatformState.
  60970. * platform/graphics/GraphicsContext.h: Add pushImageMask.
  60971. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  60972. (WebCore::GraphicsContext::savePlatformState): Push an empty mask onto the
  60973. stack, so we can keep track of when to actually apply the image mask.
  60974. (WebCore::GraphicsContext::restorePlatformState): When we are ready to apply
  60975. an image mask, use cairo_mask_surface to mask the group that we pushed onto
  60976. our surface.
  60977. (WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface
  60978. onto the image mask stack and push a group onto the Cairo state, so that the masking
  60979. only affects what we paint after this point.
  60980. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep
  60981. track of image masking information after calls to pushImageMask.
  60982. (WebCore::ImageMaskInformation::update): Added
  60983. (WebCore::ImageMaskInformation::valid): Added
  60984. (WebCore::ImageMaskInformation::maskSurface): Added
  60985. (WebCore::ImageMaskInformation::maskRect): Added
  60986. * platform/graphics/cairo/ImageBufferCairo.cpp:
  60987. (WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.
  60988. 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  60989. Reviewed by Eric Carlson.
  60990. Add RenderMediaControls to Mac build, unduplicate one method.
  60991. https://bugs.webkit.org/show_bug.cgi?id=55152
  60992. Refactoring, no functional changes.
  60993. * WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to project,
  60994. ran sort-XCode-project-file.
  60995. * rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WIN)
  60996. defines to allow building on Mac.
  60997. * rendering/RenderMediaControls.h: Ditto.
  60998. * rendering/RenderThemeMac.mm:
  60999. (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced guts
  61000. with a call to RenderMediaControls function.
  61001. 2011-02-24 James Robinson <jamesr@chromium.org>
  61002. Unreviewed, rolling out r79584.
  61003. http://trac.webkit.org/changeset/79584
  61004. https://bugs.webkit.org/show_bug.cgi?id=44797
  61005. [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
  61006. not set
  61007. * WebCore.gyp/WebCore.gyp:
  61008. * WebCore.gypi:
  61009. 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
  61010. Reviewed by Martin Robinson.
  61011. Do not cache the default cairo font options using a static
  61012. variable. It fixes a memory leak reported by valgrind.
  61013. * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  61014. (WebCore::getDefaultFontOptions):
  61015. (WebCore::FontPlatformData::initializeWithFontFace):
  61016. 2011-02-24 Andrew Wilson <atwilson@chromium.org>
  61017. Unreviewed, rolling out r79570.
  61018. http://trac.webkit.org/changeset/79570
  61019. https://bugs.webkit.org/show_bug.cgi?id=54874
  61020. Breaks chromium build because glue/mocks/mock_web_frame.h/cc
  61021. was not updated
  61022. * WebCore.exp.in:
  61023. 2011-02-24 David Dorwin <ddorwin@chromium.org>
  61024. Reviewed by Eric Seidel.
  61025. Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
  61026. fullscreen javascript bindings not implemented for v8
  61027. https://bugs.webkit.org/show_bug.cgi?id=44797
  61028. Tested by the existing fullscreen Layout Tests.
  61029. * WebCore.gyp/WebCore.gyp:
  61030. * WebCore.gypi:
  61031. 2011-02-24 Pavel Feldman <pfeldman@chromium.org>
  61032. Reviewed by Yury Semikhatsky.
  61033. Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
  61034. https://bugs.webkit.org/show_bug.cgi?id=55131
  61035. Test: inspector/elements/dom-agent-query-selector.html
  61036. * inspector/Inspector.idl:
  61037. * inspector/InspectorCSSAgent.cpp:
  61038. * inspector/InspectorCSSAgent.h:
  61039. * inspector/InspectorDOMAgent.cpp:
  61040. (WebCore::InspectorDOMAgent::nodeToSelectOn):
  61041. (WebCore::InspectorDOMAgent::querySelector):
  61042. (WebCore::InspectorDOMAgent::querySelectorAll):
  61043. * inspector/InspectorDOMAgent.h:
  61044. * inspector/front-end/AuditRules.js:
  61045. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  61046. * inspector/front-end/CSSStyleModel.js:
  61047. (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
  61048. (WebInspector.CSSStyleModel.prototype.setRuleSelector):
  61049. (WebInspector.CSSStyleModel.prototype.addRule.callback):
  61050. (WebInspector.CSSStyleModel.prototype.addRule):
  61051. 2011-02-24 Eric Seidel <eric@webkit.org>
  61052. Reviewed by Adam Barth.
  61053. Fragment parsing does not need to use HTMLSourceTracker
  61054. https://bugs.webkit.org/show_bug.cgi?id=55011
  61055. Any performance gains from this patch are likely
  61056. the result of working around:
  61057. https://bugs.webkit.org/show_bug.cgi?id=55005
  61058. (Which suggests that fixing bug 55005 will speed
  61059. up normal HTML parsing substantially.)
  61060. Assuming I ran the numbers correct, here is the
  61061. change from PerformanceTests/Parser/tiny-innerHTML:
  61062. Before patch:
  61063. avg 5586.1
  61064. median 5594
  61065. stdev 41.295157101045135
  61066. min 5425
  61067. max 5633
  61068. After Patch:
  61069. avg 2603.9
  61070. median 2609.5
  61071. stdev 32.500615378789355
  61072. min 2475
  61073. max 2649
  61074. Removing just the HTMLSourceTracker calls brought our
  61075. score from 5500 to 5200, removing the XSSFilter as well
  61076. brought it to 2600 on my machine.
  61077. * html/parser/HTMLDocumentParser.cpp:
  61078. (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  61079. (WebCore::HTMLDocumentParser::pumpTokenizer):
  61080. * html/parser/HTMLDocumentParser.h:
  61081. 2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
  61082. Reviewed by Martin Robinson.
  61083. [GTK] Implement WebEventFactory, WebErrors classes for WebKit2
  61084. https://bugs.webkit.org/show_bug.cgi?id=48510
  61085. Exported static functions for GTK, we need them to create events
  61086. in WebKit2.
  61087. * platform/PlatformKeyboardEvent.h:
  61088. * platform/gtk/KeyEventGtk.cpp:
  61089. (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
  61090. (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):
  61091. (WebCore::PlatformKeyboardEvent::singleCharacterString):
  61092. 2011-02-24 Martin Robinson <mrobinson@igalia.com>
  61093. Reviewed by Xan Lopez.
  61094. [GTK] Remove the GFile GOwnPtr specialization
  61095. https://bugs.webkit.org/show_bug.cgi?id=55154
  61096. Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.
  61097. No new tests. This should not change behavior.
  61098. * plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include.
  61099. (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr.
  61100. 2011-02-24 Patrick Gansterer <paroga@webkit.org>
  61101. Reviewed by Eric Seidel.
  61102. Rename PLATFORM(SKIA) to USE(SKIA)
  61103. https://bugs.webkit.org/show_bug.cgi?id=55090
  61104. * config.h: Removed second define of PLATFORM(SKIA).
  61105. * html/HTMLCanvasElement.cpp:
  61106. * platform/graphics/FloatPoint.h:
  61107. * platform/graphics/FloatRect.h:
  61108. * platform/graphics/Gradient.cpp:
  61109. * platform/graphics/Gradient.h:
  61110. * platform/graphics/GraphicsContext.cpp:
  61111. * platform/graphics/GraphicsContext.h:
  61112. * platform/graphics/ImageSource.h:
  61113. * platform/graphics/IntPoint.h:
  61114. * platform/graphics/IntRect.h:
  61115. * platform/graphics/Path.h:
  61116. * platform/graphics/Pattern.cpp:
  61117. * platform/graphics/Pattern.h:
  61118. * platform/graphics/chromium/ContentLayerChromium.cpp:
  61119. * platform/graphics/chromium/ContentLayerChromium.h:
  61120. * platform/graphics/chromium/GLES2Canvas.cpp:
  61121. * platform/graphics/chromium/ImageLayerChromium.cpp:
  61122. * platform/graphics/chromium/LayerChromium.cpp:
  61123. * platform/graphics/chromium/LayerRendererChromium.cpp:
  61124. * platform/graphics/chromium/LayerRendererChromium.h:
  61125. * platform/graphics/chromium/LayerTilerChromium.cpp:
  61126. * platform/graphics/chromium/ShaderChromium.h:
  61127. * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
  61128. * platform/graphics/transforms/AffineTransform.h:
  61129. * platform/graphics/transforms/TransformationMatrix.h:
  61130. * platform/image-decoders/ImageDecoder.cpp:
  61131. * platform/image-decoders/ImageDecoder.h:
  61132. * rendering/svg/RenderSVGResourceSolidColor.cpp:
  61133. 2011-02-24 Pavel Feldman <pfeldman@chromium.org>
  61134. Reviewed by Yury Semikhatsky.
  61135. Web Inspector: follow up to 79566. USE_PARAM not declared
  61136. https://bugs.webkit.org/show_bug.cgi?id=55155
  61137. * bindings/js/JSInjectedScriptHostCustom.cpp:
  61138. (WebCore::JSInjectedScriptHost::currentCallFrame):
  61139. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  61140. (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  61141. 2011-02-24 Emil A Eklund <eae@chromium.org>
  61142. Reviewed by Simon Fraser.
  61143. Add support for missing properties to getComputedStyle
  61144. https://bugs.webkit.org/show_bug.cgi?id=23668
  61145. Implement getComputedStyle for the content, counter and outline-offset
  61146. properties.
  61147. Test: fast/css/getComputedStyle/computed-style-properties.html
  61148. * css/CSSComputedStyleDeclaration.cpp:
  61149. (WebCore::contentToCSSValue):
  61150. (WebCore::counterToCSSValue):
  61151. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  61152. * css/CSSPrimitiveValue.cpp:
  61153. (WebCore::CSSPrimitiveValue::cssText):
  61154. * css/CSSPrimitiveValue.h:
  61155. 2011-02-24 Eric Seidel <eric@webkit.org>
  61156. Reviewed by Adam Barth.
  61157. SegmentedString does not need an m_composite member
  61158. https://bugs.webkit.org/show_bug.cgi?id=55083
  61159. Storing m_composite as distinct from m_substrings.isEmpty()
  61160. was just error prone and eventually going to get us in trouble.
  61161. I also cleaned up some of the style in SegementedString.*
  61162. since this file long predates check-webkit-style.
  61163. * platform/text/SegmentedString.cpp:
  61164. (WebCore::SegmentedString::SegmentedString):
  61165. (WebCore::SegmentedString::operator=):
  61166. (WebCore::SegmentedString::length):
  61167. (WebCore::SegmentedString::setExcludeLineNumbers):
  61168. (WebCore::SegmentedString::clear):
  61169. (WebCore::SegmentedString::append):
  61170. (WebCore::SegmentedString::prepend):
  61171. (WebCore::SegmentedString::advanceSubstring):
  61172. (WebCore::SegmentedString::toString):
  61173. * platform/text/SegmentedString.h:
  61174. (WebCore::SegmentedSubstring::SegmentedSubstring):
  61175. (WebCore::SegmentedSubstring::appendTo):
  61176. (WebCore::SegmentedString::SegmentedString):
  61177. (WebCore::SegmentedString::isComposite):
  61178. 2011-02-24 David Kilzer <ddkilzer@apple.com>
  61179. BUILD FIX: Add missing include for UnusedParam.h
  61180. Not reviewed.
  61181. * platform/mac/FileSystemMac.mm: Add include. It should have
  61182. originally been added with r76614.
  61183. 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
  61184. Reviewed by Alexey Proskuryakov.
  61185. DumpRenderTree should reset frame opener between tests.
  61186. https://bugs.webkit.org/show_bug.cgi?id=54874
  61187. No new tests. (no code affected, just exporting a method for DumpRenderTree use)
  61188. * WebCore.exp.in:
  61189. 2011-02-24 Dirk Schulze <krit@webkit.org>
  61190. Reviewed by Darin Adler.
  61191. Removing a SVG animation target during animation crashes WebKit
  61192. https://bugs.webkit.org/show_bug.cgi?id=12065
  61193. SVGAnimations with IRI references via 'xlink:href' are slow
  61194. https://bugs.webkit.org/show_bug.cgi?id=49437
  61195. Store reference to target element for SVG animation elements. This is important if the
  61196. target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple
  61197. times on every animation step. A very expensive operation. This will be avoided with this patch.
  61198. On the other hand, we need to be sure that the target element is always valid. The reference is
  61199. reset, if the target was removed from document or its destructor was called. A HashMap in
  61200. SVGDocumentExtensions stores all mappings from target element to all current animation elements.
  61201. Tests: svg/custom/animate-target-id-changed.svg
  61202. svg/custom/animate-target-removed-from-document.svg
  61203. * svg/SVGDocumentExtensions.cpp:
  61204. (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
  61205. (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target.
  61206. (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap.
  61207. (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all
  61208. references in SVG animation elements.
  61209. * svg/SVGDocumentExtensions.h:
  61210. * svg/SVGElement.cpp:
  61211. (WebCore::SVGElement::~SVGElement):
  61212. (WebCore::SVGElement::removedFromDocument):
  61213. (WebCore::SVGElement::attributeChanged):
  61214. * svg/SVGElement.h:
  61215. * svg/SVGHKernElement.cpp:
  61216. (WebCore::SVGHKernElement::removedFromDocument):
  61217. * svg/SVGVKernElement.cpp:
  61218. (WebCore::SVGVKernElement::removedFromDocument):
  61219. * svg/animation/SVGSMILElement.cpp:
  61220. (WebCore::SVGSMILElement::SVGSMILElement):
  61221. (WebCore::SVGSMILElement::removedFromDocument):
  61222. (WebCore::SVGSMILElement::eventBaseFor):
  61223. (WebCore::SVGSMILElement::targetElement):
  61224. * svg/animation/SVGSMILElement.h:
  61225. (WebCore::SVGSMILElement::resetTargetElement):
  61226. 2011-02-24 Simon Fraser <simon.fraser@apple.com>
  61227. Reviewed by Eric Seidel.
  61228. REGRESSION: Accelerated transitions are jumpy
  61229. https://bugs.webkit.org/show_bug.cgi?id=55022
  61230. When an accelerated transition used the default timing function,
  61231. a typo in toCAMediaTimingFunction() resulting in the incorrect
  61232. timing function being used.
  61233. Test: transitions/default-timing-function.html
  61234. * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  61235. (toCAMediaTimingFunction):
  61236. 2011-02-24 Andreas Kling <kling@webkit.org>
  61237. Reviewed by Kenneth Rohde Christiansen.
  61238. [Qt] Remove bogus optimizations in TextBreakIteratorQt
  61239. https://bugs.webkit.org/show_bug.cgi?id=55139
  61240. Let QTextBoundaryFinder hold a deep copy of the string data it's
  61241. operating on, and don't use the same working buffer for all iterators.
  61242. * platform/text/qt/TextBreakIteratorQt.cpp:
  61243. (WebCore::TextBreakIterator::TextBreakIterator):
  61244. (WebCore::setUpIterator):
  61245. 2011-02-24 Andrey Adaikin <aandrey@google.com>
  61246. Reviewed by Pavel Feldman.
  61247. Web Inspector: [Text editor] Bug in the highlighter
  61248. https://bugs.webkit.org/show_bug.cgi?id=54876
  61249. Tests: inspector/editor/highlighter-long-line.html
  61250. inspector/editor/highlighter-paste-in-comment.html
  61251. * inspector/front-end/TextEditorHighlighter.js:
  61252. (WebInspector.TextEditorHighlighter):
  61253. (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit):
  61254. (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
  61255. (WebInspector.TextEditorHighlighter.prototype._highlightLines):
  61256. 2011-02-24 James Simonsen <simonjam@chromium.org>
  61257. Reviewed by Tony Gentilcore.
  61258. [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
  61259. https://bugs.webkit.org/show_bug.cgi?id=55068
  61260. Test: http/tests/misc/webtiming-origins.html
  61261. * page/PerformanceTiming.cpp:
  61262. (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect.
  61263. (WebCore::PerformanceTiming::unloadEventStart): Ditto.
  61264. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
  61265. 2011-02-24 Adam Klein <adamk@chromium.org>
  61266. Reviewed by Darin Fisher.
  61267. [chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
  61268. https://bugs.webkit.org/show_bug.cgi?id=54516
  61269. Give Chromium's NetworkStateNotifier the ability to change the value
  61270. of m_isOnLine, rather than making it always true.
  61271. No new tests, not sure how to test this. No other LayoutTests seem
  61272. to exercise navigator.onLine.
  61273. * WebCore.gypi:
  61274. * platform/network/NetworkStateNotifier.cpp:
  61275. (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid.
  61276. * platform/network/NetworkStateNotifier.h:
  61277. (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine.
  61278. * platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
  61279. * platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
  61280. * platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.
  61281. 2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>
  61282. Reviewed by Eric Seidel.
  61283. Support building WebKit with Python 3
  61284. https://bugs.webkit.org/show_bug.cgi?id=55038
  61285. Add support for Python 3 without breaking support for Python 2.
  61286. Main issues:
  61287. -print is a function in Python 3
  61288. -list.sort() no longer have the cmp parameter
  61289. -string.uppercase and string.lowercase have been removed
  61290. * html/parser/create-html-entity-table:
  61291. 2011-02-24 Chris Fleizach <cfleizach@apple.com>
  61292. Reviewed by Eric Seidel.
  61293. AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
  61294. https://bugs.webkit.org/show_bug.cgi?id=55049
  61295. Make <math> elements behave as ARIA math roles and use MathML::alttext as a
  61296. possible accessible label.
  61297. Test: platform/mac/accessibility/math-alttext.html
  61298. * accessibility/AccessibilityRenderObject.cpp:
  61299. (WebCore::AccessibilityRenderObject::accessibilityDescription):
  61300. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  61301. * mathml/mathattrs.in:
  61302. 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
  61303. Reviewed by Pavel Feldman.
  61304. Web Inspector: adjust protocol message format according to spec.
  61305. https://bugs.webkit.org/show_bug.cgi?id=55140
  61306. * inspector/CodeGeneratorInspector.pm:
  61307. 2011-02-24 Adam Roben <aroben@apple.com>
  61308. Windows Production build fix
  61309. * platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for
  61310. <rdar://problem/9042114>.
  61311. 2011-02-23 Pavel Feldman <pfeldman@chromium.org>
  61312. Reviewed by Yury Semikhatsky.
  61313. Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
  61314. https://bugs.webkit.org/show_bug.cgi?id=55057
  61315. Test: inspector/console/command-line-api-inspect.html
  61316. I am working on getting rid of DOM agent pushes - everything should happen upon
  61317. front-end request. This patch changes the way we handle inspect() command line
  61318. api: instead of pushing nodes, we are telling front-end that inspect(object) has
  61319. been requested. It is then up to front-end to request dom nodes and focus them in
  61320. the tree. I also made inspect() work in a generic manner, using same routines for
  61321. nodes, databases, storages and potentially new elements.
  61322. As a side-effect, we don't do console.log from within inspect() anymore, but dump
  61323. inspected value as inspect's result.
  61324. Also, I added individual object release method and made object groups optional.
  61325. * bindings/js/JSInjectedScriptHostCustom.cpp:
  61326. (WebCore::InjectedScriptHost::scriptValueAsNode):
  61327. (WebCore::InjectedScriptHost::nodeAsScriptValue):
  61328. (WebCore::JSInjectedScriptHost::inspect):
  61329. (WebCore::JSInjectedScriptHost::databaseId):
  61330. (WebCore::JSInjectedScriptHost::storageId):
  61331. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  61332. (WebCore::InjectedScriptHost::scriptValueAsNode):
  61333. (WebCore::InjectedScriptHost::nodeAsScriptValue):
  61334. (WebCore::V8InjectedScriptHost::inspectCallback):
  61335. (WebCore::V8InjectedScriptHost::databaseIdCallback):
  61336. (WebCore::V8InjectedScriptHost::storageIdCallback):
  61337. * inspector/InjectedScript.cpp:
  61338. (WebCore::InjectedScript::nodeForObjectId):
  61339. (WebCore::InjectedScript::releaseObject):
  61340. (WebCore::InjectedScript::wrapForConsole):
  61341. (WebCore::InjectedScript::inspectNode):
  61342. * inspector/InjectedScript.h:
  61343. * inspector/InjectedScriptHost.cpp:
  61344. (WebCore::InjectedScriptHost::inspectImpl):
  61345. (WebCore::InjectedScriptHost::databaseIdImpl):
  61346. (WebCore::InjectedScriptHost::storageIdImpl):
  61347. * inspector/InjectedScriptHost.h:
  61348. * inspector/InjectedScriptHost.idl:
  61349. * inspector/InjectedScriptSource.js:
  61350. * inspector/Inspector.idl:
  61351. * inspector/InspectorAgent.cpp:
  61352. (WebCore::InspectorAgent::focusNode):
  61353. * inspector/InspectorDOMAgent.cpp:
  61354. * inspector/InspectorDOMAgent.h:
  61355. * inspector/InspectorDOMStorageAgent.cpp:
  61356. (WebCore::InspectorDOMStorageAgent::storageId):
  61357. (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  61358. * inspector/InspectorDOMStorageAgent.h:
  61359. * inspector/InspectorDOMStorageResource.cpp:
  61360. * inspector/InspectorDOMStorageResource.h:
  61361. * inspector/InspectorDatabaseAgent.cpp:
  61362. (WebCore::InspectorDatabaseAgent::databaseId):
  61363. * inspector/InspectorDatabaseAgent.h:
  61364. * inspector/InspectorDatabaseResource.cpp:
  61365. * inspector/InspectorDatabaseResource.h:
  61366. * inspector/InspectorRuntimeAgent.cpp:
  61367. (WebCore::InspectorRuntimeAgent::releaseObject):
  61368. * inspector/InspectorRuntimeAgent.h:
  61369. * inspector/front-end/AuditRules.js:
  61370. (WebInspector.AuditRules.evaluateInTargetWindow):
  61371. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  61372. * inspector/front-end/DOMStorage.js:
  61373. * inspector/front-end/Database.js:
  61374. * inspector/front-end/ExtensionServer.js:
  61375. (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  61376. * inspector/front-end/inspector.js:
  61377. (WebInspector.inspect):
  61378. 2011-02-22 Pavel Podivilov <podivilov@chromium.org>
  61379. Reviewed by Pavel Feldman.
  61380. Web Inspector: refactor "script or resource" mess in scripts panel.
  61381. https://bugs.webkit.org/show_bug.cgi?id=54961
  61382. - Use sourceName instead of scriptOrResource
  61383. - Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are
  61384. calling each other recursively with small one-purpose non-recursive functions
  61385. Test: inspector/debugger/scripts-panel.html
  61386. * inspector/front-end/ScriptsPanel.js:
  61387. (WebInspector.ScriptsPanel):
  61388. (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
  61389. (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  61390. (WebInspector.ScriptsPanel.prototype._addScript):
  61391. (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
  61392. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
  61393. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
  61394. (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
  61395. (WebInspector.ScriptsPanel.prototype.reset):
  61396. (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
  61397. (WebInspector.ScriptsPanel.prototype.showSourceLine):
  61398. (WebInspector.ScriptsPanel.prototype._showSourceFrame):
  61399. (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
  61400. (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
  61401. (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  61402. (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList):
  61403. (WebInspector.ScriptsPanel.prototype._sourceNameForScript):
  61404. (WebInspector.ScriptsPanel.prototype._scriptForSourceName):
  61405. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  61406. (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
  61407. (WebInspector.ScriptsPanel.prototype._goBack):
  61408. (WebInspector.ScriptsPanel.prototype._goForward):
  61409. * inspector/front-end/SourceFrame.js:
  61410. (WebInspector.SourceFrame.prototype.setExecutionLine):
  61411. 2011-02-24 Eric Seidel <eric@webkit.org>
  61412. Reviewed by Adam Barth.
  61413. Fragment parsing does not need to use HTMLSourceTracker
  61414. https://bugs.webkit.org/show_bug.cgi?id=55011
  61415. Any performance gains from this patch are likely
  61416. the result of working around:
  61417. https://bugs.webkit.org/show_bug.cgi?id=55005
  61418. (Which suggests that fixing bug 55005 will speed
  61419. up normal HTML parsing substantially.)
  61420. Assuming I ran the numbers correct, here is the
  61421. change from PerformanceTests/Parser/tiny-innerHTML:
  61422. Before patch:
  61423. avg 5586.1
  61424. median 5594
  61425. stdev 41.295157101045135
  61426. min 5425
  61427. max 5633
  61428. After Patch:
  61429. avg 2603.9
  61430. median 2609.5
  61431. stdev 32.500615378789355
  61432. min 2475
  61433. max 2649
  61434. Removing just the HTMLSourceTracker calls brought our
  61435. score from 5500 to 5200, removing the XSSFilter as well
  61436. brought it to 2600 on my machine.
  61437. * html/parser/HTMLDocumentParser.cpp:
  61438. (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  61439. (WebCore::HTMLDocumentParser::pumpTokenizer):
  61440. * html/parser/HTMLDocumentParser.h:
  61441. 2011-02-24 Andras Becsi <abecsi@webkit.org>
  61442. Reviewed by Laszlo Gombos.
  61443. [Qt] MinGW build fails to link
  61444. https://bugs.webkit.org/show_bug.cgi?id=55050
  61445. Prepend the libraries of subcomponents instead of appending them
  61446. to fix the library order according to the dependency of the libraries
  61447. No new tests needed.
  61448. * WebCore.pri:
  61449. 2011-02-24 Adam Barth <abarth@webkit.org>
  61450. Reviewed by Eric Seidel.
  61451. CSP's script-src should block JavaScript URLs
  61452. https://bugs.webkit.org/show_bug.cgi?id=54787
  61453. Blocking JavaScript URLs required some re-architecting of the lifetime
  61454. of the ContentSecurityPolicy object. We now manage the lifetime the
  61455. same way we manage the lifetime of the SecurityOrigin object. In
  61456. particular, when SecurityOrigin inherits into an about:blank iframe, we
  61457. inherit the CSP object as well. (This is covered by the test added in
  61458. this patch.) In the future, we might consider making
  61459. ContentSecurityPolicy a component of SecurityOrigin instead of a
  61460. component of Document.
  61461. I noted the trickiness in
  61462. http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
  61463. make sure it gets defined properly in the spec.
  61464. Test: http/tests/security/contentSecurityPolicy/javascript-url.html
  61465. * bindings/ScriptControllerBase.cpp:
  61466. (WebCore::ScriptController::executeIfJavaScriptURL):
  61467. * dom/Document.cpp:
  61468. (WebCore::Document::initSecurityContext):
  61469. * dom/Document.h:
  61470. (WebCore::Document::contentSecurityPolicy):
  61471. * page/ContentSecurityPolicy.cpp:
  61472. (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  61473. * page/ContentSecurityPolicy.h:
  61474. (WebCore::ContentSecurityPolicy::create):
  61475. 2011-02-21 Philippe Normand <pnormand@igalia.com>
  61476. Reviewed by Martin Robinson.
  61477. [GStreamer] GRefPtr support for GstElement
  61478. https://bugs.webkit.org/show_bug.cgi?id=54870
  61479. * CMakeListsEfl.txt:
  61480. * GNUmakefile.am:
  61481. * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added.
  61482. (WTF::GstElement):
  61483. * platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
  61484. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  61485. (webKitWebSrcQuery):
  61486. 2011-02-24 Emil A Eklund <eae@chromium.org>
  61487. Reviewed by Eric Seidel.
  61488. Share code between elementFromPoint and caretRangeFromPoint in Document.
  61489. https://bugs.webkit.org/show_bug.cgi?id=54610
  61490. Eliminate duplicate code by moving shared logic from elementFromPoint and
  61491. caretRangeFromPoint into helper function.
  61492. * dom/Document.cpp:
  61493. (WebCore::nodeFromPoint):
  61494. (WebCore::Document::elementFromPoint):
  61495. (WebCore::Document::caretRangeFromPoint):
  61496. 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
  61497. Unreviewed build fix.
  61498. * inspector/InspectorDOMAgent.cpp:
  61499. (WebCore::InspectorDOMAgent::removeAttribute):
  61500. * inspector/InspectorResourceAgent.cpp:
  61501. (WebCore::InspectorResourceAgent::cachedResources):
  61502. * inspector/InspectorRuntimeAgent.cpp:
  61503. (WebCore::InspectorRuntimeAgent::evaluate):
  61504. 2011-02-24 Zan Dobersek <zandobersek@gmail.com>
  61505. Reviewed by Eric Seidel.
  61506. [gtk] Failing collinear arcTo canvas tests
  61507. https://bugs.webkit.org/show_bug.cgi?id=54658
  61508. Check for collinearity of the three points that affect how arcTo call
  61509. results. This behavior is in accordance with the HTML standard.
  61510. No new tests added as this is already covered by at least two tests.
  61511. * platform/graphics/cairo/PathCairo.cpp:
  61512. (WebCore::areaOfTriangleFormedByPoints):
  61513. (WebCore::Path::addArcTo):
  61514. 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
  61515. Reviewed by Pavel Feldman.
  61516. Web Inspector: There is a validator of the protocol message format.
  61517. It has two parts. InspectorBackendStub.js is the frontend part.
  61518. InspectorBackendDispatcher.cpp is the backend part.
  61519. Both parts are checking protocol message format and report the error if
  61520. the message has not enough fields or the types of fields do not match with
  61521. Inspector.idl specification. These validators are generated automatically.
  61522. In addition, we have a number of places at the backend where we check the
  61523. function arguments and do nothing if the arguments are invalid
  61524. from the business logic point of view.
  61525. This patch bring us an ability to report a custom error from such function to the frontend.
  61526. https://bugs.webkit.org/show_bug.cgi?id=54971
  61527. * inspector/CodeGeneratorInspector.pm:
  61528. * inspector/InjectedScriptHost.cpp:
  61529. * inspector/InspectorAgent.cpp:
  61530. * inspector/InspectorAgent.h:
  61531. * inspector/InspectorApplicationCacheAgent.cpp:
  61532. * inspector/InspectorApplicationCacheAgent.h:
  61533. * inspector/InspectorBrowserDebuggerAgent.cpp:
  61534. * inspector/InspectorBrowserDebuggerAgent.h:
  61535. * inspector/InspectorCSSAgent.cpp:
  61536. * inspector/InspectorCSSAgent.h:
  61537. * inspector/InspectorConsoleAgent.cpp:
  61538. * inspector/InspectorConsoleAgent.h:
  61539. * inspector/InspectorController.cpp:
  61540. * inspector/InspectorDOMAgent.cpp:
  61541. * inspector/InspectorDOMAgent.h:
  61542. * inspector/InspectorDOMStorageAgent.cpp:
  61543. * inspector/InspectorDOMStorageAgent.h:
  61544. * inspector/InspectorDatabaseAgent.cpp:
  61545. * inspector/InspectorDatabaseAgent.h:
  61546. * inspector/InspectorDebuggerAgent.cpp:
  61547. * inspector/InspectorDebuggerAgent.h:
  61548. * inspector/InspectorProfilerAgent.cpp:
  61549. * inspector/InspectorProfilerAgent.h:
  61550. * inspector/InspectorResourceAgent.cpp:
  61551. * inspector/InspectorResourceAgent.h:
  61552. * inspector/InspectorRuntimeAgent.cpp:
  61553. * inspector/InspectorRuntimeAgent.h:
  61554. * inspector/InspectorTimelineAgent.cpp:
  61555. * inspector/InspectorTimelineAgent.h:
  61556. 2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
  61557. Reviewed by Ojan Vafai.
  61558. Crash when deleting inside a blockquote with a large offset
  61559. https://bugs.webkit.org/show_bug.cgi?id=55098
  61560. The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
  61561. While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
  61562. breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
  61563. the downstream position to instantiate caretPos.
  61564. Co-author: Abhishek Arya <inferno@chromium.org>.
  61565. Test: editing/deleting/delete-blockquote-large-offsets.html
  61566. * editing/CompositeEditCommand.cpp:
  61567. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  61568. 2011-02-24 Robert Kroeger <rjkroege@chromium.org>
  61569. Reviewed by Darin Fisher.
  61570. Added timestamps to PlatformTouchEvent etc.
  61571. PlatformTouchEvent doesn't have a timestamp and so
  61572. eventSender.leapForward cannot be used for touchevent based tests.
  61573. This change adds a timestamp to PlatformTouchEvent and initializes
  61574. it in a reasonable manner on Android and Qt platforms.
  61575. [chromium] [WebCore] [android] Touch events are missing time stamps
  61576. https://bugs.webkit.org/show_bug.cgi?id=53510
  61577. * platform/PlatformTouchEvent.h:
  61578. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  61579. (WebCore::PlatformTouchEvent::timestamp):
  61580. * platform/android/PlatformTouchEventAndroid.cpp:
  61581. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  61582. * platform/qt/PlatformTouchEventQt.cpp:
  61583. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  61584. 2011-02-24 Renata Hodovan <reni@webkit.org>
  61585. Unreviewed GTK, Snow Leopard build fix for r79474.
  61586. * platform/graphics/filters/FEConvolveMatrix.cpp:
  61587. (WebCore::FEConvolveMatrix::setKernelUnitLength):
  61588. * platform/graphics/filters/FEConvolveMatrix.h:
  61589. 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
  61590. Reviewed by Xan Lopez.
  61591. Use IntRect instead of a pointer to a GtkAllocation struct to avoid
  61592. unnecessary memory allocations.
  61593. * plugins/PluginView.h:
  61594. * plugins/gtk/PluginViewGtk.cpp:
  61595. (WebCore::PluginView::setNPWindowIfNeeded):
  61596. (WebCore::PluginView::plugAddedCallback):
  61597. 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
  61598. Unreviewed. Fix the build with GTK+ 3.
  61599. * plugins/PluginView.h:
  61600. 2011-02-23 Ryosuke Niwa <rniwa@webkit.org>
  61601. Reviewed by Darin Adler.
  61602. Refactor HTMLEquivalent into a hierachy of classes
  61603. https://bugs.webkit.org/show_bug.cgi?id=55025
  61604. Converted HTMLEquivalent into a class. Some logic in removeImplicitlyStyledElement is
  61605. extracted as member functions of HTMLEquivalent and its subclasses.
  61606. * editing/ApplyStyleCommand.cpp:
  61607. (WebCore::HTMLEquivalent::create): Added.
  61608. (WebCore::HTMLEquivalent::~HTMLEquivalent): Added.
  61609. (WebCore::HTMLEquivalent::matches): Returns true if the element is an equivalent, meaning that
  61610. the element's implicit style affects the property of this equivalence.
  61611. (WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalence requires attributes;
  61612. e.g. color, size, dir.
  61613. (WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the property of this equivalence
  61614. exists in the specified style. e.g. if this equivalence is for size attribute and font-size property,
  61615. this function returns true if the specified style has font-size property set.
  61616. (WebCore::HTMLEquivalent::HTMLEquivalent): Added.
  61617. (WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the specified style has the
  61618. implicit style of the specified element of this equivalence.
  61619. (WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the element of this equivalence
  61620. to the specified mutable style.
  61621. (WebCore::HTMLEquivalentValueList::create): Added.
  61622. (WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added.
  61623. (WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added.
  61624. (WebCore::HTMLEquivalentAttribute::create): Added.
  61625. (WebCore::HTMLEquivalentAttribute::matches): Added.
  61626. (WebCore::HTMLEquivalentAttribute::hasAttribute): Added.
  61627. (WebCore::HTMLEquivalentAttribute::attributeName): Added.
  61628. (WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added.
  61629. (WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added.
  61630. (WebCore::HTMLEquivalentAttribute::addToStyle): Added.
  61631. (WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added.
  61632. (WebCore::HTMLEquivalentFontSizeAttribute::create): Added.
  61633. (WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribute): Added.
  61634. (WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Added.
  61635. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new classes.
  61636. 2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
  61637. Unreviewed, rolling out r79510.
  61638. http://trac.webkit.org/changeset/79510
  61639. https://bugs.webkit.org/show_bug.cgi?id=55114
  61640. It made ~200 tests crash on Qt bot (Requested by Ossy_ on
  61641. #webkit).
  61642. * platform/text/TextBreakIterator.h:
  61643. * platform/text/TextBreakIteratorICU.cpp:
  61644. (WebCore::lineBreakIterator):
  61645. * platform/text/qt/TextBreakIteratorQt.cpp:
  61646. (WebCore::lineBreakIterator):
  61647. * rendering/RenderBlock.h:
  61648. * rendering/RenderBlockLineLayout.cpp:
  61649. (WebCore::RenderBlock::layoutInlineChildren):
  61650. (WebCore::RenderBlock::findNextLineBreak):
  61651. * rendering/RenderText.cpp:
  61652. (WebCore::RenderText::computePreferredLogicalWidths):
  61653. * rendering/break_lines.cpp:
  61654. (WebCore::nextBreakablePosition):
  61655. * rendering/break_lines.h:
  61656. (WebCore::isBreakable):
  61657. 2011-02-23 Geoffrey Garen <ggaren@apple.com>
  61658. Reviewed by Mark Rowe.
  61659. Used svn merge -r79502:79501 to roll out r79502 because it broke the
  61660. SnowLeopard and Leopard builds.
  61661. * WebCore.xcodeproj/project.pbxproj:
  61662. * platform/mac/HTMLConverter.h: Removed.
  61663. * platform/mac/HTMLConverter.mm: Removed.
  61664. * platform/mac/PasteboardMac.mm:
  61665. (WebCore::Pasteboard::writeSelection):
  61666. 2011-02-23 Beth Dakin <bdakin@apple.com>
  61667. Reviewed by Dan Bernstein.
  61668. Fix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
  61669. when scrolling
  61670. When there is both a horizontal and a vertical scrollbar, it is necessary to
  61671. include the space between them in the invalidation.
  61672. * platform/ScrollableArea.cpp:
  61673. (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
  61674. 2011-02-23 Ned Holbrook <nholbrook@apple.com>
  61675. Reviewed by Dan Bernstein.
  61676. Minimize calls to ubrk_setText()
  61677. https://bugs.webkit.org/show_bug.cgi?id=54912
  61678. <rdar://problem/9032774>
  61679. Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
  61680. break iterator creation until needed. This requires replacing the global line break iterator primitive with a
  61681. version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
  61682. layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
  61683. In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
  61684. * platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
  61685. (WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
  61686. (WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
  61687. (WebCore::LazyLineBreakIterator::string):
  61688. (WebCore::LazyLineBreakIterator::length):
  61689. (WebCore::LazyLineBreakIterator::get):
  61690. (WebCore::LazyLineBreakIterator::reset):
  61691. * platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
  61692. (WebCore::acquireLineBreakIterator):
  61693. (WebCore::releaseLineBreakIterator):
  61694. * platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.cpp.
  61695. (WebCore::acquireLineBreakIterator):
  61696. (WebCore::releaseLineBreakIterator):
  61697. * rendering/RenderBlock.h:
  61698. * rendering/RenderBlockLineLayout.cpp:
  61699. (WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
  61700. (WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
  61701. * rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
  61702. (WebCore::RenderText::computePreferredLogicalWidths):
  61703. * rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than TextBreakIterator.
  61704. (WebCore::nextBreakablePosition):
  61705. * rendering/break_lines.h: Accept LazyLineBreakIterator rather than TextBreakIterator.
  61706. (WebCore::isBreakable):
  61707. 2011-02-23 Anders Carlsson <andersca@apple.com>
  61708. Fix build.
  61709. * platform/mac/HTMLConverter.h:
  61710. 2011-02-17 Enrica Casucci <enrica@apple.com>
  61711. Reviewed by Darin Adler.
  61712. REGRESSION: Copied content loses formatting on paste to external apps.
  61713. https://bugs.webkit.org/show_bug.cgi?id=47615
  61714. <rdar://problem/9001214>
  61715. This patch adds a way for WebKit2 to create NSAttributedStrings from
  61716. a DOM range without using the AppKit api initWithDOMRange that internally
  61717. needs to access the WebView. The NSAttributedString is needed to create
  61718. RTF formats in the pasteboard.
  61719. This is to be considered a first step, since in the future we want to have
  61720. an implementation based on the TextIterator.
  61721. * WebCore.xcodeproj/project.pbxproj: Added new file.
  61722. * platform/mac/HTMLConverter.h: Added.
  61723. * platform/mac/HTMLConverter.mm: Added.
  61724. * platform/mac/PasteboardMac.mm:
  61725. (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
  61726. class for WebKit2 to create the NSAttributedString from the DOM range.
  61727. 2011-02-23 David Hyatt <hyatt@apple.com>
  61728. Reviewed by Sam Weinig.
  61729. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61730. Patch computePositionedLogicalHeightUsing to be writing-mode-aware.
  61731. * rendering/RenderBox.cpp:
  61732. (WebCore::RenderBox::computePositionedLogicalWidthUsing):
  61733. (WebCore::RenderBox::computePositionedLogicalHeightUsing):
  61734. * rendering/RenderBox.h:
  61735. 2011-02-23 Martin Robinson <mrobinson@igalia.com>
  61736. Reviewed by Xan Lopez.
  61737. [Gtk] Flash item placed on wrong location right after load
  61738. https://bugs.webkit.org/show_bug.cgi?id=37769
  61739. If a plugin is GtkSocket based, do not set the widget allocation until the
  61740. window is actually embedded in the parent. When the window is embedded, use
  61741. any pending allocation for the call to gtk_widget_size_allocate. This bug
  61742. seems to only appear with Flash movies loaded as the src of an iframe.
  61743. * manual-tests/plugins/windowed-in-iframe.html: Added.
  61744. * plugins/PluginView.h: Add a few new members to track window embedding state.
  61745. * plugins/gtk/PluginViewGtk.cpp:
  61746. (WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin
  61747. wait until the plug-added signal fires to set the widget allocation.
  61748. (WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that
  61749. we can access private members. If there is a pending allocation, call gtk_widget_size_allocate
  61750. with it.
  61751. (WebCore::PluginView::platformStart): Update the plugin state, so that we do not
  61752. call gtk_widget_size_allocate if the window isn't embedded.
  61753. 2011-02-18 Enrica Casucci <enrica@apple.com>
  61754. Reviewed by Adam Roben.
  61755. Mac OS X Services are not available for selected text in WebKit2 windows.
  61756. https://bugs.webkit.org/show_bug.cgi?id=54777
  61757. <rdar://problem/8666428>
  61758. The changes to WebCore for this bug are limited to exposing a new
  61759. entry point in the Editor class to write to the pasteboard and
  61760. changes to the Pasteboard class to write the selection with
  61761. a given set of pasteboard types. The majority of the work
  61762. is done in WebKit2.
  61763. * WebCore.exp.in:
  61764. * editing/Editor.h:
  61765. * editing/mac/EditorMac.mm: Added entrypoint to write the
  61766. selection to the pasteboard.
  61767. (WebCore::Editor::writeSelectionToPasteboard):
  61768. * platform/Pasteboard.h:
  61769. * platform/mac/ClipboardMac.mm:
  61770. (WebCore::ClipboardMac::writeRange):
  61771. * platform/mac/PasteboardMac.mm:
  61772. (WebCore::Pasteboard::writeSelection):
  61773. 2011-02-23 David Hyatt <hyatt@apple.com>
  61774. Reviewed by Simon Fraser.
  61775. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61776. Patch computePositionedLogicalHeight to be writing-mode-aware. Functions it calls have not been
  61777. patched yet, so still not testable in a vertical text environment.
  61778. * rendering/RenderBox.cpp:
  61779. (WebCore::RenderBox::computePositionedLogicalHeight):
  61780. 2011-02-23 David Hyatt <hyatt@apple.com>
  61781. Reviewed by Sam Weinig.
  61782. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61783. Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
  61784. environment, since height computations will overwrite all values computed here until they are patched as well.
  61785. * rendering/RenderBox.cpp:
  61786. (WebCore::RenderBox::computePositionedLogicalWidthUsing):
  61787. * rendering/RenderBox.h:
  61788. 2011-02-23 Renata Hodovan <reni@webkit.org>
  61789. Reviewed by Nikolas Zimmermann.
  61790. FEColorMatrixElement changes doesn't require relayout
  61791. https://bugs.webkit.org/show_bug.cgi?id=54880
  61792. When the FEColorMatrixElement receives an update message but the given value remains the same we don't need
  61793. to relayout the filter.
  61794. No new tests are needed because this modificiation is covered by the dynamic update tests of FEColorMatrix.
  61795. * platform/graphics/filters/FEColorMatrix.cpp:
  61796. (WebCore::FEColorMatrix::setType):
  61797. (WebCore::FEColorMatrix::setValues):
  61798. * platform/graphics/filters/FEColorMatrix.h:
  61799. * svg/SVGFEColorMatrixElement.cpp:
  61800. (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute):
  61801. (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
  61802. * svg/SVGFEColorMatrixElement.h:
  61803. 2011-02-23 James Robinson <jamesr@chromium.org>
  61804. REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name.html fails
  61805. Reverts TextCodecUTF16.cpp back to pre-79466 state. The crash fix in 79466 was for UTF-8 only, it also caused the UTF16 path to fail.
  61806. * platform/text/TextCodecUTF16.cpp:
  61807. (WebCore::newStreamingTextDecoderUTF16LE):
  61808. (WebCore::newStreamingTextDecoderUTF16BE):
  61809. (WebCore::TextCodecUTF16::decode):
  61810. (WebCore::TextCodecUTF16::encode):
  61811. 2011-02-23 David Hyatt <hyatt@apple.com>
  61812. Reviewed by Sam Weinig.
  61813. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61814. Patch computePositionedLogicalWidth to be writing-mode-aware. Functions it calls have not been
  61815. patched yet, so still not testable in a vertical text environment.
  61816. * rendering/RenderBox.cpp:
  61817. (WebCore::RenderBox::computePositionedLogicalWidth):
  61818. 2011-02-23 James Robinson <jamesr@chromium.org>
  61819. Unreviewed, rolling out r79428.
  61820. http://trac.webkit.org/changeset/79428
  61821. https://bugs.webkit.org/show_bug.cgi?id=54714
  61822. Does not work in the Chromium sandbox
  61823. * websockets/WebSocketHandshake.cpp:
  61824. (WebCore::generateSecWebSocketKey):
  61825. (WebCore::generateKey3):
  61826. 2011-02-23 David Hyatt <hyatt@apple.com>
  61827. Reviewed by Sam Weinig.
  61828. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61829. Add logical accessors for the left()/right()/top()/bottom() properties on the RenderStyle.
  61830. * rendering/style/RenderStyle.h:
  61831. (WebCore::InheritedFlags::logicalLeft):
  61832. (WebCore::InheritedFlags::logicalRight):
  61833. (WebCore::InheritedFlags::logicalTop):
  61834. (WebCore::InheritedFlags::logicalBottom):
  61835. 2011-02-23 Darin Adler <darin@apple.com>
  61836. Reviewed by Alexey Proskuryakov.
  61837. Fix crash seen in one of the regression tests.
  61838. * platform/text/TextCodecUTF16.cpp:
  61839. (WebCore::TextCodecUTF16::decode): Handle case where we did not decode any new data,
  61840. we were not told to flush, and we had a buffered byte. The assertion here was incorrect,
  61841. and the correct thing to do is nothing.
  61842. 2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>
  61843. Reviewed by James Robinson.
  61844. SVGCursorElement::removeClient() should verify that its argument is connected with
  61845. the proper cursor element.
  61846. https://bugs.webkit.org/show_bug.cgi?id=54979
  61847. Test: svg/css/multiple-cursors-crash.html
  61848. * svg/SVGCursorElement.cpp:
  61849. (WebCore::SVGCursorElement::removeClient):
  61850. 2011-02-23 Renata Hodovan <reni@webkit.org>
  61851. Reviewed by Darin Adler.
  61852. FEConvolveMatrixElement changes doesn't require relayout
  61853. https://bugs.webkit.org/show_bug.cgi?id=55067
  61854. When the FEConvolveMatrixElement receives an update message but the
  61855. given value remains the same we don't need to relayout the filter.
  61856. No new tests are needed because this modificiation is covered by the
  61857. dynamic update tests of FEConvolveMatrix.
  61858. * platform/graphics/filters/FEConvolveMatrix.cpp:
  61859. (WebCore::FEConvolveMatrix::setDivisor):
  61860. (WebCore::FEConvolveMatrix::setBias):
  61861. (WebCore::FEConvolveMatrix::setTargetOffset):
  61862. (WebCore::FEConvolveMatrix::edgeMode):
  61863. (WebCore::FEConvolveMatrix::setEdgeMode):
  61864. (WebCore::FEConvolveMatrix::setPreserveAlpha):
  61865. * platform/graphics/filters/FEConvolveMatrix.h:
  61866. * svg/SVGFEConvolveMatrixElement.cpp:
  61867. (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute):
  61868. (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  61869. * svg/SVGFEConvolveMatrixElement.h:
  61870. 2011-02-23 Geoffrey Garen <ggaren@apple.com>
  61871. Reviewed by Darin Adler.
  61872. Rolled back in r79367 with SnowLeopard Release bot crash fixed.
  61873. https://bugs.webkit.org/show_bug.cgi?id=54999
  61874. * ForwardingHeaders/wtf/DoublyLinkedList.h: Added.
  61875. 2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
  61876. Reviewed by Darin Adler.
  61877. Add more thorough manual test coverage for media controls
  61878. https://bugs.webkit.org/show_bug.cgi?id=55006
  61879. * manual-tests/media-controls.html: Added.
  61880. 2011-02-23 Darin Adler <darin@apple.com>
  61881. Fix build.
  61882. * platform/text/TextCodecUTF16.cpp:
  61883. (WebCore::TextCodecUTF16::decode): Removed stray unused local variable.
  61884. 2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
  61885. Reviewed by Darin Adler.
  61886. Setting shadow host should also attach and set inDocument, just like
  61887. appending/inserting a child.
  61888. https://bugs.webkit.org/show_bug.cgi?id=55065
  61889. No new tests, because functionality is not yet used.
  61890. * dom/Element.cpp:
  61891. (WebCore::Element::setShadowRoot): Add attaching and setting inDocument
  61892. for the shadow DOM subtree, like the host.
  61893. 2011-02-23 David Hyatt <hyatt@apple.com>
  61894. Reviewed by Darin Adler and Simon Fraser.
  61895. https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
  61896. - Add clientLogicalWidth and clientLogicalHeight that call the correct clientWidth or clientHeight based off
  61897. writing-mode.
  61898. - Patch clientLogicalBottom to use clientLogicalHeight.
  61899. - Convert containingBlockWidthForPositioned and containingBlockHeightForPositioned to be logical and to make use of
  61900. clientLogicalHeight/Width. Also make them able to handle perpendicular writing mode containining blocks.
  61901. - Refine containingBlockLogicalHeightForPositioned to match containingBlockLogicalWidthForPositioned more closely.
  61902. * rendering/RenderBox.cpp:
  61903. (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
  61904. (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
  61905. (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
  61906. (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
  61907. (WebCore::RenderBox::computePositionedLogicalWidth):
  61908. (WebCore::RenderBox::computePositionedLogicalHeight):
  61909. (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
  61910. (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
  61911. * rendering/RenderBox.h:
  61912. (WebCore::RenderBox::clientLogicalWidth):
  61913. (WebCore::RenderBox::clientLogicalHeight):
  61914. (WebCore::RenderBox::clientLogicalBottom):
  61915. 2011-02-23 Darin Adler <darin@apple.com>
  61916. Reviewed by Alexey Proskuryakov.
  61917. REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
  61918. https://bugs.webkit.org/show_bug.cgi?id=54862
  61919. Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 decoders when flushing with zero length
  61920. https://bugs.webkit.org/show_bug.cgi?id=54444
  61921. No new tests at this time. I will add some tests later, but since multiple
  61922. people are hitting this I wanted to get it in as quickly as possible.
  61923. * platform/text/TextCodecUTF16.cpp:
  61924. (WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit.
  61925. Removed special case for zero length now that main code handles it
  61926. correctly. Used words instead of abbreviations for local variable names.
  61927. Added error handling for a trailing byte.
  61928. * platform/text/TextCodecUTF8.cpp:
  61929. (WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper function
  61930. to make the handleError and handlePartialSequence functions clearer.
  61931. (WebCore::TextCodecUTF8::handleError): Added. Helper function to make the
  61932. handlePartialSequence clearer.
  61933. (WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out code for
  61934. the partial sequence case. Making this a separate function probably helps make
  61935. the fast case a little faster. This new version handles more cases correctly,
  61936. which is what fixes the crashes we were seeing. In particular, it no longer
  61937. assumes that the partial sequence is truly partial, because there are cases
  61938. where we end up handling complete sequences here, such as when a complete
  61939. sequence is inside a malformed partial sequence.
  61940. (WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this
  61941. call handlePartialSequence instead. Could be streamlined if we double checked
  61942. that passing a reference to "destination" and "source" doesn't harm code
  61943. generation too much, so perhaps someone can do that research on a few compilers
  61944. later and clean this up. Removed special case for zero length now that the
  61945. main code handles that correctly.
  61946. * platform/text/TextCodecUTF8.h: Added declarations for new functions.
  61947. Made partial sequence buffer large enough to hold a whole sequence so we can
  61948. use it to complete and decode a sequence in place.
  61949. 2011-02-23 Abhishek Arya <inferno@chromium.org>
  61950. Reviewed by Dave Hyatt.
  61951. Make clear float lineboxes resilient against overflows.
  61952. https://bugs.webkit.org/show_bug.cgi?id=54995
  61953. We try to dirty everthing in block range if we have a negative
  61954. logical bottom, or if our logical bottom is less than our logical
  61955. top, or if our logical top is equal to INT_MAX. Plus, we also dirty
  61956. a linebox if its block logical height is less than zero.
  61957. Tests: fast/overflow/overflow-height-float-not-removed-crash2.html
  61958. fast/overflow/overflow-height-float-not-removed-crash3.html
  61959. * rendering/RenderBlock.cpp:
  61960. (WebCore::RenderBlock::removeFloatingObject):
  61961. (WebCore::RenderBlock::markLinesDirtyInBlockRange):
  61962. * rendering/RootInlineBox.cpp:
  61963. (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack
  61964. added in r69735. we don't need this anymore since we are making the
  61965. underlying float dirty logic resilient.
  61966. 2011-02-22 Kenneth Russell <kbr@google.com>
  61967. Reviewed by Darin Fisher.
  61968. Per-page minimum DOMTimer interval broken for repeating timers
  61969. https://bugs.webkit.org/show_bug.cgi?id=55014
  61970. When the minimum timer interval is adjusted, if the timer is
  61971. repeating, cause its repeat interval to be set to its original
  61972. timeout clamped to the new minimum interval.
  61973. Tests: fast/dom/timer-increase-min-interval-repeating.html
  61974. fast/dom/timer-increase-then-decrease-min-interval-repeating.html
  61975. * page/DOMTimer.cpp:
  61976. (WebCore::DOMTimer::adjustMinimumTimerInterval):
  61977. 2011-02-23 Dan Bernstein <mitz@apple.com>
  61978. Reviewed by Maciej Stachowiak.
  61979. Fix two issues seen in WebKit2 views on Mac:
  61980. - <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
  61981. - <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text
  61982. * page/EventHandler.cpp:
  61983. (WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
  61984. to -1. Since WebKit2 doesn�t support non-activating clicks yet (<http://webkit.org/b/55053>
  61985. <rdar://problem/9042197>) and doesn�t send event numbers, all events were considered to be
  61986. window-activating events. This in turn prevented them from clearing the selection and resuming
  61987. caret blinking on mouse up.
  61988. 2011-02-23 Jacob Dinu <dinu.jacob@nokia.com>
  61989. Reviewed by Pavel Feldman.
  61990. Web Inspector: Linking error for some InspectorController symbols
  61991. https://bugs.webkit.org/show_bug.cgi?id=54953
  61992. Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag
  61993. * inspector/InspectorController.cpp:
  61994. (WebCore::InspectorController::hideHighlight):
  61995. (WebCore::InspectorController::resume):
  61996. 2011-02-23 Hans Wennborg <hans@chromium.org>
  61997. IndexedDB: Move some SQL code into IDBBackingStore
  61998. https://bugs.webkit.org/show_bug.cgi?id=54889
  61999. The idea is to gather all the SQL logic into IDBBackingStore.
  62000. No new functionality, so no new tests.
  62001. * storage/IDBBackingStore.cpp:
  62002. (WebCore::IDBBackingStore::IDBBackingStore):
  62003. (WebCore::runCommands):
  62004. (WebCore::createTables):
  62005. (WebCore::createMetaDataTable):
  62006. (WebCore::getDatabaseSchemaVersion):
  62007. (WebCore::migrateDatabase):
  62008. (WebCore::IDBBackingStore::open):
  62009. (WebCore::IDBBackingStore::extractIDBDatabaseMetaData):
  62010. (WebCore::IDBBackingStore::setIDBDatabaseMetaData):
  62011. (WebCore::IDBBackingStore::getObjectStores):
  62012. (WebCore::IDBBackingStore::createObjectStore):
  62013. (WebCore::doDelete):
  62014. (WebCore::IDBBackingStore::deleteObjectStore):
  62015. (WebCore::whereSyntaxForKey):
  62016. (WebCore::bindKeyToQuery):
  62017. (WebCore::IDBBackingStore::getObjectStoreRecord):
  62018. (WebCore::bindKeyToQueryWithNulls):
  62019. (WebCore::IDBBackingStore::putObjectStoreRecord):
  62020. (WebCore::IDBBackingStore::deleteIndexDataForRecord):
  62021. (WebCore::IDBBackingStore::putIndexDataForRecord):
  62022. (WebCore::IDBBackingStore::createIndex):
  62023. (WebCore::IDBBackingStore::deleteIndex):
  62024. (WebCore::IDBBackingStore::clearObjectStore):
  62025. * storage/IDBBackingStore.h:
  62026. * storage/IDBDatabaseBackendImpl.cpp:
  62027. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  62028. (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
  62029. (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
  62030. (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
  62031. (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  62032. * storage/IDBFactoryBackendImpl.cpp:
  62033. (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
  62034. (WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
  62035. (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
  62036. (WebCore::IDBFactoryBackendImpl::open):
  62037. * storage/IDBFactoryBackendImpl.h:
  62038. * storage/IDBObjectStoreBackendImpl.cpp:
  62039. (WebCore::IDBObjectStoreBackendImpl::getInternal):
  62040. (WebCore::IDBObjectStoreBackendImpl::putInternal):
  62041. (WebCore::IDBObjectStoreBackendImpl::clearInternal):
  62042. (WebCore::populateIndex):
  62043. (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
  62044. (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
  62045. 2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
  62046. Reviewed by Laszlo Gombos.
  62047. [Qt] Fix the Symbian build after r79334
  62048. https://bugs.webkit.org/show_bug.cgi?id=55044
  62049. No new tests as there is no new functionality.
  62050. * WebCore.pri: Reorder symbian blocks to make sure that
  62051. system-sqlite is set before it is tested.
  62052. Copy the rules from JavaScriptCore.pri for defineTest().
  62053. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  62054. Reviewed by Alexey Proskuryakov.
  62055. Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
  62056. https://bugs.webkit.org/show_bug.cgi?id=54992
  62057. * websockets/WebSocketHandshake.cpp:
  62058. (WebCore::WebSocketHandshake::readHTTPHeaders):
  62059. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  62060. Reviewed by Andreas Kling.
  62061. [CMake] Move platform dependent files out of main CMakeLists.txt
  62062. https://bugs.webkit.org/show_bug.cgi?id=53891
  62063. Apple Windows port does not use the image decoders,
  62064. so move them into the platform specific CMake files.
  62065. * CMakeLists.txt:
  62066. * CMakeListsEfl.txt:
  62067. * CMakeListsWinCE.txt:
  62068. 2011-02-21 Stephen White <senorblanco@chromium.org>
  62069. Reviewed by Kenneth Russell.
  62070. Jittering when animating a rotated image
  62071. https://bugs.webkit.org/show_bug.cgi?id=50775
  62072. Since Skia does not seem to suffer from pixel cracks when scaling to
  62073. non-integral sizes the way CG does, no-op roundToDevicePixels on the
  62074. Skia implementation.
  62075. * platform/graphics/skia/GraphicsContextSkia.cpp:
  62076. (WebCore::GraphicsContext::roundToDevicePixels):
  62077. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  62078. Reviewed by Andreas Kling.
  62079. [WINCE] Get rid of TemporaryLinkStubs.cpp
  62080. https://bugs.webkit.org/show_bug.cgi?id=54825
  62081. * CMakeListsWinCE.txt:
  62082. * platform/network/win/CookieStorageWin.cpp: Copied from platform/wince/TemporaryLinkStubs.cpp.
  62083. * platform/wince/TemporaryLinkStubs.cpp: Removed.
  62084. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  62085. Reviewed by Darin Adler.
  62086. Rename PLATFORM(CF) to USE(CF)
  62087. https://bugs.webkit.org/show_bug.cgi?id=53540
  62088. * WebCore.gyp/WebCore.gyp:
  62089. * editing/SmartReplace.cpp:
  62090. * editing/SmartReplaceICU.cpp:
  62091. * loader/MainResourceLoader.cpp:
  62092. (WebCore::MainResourceLoader::didReceiveResponse):
  62093. (WebCore::MainResourceLoader::didReceiveData):
  62094. (WebCore::MainResourceLoader::didFinishLoading):
  62095. (WebCore::MainResourceLoader::didFail):
  62096. * loader/archive/ArchiveFactory.cpp:
  62097. (WebCore::archiveMIMETypes):
  62098. * platform/FileSystem.h:
  62099. * platform/KURL.h:
  62100. * platform/KURLGoogle.cpp:
  62101. * platform/RunLoopTimer.h:
  62102. * platform/SharedBuffer.cpp:
  62103. * platform/SharedBuffer.h:
  62104. * platform/UUID.cpp:
  62105. (WebCore::createCanonicalUUIDString):
  62106. * platform/network/ResourceHandle.h:
  62107. * platform/network/ResourceRequestBase.h:
  62108. * platform/network/curl/ResourceHandleCurl.cpp:
  62109. * platform/network/curl/ResourceHandleManager.cpp:
  62110. (WebCore::certificatePath):
  62111. * platform/text/cf/StringCF.cpp:
  62112. * platform/text/cf/StringImplCF.cpp:
  62113. * platform/win/BString.cpp:
  62114. * platform/win/BString.h:
  62115. * platform/win/ClipboardUtilitiesWin.cpp:
  62116. (WebCore::getWebLocData):
  62117. (WebCore::getURL):
  62118. (WebCore::getClipboardData):
  62119. * platform/win/ClipboardWin.cpp:
  62120. (WebCore::writeFileToDataObject):
  62121. * platform/win/SearchPopupMenuWin.cpp:
  62122. (WebCore::SearchPopupMenuWin::enabled):
  62123. (WebCore::SearchPopupMenuWin::saveRecentSearches):
  62124. (WebCore::SearchPopupMenuWin::loadRecentSearches):
  62125. 2011-02-23 Benjamin Kalman <kalman@chromium.org>
  62126. Reviewed by Ojan Vafai.
  62127. Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
  62128. https://bugs.webkit.org/show_bug.cgi?id=51001
  62129. Test: editing/selection/extend-backward-by-word-over-non-editable.html
  62130. Revert some previous changes (the TextIteratorEndsAtEditingBoundary text iteration behaviour) which caused this
  62131. bug in the first place, and fix SimplifiedBackwardsTextIterator's iteration range check as an alternative fix.
  62132. The original bug was that double-clicking on an inline editable span at the start of a paragraph would clear the
  62133. selection (webkit.org/b/36360). This was caused by upstream/downstream VisbiblePosition complications. To fix,
  62134. refuse to iterate beyond the start node (rather than refusing to iterate across editable boundaries, which
  62135. causes this bug).
  62136. To see why this is correct, and to make it clearer that is indeed what is happening, the text iterator code has
  62137. been slightly restructured to express the invariant that the iterator will never advance past the start node.
  62138. * editing/TextIterator.cpp:
  62139. (WebCore::TextIterator::TextIterator): Remove references to TextIterationEndsAtEditing boundary.
  62140. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Remove m_pastStartNode as the
  62141. mechanism for iteration range checking, and use a flag m_havePassedStartNode instead.
  62142. (WebCore::SimplifiedBackwardsTextIterator::advance): Clean up, use advanceRespectingRange and
  62143. m_havePassedStartNode for iteration range checking rather than m_pastStartNode.
  62144. (WebCore::SimplifiedBackwardsTextIterator::advanceRespectingRange): The new way of modifying m_node
  62145. which updates m_havePassedStartNode and refuses to continue when it becomes true.
  62146. * editing/TextIterator.h: Remove TextIteratorEndsAtEditingBoundary, update for new/removed prototypes and
  62147. member variables.
  62148. * editing/visible_units.cpp:
  62149. (WebCore::previousBoundary): Remove references to TextIteratorEndsAtEditingBoundary.
  62150. 2011-02-23 Fumitoshi Ukai <ukai@chromium.org>
  62151. Reviewed by Adam Barth.
  62152. WebSocket uses insecure random numbers
  62153. https://bugs.webkit.org/show_bug.cgi?id=54714
  62154. * websockets/WebSocketHandshake.cpp:
  62155. (WebCore::randomNumberLessThan):
  62156. (WebCore::generateSecWebSocketKey):
  62157. (WebCore::generateKey3):
  62158. 2011-02-21 Hans Wennborg <hans@chromium.org>
  62159. Reviewed by Jeremy Orlow.
  62160. IndexedDB: Rename IDBSQLiteDatabase to IDBBackingStore
  62161. https://bugs.webkit.org/show_bug.cgi?id=54864
  62162. No new functionality, so no new tests.
  62163. * GNUmakefile.am:
  62164. * WebCore.gypi:
  62165. * storage/IDBBackingStore.cpp:
  62166. (WebCore::IDBBackingStore::IDBBackingStore):
  62167. (WebCore::IDBBackingStore::~IDBBackingStore):
  62168. * storage/IDBBackingStore.h:
  62169. (WebCore::IDBBackingStore::create):
  62170. (WebCore::IDBBackingStore::db):
  62171. * storage/IDBCursorBackendImpl.cpp:
  62172. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
  62173. (WebCore::IDBCursorBackendImpl::currentRowExists):
  62174. (WebCore::IDBCursorBackendImpl::database):
  62175. * storage/IDBCursorBackendImpl.h:
  62176. (WebCore::IDBCursorBackendImpl::create):
  62177. * storage/IDBDatabaseBackendImpl.cpp:
  62178. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  62179. (WebCore::IDBDatabaseBackendImpl::sqliteDatabase):
  62180. (WebCore::IDBDatabaseBackendImpl::createObjectStore):
  62181. (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
  62182. (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  62183. * storage/IDBDatabaseBackendImpl.h:
  62184. (WebCore::IDBDatabaseBackendImpl::create):
  62185. * storage/IDBFactoryBackendImpl.cpp:
  62186. (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
  62187. (WebCore::openSQLiteDatabase):
  62188. (WebCore::IDBFactoryBackendImpl::open):
  62189. * storage/IDBFactoryBackendImpl.h:
  62190. * storage/IDBIndexBackendImpl.cpp:
  62191. (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
  62192. (WebCore::IDBIndexBackendImpl::openCursorInternal):
  62193. (WebCore::IDBIndexBackendImpl::sqliteDatabase):
  62194. * storage/IDBIndexBackendImpl.h:
  62195. (WebCore::IDBIndexBackendImpl::create):
  62196. * storage/IDBObjectStoreBackendImpl.cpp:
  62197. (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
  62198. (WebCore::IDBObjectStoreBackendImpl::createIndex):
  62199. (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  62200. (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
  62201. (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
  62202. * storage/IDBObjectStoreBackendImpl.h:
  62203. (WebCore::IDBObjectStoreBackendImpl::create):
  62204. 2011-02-23 Dominic Mazzoni <dmazzoni@google.com>
  62205. Reviewed by Kenneth Russell.
  62206. Add a hit test handler for canvas elements that handles clicks on the canvas but ignores children.
  62207. https://bugs.webkit.org/show_bug.cgi?id=54697
  62208. New test to prevent this from regressing in the future: canvas/canvas-mouse-events.html
  62209. * rendering/RenderHTMLCanvas.cpp:
  62210. (WebCore::RenderHTMLCanvas::nodeAtPoint):
  62211. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  62212. Reviewed by Darin Adler.
  62213. Remove obsolete focusRingColor functions
  62214. https://bugs.webkit.org/show_bug.cgi?id=54824
  62215. * CMakeListsWinCE.txt:
  62216. * platform/graphics/haiku/ColorHaiku.cpp:
  62217. * platform/graphics/wince/ColorWinCE.cpp: Removed.
  62218. 2011-02-22 Jia Pu <jpu@apple.com>
  62219. Reviewed by Dan Bernstein.
  62220. On Mac OS X, English contractions are marked misspelled with certain user preference setting.
  62221. https://bugs.webkit.org/show_bug.cgi?id=54975
  62222. manual test: manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html
  62223. Without this patch, we check for contraction only when autocorrection or other type of auto-
  62224. substituation is on. And we failed to check for contraction if only spellchecking is turned on.
  62225. This patch implements the desired behavior, checking for contraction when either correction/substitution,
  62226. or spellchecking, is on.
  62227. * editing/Editor.cpp:
  62228. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  62229. * manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html: Added.
  62230. 2011-02-22 Charlie Reis <creis@chromium.org>
  62231. Reviewed by Darin Fisher.
  62232. Remove DatabasePolicy from FrameLoaderTypes
  62233. https://bugs.webkit.org/show_bug.cgi?id=54968
  62234. The DatabasePolicy enum is no longer needed now that we avoid stopping
  62235. loaders on same-document navigations.
  62236. Existing test: storage/hash-change-with-xhr.html
  62237. * WebCore.exp.in:
  62238. * loader/DocumentLoader.cpp:
  62239. * loader/DocumentLoader.h:
  62240. * loader/FrameLoader.cpp:
  62241. * loader/FrameLoader.h:
  62242. * loader/FrameLoaderTypes.h:
  62243. * workers/WorkerThread.cpp:
  62244. 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
  62245. Reviewed by Andreas Kling.
  62246. [Qt] QWebView ignores a palette set with QWebView::setPalette()
  62247. https://bugs.webkit.org/show_bug.cgi?id=31742
  62248. Use custom QWebView palette if the view provides one.
  62249. Modified version of a patch made by Fabrizio Machado.
  62250. * platform/qt/RenderThemeQt.cpp:
  62251. (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
  62252. (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
  62253. (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
  62254. (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
  62255. (WebCore::RenderThemeQt::platformFocusRingColor):
  62256. 2011-02-22 Brian Salomon <bsalomon@google.com>
  62257. Reviewed by Kenneth Russell.
  62258. Don't disable accelerated canvas when using the skia gpu backend.
  62259. No new tests are required.
  62260. * html/canvas/CanvasRenderingContext2D.cpp:
  62261. (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  62262. 2011-02-22 Luiz Agostini <luiz.agostini@openbossa.org>
  62263. Reviewed by Kenneth Rohde Christiansen.
  62264. [Qt] <select>s on http://www.ryanair.com render wrong
  62265. https://bugs.webkit.org/show_bug.cgi?id=29647
  62266. Reducing padding in <select> elements to improve its rendering and introducing a
  62267. rendering adjustment specific to QMacStyle.
  62268. * platform/qt/RenderThemeQt.cpp:
  62269. (WebCore::RenderThemeQt::setPopupPadding):
  62270. (WebCore::RenderThemeQt::paintMenuList):
  62271. 2011-02-22 Andreas Kling <kling@webkit.org>
  62272. Reviewed by Dan Bernstein.
  62273. FontCache: Make cTargetInactiveFontData an int instead of float.
  62274. https://bugs.webkit.org/show_bug.cgi?id=54963
  62275. * platform/graphics/FontCache.cpp:
  62276. 2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
  62277. Reviewed by Darin Adler.
  62278. Make Editor::selectionComputedStyle return EditingStyle
  62279. https://bugs.webkit.org/show_bug.cgi?id=54933
  62280. Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
  62281. It also no longer takes a boolean shouldUseFixedFontDefaultSize.
  62282. Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
  62283. doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
  62284. by an existing layout test only after the code was shared with selectionStartStyle.
  62285. No tests are added since this is a refactoring.
  62286. * editing/CompositeEditCommand.cpp:
  62287. (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
  62288. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  62289. * editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle.
  62290. (WebCore::EditingStyle::mergeTypingStyle): Added.
  62291. * editing/EditingStyle.h:
  62292. (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
  62293. * editing/Editor.cpp:
  62294. (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle.
  62295. (WebCore::Editor::selectionHasStyle): Ditto.
  62296. (WebCore::Editor::selectionStartCSSPropertyValue): Ditto.
  62297. (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
  62298. * editing/Editor.h:
  62299. * editing/EditorCommand.cpp:
  62300. (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
  62301. * editing/InsertLineBreakCommand.cpp:
  62302. * editing/InsertParagraphSeparatorCommand.cpp:
  62303. (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and
  62304. EditingStyle::mergeTypingStyle.
  62305. * editing/ReplaceSelectionCommand.cpp:
  62306. (WebCore::ReplaceSelectionCommand::doApply): Ditto.
  62307. 2011-02-22 Robert Hogan <robert@webkit.org>
  62308. Reviewed by Andreas Kling.
  62309. [Qt] painting of windowed plugins faulty on certain scroll events
  62310. https://bugs.webkit.org/show_bug.cgi?id=52735
  62311. Invalidate the pluginview's relative rect rather then the frameRect(). This is because QWebFrame::renderRelativeCoords()
  62312. imitates ScrollView and adds the scroll offset back on to the rect we damage here (making the co-ordinates absolute
  62313. to the frame again) before passing it to FrameView.
  62314. * plugins/qt/PluginViewQt.cpp:
  62315. (WebCore::PluginView::updatePluginWidget):
  62316. 2011-02-22 Philippe Normand <pnormand@igalia.com>
  62317. Reviewed by Martin Robinson.
  62318. Minimal build broken
  62319. https://bugs.webkit.org/show_bug.cgi?id=54743
  62320. Moved the code of setInspectorExtensionAPI and
  62321. dispatchMessageFromFrontend out of #if
  62322. ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.
  62323. * inspector/InspectorController.cpp:
  62324. (WebCore::InspectorController::setInspectorExtensionAPI):
  62325. (WebCore::InspectorController::dispatchMessageFromFrontend):
  62326. 2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
  62327. Unreviewed, rolling out r79367.
  62328. http://trac.webkit.org/changeset/79367
  62329. https://bugs.webkit.org/show_bug.cgi?id=55012
  62330. all layout tests are crashing on Snow Leopard (Requested by
  62331. rniwa on #webkit).
  62332. * ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
  62333. 2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
  62334. Reviewed by Darin Adler.
  62335. Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
  62336. https://bugs.webkit.org/show_bug.cgi?id=54944
  62337. Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.
  62338. Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
  62339. which returns true iff the specified element has inline style that conflicts or matches the editing style.
  62340. It also appends conflicting property IDs to the vector of property IDs if one is specified.
  62341. * editing/ApplyStyleCommand.cpp:
  62342. (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle.
  62343. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement.
  62344. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement.
  62345. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
  62346. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as
  62347. conflictsWithInlineStyleOfElement.
  62348. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement.
  62349. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement.
  62350. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
  62351. (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
  62352. * editing/ApplyStyleCommand.h:
  62353. (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
  62354. * editing/EditingStyle.cpp:
  62355. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
  62356. * editing/EditingStyle.h:
  62357. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
  62358. 2011-02-22 Chang Shu <cshu@webkit.org>
  62359. Reviewed by Csaba Osztrogonác.
  62360. [Qt] editing/deleting/5408255.html fails
  62361. https://bugs.webkit.org/show_bug.cgi?id=54964
  62362. Move WebCore resource file to QtWebKit since they are referred in WebKit.
  62363. * WebCore.pro:
  62364. 2011-02-22 Brady Eidson <beidson@apple.com>
  62365. Reviewed by Anders Carlsson.
  62366. <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
  62367. API to view and delete Application Cache data by origin.
  62368. Implement these to be used by WK2 API:
  62369. * loader/appcache/ApplicationCacheStorage.cpp:
  62370. (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  62371. (WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
  62372. 2011-02-22 Geoffrey Garen <ggaren@apple.com>
  62373. Reviewed by Oliver Hunt.
  62374. Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
  62375. https://bugs.webkit.org/show_bug.cgi?id=54999
  62376. New WTF header.
  62377. * ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
  62378. 2011-02-22 Beth Dakin <bdakin@apple.com>
  62379. Reviewed by Sam Weinig.
  62380. Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
  62381. Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
  62382. Scrollbars
  62383. -and corresponding-
  62384. <rdar://problem/9034318>
  62385. Instead of consulting the theme directly, callers should ask the Scrollbar or
  62386. ScrollableArea if the scrollbars are overlay or not.
  62387. * platform/ScrollView.cpp:
  62388. (WebCore::ScrollView::visibleContentRect):
  62389. (WebCore::ScrollView::scrollContents):
  62390. (WebCore::ScrollView::wheelEvent):
  62391. * platform/ScrollableArea.cpp:
  62392. (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
  62393. (WebCore::ScrollableArea::hasOverlayScrollbars):
  62394. * platform/ScrollableArea.h:
  62395. * platform/Scrollbar.cpp:
  62396. (WebCore::Scrollbar::isOverlayScrollbar):
  62397. * platform/Scrollbar.h:
  62398. * rendering/RenderBox.cpp:
  62399. (WebCore::RenderBox::includeVerticalScrollbarSize):
  62400. (WebCore::RenderBox::includeHorizontalScrollbarSize):
  62401. * rendering/RenderLayer.cpp:
  62402. (WebCore::RenderLayer::verticalScrollbarWidth):
  62403. (WebCore::RenderLayer::horizontalScrollbarHeight):
  62404. * rendering/RenderListBox.cpp:
  62405. (WebCore::RenderListBox::verticalScrollbarWidth):
  62406. * rendering/RenderScrollbar.h:
  62407. (WebCore::RenderScrollbar::isOverlayScrollbar):
  62408. 2011-02-22 Andras Becsi <abecsi@webkit.org>
  62409. Reviewed by Csaba Osztrogonác.
  62410. [Qt] Redesign the build system
  62411. https://bugs.webkit.org/show_bug.cgi?id=51339
  62412. Move inspector's resource files into the final build step to fix the layout test regression.
  62413. No new tests needed.
  62414. * WebCore.pro: Move inspector's resource files into QtWebKit.pro.
  62415. 2011-02-22 Martin Robinson <mrobinson@igalia.com>
  62416. Reviewed by Xan Lopez.
  62417. [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
  62418. https://bugs.webkit.org/show_bug.cgi?id=54990
  62419. No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
  62420. to start passing again.
  62421. * platform/gtk/ScrollViewGtk.cpp:
  62422. (WebCore::ScrollView::visibleContentRect): Update this method to match the original
  62423. in the parent class.
  62424. 2011-01-17 Martin Robinson <mrobinson@igalia.com>
  62425. Reviewed by Xan Lopez.
  62426. [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
  62427. https://bugs.webkit.org/show_bug.cgi?id=49177
  62428. * platform/ScrollView.cpp: Remove the GTK+ guards around the implementation
  62429. of platformAddChild and platformRemoveChild. This code can be shared.
  62430. * platform/gtk/MainFrameScrollbarGtk.cpp:
  62431. (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached
  62432. adjustment. Connect the adjustment value-changed signal handler after resetting the
  62433. adjustment. This prevents the rest from stomping on pre-existing WebCore values.
  62434. (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to
  62435. a scrollview do not listing for value changes. These scrollbars are defunct.
  62436. * platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
  62437. 2011-02-22 Pavel Feldman <pfeldman@chromium.org>
  62438. Reviewed by Yury Semikhatsky.
  62439. Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
  62440. https://bugs.webkit.org/show_bug.cgi?id=54954
  62441. * bindings/js/JSInjectedScriptHostCustom.cpp:
  62442. (WebCore::InjectedScriptHost::toNode):
  62443. (WebCore::JSInjectedScriptHost::inspect):
  62444. * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  62445. (WebCore::InjectedScriptHost::toNode):
  62446. (WebCore::V8InjectedScriptHost::inspectCallback):
  62447. * inspector/CodeGeneratorInspector.pm:
  62448. * inspector/InjectedScript.cpp:
  62449. (WebCore::InjectedScript::nodeForObjectId):
  62450. * inspector/InjectedScript.h:
  62451. * inspector/InjectedScriptHost.cpp:
  62452. (WebCore::InjectedScriptHost::inspect):
  62453. * inspector/InjectedScriptHost.h:
  62454. * inspector/InjectedScriptHost.idl:
  62455. * inspector/InjectedScriptSource.js:
  62456. (.):
  62457. * inspector/Inspector.idl:
  62458. * inspector/InspectorAgent.cpp:
  62459. (WebCore::InspectorAgent::focusNode):
  62460. * inspector/InspectorAgent.h:
  62461. * inspector/InspectorDOMAgent.cpp:
  62462. (WebCore::InspectorDOMAgent::inspect):
  62463. (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  62464. * inspector/InspectorDOMAgent.h:
  62465. * inspector/front-end/AuditRules.js:
  62466. (WebInspector.AuditRules.evaluateInTargetWindow):
  62467. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  62468. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  62469. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
  62470. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
  62471. * inspector/front-end/ConsoleView.js:
  62472. (WebInspector.ConsoleView.prototype.completions):
  62473. * inspector/front-end/DOMAgent.js:
  62474. (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
  62475. (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
  62476. * inspector/front-end/RemoteObject.js:
  62477. (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  62478. 2011-02-22 Brady Eidson <beidson@apple.com>
  62479. Reviewed by Anders Carlsson.
  62480. Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
  62481. API to view and delete Application Cache data by origin.
  62482. Stub these out for now:
  62483. * loader/appcache/ApplicationCacheStorage.cpp:
  62484. (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  62485. (WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
  62486. (WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac
  62487. * loader/appcache/ApplicationCacheStorage.h:
  62488. Export the new symbols:
  62489. * WebCore.exp.in:
  62490. 2011-02-22 Anders Carlsson <andersca@apple.com>
  62491. Fix debug build.
  62492. * WebCore.exp.in:
  62493. 2011-02-22 Balazs Kelemen <kbalazs@webkit.org>
  62494. Reviewed by Anders Carlsson.
  62495. notImplemented() should behave identical in WebCore and WebKit2
  62496. https://bugs.webkit.org/show_bug.cgi?id=54449
  62497. No functional change so no new tests.
  62498. * WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header
  62499. to be able to use it in WebKit2.
  62500. 2011-02-22 Andras Becsi <abecsi@webkit.org>
  62501. Reviewed by Laszlo Gombos.
  62502. Rubber-stamped by Csaba Osztrogonác.
  62503. [Qt] Redesign the build system
  62504. https://bugs.webkit.org/show_bug.cgi?id=51339
  62505. The patch landed in r79320 didn't contain the cleanup
  62506. which was already addressed in the last attachment.
  62507. No new tests needed.
  62508. * WebCore.pri: Add common LIB and CONFIG options.
  62509. * WebCore.pro: Add accidentally moved sections.
  62510. 2011-02-22 Philippe Normand <pnormand@igalia.com>
  62511. Unreviewed, rolling out r79321.
  62512. http://trac.webkit.org/changeset/79321
  62513. https://bugs.webkit.org/show_bug.cgi?id=53146
  62514. Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
  62515. /spatial-navigation/snav-single-select.html on GTK
  62516. * accessibility/gtk/AXObjectCacheAtk.cpp:
  62517. (WebCore::notifyChildrenSelectionChange):
  62518. (WebCore::AXObjectCache::postPlatformNotification):
  62519. 2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
  62520. Reviewed by Yury Semikhatsky.
  62521. Web Inspector: Inspector.IDL change. rename attribute notify -> event.
  62522. https://bugs.webkit.org/show_bug.cgi?id=54958
  62523. * inspector/CodeGeneratorInspector.pm:
  62524. * inspector/Inspector.idl:
  62525. 2011-02-22 Yury Semikhatsky <yurys@chromium.org>
  62526. Reviewed by Pavel Feldman.
  62527. Web Inspector: Timeline agent should have same lifetime as InspectorAgent
  62528. https://bugs.webkit.org/show_bug.cgi?id=54951
  62529. * inspector/CodeGeneratorInspector.pm:
  62530. * inspector/Inspector.idl:
  62531. * inspector/InspectorAgent.cpp:
  62532. (WebCore::InspectorAgent::InspectorAgent):
  62533. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  62534. (WebCore::InspectorAgent::setFrontend):
  62535. (WebCore::InspectorAgent::disconnectFrontend):
  62536. (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
  62537. (WebCore::InspectorAgent::didCommitLoad):
  62538. (WebCore::InspectorAgent::domContentLoadedEventFired):
  62539. (WebCore::InspectorAgent::loadEventFired):
  62540. * inspector/InspectorAgent.h:
  62541. * inspector/InspectorController.cpp:
  62542. (WebCore::InspectorController::startTimelineProfiler):
  62543. (WebCore::InspectorController::stopTimelineProfiler):
  62544. (WebCore::InspectorController::timelineProfilerEnabled):
  62545. * inspector/InspectorInstrumentation.cpp:
  62546. (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  62547. * inspector/InspectorTimelineAgent.cpp:
  62548. (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
  62549. (WebCore::InspectorTimelineAgent::setFrontend):
  62550. (WebCore::InspectorTimelineAgent::clearFrontend):
  62551. (WebCore::InspectorTimelineAgent::restore):
  62552. (WebCore::InspectorTimelineAgent::startTimelineProfiler):
  62553. (WebCore::InspectorTimelineAgent::stopTimelineProfiler):
  62554. (WebCore::InspectorTimelineAgent::timelineProfilerStarted):
  62555. (WebCore::InspectorTimelineAgent::didCommitLoad):
  62556. (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
  62557. (WebCore::InspectorTimelineAgent::clearRecordStack):
  62558. * inspector/InspectorTimelineAgent.h:
  62559. (WebCore::InspectorTimelineAgent::create):
  62560. * inspector/front-end/TimelinePanel.js:
  62561. (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  62562. 2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
  62563. Reviewed by Pavel Feldman.
  62564. Web Inspector: flakyness of inspector tests.
  62565. https://bugs.webkit.org/show_bug.cgi?id=54729
  62566. As far as we have the protocol with sequence numbers we can simplify test harness support
  62567. and drop out chomium specific methods.
  62568. * inspector/CodeGeneratorInspector.pm:
  62569. * inspector/front-end/TestController.js:
  62570. (WebInspector.TestController):
  62571. (WebInspector.TestController.prototype.notifyDone):
  62572. (WebInspector.TestController.prototype.runAfterPendingDispatches):
  62573. (WebInspector.TestController.prototype._evaluateForTestInFrontend):
  62574. * inspector/front-end/inspector.js:
  62575. (WebInspector.dispatch):
  62576. 2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
  62577. Reviewed by Martin Robinson.
  62578. [GTK] Combo boxes should emit object:selection-changed even when collapsed
  62579. https://bugs.webkit.org/show_bug.cgi?id=53146
  62580. Emit the selection-changed signals when the menu list value has changed
  62581. Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
  62582. * accessibility/gtk/AXObjectCacheAtk.cpp:
  62583. (WebCore::getListObject): New, return the right list object for
  62584. menu lists and list boxes.
  62585. (WebCore::notifyChildrenSelectionChange): Support menu lists.
  62586. (WebCore::AXObjectCache::postPlatformNotification): Call function
  62587. notifyChildrenSelectionChange for AXMenuListValueChanged.
  62588. 2011-02-22 Andras Becsi <abecsi@webkit.org>
  62589. Reviewed by Laszlo Gombos.
  62590. [Qt] Redesign the build system
  62591. https://bugs.webkit.org/show_bug.cgi?id=51339
  62592. Part 2.
  62593. Build WebCore as a static library, compile the WebKit API and WebKit2 API
  62594. in a final step and link to WebKit2, WebCore and JSC libraries to fix
  62595. linking issues resulting from stripped away symbols.
  62596. No new tests needed.
  62597. * WebCore.pri: Add needed rules for handling the static library.
  62598. * WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
  62599. 2011-02-22 Pavel Podivilov <podivilov@chromium.org>
  62600. Reviewed by Pavel Feldman.
  62601. Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
  62602. https://bugs.webkit.org/show_bug.cgi?id=54947
  62603. * inspector/InspectorAgent.cpp:
  62604. (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  62605. * inspector/InspectorState.cpp:
  62606. (WebCore::InspectorState::loadFromCookie):
  62607. * inspector/InspectorState.h:
  62608. 2011-02-15 Jer Noble <jer.noble@apple.com>
  62609. Reviewed by Darin Adler.
  62610. Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
  62611. https://bugs.webkit.org/show_bug.cgi?id=46142
  62612. Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
  62613. container elements. This is necessary because, during layout(), the child renderers
  62614. query the current LayoutState to determine where they will be repainting. If a new
  62615. LayoutState is not pushed here, child renderers will attempt to repaint relative to
  62616. their grandparent's origin instead of their parents', and repaint operations will fail.
  62617. * rendering/RenderMedia.cpp:
  62618. (WebCore::RenderMedia::layout):
  62619. 2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
  62620. Reviewed by Kenneth Rohde Christiansen.
  62621. Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
  62622. https://bugs.webkit.org/show_bug.cgi?id=54952
  62623. Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
  62624. a valid reference for the input type FileInputType.
  62625. * page/Chrome.cpp:
  62626. (WebCore::Chrome::setToolTip):
  62627. 2011-02-21 Pavel Podivilov <podivilov@chromium.org>
  62628. Reviewed by Pavel Feldman.
  62629. Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
  62630. https://bugs.webkit.org/show_bug.cgi?id=54645
  62631. This is needed to map one script to several source files.
  62632. Test: inspector/debugger/source-frame.html
  62633. * WebCore.gypi:
  62634. * WebCore.vcproj/WebCore.vcproj:
  62635. * inspector/front-end/DebuggerPresentationModel.js: Added.
  62636. (WebInspector.DebuggerPresentationModel):
  62637. (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName):
  62638. (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
  62639. (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
  62640. (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
  62641. (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
  62642. (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  62643. * inspector/front-end/ScriptsPanel.js:
  62644. (WebInspector.ScriptsPanel):
  62645. (WebInspector.ScriptsPanel.prototype._breakpointAdded):
  62646. (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
  62647. (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
  62648. (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
  62649. (WebInspector.ScriptsPanel.prototype._addSourceFrame):
  62650. (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
  62651. (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  62652. (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
  62653. (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  62654. (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
  62655. * inspector/front-end/SourceFrame.js:
  62656. (WebInspector.SourceFrame.prototype.get loaded):
  62657. (WebInspector.SourceFrame.prototype._createTextViewer):
  62658. (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
  62659. (WebInspector.SourceFrame.prototype.setExecutionLine):
  62660. (WebInspector.SourceFrame.prototype.clearExecutionLine):
  62661. (WebInspector.SourceFrame.prototype.addBreakpoint):
  62662. (WebInspector.SourceFrame.prototype.removeBreakpoint):
  62663. (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
  62664. (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
  62665. (WebInspector.SourceFrame.prototype._findBreakpoint.filter):
  62666. (WebInspector.SourceFrame.prototype._findBreakpoint):
  62667. * inspector/front-end/WebKit.qrc:
  62668. * inspector/front-end/inspector.html:
  62669. 2011-02-22 Andrey Kosyakov <caseq@chromium.org>
  62670. Reviewed by Pavel Feldman.
  62671. Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
  62672. https://bugs.webkit.org/show_bug.cgi?id=54671
  62673. - factored toolbar handling out of inspector.js
  62674. - added toolbar dropdown
  62675. * WebCore.gypi:
  62676. * WebCore.vcproj/WebCore.vcproj:
  62677. * inspector/front-end/ExtensionServer.js:
  62678. (WebInspector.ExtensionServer.prototype._onCreatePanel):
  62679. * inspector/front-end/Panel.js:
  62680. (WebInspector.Panel.prototype.get toolbarItem):
  62681. * inspector/front-end/Toolbar.js: Added.
  62682. (WebInspector.Toolbar):
  62683. (WebInspector.Toolbar.prototype.resize):
  62684. (WebInspector.Toolbar.prototype.addPanel):
  62685. (WebInspector.Toolbar.prototype._toolbarDragStart):
  62686. (WebInspector.Toolbar.prototype._toolbarDragEnd):
  62687. (WebInspector.Toolbar.prototype._toolbarDrag):
  62688. (WebInspector.Toolbar.prototype._onClose):
  62689. (WebInspector.Toolbar.prototype._setDropdownVisible):
  62690. (WebInspector.Toolbar.prototype._toggleDropdown):
  62691. (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
  62692. (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
  62693. (WebInspector.Toolbar.createPanelToolbarItem):
  62694. (WebInspector.ToolbarDropdown):
  62695. (WebInspector.ToolbarDropdown.prototype.show):
  62696. (WebInspector.ToolbarDropdown.prototype.hide):
  62697. (WebInspector.ToolbarDropdown.prototype.get visible):
  62698. (WebInspector.ToolbarDropdown.prototype._populate):
  62699. (WebInspector.ToolbarDropdown.prototype._onKeyDown):
  62700. * inspector/front-end/WebKit.qrc:
  62701. * inspector/front-end/inspector.css:
  62702. (#toolbar):
  62703. (.toolbar-item):
  62704. (.toolbar-item.toggleable):
  62705. (.toolbar-item.toggleable.toggled-on):
  62706. (#toolbar-dropdown .toolbar-icon):
  62707. (#toolbar-dropdown .toolbar-label):
  62708. (#toolbar-controls):
  62709. (#toolbar-dropdown-arrow):
  62710. (body.attached #toolbar-dropdown-arrow):
  62711. (#toolbar-dropdown-arrow.dropdown-visible):
  62712. (#toolbar-dropdown-arrow:hover):
  62713. (#toolbar-dropdown-arrow:active):
  62714. (#toolbar-dropdown):
  62715. (body.detached.platform-mac-snowleopard #toolbar-dropdown):
  62716. (#toolbar-dropdown .scrollable-content):
  62717. (#toolbar-dropdown .toolbar-item):
  62718. (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
  62719. (#toolbar-dropdown .toolbar-item:hover):
  62720. (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
  62721. (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
  62722. (.scrollable-content):
  62723. (.scrollable-content::-webkit-scrollbar):
  62724. (.scrollable-content::-webkit-resizer):
  62725. (.scrollable-content::-webkit-scrollbar-thumb:vertical):
  62726. (.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
  62727. (.scrollable-content::-webkit-scrollbar-track:vertical):
  62728. (.toolbar-search-item):
  62729. (#search):
  62730. (body.attached #search):
  62731. (#search-results-matches):
  62732. (#close-button-left, #close-button-right):
  62733. (.close-left):
  62734. * inspector/front-end/inspector.html:
  62735. * inspector/front-end/inspector.js:
  62736. (WebInspector.set attached):
  62737. (WebInspector.addPanel):
  62738. (WebInspector.windowResize):
  62739. 2011-02-22 Philippe Normand <pnormand@igalia.com>
  62740. Reviewed by Xan Lopez.
  62741. [GTK] make distcheck fails
  62742. https://bugs.webkit.org/show_bug.cgi?id=54943
  62743. Added new headers and removed references to deleted files.
  62744. * GNUmakefile.am:
  62745. 2011-02-21 Yury Semikhatsky <yurys@chromium.org>
  62746. Reviewed by Pavel Feldman.
  62747. Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
  62748. https://bugs.webkit.org/show_bug.cgi?id=54891
  62749. * inspector/InspectorAgent.cpp:
  62750. (WebCore::InspectorAgent::InspectorAgent):
  62751. (WebCore::InspectorAgent::setFrontend):
  62752. (WebCore::InspectorAgent::disconnectFrontend):
  62753. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  62754. (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
  62755. (WebCore::InspectorAgent::didCommitLoad):
  62756. * inspector/InspectorAgent.h:
  62757. (WebCore::InspectorAgent::instrumentingAgents):
  62758. * inspector/InspectorDOMStorageAgent.cpp:
  62759. (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
  62760. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
  62761. (WebCore::InspectorDOMStorageAgent::setFrontend):
  62762. (WebCore::InspectorDOMStorageAgent::clearFrontend):
  62763. (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
  62764. (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  62765. (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  62766. (WebCore::InspectorDOMStorageAgent::clearResources):
  62767. * inspector/InspectorDOMStorageAgent.h:
  62768. (WebCore::InspectorDOMStorageAgent::create):
  62769. * inspector/InspectorDatabaseAgent.cpp:
  62770. (WebCore::InspectorDatabaseAgent::didOpenDatabase):
  62771. (WebCore::InspectorDatabaseAgent::clearResources):
  62772. (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  62773. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
  62774. (WebCore::InspectorDatabaseAgent::setFrontend):
  62775. (WebCore::InspectorDatabaseAgent::clearFrontend):
  62776. (WebCore::InspectorDatabaseAgent::databaseForId):
  62777. (WebCore::InspectorDatabaseAgent::selectDatabase):
  62778. * inspector/InspectorDatabaseAgent.h:
  62779. (WebCore::InspectorDatabaseAgent::create):
  62780. * inspector/InspectorInstrumentation.cpp:
  62781. (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
  62782. (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
  62783. 2011-02-22 Steve Lacey <sjl@chromium.org>
  62784. Reviewed by Darin Fisher.
  62785. Rename new media statistics apis to better names
  62786. https://bugs.webkit.org/show_bug.cgi?id=54784
  62787. * html/HTMLMediaElement.cpp:
  62788. (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount):
  62789. (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
  62790. * html/HTMLMediaElement.h:
  62791. * html/HTMLMediaElement.idl:
  62792. * html/HTMLVideoElement.cpp:
  62793. (WebCore::HTMLVideoElement::webkitDecodedFrameCount):
  62794. (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
  62795. * html/HTMLVideoElement.h:
  62796. * html/HTMLVideoElement.idl:
  62797. * platform/graphics/MediaPlayer.cpp:
  62798. (WebCore::MediaPlayer::decodedFrameCount):
  62799. (WebCore::MediaPlayer::droppedFrameCount):
  62800. (WebCore::MediaPlayer::audioDecodedByteCount):
  62801. (WebCore::MediaPlayer::videoDecodedByteCount):
  62802. * platform/graphics/MediaPlayer.h:
  62803. * platform/graphics/MediaPlayerPrivate.h:
  62804. (WebCore::MediaPlayerPrivateInterface::decodedFrameCount):
  62805. (WebCore::MediaPlayerPrivateInterface::droppedFrameCount):
  62806. (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount):
  62807. (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
  62808. 2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
  62809. Reviewed by Kent Tamura.
  62810. Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
  62811. https://bugs.webkit.org/show_bug.cgi?id=54435
  62812. Changed the function to a series of early-exit 'if's,
  62813. removed most temporary variables.
  62814. No new tests. (refactoring)
  62815. * css/CSSStyleSelector.cpp:
  62816. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  62817. 2011-02-21 Nico Weber <thakis@chromium.org>
  62818. Reviewed by James Robinson.
  62819. [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
  62820. https://bugs.webkit.org/show_bug.cgi?id=54923
  62821. Rename PopupContainer::show() to showInRect(), to make it obvious it's
  62822. not an override of ScrollView::show().
  62823. No intended functionality change.
  62824. * platform/chromium/PopupMenuChromium.cpp:
  62825. (WebCore::PopupContainer::showInRect):
  62826. (WebCore::PopupMenuChromium::show):
  62827. * platform/chromium/PopupMenuChromium.h:
  62828. 2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
  62829. Reviewed by Antti Koivisto.
  62830. Improve the local{SharedStyle,CousinList} algorithm
  62831. https://bugs.webkit.org/show_bug.cgi?id=45507
  62832. This change improves the algorithm to find shared styles: the old
  62833. algorithm would stop the search after the first cousin, even if
  62834. the search threshold is not met. As such, the algorithm would
  62835. systematically miss sharings across second cousins and beyond.
  62836. The new algorithm continues the search, as long as threshold is
  62837. not met. It also separates the threshold for sibling/cousins
  62838. search, from that on the levels of search, which is easier to
  62839. optimize.
  62840. The new algorithm finds up to 30% more sharings on some sites
  62841. (e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
  62842. No new test, refactoring only.
  62843. * css/CSSStyleSelector.cpp:
  62844. (WebCore::CSSStyleSelector::locateCousinList):
  62845. (WebCore::CSSStyleSelector::locateSharedStyle):
  62846. While changing the algorithm, cleaned up the style of those 2 methods
  62847. (use early return, renamed some variables).
  62848. * css/CSSStyleSelector.h:
  62849. 2011-02-21 Nico Weber <thakis@chromium.org>
  62850. Reviewed by Adam Barth.
  62851. RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
  62852. https://bugs.webkit.org/show_bug.cgi?id=54922
  62853. RenderTableCell::baselinePosition() has the same name as a virtual
  62854. method in superclass RenderBlock. Rename the subclass method to make
  62855. it clear it's not an attempted override.
  62856. No intended functionality change.
  62857. * rendering/RenderTableCell.cpp:
  62858. (WebCore::RenderTableCell::cellBaselinePosition):
  62859. * rendering/RenderTableCell.h:
  62860. * rendering/RenderTableSection.cpp:
  62861. (WebCore::RenderTableSection::calcRowLogicalHeight):
  62862. (WebCore::RenderTableSection::layoutRows):
  62863. 2011-02-21 Benjamin Kalman <kalman@chromium.org>
  62864. Reviewed by Ryosuke Niwa.
  62865. Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
  62866. start/end of selection for RTL
  62867. https://bugs.webkit.org/show_bug.cgi?id=54724
  62868. On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
  62869. This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
  62870. extending from the end when for the "right" direction (e.g. pressing right arrow key).
  62871. However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
  62872. direction is obviously reversed) and likewise extend from the start when extending right.
  62873. * editing/SelectionController.cpp:
  62874. (WebCore::SelectionController::modify):
  62875. 2011-02-21 Nico Weber <thakis@chromium.org>
  62876. Reviewed by Adam Barth.
  62877. ImageDocument::imageChanged() confuses clang's -Woverride-virtual
  62878. https://bugs.webkit.org/show_bug.cgi?id=54924
  62879. Rename ImageDocument::imageChanged() to imageUpdated() to make clear
  62880. that it's not an override of CachedResourceClient::imageChanged().
  62881. * html/ImageDocument.cpp:
  62882. (WebCore::ImageDocumentParser::appendBytes):
  62883. (WebCore::ImageDocumentParser::finish):
  62884. (WebCore::ImageDocument::imageUpdated):
  62885. * html/ImageDocument.h:
  62886. 2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
  62887. Reviewed by Kent Tamura.
  62888. Bug 54934 - Sort the WebCore project file(s)
  62889. https://bugs.webkit.org/show_bug.cgi?id=54934
  62890. No new tests. (no code affected)
  62891. * GNUmakefile.am:
  62892. * WebCore.xcodeproj/project.pbxproj:
  62893. 2011-02-21 Nico Weber <thakis@chromium.org>
  62894. Reviewed by Adam Barth.
  62895. canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
  62896. https://bugs.webkit.org/show_bug.cgi?id=54909
  62897. Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
  62898. unconfuse clang. No intended functionality change.
  62899. * rendering/RenderBlockLineLayout.cpp:
  62900. (WebCore::RenderBlock::checkLinesForTextOverflow):
  62901. * rendering/RenderFlexibleBox.cpp:
  62902. (WebCore::RenderFlexibleBox::applyLineClamp):
  62903. * rendering/RootInlineBox.cpp:
  62904. (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
  62905. * rendering/RootInlineBox.h:
  62906. 2011-02-21 Adele Peterson <adele@apple.com>
  62907. Reviewed by Dan Bernstein.
  62908. Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
  62909. REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
  62910. Test: updated fast/forms/placeholder-position.html and tested manually
  62911. Consider padding and margin for the results and cancel buttons. This is important for the Windows
  62912. theme which uses padding to correctly position those buttons. This change fixes the placeholder
  62913. position, and also better aligns the results popup list with the actual text you type.
  62914. * rendering/RenderTextControlSingleLine.cpp:
  62915. (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
  62916. (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  62917. 2011-02-21 Nico Weber <thakis@chromium.org>
  62918. Reviewed by Kent Tamura.
  62919. GIFImageDecoder::setSize() tries to override the superclass method but fails
  62920. https://bugs.webkit.org/show_bug.cgi?id=54305
  62921. The superclass uses unsigned instead of int for its parameters, so
  62922. GIFImageDecoder::setSize() was an overload, not an override.
  62923. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  62924. (WebCore::GIFImageDecoder::setSize):
  62925. * platform/image-decoders/gif/GIFImageDecoder.h:
  62926. 2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
  62927. Reviewed by Darin Adler.
  62928. Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
  62929. https://bugs.webkit.org/show_bug.cgi?id=54528
  62930. * editing/ApplyStyleCommand.cpp:
  62931. (WebCore::StyleChange::init): Allows style to be a null pointer.
  62932. (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
  62933. -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
  62934. to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
  62935. whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
  62936. (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
  62937. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
  62938. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
  62939. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
  62940. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
  62941. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
  62942. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
  62943. ApplyStyleCommand::applyInlineStyle already does it.
  62944. * editing/ApplyStyleCommand.h:
  62945. * editing/EditingStyle.cpp:
  62946. (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
  62947. (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
  62948. * editing/EditingStyle.h:
  62949. 2011-02-21 Mark Rowe <mrowe@apple.com>
  62950. Reviewed by Darin Adler and Alexey Proskuryakov.
  62951. <http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO
  62952. * platform/graphics/cg/ImageSourceCG.cpp:
  62953. (WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
  62954. frame properties dictionary and use that if it exists. If it does not exist in the
  62955. dictionary then fall back to using the clamped frame delay.
  62956. 2011-02-21 James Kozianski <koz@chromium.org>
  62957. Reviewed by Kent Tamura.
  62958. Causes elements to be unfocusable after tabindex property is removed.
  62959. https://bugs.webkit.org/show_bug.cgi?id=54727
  62960. Test: fast/html/tabindex-removal.html
  62961. * dom/Node.cpp:
  62962. (WebCore::Node::clearTabIndexExplicitly):
  62963. * dom/Node.h:
  62964. * dom/NodeRareData.h:
  62965. (WebCore::NodeRareData::clearTabIndexExplicitly):
  62966. * html/HTMLElement.cpp:
  62967. (WebCore::HTMLElement::parseMappedAttribute):
  62968. 2011-02-21 Alexey Proskuryakov <ap@apple.com>
  62969. Reviewed by Mark Rowe.
  62970. <rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods
  62971. * platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
  62972. 2011-02-21 Sam Weinig <sam@webkit.org>
  62973. Reviewed by Dan Bernstein.
  62974. Overhang areas need to be invalidated on scroll
  62975. <rdar://problem/9032194>
  62976. https://bugs.webkit.org/show_bug.cgi?id=54917
  62977. * platform/ScrollView.cpp:
  62978. (WebCore::ScrollView::scrollContents):
  62979. We need to explicitly invalidate the overhang areas when we scroll the contents
  62980. of a ScrollView, since they could contain arbitrary content that cannot be blitted.
  62981. 2011-02-21 Lucas Forschler <lforschler@apple.com>
  62982. Reviewed by Stephanie Lewis.
  62983. Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
  62984. No new tests required.
  62985. * WebCore.xcodeproj/project.pbxproj:
  62986. 2011-02-21 Pratik Solanki <psolanki@apple.com>
  62987. Reviewed by Darin Adler.
  62988. Remove global initializer in CookieStorageCFNet.cpp
  62989. https://bugs.webkit.org/show_bug.cgi?id=54905
  62990. * platform/network/cf/CookieStorageCFNet.cpp:
  62991. (WebCore::currentCookieStorage):
  62992. (WebCore::setCurrentCookieStorage):
  62993. (WebCore::setCookieStoragePrivateBrowsingEnabled):
  62994. 2011-02-18 Jer Noble <jer.noble@apple.com>
  62995. Reviewed by Sam Weinig.
  62996. WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
  62997. https://bugs.webkit.org/show_bug.cgi?id=54771
  62998. Now that video is accelerated, we no longer need to special case
  62999. video playing within a media document.
  63000. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  63001. (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
  63002. (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
  63003. 2011-02-21 Alexey Proskuryakov <ap@apple.com>
  63004. Reviewed by Adam Roben.
  63005. REGRESSION (WebKit2): HTTP requests time out after 60 seconds
  63006. https://bugs.webkit.org/show_bug.cgi?id=54755
  63007. <rdar://problem/9006592>
  63008. No new tests - it won't be great to have a test that runs for a minute.
  63009. It's now possible to set a default timeout to be used at ResourceRequest creation. If one
  63010. hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
  63011. or use INT_MAX on other platforms).
  63012. * WebCore.exp.in:
  63013. * platform/network/ResourceRequestBase.cpp:
  63014. (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of
  63015. default timeout interval (may be 0 if using NSURLRequest default).
  63016. (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable.
  63017. (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource
  63018. request is updated. Plaform code often calls updateResourceRequest() indirectly from this
  63019. function, and that must obviously be a no-op.
  63020. (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite
  63021. direction.
  63022. * platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to
  63023. "defaultTimeoutInterval". It has been used as default by most platforms anyway.
  63024. (WebCore::ResourceRequestBase::ResourceRequestBase):
  63025. * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  63026. Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
  63027. setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
  63028. 2011-02-21 Martin Robinson <mrobinson@igalia.com>
  63029. Reviewed by Xan Lopez.
  63030. [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
  63031. https://bugs.webkit.org/show_bug.cgi?id=54895
  63032. Correct the GTK+ clipboard implementation to know that "text" is an alias
  63033. for "text/html" data. This corrects the failing test.
  63034. * platform/gtk/ClipboardGtk.cpp:
  63035. (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
  63036. (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
  63037. 2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
  63038. Reviewed by Pavel Feldman.
  63039. ProcessingInstruction should provide a way to know if it is of CSS type.
  63040. https://bugs.webkit.org/show_bug.cgi?id=54868
  63041. * dom/ProcessingInstruction.cpp:
  63042. (WebCore::ProcessingInstruction::ProcessingInstruction):
  63043. (WebCore::ProcessingInstruction::checkStyleSheet):
  63044. (WebCore::ProcessingInstruction::setCSSStyleSheet):
  63045. * dom/ProcessingInstruction.h:
  63046. (WebCore::ProcessingInstruction::isCSS):
  63047. 2011-02-21 Simon Fraser <simon.fraser@apple.com>
  63048. Put JSDOMImplementationCustom.cpp where it belongs in the project.
  63049. * WebCore.xcodeproj/project.pbxproj:
  63050. 2011-02-21 Gavin Barraclough <barraclough@apple.com>
  63051. Reviewed by Sam Weinig.
  63052. Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
  63053. The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
  63054. containing a pointer to its parent class. These links should reflect the inheritance
  63055. hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
  63056. entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
  63057. since intervening C++ classes may not have ClassInfo - but would be a potential bug
  63058. were ClassInfo were to be added.
  63059. * bindings/js/JSAudioConstructor.cpp:
  63060. * bindings/js/JSDOMGlobalObject.cpp:
  63061. * bindings/js/JSImageConstructor.cpp:
  63062. * bindings/js/JSOptionConstructor.cpp:
  63063. * bindings/scripts/CodeGeneratorJS.pm:
  63064. * bridge/objc/objc_runtime.mm:
  63065. * bridge/runtime_object.cpp:
  63066. 2011-02-21 Pavel Feldman <pfeldman@chromium.org>
  63067. Reviewed by Yury Semikhatsky.
  63068. Web Inspector: navigation does not work after reopening frontend.
  63069. https://bugs.webkit.org/show_bug.cgi?id=54879
  63070. Test: http/tests/inspector-enabled/open-close-open.html
  63071. * inspector/InspectorAgent.cpp:
  63072. (WebCore::InspectorAgent::setFrontend):
  63073. * inspector/InspectorState.cpp:
  63074. (WebCore::InspectorState::unmute):
  63075. * inspector/InspectorState.h:
  63076. 2011-02-21 Adam Roben <aroben@apple.com>
  63077. Protect the PluginView when evaluating javascript: URLs
  63078. Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
  63079. plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
  63080. added
  63081. Reviewed by Sam Weinig.
  63082. * plugins/PluginView.cpp:
  63083. (WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
  63084. when evaluating javascript: URLs.
  63085. 2011-02-21 Martin Robinson <mrobinson@igalia.com>
  63086. Fix GTK+ build after r79223.
  63087. * GNUmakefile.am: Add file missing from the source list.
  63088. 2011-02-14 Alexander Pavlov <apavlov@chromium.org>
  63089. Reviewed by Yury Semikhatsky.
  63090. Web Inspector: audits should not warn about gzip compression for 304s
  63091. https://bugs.webkit.org/show_bug.cgi?id=54343
  63092. Do not run compression-related audits on 304 resources.
  63093. Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
  63094. * inspector/front-end/AuditRules.js:
  63095. (WebInspector.AuditRules.GzipRule.prototype.doRun):
  63096. (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
  63097. 2011-02-08 Anton Muhin <antonm@chromium.org>
  63098. Reviewed by Adam Barth and Alexey Proskuryakov.
  63099. Propagate security origin of parent document into HTML documents created with DOMImplementation
  63100. https://bugs.webkit.org/show_bug.cgi?id=53611
  63101. This restores invariant that JS wrappers residing in the same JS context should come
  63102. from the same security origin.
  63103. Absence of regressions is covered by the current tests. Different security origin of
  63104. DOMImplementation is difficult to check with layout tests as DOMImplementation
  63105. resides in the same JS context as parent document and therefore there are no security origin checks.
  63106. This is observable however in C++.
  63107. * Android.jscbindings.mk:
  63108. * CMakeLists.txt:
  63109. * WebCore.gypi:
  63110. * WebCore.pro:
  63111. * WebCore.vcproj/WebCore.vcproj:
  63112. * WebCore.xcodeproj/project.pbxproj:
  63113. * bindings/v8/V8GCController.cpp:
  63114. (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  63115. * dom/DOMImplementation.cpp:
  63116. (WebCore::DOMImplementation::DOMImplementation):
  63117. (WebCore::DOMImplementation::createDocument):
  63118. * dom/DOMImplementation.h:
  63119. (WebCore::DOMImplementation::create):
  63120. (WebCore::DOMImplementation::documentDestroyed):
  63121. (WebCore::DOMImplementation::parentDocument):
  63122. * dom/DOMImplementation.idl:
  63123. * dom/Document.cpp:
  63124. (WebCore::Document::~Document):
  63125. (WebCore::Document::implementation):
  63126. * dom/Document.h:
  63127. 2011-02-21 Andrey Adaikin <aandrey@google.com>
  63128. Reviewed by Pavel Feldman.
  63129. Web Inspector: [Text editor] Optimize editing updates in gutter panel
  63130. https://bugs.webkit.org/show_bug.cgi?id=54866
  63131. * inspector/front-end/TextViewer.js:
  63132. (WebInspector.TextViewer.prototype.set startEditingListener):
  63133. (WebInspector.TextViewer.prototype.set endEditingListener):
  63134. (WebInspector.TextViewer.prototype.endUpdates):
  63135. (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
  63136. (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
  63137. (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
  63138. (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
  63139. (WebInspector.TextEditorGutterPanel.prototype.textChanged):
  63140. (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  63141. 2011-02-21 Alexander Pavlov <apavlov@chromium.org>
  63142. Reviewed by Yury Semikhatsky.
  63143. Web Inspector: [Audits] Image dimensions in inline style not checked
  63144. https://bugs.webkit.org/show_bug.cgi?id=54738
  63145. * inspector/front-end/AuditRules.js:
  63146. (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  63147. 2011-02-21 Yury Semikhatsky <yurys@chromium.org>
  63148. Reviewed by Pavel Feldman.
  63149. Web Inspector: create and destroy DOM agent along with InspectorAgent
  63150. https://bugs.webkit.org/show_bug.cgi?id=54875
  63151. * GNUmakefile.am:
  63152. * WebCore.gypi:
  63153. * WebCore.pro:
  63154. * WebCore.vcproj/WebCore.vcproj:
  63155. * WebCore.xcodeproj/project.pbxproj:
  63156. * inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
  63157. on this object.
  63158. (WebCore::InstrumentingAgents::InstrumentingAgents):
  63159. (WebCore::InstrumentingAgents::~InstrumentingAgents):
  63160. (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
  63161. (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
  63162. (WebCore::InstrumentingAgents::inspectorConsoleAgent):
  63163. (WebCore::InstrumentingAgents::setInspectorConsoleAgent):
  63164. (WebCore::InstrumentingAgents::inspectorDOMAgent):
  63165. (WebCore::InstrumentingAgents::setInspectorDOMAgent):
  63166. (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
  63167. (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
  63168. (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
  63169. (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
  63170. (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
  63171. (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
  63172. (WebCore::InstrumentingAgents::inspectorProfilerAgent):
  63173. (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
  63174. (WebCore::InstrumentingAgents::inspectorResourceAgent):
  63175. (WebCore::InstrumentingAgents::setInspectorResourceAgent):
  63176. (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
  63177. (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
  63178. (WebCore::InstrumentingAgents::inspectorStorageAgent):
  63179. (WebCore::InstrumentingAgents::setInspectorStorageAgent):
  63180. (WebCore::InstrumentingAgents::inspectorTimelineAgent):
  63181. (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
  63182. * inspector/InspectorAgent.cpp:
  63183. (WebCore::InspectorAgent::InspectorAgent):
  63184. (WebCore::InspectorAgent::setFrontend):
  63185. (WebCore::InspectorAgent::disconnectFrontend):
  63186. (WebCore::InspectorAgent::createFrontendLifetimeAgents):
  63187. (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
  63188. (WebCore::InspectorAgent::didCommitLoad):
  63189. (WebCore::InspectorAgent::domContentLoadedEventFired):
  63190. (WebCore::InspectorAgent::loadEventFired):
  63191. * inspector/InspectorAgent.h:
  63192. * inspector/InspectorCSSAgent.cpp:
  63193. (WebCore::InspectorCSSAgent::InspectorCSSAgent):
  63194. (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  63195. * inspector/InspectorCSSAgent.h:
  63196. * inspector/InspectorConsoleAgent.cpp:
  63197. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
  63198. (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
  63199. (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  63200. (WebCore::InspectorConsoleAgent::clearFrontend):
  63201. (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
  63202. (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
  63203. (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  63204. (WebCore::InspectorConsoleAgent::addConsoleMessage):
  63205. * inspector/InspectorConsoleAgent.h:
  63206. * inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached.
  63207. (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  63208. (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end
  63209. is attached.
  63210. (WebCore::InspectorDOMAgent::clearFrontend):
  63211. * inspector/InspectorDOMAgent.h:
  63212. (WebCore::InspectorDOMAgent::create):
  63213. 2011-02-21 Csaba Osztrogonác <ossy@webkit.org>
  63214. Reviewed by Andreas Kling.
  63215. [Qt][V8]REGRESSION(r79157): Fix build
  63216. https://bugs.webkit.org/show_bug.cgi?id=54871
  63217. * bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
  63218. 2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
  63219. Reviewed by Mihai Parparita.
  63220. [V8] SerializedScriptValue: fix JS exception handling.
  63221. https://bugs.webkit.org/show_bug.cgi?id=54555
  63222. Added checks for exceptions and empty handles:
  63223. * bindings/v8/SerializedScriptValue.cpp:
  63224. (WebCore::Serializer::Serializer):
  63225. (WebCore::Serializer::serialize):
  63226. (WebCore::Serializer::checkException):
  63227. (WebCore::Serializer::reportFailure):
  63228. (WebCore::Serializer::ArrayState::advance):
  63229. (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
  63230. (WebCore::Serializer::AbstractObjectState::advance):
  63231. (WebCore::Serializer::push):
  63232. (WebCore::Serializer::handleError):
  63233. (WebCore::Serializer::newObjectState):
  63234. (WebCore::Serializer::doSerialize):
  63235. (WebCore::SerializedScriptValue::SerializedScriptValue):
  63236. 2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
  63237. Reviewed by Kent Tamura.
  63238. Add selectionchange event
  63239. https://bugs.webkit.org/show_bug.cgi?id=45712
  63240. Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
  63241. This event is not cancelable and does not bubble. An event listener can be attached to a document by
  63242. body element's onselectionchange attribute or via document's onselectionchange property.
  63243. Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
  63244. fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
  63245. will not observe the event before the control returns to JavaScript.
  63246. See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx
  63247. Tests: fast/events/selectionchange-iframe.html
  63248. fast/events/selectionchange-user-initiated.html
  63249. * dom/Document.cpp:
  63250. (WebCore::Document::enqueueDocumentEvent): Added.
  63251. * dom/Document.h: Added selectionchange event listener.
  63252. * dom/Document.idl: Added onselectionchagne attribute.
  63253. * dom/EventNames.h: Added selectionchange
  63254. * editing/SelectionController.cpp:
  63255. (WebCore::SelectionController::setSelection): Fires selectionchange event.
  63256. * html/HTMLAttributeNames.in: Added onselectionchange.
  63257. * html/HTMLBodyElement.cpp:
  63258. (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
  63259. 2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
  63260. Reviewed by Pavel Feldman.
  63261. Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
  63262. https://bugs.webkit.org/show_bug.cgi?id=54859
  63263. * inspector/CodeGeneratorInspector.pm:
  63264. 2011-02-21 Pavel Feldman <pfeldman@chromium.org>
  63265. Reviewed by Yury Semikhatsky.
  63266. Web Inspector: generate protocol documentation based on IDL.
  63267. https://bugs.webkit.org/show_bug.cgi?id=54822
  63268. * inspector/CodeGeneratorInspector.pm:
  63269. 2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
  63270. Reviewed by Martin Robinson.
  63271. [GStreamer] Add URI queries support in webkitwebsrc
  63272. https://bugs.webkit.org/show_bug.cgi?id=54627
  63273. This allow replying to URI queries from downstream elements
  63274. with the uri currently set in the source element.
  63275. No new tests, this feature is dedicated to internal GStreamer use,
  63276. such as the upcoming HTTP Live Streaming element.
  63277. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  63278. (webKitWebSrcQuery):
  63279. 2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
  63280. Reviewed by Martin Robinson.
  63281. [GStreamer] Add 'location' property in webkitwebsrc
  63282. https://bugs.webkit.org/show_bug.cgi?id=54628
  63283. No new tests, this feature is dedicated to internal GStreamer use,
  63284. such as the upcoming HTTP Live Streaming element.
  63285. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  63286. (webkit_web_src_class_init):
  63287. (webKitWebSrcSetProperty):
  63288. (webKitWebSrcGetProperty):
  63289. 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
  63290. Reviewed by Kent Tamura.
  63291. Rename Position::node() to Position::deprecatedNode()
  63292. https://bugs.webkit.org/show_bug.cgi?id=54622
  63293. Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
  63294. calls were of the form node()->document() and node()->inDocument() in which case they were
  63295. replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
  63296. * WebCore.exp.in: Added Position::containerNode.
  63297. The rest abbreviated for simplicity. Please see svn log.
  63298. 2011-02-20 Gavin Barraclough <barraclough@apple.com>
  63299. Build fix (remove includes).
  63300. * bindings/js/JSDOMBinding.cpp:
  63301. * bindings/js/JSDOMWindowCustom.cpp:
  63302. * bindings/js/JSHistoryCustom.cpp:
  63303. * bindings/js/JSLocationCustom.cpp:
  63304. 2011-02-20 Gavin Barraclough <barraclough@apple.com>
  63305. Reviewed by Oliver Hunt.
  63306. https://bugs.webkit.org/show_bug.cgi?id=54839
  63307. Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.
  63308. Historically, Native functions used to be represented by PrototypeFunctions, however
  63309. since introducing call optimizations to the JIT this has used JSFunctions for host
  63310. calls too. At the point this change was made, the interpreter continued to use
  63311. PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
  63312. the interpreter has had to be able to run using host functions represented using
  63313. JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
  63314. interpreter only builds, and situations where the JIT has fallen back to interpreting.
  63315. NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
  63316. for wrappers for host functions, and as such can also be removed.
  63317. GlobalEvalFunction is a redundant wrapper that happens to be derived from
  63318. PrototypeFunction. It existed to hold a reference to the global object - but since all
  63319. functions how derive from JSObjectWithGlobalObject, this no longer requires an
  63320. additional class to provide this functionality.
  63321. * bindings/js/JSDOMBinding.cpp:
  63322. * bindings/js/JSDOMWindowCustom.cpp:
  63323. * bindings/js/JSHistoryCustom.cpp:
  63324. * bindings/js/JSLocationCustom.cpp:
  63325. Removed use of redundant classes.
  63326. 2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
  63327. Unreviewed, rolling out r79169.
  63328. http://trac.webkit.org/changeset/79169
  63329. https://bugs.webkit.org/show_bug.cgi?id=54846
  63330. Made unexpected results for tests without CJK characters
  63331. (Requested by tkent on #webkit).
  63332. * platform/graphics/chromium/FontCacheChromiumWin.cpp:
  63333. (WebCore::FontCache::createFontPlatformData):
  63334. * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  63335. (WebCore::FontPlatformData::FontPlatformData):
  63336. (WebCore::FontPlatformData::operator=):
  63337. * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  63338. (WebCore::FontPlatformData::orientation):
  63339. * platform/graphics/skia/FontCustomPlatformData.cpp:
  63340. (WebCore::FontCustomPlatformData::fontPlatformData):
  63341. 2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>
  63342. Reviewed by Kent Tamura.
  63343. On Chromium Windows, glyphs in vertical text tests are rotated 90
  63344. degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450
  63345. This platform dependent patch makes Chromium Windows show the
  63346. vertical writing text correctly. Job was done by adding a prefix '@'
  63347. in front of the font family name (Windows Only). No new tests added.
  63348. * platform/graphics/chromium/FontCacheChromiumWin.cpp:
  63349. (WebCore::FontCache::createFontPlatformData):
  63350. * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  63351. (WebCore::FontPlatformData::FontPlatformData):
  63352. (WebCore::FontPlatformData::operator=):
  63353. * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  63354. (WebCore::FontPlatformData::orientation):
  63355. * platform/graphics/skia/FontCustomPlatformData.cpp:
  63356. (WebCore::FontCustomPlatformData::fontPlatformData):
  63357. 2011-02-20 Simon Fraser <simon.fraser@apple.com>
  63358. Reviewed by Dirk Schulze.
  63359. REGRESSION (r73369-r73405): transform animation interpolates incorrectly
  63360. https://bugs.webkit.org/show_bug.cgi?id=54793
  63361. After the refactoring in r73380, the ending state for some types of
  63362. accelerated animations was computed incorrectly, because the TransformationMatrix
  63363. wasn't reset to identity before the ending value transformations were applied.
  63364. Fix by cleaning up the code to use explicit, separate values for
  63365. starting and ending values. Only matrix-type animations had this
  63366. issue, but cleaned up other clauses similarly.
  63367. Test: animations/3d/matrix-transform-type-animation.html
  63368. * platform/graphics/ca/GraphicsLayerCA.cpp:
  63369. (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
  63370. 2011-02-20 Dan Bernstein <mitz@apple.com>
  63371. Reviewed by Maciej Stachowiak.
  63372. <rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor
  63373. Test: fast/frames/iframe-scale-applied-twice.html
  63374. * page/FrameView.cpp:
  63375. (WebCore::FrameView::create): Set the initial bounds of the view to match the
  63376. frame size.
  63377. * platform/ScrollView.cpp:
  63378. (WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
  63379. (WebCore::ScrollView::updateScrollbars): Ditto.
  63380. (WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
  63381. change to setBoundsSize().
  63382. (WebCore::ScrollView::setBoundsSize): Added.
  63383. (WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
  63384. not update anything.
  63385. (WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
  63386. (WebCore::ScrollView::scrollbarCornerPresent): Ditto.
  63387. * platform/ScrollView.h:
  63388. (WebCore::ScrollView::boundsSize): Added this getter.
  63389. * platform/Widget.h:
  63390. (WebCore::Widget::resize): Set the bounds size to the frame size.
  63391. * platform/mac/ScrollbarThemeMac.mm:
  63392. (WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
  63393. path where the buffer rect was resized to capture only the damaged part, but was
  63394. still drawn in the original location.
  63395. 2011-02-20 Alexey Proskuryakov <ap@apple.com>
  63396. Reviewed by Eric Seidel.
  63397. Tighten up access permissions by using libxslt API
  63398. https://bugs.webkit.org/show_bug.cgi?id=52688
  63399. <rdar://problem/8909191>
  63400. * xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only
  63401. interested in a string result, so let libxslt know about that.
  63402. 2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
  63403. Unreviewed, rolling out r79104.
  63404. http://trac.webkit.org/changeset/79104
  63405. https://bugs.webkit.org/show_bug.cgi?id=54835
  63406. Might have caused flaky canaries (Requested by tonyg-cr on
  63407. #webkit).
  63408. * html/parser/HTMLDocumentParser.cpp:
  63409. (WebCore::HTMLDocumentParser::canTakeNextToken):
  63410. (WebCore::HTMLDocumentParser::pumpTokenizer):
  63411. * html/parser/HTMLParserScheduler.cpp:
  63412. (WebCore::isLayoutTimerActive):
  63413. * html/parser/HTMLParserScheduler.h:
  63414. (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  63415. * page/FrameView.h:
  63416. 2011-02-20 Dirk Schulze <krit@webkit.org>
  63417. Reviewed by Nikolas Zimmermann.
  63418. SVG animation - analyze attribute type for animation
  63419. https://bugs.webkit.org/show_bug.cgi?id=54542
  63420. Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
  63421. with AnimatedAttributeType instead. More cleanup of the animation code.
  63422. Added missing fillAttributeToPropertyTypeMap() for SVGGElement.
  63423. Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
  63424. from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.
  63425. No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
  63426. animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
  63427. with the W3C test suite in trunk.
  63428. The change on SVGUseElement gets covered by animate-elem-39-t.svg
  63429. Test: svg/animations/animate-dynamic-update-attributeName.html
  63430. * svg/SVGAnimateElement.cpp:
  63431. (WebCore::SVGAnimateElement::SVGAnimateElement):
  63432. (WebCore::SVGAnimateElement::hasValidAttributeType):
  63433. (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
  63434. (WebCore::SVGAnimateElement::calculateAnimatedValue):
  63435. (WebCore::inheritsFromProperty):
  63436. (WebCore::SVGAnimateElement::calculateFromAndToValues):
  63437. (WebCore::SVGAnimateElement::calculateFromAndByValues):
  63438. (WebCore::SVGAnimateElement::resetToBaseValue):
  63439. (WebCore::SVGAnimateElement::applyResultsToTarget):
  63440. (WebCore::SVGAnimateElement::calculateDistance):
  63441. * svg/SVGAnimateElement.h:
  63442. * svg/SVGAnimateMotionElement.cpp:
  63443. (WebCore::SVGAnimateMotionElement::hasValidAttributeType):
  63444. (WebCore::parsePoint):
  63445. (WebCore::SVGAnimateMotionElement::resetToBaseValue):
  63446. (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
  63447. (WebCore::SVGAnimateMotionElement::calculateDistance):
  63448. * svg/SVGAnimateMotionElement.h:
  63449. * svg/SVGAnimateTransformElement.cpp:
  63450. (WebCore::SVGAnimateTransformElement::hasValidAttributeType):
  63451. (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType):
  63452. (WebCore::SVGAnimateTransformElement::resetToBaseValue):
  63453. (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
  63454. (WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
  63455. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  63456. (WebCore::SVGAnimateTransformElement::calculateDistance):
  63457. * svg/SVGAnimateTransformElement.h:
  63458. * svg/SVGAnimationElement.cpp:
  63459. (WebCore::parseKeyTimes):
  63460. (WebCore::parseKeySplines):
  63461. (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
  63462. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  63463. (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
  63464. (WebCore::solveEpsilon):
  63465. (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
  63466. (WebCore::SVGAnimationElement::currentValuesFromKeyPoints):
  63467. (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
  63468. (WebCore::SVGAnimationElement::startedActiveInterval):
  63469. * svg/SVGAnimationElement.h:
  63470. * svg/SVGFilterElement.cpp:
  63471. (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  63472. * svg/SVGGElement.cpp:
  63473. (WebCore::SVGGElement::attributeToPropertyTypeMap):
  63474. (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
  63475. * svg/SVGGElement.h:
  63476. * svg/SVGUseElement.cpp:
  63477. (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
  63478. * svg/animation/SMILTimeContainer.cpp:
  63479. (WebCore::SMILTimeContainer::baseValueFor):
  63480. (WebCore::SMILTimeContainer::updateAnimations):
  63481. * svg/animation/SMILTimeContainer.h:
  63482. * svg/animation/SVGSMILElement.cpp:
  63483. (WebCore::SVGSMILElement::SVGSMILElement):
  63484. (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name.
  63485. (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name.
  63486. (WebCore::SVGSMILElement::removedFromDocument): Ditto.
  63487. (WebCore::SVGSMILElement::attributeChanged): Ditto.
  63488. * svg/animation/SVGSMILElement.h:
  63489. (WebCore::SVGSMILElement::attributeName):
  63490. 2011-02-20 David Kilzer <ddkilzer@apple.com>
  63491. BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)
  63492. Not reviewed.
  63493. * rendering/RenderLayerCompositor.cpp:
  63494. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):
  63495. 2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
  63496. Reviewed by Martin Robinson.
  63497. [GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
  63498. https://bugs.webkit.org/show_bug.cgi?id=52880
  63499. * platform/gtk/KeyEventGtk.cpp:
  63500. (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
  63501. 2011-02-19 Andreas Kling <kling@webkit.org>
  63502. Reviewed by Oliver Hunt.
  63503. DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
  63504. https://bugs.webkit.org/show_bug.cgi?id=54545
  63505. * page/DragController.cpp:
  63506. (WebCore::DragController::concludeEditDrag):
  63507. 2011-02-19 Sam Weinig <sam@webkit.org>
  63508. Reviewed by Anders Carlsson.
  63509. Add phase in addition to momentumPhase to platform wheel events
  63510. Part of <rdar://problem/8945362>
  63511. Rename existing phase to momentumPhase.
  63512. * platform/PlatformWheelEvent.h:
  63513. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  63514. (WebCore::PlatformWheelEvent::momentumPhase):
  63515. * platform/mac/ScrollAnimatorMac.mm:
  63516. (WebCore::ScrollAnimatorMac::handleWheelEvent):
  63517. (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
  63518. * platform/mac/WheelEventMac.mm:
  63519. (WebCore::momentumPhaseForEvent):
  63520. (WebCore::phaseForEvent):
  63521. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  63522. 2011-02-19 Gavin Barraclough <barraclough@apple.com>
  63523. Qt build fix.
  63524. * bridge/runtime_method.h:
  63525. (JSC::RuntimeMethod::createStructure):
  63526. 2011-02-19 Gavin Barraclough <barraclough@apple.com>
  63527. Qt build fix.
  63528. * bridge/qt/qt_instance.cpp:
  63529. * bridge/qt/qt_pixmapruntime.cpp:
  63530. 2011-02-19 Gavin Barraclough <barraclough@apple.com>
  63531. Qt build fix.
  63532. * bridge/qt/qt_instance.cpp:
  63533. (JSC::Bindings::QtInstance::getMethod):
  63534. * bridge/qt/qt_pixmapruntime.cpp:
  63535. (JSC::Bindings::QtPixmapInstance::getMethod):
  63536. 2011-02-18 Gavin Barraclough <barraclough@apple.com>
  63537. Reviewed by Sam Weinig.
  63538. Bug 54786 - Devirtualize JSCell::classInfo()
  63539. Instead of making a virtual function call, add a pointer to the ClassInfo
  63540. onto Structure.
  63541. This removes a virtual function call, and paves the way towards removing all
  63542. the createStructure methods, and StructureFlags/AnonymousSlotCount properties
  63543. (these should be able to move onto ClassInfo).
  63544. Calls to Structure::create must now pass a pointer to the ClassInfo for the
  63545. structure. All objects now have a ClassInfo pointer, non-object cell types
  63546. still do not.
  63547. Changes are most mechanical, involving three steps:
  63548. * Remove virtual classInfo() methods.
  63549. * Add &s_info parameter to calls to Structure::create.
  63550. * Rename ClassInfo static members on classes from 'info' to 's_info',
  63551. for consistency.
  63552. * WebCore.exp.in:
  63553. * bindings/js/JSAudioConstructor.cpp:
  63554. * bindings/js/JSAudioConstructor.h:
  63555. * bindings/js/JSDOMBinding.cpp:
  63556. * bindings/js/JSDOMBinding.h:
  63557. * bindings/js/JSDOMGlobalObject.cpp:
  63558. * bindings/js/JSDOMGlobalObject.h:
  63559. * bindings/js/JSDOMWindowBase.cpp:
  63560. * bindings/js/JSDOMWindowBase.h:
  63561. * bindings/js/JSDOMWindowShell.cpp:
  63562. * bindings/js/JSDOMWindowShell.h:
  63563. * bindings/js/JSGeolocationCustom.cpp:
  63564. * bindings/js/JSImageConstructor.cpp:
  63565. * bindings/js/JSImageConstructor.h:
  63566. * bindings/js/JSImageDataCustom.cpp:
  63567. * bindings/js/JSOptionConstructor.cpp:
  63568. * bindings/js/JSOptionConstructor.h:
  63569. * bindings/js/JSWorkerContextBase.cpp:
  63570. * bindings/js/JSWorkerContextBase.h:
  63571. * bindings/js/SerializedScriptValue.cpp:
  63572. * bindings/scripts/CodeGeneratorJS.pm:
  63573. * bridge/c/CRuntimeObject.cpp:
  63574. * bridge/c/CRuntimeObject.h:
  63575. * bridge/c/c_instance.cpp:
  63576. * bridge/jni/jsc/JNIUtilityPrivate.cpp:
  63577. * bridge/jni/jsc/JavaInstanceJSC.cpp:
  63578. * bridge/jni/jsc/JavaRuntimeObject.cpp:
  63579. * bridge/jni/jsc/JavaRuntimeObject.h:
  63580. * bridge/jsc/BridgeJSC.cpp:
  63581. * bridge/objc/ObjCRuntimeObject.h:
  63582. * bridge/objc/ObjCRuntimeObject.mm:
  63583. * bridge/objc/objc_instance.mm:
  63584. * bridge/objc/objc_runtime.h:
  63585. * bridge/objc/objc_runtime.mm:
  63586. * bridge/runtime_array.cpp:
  63587. * bridge/runtime_array.h:
  63588. * bridge/runtime_method.cpp:
  63589. * bridge/runtime_method.h:
  63590. * bridge/runtime_object.cpp:
  63591. * bridge/runtime_object.h:
  63592. 2011-02-19 Zan Dobersek <zandobersek@gmail.com>
  63593. Reviewed by Martin Robinson.
  63594. [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
  63595. https://bugs.webkit.org/show_bug.cgi?id=54491
  63596. When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
  63597. and would round to 0, alter the behaviour to ensure that width or height are
  63598. at least 1 pixel in size in these cases.
  63599. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  63600. (WebCore::GraphicsContext::roundToDevicePixels):
  63601. 2011-02-19 Dan Bernstein <mitz@apple.com>
  63602. LLVM Compiler build fix.
  63603. * platform/graphics/ShadowBlur.cpp:
  63604. (WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that generated
  63605. a global initializer since the compiler does not evaluate sqrtf at compile time.
  63606. 2011-02-19 Brian Ryner <bryner@chromium.org>
  63607. Reviewed by Adam Barth.
  63608. Replace the #include of DocumentLoader.h in Document.h with a
  63609. forward declaration, and add a missing #include now that this
  63610. transitive include is gone.
  63611. https://bugs.webkit.org/show_bug.cgi?id=50489
  63612. No new tests required.
  63613. * bindings/ScriptControllerBase.cpp:
  63614. * dom/Document.h:
  63615. 2011-02-19 Patrick Gansterer <paroga@webkit.org>
  63616. Reviewed by Antonio Gomes.
  63617. [EFL] Remove WebCore::currentTime()
  63618. https://bugs.webkit.org/show_bug.cgi?id=53886
  63619. There is no declaration for it and we use WTF::currentTime() everywhere.
  63620. * platform/efl/SystemTimeEfl.cpp:
  63621. 2011-02-19 Patrick Gansterer <paroga@webkit.org>
  63622. Reviewed by Andreas Kling.
  63623. Move KeygenWinCE from wince into win directory
  63624. https://bugs.webkit.org/show_bug.cgi?id=54804
  63625. Move this file into the win directory, since it can be used on all windows platforms.
  63626. * CMakeListsWinCE.txt:
  63627. * platform/win/SSLKeyGeneratorWin.cpp: Renamed from platform/wince/KeygenWinCE.cpp.
  63628. 2011-02-19 Patrick Gansterer <paroga@webkit.org>
  63629. Reviewed by Andreas Kling.
  63630. Make FileChooserWin.cpp more portable and use it on WinCE
  63631. https://bugs.webkit.org/show_bug.cgi?id=54803
  63632. * CMakeListsWinCE.txt:
  63633. * platform/win/FileChooserWin.cpp:
  63634. (WebCore::FileChooser::basenameForWidth):
  63635. * platform/wince/FileChooserWinCE.cpp: Removed.
  63636. 2011-02-19 James Simonsen <simonjam@chromium.org>
  63637. Reviewed by Adam Barth.
  63638. Make ScriptElement match the HTML5 spec
  63639. https://bugs.webkit.org/show_bug.cgi?id=54676
  63640. This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
  63641. http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script
  63642. There are a couple of things missing from the spec that would be new functionality. These will be added later.
  63643. - Support for async=false
  63644. - Empty src attribute should dispatch an error.
  63645. There are a couple of slight behavioral changes to match the spec.
  63646. - An XHTML script that is loaded then copied will not fire load on the copy.
  63647. - If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.
  63648. The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.
  63649. Test: All existing tests.
  63650. * dom/ScriptElement.cpp: Rewritten to match HTML5 spec.
  63651. (WebCore::ScriptElement::ScriptElement):
  63652. (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript.
  63653. (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript.
  63654. (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript.
  63655. (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests.
  63656. (WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript().
  63657. (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser.
  63658. (WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here.
  63659. (WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript.
  63660. (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts.
  63661. (WebCore::ScriptElement::execute): Renamed executeScript.
  63662. (WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts.
  63663. (WebCore::ScriptElement::ignoresLoadRequest): New variable names.
  63664. (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance.
  63665. (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
  63666. * dom/ScriptElement.h:
  63667. (WebCore::ScriptElement::willBeParserExecuted): Added.
  63668. (WebCore::ScriptElement::readyToBeParserExecuted): Added.
  63669. (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added.
  63670. (WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish.
  63671. (WebCore::ScriptElement::isParserInserted): Added.
  63672. * dom/XMLDocumentParserLibxml2.cpp:
  63673. (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
  63674. * dom/XMLDocumentParserQt.cpp:
  63675. (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
  63676. * html/HTMLScriptElement.cpp:
  63677. (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url.
  63678. (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
  63679. * html/HTMLScriptElement.h:
  63680. * html/parser/HTMLScriptRunner.cpp:
  63681. (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement.
  63682. (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
  63683. * svg/SVGScriptElement.cpp:
  63684. (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names.
  63685. (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url.
  63686. (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone.
  63687. (WebCore::SVGScriptElement::hasSourceAttribute): Added.
  63688. (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
  63689. * svg/SVGScriptElement.h:
  63690. 2011-02-19 Marc-Antoine Ruel <maruel@chromium.org>
  63691. Reviewed by James Robinson.
  63692. Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
  63693. https://bugs.webkit.org/show_bug.cgi?id=54789
  63694. * WebCore.gyp/WebCore.gyp:
  63695. 2011-02-19 Bill Budge <bbudge@chromium.org>
  63696. Reviewed by David Levin.
  63697. ThreadableLoaderClient needs willSendRequest method
  63698. https://bugs.webkit.org/show_bug.cgi?id=54688
  63699. No new tests. Exposes no new functionality
  63700. * WebCore.gypi:
  63701. * loader/DocumentThreadableLoader.cpp:
  63702. (WebCore::DocumentThreadableLoader::willSendRequest):
  63703. (WebCore::DocumentThreadableLoader::didReceiveData):
  63704. (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  63705. * loader/DocumentThreadableLoaderClient.h: Added.
  63706. (WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClient):
  63707. (WebCore::DocumentThreadableLoaderClient::willSendRequest):
  63708. * loader/ThreadableLoaderClient.h:
  63709. (WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
  63710. 2011-02-19 Charlie Reis <creis@chromium.org>
  63711. Reviewed by Mihai Parparita.
  63712. Ensure loading has stopped in HistoryController::goToItem
  63713. https://bugs.webkit.org/show_bug.cgi?id=54517
  63714. Avoid stopping all loaders in goToItem for same document navigations
  63715. or pseudo-back-forward URLs. Make HistoryController::goToItem private
  63716. to force callers to go through Page::goToItem. Also add a callback to
  63717. FrameLoaderClient to let clients decide whether to stop loading first.
  63718. Test: http/tests/navigation/forward-to-fragment-fires-onload.html
  63719. * loader/EmptyClients.h:
  63720. * loader/FrameLoader.h:
  63721. * loader/FrameLoaderClient.h:
  63722. * loader/HistoryController.cpp:
  63723. * loader/HistoryController.h:
  63724. * page/Page.cpp:
  63725. 2011-02-19 Adam Barth <abarth@webkit.org>
  63726. Reviewed by Daniel Bates.
  63727. Fix xssAuditor/iframe-injection.html
  63728. https://bugs.webkit.org/show_bug.cgi?id=54591
  63729. We should block the iframe src attribute. Although this technically
  63730. can't be used to run script, it's a pretty easy vector for stealing
  63731. passwords.
  63732. * html/parser/XSSFilter.cpp:
  63733. (WebCore::XSSFilter::filterTokenInitial):
  63734. (WebCore::XSSFilter::filterIframeToken):
  63735. * html/parser/XSSFilter.h:
  63736. 2011-02-18 Tony Gentilcore <tonyg@chromium.org>
  63737. Reviewed by Eric Seidel.
  63738. Let the parser yield for layout before running scripts
  63739. https://bugs.webkit.org/show_bug.cgi?id=54355
  63740. Prior to this patch, the parser would yield to perform a layout/paint before running a
  63741. script only if the script or a stylesheet blocking the script is not loaded yet. Since we
  63742. don't preload scan into the body while parsing the head, typically we'll block on a script
  63743. early in the body that causes us to yield to do the first paint within a reasonable time.
  63744. However, I'm planning to change the PreloadScanner to scan into the body from the head.
  63745. That significantly improves overall load time, but would hurt first paint time because
  63746. fewer scripts would be blocked during parsing and thus wouldn't yield.
  63747. This change causes us to yield before running scripts if we haven't painted yet (regardless
  63748. of whether or not the script is loaded). In addition to allowing the above mentioned
  63749. PreloadScanner change to be implemented without regressing first paint time, this also
  63750. improves first paint time by itself.
  63751. I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
  63752. bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
  63753. 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
  63754. signifcant change in page load time.
  63755. Within the pages tested, 33 had no statistically significant change in time to first paint,
  63756. 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
  63757. are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
  63758. * html/parser/HTMLDocumentParser.cpp:
  63759. (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
  63760. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
  63761. means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
  63762. the right thing whether we are just before a token or waiting for a script. Now that we may
  63763. yield before a token or before a script, this may be called while paused.
  63764. * html/parser/HTMLParserScheduler.cpp:
  63765. (WebCore::isLayoutTimerActive): Added a FIXME because r52919 changed minimumLayoutDelay()
  63766. to return m_extraLayoutDelay instead of 0 as a minimum. So checking !minimumLayoutDelay()
  63767. no longer works. The fix is to change it to check minimumLayoutDelay() ==
  63768. m_extraLayoutDelay. But this is all the more reason to move this method onto Document. I'll
  63769. do this in a follow up.
  63770. (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  63771. * page/FrameView.h:
  63772. (WebCore::FrameView::hasEverPainted): Added.
  63773. 2011-02-18 Dawit Alemayehu <adawit@kde.org>
  63774. Reviewed by Andreas Kling.
  63775. [Qt] Button Element is rendered w/ text off-center.
  63776. https://bugs.webkit.org/show_bug.cgi?id=53373
  63777. Test: LayoutTests/fast/forms/button-white-space.html
  63778. * platform/qt/RenderThemeQt.cpp:
  63779. (WebCore::RenderThemeQt::adjustButtonStyle):
  63780. 2011-02-18 Jonathan Backer <backer@chromium.org>
  63781. Reviewed by Eric Seidel.
  63782. [chromium] Fix leak of texture IDs in compositor.
  63783. https://bugs.webkit.org/show_bug.cgi?id=54750
  63784. No new tests. It is extremely unlikely that this leak would have
  63785. any user visible impact because only a few bytes of space are wasted
  63786. (we're leaking texture IDs, not actual textures) and the space of
  63787. texture IDs is large (32 bits).
  63788. * platform/graphics/chromium/TextureManager.cpp:
  63789. (WebCore::TextureManager::requestTexture):
  63790. 2011-02-18 Yi Shen <yi.4.shen@nokia.com>
  63791. Reviewed by Tor Arne Vestbø.
  63792. Always display the media controls when requiresFullscreenForVideoPlayback() is true
  63793. https://bugs.webkit.org/show_bug.cgi?id=54308
  63794. For video element, it should have controls when
  63795. Chrome::requiresFullscreenForVideoPlayback() is true.
  63796. * html/HTMLMediaElement.cpp:
  63797. (WebCore::HTMLMediaElement::controls):
  63798. 2011-02-18 Adrienne Walker <enne@google.com>
  63799. Reviewed by Kenneth Russell.
  63800. [chromium] Use nearest-neighbor filtering for root layer.
  63801. https://bugs.webkit.org/show_bug.cgi?id=54409
  63802. https://bugs.webkit.org/show_bug.cgi?id=54509
  63803. This setting creates more consistent images for LayoutTests and
  63804. prevents small floating point errors in texture coordinates from
  63805. creating off-by-one pixel color differences.
  63806. * platform/graphics/chromium/LayerTilerChromium.cpp:
  63807. (WebCore::LayerTilerChromium::update):
  63808. 2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  63809. Reviewed by Kent Tamura.
  63810. [EFL] Fix coding style errors in RenderThemeEfl.h
  63811. https://bugs.webkit.org/show_bug.cgi?id=54693
  63812. Fix style errors in RenderThemeEfl.h
  63813. * platform/efl/RenderThemeEfl.h:
  63814. 2011-02-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
  63815. Reviewed by Andreas Kling.
  63816. [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
  63817. https://bugs.webkit.org/show_bug.cgi?id=54742
  63818. This change was applied in the Qt repository (qt/src/3rdparty/webkit),
  63819. so we should do the same here in QtWebKit.
  63820. Patch by Eckhart Koppen <eckhart.koppen@nokia.com>
  63821. a8a84f1667966acfa093c4be0b7d4b0900ddd3d9:
  63822. The previously used name "Nokia, Qt" was not usable for Nokia
  63823. Content Signing, which only allows "Nokia" as the visible vendor
  63824. name. The unique vendor ID remains as "Nokia, Qt"
  63825. * WebCore.pro:
  63826. 2011-02-18 Alexis Menard <alexis.menard@openbossa.org>
  63827. Reviewed by Andreas Kling.
  63828. [Qt] REGRESSION(r67516) : on www.gmail.com a strange rendering issue appears on the
  63829. menu bar due to flash.
  63830. https://bugs.webkit.org/show_bug.cgi?id=54741
  63831. Only show plugins with a valid size. We then don't involve X11 if there is
  63832. nothing to see anyway.
  63833. * plugins/qt/PluginViewQt.cpp:
  63834. (WebCore::PluginView::updatePluginWidget):
  63835. (WebCore::PluginView::platformStart):
  63836. 2011-02-18 Ryuan Choi <ryuan.choi@samsung.com>
  63837. Reviewed by Kent Tamura.
  63838. [EFL] Remove GDK dependency.
  63839. https://bugs.webkit.org/show_bug.cgi?id=53978
  63840. Remove GLIB_SUPPORT macro in GDK related code.
  63841. Regardless of GLIB_SUPPORT, getDefaultFontOptions() will works same way.
  63842. * CMakeListsEfl.txt:
  63843. * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  63844. (WebCore::getDefaultFontOptions):
  63845. 2011-02-18 Noel Gordon <noel.gordon@gmail.com>
  63846. Reviewed by James Robinson.
  63847. [Chromium] Add elliptical gradient support to GradientSkia
  63848. https://bugs.webkit.org/show_bug.cgi?id=51841
  63849. Covered by existing tests, these need new rebaselines once this patch
  63850. lands for chrome linux, win32
  63851. fast/gradients/css3-color-stop-units.html
  63852. fast/gradients/css3-color-stops.html
  63853. fast/gradients/css3-linear-angle-gradients.html
  63854. fast/gradients/css3-radial-gradients.html
  63855. fast/gradients/css3-radial-gradients2.html
  63856. fast/gradients/css3-radial-gradients3.html
  63857. fast/gradients/css3-repeating-radial-gradients.html
  63858. * platform/graphics/skia/GradientSkia.cpp:
  63859. (WebCore::Gradient::platformGradient):
  63860. 2011-02-18 James Robinson <jamesr@chromium.org>
  63861. Fix typo in boundary test in ASSERT() - test is for an inclusive range, not exclusive.
  63862. * platform/graphics/chromium/ContentLayerChromium.cpp:
  63863. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  63864. 2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  63865. Reviewed by Kenneth Rohde Christiansen.
  63866. Tiled backing store area is too big.
  63867. Error in area calculcation causes size of backing store
  63868. up to 6 times bigger than viewport with default multipliers.
  63869. https://bugs.webkit.org/show_bug.cgi?id=54587
  63870. * platform/graphics/TiledBackingStore.cpp:
  63871. (WebCore::TiledBackingStore::createTiles):
  63872. 2011-02-18 Beth Dakin <bdakin@apple.com>
  63873. Reviewed by Sam Weinig.
  63874. Fix for <rdar://problem/9018729> Horizontal scroller doesn't
  63875. appear when loading a page with a Horizontal scrollbar from
  63876. the back/forward cache.
  63877. This patch adds a new bool member variable to FrameView to
  63878. keep track of whether we are loading a page from the back/
  63879. forward cache. If we are, don't suppress scrollbars on
  63880. first layout.
  63881. * history/CachedFrame.cpp:
  63882. (WebCore::CachedFrameBase::restore):
  63883. * page/FrameView.cpp:
  63884. (WebCore::FrameView::FrameView):
  63885. (WebCore::FrameView::reset):
  63886. (WebCore::FrameView::layout):
  63887. * page/FrameView.h:
  63888. (WebCore::FrameView::setIsRestoringFromBackForward):
  63889. (WebCore::FrameView::isRestoringFromBackForward):
  63890. 2011-02-18 Patrick Gansterer <paroga@webkit.org>
  63891. Unreviewed WinCE build fix for r78846.
  63892. * platform/graphics/wince/FontWinCE.cpp:
  63893. (WebCore::TextRunComponent::TextRunComponent):
  63894. * platform/graphics/wince/GraphicsContextWinCE.cpp:
  63895. (WebCore::GraphicsContext::drawLineForText):
  63896. (WebCore::GraphicsContext::drawLineForTextChecking):
  63897. (WebCore::GraphicsContext::drawText):
  63898. * platform/wince/FileChooserWinCE.cpp:
  63899. (WebCore::FileChooser::basenameForWidth):
  63900. 2011-02-18 Emil A Eklund <eae@chromium.org>
  63901. Reviewed by Darin Adler.
  63902. Crash in EventHandler::sendContextMenuEventForKey
  63903. https://bugs.webkit.org/show_bug.cgi?id=54495
  63904. Test: fast/events/menu-keydown-on-hidden-element.html
  63905. * page/EventHandler.cpp:
  63906. (WebCore::EventHandler::sendContextMenuEventForKey): Add null check.
  63907. 2011-02-15 Adrienne Walker <enne@google.com>
  63908. Reviewed by James Robinson.
  63909. [chromium] Clean up shader code from LayerChromium classes
  63910. https://bugs.webkit.org/show_bug.cgi?id=54484
  63911. This is a refactoring and there should be no change in functionality.
  63912. All shader code is pulled out into classes in ShaderChromium.
  63913. The SharedValues classes are now turned into ProgramBinding, one per
  63914. shader program. These contain shader classes that know about what
  63915. variables they can bind.
  63916. * WebCore.gypi:
  63917. * platform/graphics/chromium/CanvasLayerChromium.cpp:
  63918. (WebCore::CanvasLayerChromium::draw):
  63919. * platform/graphics/chromium/CanvasLayerChromium.h:
  63920. * platform/graphics/chromium/ContentLayerChromium.cpp:
  63921. (WebCore::ContentLayerChromium::draw):
  63922. * platform/graphics/chromium/ContentLayerChromium.h:
  63923. * platform/graphics/chromium/GeometryBinding.cpp: Added.
  63924. (WebCore::GeometryBinding::GeometryBinding):
  63925. (WebCore::GeometryBinding::~GeometryBinding):
  63926. (WebCore::GeometryBinding::prepareForDraw):
  63927. * platform/graphics/chromium/GeometryBinding.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
  63928. (WebCore::GeometryBinding::initialized):
  63929. (WebCore::GeometryBinding::context):
  63930. (WebCore::GeometryBinding::quadVerticesVbo):
  63931. (WebCore::GeometryBinding::quadElementsVbo):
  63932. (WebCore::GeometryBinding::positionAttribLocation):
  63933. (WebCore::GeometryBinding::texCoordAttribLocation):
  63934. * platform/graphics/chromium/LayerChromium.cpp:
  63935. (WebCore::LayerChromium::drawDebugBorder):
  63936. * platform/graphics/chromium/LayerChromium.h:
  63937. * platform/graphics/chromium/LayerRendererChromium.cpp:
  63938. (WebCore::LayerRendererChromium::drawLayers):
  63939. (WebCore::LayerRendererChromium::initializeSharedObjects):
  63940. (WebCore::LayerRendererChromium::cleanupSharedObjects):
  63941. * platform/graphics/chromium/LayerRendererChromium.h:
  63942. (WebCore::LayerRendererChromium::sharedGeometry):
  63943. (WebCore::LayerRendererChromium::borderProgram):
  63944. (WebCore::LayerRendererChromium::contentLayerProgram):
  63945. (WebCore::LayerRendererChromium::canvasLayerProgram):
  63946. (WebCore::LayerRendererChromium::videoLayerRGBAProgram):
  63947. (WebCore::LayerRendererChromium::videoLayerYUVProgram):
  63948. (WebCore::LayerRendererChromium::pluginLayerProgram):
  63949. (WebCore::LayerRendererChromium::renderSurfaceProgram):
  63950. (WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
  63951. (WebCore::LayerRendererChromium::tilerProgram):
  63952. * platform/graphics/chromium/LayerTilerChromium.cpp:
  63953. (WebCore::LayerTilerChromium::draw):
  63954. (WebCore::LayerTilerChromium::drawTexturedQuad):
  63955. * platform/graphics/chromium/LayerTilerChromium.h:
  63956. * platform/graphics/chromium/PluginLayerChromium.cpp:
  63957. (WebCore::PluginLayerChromium::draw):
  63958. * platform/graphics/chromium/PluginLayerChromium.h:
  63959. * platform/graphics/chromium/ProgramBinding.cpp: Added.
  63960. (WebCore::ProgramBindingBase::ProgramBindingBase):
  63961. (WebCore::ProgramBindingBase::~ProgramBindingBase):
  63962. (WebCore::ProgramBindingBase::init):
  63963. (WebCore::ProgramBindingBase::loadShader):
  63964. (WebCore::ProgramBindingBase::createShaderProgram):
  63965. * platform/graphics/chromium/ProgramBinding.h: Added.
  63966. (WebCore::ProgramBindingBase::program):
  63967. (WebCore::ProgramBindingBase::initialized):
  63968. (WebCore::ProgramBinding::ProgramBinding):
  63969. (WebCore::ProgramBinding::vertexShader):
  63970. (WebCore::ProgramBinding::fragmentShader):
  63971. * platform/graphics/chromium/RenderSurfaceChromium.cpp:
  63972. (WebCore::RenderSurfaceChromium::drawSurface):
  63973. * platform/graphics/chromium/RenderSurfaceChromium.h:
  63974. * platform/graphics/chromium/ShaderChromium.cpp: Added.
  63975. (WebCore::VertexShaderPosTex::VertexShaderPosTex):
  63976. (WebCore::VertexShaderPosTex::init):
  63977. (WebCore::VertexShaderPosTex::getShaderString):
  63978. (WebCore::VertexShaderPosTexYUVStretch::VertexShaderPosTexYUVStretch):
  63979. (WebCore::VertexShaderPosTexYUVStretch::init):
  63980. (WebCore::VertexShaderPosTexYUVStretch::getShaderString):
  63981. (WebCore::VertexShaderPos::VertexShaderPos):
  63982. (WebCore::VertexShaderPos::init):
  63983. (WebCore::VertexShaderPos::getShaderString):
  63984. (WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
  63985. (WebCore::VertexShaderPosTexTransform::init):
  63986. (WebCore::VertexShaderPosTexTransform::getShaderString):
  63987. (WebCore::FragmentTexAlphaBinding::FragmentTexAlphaBinding):
  63988. (WebCore::FragmentTexAlphaBinding::init):
  63989. (WebCore::FragmentShaderRGBATexFlipAlpha::getShaderString):
  63990. (WebCore::FragmentShaderRGBATexAlpha::getShaderString):
  63991. (WebCore::FragmentShaderBGRATexAlpha::getShaderString):
  63992. (WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
  63993. (WebCore::FragmentShaderRGBATexAlphaMask::init):
  63994. (WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
  63995. (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
  63996. (WebCore::FragmentShaderYUVVideo::init):
  63997. (WebCore::FragmentShaderYUVVideo::getShaderString):
  63998. (WebCore::FragmentShaderColor::FragmentShaderColor):
  63999. (WebCore::FragmentShaderColor::init):
  64000. (WebCore::FragmentShaderColor::getShaderString):
  64001. * platform/graphics/chromium/ShaderChromium.h: Added.
  64002. (WebCore::VertexShaderPosTex::matrixLocation):
  64003. (WebCore::VertexShaderPosTexYUVStretch::matrixLocation):
  64004. (WebCore::VertexShaderPosTexYUVStretch::yWidthScaleFactorLocation):
  64005. (WebCore::VertexShaderPosTexYUVStretch::uvWidthScaleFactorLocation):
  64006. (WebCore::VertexShaderPos::matrixLocation):
  64007. (WebCore::VertexShaderPosTexTransform::matrixLocation):
  64008. (WebCore::VertexShaderPosTexTransform::texTransformLocation):
  64009. (WebCore::FragmentTexAlphaBinding::alphaLocation):
  64010. (WebCore::FragmentTexAlphaBinding::samplerLocation):
  64011. (WebCore::FragmentShaderRGBATexAlphaMask::alphaLocation):
  64012. (WebCore::FragmentShaderRGBATexAlphaMask::samplerLocation):
  64013. (WebCore::FragmentShaderRGBATexAlphaMask::maskSamplerLocation):
  64014. (WebCore::FragmentShaderYUVVideo::yTextureLocation):
  64015. (WebCore::FragmentShaderYUVVideo::uTextureLocation):
  64016. (WebCore::FragmentShaderYUVVideo::vTextureLocation):
  64017. (WebCore::FragmentShaderYUVVideo::alphaLocation):
  64018. (WebCore::FragmentShaderYUVVideo::ccMatrixLocation):
  64019. (WebCore::FragmentShaderYUVVideo::signAdjLocation):
  64020. (WebCore::FragmentShaderColor::colorLocation):
  64021. * platform/graphics/chromium/VideoLayerChromium.cpp:
  64022. (WebCore::VideoLayerChromium::draw):
  64023. (WebCore::VideoLayerChromium::drawYUV):
  64024. (WebCore::VideoLayerChromium::drawRGBA):
  64025. * platform/graphics/chromium/VideoLayerChromium.h:
  64026. 2011-02-18 James Robinson <jamesr@chromium.org>
  64027. Reviewed by Kenneth Russell.
  64028. [chromium] Update texture for ContentLayerChromiums in draw() call instead of updateContents..() call
  64029. https://bugs.webkit.org/show_bug.cgi?id=54315
  64030. This defers all operations on the compositor's GL context until the
  64031. draw() call which is a prerequisite for moving the draw() off-thread.
  64032. Also cleans up the update cycle a bit - there were some unused local
  64033. variables and whatnot.
  64034. One consequence of this change is that the upload buffer is retained
  64035. across updates now instead of allocated by each paint. This is
  64036. necessary so that the full layer contents can be uploaded if the
  64037. texture manager evicts the layer's backing texture. This costs more
  64038. persistent memory but avoids lots of allocator churn on updates.
  64039. Another nonobvious detail is that I have to update the texture for
  64040. ContentLayerChromiums in bindContentsTexture() because mask layers
  64041. never draw(), they are instead bound to the secondary texture unit.
  64042. * platform/graphics/chromium/ContentLayerChromium.cpp:
  64043. (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
  64044. (WebCore::ContentLayerChromium::updateContentsIfDirty):
  64045. (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
  64046. (WebCore::ContentLayerChromium::resizeUploadBuffer):
  64047. (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
  64048. (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
  64049. (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
  64050. (WebCore::ContentLayerChromium::updateTextureIfNeeded):
  64051. (WebCore::ContentLayerChromium::draw):
  64052. (WebCore::ContentLayerChromium::unreserveContentsTexture):
  64053. (WebCore::ContentLayerChromium::bindContentsTexture):
  64054. * platform/graphics/chromium/ContentLayerChromium.h:
  64055. * platform/graphics/chromium/ImageLayerChromium.cpp:
  64056. (WebCore::ImageLayerChromium::updateContentsIfDirty):
  64057. * platform/graphics/chromium/LayerChromium.cpp:
  64058. (WebCore::LayerChromium::setBounds):
  64059. * platform/graphics/chromium/LayerChromium.h:
  64060. 2011-02-18 Kenneth Russell <kbr@google.com>
  64061. Unreviewed, Chromium build fix on certain Linux platforms.
  64062. * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
  64063. 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  64064. Reviewed by Kenneth Rohde Christiansen.
  64065. [Qt] Implement client based geolocation for qtport
  64066. https://bugs.webkit.org/show_bug.cgi?id=42629
  64067. Implements client based geolocation for qtwebkit. Removed old code related to non-client based geolocation
  64068. No tests as yet. This will be raised as different bug as new mock client implementation need to be done.
  64069. * WebCore.pro:
  64070. * features.pri:
  64071. * platform/qt/GeolocationServiceQt.cpp: Removed.
  64072. * platform/qt/GeolocationServiceQt.h: Removed.
  64073. 2011-02-18 Yael Aharon <yael.aharon@nokia.com>
  64074. Reviewed by Dave Hyatt.
  64075. Add support for dir=auto
  64076. https://bugs.webkit.org/show_bug.cgi?id=50916
  64077. When an element has dir attribute with value "auto", call defaultWritingMode
  64078. to find its directionality.
  64079. Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set
  64080. and check this flag. This flag is set on every node between an element with
  64081. dir=auto attribute and its first text node. Changes in the DOM between those
  64082. elements will trigger re-evaluating the directionality, but changes not
  64083. between those element do not need to be concerned.
  64084. The DOM hooks were added to childrenChanged, and to parseMappedAttribute.
  64085. The directionality is evaluated when children are added, and cleared when they are
  64086. removed. Directionality flag is also cleared on a child that is no longer determining
  64087. the directionality due to a sibling being added before that child.
  64088. Added 2 static CSSMutableStyleDeclarations to be used for elements with dir=auto.
  64089. We cannot used the mapped declaration, because it can take only one value.
  64090. Tests: fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html
  64091. fast/dom/HTMLElement/attr-dir-auto-change-child-node.html
  64092. fast/dom/HTMLElement/attr-dir-auto-change-text.html
  64093. fast/dom/HTMLElement/attr-dir-auto-children.html
  64094. fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html
  64095. fast/dom/HTMLElement/attr-dir-auto.html
  64096. fast/dom/HTMLElement/attr-dir-value-change.html
  64097. * css/CSSStyleSelector.cpp:
  64098. (WebCore::leftToRightDeclaration):
  64099. (WebCore::rightToLeftDeclaration):
  64100. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  64101. (WebCore::CSSStyleSelector::styleForElement):
  64102. * dom/Node.h:
  64103. (WebCore::Node::selfOrAncestorHasDirAutoAttribute):
  64104. (WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):
  64105. * html/HTMLElement.cpp:
  64106. (WebCore::HTMLElement::mapToEntry):
  64107. (WebCore::HTMLElement::parseMappedAttribute):
  64108. (WebCore::setHasDirAutoFlagRecursively):
  64109. (WebCore::HTMLElement::childrenChanged):
  64110. (WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
  64111. (WebCore::HTMLElement::directionality):
  64112. (WebCore::HTMLElement::dirAttributeChanged):
  64113. (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
  64114. (WebCore::HTMLElement::calculateAndAdjustDirectionality):
  64115. (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
  64116. * html/HTMLElement.h:
  64117. 2011-02-18 Yael Aharon <yael.aharon@nokia.com>
  64118. Reviewed by Antonio Gomes.
  64119. Navigating downwards / upwards does not focus on the links spread across more than one line.
  64120. https://bugs.webkit.org/show_bug.cgi?id=54639
  64121. When 2 anchor elements span more than one line each, and one ends on the same line that the
  64122. second starts on, the rects reported by their renderers are overlapping. When handling
  64123. 2 overlapping nodes, check for this case, and don't assume that one of the nodes is on a higher layer.
  64124. Test: fast/spatial-navigation/snav-two-elements-one-line.html
  64125. * page/FocusController.cpp:
  64126. (WebCore::updateFocusCandidateIfNeeded):
  64127. (WebCore::FocusController::findFocusCandidateInContainer):
  64128. * page/SpatialNavigation.cpp:
  64129. (WebCore::areElementsOnSameLine):
  64130. (WebCore::distanceDataForNode):
  64131. * page/SpatialNavigation.h:
  64132. 2011-02-18 Ben Vanik <benvanik@google.com>
  64133. Reviewed by Kenneth Russell.
  64134. Bug 53940: Implement the OES_vertex_array_object WebGL extension
  64135. https://bugs.webkit.org/show_bug.cgi?id=53940
  64136. Initial implementation of the OES_vertex_array_object extension adding the OESVertexArrayObject
  64137. extension container and WebGLVertexArrayObjectOES VAO object. The extension is plumbed through
  64138. the Extensions3D interface and implemented in the Extensions3DOpenGL (WebKit/OSX) version when
  64139. it is available.
  64140. Two big changes touching code outside of the extension files:
  64141. * Moved the typedefs at the top of GraphicsContext3D.h to GraphicsTypes3D.h (modeled after
  64142. GraphicsTypes.h). They are not namespaced as they weren't before.
  64143. * To make the code cleaner/clearer all vertex attribute state has been moved to the
  64144. WebGLVertexArrayObjectOES type (struct VertexAttribState) except for values which are still
  64145. on the WebGLRenderingContext. A default VAO is now used to store the existing attribute
  64146. states for when no other VAO is used. Code in WebGLRenderingContext dealing with buffers and
  64147. vertex attributes now defers to or stores values in the bound array object.
  64148. Tested against the WebGL conformance suite and the new
  64149. oes-vertex-array-object test:
  64150. https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-vertex-array-object.html
  64151. * CMakeLists.txt:
  64152. * CodeGenerators.pri:
  64153. * DerivedSources.make:
  64154. * GNUmakefile.am:
  64155. * WebCore.gyp: Modified property svn:ignore.
  64156. * WebCore.gypi:
  64157. * WebCore.pro:
  64158. * WebCore.xcodeproj/project.pbxproj:
  64159. * bindings/js/JSWebGLRenderingContextCustom.cpp:
  64160. (WebCore::toJS):
  64161. * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  64162. (WebCore::toV8Object):
  64163. * html/canvas/OESVertexArrayObject.cpp: Added.
  64164. (WebCore::OESVertexArrayObject::OESVertexArrayObject):
  64165. (WebCore::OESVertexArrayObject::~OESVertexArrayObject):
  64166. (WebCore::OESVertexArrayObject::getName):
  64167. (WebCore::OESVertexArrayObject::create):
  64168. (WebCore::OESVertexArrayObject::createVertexArrayOES):
  64169. (WebCore::OESVertexArrayObject::deleteVertexArrayOES):
  64170. (WebCore::OESVertexArrayObject::isVertexArrayOES):
  64171. (WebCore::OESVertexArrayObject::bindVertexArrayOES):
  64172. * html/canvas/OESVertexArrayObject.h: Added.
  64173. * html/canvas/OESVertexArrayObject.idl: Added.
  64174. * html/canvas/WebGLExtension.h:
  64175. * html/canvas/WebGLGetInfo.cpp:
  64176. (WebCore::WebGLGetInfo::WebGLGetInfo):
  64177. (WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
  64178. * html/canvas/WebGLGetInfo.h:
  64179. * html/canvas/WebGLRenderingContext.cpp:
  64180. (WebCore::WebGLRenderingContext::initializeNewContext):
  64181. (WebCore::WebGLRenderingContext::bindBuffer):
  64182. (WebCore::WebGLRenderingContext::deleteBuffer):
  64183. (WebCore::WebGLRenderingContext::disableVertexAttribArray):
  64184. (WebCore::WebGLRenderingContext::validateElementArraySize):
  64185. (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
  64186. (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
  64187. (WebCore::WebGLRenderingContext::validateRenderingState):
  64188. (WebCore::WebGLRenderingContext::drawElements):
  64189. (WebCore::WebGLRenderingContext::enableVertexAttribArray):
  64190. (WebCore::WebGLRenderingContext::getExtension):
  64191. (WebCore::WebGLRenderingContext::getParameter):
  64192. (WebCore::WebGLRenderingContext::getSupportedExtensions):
  64193. (WebCore::WebGLRenderingContext::getVertexAttrib):
  64194. (WebCore::WebGLRenderingContext::vertexAttribPointer):
  64195. (WebCore::WebGLRenderingContext::validateBufferDataParameters):
  64196. (WebCore::WebGLRenderingContext::vertexAttribfImpl):
  64197. (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  64198. (WebCore::WebGLRenderingContext::initVertexAttrib0):
  64199. (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
  64200. (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
  64201. (WebCore::WebGLRenderingContext::getNumberOfExtensions):
  64202. (WebCore::WebGLRenderingContext::getExtensionNumber):
  64203. * html/canvas/WebGLRenderingContext.h:
  64204. (WebCore::WebGLRenderingContext::getMaxVertexAttribs):
  64205. (WebCore::WebGLRenderingContext::setBoundVertexArrayObject):
  64206. (WebCore::WebGLRenderingContext::VertexAttribValue::VertexAttribValue):
  64207. * html/canvas/WebGLVertexArrayObjectOES.cpp: Added.
  64208. (WebCore::WebGLVertexArrayObjectOES::create):
  64209. (WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
  64210. (WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
  64211. * html/canvas/WebGLVertexArrayObjectOES.h: Added.
  64212. (WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
  64213. (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribState):
  64214. (WebCore::WebGLVertexArrayObjectOES::isDefaultObject):
  64215. (WebCore::WebGLVertexArrayObjectOES::hasEverBeenBound):
  64216. (WebCore::WebGLVertexArrayObjectOES::setHasEverBeenBound):
  64217. (WebCore::WebGLVertexArrayObjectOES::getElementArrayBuffer):
  64218. (WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
  64219. (WebCore::WebGLVertexArrayObjectOES::getVertexAttribState):
  64220. (WebCore::WebGLVertexArrayObjectOES::isVertexArray):
  64221. * html/canvas/WebGLVertexArrayObjectOES.idl: Added.
  64222. * platform/graphics/Extensions3D.h:
  64223. * platform/graphics/GraphicsContext3D.h:
  64224. * platform/graphics/GraphicsTypes3D.h: Added.
  64225. * platform/graphics/chromium/Extensions3DChromium.h:
  64226. * platform/graphics/opengl/Extensions3DOpenGL.cpp:
  64227. (WebCore::Extensions3DOpenGL::supports):
  64228. (WebCore::Extensions3DOpenGL::createVertexArrayOES):
  64229. (WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
  64230. (WebCore::Extensions3DOpenGL::isVertexArrayOES):
  64231. (WebCore::Extensions3DOpenGL::bindVertexArrayOES):
  64232. * platform/graphics/opengl/Extensions3DOpenGL.h:
  64233. * platform/graphics/qt/Extensions3DQt.cpp:
  64234. (WebCore::Extensions3DQt::createVertexArrayOES):
  64235. (WebCore::Extensions3DQt::deleteVertexArrayOES):
  64236. (WebCore::Extensions3DQt::isVertexArrayOES):
  64237. (WebCore::Extensions3DQt::bindVertexArrayOES):
  64238. * platform/graphics/qt/Extensions3DQt.h:
  64239. 2011-02-17 Alexander Pavlov <apavlov@chromium.org>
  64240. Reviewed by Pavel Feldman.
  64241. Web Inspector: reflect changes to styles when they happen outside inspector.
  64242. https://bugs.webkit.org/show_bug.cgi?id=44620
  64243. Notify InspectorInstrumentation of inline style changes from CSSMutableStyleDeclaration
  64244. whenever the style change does not come from a direct "style" attribute modification.
  64245. The performance regression occurs only with the Web Inspector opened, when inline styles
  64246. are modified through setting style.cssText or style.<styleAttribute>: according to the Web Inspector protocol,
  64247. an attribute change requires that all attributes for the node in question be pushed into the frontend.
  64248. Test: inspector/styles/styles-update-from-js.html
  64249. * css/CSSMutableStyleDeclaration.cpp:
  64250. (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
  64251. * inspector/InspectorDOMAgent.cpp:
  64252. (WebCore::RevalidateStyleAttributeTask::reset):
  64253. (WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
  64254. (WebCore::RevalidateStyleAttributeTask::scheduleFor):
  64255. (WebCore::RevalidateStyleAttributeTask::onTimer):
  64256. (WebCore::InspectorDOMAgent::reset):
  64257. (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
  64258. * inspector/InspectorDOMAgent.h:
  64259. * inspector/InspectorInstrumentation.cpp:
  64260. (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
  64261. * inspector/InspectorInstrumentation.h:
  64262. (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
  64263. * inspector/InspectorStyleSheet.cpp:
  64264. (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
  64265. (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
  64266. (WebCore::InspectorStyleSheetForInlineStyle::elementStyleText):
  64267. * inspector/InspectorStyleSheet.h:
  64268. * inspector/front-end/ElementsPanel.js:
  64269. (WebInspector.ElementsPanel.prototype._attributesUpdated):
  64270. * inspector/front-end/StylesSidebarPane.js:
  64271. (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
  64272. (WebInspector.StylesSidebarPane.prototype.addBlankSection):
  64273. (WebInspector.StylePropertiesSection.prototype.onpopulate):
  64274. (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
  64275. (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
  64276. (WebInspector.BlankStylePropertiesSection):
  64277. (WebInspector.StylePropertyTreeElement):
  64278. (WebInspector.StylePropertyTreeElement.prototype):
  64279. (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
  64280. 2011-02-16 Tony Gentilcore <tonyg@chromium.org>
  64281. Reviewed by Eric Seidel.
  64282. Refactor pumpTokenizer loop
  64283. https://bugs.webkit.org/show_bug.cgi?id=54574
  64284. 1. This makes pumpTokenizer() safe to call when waiting for a script or when about to get
  64285. the next token, although ASSERTs still enforce that we aren't waiting for a script. This
  64286. enables resumeParsingAfterYield() to call pumpTokenizer with no modifications even if we
  64287. yield before running a script rather than before taking a token (see bug 54355).
  64288. 2. This also picks up the refCount >= 1 assert when stopped.
  64289. Tested PerformanceTests/Parser to verify no regression. If anything it got faster.
  64290. Before:
  64291. avg 985.05
  64292. median 985.5
  64293. stdev 3.007906248539007
  64294. min 980
  64295. max 990
  64296. After:
  64297. avg 980.05
  64298. median 981
  64299. stdev 3.122098653149833
  64300. min 974
  64301. max 985
  64302. No new tests because no new functionality.
  64303. * html/parser/HTMLDocumentParser.cpp:
  64304. (WebCore::HTMLDocumentParser::canTakeNextToken): Added.
  64305. (WebCore::HTMLDocumentParser::pumpTokenizer):
  64306. * html/parser/HTMLDocumentParser.h:
  64307. 2011-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
  64308. Unreviewed, rolling out r79003.
  64309. http://trac.webkit.org/changeset/79003
  64310. https://bugs.webkit.org/show_bug.cgi?id=54753
  64311. It broke tests on GTK bots (Requested by Ossy on #webkit).
  64312. * accessibility/AccessibilityRenderObject.cpp:
  64313. (WebCore::lastChildConsideringContinuation):
  64314. * dom/Node.cpp:
  64315. (WebCore::Node::removeEventListener):
  64316. * html/DateComponents.cpp:
  64317. (WebCore::DateComponents::parseTime):
  64318. 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
  64319. Rubber-stamped by Andreas Kling.
  64320. Warning fix. Use ASSERT_UNUSED() instead of ASSERT().
  64321. * accessibility/AccessibilityRenderObject.cpp:
  64322. (WebCore::lastChildConsideringContinuation):
  64323. * dom/Node.cpp:
  64324. (WebCore::Node::removeEventListener):
  64325. * html/DateComponents.cpp:
  64326. (WebCore::DateComponents::parseTime):
  64327. 2011-02-18 Andrey Adaikin <aandrey@google.com>
  64328. Reviewed by Pavel Feldman.
  64329. Web Inspector: [Text editor] Optimize editing updates in main panel
  64330. https://bugs.webkit.org/show_bug.cgi?id=54661
  64331. * inspector/front-end/TextViewer.js:
  64332. (WebInspector.TextViewer):
  64333. (WebInspector.TextViewer.prototype._textChanged):
  64334. (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
  64335. (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
  64336. (WebInspector.TextViewer.prototype._syncDecorationsForLine):
  64337. (WebInspector.TextEditorChunkedPanel.prototype.textChanged):
  64338. (WebInspector.TextEditorChunkedPanel.prototype._scroll):
  64339. (WebInspector.TextEditorChunkedPanel.prototype.chunkForLine):
  64340. (WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
  64341. (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
  64342. (WebInspector.TextEditorGutterChunk):
  64343. (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
  64344. (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
  64345. (WebInspector.TextEditorMainPanel):
  64346. (WebInspector.TextEditorMainPanel.prototype._expandChunks):
  64347. (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
  64348. (WebInspector.TextEditorMainPanel.prototype._markSkippedPaintLines):
  64349. (WebInspector.TextEditorMainPanel.prototype._paintSkippedLines):
  64350. (WebInspector.TextEditorMainPanel.prototype._paintLines):
  64351. (WebInspector.TextEditorMainPanel.prototype._paintLine):
  64352. (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
  64353. (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
  64354. (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  64355. (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
  64356. (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
  64357. (WebInspector.TextEditorMainChunk):
  64358. (WebInspector.TextEditorMainChunk.prototype.get startLine):
  64359. (WebInspector.TextEditorMainChunk.prototype.set startLine):
  64360. (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
  64361. (WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
  64362. 2011-02-18 Steve Block <steveblock@google.com>
  64363. Reviewed by Andreas Kling
  64364. Memory allocation error in convertV8ObjectToNPVariant() for strings
  64365. https://bugs.webkit.org/show_bug.cgi?id=54737
  64366. Include the termination character in the length when allocating memory
  64367. and copying the string. This fixes a crashing bug on Android.
  64368. This should be tested by the java/ tests on Chromium, but these
  64369. tests are currently skipped.
  64370. * bindings/v8/V8NPUtils.cpp:
  64371. (WebCore::convertV8ObjectToNPVariant):
  64372. 2011-02-18 Philippe Normand <pnormand@igalia.com>
  64373. Unreviewed, rolling out r78979.
  64374. http://trac.webkit.org/changeset/78979
  64375. https://bugs.webkit.org/show_bug.cgi?id=53146
  64376. causes multiple crashes on GTK
  64377. * accessibility/gtk/AXObjectCacheAtk.cpp:
  64378. (WebCore::notifyChildrenSelectionChange):
  64379. (WebCore::AXObjectCache::postPlatformNotification):
  64380. 2011-02-18 Philippe Normand <pnormand@igalia.com>
  64381. Reviewed by Martin Robinson.
  64382. [GTK] minimal build unrecognized options
  64383. https://bugs.webkit.org/show_bug.cgi?id=50890
  64384. * GNUmakefile.am: new feature defines for optional features build.
  64385. 2011-02-17 Hans Wennborg <hans@chromium.org>
  64386. Reviewed by Jeremy Orlow.
  64387. IndexedDB: Populate indexes created for object stores with data
  64388. https://bugs.webkit.org/show_bug.cgi?id=54669
  64389. Make sure that indices for object stores that already hold data get
  64390. populated.
  64391. * storage/IDBIndexBackendImpl.h:
  64392. (WebCore::IDBIndexBackendImpl::hasValidId):
  64393. * storage/IDBObjectStoreBackendImpl.cpp:
  64394. (WebCore::IDBObjectStoreBackendImpl::putInternal):
  64395. (WebCore::populateIndex):
  64396. (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
  64397. 2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
  64398. Reviewed by Martin Robinson.
  64399. [GTK] Combo boxes should emit object:selection-changed even when collapsed
  64400. https://bugs.webkit.org/show_bug.cgi?id=53146
  64401. Emit the selection-changed signals when the menu list value has changed
  64402. Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
  64403. * accessibility/gtk/AXObjectCacheAtk.cpp:
  64404. (WebCore::getListObject): New, return the right list object for
  64405. menu lists and list boxes.
  64406. (WebCore::notifyChildrenSelectionChange): Support menu lists.
  64407. (WebCore::AXObjectCache::postPlatformNotification): Call function
  64408. notifyChildrenSelectionChange for AXMenuListValueChanged.
  64409. 2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
  64410. Reviewed by Martin Robinson.
  64411. [Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
  64412. https://bugs.webkit.org/show_bug.cgi?id=53453
  64413. Ensure that atk_text_{get|set}_selection() work with list items.
  64414. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  64415. (webkit_accessible_text_get_text): Properly handle list item
  64416. markers when returning the text for an object for a given interval
  64417. specified through the startOffset and endOffset parameters.
  64418. (getSelectionOffsetsForObject): Bear in mind list item markers
  64419. when returning the offsets for a selection over a list item.
  64420. (webkit_accessible_text_set_selection): Adjust offsets if needed
  64421. for list items with item markers. Ensure that it returns TRUE only
  64422. when everything went fine setting the text selection.
  64423. 2011-02-18 Antti Koivisto <antti@apple.com>
  64424. Reviewed by Maciej Stachowiak.
  64425. https://bugs.webkit.org/show_bug.cgi?id=54728
  64426. checkSelector*Value functions used in fastCheckSelector fail to inline
  64427. Wrap the functions used as template arguments to classes.
  64428. * css/CSSStyleSelector.cpp:
  64429. (WebCore::fastCheckSingleSelector):
  64430. (WebCore::ClassCheck::checkValue):
  64431. (WebCore::IdCheck::checkValue):
  64432. (WebCore::TagCheck::checkValue):
  64433. (WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
  64434. 2011-02-17 Simon Fraser <simon.fraser@apple.com>
  64435. Reviewed by Sam Weinig.
  64436. Composited iframe content is missing from snapshots in WebKit2
  64437. https://bugs.webkit.org/show_bug.cgi?id=54696
  64438. We need to propagate the 'flattening' paint behavior flag
  64439. down to subviews while painting. WebKit1 does this via
  64440. code in WebFrameView, but this is a more general fix
  64441. that works in WebKit2 as well.
  64442. Made a utility method, parentFrameView(), which I changed
  64443. some other methods to use as well.
  64444. * page/FrameView.cpp:
  64445. (WebCore::FrameView::isEnclosedInCompositingLayer):
  64446. (WebCore::FrameView::useSlowRepaints):
  64447. (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
  64448. (WebCore::FrameView::isOverlappedIncludingAncestors):
  64449. (WebCore::FrameView::parentFrameView):
  64450. (WebCore::FrameView::paintContents):
  64451. * page/FrameView.h:
  64452. 2011-02-17 Dan Bernstein <mitz@apple.com>
  64453. Reviewed by Simon Fraser.
  64454. <rdar://problem/8898595> Pages that use fixed positioning display poorly when scaled
  64455. * html/HTMLBodyElement.cpp:
  64456. (WebCore::adjustForZoom): Account for page scale.
  64457. (WebCore::HTMLBodyElement::setScrollLeft): Ditto.
  64458. (WebCore::HTMLBodyElement::setScrollTop): Ditto.
  64459. * page/FrameView.cpp:
  64460. (WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView here and changed to
  64461. account for page scale: when the page is scaled, the “viewport” with respect to which fixed
  64462. objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
  64463. the frame view), we move it around in proportion to the document scroll, so that when the document
  64464. is fully scrolled to the bottom-right, the bottom right of the scaled viewport is visible.
  64465. (WebCore::FrameView::scrollYForFixedPosition): Ditto.
  64466. (WebCore::FrameView::scrollOffsetForFixedPosition): Moved from ScrollView here.
  64467. * page/FrameView.h:
  64468. * platform/ScrollView.cpp: Moved functions to FrameView.
  64469. * platform/ScrollView.h:
  64470. * rendering/RenderLayer.cpp:
  64471. (WebCore::RenderLayer::updateRepaintRectsAfterScroll): Account for the RenderView being transformed.
  64472. (WebCore::RenderLayer::calculateClipRects): Used scrollOffsetForFixedPosition().
  64473. (WebCore::RenderLayer::backgroundClipRect): Ditto.
  64474. 2011-02-17 Kenneth Russell <kbr@google.com>
  64475. Reviewed by James Robinson.
  64476. Add support for GPU accelerated path rendering
  64477. https://bugs.webkit.org/show_bug.cgi?id=44729
  64478. Incorporates the Loop and Blinn path rendering algorithm as an
  64479. option to the GPU-accelerated canvas code, currently only compiled
  64480. in to the Chromium port. Currently it's toggled by changing a
  64481. hardcoded constant in
  64482. SharedGraphicsContext3D::useLoopBlinnForPathRendering() and is
  64483. disabled by default. This mechanism can be improved once we've
  64484. gained more confidence in the implementation. There are some known
  64485. bugs that need to be fixed first.
  64486. No new tests; ran some 2D Canvas tests manually with the new flag
  64487. both enabled and disabled.
  64488. * WebCore.gypi:
  64489. * platform/graphics/chromium/GLES2Canvas.cpp:
  64490. (WebCore::GLES2Canvas::GLES2Canvas):
  64491. (WebCore::GLES2Canvas::fillPath):
  64492. * platform/graphics/chromium/GLES2Canvas.h:
  64493. * platform/graphics/gpu/LoopBlinnClassifier.h:
  64494. * platform/graphics/gpu/LoopBlinnLocalTriangulator.h:
  64495. * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  64496. (WebCore::SharedGraphicsContext3D::create):
  64497. (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  64498. (WebCore::SharedGraphicsContext3D::createBuffer):
  64499. (WebCore::SharedGraphicsContext3D::bindBuffer):
  64500. (WebCore::SharedGraphicsContext3D::bufferData):
  64501. (WebCore::SharedGraphicsContext3D::bufferSubData):
  64502. (WebCore::SharedGraphicsContext3D::useLoopBlinnForPathRendering):
  64503. (WebCore::SharedGraphicsContext3D::useLoopBlinnInteriorProgram):
  64504. (WebCore::SharedGraphicsContext3D::useLoopBlinnExteriorProgram):
  64505. * platform/graphics/gpu/SharedGraphicsContext3D.h:
  64506. * platform/graphics/skia/GraphicsContextSkia.cpp:
  64507. (WebCore::GraphicsContext::fillPath):
  64508. 2011-02-16 Stephen White <senorblanco@chromium.org>
  64509. Reviewed by James Robinson.
  64510. Layout Test fast/canvas/setWidthResetAfterForcedRender.html fails on
  64511. accelerated 2D canvas w/compositor enabled.
  64512. https://bugs.webkit.org/show_bug.cgi?id=54561
  64513. When resetting the CanvasRenderingContext2D, we also need to send a
  64514. contentChanged() to the relevant RenderLayer. This is similar to what
  64515. is done in didDraw().
  64516. Covered by fast/canvas/setWidthResetAfterForcedRender.html, but note
  64517. that this test will still fail pixel tests because the compositor
  64518. is not compatible with repaint tests (the green square is now white,
  64519. but the half-transparent grey repaint rect does not appear).
  64520. * html/canvas/CanvasRenderingContext2D.cpp:
  64521. (WebCore::CanvasRenderingContext2D::reset):
  64522. 2011-02-17 Sergey Glazunov <serg.glazunov@gmail.com>
  64523. Reviewed by Kenneth Russell.
  64524. Null out the WEBKIT_lose_context WebGL extension's context pointer when
  64525. the WebGL rendering context is removed.
  64526. https://bugs.webkit.org/show_bug.cgi?id=54679
  64527. Test: fast/canvas/webgl/context-destroyed-crash.html
  64528. * html/canvas/WebGLRenderingContext.cpp:
  64529. (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  64530. * html/canvas/WebKitLoseContext.cpp:
  64531. (WebCore::WebKitLoseContext::loseContext): Add null-check for m_context.
  64532. * html/canvas/WebKitLoseContext.h:
  64533. (WebCore::WebKitLoseContext::contextDestroyed):
  64534. 2011-02-17 Kenneth Russell <kbr@google.com>
  64535. Reviewed by Chris Marrin.
  64536. Construction of Uint8Array from JS Array (and possibly others) incorrectly clamps values
  64537. https://bugs.webkit.org/show_bug.cgi?id=52768
  64538. Removed incorrect clamping code from IntegralTypedArrayBase. Fixed
  64539. code which casts from incoming double to the destination type.
  64540. Changed the JSC bindings to use this code, rather than a copy of
  64541. the casting code and a different constructor, in order to reuse
  64542. the fix.
  64543. * bindings/js/JSArrayBufferViewHelper.h:
  64544. (WebCore::constructArrayBufferView):
  64545. * html/canvas/Int32Array.h:
  64546. (WebCore::Int32Array::set):
  64547. * html/canvas/Int8Array.h:
  64548. (WebCore::Int8Array::set):
  64549. * html/canvas/IntegralTypedArrayBase.h:
  64550. (WebCore::IntegralTypedArrayBase::set):
  64551. * html/canvas/Uint16Array.h:
  64552. (WebCore::Uint16Array::set):
  64553. * html/canvas/Uint32Array.h:
  64554. (WebCore::Uint32Array::set):
  64555. * html/canvas/Uint8Array.h:
  64556. (WebCore::Uint8Array::set):
  64557. 2011-02-17 Sam Weinig <sam@webkit.org>
  64558. Reviewed by Dan Bernstein.
  64559. Knob proportion not quite right during rubber-band.
  64560. <rdar://problem/9015201>
  64561. Change knob proportion algorithm to treat overhang as making the view smaller,
  64562. rather than document bigger.
  64563. * platform/mac/ScrollbarThemeMac.mm:
  64564. (WebCore::ScrollbarThemeMac::paint):
  64565. 2011-02-16 Luiz Agostini <luiz.agostini@openbossa.org>
  64566. Reviewed by Andreas Kling.
  64567. Summary: HTML5 <details> and <summary>: HTMLSummaryElement
  64568. https://bugs.webkit.org/show_bug.cgi?id=54584
  64569. Adding class HTMLSummaryElement to build systems. This class will be used in
  64570. the implementation of new HTML5 tag <summary>.
  64571. * CMakeLists.txt:
  64572. * GNUmakefile.am:
  64573. * WebCore.gypi:
  64574. * WebCore.pro:
  64575. * WebCore.vcproj/WebCore.vcproj:
  64576. * WebCore.xcodeproj/project.pbxproj:
  64577. * html/HTMLElementsAllInOne.cpp:
  64578. * html/HTMLSummaryElement.cpp: Added.
  64579. (WebCore::HTMLSummaryElement::create):
  64580. (WebCore::HTMLSummaryElement::HTMLSummaryElement):
  64581. * html/HTMLSummaryElement.h: Added.
  64582. * html/HTMLTagNames.in:
  64583. 2011-02-17 Jeremy Orlow <jorlow@chromium.org>
  64584. Reviewed by Nate Chapin.
  64585. Throwing in an IndexedDB error or success event should lead to the transaction aborting
  64586. https://bugs.webkit.org/show_bug.cgi?id=54249
  64587. When an exception is thrown but not handled within an IDBRequests success/error event,
  64588. we should abort the transaction.
  64589. Test: storage/indexeddb/exception-in-event-aborts.html
  64590. * bindings/js/JSEventListener.cpp:
  64591. (WebCore::JSEventListener::handleEvent):
  64592. * bindings/js/JSEventTarget.cpp:
  64593. (WebCore::toJS):
  64594. * bindings/v8/V8AbstractEventListener.cpp:
  64595. (WebCore::V8AbstractEventListener::invokeEventHandler):
  64596. * dom/EventTarget.cpp:
  64597. (WebCore::EventTarget::uncaughtExceptionInEventHandler):
  64598. * dom/EventTarget.h:
  64599. * storage/IDBRequest.cpp:
  64600. (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
  64601. * storage/IDBRequest.h:
  64602. 2011-02-17 Sam Weinig <sam@webkit.org>
  64603. Reviewed by Maciej Stachowiak.
  64604. WebKit2: Support Dictionary popup
  64605. <rdar://problem/7660670>
  64606. Add some necessary exports.
  64607. * WebCore.exp.in:
  64608. 2011-02-17 W. James MacLean <wjmaclean@chromium.org>
  64609. Reviewed by James Robinson.
  64610. [chromium] Add command-line flag to enable composite to offscreen texture.
  64611. https://bugs.webkit.org/show_bug.cgi?id=52311
  64612. Add plumbing to allow command-line switch to enable offscreen compositing. Function
  64613. LayerRendererChromium::copyOffscreenTextureToDisplay used for now to mimic
  64614. normal renderer operation.
  64615. Existing functionality not changed; offscreen compositing will be tested via GPU test framework.
  64616. * platform/graphics/chromium/LayerRendererChromium.cpp:
  64617. (WebCore::LayerRendererChromium::setRootLayer):
  64618. (WebCore::LayerRendererChromium::setCompositeOffscreen):
  64619. (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
  64620. (WebCore::LayerRendererChromium::useRenderSurface):
  64621. (WebCore::LayerRendererChromium::setScissorToRect):
  64622. * platform/graphics/chromium/LayerRendererChromium.h:
  64623. (WebCore::LayerRendererChromium::isCompositingOffscreen):
  64624. 2011-02-17 Kevin Ollivier <kevino@theolliviers.com>
  64625. [wx] Build fixes after recent changes.
  64626. * dom/ScriptedAnimationController.h:
  64627. * platform/graphics/wx/FontWx.cpp:
  64628. (WebCore::Font::drawComplexText):
  64629. * platform/graphics/wx/GraphicsContextWx.cpp:
  64630. (WebCore::GraphicsContext::drawLineForText):
  64631. (WebCore::GraphicsContext::drawLineForTextChecking):
  64632. * platform/wx/WidgetWx.cpp:
  64633. (WebCore::Widget::setFrameRect):
  64634. 2011-02-16 Brian Weinstein <bweinstein@apple.com>
  64635. Reviewed by Brady Eidson.
  64636. WebKit2: Need a way to manage the WebCore Cache
  64637. https://bugs.webkit.org/show_bug.cgi?id=54501
  64638. Add a way to get a set of all of the origins that have entries in the
  64639. WebCore memory cache, and a method to remove all resources from the memory
  64640. cache from a given security origin.
  64641. No change in behavior.
  64642. * WebCore.exp.in: Add functions that need to be exported.
  64643. * loader/cache/MemoryCache.cpp:
  64644. (WebCore::MemoryCache::removeResourcesWithOrigin):
  64645. (WebCore::MemoryCache::getOriginsWithCache):
  64646. * loader/cache/MemoryCache.h:
  64647. 2011-02-16 David Hyatt <hyatt@apple.com>
  64648. Reviewed by Dan Bernstein.
  64649. https://bugs.webkit.org/show_bug.cgi?id=54244
  64650. Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
  64651. hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
  64652. The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
  64653. been changed as well.
  64654. In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
  64655. Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
  64656. Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
  64657. still have a precise floating point position.
  64658. Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
  64659. be rounding justification spacing in their font code.
  64660. Many layout test results change on Mac, since rounding hacks were used there and are now gone.
  64661. * WebCore.exp.in:
  64662. * html/canvas/CanvasRenderingContext2D.cpp:
  64663. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  64664. * platform/chromium/FileChooserChromium.cpp:
  64665. (WebCore::FileChooser::basenameForWidth):
  64666. * platform/graphics/Font.cpp:
  64667. (WebCore::Font::width):
  64668. * platform/graphics/Font.h:
  64669. (WebCore::Font::spaceWidth):
  64670. (WebCore::Font::tabWidth):
  64671. * platform/graphics/FontFastPath.cpp:
  64672. (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
  64673. * platform/graphics/GraphicsContext.cpp:
  64674. (WebCore::GraphicsContext::drawText):
  64675. (WebCore::GraphicsContext::drawEmphasisMarks):
  64676. (WebCore::GraphicsContext::drawBidiText):
  64677. (WebCore::GraphicsContext::drawHighlightForText):
  64678. * platform/graphics/GraphicsContext.h:
  64679. * platform/graphics/SimpleFontData.cpp:
  64680. (WebCore::SimpleFontData::SimpleFontData):
  64681. (WebCore::SimpleFontData::platformGlyphInit):
  64682. * platform/graphics/SimpleFontData.h:
  64683. (WebCore::SimpleFontData::spaceWidth):
  64684. * platform/graphics/StringTruncator.cpp:
  64685. (WebCore::stringWidth):
  64686. (WebCore::truncateString):
  64687. (WebCore::StringTruncator::centerTruncate):
  64688. (WebCore::StringTruncator::rightTruncate):
  64689. (WebCore::StringTruncator::width):
  64690. * platform/graphics/StringTruncator.h:
  64691. * platform/graphics/TextRun.h:
  64692. (WebCore::TextRun::TextRun):
  64693. (WebCore::TextRun::xPos):
  64694. (WebCore::TextRun::expansion):
  64695. (WebCore::TextRun::directionalOverride):
  64696. (WebCore::TextRun::disableSpacing):
  64697. * platform/graphics/WidthIterator.cpp:
  64698. (WebCore::WidthIterator::WidthIterator):
  64699. (WebCore::WidthIterator::advance):
  64700. * platform/graphics/WidthIterator.h:
  64701. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  64702. (WebCore::GraphicsContext::drawLineForText):
  64703. (WebCore::GraphicsContext::drawLineForTextChecking):
  64704. * platform/graphics/cg/GraphicsContextCG.cpp:
  64705. (WebCore::GraphicsContext::drawLineForText):
  64706. * platform/graphics/mac/ComplexTextController.cpp:
  64707. (WebCore::ComplexTextController::ComplexTextController):
  64708. (WebCore::ComplexTextController::advance):
  64709. (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
  64710. * platform/graphics/mac/ComplexTextController.h:
  64711. * platform/graphics/mac/FontComplexTextMac.cpp:
  64712. (WebCore::Font::getGlyphsAndAdvancesForComplexText):
  64713. * platform/graphics/mac/GraphicsContextMac.mm:
  64714. (WebCore::GraphicsContext::drawLineForTextChecking):
  64715. * platform/graphics/qt/GraphicsContextQt.cpp:
  64716. (WebCore::GraphicsContext::drawLineForText):
  64717. (WebCore::GraphicsContext::drawLineForTextChecking):
  64718. * platform/graphics/qt/SimpleFontDataQt.cpp:
  64719. (WebCore::SimpleFontData::platformGlyphInit):
  64720. * platform/graphics/skia/GraphicsContextSkia.cpp:
  64721. (WebCore::GraphicsContext::drawLineForTextChecking):
  64722. (WebCore::GraphicsContext::drawLineForText):
  64723. * platform/graphics/win/GraphicsContextCGWin.cpp:
  64724. (WebCore::GraphicsContext::drawLineForTextChecking):
  64725. * platform/graphics/win/UniscribeController.cpp:
  64726. (WebCore::UniscribeController::shapeAndPlaceItem):
  64727. * platform/gtk/FileChooserGtk.cpp:
  64728. (WebCore::FileChooser::basenameForWidth):
  64729. * platform/mac/DragImageMac.mm:
  64730. (WebCore::widthWithFont):
  64731. (WebCore::drawAtPoint):
  64732. * platform/mac/FileChooserMac.mm:
  64733. (WebCore::FileChooser::basenameForWidth):
  64734. * platform/win/DragImageWin.cpp:
  64735. (WebCore::createDragImageForLink):
  64736. * platform/win/FileChooserWin.cpp:
  64737. (WebCore::FileChooser::basenameForWidth):
  64738. * platform/win/PopupMenuWin.cpp:
  64739. (WebCore::PopupMenuWin::calculatePositionAndSize):
  64740. * platform/win/WebCoreTextRenderer.cpp:
  64741. (WebCore::WebCoreTextFloatWidth):
  64742. * rendering/HitTestResult.cpp:
  64743. (WebCore::HitTestResult::addNodeToRectBasedTestResult):
  64744. * rendering/HitTestResult.h:
  64745. * rendering/InlineBox.cpp:
  64746. (WebCore::InlineBox::adjustPosition):
  64747. (WebCore::InlineBox::placeEllipsisBox):
  64748. (WebCore::InlineBox::locationIncludingFlipping):
  64749. (WebCore::InlineBox::flipForWritingMode):
  64750. * rendering/InlineBox.h:
  64751. (WebCore::InlineBox::InlineBox):
  64752. (WebCore::InlineBox::adjustLineDirectionPosition):
  64753. (WebCore::InlineBox::adjustBlockDirectionPosition):
  64754. (WebCore::InlineBox::setX):
  64755. (WebCore::InlineBox::x):
  64756. (WebCore::InlineBox::setY):
  64757. (WebCore::InlineBox::y):
  64758. (WebCore::InlineBox::width):
  64759. (WebCore::InlineBox::height):
  64760. (WebCore::InlineBox::logicalLeft):
  64761. (WebCore::InlineBox::logicalRight):
  64762. (WebCore::InlineBox::setLogicalLeft):
  64763. (WebCore::InlineBox::pixelSnappedLogicalLeft):
  64764. (WebCore::InlineBox::pixelSnappedLogicalRight):
  64765. (WebCore::InlineBox::setLogicalWidth):
  64766. (WebCore::InlineBox::logicalWidth):
  64767. (WebCore::InlineBox::verticalAlign):
  64768. * rendering/InlineFlowBox.cpp:
  64769. (WebCore::InlineFlowBox::roundedFrameRect):
  64770. (WebCore::InlineFlowBox::adjustPosition):
  64771. (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
  64772. (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
  64773. (WebCore::verticalPositionForBox):
  64774. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  64775. (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  64776. (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
  64777. (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
  64778. (WebCore::InlineFlowBox::computeOverflow):
  64779. (WebCore::InlineFlowBox::setLayoutOverflow):
  64780. (WebCore::InlineFlowBox::setVisualOverflow):
  64781. (WebCore::InlineFlowBox::nodeAtPoint):
  64782. (WebCore::InlineFlowBox::paintBoxDecorations):
  64783. (WebCore::InlineFlowBox::paintMask):
  64784. (WebCore::InlineFlowBox::placeEllipsisBox):
  64785. * rendering/InlineFlowBox.h:
  64786. (WebCore::InlineFlowBox::maxYLayoutOverflow):
  64787. (WebCore::InlineFlowBox::maxXLayoutOverflow):
  64788. (WebCore::InlineFlowBox::layoutOverflowRect):
  64789. (WebCore::InlineFlowBox::maxYVisualOverflow):
  64790. (WebCore::InlineFlowBox::maxXVisualOverflow):
  64791. (WebCore::InlineFlowBox::visualOverflowRect):
  64792. * rendering/InlineTextBox.cpp:
  64793. (WebCore::InlineTextBox::placeEllipsisBox):
  64794. (WebCore::InlineTextBox::nodeAtPoint):
  64795. (WebCore::paintTextWithShadows):
  64796. (WebCore::InlineTextBox::paint):
  64797. (WebCore::InlineTextBox::paintSelection):
  64798. (WebCore::InlineTextBox::paintCompositionBackground):
  64799. (WebCore::InlineTextBox::paintDecoration):
  64800. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  64801. (WebCore::InlineTextBox::paintTextMatchMarker):
  64802. (WebCore::InlineTextBox::paintDocumentMarkers):
  64803. (WebCore::InlineTextBox::paintCompositionUnderline):
  64804. (WebCore::InlineTextBox::textPos):
  64805. (WebCore::InlineTextBox::offsetForPosition):
  64806. (WebCore::InlineTextBox::positionForOffset):
  64807. * rendering/InlineTextBox.h:
  64808. (WebCore::InlineTextBox::setExpansion):
  64809. * rendering/RenderBR.h:
  64810. (WebCore::RenderBR::width):
  64811. * rendering/RenderBlock.cpp:
  64812. (WebCore::stripTrailingSpace):
  64813. (WebCore::updatePreferredWidth):
  64814. (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
  64815. (WebCore::RenderBlock::adjustForBorderFit):
  64816. (WebCore::RenderBlock::addFocusRingRects):
  64817. * rendering/RenderBlock.h:
  64818. * rendering/RenderBlockLineLayout.cpp:
  64819. (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
  64820. (WebCore::RenderBlock::fitBelowFloats):
  64821. (WebCore::textWidth):
  64822. (WebCore::tryHyphenating):
  64823. (WebCore::RenderBlock::findNextLineBreak):
  64824. * rendering/RenderBox.cpp:
  64825. (WebCore::RenderBox::positionLineBox):
  64826. (WebCore::RenderBox::flipForWritingMode):
  64827. * rendering/RenderBox.h:
  64828. * rendering/RenderCombineText.cpp:
  64829. (WebCore::RenderCombineText::width):
  64830. (WebCore::RenderCombineText::adjustTextOrigin):
  64831. (WebCore::RenderCombineText::combineText):
  64832. * rendering/RenderCombineText.h:
  64833. (WebCore::RenderCombineText::combinedTextWidth):
  64834. * rendering/RenderCounter.cpp:
  64835. (WebCore::RenderCounter::computePreferredLogicalWidths):
  64836. * rendering/RenderCounter.h:
  64837. * rendering/RenderEmbeddedObject.cpp:
  64838. (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  64839. * rendering/RenderFileUploadControl.cpp:
  64840. (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  64841. * rendering/RenderImage.cpp:
  64842. * rendering/RenderInline.cpp:
  64843. (WebCore::RenderInline::linesBoundingBox):
  64844. (WebCore::RenderInline::linesVisualOverflowBoundingBox):
  64845. (WebCore::RenderInline::addFocusRingRects):
  64846. (WebCore::RenderInline::paintOutline):
  64847. * rendering/RenderListBox.cpp:
  64848. (WebCore::RenderListBox::updateFromElement):
  64849. (WebCore::RenderListBox::paintItemForeground):
  64850. * rendering/RenderMenuList.cpp:
  64851. (WebCore::RenderMenuList::updateOptionsWidth):
  64852. * rendering/RenderText.cpp:
  64853. (WebCore::RenderText::localCaretRect):
  64854. (WebCore::RenderText::widthFromCache):
  64855. (WebCore::RenderText::trimmedPrefWidths):
  64856. (WebCore::RenderText::minLogicalWidth):
  64857. (WebCore::RenderText::maxLogicalWidth):
  64858. (WebCore::RenderText::computePreferredLogicalWidths):
  64859. (WebCore::RenderText::firstRunOrigin):
  64860. (WebCore::RenderText::firstRunX):
  64861. (WebCore::RenderText::firstRunY):
  64862. (WebCore::RenderText::width):
  64863. (WebCore::RenderText::linesBoundingBox):
  64864. * rendering/RenderText.h:
  64865. * rendering/RenderTextControl.cpp:
  64866. (WebCore::RenderTextControl::getAvgCharWidth):
  64867. (WebCore::RenderTextControl::paintPlaceholder):
  64868. * rendering/RenderTreeAsText.cpp:
  64869. (WebCore::writeTextRun):
  64870. * rendering/RootInlineBox.cpp:
  64871. (WebCore::RootInlineBox::placeEllipsis):
  64872. (WebCore::RootInlineBox::placeEllipsisBox):
  64873. (WebCore::RootInlineBox::adjustPosition):
  64874. (WebCore::RootInlineBox::beforeAnnotationsAdjustment):
  64875. (WebCore::RootInlineBox::paddedLayoutOverflowRect):
  64876. * rendering/RootInlineBox.h:
  64877. * rendering/VerticalPositionCache.h:
  64878. * rendering/svg/SVGInlineTextBox.cpp:
  64879. (WebCore::SVGInlineTextBox::offsetForPosition):
  64880. (WebCore::SVGInlineTextBox::positionForOffset):
  64881. (WebCore::SVGInlineTextBox::constructTextRun):
  64882. * rendering/svg/SVGInlineTextBox.h:
  64883. * rendering/svg/SVGRenderTreeAsText.cpp:
  64884. (WebCore::writeRenderSVGTextBox):
  64885. * rendering/svg/SVGTextMetrics.cpp:
  64886. (WebCore::SVGTextMetrics::SVGTextMetrics):
  64887. (WebCore::constructTextRun):
  64888. * svg/SVGFont.cpp:
  64889. (WebCore::floatWidthMissingGlyphCallback):
  64890. (WebCore::Font::drawTextUsingSVGFont):
  64891. 2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
  64892. Reviewed by Dirk Schulze.
  64893. 'ex' coordinates fail, when SVGFont doesn't provide an explicit xHeight attribute
  64894. https://bugs.webkit.org/show_bug.cgi?id=54672
  64895. Measure the xHeight from the 'x' glyph of a SVGFont, if the font itself doesn't explicitely specify an x-height attribute.
  64896. Fixes the modern version of SVG 1.1 2nd Edition coords-units-03-b.svg.
  64897. Test: svg/W3C-SVG-1.1-SE/coords-units-03-b.svg
  64898. * platform/graphics/SimpleFontData.cpp:
  64899. (WebCore::SimpleFontData::SimpleFontData):
  64900. 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
  64901. Reviewed by Adam Roben.
  64902. HTML5 <details> and <summary>: localized text
  64903. https://bugs.webkit.org/show_bug.cgi?id=54260
  64904. The method defaultDetailsSummaryText was added to LocalizationStrategy class and to
  64905. platform/LocalizedStrings. It is used to provide the default label to be used by a
  64906. <details> tag that has no <summary> child.
  64907. * platform/LocalizationStrategy.h:
  64908. * platform/LocalizedStrings.cpp:
  64909. (WebCore::fileButtonNoFileSelectedLabel):
  64910. (WebCore::defaultDetailsSummaryText):
  64911. * platform/LocalizedStrings.h:
  64912. * platform/android/LocalizedStringsAndroid.cpp:
  64913. (WebCore::defaultDetailsSummaryText):
  64914. * platform/brew/LocalizedStringsBrew.cpp:
  64915. (WebCore::defaultDetailsSummaryText):
  64916. * platform/efl/LocalizedStringsEfl.cpp:
  64917. (WebCore::defaultDetailsSummaryText):
  64918. * platform/gtk/LocalizedStringsGtk.cpp:
  64919. (WebCore::defaultDetailsSummaryText):
  64920. * platform/haiku/LocalizedStringsHaiku.cpp:
  64921. (WebCore::defaultDetailsSummaryText):
  64922. * platform/wx/LocalizedStringsWx.cpp:
  64923. (WebCore::defaultDetailsSummaryText):
  64924. 2011-02-17 Kristian Amlie <kristian.amlie@nokia.com>
  64925. Reviewed by Laszlo Gombos.
  64926. Updated include paths for phonon.
  64927. [Qt] WebKit patches required to work with a modularized version of Qt
  64928. https://bugs.webkit.org/show_bug.cgi?id=53916
  64929. Build fix. No tests.
  64930. * WebCore.pro:
  64931. 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
  64932. Reviewed by Laszlo Gombos.
  64933. The URL of HTML5 Video Element is percent encoded at websites such as youtube.
  64934. It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
  64935. the HTTP GET request for the video to be rejected by the service provider.
  64936. https://bugs.webkit.org/show_bug.cgi?id=53973.
  64937. The bug is fixed by constructing QUrl from the encoded URL.
  64938. New test function tst_QWebPage::loadHtml5Video() is added in
  64939. Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
  64940. * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  64941. (WebCore::MediaPlayerPrivateQt::commitLoad):
  64942. 2011-02-17 Andreas Kling <kling@webkit.org>
  64943. Reviewed by Antti Koivisto.
  64944. [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
  64945. https://bugs.webkit.org/show_bug.cgi?id=49216
  64946. CachedResourceRequest::didFail() will protect the CachedResourceLoader's
  64947. document() while it runs, but if we're being called from the Document destructor,
  64948. the protecting RefPtr<Document> will cause a double-delete instead.
  64949. * loader/cache/CachedResourceLoader.cpp:
  64950. (WebCore::CachedResourceLoader::~CachedResourceLoader): Clear the m_document
  64951. pointer so CachedResourceRequest::didFail() won't try to protect it.
  64952. (WebCore::CachedResourceLoader::frame): Add null-check for m_document.
  64953. 2011-02-17 Andrey Adaikin <aandrey@google.com>
  64954. Reviewed by Pavel Feldman.
  64955. Web Inspector: [Text editor] Add updateHighlight method to the highlighter
  64956. https://bugs.webkit.org/show_bug.cgi?id=54448
  64957. * inspector/front-end/SourceTokenizer.js:
  64958. * inspector/front-end/TextEditorHighlighter.js:
  64959. (WebInspector.TextEditorHighlighter.prototype.set mimeType):
  64960. (WebInspector.TextEditorHighlighter.prototype.reset):
  64961. (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
  64962. (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
  64963. (WebInspector.TextEditorHighlighter.prototype._highlightLines):
  64964. 2011-02-16 Pavel Podivilov <podivilov@chromium.org>
  64965. Reviewed by Yury Semikhatsky.
  64966. Web Inspector: show all inlined scripts from single document in the same source frame.
  64967. https://bugs.webkit.org/show_bug.cgi?id=54544
  64968. Currently when debugging synchronously executed inlined scripts each script is shown in it's own source frame ("example.html:24").
  64969. We should show such scripts in the same source frame "example.html" with <script></script> framing.
  64970. Test: inspector/debugger/debug-inlined-scripts.html
  64971. * inspector/front-end/ScriptsPanel.js:
  64972. (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  64973. (WebInspector.ScriptsPanel.prototype._addScript):
  64974. (WebInspector.ScriptsPanel.prototype._resourceForURL):
  64975. (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
  64976. (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
  64977. (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
  64978. (WebInspector.ScriptsPanel.prototype.reset):
  64979. (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
  64980. (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
  64981. (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
  64982. (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  64983. (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare):
  64984. (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  64985. (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
  64986. (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
  64987. 2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
  64988. Reviewed by Dirk Schulze.
  64989. svg/batik/paints/patternRegions-positioned-objects.svg fails on Windows
  64990. https://bugs.webkit.org/show_bug.cgi?id=44484
  64991. Pattern of pattern defined with objectBoundingBox does not render correctly
  64992. https://bugs.webkit.org/show_bug.cgi?id=53463
  64993. Fix <pattern> + patternContentUnits="objectBoundingBox" support.
  64994. We were incorrrectly translating the tile image transform, by the target objects bbox.x()/y().
  64995. RenderSVGResourceMask/Clipper don't have this error.
  64996. Fix nesting <patterns> in objectBoundingBox mode, propagate the tileImageTransform as new user-space
  64997. when drawing the pattern children. <mask> + <clipPath> don't have the problem.
  64998. Test: svg/custom/nested-pattern-boundingBoxModeContent.svg
  64999. * rendering/svg/RenderSVGResourcePattern.cpp:
  65000. (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
  65001. (WebCore::RenderSVGResourcePattern::createTileImage):
  65002. 2011-02-17 Csaba Osztrogonác <ossy@webkit.org>
  65003. Unreviewed.
  65004. [Qt][V8] Buildfix after r78752.
  65005. * CodeGenerators.pri: Add missing IDL files.
  65006. 2011-02-17 Benjamin Kalman <kalman@chromium.org>
  65007. Reviewed by Ryosuke Niwa.
  65008. RTL lineboundary left/right is reversed when cursor is at start of RTL container
  65009. https://bugs.webkit.org/show_bug.cgi?id=54534
  65010. Test: editing/selection/extend-left-right-by-lineboundary.html
  65011. Add missing cases for extending left/right by lineboundary.
  65012. * editing/SelectionController.cpp:
  65013. (WebCore::SelectionController::modifyExtendingRight):
  65014. (WebCore::SelectionController::modifyExtendingLeft):
  65015. 2011-02-16 Philippe Normand <pnormand@igalia.com>
  65016. Reviewed by Martin Robinson.
  65017. [GTK] libsoup critical warnings
  65018. https://bugs.webkit.org/show_bug.cgi?id=54557
  65019. Avoid pausing a soup message for already downloaded resources.
  65020. * platform/network/soup/ResourceHandleSoup.cpp:
  65021. (WebCore::ResourceHandle::platformSetDefersLoading):
  65022. 2011-02-16 Brian Ryner <bryner@chromium.org>
  65023. Reviewed by Darin Fisher.
  65024. Split the socket address field into separate IP address and port fields.
  65025. This will make the field less error-prone to parse, for example when
  65026. dealing with IPv6 literals.
  65027. https://bugs.webkit.org/show_bug.cgi?id=54607
  65028. No new tests required.
  65029. * platform/network/chromium/ResourceResponse.cpp:
  65030. (WebCore::ResourceResponse::doPlatformCopyData):
  65031. (WebCore::ResourceResponse::doPlatformAdopt):
  65032. * platform/network/chromium/ResourceResponse.h:
  65033. (WebCore::ResourceResponse::ResourceResponse):
  65034. (WebCore::ResourceResponse::remoteIPAddress):
  65035. (WebCore::ResourceResponse::setRemoteIPAddress):
  65036. (WebCore::ResourceResponse::remotePort):
  65037. (WebCore::ResourceResponse::setRemotePort):
  65038. 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
  65039. Reviewed by Chris Fleizach.
  65040. Add support for canvas fallback content.
  65041. https://bugs.webkit.org/show_bug.cgi?id=50126
  65042. Test: accessibility/canvas-fallback-content.html
  65043. * accessibility/AccessibilityObject.h:
  65044. * accessibility/AccessibilityRenderObject.cpp:
  65045. (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  65046. (WebCore::AccessibilityRenderObject::canHaveChildren):
  65047. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  65048. (atkRole):
  65049. * accessibility/mac/AccessibilityObjectWrapper.mm:
  65050. * html/HTMLFormControlElement.cpp:
  65051. (WebCore::HTMLFormControlElement::isFocusable):
  65052. * rendering/RenderHTMLCanvas.cpp:
  65053. (WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout):
  65054. (WebCore::RenderHTMLCanvas::layout):
  65055. (WebCore::RenderHTMLCanvas::nodeAtPoint):
  65056. * rendering/RenderHTMLCanvas.h:
  65057. (WebCore::RenderHTMLCanvas::children):
  65058. (WebCore::RenderHTMLCanvas::canHaveChildren):
  65059. (WebCore::RenderHTMLCanvas::virtualChildren):
  65060. * rendering/RenderObject.cpp:
  65061. (WebCore::RenderObject::repaint):
  65062. * rendering/RenderTreeAsText.cpp:
  65063. (WebCore::write):
  65064. 2011-02-16 Matthew Delaney <mdelaney@apple.com>
  65065. Reviewed by Simon Fraser.
  65066. Allow acceleratesDrawing for WebKit2
  65067. https://bugs.webkit.org/show_bug.cgi?id=54511
  65068. Plumb through preference for accelerated drawing.
  65069. When accelerated drawing is enabled, set a flag on new GraphicsLayers.
  65070. Not testable via Layout Tests
  65071. * WebCore.exp.in:
  65072. * page/Settings.cpp:
  65073. (WebCore::Settings::Settings):
  65074. (WebCore::Settings::setAcceleratedDrawingEnabled):
  65075. * page/Settings.h:
  65076. (WebCore::Settings::acceleratedDrawingEnabled):
  65077. * rendering/RenderLayerCompositor.cpp:
  65078. (WebCore::RenderLayerCompositor::updateBacking):
  65079. 2011-02-16 Victoria Kirst <vrk@google.com>
  65080. Reviewed by Kenneth Russell.
  65081. [chromium] Fix green pixels at edge of certain GPU-accelerated videos
  65082. https://bugs.webkit.org/show_bug.cgi?id=54559
  65083. Adds logic to properly resize the range of YUV textures to only
  65084. select legitimate values.
  65085. * platform/graphics/chromium/VideoFrameChromium.h:
  65086. * platform/graphics/chromium/VideoLayerChromium.cpp:
  65087. (WebCore::VideoLayerChromium::SharedValues::SharedValues):
  65088. (WebCore::VideoLayerChromium::allocateTexturesIfNeeded):
  65089. (WebCore::VideoLayerChromium::drawYUV):
  65090. * platform/graphics/chromium/VideoLayerChromium.h:
  65091. (WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation):
  65092. (WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):
  65093. 2011-02-16 Bill Budge <bbudge@chromium.org>
  65094. Reviewed by David Levin.
  65095. Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient
  65096. https://bugs.webkit.org/show_bug.cgi?id=54313
  65097. No tests needed, exposes no new functionality
  65098. * fileapi/FileReaderLoader.cpp:
  65099. (WebCore::FileReaderLoader::didFinishLoading):
  65100. * fileapi/FileReaderLoader.h:
  65101. * loader/DocumentThreadableLoader.cpp:
  65102. (WebCore::DocumentThreadableLoader::setDefersLoading):
  65103. (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  65104. (WebCore::DocumentThreadableLoader::didFinishLoading):
  65105. (WebCore::DocumentThreadableLoader::loadRequest):
  65106. * loader/DocumentThreadableLoader.h:
  65107. * loader/ThreadableLoaderClient.h:
  65108. (WebCore::ThreadableLoaderClient::didReceiveData):
  65109. (WebCore::ThreadableLoaderClient::didReceiveCachedMetadata):
  65110. (WebCore::ThreadableLoaderClient::didFinishLoading):
  65111. * loader/ThreadableLoaderClientWrapper.h:
  65112. (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
  65113. (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata):
  65114. (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  65115. * loader/WorkerThreadableLoader.cpp:
  65116. (WebCore::workerContextDidReceiveCachedMetadata):
  65117. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
  65118. (WebCore::workerContextDidFinishLoading):
  65119. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  65120. * loader/WorkerThreadableLoader.h:
  65121. * notifications/Notification.cpp:
  65122. (WebCore::Notification::didFinishLoading):
  65123. * notifications/Notification.h:
  65124. * page/EventSource.cpp:
  65125. (WebCore::EventSource::didFinishLoading):
  65126. * page/EventSource.h:
  65127. * workers/WorkerScriptLoader.cpp:
  65128. (WebCore::WorkerScriptLoader::didFinishLoading):
  65129. * workers/WorkerScriptLoader.h:
  65130. * xml/XMLHttpRequest.cpp:
  65131. (WebCore::XMLHttpRequest::didFinishLoading):
  65132. * xml/XMLHttpRequest.h:
  65133. 2011-02-16 Jeremy Orlow <jorlow@chromium.org>
  65134. Fix uninitialized memory error.
  65135. * storage/IDBDatabaseBackendImpl.cpp:
  65136. (WebCore::IDBDatabaseBackendImpl::close):
  65137. 2011-02-16 Adam Barth <abarth@webkit.org>
  65138. Reviewed by Eric Seidel.
  65139. Fix xssAuditor/form-action.html
  65140. https://bugs.webkit.org/show_bug.cgi?id=54590
  65141. We should block form actions. Although this technically can't be used
  65142. to run script, it's a pretty easy vector for stealing passwords.
  65143. * html/parser/XSSFilter.cpp:
  65144. (WebCore::XSSFilter::filterTokenInitial):
  65145. (WebCore::XSSFilter::filterFormToken):
  65146. * html/parser/XSSFilter.h:
  65147. 2011-02-16 Abhishek Arya <inferno@chromium.org>
  65148. Reviewed by James Robinson.
  65149. Remove the early bail added in r75823 since we can run into anonymous
  65150. blocks when traversing the parents chain for clearing floats.
  65151. https://bugs.webkit.org/show_bug.cgi?id=54601
  65152. removeFloatingOrPositionedChildFromBlockLists tries to find the topmost
  65153. parent containing "this" block and then tries to remove it from its floats
  65154. list and mark all descendants blocks for layout. I added a bailout condition
  65155. in r75823 because we thought that if one of the parent render block does not
  65156. contain "this" float, then it is safe to assume that none of the grand parents
  65157. will have it. This is a wrong assumption since anonymous blocks do not have
  65158. float objects and we need to go higher in the chain to find the top most parent
  65159. containing this float. Instead of breaking out of the loop, it is ok to keep
  65160. traversing the chain till we find that parent. Otherwise, we will leave deleted
  65161. floats in the grand parents floats list.
  65162. Test: fast/block/float/floats-not-cleared-from-grand-parents.html
  65163. * rendering/RenderBox.cpp:
  65164. (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
  65165. 2011-02-16 Andreas Kling <kling@webkit.org>
  65166. Reviewed by Ryosuke Niwa.
  65167. Editing styles should not emit #RRGGBBAA colors
  65168. https://bugs.webkit.org/show_bug.cgi?id=54540
  65169. * editing/ApplyStyleCommand.cpp:
  65170. (WebCore::StyleChange::extractTextStyles): Use Color::serialized()
  65171. instead of Color::nameForRenderTreeAsText().
  65172. 2011-02-16 Ryosuke Niwa <rniwa@webkit.org>
  65173. Reviewed by Kent Tamura.
  65174. Improve showTree of Range, Position, and VisiblePosition
  65175. https://bugs.webkit.org/show_bug.cgi?id=54536
  65176. Enhanced showTree of Range, Position, and VisiblePosition.
  65177. * dom/Position.cpp:
  65178. (WebCore::Position::showAnchorTypeAndOffset): Added; dumps "legacy" if the position
  65179. is a legacy position and also dumps anchor type.
  65180. (WebCore::Position::showTreeForThis): Calls showAnchorTypeAndOffset.
  65181. * dom/Position.h:
  65182. * dom/Range.cpp:
  65183. (showTree): No longer calls deprecatedEditingOffset.
  65184. * editing/VisiblePosition.cpp:
  65185. (WebCore::VisiblePosition::debugPosition): No longer included in release build.
  65186. Calls Position::showAnchorTypeAndOffset instead of manually calling deprecatedEditingOffset.
  65187. * editing/VisiblePosition.h:
  65188. * editing/VisibleSelection.cpp:
  65189. (WebCore::VisibleSelection::debugPosition): Ditto.
  65190. (WebCore::VisibleSelection::showTreeForThis): Ditto.
  65191. * editing/VisibleSelection.h:
  65192. * page/EventHandler.cpp:
  65193. 2011-02-16 David Grogan <dgrogan@chromium.org>
  65194. Reviewed by Jeremy Orlow.
  65195. fix compile error introduced in 78752
  65196. https://bugs.webkit.org/show_bug.cgi?id=54604
  65197. * storage/IDBRequest.h:
  65198. 2011-02-16 Jeremy Orlow <jorlow@chromium.org>
  65199. Back out IndexedDB change thats no longer necessary
  65200. https://bugs.webkit.org/show_bug.cgi?id=54603
  65201. Backing out 78645 as it turns out that it's not necessary.
  65202. * storage/IDBFactoryBackendImpl.cpp:
  65203. (WebCore::IDBFactoryBackendImpl::open):
  65204. * storage/IDBFactoryBackendImpl.h:
  65205. * storage/IDBFactoryBackendInterface.h:
  65206. 2011-02-16 Brian Salomon <bsalomon@google.com>
  65207. Reviewed by James Robinson.
  65208. Skia's gpu backed just needs the correct context bound before drawing. It will bind the correct FBO itself and doing so externally confuses it unless resetContext is called.
  65209. No new tests required.
  65210. * platform/graphics/skia/PlatformContextSkia.cpp:
  65211. (WebCore::PlatformContextSkia::syncSoftwareCanvas):
  65212. 2011-02-16 Mike Reed <reed@google.com>
  65213. Reviewed by Kenneth Russell.
  65214. Use non-asserting pack function for decoding images, since webgl may want
  65215. a non-premultiplied version of the image.
  65216. https://bugs.webkit.org/show_bug.cgi?id=54023
  65217. No new tests.
  65218. fast/canvas/webgl/gl-teximage.html
  65219. fast/canvas/webgl/tex-image-with-format-and-type.html
  65220. fast/canvas/webgl/texture-transparent-pixels-initialized.html
  65221. * platform/image-decoders/ImageDecoder.h:
  65222. (WebCore::ImageFrame::setRGBA):
  65223. 2011-02-16 David Grogan <dgrogan@chromium.org>
  65224. Reviewed by Jeremy Orlow.
  65225. indexeddb: make setVersion fire blocked event if other connections are open
  65226. https://bugs.webkit.org/show_bug.cgi?id=53728
  65227. Tests: storage/indexeddb/set_version_blocked.html
  65228. storage/indexeddb/set_version_queue.html
  65229. * WebCore.gypi:
  65230. * bindings/js/JSEventCustom.cpp:
  65231. (WebCore::toJS):
  65232. * bindings/v8/custom/V8EventCustom.cpp:
  65233. (WebCore::toV8):
  65234. * dom/Event.cpp:
  65235. (WebCore::Event::isIDBVersionChangeEvent):
  65236. * dom/Event.h:
  65237. * dom/EventNames.h:
  65238. * dom/EventTarget.cpp:
  65239. (WebCore::EventTarget::toIDBVersionChangeRequest):
  65240. * dom/EventTarget.h:
  65241. * storage/IDBCallbacks.h:
  65242. * storage/IDBDatabase.cpp:
  65243. (WebCore::IDBDatabase::setVersion):
  65244. (WebCore::IDBDatabase::close):
  65245. * storage/IDBDatabase.h:
  65246. * storage/IDBDatabase.idl:
  65247. * storage/IDBDatabaseBackendImpl.cpp:
  65248. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
  65249. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::version):
  65250. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::callbacks):
  65251. (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
  65252. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  65253. (WebCore::IDBDatabaseBackendImpl::setVersion):
  65254. (WebCore::IDBDatabaseBackendImpl::open):
  65255. (WebCore::IDBDatabaseBackendImpl::close):
  65256. * storage/IDBDatabaseBackendImpl.h:
  65257. * storage/IDBDatabaseBackendInterface.h:
  65258. * storage/IDBFactoryBackendImpl.cpp:
  65259. (WebCore::IDBFactoryBackendImpl::open):
  65260. * storage/IDBRequest.cpp:
  65261. (WebCore::IDBRequest::onBlocked):
  65262. (WebCore::IDBRequest::dispatchEvent):
  65263. (WebCore::IDBRequest::source):
  65264. * storage/IDBRequest.h:
  65265. * storage/IDBVersionChangeEvent.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  65266. (WebCore::IDBVersionChangeEvent::create):
  65267. (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
  65268. (WebCore::IDBVersionChangeEvent::~IDBVersionChangeEvent):
  65269. (WebCore::IDBVersionChangeEvent::version):
  65270. * storage/IDBVersionChangeEvent.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  65271. (WebCore::IDBVersionChangeEvent::isIDBVersionChangeEvent):
  65272. * storage/IDBVersionChangeEvent.idl: Added.
  65273. * storage/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  65274. (WebCore::IDBVersionChangeRequest::create):
  65275. (WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):
  65276. (WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest):
  65277. (WebCore::IDBVersionChangeRequest::onBlocked):
  65278. * storage/IDBVersionChangeRequest.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  65279. * storage/IDBVersionChangeRequest.idl: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  65280. 2011-02-16 Robin Cao <robin.cao@torchmobile.com.cn>
  65281. Reviewed by James Robinson.
  65282. PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property
  65283. https://bugs.webkit.org/show_bug.cgi?id=54336
  65284. We need to take fill type of paths into account when drawing them.
  65285. No new tests, covered by svg/W3C-SVG-1.1/masking-path-05-f.svg.
  65286. * platform/graphics/skia/PlatformContextSkia.cpp:
  65287. (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
  65288. 2011-02-16 Eric Seidel <eric@webkit.org>
  65289. Reviewed by Adam Barth.
  65290. REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
  65291. https://bugs.webkit.org/show_bug.cgi?id=53717
  65292. Test: http/tests/local/absolute-url-strip-whitespace.html
  65293. This was theoretically tested already in fast/url, however the
  65294. tests were disabled due to lack of any clean way to test absolute
  65295. url parsing in JavaScript. I added a test which mimics the sites
  65296. behavior using our local http server. There seems to be no other
  65297. way to test this at the moment.
  65298. * platform/KURL.cpp:
  65299. (WebCore::shouldTrimFromURL):
  65300. - Any char 0-20 should be removed (matches google-url and other browsers).
  65301. (WebCore::KURL::init):
  65302. 2011-02-16 Abhishek Arya <inferno@chromium.org>
  65303. Reviewed by James Robinson.
  65304. Traverse the next sibling tree to find the text fragment for a first letter.
  65305. https://bugs.webkit.org/show_bug.cgi?id=54568
  65306. We cannot assume that the next sibling to the first letter will a text fragment
  65307. since there can be intermediatary Apple-style-span inline elements wrapping the
  65308. text fragment. So, we traverse the next sibling tree to find it.
  65309. Test: fast/css/first-letter-text-fragment-crash.html
  65310. * rendering/RenderBlock.cpp:
  65311. (WebCore::RenderBlock::updateFirstLetter):
  65312. 2011-02-16 Martin Robinson <mrobinson@igalia.com>
  65313. Reviewed by Xan Lopez.
  65314. [GTK] r78718 introduced some assertion failures in some HTTP tests
  65315. https://bugs.webkit.org/show_bug.cgi?id=54592
  65316. No new tests. This fix is covered by tests that are currently failing.
  65317. * platform/network/soup/ResourceRequestSoup.cpp:
  65318. (WebCore::ResourceRequest::updateFromSoupMessage): Instead of setting the existing
  65319. headers and then selectively removing ones that do not exist in the updated soup
  65320. message, just remove all headers from the map first.
  65321. 2011-02-16 Jian Li <jianli@chromium.org>
  65322. Reviewed by Kenneth Russell.
  65323. [V8] DataView constructor can be applied as a regular method
  65324. https://bugs.webkit.org/show_bug.cgi?id=54563
  65325. Tested by adding a new test case to fast/canvas/webgl/data-view-test.html.
  65326. * bindings/v8/custom/V8DataViewCustom.cpp:
  65327. (WebCore::V8DataView::constructorCallback):
  65328. == Rolled over to ChangeLog-2011-02-16 ==